[webkit-changes] [166565] trunk/Source/WebKit2
Title: [166565] trunk/Source/WebKit2
Revision 166565
Author commit-qu...@webkit.org
Date 2014-03-31 23:01:28 -0700 (Mon, 31 Mar 2014)
Log Message
[EFL][WK2]Implement ewk APIs of web local storage which have deletion functions of the local storage entries
https://bugs.webkit.org/show_bug.cgi?id=130577
Patch by Joonghun Park jh718.p...@samsung.com on 2014-03-31
Reviewed by Gyuyoung Kim.
* UIProcess/API/efl/ewk_storage_manager.cpp:
(ewk_storage_manager_entries_clear):
(ewk_storage_manager_entries_for_origin_del):
* UIProcess/API/efl/ewk_storage_manager.h:
* UIProcess/API/efl/ewk_storage_manager_private.h:
(EwkStorageManager::wkStorageManager):
* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
adding and updating API unittest and fixing memory leak of the existing test case
(EWK2StorageManagerTest::getStorageOriginsCallback):
(EWK2StorageManagerTest::checkOrigin):
(EWK2StorageManagerTest::getOrigin):
(TEST_F):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager_private.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166564 => 166565)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 05:44:38 UTC (rev 166564)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 06:01:28 UTC (rev 166565)
@@ -1,3 +1,23 @@
+2014-03-31 Joonghun Park jh718.p...@samsung.com
+
+[EFL][WK2]Implement ewk APIs of web local storage which have deletion functions of the local storage entries
+https://bugs.webkit.org/show_bug.cgi?id=130577
+
+Reviewed by Gyuyoung Kim.
+
+* UIProcess/API/efl/ewk_storage_manager.cpp:
+(ewk_storage_manager_entries_clear):
+(ewk_storage_manager_entries_for_origin_del):
+* UIProcess/API/efl/ewk_storage_manager.h:
+* UIProcess/API/efl/ewk_storage_manager_private.h:
+(EwkStorageManager::wkStorageManager):
+* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
+adding and updating API unittest and fixing memory leak of the existing test case
+(EWK2StorageManagerTest::getStorageOriginsCallback):
+(EWK2StorageManagerTest::checkOrigin):
+(EWK2StorageManagerTest::getOrigin):
+(TEST_F):
+
2014-03-31 Anders Carlsson ander...@apple.com
Rename policy enums to match the delegate methods
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.cpp (166564 => 166565)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.cpp 2014-04-01 05:44:38 UTC (rev 166564)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.cpp 2014-04-01 06:01:28 UTC (rev 166565)
@@ -28,6 +28,8 @@
#include WKAPICast.h
#include WKArray.h
+#include WKSecurityOrigin.h
+#include WKString.h
#include ewk_security_origin_private.h
#include ewk_storage_manager_private.h
@@ -94,3 +96,22 @@
return true;
}
+
+Eina_Bool ewk_storage_manager_entries_clear(Ewk_Storage_Manager* ewkStorageManager)
+{
+EINA_SAFETY_ON_NULL_RETURN_VAL(ewkStorageManager, false);
+
+WKKeyValueStorageManagerDeleteAllEntries(ewkStorageManager-wkStorageManager().get());
+
+return true;
+}
+
+Eina_Bool ewk_storage_manager_entries_for_origin_del(Ewk_Storage_Manager* ewkStorageManager, Ewk_Security_Origin* origin)
+{
+EINA_SAFETY_ON_NULL_RETURN_VAL(ewkStorageManager, false);
+EWK_OBJ_GET_IMPL_OR_RETURN(EwkSecurityOrigin, origin, impl, false);
+
+WKKeyValueStorageManagerDeleteEntriesForOrigin(ewkStorageManager-wkStorageManager().get(), impl-wkSecurityOrigin());
+
+return true;
+}
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h (166564 => 166565)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h 2014-04-01 05:44:38 UTC (rev 166564)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_storage_manager.h 2014-04-01 06:01:28 UTC (rev 166565)
@@ -33,6 +33,7 @@
#ifndef ewk_storage_manager_h
#define ewk_storage_manager_h
+#include ewk_security_origin.h
#include Eina.h
#ifdef __cplusplus
@@ -80,6 +81,25 @@
*/
EAPI Eina_Bool ewk_storage_manager_origins_async_get(const Ewk_Storage_Manager *manager, Ewk_Storage_Origins_Async_Get_Cb callback, void *user_data);
+/**
+ * Deletes all local storage.
+ *
+ * @param manager Ewk_Storage_Manager object
+ *
+ * @return @c EINA_TRUE on success, @c EINA_FALSE on failure
+ */
+EAPI Eina_Bool ewk_storage_manager_entries_clear(Ewk_Storage_Manager *manager);
+
+/**
+ * Deletes local storage for the specified origin.
+ *
+ * @param manager Ewk_Storage_Manager object
+ * @param origin security origin
+ *
+ * @return @c EINA_TRUE on success, @c EINA_FALSE on failure
+ */
+EAPI Eina_Bool ewk_storage_manager_entries_for_origin_del(Ewk_Storage_Manager *manager, Ewk_Security_Origin *origin);
+
#ifdef __cplusplus
}
#endif
Modified:
[webkit-changes] [166567] trunk/Source/WebKit2
Title: [166567] trunk/Source/WebKit2
Revision 166567
Author zandober...@gmail.com
Date 2014-03-31 23:34:18 -0700 (Mon, 31 Mar 2014)
Log Message
Unreviewed GTK build fix after r166553.
* UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Pass 'WebKit2.' as the second argument to WebPreferences::create().
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166566 => 166567)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 06:09:55 UTC (rev 166566)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 06:34:18 UTC (rev 166567)
@@ -1,3 +1,10 @@
+2014-03-31 Zan Dobersek zdober...@igalia.com
+
+Unreviewed GTK build fix after r166553.
+
+* UIProcess/API/gtk/WebKitSettings.cpp:
+(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Pass 'WebKit2.' as the second argument to WebPreferences::create().
+
2014-03-31 Ryuan Choi ryuan.c...@samsung.com
[EFL][WK2] Extract the control of page background out of color_set
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (166566 => 166567)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2014-04-01 06:09:55 UTC (rev 166566)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp 2014-04-01 06:34:18 UTC (rev 166567)
@@ -42,7 +42,7 @@
struct _WebKitSettingsPrivate {
_WebKitSettingsPrivate()
-: preferences(WebPreferences::create(String()))
+: preferences(WebPreferences::create(String(), WebKit2.))
{
defaultFontFamily = preferences-standardFontFamily().utf8();
monospaceFontFamily = preferences-fixedFontFamily().utf8();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166568] trunk/Source/WebCore
Title: [166568] trunk/Source/WebCore
Revision 166568
Author mrobin...@webkit.org
Date 2014-04-01 00:28:14 -0700 (Tue, 01 Apr 2014)
Log Message
[GTK] Readonly attributes installed as readwrite in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=130978
Reviewed by Carlos Garcia Campos.
Unify how we decide if an attribute is readable or writeable and improve the code.
This results in some attributes now being marked as read-only which didn't have
corresponding case statements in the set_property switch statements and also correctly
installs set_property support for some more POD types.
* bindings/scripts/CodeGeneratorGObject.pm:
(IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
(IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
update the list of types to reflect the full list of types we can generate setters for.
(GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
(GenerateProperties): Use grep and the new helpers to simplify the code.
(GetReadableProperties): Deleted.
(GetWriteableProperties): Deleted.
* bindings/scripts/test/GObject: Update results
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166567 => 166568)
--- trunk/Source/WebCore/ChangeLog 2014-04-01 06:34:18 UTC (rev 166567)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 07:28:14 UTC (rev 166568)
@@ -1,3 +1,26 @@
+2014-04-01 Martin Robinson mrobin...@igalia.com
+
+[GTK] Readonly attributes installed as readwrite in GObject DOM bindings
+https://bugs.webkit.org/show_bug.cgi?id=130978
+
+Reviewed by Carlos Garcia Campos.
+
+Unify how we decide if an attribute is readable or writeable and improve the code.
+This results in some attributes now being marked as read-only which didn't have
+corresponding case statements in the set_property switch statements and also correctly
+installs set_property support for some more POD types.
+
+* bindings/scripts/CodeGeneratorGObject.pm:
+(IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
+(IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
+update the list of types to reflect the full list of types we can generate setters for.
+(GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
+Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
+(GenerateProperties): Use grep and the new helpers to simplify the code.
+(GetReadableProperties): Deleted.
+(GetWriteableProperties): Deleted.
+* bindings/scripts/test/GObject: Update results
+
2014-03-31 Ryuan Choi ryuan.c...@samsung.com
[EFL][WK2] Extract the control of page background out of color_set
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (166567 => 166568)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-01 06:34:18 UTC (rev 166567)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-01 07:28:14 UTC (rev 166568)
@@ -412,41 +412,45 @@
return 1;
}
-sub GetReadableProperties {
-my $properties = shift;
+sub IsPropertyReadable {
+my $property = shift;
+return !SkipAttribute($property);
+}
-my @result = ();
+sub IsPropertyWriteable {
+my $property = shift;
-foreach my $property (@{$properties}) {
-if (!SkipAttribute($property)) {
-push(@result, $property);
-}
+if (!IsPropertyReadable($property)) {
+return 0;
}
-return @result;
-}
+if ($property-isReadOnly) {
+return 0;
+}
-sub GetWriteableProperties {
-my $properties = shift;
-my @result = ();
+my $gtype = GetGValueTypeName($property-signature-type);
+my $hasGtypeSignature = $gtype eq boolean || $gtype eq float || $gtype eq double ||
+$gtype eq int64 || $gtype eq uint64 ||
+$gtype eq long || $gtype eq ulong ||
+$gtype eq int || $gtype eq uint ||
+$gtype eq short || $gtype eq ushort ||
+$gtype eq int8 || $gtype eq uint8 ||
+
[webkit-changes] [166574] trunk/Source/WebKit2
Title: [166574] trunk/Source/WebKit2
Revision 166574
Author zandober...@gmail.com
Date 2014-04-01 02:07:25 -0700 (Tue, 01 Apr 2014)
Log Message
[GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
https://bugs.webkit.org/show_bug.cgi?id=131015
Reviewed by Carlos Garcia Campos.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
That function already returns a reference, so the return value should be stored accordingly.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166573 => 166574)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 09:04:45 UTC (rev 166573)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 09:07:25 UTC (rev 166574)
@@ -1,3 +1,14 @@
+2014-04-01 Zan Dobersek zdober...@igalia.com
+
+[GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
+https://bugs.webkit.org/show_bug.cgi?id=131015
+
+Reviewed by Carlos Garcia Campos.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
+That function already returns a reference, so the return value should be stored accordingly.
+
2014-04-01 Eunmi Lee eunmi15@samsung.com
[CoordinatedGraphics] Content scale factor should not be applied to draw contents when fixed layout is not used.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (166573 => 166574)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-01 09:04:45 UTC (rev 166573)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-01 09:07:25 UTC (rev 166574)
@@ -273,7 +273,7 @@
}
WebKitURIResponse* response = webkit_response_policy_decision_get_response(WEBKIT_RESPONSE_POLICY_DECISION(decision));
-const ResourceResponse resourceResponse = webkitURIResponseGetResourceResponse(response);
+const ResourceResponse resourceResponse = webkitURIResponseGetResourceResponse(response);
if (resourceResponse.isAttachment()) {
webkit_policy_decision_download(decision);
return TRUE;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166575] trunk/Source/WebKit2
Title: [166575] trunk/Source/WebKit2 Revision 166575 Author zandober...@gmail.com Date 2014-04-01 02:11:14 -0700 (Tue, 01 Apr 2014) Log Message Don't copy the children map in webkitWebViewBaseContainerForall https://bugs.webkit.org/show_bug.cgi?id=131016 Reviewed by Carlos Garcia Campos. * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseContainerForall): Avoid copying the GtkWidget-to-IntRect HashMap object by transforming the iteration to a range-based for-loop over that HashMap's keys. Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (166574 => 166575) --- trunk/Source/WebKit2/ChangeLog 2014-04-01 09:07:25 UTC (rev 166574) +++ trunk/Source/WebKit2/ChangeLog 2014-04-01 09:11:14 UTC (rev 166575) @@ -1,5 +1,16 @@ 2014-04-01 Zan Dobersek zdober...@igalia.com +Don't copy the children map in webkitWebViewBaseContainerForall +https://bugs.webkit.org/show_bug.cgi?id=131016 + +Reviewed by Carlos Garcia Campos. + +* UIProcess/API/gtk/WebKitWebViewBase.cpp: +(webkitWebViewBaseContainerForall): Avoid copying the GtkWidget-to-IntRect HashMap object +by transforming the iteration to a range-based for-loop over that HashMap's keys. + +2014-04-01 Zan Dobersek zdober...@igalia.com + [GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy https://bugs.webkit.org/show_bug.cgi?id=131015 Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (166574 => 166575) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2014-04-01 09:07:25 UTC (rev 166574) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2014-04-01 09:11:14 UTC (rev 166575) @@ -363,10 +363,8 @@ WebKitWebViewBase* webView = WEBKIT_WEB_VIEW_BASE(container); WebKitWebViewBasePrivate* priv = webView-priv; -WebKitWebViewChildrenMap children = priv-children; -WebKitWebViewChildrenMap::const_iterator end = children.end(); -for (WebKitWebViewChildrenMap::const_iterator current = children.begin(); current != end; ++current) -(*callback)(current-key, callbackData); +for (const auto widget : priv-children.keys()) +(*callback)(widget, callbackData); if (includeInternals priv-inspectorView) (*callback)(priv-inspectorView, callbackData); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166576] trunk/Source/WebKit2
Title: [166576] trunk/Source/WebKit2
Revision 166576
Author commit-qu...@webkit.org
Date 2014-04-01 04:38:37 -0700 (Tue, 01 Apr 2014)
Log Message
[EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_async_get API
https://bugs.webkit.org/show_bug.cgi?id=131017
Patch by Joonghun Park jh718.p...@samsung.com on 2014-04-01
Reviewed by Gyuyoung Kim.
* UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
Fix memory leaks and errors caused by duplication of Ecore_Timer deletion
as well as update a naming style of local variable.
(EWK2DatabaseManagerTest::databaseOriginsCallback):
(TEST_F):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_database_manager.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166575 => 166576)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 09:11:14 UTC (rev 166575)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 11:38:37 UTC (rev 166576)
@@ -1,3 +1,16 @@
+2014-04-01 Joonghun Park jh718.p...@samsung.com
+
+[EFL][WK2] Fix and update the existing test case for ewk_database_manager_origins_async_get API
+https://bugs.webkit.org/show_bug.cgi?id=131017
+
+Reviewed by Gyuyoung Kim.
+
+* UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
+Fix memory leaks and errors caused by duplication of Ecore_Timer deletion
+as well as update a naming style of local variable.
+(EWK2DatabaseManagerTest::databaseOriginsCallback):
+(TEST_F):
+
2014-04-01 Zan Dobersek zdober...@igalia.com
Don't copy the children map in webkitWebViewBaseContainerForall
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_database_manager.cpp (166575 => 166576)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_database_manager.cpp 2014-04-01 09:11:14 UTC (rev 166575)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_database_manager.cpp 2014-04-01 11:38:37 UTC (rev 166576)
@@ -55,15 +55,18 @@
Eina_List* l;
void* data;
EINA_LIST_FOREACH(origins, l, data) {
-originData-originList = eina_list_append(originData-originList, data);
Ewk_Security_Origin* origin = static_castEwk_Security_Origin*(data);
if (!strcmp(ewk_security_origin_protocol_get(origin), http)
!strcmp(ewk_security_origin_host_get(origin), www.databasetest.com)
!ewk_security_origin_port_get(origin)) {
+originData-originList = origins;
originData-isSynchronized = true;
-ecore_main_loop_quit();
+return;
}
}
+void* originItem;
+EINA_LIST_FREE(origins, originItem)
+ewk_object_unref(static_castEwk_Object*(originItem));
}
static Eina_Bool timerCallback(void* userData)
@@ -101,12 +104,15 @@
OriginData originData;
originData.manager = ewk_context_database_manager_get(ewk_view_context_get(view));
ASSERT_TRUE(ewk_database_manager_origins_async_get(originData.manager, databaseOriginsCallback, originData));
-Ecore_Timer* database_timer = ecore_timer_add(1, timerCallback, originData);
+Ecore_Timer* databaseTimer = ecore_timer_add(1, timerCallback, originData);
ecore_main_loop_begin();
-if (database_timer)
-ecore_timer_del(database_timer);
+databaseTimer = nullptr;
ASSERT_TRUE(originData.isSynchronized);
ASSERT_LE(1, eina_list_count(originData.originList));
+
+void* originItem;
+EINA_LIST_FREE(originData.originList, originItem)
+ewk_object_unref(static_castEwk_Object*(originItem));
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166577] trunk/Tools
Title: [166577] trunk/Tools Revision 166577 Author mario.pr...@samsung.com Date 2014-04-01 05:36:48 -0700 (Tue, 01 Apr 2014) Log Message [GTK] Running minibrowser with url crashes in debug build https://bugs.webkit.org/show_bug.cgi?id=130492 Reviewed by Martin Robinson. Update uri-scheme test not to use invalid URIs in it, so we don't get a mistmatch when comparing the original URI stored in the test class with the one returned by the WebKitWebView. * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: (testWebContextURIScheme): Update the test. Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp Diff Modified: trunk/Tools/ChangeLog (166576 => 166577) --- trunk/Tools/ChangeLog 2014-04-01 11:38:37 UTC (rev 166576) +++ trunk/Tools/ChangeLog 2014-04-01 12:36:48 UTC (rev 166577) @@ -1,3 +1,17 @@ +2014-04-01 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Running minibrowser with url crashes in debug build +https://bugs.webkit.org/show_bug.cgi?id=130492 + +Reviewed by Martin Robinson. + +Update uri-scheme test not to use invalid URIs in it, so we +don't get a mistmatch when comparing the original URI stored in +the test class with the one returned by the WebKitWebView. + +* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: +(testWebContextURIScheme): Update the test. + 2014-04-01 Mihai Tica mit...@adobe.com Unreviewed: Add myself as a commiter to the contributors list. Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp (166576 => 166577) --- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp 2014-04-01 11:38:37 UTC (rev 166576) +++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp 2014-04-01 12:36:48 UTC (rev 166577) @@ -195,7 +195,7 @@ g_assert(!strncmp(mainResourceData, kBarHTML, mainResourceDataSize)); test-registerURISchemeHandler(echo, kEchoHTMLFormat, -1, text/html); -test-loadURI(echo:hello world); +test-loadURI(echo:hello-world); test-waitUntilLoadFinished(); GUniquePtrchar echoHTML(g_strdup_printf(kEchoHTMLFormat, webkit_uri_scheme_request_get_path(test-m_uriSchemeRequest.get(; mainResourceDataSize = 0; @@ -205,7 +205,7 @@ test-registerURISchemeHandler(nomime, kBarHTML, -1, 0); test-m_loadEvents.clear(); -test-loadURI(nomime:foo bar); +test-loadURI(nomime:foo-bar); test-waitUntilLoadFinished(); g_assert(test-m_loadEvents.contains(LoadTrackingTest::ProvisionalLoadFailed)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166578] releases/WebKitGTK/webkit-2.4
Title: [166578] releases/WebKitGTK/webkit-2.4 Revision 166578 Author carlo...@webkit.org Date 2014-04-01 06:14:15 -0700 (Tue, 01 Apr 2014) Log Message Merge r166410 - [GTK] Running minibrowser with url crashes in debug build https://bugs.webkit.org/show_bug.cgi?id=130492 Reviewed by Martin Robinson. Use the ResourceRequest(const URL url) constructor, instead of the one taking a String, to call WebPageProxy::loadRequest(), so we ensure that the passed URI is correctly constructed. * UIProcess/API/gtk/WebKitWebView.cpp: (webkit_web_view_load_uri): Create an URL out of a SoupURI and use that to create a ResourceRequest to pass to loadRequest(). Modified Paths releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp releases/WebKitGTK/webkit-2.4/Tools/ChangeLog releases/WebKitGTK/webkit-2.4/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp Diff Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog (166577 => 166578) --- releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog 2014-04-01 12:36:48 UTC (rev 166577) +++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog 2014-04-01 13:14:15 UTC (rev 166578) @@ -1,3 +1,18 @@ +2014-03-28 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Running minibrowser with url crashes in debug build +https://bugs.webkit.org/show_bug.cgi?id=130492 + +Reviewed by Martin Robinson. + +Use the ResourceRequest(const URL url) constructor, instead of the +one taking a String, to call WebPageProxy::loadRequest(), so we +ensure that the passed URI is correctly constructed. + +* UIProcess/API/gtk/WebKitWebView.cpp: +(webkit_web_view_load_uri): Create an URL out of a SoupURI and +use that to create a ResourceRequest to pass to loadRequest(). + 2014-03-24 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Race condition when closing pages with network process enabled Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (166577 => 166578) --- releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-01 12:36:48 UTC (rev 166577) +++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-01 13:14:15 UTC (rev 166578) @@ -2000,7 +2000,8 @@ g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView)); g_return_if_fail(uri); -getPage(webView)-loadRequest(String::fromUTF8(uri)); +GUniquePtrSoupURI soupURI(soup_uri_new(uri)); +getPage(webView)-loadRequest(URL(soupURI.get())); } /** Modified: releases/WebKitGTK/webkit-2.4/Tools/ChangeLog (166577 => 166578) --- releases/WebKitGTK/webkit-2.4/Tools/ChangeLog 2014-04-01 12:36:48 UTC (rev 166577) +++ releases/WebKitGTK/webkit-2.4/Tools/ChangeLog 2014-04-01 13:14:15 UTC (rev 166578) @@ -1,3 +1,17 @@ +2014-04-01 Mario Sanchez Prada mario.pr...@samsung.com + +[GTK] Running minibrowser with url crashes in debug build +https://bugs.webkit.org/show_bug.cgi?id=130492 + +Reviewed by Martin Robinson. + +Update uri-scheme test not to use invalid URIs in it, so we +don't get a mistmatch when comparing the original URI stored in +the test class with the one returned by the WebKitWebView. + +* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: +(testWebContextURIScheme): Update the test. + 2014-03-24 Carlos Garcia Campos cgar...@igalia.com Unreviewed. Race condition when closing pages with network process enabled Modified: releases/WebKitGTK/webkit-2.4/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp (166577 => 166578) --- releases/WebKitGTK/webkit-2.4/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp 2014-04-01 12:36:48 UTC (rev 166577) +++ releases/WebKitGTK/webkit-2.4/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp 2014-04-01 13:14:15 UTC (rev 166578) @@ -195,7 +195,7 @@ g_assert(!strncmp(mainResourceData, kBarHTML, mainResourceDataSize)); test-registerURISchemeHandler(echo, kEchoHTMLFormat, -1, text/html); -test-loadURI(echo:hello world); +test-loadURI(echo:hello-world); test-waitUntilLoadFinished(); GUniquePtrchar echoHTML(g_strdup_printf(kEchoHTMLFormat, webkit_uri_scheme_request_get_path(test-m_uriSchemeRequest.get(; mainResourceDataSize = 0; @@ -205,7 +205,7 @@ test-registerURISchemeHandler(nomime, kBarHTML, -1, 0); test-m_loadEvents.clear(); -test-loadURI(nomime:foo bar); +test-loadURI(nomime:foo-bar); test-waitUntilLoadFinished(); g_assert(test-m_loadEvents.contains(LoadTrackingTest::ProvisionalLoadFailed)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166579] releases/WebKitGTK/webkit-2.4/Source/WebCore
Title: [166579] releases/WebKitGTK/webkit-2.4/Source/WebCore
Revision 166579
Author carlo...@webkit.org
Date 2014-04-01 06:25:54 -0700 (Tue, 01 Apr 2014)
Log Message
Merge r166568 - [GTK] Readonly attributes installed as readwrite in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=130978
Reviewed by Carlos Garcia Campos.
Unify how we decide if an attribute is readable or writeable and improve the code.
This results in some attributes now being marked as read-only which didn't have
corresponding case statements in the set_property switch statements and also correctly
installs set_property support for some more POD types.
* bindings/scripts/CodeGeneratorGObject.pm:
(IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
(IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
update the list of types to reflect the full list of types we can generate setters for.
(GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
(GenerateProperties): Use grep and the new helpers to simplify the code.
(GetReadableProperties): Deleted.
(GetWriteableProperties): Deleted.
* bindings/scripts/test/GObject: Update results
Modified Paths
releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp
releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp
releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (166578 => 166579)
--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-04-01 13:14:15 UTC (rev 166578)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog 2014-04-01 13:25:54 UTC (rev 166579)
@@ -1,3 +1,26 @@
+2014-04-01 Martin Robinson mrobin...@igalia.com
+
+[GTK] Readonly attributes installed as readwrite in GObject DOM bindings
+https://bugs.webkit.org/show_bug.cgi?id=130978
+
+Reviewed by Carlos Garcia Campos.
+
+Unify how we decide if an attribute is readable or writeable and improve the code.
+This results in some attributes now being marked as read-only which didn't have
+corresponding case statements in the set_property switch statements and also correctly
+installs set_property support for some more POD types.
+
+* bindings/scripts/CodeGeneratorGObject.pm:
+(IsPropertyReadable): Added this helper to simplify deciding if an attribute is readable.
+(IsPropertyWriteable): Added this helper to simplify deciding if an attribute is writeable. Also
+update the list of types to reflect the full list of types we can generate setters for.
+(GenerateProperty): Use the IsPropertyWriteable helper instead of checking whether the attribute is read-only.
+Also fix generation of the blurb by using $mutableString instead of $mutableStringconst which isn't used.
+(GenerateProperties): Use grep and the new helpers to simplify the code.
+(GetReadableProperties): Deleted.
+(GetWriteableProperties): Deleted.
+* bindings/scripts/test/GObject: Update results
+
2014-03-30 Xabier Rodriguez Calvar calva...@igalia.com
[GTK] [TextureMapper] Weird brightness with some videos with acceletared compositing
Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (166578 => 166579)
--- releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-01 13:14:15 UTC (rev 166578)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2014-04-01 13:25:54 UTC (rev 166579)
@@ -412,41 +412,45 @@
return 1;
}
-sub GetReadableProperties {
-my $properties = shift;
+sub IsPropertyReadable {
+my $property = shift;
+return !SkipAttribute($property);
+}
-my @result = ();
+sub IsPropertyWriteable {
+my $property = shift;
-foreach my $property (@{$properties}) {
-if (!SkipAttribute($property)) {
-push(@result, $property);
-}
+if (!IsPropertyReadable($property)) {
+return 0;
}
-return @result;
-}
+if ($property-isReadOnly) {
+return 0;
+}
-sub GetWriteableProperties {
-my $properties = shift;
-my @result = ();
+my $gtype = GetGValueTypeName($property-signature-type);
+my $hasGtypeSignature = $gtype eq boolean || $gtype eq float || $gtype eq double ||
+
[webkit-changes] [166580] releases/WebKitGTK/webkit-2.4/Source/WebKit2
Title: [166580] releases/WebKitGTK/webkit-2.4/Source/WebKit2
Revision 166580
Author carlo...@webkit.org
Date 2014-04-01 06:35:39 -0700 (Tue, 01 Apr 2014)
Log Message
Merge r166574 - [GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
https://bugs.webkit.org/show_bug.cgi?id=131015
Reviewed by Carlos Garcia Campos.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
That function already returns a reference, so the return value should be stored accordingly.
Modified Paths
releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog (166579 => 166580)
--- releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog 2014-04-01 13:25:54 UTC (rev 166579)
+++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog 2014-04-01 13:35:39 UTC (rev 166580)
@@ -1,3 +1,14 @@
+2014-04-01 Zan Dobersek zdober...@igalia.com
+
+[GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy
+https://bugs.webkit.org/show_bug.cgi?id=131015
+
+Reviewed by Carlos Garcia Campos.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewDecidePolicy): Avoid copying the ResourceResponce object returned by webkitURIResponseGetResourceResponse.
+That function already returns a reference, so the return value should be stored accordingly.
+
2014-03-28 Mario Sanchez Prada mario.pr...@samsung.com
[GTK] Running minibrowser with url crashes in debug build
Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (166579 => 166580)
--- releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-01 13:25:54 UTC (rev 166579)
+++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-04-01 13:35:39 UTC (rev 166580)
@@ -274,7 +274,7 @@
}
WebKitURIResponse* response = webkit_response_policy_decision_get_response(WEBKIT_RESPONSE_POLICY_DECISION(decision));
-const ResourceResponse resourceResponse = webkitURIResponseGetResourceResponse(response);
+const ResourceResponse resourceResponse = webkitURIResponseGetResourceResponse(response);
if (resourceResponse.isAttachment()) {
webkit_policy_decision_download(decision);
return TRUE;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166581] releases/WebKitGTK/webkit-2.4/Source/WebKit2
Title: [166581] releases/WebKitGTK/webkit-2.4/Source/WebKit2 Revision 166581 Author carlo...@webkit.org Date 2014-04-01 06:45:58 -0700 (Tue, 01 Apr 2014) Log Message Merge r166575 - Don't copy the children map in webkitWebViewBaseContainerForall https://bugs.webkit.org/show_bug.cgi?id=131016 Reviewed by Carlos Garcia Campos. * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseContainerForall): Avoid copying the GtkWidget-to-IntRect HashMap object by transforming the iteration to a range-based for-loop over that HashMap's keys. Modified Paths releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp Diff Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog (166580 => 166581) --- releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog 2014-04-01 13:35:39 UTC (rev 166580) +++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/ChangeLog 2014-04-01 13:45:58 UTC (rev 166581) @@ -1,5 +1,16 @@ 2014-04-01 Zan Dobersek zdober...@igalia.com +Don't copy the children map in webkitWebViewBaseContainerForall +https://bugs.webkit.org/show_bug.cgi?id=131016 + +Reviewed by Carlos Garcia Campos. + +* UIProcess/API/gtk/WebKitWebViewBase.cpp: +(webkitWebViewBaseContainerForall): Avoid copying the GtkWidget-to-IntRect HashMap object +by transforming the iteration to a range-based for-loop over that HashMap's keys. + +2014-04-01 Zan Dobersek zdober...@igalia.com + [GTK] Don't copy the ResourceResponse object in webkitWebViewDecidePolicy https://bugs.webkit.org/show_bug.cgi?id=131015 Modified: releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (166580 => 166581) --- releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2014-04-01 13:35:39 UTC (rev 166580) +++ releases/WebKitGTK/webkit-2.4/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2014-04-01 13:45:58 UTC (rev 166581) @@ -362,10 +362,8 @@ WebKitWebViewBase* webView = WEBKIT_WEB_VIEW_BASE(container); WebKitWebViewBasePrivate* priv = webView-priv; -WebKitWebViewChildrenMap children = priv-children; -WebKitWebViewChildrenMap::const_iterator end = children.end(); -for (WebKitWebViewChildrenMap::const_iterator current = children.begin(); current != end; ++current) -(*callback)(current-key, callbackData); +for (const auto widget : priv-children.keys()) +(*callback)(widget, callbackData); if (includeInternals priv-inspectorView) (*callback)(priv-inspectorView, callbackData); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166583] trunk/Source/WTF
Title: [166583] trunk/Source/WTF Revision 166583 Author commit-qu...@webkit.org Date 2014-04-01 07:32:44 -0700 (Tue, 01 Apr 2014) Log Message [GTK][Cmake] Enable CSS JIT https://bugs.webkit.org/show_bug.cgi?id=131022 Patch by Javier Fernandez jfernan...@igalia.com on 2014-04-01 Reviewed by Martin Robinson. * wtf/Platform.h: Enable CSS JIT for GTK port. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h Diff Modified: trunk/Source/WTF/ChangeLog (166582 => 166583) --- trunk/Source/WTF/ChangeLog 2014-04-01 14:17:58 UTC (rev 166582) +++ trunk/Source/WTF/ChangeLog 2014-04-01 14:32:44 UTC (rev 166583) @@ -1,3 +1,12 @@ +2014-04-01 Javier Fernandez jfernan...@igalia.com + +[GTK][Cmake] Enable CSS JIT +https://bugs.webkit.org/show_bug.cgi?id=131022 + +Reviewed by Martin Robinson. + +* wtf/Platform.h: Enable CSS JIT for GTK port. + 2014-04-01 Gyuyoung Kim gyuyoung@samsung.com [CMake][EFL] Enable CSS JIT Modified: trunk/Source/WTF/wtf/Platform.h (166582 => 166583) --- trunk/Source/WTF/wtf/Platform.h 2014-04-01 14:17:58 UTC (rev 166582) +++ trunk/Source/WTF/wtf/Platform.h 2014-04-01 14:32:44 UTC (rev 166583) @@ -849,7 +849,7 @@ /* CSS Selector JIT Compiler */ #if !defined(ENABLE_CSS_SELECTOR_JIT) -#if CPU(X86_64) ENABLE(JIT) (OS(DARWIN) || PLATFORM(EFL)) !PLATFORM(GTK) +#if CPU(X86_64) ENABLE(JIT) (OS(DARWIN) || PLATFORM(EFL) || PLATFORM(GTK)) #define ENABLE_CSS_SELECTOR_JIT 1 #else #define ENABLE_CSS_SELECTOR_JIT 0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166584] trunk/Tools
Title: [166584] trunk/Tools
Revision 166584
Author mrobin...@webkit.org
Date 2014-04-01 08:13:40 -0700 (Tue, 01 Apr 2014)
Log Message
[GTK] No longer build WebKit1 gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=130970
Reviewed by Anders Carlsson.
* gtk/common.py:
(gtk_version_of_pkg_config_file): Deleted.
* gtk/generate-gtkdoc:
(get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
was only applicable for WebKit1.
(get_generator_for_config): No longer look for the WebKit1 configuration file.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/gtk/common.py
trunk/Tools/gtk/generate-gtkdoc
Diff
Modified: trunk/Tools/ChangeLog (166583 => 166584)
--- trunk/Tools/ChangeLog 2014-04-01 14:32:44 UTC (rev 166583)
+++ trunk/Tools/ChangeLog 2014-04-01 15:13:40 UTC (rev 166584)
@@ -1,3 +1,17 @@
+2014-04-01 Martin Robinson mrobin...@igalia.com
+
+[GTK] No longer build WebKit1 gtkdoc
+https://bugs.webkit.org/show_bug.cgi?id=130970
+
+Reviewed by Anders Carlsson.
+
+* gtk/common.py:
+(gtk_version_of_pkg_config_file): Deleted.
+* gtk/generate-gtkdoc:
+(get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
+was only applicable for WebKit1.
+(get_generator_for_config): No longer look for the WebKit1 configuration file.
+
2014-04-01 Mario Sanchez Prada mario.pr...@samsung.com
[GTK] Running minibrowser with url crashes in debug build
Modified: trunk/Tools/gtk/common.py (166583 => 166584)
--- trunk/Tools/gtk/common.py 2014-04-01 14:32:44 UTC (rev 166583)
+++ trunk/Tools/gtk/common.py 2014-04-01 15:13:40 UTC (rev 166584)
@@ -117,16 +117,6 @@
return pkg_config_file_variable(package, 'prefix')
-def gtk_version_of_pkg_config_file(pkg_config_path):
-process = subprocess.Popen(['pkg-config', pkg_config_path, '--print-requires'],
- stdout=subprocess.PIPE)
-stdout = process.communicate()[0].decode(utf-8)
-
-if 'gtk+-3.0' in stdout:
-return 3
-return 2
-
-
def parse_output_lines(fd, parse_line_callback):
output = ''
read_set = [fd]
Modified: trunk/Tools/gtk/generate-gtkdoc (166583 => 166584)
--- trunk/Tools/gtk/generate-gtkdoc 2014-04-01 14:32:44 UTC (rev 166583)
+++ trunk/Tools/gtk/generate-gtkdoc 2014-04-01 15:13:40 UTC (rev 166584)
@@ -39,16 +39,13 @@
else:
handler.setFormatter(logging.Formatter('%(message)s'))
-def get_gtkdoc_module_paths(gtk_version):
+def get_gtkdoc_module_paths():
dependent_packages = {
'glib-2.0' : ['glib', 'gobject', 'gio'],
'libsoup-2.4' : ['libsoup-2.4'],
-'gdk-pixbuf-2.0': ['gdk-pixbuf']
+'gdk-pixbuf-2.0': ['gdk-pixbuf'],
+'gtk+-3.0' : ['gtk3', 'gdk3']
}
-if gtk_version == 3:
-dependent_packages.update({'gtk+-3.0' : ['gtk3', 'gdk3']})
-else:
-dependent_packages.update({'gtk+-2.0' : ['gtk', 'gdk']})
paths = []
html_dir = os.path.join('share', 'gtk-doc', 'html')
@@ -105,7 +102,6 @@
config.read(config_file)
module_name = config.sections()[0]
pkgconfig_file = config.get(module_name, 'pkgconfig_file')
-gtk_version = common.gtk_version_of_pkg_config_file(pkgconfig_file)
if not os.path.isfile(pkgconfig_file):
return None
@@ -124,7 +120,7 @@
'source_dirs': source_dirs,
'headers': headers,
'cflags': .join(config.get(module_name, 'cflags').split()),
-'cross_reference_deps': get_gtkdoc_module_paths(gtk_version),
+'cross_reference_deps': get_gtkdoc_module_paths(),
'ignored_files': files_to_ignore(source_dirs, headers),
})
@@ -193,8 +189,6 @@
webkitdom.write_doc_files()
generate_documentation_for_config(common.build_path('gtkdoc-webkitdom.cfg'))
+saw_warnings = generate_documentation_for_config(common.build_path('gtkdoc-webkit2gtk.cfg'))
-saw_webkit1_warnings = generate_documentation_for_config(common.build_path('gtkdoc-webkitgtk.cfg'))
-saw_webkit2_warnings = generate_documentation_for_config(common.build_path('gtkdoc-webkit2gtk.cfg'))
-
-sys.exit(saw_webkit1_warnings or saw_webkit2_warnings)
+sys.exit(saw_warnings)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166585] trunk/Source/WebCore
Title: [166585] trunk/Source/WebCore Revision 166585 Author zandober...@gmail.com Date 2014-04-01 08:20:40 -0700 (Tue, 01 Apr 2014) Log Message Move the attributes HashMap out of the parseAttributes function https://bugs.webkit.org/show_bug.cgi?id=131019 Reviewed by Andreas Kling. * xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::parseAttributes): Avoid copying the HashMap object that's being returned by converting it to an xvalue through using std::move() in the return statement. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (166584 => 166585) --- trunk/Source/WebCore/ChangeLog 2014-04-01 15:13:40 UTC (rev 166584) +++ trunk/Source/WebCore/ChangeLog 2014-04-01 15:20:40 UTC (rev 166585) @@ -1,3 +1,14 @@ +2014-04-01 Zan Dobersek zdober...@igalia.com + +Move the attributes HashMap out of the parseAttributes function +https://bugs.webkit.org/show_bug.cgi?id=131019 + +Reviewed by Andreas Kling. + +* xml/parser/XMLDocumentParserLibxml2.cpp: +(WebCore::parseAttributes): Avoid copying the HashMap object that's being returned by +converting it to an xvalue through using std::move() in the return statement. + 2014-04-01 Zalan Bujtas za...@apple.com Subpixel rendering: Transition class Image (and its dependencies) from int to float to enable subpixel positioned/sized images. Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp (166584 => 166585) --- trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2014-04-01 15:13:40 UTC (rev 166584) +++ trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp 2014-04-01 15:20:40 UTC (rev 166585) @@ -1544,7 +1544,7 @@ xmlParseChunk(parser-context(), reinterpret_castconst char*(StringView(parseString).upconvertedCharacters().get()), parseString.length() * sizeof(UChar), 1); attrsOK = state.gotAttributes; -return state.attributes; +return std::move(state.attributes); } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166586] trunk/Source/WebCore
Title: [166586] trunk/Source/WebCore
Revision 166586
Author zandober...@gmail.com
Date 2014-04-01 08:22:36 -0700 (Tue, 01 Apr 2014)
Log Message
Avoid unnecessary HashSet copies when calling collectInstancesForSVGElement
https://bugs.webkit.org/show_bug.cgi?id=131020
Reviewed by Andreas Kling.
Remove collectInstancesForSVGElement() to avoid HashSet copies when assigning a const
HashSet reference to a non-const HashSet reference. Instead, range-based for-loops are
deployed to iterate directly over the const reference to HashSet that's returned by
SVGElement::instancesForElement(). SVGElement::containingShadowRoot() return value
is checked to see if the iteration should be performed in the first place, preserving
the behavior of collectInstancesForSVGElement().
* svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
(WebCore::collectInstancesForSVGElement): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166585 => 166586)
--- trunk/Source/WebCore/ChangeLog 2014-04-01 15:20:40 UTC (rev 166585)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 15:22:36 UTC (rev 166586)
@@ -1,5 +1,24 @@
2014-04-01 Zan Dobersek zdober...@igalia.com
+Avoid unnecessary HashSet copies when calling collectInstancesForSVGElement
+https://bugs.webkit.org/show_bug.cgi?id=131020
+
+Reviewed by Andreas Kling.
+
+Remove collectInstancesForSVGElement() to avoid HashSet copies when assigning a const
+HashSet reference to a non-const HashSet reference. Instead, range-based for-loops are
+deployed to iterate directly over the const reference to HashSet that's returned by
+SVGElement::instancesForElement(). SVGElement::containingShadowRoot() return value
+is checked to see if the iteration should be performed in the first place, preserving
+the behavior of collectInstancesForSVGElement().
+
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::addEventListener):
+(WebCore::SVGElement::removeEventListener):
+(WebCore::collectInstancesForSVGElement): Deleted.
+
+2014-04-01 Zan Dobersek zdober...@igalia.com
+
Move the attributes HashMap out of the parseAttributes function
https://bugs.webkit.org/show_bug.cgi?id=131019
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (166585 => 166586)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2014-04-01 15:20:40 UTC (rev 166585)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2014-04-01 15:22:36 UTC (rev 166586)
@@ -535,17 +535,6 @@
return true;
}
-static inline void collectInstancesForSVGElement(SVGElement* element, HashSetSVGElementInstance* instances)
-{
-ASSERT(element);
-if (element-containingShadowRoot())
-return;
-
-ASSERT(!element-instanceUpdatesBlocked());
-
-instances = element-instancesForElement();
-}
-
bool SVGElement::addEventListener(const AtomicString eventType, PassRefPtrEventListener prpListener, bool useCapture)
{
RefPtrEventListener listener = prpListener;
@@ -554,15 +543,16 @@
if (!Node::addEventListener(eventType, listener, useCapture))
return false;
+if (containingShadowRoot())
+return true;
+
// Add event listener to all shadow tree DOM element instances
-HashSetSVGElementInstance* instances;
-collectInstancesForSVGElement(this, instances);
-const HashSetSVGElementInstance*::const_iterator end = instances.end();
-for (HashSetSVGElementInstance*::const_iterator it = instances.begin(); it != end; ++it) {
-ASSERT((*it)-shadowTreeElement());
-ASSERT((*it)-correspondingElement() == this);
+ASSERT(!element-instanceUpdatesBlocked());
+for (auto instance : instancesForElement()) {
+ASSERT(instance-shadowTreeElement());
+ASSERT(instance-correspondingElement() == this);
-bool result = (*it)-shadowTreeElement()-Node::addEventListener(eventType, listener, useCapture);
+bool result = instance-shadowTreeElement()-Node::addEventListener(eventType, listener, useCapture);
ASSERT_UNUSED(result, result);
}
@@ -571,9 +561,7 @@
bool SVGElement::removeEventListener(const AtomicString eventType, EventListener* listener, bool useCapture)
{
-HashSetSVGElementInstance* instances;
-collectInstancesForSVGElement(this, instances);
-if (instances.isEmpty())
+if (containingShadowRoot())
return Node::removeEventListener(eventType, listener, useCapture);
// EventTarget::removeEventListener creates a PassRefPtr around the given EventListener
@@ -588,11 +576,11 @@
return false;
// Remove event listener from all shadow tree DOM element instances
-const HashSetSVGElementInstance*::const_iterator end = instances.end();
-for (HashSetSVGElementInstance*::const_iterator it = instances.begin(); it != end; ++it) {
-
[webkit-changes] [166587] trunk/Source/WebKit2
Title: [166587] trunk/Source/WebKit2 Revision 166587 Author za...@apple.com Date 2014-04-01 08:28:36 -0700 (Tue, 01 Apr 2014) Log Message Build fix after r166582. * Shared/ContextMenuContextData.cpp: (WebKit::ContextMenuContextData::ContextMenuContextData): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/ContextMenuContextData.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (166586 => 166587) --- trunk/Source/WebKit2/ChangeLog 2014-04-01 15:22:36 UTC (rev 166586) +++ trunk/Source/WebKit2/ChangeLog 2014-04-01 15:28:36 UTC (rev 166587) @@ -1,5 +1,12 @@ 2014-04-01 Zalan Bujtas za...@apple.com +Build fix after r166582. + +* Shared/ContextMenuContextData.cpp: +(WebKit::ContextMenuContextData::ContextMenuContextData): + +2014-04-01 Zalan Bujtas za...@apple.com + Subpixel rendering: Transition class Image (and its dependencies) from int to float to enable subpixel positioned/sized images. https://bugs.webkit.org/show_bug.cgi?id=130643 Modified: trunk/Source/WebKit2/Shared/ContextMenuContextData.cpp (166586 => 166587) --- trunk/Source/WebKit2/Shared/ContextMenuContextData.cpp 2014-04-01 15:22:36 UTC (rev 166586) +++ trunk/Source/WebKit2/Shared/ContextMenuContextData.cpp 2014-04-01 15:28:36 UTC (rev 166587) @@ -48,8 +48,8 @@ Image* image = context.controlledImage(); if (!image) return; - -RefPtrShareableBitmap bitmap = ShareableBitmap::createShareable(image-size(), ShareableBitmap::SupportsAlpha); +// FIXME: figure out the rounding startegy for ShareableBitmap. +RefPtrShareableBitmap bitmap = ShareableBitmap::createShareable(IntSize(image-size()), ShareableBitmap::SupportsAlpha); bitmap-createGraphicsContext()-drawImage(image, ColorSpaceDeviceRGB, IntPoint()); bitmap-createHandle(m_controlledImageHandle); #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166588] trunk/Source/WebKit2
Title: [166588] trunk/Source/WebKit2
Revision 166588
Author simon.fra...@apple.com
Date 2014-04-01 08:29:16 -0700 (Tue, 01 Apr 2014)
Log Message
[UI-side compositing] Fix animations, and add logging
https://bugs.webkit.org/show_bug.cgi?id=131011
Reviewed by Tim Horton.
UI-side animations were broken because GraphicsLayerCARemote::addAnimation()
never called the superclass, so fix.
Add logging for animations to the layer tree commit output.
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpProperty):
(WebKit::RemoteLayerTreeTextStream::operator):
(WebKit::dumpChangedLayers):
* WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::addAnimation):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166587 => 166588)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 15:28:36 UTC (rev 166587)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 15:29:16 UTC (rev 166588)
@@ -1,3 +1,22 @@
+2014-03-31 Simon Fraser simon.fra...@apple.com
+
+[UI-side compositing] Fix animations, and add logging
+https://bugs.webkit.org/show_bug.cgi?id=131011
+
+Reviewed by Tim Horton.
+
+UI-side animations were broken because GraphicsLayerCARemote::addAnimation()
+never called the superclass, so fix.
+
+Add logging for animations to the layer tree commit output.
+
+* Shared/mac/RemoteLayerTreeTransaction.mm:
+(WebKit::dumpProperty):
+(WebKit::RemoteLayerTreeTextStream::operator):
+(WebKit::dumpChangedLayers):
+* WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
+(WebKit::GraphicsLayerCARemote::addAnimation):
+
2014-04-01 Zalan Bujtas za...@apple.com
Build fix after r166582.
Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm (166587 => 166588)
--- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2014-04-01 15:28:36 UTC (rev 166587)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2014-04-01 15:29:16 UTC (rev 166588)
@@ -29,10 +29,12 @@
#import ArgumentCoders.h
#import MessageDecoder.h
#import MessageEncoder.h
+#import PlatformCAAnimationRemote.h
#import PlatformCALayerRemote.h
#import WebCoreArgumentCoders.h
#import QuartzCore/QuartzCore.h
#import WebCore/TextStream.h
+#import WebCore/TimingFunction.h
#import wtf/text/CString.h
#import wtf/text/StringBuilder.h
@@ -557,9 +559,15 @@
RemoteLayerTreeTextStream operator(FloatPoint3D);
RemoteLayerTreeTextStream operator(Color);
RemoteLayerTreeTextStream operator(FloatRect);
-RemoteLayerTreeTextStream operator(const VectorWebCore::GraphicsLayer::PlatformLayerID layers);
+RemoteLayerTreeTextStream operator(const VectorWebCore::GraphicsLayer::PlatformLayerID);
RemoteLayerTreeTextStream operator(const FilterOperations);
-RemoteLayerTreeTextStream operator(const RemoteLayerBackingStore backingStore);
+RemoteLayerTreeTextStream operator(const PlatformCAAnimationRemote::Properties);
+RemoteLayerTreeTextStream operator(const RemoteLayerBackingStore);
+RemoteLayerTreeTextStream operator(PlatformCAAnimation::AnimationType);
+RemoteLayerTreeTextStream operator(PlatformCAAnimation::FillModeType);
+RemoteLayerTreeTextStream operator(PlatformCAAnimation::ValueFunctionType);
+RemoteLayerTreeTextStream operator(const TimingFunction);
+RemoteLayerTreeTextStream operator(const PlatformCAAnimationRemote::KeyframeValue);
void increaseIndent() { ++m_indent; }
void decreaseIndent() { --m_indent; ASSERT(m_indent = 0); }
@@ -570,6 +578,17 @@
int m_indent;
};
+template class T
+static void dumpProperty(RemoteLayerTreeTextStream ts, String name, T value)
+{
+ts \n;
+ts.increaseIndent();
+ts.writeIndent();
+ts ( name ;
+ts value );
+ts.decreaseIndent();
+}
+
RemoteLayerTreeTextStream RemoteLayerTreeTextStream::operator(const TransformationMatrix transform)
{
RemoteLayerTreeTextStream ts = *this;
@@ -660,6 +679,165 @@
return ts;
}
+RemoteLayerTreeTextStream RemoteLayerTreeTextStream::operator(PlatformCAAnimation::AnimationType type)
+{
+RemoteLayerTreeTextStream ts = *this;
+switch (type) {
+case PlatformCAAnimation::Basic: ts basic; break;
+case PlatformCAAnimation::Keyframe: ts keyframe; break;
+}
+return ts;
+}
+
+RemoteLayerTreeTextStream RemoteLayerTreeTextStream::operator(PlatformCAAnimation::FillModeType type)
+{
+RemoteLayerTreeTextStream ts = *this;
+switch (type) {
+case PlatformCAAnimation::NoFillMode: ts none; break;
+case PlatformCAAnimation::Forwards: ts forwards; break;
+case PlatformCAAnimation::Backwards: ts backwards; break;
+case PlatformCAAnimation::Both: ts both; break;
+}
+return ts;
+}
+
[webkit-changes] [166589] trunk/Source/WebCore
Title: [166589] trunk/Source/WebCore
Revision 166589
Author zandober...@gmail.com
Date 2014-04-01 08:35:46 -0700 (Tue, 01 Apr 2014)
Log Message
Prevent unnecessary copies in compareEqual template
https://bugs.webkit.org/show_bug.cgi?id=131014
Reviewed by Antti Koivisto.
* rendering/style/RenderStyle.h:
(compareEqual): Casting the second parameter to a non-const, non-reference type
causes an extra copy of that object. Casting to the const reference type of the
first parameter avoids that.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/RenderStyle.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166588 => 166589)
--- trunk/Source/WebCore/ChangeLog 2014-04-01 15:29:16 UTC (rev 166588)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 15:35:46 UTC (rev 166589)
@@ -1,5 +1,17 @@
2014-04-01 Zan Dobersek zdober...@igalia.com
+Prevent unnecessary copies in compareEqual template
+https://bugs.webkit.org/show_bug.cgi?id=131014
+
+Reviewed by Antti Koivisto.
+
+* rendering/style/RenderStyle.h:
+(compareEqual): Casting the second parameter to a non-const, non-reference type
+causes an extra copy of that object. Casting to the const reference type of the
+first parameter avoids that.
+
+2014-04-01 Zan Dobersek zdober...@igalia.com
+
Avoid unnecessary HashSet copies when calling collectInstancesForSVGElement
https://bugs.webkit.org/show_bug.cgi?id=131020
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (166588 => 166589)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2014-04-01 15:29:16 UTC (rev 166588)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2014-04-01 15:35:46 UTC (rev 166589)
@@ -91,7 +91,7 @@
#include TextSizeAdjustment.h
#endif
-templatetypename T, typename U inline bool compareEqual(const T t, const U u) { return t == static_castT(u); }
+templatetypename T, typename U inline bool compareEqual(const T t, const U u) { return t == static_castconst T(u); }
#define SET_VAR(group, variable, value) \
if (!compareEqual(group-variable, value)) \
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166590] trunk/Source/WebCore
Title: [166590] trunk/Source/WebCore
Revision 166590
Author zandober...@gmail.com
Date 2014-04-01 08:47:47 -0700 (Tue, 01 Apr 2014)
Log Message
Unreviewed. Fixing debug builds after r166586.
* svg/SVGElement.cpp:
(WebCore::SVGElement::addEventListener): Fix the ASSERT.
(WebCore::SVGElement::removeEventListener): Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166589 => 166590)
--- trunk/Source/WebCore/ChangeLog 2014-04-01 15:35:46 UTC (rev 166589)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 15:47:47 UTC (rev 166590)
@@ -1,5 +1,13 @@
2014-04-01 Zan Dobersek zdober...@igalia.com
+Unreviewed. Fixing debug builds after r166586.
+
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::addEventListener): Fix the ASSERT.
+(WebCore::SVGElement::removeEventListener): Ditto.
+
+2014-04-01 Zan Dobersek zdober...@igalia.com
+
Prevent unnecessary copies in compareEqual template
https://bugs.webkit.org/show_bug.cgi?id=131014
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (166589 => 166590)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2014-04-01 15:35:46 UTC (rev 166589)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2014-04-01 15:47:47 UTC (rev 166590)
@@ -547,7 +547,7 @@
return true;
// Add event listener to all shadow tree DOM element instances
-ASSERT(!element-instanceUpdatesBlocked());
+ASSERT(!instanceUpdatesBlocked());
for (auto instance : instancesForElement()) {
ASSERT(instance-shadowTreeElement());
ASSERT(instance-correspondingElement() == this);
@@ -576,7 +576,7 @@
return false;
// Remove event listener from all shadow tree DOM element instances
-ASSERT(!element-instanceUpdatesBlocked());
+ASSERT(!instanceUpdatesBlocked());
for (auto instance : instancesForElement()) {
ASSERT(instance-correspondingElement() == this);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166591] trunk/Source/WTF
Title: [166591] trunk/Source/WTF Revision 166591 Author commit-qu...@webkit.org Date 2014-04-01 09:04:46 -0700 (Tue, 01 Apr 2014) Log Message Unreviewed, rolling out r166583. https://bugs.webkit.org/show_bug.cgi?id=131040 It's causing frequent crashes when running Layout Tests (Requested by svillar on #webkit). Reverted changeset: [GTK][Cmake] Enable CSS JIT https://bugs.webkit.org/show_bug.cgi?id=131022 http://trac.webkit.org/changeset/166583 Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h Diff Modified: trunk/Source/WTF/ChangeLog (166590 => 166591) --- trunk/Source/WTF/ChangeLog 2014-04-01 15:47:47 UTC (rev 166590) +++ trunk/Source/WTF/ChangeLog 2014-04-01 16:04:46 UTC (rev 166591) @@ -1,3 +1,17 @@ +2014-04-01 Commit Queue commit-qu...@webkit.org + +Unreviewed, rolling out r166583. +https://bugs.webkit.org/show_bug.cgi?id=131040 + +It's causing frequent crashes when running Layout Tests +(Requested by svillar on #webkit). + +Reverted changeset: + +[GTK][Cmake] Enable CSS JIT +https://bugs.webkit.org/show_bug.cgi?id=131022 +http://trac.webkit.org/changeset/166583 + 2014-04-01 Javier Fernandez jfernan...@igalia.com [GTK][Cmake] Enable CSS JIT Modified: trunk/Source/WTF/wtf/Platform.h (166590 => 166591) --- trunk/Source/WTF/wtf/Platform.h 2014-04-01 15:47:47 UTC (rev 166590) +++ trunk/Source/WTF/wtf/Platform.h 2014-04-01 16:04:46 UTC (rev 166591) @@ -849,7 +849,7 @@ /* CSS Selector JIT Compiler */ #if !defined(ENABLE_CSS_SELECTOR_JIT) -#if CPU(X86_64) ENABLE(JIT) (OS(DARWIN) || PLATFORM(EFL) || PLATFORM(GTK)) +#if CPU(X86_64) ENABLE(JIT) (OS(DARWIN) || PLATFORM(EFL)) !PLATFORM(GTK) #define ENABLE_CSS_SELECTOR_JIT 1 #else #define ENABLE_CSS_SELECTOR_JIT 0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166593] trunk/Source/WTF
Title: [166593] trunk/Source/WTF Revision 166593 Author o...@webkit.org Date 2014-04-01 09:32:41 -0700 (Tue, 01 Apr 2014) Log Message [EFL] REGRESSION(166569): It made DoYouEvenBench/Full.html, CSS/QuerySelector.html and Dromaeo performance tests crash https://bugs.webkit.org/show_bug.cgi?id=131039 Patch by Zsolt Borbely zsborbely.u-sze...@partner.samsung.com on 2014-04-01 Reviewed by Csaba Osztrogonác. * wtf/Platform.h: Disable CSS JIT on EFL until proper fix. Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/Platform.h Diff Modified: trunk/Source/WTF/ChangeLog (166592 => 166593) --- trunk/Source/WTF/ChangeLog 2014-04-01 16:18:38 UTC (rev 166592) +++ trunk/Source/WTF/ChangeLog 2014-04-01 16:32:41 UTC (rev 166593) @@ -1,3 +1,12 @@ +2014-04-01 Zsolt Borbely zsborbely.u-sze...@partner.samsung.com + +[EFL] REGRESSION(166569): It made DoYouEvenBench/Full.html, CSS/QuerySelector.html and Dromaeo performance tests crash +https://bugs.webkit.org/show_bug.cgi?id=131039 + +Reviewed by Csaba Osztrogonác. + +* wtf/Platform.h: Disable CSS JIT on EFL until proper fix. + 2014-04-01 Commit Queue commit-qu...@webkit.org Unreviewed, rolling out r166583. Modified: trunk/Source/WTF/wtf/Platform.h (166592 => 166593) --- trunk/Source/WTF/wtf/Platform.h 2014-04-01 16:18:38 UTC (rev 166592) +++ trunk/Source/WTF/wtf/Platform.h 2014-04-01 16:32:41 UTC (rev 166593) @@ -849,7 +849,7 @@ /* CSS Selector JIT Compiler */ #if !defined(ENABLE_CSS_SELECTOR_JIT) -#if CPU(X86_64) ENABLE(JIT) (OS(DARWIN) || PLATFORM(EFL)) !PLATFORM(GTK) +#if CPU(X86_64) ENABLE(JIT) OS(DARWIN) !PLATFORM(EFL) !PLATFORM(GTK) #define ENABLE_CSS_SELECTOR_JIT 1 #else #define ENABLE_CSS_SELECTOR_JIT 0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166594] trunk
Title: [166594] trunk Revision 166594 Author commit-qu...@webkit.org Date 2014-04-01 09:36:45 -0700 (Tue, 01 Apr 2014) Log Message AX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if roleValue is ApplicationAlertRole || ApplicationStatusRole https://bugs.webkit.org/show_bug.cgi?id=130907 Patch by James Craig jcr...@apple.com on 2014-04-01 Reviewed by Chris Fleizach. Source/WebCore: Tests: inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html: platform/mac/accessibility/aria-liveregions-attributes.html: Updated AccessibilityRenderObject::ariaLiveRegionAtomic() to match ARIA spec. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic): LayoutTests: Updated AccessibilityRenderObject::ariaLiveRegionAtomic() to match ARIA spec. * inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt: * inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html: * platform/mac/accessibility/aria-liveregions-attributes-expected.txt: * platform/mac/accessibility/aria-liveregions-attributes.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-attributes.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp Diff Modified: trunk/LayoutTests/ChangeLog (166593 => 166594) --- trunk/LayoutTests/ChangeLog 2014-04-01 16:32:41 UTC (rev 166593) +++ trunk/LayoutTests/ChangeLog 2014-04-01 16:36:45 UTC (rev 166594) @@ -1,3 +1,18 @@ +2014-04-01 James Craig jcr...@apple.com + +AX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if +roleValue is ApplicationAlertRole || ApplicationStatusRole +https://bugs.webkit.org/show_bug.cgi?id=130907 + +Reviewed by Chris Fleizach. + +Updated AccessibilityRenderObject::ariaLiveRegionAtomic() to match ARIA spec. + +* inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt: +* inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html: +* platform/mac/accessibility/aria-liveregions-attributes-expected.txt: +* platform/mac/accessibility/aria-liveregions-attributes.html: + 2014-04-01 Zalan Bujtas za...@apple.com Subpixel rendering: Transition class Image (and its dependencies) from int to float to enable subpixel positioned/sized images. Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt (166593 => 166594) --- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt 2014-04-01 16:32:41 UTC (rev 166593) +++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt 2014-04-01 16:36:45 UTC (rev 166594) @@ -8,14 +8,14 @@ div role=status aria-live=offoff/div exists: true -div role=status aria-live=assertiveassertive !-- FIXME: atomic should be true http://webkit.org/b/130907 --/div +div role=status aria-live=assertiveassertive/div exists: true -liveRegionAtomic: false +liveRegionAtomic: true liveRegionStatus: assertive -div role=statuspolite (default) !-- FIXME: atomic should be true http://webkit.org/b/130907 --/div +div role=statuspolite (default)/div exists: true -liveRegionAtomic: false +liveRegionAtomic: true liveRegionStatus: polite div role=marqueeoff (default)/div @@ -34,17 +34,17 @@ liveRegionAtomic: false liveRegionStatus: polite -div role=alert aria-live=politepolite !-- FIXME: atomic should be true http://webkit.org/b/130907 --/div +div role=alert aria-live=politepolite/div exists: true -liveRegionAtomic: false +liveRegionAtomic: true liveRegionStatus: polite div role=alert aria-live=offoff/div exists: true -div role=alertassertive (default) !-- FIXME: atomic should be true http://webkit.org/b/130907 --/div +div role=alertassertive (default)/div exists: true -liveRegionAtomic: false +liveRegionAtomic: true liveRegionStatus: assertive div role=group aria-live=assertive aria-busy=true aria-atomic=falseassertive/div Modified: trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html (166593 => 166594) --- trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html 2014-04-01 16:32:41 UTC (rev 166593) +++ trunk/LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html 2014-04-01 16:36:45 UTC (rev 166594) @@ -15,15 +15,15 @@ div class=ex role=group aria-live=polite
[webkit-changes] [166595] trunk/Source
Title: [166595] trunk/Source
Revision 166595
Author simon.fra...@apple.com
Date 2014-04-01 10:08:54 -0700 (Tue, 01 Apr 2014)
Log Message
Enable WEB_TIMING on Mac and iOS
https://bugs.webkit.org/show_bug.cgi?id=128064
Source/_javascript_Core:
Reviewed by Sam Weinig, Brent Fulgham.
Enable WEB_TIMING.
* Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Reviewed by Sam Weinig, Brent Fulgham.
Enable WEB_TIMING. Add PerformanceTiming.cpp and JSPerformanceTiming.cpp
to the project.
* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Reviewed by Sam Weinig, Brent Fulgham.
Enable WEB_TIMING.
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Reviewed by Sam Weinig, Brent Fulgham.
Enable WEB_TIMING.
* Configurations/FeatureDefines.xcconfig:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (166594 => 166595)
--- trunk/Source/_javascript_Core/ChangeLog 2014-04-01 16:36:45 UTC (rev 166594)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-04-01 17:08:54 UTC (rev 166595)
@@ -1,3 +1,14 @@
+2014-03-31 Simon Fraser simon.fra...@apple.com
+
+Enable WEB_TIMING on Mac and iOS
+https://bugs.webkit.org/show_bug.cgi?id=128064
+
+Reviewed by Sam Weinig, Brent Fulgham.
+
+Enable WEB_TIMING.
+
+* Configurations/FeatureDefines.xcconfig:
+
2014-03-31 Michael Saboff msab...@apple.com
REGRESSION(r166415): JSObject{Get,Set}Private() don't work with proxies objects
Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (166594 => 166595)
--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2014-04-01 16:36:45 UTC (rev 166594)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2014-04-01 17:08:54 UTC (rev 166595)
@@ -187,6 +187,7 @@
ENABLE_SUBTLE_CRYPTO_iphoneos = ENABLE_SUBTLE_CRYPTO;
ENABLE_SUBTLE_CRYPTO_iphonesimulator = $(ENABLE_SUBTLE_CRYPTO_iphoneos);
ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
+
ENABLE_TELEPHONE_NUMBER_DETECTION = $(ENABLE_TELEPHONE_NUMBER_DETECTION_$(PLATFORM_NAME));
ENABLE_TELEPHONE_NUMBER_DETECTION_macosx = $(ENABLE_TELEPHONE_NUMBER_DETECTION_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
ENABLE_TELEPHONE_NUMBER_DETECTION_macosx_1080 = ;
@@ -194,6 +195,7 @@
ENABLE_TELEPHONE_NUMBER_DETECTION_macosx_101000 = ENABLE_TELEPHONE_NUMBER_DETECTION;
ENABLE_TELEPHONE_NUMBER_DETECTION_iphoneos = ENABLE_TELEPHONE_NUMBER_DETECTION;
ENABLE_TELEPHONE_NUMBER_DETECTION_iphonesimulator = $(ENABLE_TELEPHONE_NUMBER_DETECTION_iphoneos);
+
ENABLE_TEMPLATE_ELEMENT = ENABLE_TEMPLATE_ELEMENT;
ENABLE_TEXT_AUTOSIZING = ;
ENABLE_TOUCH_EVENTS = $(ENABLE_TOUCH_EVENTS_$(PLATFORM_NAME));
@@ -208,7 +210,15 @@
ENABLE_WEB_AUDIO = ENABLE_WEB_AUDIO;
ENABLE_WEB_REPLAY = ;
ENABLE_WEB_SOCKETS = ENABLE_WEB_SOCKETS;
-ENABLE_WEB_TIMING = ;
+
+ENABLE_WEB_TIMING = $(ENABLE_WEB_TIMING_$(PLATFORM_NAME));
+ENABLE_WEB_TIMING_macosx = $(ENABLE_WEB_TIMING_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
+ENABLE_WEB_TIMING_macosx_1080 = ;
+ENABLE_WEB_TIMING_macosx_1090 = ;
+ENABLE_WEB_TIMING_macosx_101000 = ENABLE_WEB_TIMING;
+ENABLE_WEB_TIMING_iphoneos = ENABLE_WEB_TIMING;
+ENABLE_WEB_TIMING_iphonesimulator = $(ENABLE_WEB_TIMING_iphoneos);
+
ENABLE_WEBVTT_REGIONS = ENABLE_WEBVTT_REGIONS;
ENABLE_XHR_TIMEOUT = ENABLE_XHR_TIMEOUT;
ENABLE_XSLT = ENABLE_XSLT;
Modified: trunk/Source/WebCore/ChangeLog (166594 => 166595)
--- trunk/Source/WebCore/ChangeLog 2014-04-01 16:36:45 UTC (rev 166594)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 17:08:54 UTC (rev 166595)
@@ -1,3 +1,16 @@
+2014-03-31 Simon Fraser simon.fra...@apple.com
+
+Enable WEB_TIMING on Mac and iOS
+https://bugs.webkit.org/show_bug.cgi?id=128064
+
+Reviewed by Sam Weinig, Brent Fulgham.
+
+Enable WEB_TIMING. Add PerformanceTiming.cpp and JSPerformanceTiming.cpp
+to the project.
+
+* Configurations/FeatureDefines.xcconfig:
+* WebCore.xcodeproj/project.pbxproj:
+
2014-04-01 James Craig jcr...@apple.com
AX: AccessibilityRenderObject::ariaLiveRegionAtomic() should default to true if
Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (166594 => 166595)
--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2014-04-01 16:36:45 UTC (rev 166594)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2014-04-01 17:08:54 UTC (rev 166595)
@@ -187,6 +187,7 @@
ENABLE_SUBTLE_CRYPTO_iphoneos = ENABLE_SUBTLE_CRYPTO;
[webkit-changes] [166596] trunk/Source/WebKit2
Title: [166596] trunk/Source/WebKit2
Revision 166596
Author ander...@apple.com
Date 2014-04-01 10:39:11 -0700 (Tue, 01 Apr 2014)
Log Message
Tweak WKPreferences API
https://bugs.webkit.org/show_bug.cgi?id=131047
Reviewed by Simon Fraser.
* UIProcess/API/Cocoa/WKPreferences.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences init]):
(-[WKPreferences initWithUserDefaultsKeyPrefix:]):
(-[WKPreferences userDefaultsKeyPrefix]):
(-[WKPreferences initWithUserDefaultsPrefixKey:]): Deleted.
(-[WKPreferences userDefaultsPrefixKey]): Deleted.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166595 => 166596)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 17:08:54 UTC (rev 166595)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 17:39:11 UTC (rev 166596)
@@ -1,3 +1,18 @@
+2014-04-01 Anders Carlsson ander...@apple.com
+
+Tweak WKPreferences API
+https://bugs.webkit.org/show_bug.cgi?id=131047
+
+Reviewed by Simon Fraser.
+
+* UIProcess/API/Cocoa/WKPreferences.h:
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences init]):
+(-[WKPreferences initWithUserDefaultsKeyPrefix:]):
+(-[WKPreferences userDefaultsKeyPrefix]):
+(-[WKPreferences initWithUserDefaultsPrefixKey:]): Deleted.
+(-[WKPreferences userDefaultsPrefixKey]): Deleted.
+
2014-03-31 Simon Fraser simon.fra...@apple.com
Enable WEB_TIMING on Mac and iOS
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h (166595 => 166596)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h 2014-04-01 17:08:54 UTC (rev 166595)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.h 2014-04-01 17:39:11 UTC (rev 166596)
@@ -35,9 +35,9 @@
WK_API_CLASS
@interface WKPreferences : NSObject
-- (instancetype)initWithUserDefaultsPrefixKey:(NSString *)userDefaultsPrefixKey WK_DESIGNATED_INITIALIZER;
+- (instancetype)initWithUserDefaultsKeyPrefix:(NSString *)userDefaultsKeyPrefix WK_DESIGNATED_INITIALIZER;
-@property (nonatomic, readonly) NSString *userDefaultsPrefixKey;
+@property (nonatomic, readonly) NSString *userDefaultsKeyPrefix;
@property (nonatomic) CGFloat minimumFontSize;
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (166595 => 166596)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-04-01 17:08:54 UTC (rev 166595)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2014-04-01 17:39:11 UTC (rev 166596)
@@ -33,28 +33,28 @@
@implementation WKPreferences
{
-RetainPtrNSString _userDefaultsPrefixKey;
+RetainPtrNSString _userDefaultsKeyPrefix;
}
- (instancetype)init
{
-return [self initWithUserDefaultsPrefixKey:nil];
+return [self initWithUserDefaultsKeyPrefix:nil];
}
-- (instancetype)initWithUserDefaultsPrefixKey:(NSString *)userDefaultsPrefixKey
+- (instancetype)initWithUserDefaultsKeyPrefix:(NSString *)userDefaultsKeyPrefix
{
if (!(self = [super init]))
return nil;
-_userDefaultsPrefixKey = adoptNS([userDefaultsPrefixKey copy]);
+_userDefaultsKeyPrefix = adoptNS([userDefaultsKeyPrefix copy]);
-_preferences = WebKit::WebPreferences::create(_userDefaultsPrefixKey.get(), WebKit);
+_preferences = WebKit::WebPreferences::create(_userDefaultsKeyPrefix.get(), WebKit);
return self;
}
-- (NSString *)userDefaultsPrefixKey
+- (NSString *)userDefaultsKeyPrefix
{
-return _userDefaultsPrefixKey.get();
+return _userDefaultsKeyPrefix.get();
}
- (CGFloat)minimumFontSize
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166597] trunk/Source/WebKit2
Title: [166597] trunk/Source/WebKit2
Revision 166597
Author akl...@apple.com
Date 2014-04-01 10:45:02 -0700 (Tue, 01 Apr 2014)
Log Message
Invalidate CFNetwork connection cache on memory pressure.
https://webkit.org/b/131038
Stop holding on to cached HTTP connections if we come under memory pressure.
Reviewed by Geoff Malloc-Garen.
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformLowMemoryHandler):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166596 => 166597)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 17:39:11 UTC (rev 166596)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 17:45:02 UTC (rev 166597)
@@ -1,3 +1,15 @@
+2014-04-01 Andreas Kling akl...@apple.com
+
+Invalidate CFNetwork connection cache on memory pressure.
+https://webkit.org/b/131038
+
+Stop holding on to cached HTTP connections if we come under memory pressure.
+
+Reviewed by Geoff Malloc-Garen.
+
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::NetworkProcess::platformLowMemoryHandler):
+
2014-04-01 Anders Carlsson ander...@apple.com
Tweak WKPreferences API
Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm (166596 => 166597)
--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2014-04-01 17:39:11 UTC (rev 166596)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2014-04-01 17:45:02 UTC (rev 166597)
@@ -38,6 +38,7 @@
typedef const struct _CFURLCache* CFURLCacheRef;
extern C CFURLCacheRef CFURLCacheCopySharedURLCache();
extern C void _CFURLCachePurgeMemoryCache(CFURLCacheRef);
+extern C void CFURLConnectionInvalidateConnectionCache();
#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED = 1090
extern C void _CFURLCacheSetMinSizeForVMCachedResource(CFURLCacheRef, CFIndex);
@@ -47,6 +48,7 @@
void NetworkProcess::platformLowMemoryHandler(bool)
{
+CFURLConnectionInvalidateConnectionCache();
_CFURLCachePurgeMemoryCache(adoptCF(CFURLCacheCopySharedURLCache()).get());
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166598] trunk/Source/WebKit2
Title: [166598] trunk/Source/WebKit2 Revision 166598 Author ander...@apple.com Date 2014-04-01 11:48:31 -0700 (Tue, 01 Apr 2014) Log Message Stub out the web process - UI process message SPI https://bugs.webkit.org/show_bug.cgi?id=131048 Reviewed by Sam Weinig. * UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView initWithFrame:configuration:]): * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: (-[WKWebViewConfiguration copyWithZone:]): (-[WKWebViewConfiguration _userContentController]): (-[WKWebViewConfiguration _setUserContentController:]): * UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: * UIProcess/API/Cocoa/WKWebViewPrivate.h: * UIProcess/API/Cocoa/_WKScriptMessage.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h. * UIProcess/API/Cocoa/_WKScriptMessage.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h. (-[_WKScriptMessage body]): (-[_WKScriptMessage originatingWebView]): * UIProcess/API/Cocoa/_WKScriptMessageHandler.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h. * UIProcess/API/Cocoa/_WKScriptWorld.h: * UIProcess/API/Cocoa/_WKUserContentController.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h. * UIProcess/API/Cocoa/_WKUserContentController.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h. (-[_WKUserContentController addScriptMessageHandler:name:world:]): (-[_WKUserContentController removeScriptMessageHandler:]): * WebKit2.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptMessage.h trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptMessage.mm trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKScriptMessageHandler.h trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentController.h trunk/Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentController.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (166597 => 166598) --- trunk/Source/WebKit2/ChangeLog 2014-04-01 17:45:02 UTC (rev 166597) +++ trunk/Source/WebKit2/ChangeLog 2014-04-01 18:48:31 UTC (rev 166598) @@ -1,3 +1,30 @@ +2014-04-01 Anders Carlsson ander...@apple.com + +Stub out the web process - UI process message SPI +https://bugs.webkit.org/show_bug.cgi?id=131048 + +Reviewed by Sam Weinig. + +* UIProcess/API/Cocoa/WKWebView.mm: +(-[WKWebView initWithFrame:configuration:]): +* UIProcess/API/Cocoa/WKWebViewConfiguration.mm: +(-[WKWebViewConfiguration copyWithZone:]): +(-[WKWebViewConfiguration _userContentController]): +(-[WKWebViewConfiguration _setUserContentController:]): +* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: +* UIProcess/API/Cocoa/WKWebViewPrivate.h: +* UIProcess/API/Cocoa/_WKScriptMessage.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h. +* UIProcess/API/Cocoa/_WKScriptMessage.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h. +(-[_WKScriptMessage body]): +(-[_WKScriptMessage originatingWebView]): +* UIProcess/API/Cocoa/_WKScriptMessageHandler.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h. +* UIProcess/API/Cocoa/_WKScriptWorld.h: +* UIProcess/API/Cocoa/_WKUserContentController.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKScriptWorld.h. +* UIProcess/API/Cocoa/_WKUserContentController.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h. +(-[_WKUserContentController addScriptMessageHandler:name:world:]): +(-[_WKUserContentController removeScriptMessageHandler:]): +* WebKit2.xcodeproj/project.pbxproj: + 2014-04-01 Andreas Kling akl...@apple.com Invalidate CFNetwork connection cache on memory pressure. Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (166597 => 166598) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-04-01 17:45:02 UTC (rev 166597) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-04-01 18:48:31 UTC (rev 166598) @@ -54,6 +54,7 @@ #import WebPageProxy.h #import WebProcessProxy.h #import _WKRemoteObjectRegistryInternal.h +#import _WKUserContentController.h #import _WKVisitedLinkProviderInternal.h #import wtf/RetainPtr.h @@ -132,6 +133,9 @@ if (![_configuration preferences]) [_configuration setPreferences:adoptNS([[WKPreferences alloc] init]).get()]; +if (![_configuration _userContentController]) +[_configuration _setUserContentController:adoptNS([[_WKUserContentController alloc]
[webkit-changes] [166600] trunk
Title: [166600] trunk Revision 166600 Author ddkil...@apple.com Date 2014-04-01 12:21:34 -0700 (Tue, 01 Apr 2014) Log Message Do not allow HTTP refresh headers to refresh to _javascript_: URLs http://webkit.org/b/119051 rdar://problem/14536453 Reviewed by Alexey Proskuryakov. Merged from Blink (patch by tse...@chromium.org): https://src.chromium.org/viewvc/blink?revision=153912view=revision http://crbug.com/258151 This behaviour has been standard in IE since IE7. This makes us both more compatible and less vulnerable to XSS. Source/WebCore: Tests: http/tests/security/no-_javascript_-location-percent-escaped.html http/tests/security/no-_javascript_-location.html http/tests/security/no-_javascript_-refresh-percent-escaped.php http/tests/security/no-_javascript_-refresh-spaces.php http/tests/security/no-_javascript_-refresh-static-percent-escaped.html http/tests/security/no-_javascript_-refresh-static-spaces.html http/tests/security/no-_javascript_-refresh-static.html http/tests/security/no-_javascript_-refresh.php * dom/Document.cpp: (WebCore::Document::processHttpEquiv): * loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): - Do not fire meta http refresh for a _javascript_: URL protocol. LayoutTests: * http/tests/security/no-_javascript_-refresh-expected.txt: Added. * http/tests/security/no-_javascript_-refresh-static-expected.txt: Added. * http/tests/security/no-_javascript_-refresh-static.html: Added. * http/tests/security/no-_javascript_-refresh.php: Added. - Original Blink layout tests with typos fixed and 'PASS:' text added. * http/tests/security/no-_javascript_-location.html: Added. * http/tests/security/no-_javascript_-location-expected.txt: Added. * http/tests/security/resources/no-_javascript_-location.php: Copied from LayoutTests/http/tests/security/no-_javascript_-refresh.php. * http/tests/security/no-_javascript_-location-percent-escaped.html: Added. * http/tests/security/no-_javascript_-location-percent-escaped-expected.txt: Added. * http/tests/security/resources/no-_javascript_-location-percent-escaped.php: Added. - Add tests using a _javascript_: URL in a Location: header. * http/tests/security/no-_javascript_-refresh-percent-escaped.php: Copied from LayoutTests/http/tests/security/no-_javascript_-refresh.php. * http/tests/security/no-_javascript_-refresh-percent-escaped-expected.txt: Added. * http/tests/security/no-_javascript_-refresh-spaces.php: Copied from LayoutTests/http/tests/security/no-_javascript_-refresh.php. * http/tests/security/no-_javascript_-refresh-spaces-expected.txt: Added. - Add tests using a percent-escaped _javascript_: URL and a _javascript_: URL with leading spaces in a Refresh: header from a web server. * http/tests/security/no-_javascript_-refresh-static-percent-escaped.html: Added. * http/tests/security/no-_javascript_-refresh-static-percent-escaped-expected.txt: Added. * http/tests/security/no-_javascript_-refresh-static-spaces.html: Added. * http/tests/security/no-_javascript_-refresh-static-spaces-expected.txt: Added. - Add tests using a percent-escaped _javascript_: URL and a _javascript_: URL with leading spaces in a meta http-equiv tag. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/loader/FrameLoader.cpp Added Paths trunk/LayoutTests/http/tests/security/no-_javascript_-location-expected.txt trunk/LayoutTests/http/tests/security/no-_javascript_-location-percent-escaped-expected.txt trunk/LayoutTests/http/tests/security/no-_javascript_-location-percent-escaped.html trunk/LayoutTests/http/tests/security/no-_javascript_-location.html trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-expected.txt trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-percent-escaped-expected.txt trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-percent-escaped.php trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-spaces-expected.txt trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-spaces.php trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-static-expected.txt trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-static-percent-escaped-expected.txt trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-static-percent-escaped.html trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-static-spaces-expected.txt trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-static-spaces.html trunk/LayoutTests/http/tests/security/no-_javascript_-refresh-static.html trunk/LayoutTests/http/tests/security/no-_javascript_-refresh.php trunk/LayoutTests/http/tests/security/resources/no-_javascript_-location-percent-escaped.php trunk/LayoutTests/http/tests/security/resources/no-_javascript_-location.php Diff Modified: trunk/LayoutTests/ChangeLog (166599 => 166600) --- trunk/LayoutTests/ChangeLog
[webkit-changes] [166601] trunk
Title: [166601] trunk
Revision 166601
Author dba...@webkit.org
Date 2014-04-01 12:38:13 -0700 (Tue, 01 Apr 2014)
Log Message
RenderQuote must destroy remaining text renderer before first letter renderer
https://bugs.webkit.org/show_bug.cgi?id=78023
rdar://problem/10830009
Reviewed by Brent Fulgham.
Merged from Blink (patch by Abhishek Arya):
https://src.chromium.org/viewvc/blink?view=revrevision=151270
Source/WebCore:
Following the fix for https://bugs.webkit.org/show_bug.cgi?id=114586, a
RenderQuote may have child render objects for the first letter of its text
and everything following the first letter so as to support the CSS first-
letter property. The latter renderer is responsible for destroying the former
on destruction. It's sufficient to reverse the destruction of the children of
RenderQuote to ensure that we destroy the remaining text renderer before we
destroy the first letter renderer.
Test: fast/css-generated-content/quote-first-letter-crash.html
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateText):
LayoutTests:
* fast/css-generated-content/quote-first-letter-crash-expected.txt: Added.
* fast/css-generated-content/quote-first-letter-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderQuote.cpp
Added Paths
trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash-expected.txt
trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166600 => 166601)
--- trunk/LayoutTests/ChangeLog 2014-04-01 19:21:34 UTC (rev 166600)
+++ trunk/LayoutTests/ChangeLog 2014-04-01 19:38:13 UTC (rev 166601)
@@ -1,3 +1,17 @@
+2014-04-01 Daniel Bates daba...@apple.com
+
+RenderQuote must destroy remaining text renderer before first letter renderer
+https://bugs.webkit.org/show_bug.cgi?id=78023
+rdar://problem/10830009
+
+Reviewed by Brent Fulgham.
+
+Merged from Blink (patch by Abhishek Arya):
+https://src.chromium.org/viewvc/blink?view=revrevision=151270
+
+* fast/css-generated-content/quote-first-letter-crash-expected.txt: Added.
+* fast/css-generated-content/quote-first-letter-crash.html: Added.
+
2014-04-01 David Kilzer ddkil...@apple.com
Do not allow HTTP refresh headers to refresh to _javascript_: URLs
Added: trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash-expected.txt (0 => 166601)
--- trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash-expected.txt 2014-04-01 19:38:13 UTC (rev 166601)
@@ -0,0 +1 @@
+PASS. Test didn't crash.
Added: trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html (0 => 166601)
--- trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html 2014-04-01 19:38:13 UTC (rev 166601)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+html
+style
+.class1::first-letter { position: inherit; }
+.class1:after { visibility: inherit; content: open-quote; }
+/style
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function crash() {
+element1 = document.createElement('hr');
+element1.setAttribute('class', 'class1');
+document.documentElement.appendChild(element1);
+element2 = document.createElement('td');
+element2.setAttribute('class', 'class1');
+document.documentElement.appendChild(element2);
+document.documentElement.offsetTop;
+document.open();
+document.write(PASS. Test didn't crash.);
+document.close();
+}
+window._onload_ = crash;
+/script
+/html
Property changes on: trunk/LayoutTests/fast/css-generated-content/quote-first-letter-crash.html
___
Added: svn:executable
Modified: trunk/Source/WebCore/ChangeLog (166600 => 166601)
--- trunk/Source/WebCore/ChangeLog 2014-04-01 19:21:34 UTC (rev 166600)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 19:38:13 UTC (rev 166601)
@@ -1,3 +1,27 @@
+2014-04-01 Daniel Bates daba...@apple.com
+
+RenderQuote must destroy remaining text renderer before first letter renderer
+https://bugs.webkit.org/show_bug.cgi?id=78023
+rdar://problem/10830009
+
+Reviewed by Brent Fulgham.
+
+Merged from Blink (patch by Abhishek Arya):
+https://src.chromium.org/viewvc/blink?view=revrevision=151270
+
+Following the fix for https://bugs.webkit.org/show_bug.cgi?id=114586, a
+RenderQuote may have child render objects for the first letter of its text
+and everything following the first letter so as to support the CSS first-
+letter property. The latter renderer is responsible for destroying the former
+on destruction. It's
[webkit-changes] [166602] trunk/Source/WebKit2
Title: [166602] trunk/Source/WebKit2
Revision 166602
Author ander...@apple.com
Date 2014-04-01 12:53:04 -0700 (Tue, 01 Apr 2014)
Log Message
Remove limits from WKBackForwardList getters
https://bugs.webkit.org/show_bug.cgi?id=131052
Reviewed by Beth Dakin.
* UIProcess/API/Cocoa/WKBackForwardList.h:
* UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList backList]):
(-[WKBackForwardList forwardList]):
(-[WKBackForwardList backListCount]): Deleted.
(-[WKBackForwardList forwardListCount]): Deleted.
(-[WKBackForwardList backListWithLimit:]): Deleted.
(-[WKBackForwardList forwardListWithLimit:]): Deleted.
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::backList):
(WebKit::WebBackForwardList::forwardList):
* UIProcess/WebBackForwardList.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm
trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp
trunk/Source/WebKit2/UIProcess/WebBackForwardList.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166601 => 166602)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 19:38:13 UTC (rev 166601)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 19:53:04 UTC (rev 166602)
@@ -1,5 +1,25 @@
2014-04-01 Anders Carlsson ander...@apple.com
+Remove limits from WKBackForwardList getters
+https://bugs.webkit.org/show_bug.cgi?id=131052
+
+Reviewed by Beth Dakin.
+
+* UIProcess/API/Cocoa/WKBackForwardList.h:
+* UIProcess/API/Cocoa/WKBackForwardList.mm:
+(-[WKBackForwardList backList]):
+(-[WKBackForwardList forwardList]):
+(-[WKBackForwardList backListCount]): Deleted.
+(-[WKBackForwardList forwardListCount]): Deleted.
+(-[WKBackForwardList backListWithLimit:]): Deleted.
+(-[WKBackForwardList forwardListWithLimit:]): Deleted.
+* UIProcess/WebBackForwardList.cpp:
+(WebKit::WebBackForwardList::backList):
+(WebKit::WebBackForwardList::forwardList):
+* UIProcess/WebBackForwardList.h:
+
+2014-04-01 Anders Carlsson ander...@apple.com
+
Stub out the web process - UI process message SPI
https://bugs.webkit.org/show_bug.cgi?id=131048
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h (166601 => 166602)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h 2014-04-01 19:38:13 UTC (rev 166601)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h 2014-04-01 19:53:04 UTC (rev 166602)
@@ -52,18 +52,15 @@
WK_API_CLASS
@interface WKBackForwardList : NSObject
-@property (readonly) WKBackForwardListItem *currentItem;
-@property (readonly) WKBackForwardListItem *backItem;
-@property (readonly) WKBackForwardListItem *forwardItem;
+@property (nonatomic, readonly) WKBackForwardListItem *currentItem;
+@property (nonatomic, readonly) WKBackForwardListItem *backItem;
+@property (nonatomic, readonly) WKBackForwardListItem *forwardItem;
- (WKBackForwardListItem *)itemAtIndex:(NSInteger)index;
-@property (readonly) NSUInteger backListCount;
-@property (readonly) NSUInteger forwardListCount;
+@property (nonatomic, readonly) NSArray *backList;
+@property (nonatomic, readonly) NSArray *forwardList;
-- (NSArray *)backListWithLimit:(NSUInteger)limit;
-- (NSArray *)forwardListWithLimit:(NSUInteger)limit;
-
@end
#endif // WK_API_ENABLED
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm (166601 => 166602)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm 2014-04-01 19:38:13 UTC (rev 166601)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm 2014-04-01 19:53:04 UTC (rev 166602)
@@ -76,28 +76,18 @@
return toWKBackForwardListItem(_list-itemAtIndex(index));
}
-- (NSUInteger)backListCount
+- (NSArray *)backList
{
-return _list-backListCount();
-}
-
-- (NSUInteger)forwardListCount
-{
-return _list-forwardListCount();
-}
-
-- (NSArray *)backListWithLimit:(NSUInteger)limit
-{
-RefPtrAPI::Array list = _list-backListAsAPIArrayWithLimit(limit);
+RefPtrAPI::Array list = _list-backList();
if (!list)
return nil;
return [wrapper(*list.release().leakRef()) autorelease];
}
-- (NSArray *)forwardListWithLimit:(NSUInteger)limit
+- (NSArray *)forwardList
{
-RefPtrAPI::Array list = _list-forwardListAsAPIArrayWithLimit(limit);
+RefPtrAPI::Array list = _list-forwardList();
if (!list)
return nil;
Modified: trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp (166601 => 166602)
--- trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2014-04-01 19:38:13 UTC (rev 166601)
+++ trunk/Source/WebKit2/UIProcess/WebBackForwardList.cpp 2014-04-01 19:53:04 UTC (rev 166602)
@@ -200,6 +200,16 @@
return m_page m_hasCurrentIndex ? m_entries.size() - (m_currentIndex + 1) : 0;
}
+PassRefPtrAPI::Array WebBackForwardList::backList() const
+{
+return
[webkit-changes] [166603] trunk
Title: [166603] trunk Revision 166603 Author mmaxfi...@apple.com Date 2014-04-01 13:05:08 -0700 (Tue, 01 Apr 2014) Log Message svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face-crash.html frequently assert in ComplexTextController::offsetForPosition https://bugs.webkit.org/show_bug.cgi?id=119747 Reviewed by Simon Fraser. Source/WebCore: Even though kerning and ligatures currently don't work with the simple text path, messing those up is better than creating null CTRun and CTLine objects. Rather than calling the badly-named renderingContext() function on TextRun objects to determine if they are drawn with an SVG font, this patch creates a wrapper function with a better name and uses that instead. Test: svg/text/svg-font-hittest.html * platform/graphics/Font.cpp: (WebCore::isDrawnWithSVGFont): Wrapper around renderingContext() (WebCore::Font::drawText): Use wrapper function (WebCore::Font::drawEmphasisMarks): Use wrapper function (WebCore::Font::width): Use wrapper function (WebCore::Font::selectionRectForText): Use wrapper function (WebCore::Font::offsetForPosition): If we are using an SVG font, use the simple path instead of the complex one (WebCore::Font::codePath): Use wrapper function * platform/graphics/cocoa/FontPlatformDataCocoa.mm: (WebCore::FontPlatformData::ctFont): LayoutTests: Clicking on SVG text used to cause a ComplexTextController to be built around the SVG text (which is incorrect and would crash). This test does just that and makes sure there is no crash. * svg/text/resources/Litherum.svg: Added. * svg/text/svg-font-hittest-expected.txt: Added. * svg/text/svg-font-hittest.html: Added. * LayoutTests/platform/mac/TestExpectations: Unskipped tests Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/Font.cpp trunk/Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm Added Paths trunk/LayoutTests/svg/text/resources/Litherum.svg trunk/LayoutTests/svg/text/svg-font-hittest-expected.txt trunk/LayoutTests/svg/text/svg-font-hittest.html Diff Modified: trunk/LayoutTests/ChangeLog (166602 => 166603) --- trunk/LayoutTests/ChangeLog 2014-04-01 19:53:04 UTC (rev 166602) +++ trunk/LayoutTests/ChangeLog 2014-04-01 20:05:08 UTC (rev 166603) @@ -1,3 +1,19 @@ +2014-04-01 Myles C. Maxfield mmaxfi...@apple.com + +svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face-crash.html frequently assert in ComplexTextController::offsetForPosition +https://bugs.webkit.org/show_bug.cgi?id=119747 + +Reviewed by Simon Fraser. + +Clicking on SVG text used to cause a ComplexTextController to be built +around the SVG text (which is incorrect and would crash). This test +does just that and makes sure there is no crash. + +* svg/text/resources/Litherum.svg: Added. +* svg/text/svg-font-hittest-expected.txt: Added. +* svg/text/svg-font-hittest.html: Added. +* LayoutTests/platform/mac/TestExpectations: Unskipped tests + 2014-04-01 Daniel Bates daba...@apple.com RenderQuote must destroy remaining text renderer before first letter renderer Modified: trunk/LayoutTests/platform/mac/TestExpectations (166602 => 166603) --- trunk/LayoutTests/platform/mac/TestExpectations 2014-04-01 19:53:04 UTC (rev 166602) +++ trunk/LayoutTests/platform/mac/TestExpectations 2014-04-01 20:05:08 UTC (rev 166603) @@ -1319,9 +1319,6 @@ webkit.org/b/122040 animations/combo-transform-translate+scale.html [ Pass Failure ] webkit.org/b/128379 animations/suspend-resume-animation.html [ Pass Failure ] -webkit.org/b/119747 [ Debug ] svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html [ Skip ] -webkit.org/b/119747 [ Debug ] svg/css/font-face-crash.html [ Skip ] - # Regressions in svg/clip-path webkit.org/b/128499 svg/clip-path/clip-path-content-use-005.svg [ ImageOnlyFailure ] webkit.org/b/128499 svg/clip-path/clip-path-precision-001.svg [ ImageOnlyFailure ] Added: trunk/LayoutTests/svg/text/resources/Litherum.svg (0 => 166603) --- trunk/LayoutTests/svg/text/resources/Litherum.svg (rev 0) +++ trunk/LayoutTests/svg/text/resources/Litherum.svg 2014-04-01 20:05:08 UTC (rev 166603) @@ -0,0 +1,11 @@ +?xml version=1.0 standalone=no? +!DOCTYPE svg PUBLIC -//W3C//DTD SVG 1.1//EN http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd +svg xmlns=http://www.w3.org/2000/svg +metadata/metadata +defs +font id=Litherum horiz-adv-x=1024 +font-face units-per-em=14 ascent=14 descent=-7/ +glyph unicode=| horiz-adv-x=14 d=M5 -7v21h4v-21z/ +/font +/defs +/svg Added: trunk/LayoutTests/svg/text/svg-font-hittest-expected.txt (0 => 166603) --- trunk/LayoutTests/svg/text/svg-font-hittest-expected.txt (rev 0) +++ trunk/LayoutTests/svg/text/svg-font-hittest-expected.txt 2014-04-01 20:05:08 UTC (rev 166603) @@ -0,0
[webkit-changes] [166604] trunk/Source/WebCore
Title: [166604] trunk/Source/WebCore
Revision 166604
Author benja...@webkit.org
Date 2014-04-01 13:32:33 -0700 (Tue, 01 Apr 2014)
Log Message
Remove a couple of useless static strings
https://bugs.webkit.org/show_bug.cgi?id=131003
Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-01
Reviewed by David Kilzer.
There is zero value in keeping those strings alive.
* css/StyleProperties.cpp:
(WebCore::isInitialOrInherit):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleProperties.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (166603 => 166604)
--- trunk/Source/WebCore/ChangeLog 2014-04-01 20:05:08 UTC (rev 166603)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 20:32:33 UTC (rev 166604)
@@ -1,3 +1,15 @@
+2014-04-01 Benjamin Poulain bpoul...@apple.com
+
+Remove a couple of useless static strings
+https://bugs.webkit.org/show_bug.cgi?id=131003
+
+Reviewed by David Kilzer.
+
+There is zero value in keeping those strings alive.
+
+* css/StyleProperties.cpp:
+(WebCore::isInitialOrInherit):
+
2014-04-01 Myles C. Maxfield mmaxfi...@apple.com
svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face-crash.html frequently assert in ComplexTextController::offsetForPosition
Modified: trunk/Source/WebCore/css/StyleProperties.cpp (166603 => 166604)
--- trunk/Source/WebCore/css/StyleProperties.cpp 2014-04-01 20:05:08 UTC (rev 166603)
+++ trunk/Source/WebCore/css/StyleProperties.cpp 2014-04-01 20:32:33 UTC (rev 166604)
@@ -50,9 +50,7 @@
static bool isInitialOrInherit(const String value)
{
-DEPRECATED_DEFINE_STATIC_LOCAL(String, initial, (initial));
-DEPRECATED_DEFINE_STATIC_LOCAL(String, inherit, (inherit));
-return value.length() == 7 (value == initial || value == inherit);
+return value.length() == 7 (value == initial || value == inherit);
}
PassRefImmutableStyleProperties ImmutableStyleProperties::create(const CSSProperty* properties, unsigned count, CSSParserMode cssParserMode)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166605] trunk/Source/WebKit2
Title: [166605] trunk/Source/WebKit2
Revision 166605
Author benja...@webkit.org
Date 2014-04-01 13:33:13 -0700 (Tue, 01 Apr 2014)
Log Message
[iOS][WK2] Remove the two finger pan gesture recognizer until it is actually implemented
https://bugs.webkit.org/show_bug.cgi?id=131009
Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-01
Reviewed by Sam Weinig.
The two finger pan should not block the pinch gesture recognizer.
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _twoFingerPanRecognized:]): Deleted.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166604 => 166605)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 20:32:33 UTC (rev 166604)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 20:33:13 UTC (rev 166605)
@@ -1,3 +1,19 @@
+2014-04-01 Benjamin Poulain bpoul...@apple.com
+
+[iOS][WK2] Remove the two finger pan gesture recognizer until it is actually implemented
+https://bugs.webkit.org/show_bug.cgi?id=131009
+
+Reviewed by Sam Weinig.
+
+The two finger pan should not block the pinch gesture recognizer.
+
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView setupInteraction]):
+(-[WKContentView cleanupInteraction]):
+(-[WKContentView gestureRecognizerShouldBegin:]):
+(-[WKContentView _twoFingerPanRecognized:]): Deleted.
+
2014-04-01 Anders Carlsson ander...@apple.com
Remove limits from WKBackForwardList getters
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (166604 => 166605)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h 2014-04-01 20:32:33 UTC (rev 166604)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h 2014-04-01 20:33:13 UTC (rev 166605)
@@ -86,7 +86,6 @@
RetainPtrUILongPressGestureRecognizer _longPressGestureRecognizer;
RetainPtrUITapGestureRecognizer _doubleTapGestureRecognizer;
RetainPtrUITapGestureRecognizer _twoFingerDoubleTapGestureRecognizer;
-RetainPtrUIPanGestureRecognizer _twoFingerPanGestureRecognizer;
RetainPtrUIWKTextInteractionAssistant _textSelectionAssistant;
RetainPtrUIWKSelectionAssistant _webSelectionAssistant;
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (166604 => 166605)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-04-01 20:32:33 UTC (rev 166604)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-04-01 20:33:13 UTC (rev 166605)
@@ -164,12 +164,6 @@
[_longPressGestureRecognizer setDelegate:self];
[self addGestureRecognizer:_longPressGestureRecognizer.get()];
-_twoFingerPanGestureRecognizer = adoptNS([[UIPanGestureRecognizer alloc] initWithTarget:self action:@selector(_twoFingerPanRecognized:)]);
-[_twoFingerPanGestureRecognizer setMinimumNumberOfTouches:2];
-[_twoFingerPanGestureRecognizer setMaximumNumberOfTouches:2];
-[_twoFingerPanGestureRecognizer setDelegate:self];
-[self addGestureRecognizer:_twoFingerPanGestureRecognizer.get()];
-
[[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(_resetShowingTextStyle:) name:UIMenuControllerDidHideMenuNotification object:nil];
_showingTextStyleOptions = NO;
@@ -190,7 +184,6 @@
[_doubleTapGestureRecognizer setDelegate:nil];
[_highlightLongPressGestureRecognizer setDelegate:nil];
[_longPressGestureRecognizer setDelegate:nil];
-[_twoFingerPanGestureRecognizer setDelegate:nil];
}
- (const InteractionInformationAtPosition)positionInformation
@@ -559,10 +552,6 @@
}
}
-if (gestureRecognizer == _twoFingerPanGestureRecognizer) {
-notImplemented();
-}
-
return YES;
}
@@ -663,11 +652,6 @@
_smartMagnificationController-handleResetMagnificationGesture(gestureRecognizer.location);
}
-- (void)_twoFingerPanRecognized:(UIPanGestureRecognizer *)gestureRecognizer
-{
-// FIXME: Add implementation.
-}
-
- (void)_attemptClickAtLocation:(CGPoint)location
{
// FIXME: Ideally, we should always provide some visual feedback on click. If a short tap did not trigger the
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166606] trunk/Source/WebKit2
Title: [166606] trunk/Source/WebKit2
Revision 166606
Author ander...@apple.com
Date 2014-04-01 13:35:47 -0700 (Tue, 01 Apr 2014)
Log Message
Pass a WKNavigationAction to the create UIDelegate method
https://bugs.webkit.org/show_bug.cgi?id=131053
Reviewed by Sam Weinig.
* UIProcess/API/Cocoa/WKUIDelegate.h:
* UIProcess/Cocoa/UIClient.h:
* UIProcess/Cocoa/UIClient.mm:
(WebKit::UIClient::setDelegate):
(WebKit::UIClient::createNewPage):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h
trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166605 => 166606)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 20:33:13 UTC (rev 166605)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 20:35:47 UTC (rev 166606)
@@ -1,3 +1,16 @@
+2014-04-01 Anders Carlsson ander...@apple.com
+
+Pass a WKNavigationAction to the create UIDelegate method
+https://bugs.webkit.org/show_bug.cgi?id=131053
+
+Reviewed by Sam Weinig.
+
+* UIProcess/API/Cocoa/WKUIDelegate.h:
+* UIProcess/Cocoa/UIClient.h:
+* UIProcess/Cocoa/UIClient.mm:
+(WebKit::UIClient::setDelegate):
+(WebKit::UIClient::createNewPage):
+
2014-04-01 Benjamin Poulain bpoul...@apple.com
[iOS][WK2] Remove the two finger pan gesture recognizer until it is actually implemented
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h (166605 => 166606)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h 2014-04-01 20:33:13 UTC (rev 166605)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegate.h 2014-04-01 20:35:47 UTC (rev 166606)
@@ -36,9 +36,7 @@
@optional
-// FIXME: Maybe we should pass a WKNavigationAction instead of request and frame.
-// The C SPI has the key modifiers and mouse button as well.
-- (WKWebView *)webView:(WKWebView *)webView createWebViewWithConfiguration:(WKWebViewConfiguration *)configuration request:(NSURLRequest *)request windowFeatures:(WKWindowFeatures *)windowFeatures initiatedByFrame:(WKFrameInfo *)frame;
+- (WKWebView *)webView:(WKWebView *)webView createWebViewWithConfiguration:(WKWebViewConfiguration *)configuration forNavigationAction:(WKNavigationAction *)navigationAction windowFeatures:(WKWindowFeatures *)windowFeatures;
- (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)())completionHandler;
Modified: trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h (166605 => 166606)
--- trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h 2014-04-01 20:33:13 UTC (rev 166605)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.h 2014-04-01 20:35:47 UTC (rev 166606)
@@ -61,7 +61,7 @@
WeakObjCPtrid WKUIDelegate m_delegate;
struct {
-bool webViewCreateWebViewWithConfigurationRequestWindowFeaturesInitiatedByFrame : 1;
+bool webViewCreateWebViewWithConfigurationForNavigationActionWindowFeatures : 1;
bool webViewRunJavaScriptAlertPanelWithMessageInitiatedByFrameCompletionHandler : 1;
bool webViewRunJavaScriptConfirmPanelWithMessageInitiatedByFrameCompletionHandler : 1;
bool webViewRunJavaScriptTextInputPanelWithPromptDefaultTextInitiatedByFrameCompletionHandler : 1;
Modified: trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.mm (166605 => 166606)
--- trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.mm 2014-04-01 20:33:13 UTC (rev 166605)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/UIClient.mm 2014-04-01 20:35:47 UTC (rev 166606)
@@ -29,6 +29,7 @@
#if WK_API_ENABLED
#import WKFrameInfoInternal.h
+#import WKNavigationActionInternal.h
#import WKWebViewConfigurationInternal.h
#import WKWebViewInternal.h
#import WKWindowFeaturesInternal.h
@@ -54,7 +55,7 @@
{
m_delegate = delegate;
-m_delegateMethods.webViewCreateWebViewWithConfigurationRequestWindowFeaturesInitiatedByFrame = [delegate respondsToSelector:@selector(webView:createWebViewWithConfiguration:request:windowFeatures:initiatedByFrame:)];
+m_delegateMethods.webViewCreateWebViewWithConfigurationForNavigationActionWindowFeatures = [delegate respondsToSelector:@selector(webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:)];
m_delegateMethods.webViewRunJavaScriptAlertPanelWithMessageInitiatedByFrameCompletionHandler = [delegate respondsToSelector:@selector(webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:)];
m_delegateMethods.webViewRunJavaScriptConfirmPanelWithMessageInitiatedByFrameCompletionHandler = [delegate respondsToSelector:@selector(webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:)];
m_delegateMethods.webViewRunJavaScriptTextInputPanelWithPromptDefaultTextInitiatedByFrameCompletionHandler = [delegate
[webkit-changes] [166607] trunk/Source/WebKit2
Title: [166607] trunk/Source/WebKit2
Revision 166607
Author timothy_hor...@apple.com
Date 2014-04-01 13:47:18 -0700 (Tue, 01 Apr 2014)
Log Message
[iOS WebKit2] Partial repaint is broken
https://bugs.webkit.org/show_bug.cgi?id=131056
Reviewed by Dean Jackson.
* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::display):
We need to check if the repaint rects themselves cover the whole
layer's surface, not just their bounds. Otherwise, we'll optimize
out the back-front copy and end up not painting the whole layer.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166606 => 166607)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 20:35:47 UTC (rev 166606)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 20:47:18 UTC (rev 166607)
@@ -1,3 +1,16 @@
+2014-04-01 Tim Horton timothy_hor...@apple.com
+
+[iOS WebKit2] Partial repaint is broken
+https://bugs.webkit.org/show_bug.cgi?id=131056
+
+Reviewed by Dean Jackson.
+
+* Shared/mac/RemoteLayerBackingStore.mm:
+(WebKit::RemoteLayerBackingStore::display):
+We need to check if the repaint rects themselves cover the whole
+layer's surface, not just their bounds. Otherwise, we'll optimize
+out the back-front copy and end up not painting the whole layer.
+
2014-04-01 Anders Carlsson ander...@apple.com
Pass a WKNavigationAction to the create UIDelegate method
Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm (166606 => 166607)
--- trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm 2014-04-01 20:35:47 UTC (rev 166606)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm 2014-04-01 20:47:18 UTC (rev 166607)
@@ -180,7 +180,7 @@
scaledSize.scale(m_scale);
IntSize expandedScaledSize = expandedIntSize(scaledSize);
-bool willPaintEntireBackingStore = m_dirtyRegion.bounds().contains(layerBounds);
+bool willPaintEntireBackingStore = m_dirtyRegion.contains(layerBounds);
#if USE(IOSURFACE)
if (m_acceleratesDrawing) {
std::swap(m_frontSurface, m_backSurface);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166608] trunk/Tools
Title: [166608] trunk/Tools
Revision 166608
Author lforsch...@apple.com
Date 2014-04-01 14:09:04 -0700 (Tue, 01 Apr 2014)
Log Message
Add a 32bit JSC builder/tester.
https://bugs.webkit.org/show_bug.cgi?id=131054
Reviewed by Michael Saboff.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(Compile32bitJSC):
(Run32bitJSCTests):
(Run32bitJSCTests.countFailures):
(BuildAndTest32bitJSCFactory):
(BuildAndTest32bitJSCFactory.__init__):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (166607 => 166608)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-04-01 20:47:18 UTC (rev 166607)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-04-01 21:09:04 UTC (rev 166608)
@@ -13,6 +13,7 @@
{ name: apple-mini-210, platform: mac-mountainlion},
{ name: apple-mini-218, platform: mac-mountainlion},
+{ name: apple-mac-114, platform: mac-mavericks},
{ name: apple-mini-129, platform: mac-mavericks},
{ name: apple-mini-130, platform: mac-mavericks},
{ name: apple-mini-137, platform: mac-mavericks},
@@ -99,6 +100,10 @@
platform: mac-mavericks, configuration: debug, architectures: [x86_64],
slavenames: [apple-mini-180]
},
+{ name: Apple Mavericks 32-bit JSC (BuildAndTest), type: BuildAndTest32bitJSC, builddir: mavericks-32bitJSC-debug,
+ platform: mac-mavericks, configuration: debug, architectures: [x86_64],
+ slavenames: [apple-mac-114]
+},
{ name: Apple Mavericks Release (Build), type: Build, builddir: mavericks-release,
platform: mac-mavericks, configuration: release, architectures: [x86_64],
triggers: [mavericks-release-tests-wk1, mavericks-release-tests-wk2, mavericks-release-perf],
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (166607 => 166608)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-04-01 20:47:18 UTC (rev 166607)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2014-04-01 21:09:04 UTC (rev 166608)
@@ -233,6 +233,8 @@
class CompileLLINTCLoop(CompileWebKit):
command = [perl, ./Tools/Scripts/build-jsc, --cloop, WithProperties(--%(configuration)s)]
+class Compile32bitJSC(CompileWebKit):
+command = [perl, ./Tools/Scripts/build-jsc, --32-bit, WithProperties(--%(configuration)s)]
class CompileWebKit1Only(CompileWebKit):
command = [perl, ./Tools/Scripts/build-webkit, --no-webkit2, WithProperties(--%(configuration)s)]
@@ -562,6 +564,25 @@
return 0
+class Run32bitJSCTests(TestWithFailureCount):
+name = webkit-32bit-jsc-test
+description = [32bit-jsc-tests running]
+descriptionDone = [32bit-jsc-tests]
+command = [perl, ./Tools/Scripts/run-_javascript_core-tests, --32-bit, --no-build, WithProperties(--%(configuration)s)]
+failedTestsFormatString = %d regressions found.
+
+def countFailures(self, cmd):
+logText = cmd.logs['stdio'].getText()
+# We're looking for the line that looks like this: 0 regressions found.\n0 tests fixed.
+regex = re.compile(r'(?Pcount\d+) regressions found.')
+for line in logText.splitlines():
+match = regex.match(line)
+if not match:
+continue
+return int(match.group('count'))
+return 0
+
+
class RunBindingsTests(shell.Test):
name = bindings-generation-tests
description = [bindings-tests running]
@@ -862,6 +883,12 @@
self.addStep(CompileLLINTCLoop())
self.addStep(RunLLINTCLoopTests())
+class BuildAndTest32bitJSCFactory(Factory):
+def __init__(self, platform, configuration, architectures, triggers=None, additionalArguments=None, SVNMirror=None, **kwargs):
+Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, SVNMirror, **kwargs)
+self.addStep(Compile32bitJSC())
+self.addStep(Run32bitJSCTests())
+
class BuildAndTestWebKit2Factory(BuildAndTestFactory):
CompileClass = CompileWebKit
LayoutTestClass = RunWebKit2Tests
Modified: trunk/Tools/ChangeLog (166607 => 166608)
--- trunk/Tools/ChangeLog 2014-04-01 20:47:18 UTC (rev 166607)
+++ trunk/Tools/ChangeLog 2014-04-01 21:09:04 UTC (rev 166608)
@@ -1,3 +1,18 @@
+2014-04-01 Lucas Forschler lforsch...@apple.com
+
+Add a 32bit JSC builder/tester.
+https://bugs.webkit.org/show_bug.cgi?id=131054
+
+Reviewed by Michael
[webkit-changes] [166609] trunk/Tools
Title: [166609] trunk/Tools Revision 166609 Author r...@igalia.com Date 2014-04-01 14:21:41 -0700 (Tue, 01 Apr 2014) Log Message [GTK] Remove last reference to GTK+ WK1 EWS https://bugs.webkit.org/show_bug.cgi?id=131058 Reviewed by Martin Robinson. In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing. * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS. Modified Paths trunk/Tools/ChangeLog trunk/Tools/QueueStatusServer/config/queues.py Diff Modified: trunk/Tools/ChangeLog (166608 => 166609) --- trunk/Tools/ChangeLog 2014-04-01 21:09:04 UTC (rev 166608) +++ trunk/Tools/ChangeLog 2014-04-01 21:21:41 UTC (rev 166609) @@ -1,3 +1,14 @@ +2014-04-01 Manuel Rego Casasnovas r...@igalia.com + +[GTK] Remove last reference to GTK+ WK1 EWS +https://bugs.webkit.org/show_bug.cgi?id=131058 + +Reviewed by Martin Robinson. + +In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing. + +* QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS. + 2014-04-01 Lucas Forschler lforsch...@apple.com Add a 32bit JSC builder/tester. Modified: trunk/Tools/QueueStatusServer/config/queues.py (166608 => 166609) --- trunk/Tools/QueueStatusServer/config/queues.py 2014-04-01 21:09:04 UTC (rev 166608) +++ trunk/Tools/QueueStatusServer/config/queues.py 2014-04-01 21:21:41 UTC (rev 166609) @@ -30,7 +30,6 @@ all_queue_names = [ commit-queue, style-queue, -gtk-ews, gtk-wk2-ews, mac-ews, mac-wk2-ews, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166610] trunk/LayoutTests
Title: [166610] trunk/LayoutTests
Revision 166610
Author commit-qu...@webkit.org
Date 2014-04-01 14:22:56 -0700 (Tue, 01 Apr 2014)
Log Message
[CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a reftest
https://bugs.webkit.org/show_bug.cgi?id=130935
Patch by Javier Fernandez jfernan...@igalia.com on 2014-04-01
Reviewed by Darin Adler.
Removed the 'checkLayout' script references from the test.
* fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.html: Added.
* fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.txt: Removed.
* fast/css-grid-layout/grid-item-margin-auto-columns-rows.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows.html
Added Paths
trunk/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.html
Removed Paths
trunk/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (166609 => 166610)
--- trunk/LayoutTests/ChangeLog 2014-04-01 21:21:41 UTC (rev 166609)
+++ trunk/LayoutTests/ChangeLog 2014-04-01 21:22:56 UTC (rev 166610)
@@ -1,3 +1,16 @@
+2014-04-01 Javier Fernandez jfernan...@igalia.com
+
+[CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a reftest
+https://bugs.webkit.org/show_bug.cgi?id=130935
+
+Reviewed by Darin Adler.
+
+Removed the 'checkLayout' script references from the test.
+
+* fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.html: Added.
+* fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.txt: Removed.
+* fast/css-grid-layout/grid-item-margin-auto-columns-rows.html:
+
2014-04-01 Myles C. Maxfield mmaxfi...@apple.com
svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face-crash.html frequently assert in ComplexTextController::offsetForPosition
Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.html (0 => 166610)
--- trunk/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-margin-auto-columns-rows-expected.html 2014-04-01 21:22:56 UTC (rev 166610)
@@ -0,0 +1,199 @@
+!DOCTYPE html
+html
+style
+.grid {
+ display: block;
+ background-color: grey;
+ width: 200px;
+}
+
+.gridLong {
+ height: 120px;
+}
+
+.gridShort {
+ height: 100px;
+}
+
+.firstRowFirstColumn {
+ background-color: blue;
+ position: absolute;
+}
+
+.firstRowSecondColumn {
+ background-color: lime;
+ position: absolute;
+}
+
+.secondRowFirstColumn {
+ background-color: purple;
+ position: absolute;
+}
+
+.secondRowSecondColumn {
+ background-color: orange;
+ position: absolute;
+ left: 20px;
+}
+
+.gridItem {
+width: 20px;
+height: 40px;
+}
+
+.testContainer {
+position: relative;
+margin-bottom: 20px;
+}
+/style
+/head
+body
+
+divThis test checks that the grid's rows and columns 'auto' sizes are updated accordingly to its grid-item's before and start margins./div
+
+div class=testContainer
+div class=grid gridLong
+div class=gridItem firstRowFirstColumn style=top: 20px;/div
+div class=gridItem firstRowSecondColumn style=left: 20px;/div
+div class=gridItem secondRowFirstColumn style=top: 60px;/div
+div class=gridItem secondRowSecondColumn style=left: 20px; top: 60px;/div
+/div
+/div
+
+div class=testContainer
+div class=grid gridShort
+div class=gridItem firstRowFirstColumn style=top: 20px;/div
+div class=gridItem firstRowSecondColumn style=left: 20px;/div
+div class=gridItem secondRowFirstColumn style=top: 60px;/div
+div class=gridItem secondRowSecondColumn style=left: 20px; top: 60px;/div
+/div
+/div
+
+div class=testContainer
+div class=grid gridLong
+div class=gridItem firstRowFirstColumn style=left: 180px; top: 20px;/div
+div class=gridItem firstRowSecondColumn style=left: 180px; top: 60px;/div
+div class=gridItem secondRowFirstColumn style=left: 160px;/div
+div class=gridItem secondRowSecondColumn style=left: 160px; top: 60px;/div
+/div
+/div
+
+div class=testContainer
+div class=grid gridShort
+div class=gridItem firstRowFirstColumn style=left: 180px; top: 20px;/div
+div class=gridItem firstRowSecondColumn style=left: 180px; top: 60px;/div
+div class=gridItem secondRowFirstColumn style=left: 160px;/div
+div class=gridItem secondRowSecondColumn style=left: 160px; top: 60px;/div
+/div
+/div
+
+div class=testContainer
+div class=grid gridLong
+div class=gridItem firstRowFirstColumn style=top: 20px;/div
+div class=gridItem firstRowSecondColumn style=top: 60px;/div
+div class=gridItem secondRowFirstColumn style=left:
[webkit-changes] [166611] trunk/Source/WebKit2
Title: [166611] trunk/Source/WebKit2 Revision 166611 Author simon.fra...@apple.com Date 2014-04-01 14:27:35 -0700 (Tue, 01 Apr 2014) Log Message Remove some explicit template instantiations from logging code https://bugs.webkit.org/show_bug.cgi?id=131065 Reviewed by Tim Horton. No need to explicitly state template types. * Shared/mac/RemoteLayerTreeTransaction.mm: (WebKit::dumpChangedLayers): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm Diff Modified: trunk/Source/WebKit2/ChangeLog (166610 => 166611) --- trunk/Source/WebKit2/ChangeLog 2014-04-01 21:22:56 UTC (rev 166610) +++ trunk/Source/WebKit2/ChangeLog 2014-04-01 21:27:35 UTC (rev 166611) @@ -1,3 +1,15 @@ +2014-04-01 Simon Fraser simon.fra...@apple.com + +Remove some explicit template instantiations from logging code +https://bugs.webkit.org/show_bug.cgi?id=131065 + +Reviewed by Tim Horton. + +No need to explicitly state template types. + +* Shared/mac/RemoteLayerTreeTransaction.mm: +(WebKit::dumpChangedLayers): + 2014-04-01 Tim Horton timothy_hor...@apple.com [iOS WebKit2] Partial repaint is broken Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm (166610 => 166611) --- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2014-04-01 21:22:56 UTC (rev 166610) +++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2014-04-01 21:27:35 UTC (rev 166611) @@ -913,100 +913,100 @@ ts (layer layerID; if (layerProperties.changedProperties RemoteLayerTreeTransaction::NameChanged) -dumpPropertyString(ts, name, layerProperties.name); +dumpProperty(ts, name, layerProperties.name); if (layerProperties.changedProperties RemoteLayerTreeTransaction::ChildrenChanged) dumpPropertyVectorGraphicsLayer::PlatformLayerID(ts, children, layerProperties.children); if (layerProperties.changedProperties RemoteLayerTreeTransaction::PositionChanged) -dumpPropertyFloatPoint3D(ts, position, layerProperties.position); +dumpProperty(ts, position, layerProperties.position); if (layerProperties.changedProperties RemoteLayerTreeTransaction::SizeChanged) -dumpPropertyFloatSize(ts, size, layerProperties.size); +dumpProperty(ts, size, layerProperties.size); if (layerProperties.changedProperties RemoteLayerTreeTransaction::AnchorPointChanged) -dumpPropertyFloatPoint3D(ts, anchorPoint, layerProperties.anchorPoint); +dumpProperty(ts, anchorPoint, layerProperties.anchorPoint); if (layerProperties.changedProperties RemoteLayerTreeTransaction::BackgroundColorChanged) -dumpPropertyColor(ts, backgroundColor, layerProperties.backgroundColor); +dumpProperty(ts, backgroundColor, layerProperties.backgroundColor); if (layerProperties.changedProperties RemoteLayerTreeTransaction::BorderColorChanged) -dumpPropertyColor(ts, borderColor, layerProperties.borderColor); +dumpProperty(ts, borderColor, layerProperties.borderColor); if (layerProperties.changedProperties RemoteLayerTreeTransaction::BorderWidthChanged) -dumpPropertyfloat(ts, borderWidth, layerProperties.borderWidth); +dumpProperty(ts, borderWidth, layerProperties.borderWidth); if (layerProperties.changedProperties RemoteLayerTreeTransaction::OpacityChanged) -dumpPropertyfloat(ts, opacity, layerProperties.opacity); +dumpProperty(ts, opacity, layerProperties.opacity); if (layerProperties.changedProperties RemoteLayerTreeTransaction::TransformChanged) -dumpPropertyTransformationMatrix(ts, transform, layerProperties.transform ? *layerProperties.transform : TransformationMatrix()); +dumpProperty(ts, transform, layerProperties.transform ? *layerProperties.transform : TransformationMatrix()); if (layerProperties.changedProperties RemoteLayerTreeTransaction::SublayerTransformChanged) -dumpPropertyTransformationMatrix(ts, sublayerTransform, layerProperties.sublayerTransform ? *layerProperties.sublayerTransform : TransformationMatrix()); +dumpProperty(ts, sublayerTransform, layerProperties.sublayerTransform ? *layerProperties.sublayerTransform : TransformationMatrix()); if (layerProperties.changedProperties RemoteLayerTreeTransaction::HiddenChanged) -dumpPropertybool(ts, hidden, layerProperties.hidden); +dumpProperty(ts, hidden, layerProperties.hidden); if (layerProperties.changedProperties RemoteLayerTreeTransaction::GeometryFlippedChanged) -dumpPropertybool(ts, geometryFlipped, layerProperties.geometryFlipped); +dumpProperty(ts, geometryFlipped, layerProperties.geometryFlipped); if
[webkit-changes] [166612] trunk/Source/WebKit2
Title: [166612] trunk/Source/WebKit2
Revision 166612
Author aes...@apple.com
Date 2014-04-01 14:29:48 -0700 (Tue, 01 Apr 2014)
Log Message
[Cocoa] Add SPI to determine if a WKWebView is displaying a PDF
https://bugs.webkit.org/show_bug.cgi?id=131063
Reviewed by Tim Horton.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _isDisplayingPDF]):
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166611 => 166612)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 21:27:35 UTC (rev 166611)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 21:29:48 UTC (rev 166612)
@@ -1,3 +1,14 @@
+2014-04-01 Andy Estes aes...@apple.com
+
+[Cocoa] Add SPI to determine if a WKWebView is displaying a PDF
+https://bugs.webkit.org/show_bug.cgi?id=131063
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _isDisplayingPDF]):
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
2014-04-01 Simon Fraser simon.fra...@apple.com
Remove some explicit template instantiations from logging code
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (166611 => 166612)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-04-01 21:27:35 UTC (rev 166611)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-04-01 21:29:48 UTC (rev 166612)
@@ -59,6 +59,7 @@
#import wtf/RetainPtr.h
#if PLATFORM(IOS)
+#import WKPDFView.h
#import WKScrollView.h
#import WKWebViewContentProviderRegistry.h
#import UIKit/UIPeripheralHost_Private.h
@@ -1178,6 +1179,11 @@
});
}
+- (BOOL)_isDisplayingPDF
+{
+return [_customContentView isKindOfClass:[WKPDFView class]];
+}
+
#else
#pragma mark - OS X-specific methods
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h (166611 => 166612)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2014-04-01 21:27:35 UTC (rev 166611)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2014-04-01 21:29:48 UTC (rev 166612)
@@ -90,6 +90,8 @@
// This is deprecated and should be removed entirely: rdar://problem/16294704.
@property (readonly) UIColor *_pageExtendedBackgroundColor;
+@property (nonatomic, readonly, getter=_isDisplayingPDF) BOOL _displayingPDF;
+
- (void)_beginInteractiveObscuredInsetsChange;
- (void)_endInteractiveObscuredInsetsChange;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166613] trunk/Source/WebKit2
Title: [166613] trunk/Source/WebKit2
Revision 166613
Author ander...@apple.com
Date 2014-04-01 14:35:54 -0700 (Tue, 01 Apr 2014)
Log Message
Demote WKBackForwardListDidChangeNotification to SPI
https://bugs.webkit.org/show_bug.cgi?id=131059
Reviewed by Dan Bernstein.
* UIProcess/API/Cocoa/WKBackForwardList.h:
* UIProcess/API/Cocoa/WKBackForwardList.mm:
* UIProcess/API/Cocoa/WKBackForwardListInternal.h:
* UIProcess/API/Cocoa/WKBackForwardListPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h.
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::LoaderClient::didChangeBackForwardList):
* WebKit2.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h
trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListPrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166612 => 166613)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 21:29:48 UTC (rev 166612)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 21:35:54 UTC (rev 166613)
@@ -1,3 +1,18 @@
+2014-04-01 Anders Carlsson ander...@apple.com
+
+Demote WKBackForwardListDidChangeNotification to SPI
+https://bugs.webkit.org/show_bug.cgi?id=131059
+
+Reviewed by Dan Bernstein.
+
+* UIProcess/API/Cocoa/WKBackForwardList.h:
+* UIProcess/API/Cocoa/WKBackForwardList.mm:
+* UIProcess/API/Cocoa/WKBackForwardListInternal.h:
+* UIProcess/API/Cocoa/WKBackForwardListPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h.
+* UIProcess/Cocoa/NavigationState.mm:
+(WebKit::NavigationState::LoaderClient::didChangeBackForwardList):
+* WebKit2.xcodeproj/project.pbxproj:
+
2014-04-01 Andy Estes aes...@apple.com
[Cocoa] Add SPI to determine if a WKWebView is displaying a PDF
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h (166612 => 166613)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h 2014-04-01 21:29:48 UTC (rev 166612)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h 2014-04-01 21:35:54 UTC (rev 166613)
@@ -29,26 +29,7 @@
#import WebKit2/WKBackForwardListItem.h
-/*! Posted when a back-forward list changes. The notification object is the WKBackForwardList
-that changed. The codeuserInfo/code dictionary may contain the
-@link WKBackForwardListAddedItemKey @/link and @link WKBackForwardListRemovedItemsKey @/link
-keys.
-*/
-WK_EXTERN NSString * const WKBackForwardListDidChangeNotification;
-/*! A key in the codeuserInfo/code dictionary of a
-@link WKBackForwardListDidChangeNotification @/link, whose value is the
-@link WKBackForwardListItem @/link that was appended to the list.
-*/
-WK_EXTERN NSString * const WKBackForwardListAddedItemKey;
-
-
-/*! A key in the codeuserInfo/code dictionary of a
-@link WKBackForwardListDidChangeNotification @/link, whose value is an NSArray of
-@link WKBackForwardListItem@/link instances that were removed from the list.
-*/
-WK_EXTERN NSString * const WKBackForwardListRemovedItemsKey;
-
WK_API_CLASS
@interface WKBackForwardList : NSObject
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm (166612 => 166613)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm 2014-04-01 21:29:48 UTC (rev 166612)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm 2014-04-01 21:35:54 UTC (rev 166613)
@@ -31,10 +31,12 @@
#import WKBackForwardListItemInternal.h
#import WKNSArray.h
-NSString * const WKBackForwardListDidChangeNotification = @WKBackForwardListDidChangeNotification;
-NSString * const WKBackForwardListAddedItemKey = @WKBackForwardListAddedItemKey;
-NSString * const WKBackForwardListRemovedItemsKey = @WKBackForwardListRemovedItemsKey;
+// FIXME: Remove this when nobody depends on it.
+WK_EXTERN NSString * const WKBackForwardListDidChangeNotification;
+NSString * const WKBackForwardListDidChangeNotification = @_WKBackForwardListDidChangeNotification;
+NSString * const _WKBackForwardListDidChangeNotification = @_WKBackForwardListDidChangeNotification;
+
using namespace WebKit;
@implementation WKBackForwardList {
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h (166612 => 166613)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h 2014-04-01 21:29:48 UTC (rev 166612)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardListInternal.h 2014-04-01 21:35:54 UTC (rev 166613)
@@ -23,7 +23,7 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-#import WKBackForwardList.h
+#import WKBackForwardListPrivate.h
#if
[webkit-changes] [166614] trunk
Title: [166614] trunk
Revision 166614
Author r...@igalia.com
Date 2014-04-01 14:57:12 -0700 (Tue, 01 Apr 2014)
Log Message
[CSS Grid Layout] Enable runtime feature if feature flag is enabled
https://bugs.webkit.org/show_bug.cgi?id=130013
Reviewed by Simon Fraser.
Source/WebKit/mac:
Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Source/WebKit2:
Enable CSS Grid Layout runtime feature when ENABLE_CSS_GRID_LAYOUT flag is true.
* Shared/WebPreferencesStore.h:
LayoutTests:
Modify layout test as feature is not disabled by default in WK2.
The test now checks that the runtime feature can be disabled.
* fast/css-grid-layout/grid-disabled-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-disabled-by-default-expected.txt.
* fast/css-grid-layout/grid-disabled.html: Renamed from LayoutTests/fast/css-grid-layout/grid-disabled-by-default.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebPreferences.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesStore.h
Added Paths
trunk/LayoutTests/fast/css-grid-layout/grid-disabled-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-disabled.html
Removed Paths
trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166613 => 166614)
--- trunk/LayoutTests/ChangeLog 2014-04-01 21:35:54 UTC (rev 166613)
+++ trunk/LayoutTests/ChangeLog 2014-04-01 21:57:12 UTC (rev 166614)
@@ -1,3 +1,16 @@
+2014-04-01 Manuel Rego Casasnovas r...@igalia.com
+
+[CSS Grid Layout] Enable runtime feature if feature flag is enabled
+https://bugs.webkit.org/show_bug.cgi?id=130013
+
+Reviewed by Simon Fraser.
+
+Modify layout test as feature is not disabled by default in WK2.
+The test now checks that the runtime feature can be disabled.
+
+* fast/css-grid-layout/grid-disabled-expected.txt: Renamed from LayoutTests/fast/css-grid-layout/grid-disabled-by-default-expected.txt.
+* fast/css-grid-layout/grid-disabled.html: Renamed from LayoutTests/fast/css-grid-layout/grid-disabled-by-default.html.
+
2014-04-01 Javier Fernandez jfernan...@igalia.com
[CSS Grid Layout] Make the grid-item-margin-auto-columns-rows.html test a reftest
Deleted: trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default-expected.txt (166613 => 166614)
--- trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default-expected.txt 2014-04-01 21:35:54 UTC (rev 166613)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default-expected.txt 2014-04-01 21:57:12 UTC (rev 166614)
@@ -1,10 +0,0 @@
-Verifies that display: -webkit-grid does nothing by default.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS document.getElementById('grid').style.display is ''
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default.html (166613 => 166614)
--- trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default.html 2014-04-01 21:35:54 UTC (rev 166613)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default.html 2014-04-01 21:57:12 UTC (rev 166614)
@@ -1,14 +0,0 @@
-!DOCTYPE html
-html
-body
-div id=grid style=display: -webkit-grid/div
-
-script src=""
-script
-description(Verifies that display: -webkit-grid does nothing by default.);
-
-shouldBe(document.getElementById('grid').style.display, '');
-/script
-script src=""
-/body
-/html
\ No newline at end of file
Copied: trunk/LayoutTests/fast/css-grid-layout/grid-disabled-expected.txt (from rev 166613, trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default-expected.txt) (0 => 166614)
--- trunk/LayoutTests/fast/css-grid-layout/grid-disabled-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-disabled-expected.txt 2014-04-01 21:57:12 UTC (rev 166614)
@@ -0,0 +1,10 @@
+Verifies that display: -webkit-grid does nothing if runtime feature is disabled.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS document.getElementById('grid').style.display is ''
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: trunk/LayoutTests/fast/css-grid-layout/grid-disabled.html (from rev 166613, trunk/LayoutTests/fast/css-grid-layout/grid-disabled-by-default.html) (0 => 166614)
--- trunk/LayoutTests/fast/css-grid-layout/grid-disabled.html (rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-disabled.html 2014-04-01 21:57:12 UTC (rev 166614)
@@ -0,0 +1,18 @@
+!DOCTYPE html
+html
+script
+if (window.testRunner)
+testRunner.overridePreference(WebKitCSSGridLayoutEnabled, 0);
+/script
+body
+div id=grid style=display:
[webkit-changes] [166615] trunk/Source/WebCore
Title: [166615] trunk/Source/WebCore
Revision 166615
Author a...@apple.com
Date 2014-04-01 14:57:15 -0700 (Tue, 01 Apr 2014)
Log Message
Eliminate HTMLFormElement::m_shouldSubmit
https://bugs.webkit.org/show_bug.cgi?id=131055
Reviewed by Tim Horton.
m_shouldSubmit was used for two purposes:
- as a return value in a function whose return value is ignored by all callers;
- to make a decision that's local to a function.
There is no need for it to be an instance variable.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::prepareForSubmission):
(WebCore::HTMLFormElement::submit):
* html/HTMLFormElement.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormElement.cpp
trunk/Source/WebCore/html/HTMLFormElement.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166614 => 166615)
--- trunk/Source/WebCore/ChangeLog 2014-04-01 21:57:12 UTC (rev 166614)
+++ trunk/Source/WebCore/ChangeLog 2014-04-01 21:57:15 UTC (rev 166615)
@@ -1,3 +1,22 @@
+2014-04-01 Alexey Proskuryakov a...@apple.com
+
+Eliminate HTMLFormElement::m_shouldSubmit
+https://bugs.webkit.org/show_bug.cgi?id=131055
+
+Reviewed by Tim Horton.
+
+m_shouldSubmit was used for two purposes:
+- as a return value in a function whose return value is ignored by all callers;
+- to make a decision that's local to a function.
+
+There is no need for it to be an instance variable.
+
+* html/HTMLFormElement.cpp:
+(WebCore::HTMLFormElement::HTMLFormElement):
+(WebCore::HTMLFormElement::prepareForSubmission):
+(WebCore::HTMLFormElement::submit):
+* html/HTMLFormElement.h:
+
2014-04-01 Benjamin Poulain bpoul...@apple.com
Remove a couple of useless static strings
Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (166614 => 166615)
--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2014-04-01 21:57:12 UTC (rev 166614)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2014-04-01 21:57:15 UTC (rev 166615)
@@ -57,7 +57,6 @@
, m_associatedElementsAfterIndex(0)
, m_wasUserSubmitted(false)
, m_isSubmittingOrPreparingForSubmission(false)
-, m_shouldSubmit(false)
, m_isInResetFunction(false)
, m_wasDemoted(false)
{
@@ -260,19 +259,19 @@
return false;
}
-bool HTMLFormElement::prepareForSubmission(Event* event)
+void HTMLFormElement::prepareForSubmission(Event* event)
{
Frame* frame = document().frame();
if (m_isSubmittingOrPreparingForSubmission || !frame)
-return m_isSubmittingOrPreparingForSubmission;
+return;
m_isSubmittingOrPreparingForSubmission = true;
-m_shouldSubmit = false;
+bool shouldSubmit = false;
// Interactive validation must be done before dispatching the submit event.
if (!validateInteractively(event)) {
m_isSubmittingOrPreparingForSubmission = false;
-return false;
+return;
}
StringPairVector controlNamesAndValues;
@@ -281,14 +280,12 @@
frame-loader().client().dispatchWillSendSubmitEvent(formState.release());
if (dispatchEvent(Event::create(eventNames().submitEvent, true, true)))
-m_shouldSubmit = true;
+shouldSubmit = true;
m_isSubmittingOrPreparingForSubmission = false;
-if (m_shouldSubmit)
+if (shouldSubmit)
submit(event, true, true, NotSubmittedByJavaScript);
-
-return m_shouldSubmit;
}
void HTMLFormElement::submit()
@@ -325,10 +322,8 @@
if (!view || !frame)
return;
-if (m_isSubmittingOrPreparingForSubmission) {
-m_shouldSubmit = true;
+if (m_isSubmittingOrPreparingForSubmission)
return;
-}
m_isSubmittingOrPreparingForSubmission = true;
m_wasUserSubmitted = processingUserGesture;
@@ -358,7 +353,6 @@
if (needButtonActivation firstSuccessfulSubmitButton)
firstSuccessfulSubmitButton-setActivatedSubmit(false);
-m_shouldSubmit = false;
m_isSubmittingOrPreparingForSubmission = false;
}
Modified: trunk/Source/WebCore/html/HTMLFormElement.h (166614 => 166615)
--- trunk/Source/WebCore/html/HTMLFormElement.h 2014-04-01 21:57:12 UTC (rev 166614)
+++ trunk/Source/WebCore/html/HTMLFormElement.h 2014-04-01 21:57:15 UTC (rev 166615)
@@ -81,7 +81,7 @@
void registerImgElement(HTMLImageElement*);
void removeImgElement(HTMLImageElement*);
-bool prepareForSubmission(Event*);
+void prepareForSubmission(Event*); // FIXME: This function doesn't only prepare, it sometimes calls sumbit() itself.
void submit();
void submitFromJavaScript();
void reset();
@@ -172,7 +172,6 @@
bool m_wasUserSubmitted;
bool m_isSubmittingOrPreparingForSubmission;
-bool m_shouldSubmit;
bool m_isInResetFunction;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [166617] trunk/Source
Title: [166617] trunk/Source Revision 166617 Author ander...@apple.com Date 2014-04-01 15:03:31 -0700 (Tue, 01 Apr 2014) Log Message Migrate more headers https://bugs.webkit.org/show_bug.cgi?id=131068 Reviewed by Tim Horton. Source/WebKit/mac: * MigrateHeaders.make: Source/WebKit2: * UIProcess/API/Cocoa/WKBackForwardList.h: Remove a newline. * WebKit2.xcodeproj/project.pbxproj: Move files from the Deprecated group. Modified Paths trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/MigrateHeaders.make trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj Diff Modified: trunk/Source/WebKit/mac/ChangeLog (166616 => 166617) --- trunk/Source/WebKit/mac/ChangeLog 2014-04-01 22:02:15 UTC (rev 166616) +++ trunk/Source/WebKit/mac/ChangeLog 2014-04-01 22:03:31 UTC (rev 166617) @@ -1,3 +1,12 @@ +2014-04-01 Anders Carlsson ander...@apple.com + +Migrate more headers +https://bugs.webkit.org/show_bug.cgi?id=131068 + +Reviewed by Tim Horton. + +* MigrateHeaders.make: + 2014-04-01 Manuel Rego Casasnovas r...@igalia.com [CSS Grid Layout] Enable runtime feature if feature flag is enabled Modified: trunk/Source/WebKit/mac/MigrateHeaders.make (166616 => 166617) --- trunk/Source/WebKit/mac/MigrateHeaders.make 2014-04-01 22:02:15 UTC (rev 166616) +++ trunk/Source/WebKit/mac/MigrateHeaders.make 2014-04-01 22:03:31 UTC (rev 166617) @@ -260,6 +260,10 @@ # Migration of WebKit2 headers to WebKit WEBKIT2_HEADERS = \ +WKBackForwardList.h \ +WKBackForwardListItem.h \ +WKBackForwardListItemPrivate.h \ +WKBackForwardListPrivate.h \ WKFoundation.h \ WKFrameInfo.h \ WKHistoryDelegatePrivate.h \ @@ -269,13 +273,9 @@ WKNavigationResponse.h \ WKPreferences.h \ WKProcessPool.h \ -WKProcessPoolConfiguration.h \ -WKProcessPoolConfigurationPrivate.h \ WKProcessPoolPrivate.h \ WKUIDelegate.h \ WKUIDelegatePrivate.h \ -WKVisitedLinkProvider.h \ -WKVisitedLinkProviderPrivate.h \ WKWebView.h \ WKWebViewConfiguration.h \ WKWebViewConfigurationPrivate.h \ @@ -284,6 +284,8 @@ _WKElementAction.h \ _WKProcessPoolConfiguration.h \ _WKThumbnailView.h \ +_WKVisitedLinkProvider.h \ +_WKVisitedLinkProviderPrivate.h \ # WEBKIT2_PUBLIC_HEADERS = $(addprefix $(PUBLIC_HEADERS_DIR)/, $(filter $(WEBKIT2_HEADERS),$(notdir $(wildcard $(WEBKIT2_FRAMEWORKS_DIR)/WebKit2.framework/Headers/* Modified: trunk/Source/WebKit2/ChangeLog (166616 => 166617) --- trunk/Source/WebKit2/ChangeLog 2014-04-01 22:02:15 UTC (rev 166616) +++ trunk/Source/WebKit2/ChangeLog 2014-04-01 22:03:31 UTC (rev 166617) @@ -1,3 +1,16 @@ +2014-04-01 Anders Carlsson ander...@apple.com + +Migrate more headers +https://bugs.webkit.org/show_bug.cgi?id=131068 + +Reviewed by Tim Horton. + +* UIProcess/API/Cocoa/WKBackForwardList.h: +Remove a newline. + +* WebKit2.xcodeproj/project.pbxproj: +Move files from the Deprecated group. + 2014-04-01 Manuel Rego Casasnovas r...@igalia.com [CSS Grid Layout] Enable runtime feature if feature flag is enabled Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h (166616 => 166617) --- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h 2014-04-01 22:02:15 UTC (rev 166616) +++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.h 2014-04-01 22:03:31 UTC (rev 166617) @@ -29,7 +29,6 @@ #import WebKit2/WKBackForwardListItem.h - WK_API_CLASS @interface WKBackForwardList : NSObject Modified: trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj (166616 => 166617) --- trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2014-04-01 22:02:15 UTC (rev 166616) +++ trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj 2014-04-01 22:03:31 UTC (rev 166617) @@ -3787,13 +3787,6 @@ isa = PBXGroup; children = ( BC59548815C7868500FD1E3E /* WebKit2.h */, -37C4C08B1814AC5C003688B9 /* WKBackForwardList.h */, -37C4C08A1814AC5C003688B9 /* WKBackForwardList.mm */, -37C4C08E1814AF3A003688B9 /* WKBackForwardListInternal.h */, -1A79D9F118EB5EF100914CC5 /* WKBackForwardListPrivate.h */, -37C4C08518149C5B003688B9 /* WKBackForwardListItem.h */, -37C4C08418149C5B003688B9 /* WKBackForwardListItem.mm */, -37C4C08818149F23003688B9 /* WKBackForwardListItemInternal.h */, BCBAAC6C144E61910053F82F /* WKBrowsingContextController.h */, BCBAAC6D144E61920053F82F /* WKBrowsingContextController.mm */, BCBAAC6E144E61920053F82F /* WKBrowsingContextControllerInternal.h */, @@ -4656,6 +4649,13 @@ 1A81B37F18BD66AD0007FDAC /* _WKVisitedLinkProvider.h */, 1A81B37E18BD66AD0007FDAC /* _WKVisitedLinkProvider.mm */, 1A81B38418BD673A0007FDAC /* _WKVisitedLinkProviderInternal.h */, +37C4C08B1814AC5C003688B9 /* WKBackForwardList.h */,
[webkit-changes] [166618] trunk
Title: [166618] trunk Revision 166618 Author zol...@webkit.org Date 2014-04-01 15:13:34 -0700 (Tue, 01 Apr 2014) Log Message [CSS Exclusions] Remove exclusions parsing support https://bugs.webkit.org/show_bug.cgi?id=131046 Reviewed by David Hyatt. Source/WebCore: CSS Exclusions specification [1] needs some evolution before the actual implementation happens. We have only the parsing code in WebKit for -webkit-wrap-flow and -webkit-wrap-through. This patch removes the code from the trunk for now, it doesn't make sense to keep it around. [1] http://www.w3.org/TR/css3-exclusions/ Removed existing parsing tests. * css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::propertyValue): * css/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): (WebCore::isKeywordPropertyID): (WebCore::CSSParser::parseValue): * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted. (WebCore::CSSPrimitiveValue::operator WrapFlow): Deleted. (WebCore::CSSPrimitiveValue::operator WrapThrough): Deleted. * css/CSSPropertyNames.in: * css/CSSValueKeywords.in: * css/DeprecatedStyleBuilder.cpp: (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): * css/StyleResolver.cpp: (WebCore::StyleResolver::applyProperty): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::changeRequiresLayout): * rendering/style/RenderStyle.h: * rendering/style/RenderStyleConstants.h: * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: Source/WebInspectorUI: * UserInterface/Models/CSSKeywordCompletions.js: Tools: * Scripts/webkitperl/FeatureList.pm: LayoutTests: * fast/exclusions/css-exclusions-disabled-expected.txt: Removed. * fast/exclusions/css-exclusions-disabled.html: Removed. * fast/exclusions/css-exclusions-enabled-expected.txt: Removed. * fast/exclusions/css-exclusions-enabled.html: Removed. * fast/exclusions/parsing/parsing-wrap-flow-expected.txt: Removed. * fast/exclusions/parsing/parsing-wrap-flow.html: Removed. * fast/exclusions/parsing/parsing-wrap-through-expected.txt: Removed. * fast/exclusions/parsing/parsing-wrap-through.html: Removed. * fast/exclusions/parsing/script-tests/parsing-test-utils.js: Removed. * fast/exclusions/parsing/script-tests/parsing-wrap-flow.js: Removed. * fast/exclusions/parsing/script-tests/parsing-wrap-through.js: Removed. * platform/win/TestExpectations: * platform/wincairo/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations trunk/LayoutTests/platform/wincairo/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp trunk/Source/WebCore/css/CSSParser.cpp trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/CSSValueKeywords.in trunk/Source/WebCore/css/DeprecatedStyleBuilder.cpp trunk/Source/WebCore/css/StyleResolver.cpp trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/RenderStyleConstants.h trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp trunk/Source/WebCore/rendering/style/StyleRareNonInheritedData.h trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitperl/FeatureList.pm Removed Paths trunk/LayoutTests/fast/exclusions/ Diff Modified: trunk/LayoutTests/ChangeLog (166617 => 166618) --- trunk/LayoutTests/ChangeLog 2014-04-01 22:03:31 UTC (rev 166617) +++ trunk/LayoutTests/ChangeLog 2014-04-01 22:13:34 UTC (rev 166618) @@ -1,3 +1,24 @@ +2014-04-01 Zoltan Horvath zol...@webkit.org + +[CSS Exclusions] Remove exclusions parsing support +https://bugs.webkit.org/show_bug.cgi?id=131046 + +Reviewed by David Hyatt. + +* fast/exclusions/css-exclusions-disabled-expected.txt: Removed. +* fast/exclusions/css-exclusions-disabled.html: Removed. +* fast/exclusions/css-exclusions-enabled-expected.txt: Removed. +* fast/exclusions/css-exclusions-enabled.html: Removed. +* fast/exclusions/parsing/parsing-wrap-flow-expected.txt: Removed. +* fast/exclusions/parsing/parsing-wrap-flow.html: Removed. +* fast/exclusions/parsing/parsing-wrap-through-expected.txt: Removed. +* fast/exclusions/parsing/parsing-wrap-through.html: Removed. +* fast/exclusions/parsing/script-tests/parsing-test-utils.js: Removed. +* fast/exclusions/parsing/script-tests/parsing-wrap-flow.js: Removed. +* fast/exclusions/parsing/script-tests/parsing-wrap-through.js: Removed. +* platform/win/TestExpectations: +* platform/wincairo/TestExpectations: + 2014-04-01 Manuel Rego Casasnovas r...@igalia.com
[webkit-changes] [166619] trunk/Tools
Title: [166619] trunk/Tools
Revision 166619
Author bfulg...@apple.com
Date 2014-04-01 15:18:06 -0700 (Tue, 01 Apr 2014)
Log Message
Unreviewed test gardening.
* Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/base_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (166618 => 166619)
--- trunk/Tools/ChangeLog 2014-04-01 22:13:34 UTC (rev 166618)
+++ trunk/Tools/ChangeLog 2014-04-01 22:18:06 UTC (rev 166619)
@@ -1,3 +1,10 @@
+2014-04-01 Brent Fulgham bfulg...@apple.com
+
+Unreviewed test gardening.
+
+* Scripts/webkitpy/port/base_unittest.py:
+(PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
+
2014-04-01 Zoltan Horvath zol...@webkit.org
[CSS Exclusions] Remove exclusions parsing support
Modified: trunk/Tools/Scripts/webkitpy/port/base_unittest.py (166618 => 166619)
--- trunk/Tools/Scripts/webkitpy/port/base_unittest.py 2014-04-01 22:13:34 UTC (rev 166618)
+++ trunk/Tools/Scripts/webkitpy/port/base_unittest.py 2014-04-01 22:18:06 UTC (rev 166619)
@@ -391,7 +391,10 @@
def test_build_path(self):
port = self.make_port(options=optparse.Values({'build_directory': '/my-build-directory/'}))
-self.assertEqual(port._build_path(), '/my-build-directory/Release')
+if port.get_option('configuration') == 'Debug':
+self.assertEqual(port._build_path(), '/my-build-directory/Debug')
+else:
+self.assertEqual(port._build_path(), '/my-build-directory/Release')
class NaturalCompareTest(unittest.TestCase):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166620] trunk/Source/WebInspectorUI
Title: [166620] trunk/Source/WebInspectorUI
Revision 166620
Author commit-qu...@webkit.org
Date 2014-04-01 15:18:07 -0700 (Tue, 01 Apr 2014)
Log Message
Web Inspector: Remove stale localStorage deletion transition code
https://bugs.webkit.org/show_bug.cgi?id=131061
Patch by Joseph Pecoraro pecor...@apple.com on 2014-04-01
Reviewed by Timothy Hatcher.
* UserInterface/Base/ImageUtilities.js:
This code has been in for a while. We have transitioned to Web SQL.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (166619 => 166620)
--- trunk/Source/WebInspectorUI/ChangeLog 2014-04-01 22:18:06 UTC (rev 166619)
+++ trunk/Source/WebInspectorUI/ChangeLog 2014-04-01 22:18:07 UTC (rev 166620)
@@ -1,3 +1,13 @@
+2014-04-01 Joseph Pecoraro pecor...@apple.com
+
+Web Inspector: Remove stale localStorage deletion transition code
+https://bugs.webkit.org/show_bug.cgi?id=131061
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/ImageUtilities.js:
+This code has been in for a while. We have transitioned to Web SQL.
+
2014-04-01 Zoltan Horvath zol...@webkit.org
[CSS Exclusions] Remove exclusions parsing support
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js (166619 => 166620)
--- trunk/Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js 2014-04-01 22:18:06 UTC (rev 166619)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/ImageUtilities.js 2014-04-01 22:18:07 UTC (rev 166620)
@@ -44,23 +44,6 @@
// Updates each image when the device pixel ratio changes to redraw at the new resolution.
window.matchMedia((-webkit-device-pixel-ratio: 1)).addListener(_devicePixelRatioChanged);
-// Delete old cached images from localStorage to free up space.
-// FIXME: Remove this once it has been in the builds for a while.
-try {
-const processedFlagKey = com.apple.WebInspector.deleted-generated-images;
-
-if (!window.localStorage[processedFlagKey]) {
-for (var key in window.localStorage) {
-if (/^com\.apple\.WebInspector\.generated-(?:colored|embossed)-image-/.test(key))
-delete window.localStorage[key];
-}
-
-window.localStorage[processedFlagKey] = true;
-}
-} catch (e) {
-// Ignore.
-}
-
function _devicePixelRatioChanged()
{
_prefetchCachedImagesAndUpdate();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166624] trunk/Tools
Title: [166624] trunk/Tools
Revision 166624
Author ander...@apple.com
Date 2014-04-01 16:45:12 -0700 (Tue, 01 Apr 2014)
Log Message
Fix build.
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController dealloc]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m
Diff
Modified: trunk/Tools/ChangeLog (166623 => 166624)
--- trunk/Tools/ChangeLog 2014-04-01 23:37:58 UTC (rev 166623)
+++ trunk/Tools/ChangeLog 2014-04-01 23:45:12 UTC (rev 166624)
@@ -1,3 +1,12 @@
+2014-04-01 Anders Carlsson ander...@apple.com
+
+Fix build.
+
+* MiniBrowser/mac/WK2BrowserWindowController.m:
+(-[WK2BrowserWindowController awakeFromNib]):
+(-[WK2BrowserWindowController dealloc]):
+(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
+
2014-04-01 Brent Fulgham bfulg...@apple.com
Unreviewed test gardening.
Modified: trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m (166623 => 166624)
--- trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-04-01 23:37:58 UTC (rev 166623)
+++ trunk/Tools/MiniBrowser/mac/WK2BrowserWindowController.m 2014-04-01 23:45:12 UTC (rev 166624)
@@ -59,7 +59,7 @@
[progressIndicator bind:NSValueBinding toObject:_webView withKeyPath:@estimatedProgress options:nil];
[_webView addObserver:self forKeyPath:@title options:0 context:keyValueObservingContext];
-[_webView addObserver:self forKeyPath:@activeURL options:0 context:keyValueObservingContext];
+[_webView addObserver:self forKeyPath:@URL options:0 context:keyValueObservingContext];
_webView.navigationDelegate = self;
_webView.UIDelegate = self;
@@ -70,7 +70,7 @@
- (void)dealloc
{
[_webView removeObserver:self forKeyPath:@title];
-[_webView removeObserver:self forKeyPath:@activeURL];
+[_webView removeObserver:self forKeyPath:@URL];
[progressIndicator unbind:NSHiddenBinding];
[progressIndicator unbind:NSValueBinding];
@@ -313,8 +313,8 @@
if ([keyPath isEqualToString:@title])
self.window.title = [_webView.title stringByAppendingString:@ [WK2]];
-else if ([keyPath isEqualToString:@activeURL])
-[self updateTextFieldFromURL:_webView.activeURL];
+else if ([keyPath isEqualToString:@URL])
+[self updateTextFieldFromURL:_webView.URL];
}
- (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)())completionHandler
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166625] trunk/Source/WebKit2
Title: [166625] trunk/Source/WebKit2
Revision 166625
Author ander...@apple.com
Date 2014-04-01 16:54:44 -0700 (Tue, 01 Apr 2014)
Log Message
Stub out more WKNavigation properties
https://bugs.webkit.org/show_bug.cgi?id=131080
Reviewed by Tim Horton.
* UIProcess/API/Cocoa/WKNavigation.h:
* UIProcess/API/Cocoa/WKNavigation.mm:
(-[WKNavigation initialRequest]):
(-[WKNavigation response]):
(-[WKNavigation error]):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.h
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166624 => 166625)
--- trunk/Source/WebKit2/ChangeLog 2014-04-01 23:45:12 UTC (rev 166624)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-01 23:54:44 UTC (rev 166625)
@@ -1,5 +1,18 @@
2014-04-01 Anders Carlsson ander...@apple.com
+Stub out more WKNavigation properties
+https://bugs.webkit.org/show_bug.cgi?id=131080
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/Cocoa/WKNavigation.h:
+* UIProcess/API/Cocoa/WKNavigation.mm:
+(-[WKNavigation initialRequest]):
+(-[WKNavigation response]):
+(-[WKNavigation error]):
+
+2014-04-01 Anders Carlsson ander...@apple.com
+
Rename -[WKWebView activeURL] to -[WKWebView URL]
https://bugs.webkit.org/show_bug.cgi?id=131077
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.h (166624 => 166625)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.h 2014-04-01 23:45:12 UTC (rev 166624)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.h 2014-04-01 23:54:44 UTC (rev 166625)
@@ -31,7 +31,10 @@
WK_API_CLASS
@interface WKNavigation : NSObject
+@property (nonatomic, readonly) NSURLRequest *initialRequest;
@property (nonatomic, readonly) NSURLRequest *request;
+@property (nonatomic, readonly) NSURLResponse *response;
+@property (nonatomic, readonly) NSError *error;
@end
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm (166624 => 166625)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm 2014-04-01 23:45:12 UTC (rev 166624)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKNavigation.mm 2014-04-01 23:54:44 UTC (rev 166625)
@@ -34,6 +34,12 @@
RetainPtrNSURLRequest _request;
}
+- (NSURLRequest *)initialRequest
+{
+// FIXME: Implement.
+return nil;
+}
+
- (NSURLRequest *)request
{
return _request.get();
@@ -44,6 +50,18 @@
_request = adoptNS([request copy]);
}
+- (NSURLResponse *)response
+{
+// FIXME: Implement.
+return nil;
+}
+
+- (NSError *)error
+{
+// FIXME: Implement.
+return nil;
+}
+
@end
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166626] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Title: [166626] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Revision 166626
Author lforsch...@apple.com
Date 2014-04-01 17:43:20 -0700 (Tue, 01 Apr 2014)
Log Message
Add Scheduler for 32-bit JSC bot.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (166625 => 166626)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-04-01 23:54:44 UTC (rev 166625)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2014-04-02 00:43:20 UTC (rev 166626)
@@ -213,7 +213,7 @@
builderNames: [Apple MountainLion Release (Build), Apple MountainLion Debug (Build), Apple MountainLion Release (32-bit Build)]
},
{ type: PlatformSpecificScheduler, platform: mac-mavericks, branch: trunk, treeStableTimer: 45.0,
- builderNames: [Apple Mavericks Release (Build), Apple Mavericks Debug (Build), Apple Mavericks LLINT CLoop (BuildAndTest)]
+ builderNames: [Apple Mavericks Release (Build), Apple Mavericks Debug (Build), Apple Mavericks LLINT CLoop (BuildAndTest), Apple Mavericks 32-bit JSC (BuildAndTest)]
},
{ type: PlatformSpecificScheduler, platform: win, branch: trunk, treeStableTimer: 45.0,
builderNames: [Apple Win Release (Build), Apple Win Debug (Build)]
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166628] trunk
Title: [166628] trunk
Revision 166628
Author jhoneyc...@apple.com
Date 2014-04-01 19:48:14 -0700 (Tue, 01 Apr 2014)
Log Message
Crash in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients
https://bugs.webkit.org/show_bug.cgi?id=121887
rdar://problem/15073043
Reviewed by Dean Jackson.
Source/WebCore:
Test: svg/filters/first-letter-crash.html
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):
Added a null check to prevent crashes for anonymous RenderObjects.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::filterNeedsRepaint):
Get the enclosing element, if there is one, and recalculate its style.
We use the enclosing element so that we recalculate style for the
ancestor of an anonymous RenderElement.
(WebCore::RenderLayer::enclosingElement):
Remove an assertion; we may now reach this condition if loading a
cached SVG document results in RenderLayer::filterNeedsRepaint() being
called before the object has been inserted into the render tree.
* rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayer::FilterInfo::notifyFinished):
Tell the RenderLayer that the filter needs repainting.
(WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients):
Get the Element from the renderer rather than asking the renderer's
Element, which will be null for anonymous RenderObjects.
* rendering/RenderLayerFilterInfo.h:
Removed declaration for the old workaround function, layerElement().
LayoutTests:
* svg/filters/first-letter-crash-expected.txt: Added.
* svg/filters/first-letter-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/FilterEffectRenderer.cpp
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp
trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h
Added Paths
trunk/LayoutTests/svg/filters/first-letter-crash-expected.txt
trunk/LayoutTests/svg/filters/first-letter-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166627 => 166628)
--- trunk/LayoutTests/ChangeLog 2014-04-02 02:41:12 UTC (rev 166627)
+++ trunk/LayoutTests/ChangeLog 2014-04-02 02:48:14 UTC (rev 166628)
@@ -1,3 +1,15 @@
+2014-04-01 Jon Honeycutt jhoneyc...@apple.com
+
+Crash in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients
+
+https://bugs.webkit.org/show_bug.cgi?id=121887
+rdar://problem/15073043
+
+Reviewed by Dean Jackson.
+
+* svg/filters/first-letter-crash-expected.txt: Added.
+* svg/filters/first-letter-crash.html: Added.
+
2014-04-01 Zoltan Horvath zol...@webkit.org
[CSS Exclusions] Remove exclusions parsing support
Added: trunk/LayoutTests/svg/filters/first-letter-crash-expected.txt (0 => 166628)
--- trunk/LayoutTests/svg/filters/first-letter-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/filters/first-letter-crash-expected.txt 2014-04-02 02:48:14 UTC (rev 166628)
@@ -0,0 +1,2 @@
+PASS.
+WebKit bug #121887: Crash when applying SVG filter to first-letter pseudo element. This test passes if it does not crash.
Added: trunk/LayoutTests/svg/filters/first-letter-crash.html (0 => 166628)
--- trunk/LayoutTests/svg/filters/first-letter-crash.html (rev 0)
+++ trunk/LayoutTests/svg/filters/first-letter-crash.html 2014-04-02 02:48:14 UTC (rev 166628)
@@ -0,0 +1,16 @@
+head
+style
+div:first-letter { -webkit-filter: url(#blurFirstLetter); }
+/style
+/head
+
+divPASS./div
+
+p
+WebKit bug #a href="" Crash when applying SVG filter to first-letter pseudo element. This test passes if it does not crash.
+/p
+
+script
+if (window.testRunner)
+window.testRunner.dumpAsText();
+/script
Modified: trunk/Source/WebCore/ChangeLog (166627 => 166628)
--- trunk/Source/WebCore/ChangeLog 2014-04-02 02:41:12 UTC (rev 166627)
+++ trunk/Source/WebCore/ChangeLog 2014-04-02 02:48:14 UTC (rev 166628)
@@ -1,3 +1,38 @@
+2014-04-01 Jon Honeycutt jhoneyc...@apple.com
+
+Crash in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients
+
+https://bugs.webkit.org/show_bug.cgi?id=121887
+rdar://problem/15073043
+
+Reviewed by Dean Jackson.
+
+Test: svg/filters/first-letter-crash.html
+
+* rendering/FilterEffectRenderer.cpp:
+(WebCore::FilterEffectRenderer::buildReferenceFilter):
+Added a null check to prevent crashes for anonymous RenderObjects.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::filterNeedsRepaint):
+Get the enclosing element, if there is one, and recalculate its style.
+We use the enclosing element so that we recalculate style for the
+ancestor of an anonymous RenderElement.
+(WebCore::RenderLayer::enclosingElement):
+Remove an assertion; we may now reach this condition if loading a
+cached SVG document results in
[webkit-changes] [166629] trunk/Source/WebKit2
Title: [166629] trunk/Source/WebKit2
Revision 166629
Author benja...@webkit.org
Date 2014-04-01 20:36:29 -0700 (Tue, 01 Apr 2014)
Log Message
rdar://problem/16294704 Remove _pageExtendedBackgroundColor entirely
https://bugs.webkit.org/show_bug.cgi?id=131075
Patch by Benjamin Poulain bpoul...@apple.com on 2014-04-01
Reviewed by Beth Dakin.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _pageExtendedBackgroundColor]): Deleted.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (166628 => 166629)
--- trunk/Source/WebKit2/ChangeLog 2014-04-02 02:48:14 UTC (rev 166628)
+++ trunk/Source/WebKit2/ChangeLog 2014-04-02 03:36:29 UTC (rev 166629)
@@ -1,3 +1,14 @@
+2014-04-01 Benjamin Poulain bpoul...@apple.com
+
+rdar://problem/16294704 Remove _pageExtendedBackgroundColor entirely
+https://bugs.webkit.org/show_bug.cgi?id=131075
+
+Reviewed by Beth Dakin.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _pageExtendedBackgroundColor]): Deleted.
+* UIProcess/API/Cocoa/WKWebViewPrivate.h:
+
2014-04-01 Anders Carlsson ander...@apple.com
Stub out more WKNavigation properties
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (166628 => 166629)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-04-02 02:48:14 UTC (rev 166628)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm 2014-04-02 03:36:29 UTC (rev 166629)
@@ -1106,12 +1106,6 @@
[self _updateVisibleContentRects];
}
-- (UIColor *)_pageExtendedBackgroundColor
-{
-// This is deprecated.
-return nil;
-}
-
- (void)_setBackgroundExtendsBeyondPage:(BOOL)backgroundExtends
{
_page-setBackgroundExtendsBeyondPage(backgroundExtends);
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h (166628 => 166629)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2014-04-02 02:48:14 UTC (rev 166628)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h 2014-04-02 03:36:29 UTC (rev 166629)
@@ -87,9 +87,6 @@
@property (nonatomic, setter=_setBackgroundExtendsBeyondPage:) BOOL _backgroundExtendsBeyondPage;
-// This is deprecated and should be removed entirely: rdar://problem/16294704.
-@property (readonly) UIColor *_pageExtendedBackgroundColor;
-
@property (nonatomic, readonly, getter=_isDisplayingPDF) BOOL _displayingPDF;
- (void)_beginInteractiveObscuredInsetsChange;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [166630] trunk
Title: [166630] trunk
Revision 166630
Author bda...@apple.com
Date 2014-04-01 21:49:28 -0700 (Tue, 01 Apr 2014)
Log Message
willReveal edge events should be hooked up for overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=131071
-and corresponding-
rdar://problem/16190392
Reviewed by Sam Weinig.
Source/WebCore:
This patch moves the will reveal logic from FrameView to Document so that it can
be shared for RenderLayers.
This is mostly just a moved function, but now the function takes an Element* that
represents the target of the event if the target is not the window.
* dom/Document.cpp:
(WebCore::Document::sendWillRevealEdgeEventsIfNeeded):
* dom/Document.h:
No longer implement sendWillRevealEdgeEventsIfNeeded() on FrameView or
ScrollableArea at all. Call into Document instead.
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::sendWillRevealEdgeEventsIfNeeded): Deleted.
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::sendWillRevealEdgeEventsIfNeeded): Deleted.
Call sendWillRevealEdgeEventsIfNeeded() after sending scroll events.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
LayoutTests:
* fast/events/will-reveal-edge-on-div-expected.txt: Added.
* fast/events/will-reveal-edge-on-div.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt
trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html
Diff
Modified: trunk/LayoutTests/ChangeLog (166629 => 166630)
--- trunk/LayoutTests/ChangeLog 2014-04-02 03:36:29 UTC (rev 166629)
+++ trunk/LayoutTests/ChangeLog 2014-04-02 04:49:28 UTC (rev 166630)
@@ -1,3 +1,15 @@
+2014-04-01 Beth Dakin bda...@apple.com
+
+willReveal edge events should be hooked up for overflow:scroll
+https://bugs.webkit.org/show_bug.cgi?id=131071
+-and corresponding-
+rdar://problem/16190392
+
+Reviewed by Sam Weinig.
+
+* fast/events/will-reveal-edge-on-div-expected.txt: Added.
+* fast/events/will-reveal-edge-on-div.html: Added.
+
2014-04-01 Jon Honeycutt jhoneyc...@apple.com
Crash in WebCore::RenderLayer::FilterInfo::updateReferenceFilterClients
Added: trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt (0 => 166630)
--- trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/will-reveal-edge-on-div-expected.txt 2014-04-02 04:49:28 UTC (rev 166630)
@@ -0,0 +1,10 @@
+This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+All edges were revealed!
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html (0 => 166630)
--- trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html (rev 0)
+++ trunk/LayoutTests/fast/events/will-reveal-edge-on-div.html 2014-04-02 04:49:28 UTC (rev 166630)
@@ -0,0 +1,83 @@
+html
+script src=""
+
+style
+#scrolly-div {
+width:200px;
+height:200px;
+border:2px solid black;
+overflow:scroll;
+}
+
+.big {
+background-color:purple;
+width:600px;
+height:600px;
+}
+/style
+
+script type=text/_javascript_
+description('This tests that we can listen for webkitwillrevealbottom, webkitwillrevealtop, webkitwillrevealleft, and webkitwillrevealright');
+
+var triggeredWillRevealBottom = false;
+var triggeredWillRevealTop = false;
+var triggeredWillRevealRight = false;
+var triggeredWillRevealLeft = false;
+
+function bottomRevealed()
+{
+triggeredWillRevealBottom = true;
+var scrolly = document.getElementById(scrolly-div);
+scrolly.scrollTop = 0;
+checkComplete();
+}
+
+function topRevealed()
+{
+triggeredWillRevealTop = true;
+var scrolly = document.getElementById(scrolly-div);
+scrolly.scrollLeft = 600;
+checkComplete();
+}
+
+function rightRevealed()
+{
+triggeredWillRevealRight = true;
+var scrolly = document.getElementById(scrolly-div);
+scrolly.scrollLeft = 0;
+checkComplete();
+}
+
+function leftRevealed()
+{
+triggeredWillRevealLeft = true;
+checkComplete();
+}
+
+function checkComplete()
+{
+if (triggeredWillRevealBottom triggeredWillRevealTop triggeredWillRevealRight triggeredWillRevealLeft) {
+debug('All edges were revealed!');
+finishJSTest();
+}
+}
+
+var jsTestIsAsync = true;
+
+function runTest() {
+var scrolly = document.getElementById(scrolly-div);
+
[webkit-changes] [166631] trunk/Source/WebCore
Title: [166631] trunk/Source/WebCore
Revision 166631
Author abu...@adobe.com
Date 2014-04-01 22:36:54 -0700 (Tue, 01 Apr 2014)
Log Message
[CSS Regions] Simplify the RenderFlowThread state pusher
https://bugs.webkit.org/show_bug.cgi?id=131035
Reviewed by David Hyatt.
The RenderFlowThread state pusher is desynchronized from the RenderView layout state pusher
by one renderer. This patch fixes the anomaly by correctly ordering the push and pop operations
between the two systems.
Tests: no functional change, no new tests.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
(WebCore::RenderFlowThread::popFlowThreadLayoutState):
(WebCore::RenderFlowThread::offsetFromLogicalTopOfFirstRegion):
* rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
* rendering/RenderView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlowThread.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (166630 => 166631)
--- trunk/Source/WebCore/ChangeLog 2014-04-02 04:49:28 UTC (rev 166630)
+++ trunk/Source/WebCore/ChangeLog 2014-04-02 05:36:54 UTC (rev 166631)
@@ -1,3 +1,24 @@
+2014-04-01 Andrei Bucur abu...@adobe.com
+
+[CSS Regions] Simplify the RenderFlowThread state pusher
+https://bugs.webkit.org/show_bug.cgi?id=131035
+
+Reviewed by David Hyatt.
+
+The RenderFlowThread state pusher is desynchronized from the RenderView layout state pusher
+by one renderer. This patch fixes the anomaly by correctly ordering the push and pop operations
+between the two systems.
+
+Tests: no functional change, no new tests.
+
+* rendering/RenderFlowThread.cpp:
+(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
+(WebCore::RenderFlowThread::popFlowThreadLayoutState):
+(WebCore::RenderFlowThread::offsetFromLogicalTopOfFirstRegion):
+* rendering/RenderView.cpp:
+(WebCore::RenderView::pushLayoutState):
+* rendering/RenderView.h:
+
2014-04-01 Beth Dakin bda...@apple.com
willReveal edge events should be hooked up for overflow:scroll
Modified: trunk/Source/WebCore/rendering/RenderFlowThread.cpp (166630 => 166631)
--- trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-04-02 04:49:28 UTC (rev 166630)
+++ trunk/Source/WebCore/rendering/RenderFlowThread.cpp 2014-04-02 05:36:54 UTC (rev 166631)
@@ -1144,6 +1144,8 @@
void RenderFlowThread::pushFlowThreadLayoutState(const RenderObject object)
{
+m_activeObjectsStack.add(object);
+
if (const RenderBox* currentBoxDescendant = currentActiveRenderBox()) {
LayoutState* layoutState = currentBoxDescendant-view().layoutState();
if (layoutState layoutState-isPaginated()) {
@@ -1152,19 +1154,17 @@
setOffsetFromLogicalTopOfFirstRegion(currentBoxDescendant, currentBoxDescendant-isHorizontalWritingMode() ? offsetDelta.height() : offsetDelta.width());
}
}
-
-m_activeObjectsStack.add(object);
}
void RenderFlowThread::popFlowThreadLayoutState()
{
-m_activeObjectsStack.removeLast();
-
if (const RenderBox* currentBoxDescendant = currentActiveRenderBox()) {
LayoutState* layoutState = currentBoxDescendant-view().layoutState();
if (layoutState layoutState-isPaginated())
clearOffsetFromLogicalTopOfFirstRegion(currentBoxDescendant);
}
+
+m_activeObjectsStack.removeLast();
}
LayoutUnit RenderFlowThread::offsetFromLogicalTopOfFirstRegion(const RenderBlock* currentBlock) const
@@ -1174,16 +1174,6 @@
if (hasCachedOffsetFromLogicalTopOfFirstRegion(currentBlock))
return cachedOffsetFromLogicalTopOfFirstRegion(currentBlock);
-// If it's the current box being laid out, use the layout state.
-const RenderBox* currentBoxDescendant = currentActiveRenderBox();
-if (currentBlock == currentBoxDescendant) {
-LayoutState* layoutState = view().layoutState();
-ASSERT(layoutState-m_renderer == currentBlock);
-ASSERT(layoutState layoutState-isPaginated());
-LayoutSize offsetDelta = layoutState-m_layoutOffset - layoutState-m_pageOffset;
-return currentBoxDescendant-isHorizontalWritingMode() ? offsetDelta.height() : offsetDelta.width();
-}
-
// As a last resort, take the slow path.
LayoutRect blockRect(0, 0, currentBlock-width(), currentBlock-height());
while (currentBlock !currentBlock-isRenderFlowThread()) {
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (166630 => 166631)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2014-04-02 04:49:28 UTC (rev 166630)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2014-04-02 05:36:54 UTC (rev 166631)
@@ -1019,8 +1019,8 @@
ASSERT(m_layoutStateDisableCount == 0);
ASSERT(m_layoutState == 0);
+m_layoutState = std::make_uniqueLayoutState(root);
