[webkit-changes] [187583] trunk
Title: [187583] trunk
Revision 187583
Author mcatanz...@igalia.com
Date 2015-07-30 07:51:09 -0700 (Thu, 30 Jul 2015)
Log Message
Web Inspector: [Freetype] Allow inspector to retrieve a list of system fonts
https://bugs.webkit.org/show_bug.cgi?id=147018
Reviewed by Carlos Garcia Campos.
Source/WebCore:
No new tests; unskipped inspector/css/get-system-fonts.html
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::patternToFamilies): Added.
(WebCore::FontCache::systemFontFamilies): Implemented.
(WebCore::strongAliasesForFamily): Split some code off to patternToFamilies.
LayoutTests:
* inspector/css/get-system-fonts-expected.txt: Expect some free fonts to be missing
* inspector/css/get-system-fonts.html: Check for some free fonts.
* platform/gtk/TestExpectations: Unskip the test.
* platform/gtk/inspector/css/get-system-fonts-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/css/get-system-fonts-expected.txt
trunk/LayoutTests/inspector/css/get-system-fonts.html
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp
Added Paths
trunk/LayoutTests/platform/gtk/inspector/css/
trunk/LayoutTests/platform/gtk/inspector/css/get-system-fonts-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (187582 => 187583)
--- trunk/LayoutTests/ChangeLog 2015-07-30 11:10:38 UTC (rev 187582)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 14:51:09 UTC (rev 187583)
@@ -1,3 +1,15 @@
+2015-07-30 Michael Catanzaro mcatanz...@igalia.com
+
+Web Inspector: [Freetype] Allow inspector to retrieve a list of system fonts
+https://bugs.webkit.org/show_bug.cgi?id=147018
+
+Reviewed by Carlos Garcia Campos.
+
+* inspector/css/get-system-fonts-expected.txt: Expect some free fonts to be missing
+* inspector/css/get-system-fonts.html: Check for some free fonts.
+* platform/gtk/TestExpectations: Unskip the test.
+* platform/gtk/inspector/css/get-system-fonts-expected.txt: Added.
+
2015-07-30 Nan Wang n_w...@apple.com
AX: VoiceOver unable to access content in malformed trees
Modified: trunk/LayoutTests/inspector/css/get-system-fonts-expected.txt (187582 => 187583)
--- trunk/LayoutTests/inspector/css/get-system-fonts-expected.txt 2015-07-30 11:10:38 UTC (rev 187582)
+++ trunk/LayoutTests/inspector/css/get-system-fonts-expected.txt 2015-07-30 14:51:09 UTC (rev 187583)
@@ -1,4 +1,7 @@
-Has at least 5 fonts: true
-PASS: Includes Arial
-PASS: Includes Times
+This test ensures that the inspector can enumerate system font families, and checks for the existance of common fonts.
+Includes Arial
+Includes Times
+Missing DejaVu Sans
+Missing Liberation Serif
+
Modified: trunk/LayoutTests/inspector/css/get-system-fonts.html (187582 => 187583)
--- trunk/LayoutTests/inspector/css/get-system-fonts.html 2015-07-30 11:10:38 UTC (rev 187582)
+++ trunk/LayoutTests/inspector/css/get-system-fonts.html 2015-07-30 14:51:09 UTC (rev 187583)
@@ -3,19 +3,22 @@
head
script type=text/_javascript_ src=""
script
-// Testing that we can get the fonts on the system and that the fonts contain some universal fonts (arial, times, etc).
function test() {
function hasFontFamily(fontFamilies, fontFamily) {
-return (fontFamilies.includes(fontFamily) ? PASS: Includes : FAIL: Missing ) + fontFamily;
+return (fontFamilies.includes(fontFamily) ? Includes : Missing ) + fontFamily;
}
function fontFamilyNamesCallback(error, fontFamilyNames) {
InspectorTest.assert(!error, Error in getting font family names.);
if (!error) {
-InspectorTest.log(Has at least 5 fonts: + (fontFamilyNames.length = 5));
+InspectorTest.assert(fontFamilyNames.length = 5, Has at least 5 fonts);
+// We can't count on any font existing on every platform, so we list enough fonts here
+// such that at least one will exist. Update your port's test expectations as needed.
InspectorTest.log(hasFontFamily(fontFamilyNames, Arial));
InspectorTest.log(hasFontFamily(fontFamilyNames, Times));
+InspectorTest.log(hasFontFamily(fontFamilyNames, DejaVu Sans));
+InspectorTest.log(hasFontFamily(fontFamilyNames, Liberation Serif));
}
InspectorTest.completeTest();
@@ -24,5 +27,8 @@
}
/script
/head
-body _onload_=runTest()/body
+body _onload_=runTest()
+ pThis test ensures that the inspector can enumerate system font families, and checks for the
+ existance of common fonts./p
+/body
/html
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (187582 => 187583)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-07-30 11:10:38 UTC (rev 187582)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-07-30 14:51:09 UTC (rev 187583)
@@ -1319,7 +1319,6 @@
webkit.org/b/139362
[webkit-changes] [187598] trunk/Source/WebInspectorUI
Title: [187598] trunk/Source/WebInspectorUI
Revision 187598
Author drou...@apple.com
Date 2015-07-30 12:24:06 -0700 (Thu, 30 Jul 2015)
Log Message
Web Inspector: Add special case for deleting the next character when editing rules in the CSS Sidebar
https://bugs.webkit.org/show_bug.cgi?id=147442
Reviewed by Timothy Hatcher.
If the cursor is on the first position of the first line in a CSS Rule and that line
has no content, delete the line instead of doing nothing.
* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleBeforeChange):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (187597 => 187598)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-30 19:13:49 UTC (rev 187597)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-30 19:24:06 UTC (rev 187598)
@@ -1,3 +1,16 @@
+2015-07-30 Devin Rousso drou...@apple.com
+
+Web Inspector: Add special case for deleting the next character when editing rules in the CSS Sidebar
+https://bugs.webkit.org/show_bug.cgi?id=147442
+
+Reviewed by Timothy Hatcher.
+
+If the cursor is on the first position of the first line in a CSS Rule and that line
+has no content, delete the line instead of doing nothing.
+
+* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleBeforeChange):
+
2015-07-29 Nikita Vasilyev nvasil...@apple.com
Web Inspector: Improve styles of debugger popovers
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (187597 => 187598)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2015-07-30 19:13:49 UTC (rev 187597)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2015-07-30 19:24:06 UTC (rev 187598)
@@ -474,11 +474,22 @@
_handleBeforeChange(codeMirror, change)
{
-if (change.origin !== +delete || (!change.to.line !change.to.ch) || this._completionController.isShowingCompletions())
+if (change.origin !== +delete || this._completionController.isShowingCompletions())
return CodeMirror.Pass;
+if (!change.to.line !change.to.ch) {
+if (codeMirror.lineCount() === 1)
+return CodeMirror.Pass;
+
+var line = codeMirror.getLine(change.to.line);
+if (line line.trim().length)
+return CodeMirror.Pass;
+
+codeMirror.execCommand(deleteLine);
+return;
+}
+
var marks = codeMirror.findMarksAt(change.to);
-
if (!marks.length)
return CodeMirror.Pass;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187602] trunk/Source/WebCore
Title: [187602] trunk/Source/WebCore Revision 187602 Author achristen...@apple.com Date 2015-07-30 13:20:55 -0700 (Thu, 30 Jul 2015) Log Message Remove LegacyCACFLayerTreeHost https://bugs.webkit.org/show_bug.cgi?id=147388 Reviewed by Geoffrey Garen. * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::create): * platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Removed. * platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Removed. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp Removed Paths trunk/Source/WebCore/platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp trunk/Source/WebCore/platform/graphics/ca/win/LegacyCACFLayerTreeHost.h Diff Modified: trunk/Source/WebCore/ChangeLog (187601 => 187602) --- trunk/Source/WebCore/ChangeLog 2015-07-30 20:15:31 UTC (rev 187601) +++ trunk/Source/WebCore/ChangeLog 2015-07-30 20:20:55 UTC (rev 187602) @@ -1,5 +1,19 @@ 2015-07-30 Alex Christensen achristen...@webkit.org +Remove LegacyCACFLayerTreeHost +https://bugs.webkit.org/show_bug.cgi?id=147388 + +Reviewed by Geoffrey Garen. + +* WebCore.vcxproj/WebCore.vcxproj: +* WebCore.vcxproj/WebCore.vcxproj.filters: +* platform/graphics/ca/win/CACFLayerTreeHost.cpp: +(WebCore::CACFLayerTreeHost::create): +* platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Removed. +* platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Removed. + +2015-07-30 Alex Christensen achristen...@webkit.org + Fix Windows build after r187587. * loader/SubresourceLoader.h: Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj (187601 => 187602) --- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2015-07-30 20:15:31 UTC (rev 187601) +++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj 2015-07-30 20:20:55 UTC (rev 187602) @@ -8773,12 +8773,6 @@ ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'true/ExcludedFromBuild ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Release_WinCairo|x64'true/ExcludedFromBuild /ClCompile -ClCompile Include=..\platform\graphics\ca\win\LegacyCACFLayerTreeHost.cpp - ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'true/ExcludedFromBuild - ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug_WinCairo|x64'true/ExcludedFromBuild - ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Release_WinCairo|Win32'true/ExcludedFromBuild - ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Release_WinCairo|x64'true/ExcludedFromBuild -/ClCompile ClCompile Include=..\platform\graphics\ca\win\PlatformCAAnimationWin.cpp ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug_WinCairo|Win32'true/ExcludedFromBuild ExcludedFromBuild Condition='$(Configuration)|$(Platform)'=='Debug_WinCairo|x64'true/ExcludedFromBuild @@ -20529,7 +20523,6 @@ CustomBuildStep Include=..\platform\graphics\ca\win\CACFLayerTreeHost.h / ClInclude Include=..\platform\graphics\ca\win\CACFLayerTreeHostClient.h / CustomBuildStep Include=..\platform\graphics\ca\win\LayerChangesFlusher.h / -ClInclude Include=..\platform\graphics\ca\win\LegacyCACFLayerTreeHost.h / ClInclude Include=..\platform\graphics\ca\win\PlatformCALayerWinInternal.h / ClInclude Include=..\platform\graphics\ca\win\WKCACFViewLayerTreeHost.h / ClInclude Include=..\platform\graphics\avfoundation\MediaPlayerPrivateAVFoundation.h / Modified: trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters (187601 => 187602) --- trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2015-07-30 20:15:31 UTC (rev 187601) +++ trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters 2015-07-30 20:20:55 UTC (rev 187602) @@ -1731,9 +1731,6 @@ ClCompile Include=..\platform\graphics\ca\win\LayerChangesFlusher.cpp Filterplatform\graphics\ca\win/Filter /ClCompile -ClCompile Include=..\platform\graphics\ca\win\LegacyCACFLayerTreeHost.cpp - Filterplatform\graphics\ca\win/Filter -/ClCompile ClCompile Include=..\platform\graphics\ca\win\PlatformCAAnimationWin.cpp Filterplatform\graphics\ca\win/Filter /ClCompile @@ -8741,9 +8738,6 @@ ClInclude Include=..\platform\graphics\ca\win\CACFLayerTreeHostClient.h Filterplatform\graphics\ca\win/Filter /ClInclude -ClInclude Include=..\platform\graphics\ca\win\LegacyCACFLayerTreeHost.h - Filterplatform\graphics\ca\win/Filter -/ClInclude ClInclude Include=..\platform\graphics\ca\win\PlatformCALayerWinInternal.h Filterplatform\graphics\ca\win/Filter
[webkit-changes] [187609] trunk
Title: [187609] trunk Revision 187609 Author d...@apple.com Date 2015-07-30 14:22:47 -0700 (Thu, 30 Jul 2015) Log Message Don't use (Details) when exposing SPI https://bugs.webkit.org/show_bug.cgi?id=147426 rdar://problem/22062407 Reviewed by Dan Bernstein. If we are declaring the interface without any implementation, we should use class extensions. Source/WebCore: Added three new SPI.h files for NSButtonCell, NSURLConnection and NSURLRequest. * WebCore.xcodeproj/project.pbxproj: * platform/mac/ScrollViewMac.mm: * platform/mac/ThemeMac.mm: * platform/network/mac/ResourceHandleMac.mm: * platform/network/mac/WebCoreResourceHandleAsDelegate.mm: * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm: * platform/spi/cf/CFNetworkSPI.h: * platform/spi/cocoa/AVKitSPI.h: * platform/spi/cocoa/CFNSURLConnectionSPI.h: * platform/spi/cocoa/NSButtonCellSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSColorSPI.h. * platform/spi/cocoa/NSCalendarDateSPI.h: * platform/spi/cocoa/NSColorSPI.h: * platform/spi/cocoa/NSFileManagerSPI.h: * platform/spi/cocoa/NSStringSPI.h: * platform/spi/cocoa/NSURLConnectionSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSStringSPI.h. * platform/spi/cocoa/NSURLDownloadSPI.h: * platform/spi/cocoa/NSURLRequestSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSStringSPI.h. * platform/spi/cocoa/QuartzCoreSPI.h: * platform/spi/cocoa/WebFilterEvaluatorSPI.h: * platform/spi/ios/CoreUISPI.h: * platform/spi/ios/LaunchServicesSPI.h: * platform/spi/ios/MediaPlayerSPI.h: * platform/spi/ios/QuickLookSPI.h: * platform/spi/ios/UIColorSPI.h: * platform/spi/mac/QuickLookMacSPI.h: * rendering/RenderThemeMac.mm: Source/WebKit/mac: * WebView/WebFrameView.mm: * WebView/WebPDFView.mm: Source/WebKit2: * Platform/spi/ios/AssertionServicesSPI.h: * Platform/spi/ios/CorePDFSPI.h: * Platform/spi/ios/DataDetectorsUISPI.h: * Platform/spi/ios/ManagedConfigurationSPI.h: * Platform/spi/ios/UIKitSPI.h: * Shared/API/Cocoa/WKRemoteObjectCoder.mm: * Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm: * UIProcess/_WKWebViewPrintFormatter.mm: * UIProcess/mac/WebPageProxyMac.mm: Tools: * DumpRenderTree/mac/DumpRenderTree.mm: * DumpRenderTree/mac/EventSendingController.mm: * DumpRenderTree/mac/PixelDumpSupportMac.mm: * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: * WebKitTestRunner/ios/PlatformWebViewIOS.mm: * WebKitTestRunner/mac/PlatformWebViewMac.mm: * WebKitTestRunner/mac/TestControllerMac.mm: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/mac/ScrollViewMac.mm trunk/Source/WebCore/platform/mac/ThemeMac.mm trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h trunk/Source/WebCore/platform/spi/cocoa/AVKitSPI.h trunk/Source/WebCore/platform/spi/cocoa/CFNSURLConnectionSPI.h trunk/Source/WebCore/platform/spi/cocoa/NSCalendarDateSPI.h trunk/Source/WebCore/platform/spi/cocoa/NSColorSPI.h trunk/Source/WebCore/platform/spi/cocoa/NSFileManagerSPI.h trunk/Source/WebCore/platform/spi/cocoa/NSStringSPI.h trunk/Source/WebCore/platform/spi/cocoa/NSURLDownloadSPI.h trunk/Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h trunk/Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h trunk/Source/WebCore/platform/spi/ios/CoreUISPI.h trunk/Source/WebCore/platform/spi/ios/LaunchServicesSPI.h trunk/Source/WebCore/platform/spi/ios/MediaPlayerSPI.h trunk/Source/WebCore/platform/spi/ios/QuickLookSPI.h trunk/Source/WebCore/platform/spi/ios/UIColorSPI.h trunk/Source/WebCore/platform/spi/mac/QuickLookMacSPI.h trunk/Source/WebCore/rendering/RenderThemeMac.mm trunk/Source/WebKit/mac/ChangeLog trunk/Source/WebKit/mac/WebView/WebFrameView.mm trunk/Source/WebKit/mac/WebView/WebPDFView.mm trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Platform/spi/ios/AssertionServicesSPI.h trunk/Source/WebKit2/Platform/spi/ios/CorePDFSPI.h trunk/Source/WebKit2/Platform/spi/ios/DataDetectorsUISPI.h trunk/Source/WebKit2/Platform/spi/ios/ManagedConfigurationSPI.h trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h trunk/Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm trunk/Source/WebKit2/Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm trunk/Source/WebKit2/UIProcess/_WKWebViewPrintFormatter.mm trunk/Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/DumpRenderTree/mac/EventSendingController.mm trunk/Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm Added
[webkit-changes] [187600] trunk/Source/WebKit2
Title: [187600] trunk/Source/WebKit2
Revision 187600
Author cdu...@apple.com
Date 2015-07-30 12:40:56 -0700 (Thu, 30 Jul 2015)
Log Message
[WK2][NetworkCache] Stop closing files on the main thread
https://bugs.webkit.org/show_bug.cgi?id=147410
Reviewed by Andreas Kling.
After r186510, we no longer open cache files on the main thread.
However, we still close them on the main thread. This patch makes
sure we close the files on another thread instead.
* NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
(WebKit::NetworkCache::IOChannel::IOChannel):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187599 => 187600)
--- trunk/Source/WebKit2/ChangeLog 2015-07-30 19:26:29 UTC (rev 187599)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-30 19:40:56 UTC (rev 187600)
@@ -1,3 +1,17 @@
+2015-07-30 Chris Dumez cdu...@apple.com
+
+[WK2][NetworkCache] Stop closing files on the main thread
+https://bugs.webkit.org/show_bug.cgi?id=147410
+
+Reviewed by Andreas Kling.
+
+After r186510, we no longer open cache files on the main thread.
+However, we still close them on the main thread. This patch makes
+sure we close the files on another thread instead.
+
+* NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
+(WebKit::NetworkCache::IOChannel::IOChannel):
+
2015-07-30 Simon Fraser simon.fra...@apple.com
Convert Path applier to use std::function
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm (187599 => 187600)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm 2015-07-30 19:26:29 UTC (rev 187599)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm 2015-07-30 19:40:56 UTC (rev 187600)
@@ -69,7 +69,7 @@
int fd = ::open(path.data(), oflag, mode);
m_fileDescriptor = fd;
-m_dispatchIO = adoptDispatch(dispatch_io_create(DISPATCH_IO_RANDOM, fd, dispatch_get_main_queue(), [fd](int) {
+m_dispatchIO = adoptDispatch(dispatch_io_create(DISPATCH_IO_RANDOM, fd, dispatch_get_global_queue(useLowIOPriority ? DISPATCH_QUEUE_PRIORITY_BACKGROUND : DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), [fd](int) {
close(fd);
}));
ASSERT(m_dispatchIO.get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187599] trunk/Source/WebInspectorUI
Title: [187599] trunk/Source/WebInspectorUI Revision 187599 Author nvasil...@apple.com Date 2015-07-30 12:26:29 -0700 (Thu, 30 Jul 2015) Log Message Web Inspector: Regression: %c is broken for console.group https://bugs.webkit.org/show_bug.cgi?id=147436 Reviewed by Timothy Hatcher. * UserInterface/Views/ConsoleMessageView.js: (WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (187598 => 187599) --- trunk/Source/WebInspectorUI/ChangeLog 2015-07-30 19:24:06 UTC (rev 187598) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-30 19:26:29 UTC (rev 187599) @@ -1,3 +1,13 @@ +2015-07-30 Nikita Vasilyev nvasil...@apple.com + +Web Inspector: Regression: %c is broken for console.group +https://bugs.webkit.org/show_bug.cgi?id=147436 + +Reviewed by Timothy Hatcher. + +* UserInterface/Views/ConsoleMessageView.js: +(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments): + 2015-07-30 Devin Rousso drou...@apple.com Web Inspector: Add special case for deleting the next character when editing rules in the CSS Sidebar Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (187598 => 187599) --- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-07-30 19:24:06 UTC (rev 187598) +++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-07-30 19:26:29 UTC (rev 187599) @@ -255,8 +255,8 @@ case WebInspector.ConsoleMessage.MessageType.StartGroup: case WebInspector.ConsoleMessage.MessageType.StartGroupCollapsed: -var groupName = this._message.messageText || WebInspector.UIString(Group); -element.append(groupName); +var args = this._message.parameters || [this._message.messageText || WebInspector.UIString(Group)]; +this._formatWithSubstitutionString(args, element); this._extraParameters = null; break; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187601] trunk/Source/WebCore
Title: [187601] trunk/Source/WebCore
Revision 187601
Author achristen...@apple.com
Date 2015-07-30 13:15:31 -0700 (Thu, 30 Jul 2015)
Log Message
Fix Windows build after r187587.
* loader/SubresourceLoader.h:
* loader/cache/CachedResource.h:
* platform/graphics/Font.h:
(WebCore::Font::DerivedFontData::DerivedFontData):
* rendering/RenderLayerFilterInfo.h:
Visual Studio doesn't like making std::unique_ptrs of private nested classes.
It tries to make a std::default_delete with the private class as a template parameter.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.h
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/platform/graphics/Font.h
trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (187600 => 187601)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 19:40:56 UTC (rev 187600)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 20:15:31 UTC (rev 187601)
@@ -1,3 +1,15 @@
+2015-07-30 Alex Christensen achristen...@webkit.org
+
+Fix Windows build after r187587.
+
+* loader/SubresourceLoader.h:
+* loader/cache/CachedResource.h:
+* platform/graphics/Font.h:
+(WebCore::Font::DerivedFontData::DerivedFontData):
+* rendering/RenderLayerFilterInfo.h:
+Visual Studio doesn't like making std::unique_ptrs of private nested classes.
+It tries to make a std::default_delete with the private class as a template parameter.
+
2015-07-30 Simon Fraser simon.fra...@apple.com
Convert Path applier to use std::function
Modified: trunk/Source/WebCore/loader/SubresourceLoader.h (187600 => 187601)
--- trunk/Source/WebCore/loader/SubresourceLoader.h 2015-07-30 19:40:56 UTC (rev 187600)
+++ trunk/Source/WebCore/loader/SubresourceLoader.h 2015-07-30 20:15:31 UTC (rev 187601)
@@ -106,7 +106,9 @@
};
class RequestCountTracker {
+#if !COMPILER(MSVC)
WTF_MAKE_FAST_ALLOCATED;
+#endif
public:
RequestCountTracker(CachedResourceLoader, CachedResource*);
~RequestCountTracker();
Modified: trunk/Source/WebCore/loader/cache/CachedResource.h (187600 => 187601)
--- trunk/Source/WebCore/loader/cache/CachedResource.h 2015-07-30 19:40:56 UTC (rev 187600)
+++ trunk/Source/WebCore/loader/cache/CachedResource.h 2015-07-30 20:15:31 UTC (rev 187601)
@@ -348,7 +348,9 @@
};
class CachedResource::Callback {
+#if !COMPILER(MSVC)
WTF_MAKE_FAST_ALLOCATED;
+#endif
public:
Callback(CachedResource, CachedResourceClient);
Modified: trunk/Source/WebCore/platform/graphics/Font.h (187600 => 187601)
--- trunk/Source/WebCore/platform/graphics/Font.h 2015-07-30 19:40:56 UTC (rev 187600)
+++ trunk/Source/WebCore/platform/graphics/Font.h 2015-07-30 20:15:31 UTC (rev 187601)
@@ -267,7 +267,9 @@
Glyph m_zeroWidthSpaceGlyph;
struct DerivedFontData {
+#if !COMPILER(MSVC)
WTF_MAKE_FAST_ALLOCATED;
+#endif
public:
explicit DerivedFontData(bool custom)
: forCustomFont(custom)
Modified: trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h (187600 => 187601)
--- trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h 2015-07-30 19:40:56 UTC (rev 187600)
+++ trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h 2015-07-30 20:15:31 UTC (rev 187601)
@@ -41,7 +41,9 @@
class Element;
class RenderLayer::FilterInfo final : private CachedSVGDocumentClient {
+#if !COMPILER(MSVC)
WTF_MAKE_FAST_ALLOCATED;
+#endif
public:
static FilterInfo get(RenderLayer);
static FilterInfo* getIfExists(const RenderLayer);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187605] trunk
Title: [187605] trunk Revision 187605 Author a...@apple.com Date 2015-07-30 13:57:36 -0700 (Thu, 30 Jul 2015) Log Message Replace Google App Engine with AppScale https://bugs.webkit.org/show_bug.cgi?id=147178 Patch by Aakash Jain aakash_j...@apple.com on 2015-07-30 Reviewed by Daniel Bates. Tools: * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunWebKitTests): * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: (.): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: (BubbleQueueServer): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: (TestHistory): * BuildSlaveSupport/build.webkit.org-config/templates/root.html: * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section Concurrent Requests and WSGI of https://cloud.google.com/appengine/docs/python/python25/migrate27. * TestResultServer/app.yaml: Ditto * Scripts/webkitpy/common/config/urls.py: * TestResultServer/main.py: * TestResultServer/static-dashboards/dashboard_base.js: * TestResultServer/static-dashboards/loader.js: Websites/bugs.webkit.org: * code-review.js: * template/en/default/attachment/edit.html.tmpl: * template/en/default/attachment/list.html.tmpl: * template/en/default/attachment/reviewform.html.tmpl: LayoutTests: * fast/harness/results.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/harness/results.html trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js trunk/Tools/BuildSlaveSupport/build.webkit.org-config/templates/root.html trunk/Tools/ChangeLog trunk/Tools/QueueStatusServer/app.yaml trunk/Tools/Scripts/webkitpy/common/config/urls.py trunk/Tools/TestResultServer/app.yaml trunk/Tools/TestResultServer/main.py trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js trunk/Tools/TestResultServer/static-dashboards/loader.js trunk/Websites/bugs.webkit.org/ChangeLog trunk/Websites/bugs.webkit.org/code-review.js trunk/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl trunk/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl trunk/Websites/bugs.webkit.org/template/en/default/attachment/reviewform.html.tmpl Diff Modified: trunk/LayoutTests/ChangeLog (187604 => 187605) --- trunk/LayoutTests/ChangeLog 2015-07-30 20:23:56 UTC (rev 187604) +++ trunk/LayoutTests/ChangeLog 2015-07-30 20:57:36 UTC (rev 187605) @@ -1,3 +1,12 @@ +2015-07-30 Aakash Jain aakash_j...@apple.com + +Replace Google App Engine with AppScale +https://bugs.webkit.org/show_bug.cgi?id=147178 + +Reviewed by Daniel Bates. + +* fast/harness/results.html: + 2015-07-30 Joonghun Park jh718.p...@samsung.com [EFL] Enable IndexedDB based on DatabaseProcess Modified: trunk/LayoutTests/fast/harness/results.html (187604 => 187605) --- trunk/LayoutTests/fast/harness/results.html 2015-07-30 20:23:56 UTC (rev 187604) +++ trunk/LayoutTests/fast/harness/results.html 2015-07-30 20:57:36 UTC (rev 187605) @@ -633,7 +633,7 @@ testList += ,; } -return 'http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=truetests=' + encodeURIComponent(testList); +return 'http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=truetests=' + encodeURIComponent(testList); } function tableRow(testObject) Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (187604 => 187605) --- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2015-07-30 20:23:56 UTC (rev 187604)
[webkit-changes] [187608] branches/safari-601.1-branch/Source/WebKit2
Title: [187608] branches/safari-601.1-branch/Source/WebKit2
Revision 187608
Author matthew_han...@apple.com
Date 2015-07-30 14:20:40 -0700 (Thu, 30 Jul 2015)
Log Message
Merge r187565. rdar://problem/22061043
Modified Paths
branches/safari-601.1-branch/Source/WebKit2/ChangeLog
branches/safari-601.1-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: branches/safari-601.1-branch/Source/WebKit2/ChangeLog (187607 => 187608)
--- branches/safari-601.1-branch/Source/WebKit2/ChangeLog 2015-07-30 21:20:38 UTC (rev 187607)
+++ branches/safari-601.1-branch/Source/WebKit2/ChangeLog 2015-07-30 21:20:40 UTC (rev 187608)
@@ -1,5 +1,23 @@
2015-07-30 Matthew Hanson matthew_han...@apple.com
+Merge r187565. rdar://problem/22061043
+
+2015-07-29 Enrica Casucci enr...@apple.com
+
+Preview should not start if touch handler prevents default.
+https://bugs.webkit.org/show_bug.cgi?id=147423
+rdar://problem/22061043
+
+Reviewed by Tim Horton.
+
+We need to check if _highlightLongPressCanClick has not been reset before
+we allow the preview. It can be reset by a touch handler preventing default.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
+
+2015-07-30 Matthew Hanson matthew_han...@apple.com
+
Merge r187517. rdar://problem/21645007
2015-07-28 Yongjun Zhang yongjun_zh...@apple.com
Modified: branches/safari-601.1-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (187607 => 187608)
--- branches/safari-601.1-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-07-30 21:20:38 UTC (rev 187607)
+++ branches/safari-601.1-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-07-30 21:20:40 UTC (rev 187608)
@@ -3209,6 +3209,9 @@
- (BOOL)_interactionShouldBeginFromPreviewItemController:(UIPreviewItemController *)controller forPosition:(CGPoint)position
{
+if (!_highlightLongPressCanClick)
+return NO;
+
[self ensurePositionInformationIsUpToDate:position];
if (_positionInformation.clickableElementName != A _positionInformation.clickableElementName != IMG)
return NO;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187606] branches/safari-601.1-branch
Title: [187606] branches/safari-601.1-branch
Revision 187606
Author matthew_han...@apple.com
Date 2015-07-30 14:20:34 -0700 (Thu, 30 Jul 2015)
Log Message
Merge r187278. rdar://problem/19908029
Modified Paths
branches/safari-601.1-branch/LayoutTests/ChangeLog
branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt
branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html
branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-expected.txt
branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications.html
branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/accessibility/AXObjectCache.cpp
branches/safari-601.1-branch/Source/WebCore/accessibility/AXObjectCache.h
branches/safari-601.1-branch/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Added Paths
branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-multiple-liveregions-notification-expected.txt
branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-multiple-liveregions-notification.html
Diff
Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (187605 => 187606)
--- branches/safari-601.1-branch/LayoutTests/ChangeLog 2015-07-30 20:57:36 UTC (rev 187605)
+++ branches/safari-601.1-branch/LayoutTests/ChangeLog 2015-07-30 21:20:34 UTC (rev 187606)
@@ -1,5 +1,24 @@
2015-07-30 Matthew Hanson matthew_han...@apple.com
+Merge r187278. rdar://problem/19908029
+
+2015-07-23 Nan Wang n_w...@apple.com
+
+AX: AccessibilityNodeObject::childrenChanged() generates too many AXLiveRegionChanged notifications
+https://bugs.webkit.org/show_bug.cgi?id=147211
+rdar://problem/19908029
+
+Reviewed by Chris Fleizach.
+
+* platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt:
+* platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:
+* platform/mac/accessibility/aria-liveregions-notifications-expected.txt:
+* platform/mac/accessibility/aria-liveregions-notifications.html:
+* platform/mac/accessibility/aria-multiple-liveregions-notification-expected.txt: Added.
+* platform/mac/accessibility/aria-multiple-liveregions-notification.html: Added.
+
+2015-07-30 Matthew Hanson matthew_han...@apple.com
+
Merge r187504. rdar://problem/21915355
2015-07-28 Said Abou-Hallawa sabouhall...@apple.com
Modified: branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt (187605 => 187606)
--- branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt 2015-07-30 20:57:36 UTC (rev 187605)
+++ branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt 2015-07-30 21:20:34 UTC (rev 187606)
@@ -5,6 +5,7 @@
PASS addedNotification is true
+PASS liveRegionChangeCount == 3 is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html (187605 => 187606)
--- branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html 2015-07-30 20:57:36 UTC (rev 187605)
+++ branches/safari-601.1-branch/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html 2015-07-30 21:20:34 UTC (rev 187606)
@@ -13,23 +13,18 @@
div id=console/div
script
+var jsTestIsAsync = true;
description(This tests that ARIA live region notifications are sent even when an assistive technology is not accessing them directly on each update.);
if (window.accessibilityController) {
-window.testRunner.waitUntilDone();
-document.getElementById(liveregion).focus();
-liveRegion = window.accessibilityController.focusedElement;
+liveRegion = accessibilityController.accessibleElementById(liveregion);
var liveRegionChangeCount = 0;
function ariaCallback(notification) {
if (notification == AXLiveRegionChanged) {
liveRegionChangeCount++;
- if (liveRegionChangeCount == 3) {
- liveRegion.removeNotificationListener();
- window.testRunner.notifyDone();
- }
}
}
var addedNotification = liveRegion.addNotificationListener(ariaCallback);
@@ -37,11 +32,33 @@
// this should trigger our live region callback for a new element.
for (var k = 0; k 3; k++) {
- var textNode = document.createTextNode(test + k);
-
[webkit-changes] [187607] branches/safari-601.1-branch/Source/WebKit2
Title: [187607] branches/safari-601.1-branch/Source/WebKit2
Revision 187607
Author matthew_han...@apple.com
Date 2015-07-30 14:20:38 -0700 (Thu, 30 Jul 2015)
Log Message
Merge r187517. rdar://problem/21645007
Modified Paths
branches/safari-601.1-branch/Source/WebKit2/ChangeLog
branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: branches/safari-601.1-branch/Source/WebKit2/ChangeLog (187606 => 187607)
--- branches/safari-601.1-branch/Source/WebKit2/ChangeLog 2015-07-30 21:20:34 UTC (rev 187606)
+++ branches/safari-601.1-branch/Source/WebKit2/ChangeLog 2015-07-30 21:20:38 UTC (rev 187607)
@@ -1,5 +1,22 @@
2015-07-30 Matthew Hanson matthew_han...@apple.com
+Merge r187517. rdar://problem/21645007
+
+2015-07-28 Yongjun Zhang yongjun_zh...@apple.com
+
+Bounds in InteractionInformationAtPosition should be always in main frame coordinate space.
+https://bugs.webkit.org/show_bug.cgi?id=147372
+
+When we prepare the bounds for InteractionInformationAtPosition, we should convert the rect to
+main frame space since WKContent in UIProcess expects it to be in the web view space.
+
+Reviewed by Tim Horton.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::getPositionInformation): Convert the bounding rect to main frame space if the element is inside a sub-frame.
+
+2015-07-30 Matthew Hanson matthew_han...@apple.com
+
Merge r187478. rdar://problem/21838764
2015-07-27 Andreas Kling akl...@apple.com
Modified: branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (187606 => 187607)
--- branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-07-30 21:20:34 UTC (rev 187606)
+++ branches/safari-601.1-branch/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2015-07-30 21:20:38 UTC (rev 187607)
@@ -2215,6 +2215,11 @@
info.bounds = downcastRenderImage(*renderer).absoluteContentQuad().enclosingBoundingBox();
else
info.bounds = renderer-absoluteBoundingBoxRect();
+
+if (!renderer-document().frame()-isMainFrame()) {
+FrameView *view = renderer-document().frame()-view();
+info.bounds = view-contentsToRootView(info.bounds);
+}
}
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187603] branches/safari-601.1-branch/Source/WebKit2
Title: [187603] branches/safari-601.1-branch/Source/WebKit2
Revision 187603
Author matthew_han...@apple.com
Date 2015-07-30 13:23:53 -0700 (Thu, 30 Jul 2015)
Log Message
Merge r187478. rdar://problem/21838764
Modified Paths
branches/safari-601.1-branch/Source/WebKit2/ChangeLog
branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp
Diff
Modified: branches/safari-601.1-branch/Source/WebKit2/ChangeLog (187602 => 187603)
--- branches/safari-601.1-branch/Source/WebKit2/ChangeLog 2015-07-30 20:20:55 UTC (rev 187602)
+++ branches/safari-601.1-branch/Source/WebKit2/ChangeLog 2015-07-30 20:23:53 UTC (rev 187603)
@@ -1,3 +1,25 @@
+2015-07-30 Matthew Hanson matthew_han...@apple.com
+
+Merge r187478. rdar://problem/21838764
+
+2015-07-27 Andreas Kling akl...@apple.com
+
+WebsiteDataStore should clean up its storage in the network process when destroyed.
+https://webkit.org/b/147349
+rdar://problem/21838764
+
+Reviewed by Darin Adler.
+
+Have ~WebsiteDataStore() send a DestroyPrivateBrowsingSession message to all networking processes
+for ephemeral sessions. This plugs a NetworkStorageSession leak that could retain a large
+CFNetwork object graph.
+
+This complements r187115 which did the same for network process storage owned by
+API::Session objects.
+
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::~WebsiteDataStore):
+
2015-07-27 Babak Shafiei bshaf...@apple.com
Roll out r187376.
Modified: branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp (187602 => 187603)
--- branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2015-07-30 20:20:55 UTC (rev 187602)
+++ branches/safari-601.1-branch/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp 2015-07-30 20:23:53 UTC (rev 187603)
@@ -28,6 +28,7 @@
#include APIProcessPoolConfiguration.h
#include APIWebsiteDataRecord.h
+#include NetworkProcessMessages.h
#include StorageManager.h
#include WebProcessPool.h
#include WebsiteData.h
@@ -92,6 +93,13 @@
WebsiteDataStore::~WebsiteDataStore()
{
platformDestroy();
+
+#if ENABLE(NETWORK_PROCESS)
+if (m_sessionID.isEphemeral()) {
+for (auto processPool : WebProcessPool::allProcessPools())
+processPool-sendToNetworkingProcess(Messages::NetworkProcess::DestroyPrivateBrowsingSession(m_sessionID));
+}
+#endif
}
void WebsiteDataStore::cloneSessionData(WebPageProxy sourcePage, WebPageProxy newPage)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187604] branches/safari-601.1-branch
Title: [187604] branches/safari-601.1-branch
Revision 187604
Author matthew_han...@apple.com
Date 2015-07-30 13:23:56 -0700 (Thu, 30 Jul 2015)
Log Message
Merge r187504. rdar://problem/21915355
Modified Paths
branches/safari-601.1-branch/LayoutTests/ChangeLog
branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/svg/SVGElement.cpp
branches/safari-601.1-branch/Source/WebCore/svg/SVGUseElement.cpp
Added Paths
branches/safari-601.1-branch/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt
branches/safari-601.1-branch/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg
Diff
Modified: branches/safari-601.1-branch/LayoutTests/ChangeLog (187603 => 187604)
--- branches/safari-601.1-branch/LayoutTests/ChangeLog 2015-07-30 20:23:53 UTC (rev 187603)
+++ branches/safari-601.1-branch/LayoutTests/ChangeLog 2015-07-30 20:23:56 UTC (rev 187604)
@@ -1,3 +1,21 @@
+2015-07-30 Matthew Hanson matthew_han...@apple.com
+
+Merge r187504. rdar://problem/21915355
+
+2015-07-28 Said Abou-Hallawa sabouhall...@apple.com
+
+Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
+https://bugs.webkit.org/show_bug.cgi?id=147290
+
+Reviewed by Daniel Bates.
+
+Make sure we do not crash when when calling removeEventListener() for an
+element which is cloned under a disallowed parent inside the shadow tree
+of another use element.
+
+* svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt: Added.
+* svg/custom/remove-event-listener-shadow-disallowed-element.svg: Added.
+
2015-07-27 Alexey Proskuryakov a...@apple.com
More test gardening after r187346 ('' descendant combinator).
Added: branches/safari-601.1-branch/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt (0 => 187604)
--- branches/safari-601.1-branch/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt (rev 0)
+++ branches/safari-601.1-branch/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt 2015-07-30 20:23:56 UTC (rev 187604)
@@ -0,0 +1 @@
+Pass.
Added: branches/safari-601.1-branch/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg (0 => 187604)
--- branches/safari-601.1-branch/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg (rev 0)
+++ branches/safari-601.1-branch/LayoutTests/svg/custom/remove-event-listener-shadow-disallowed-element.svg 2015-07-30 20:23:56 UTC (rev 187604)
@@ -0,0 +1,37 @@
+svg version=1.1 xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+
+ defs
+svg id=green-svg width=100 height=100
+ defs
+ rect id=green-rect fill=green width=100 height=100/
+ /defs
+ use id=use-green-rect xlink:href=""
+/svg
+ /defs
+
+ use id=use-green-svg x=10 y=10 xlink:href=""
+ textPass./text
+
+ script
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+var _onAlert_ = function() {
+ alert(test);
+}
+
+// This removeEventListener() has to be called before the onload fires. Before
+// onload fires, the shadow tree of the SVGUseElement is not built. So this
+// call should affect the original element only. Once the shadow tree is built,
+// the SVGUseElement calls updateShadowTree() and this is where we want to make
+// sure the eventListeners of all the cloned elements in the shadow tree are
+// updated correctly and the disallowed cloned elements and their descendants
+// are disconnected from their corresponding elements.
+document.getElementById(green-rect).addEventListener(click, onAlert);
+
+window.addEventListener(load, function () {
+ document.getElementById(green-rect).removeEventListener(click, onAlert);
+}, false);
+ /script
+
+/svg
\ No newline at end of file
Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (187603 => 187604)
--- branches/safari-601.1-branch/Source/WebCore/ChangeLog 2015-07-30 20:23:53 UTC (rev 187603)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog 2015-07-30 20:23:56 UTC (rev 187604)
@@ -1,3 +1,27 @@
+2015-07-30 Matthew Hanson matthew_han...@apple.com
+
+Merge r187504. rdar://problem/21915355
+
+2015-07-28 Said Abou-Hallawa sabouhall...@apple.com
+
+Crash happens when calling removeEventListener for an SVG element which has an instance inside a defs element of shadow tree
+https://bugs.webkit.org/show_bug.cgi?id=147290
+
+Reviewed by Daniel Bates.
+
+When the shadow tree is built for a use element, all the SVG elements
+are allowed to be cloned in the shadow tree but later some of the
[webkit-changes] [187631] branches/safari-600.1.4.17-branch/Source/WebCore
Title: [187631] branches/safari-600.1.4.17-branch/Source/WebCore
Revision 187631
Author bshaf...@apple.com
Date 2015-07-30 18:40:13 -0700 (Thu, 30 Jul 2015)
Log Message
Roll out r187490. rdar://problem/22035036
Modified Paths
branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Diff
Modified: branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog (187630 => 187631)
--- branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog 2015-07-31 00:52:45 UTC (rev 187630)
+++ branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog 2015-07-31 01:40:13 UTC (rev 187631)
@@ -1,5 +1,9 @@
2015-07-29 Babak Shafiei bshaf...@apple.com
+Roll out r187490.
+
+2015-07-29 Babak Shafiei bshaf...@apple.com
+
Roll out r185848.
2015-07-28 Babak Shafiei bshaf...@apple.com
Modified: branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp (187630 => 187631)
--- branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-31 00:52:45 UTC (rev 187630)
+++ branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-31 01:40:13 UTC (rev 187631)
@@ -85,7 +85,6 @@
static RetainPtrCFArrayRef filterCookies(CFArrayRef unfilteredCookies)
{
-ASSERT(unfilteredCookies);
CFIndex count = CFArrayGetCount(unfilteredCookies);
RetainPtrCFMutableArrayRef filteredCookies = adoptCF(CFArrayCreateMutable(0, count, kCFTypeArrayCallBacks));
for (CFIndex i = 0; i count; ++i) {
@@ -121,11 +120,7 @@
static CFArrayRef createCookies(CFDictionaryRef headerFields, CFURLRef url)
{
-CFArrayRef parsedCookies = _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
-if (!parsedCookies)
-parsedCookies = CFArrayCreate(kCFAllocatorDefault, 0, 0, kCFTypeArrayCallBacks);
-
-return parsedCookies;
+return _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
}
void setCookiesFromDOM(const NetworkStorageSession session, const URL firstParty, const URL url, const String value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187625] trunk/Source/WebInspectorUI
Title: [187625] trunk/Source/WebInspectorUI
Revision 187625
Author drou...@apple.com
Date 2015-07-30 16:56:51 -0700 (Thu, 30 Jul 2015)
Log Message
Web Inspector: Support smart-pasting in the Rules sidebar panel
https://bugs.webkit.org/show_bug.cgi?id=147362
Reviewed by Timothy Hatcher.
When pasting over the selector, if the pasted text matches CSS rule
formatting, replace the selected rule with the selector and text in
the pasted data.
* UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype.changeRule.changeCompleted):
(WebInspector.DOMNodeStyles.prototype.changeRule.styleChanged):
(WebInspector.DOMNodeStyles.prototype.changeRule.changeText):
(WebInspector.DOMNodeStyles.prototype.changeRule.ruleSelectorChanged):
(WebInspector.DOMNodeStyles.prototype.changeRule):
* UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
(WebInspector.CSSStyleDeclarationSection):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js
trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (187624 => 187625)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-07-30 23:51:29 UTC (rev 187624)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-30 23:56:51 UTC (rev 187625)
@@ -1,3 +1,25 @@
+2015-07-30 Devin Rousso drou...@apple.com
+
+Web Inspector: Support smart-pasting in the Rules sidebar panel
+https://bugs.webkit.org/show_bug.cgi?id=147362
+
+Reviewed by Timothy Hatcher.
+
+When pasting over the selector, if the pasted text matches CSS rule
+formatting, replace the selected rule with the selector and text in
+the pasted data.
+
+* UserInterface/Models/DOMNodeStyles.js:
+(WebInspector.DOMNodeStyles.prototype.changeRule.changeCompleted):
+(WebInspector.DOMNodeStyles.prototype.changeRule.styleChanged):
+(WebInspector.DOMNodeStyles.prototype.changeRule.changeText):
+(WebInspector.DOMNodeStyles.prototype.changeRule.ruleSelectorChanged):
+(WebInspector.DOMNodeStyles.prototype.changeRule):
+* UserInterface/Views/CSSStyleDeclarationSection.js:
+(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
+(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
+(WebInspector.CSSStyleDeclarationSection):
+
2015-07-30 Matt Baker mattba...@apple.com
Web Inspector: Fix typo in frame duration filtering console.assert message
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js (187624 => 187625)
--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js 2015-07-30 23:51:29 UTC (rev 187624)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMNodeStyles.js 2015-07-30 23:56:51 UTC (rev 187625)
@@ -322,6 +322,52 @@
this._markAsNeedsRefresh();
}
+changeRule(rule, selector, text)
+{
+if (!rule)
+return;
+
+selector = selector || ;
+
+function changeCompleted()
+{
+DOMAgent.markUndoableState();
+this.refresh();
+}
+
+function styleChanged(error, stylePayload)
+{
+if (error)
+return;
+
+changeCompleted.call(this);
+}
+
+function changeText(styleId)
+{
+// COMPATIBILITY (iOS 6): CSSAgent.setStyleText was not available in iOS 6.
+if (!text || !text.length || !CSSAgent.setStyleText) {
+changeCompleted.call(this);
+return;
+}
+
+CSSAgent.setStyleText(styleId, text, styleChanged.bind(this));
+}
+
+function ruleSelectorChanged(error, rulePayload)
+{
+if (error)
+return;
+
+changeText.call(this, rulePayload.style.styleId);
+}
+
+this._needsRefresh = true;
+this._ignoreNextContentDidChangeForStyleSheet = rule.ownerStyleSheet;
+
+CSSAgent.setRuleSelector(rule.id, selector, ruleSelectorChanged.bind(this));
+}
+
changeRuleSelector(rule, selector)
{
selector = selector || ;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js (187624 => 187625)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js 2015-07-30 23:51:29 UTC (rev 187624)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js 2015-07-30 23:56:51 UTC (rev 187625)
@@ -52,6 +52,7 @@
this._selectorElement.addEventListener(mouseout, this._handleMouseOut.bind(this));
this._selectorElement.addEventListener(keydown, this._handleKeyDown.bind(this));
[webkit-changes] [187628] branches/safari-600.8-branch/Source/WebCore
Title: [187628] branches/safari-600.8-branch/Source/WebCore
Revision 187628
Author bshaf...@apple.com
Date 2015-07-30 17:37:38 -0700 (Thu, 30 Jul 2015)
Log Message
Roll out r186863. rdar://problem/21714843
Modified Paths
branches/safari-600.8-branch/Source/WebCore/ChangeLog
branches/safari-600.8-branch/Source/WebCore/platform/network/mac/CookieJarMac.mm
Diff
Modified: branches/safari-600.8-branch/Source/WebCore/ChangeLog (187627 => 187628)
--- branches/safari-600.8-branch/Source/WebCore/ChangeLog 2015-07-31 00:17:28 UTC (rev 187627)
+++ branches/safari-600.8-branch/Source/WebCore/ChangeLog 2015-07-31 00:37:38 UTC (rev 187628)
@@ -1,3 +1,7 @@
+2015-07-30 Babak Shafiei bshaf...@apple.com
+
+Roll out r186863.
+
2015-07-29 Babak Shafiei bshaf...@apple.com
Roll out r185848.
Modified: branches/safari-600.8-branch/Source/WebCore/platform/network/mac/CookieJarMac.mm (187627 => 187628)
--- branches/safari-600.8-branch/Source/WebCore/platform/network/mac/CookieJarMac.mm 2015-07-31 00:17:28 UTC (rev 187627)
+++ branches/safari-600.8-branch/Source/WebCore/platform/network/mac/CookieJarMac.mm 2015-07-31 00:37:38 UTC (rev 187628)
@@ -105,18 +105,7 @@
String cookieString = cookieStr.contains('=') ? cookieStr : cookieStr + =;
NSURL *cookieURL = url;
-NSDictionary *headerFields = [NSDictionary dictionaryWithObject:cookieString forKey:@Set-Cookie];
-
-NSArray *unfilteredCookies;
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored -Wundeclared-selector
-if ([[NSHTTPCookie class] respondsToSelector:@selector(_parsedCookiesWithResponseHeaderFields:forURL:)])
-unfilteredCookies = [NSHTTPCookie performSelector:@selector(_parsedCookiesWithResponseHeaderFields:forURL:) withObject:headerFields withObject:cookieURL];
-#pragma clang diagnostic pop
-else
-unfilteredCookies = [NSHTTPCookie cookiesWithResponseHeaderFields:headerFields forURL:cookieURL];
-
-RetainPtrNSArray filteredCookies = filterCookies(unfilteredCookies);
+RetainPtrNSArray filteredCookies = filterCookies([NSHTTPCookie cookiesWithResponseHeaderFields:[NSDictionary dictionaryWithObject:cookieString forKey:@Set-Cookie] forURL:cookieURL]);
ASSERT([filteredCookies.get() count] = 1);
wkSetHTTPCookiesForURL(session.cookieStorage().get(), filteredCookies.get(), cookieURL, firstParty);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187632] branches/safari-600.1.4.17-branch/Source/WebCore
Title: [187632] branches/safari-600.1.4.17-branch/Source/WebCore
Revision 187632
Author bshaf...@apple.com
Date 2015-07-30 18:43:22 -0700 (Thu, 30 Jul 2015)
Log Message
Roll out r187048. rdar://problem/21714851
Modified Paths
branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Diff
Modified: branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog (187631 => 187632)
--- branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog 2015-07-31 01:40:13 UTC (rev 187631)
+++ branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog 2015-07-31 01:43:22 UTC (rev 187632)
@@ -1,5 +1,9 @@
-2015-07-29 Babak Shafiei bshaf...@apple.com
+2015-07-30 Babak Shafiei bshaf...@apple.com
+Roll out r187048.
+
+2015-07-30 Babak Shafiei bshaf...@apple.com
+
Roll out r187490.
2015-07-29 Babak Shafiei bshaf...@apple.com
Modified: branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp (187631 => 187632)
--- branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-31 01:40:13 UTC (rev 187631)
+++ branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-31 01:43:22 UTC (rev 187632)
@@ -120,7 +120,11 @@
static CFArrayRef createCookies(CFDictionaryRef headerFields, CFURLRef url)
{
+#if (PLATFORM(IOS) __IPHONE_OS_VERSION_MIN_REQUIRED = 9)
return _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
+#else
+return CFHTTPCookieCreateWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
+#endif
}
void setCookiesFromDOM(const NetworkStorageSession session, const URL firstParty, const URL url, const String value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187612] trunk/LayoutTests
Title: [187612] trunk/LayoutTests
Revision 187612
Author mra...@apple.com
Date 2015-07-30 15:13:46 -0700 (Thu, 30 Jul 2015)
Log Message
Media Session: test Play/Pause media control events delivered to non-Content media sessions https://bugs.webkit.org/show_bug.cgi?id=147414
Reviewed by Eric Carlson.
* media/session/play-pause-media-events-in-non-content-sessions-expected.txt: Added.
* media/session/play-pause-media-events-in-non-content-sessions.html: Added.
* platform/mac/TestExpectations: Media Session support is disabled by default.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
Added Paths
trunk/LayoutTests/media/session/play-pause-media-events-in-non-content-sessions-expected.txt
trunk/LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html
Diff
Modified: trunk/LayoutTests/ChangeLog (187611 => 187612)
--- trunk/LayoutTests/ChangeLog 2015-07-30 21:58:23 UTC (rev 187611)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 22:13:46 UTC (rev 187612)
@@ -1,5 +1,16 @@
2015-07-29 Matt Rajca mra...@apple.com
+Media Session: test Play/Pause media control events delivered to non-Content media sessions
+https://bugs.webkit.org/show_bug.cgi?id=147414
+
+Reviewed by Eric Carlson.
+
+* media/session/play-pause-media-events-in-non-content-sessions-expected.txt: Added.
+* media/session/play-pause-media-events-in-non-content-sessions.html: Added.
+* platform/mac/TestExpectations: Media Session support is disabled by default.
+
+2015-07-29 Matt Rajca mra...@apple.com
+
Media Session: test Play/Pause media control events delivered to Content media sessions
https://bugs.webkit.org/show_bug.cgi?id=147413
Added: trunk/LayoutTests/media/session/play-pause-media-events-in-non-content-sessions-expected.txt (0 => 187612)
--- trunk/LayoutTests/media/session/play-pause-media-events-in-non-content-sessions-expected.txt (rev 0)
+++ trunk/LayoutTests/media/session/play-pause-media-events-in-non-content-sessions-expected.txt 2015-07-30 22:13:46 UTC (rev 187612)
@@ -0,0 +1,41 @@
+'Transient', 'Transient Solo', and 'Ambient' sessions should not respond to Play/Pause media control events.
+
+
+---
+Testing transient session kind
+---
+EVENT(canplaythrough)
+EVENT(playing)
+Media began playing.
+EXPECTED (video.paused == 'false') OK
+EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK
+Non-Content Media Sessions should not respond to Play/Pause events.
+Sending Play/Pause media event.
+RUN(internals.sendMediaControlEvent(play-pause))
+EXPECTED (video.paused == 'false') OK
+---
+Testing transient-solo session kind
+---
+EVENT(canplaythrough)
+EVENT(playing)
+Media began playing.
+EXPECTED (video.paused == 'false') OK
+EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK
+Non-Content Media Sessions should not respond to Play/Pause events.
+Sending Play/Pause media event.
+RUN(internals.sendMediaControlEvent(play-pause))
+EXPECTED (video.paused == 'false') OK
+---
+Testing ambient session kind
+---
+EVENT(canplaythrough)
+EVENT(playing)
+Media began playing.
+EXPECTED (video.paused == 'false') OK
+EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK
+Non-Content Media Sessions should not respond to Play/Pause events.
+Sending Play/Pause media event.
+RUN(internals.sendMediaControlEvent(play-pause))
+EXPECTED (video.paused == 'false') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html (0 => 187612)
--- trunk/LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html (rev 0)
+++ trunk/LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html 2015-07-30 22:13:46 UTC (rev 187612)
@@ -0,0 +1,63 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+script type=text/_javascript_
+var session;
+
+function runAllTests()
+{
+findMediaElement();
+waitForEvent('canplaythrough', beginPlaying);
+runTest(transient);
+}
+
+function runTest(sessionKind)
+{
+consoleWrite('---');
+consoleWrite('Testing ' + sessionKind + ' session kind');
+consoleWrite('---');
+
+session = new MediaSession(sessionKind);
+
+video.src = "" ../content/counting);
+video.session = session;
+waitForEvent('playing', beganPlaying, false, true, video);
+}
+
+function beginPlaying(event)
+{
+video.play();
+}
+
+function beganPlaying(event)
+{
+consoleWrite(Media began playing.);
+testExpected('video.paused', false);
+
+if (window.internals) {
+testExpected('internals.mediaSessionCurrentState(session)', active);
+
+
[webkit-changes] [187614] trunk/Source/WebKit2
Title: [187614] trunk/Source/WebKit2
Revision 187614
Author eric.carl...@apple.com
Date 2015-07-30 15:56:20 -0700 (Thu, 30 Jul 2015)
Log Message
[iOS] Set AirPlay discovery mode to disabled when page is hidden
https://bugs.webkit.org/show_bug.cgi?id=147455
Reviewed by Enrica Casucci.
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Set discovery mode to disabled after
the picker has been closed.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Ditto.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187613 => 187614)
--- trunk/Source/WebKit2/ChangeLog 2015-07-30 22:26:20 UTC (rev 187613)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-30 22:56:20 UTC (rev 187614)
@@ -1,3 +1,15 @@
+2015-07-30 Eric Carlson eric.carl...@apple.com
+
+[iOS] Set AirPlay discovery mode to disabled when page is hidden
+https://bugs.webkit.org/show_bug.cgi?id=147455
+
+Reviewed by Enrica Casucci.
+
+* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
+(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Set discovery mode to disabled after
+ the picker has been closed.
+(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Ditto.
+
2015-07-29 Dean Jackson d...@apple.com
Don't use (Details) when exposing SPI
Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm (187613 => 187614)
--- trunk/Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm 2015-07-30 22:26:20 UTC (rev 187613)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm 2015-07-30 22:56:20 UTC (rev 187614)
@@ -93,6 +93,10 @@
- (void)_dismissAirPlayRoutePickerIPad
{
+if (!_routingController)
+return;
+
+[_routingController setDiscoveryMode:MPRouteDiscoveryModeDisabled];
_routingController = nil;
if (!_popoverController)
@@ -134,6 +138,7 @@
return UIInterfaceOrientationMaskPortrait;
}
completionHandler:^{
+[_routingController setDiscoveryMode:MPRouteDiscoveryModeDisabled];
_routingController = nil;
_actionSheet = nil;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187616] branches/jsc-tailcall/Source/JavaScriptCore
Title: [187616] branches/jsc-tailcall/Source/_javascript_Core Revision 187616 Author basile_clem...@apple.com Date 2015-07-30 16:08:56 -0700 (Thu, 30 Jul 2015) Log Message jsc-tailcall: We should consider a tail call as an exit in the LLInt for the purpose of switching to the JIT https://bugs.webkit.org/show_bug.cgi?id=147449 Reviewed by Michael Saboff. * llint/LowLevelInterpreter.asm: Modified Paths branches/jsc-tailcall/Source/_javascript_Core/ChangeLog branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm Diff Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (187615 => 187616) --- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-30 23:07:09 UTC (rev 187615) +++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-30 23:08:56 UTC (rev 187616) @@ -1,3 +1,12 @@ +2015-07-30 Basile Clement basile_clem...@apple.com + +jsc-tailcall: We should consider a tail call as an exit in the LLInt for the purpose of switching to the JIT +https://bugs.webkit.org/show_bug.cgi?id=147449 + +Reviewed by Michael Saboff. + +* llint/LowLevelInterpreter.asm: + 2015-07-23 Basile Clement basile_clem...@apple.com Merged r187505 from trunk. Modified: branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm (187615 => 187616) --- branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2015-07-30 23:07:09 UTC (rev 187615) +++ branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2015-07-30 23:08:56 UTC (rev 187616) @@ -1312,6 +1312,7 @@ _llint_op_tail_call: traceExecution() arrayProfileForCall() +checkSwitchToJITForEpilogue() doCall(_llint_slow_path_call, prepareForTailCall) _llint_op_construct: @@ -1342,6 +1343,7 @@ _llint_op_tail_call_varargs: traceExecution() +checkSwitchToJITForEpilogue() # We lie and perform the tail call instead of preparing it since we can't # prepare the frame for a call opcode doCallVarargs(_llint_slow_path_call_varargs, prepareForTailCall) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187620] trunk
Title: [187620] trunk
Revision 187620
Author ander...@apple.com
Date 2015-07-30 16:38:23 -0700 (Thu, 30 Jul 2015)
Log Message
Assertion failure when a plug-in loads a resource that redirects somewhere
https://bugs.webkit.org/show_bug.cgi?id=147469
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/plugins/get-url-redirect.html
r186597 moved the call to addPlugInStreamLoader to willSendRequest. This is wrong since
willSendRequest can be invoked more than once.
Fix this by making the initialization phase of NetscapePlugInStreamLoader be more like
SubresourceLoader where we only call addPlugInStreamLoader once we've successfully initialized
the loader, and only call removePlugInStreamLoader if we've called addPlugInStreamLoader.
Also change addPlugInStreamLoader and removePlugInStreamLoader to take references.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::addPlugInStreamLoader):
(WebCore::DocumentLoader::removePlugInStreamLoader):
* loader/DocumentLoader.h:
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::create):
(WebCore::NetscapePlugInStreamLoader::init):
(WebCore::NetscapePlugInStreamLoader::didFinishLoading):
(WebCore::NetscapePlugInStreamLoader::didFail):
(WebCore::NetscapePlugInStreamLoader::didCancel):
(WebCore::NetscapePlugInStreamLoader::notifyDone):
* loader/NetscapePlugInStreamLoader.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest): Deleted.
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::isPlugInStreamLoader): Deleted.
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
LayoutTests:
Add a test.
* http/tests/plugins/get-url-redirect-expected.txt: Added.
* http/tests/plugins/get-url-redirect.html: Added.
* http/tests/plugins/resources/redirection-response.php: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentLoader.h
trunk/Source/WebCore/loader/NetscapePlugInStreamLoader.cpp
trunk/Source/WebCore/loader/NetscapePlugInStreamLoader.h
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/loader/ResourceLoader.h
trunk/Source/WebCore/loader/SubframeLoader.cpp
Added Paths
trunk/LayoutTests/http/tests/plugins/get-url-redirect-expected.txt
trunk/LayoutTests/http/tests/plugins/get-url-redirect.html
trunk/LayoutTests/http/tests/plugins/resources/redirection-response.php
Diff
Modified: trunk/LayoutTests/ChangeLog (187619 => 187620)
--- trunk/LayoutTests/ChangeLog 2015-07-30 23:25:43 UTC (rev 187619)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 23:38:23 UTC (rev 187620)
@@ -1,3 +1,16 @@
+2015-07-30 Anders Carlsson ander...@apple.com
+
+Assertion failure when a plug-in loads a resource that redirects somewhere
+https://bugs.webkit.org/show_bug.cgi?id=147469
+
+Reviewed by Alexey Proskuryakov.
+
+Add a test.
+
+* http/tests/plugins/get-url-redirect-expected.txt: Added.
+* http/tests/plugins/get-url-redirect.html: Added.
+* http/tests/plugins/resources/redirection-response.php: Added.
+
2015-07-29 Matt Rajca mra...@apple.com
Media Session: test Play/Pause media control events delivered to non-Content media sessions
Added: trunk/LayoutTests/http/tests/plugins/get-url-redirect-expected.txt (0 => 187620)
--- trunk/LayoutTests/http/tests/plugins/get-url-redirect-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/plugins/get-url-redirect-expected.txt 2015-07-30 23:38:23 UTC (rev 187620)
@@ -0,0 +1 @@
+This tests that NPN_GetURLNotify does not ASSERT in debug builds.
Added: trunk/LayoutTests/http/tests/plugins/get-url-redirect.html (0 => 187620)
--- trunk/LayoutTests/http/tests/plugins/get-url-redirect.html (rev 0)
+++ trunk/LayoutTests/http/tests/plugins/get-url-redirect.html 2015-07-30 23:38:23 UTC (rev 187620)
@@ -0,0 +1,19 @@
+html
+body
+This tests that NPN_GetURLNotify does not ASSERT in debug builds.
+embed name=plg type=application/x-webkit-test-netscape/embed
+script
+function notify()
+{
+if (window.testRunner)
+testRunner.notifyDone();
+}
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+plg.getURLNotify(resources/redirection-response.php?status=301target=load-me-1.txt, null, notify);
+/script
+/body
+/html
Added: trunk/LayoutTests/http/tests/plugins/resources/redirection-response.php (0 => 187620)
--- trunk/LayoutTests/http/tests/plugins/resources/redirection-response.php (rev 0)
+++ trunk/LayoutTests/http/tests/plugins/resources/redirection-response.php 2015-07-30 23:38:23 UTC (rev 187620)
@@ -0,0 +1,31 @@
+?php
+$status_code = $_GET['status'];
+
+$uri = rtrim(dirname($_SERVER['PHP_SELF']), '/\\') . / . $_GET['target'];
+
+$host = $_SERVER['HTTP_HOST'];
+if (isset($_GET['host']))
+$host =
[webkit-changes] [187624] trunk/Tools
Title: [187624] trunk/Tools
Revision 187624
Author ander...@apple.com
Date 2015-07-30 16:51:29 -0700 (Thu, 30 Jul 2015)
Log Message
Add support for window.open to WK1BrowserWindowController
https://bugs.webkit.org/show_bug.cgi?id=147474
Reviewed by Dan Bernstein.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
Set _javascript_CanOpenWindowsAutomatically to YES.
If this becomes a nuisance, we can always add a menu item to toggle this.
(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
Implement this UI delegate method.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m
Diff
Modified: trunk/Tools/ChangeLog (187623 => 187624)
--- trunk/Tools/ChangeLog 2015-07-30 23:47:57 UTC (rev 187623)
+++ trunk/Tools/ChangeLog 2015-07-30 23:51:29 UTC (rev 187624)
@@ -1,5 +1,20 @@
2015-07-30 Anders Carlsson ander...@apple.com
+Add support for window.open to WK1BrowserWindowController
+https://bugs.webkit.org/show_bug.cgi?id=147474
+
+Reviewed by Dan Bernstein.
+
+* MiniBrowser/mac/WK1BrowserWindowController.m:
+(-[WK1BrowserWindowController awakeFromNib]):
+Set _javascript_CanOpenWindowsAutomatically to YES.
+If this becomes a nuisance, we can always add a menu item to toggle this.
+
+(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
+Implement this UI delegate method.
+
+2015-07-30 Anders Carlsson ander...@apple.com
+
Undo stray commit.
* MiniBrowser/mac/WK1BrowserWindowController.m:
Modified: trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m (187623 => 187624)
--- trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2015-07-30 23:47:57 UTC (rev 187623)
+++ trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2015-07-30 23:51:29 UTC (rev 187624)
@@ -52,6 +52,7 @@
[[WebPreferences standardPreferences] setDeveloperExtrasEnabled:YES];
[[WebPreferences standardPreferences] setImageControlsEnabled:YES];
[[WebPreferences standardPreferences] setServiceControlsEnabled:YES];
+[[WebPreferences standardPreferences] setJavaScriptCanOpenWindowsAutomatically:YES];
[_webView _listenForLayoutMilestones:WebDidFirstLayout | WebDidFirstVisuallyNonEmptyLayout | WebDidHitRelevantRepaintedObjectsAreaThreshold];
@@ -312,6 +313,14 @@
[self.window setTitle:[title stringByAppendingString:@ [WK1]]];
}
+- (WebView *)webView:(WebView *)sender createWebViewWithRequest:(NSURLRequest *)request
+{
+WK1BrowserWindowController *newBrowserWindowController = [[WK1BrowserWindowController alloc] initWithWindowNibName:@BrowserWindow];
+[newBrowserWindowController.window makeKeyAndOrderFront:self];
+
+return newBrowserWindowController-_webView;
+}
+
- (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame
{
if (frame != [sender mainFrame])
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187611] trunk/LayoutTests
Title: [187611] trunk/LayoutTests
Revision 187611
Author mra...@apple.com
Date 2015-07-30 14:58:23 -0700 (Thu, 30 Jul 2015)
Log Message
Media Session: test Play/Pause media control events delivered to Content media sessions
https://bugs.webkit.org/show_bug.cgi?id=147413
Reviewed by Eric Carlson.
* media/session/play-pause-media-events-in-content-sessions-expected.txt: Added.
* media/session/play-pause-media-events-in-content-sessions.html: Added.
* platform/mac/TestExpectations: Media Session support is disabled by default.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
Added Paths
trunk/LayoutTests/media/session/play-pause-media-events-in-content-sessions-expected.txt
trunk/LayoutTests/media/session/play-pause-media-events-in-content-sessions.html
Diff
Modified: trunk/LayoutTests/ChangeLog (187610 => 187611)
--- trunk/LayoutTests/ChangeLog 2015-07-30 21:50:44 UTC (rev 187610)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 21:58:23 UTC (rev 187611)
@@ -1,3 +1,14 @@
+2015-07-29 Matt Rajca mra...@apple.com
+
+Media Session: test Play/Pause media control events delivered to Content media sessions
+https://bugs.webkit.org/show_bug.cgi?id=147413
+
+Reviewed by Eric Carlson.
+
+* media/session/play-pause-media-events-in-content-sessions-expected.txt: Added.
+* media/session/play-pause-media-events-in-content-sessions.html: Added.
+* platform/mac/TestExpectations: Media Session support is disabled by default.
+
2015-07-30 Aakash Jain aakash_j...@apple.com
Replace Google App Engine with AppScale
Added: trunk/LayoutTests/media/session/play-pause-media-events-in-content-sessions-expected.txt (0 => 187611)
--- trunk/LayoutTests/media/session/play-pause-media-events-in-content-sessions-expected.txt (rev 0)
+++ trunk/LayoutTests/media/session/play-pause-media-events-in-content-sessions-expected.txt 2015-07-30 21:58:23 UTC (rev 187611)
@@ -0,0 +1,21 @@
+'Content' sessions that are active should respond to Play/Pause media control events.
+
+
+EVENT(canplaythrough)
+EXPECTED (internals.mediaSessionCurrentState(session) == 'idle') OK
+Idle Media Sessions should not respond to Play/Pause events.
+EXPECTED (video.paused == 'true') OK
+Sending Play/Pause media event.
+RUN(internals.sendMediaControlEvent(play-pause))
+EXPECTED (video.paused == 'true') OK
+
+Playing media.
+EVENT(playing)
+Media began playing.
+EXPECTED (video.paused == 'false') OK
+EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK
+Sending Play/Pause media event.
+RUN(internals.sendMediaControlEvent(play-pause))
+EXPECTED (video.paused == 'true') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/session/play-pause-media-events-in-content-sessions.html (0 => 187611)
--- trunk/LayoutTests/media/session/play-pause-media-events-in-content-sessions.html (rev 0)
+++ trunk/LayoutTests/media/session/play-pause-media-events-in-content-sessions.html 2015-07-30 21:58:23 UTC (rev 187611)
@@ -0,0 +1,61 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+script type=text/_javascript_
+var session;
+
+function runTest()
+{
+session = new MediaSession(content);
+
+findMediaElement();
+waitForEvent('canplaythrough', beginPlaying);
+video.src = "" ../content/counting);
+video.session = session;
+waitForEvent('playing', beganPlaying, false, true, video);
+}
+
+function beginPlaying(event)
+{
+if (window.internals)
+testExpected('internals.mediaSessionCurrentState(session)', idle);
+
+consoleWrite(Idle Media Sessions should not respond to Play/Pause events.);
+
+testExpected('video.paused', true);
+
+if (window.internals) {
+consoleWrite(Sending Play/Pause media event.);
+run('internals.sendMediaControlEvent(play-pause)');
+testExpected('video.paused', true);
+}
+
+consoleWrite();
+consoleWrite(Playing media.);
+video.play();
+}
+
+function beganPlaying(event)
+{
+consoleWrite(Media began playing.);
+testExpected('video.paused', false);
+
+if (window.internals) {
+testExpected('internals.mediaSessionCurrentState(session)', active);
+
+consoleWrite(Sending Play/Pause media event.);
+run('internals.sendMediaControlEvent(play-pause)');
+testExpected('video.paused', true);
+}
+
+endTest();
+}
+/script
+/head
+body _onload_=runTest()
+p'Content' sessions that are active should respond to Play/Pause media control events./p
+video id=video /
+/body
+/html
Modified:
[webkit-changes] [187613] trunk/Source/WebCore
Title: [187613] trunk/Source/WebCore
Revision 187613
Author mra...@apple.com
Date 2015-07-30 15:26:20 -0700 (Thu, 30 Jul 2015)
Log Message
[Mac] Media Session: add support for more telephony interruptions
https://bugs.webkit.org/show_bug.cgi?id=147079
Reviewed by Eric Carlson.
* platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm:
(WebCore::callDidEndRinging): End 'Transient' interruptions.
(WebCore::callDidConnect): Forward this event to media sessions as a 'Content' interruption.
(WebCore::MediaSessionInterruptionProviderMac::beginListeningForInterruptions): Register observers for new
notification types.
(WebCore::MediaSessionInterruptionProviderMac::stopListeningForInterruptions): Unregister all observers.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (187612 => 187613)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 22:13:46 UTC (rev 187612)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 22:26:20 UTC (rev 187613)
@@ -1,3 +1,17 @@
+2015-07-18 Matt Rajca mra...@apple.com
+
+[Mac] Media Session: add support for more telephony interruptions
+https://bugs.webkit.org/show_bug.cgi?id=147079
+
+Reviewed by Eric Carlson.
+
+* platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm:
+(WebCore::callDidEndRinging): End 'Transient' interruptions.
+(WebCore::callDidConnect): Forward this event to media sessions as a 'Content' interruption.
+(WebCore::MediaSessionInterruptionProviderMac::beginListeningForInterruptions): Register observers for new
+ notification types.
+(WebCore::MediaSessionInterruptionProviderMac::stopListeningForInterruptions): Unregister all observers.
+
2015-07-29 Dean Jackson d...@apple.com
Don't use (Details) when exposing SPI
Modified: trunk/Source/WebCore/platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm (187612 => 187613)
--- trunk/Source/WebCore/platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm 2015-07-30 22:13:46 UTC (rev 187612)
+++ trunk/Source/WebCore/platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm 2015-07-30 22:26:20 UTC (rev 187613)
@@ -33,6 +33,8 @@
namespace WebCore {
static const CFStringRef callDidBeginRingingNotification = CFSTR(CallDidBeginRinging);
+static const CFStringRef callDidEndRingingNotification = CFSTR(CallDidEndRinging);
+static const CFStringRef callDidConnectNotification = CFSTR(CallDidConnect);
static void callDidBeginRinging(CFNotificationCenterRef, void* observer, CFStringRef, const void*, CFDictionaryRef)
{
@@ -41,14 +43,33 @@
provider-client().didReceiveStartOfInterruptionNotification(MediaSessionInterruptingCategory::Transient);
}
+static void callDidEndRinging(CFNotificationCenterRef, void* observer, CFStringRef, const void*, CFDictionaryRef)
+{
+ASSERT_ARG(observer, observer);
+MediaSessionInterruptionProviderMac* provider = (MediaSessionInterruptionProviderMac*)observer;
+provider-client().didReceiveEndOfInterruptionNotification(MediaSessionInterruptingCategory::Transient);
+}
+
+static void callDidConnect(CFNotificationCenterRef, void* observer, CFStringRef, const void*, CFDictionaryRef)
+{
+ASSERT_ARG(observer, observer);
+MediaSessionInterruptionProviderMac* provider = (MediaSessionInterruptionProviderMac*)observer;
+MediaSessionInterruptionProviderClient client = provider-client();
+client.didReceiveEndOfInterruptionNotification(MediaSessionInterruptingCategory::Transient);
+client.didReceiveStartOfInterruptionNotification(MediaSessionInterruptingCategory::Content);
+}
+
void MediaSessionInterruptionProviderMac::beginListeningForInterruptions()
{
-CFNotificationCenterAddObserver(CFNotificationCenterGetDistributedCenter(), this, callDidBeginRinging, callDidBeginRingingNotification, nullptr, CFNotificationSuspensionBehaviorDeliverImmediately);
+CFNotificationCenterRef notificationCenter = CFNotificationCenterGetDistributedCenter();
+CFNotificationCenterAddObserver(notificationCenter, this, callDidBeginRinging, callDidBeginRingingNotification, nullptr, CFNotificationSuspensionBehaviorDeliverImmediately);
+CFNotificationCenterAddObserver(notificationCenter, this, callDidEndRinging, callDidEndRingingNotification, nullptr, CFNotificationSuspensionBehaviorDeliverImmediately);
+CFNotificationCenterAddObserver(notificationCenter, this, callDidConnect, callDidConnectNotification, nullptr, CFNotificationSuspensionBehaviorDeliverImmediately);
}
void MediaSessionInterruptionProviderMac::stopListeningForInterruptions()
{
-CFNotificationCenterRemoveObserver(CFNotificationCenterGetDistributedCenter(), this, callDidBeginRingingNotification, nullptr);
+CFNotificationCenterRemoveEveryObserver(CFNotificationCenterGetDistributedCenter(), this);
}
} // namespace WebCore
[webkit-changes] [187617] trunk/Source/WebCore
Title: [187617] trunk/Source/WebCore
Revision 187617
Author jer.no...@apple.com
Date 2015-07-30 16:17:45 -0700 (Thu, 30 Jul 2015)
Log Message
[iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=147367
Reviewed by Eric Carlson.
During the request to exit fullscreen, the video element's m_videoFullscreenMode variable
is set, but no exitFullscreen() request is sent up to the UIProcess. Previous threading
issues have been discovered and fixed, but may have been re-introduced (or never fully
fixed in the first place). To solve the bad behavior this threading issue creates, add
a watchdog timer, similar to the one used in the desktop fullscreen controller, to ensure
that if an exit fullscreen request is not acted upon, the UIProcess forcibly exits fullscreen
anyway.
* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit): Initialize the timer.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Cancel the timer.
(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason): Set the timer.
(WebVideoFullscreenInterfaceAVKit::watchdogTimerFired): Forcibly exit fullscreen mode.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (187616 => 187617)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 23:08:56 UTC (rev 187616)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 23:17:45 UTC (rev 187617)
@@ -1,3 +1,25 @@
+2015-07-30 Jer Noble jer.no...@apple.com
+
+[iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fullscreen
+https://bugs.webkit.org/show_bug.cgi?id=147367
+
+Reviewed by Eric Carlson.
+
+During the request to exit fullscreen, the video element's m_videoFullscreenMode variable
+is set, but no exitFullscreen() request is sent up to the UIProcess. Previous threading
+issues have been discovered and fixed, but may have been re-introduced (or never fully
+fixed in the first place). To solve the bad behavior this threading issue creates, add
+a watchdog timer, similar to the one used in the desktop fullscreen controller, to ensure
+that if an exit fullscreen request is not acted upon, the UIProcess forcibly exits fullscreen
+anyway.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+(WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit): Initialize the timer.
+(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Cancel the timer.
+(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason): Set the timer.
+(WebVideoFullscreenInterfaceAVKit::watchdogTimerFired): Forcibly exit fullscreen mode.
+
2015-07-30 Myles C. Maxfield mmaxfi...@apple.com
Clean up makeFontCascadeCacheKey()
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h (187616 => 187617)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h 2015-07-30 23:08:56 UTC (rev 187616)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h 2015-07-30 23:17:45 UTC (rev 187617)
@@ -32,6 +32,7 @@
#include WebCore/EventListener.h
#include WebCore/HTMLMediaElementEnums.h
#include WebCore/PlatformLayer.h
+#include WebCore/Timer.h
#include WebCore/WebVideoFullscreenInterface.h
#include functional
#include objc/objc.h
@@ -132,6 +133,7 @@
void beginSession();
void enterPictureInPicture();
void enterFullscreenStandard();
+void watchdogTimerFired();
RetainPtrWebAVPlayerController m_playerController;
RetainPtrAVPlayerViewController m_playerViewController;
@@ -146,6 +148,7 @@
RetainPtrWebAVPlayerLayerView m_playerLayerView;
HTMLMediaElementEnums::VideoFullscreenMode m_mode { HTMLMediaElementEnums::VideoFullscreenModeNone };
std::functionvoid(bool) m_prepareToInlineCallback;
+Timer m_watchdogTimer;
bool m_allowsPictureInPicturePlayback { false };
bool m_exitRequested { false };
bool m_exitCompleted { false };
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (187616 => 187617)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-07-30 23:08:56 UTC (rev 187616)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-07-30 23:17:45 UTC (rev 187617)
@@ -77,6 +77,7 @@
}
#endif
+static const double DefaultWatchdogTimerInterval = 1;
@class WebAVMediaSelectionOption;
@@ -870,6 +871,7 @@
WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit()
: m_playerController(adoptNS([[WebAVPlayerController alloc] init]))
+,
[webkit-changes] [187621] trunk/Source/WebCore
Title: [187621] trunk/Source/WebCore
Revision 187621
Author simon.fra...@apple.com
Date 2015-07-30 16:41:54 -0700 (Thu, 30 Jul 2015)
Log Message
Make Path::apply() take a function reference
https://bugs.webkit.org/show_bug.cgi?id=147472
Reviewed by Anders Carlsson.
Path::apply() should take a const reference to a std::function.
* platform/graphics/Path.h:
* platform/graphics/cairo/PathCairo.cpp:
* platform/graphics/cg/PathCG.cpp:
(WebCore::CGPathApplierToPathApplier):
(WebCore::Path::apply):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/Path.h
trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187620 => 187621)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 23:38:23 UTC (rev 187620)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 23:41:54 UTC (rev 187621)
@@ -1,3 +1,18 @@
+2015-07-30 Simon Fraser simon.fra...@apple.com
+
+Make Path::apply() take a function reference
+https://bugs.webkit.org/show_bug.cgi?id=147472
+
+Reviewed by Anders Carlsson.
+
+Path::apply() should take a const reference to a std::function.
+
+* platform/graphics/Path.h:
+* platform/graphics/cairo/PathCairo.cpp:
+* platform/graphics/cg/PathCG.cpp:
+(WebCore::CGPathApplierToPathApplier):
+(WebCore::Path::apply):
+
2015-07-30 Anders Carlsson ander...@apple.com
Assertion failure when a plug-in loads a resource that redirects somewhere
Modified: trunk/Source/WebCore/platform/graphics/Path.h (187620 => 187621)
--- trunk/Source/WebCore/platform/graphics/Path.h 2015-07-30 23:38:23 UTC (rev 187620)
+++ trunk/Source/WebCore/platform/graphics/Path.h 2015-07-30 23:41:54 UTC (rev 187621)
@@ -155,7 +155,7 @@
// ensurePlatformPath() will allocate a PlatformPath if it has not yet been and will never return null.
WEBCORE_EXPORT PlatformPathPtr ensurePlatformPath();
-WEBCORE_EXPORT void apply(PathApplierFunction) const;
+WEBCORE_EXPORT void apply(const PathApplierFunction) const;
void transform(const AffineTransform);
void addBeziersForRoundedRect(const FloatRect, const FloatSize topLeftRadius, const FloatSize topRightRadius, const FloatSize bottomLeftRadius, const FloatSize bottomRightRadius);
Modified: trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp (187620 => 187621)
--- trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp 2015-07-30 23:38:23 UTC (rev 187620)
+++ trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp 2015-07-30 23:41:54 UTC (rev 187621)
@@ -390,7 +390,7 @@
return cairo_in_stroke(cr, point.x(), point.y());
}
-void Path::apply(PathApplierFunction function) const
+void Path::apply(const PathApplierFunction function) const
{
if (isNull())
return;
Modified: trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp (187620 => 187621)
--- trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp 2015-07-30 23:38:23 UTC (rev 187620)
+++ trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp 2015-07-30 23:41:54 UTC (rev 187621)
@@ -375,9 +375,9 @@
return CGPathGetCurrentPoint(m_path);
}
-static void CGPathApplierToPathApplier(void *info, const CGPathElement* element)
+static void CGPathApplierToPathApplier(void* info, const CGPathElement* element)
{
-PathApplierFunction function = *(PathApplierFunction*)info;
+const PathApplierFunction function = *(PathApplierFunction*)info;
FloatPoint points[3];
PathElement pelement;
pelement.type = (PathElementType)element-type;
@@ -403,12 +403,12 @@
function(pelement);
}
-void Path::apply(PathApplierFunction function) const
+void Path::apply(const PathApplierFunction function) const
{
if (isNull())
return;
-CGPathApply(m_path, function, CGPathApplierToPathApplier);
+CGPathApply(m_path, (void*)function, CGPathApplierToPathApplier);
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187623] trunk/Tools
Title: [187623] trunk/Tools
Revision 187623
Author ander...@apple.com
Date 2015-07-30 16:47:57 -0700 (Thu, 30 Jul 2015)
Log Message
Undo stray commit.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m
Diff
Modified: trunk/Tools/ChangeLog (187622 => 187623)
--- trunk/Tools/ChangeLog 2015-07-30 23:46:11 UTC (rev 187622)
+++ trunk/Tools/ChangeLog 2015-07-30 23:47:57 UTC (rev 187623)
@@ -1,3 +1,11 @@
+2015-07-30 Anders Carlsson ander...@apple.com
+
+Undo stray commit.
+
+* MiniBrowser/mac/WK1BrowserWindowController.m:
+(-[WK1BrowserWindowController awakeFromNib]):
+(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
+
2015-07-29 Dean Jackson d...@apple.com
Don't use (Details) when exposing SPI
Modified: trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m (187622 => 187623)
--- trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2015-07-30 23:46:11 UTC (rev 187622)
+++ trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2015-07-30 23:47:57 UTC (rev 187623)
@@ -52,7 +52,6 @@
[[WebPreferences standardPreferences] setDeveloperExtrasEnabled:YES];
[[WebPreferences standardPreferences] setImageControlsEnabled:YES];
[[WebPreferences standardPreferences] setServiceControlsEnabled:YES];
-[[WebPreferences standardPreferences] setJavaScriptCanOpenWindowsAutomatically:YES];
[_webView _listenForLayoutMilestones:WebDidFirstLayout | WebDidFirstVisuallyNonEmptyLayout | WebDidHitRelevantRepaintedObjectsAreaThreshold];
@@ -313,14 +312,6 @@
[self.window setTitle:[title stringByAppendingString:@ [WK1]]];
}
-- (WebView *)webView:(WebView *)sender createWebViewWithRequest:(NSURLRequest *)request
-{
-WK1BrowserWindowController *newBrowserWindowController = [[WK1BrowserWindowController alloc] initWithWindowNibName:@BrowserWindow];
-[newBrowserWindowController.window makeKeyAndOrderFront:self];
-
-return newBrowserWindowController-_webView;
-}
-
- (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame
{
if (frame != [sender mainFrame])
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187610] branches/safari-601.1-branch/Source/WebCore
Title: [187610] branches/safari-601.1-branch/Source/WebCore
Revision 187610
Author matthew_han...@apple.com
Date 2015-07-30 14:50:44 -0700 (Thu, 30 Jul 2015)
Log Message
Merge r187490. rdar://problem/21995928
Modified Paths
branches/safari-601.1-branch/Source/WebCore/ChangeLog
branches/safari-601.1-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Diff
Modified: branches/safari-601.1-branch/Source/WebCore/ChangeLog (187609 => 187610)
--- branches/safari-601.1-branch/Source/WebCore/ChangeLog 2015-07-30 21:22:47 UTC (rev 187609)
+++ branches/safari-601.1-branch/Source/WebCore/ChangeLog 2015-07-30 21:50:44 UTC (rev 187610)
@@ -1,5 +1,20 @@
2015-07-30 Matthew Hanson matthew_han...@apple.com
+Merge r187490. rdar://problem/21995928
+
+2015-07-28 Brady Eidson beid...@apple.com
+
+Handle null CFArrayRef returning from _CFHTTPParsedCookiesWithResponseHeaderFields.
+rdar://problem/21995928 and https://bugs.webkit.org/show_bug.cgi?id=147365
+
+Reviewed by Alexey Proskuryakov.
+
+* platform/network/cf/CookieJarCFNet.cpp:
+(WebCore::filterCookies): ASSERT the input is not null.
+(WebCore::createCookies): Always return a CFArrayRef, even if it's empty.
+
+2015-07-30 Matthew Hanson matthew_han...@apple.com
+
Merge r187278. rdar://problem/19908029
2015-07-23 Nan Wang n_w...@apple.com
Modified: branches/safari-601.1-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp (187609 => 187610)
--- branches/safari-601.1-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-30 21:22:47 UTC (rev 187609)
+++ branches/safari-601.1-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-30 21:50:44 UTC (rev 187610)
@@ -80,6 +80,7 @@
static RetainPtrCFArrayRef filterCookies(CFArrayRef unfilteredCookies)
{
+ASSERT(unfilteredCookies);
CFIndex count = CFArrayGetCount(unfilteredCookies);
RetainPtrCFMutableArrayRef filteredCookies = adoptCF(CFArrayCreateMutable(0, count, kCFTypeArrayCallBacks));
for (CFIndex i = 0; i count; ++i) {
@@ -116,10 +117,14 @@
static CFArrayRef createCookies(CFDictionaryRef headerFields, CFURLRef url)
{
#if (PLATFORM(IOS) __IPHONE_OS_VERSION_MIN_REQUIRED = 9)
-return _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
+CFArrayRef parsedCookies = _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
#else
-return CFHTTPCookieCreateWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
+CFArrayRef parsedCookies = CFHTTPCookieCreateWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
#endif
+if (!parsedCookies)
+parsedCookies = CFArrayCreate(kCFAllocatorDefault, 0, 0, kCFTypeArrayCallBacks);
+
+return parsedCookies;
}
void setCookiesFromDOM(const NetworkStorageSession session, const URL firstParty, const URL url, const String value)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187615] trunk/Source/WebCore
Title: [187615] trunk/Source/WebCore
Revision 187615
Author mmaxfi...@apple.com
Date 2015-07-30 16:07:09 -0700 (Thu, 30 Jul 2015)
Log Message
Clean up makeFontCascadeCacheKey()
https://bugs.webkit.org/show_bug.cgi?id=147430
Reviewed by Benjamin Poulain.
FontDescriptionKey is designed to encapsulate all the cacheable properties of a FontDescription.
However, a higher-level cache, FontCascadeCacheKey, was taking some values from FontDescriptions.
The fact that there wasn't a bug before is just a happy coincidence. This patch moves those bits
from the higher-level cache and puts them into FontDescriptionKey where they belong.
No new tests because there is no behavior change.
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::makeFlagKey):
* platform/graphics/FontCascade.cpp:
(WebCore::operator==):
(WebCore::makeFontSelectorFlags): Deleted.
(WebCore::makeFontCascadeCacheKey): Deleted.
(WebCore::computeFontCascadeCacheHash): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187614 => 187615)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 22:56:20 UTC (rev 187614)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 23:07:09 UTC (rev 187615)
@@ -1,3 +1,25 @@
+2015-07-30 Myles C. Maxfield mmaxfi...@apple.com
+
+Clean up makeFontCascadeCacheKey()
+https://bugs.webkit.org/show_bug.cgi?id=147430
+
+Reviewed by Benjamin Poulain.
+
+FontDescriptionKey is designed to encapsulate all the cacheable properties of a FontDescription.
+However, a higher-level cache, FontCascadeCacheKey, was taking some values from FontDescriptions.
+The fact that there wasn't a bug before is just a happy coincidence. This patch moves those bits
+from the higher-level cache and puts them into FontDescriptionKey where they belong.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/FontCache.h:
+(WebCore::FontDescriptionKey::makeFlagKey):
+* platform/graphics/FontCascade.cpp:
+(WebCore::operator==):
+(WebCore::makeFontSelectorFlags): Deleted.
+(WebCore::makeFontCascadeCacheKey): Deleted.
+(WebCore::computeFontCascadeCacheHash): Deleted.
+
2015-07-18 Matt Rajca mra...@apple.com
[Mac] Media Session: add support for more telephony interruptions
Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (187614 => 187615)
--- trunk/Source/WebCore/platform/graphics/FontCache.h 2015-07-30 22:56:20 UTC (rev 187614)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h 2015-07-30 23:07:09 UTC (rev 187615)
@@ -79,7 +79,10 @@
{ }
static unsigned makeFlagKey(const FontDescription description)
{
-return static_castunsigned(description.fontSynthesis()) 6
+static_assert(USCRIPT_CODE_LIMIT 0x1000, Script code must fit in an unsigned along with the other flags);
+return static_castunsigned(description.script()) 9
+| static_castunsigned(description.smallCaps()) 8
+| static_castunsigned(description.fontSynthesis()) 6
| static_castunsigned(description.widthVariant()) 4
| static_castunsigned(description.nonCJKGlyphOrientation()) 3
| static_castunsigned(description.orientation()) 2
Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (187614 => 187615)
--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2015-07-30 22:56:20 UTC (rev 187614)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp 2015-07-30 23:07:09 UTC (rev 187615)
@@ -183,7 +183,6 @@
VectorAtomicString, 3 families;
unsigned fontSelectorId;
unsigned fontSelectorVersion;
-unsigned fontSelectorFlags;
};
struct FontCascadeCacheEntry {
@@ -203,7 +202,7 @@
{
if (a.fontDescriptionKey != b.fontDescriptionKey)
return false;
-if (a.fontSelectorId != b.fontSelectorId || a.fontSelectorVersion != b.fontSelectorVersion || a.fontSelectorFlags != b.fontSelectorFlags)
+if (a.fontSelectorId != b.fontSelectorId || a.fontSelectorVersion != b.fontSelectorVersion)
return false;
if (a.families.size() != b.families.size())
return false;
@@ -231,11 +230,6 @@
value-fonts.get().widthCache().clear();
}
-static unsigned makeFontSelectorFlags(const FontDescription description)
-{
-return static_castunsigned(description.script()) 1 | static_castunsigned(description.smallCaps());
-}
-
static FontCascadeCacheKey makeFontCascadeCacheKey(const FontDescription description, FontSelector* fontSelector)
{
FontCascadeCacheKey key;
@@ -244,7 +238,6 @@
key.families.append(description.familyAt(i));
key.fontSelectorId = fontSelector ? fontSelector-uniqueId() : 0;
key.fontSelectorVersion = fontSelector ? fontSelector-version() : 0;
-
[webkit-changes] [187622] trunk
Title: [187622] trunk
Revision 187622
Author ander...@apple.com
Date 2015-07-30 16:46:11 -0700 (Thu, 30 Jul 2015)
Log Message
Remove stray printf.
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubframeLoader.cpp
trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m
Diff
Modified: trunk/Source/WebCore/ChangeLog (187621 => 187622)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 23:41:54 UTC (rev 187621)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 23:46:11 UTC (rev 187622)
@@ -1,3 +1,10 @@
+2015-07-30 Anders Carlsson ander...@apple.com
+
+Remove stray printf.
+
+* loader/SubframeLoader.cpp:
+(WebCore::SubframeLoader::requestObject):
+
2015-07-30 Simon Fraser simon.fra...@apple.com
Make Path::apply() take a function reference
Modified: trunk/Source/WebCore/loader/SubframeLoader.cpp (187621 => 187622)
--- trunk/Source/WebCore/loader/SubframeLoader.cpp 2015-07-30 23:41:54 UTC (rev 187621)
+++ trunk/Source/WebCore/loader/SubframeLoader.cpp 2015-07-30 23:46:11 UTC (rev 187622)
@@ -212,7 +212,6 @@
bool SubframeLoader::requestObject(HTMLPlugInImageElement ownerElement, const String url, const AtomicString frameName, const String mimeType, const VectorString paramNames, const VectorString paramValues)
{
-printf(request oject url %s mime type %s\n, url.ascii().data(), mimeType.ascii().data());
if (url.isEmpty() mimeType.isEmpty())
return false;
Modified: trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m (187621 => 187622)
--- trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2015-07-30 23:41:54 UTC (rev 187621)
+++ trunk/Tools/MiniBrowser/mac/WK1BrowserWindowController.m 2015-07-30 23:46:11 UTC (rev 187622)
@@ -52,6 +52,7 @@
[[WebPreferences standardPreferences] setDeveloperExtrasEnabled:YES];
[[WebPreferences standardPreferences] setImageControlsEnabled:YES];
[[WebPreferences standardPreferences] setServiceControlsEnabled:YES];
+[[WebPreferences standardPreferences] setJavaScriptCanOpenWindowsAutomatically:YES];
[_webView _listenForLayoutMilestones:WebDidFirstLayout | WebDidFirstVisuallyNonEmptyLayout | WebDidHitRelevantRepaintedObjectsAreaThreshold];
@@ -312,6 +313,14 @@
[self.window setTitle:[title stringByAppendingString:@ [WK1]]];
}
+- (WebView *)webView:(WebView *)sender createWebViewWithRequest:(NSURLRequest *)request
+{
+WK1BrowserWindowController *newBrowserWindowController = [[WK1BrowserWindowController alloc] initWithWindowNibName:@BrowserWindow];
+[newBrowserWindowController.window makeKeyAndOrderFront:self];
+
+return newBrowserWindowController-_webView;
+}
+
- (void)webView:(WebView *)sender didCommitLoadForFrame:(WebFrame *)frame
{
if (frame != [sender mainFrame])
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187627] trunk/Source/WebKit2
Title: [187627] trunk/Source/WebKit2
Revision 187627
Author commit-qu...@webkit.org
Date 2015-07-30 17:17:28 -0700 (Thu, 30 Jul 2015)
Log Message
LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1
https://bugs.webkit.org/show_bug.cgi?id=147456
Patch by Joseph Pecoraro pecor...@apple.com on 2015-07-30
Reviewed by Timothy Hatcher.
By default, WebKit2 WebPage's on PLATFORM(COCOA) enabling DOM Timer
throttling. Under testing, this ends up impacting Web Inspector
tests that create their own WKWebView which never gets displayed
and so gets throttled. Disable throttling on the Inspector's view
during testing.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _hiddenPageDOMTimerThrottlingEnabled]):
(-[WKPreferences _setHiddenPageDOMTimerThrottlingEnabled:]):
SPI to toggle DOM timer throttling.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage):
* UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::isUnderTest):
Provide a way to get if we are under test, and set it before
calling into the platform method.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
When testing, disable timer throttling.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h
trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp
trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h
trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187626 => 187627)
--- trunk/Source/WebKit2/ChangeLog 2015-07-31 00:12:38 UTC (rev 187626)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-31 00:17:28 UTC (rev 187627)
@@ -1,3 +1,33 @@
+2015-07-30 Joseph Pecoraro pecor...@apple.com
+
+LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=147456
+
+Reviewed by Timothy Hatcher.
+
+By default, WebKit2 WebPage's on PLATFORM(COCOA) enabling DOM Timer
+throttling. Under testing, this ends up impacting Web Inspector
+tests that create their own WKWebView which never gets displayed
+and so gets throttled. Disable throttling on the Inspector's view
+during testing.
+
+* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
+* UIProcess/API/Cocoa/WKPreferences.mm:
+(-[WKPreferences _hiddenPageDOMTimerThrottlingEnabled]):
+(-[WKPreferences _setHiddenPageDOMTimerThrottlingEnabled:]):
+SPI to toggle DOM timer throttling.
+
+* UIProcess/WebInspectorProxy.cpp:
+(WebKit::WebInspectorProxy::createInspectorPage):
+* UIProcess/WebInspectorProxy.h:
+(WebKit::WebInspectorProxy::isUnderTest):
+Provide a way to get if we are under test, and set it before
+calling into the platform method.
+
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(WebKit::WebInspectorProxy::platformCreateInspectorPage):
+When testing, disable timer throttling.
+
2015-07-30 Eric Carlson eric.carl...@apple.com
[iOS] Set AirPlay discovery mode to disabled when page is hidden
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm (187626 => 187627)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2015-07-31 00:12:38 UTC (rev 187626)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm 2015-07-31 00:17:28 UTC (rev 187627)
@@ -257,6 +257,16 @@
_preferences-setLogsPageMessagesToSystemConsoleEnabled(logsPageMessagesToSystemConsoleEnabled);
}
+- (BOOL)_hiddenPageDOMTimerThrottlingEnabled
+{
+return _preferences-hiddenPageDOMTimerThrottlingEnabled();
+}
+
+- (void)_setHiddenPageDOMTimerThrottlingEnabled:(BOOL)hiddenPageDOMTimerRhrottlingEnabled
+{
+_preferences-setHiddenPageDOMTimerThrottlingEnabled(hiddenPageDOMTimerRhrottlingEnabled);
+}
+
- (BOOL)_allowFileAccessFromFileURLs
{
return _preferences-allowFileAccessFromFileURLs();
Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h (187626 => 187627)
--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2015-07-31 00:12:38 UTC (rev 187626)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKPreferencesPrivate.h 2015-07-31 00:17:28 UTC (rev 187627)
@@ -62,6 +62,8 @@
@property (nonatomic, setter=_setLogsPageMessagesToSystemConsoleEnabled:) BOOL _logsPageMessagesToSystemConsoleEnabled WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
+@property (nonatomic, setter=_setHiddenPageDOMTimerThrottlingEnabled:) BOOL _hiddenPageDOMTimerThrottlingEnabled WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
+
@property (nonatomic, setter=_setAllowFileAccessFromFileURLs:) BOOL _allowFileAccessFromFileURLs WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
@property (nonatomic, setter=_setJavaScriptRuntimeFlags:)
[webkit-changes] [187618] branches/jsc-tailcall/Source/JavaScriptCore
Title: [187618] branches/jsc-tailcall/Source/_javascript_Core
Revision 187618
Author basile_clem...@apple.com
Date 2015-07-30 16:19:30 -0700 (Thu, 30 Jul 2015)
Log Message
jsc-tailcall: Don't waste stack space when arity fixup was performed
https://bugs.webkit.org/show_bug.cgi?id=147447
Reviewed by Michael Saboff.
When doing a tail call, we overwrite an amount of stack space based on
the number of arguments in the call frame. If we entered the tail
caller by performing an arity fixup, this is incorrect and leads to
wasted stack space - we must use the CodeBlock's number of parameters
instead in that case.
This patch is also moving the prepareForTailCall() function from
jit/ThunkGenerators.h to the place where it should have always been,
namely jit/CCallHelpers.h
* jit/CCallHelpers.h:
(JSC::CCallHelpers::prepareForTailCallSlow):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/Repatch.cpp:
(JSC::linkPolymorphicCall):
* jit/ThunkGenerators.cpp:
(JSC::slowPathFor):
(JSC::virtualThunkFor):
* jit/ThunkGenerators.h:
* tests/stress/tail-call-no-stack-overflow.js:
(strictLoopArityFixup):
Modified Paths
branches/jsc-tailcall/Source/_javascript_Core/ChangeLog
branches/jsc-tailcall/Source/_javascript_Core/jit/CCallHelpers.h
branches/jsc-tailcall/Source/_javascript_Core/jit/JITCall.cpp
branches/jsc-tailcall/Source/_javascript_Core/jit/JITCall32_64.cpp
branches/jsc-tailcall/Source/_javascript_Core/jit/Repatch.cpp
branches/jsc-tailcall/Source/_javascript_Core/jit/ThunkGenerators.cpp
branches/jsc-tailcall/Source/_javascript_Core/jit/ThunkGenerators.h
branches/jsc-tailcall/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js
Diff
Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (187617 => 187618)
--- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-30 23:17:45 UTC (rev 187617)
+++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-30 23:19:30 UTC (rev 187618)
@@ -1,5 +1,35 @@
2015-07-30 Basile Clement basile_clem...@apple.com
+jsc-tailcall: Don't waste stack space when arity fixup was performed
+https://bugs.webkit.org/show_bug.cgi?id=147447
+
+Reviewed by Michael Saboff.
+
+When doing a tail call, we overwrite an amount of stack space based on
+the number of arguments in the call frame. If we entered the tail
+caller by performing an arity fixup, this is incorrect and leads to
+wasted stack space - we must use the CodeBlock's number of parameters
+instead in that case.
+
+This patch is also moving the prepareForTailCall() function from
+jit/ThunkGenerators.h to the place where it should have always been,
+namely jit/CCallHelpers.h
+
+* jit/CCallHelpers.h:
+(JSC::CCallHelpers::prepareForTailCallSlow):
+* jit/JITCall.cpp:
+(JSC::JIT::compileOpCall):
+* jit/Repatch.cpp:
+(JSC::linkPolymorphicCall):
+* jit/ThunkGenerators.cpp:
+(JSC::slowPathFor):
+(JSC::virtualThunkFor):
+* jit/ThunkGenerators.h:
+* tests/stress/tail-call-no-stack-overflow.js:
+(strictLoopArityFixup):
+
+2015-07-30 Basile Clement basile_clem...@apple.com
+
jsc-tailcall: We should consider a tail call as an exit in the LLInt for the purpose of switching to the JIT
https://bugs.webkit.org/show_bug.cgi?id=147449
Modified: branches/jsc-tailcall/Source/_javascript_Core/jit/CCallHelpers.h (187617 => 187618)
--- branches/jsc-tailcall/Source/_javascript_Core/jit/CCallHelpers.h 2015-07-30 23:17:45 UTC (rev 187617)
+++ branches/jsc-tailcall/Source/_javascript_Core/jit/CCallHelpers.h 2015-07-30 23:19:30 UTC (rev 187618)
@@ -30,6 +30,7 @@
#include AssemblyHelpers.h
#include GPRInfo.h
+#include StackAlignment.h
namespace JSC {
@@ -2020,6 +2021,70 @@
loadPtr(vm()-targetMachinePCForThrow, GPRInfo::regT1);
jump(GPRInfo::regT1);
}
+
+void prepareForTailCallSlow(const TempRegisterSet usedRegisters = { RegisterSet::specialRegisters() })
+{
+GPRReg temp1 = usedRegisters.getFreeGPR(0);
+GPRReg temp2 = usedRegisters.getFreeGPR(1);
+ASSERT(temp2 != InvalidGPRReg);
+
+subPtr(TrustedImm32(sizeof(CallerFrameAndPC)), stackPointerRegister);
+loadPtr(Address(GPRInfo::callFrameRegister), temp1);
+storePtr(temp1, Address(stackPointerRegister));
+loadPtr(Address(GPRInfo::callFrameRegister, sizeof(void*)), temp1);
+storePtr(temp1, Address(stackPointerRegister, sizeof(void*)));
+
+// Now stackPointerRegister points to a valid call frame for the callee
+// and callFrameRegister points to our own call frame.
+// We now slide the callee's call frame over our own call frame,
+// starting with the top to avoid unwanted overwrites
+
+// Move the callFrameRegister to the top of our (trashed) call frame
+load32(Address(GPRInfo::callFrameRegister,
[webkit-changes] [187626] trunk/Source/WebCore
Title: [187626] trunk/Source/WebCore Revision 187626 Author mmaxfi...@apple.com Date 2015-07-30 17:12:38 -0700 (Thu, 30 Jul 2015) Log Message Move locale information into FontDescription https://bugs.webkit.org/show_bug.cgi?id=147457 Reviewed by Andreas Kling. Currently, the lang attribute on a node sets locale information in RenderStyle. Font selection is sensitive to this locale information, and occurs deep within platform/ code, far away from RenderStyle. Because every RenderStyle owns a FontDescription, and font selection can consult with FontDescriptions, it makes sense to move the variable from RenderStyle to FontDescription, and provide convenience methods on RenderStyle which inspect its FontDescription for locale information. This patch is in preparation for correctly obeying locale information when performing font fallback. No new tests because there is no behavior change. * css/CSSPropertyNames.in: * css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueWebkitLocale): * platform/graphics/FontCache.h: (WebCore::FontDescriptionKey::FontDescriptionKey): (WebCore::FontDescriptionKey::operator==): * platform/graphics/FontCascade.cpp: * platform/graphics/FontDescription.cpp: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::setLocale): * platform/graphics/FontDescription.h: (WebCore::FontDescription::locale): (WebCore::FontDescription::initialLocale): (WebCore::FontDescription::operator==): (WebCore::FontDescription::FontDescription): Deleted. (WebCore::FontDescription::setScript): Deleted. * platform/text/LocaleToScriptMappingDefault.cpp: (WebCore::localeToScriptCodeForFontSelection): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::changeRequiresLayout): Deleted. * rendering/style/RenderStyle.h: * rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::StyleRareInheritedData): Deleted. (WebCore::StyleRareInheritedData::operator==): Deleted. * rendering/style/StyleRareInheritedData.h: * style/StyleResolveForDocument.cpp: (WebCore::Style::resolveForDocument): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSPropertyNames.in trunk/Source/WebCore/css/StyleBuilderCustom.h trunk/Source/WebCore/platform/graphics/FontCache.h trunk/Source/WebCore/platform/graphics/FontCascade.cpp trunk/Source/WebCore/platform/graphics/FontDescription.cpp trunk/Source/WebCore/platform/graphics/FontDescription.h trunk/Source/WebCore/platform/text/LocaleToScriptMappingDefault.cpp trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/rendering/style/RenderStyle.h trunk/Source/WebCore/rendering/style/StyleRareInheritedData.cpp trunk/Source/WebCore/rendering/style/StyleRareInheritedData.h trunk/Source/WebCore/style/StyleResolveForDocument.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (187625 => 187626) --- trunk/Source/WebCore/ChangeLog 2015-07-30 23:56:51 UTC (rev 187625) +++ trunk/Source/WebCore/ChangeLog 2015-07-31 00:12:38 UTC (rev 187626) @@ -1,3 +1,51 @@ +2015-07-30 Myles C. Maxfield mmaxfi...@apple.com + +Move locale information into FontDescription +https://bugs.webkit.org/show_bug.cgi?id=147457 + +Reviewed by Andreas Kling. + +Currently, the lang attribute on a node sets locale information in RenderStyle. +Font selection is sensitive to this locale information, and occurs deep within +platform/ code, far away from RenderStyle. Because every RenderStyle owns a +FontDescription, and font selection can consult with FontDescriptions, it makes +sense to move the variable from RenderStyle to FontDescription, and provide +convenience methods on RenderStyle which inspect its FontDescription for locale +information. + +This patch is in preparation for correctly obeying locale information when +performing font fallback. + +No new tests because there is no behavior change. + +* css/CSSPropertyNames.in: +* css/StyleBuilderCustom.h: +(WebCore::StyleBuilderCustom::applyValueWebkitLocale): +* platform/graphics/FontCache.h: +(WebCore::FontDescriptionKey::FontDescriptionKey): +(WebCore::FontDescriptionKey::operator==): +* platform/graphics/FontCascade.cpp: +* platform/graphics/FontDescription.cpp: +(WebCore::FontDescription::FontDescription): +(WebCore::FontDescription::setLocale): +* platform/graphics/FontDescription.h: +(WebCore::FontDescription::locale): +(WebCore::FontDescription::initialLocale): +(WebCore::FontDescription::operator==): +(WebCore::FontDescription::FontDescription): Deleted. +(WebCore::FontDescription::setScript): Deleted. +* platform/text/LocaleToScriptMappingDefault.cpp: +(WebCore::localeToScriptCodeForFontSelection): +* rendering/style/RenderStyle.cpp: +(WebCore::RenderStyle::changeRequiresLayout): Deleted. +*
[webkit-changes] [187630] trunk/Source/WebCore
Title: [187630] trunk/Source/WebCore
Revision 187630
Author akl...@apple.com
Date 2015-07-30 17:52:45 -0700 (Thu, 30 Jul 2015)
Log Message
[CF] Web process continually eating memory on simple, shared Google Docs spreadsheet.
https://webkit.org/b/147403
rdar://problem/18835799
Reviewed by Geoffrey Garen.
Make sure we service the CFRunLoop on worker threads, since ports using CoreFoundation
will be scheduling garbage collections and heap sweeps using CFRunLoop timers.
This fix is a stopgap. Long term we need a better design for integrating GC tasks with
with the web worker run loop.
* workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::runInMode): Instead of sleeping forever, calculate a better
wakeup deadline by asking the CFRunLoop when its next timer will fire. Then, when a
timeout occurs, call CFRunLoopRunInMode (with seconds=0) to service pending timers.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerRunLoop.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (187629 => 187630)
--- trunk/Source/WebCore/ChangeLog 2015-07-31 00:43:25 UTC (rev 187629)
+++ trunk/Source/WebCore/ChangeLog 2015-07-31 00:52:45 UTC (rev 187630)
@@ -1,3 +1,22 @@
+2015-07-30 Andreas Kling akl...@apple.com
+
+[CF] Web process continually eating memory on simple, shared Google Docs spreadsheet.
+https://webkit.org/b/147403
+rdar://problem/18835799
+
+Reviewed by Geoffrey Garen.
+
+Make sure we service the CFRunLoop on worker threads, since ports using CoreFoundation
+will be scheduling garbage collections and heap sweeps using CFRunLoop timers.
+
+This fix is a stopgap. Long term we need a better design for integrating GC tasks with
+with the web worker run loop.
+
+* workers/WorkerRunLoop.cpp:
+(WebCore::WorkerRunLoop::runInMode): Instead of sleeping forever, calculate a better
+wakeup deadline by asking the CFRunLoop when its next timer will fire. Then, when a
+timeout occurs, call CFRunLoopRunInMode (with seconds=0) to service pending timers.
+
2015-07-30 Myles C. Maxfield mmaxfi...@apple.com
Move locale information into FontDescription
Modified: trunk/Source/WebCore/workers/WorkerRunLoop.cpp (187629 => 187630)
--- trunk/Source/WebCore/workers/WorkerRunLoop.cpp 2015-07-31 00:43:25 UTC (rev 187629)
+++ trunk/Source/WebCore/workers/WorkerRunLoop.cpp 2015-07-31 00:52:45 UTC (rev 187630)
@@ -148,9 +148,21 @@
ASSERT(context);
ASSERT(context-thread().threadID() == currentThread());
+double deadline = MessageQueueTask::infiniteTime();
+
+#if USE(CF)
+CFAbsoluteTime nextCFRunLoopTimerFireDate = CFRunLoopGetNextTimerFireDate(CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
+double timeUntilNextCFRunLoopTimerInSeconds = nextCFRunLoopTimerFireDate - CFAbsoluteTimeGetCurrent();
+deadline = currentTime() + std::max(0.0, timeUntilNextCFRunLoopTimerInSeconds);
+#endif
+
double absoluteTime = 0.0;
-if (waitMode == WaitForMessage)
-absoluteTime = (predicate.isDefaultMode() m_sharedTimer-isActive()) ? m_sharedTimer-fireTime() : MessageQueueTask::infiniteTime();
+if (waitMode == WaitForMessage) {
+if (predicate.isDefaultMode() m_sharedTimer-isActive())
+absoluteTime = std::min(deadline, m_sharedTimer-fireTime());
+else
+absoluteTime = deadline;
+}
MessageQueueWaitResult result;
auto task = m_messageQueue.waitForMessageFilteredWithTimeout(result, predicate, absoluteTime);
@@ -167,6 +179,10 @@
case MessageQueueTimeout:
if (!context-isClosing())
m_sharedTimer-fire();
+#if USE(CF)
+if (nextCFRunLoopTimerFireDate = CFAbsoluteTimeGetCurrent())
+CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0, /*returnAfterSourceHandled*/ false);
+#endif
break;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187637] branches/jsc-tailcall/Source/JavaScriptCore
Title: [187637] branches/jsc-tailcall/Source/_javascript_Core Revision 187637 Author msab...@apple.com Date 2015-07-30 20:40:56 -0700 (Thu, 30 Jul 2015) Log Message jsc-tailcall: Eliminate rdi from temp register list for X86-64 Windows https://bugs.webkit.org/show_bug.cgi?id=147461 Reviewed by Basile Clement. Eliminated rdi from the list of temporary registers for X86-64 Windows as it is a callee saves register. This reduced the number of temporary registers for X86-64 Windows. Since the LLInt needs 6 available registers in a couple of places, added a register alias called extraTempReg which is t0 on X86-64 Windows and t5 on all other platforms. As a result of this change, I changed the PC register in the LLInt from t5 to t4. * jit/GPRInfo.h: (JSC::GPRInfo::toRegister): (JSC::GPRInfo::toIndex): * llint/LowLevelInterpreter.asm: * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: * offlineasm/x86.rb: Modified Paths branches/jsc-tailcall/Source/_javascript_Core/ChangeLog branches/jsc-tailcall/Source/_javascript_Core/jit/GPRInfo.h branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter64.asm branches/jsc-tailcall/Source/_javascript_Core/offlineasm/x86.rb Diff Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (187636 => 187637) --- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-31 02:07:03 UTC (rev 187636) +++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-31 03:40:56 UTC (rev 187637) @@ -1,3 +1,27 @@ +2015-07-30 Michael Saboff msab...@apple.com + +jsc-tailcall: Eliminate rdi from temp register list for X86-64 Windows +https://bugs.webkit.org/show_bug.cgi?id=147461 + +Reviewed by Basile Clement. + +Eliminated rdi from the list of temporary registers for X86-64 Windows as it +is a callee saves register. This reduced the number of temporary registers +for X86-64 Windows. Since the LLInt needs 6 available registers in a couple +of places, added a register alias called extraTempReg which is t0 on X86-64 +Windows and t5 on all other platforms. + +As a result of this change, I changed the PC register in the LLInt from t5 +to t4. + +* jit/GPRInfo.h: +(JSC::GPRInfo::toRegister): +(JSC::GPRInfo::toIndex): +* llint/LowLevelInterpreter.asm: +* llint/LowLevelInterpreter32_64.asm: +* llint/LowLevelInterpreter64.asm: +* offlineasm/x86.rb: + 2015-07-30 Basile Clement basile_clem...@apple.com jsc-tailcall: Add enums for type-safety Modified: branches/jsc-tailcall/Source/_javascript_Core/jit/GPRInfo.h (187636 => 187637) --- branches/jsc-tailcall/Source/_javascript_Core/jit/GPRInfo.h 2015-07-31 02:07:03 UTC (rev 187636) +++ branches/jsc-tailcall/Source/_javascript_Core/jit/GPRInfo.h 2015-07-31 03:40:56 UTC (rev 187637) @@ -396,9 +396,8 @@ static const GPRReg regT1 = X86Registers::edx; static const GPRReg regT2 = X86Registers::r8; static const GPRReg regT3 = X86Registers::r9; -static const GPRReg regT4 = X86Registers::edi; // This one is actually callee-save -static const GPRReg regT5 = X86Registers::r10; -static const GPRReg regT6 = X86Registers::ecx; +static const GPRReg regT4 = X86Registers::r10; +static const GPRReg regT5 = X86Registers::ecx; #endif static const GPRReg regCS0 = X86Registers::ebx; @@ -410,31 +409,31 @@ static const GPRReg regCS4 = X86Registers::r15; #else static const GPRReg regCS3 = X86Registers::esi; -static const GPRReg regCS4 = X86Registers::edi; // regT4 +static const GPRReg regCS4 = X86Registers::edi; static const GPRReg regCS5 = X86Registers::r14; static const GPRReg regCS6 = X86Registers::r15; #endif // These constants provide the names for the general purpose argument return value registers. -#if OS(WINDOWS) -static const GPRReg argumentGPR0 = X86Registers::ecx; // regT6 -static const GPRReg argumentGPR1 = X86Registers::edx; // regT1 -static const GPRReg argumentGPR2 = X86Registers::r8; // regT2 -static const GPRReg argumentGPR3 = X86Registers::r9; // regT3 -#else +#if !OS(WINDOWS) static const GPRReg argumentGPR0 = X86Registers::edi; // regT6 static const GPRReg argumentGPR1 = X86Registers::esi; // regT1 static const GPRReg argumentGPR2 = X86Registers::edx; // regT2 static const GPRReg argumentGPR3 = X86Registers::ecx; // regT3 static const GPRReg argumentGPR4 = X86Registers::r8; // regT4 static const GPRReg argumentGPR5 = X86Registers::r9; // regT7 +#else +static const GPRReg argumentGPR0 = X86Registers::ecx; // regT5 +static const GPRReg argumentGPR1 = X86Registers::edx; // regT1 +static const GPRReg argumentGPR2 = X86Registers::r8; // regT2 +
[webkit-changes] [187638] trunk/Source/WebCore
Title: [187638] trunk/Source/WebCore
Revision 187638
Author za...@apple.com
Date 2015-07-30 20:48:40 -0700 (Thu, 30 Jul 2015)
Log Message
RenderTheme::paintBorderOnly and paintDecorations should take RenderBox instead of RenderObject.
https://bugs.webkit.org/show_bug.cgi?id=147470
Reviewed by Simon Fraser.
Tighten the code so that RenderTheme paint functions take RenderBox instead of RenderObject.
No change in functionality.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
* rendering/RenderTheme.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/RenderTheme.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (187637 => 187638)
--- trunk/Source/WebCore/ChangeLog 2015-07-31 03:40:56 UTC (rev 187637)
+++ trunk/Source/WebCore/ChangeLog 2015-07-31 03:48:40 UTC (rev 187638)
@@ -1,3 +1,19 @@
+2015-07-30 Zalan Bujtas za...@apple.com
+
+RenderTheme::paintBorderOnly and paintDecorations should take RenderBox instead of RenderObject.
+https://bugs.webkit.org/show_bug.cgi?id=147470
+
+Reviewed by Simon Fraser.
+
+Tighten the code so that RenderTheme paint functions take RenderBox instead of RenderObject.
+
+No change in functionality.
+
+* rendering/RenderTheme.cpp:
+(WebCore::RenderTheme::paintBorderOnly):
+(WebCore::RenderTheme::paintDecorations):
+* rendering/RenderTheme.h:
+
2015-07-30 Andreas Kling akl...@apple.com
[CF] Web process continually eating memory on simple, shared Google Docs spreadsheet.
Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (187637 => 187638)
--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2015-07-31 03:40:56 UTC (rev 187637)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2015-07-31 03:48:40 UTC (rev 187638)
@@ -409,23 +409,23 @@
return true; // We don't support the appearance, so let the normal background/border paint.
}
-bool RenderTheme::paintBorderOnly(const RenderObject o, const PaintInfo paintInfo, const LayoutRect r)
+bool RenderTheme::paintBorderOnly(const RenderBox box, const PaintInfo paintInfo, const LayoutRect rect)
{
if (paintInfo.context-paintingDisabled())
return false;
#if PLATFORM(IOS)
-UNUSED_PARAM(r);
-return o.style().appearance() != NoControlPart;
+UNUSED_PARAM(rect);
+return box.style().appearance() != NoControlPart;
#else
-FloatRect devicePixelSnappedRect = snapRectToDevicePixels(r, o.document().deviceScaleFactor());
+FloatRect devicePixelSnappedRect = snapRectToDevicePixels(rect, box.document().deviceScaleFactor());
// Call the appropriate paint method based off the appearance value.
-switch (o.style().appearance()) {
+switch (box.style().appearance()) {
case TextFieldPart:
-return paintTextField(o, paintInfo, devicePixelSnappedRect);
+return paintTextField(box, paintInfo, devicePixelSnappedRect);
case ListboxPart:
case TextAreaPart:
-return paintTextArea(o, paintInfo, devicePixelSnappedRect);
+return paintTextArea(box, paintInfo, devicePixelSnappedRect);
case MenulistButtonPart:
case SearchFieldPart:
return true;
@@ -463,39 +463,39 @@
#endif
}
-bool RenderTheme::paintDecorations(const RenderObject renderer, const PaintInfo paintInfo, const LayoutRect rect)
+bool RenderTheme::paintDecorations(const RenderBox box, const PaintInfo paintInfo, const LayoutRect rect)
{
if (paintInfo.context-paintingDisabled())
return false;
IntRect integralSnappedRect = snappedIntRect(rect);
-FloatRect devicePixelSnappedRect = snapRectToDevicePixels(rect, renderer.document().deviceScaleFactor());
+FloatRect devicePixelSnappedRect = snapRectToDevicePixels(rect, box.document().deviceScaleFactor());
// Call the appropriate paint method based off the appearance value.
-switch (renderer.style().appearance()) {
+switch (box.style().appearance()) {
case MenulistButtonPart:
-return paintMenuListButtonDecorations(renderer, paintInfo, devicePixelSnappedRect);
+return paintMenuListButtonDecorations(box, paintInfo, devicePixelSnappedRect);
case TextFieldPart:
-return paintTextFieldDecorations(renderer, paintInfo, devicePixelSnappedRect);
+return paintTextFieldDecorations(box, paintInfo, devicePixelSnappedRect);
case TextAreaPart:
-return paintTextAreaDecorations(renderer, paintInfo, devicePixelSnappedRect);
+return paintTextAreaDecorations(box, paintInfo, devicePixelSnappedRect);
case CheckboxPart:
-return paintCheckboxDecorations(renderer, paintInfo, integralSnappedRect);
+return paintCheckboxDecorations(box, paintInfo, integralSnappedRect);
case RadioPart:
-return paintRadioDecorations(renderer, paintInfo, integralSnappedRect);
+return
[webkit-changes] [187636] tags/Safari-600.8.9/
Title: [187636] tags/Safari-600.8.9/ Revision 187636 Author bshaf...@apple.com Date 2015-07-30 19:07:03 -0700 (Thu, 30 Jul 2015) Log Message New tag. Added Paths tags/Safari-600.8.9/ Diff Property changes: tags/Safari-600.8.9 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187635] tags/Safari-600.1.4.17.8/
Title: [187635] tags/Safari-600.1.4.17.8/ Revision 187635 Author bshaf...@apple.com Date 2015-07-30 19:06:51 -0700 (Thu, 30 Jul 2015) Log Message New tag. Added Paths tags/Safari-600.1.4.17.8/ Diff Property changes: tags/Safari-600.1.4.17.8 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187634] trunk/Source/WebInspectorUI
Title: [187634] trunk/Source/WebInspectorUI Revision 187634 Author mattba...@apple.com Date 2015-07-30 18:55:56 -0700 (Thu, 30 Jul 2015) Log Message Web Inspector: Better share objects generated from timeline events (Records) https://bugs.webkit.org/show_bug.cgi?id=147029 Reviewed by Brian Burg. This patch changes the way TimelineManager processes events, preserving the event hierarchy after converting payloads to TimelineRecord objects by retaining parent-child relationships between records. This eliminates the need for RenderingFrameTimelineRecord objects to create a separate copy of their child records, and provides richer data for the Timelines UI. * UserInterface/Controllers/TimelineManager.js: (WebInspector.TimelineManager.prototype.eventRecorded): Track the parent TimelineRecord as child record payloads are unpacked, and create a hierarchy of TimelineRecords that mirrors the original event payload hierarchy. (WebInspector.TimelineManager.prototype._processRecord): RenderingFrameTimelineRecord is now processed like any other event. (WebInspector.TimelineManager.prototype._processNestedRecords): Deleted. Reverted back to a single pass over the incoming timeline event payload. * UserInterface/Models/LayoutTimelineRecord.js: (WebInspector.LayoutTimelineRecord): (WebInspector.LayoutTimelineRecord.prototype.get duringComposite): Deleted. Removed duringComposite property and constructor parameter. No longer needed. * UserInterface/Models/RenderingFrameTimelineRecord.js: (WebInspector.RenderingFrameTimelineRecord.prototype.get children): Deleted. Removed children property. It now exists on the base class TimelineRecord. Also removed code that was needed to prevent paint time from being added twice. * UserInterface/Models/ScriptTimelineRecord.js: (WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload): (WebInspector.ScriptTimelineRecord): Removed workaround added in: https://webkit.org/b/147025 Web Inspector: REGRESSION (r186218) ScriptTimelineRecord attempts to access null property * UserInterface/Models/TimelineRecord.js: (WebInspector.TimelineRecord): (WebInspector.TimelineRecord.prototype.get children): Added children property. * UserInterface/Views/RenderingFrameTimelineView.js: (WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords): Now that we preserve the frame's child record hierarchy, we process the entire tree, yielding richer data grid output: Frame X Styles Recalculated Layout Invalidated Composite Paint Paint Compared to the previous output: Frame X Styles Recalculated Layout Invalidated Composite Paint Paint Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js trunk/Source/WebInspectorUI/UserInterface/Models/LayoutTimelineRecord.js trunk/Source/WebInspectorUI/UserInterface/Models/RenderingFrameTimelineRecord.js trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js trunk/Source/WebInspectorUI/UserInterface/Models/TimelineRecord.js trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (187633 => 187634) --- trunk/Source/WebInspectorUI/ChangeLog 2015-07-31 01:49:35 UTC (rev 187633) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-31 01:55:56 UTC (rev 187634) @@ -1,3 +1,66 @@ +2015-07-30 Matt Baker mattba...@apple.com + +Web Inspector: Better share objects generated from timeline events (Records) +https://bugs.webkit.org/show_bug.cgi?id=147029 + +Reviewed by Brian Burg. + +This patch changes the way TimelineManager processes events, preserving the event hierarchy after +converting payloads to TimelineRecord objects by retaining parent-child relationships between records. +This eliminates the need for RenderingFrameTimelineRecord objects to create a separate copy of their child +records, and provides richer data for the Timelines UI. + +* UserInterface/Controllers/TimelineManager.js: +(WebInspector.TimelineManager.prototype.eventRecorded): +Track the parent TimelineRecord as child record payloads are unpacked, and create +a hierarchy of TimelineRecords that mirrors the original event payload hierarchy. +(WebInspector.TimelineManager.prototype._processRecord): +RenderingFrameTimelineRecord is now processed like any other event. +(WebInspector.TimelineManager.prototype._processNestedRecords): Deleted. +Reverted back to a single pass over the incoming timeline event payload. + +* UserInterface/Models/LayoutTimelineRecord.js: +(WebInspector.LayoutTimelineRecord): +(WebInspector.LayoutTimelineRecord.prototype.get duringComposite): Deleted. +Removed duringComposite property and constructor parameter. No longer needed. + +*
[webkit-changes] [187579] trunk/Source/JavaScriptCore
Title: [187579] trunk/Source/_javascript_Core
Revision 187579
Author fpi...@apple.com
Date 2015-07-29 23:26:52 -0700 (Wed, 29 Jul 2015)
Log Message
DFG::ArgumentsEliminationPhase should emit a PutStack for all of the GetStacks that the ByteCodeParser emitted
https://bugs.webkit.org/show_bug.cgi?id=147433
rdar://problem/21668986
Reviewed by Mark Lam.
Ideally, the ByteCodeParser would only emit SetArgument nodes for named arguments. But
currently that's not what it does - it emits a SetArgument for every argument that a varargs
call may pass. Each SetArgument gets turned into a GetStack. This means that if
ArgumentsEliminationPhase optimizes away PutStacks for those varargs arguments that didn't
get passed or used, we get degenerate IR where we have a GetStack of something that didn't
have a PutStack.
This fixes the bug by removing the code to optimize away PutStacks in
ArgumentsEliminationPhase.
* dfg/DFGArgumentsEliminationPhase.cpp:
* tests/stress/varargs-inlining-underflow.js: Added.
(baz):
(bar):
(foo):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp
Added Paths
trunk/Source/_javascript_Core/tests/stress/varargs-inlining-underflow.js
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (187578 => 187579)
--- trunk/Source/_javascript_Core/ChangeLog 2015-07-30 05:47:26 UTC (rev 187578)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-07-30 06:26:52 UTC (rev 187579)
@@ -1,3 +1,27 @@
+2015-07-29 Filip Pizlo fpi...@apple.com
+
+DFG::ArgumentsEliminationPhase should emit a PutStack for all of the GetStacks that the ByteCodeParser emitted
+https://bugs.webkit.org/show_bug.cgi?id=147433
+rdar://problem/21668986
+
+Reviewed by Mark Lam.
+
+Ideally, the ByteCodeParser would only emit SetArgument nodes for named arguments. But
+currently that's not what it does - it emits a SetArgument for every argument that a varargs
+call may pass. Each SetArgument gets turned into a GetStack. This means that if
+ArgumentsEliminationPhase optimizes away PutStacks for those varargs arguments that didn't
+get passed or used, we get degenerate IR where we have a GetStack of something that didn't
+have a PutStack.
+
+This fixes the bug by removing the code to optimize away PutStacks in
+ArgumentsEliminationPhase.
+
+* dfg/DFGArgumentsEliminationPhase.cpp:
+* tests/stress/varargs-inlining-underflow.js: Added.
+(baz):
+(bar):
+(foo):
+
2015-07-29 Andy VanWagoner thetalecraf...@gmail.com
Implement basic types for ECMAScript Internationalization API
Modified: trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp (187578 => 187579)
--- trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp 2015-07-30 05:47:26 UTC (rev 187578)
+++ trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp 2015-07-30 06:26:52 UTC (rev 187579)
@@ -516,11 +516,12 @@
value = insertionSet.insertNode(
nodeIndex, SpecNone, GetStack, node-origin, OpInfo(data));
} else {
-// Check if this an element that we must initialize.
-if (storeIndex = varargsData-mandatoryMinimum) {
-// It's not. We're done.
-break;
-}
+// FIXME: We shouldn't have to store anything if
+// storeIndex = varargsData-mandatoryMinimum, but we will still
+// have GetStacks in that range. So if we don't do the stores, we'll
+// have degenerate IR: we'll have GetStacks of something that didn't
+// have PutStacks.
+// https://bugs.webkit.org/show_bug.cgi?id=147434
if (!undefined) {
undefined = insertionSet.insertConstant(
Added: trunk/Source/_javascript_Core/tests/stress/varargs-inlining-underflow.js (0 => 187579)
--- trunk/Source/_javascript_Core/tests/stress/varargs-inlining-underflow.js (rev 0)
+++ trunk/Source/_javascript_Core/tests/stress/varargs-inlining-underflow.js 2015-07-30 06:26:52 UTC (rev 187579)
@@ -0,0 +1,18 @@
+function baz() {
+}
+
+function bar() {
+baz.apply(this, arguments);
+}
+
+for (var i = 0; i 1000; ++i)
+bar(1, 2, 3, 4, 5, 6, 7);
+
+function foo() {
+bar();
+}
+
+noInline(foo);
+
+for (var i = 0; i 1; ++i)
+foo();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187580] trunk/Source/WebCore
Title: [187580] trunk/Source/WebCore
Revision 187580
Author carlo...@webkit.org
Date 2015-07-29 23:39:59 -0700 (Wed, 29 Jul 2015)
Log Message
[GTK] Paste data is removed from clipboard when closing browser tab
https://bugs.webkit.org/show_bug.cgi?id=144549
Reviewed by Martin Robinson.
GTK+ stores all clipboards in gtk_main or gtk_application_shutdown
when the main loop finishes. We don't use gtk_main() in the web
process, so we need to do the same and store all clipboards on
process shutdown.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::Pasteboard): Register the GtkClipboard.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::singleton): Make it destructible.
(WebCore::PasteboardHelper::~PasteboardHelper): Call
gtk_clipboard_store for every registered GtkClipboard.
(WebCore::PasteboardHelper::registerClipboard): Save the given
GtkClipboard.
* platform/gtk/PasteboardHelper.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp
trunk/Source/WebCore/platform/gtk/PasteboardHelper.cpp
trunk/Source/WebCore/platform/gtk/PasteboardHelper.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (187579 => 187580)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 06:26:52 UTC (rev 187579)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 06:39:59 UTC (rev 187580)
@@ -1,3 +1,25 @@
+2015-07-29 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Paste data is removed from clipboard when closing browser tab
+https://bugs.webkit.org/show_bug.cgi?id=144549
+
+Reviewed by Martin Robinson.
+
+GTK+ stores all clipboards in gtk_main or gtk_application_shutdown
+when the main loop finishes. We don't use gtk_main() in the web
+process, so we need to do the same and store all clipboards on
+process shutdown.
+
+* platform/gtk/PasteboardGtk.cpp:
+(WebCore::Pasteboard::Pasteboard): Register the GtkClipboard.
+* platform/gtk/PasteboardHelper.cpp:
+(WebCore::PasteboardHelper::singleton): Make it destructible.
+(WebCore::PasteboardHelper::~PasteboardHelper): Call
+gtk_clipboard_store for every registered GtkClipboard.
+(WebCore::PasteboardHelper::registerClipboard): Save the given
+GtkClipboard.
+* platform/gtk/PasteboardHelper.h:
+
2015-07-29 Andy VanWagoner thetalecraf...@gmail.com
Implement basic types for ECMAScript Internationalization API
Modified: trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp (187579 => 187580)
--- trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp 2015-07-30 06:26:52 UTC (rev 187579)
+++ trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp 2015-07-30 06:39:59 UTC (rev 187580)
@@ -76,7 +76,7 @@
Pasteboard::Pasteboard(PassRefPtrDataObjectGtk dataObject)
: m_dataObject(dataObject)
-, m_gtkClipboard(0)
+, m_gtkClipboard(nullptr)
{
ASSERT(m_dataObject);
}
@@ -86,6 +86,7 @@
, m_gtkClipboard(gtkClipboard)
{
ASSERT(m_dataObject);
+PasteboardHelper::singleton().registerClipboard(gtkClipboard);
}
Pasteboard::~Pasteboard()
Modified: trunk/Source/WebCore/platform/gtk/PasteboardHelper.cpp (187579 => 187580)
--- trunk/Source/WebCore/platform/gtk/PasteboardHelper.cpp 2015-07-30 06:26:52 UTC (rev 187579)
+++ trunk/Source/WebCore/platform/gtk/PasteboardHelper.cpp 2015-07-30 06:39:59 UTC (rev 187580)
@@ -53,7 +53,7 @@
PasteboardHelper PasteboardHelper::singleton()
{
-static NeverDestroyedPasteboardHelper helper;
+static PasteboardHelper helper;
return helper;
}
@@ -75,6 +75,12 @@
gtk_target_list_add(m_targetList.get(), unknownAtom, 0, PasteboardHelper::TargetTypeUnknown);
}
+PasteboardHelper::~PasteboardHelper()
+{
+for (auto* clipboard : m_gtkClipboards)
+gtk_clipboard_store(clipboard);
+}
+
GtkTargetList* PasteboardHelper::targetList() const
{
return m_targetList.get();
@@ -316,5 +322,11 @@
return gtk_clipboard_wait_is_target_available(clipboard, smartPasteAtom);
}
+void PasteboardHelper::registerClipboard(GtkClipboard* clipboard)
+{
+ASSERT(clipboard);
+m_gtkClipboards.add(clipboard);
}
+}
+
Modified: trunk/Source/WebCore/platform/gtk/PasteboardHelper.h (187579 => 187580)
--- trunk/Source/WebCore/platform/gtk/PasteboardHelper.h 2015-07-30 06:26:52 UTC (rev 187579)
+++ trunk/Source/WebCore/platform/gtk/PasteboardHelper.h 2015-07-30 06:39:59 UTC (rev 187580)
@@ -25,7 +25,7 @@
#ifndef PasteboardHelper_h
#define PasteboardHelper_h
-#include wtf/NeverDestroyed.h
+#include wtf/HashSet.h
#include wtf/Noncopyable.h
#include wtf/Vector.h
#include wtf/glib/GRefPtr.h
@@ -52,13 +52,14 @@
enum PasteboardTargetType { TargetTypeMarkup, TargetTypeText, TargetTypeImage, TargetTypeURIList, TargetTypeNetscapeURL, TargetTypeSmartPaste, TargetTypeUnknown };
bool clipboardContentSupportsSmartReplace(GtkClipboard*);
+void registerClipboard(GtkClipboard*);
+
private:
[webkit-changes] [187584] trunk/Source/WebCore
Title: [187584] trunk/Source/WebCore Revision 187584 Author achristen...@apple.com Date 2015-07-30 08:56:35 -0700 (Thu, 30 Jul 2015) Log Message [Win] Unreviewed build fix after r187582. * accessibility/AccessibilityAllInOne.cpp: Include new files. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityAllInOne.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (187583 => 187584) --- trunk/Source/WebCore/ChangeLog 2015-07-30 14:51:09 UTC (rev 187583) +++ trunk/Source/WebCore/ChangeLog 2015-07-30 15:56:35 UTC (rev 187584) @@ -1,3 +1,10 @@ +2015-07-30 Alex Christensen achristen...@webkit.org + +[Win] Unreviewed build fix after r187582. + +* accessibility/AccessibilityAllInOne.cpp: +Include new files. + 2015-07-30 Michael Catanzaro mcatanz...@igalia.com Web Inspector: [Freetype] Allow inspector to retrieve a list of system fonts Modified: trunk/Source/WebCore/accessibility/AccessibilityAllInOne.cpp (187583 => 187584) --- trunk/Source/WebCore/accessibility/AccessibilityAllInOne.cpp 2015-07-30 14:51:09 UTC (rev 187583) +++ trunk/Source/WebCore/accessibility/AccessibilityAllInOne.cpp 2015-07-30 15:56:35 UTC (rev 187584) @@ -52,4 +52,5 @@ #include AccessibilityTableColumn.cpp #include AccessibilityTableHeaderContainer.cpp #include AccessibilityTableRow.cpp - +#include AccessibilityTree.cpp +#include AccessibilityTreeItem.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187587] trunk/Source
Title: [187587] trunk/Source
Revision 187587
Author cdu...@apple.com
Date 2015-07-30 09:25:36 -0700 (Thu, 30 Jul 2015)
Log Message
Mark more classes as fast allocated
https://bugs.webkit.org/show_bug.cgi?id=147440
Reviewed by Sam Weinig.
Mark more classes as fast allocated for performance. We heap-allocate
objects of those types throughout the code base.
Source/_javascript_Core:
* API/JSCallbackObject.h:
* API/ObjCCallbackFunction.mm:
* bytecode/BytecodeKills.h:
* bytecode/BytecodeLivenessAnalysis.h:
* bytecode/CallLinkStatus.h:
* bytecode/FullBytecodeLiveness.h:
* bytecode/SamplingTool.h:
* bytecompiler/BytecodeGenerator.h:
* dfg/DFGBasicBlock.h:
* dfg/DFGBlockMap.h:
* dfg/DFGInPlaceAbstractState.h:
* dfg/DFGThreadData.h:
* heap/HeapVerifier.h:
* heap/SlotVisitor.h:
* parser/Lexer.h:
* runtime/ControlFlowProfiler.h:
* runtime/TypeProfiler.h:
* runtime/TypeProfilerLog.h:
* runtime/Watchdog.h:
Source/WebCore:
* editing/Editor.h:
* history/CachedFrame.h:
* history/CachedPage.h:
* html/parser/HTMLResourcePreloader.h:
* loader/PolicyChecker.h:
* loader/SubresourceLoader.h:
* loader/cache/CachedResource.h:
* page/animation/AnimationController.h:
* page/scrolling/ScrollingConstraints.h:
* page/scrolling/ScrollingStateTree.h:
* platform/graphics/Font.h:
* platform/graphics/GraphicsLayerUpdater.h:
* rendering/FilterEffectRenderer.h:
* rendering/ImageQualityController.h:
* rendering/RenderLayerFilterInfo.h:
* rendering/SimpleLineLayoutResolver.h:
* rendering/shapes/RasterShape.h:
* rendering/shapes/Shape.h:
Source/WebKit2:
* NetworkProcess/cache/NetworkCacheStorage.cpp:
* NetworkProcess/cache/NetworkCacheStorage.h:
* Platform/IPC/MessageRecorder.h:
* Platform/mac/LayerHostingContext.h:
Source/WTF:
* wtf/Bag.h:
* wtf/SegmentedVector.h:
* wtf/SentinelLinkedList.h:
Modified Paths
trunk/Source/_javascript_Core/API/JSCallbackObject.h
trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/BytecodeKills.h
trunk/Source/_javascript_Core/bytecode/BytecodeLivenessAnalysis.h
trunk/Source/_javascript_Core/bytecode/CallLinkStatus.h
trunk/Source/_javascript_Core/bytecode/FullBytecodeLiveness.h
trunk/Source/_javascript_Core/bytecode/SamplingTool.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/dfg/DFGBasicBlock.h
trunk/Source/_javascript_Core/dfg/DFGBlockMap.h
trunk/Source/_javascript_Core/dfg/DFGInPlaceAbstractState.h
trunk/Source/_javascript_Core/dfg/DFGThreadData.h
trunk/Source/_javascript_Core/heap/HeapVerifier.h
trunk/Source/_javascript_Core/heap/SlotVisitor.h
trunk/Source/_javascript_Core/parser/Lexer.h
trunk/Source/_javascript_Core/runtime/ControlFlowProfiler.h
trunk/Source/_javascript_Core/runtime/TypeProfiler.h
trunk/Source/_javascript_Core/runtime/TypeProfilerLog.h
trunk/Source/_javascript_Core/runtime/Watchdog.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Bag.h
trunk/Source/WTF/wtf/SegmentedVector.h
trunk/Source/WTF/wtf/SentinelLinkedList.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/history/CachedFrame.h
trunk/Source/WebCore/history/CachedPage.h
trunk/Source/WebCore/html/parser/HTMLResourcePreloader.h
trunk/Source/WebCore/loader/PolicyChecker.h
trunk/Source/WebCore/loader/SubresourceLoader.h
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/page/animation/AnimationController.h
trunk/Source/WebCore/page/scrolling/ScrollingConstraints.h
trunk/Source/WebCore/page/scrolling/ScrollingStateTree.h
trunk/Source/WebCore/platform/graphics/Font.h
trunk/Source/WebCore/platform/graphics/GraphicsLayerUpdater.h
trunk/Source/WebCore/rendering/FilterEffectRenderer.h
trunk/Source/WebCore/rendering/ImageQualityController.h
trunk/Source/WebCore/rendering/RenderLayerFilterInfo.h
trunk/Source/WebCore/rendering/SimpleLineLayoutResolver.h
trunk/Source/WebCore/rendering/shapes/RasterShape.h
trunk/Source/WebCore/rendering/shapes/Shape.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp
trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h
trunk/Source/WebKit2/Platform/IPC/MessageRecorder.h
trunk/Source/WebKit2/Platform/mac/LayerHostingContext.h
Diff
Modified: trunk/Source/_javascript_Core/API/JSCallbackObject.h (187586 => 187587)
--- trunk/Source/_javascript_Core/API/JSCallbackObject.h 2015-07-30 16:21:45 UTC (rev 187586)
+++ trunk/Source/_javascript_Core/API/JSCallbackObject.h 2015-07-30 16:25:36 UTC (rev 187587)
@@ -79,6 +79,8 @@
void* privateData;
JSClassRef jsClass;
struct JSPrivatePropertyMap {
+WTF_MAKE_FAST_ALLOCATED;
+public:
JSValue getPrivateProperty(const Identifier propertyName) const
{
PrivatePropertyMap::const_iterator location = m_propertyMap.find(propertyName.impl());
Modified: trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm (187586 => 187587)
---
[webkit-changes] [187588] trunk/Source/WebCore
Title: [187588] trunk/Source/WebCore
Revision 187588
Author mra...@apple.com
Date 2015-07-30 10:02:13 -0700 (Thu, 30 Jul 2015)
Log Message
Media Session: add infrastructure for testing media control events
https://bugs.webkit.org/show_bug.cgi?id=147412
Reviewed by Eric Carlson.
* Modules/mediasession/MediaSessionManager.h:
* testing/Internals.cpp:
(WebCore::Internals::sendMediaControlEvent): Let tests simulate media control events.
* testing/Internals.h:
* testing/Internals.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasession/MediaSessionManager.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (187587 => 187588)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 16:25:36 UTC (rev 187587)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 17:02:13 UTC (rev 187588)
@@ -1,3 +1,16 @@
+2015-07-29 Matt Rajca mra...@apple.com
+
+Media Session: add infrastructure for testing media control events
+https://bugs.webkit.org/show_bug.cgi?id=147412
+
+Reviewed by Eric Carlson.
+
+* Modules/mediasession/MediaSessionManager.h:
+* testing/Internals.cpp:
+(WebCore::Internals::sendMediaControlEvent): Let tests simulate media control events.
+* testing/Internals.h:
+* testing/Internals.idl:
+
2015-07-30 Chris Dumez cdu...@apple.com
Mark more classes as fast allocated
Modified: trunk/Source/WebCore/Modules/mediasession/MediaSessionManager.h (187587 => 187588)
--- trunk/Source/WebCore/Modules/mediasession/MediaSessionManager.h 2015-07-30 16:25:36 UTC (rev 187587)
+++ trunk/Source/WebCore/Modules/mediasession/MediaSessionManager.h 2015-07-30 17:02:13 UTC (rev 187588)
@@ -41,9 +41,9 @@
public:
WEBCORE_EXPORT static MediaSessionManager singleton();
-void togglePlayback();
-void skipToNextTrack();
-void skipToPreviousTrack();
+WEBCORE_EXPORT void togglePlayback();
+WEBCORE_EXPORT void skipToNextTrack();
+WEBCORE_EXPORT void skipToPreviousTrack();
WEBCORE_EXPORT void didReceiveStartOfInterruptionNotification(MediaSessionInterruptingCategory) override;
WEBCORE_EXPORT void didReceiveEndOfInterruptionNotification(MediaSessionInterruptingCategory) override;
Modified: trunk/Source/WebCore/testing/Internals.cpp (187587 => 187588)
--- trunk/Source/WebCore/testing/Internals.cpp 2015-07-30 16:25:36 UTC (rev 187587)
+++ trunk/Source/WebCore/testing/Internals.cpp 2015-07-30 17:02:13 UTC (rev 187588)
@@ -2821,6 +2821,18 @@
ASSERT_ARG(element, element);
return element-playerVolume();
}
+
+void Internals::sendMediaControlEvent(const String event)
+{
+if (event == play-pause)
+MediaSessionManager::singleton().togglePlayback();
+else if (event == next-track)
+MediaSessionManager::singleton().skipToNextTrack();
+else if (event == previous-track)
+MediaSessionManager::singleton().skipToPreviousTrack();
+else
+ASSERT_NOT_REACHED();
+}
#endif // ENABLE(MEDIA_SESSION)
#if ENABLE(WEB_AUDIO)
Modified: trunk/Source/WebCore/testing/Internals.h (187587 => 187588)
--- trunk/Source/WebCore/testing/Internals.h 2015-07-30 16:25:36 UTC (rev 187587)
+++ trunk/Source/WebCore/testing/Internals.h 2015-07-30 17:02:13 UTC (rev 187588)
@@ -400,6 +400,7 @@
void sendMediaSessionEndOfInterruptionNotification(const String);
String mediaSessionCurrentState(MediaSession*) const;
double mediaElementPlayerVolume(HTMLMediaElement*) const;
+void sendMediaControlEvent(const String);
#endif
#if ENABLE(WEB_AUDIO)
Modified: trunk/Source/WebCore/testing/Internals.idl (187587 => 187588)
--- trunk/Source/WebCore/testing/Internals.idl 2015-07-30 16:25:36 UTC (rev 187587)
+++ trunk/Source/WebCore/testing/Internals.idl 2015-07-30 17:02:13 UTC (rev 187588)
@@ -51,6 +51,12 @@
transient-solo
};
+enum MediaControlEvent {
+play-pause,
+next-track,
+previous-track
+};
+
[
NoInterfaceObject,
] interface Internals {
@@ -363,6 +369,7 @@
[Conditional=MEDIA_SESSION] void sendMediaSessionEndOfInterruptionNotification(MediaSessionInterruptingCategory category);
[Conditional=MEDIA_SESSION] DOMString mediaSessionCurrentState(MediaSession session);
[Conditional=MEDIA_SESSION] double mediaElementPlayerVolume(HTMLMediaElement element);
+[Conditional=MEDIA_SESSION] void sendMediaControlEvent(MediaControlEvent event);
[Conditional=VIDEO] void applicationWillEnterForeground();
[Conditional=VIDEO] void applicationWillEnterBackground();
[Conditional=VIDEO, RaisesException] void setMediaSessionRestrictions(DOMString mediaType, DOMString restrictions);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187589] trunk/LayoutTests
Title: [187589] trunk/LayoutTests
Revision 187589
Author mra...@apple.com
Date 2015-07-30 10:19:47 -0700 (Thu, 30 Jul 2015)
Log Message
Media Session: test Next/Previous Track media control events delivered to Content media sessions https://bugs.webkit.org/show_bug.cgi?id=147416
Reviewed by Eric Carlson.
* media/session/track-media-events-in-content-sessions-expected.txt: Added.
* media/session/track-media-events-in-content-sessions.html: Added.
* platform/mac/TestExpectations: Media Session support is disabled by default.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
Added Paths
trunk/LayoutTests/media/session/track-media-events-in-content-sessions-expected.txt
trunk/LayoutTests/media/session/track-media-events-in-content-sessions.html
Diff
Modified: trunk/LayoutTests/ChangeLog (187588 => 187589)
--- trunk/LayoutTests/ChangeLog 2015-07-30 17:02:13 UTC (rev 187588)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 17:19:47 UTC (rev 187589)
@@ -1,3 +1,14 @@
+2015-07-29 Matt Rajca mra...@apple.com
+
+Media Session: test Next/Previous Track media control events delivered to Content media sessions
+https://bugs.webkit.org/show_bug.cgi?id=147416
+
+Reviewed by Eric Carlson.
+
+* media/session/track-media-events-in-content-sessions-expected.txt: Added.
+* media/session/track-media-events-in-content-sessions.html: Added.
+* platform/mac/TestExpectations: Media Session support is disabled by default.
+
2015-07-30 Michael Catanzaro mcatanz...@igalia.com
Web Inspector: [Freetype] Allow inspector to retrieve a list of system fonts
Added: trunk/LayoutTests/media/session/track-media-events-in-content-sessions-expected.txt (0 => 187589)
--- trunk/LayoutTests/media/session/track-media-events-in-content-sessions-expected.txt (rev 0)
+++ trunk/LayoutTests/media/session/track-media-events-in-content-sessions-expected.txt 2015-07-30 17:19:47 UTC (rev 187589)
@@ -0,0 +1,19 @@
+'Content' sessions that are active should respond to Previous/Next Track media control events.
+
+
+EVENT(canplaythrough)
+EXPECTED (internals.mediaSessionCurrentState(session) == 'idle') OK
+EXPECTED (video.paused == 'true') OK
+Begin playing media.
+EVENT(playing)
+Media began playing.
+EXPECTED (video.paused == 'false') OK
+EXPECTED (internals.mediaSessionCurrentState(session) == 'active') OK
+Sending Next Track media event.
+RUN(internals.sendMediaControlEvent(next-track))
+EVENT(nexttrack)
+Sending Previous Track media event.
+RUN(internals.sendMediaControlEvent(previous-track))
+EVENT(previoustrack)
+END OF TEST
+
Added: trunk/LayoutTests/media/session/track-media-events-in-content-sessions.html (0 => 187589)
--- trunk/LayoutTests/media/session/track-media-events-in-content-sessions.html (rev 0)
+++ trunk/LayoutTests/media/session/track-media-events-in-content-sessions.html 2015-07-30 17:19:47 UTC (rev 187589)
@@ -0,0 +1,65 @@
+!DOCTYPE html
+html
+head
+script src=""
+script src=""
+script type=text/_javascript_
+var session, controls;
+
+function runTest()
+{
+session = new MediaSession(content);
+controls = session.controls;
+controls.nextTrackEnabled = true;
+controls.previousTrackEnabled = true;
+waitForEvent('nexttrack', skipToNextTrack, false, true, controls);
+waitForEvent('previoustrack', skipToPreviousTrack, false, true, controls);
+
+findMediaElement();
+waitForEvent('canplaythrough', beginPlaying);
+video.src = "" ../content/counting);
+video.session = session;
+waitForEvent('playing', beganPlaying, false, true, video);
+}
+
+function beginPlaying(event)
+{
+if (window.internals)
+testExpected('internals.mediaSessionCurrentState(session)', idle);
+
+testExpected('video.paused', true);
+
+consoleWrite(Begin playing media.);
+video.play();
+}
+
+function beganPlaying(event)
+{
+consoleWrite(Media began playing.);
+testExpected('video.paused', false);
+
+if (window.internals) {
+testExpected('internals.mediaSessionCurrentState(session)', active);
+
+consoleWrite(Sending Next Track media event.);
+run('internals.sendMediaControlEvent(next-track)');
+}
+}
+
+function skipToNextTrack(event)
+{
+consoleWrite(Sending Previous Track media event.);
+run('internals.sendMediaControlEvent(previous-track)');
+}
+
+function skipToPreviousTrack(event)
+{
+endTest();
+}
+/script
+/head
+body _onload_=runTest()
+p'Content' sessions that are active should respond to Previous/Next Track media control events./p
[webkit-changes] [187590] branches/jsc-tailcall/Source/JavaScriptCore
Title: [187590] branches/jsc-tailcall/Source/_javascript_Core Revision 187590 Author basile_clem...@apple.com Date 2015-07-30 11:21:36 -0700 (Thu, 30 Jul 2015) Log Message Merged r187505 from trunk. Simplify call linking https://bugs.webkit.org/show_bug.cgi?id=147363 Reviewed by Filip Pizlo. Previously, we were passing both the CallLinkInfo and a (CodeSpecializationKind, RegisterPreservationMode) pair to the different call linking slow paths. However, the CallLinkInfo already has all of that information, and we don't gain anything by having them in additional static parameters - except possibly a very small performance gain in presence of inlining. However since those are already slow paths, this performance loss (if it exists) will not be visible in practice. This patch removes the various specialized thunks and JIT operations for regular and polymorphic call linking with a single thunk and operation for each case. Moreover, it removes the four specialized virtual call thunks and operations with one virtual call thunk for each call link info, allowing for better branch prediction by the CPU and fixing a pre-existing FIXME. * bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::unlink): (JSC::CallLinkInfo::dummy): Deleted. * bytecode/CallLinkInfo.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::registerPreservationMode): (JSC::CallLinkInfo::setUpCallFromFTL): (JSC::CallLinkInfo::setSlowStub): (JSC::CallLinkInfo::clearSlowStub): (JSC::CallLinkInfo::slowStub): * dfg/DFGDriver.cpp: (JSC::DFG::compileImpl): * dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::link): * ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::link): * jit/JITCall.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): * jit/JITCall32_64.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): * jit/JITOperations.cpp: * jit/JITOperations.h: (JSC::operationLinkFor): Deleted. (JSC::operationVirtualFor): Deleted. (JSC::operationLinkPolymorphicCallFor): Deleted. * jit/Repatch.cpp: (JSC::generateByIdStub): (JSC::linkSlowFor): (JSC::linkFor): (JSC::revertCall): (JSC::unlinkFor): (JSC::linkVirtualFor): (JSC::linkPolymorphicCall): * jit/Repatch.h: * jit/ThunkGenerators.cpp: (JSC::linkCallThunkGenerator): (JSC::linkPolymorphicCallThunkGenerator): (JSC::virtualThunkFor): (JSC::linkForThunkGenerator): Deleted. (JSC::linkConstructThunkGenerator): Deleted. (JSC::linkCallThatPreservesRegsThunkGenerator): Deleted. (JSC::linkConstructThatPreservesRegsThunkGenerator): Deleted. (JSC::linkPolymorphicCallForThunkGenerator): Deleted. (JSC::linkPolymorphicCallThatPreservesRegsThunkGenerator): Deleted. (JSC::virtualForThunkGenerator): Deleted. (JSC::virtualCallThunkGenerator): Deleted. (JSC::virtualConstructThunkGenerator): Deleted. (JSC::virtualCallThatPreservesRegsThunkGenerator): Deleted. (JSC::virtualConstructThatPreservesRegsThunkGenerator): Deleted. * jit/ThunkGenerators.h: (JSC::linkThunkGeneratorFor): Deleted. (JSC::linkPolymorphicCallThunkGeneratorFor): Deleted. (JSC::virtualThunkGeneratorFor): Deleted. Modified Paths branches/jsc-tailcall/Source/_javascript_Core/ChangeLog branches/jsc-tailcall/Source/_javascript_Core/bytecode/CallLinkInfo.cpp branches/jsc-tailcall/Source/_javascript_Core/bytecode/CallLinkInfo.h branches/jsc-tailcall/Source/_javascript_Core/dfg/DFGDriver.cpp branches/jsc-tailcall/Source/_javascript_Core/dfg/DFGJITCompiler.cpp branches/jsc-tailcall/Source/_javascript_Core/ftl/FTLJSCallBase.cpp branches/jsc-tailcall/Source/_javascript_Core/jit/JITCall.cpp branches/jsc-tailcall/Source/_javascript_Core/jit/JITCall32_64.cpp branches/jsc-tailcall/Source/_javascript_Core/jit/JITOperations.cpp branches/jsc-tailcall/Source/_javascript_Core/jit/JITOperations.h branches/jsc-tailcall/Source/_javascript_Core/jit/Repatch.cpp branches/jsc-tailcall/Source/_javascript_Core/jit/Repatch.h branches/jsc-tailcall/Source/_javascript_Core/jit/ThunkGenerators.cpp branches/jsc-tailcall/Source/_javascript_Core/jit/ThunkGenerators.h Diff Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (187589 => 187590) --- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-30 17:19:47 UTC (rev 187589) +++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-30 18:21:36 UTC (rev 187590) @@ -1,5 +1,88 @@ 2015-07-23 Basile Clement basile_clem...@apple.com +Merged r187505 from trunk. + +Simplify call linking +https://bugs.webkit.org/show_bug.cgi?id=147363 + +Reviewed by Filip Pizlo. + +Previously, we were passing both the CallLinkInfo and a +
[webkit-changes] [187591] trunk/Source/JavaScriptCore
Title: [187591] trunk/Source/_javascript_Core Revision 187591 Author commit-qu...@webkit.org Date 2015-07-30 11:29:18 -0700 (Thu, 30 Jul 2015) Log Message Add the wasm directory to the Additional Include Directories for jsc.exe https://bugs.webkit.org/show_bug.cgi?id=147443 Patch by Sukolsak Sakshuwong sukol...@gmail.com on 2015-07-30 Reviewed by Mark Lam. This patch should fix the ..\..\jsc.cpp(46): fatal error C1083: Cannot open include file: 'JSWASMModule.h' error in the Windows build. * _javascript_Core.vcxproj/jsc/jscCommon.props: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcxproj/jsc/jscCommon.props Diff Modified: trunk/Source/_javascript_Core/ChangeLog (187590 => 187591) --- trunk/Source/_javascript_Core/ChangeLog 2015-07-30 18:21:36 UTC (rev 187590) +++ trunk/Source/_javascript_Core/ChangeLog 2015-07-30 18:29:18 UTC (rev 187591) @@ -1,3 +1,15 @@ +2015-07-30 Sukolsak Sakshuwong sukol...@gmail.com + +Add the wasm directory to the Additional Include Directories for jsc.exe +https://bugs.webkit.org/show_bug.cgi?id=147443 + +Reviewed by Mark Lam. + +This patch should fix the ..\..\jsc.cpp(46): fatal error C1083: +Cannot open include file: 'JSWASMModule.h' error in the Windows build. + +* _javascript_Core.vcxproj/jsc/jscCommon.props: + 2015-07-30 Chris Dumez cdu...@apple.com Mark more classes as fast allocated Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/jsc/jscCommon.props (187590 => 187591) --- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/jsc/jscCommon.props 2015-07-30 18:21:36 UTC (rev 187590) +++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/jsc/jscCommon.props 2015-07-30 18:29:18 UTC (rev 187591) @@ -7,7 +7,7 @@ /PropertyGroup ItemDefinitionGroup ClCompile - AdditionalIncludeDirectories..\..\;..\..\tools\;..\..\runtime\;..\..\llint\;..\..\jit\;..\..\disassembler\;..\..\heap\;..\..\debugger\;..\..\assembler\;..\..\profiler\;..\..\interpreter\;..\..\bytecode\;..\..\dfg\;..\..\bytecompiler\;..\..\parser\;..\..\API\;$(ConfigurationBuildDir)\include\;$(ConfigurationBuildDir)\include\private\;$(ConfigurationBuildDir)\include\_javascript_Core\;$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\_javascript_Core\DerivedSources\;$(WebKit_Libraries)\include;%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories + AdditionalIncludeDirectories..\..\;..\..\tools\;..\..\runtime\;..\..\llint\;..\..\jit\;..\..\disassembler\;..\..\heap\;..\..\debugger\;..\..\assembler\;..\..\profiler\;..\..\interpreter\;..\..\bytecode\;..\..\dfg\;..\..\bytecompiler\;..\..\parser\;..\..\wasm\;..\..\API\;$(ConfigurationBuildDir)\include\;$(ConfigurationBuildDir)\include\private\;$(ConfigurationBuildDir)\include\_javascript_Core\;$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\_javascript_Core\DerivedSources\;$(WebKit_Libraries)\include;%(AdditionalIncludeDirectories)/AdditionalIncludeDirectories PreprocessorDefinitionsUSE_CONSOLE_ENTRY_POINT;%(PreprocessorDefinitions)/PreprocessorDefinitions ForcedIncludeFilesICUVersion.h/ForcedIncludeFiles /ClCompile ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187592] trunk/Source/WebCore
Title: [187592] trunk/Source/WebCore
Revision 187592
Author simon.fra...@apple.com
Date 2015-07-30 11:31:01 -0700 (Thu, 30 Jul 2015)
Log Message
Improve the history logging output
https://bugs.webkit.org/show_bug.cgi?id=147429
Reviewed by Alexey Proskuryakov.
Improve the History log channel output to show which frame is navigating,
print the addresses of the HistoryController and Frame, and print URLs
for everything.
Remove the BackForward log channel which had just one calling location,
and log for pushState/replaceState.
* loader/HistoryController.cpp:
(WebCore::HistoryController::updateForBackForwardNavigation):
(WebCore::HistoryController::updateForReload):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
(WebCore::HistoryController::updateForClientRedirect):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):
* platform/Logging.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/HistoryController.cpp
trunk/Source/WebCore/platform/Logging.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (187591 => 187592)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 18:29:18 UTC (rev 187591)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 18:31:01 UTC (rev 187592)
@@ -1,3 +1,29 @@
+2015-07-30 Simon Fraser simon.fra...@apple.com
+
+Improve the history logging output
+https://bugs.webkit.org/show_bug.cgi?id=147429
+
+Reviewed by Alexey Proskuryakov.
+
+Improve the History log channel output to show which frame is navigating,
+print the addresses of the HistoryController and Frame, and print URLs
+for everything.
+
+Remove the BackForward log channel which had just one calling location,
+and log for pushState/replaceState.
+
+* loader/HistoryController.cpp:
+(WebCore::HistoryController::updateForBackForwardNavigation):
+(WebCore::HistoryController::updateForReload):
+(WebCore::HistoryController::updateForStandardLoad):
+(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
+(WebCore::HistoryController::updateForClientRedirect):
+(WebCore::HistoryController::updateForCommit):
+(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
+(WebCore::HistoryController::pushState):
+(WebCore::HistoryController::replaceState):
+* platform/Logging.h:
+
2015-07-29 Matt Rajca mra...@apple.com
Media Session: add infrastructure for testing media control events
Modified: trunk/Source/WebCore/loader/HistoryController.cpp (187591 => 187592)
--- trunk/Source/WebCore/loader/HistoryController.cpp 2015-07-30 18:29:18 UTC (rev 187591)
+++ trunk/Source/WebCore/loader/HistoryController.cpp 2015-07-30 18:31:01 UTC (rev 187592)
@@ -316,10 +316,7 @@
void HistoryController::updateForBackForwardNavigation()
{
-#if !LOG_DISABLED
-if (m_frame.loader().documentLoader())
-LOG(History, WebCoreHistory: Updating History for back/forward navigation in frame %s, m_frame.loader().documentLoader()-title().string().utf8().data());
-#endif
+LOG(History, HistoryController %p updateForBackForwardNavigation: Updating History for back/forward navigation in frame %p (main frame %d) %s, this, m_frame, m_frame.isMainFrame(), m_frame.loader().documentLoader() ? m_frame.loader().documentLoader()-url().string().utf8().data() : );
// Must grab the current scroll position before disturbing it
if (!m_frameLoadComplete)
@@ -332,10 +329,7 @@
void HistoryController::updateForReload()
{
-#if !LOG_DISABLED
-if (m_frame.loader().documentLoader())
-LOG(History, WebCoreHistory: Updating History for reload in frame %s, m_frame.loader().documentLoader()-title().string().utf8().data());
-#endif
+LOG(History, HistoryController %p updateForBackForwardNavigation: Updating History for reload in frame %p (main frame %d) %s, this, m_frame, m_frame.isMainFrame(), m_frame.loader().documentLoader() ? m_frame.loader().documentLoader()-url().string().utf8().data() : );
if (m_currentItem) {
PageCache::singleton().remove(*m_currentItem);
@@ -360,7 +354,7 @@
void HistoryController::updateForStandardLoad(HistoryUpdateType updateType)
{
-LOG(History, WebCoreHistory: Updating History for Standard Load in frame %s, m_frame.loader().documentLoader()-url().string().ascii().data());
+LOG(History, HistoryController %p updateForStandardLoad: Updating History for standard load in frame %p (main frame %d) %s, this, m_frame, m_frame.isMainFrame(), m_frame.loader().documentLoader()-url().string().ascii().data());
FrameLoader frameLoader = m_frame.loader();
@@ -396,10 +390,7 @@
void HistoryController::updateForRedirectWithLockedBackForwardList()
{
[webkit-changes] [187593] trunk
Title: [187593] trunk
Revision 187593
Author simon.fra...@apple.com
Date 2015-07-30 11:32:45 -0700 (Thu, 30 Jul 2015)
Log Message
Selecting in an iframe can cause main page scrolling
https://bugs.webkit.org/show_bug.cgi?id=147431
rdar://problem/19244589
Reviewed by Zalan Bujtas.
Source/WebCore:
The RenderLayer auatoscroll code walks up the RenderLayer hierarchy, crossing
frame boundaries. However, as it crosses into an ancestor frame it failed to
map the target rect into the coordinate space of the new frame, which caused
us to scroll to an incorrect location in that parent frame.
Test: fast/events/autoscroll-in-iframe.html
* rendering/RenderLayer.cpp:
(WebCore::parentLayerCrossFrame): Make the layer a reference, and pass in
an optional rect. When crossing frame boundaries, map the rect from the
contents of the child frame to the contents of the parent frame.
(WebCore::RenderLayer::enclosingScrollableLayer): Pass optional rect.
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::hasScrollableOrRubberbandableAncestor):
* rendering/RenderLayer.h:
LayoutTests:
Test that uses eventSender to select in an iframe after scrolling the
main page.
* fast/events/autoscroll-in-iframe-expected.txt: Added.
* fast/events/autoscroll-in-iframe.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
Added Paths
trunk/LayoutTests/fast/events/autoscroll-in-iframe-expected.txt
trunk/LayoutTests/fast/events/autoscroll-in-iframe.html
Diff
Modified: trunk/LayoutTests/ChangeLog (187592 => 187593)
--- trunk/LayoutTests/ChangeLog 2015-07-30 18:31:01 UTC (rev 187592)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 18:32:45 UTC (rev 187593)
@@ -1,3 +1,17 @@
+2015-07-30 Simon Fraser simon.fra...@apple.com
+
+Selecting in an iframe can cause main page scrolling
+https://bugs.webkit.org/show_bug.cgi?id=147431
+rdar://problem/19244589
+
+Reviewed by Zalan Bujtas.
+
+Test that uses eventSender to select in an iframe after scrolling the
+main page.
+
+* fast/events/autoscroll-in-iframe-expected.txt: Added.
+* fast/events/autoscroll-in-iframe.html: Added.
+
2015-07-29 Matt Rajca mra...@apple.com
Media Session: test Next/Previous Track media control events delivered to Content media sessions
Added: trunk/LayoutTests/fast/events/autoscroll-in-iframe-expected.txt (0 => 187593)
--- trunk/LayoutTests/fast/events/autoscroll-in-iframe-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/autoscroll-in-iframe-expected.txt 2015-07-30 18:32:45 UTC (rev 187593)
@@ -0,0 +1,3 @@
+
+PASSED: selecting in the iframe did not scroll the page.
+
Added: trunk/LayoutTests/fast/events/autoscroll-in-iframe.html (0 => 187593)
--- trunk/LayoutTests/fast/events/autoscroll-in-iframe.html (rev 0)
+++ trunk/LayoutTests/fast/events/autoscroll-in-iframe.html 2015-07-30 18:32:45 UTC (rev 187593)
@@ -0,0 +1,89 @@
+html
+head
+style
+body {
+height: 2000px;
+}
+iframe {
+position: absolute;
+top: 800px;
+}
+/style
+script src=""
+script
+
+if (window.testRunner) {
+testRunner.waitUntilDone();
+testRunner.dumpAsText();
+}
+
+function log(msg)
+{
+document.getElementById('console').appendChild(document.createTextNode(msg + '\n'));
+}
+
+var verticalScrollOffset;
+var iframe;
+
+function doTest()
+{
+document.scrollingElement.scrollTop = 800;
+if (document.scrollingElement.scrollTop != 800)
+log(FAILED: failed to scroll by 800px);
+
+iframe = document.getElementById('targetFrame');
+
+var textInIframe = iframe.contentDocument.getElementById('starthere');
+var x = iframe.clientLeft + textInIframe.offsetLeft + 7;
+var y = iframe.clientTop + textInIframe.offsetTop + 7;
+if (window.eventSender) {
+eventSender.dragMode = false;
+eventSender.mouseMoveTo(x, y);
+eventSender.mouseDown();
+eventSender.mouseUp();
+}
+setTimeout(autoscrollTestPart1, 0);
+}
+
+function autoscrollTestPart1()
+{
+var mainDocumentTop = document.scrollingElement.scrollTop;
+if (mainDocumentTop != 800)
+log(FAILED: Clicking in the iframe scrolled the page (window.scrollTops is + mainDocumentTop + ));
+
+if (window.eventSender) {
+var textInIframe = iframe.contentDocument.getElementById('starthere');
+var x = iframe.clientLeft + textInIframe.offsetLeft + 7;
+
[webkit-changes] [187594] trunk/Source/WebKit2
Title: [187594] trunk/Source/WebKit2
Revision 187594
Author cdu...@apple.com
Date 2015-07-30 11:36:59 -0700 (Thu, 30 Jul 2015)
Log Message
Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
https://bugs.webkit.org/show_bug.cgi?id=147446
Reviewed by Simon Fraser.
Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
by leveraging the fact that we know in advance how many layer IDs are going to be added. We
now set the Vector size from the start, instead of clearing it and then growing the vector
capacity when appending the layer IDs one by one.
* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (187593 => 187594)
--- trunk/Source/WebKit2/ChangeLog 2015-07-30 18:32:45 UTC (rev 187593)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-30 18:36:59 UTC (rev 187594)
@@ -1,5 +1,20 @@
2015-07-30 Chris Dumez cdu...@apple.com
+Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
+https://bugs.webkit.org/show_bug.cgi?id=147446
+
+Reviewed by Simon Fraser.
+
+Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
+by leveraging the fact that we know in advance how many layer IDs are going to be added. We
+now set the Vector size from the start, instead of clearing it and then growing the vector
+capacity when appending the layer IDs one by one.
+
+* WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
+(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
+
+2015-07-30 Chris Dumez cdu...@apple.com
+
Mark more classes as fast allocated
https://bugs.webkit.org/show_bug.cgi?id=147440
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp (187593 => 187594)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2015-07-30 18:32:45 UTC (rev 187593)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp 2015-07-30 18:36:59 UTC (rev 187594)
@@ -158,9 +158,9 @@
if (m_properties.changedProperties != RemoteLayerTreeTransaction::NoChange) {
if (m_properties.changedProperties RemoteLayerTreeTransaction::ChildrenChanged) {
-m_properties.children.clear();
-for (const auto layer : m_children)
-m_properties.children.append(layer-layerID());
+m_properties.children.resize(m_children.size());
+for (size_t i = 0; i m_children.size(); ++i)
+m_properties.children[i] = m_children[i]-layerID();
}
if (isPlatformCALayerRemoteCustom()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187595] trunk/LayoutTests
Title: [187595] trunk/LayoutTests
Revision 187595
Author commit-qu...@webkit.org
Date 2015-07-30 11:39:42 -0700 (Thu, 30 Jul 2015)
Log Message
aria-liveregions-notifications tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=147299
rdar://problem/21998675
Patch by Nan Wang n_w...@apple.com on 2015-07-30
Reviewed by Chris Fleizach.
These tests were flaky because they relied on timer notification callbacks.
Fixed these tests by using different objects to capture the notifications instead.
* platform/mac/TestExpectations:
* platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt:
* platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:
* platform/mac/accessibility/aria-liveregions-notifications-expected.txt:
* platform/mac/accessibility/aria-liveregions-notifications.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt
trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html
trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-expected.txt
trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications.html
Diff
Modified: trunk/LayoutTests/ChangeLog (187594 => 187595)
--- trunk/LayoutTests/ChangeLog 2015-07-30 18:36:59 UTC (rev 187594)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 18:39:42 UTC (rev 187595)
@@ -1,3 +1,20 @@
+2015-07-30 Nan Wang n_w...@apple.com
+
+aria-liveregions-notifications tests are very flaky
+https://bugs.webkit.org/show_bug.cgi?id=147299
+rdar://problem/21998675
+
+Reviewed by Chris Fleizach.
+
+These tests were flaky because they relied on timer notification callbacks.
+Fixed these tests by using different objects to capture the notifications instead.
+
+* platform/mac/TestExpectations:
+* platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt:
+* platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:
+* platform/mac/accessibility/aria-liveregions-notifications-expected.txt:
+* platform/mac/accessibility/aria-liveregions-notifications.html:
+
2015-07-30 Simon Fraser simon.fra...@apple.com
Selecting in an iframe can cause main page scrolling
Modified: trunk/LayoutTests/platform/mac/TestExpectations (187594 => 187595)
--- trunk/LayoutTests/platform/mac/TestExpectations 2015-07-30 18:36:59 UTC (rev 187594)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-07-30 18:39:42 UTC (rev 187595)
@@ -1302,9 +1302,6 @@
# rdar://problem/21857102
[ ElCapitan+ ] fast/canvas/canvas-too-large-to-draw.html [ Crash ]
-webkit.org/b/147299 platform/mac/accessibility/aria-liveregions-notifications-always-sent.html [ Pass Failure ]
-webkit.org/b/147299 platform/mac/accessibility/aria-liveregions-notifications.html [ Pass Failure ]
-
# rdar://problem/22014672
[ ElCapitan+ ] imported/w3c/canvas/2d.composite.uncovered.fill.destination-atop.html [ Pass Failure ]
[ ElCapitan+ ] imported/w3c/canvas/2d.composite.uncovered.fill.destination-in.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt (187594 => 187595)
--- trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt 2015-07-30 18:36:59 UTC (rev 187594)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt 2015-07-30 18:39:42 UTC (rev 187595)
@@ -1,11 +1,12 @@
-Test test0test1test2
+Test test1
+test2
This tests that ARIA live region notifications are sent even when an assistive technology is not accessing them directly on each update.
On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-PASS addedNotification is true
-PASS liveRegionChangeCount == 3 is true
+PASS addedNotification1 is true
+PASS addedNotification2 is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html (187594 => 187595)
--- trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html 2015-07-30 18:36:59 UTC (rev 187594)
+++ trunk/LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html 2015-07-30 18:39:42 UTC (rev 187595)
@@ -5,9 +5,10 @@
/head
body id=body
-div role=group tabindex=0 id=liveregion aria-live=polite aria-relevant=additions
+div role=group tabindex=0 id=liveregion1 aria-live=polite aria-relevant=additions
Test
/div
+div role=group tabindex=0 id=liveregion2 aria-live=polite aria-relevant=additions/div
p id=description/p
div id=console/div
@@ -19,44 +20,43 @@
if (window.accessibilityController) {
-liveRegion =
[webkit-changes] [187585] trunk
Title: [187585] trunk
Revision 187585
Author achristen...@apple.com
Date 2015-07-30 09:16:23 -0700 (Thu, 30 Jul 2015)
Log Message
Build AppleWin port with CMake
https://bugs.webkit.org/show_bug.cgi?id=147385
Reviewed by Martin Robinson.
.:
* Source/cmake/OptionsWindows.cmake:
Use the static multithreaded runtime. Based on
http://www.cmake.org/Wiki/CMake_FAQ#How_can_I_build_my_MSVC_application_with_a_static_runtime.3F
Source/WebCore:
* CMakeLists.txt:
Add makesafeseh.asm to 32-bit build. It needs to be after the ADD_PRECOMPILED_HEADER macro
because CMake can only set COMPILE_FLAGS once with set_source_files_properties, and we want
to use that to add /safeseh instead of a precompiled header (which wouldn't be used anyway in assembly).
* PlatformAppleWin.cmake:
* PlatformWin.cmake:
* PlatformWinCairo.cmake:
Added missing source files and libraries.
Source/WebKit:
* PlatformWin.cmake:
Added missing source files and libraries.
Tools:
* WinLauncher/CMakeLists.txt:
Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformAppleWin.cmake
trunk/Source/WebCore/PlatformWin.cmake
trunk/Source/WebCore/PlatformWinCairo.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWin.cmake
trunk/Source/cmake/OptionsWindows.cmake
trunk/Tools/ChangeLog
trunk/Tools/WinLauncher/CMakeLists.txt
Diff
Modified: trunk/ChangeLog (187584 => 187585)
--- trunk/ChangeLog 2015-07-30 15:56:35 UTC (rev 187584)
+++ trunk/ChangeLog 2015-07-30 16:16:23 UTC (rev 187585)
@@ -1,3 +1,14 @@
+2015-07-30 Alex Christensen achristen...@webkit.org
+
+Build AppleWin port with CMake
+https://bugs.webkit.org/show_bug.cgi?id=147385
+
+Reviewed by Martin Robinson.
+
+* Source/cmake/OptionsWindows.cmake:
+Use the static multithreaded runtime. Based on
+http://www.cmake.org/Wiki/CMake_FAQ#How_can_I_build_my_MSVC_application_with_a_static_runtime.3F
+
2015-07-29 Andy VanWagoner thetalecraf...@gmail.com
Implement basic types for ECMAScript Internationalization API
Modified: trunk/Source/WebCore/CMakeLists.txt (187584 => 187585)
--- trunk/Source/WebCore/CMakeLists.txt 2015-07-30 15:56:35 UTC (rev 187584)
+++ trunk/Source/WebCore/CMakeLists.txt 2015-07-30 16:16:23 UTC (rev 187585)
@@ -3576,6 +3576,10 @@
if (MSVC)
ADD_PRECOMPILED_HEADER(WebCorePrefix.h WebCorePrefix.cpp WebCore_SOURCES)
+if (CMAKE_SIZEOF_VOID_P EQUAL 4)
+list(APPEND WebCore_SOURCES platform/win/makesafeseh.asm)
+set_source_files_properties(platform/win/makesafeseh.asm PROPERTIES COMPILE_FLAGS /safeseh)
+endif ()
endif ()
add_library(WebCore ${WebCore_LIBRARY_TYPE} ${WebCore_SOURCES})
Modified: trunk/Source/WebCore/ChangeLog (187584 => 187585)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 15:56:35 UTC (rev 187584)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 16:16:23 UTC (rev 187585)
@@ -1,5 +1,21 @@
2015-07-30 Alex Christensen achristen...@webkit.org
+Build AppleWin port with CMake
+https://bugs.webkit.org/show_bug.cgi?id=147385
+
+Reviewed by Martin Robinson.
+
+* CMakeLists.txt:
+Add makesafeseh.asm to 32-bit build. It needs to be after the ADD_PRECOMPILED_HEADER macro
+because CMake can only set COMPILE_FLAGS once with set_source_files_properties, and we want
+to use that to add /safeseh instead of a precompiled header (which wouldn't be used anyway in assembly).
+* PlatformAppleWin.cmake:
+* PlatformWin.cmake:
+* PlatformWinCairo.cmake:
+Added missing source files and libraries.
+
+2015-07-30 Alex Christensen achristen...@webkit.org
+
[Win] Unreviewed build fix after r187582.
* accessibility/AccessibilityAllInOne.cpp:
Modified: trunk/Source/WebCore/PlatformAppleWin.cmake (187584 => 187585)
--- trunk/Source/WebCore/PlatformAppleWin.cmake 2015-07-30 15:56:35 UTC (rev 187584)
+++ trunk/Source/WebCore/PlatformAppleWin.cmake 2015-07-30 16:16:23 UTC (rev 187585)
@@ -13,6 +13,11 @@
list(APPEND WebCore_SOURCES
editing/SmartReplaceCF.cpp
+loader/cf/ResourceLoaderCFNet.cpp
+
+page/win/FrameCGWin.cpp
+
+platform/cf/CFURLExtras.cpp
platform/cf/URLCF.cpp
platform/graphics/ca/GraphicsLayerCA.cpp
@@ -71,12 +76,16 @@
platform/network/cf/FormDataStreamCFNet.cpp
platform/network/cf/LoaderRunLoopCF.cpp
platform/network/cf/NetworkStorageSessionCFNet.cpp
+platform/network/cf/ProtectionSpaceCFNet.cpp
platform/network/cf/ProxyServerCFNet.cpp
platform/network/cf/ResourceErrorCF.cpp
platform/network/cf/ResourceHandleCFNet.cpp
+platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp
platform/network/cf/ResourceRequestCFNet.cpp
platform/network/cf/ResourceResponseCFNet.cpp
[webkit-changes] [187586] trunk/Source/WebCore
Title: [187586] trunk/Source/WebCore
Revision 187586
Author mcatanz...@igalia.com
Date 2015-07-30 09:21:45 -0700 (Thu, 30 Jul 2015)
Log Message
[GTK] Crashes when SoupSession is destroyed in exit handler
https://bugs.webkit.org/show_bug.cgi?id=145347
Reviewed by Carlos Garcia Campos.
Leak the default SoupSession with NeverDestroyed to avoid races at program exit.
* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::defaultSession):
* platform/network/soup/SoupNetworkSession.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (187585 => 187586)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 16:16:23 UTC (rev 187585)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 16:21:45 UTC (rev 187586)
@@ -1,3 +1,16 @@
+2015-07-30 Michael Catanzaro mcatanz...@igalia.com
+
+[GTK] Crashes when SoupSession is destroyed in exit handler
+https://bugs.webkit.org/show_bug.cgi?id=145347
+
+Reviewed by Carlos Garcia Campos.
+
+Leak the default SoupSession with NeverDestroyed to avoid races at program exit.
+
+* platform/network/soup/SoupNetworkSession.cpp:
+(WebCore::SoupNetworkSession::defaultSession):
+* platform/network/soup/SoupNetworkSession.h:
+
2015-07-30 Alex Christensen achristen...@webkit.org
Build AppleWin port with CMake
Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (187585 => 187586)
--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2015-07-30 16:16:23 UTC (rev 187585)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2015-07-30 16:21:45 UTC (rev 187586)
@@ -37,6 +37,7 @@
#include ResourceHandle.h
#include glib/gstdio.h
#include libsoup/soup.h
+#include wtf/NeverDestroyed.h
#include wtf/text/CString.h
#include wtf/text/StringBuilder.h
@@ -51,7 +52,7 @@
SoupNetworkSession SoupNetworkSession::defaultSession()
{
-static SoupNetworkSession networkSession(soupCookieJar());
+static NeverDestroyedSoupNetworkSession networkSession(soupCookieJar());
return networkSession;
}
Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h (187585 => 187586)
--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h 2015-07-30 16:16:23 UTC (rev 187585)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.h 2015-07-30 16:21:45 UTC (rev 187586)
@@ -70,6 +70,8 @@
void setAcceptLanguages(const VectorString);
private:
+friend class NeverDestroyedSoupNetworkSession;
+
SoupNetworkSession(SoupCookieJar*);
SoupNetworkSession(SoupSession*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187619] trunk/Source/WebInspectorUI
Title: [187619] trunk/Source/WebInspectorUI Revision 187619 Author mattba...@apple.com Date 2015-07-30 16:25:43 -0700 (Thu, 30 Jul 2015) Log Message Web Inspector: Fix typo in frame duration filtering console.assert message https://bugs.webkit.org/show_bug.cgi?id=147458 Rubber-stamped by Joseph Pecoraro. * UserInterface/Views/RenderingFrameTimelineView.js: (WebInspector.RenderingFrameTimelineView.displayNameForDurationFilter): Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (187618 => 187619) --- trunk/Source/WebInspectorUI/ChangeLog 2015-07-30 23:19:30 UTC (rev 187618) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-07-30 23:25:43 UTC (rev 187619) @@ -1,3 +1,13 @@ +2015-07-30 Matt Baker mattba...@apple.com + +Web Inspector: Fix typo in frame duration filtering console.assert message +https://bugs.webkit.org/show_bug.cgi?id=147458 + +Rubber-stamped by Joseph Pecoraro. + +* UserInterface/Views/RenderingFrameTimelineView.js: +(WebInspector.RenderingFrameTimelineView.displayNameForDurationFilter): + 2015-07-30 Nikita Vasilyev nvasil...@apple.com Web Inspector: Regression: %c is broken for console.group Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js (187618 => 187619) --- trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2015-07-30 23:19:30 UTC (rev 187618) +++ trunk/Source/WebInspectorUI/UserInterface/Views/RenderingFrameTimelineView.js 2015-07-30 23:25:43 UTC (rev 187619) @@ -100,7 +100,7 @@ case WebInspector.RenderingFrameTimelineView.DurationFilter.OverFifteenMilliseconds: return WebInspector.UIString(Over 15 ms); default: -console.error(Unknown tab type, tabType); +console.error(Unknown filter type, filter); } return null; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187629] branches/jsc-tailcall/Source/JavaScriptCore
Title: [187629] branches/jsc-tailcall/Source/_javascript_Core Revision 187629 Author basile_clem...@apple.com Date 2015-07-30 17:43:25 -0700 (Thu, 30 Jul 2015) Log Message jsc-tailcall: Add enums for type-safety https://bugs.webkit.org/show_bug.cgi?id=147475 Reviewed by Michael Saboff. This adds: - A CallMode enum to distinguish tail calls from regular calls from construct - A FrameAction enum to indicate whether to keep or reuse the call frame. It also changes JITOperations.h to correctly use this to tell slowPathFor to *not* trash the frame on a regular call (before r187505, this was statically known in slowPathFor). * CMakeLists.txt: * _javascript_Core.vcxproj/_javascript_Core.vcxproj: * _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: * _javascript_Core.xcodeproj/project.pbxproj: * assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::repatchNearCall): * assembler/CodeLocation.h: (JSC::CodeLocationNearCall::CodeLocationNearCall): (JSC::CodeLocationNearCall::callMode): (JSC::CodeLocationCommon::nearCallAtOffset): * assembler/LinkBuffer.h: (JSC::LinkBuffer::locationOfNearCall): * bytecode/CallLinkInfo.h: (JSC::CallLinkInfo::callModeFor): (JSC::CallLinkInfo::callMode): (JSC::CallLinkInfo::isTailCall): (JSC::CallLinkInfo::isVarargs): * bytecode/CallMode.cpp: Added. (WTF::printInternal): * bytecode/CallMode.h: Added. * jit/JITOperations.cpp: * jit/Repatch.cpp: (JSC::linkPolymorphicCall): * jit/ThunkGenerators.cpp: (JSC::slowPathFor): (JSC::virtualThunkFor): Modified Paths branches/jsc-tailcall/Source/_javascript_Core/CMakeLists.txt branches/jsc-tailcall/Source/_javascript_Core/ChangeLog branches/jsc-tailcall/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj branches/jsc-tailcall/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters branches/jsc-tailcall/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj branches/jsc-tailcall/Source/_javascript_Core/assembler/AbstractMacroAssembler.h branches/jsc-tailcall/Source/_javascript_Core/assembler/CodeLocation.h branches/jsc-tailcall/Source/_javascript_Core/assembler/LinkBuffer.h branches/jsc-tailcall/Source/_javascript_Core/bytecode/CallLinkInfo.h branches/jsc-tailcall/Source/_javascript_Core/jit/JITOperations.cpp branches/jsc-tailcall/Source/_javascript_Core/jit/Repatch.cpp branches/jsc-tailcall/Source/_javascript_Core/jit/ThunkGenerators.cpp Added Paths branches/jsc-tailcall/Source/_javascript_Core/bytecode/CallMode.cpp branches/jsc-tailcall/Source/_javascript_Core/bytecode/CallMode.h Diff Modified: branches/jsc-tailcall/Source/_javascript_Core/CMakeLists.txt (187628 => 187629) --- branches/jsc-tailcall/Source/_javascript_Core/CMakeLists.txt 2015-07-31 00:37:38 UTC (rev 187628) +++ branches/jsc-tailcall/Source/_javascript_Core/CMakeLists.txt 2015-07-31 00:43:25 UTC (rev 187629) @@ -76,6 +76,7 @@ bytecode/CallEdge.cpp bytecode/CallLinkInfo.cpp bytecode/CallLinkStatus.cpp +bytecode/CallMode.cpp bytecode/CallVariant.cpp bytecode/CodeBlock.cpp bytecode/CodeBlockHash.cpp Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (187628 => 187629) --- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-31 00:37:38 UTC (rev 187628) +++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-07-31 00:43:25 UTC (rev 187629) @@ -1,5 +1,48 @@ 2015-07-30 Basile Clement basile_clem...@apple.com +jsc-tailcall: Add enums for type-safety +https://bugs.webkit.org/show_bug.cgi?id=147475 + +Reviewed by Michael Saboff. + +This adds: + + - A CallMode enum to distinguish tail calls from regular calls from construct + + - A FrameAction enum to indicate whether to keep or reuse the call + frame. It also changes JITOperations.h to correctly use this to tell + slowPathFor to *not* trash the frame on a regular call (before + r187505, this was statically known in slowPathFor). + +* CMakeLists.txt: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj: +* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters: +* _javascript_Core.xcodeproj/project.pbxproj: +* assembler/AbstractMacroAssembler.h: +(JSC::AbstractMacroAssembler::repatchNearCall): +* assembler/CodeLocation.h: +(JSC::CodeLocationNearCall::CodeLocationNearCall): +(JSC::CodeLocationNearCall::callMode): +(JSC::CodeLocationCommon::nearCallAtOffset): +* assembler/LinkBuffer.h: +(JSC::LinkBuffer::locationOfNearCall): +* bytecode/CallLinkInfo.h: +(JSC::CallLinkInfo::callModeFor): +(JSC::CallLinkInfo::callMode): +(JSC::CallLinkInfo::isTailCall): +(JSC::CallLinkInfo::isVarargs): +* bytecode/CallMode.cpp: Added. +(WTF::printInternal): +* bytecode/CallMode.h: Added. +* jit/JITOperations.cpp: +*
[webkit-changes] [187633] branches/safari-600.1.4.17-branch/Source/WebCore
Title: [187633] branches/safari-600.1.4.17-branch/Source/WebCore
Revision 187633
Author bshaf...@apple.com
Date 2015-07-30 18:49:35 -0700 (Thu, 30 Jul 2015)
Log Message
Roll out r186895. rdar://problem/21714851
Modified Paths
branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog
branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Diff
Modified: branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog (187632 => 187633)
--- branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog 2015-07-31 01:43:22 UTC (rev 187632)
+++ branches/safari-600.1.4.17-branch/Source/WebCore/ChangeLog 2015-07-31 01:49:35 UTC (rev 187633)
@@ -1,5 +1,9 @@
2015-07-30 Babak Shafiei bshaf...@apple.com
+Roll out r186895.
+
+2015-07-30 Babak Shafiei bshaf...@apple.com
+
Roll out r187048.
2015-07-30 Babak Shafiei bshaf...@apple.com
Modified: branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp (187632 => 187633)
--- branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-31 01:43:22 UTC (rev 187632)
+++ branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp 2015-07-31 01:49:35 UTC (rev 187633)
@@ -47,12 +47,6 @@
};
#endif
-#ifdef __cplusplus
-extern C CFArrayRef _CFHTTPParsedCookiesWithResponseHeaderFields(CFAllocatorRef inAllocator, CFDictionaryRef headerFields, CFURLRef inURL);
-#else
-extern CFArrayRef _CFHTTPParsedCookiesWithResponseHeaderFields(CFAllocatorRef inAllocator, CFDictionaryRef headerFields, CFURLRef inURL);
-#endif
-
namespace WebCore {
static const CFStringRef s_setCookieKeyCF = CFSTR(Set-Cookie);
@@ -118,15 +112,6 @@
#endif
}
-static CFArrayRef createCookies(CFDictionaryRef headerFields, CFURLRef url)
-{
-#if (PLATFORM(IOS) __IPHONE_OS_VERSION_MIN_REQUIRED = 9)
-return _CFHTTPParsedCookiesWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
-#else
-return CFHTTPCookieCreateWithResponseHeaderFields(kCFAllocatorDefault, headerFields, url);
-#endif
-}
-
void setCookiesFromDOM(const NetworkStorageSession session, const URL firstParty, const URL url, const String value)
{
// rdar://problem/5632883 CFHTTPCookieStorage stores an empty cookie, which would be sent as Cookie: =.
@@ -145,8 +130,10 @@
(const void**)s_setCookieKeyCF, (const void**)cookieStringCF, 1,
kCFTypeDictionaryKeyCallBacks, kCFTypeDictionaryValueCallBacks));
-RetainPtrCFArrayRef unfilteredCookies = adoptCF(createCookies(headerFieldsCF.get(), urlCF.get()));
-CFHTTPCookieStorageSetCookies(session.cookieStorage().get(), filterCookies(unfilteredCookies.get()).get(), urlCF.get(), firstPartyForCookiesCF.get());
+RetainPtrCFArrayRef cookiesCF = adoptCF(CFHTTPCookieCreateWithResponseHeaderFields(kCFAllocatorDefault,
+headerFieldsCF.get(), urlCF.get()));
+
+CFHTTPCookieStorageSetCookies(session.cookieStorage().get(), filterCookies(cookiesCF.get()).get(), urlCF.get(), firstPartyForCookiesCF.get());
}
String cookiesForDOM(const NetworkStorageSession session, const URL firstParty, const URL url)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187596] trunk
Title: [187596] trunk Revision 187596 Author commit-qu...@webkit.org Date 2015-07-30 11:47:37 -0700 (Thu, 30 Jul 2015) Log Message [EFL] Enable IndexedDB based on DatabaseProcess https://bugs.webkit.org/show_bug.cgi?id=147221 Patch by Joonghun Park jh718.p...@samsung.com on 2015-07-30 Reviewed by Csaba Osztrogonác. .: * Source/cmake/OptionsEfl.cmake: Source/WebKit2: * DatabaseProcess/efl/DatabaseProcessMainEfl.cpp: Add ecore_init(). Without this call, it leads to crash when launching DatabaseProcess. * PlatformEfl.cmake: Add missing include_directory. * Shared/efl/ProcessExecutablePathEfl.cpp: (WebKit::executablePathOfDatabaseProcess): * UIProcess/Launcher/efl/ProcessLauncherEfl.cpp: (WebKit::ProcessLauncher::launchProcess): * UIProcess/efl/WebProcessPoolEfl.cpp: (WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory): Add default path for indexedDB sqlite3 db file. Tools: * Scripts/webkitperl/FeatureList.pm: LayoutTests: * platform/efl/TestExpectations: Update IndexedDB test expectations. Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/DatabaseProcess/efl/DatabaseProcessMainEfl.cpp trunk/Source/WebKit2/PlatformEfl.cmake trunk/Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp trunk/Source/WebKit2/UIProcess/efl/WebProcessPoolEfl.cpp trunk/Source/cmake/OptionsEfl.cmake trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitperl/FeatureList.pm Diff Modified: trunk/ChangeLog (187595 => 187596) --- trunk/ChangeLog 2015-07-30 18:39:42 UTC (rev 187595) +++ trunk/ChangeLog 2015-07-30 18:47:37 UTC (rev 187596) @@ -1,3 +1,12 @@ +2015-07-30 Joonghun Park jh718.p...@samsung.com + +[EFL] Enable IndexedDB based on DatabaseProcess +https://bugs.webkit.org/show_bug.cgi?id=147221 + +Reviewed by Csaba Osztrogonác. + +* Source/cmake/OptionsEfl.cmake: + 2015-07-30 Alex Christensen achristen...@webkit.org Build AppleWin port with CMake Modified: trunk/LayoutTests/ChangeLog (187595 => 187596) --- trunk/LayoutTests/ChangeLog 2015-07-30 18:39:42 UTC (rev 187595) +++ trunk/LayoutTests/ChangeLog 2015-07-30 18:47:37 UTC (rev 187596) @@ -1,3 +1,12 @@ +2015-07-30 Joonghun Park jh718.p...@samsung.com + +[EFL] Enable IndexedDB based on DatabaseProcess +https://bugs.webkit.org/show_bug.cgi?id=147221 + +Reviewed by Csaba Osztrogonác. + +* platform/efl/TestExpectations: Update IndexedDB test expectations. + 2015-07-30 Nan Wang n_w...@apple.com aria-liveregions-notifications tests are very flaky Modified: trunk/LayoutTests/platform/efl/TestExpectations (187595 => 187596) --- trunk/LayoutTests/platform/efl/TestExpectations 2015-07-30 18:39:42 UTC (rev 187595) +++ trunk/LayoutTests/platform/efl/TestExpectations 2015-07-30 18:47:37 UTC (rev 187596) @@ -273,16 +273,106 @@ # ENABLE(DRAGGABLE_REGION) is disabled fast/css/draggable-region-parser.html -# IndexedDB is on refactoring/refreshing, so the tests are quite unstable at this point. -webkit.org/b/87661 storage/indexeddb [ Skip ] -webkit.org/b/87661 http/tests/security/cross-origin-indexeddb-allowed.html [ Skip ] -webkit.org/b/87661 http/tests/security/cross-origin-indexeddb.html [ Skip ] -webkit.org/b/87661 http/tests/security/cross-origin-worker-indexeddb-allowed.html [ Skip ] -webkit.org/b/87661 http/tests/security/cross-origin-worker-indexeddb.html [ Skip ] -webkit.org/b/87661 http/tests/security/no-indexeddb-from-sandbox.html [ Skip ] +## IndexedDB related failures + +# Blink tests with unexplained timeouts +storage/indexeddb/database-deletepending-flag.html [ Skip ] +storage/indexeddb/exceptions.html [ Skip ] +storage/indexeddb/intversion-gated-on-delete.html [ Skip ] +storage/indexeddb/intversion-long-queue.html [ Skip ] +storage/indexeddb/open-ordering.html [ Skip ] +storage/indexeddb/transaction-basics.html [ Skip ] +storage/indexeddb/transaction-coordination-within-database.html [ Skip ] + +# Blink tests with non-trivial text failures. +storage/indexeddb/createIndex-after-failure.html [ Skip ] +storage/indexeddb/create-object-store-options.html [ Skip ] +storage/indexeddb/cursor-advance.html [ Skip ] +storage/indexeddb/cursor-basics.html [ Skip ] +storage/indexeddb/cursor-continue.html [ Skip ] +storage/indexeddb/cursor-continue-validity.html [ Skip ] +storage/indexeddb/cursor-continueprimarykey.html [ Skip ] +storage/indexeddb/cursor-index-delete.html [ Skip ] +storage/indexeddb/cursor-key-order.html [ Skip ] +storage/indexeddb/cursor-leak.html [ Skip ] # Missing needed WKTR feature? +storage/indexeddb/cursor-overloads.html [ Skip ] +storage/indexeddb/cursor-primary-key-order.html [ Skip ] +storage/indexeddb/cursor-request-cycle.html [ Skip ] # Missing needed WKTR feature? +storage/indexeddb/cursor-update.html [ Skip ] +storage/indexeddb/data-corruption.html [
[webkit-changes] [187597] trunk/Source
Title: [187597] trunk/Source Revision 187597 Author simon.fra...@apple.com Date 2015-07-30 12:13:49 -0700 (Thu, 30 Jul 2015) Log Message Convert Path applier to use std::function https://bugs.webkit.org/show_bug.cgi?id=147368 Reviewed by Sam Weinig. Use std::function for Path::apply(). Source/WebCore: * accessibility/mac/WebAccessibilityObjectWrapperBase.mm: (convertPathToScreenSpaceFunction): (-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]): (ConvertPathToScreenSpaceFunction): Deleted. * inspector/InspectorOverlay.cpp: (WebCore::appendPathSegment): (WebCore::buildObjectForShapeOutside): * platform/graphics/Path.cpp: (WebCore::Path::length): (WebCore::Path::traversalStateAtLength): (WebCore::pathLengthApplierFunction): Deleted. * platform/graphics/Path.h: * platform/graphics/cairo/FontCairo.cpp: (WebCore::findPathIntersections): (WebCore::FontCascade::dashesForIntersectionsWithRect): * platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::apply): * platform/graphics/cg/PathCG.cpp: (WebCore::CGPathApplierToPathApplier): (WebCore::Path::apply): * rendering/svg/RenderSVGPath.cpp: (WebCore::RenderSVGPath::updateZeroLengthSubpaths): * rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::processMarkerPositions): * rendering/svg/SVGMarkerData.h: (WebCore::SVGMarkerData::updateFromPathElement): * rendering/svg/SVGSubpathData.h: (WebCore::SVGSubpathData::updateFromPathElement): (WebCore::SVGSubpathData::SVGSubpathData): Deleted. * svg/SVGPathUtilities.cpp: (WebCore::pathIteratorForBuildingString): (WebCore::buildStringFromPath): Source/WebKit2: * Shared/WebCoreArgumentCoders.cpp: (IPC::pathEncodeApplierFunction): (IPC::ArgumentCoderPath::encode): (IPC::pathPointCountApplierFunction): Deleted. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm trunk/Source/WebCore/inspector/InspectorOverlay.cpp trunk/Source/WebCore/platform/graphics/Path.cpp trunk/Source/WebCore/platform/graphics/Path.h trunk/Source/WebCore/platform/graphics/cairo/FontCairo.cpp trunk/Source/WebCore/platform/graphics/cairo/PathCairo.cpp trunk/Source/WebCore/platform/graphics/cg/PathCG.cpp trunk/Source/WebCore/rendering/svg/RenderSVGPath.cpp trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp trunk/Source/WebCore/rendering/svg/SVGMarkerData.h trunk/Source/WebCore/rendering/svg/SVGSubpathData.h trunk/Source/WebCore/svg/SVGPathUtilities.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (187596 => 187597) --- trunk/Source/WebCore/ChangeLog 2015-07-30 18:47:37 UTC (rev 187596) +++ trunk/Source/WebCore/ChangeLog 2015-07-30 19:13:49 UTC (rev 187597) @@ -1,5 +1,47 @@ 2015-07-30 Simon Fraser simon.fra...@apple.com +Convert Path applier to use std::function +https://bugs.webkit.org/show_bug.cgi?id=147368 + +Reviewed by Sam Weinig. + +Use std::function for Path::apply(). + +* accessibility/mac/WebAccessibilityObjectWrapperBase.mm: +(convertPathToScreenSpaceFunction): +(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]): +(ConvertPathToScreenSpaceFunction): Deleted. +* inspector/InspectorOverlay.cpp: +(WebCore::appendPathSegment): +(WebCore::buildObjectForShapeOutside): +* platform/graphics/Path.cpp: +(WebCore::Path::length): +(WebCore::Path::traversalStateAtLength): +(WebCore::pathLengthApplierFunction): Deleted. +* platform/graphics/Path.h: +* platform/graphics/cairo/FontCairo.cpp: +(WebCore::findPathIntersections): +(WebCore::FontCascade::dashesForIntersectionsWithRect): +* platform/graphics/cairo/PathCairo.cpp: +(WebCore::Path::apply): +* platform/graphics/cg/PathCG.cpp: +(WebCore::CGPathApplierToPathApplier): +(WebCore::Path::apply): +* rendering/svg/RenderSVGPath.cpp: +(WebCore::RenderSVGPath::updateZeroLengthSubpaths): +* rendering/svg/RenderSVGShape.cpp: +(WebCore::RenderSVGShape::processMarkerPositions): +* rendering/svg/SVGMarkerData.h: +(WebCore::SVGMarkerData::updateFromPathElement): +* rendering/svg/SVGSubpathData.h: +(WebCore::SVGSubpathData::updateFromPathElement): +(WebCore::SVGSubpathData::SVGSubpathData): Deleted. +* svg/SVGPathUtilities.cpp: +(WebCore::pathIteratorForBuildingString): +(WebCore::buildStringFromPath): + +2015-07-30 Simon Fraser simon.fra...@apple.com + Selecting in an iframe can cause main page scrolling https://bugs.webkit.org/show_bug.cgi?id=147431 rdar://problem/19244589 Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm (187596 => 187597) --- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm 2015-07-30 18:47:37 UTC (rev 187596)
[webkit-changes] [187581] trunk/LayoutTests
Title: [187581] trunk/LayoutTests
Revision 187581
Author benja...@webkit.org
Date 2015-07-30 02:52:48 -0700 (Thu, 30 Jul 2015)
Log Message
Update JSC's standalone-pre.js for r187575
https://bugs.webkit.org/show_bug.cgi?id=147444
Unreviewed.
* resources/standalone-pre.js:
(shouldBeType):
Copy shouldBeType() from the non-standalone version.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/resources/standalone-pre.js
Diff
Modified: trunk/LayoutTests/ChangeLog (187580 => 187581)
--- trunk/LayoutTests/ChangeLog 2015-07-30 06:39:59 UTC (rev 187580)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 09:52:48 UTC (rev 187581)
@@ -1,3 +1,14 @@
+2015-07-30 Benjamin Poulain benja...@webkit.org
+
+Update JSC's standalone-pre.js for r187575
+https://bugs.webkit.org/show_bug.cgi?id=147444
+
+Unreviewed.
+
+* resources/standalone-pre.js:
+(shouldBeType):
+Copy shouldBeType() from the non-standalone version.
+
2015-07-29 Andy VanWagoner thetalecraf...@gmail.com
Implement basic types for ECMAScript Internationalization API
Modified: trunk/LayoutTests/resources/standalone-pre.js (187580 => 187581)
--- trunk/LayoutTests/resources/standalone-pre.js 2015-07-30 06:39:59 UTC (rev 187580)
+++ trunk/LayoutTests/resources/standalone-pre.js 2015-07-30 09:52:48 UTC (rev 187581)
@@ -175,6 +175,23 @@
return values.length;
}
+function shouldBeType(_a, _type) {
+ var exception;
+ var _av;
+ try {
+_av = eval(_a);
+ } catch (e) {
+exception = e;
+ }
+
+ var _typev = eval(_type);
+ if (_av instanceof _typev) {
+testPassed(_a + is an instance of + _type);
+ } else {
+testFailed(_a + is not an instance of + _type);
+ }
+}
+
function shouldBeTrue(_a) { shouldBe(_a, true); }
function shouldBeFalse(_a) { shouldBe(_a, false); }
function shouldBeNaN(_a) { shouldBe(_a, NaN); }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [187582] trunk
Title: [187582] trunk Revision 187582 Author commit-qu...@webkit.org Date 2015-07-30 04:10:38 -0700 (Thu, 30 Jul 2015) Log Message AX: VoiceOver unable to access content in malformed trees https://bugs.webkit.org/show_bug.cgi?id=147295 rdar://problem/14862892 Patch by Nan Wang n_w...@apple.com on 2015-07-30 Reviewed by Chris Fleizach. Source/WebCore: VoiceOver is skipping the content of malformed trees. This fixes the problem by having the tree check if it has valid children (treeitems) and makes treeitems check if they are inside trees. Test: platform/mac/accessibility/malformed-tree.html * CMakeLists.txt: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * WebCore.xcodeproj/project.pbxproj: * accessibility/AXObjectCache.cpp: (WebCore::createFromRenderer): * accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::addChildren): (WebCore::AccessibilityObject::addChild): (WebCore::AccessibilityObject::insertChild): (WebCore::AccessibilityObject::shouldIgnoreAttributeRole): (WebCore::AccessibilityObject::canHaveChildren): (WebCore::AccessibilityObject::hasChildren): * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): * accessibility/AccessibilityTree.cpp: Added. (WebCore::AccessibilityTree::AccessibilityTree): (WebCore::AccessibilityTree::~AccessibilityTree): (WebCore::AccessibilityTree::create): (WebCore::AccessibilityTree::computeAccessibilityIsIgnored): (WebCore::AccessibilityTree::determineAccessibilityRole): (WebCore::AccessibilityTree::isTreeValid): * accessibility/AccessibilityTree.h: Added. * accessibility/AccessibilityTreeItem.cpp: Added. (WebCore::AccessibilityTreeItem::AccessibilityTreeItem): (WebCore::AccessibilityTreeItem::~AccessibilityTreeItem): (WebCore::AccessibilityTreeItem::create): (WebCore::AccessibilityTreeItem::determineAccessibilityRole): * accessibility/AccessibilityTreeItem.h: Added. LayoutTests: * accessibility/aria-mappings.html: * accessibility/treeitem-child-exposed-expected.txt: * accessibility/treeitem-child-exposed.html: * platform/mac/accessibility/malformed-tree-expected.txt: Added. * platform/mac/accessibility/malformed-tree.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/accessibility/aria-mappings.html trunk/LayoutTests/accessibility/treeitem-child-exposed-expected.txt trunk/LayoutTests/accessibility/treeitem-child-exposed.html trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp Added Paths trunk/LayoutTests/platform/mac/accessibility/malformed-tree-expected.txt trunk/LayoutTests/platform/mac/accessibility/malformed-tree.html trunk/Source/WebCore/accessibility/AccessibilityTree.cpp trunk/Source/WebCore/accessibility/AccessibilityTree.h trunk/Source/WebCore/accessibility/AccessibilityTreeItem.cpp trunk/Source/WebCore/accessibility/AccessibilityTreeItem.h Diff Modified: trunk/LayoutTests/ChangeLog (187581 => 187582) --- trunk/LayoutTests/ChangeLog 2015-07-30 09:52:48 UTC (rev 187581) +++ trunk/LayoutTests/ChangeLog 2015-07-30 11:10:38 UTC (rev 187582) @@ -1,3 +1,17 @@ +2015-07-30 Nan Wang n_w...@apple.com + +AX: VoiceOver unable to access content in malformed trees +https://bugs.webkit.org/show_bug.cgi?id=147295 +rdar://problem/14862892 + +Reviewed by Chris Fleizach. + +* accessibility/aria-mappings.html: +* accessibility/treeitem-child-exposed-expected.txt: +* accessibility/treeitem-child-exposed.html: +* platform/mac/accessibility/malformed-tree-expected.txt: Added. +* platform/mac/accessibility/malformed-tree.html: Added. + 2015-07-30 Benjamin Poulain benja...@webkit.org Update JSC's standalone-pre.js for r187575 Modified: trunk/LayoutTests/accessibility/aria-mappings.html (187581 => 187582) --- trunk/LayoutTests/accessibility/aria-mappings.html 2015-07-30 09:52:48 UTC (rev 187581) +++ trunk/LayoutTests/accessibility/aria-mappings.html 2015-07-30 11:10:38 UTC (rev 187582) @@ -12,8 +12,8 @@ div id=document role=documentdocument role/div div id=status role=statusstatus role/div div id=tooltip role=tooltiptooltip role/div -div id=tree role=treetree role/div -div id=treeitem role=treeitemtreeitem role/div +div id=tree role=treediv role=treeitemtree role/div/div +div role=treediv id=treeitem role=treeitemtreeitem role/div/div br p id=description/p div id=console/div Modified: trunk/LayoutTests/accessibility/treeitem-child-exposed-expected.txt (187581 => 187582) --- trunk/LayoutTests/accessibility/treeitem-child-exposed-expected.txt 2015-07-30 09:52:48 UTC (rev 187581) +++
