[webkit-changes] [189671] trunk/LayoutTests

2015-09-13 Thread mmaxfield 
Title: [189671] trunk/LayoutTests








Revision 189671
Author mmaxfi...@apple.com
Date 2015-09-12 23:19:01 -0700 (Sat, 12 Sep 2015)


Log Message
Test fix after r189670.

Unreviewed.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (189670 => 189671)

--- trunk/LayoutTests/ChangeLog	2015-09-13 04:10:06 UTC (rev 189670)
+++ trunk/LayoutTests/ChangeLog	2015-09-13 06:19:01 UTC (rev 189671)
@@ -1,5 +1,13 @@
 2015-09-12  Myles C. Maxfield  
 
+Test fix after r189670.
+
+Unreviewed.
+
+* platform/mac/TestExpectations:
+
+2015-09-12  Myles C. Maxfield  
+
 [Cocoa] Add system-language-specific tests
 https://bugs.webkit.org/show_bug.cgi?id=148775
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (189670 => 189671)

--- trunk/LayoutTests/platform/mac/TestExpectations	2015-09-13 04:10:06 UTC (rev 189670)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-09-13 06:19:01 UTC (rev 189671)
@@ -1286,6 +1286,6 @@
 [ Mavericks Yosemite ] fast/canvas/webgl/match-page-color-space.html [ Skip ]
 
 # Mocking the system language relies on Bootstrap XPC messages, which are not supported in Mavericks.
-[ Mavericks ] fast/text/international/system-language [ Failure ]
+[ Mavericks ] fast/text/international/system-language [ Failure ImageOnlyFailure ]
 # Han quotes are not different on Mavericks nor Yosemite.
 [ Mavericks Yosemite ] fast/text/international/system-language/han-quotes.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189672] trunk/LayoutTests

2015-09-13 Thread mmaxfield 
Title: [189672] trunk/LayoutTests








Revision 189672
Author mmaxfi...@apple.com
Date 2015-09-12 23:46:30 -0700 (Sat, 12 Sep 2015)


Log Message
Another test fix after r189670.

Unreviewed.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (189671 => 189672)

--- trunk/LayoutTests/ChangeLog	2015-09-13 06:19:01 UTC (rev 189671)
+++ trunk/LayoutTests/ChangeLog	2015-09-13 06:46:30 UTC (rev 189672)
@@ -1,5 +1,13 @@
 2015-09-12  Myles C. Maxfield  
 
+Another test fix after r189670.
+
+Unreviewed.
+
+* platform/mac-wk1/TestExpectations:
+
+2015-09-12  Myles C. Maxfield  
+
 Test fix after r189670.
 
 Unreviewed.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (189671 => 189672)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-09-13 06:19:01 UTC (rev 189671)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-09-13 06:46:30 UTC (rev 189672)
@@ -143,4 +143,4 @@
 http/tests/contentfiltering/load-substitute-data-from-appcache.html
 
 # Testing the system language declaratively only makes sense in WK2, because it's implemented in WebKitTestRunner by launching a new WebContent process.
-fast/text/international/system-language [ Failure ]
+fast/text/international/system-language [ Failure ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189673] trunk/Source/WebCore/platform/gtk/po

2015-09-13 Thread mcatanzaro 
Title: [189673] trunk/Source/WebCore/platform/gtk/po








Revision 189673
Author mcatanz...@igalia.com
Date 2015-09-13 07:01:49 -0700 (Sun, 13 Sep 2015)


Log Message
Webkit Gujarati Translations
https://bugs.webkit.org/show_bug.cgi?id=139530

Unreviewed.

Patch by Ankit Patel  on 2015-09-13

* gu.po:

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/gu.po




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (189672 => 189673)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-13 06:46:30 UTC (rev 189672)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2015-09-13 14:01:49 UTC (rev 189673)
@@ -1,3 +1,12 @@
+2015-09-13  Ankit Patel  
+
+Webkit Gujarati Translations
+https://bugs.webkit.org/show_bug.cgi?id=139530
+
+Unreviewed.
+
+* gu.po:
+
 2015-09-12  Francisco Serrador  
 
 Updated Spanish translation


Modified: trunk/Source/WebCore/platform/gtk/po/gu.po (189672 => 189673)

--- trunk/Source/WebCore/platform/gtk/po/gu.po	2015-09-13 06:46:30 UTC (rev 189672)
+++ trunk/Source/WebCore/platform/gtk/po/gu.po	2015-09-13 14:01:49 UTC (rev 189673)
@@ -8,8 +8,8 @@
 msgstr ""
 "Project-Id-Version: webkit.gu\n"
 "Report-Msgid-Bugs-To: http://bugs.webkit.org\n"
-"POT-Creation-Date: 2014-08-28 22:55+\n"
-"PO-Revision-Date: 2014-09-04 15:13+0530\n"
+"POT-Creation-Date: 2014-10-25 10:53+\n"
+"PO-Revision-Date: 2014-12-11 10:49+0530\n"
 "Last-Translator: \n"
 "Language-Team: American English \n"
 "Language: \n"
@@ -125,12 +125,10 @@
 msgstr "નવી વિન્ડોમાં ઓડિયો ખોલો (_A)"
 
 #: ../LocalizedStringsGtk.cpp:145
-#| msgid "_Download Linked File"
 msgid "Download _Video"
 msgstr "વિડિઓને ડાઉનલોડ કરો (_V)"
 
 #: ../LocalizedStringsGtk.cpp:150
-#| msgid "_Download Linked File"
 msgid "Download _Audio"
 msgstr "ઓડિયોને ડાઉનલોડ કરો (_A)"
 
@@ -147,12 +145,10 @@
 msgstr "ટૉગલ મીડિયા નિયંત્રણ (_T)"
 
 #: ../LocalizedStringsGtk.cpp:170
-#| msgid "_Toggle Media Controls"
 msgid "_Show Media Controls"
 msgstr "મીડિયા નિયંત્રણને બતાવો (_S)"
 
 #: ../LocalizedStringsGtk.cpp:175
-#| msgid "_Toggle Media Controls"
 msgid "_Hide Media Controls"
 msgstr "મીડિયા નિયંત્રણને છુપાડો (_H)"
 
@@ -321,7 +317,6 @@
 msgstr "પદ"
 
 #: ../LocalizedStringsGtk.cpp:446
-#| msgid "definition"
 msgid "description"
 msgstr "વર્ણન"
 
@@ -389,12 +384,10 @@
 msgstr "જીવંત પ્રસારણ"
 
 #: ../LocalizedStringsGtk.cpp:568
-#| msgid "pause playback"
 msgid "audio playback"
 msgstr "ઓડિયો વગાડો"
 
 #: ../LocalizedStringsGtk.cpp:570
-#| msgid "begin playback"
 msgid "video playback"
 msgstr "વિડિયો વગાડો"
 
@@ -583,7 +576,6 @@
 msgstr "અસ્વીકારી TLS પ્રમાણપત્ર"
 
 #: ../LocalizedStringsGtk.cpp:791
-#| msgid "stop displaying closed captions"
 msgctxt "Closed Captions"
 msgid "Menu section heading for closed captions"
 msgstr "મેનુ વિભાગ બંધ કૅપ્શન માટે મથાળું"
@@ -594,8 +586,7 @@
 msgstr "ઉપશીર્ષકો"
 
 #: ../LocalizedStringsGtk.cpp:801
-msgctxt ""
-"Menu item label for the track that represents disabling closed captions"
+msgctxt "Menu item label for the track that represents disabling closed captions"
 msgid "Off"
 msgstr "બંધ"
 
@@ -609,73 +600,87 @@
 msgid "No label"
 msgstr "લેબલ નથી"
 
-#: ../LocalizedStringsGtk.cpp:817
+#: ../LocalizedStringsGtk.cpp:816
+#| msgctxt "Menu item label for a closed captions track that has no other name"
+#| msgid "No label"
+msgctxt "Menu item label for an audio track that has no other name"
+msgid "No label"
+msgstr "લેબલ નથી"
+
+#: ../LocalizedStringsGtk.cpp:822
 msgctxt "Snapshotted Plug-In"
 msgid "Title of the label to show on a snapshotted plug-in"
 msgstr "સ્નેપશોટ થયેલ પ્લગ-ઇન પર બતાવવા માટે લેબલનું શીર્ષક"
 
-#: ../LocalizedStringsGtk.cpp:822
+#: ../LocalizedStringsGtk.cpp:827
 msgctxt "Click to restart"
 msgid "Subtitle of the label to show on a snapshotted plug-in"
 msgstr "સ્નેપશોટ થયેલ પ્લગઇન પર બતાવવા માટે લેબલનું ઉપશીર્ષક"
 
-#: ../WebKitAuthenticationWidget.cpp:155
+#: ../../../../WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:99
 #, c-format
+msgid "Cannot determine destination URI for download with suggested filename %s"
+msgstr "સૂચિત ફાઇલનામ %s સાથે ડાઉનલોડ માટે લક્ષ્ય URI ને નક્કી કરી શકાતુ નથી"
+
+#. Prompt on the HTTP authentication dialog.
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:114
+#, c-format
 msgid "The site %s:%i requests a username and password"
 msgstr "સાઇટ %s:%i એ વપરાશકર્તાનામ અને પાસવર્ડની માંગણી કરે છે"
 
-#: ../WebKitAuthenticationWidget.cpp:159
-msgid "_Remember password"
-msgstr "પાસવર્ડ યાદ રાખો (_R)"
-
-#: ../WebKitAuthenticationWidget.cpp:167
+#: ../../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:122
 msgid "Server message:"
 msgstr "સર્વર સંદેશો:"
 
-#: ../WebKitAuthenticationWidget.cpp:168 ../WebKitAuthenticationWidget.cpp:177
+#. Check button on the HTTP authentication dialog.
+#:

[webkit-changes] [189674] trunk/Source/WebKit2

2015-09-13 Thread mitz 
Title: [189674] trunk/Source/WebKit2








Revision 189674
Author m...@apple.com
Date 2015-09-13 12:13:41 -0700 (Sun, 13 Sep 2015)


Log Message
Define HAVE_LINK_PREVIEW in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=149099

Reviewed by Sam Weinig.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/WKImagePreviewViewController.mm:
* config.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h
trunk/Source/WebKit2/UIProcess/WKImagePreviewViewController.mm
trunk/Source/WebKit2/config.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (189673 => 189674)

--- trunk/Source/WebKit2/ChangeLog	2015-09-13 14:01:49 UTC (rev 189673)
+++ trunk/Source/WebKit2/ChangeLog	2015-09-13 19:13:41 UTC (rev 189674)
@@ -1,3 +1,14 @@
+2015-09-13  Dan Bernstein  
+
+Define HAVE_LINK_PREVIEW in WebKit2
+https://bugs.webkit.org/show_bug.cgi?id=149099
+
+Reviewed by Sam Weinig.
+
+* Platform/spi/ios/UIKitSPI.h:
+* UIProcess/WKImagePreviewViewController.mm:
+* config.h:
+
 2015-09-12  Myles C. Maxfield  
 
 [Cocoa] Allow testing with the system language


Modified: trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h (189673 => 189674)

--- trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h	2015-09-13 14:01:49 UTC (rev 189673)
+++ trunk/Source/WebKit2/Platform/spi/ios/UIKitSPI.h	2015-09-13 19:13:41 UTC (rev 189674)
@@ -74,8 +74,6 @@
 #import 
 #import 
 
-#import 
-
 #if HAVE(LINK_PREVIEW)
 #import 
 #endif


Modified: trunk/Source/WebKit2/UIProcess/WKImagePreviewViewController.mm (189673 => 189674)

--- trunk/Source/WebKit2/UIProcess/WKImagePreviewViewController.mm	2015-09-13 14:01:49 UTC (rev 189673)
+++ trunk/Source/WebKit2/UIProcess/WKImagePreviewViewController.mm	2015-09-13 19:13:41 UTC (rev 189674)
@@ -30,9 +30,6 @@
 
 #import 
 #import 
-#if USE(APPLE_INTERNAL_SDK)
-#import 
-#endif
 #import <_WKElementAction.h>
 
 @implementation WKImagePreviewViewController {


Modified: trunk/Source/WebKit2/config.h (189673 => 189674)

--- trunk/Source/WebKit2/config.h	2015-09-13 14:01:49 UTC (rev 189673)
+++ trunk/Source/WebKit2/config.h	2015-09-13 19:13:41 UTC (rev 189674)
@@ -102,3 +102,11 @@
 #define HAVE_SAFARI_SERVICES_FRAMEWORK 0
 #endif
 #endif
+
+#ifndef HAVE_LINK_PREVIEW
+#if defined TARGET_OS_IOS && TARGET_OS_IOS
+#define HAVE_LINK_PREVIEW 1
+#else
+#define HAVE_LINK_PREVIEW 0
+#endif
+#endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [189676] trunk

2015-09-13 Thread cdumez 
Title: [189676] trunk








Revision 189676
Author cdu...@apple.com
Date 2015-09-13 19:42:06 -0700 (Sun, 13 Sep 2015)


Log Message
CharacterData API parameters should not be optional
https://bugs.webkit.org/show_bug.cgi?id=149101


Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C tests now that more checks are passing.

* web-platform-tests/dom/interfaces-expected.txt:
* web-platform-tests/dom/nodes/CharacterData-appendData-expected.txt:
* web-platform-tests/dom/nodes/CharacterData-substringData-expected.txt:

Source/WebCore:

CharacterData API parameters should not be optional as per the DOM
specification:
https://dom.spec.whatwg.org/#characterdata

The parameters are also mandatory in Firefox and Chrome. However,
those parameters are optional in WebKit. When DOMString parameters
were omitted, we would use the "undefined" string instead. When
unsigned long parameters were omitted, we would use 0 instead.
This patch aligns our behavior with the specification and other
major browsers.

No new tests, already covered by existing tests.

* dom/CharacterData.cpp:
(WebCore::CharacterData::appendData):
* dom/CharacterData.h:
* dom/CharacterData.idl:
* dom/Element.cpp:
(WebCore::Element::mergeWithNextTextNode):
* dom/Node.cpp:
(WebCore::Node::normalize):
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::exitText):

LayoutTests:

Update existing test to reflect our web-exposed behavior change.

* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt
trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/CharacterData-appendData-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/CharacterData-substringData-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/CharacterData.cpp
trunk/Source/WebCore/dom/CharacterData.h
trunk/Source/WebCore/dom/CharacterData.idl
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (189675 => 189676)

--- trunk/LayoutTests/ChangeLog	2015-09-14 02:36:37 UTC (rev 189675)
+++ trunk/LayoutTests/ChangeLog	2015-09-14 02:42:06 UTC (rev 189676)
@@ -1,3 +1,16 @@
+2015-09-13  Chris Dumez  
+
+CharacterData API parameters should not be optional
+https://bugs.webkit.org/show_bug.cgi?id=149101
+
+
+Reviewed by Sam Weinig.
+
+Update existing test to reflect our web-exposed behavior change.
+
+* fast/dom/non-numeric-values-numeric-parameters-expected.txt:
+* fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
+
 2015-09-12  Myles C. Maxfield  
 
 Another test fix after r189670.


Modified: trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt (189675 => 189676)

--- trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	2015-09-14 02:36:37 UTC (rev 189675)
+++ trunk/LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	2015-09-14 02:42:06 UTC (rev 189676)
@@ -4,10 +4,10 @@
 
 
 PASS nonNumericPolicy('document.createTextNode("a").substringData(x, 0)') is 'any type allowed'
-PASS nonNumericPolicy('document.createTextNode("a").substringData(0, x)') is 'any type allowed'
+PASS nonNumericPolicy('document.createTextNode("a").substringData(0, x)') is 'any type allowed (but not omitted)'
 PASS nonNumericPolicy('document.createTextNode("a").insertData(x, "b")') is 'any type allowed'
 PASS nonNumericPolicy('document.createTextNode("a").deleteData(x, 0)') is 'any type allowed'
-PASS nonNumericPolicy('document.createTextNode("a").deleteData(0, x)') is 'any type allowed'
+PASS nonNumericPolicy('document.createTextNode("a").deleteData(0, x)') is 'any type allowed (but not omitted)'
 PASS nonNumericPolicy('document.createTextNode("a").replaceData(x, 0, "b")') is 'any type allowed'
 PASS nonNumericPolicy('document.createTextNode("a").replaceData(0, x, "b")') is 'any type allowed'
 PASS nonNumericPolicy('createCSSMediaRule().insertRule(ruleText, x)') is 'any type allowed'


Modified: trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js (189675 => 189676)

--- trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	2015-09-14 02:36:37 UTC (rev 189675)
+++ trunk/LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	2015-09-14 02:42:06 UTC (rev 189676)
@@ -186,10 +186,10 @@
 // CharacterData
 
 shouldBe("nonNumericPolicy('document.createTextNode(\"a\").substringData(x, 0)')", "'any type

[webkit-changes] [189675] trunk/Source

2015-09-13 Thread gyuyoung . kim 
Title: [189675] trunk/Source








Revision 189675
Author gyuyoung@webkit.org
Date 2015-09-13 19:36:37 -0700 (Sun, 13 Sep 2015)


Log Message
Remove all uses of PassRefPtr in crypto, storage, and history
https://bugs.webkit.org/show_bug.cgi?id=149091

Reviewed by Andreas Kling.

Source/WebCore:

* crypto/CryptoKeyPair.cpp:
(WebCore::CryptoKeyPair::CryptoKeyPair):
* crypto/CryptoKeyPair.h:
(WebCore::CryptoKeyPair::create):
* crypto/SubtleCrypto.h:
(WebCore::SubtleCrypto::create):
* crypto/gnutls/CryptoKeyRSAGnuTLS.cpp:
(WebCore::CryptoKeyRSA::create):
* crypto/keys/CryptoKeyAES.cpp:
(WebCore::CryptoKeyAES::generate):
* crypto/keys/CryptoKeyAES.h:
* crypto/keys/CryptoKeyHMAC.cpp:
(WebCore::CryptoKeyHMAC::generate):
* crypto/keys/CryptoKeyHMAC.h:
* crypto/keys/CryptoKeyRSA.h:
* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::create):
* history/BackForwardController.cpp:
(WebCore::BackForwardController::BackForwardController):
* history/BackForwardController.h:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::setStateObject):
(WebCore::HistoryItem::setFormData):
* history/HistoryItem.h:
(WebCore::HistoryItem::stateObject):
* loader/EmptyClients.cpp:
* page/Page.cpp:
(WebCore::Page::Page):
* storage/Storage.cpp:
(WebCore::Storage::create):
(WebCore::Storage::Storage):
* storage/Storage.h:
* storage/StorageArea.h:
* storage/StorageMap.cpp:
(WebCore::StorageMap::copy):
(WebCore::StorageMap::setItem):
(WebCore::StorageMap::setItemIgnoringQuota):
(WebCore::StorageMap::removeItem):
* storage/StorageMap.h:
* storage/StorageNamespace.h:

Source/WebKit:

* Storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::storageArea):
* Storage/StorageNamespaceImpl.h:

Source/WebKit2:

* WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
* WebProcess/Storage/StorageNamespaceImpl.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/crypto/CryptoKeyPair.cpp
trunk/Source/WebCore/crypto/CryptoKeyPair.h
trunk/Source/WebCore/crypto/SubtleCrypto.h
trunk/Source/WebCore/crypto/gnutls/CryptoKeyRSAGnuTLS.cpp
trunk/Source/WebCore/crypto/keys/CryptoKeyAES.cpp
trunk/Source/WebCore/crypto/keys/CryptoKeyAES.h
trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.cpp
trunk/Source/WebCore/crypto/keys/CryptoKeyHMAC.h
trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.h
trunk/Source/WebCore/crypto/mac/CryptoKeyRSAMac.cpp
trunk/Source/WebCore/history/BackForwardController.cpp
trunk/Source/WebCore/history/BackForwardController.h
trunk/Source/WebCore/history/HistoryItem.cpp
trunk/Source/WebCore/history/HistoryItem.h
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/storage/Storage.cpp
trunk/Source/WebCore/storage/Storage.h
trunk/Source/WebCore/storage/StorageArea.h
trunk/Source/WebCore/storage/StorageMap.cpp
trunk/Source/WebCore/storage/StorageMap.h
trunk/Source/WebCore/storage/StorageNamespace.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Storage/StorageNamespaceImpl.cpp
trunk/Source/WebKit/Storage/StorageNamespaceImpl.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp
trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (189674 => 189675)

--- trunk/Source/WebCore/ChangeLog	2015-09-13 19:13:41 UTC (rev 189674)
+++ trunk/Source/WebCore/ChangeLog	2015-09-14 02:36:37 UTC (rev 189675)
@@ -1,3 +1,51 @@
+2015-09-13  Gyuyoung Kim  
+
+Remove all uses of PassRefPtr in crypto, storage, and history
+https://bugs.webkit.org/show_bug.cgi?id=149091
+
+Reviewed by Andreas Kling.
+
+* crypto/CryptoKeyPair.cpp:
+(WebCore::CryptoKeyPair::CryptoKeyPair):
+* crypto/CryptoKeyPair.h:
+(WebCore::CryptoKeyPair::create):
+* crypto/SubtleCrypto.h:
+(WebCore::SubtleCrypto::create):
+* crypto/gnutls/CryptoKeyRSAGnuTLS.cpp:
+(WebCore::CryptoKeyRSA::create):
+* crypto/keys/CryptoKeyAES.cpp:
+(WebCore::CryptoKeyAES::generate):
+* crypto/keys/CryptoKeyAES.h:
+* crypto/keys/CryptoKeyHMAC.cpp:
+(WebCore::CryptoKeyHMAC::generate):
+* crypto/keys/CryptoKeyHMAC.h:
+* crypto/keys/CryptoKeyRSA.h:
+* crypto/mac/CryptoKeyRSAMac.cpp:
+(WebCore::CryptoKeyRSA::create):
+* history/BackForwardController.cpp:
+(WebCore::BackForwardController::BackForwardController):
+* history/BackForwardController.h:
+* history/HistoryItem.cpp:
+(WebCore::HistoryItem::setStateObject):
+(WebCore::HistoryItem::setFormData):
+* history/HistoryItem.h:
+(WebCore::HistoryItem::stateObject):
+* loader/EmptyClients.cpp:
+* page/Page.cpp:
+(WebCore::Page::Page):
+* storage/Storage.cpp:
+(WebCore::Storage::create):
+(WebCore::Storage::Storage):
+* storage/Storage.h:
+*

[webkit-changes] [189680] trunk

2015-09-13 Thread cdumez 
Title: [189680] trunk








Revision 189680
Author cdu...@apple.com
Date 2015-09-13 22:03:29 -0700 (Sun, 13 Sep 2015)


Log Message
Document.title does not behave according to specification
https://bugs.webkit.org/show_bug.cgi?id=149098

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01-expected.txt:
* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02-expected.txt:

Source/WebCore:

Update Document.title to behave according to the latest DOM specification:
https://html.spec.whatwg.org/multipage/dom.html#document.title

In particular, the following Web-Exposed changes were made:
1. The title Element should be the first title element in the document
   (in tree order) [1]. Previously, WebKit would use the first title
   Element *added* to the Document. Document.title returns the text
   content of the title Element so this change is web-exposed.
2. If the title Element is replaced after the title has been set by the
   JS (via the document.title setter), we should update the value
   returned by the document.title getter. Previously, WebKit would set
   a flag if the title was explicitly set by JS via document.title
   setter and later title element changes would not override the title
   set by the JS. This behavior isn't specified and does not match the
   behavior of other browsers.

The new behavior is also consistent with the behavior of Firefox and
Chrome.

Some refactoring was made for the sake of clarity now that our
implementation has changed. See details below.

[1] https://html.spec.whatwg.org/multipage/dom.html#the-title-element-2

No new tests, already covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::updateTitleFromTitleElement):
New convenience method that calls updateTitle() with the text of the
document's current title Element. If there is no title Element, it
clears the title.

(WebCore::Document::updateTitleElement):
Method which updates the Document's title Element whenever a title
Element is added or removed from the Document. Once the title Element
is updated, it takes care of calling updateTitleFromTitleElement() to
update the Document's title.

(WebCore::Document::titleElementAdded):
(WebCore::Document::titleElementRemoved):
(WebCore::Document::titleElementTextChanged):
New Document public API called by HTMLTitleElement / SVGTitleElement
whenever a title Element is added / removed from the Document or
whenever the title element's text has changed. These methods will
take care of calling updateTitleElement() / updateTitleFromTitleElement()
as necessary.
Previously, we would only have 2 methods:
- setTitleElement() which would be called whenever a title Element was
  added to the document or when its text had changed. The name was
  confusing because it would not necessarily set the document's title
  Element and it would be used both for title element update and a
  simple title update. This method has been split into 2:
  titleElementAdded() and titleElementTextChanged().
- removeTitle() which would be called whenever a title Element was
  removed. The naming was confusing because it would not necessarily
  remove the Document's title Element. This is now called
  titleElementRemoved().

* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::insertedInto):
Call the new titleElementAdded() instead of setTitleElement().

(WebCore::HTMLTitleElement::removedFrom):
Call the new titleElementRemoved() instead of removeTitle().

(WebCore::HTMLTitleElement::childrenChanged):
Call the new titleElementTextChanged() instead of
setTitleElement() / removeTitle() as we don't really want
to remove or add a title Element. We merely want to notify
the document that the title element text has changed in
case it is the current title Element of the Document.

(WebCore::HTMLTitleElement::computedTextWithDirection):
Rename textWithDirection() to computedTextWithDirection() to
make it clear it is not a simple getter and make it private
as it is only used to set the m_title member which caches the
computed text.

* html/HTMLTitleElement.h:
Add new textWithDirection() getter which returns m_title. This
is needed so that Document can query the title of the Element.
Previously, HTMLTitleElement would pass directly m_title to
the Document when calling Document::setTitleElement().

* svg/SVGTitleElement.cpp:
(WebCore::SVGTitleElement::insertedInto):
Call the new titleElementAdded() instead of setTitleElement().

(WebCore::SVGTitleElement::removedFrom):
Call the new titleElementRemoved() instead of removeTitle().

(WebCore::SVGTitleElement::childrenChanged):
Call the new titleElementTextChanged() instead of
setTitleElement().

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01-expected.txt

[webkit-changes] [189682] trunk

2015-09-13 Thread cdumez 
Title: [189682] trunk








Revision 189682
Author cdu...@apple.com
Date 2015-09-13 22:08:39 -0700 (Sun, 13 Sep 2015)


Log Message
Improve Node pre-insertion validation when the parent is a Document
https://bugs.webkit.org/show_bug.cgi?id=149109


Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

* web-platform-tests/dom/nodes/Node-insertBefore-expected.txt:
* web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
* web-platform-tests/dom/nodes/append-on-Document-expected.txt:
* web-platform-tests/dom/nodes/prepend-on-Document-expected.txt:

Source/WebCore:

Improve Node pre-insertion validation when the parent is a Document to
match the specification:
https://dom.spec.whatwg.org/#concept-node-ensure-pre-insertion-validity
https://dom.spec.whatwg.org/#concept-node-replace

This affects the following API: Node.insertBefore(), Node.appendChild(),
Node.replaceChild().

WebKit current fails to do the following checks whenever the parent is a
Document from pre-insertion validation:
1. If the inserted Node is a DocumentFragment, we should make sure it
  contains only one Element.
-> This is because a Document can have only one child that is an
   Element [1].
2.a. If an Element is inserted, we should make sure it is not inserted
 before a DocumentType.
2.b. If a DocumentType is inserted, we should make sure it is not
 inserted after an Element.
-> This is because the DocType must come before the optional Element
   child [1].

Firefox and Chrome already match the specification here. This patch
aligns WebKit's behavior with those browsers and the specification.

[1] https://dom.spec.whatwg.org/#node-trees

No new tests, already covered by existing W3C tests.

* dom/ContainerNode.cpp:
(WebCore::checkAcceptChild):
(WebCore::checkAddChild):
(WebCore::checkReplaceChild):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::appendChild):
(WebCore::containsConsideringHostElements): Deleted.
(WebCore::checkAcceptChildGuaranteedNodeTypes): Deleted.
* dom/Document.cpp:
(WebCore::Document::canAcceptChild):
(WebCore::Document::cloneNodeInternal): Deleted.
* dom/Document.h:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-insertBefore-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-replaceChild-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/append-on-Document-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/prepend-on-Document-expected.txt
trunk/LayoutTests/userscripts/mixed-case-stylesheet.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189681 => 189682)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-14 05:06:40 UTC (rev 189681)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-14 05:08:39 UTC (rev 189682)
@@ -1,5 +1,20 @@
 2015-09-13  Chris Dumez  
 
+Improve Node pre-insertion validation when the parent is a Document
+https://bugs.webkit.org/show_bug.cgi?id=149109
+
+
+Reviewed by Ryosuke Niwa.
+
+Rebaseline several W3C tests now that more checks are passing.
+
+* web-platform-tests/dom/nodes/Node-insertBefore-expected.txt:
+* web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
+* web-platform-tests/dom/nodes/append-on-Document-expected.txt:
+* web-platform-tests/dom/nodes/prepend-on-Document-expected.txt:
+
+2015-09-13  Chris Dumez  
+
 Document.adoptNode() should be able to explicitly adopt a DocumentType node
 https://bugs.webkit.org/show_bug.cgi?id=149097
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-insertBefore-expected.txt (189681 => 189682)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-insertBefore-expected.txt	2015-09-14 05:06:40 UTC (rev 189681)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-insertBefore-expected.txt	2015-09-14 05:08:39 UTC (rev 189682)
@@ -11,33 +11,17 @@
 PASS Calling insertBefore with an inclusive ancestor of the context object must throw HIERARCHY_REQUEST_ERR. 
 PASS Calling insertBefore with a reference child whose parent is not the context node must throw a NotFoundError. 
 PASS If the context node is a document, inserting a document or text node should throw a HierarchyRequestError. 
-FAIL If the context node is a document, appending a DocumentFragment that contains a text node or too many elements should throw a HierarchyRequestError. assert_throws: function "function () {
-doc.insertBefore(df, null);
-  }" did not throw
-FAIL If the context node is a document, inserting a DocumentFragment that contains a text node or too many elements should

[webkit-changes] [189678] trunk/LayoutTests

2015-09-13 Thread gyuyoung . kim 
Title: [189678] trunk/LayoutTests








Revision 189678
Author gyuyoung@webkit.org
Date 2015-09-13 20:07:48 -0700 (Sun, 13 Sep 2015)


Log Message
Unreviewed EFL gardening.

Mark fast/text/international/system-language/system-font-punctuation.html to *Missing* since r188377.
Additionally some tests have been passed since r188693. Removed the tests in TestExpectation.

* platform/efl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (189677 => 189678)

--- trunk/LayoutTests/ChangeLog	2015-09-14 03:04:47 UTC (rev 189677)
+++ trunk/LayoutTests/ChangeLog	2015-09-14 03:07:48 UTC (rev 189678)
@@ -1,3 +1,12 @@
+2015-09-13  Gyuyoung Kim  
+
+Unreviewed EFL gardening.
+
+Mark fast/text/international/system-language/system-font-punctuation.html to *Missing* since r188377.
+Additionally some tests have been passed since r188693. Removed the tests in TestExpectation.
+
+* platform/efl/TestExpectations:
+
 2015-09-13  Chris Dumez  
 
 Node.baseURI should not return null for detached nodes


Modified: trunk/LayoutTests/platform/efl/TestExpectations (189677 => 189678)

--- trunk/LayoutTests/platform/efl/TestExpectations	2015-09-14 03:04:47 UTC (rev 189677)
+++ trunk/LayoutTests/platform/efl/TestExpectations	2015-09-14 03:07:48 UTC (rev 189678)
@@ -405,9 +405,6 @@
 # CSS image-resolution is not yet enabled.
 webkit.org/b/85262 fast/css/image-resolution
 
-# Some CSS properties not supported on EFL
-fast/css/will-change/will-change-creates-stacking-context.html [ ImageOnlyFailure ]
-
 # Perf tests are really slow in debug builds and there are few benefits in running them.
 [ Debug ] perf [ WontFix ]
 
@@ -720,7 +717,6 @@
 webkit.org/b/131729 http/tests/globalhistory/history-delegate-basic-title.html [ Failure ]
 webkit.org/b/131729 http/tests/globalhistory/history-delegate-pushstate.html [ Failure ]
 webkit.org/b/131729 http/tests/globalhistory/history-delegate-replacestate.html [ Failure ]
-webkit.org/b/131729 http/tests/loading/sizes/preload-image-sizes-2x.html [ Failure ]
 webkit.org/b/131729 http/tests/misc/acid3.html [ Failure Pass ]
 webkit.org/b/131729 http/tests/misc/image-blocked-src-change.html [ Failure Pass ]
 webkit.org/b/131729 http/tests/misc/slow-loading-image-in-pattern.html [ Failure ]
@@ -1461,9 +1457,6 @@
 webkit.org/b/85463 editing/inserting/smart-link-when-caret-is-moved-before-URL.html
 editing/inserting/smart-quote-with-all-configurations.html
 
-# Tests failing due to rounding problems in colors inside pixman
-webkit.org/b/49964 fast/canvas/canvas-fillPath-shadow.html [ Failure ]
-
 # Failing after r119268 on GTK and EFL
 webkit.org/b/88138 http/tests/media/video-buffered.html [ Failure ]
 
@@ -1565,8 +1558,6 @@
 Bug(EFL) fast/dynamic/layer-hit-test-crash.html [ Failure ]
 Bug(EFL) fast/layers/layer-visibility-sublayer.html [ Failure ]
 Bug(EFL) fast/layers/layer-visibility.html [ Failure ]
-Bug(EFL) fast/repaint/invisible-objects.html [ Failure ]
-Bug(EFL) fast/repaint/layer-hide-when-needs-layout.html [ Failure ]
 Bug(EFL) fast/text/whitespace/019.html [ Failure ]
 Bug(EFL) fast/text/whitespace/023.html [ Failure ]
 Bug(EFL) fast/text/whitespace/028.html [ Failure ]
@@ -1688,7 +1679,6 @@
 # Border-fit should happen at layout time rather than paint time
 webkit.org/b/111606 fast/borders/border-fit-2.html [ Failure ]
 webkit.org/b/111606 fast/borders/border-fit.html [ Failure ]
-webkit.org/b/111606 fast/repaint/border-fit-lines.html [ Failure ]
 
 # Started failing on EFL afrer r145025.
 webkit.org/b/111860 fast/forms/number/number-validation-message.html [ Failure ]
@@ -2026,7 +2016,6 @@
 webkit.org/b/133974 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-svg.html [ ImageOnlyFailure Pass ]
 
 webkit.org/b/134756 fast/dom/HTMLImageElement/sizes/image-sizes-2x.html [ Failure ]
-webkit.org/b/134756 fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html [ Failure ]
 
 webkit.org/b/135504 svg/css/parse-height.html [ Failure ]
 webkit.org/b/135504 svg/css/parse-length.html [ Failure ]
@@ -2066,7 +2055,6 @@
 webkit.org/b/136406 compositing/contents-scale/simple-scale.html [ Failure ]
 webkit.org/b/136406 compositing/contents-scale/z-translate.html [ Failure ]
 webkit.org/b/136406 compositing/fixed-image-loading.html [ Failure ]
-webkit.org/b/136406 compositing/geometry/ancestor-overflow-change.html [ Failure ]
 webkit.org/b/136406 compositing/images/direct-image-object-fit.html [ Failure ]
 webkit.org/b/136406 compositing/layer-creation/fixed-position-change-out-of-view-in-view.html [ Failure ]
 webkit.org/b/136406 compositing/layer-creation/overlap-animation-container.html [ Failure ]
@@ -2179,7 +2167,6 @@
 webkit.org/b/131044 media/media-controls-invalid-url.html [ Failure ]
 webkit.org/b/131044 media/media-controls-timeline-updates.html [ Failure ]
 webkit.org/b/131044

[webkit-changes] [189677] trunk

2015-09-13 Thread cdumez 
Title: [189677] trunk








Revision 189677
Author cdu...@apple.com
Date 2015-09-13 20:04:47 -0700 (Sun, 13 Sep 2015)


Log Message
Node.baseURI should not return null for detached nodes
https://bugs.webkit.org/show_bug.cgi?id=149104


Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/dom/nodes/Node-baseURI-expected.txt:

Source/WebCore:

Node.baseURI should not return null for detached nodes. It should return
the node document's base URL. The node document is set when the node is
created so it is valid even if the node is detached [1]:
https://dom.spec.whatwg.org/#dom-node-baseuri

WebKit was traversing the ancestors to find the base URL, which only
works if the node is attached. Also, WebKit was taking into account
the xml:base attribute when computing the baseURI.

Both Chrome and Firefox already dropped support for xml:base:
https://code.google.com/p/chromium/issues/detail?id=341854
https://bugzilla.mozilla.org/show_bug.cgi?id=903372

Firefox complies with the specification. Chrome's baseURI still only
works for attached Nodes as their implementation still traverses the
DOM tree, despite dropping support for xml:base.

This patch drops support xml:base when computing Node.baseURI, as
Firefox, Chrome and the latest DOM specification do. It also makes
Node.baseURI work for detached Nodes by returning the base URL of the
node Document. This means we no longer have to traverse the Node's
ancestors in the DOM tree. This is consistent with the behavior of
Firefox and the latest DOM specification.

This patch does not drop the SVGElement.xmlbase attribute yet. However,
we should probably consider making this change as well given that:
- The SVG2 specification dropped it
- Chrome dropped it.
- It no longers impacts Node.baseURI

[1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=20976

No new tests, already covered by existing test.

* dom/Document.cpp:
(WebCore::Document::setContent): Deleted.
* dom/Document.h:
(WebCore::Document::inputCursor): Deleted.
* dom/DocumentType.cpp:
(WebCore::DocumentType::nodeName): Deleted.
* dom/DocumentType.h:
* dom/Element.cpp:
(WebCore::Element::imageSourceURL): Deleted.
(WebCore::Element::rendererIsNeeded): Deleted.
(WebCore::Element::createElementRenderer): Deleted.
(WebCore::Element::insertedInto): Deleted.
* dom/Element.h:
* dom/Node.cpp:
(WebCore::Node::baseURI):
* dom/Node.h:
* svg/SVGElement.idl:

LayoutTests:

* dom/xhtml/level3/core/nodegetbaseuri03-expected.txt:
Rebaseline outdated DOM3 test.

* svg/custom/image-base-uri-expected.txt: Removed.
* svg/custom/image-base-uri.svg: Removed.
Drop outdated SVG test. SVG2 no longer support xml:base.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03-expected.txt
trunk/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03.js
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-baseURI-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/DocumentType.cpp
trunk/Source/WebCore/dom/DocumentType.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/svg/SVGElement.idl


Removed Paths

trunk/LayoutTests/svg/custom/image-base-uri-expected.txt
trunk/LayoutTests/svg/custom/image-base-uri.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (189676 => 189677)

--- trunk/LayoutTests/ChangeLog	2015-09-14 02:42:06 UTC (rev 189676)
+++ trunk/LayoutTests/ChangeLog	2015-09-14 03:04:47 UTC (rev 189677)
@@ -1,5 +1,20 @@
 2015-09-13  Chris Dumez  
 
+Node.baseURI should not return null for detached nodes
+https://bugs.webkit.org/show_bug.cgi?id=149104
+
+
+Reviewed by Sam Weinig.
+
+* dom/xhtml/level3/core/nodegetbaseuri03-expected.txt:
+Rebaseline outdated DOM3 test.
+
+* svg/custom/image-base-uri-expected.txt: Removed.
+* svg/custom/image-base-uri.svg: Removed.
+Drop outdated SVG test. SVG2 no longer support xml:base.
+
+2015-09-13  Chris Dumez  
+
 CharacterData API parameters should not be optional
 https://bugs.webkit.org/show_bug.cgi?id=149101
 


Modified: trunk/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03-expected.txt (189676 => 189677)

--- trunk/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03-expected.txt	2015-09-14 02:42:06 UTC (rev 189676)
+++ trunk/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03-expected.txt	2015-09-14 03:04:47 UTC (rev 189677)
@@ -1,2 +1,3 @@
 Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/nodegetbaseuri03
-Status	Success
+Status	failure
+Message	nodegetbaseuri03: assertTrue failed


Modified: trunk/LayoutTests/dom/xhtml/level3/core/nodegetbaseuri03.js (189676 => 189677)

---

[webkit-changes] [189681] trunk

2015-09-13 Thread cdumez 
Title: [189681] trunk








Revision 189681
Author cdu...@apple.com
Date 2015-09-13 22:06:40 -0700 (Sun, 13 Sep 2015)


Log Message
Document.adoptNode() should be able to explicitly adopt a DocumentType node
https://bugs.webkit.org/show_bug.cgi?id=149097
LayoutTests/imported/w3c:



Reviewed by Ryosuke Niwa.

Rebaseline W3C test now that a new check is passing.

* web-platform-tests/dom/nodes/Document-adoptNode-expected.txt:

Source/WebCore:



Reviewed by Ryosuke Niwa.

Document.adoptNode() should be able to explicitly adopt a DocumentType
node as per the latest DOM specification:
https://dom.spec.whatwg.org/#dom-document-adoptnode

Chrome and Firefox match the specidicaiton but WebKit was throwing a
NotSupportedError.

No new tests, already covered by existing test.

* dom/Document.cpp:
(WebCore::Document::adoptNode): Deleted.

LayoutTests:

Reviewed by Ryosuke Niwa.

Rebaseline DOM3 tests, those seem to be outdated now.

* dom/xhtml/level3/core/documentadoptnode10-expected.txt:
* dom/xhtml/level3/core/documentadoptnode11-expected.txt:
* dom/xhtml/level3/core/documentadoptnode12-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode10-expected.txt
trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode11-expected.txt
trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode12-expected.txt
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-adoptNode-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (189680 => 189681)

--- trunk/LayoutTests/ChangeLog	2015-09-14 05:03:29 UTC (rev 189680)
+++ trunk/LayoutTests/ChangeLog	2015-09-14 05:06:40 UTC (rev 189681)
@@ -1,5 +1,18 @@
 2015-09-13  Chris Dumez  
 
+Document.adoptNode() should be able to explicitly adopt a DocumentType node
+https://bugs.webkit.org/show_bug.cgi?id=149097
+
+Reviewed by Ryosuke Niwa.
+
+Rebaseline DOM3 tests, those seem to be outdated now.
+
+* dom/xhtml/level3/core/documentadoptnode10-expected.txt:
+* dom/xhtml/level3/core/documentadoptnode11-expected.txt:
+* dom/xhtml/level3/core/documentadoptnode12-expected.txt:
+
+2015-09-13  Chris Dumez  
+
 document.lastModified should use the user's local time zone
 https://bugs.webkit.org/show_bug.cgi?id=149092
 


Modified: trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode10-expected.txt (189680 => 189681)

--- trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode10-expected.txt	2015-09-14 05:03:29 UTC (rev 189680)
+++ trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode10-expected.txt	2015-09-14 05:06:40 UTC (rev 189681)
@@ -1,2 +1,3 @@
 Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/documentadoptnode10
-Status	Success
+Status	failure
+Message	throw_NOT_SUPPORTED_ERR: assertTrue failed


Modified: trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode11-expected.txt (189680 => 189681)

--- trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode11-expected.txt	2015-09-14 05:03:29 UTC (rev 189680)
+++ trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode11-expected.txt	2015-09-14 05:06:40 UTC (rev 189681)
@@ -1,2 +1,3 @@
 Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/documentadoptnode11
-Status	Success
+Status	failure
+Message	throw_NOT_SUPPORTED_ERR: assertTrue failed


Modified: trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode12-expected.txt (189680 => 189681)

--- trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode12-expected.txt	2015-09-14 05:03:29 UTC (rev 189680)
+++ trunk/LayoutTests/dom/xhtml/level3/core/documentadoptnode12-expected.txt	2015-09-14 05:06:40 UTC (rev 189681)
@@ -1,2 +1,3 @@
 Test	http://www.w3.org/2001/DOM-Test-Suite/level3/core/documentadoptnode12
-Status	Success
+Status	failure
+Message	throw_NOT_SUPPORTED_ERR: assertTrue failed


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189680 => 189681)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-14 05:03:29 UTC (rev 189680)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-14 05:06:40 UTC (rev 189681)
@@ -1,5 +1,17 @@
 2015-09-13  Chris Dumez  
 
+Document.adoptNode() should be able to explicitly adopt a DocumentType node
+https://bugs.webkit.org/show_bug.cgi?id=149097
+
+
+Reviewed by Ryosuke Niwa.
+
+Rebaseline W3C test now that a new check is passing. 
+
+* web-platform-tests/dom/nodes/Document-adoptNode-expected.txt:
+
+2015-09-13  Chris Dumez  
+
 Document.title does not behave according to specification
 https://bugs.webkit.org/show_bug.cgi?id=149098
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-adoptNode-expected.txt (189680 => 189681)

---

[webkit-changes] [189679] trunk

2015-09-13 Thread cdumez 
Title: [189679] trunk








Revision 189679
Author cdu...@apple.com
Date 2015-09-13 21:18:18 -0700 (Sun, 13 Sep 2015)


Log Message
document.lastModified should use the user's local time zone
https://bugs.webkit.org/show_bug.cgi?id=149092
LayoutTests/imported/w3c:



Reviewed by Ryosuke Niwa.

Rebaseline a couple of W3C tests now that more checks are passing.

* web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-01-expected.txt:
* web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-expected.txt:

Source/WebCore:



Reviewed by Ryosuke Niwa.

document.lastModified should use the user's local time zone:
https://html.spec.whatwg.org/multipage/dom.html#dom-document-lastmodified

Chrome and Firefox comply with the specification but WebKit was using
UTC. This patch aligns WebKit's behavior with the specification and
other browsers.

No new tests, already covered by existing tests.

* dom/Document.cpp:
(WebCore::Document::lastModified):
(WebCore::Document::setCookieURL): Deleted.

LayoutTests:

Reviewed by Ryosuke Niwa.

Update test so that it converts document.lastModified to UTF before
printing it. This is so that we can consistent layout tests results, no
matter the system's timezone.

* http/tests/misc/last-modified-parsing-expected.txt:
* http/tests/resources/last-modified.php:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt
trunk/LayoutTests/http/tests/resources/last-modified.php
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-01-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (189678 => 189679)

--- trunk/LayoutTests/ChangeLog	2015-09-14 03:07:48 UTC (rev 189678)
+++ trunk/LayoutTests/ChangeLog	2015-09-14 04:18:18 UTC (rev 189679)
@@ -1,3 +1,17 @@
+2015-09-13  Chris Dumez  
+
+document.lastModified should use the user's local time zone
+https://bugs.webkit.org/show_bug.cgi?id=149092
+
+Reviewed by Ryosuke Niwa.
+
+Update test so that it converts document.lastModified to UTF before
+printing it. This is so that we can consistent layout tests results, no
+matter the system's timezone.
+
+* http/tests/misc/last-modified-parsing-expected.txt:
+* http/tests/resources/last-modified.php:
+
 2015-09-13  Gyuyoung Kim  
 
 Unreviewed EFL gardening.


Modified: trunk/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt (189678 => 189679)

--- trunk/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt	2015-09-14 03:07:48 UTC (rev 189678)
+++ trunk/LayoutTests/http/tests/misc/last-modified-parsing-expected.txt	2015-09-14 04:18:18 UTC (rev 189679)
@@ -3,34 +3,34 @@
 
 Frame: '-->'
 
-11/21/2008 01:03:33
+Fri, 21 Nov 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-11/21/2008 01:03:33
+Fri, 21 Nov 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-11/21/1997 01:03:33
+Fri, 21 Nov 1997 01:03:33 GMT
 
 
 Frame: '-->'
 
-11/21/2008 01:03:33
+Fri, 21 Nov 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-02/21/2008 01:03:33
+Thu, 21 Feb 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-02/03/2008 01:03:33
+Sun, 03 Feb 2008 01:03:33 GMT
 
 
 Frame: '-->'
 
-03/03/2008 01:03:33
+Mon, 03 Mar 2008 01:03:33 GMT


Modified: trunk/LayoutTests/http/tests/resources/last-modified.php (189678 => 189679)

--- trunk/LayoutTests/http/tests/resources/last-modified.php	2015-09-14 03:07:48 UTC (rev 189678)
+++ trunk/LayoutTests/http/tests/resources/last-modified.php	2015-09-14 04:18:18 UTC (rev 189679)
@@ -3,5 +3,5 @@
 header("Last-Modified: $date");
 ?>
 
-document.write(document.lastModified);
+document.write((new Date(document.lastModified)).toUTCString());
 


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (189678 => 189679)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-14 03:07:48 UTC (rev 189678)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2015-09-14 04:18:18 UTC (rev 189679)
@@ -1,5 +1,18 @@
 2015-09-13  Chris Dumez  
 
+document.lastModified should use the user's local time zone
+https://bugs.webkit.org/show_bug.cgi?id=149092
+
+
+Reviewed by Ryosuke Niwa.
+
+Rebaseline a couple of W3C tests now that more checks are passing.
+
+* web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-01-expected.txt:
+* web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-expected.txt: