date:20151222

[webkit-changes] [194369] trunk/Source

2015-12-22 Thread keith_miller

Title: [194369] trunk/Source








Revision 194369
Author keith_mil...@apple.com
Date 2015-12-22 12:04:56 -0800 (Tue, 22 Dec 2015)


Log Message
Remove OverridesHasInstance from TypeInfoFlags
https://bugs.webkit.org/show_bug.cgi?id=152005

Reviewed by Saam Barati.

Currently, we have three TypeInfo flags associated with instanceof behavior,
ImplementsHasInstance, ImplementDefaultHasInstance, and OverridesHasInstance. This patch
removes the third and moves the first to the out of line flags. In theory, we should only
need one flag but removing ImplementsHasInstance is more involved and should be done in a
separate patch.

Source/_javascript_Core:

* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_overrides_has_instance):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_overrides_has_instance):
* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
* llint/LowLevelInterpreter.asm:
* runtime/InternalFunction.h:
* runtime/JSBoundFunction.h:
* runtime/JSCallee.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::implementsHasInstance):
(JSC::TypeInfo::TypeInfo): Deleted.
(JSC::TypeInfo::overridesHasInstance): Deleted.
* runtime/NumberConstructor.h:

Source/WebCore:

* bindings/js/JSDOMBinding.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):

Modified Paths

trunk/Source/_javascript_Core/API/JSCallbackConstructor.h
trunk/Source/_javascript_Core/API/JSCallbackObject.h
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/JITOpcodes.cpp
trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp
trunk/Source/_javascript_Core/llint/LLIntData.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/runtime/InternalFunction.h
trunk/Source/_javascript_Core/runtime/JSBoundFunction.h
trunk/Source/_javascript_Core/runtime/JSCallee.h
trunk/Source/_javascript_Core/runtime/JSTypeInfo.h
trunk/Source/_javascript_Core/runtime/NumberConstructor.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm




Diff

Modified: trunk/Source/_javascript_Core/API/JSCallbackConstructor.h (194368 => 194369)

--- trunk/Source/_javascript_Core/API/JSCallbackConstructor.h	2015-12-22 20:03:13 UTC (rev 194368)
+++ trunk/Source/_javascript_Core/API/JSCallbackConstructor.h	2015-12-22 20:04:56 UTC (rev 194369)
@@ -34,7 +34,7 @@
 class JSCallbackConstructor : public JSDestructibleObject {
 public:
 typedef JSDestructibleObject Base;
-static const unsigned StructureFlags = Base::StructureFlags | ImplementsHasInstance;
+static const unsigned StructureFlags = Base::StructureFlags | ImplementsHasInstance | ImplementsDefaultHasInstance;
 
 static JSCallbackConstructor* create(ExecState* exec, JSGlobalObject* globalObject, Structure* structure, JSClassRef classRef, JSObjectCallAsConstructorCallback callback) 
 {


Modified: trunk/Source/_javascript_Core/API/JSCallbackObject.h (194368 => 194369)

--- trunk/Source/_javascript_Core/API/JSCallbackObject.h	2015-12-22 20:03:13 UTC (rev 194368)
+++ trunk/Source/_javascript_Core/API/JSCallbackObject.h	2015-12-22 20:04:56 UTC (rev 194369)
@@ -127,7 +127,7 @@
 
 public:
 typedef Parent Base;
-static const unsigned StructureFlags = Base::StructureFlags | ProhibitsPropertyCaching | OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | ImplementsHasInstance | OverridesHasInstanceFlag | OverridesGetPropertyNames | TypeOfShouldCallGetCallData;
+static const unsigned StructureFlags = Base::StructureFlags | ProhibitsPropertyCaching | OverridesGetOwnPropertySlot | InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero | ImplementsHasInstance | OverridesGetPropertyNames | TypeOfShouldCallGetCallData;
 
 ~JSCallbackObject();
 


Modified: trunk/Source/_javascript_Core/ChangeLog (194368 => 194369)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-22 20:03:13 UTC (rev 194368)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-22 20:04:56 UTC (rev 194369)
@@ -1,3 +1,34 @@
+2015-12-22  Keith Miller  
+
+Remove OverridesHasInstance from TypeInfoFlags
+https://bugs.webkit.org/show_bug.cgi?id=152005
+
+Reviewed by Saam Barati.
+
+Currently, we have three TypeInfo flags associated with instanceof behavior,
+ImplementsHasInstance, ImplementDefaultHasInstance, and OverridesHasInstance. This patch
+removes the third and moves the first to the out of line flags. In theory, we should only
+need one flag but removing ImplementsHasInstance is more involved and should be done in a
+separate patch.
+
+* API/JSCallbackConstructor.h:
+* API/JSCallbackObject.h:
+* jit/JITOpcodes.cpp:
+(JSC::JIT::emit_op_overrides_has_instance):
+* jit/JITOpcodes32_64.cpp:
+(JSC::JIT::emit_op_overrides_has_instance):
+* llint/LLIntData.cpp:
+

[webkit-changes] [194370] trunk/Source/WebCore

2015-12-22 Thread commit-queue

Title: [194370] trunk/Source/WebCore








Revision 194370
Author commit-qu...@webkit.org
Date 2015-12-22 12:37:33 -0800 (Tue, 22 Dec 2015)


Log Message
Unreviewed, rolling out r194362.
https://bugs.webkit.org/show_bug.cgi?id=152508

crashes release bot (Requested by mcatanzaro on #webkit).

Reverted changeset:

"[GTK] Everything broken in GTK+ 3.19"
https://bugs.webkit.org/show_bug.cgi?id=150550
http://trac.webkit.org/changeset/194362

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp
trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h
trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194369 => 194370)

--- trunk/Source/WebCore/ChangeLog	2015-12-22 20:04:56 UTC (rev 194369)
+++ trunk/Source/WebCore/ChangeLog	2015-12-22 20:37:33 UTC (rev 194370)
@@ -1,3 +1,16 @@
+2015-12-22  Commit Queue  
+
+Unreviewed, rolling out r194362.
+https://bugs.webkit.org/show_bug.cgi?id=152508
+
+crashes release bot (Requested by mcatanzaro on #webkit).
+
+Reverted changeset:
+
+"[GTK] Everything broken in GTK+ 3.19"
+https://bugs.webkit.org/show_bug.cgi?id=150550
+http://trac.webkit.org/changeset/194362
+
 2015-12-22  Keith Miller  
 
 Remove OverridesHasInstance from TypeInfoFlags


Modified: trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp (194369 => 194370)

--- trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp	2015-12-22 20:04:56 UTC (rev 194369)
+++ trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp	2015-12-22 20:37:33 UTC (rev 194370)
@@ -72,22 +72,6 @@
 if (ptr)
 gdk_cursor_unref(ptr);
 }
-
-#else
-
-template <> GtkWidgetPath* refGPtr(GtkWidgetPath* ptr)
-{
-if (ptr)
-gtk_widget_path_ref(ptr);
-return ptr;
-}
-
-template <> void derefGPtr(GtkWidgetPath* ptr)
-{
-if (ptr)
-gtk_widget_path_unref(ptr);
-}
-
 #endif
 
 }


Modified: trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h (194369 => 194370)

--- trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h	2015-12-22 20:04:56 UTC (rev 194369)
+++ trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h	2015-12-22 20:37:33 UTC (rev 194370)
@@ -23,7 +23,6 @@
 
 #include 
 
-typedef struct _GtkWidgetPath GtkWidgetPath;
 typedef struct _SecretValue SecretValue;
 
 namespace WTF {
@@ -39,9 +38,6 @@
 #ifdef GTK_API_VERSION_2
 template <> GdkCursor* refGPtr(GdkCursor* ptr);
 template <> void derefGPtr(GdkCursor* ptr);
-#else
-template <> GtkWidgetPath* refGPtr(GtkWidgetPath* ptr);
-template <> void derefGPtr(GtkWidgetPath* ptr);
 #endif
 
 }


Modified: trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp (194369 => 194370)

--- trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp	2015-12-22 20:04:56 UTC (rev 194369)
+++ trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp	2015-12-22 20:37:33 UTC (rev 194370)
@@ -163,12 +163,6 @@
 }
 
 #ifndef GTK_API_VERSION_2
-
-#if !GTK_CHECK_VERSION(3, 19, 2)
-// Currently we use a static GtkStyleContext for GTK+ < 3.19, and a bunch of unique
-// GtkStyleContexts for GTK+ >= 3.19. This is crazy and definitely should not be necessary, but I
-// couldn't find any other way to not break one version or the other. Ideally one of the two
-// people on the planet who really understand GTK+ styles would fix this.
 class ScrollbarStyleContext {
 WTF_MAKE_NONCOPYABLE(ScrollbarStyleContext); WTF_MAKE_FAST_ALLOCATED;
 public:
@@ -197,7 +191,6 @@
 static NeverDestroyed styleContext;
 return styleContext.get().context();
 }
-#endif
 
 ScrollbarThemeGtk::ScrollbarThemeGtk()
 {
@@ -206,28 +199,14 @@
 
 void ScrollbarThemeGtk::themeChanged()
 {
-#if !GTK_CHECK_VERSION(3, 19, 2)
 gtk_style_context_invalidate(gtkScrollbarStyleContext());
-#endif
 updateThemeProperties();
 }
 
 void ScrollbarThemeGtk::updateThemeProperties()
 {
-#if GTK_CHECK_VERSION(3, 19, 2)
-GRefPtr styleContext = adoptGRef(gtk_style_context_new());
-GRefPtr path = adoptGRef(gtk_widget_path_new());
-
-gtk_widget_path_append_type(path.get(), GTK_TYPE_SCROLLBAR);
-gtk_widget_path_iter_set_object_name(path.get(), 0, "scrollbar");
-
-gtk_style_context_set_path(styleContext.get(), path.get());
-#else
-GRefPtr styleContext = gtkScrollbarStyleContext();
-#endif
-
 gtk_style_context_get_style(
-styleContext.get(),
+gtkScrollbarStyleContext(),
 "min-slider-length", _minThumbLength,
 "slider-width", _thumbFatness,
 "trough-border", _troughBorderWidth,
@@ -293,19 +272,11 @@
 return IntRect(trackRect.x() + (trackRect.width() - m_thumbFatness) / 2, trackRect.y() + thumbPos, m_thumbFatness, thumbLength(scrollbar));
 }
 
-
-static const char* orientationStyleClass(ScrollbarOrientation orientation)
-{
-return orientation == VerticalScrollbar ? "vertical" : "horizontal";
-}
-
-#if !GTK_CHECK_VERSION(3, 19, 2)
 static void

[webkit-changes] [194368] trunk/Source/JavaScriptCore

2015-12-22 Thread fpizlo

Title: [194368] trunk/Source/_javascript_Core








Revision 194368
Author fpi...@apple.com
Date 2015-12-22 12:03:13 -0800 (Tue, 22 Dec 2015)


Log Message
FTL B3 should do tail calls
https://bugs.webkit.org/show_bug.cgi?id=152494

Reviewed by Michael Saboff.

OMG this was so easy.

The only shady part is that I broke a layering rule that we had so far been following: B3 was
sitting below the JSC runtime, and did not use JS-specific types. No more, since B3::ValueRep
can now turn itself into a ValueRecovery for a JSValue. This small feature makes a huge
difference for the readability of tail call code: it makes it plain that the call frame
shuffler is basically just directly consuming the stackmap generation params, and insofar as
there is any data transformation, it's just because it uses different classes to say the same
thing.

I think we should avoid adding too many JS-specific things to B3. But, so long as it's still
possible to use B3 to compile things that aren't JS, I think we'll be fine.

* b3/B3ValueRep.cpp:
(JSC::B3::ValueRep::dump):
(JSC::B3::ValueRep::emitRestore):
(JSC::B3::ValueRep::recoveryForJSValue):
* b3/B3ValueRep.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileTailCall):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
* test/stress/ftl-tail-call.js: Added.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3ValueRep.cpp
trunk/Source/_javascript_Core/b3/B3ValueRep.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp


Added Paths

trunk/Source/_javascript_Core/tests/stress/ftl-tail-call.js




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194367 => 194368)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-22 19:37:50 UTC (rev 194367)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-22 20:03:13 UTC (rev 194368)
@@ -1,3 +1,33 @@
+2015-12-22  Filip Pizlo  
+
+FTL B3 should do tail calls
+https://bugs.webkit.org/show_bug.cgi?id=152494
+
+Reviewed by Michael Saboff.
+
+OMG this was so easy.
+
+The only shady part is that I broke a layering rule that we had so far been following: B3 was
+sitting below the JSC runtime, and did not use JS-specific types. No more, since B3::ValueRep
+can now turn itself into a ValueRecovery for a JSValue. This small feature makes a huge
+difference for the readability of tail call code: it makes it plain that the call frame
+shuffler is basically just directly consuming the stackmap generation params, and insofar as
+there is any data transformation, it's just because it uses different classes to say the same
+thing.
+
+I think we should avoid adding too many JS-specific things to B3. But, so long as it's still
+possible to use B3 to compile things that aren't JS, I think we'll be fine.
+
+* b3/B3ValueRep.cpp:
+(JSC::B3::ValueRep::dump):
+(JSC::B3::ValueRep::emitRestore):
+(JSC::B3::ValueRep::recoveryForJSValue):
+* b3/B3ValueRep.h:
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::compileTailCall):
+(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
+* test/stress/ftl-tail-call.js: Added.
+
 2015-12-21  Mark Lam  
 
 Snippefy op_negate for the baseline JIT.


Modified: trunk/Source/_javascript_Core/b3/B3ValueRep.cpp (194367 => 194368)

--- trunk/Source/_javascript_Core/b3/B3ValueRep.cpp	2015-12-22 19:37:50 UTC (rev 194367)
+++ trunk/Source/_javascript_Core/b3/B3ValueRep.cpp	2015-12-22 20:03:13 UTC (rev 194368)
@@ -29,6 +29,7 @@
 #if ENABLE(B3_JIT)
 
 #include "AssemblyHelpers.h"
+#include "JSCInlines.h"
 
 namespace JSC { namespace B3 {
 
@@ -57,7 +58,7 @@
 RELEASE_ASSERT_NOT_REACHED();
 }
 
-void ValueRep::emitRestore(AssemblyHelpers& jit, Reg reg)
+void ValueRep::emitRestore(AssemblyHelpers& jit, Reg reg) const
 {
 if (reg.isGPR()) {
 switch (kind()) {
@@ -100,6 +101,24 @@
 }
 }
 
+ValueRecovery ValueRep::recoveryForJSValue() const
+{
+switch (kind()) {
+case Register:
+return ValueRecovery::inGPR(gpr(), DataFormatJS);
+case Stack:
+RELEASE_ASSERT(!(offsetFromFP() % sizeof(EncodedJSValue)));
+return ValueRecovery::displacedInJSStack(
+VirtualRegister(offsetFromFP() / sizeof(EncodedJSValue)),
+DataFormatJS);
+case Constant:
+return ValueRecovery::constant(JSValue::decode(value()));
+default:
+RELEASE_ASSERT_NOT_REACHED();
+return { };
+}
+}
+
 } } // namespace JSC::B3
 
 namespace WTF {


Modified: trunk/Source/_javascript_Core/b3/B3ValueRep.h (194367 => 194368)

--- trunk/Source/_javascript_Core/b3/B3ValueRep.h	2015-12-22 19:37:50 UTC (rev 194367)
+++ trunk/Source/_javascript_Core/b3/B3ValueRep.h	2015-12-22 20:03:13 UTC (rev 194368)
@@ -32,6 +32,7 @@
 #include "GPRInfo.h"
 #include "JSCJSValue.h"

[webkit-changes] [194366] trunk/LayoutTests

2015-12-22 Thread calvaris

Title: [194366] trunk/LayoutTests








Revision 194366
Author calva...@igalia.com
Date 2015-12-22 10:20:49 -0800 (Tue, 22 Dec 2015)


Log Message
[Streams API] Fix cosmetic things after importing spec tests
https://bugs.webkit.org/show_bug.cgi?id=152479

Reviewed by Youenn Fablet.

Spec version are mainly updated in this patch as it wasn't done when importing tests from the spec. Some other
minor changes were done, as renumbering some tests, removing some orphan expectations and other styling issues.

* streams/brand-checks.html:
* streams/pipe-to.html:
* streams/readable-stream-controller-error.html:
* streams/readable-stream-pipeThrough.html:
* streams/readable-stream-reader-read.html:
* streams/reference-implementation/abstract-ops.html:
* streams/reference-implementation/bad-strategies.html:
* streams/reference-implementation/bad-underlying-sinks.html:
* streams/reference-implementation/bad-underlying-sources-expected.txt: Removed.
* streams/reference-implementation/brand-checks.html:
* streams/reference-implementation/byte-length-queuing-strategy.html:
* streams/reference-implementation/count-queuing-strategy.html:
* streams/reference-implementation/pipe-through.html:
* streams/reference-implementation/pipe-to-options.html:
* streams/reference-implementation/pipe-to.html:
* streams/reference-implementation/readable-stream-templated.html:
* streams/reference-implementation/transform-stream-errors.html:
* streams/reference-implementation/transform-stream.html:
* streams/reference-implementation/writable-stream-abort.html:
* streams/reference-implementation/writable-stream-expected.txt:
* streams/reference-implementation/writable-stream.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/streams/brand-checks.html
trunk/LayoutTests/streams/pipe-to.html
trunk/LayoutTests/streams/readable-stream-controller-error.html
trunk/LayoutTests/streams/readable-stream-pipeThrough.html
trunk/LayoutTests/streams/readable-stream-reader-read.html
trunk/LayoutTests/streams/reference-implementation/abstract-ops.html
trunk/LayoutTests/streams/reference-implementation/bad-strategies.html
trunk/LayoutTests/streams/reference-implementation/bad-underlying-sinks.html
trunk/LayoutTests/streams/reference-implementation/brand-checks.html
trunk/LayoutTests/streams/reference-implementation/byte-length-queuing-strategy.html
trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy.html
trunk/LayoutTests/streams/reference-implementation/pipe-through.html
trunk/LayoutTests/streams/reference-implementation/pipe-to-options.html
trunk/LayoutTests/streams/reference-implementation/pipe-to.html
trunk/LayoutTests/streams/reference-implementation/readable-stream-templated.html
trunk/LayoutTests/streams/reference-implementation/transform-stream-errors.html
trunk/LayoutTests/streams/reference-implementation/transform-stream.html
trunk/LayoutTests/streams/reference-implementation/writable-stream-abort.html
trunk/LayoutTests/streams/reference-implementation/writable-stream-expected.txt
trunk/LayoutTests/streams/reference-implementation/writable-stream.html


Removed Paths

trunk/LayoutTests/streams/reference-implementation/bad-underlying-sources-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (194365 => 194366)

--- trunk/LayoutTests/ChangeLog	2015-12-22 18:15:02 UTC (rev 194365)
+++ trunk/LayoutTests/ChangeLog	2015-12-22 18:20:49 UTC (rev 194366)
@@ -1,3 +1,35 @@
+2015-12-22  Xabier Rodriguez Calvar  
+
+[Streams API] Fix cosmetic things after importing spec tests
+https://bugs.webkit.org/show_bug.cgi?id=152479
+
+Reviewed by Youenn Fablet.
+
+Spec version are mainly updated in this patch as it wasn't done when importing tests from the spec. Some other
+minor changes were done, as renumbering some tests, removing some orphan expectations and other styling issues.
+
+* streams/brand-checks.html:
+* streams/pipe-to.html:
+* streams/readable-stream-controller-error.html:
+* streams/readable-stream-pipeThrough.html:
+* streams/readable-stream-reader-read.html:
+* streams/reference-implementation/abstract-ops.html:
+* streams/reference-implementation/bad-strategies.html:
+* streams/reference-implementation/bad-underlying-sinks.html:
+* streams/reference-implementation/bad-underlying-sources-expected.txt: Removed.
+* streams/reference-implementation/brand-checks.html:
+* streams/reference-implementation/byte-length-queuing-strategy.html:
+* streams/reference-implementation/count-queuing-strategy.html:
+* streams/reference-implementation/pipe-through.html:
+* streams/reference-implementation/pipe-to-options.html:
+* streams/reference-implementation/pipe-to.html:
+* streams/reference-implementation/readable-stream-templated.html:
+* streams/reference-implementation/transform-stream-errors.html:
+*

[webkit-changes] [194375] tags/Safari-601.1.46.89/

2015-12-22 Thread bshafiei

Title: [194375] tags/Safari-601.1.46.89/








Revision 194375
Author bshaf...@apple.com
Date 2015-12-22 14:52:42 -0800 (Tue, 22 Dec 2015)


Log Message
New tag.

Added Paths

tags/Safari-601.1.46.89/




Diff

Property changes: tags/Safari-601.1.46.89



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194383] trunk/Source/JavaScriptCore

2015-12-22 Thread fpizlo

Title: [194383] trunk/Source/_javascript_Core








Revision 194383
Author fpi...@apple.com
Date 2015-12-22 18:33:48 -0800 (Tue, 22 Dec 2015)


Log Message
FTL B3 should use the right type for comparison slow paths
https://bugs.webkit.org/show_bug.cgi?id=152521

Reviewed by Saam Barati.

Fixes a small goof that was leading to B3 validation failures.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::nonSpeculativeCompare):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194382 => 194383)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-23 01:50:19 UTC (rev 194382)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-23 02:33:48 UTC (rev 194383)
@@ -1,5 +1,17 @@
 2015-12-22  Filip Pizlo  
 
+FTL B3 should use the right type for comparison slow paths
+https://bugs.webkit.org/show_bug.cgi?id=152521
+
+Reviewed by Saam Barati.
+
+Fixes a small goof that was leading to B3 validation failures.
+
+* ftl/FTLLowerDFGToLLVM.cpp:
+(JSC::FTL::DFG::LowerDFGToLLVM::nonSpeculativeCompare):
+
+2015-12-22  Filip Pizlo  
+
 FTL B3 should be able to run richards
 https://bugs.webkit.org/show_bug.cgi?id=152514
 


Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (194382 => 194383)

--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-12-23 01:50:19 UTC (rev 194382)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2015-12-23 02:33:48 UTC (rev 194383)
@@ -7367,7 +7367,7 @@
 
 m_out.appendTo(slowPath, continuation);
 ValueFromBlock slowResult = m_out.anchor(m_out.notNull(vmCall(
-m_out.boolean, m_out.operation(helperFunction), m_callFrame, left, right)));
+m_out.intPtr, m_out.operation(helperFunction), m_callFrame, left, right)));
 m_out.jump(continuation);
 
 m_out.appendTo(continuation, lastNext);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194379] branches/safari-601.1.46-branch/Source

2015-12-22 Thread bshafiei

Title: [194379] branches/safari-601.1.46-branch/Source








Revision 194379
Author bshaf...@apple.com
Date 2015-12-22 16:23:00 -0800 (Tue, 22 Dec 2015)


Log Message
Versioning.

Modified Paths

branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (194378 => 194379)

--- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-12-22 23:52:00 UTC (rev 194378)
+++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2015-12-23 00:23:00 UTC (rev 194379)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 89;
+MICRO_VERSION = 90;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (194378 => 194379)

--- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2015-12-22 23:52:00 UTC (rev 194378)
+++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig	2015-12-23 00:23:00 UTC (rev 194379)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 89;
+MICRO_VERSION = 90;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (194378 => 194379)

--- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-12-22 23:52:00 UTC (rev 194378)
+++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2015-12-23 00:23:00 UTC (rev 194379)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 89;
+MICRO_VERSION = 90;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (194378 => 194379)

--- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-12-22 23:52:00 UTC (rev 194378)
+++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2015-12-23 00:23:00 UTC (rev 194379)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 89;
+MICRO_VERSION = 90;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (194378 => 194379)

--- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-12-22 23:52:00 UTC (rev 194378)
+++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig	2015-12-23 00:23:00 UTC (rev 194379)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 601;
 MINOR_VERSION = 1;
 TINY_VERSION = 46;
-MICRO_VERSION = 89;
+MICRO_VERSION = 90;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194380] trunk/Source/WebCore

2015-12-22 Thread aestes

Title: [194380] trunk/Source/WebCore








Revision 194380
Author aes...@apple.com
Date 2015-12-22 16:34:35 -0800 (Tue, 22 Dec 2015)


Log Message
Try to fix the iOS build after r194378

* platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194379 => 194380)

--- trunk/Source/WebCore/ChangeLog	2015-12-23 00:23:00 UTC (rev 194379)
+++ trunk/Source/WebCore/ChangeLog	2015-12-23 00:34:35 UTC (rev 194380)
@@ -1,5 +1,11 @@
 2015-12-22  Andy Estes  
 
+Try to fix the iOS build after r194378
+
+* platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
+
+2015-12-22  Andy Estes  
+
 [CF] Replace CFNetwork-related WebKitSystemInterface calls with SPI
 https://bugs.webkit.org/show_bug.cgi?id=152463
 


Modified: trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp (194379 => 194380)

--- trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp	2015-12-23 00:23:00 UTC (rev 194379)
+++ trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp	2015-12-23 00:34:35 UTC (rev 194380)
@@ -36,6 +36,7 @@
 #include "ResourceHandleClient.h"
 #include "ResourceResponse.h"
 #include "SharedBuffer.h"
+#include "WebCoreSystemInterface.h"
 #include "WebCoreURLResponse.h"
 #include 
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194382] trunk/Source

2015-12-22 Thread fpizlo

Title: [194382] trunk/Source








Revision 194382
Author fpi...@apple.com
Date 2015-12-22 17:50:19 -0800 (Tue, 22 Dec 2015)


Log Message
FTL B3 should be able to run richards
https://bugs.webkit.org/show_bug.cgi?id=152514

Reviewed by Michael Saboff.

Source/_javascript_Core:

This came down to a liveness bug and a register allocation bug.

The liveness bug was that the code that determined whether we should go around the fixpoint
assumed that BitVector::quickSet() would return true if the bit changed state from false to
true. That's not how it works. It returns the old value of the bit, so it will return false
if the bit changed from false to true. Since there is already a lot of code that relies on
this behavior, I fixed Liveness instead of changing BitVector.

The register allocation bug was that we weren't guarding some checks of tmp()'s with checks
that the Arg isTmp().

The liveness took a long time to track down, and I needed to add a lot of dumping to do it.
It's now possible to dump more of the liveness states, including liveAtHead. I found this
extremely helpful, so I removed the code that cleared liveAtHead.

* b3/air/AirIteratedRegisterCoalescing.cpp:
* b3/air/AirLiveness.h:
(JSC::B3::Air::AbstractLiveness::AbstractLiveness):
(JSC::B3::Air::AbstractLiveness::Iterable::Iterable):
(JSC::B3::Air::AbstractLiveness::Iterable::iterator::iterator):
(JSC::B3::Air::AbstractLiveness::Iterable::iterator::operator*):
(JSC::B3::Air::AbstractLiveness::Iterable::iterator::operator++):
(JSC::B3::Air::AbstractLiveness::Iterable::iterator::operator==):
(JSC::B3::Air::AbstractLiveness::Iterable::iterator::operator!=):
(JSC::B3::Air::AbstractLiveness::Iterable::begin):
(JSC::B3::Air::AbstractLiveness::Iterable::end):
(JSC::B3::Air::AbstractLiveness::liveAtHead):
(JSC::B3::Air::AbstractLiveness::liveAtTail):
* b3/air/AirStackSlot.h:
(WTF::printInternal):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):

Source/WTF:

Change the list dumping helpers to work with a broader set of list kinds.

* wtf/ListDump.h:
(WTF::ListDump::dump):
(WTF::MapDump::dump):
(WTF::sortedMapDump):
(WTF::ListDumpInContext::dump):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp
trunk/Source/_javascript_Core/b3/air/AirLiveness.h
trunk/Source/_javascript_Core/b3/air/AirStackSlot.h
trunk/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ListDump.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194381 => 194382)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-23 01:36:03 UTC (rev 194381)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-23 01:50:19 UTC (rev 194382)
@@ -1,3 +1,43 @@
+2015-12-22  Filip Pizlo  
+
+FTL B3 should be able to run richards
+https://bugs.webkit.org/show_bug.cgi?id=152514
+
+Reviewed by Michael Saboff.
+
+This came down to a liveness bug and a register allocation bug.
+
+The liveness bug was that the code that determined whether we should go around the fixpoint
+assumed that BitVector::quickSet() would return true if the bit changed state from false to
+true. That's not how it works. It returns the old value of the bit, so it will return false
+if the bit changed from false to true. Since there is already a lot of code that relies on
+this behavior, I fixed Liveness instead of changing BitVector.
+
+The register allocation bug was that we weren't guarding some checks of tmp()'s with checks
+that the Arg isTmp().
+
+The liveness took a long time to track down, and I needed to add a lot of dumping to do it.
+It's now possible to dump more of the liveness states, including liveAtHead. I found this
+extremely helpful, so I removed the code that cleared liveAtHead.
+
+* b3/air/AirIteratedRegisterCoalescing.cpp:
+* b3/air/AirLiveness.h:
+(JSC::B3::Air::AbstractLiveness::AbstractLiveness):
+(JSC::B3::Air::AbstractLiveness::Iterable::Iterable):
+(JSC::B3::Air::AbstractLiveness::Iterable::iterator::iterator):
+(JSC::B3::Air::AbstractLiveness::Iterable::iterator::operator*):
+(JSC::B3::Air::AbstractLiveness::Iterable::iterator::operator++):
+(JSC::B3::Air::AbstractLiveness::Iterable::iterator::operator==):
+(JSC::B3::Air::AbstractLiveness::Iterable::iterator::operator!=):
+(JSC::B3::Air::AbstractLiveness::Iterable::begin):
+(JSC::B3::Air::AbstractLiveness::Iterable::end):
+(JSC::B3::Air::AbstractLiveness::liveAtHead):
+(JSC::B3::Air::AbstractLiveness::liveAtTail):
+* b3/air/AirStackSlot.h:
+(WTF::printInternal):
+* ftl/FTLOSRExitCompiler.cpp:
+(JSC::FTL::compileFTLOSRExit):
+
 2015-12-22  Saam barati  
 
 Cloop build fix after https://bugs.webkit.org/show_bug.cgi?id=152511.

[webkit-changes] [194385] trunk/Source/JavaScriptCore

2015-12-22 Thread fpizlo

Title: [194385] trunk/Source/_javascript_Core








Revision 194385
Author fpi...@apple.com
Date 2015-12-22 19:22:47 -0800 (Tue, 22 Dec 2015)


Log Message
REGRESSION(194382): FTL B3 no longer runs V8/encrypt
https://bugs.webkit.org/show_bug.cgi?id=152519

Reviewed by Saam Barati.

A "Move Imm, Tmp" instruction should turn into "Move32 Imm, Tmp" if the Tmp is spilled to a
32-bit slot. Changing where we check isTmp() achieves this. Since all of the logic is only
relevant to when we spill without introducing a Tmp, and since a Move does not have a "Move Addr,
Addr" form, this code ensures that the logic only happens for "Tmp, Tmp" and "Imm, Tmp".

* b3/air/AirIteratedRegisterCoalescing.cpp:
* dfg/DFGOperations.cpp:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194384 => 194385)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-23 02:54:39 UTC (rev 194384)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-23 03:22:47 UTC (rev 194385)
@@ -1,5 +1,20 @@
 2015-12-22  Filip Pizlo  
 
+REGRESSION(194382): FTL B3 no longer runs V8/encrypt
+https://bugs.webkit.org/show_bug.cgi?id=152519
+
+Reviewed by Saam Barati.
+
+A "Move Imm, Tmp" instruction should turn into "Move32 Imm, Tmp" if the Tmp is spilled to a
+32-bit slot. Changing where we check isTmp() achieves this. Since all of the logic is only
+relevant to when we spill without introducing a Tmp, and since a Move does not have a "Move Addr,
+Addr" form, this code ensures that the logic only happens for "Tmp, Tmp" and "Imm, Tmp".
+
+* b3/air/AirIteratedRegisterCoalescing.cpp:
+* dfg/DFGOperations.cpp:
+
+2015-12-22  Filip Pizlo  
+
 FTL B3 should use the right type for comparison slow paths
 https://bugs.webkit.org/show_bug.cgi?id=152521
 


Modified: trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp (194384 => 194385)

--- trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp	2015-12-23 02:54:39 UTC (rev 194384)
+++ trunk/Source/_javascript_Core/b3/air/AirIteratedRegisterCoalescing.cpp	2015-12-23 03:22:47 UTC (rev 194385)
@@ -1190,10 +1190,9 @@
 // Move is the canonical way to move data between GPRs.
 bool forceMove32IfDidSpill = false;
 bool didSpill = false;
-if (type == Arg::GP && inst.opcode == Move
-&& inst.args[0].isTmp() && inst.args[1].isTmp()) {
-if (m_tmpWidth.defWidth(inst.args[0].tmp()) <= Arg::Width32
-|| m_tmpWidth.useWidth(inst.args[1].tmp()) <= Arg::Width32)
+if (type == Arg::GP && inst.opcode == Move) {
+if ((inst.args[0].isTmp() && m_tmpWidth.defWidth(inst.args[0].tmp()) <= Arg::Width32)
+|| (inst.args[1].isTmp() && m_tmpWidth.useWidth(inst.args[1].tmp()) <= Arg::Width32))
 forceMove32IfDidSpill = true;
 }
 


Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (194384 => 194385)

--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2015-12-23 02:54:39 UTC (rev 194384)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp	2015-12-23 03:22:47 UTC (rev 194385)
@@ -1252,8 +1252,6 @@
 VM& vm = exec->vm();
 NativeCallFrameTracer tracer(, exec);
 
-dataLog("Ran the barrier.\n");
-
 return bitwise_cast(jsCast(cell)->butterfly());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194373] trunk/Source/JavaScriptCore

2015-12-22 Thread sbarati

Title: [194373] trunk/Source/_javascript_Core








Revision 194373
Author sbar...@apple.com
Date 2015-12-22 14:19:31 -0800 (Tue, 22 Dec 2015)


Log Message
Work around issue in bug #152510
https://bugs.webkit.org/show_bug.cgi?id=152511

Reviewed by Filip Pizlo.

* runtime/Options.cpp:
(JSC::recomputeDependentOptions):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194372 => 194373)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-22 21:59:59 UTC (rev 194372)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-22 22:19:31 UTC (rev 194373)
@@ -1,3 +1,13 @@
+2015-12-22  Saam barati  
+
+Work around issue in bug #152510
+https://bugs.webkit.org/show_bug.cgi?id=152511
+
+Reviewed by Filip Pizlo.
+
+* runtime/Options.cpp:
+(JSC::recomputeDependentOptions):
+
 2015-12-22  Filip Pizlo  
 
 FTL B3 does not logicalNot correctly


Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (194372 => 194373)

--- trunk/Source/_javascript_Core/runtime/Options.cpp	2015-12-22 21:59:59 UTC (rev 194372)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2015-12-22 22:19:31 UTC (rev 194373)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "Options.h"
 
+#include "CCallHelpers.h"
 #include 
 #include 
 #include 
@@ -316,6 +317,16 @@
 Options::useOSREntryToFTL() = false;
 }
 
+if (isARM64()) {
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=152510
+// We're running into a bug where some ARM64 tests are failing in the FTL
+// with what appears to be an llvm bug where llvm is miscalculating the
+// live-out variables of a patchpoint. This causes us to not keep a 
+// volatile register alive across a C call in a patchpoint, even though 
+// that register is used immediately after the patchpoint.
+Options::assumeAllRegsInFTLICAreLive() = true;
+}
+
 // Compute the maximum value of the reoptimization retry counter. This is simply
 // the largest value at which we don't overflow the execute counter, when using it
 // to left-shift the execution counter by this amount. Currently the value ends






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194374] trunk/Tools

2015-12-22 Thread bfulgham

Title: [194374] trunk/Tools








Revision 194374
Author bfulg...@apple.com
Date 2015-12-22 14:48:31 -0800 (Tue, 22 Dec 2015)


Log Message
Unreviewed: Add John Wilander as a contributor.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (194373 => 194374)

--- trunk/Tools/ChangeLog	2015-12-22 22:19:31 UTC (rev 194373)
+++ trunk/Tools/ChangeLog	2015-12-22 22:48:31 UTC (rev 194374)
@@ -1,3 +1,9 @@
+2015-12-22  Brent Fulgham  
+
+Unreviewed: Add John Wilander as a contributor.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2015-12-22  Chris Fleizach  
 
 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (194373 => 194374)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-12-22 22:19:31 UTC (rev 194373)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-12-22 22:48:31 UTC (rev 194374)
@@ -1502,6 +1502,14 @@
 "jknotten"
  ]
   },
+  "John Wilander" : {
+ "emails" : [
+"wilan...@apple.com"
+ ],
+ "nicks" : [
+"johnwilander"
+ ]
+  },
   "Johnny Ding" : {
  "emails" : [
 "j...@chromium.org",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194377] trunk/Source/WebCore

2015-12-22 Thread mcatanzaro

Title: [194377] trunk/Source/WebCore








Revision 194377
Author mcatanz...@igalia.com
Date 2015-12-22 15:15:25 -0800 (Tue, 22 Dec 2015)


Log Message
[GTK] Everything broken in GTK+ 3.19
https://bugs.webkit.org/show_bug.cgi?id=150550

Reviewed by Carlos Garcia Campos.

Port RenderThemeGtk and ScrollbarThemeGtk to use CSS nodes. This makes it possible to render
stuff with modern GTK+.

No new tests. We already have tons of tests for this functionality, but we're running them
with GTK+ 3.16, so they cannot have detected this breakage. These fixes require unreleased
GTK+, and GTK+ rendering is currently in a state of flux; once things settle down, we can
consider upgrading the GTK+ used for our layout tests.

* platform/gtk/GRefPtrGtk.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
* platform/gtk/GRefPtrGtk.h:
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::themeChanged):
(WebCore::ScrollbarThemeGtk::updateThemeProperties):
(WebCore::orientationStyleClass):
(WebCore::applyScrollbarStyleContextClasses):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
* rendering/RenderThemeGtk.cpp:
(WebCore::createStyleContext):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::applySliderStyleContextClasses):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::paintSpinArrowButton):
(WebCore::styleColor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp
trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h
trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194376 => 194377)

--- trunk/Source/WebCore/ChangeLog	2015-12-22 23:12:43 UTC (rev 194376)
+++ trunk/Source/WebCore/ChangeLog	2015-12-22 23:15:25 UTC (rev 194377)
@@ -1,3 +1,46 @@
+2015-12-22  Michael Catanzaro  
+
+[GTK] Everything broken in GTK+ 3.19
+https://bugs.webkit.org/show_bug.cgi?id=150550
+
+Reviewed by Carlos Garcia Campos.
+
+Port RenderThemeGtk and ScrollbarThemeGtk to use CSS nodes. This makes it possible to render
+stuff with modern GTK+.
+
+No new tests. We already have tons of tests for this functionality, but we're running them
+with GTK+ 3.16, so they cannot have detected this breakage. These fixes require unreleased
+GTK+, and GTK+ rendering is currently in a state of flux; once things settle down, we can
+consider upgrading the GTK+ used for our layout tests.
+
+* platform/gtk/GRefPtrGtk.cpp:
+(WTF::refGPtr):
+(WTF::derefGPtr):
+* platform/gtk/GRefPtrGtk.h:
+* platform/gtk/ScrollbarThemeGtk.cpp:
+(WebCore::ScrollbarThemeGtk::themeChanged):
+(WebCore::ScrollbarThemeGtk::updateThemeProperties):
+(WebCore::orientationStyleClass):
+(WebCore::applyScrollbarStyleContextClasses):
+(WebCore::ScrollbarThemeGtk::paintTrackBackground):
+(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
+(WebCore::ScrollbarThemeGtk::paintThumb):
+(WebCore::ScrollbarThemeGtk::paintButton):
+* rendering/RenderThemeGtk.cpp:
+(WebCore::createStyleContext):
+(WebCore::setToggleSize):
+(WebCore::paintToggle):
+(WebCore::RenderThemeGtk::paintButton):
+(WebCore::getComboBoxMetrics):
+(WebCore::RenderThemeGtk::paintMenuList):
+(WebCore::RenderThemeGtk::paintTextField):
+(WebCore::applySliderStyleContextClasses):
+(WebCore::RenderThemeGtk::paintSliderTrack):
+(WebCore::RenderThemeGtk::paintSliderThumb):
+(WebCore::RenderThemeGtk::paintProgressBar):
+(WebCore::paintSpinArrowButton):
+(WebCore::styleColor):
+
 2015-12-22  Eric Carlson  
 
 [MediaStream] MediaStreamTrackPrivate.source should be a reference


Modified: trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp (194376 => 194377)

--- trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp	2015-12-22 23:12:43 UTC (rev 194376)
+++ trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp	2015-12-22 23:15:25 UTC (rev 194377)
@@ -72,6 +72,22 @@
 if (ptr)
 gdk_cursor_unref(ptr);
 }
+
+#else
+
+template <> GtkWidgetPath* refGPtr(GtkWidgetPath* ptr)
+{
+if (ptr)
+gtk_widget_path_ref(ptr);
+return ptr;
+}
+
+template <> void derefGPtr(GtkWidgetPath* ptr)
+{
+if (ptr)
+gtk_widget_path_unref(ptr);
+}
+
 #endif
 
 }


Modified: trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h (194376 => 194377)

---

[webkit-changes] [194371] trunk/Source/WebCore

2015-12-22 Thread eric . carlson

Title: [194371] trunk/Source/WebCore








Revision 194371
Author eric.carl...@apple.com
Date 2015-12-22 13:45:49 -0800 (Tue, 22 Dec 2015)


Log Message
[MediaStream] MediaStreamTrackPrivate.source should be a reference
https://bugs.webkit.org/show_bug.cgi?id=152509

Reviewed by Tim Horton.

No new tests, no functional change.

* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::trackVectorForType):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/mediastream/RTCDTMFSender.cpp:
(WebCore::RTCDTMFSender::create):
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
* platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::platformLayer):
(WebCore::MediaStreamPrivate::currentFrameImage):
* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
* platform/mediastream/MediaStreamTrackPrivate.h:
(WebCore::MediaStreamTrackPrivate::source):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (194370 => 194371)

--- trunk/Source/WebCore/ChangeLog	2015-12-22 20:37:33 UTC (rev 194370)
+++ trunk/Source/WebCore/ChangeLog	2015-12-22 21:45:49 UTC (rev 194371)
@@ -1,3 +1,27 @@
+2015-12-22  Eric Carlson  
+
+[MediaStream] MediaStreamTrackPrivate.source should be a reference
+https://bugs.webkit.org/show_bug.cgi?id=152509
+
+Reviewed by Tim Horton.
+
+No new tests, no functional change.
+
+* Modules/mediastream/MediaStream.cpp:
+(WebCore::MediaStream::trackVectorForType):
+* Modules/mediastream/MediaStreamTrack.h:
+* Modules/mediastream/RTCDTMFSender.cpp:
+(WebCore::RTCDTMFSender::create):
+* Modules/mediastream/UserMediaRequest.cpp:
+(WebCore::UserMediaRequest::didCreateStream):
+* platform/mediastream/MediaStreamPrivate.cpp:
+(WebCore::MediaStreamPrivate::platformLayer):
+(WebCore::MediaStreamPrivate::currentFrameImage):
+* platform/mediastream/MediaStreamTrackPrivate.cpp:
+(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
+* platform/mediastream/MediaStreamTrackPrivate.h:
+(WebCore::MediaStreamTrackPrivate::source):
+
 2015-12-22  Commit Queue  
 
 Unreviewed, rolling out r194362.


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp (194370 => 194371)

--- trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2015-12-22 20:37:33 UTC (rev 194370)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.cpp	2015-12-22 21:45:49 UTC (rev 194371)
@@ -315,7 +315,7 @@
 {
 MediaStreamTrackVector tracks;
 for (auto& track : m_trackSet.values()) {
-if (track->source()->type() == filterType)
+if (track->source().type() == filterType)
 tracks.append(track);
 }
 


Modified: trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h (194370 => 194371)

--- trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h	2015-12-22 20:37:33 UTC (rev 194370)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h	2015-12-22 21:45:49 UTC (rev 194371)
@@ -83,7 +83,7 @@
 void applyConstraints(const Dictionary&);
 void applyConstraints(const MediaConstraints&);
 
-RealtimeMediaSource* source() const { return m_private->source(); }
+RealtimeMediaSource& source() const { return m_private->source(); }
 MediaStreamTrackPrivate& privateTrack() { return m_private.get(); }
 
 AudioSourceProvider* audioSourceProvider();


Modified: trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp (194370 => 194371)

--- trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp	2015-12-22 20:37:33 UTC (rev 194370)
+++ trunk/Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp	2015-12-22 21:45:49 UTC (rev 194371)
@@ -47,7 +47,7 @@
 RefPtr RTCDTMFSender::create(ScriptExecutionContext* context, RTCPeerConnectionHandler* peerConnectionHandler, PassRefPtr prpTrack, ExceptionCode& ec)
 {
 RefPtr track = prpTrack;
-std::unique_ptr handler = peerConnectionHandler->createDTMFSender(track->source());
+std::unique_ptr handler = peerConnectionHandler->createDTMFSender(>source());
 if (!handler) {
 ec = NOT_SUPPORTED_ERR;
 return nullptr;


Modified: trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp (194370 => 194371)

--- trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp	2015-12-22 20:37:33 UTC (rev 194370)
+++

[webkit-changes] [194372] trunk/Source

2015-12-22 Thread fpizlo

Title: [194372] trunk/Source








Revision 194372
Author fpi...@apple.com
Date 2015-12-22 13:59:59 -0800 (Tue, 22 Dec 2015)


Log Message
FTL B3 does not logicalNot correctly
https://bugs.webkit.org/show_bug.cgi?id=152512

Reviewed by Saam Barati.

Source/_javascript_Core:

I'm working on a bug where V8/richards does not run correctly. I noticed that the codegen was
doing a log of Not32's followed by branches, which smelled like badness. To debug this, I
needed B3's origins to dump as something other than a hexed pointer to a node. The node index
would be better. So, I added the notion of an origin printer to Procedure.

The bug was easy enough to fix. This introduces Output::logicalNot(). In LLVM, it's the same
as bitNot(). In B3, it's compiled to Equal(value, 0). We could have also compiled it to
BitXor(value, 1), except that B3 will strength-reduce to that anyway whenever it's safe. It's
sort of nice that right now, you could use logicalNot() on non-bool values and get C-like
behavior.

Richards still doesn't run, though. There are more bugs!

* _javascript_Core.xcodeproj/project.pbxproj:
* b3/B3BasicBlock.cpp:
(JSC::B3::BasicBlock::dump):
(JSC::B3::BasicBlock::deepDump):
* b3/B3BasicBlock.h:
(JSC::B3::BasicBlock::frequency):
(JSC::B3::DeepBasicBlockDump::DeepBasicBlockDump):
(JSC::B3::DeepBasicBlockDump::dump):
(JSC::B3::deepDump):
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::lower):
* b3/B3Origin.h:
(JSC::B3::Origin::data):
* b3/B3OriginDump.h: Added.
(JSC::B3::OriginDump::OriginDump):
(JSC::B3::OriginDump::dump):
* b3/B3Procedure.cpp:
(JSC::B3::Procedure::~Procedure):
(JSC::B3::Procedure::printOrigin):
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::dump):
* b3/B3Procedure.h:
(JSC::B3::Procedure::setOriginPrinter):
* b3/B3Value.cpp:
(JSC::B3::Value::dumpChildren):
(JSC::B3::Value::deepDump):
* b3/B3Value.h:
(JSC::B3::DeepValueDump::DeepValueDump):
(JSC::B3::DeepValueDump::dump):
(JSC::B3::deepDump):
* ftl/FTLB3Output.cpp:
(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::bitNot):
(JSC::FTL::Output::logicalNot):
(JSC::FTL::Output::load):
* ftl/FTLB3Output.h:
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::lShr):
(JSC::FTL::Output::ctlz32):
(JSC::FTL::Output::addWithOverflow32):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::doubleEqual):
(JSC::FTL::Output::doubleEqualOrUnordered):
(JSC::FTL::Output::doubleNotEqualOrUnordered):
(JSC::FTL::Output::doubleLessThan):
(JSC::FTL::Output::doubleLessThanOrEqual):
(JSC::FTL::Output::doubleGreaterThan):
(JSC::FTL::Output::doubleGreaterThanOrEqual):
(JSC::FTL::Output::doubleNotEqualAndOrdered):
(JSC::FTL::Output::doubleLessThanOrUnordered):
(JSC::FTL::Output::doubleLessThanOrEqualOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrEqualOrUnordered):
(JSC::FTL::Output::isZero32):
(JSC::FTL::Output::notZero32):
(JSC::FTL::Output::addIncomingToPhi):
(JSC::FTL::Output::bitCast):
(JSC::FTL::Output::bitNot): Deleted.
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckArray):
(JSC::FTL::DFG::LowerDFGToLLVM::compileGetTypedArrayByteOffset):
(JSC::FTL::DFG::LowerDFGToLLVM::compileLogicalNot):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileInstanceOfCustom):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCountExecution):
(JSC::FTL::DFG::LowerDFGToLLVM::boolify):
(JSC::FTL::DFG::LowerDFGToLLVM::isMisc):
(JSC::FTL::DFG::LowerDFGToLLVM::isNotBoolean):
(JSC::FTL::DFG::LowerDFGToLLVM::isBoolean):
(JSC::FTL::DFG::LowerDFGToLLVM::unboxBoolean):
(JSC::FTL::DFG::LowerDFGToLLVM::isNotType):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateObject):
* ftl/FTLOutput.h:
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::lShr):
(JSC::FTL::Output::bitNot):
(JSC::FTL::Output::logicalNot):
(JSC::FTL::Output::insertElement):
* ftl/FTLState.cpp:
(JSC::FTL::State::State):

Source/WTF:

This change introduces yet another use of SharedTask in JSC. While doing this, I noticed that
SharedTask::run() always demands that whatever arguments the callback takes, they must be
passed as rvalue references. This was a clear misuse of perfect forwarding. This change makes
SharedTask's approach to forwarding match what we were already doing in ScopedLambda.

* wtf/SharedTask.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/b3/B3BasicBlock.cpp
trunk/Source/_javascript_Core/b3/B3BasicBlock.h
trunk/Source/_javascript_Core/b3/B3LowerToAir.cpp
trunk/Source/_javascript_Core/b3/B3Origin.h
trunk/Source/_javascript_Core/b3/B3Procedure.cpp
trunk/Source/_javascript_Core/b3/B3Procedure.h
trunk/Source/_javascript_Core/b3/B3Value.cpp
trunk/Source/_javascript_Core/b3/B3Value.h
trunk/Source/_javascript_Core/ftl/FTLB3Output.cpp
trunk/Source/_javascript_Core/ftl/FTLB3Output.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp

[webkit-changes] [194376] trunk/Source/JavaScriptCore

2015-12-22 Thread sbarati

Title: [194376] trunk/Source/_javascript_Core








Revision 194376
Author sbar...@apple.com
Date 2015-12-22 15:12:43 -0800 (Tue, 22 Dec 2015)


Log Message
Cloop build fix after https://bugs.webkit.org/show_bug.cgi?id=152511.

Unreviewed build fix.

* runtime/Options.cpp:
(JSC::recomputeDependentOptions):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Options.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (194375 => 194376)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-22 22:52:42 UTC (rev 194375)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-22 23:12:43 UTC (rev 194376)
@@ -1,5 +1,14 @@
 2015-12-22  Saam barati  
 
+Cloop build fix after https://bugs.webkit.org/show_bug.cgi?id=152511.
+
+Unreviewed build fix.
+
+* runtime/Options.cpp:
+(JSC::recomputeDependentOptions):
+
+2015-12-22  Saam barati  
+
 Work around issue in bug #152510
 https://bugs.webkit.org/show_bug.cgi?id=152511
 


Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (194375 => 194376)

--- trunk/Source/_javascript_Core/runtime/Options.cpp	2015-12-22 22:52:42 UTC (rev 194375)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp	2015-12-22 23:12:43 UTC (rev 194376)
@@ -26,7 +26,6 @@
 #include "config.h"
 #include "Options.h"
 
-#include "CCallHelpers.h"
 #include 
 #include 
 #include 
@@ -317,15 +316,15 @@
 Options::useOSREntryToFTL() = false;
 }
 
-if (isARM64()) {
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=152510
-// We're running into a bug where some ARM64 tests are failing in the FTL
-// with what appears to be an llvm bug where llvm is miscalculating the
-// live-out variables of a patchpoint. This causes us to not keep a 
-// volatile register alive across a C call in a patchpoint, even though 
-// that register is used immediately after the patchpoint.
-Options::assumeAllRegsInFTLICAreLive() = true;
-}
+#if CPU(ARM64)
+// FIXME: https://bugs.webkit.org/show_bug.cgi?id=152510
+// We're running into a bug where some ARM64 tests are failing in the FTL
+// with what appears to be an llvm bug where llvm is miscalculating the
+// live-out variables of a patchpoint. This causes us to not keep a 
+// volatile register alive across a C call in a patchpoint, even though 
+// that register is used immediately after the patchpoint.
+Options::assumeAllRegsInFTLICAreLive() = true;
+#endif
 
 // Compute the maximum value of the reoptimization retry counter. This is simply
 // the largest value at which we don't overflow the execute counter, when using it






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194367] trunk/Source

2015-12-22 Thread bfulgham

Title: [194367] trunk/Source








Revision 194367
Author bfulg...@apple.com
Date 2015-12-22 11:37:50 -0800 (Tue, 22 Dec 2015)


Log Message
Allow _javascript_ to iterate over plugins for local SecurityOrigins
https://bugs.webkit.org/show_bug.cgi?id=152489

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Instead of calling 'isLocalFile' on the URL, we check the Document's SecurityOrigin. If
no origin exists, we construct a SecurityOrigin from the URL, and check whether it
satisfies 'isLocal'.

* page/Page.cpp:
(WebCore::Page::showAllPlugins): Revised to use SecurityOrigin.

Source/WebKit2:

The 'getWebVisiblePluginInfo' is filtering plugins, even when we want to list
all plugins. To avoid this, we check the Document's SecurityOrigin. If no such
origin exists, we construct a SecurityOrigin from the URL.

If the relevant SecurityOrigin satsifies 'isLocal', we show all plugins.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::getWebVisiblePluginInfo):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/SecurityOrigin.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194366 => 194367)

--- trunk/Source/WebCore/ChangeLog	2015-12-22 18:20:49 UTC (rev 194366)
+++ trunk/Source/WebCore/ChangeLog	2015-12-22 19:37:50 UTC (rev 194367)
@@ -1,3 +1,17 @@
+2015-12-22  Brent Fulgham  
+
+Allow _javascript_ to iterate over plugins for local SecurityOrigins
+https://bugs.webkit.org/show_bug.cgi?id=152489
+
+Reviewed by Alexey Proskuryakov.
+
+Instead of calling 'isLocalFile' on the URL, we check the Document's SecurityOrigin. If
+no origin exists, we construct a SecurityOrigin from the URL, and check whether it
+satisfies 'isLocal'.
+
+* page/Page.cpp:
+(WebCore::Page::showAllPlugins): Revised to use SecurityOrigin.
+
 2015-12-22  Michael Catanzaro  
 
 [GTK] Everything broken in GTK+ 3.19


Modified: trunk/Source/WebCore/page/Page.cpp (194366 => 194367)

--- trunk/Source/WebCore/page/Page.cpp	2015-12-22 18:20:49 UTC (rev 194366)
+++ trunk/Source/WebCore/page/Page.cpp	2015-12-22 19:37:50 UTC (rev 194367)
@@ -524,7 +524,15 @@
 
 bool Page::showAllPlugins() const
 {
-return m_showAllPlugins || mainFrame().loader().documentLoader()->url().isLocalFile();
+if (m_showAllPlugins)
+return true;
+
+if (Document* document = mainFrame().document()) {
+if (SecurityOrigin* securityOrigin = document->securityOrigin())
+return securityOrigin->isLocal();
+}
+
+return false;
 }
 
 inline MediaCanStartListener* Page::takeAnyMediaCanStartListener()


Modified: trunk/Source/WebCore/page/SecurityOrigin.h (194366 => 194367)

--- trunk/Source/WebCore/page/SecurityOrigin.h	2015-12-22 18:20:49 UTC (rev 194366)
+++ trunk/Source/WebCore/page/SecurityOrigin.h	2015-12-22 19:37:50 UTC (rev 194367)
@@ -161,7 +161,7 @@
 // The local SecurityOrigin is the most privileged SecurityOrigin.
 // The local SecurityOrigin can script any document, navigate to local
 // resources, and can set arbitrary headers on XMLHttpRequests.
-bool isLocal() const;
+WEBCORE_EXPORT bool isLocal() const;
 
 // The origin is a globally unique identifier assigned when the Document is
 // created. http://www.whatwg.org/specs/web-apps/current-work/#sandboxOrigin


Modified: trunk/Source/WebKit2/ChangeLog (194366 => 194367)

--- trunk/Source/WebKit2/ChangeLog	2015-12-22 18:20:49 UTC (rev 194366)
+++ trunk/Source/WebKit2/ChangeLog	2015-12-22 19:37:50 UTC (rev 194367)
@@ -1,3 +1,19 @@
+2015-12-22  Brent Fulgham  
+
+Allow _javascript_ to iterate over plugins for local SecurityOrigins
+https://bugs.webkit.org/show_bug.cgi?id=152489
+
+Reviewed by Alexey Proskuryakov.
+
+The 'getWebVisiblePluginInfo' is filtering plugins, even when we want to list
+all plugins. To avoid this, we check the Document's SecurityOrigin. If no such
+origin exists, we construct a SecurityOrigin from the URL.
+
+If the relevant SecurityOrigin satsifies 'isLocal', we show all plugins.
+
+* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
+(WebKit::WebPlatformStrategies::getWebVisiblePluginInfo):
+
 2015-12-21  Hunseop Jeong  
 
 [EFL] test_ewk2_context failed after r192808


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp (194366 => 194367)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp	2015-12-22 18:20:49 UTC (rev 194366)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp	2015-12-22 19:37:50 UTC (rev 194367)
@@ -48,6 +48,7 @@
 #include "WebProcess.h"
 #include "WebProcessProxyMessages.h"

[webkit-changes] [194365] trunk/LayoutTests

2015-12-22 Thread ryanhaddad

Title: [194365] trunk/LayoutTests








Revision 194365
Author ryanhad...@apple.com
Date 2015-12-22 10:15:02 -0800 (Tue, 22 Dec 2015)


Log Message
Marking webgl/1.0.2/conformance/extensions/get-extension.html as flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=152506

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (194364 => 194365)

--- trunk/LayoutTests/ChangeLog	2015-12-22 17:38:00 UTC (rev 194364)
+++ trunk/LayoutTests/ChangeLog	2015-12-22 18:15:02 UTC (rev 194365)
@@ -1,3 +1,12 @@
+2015-12-22  Ryan Haddad  
+
+Marking webgl/1.0.2/conformance/extensions/get-extension.html as flaky on mac-wk1
+https://bugs.webkit.org/show_bug.cgi?id=152506
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2015-12-22  Chris Fleizach  
 
 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (194364 => 194365)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-12-22 17:38:00 UTC (rev 194364)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-12-22 18:15:02 UTC (rev 194365)
@@ -56,6 +56,8 @@
 
 webkit.org/b/152487 inspector/debugger/command-line-api-exception-nested-catch.html [ Pass Timeout ]
 
+webkit.org/b/152506 webgl/1.0.2/conformance/extensions/get-extension.html [ Pass Timeout ]
+
 ### END OF (1) Failures with bug reports
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194361] trunk/Tools

2015-12-22 Thread calvaris

Title: [194361] trunk/Tools








Revision 194361
Author calva...@igalia.com
Date 2015-12-22 01:16:24 -0800 (Tue, 22 Dec 2015)


Log Message
Unreviewed.

* Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (194360 => 194361)

--- trunk/Tools/ChangeLog	2015-12-22 06:07:23 UTC (rev 194360)
+++ trunk/Tools/ChangeLog	2015-12-22 09:16:24 UTC (rev 194361)
@@ -1,3 +1,9 @@
+2015-12-22  Xabier Rodriguez Calvar  
+
+Unreviewed.
+
+* Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
+
 2015-12-21  Hunseop Jeong  
 
 [EFL] test_ewk2_context failed after r192808


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (194360 => 194361)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-12-22 06:07:23 UTC (rev 194360)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2015-12-22 09:16:24 UTC (rev 194361)
@@ -2970,15 +2970,6 @@
 "wms"
  ]
   },
-  "Xabier Rodriguez-Calvar" : {
- "emails" : [
-"calva...@igalia.com",
-"xrcal...@igalia.com"
- ],
- "nicks" : [
-"calvaris"
- ]
-  },
   "Xianzhu Wang" : {
  "emails" : [
 "wangxian...@chromium.org",
@@ -4985,6 +4976,16 @@
 "vsevik"
  ]
   },
+  "Xabier Rodriguez-Calvar" : {
+ "emails" : [
+"calva...@igalia.com",
+"xrcal...@igalia.com"
+ ],
+ "expertise" : "WebKitGTK+, GStreamer, Streams API",
+ "nicks" : [
+"calvaris"
+ ]
+  },
   "Xan Lopez" : {
  "emails" : [
 "xan.lo...@gmail.com",






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [194363] trunk/Source/JavaScriptCore

2015-12-22 Thread mark . lam

Title: [194363] trunk/Source/_javascript_Core








Revision 194363
Author mark@apple.com
Date 2015-12-22 08:20:48 -0800 (Tue, 22 Dec 2015)


Log Message
Snippefy op_negate for the baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=152447

Reviewed by Benjamin Poulain.

* CMakeLists.txt:
* _javascript_Core.vcxproj/_javascript_Core.vcxproj:
* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters:
* _javascript_Core.xcodeproj/project.pbxproj:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitBitBinaryOpFastPath):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_op_negate): Deleted.
(JSC::JIT::emitSlow_op_negate): Deleted.
* jit/JITNegGenerator.cpp: Added.
(JSC::JITNegGenerator::generateFastPath):
* jit/JITNegGenerator.h: Added.
(JSC::JITNegGenerator::JITNegGenerator):
(JSC::JITNegGenerator::didEmitFastPath):
(JSC::JITNegGenerator::endJumpList):
(JSC::JITNegGenerator::slowPathJumpList):

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj
trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/jit/JITArithmetic.cpp
trunk/Source/_javascript_Core/jit/JITArithmetic32_64.cpp


Added Paths

trunk/Source/_javascript_Core/jit/JITNegGenerator.cpp
trunk/Source/_javascript_Core/jit/JITNegGenerator.h




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (194362 => 194363)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2015-12-22 14:22:03 UTC (rev 194362)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2015-12-22 16:20:48 UTC (rev 194363)
@@ -473,6 +473,7 @@
 jit/JITInlineCacheGenerator.cpp
 jit/JITLeftShiftGenerator.cpp
 jit/JITMulGenerator.cpp
+jit/JITNegGenerator.cpp
 jit/JITOpcodes.cpp
 jit/JITOpcodes32_64.cpp
 jit/JITOperations.cpp


Modified: trunk/Source/_javascript_Core/ChangeLog (194362 => 194363)

--- trunk/Source/_javascript_Core/ChangeLog	2015-12-22 14:22:03 UTC (rev 194362)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-12-22 16:20:48 UTC (rev 194363)
@@ -1,3 +1,31 @@
+2015-12-21  Mark Lam  
+
+Snippefy op_negate for the baseline JIT.
+https://bugs.webkit.org/show_bug.cgi?id=152447
+
+Reviewed by Benjamin Poulain.
+
+* CMakeLists.txt:
+* _javascript_Core.vcxproj/_javascript_Core.vcxproj:
+* _javascript_Core.vcxproj/_javascript_Core.vcxproj.filters:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* jit/JITArithmetic.cpp:
+(JSC::JIT::emit_op_unsigned):
+(JSC::JIT::emit_op_negate):
+(JSC::JIT::emitSlow_op_negate):
+(JSC::JIT::emitBitBinaryOpFastPath):
+* jit/JITArithmetic32_64.cpp:
+(JSC::JIT::emit_compareAndJump):
+(JSC::JIT::emit_op_negate): Deleted.
+(JSC::JIT::emitSlow_op_negate): Deleted.
+* jit/JITNegGenerator.cpp: Added.
+(JSC::JITNegGenerator::generateFastPath):
+* jit/JITNegGenerator.h: Added.
+(JSC::JITNegGenerator::JITNegGenerator):
+(JSC::JITNegGenerator::didEmitFastPath):
+(JSC::JITNegGenerator::endJumpList):
+(JSC::JITNegGenerator::slowPathJumpList):
+
 2015-12-21  Filip Pizlo  
 
 Address review feedback from Saam.  I should have landed it in r194354.


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj (194362 => 194363)

--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj	2015-12-22 14:22:03 UTC (rev 194362)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj	2015-12-22 16:20:48 UTC (rev 194363)
@@ -657,6 +657,7 @@
 
 
 
+
 
 
 
@@ -1490,6 +1491,7 @@
 
 
 
+
 
 
 


Modified: trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters (194362 => 194363)

--- trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters	2015-12-22 14:22:03 UTC (rev 194362)
+++ trunk/Source/_javascript_Core/_javascript_Core.vcxproj/_javascript_Core.vcxproj.filters	2015-12-22 16:20:48 UTC (rev 194363)
@@ -462,6 +462,9 @@
 
   jit
 
+
+  jit
+
 
   jit
 
@@ -2582,6 +2585,9 @@
 
   jit
 
+
+  jit
+
 
   jit
 


Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (194362 => 194363)

--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2015-12-22 14:22:03 UTC (rev 194362)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2015-12-22 16:20:48 UTC (rev 194363)
@@ -2054,6 +2054,8 @@
 		FE7BA60F1A1A7CEC00F1F7B4

[webkit-changes] [194362] trunk/Source/WebCore

2015-12-22 Thread mcatanzaro

Title: [194362] trunk/Source/WebCore








Revision 194362
Author mcatanz...@igalia.com
Date 2015-12-22 06:22:03 -0800 (Tue, 22 Dec 2015)


Log Message
[GTK] Everything broken in GTK+ 3.19
https://bugs.webkit.org/show_bug.cgi?id=150550

Reviewed by Carlos Garcia Campos.

Port RenderThemeGtk and ScrollbarThemeGtk to use CSS nodes. This makes it possible to render
stuff with modern GTK+.

No new tests. We already have tons of tests for this functionality, but we're running them
with GTK+ 3.16, so they cannot have detected this breakage. These fixes require unreleased
GTK+, and GTK+ rendering is currently in a state of flux; once things settle down, we can
consider upgrading the GTK+ used for our layout tests.

* platform/gtk/GRefPtrGtk.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
* platform/gtk/GRefPtrGtk.h:
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::themeChanged):
(WebCore::ScrollbarThemeGtk::updateThemeProperties):
(WebCore::orientationStyleClass):
(WebCore::applyScrollbarStyleContextClasses):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):
(WebCore::ScrollbarThemeGtk::paintButton):
* rendering/RenderThemeGtk.cpp:
(WebCore::createStyleContext):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::applySliderStyleContextClasses):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::paintSpinArrowButton):
(WebCore::styleColor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp
trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h
trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (194361 => 194362)

--- trunk/Source/WebCore/ChangeLog	2015-12-22 09:16:24 UTC (rev 194361)
+++ trunk/Source/WebCore/ChangeLog	2015-12-22 14:22:03 UTC (rev 194362)
@@ -1,3 +1,46 @@
+2015-12-22  Michael Catanzaro  
+
+[GTK] Everything broken in GTK+ 3.19
+https://bugs.webkit.org/show_bug.cgi?id=150550
+
+Reviewed by Carlos Garcia Campos.
+
+Port RenderThemeGtk and ScrollbarThemeGtk to use CSS nodes. This makes it possible to render
+stuff with modern GTK+.
+
+No new tests. We already have tons of tests for this functionality, but we're running them
+with GTK+ 3.16, so they cannot have detected this breakage. These fixes require unreleased
+GTK+, and GTK+ rendering is currently in a state of flux; once things settle down, we can
+consider upgrading the GTK+ used for our layout tests.
+
+* platform/gtk/GRefPtrGtk.cpp:
+(WTF::refGPtr):
+(WTF::derefGPtr):
+* platform/gtk/GRefPtrGtk.h:
+* platform/gtk/ScrollbarThemeGtk.cpp:
+(WebCore::ScrollbarThemeGtk::themeChanged):
+(WebCore::ScrollbarThemeGtk::updateThemeProperties):
+(WebCore::orientationStyleClass):
+(WebCore::applyScrollbarStyleContextClasses):
+(WebCore::ScrollbarThemeGtk::paintTrackBackground):
+(WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
+(WebCore::ScrollbarThemeGtk::paintThumb):
+(WebCore::ScrollbarThemeGtk::paintButton):
+* rendering/RenderThemeGtk.cpp:
+(WebCore::createStyleContext):
+(WebCore::setToggleSize):
+(WebCore::paintToggle):
+(WebCore::RenderThemeGtk::paintButton):
+(WebCore::getComboBoxMetrics):
+(WebCore::RenderThemeGtk::paintMenuList):
+(WebCore::RenderThemeGtk::paintTextField):
+(WebCore::applySliderStyleContextClasses):
+(WebCore::RenderThemeGtk::paintSliderTrack):
+(WebCore::RenderThemeGtk::paintSliderThumb):
+(WebCore::RenderThemeGtk::paintProgressBar):
+(WebCore::paintSpinArrowButton):
+(WebCore::styleColor):
+
 2015-12-20  Jeremy Zerfas  
 
 Don't allocate a NSImage and skip unneeded call to TIFFRepresentation when copying image to clipboard.


Modified: trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp (194361 => 194362)

--- trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp	2015-12-22 09:16:24 UTC (rev 194361)
+++ trunk/Source/WebCore/platform/gtk/GRefPtrGtk.cpp	2015-12-22 14:22:03 UTC (rev 194362)
@@ -72,6 +72,22 @@
 if (ptr)
 gdk_cursor_unref(ptr);
 }
+
+#else
+
+template <> GtkWidgetPath* refGPtr(GtkWidgetPath* ptr)
+{
+if (ptr)
+gtk_widget_path_ref(ptr);
+return ptr;
+}
+
+template <> void derefGPtr(GtkWidgetPath* ptr)
+{
+if (ptr)
+gtk_widget_path_unref(ptr);
+}
+
 #endif
 
 }


Modified: trunk/Source/WebCore/platform/gtk/GRefPtrGtk.h (194361 =>

[webkit-changes] [194364] trunk

2015-12-22 Thread cfleizach

Title: [194364] trunk








Revision 194364
Author cfleiz...@apple.com
Date 2015-12-22 09:38:00 -0800 (Tue, 22 Dec 2015)


Log Message
[WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
https://bugs.webkit.org/show_bug.cgi?id=152482

Reviewed by Brent Fulgham.

Tools:

vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
for the same property. On WK2, the element returned will not be valid, but is still present and
that can lead to looping.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):

LayoutTests:

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (194363 => 194364)

--- trunk/LayoutTests/ChangeLog	2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/LayoutTests/ChangeLog	2015-12-22 17:38:00 UTC (rev 194364)
@@ -1,3 +1,12 @@
+2015-12-22  Chris Fleizach  
+
+[WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
+https://bugs.webkit.org/show_bug.cgi?id=152482
+
+Reviewed by Brent Fulgham.
+
+* platform/mac-wk2/TestExpectations:
+
 2015-12-21  Ryan Haddad  
 
 Skipping unsupported test on ios-simulator


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (194363 => 194364)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2015-12-22 17:38:00 UTC (rev 194364)
@@ -364,9 +364,6 @@
 
 [ Debug ] editing/undo/remove-css-property-and-remove-style.html [ Pass Failure ]
 
-# Test for WK1 only
-fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [ Skip ]
-
 ### END OF (3) Unclassified failures
 
 


Modified: trunk/Tools/ChangeLog (194363 => 194364)

--- trunk/Tools/ChangeLog	2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/Tools/ChangeLog	2015-12-22 17:38:00 UTC (rev 194364)
@@ -1,3 +1,21 @@
+2015-12-22  Chris Fleizach  
+
+[WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
+https://bugs.webkit.org/show_bug.cgi?id=152482
+
+Reviewed by Brent Fulgham.
+
+vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
+for the same property. On WK2, the element returned will not be valid, but is still present and
+that can lead to looping.
+
+* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+(AccessibilityUIElement::horizontalScrollbar):
+(AccessibilityUIElement::verticalScrollbar):
+* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+(WTR::AccessibilityUIElement::horizontalScrollbar):
+(WTR::AccessibilityUIElement::verticalScrollbar):
+
 2015-12-22  Xabier Rodriguez Calvar  
 
 Unreviewed.


Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (194363 => 194364)

--- trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm	2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm	2015-12-22 17:38:00 UTC (rev 194364)
@@ -1292,6 +1292,9 @@
 
 AccessibilityUIElement AccessibilityUIElement::horizontalScrollbar() const
 {
+if (!m_element)
+return nullptr;
+
 BEGIN_AX_OBJC_EXCEPTIONS
 return AccessibilityUIElement([m_element accessibilityAttributeValue:NSAccessibilityHorizontalScrollBarAttribute]);
 END_AX_OBJC_EXCEPTIONS
@@ -1301,6 +1304,9 @@
 
 AccessibilityUIElement AccessibilityUIElement::verticalScrollbar() const
 {
+if (!m_element)
+return nullptr;
+
 BEGIN_AX_OBJC_EXCEPTIONS
 return AccessibilityUIElement([m_element accessibilityAttributeValue:NSAccessibilityVerticalScrollBarAttribute]);
 END_AX_OBJC_EXCEPTIONS


Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (194363 => 194364)

--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm	2015-12-22 16:20:48 UTC (rev 194363)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm	2015-12-22 17:38:00 UTC (rev 194364)
@@ -1352,6 +1352,9 @@
 
 PassRefPtr AccessibilityUIElement::horizontalScrollbar() const
 {
+if (!m_element)
+return nullptr;
+
 BEGIN_AX_OBJC_EXCEPTIONS

[webkit-changes] [194369] trunk/Source

[webkit-changes] [194370] trunk/Source/WebCore

[webkit-changes] [194368] trunk/Source/JavaScriptCore

[webkit-changes] [194366] trunk/LayoutTests

[webkit-changes] [194375] tags/Safari-601.1.46.89/

[webkit-changes] [194383] trunk/Source/JavaScriptCore

[webkit-changes] [194379] branches/safari-601.1.46-branch/Source

[webkit-changes] [194380] trunk/Source/WebCore

[webkit-changes] [194382] trunk/Source

[webkit-changes] [194385] trunk/Source/JavaScriptCore

[webkit-changes] [194373] trunk/Source/JavaScriptCore

[webkit-changes] [194374] trunk/Tools

[webkit-changes] [194377] trunk/Source/WebCore

[webkit-changes] [194371] trunk/Source/WebCore

[webkit-changes] [194372] trunk/Source

[webkit-changes] [194376] trunk/Source/JavaScriptCore

[webkit-changes] [194367] trunk/Source

[webkit-changes] [194365] trunk/LayoutTests

[webkit-changes] [194361] trunk/Tools

[webkit-changes] [194363] trunk/Source/JavaScriptCore

[webkit-changes] [194362] trunk/Source/WebCore

[webkit-changes] [194364] trunk

22 matches

Site Navigation

Mail list logo

Footer information