[webkit-changes] [210727] trunk/Source/WebCore

[timothy_horton]

Title: [210727] trunk/Source/WebCore








Revision 210727
Author timothy_hor...@apple.com
Date 2017-01-12 23:36:54 -0800 (Thu, 12 Jan 2017)


Log Message
Keyboard accessory bar can appear on top of full-screen video
https://bugs.webkit.org/show_bug.cgi?id=166902


Reviewed by Darin Adler.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
Increase the full-screen video window level to one above the keyboard,
to ensure that the video is never obscured by the keyboard or its
accessory views.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (210726 => 210727)

--- trunk/Source/WebCore/ChangeLog	2017-01-13 07:12:00 UTC (rev 210726)
+++ trunk/Source/WebCore/ChangeLog	2017-01-13 07:36:54 UTC (rev 210727)
@@ -1,3 +1,17 @@
+2017-01-12  Tim Horton  
+
+Keyboard accessory bar can appear on top of full-screen video
+https://bugs.webkit.org/show_bug.cgi?id=166902
+
+
+Reviewed by Darin Adler.
+
+* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
+Increase the full-screen video window level to one above the keyboard,
+to ensure that the video is never obscured by the keyboard or its
+accessory views.
+
 2017-01-12  Joseph Pecoraro  
 
 Remove unnecessary includes of Page.h


Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (210726 => 210727)

--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2017-01-13 07:12:00 UTC (rev 210726)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm	2017-01-13 07:36:54 UTC (rev 210727)
@@ -73,6 +73,7 @@
 SOFT_LINK_CLASS(UIKit, UIView)
 SOFT_LINK_CLASS(UIKit, UIViewController)
 SOFT_LINK_CLASS(UIKit, UIColor)
+SOFT_LINK_CONSTANT(UIKit, UIRemoteKeyboardLevel, UIWindowLevel)
 
 #if !LOG_DISABLED
 static const char* boolString(bool val)
@@ -606,6 +607,7 @@
 [[m_viewController view] setFrame:[m_window bounds]];
 [m_viewController _setIgnoreAppSupportedOrientations:YES];
 [m_window setRootViewController:m_viewController.get()];
+[m_window setWindowLevel:getUIRemoteKeyboardLevel() + 1];
 [m_window makeKeyAndVisible];
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [210726] branches/safari-603-branch/Source/WebKit2

[matthew_hanson]

Title: [210726] branches/safari-603-branch/Source/WebKit2








Revision 210726
Author matthew_han...@apple.com
Date 2017-01-12 23:12:00 -0800 (Thu, 12 Jan 2017)


Log Message
Merge r209189. rdar://problem/29428877

Modified Paths

branches/safari-603-branch/Source/WebKit2/ChangeLog
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCache.h
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.cpp
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheBlobStorage.h
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheData.cpp
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.cpp
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheKey.h
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp
branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h




Diff

Modified: branches/safari-603-branch/Source/WebKit2/ChangeLog (210725 => 210726)

--- branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-01-13 07:11:54 UTC (rev 210725)
+++ branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-01-13 07:12:00 UTC (rev 210726)
@@ -1,5 +1,60 @@
 2017-01-12  Matthew Hanson  
 
+Merge r209189. rdar://problem/29428877
+
+2016-12-01  Antti Koivisto  
+
+Revert r208931
+https://bugs.webkit.org/show_bug.cgi?id=164924
+
+PLT regression.
+
+* NetworkProcess/cache/NetworkCache.cpp:
+(WebKit::NetworkCache::makeCacheKey):
+(WebKit::NetworkCache::Cache::makeCacheKey): Deleted.
+* NetworkProcess/cache/NetworkCache.h:
+* NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
+(WebKit::NetworkCache::BlobStorage::BlobStorage):
+(WebKit::NetworkCache::BlobStorage::add):
+(WebKit::NetworkCache::BlobStorage::get):
+* NetworkProcess/cache/NetworkCacheBlobStorage.h:
+* NetworkProcess/cache/NetworkCacheData.cpp:
+(WebKit::NetworkCache::computeSHA1):
+(WebKit::NetworkCache::makeSalt): Deleted.
+(WebKit::NetworkCache::readOrMakeSalt): Deleted.
+* NetworkProcess/cache/NetworkCacheData.h:
+* NetworkProcess/cache/NetworkCacheKey.cpp:
+(WebKit::NetworkCache::noPartitionString):
+(WebKit::NetworkCache::Key::Key):
+(WebKit::NetworkCache::Key::hasPartition):
+(WebKit::NetworkCache::Key::computeHash):
+(WebKit::NetworkCache::Key::hashAsString):
+(WebKit::NetworkCache::Key::computePartitionHash): Deleted.
+* NetworkProcess/cache/NetworkCacheKey.h:
+(WebKit::NetworkCache::Key::hash):
+(WebKit::NetworkCache::Key::partitionHash): Deleted.
+(WebKit::NetworkCache::Key::hashAsString): Deleted.
+(WebKit::NetworkCache::Key::partitionHashAsString): Deleted.
+* NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
+(WebKit::NetworkCache::makeSubresourcesKey):
+(WebKit::NetworkCache::constructRevalidationRequest):
+(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::saveToDiskIfReady):
+(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):
+* NetworkProcess/cache/NetworkCacheStorage.cpp:
+(WebKit::NetworkCache::Storage::open):
+(WebKit::NetworkCache::traverseRecordsFiles):
+(WebKit::NetworkCache::Storage::Storage):
+(WebKit::NetworkCache::Storage::recordDirectoryPathForKey):
+(WebKit::NetworkCache::decodeRecordHeader):
+(WebKit::NetworkCache::Storage::readRecord):
+(WebKit::NetworkCache::Storage::encodeRecord):
+(WebKit::NetworkCache::Storage::traverse):
+(WebKit::NetworkCache::makeSaltFilePath): Deleted.
+* NetworkProcess/cache/NetworkCacheStorage.h:
+(WebKit::NetworkCache::Storage::salt): Deleted.
+
+2017-01-12  Matthew Hanson  
+
 Merge r209554. rdar://problem/29428877
 
 2016-12-08  Antti Koivisto  


Modified: branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp (210725 => 210726)

--- branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp	2017-01-13 07:11:54 UTC (rev 210725)
+++ branches/safari-603-branch/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp	2017-01-13 07:12:00 UTC (rev 210726)
@@ -114,7 +114,7 @@
 m_storage->setCapacity(maximumSize);

[webkit-changes] [210725] branches/safari-603-branch/Source/WebKit2/ChangeLog

[matthew_hanson]

Title: [210725] branches/safari-603-branch/Source/WebKit2/ChangeLog








Revision 210725
Author matthew_han...@apple.com
Date 2017-01-12 23:11:54 -0800 (Thu, 12 Jan 2017)


Log Message
Merge r209554. rdar://problem/29428877

Modified Paths

branches/safari-603-branch/Source/WebKit2/ChangeLog




Diff

Modified: branches/safari-603-branch/Source/WebKit2/ChangeLog (210724 => 210725)

--- branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-01-13 07:05:20 UTC (rev 210724)
+++ branches/safari-603-branch/Source/WebKit2/ChangeLog	2017-01-13 07:11:54 UTC (rev 210725)
@@ -1,5 +1,88 @@
 2017-01-12  Matthew Hanson  
 
+Merge r209554. rdar://problem/29428877
+
+2016-12-08  Antti Koivisto  
+
+Salt network cache hashes
+https://bugs.webkit.org/show_bug.cgi?id=164924
+
+Reviewed by Alex Christensen.
+
+To enhance privacy make cache content unidentifiable from file names alone.
+This is done by generating a unique persistent salt for each cache instance.
+It is used when computing hashes used in file names.
+
+The patch also replaces plain text partition directory names with salted hashes.
+
+* NetworkProcess/cache/NetworkCache.cpp:
+(WebKit::NetworkCache::Cache::makeCacheKey):
+(WebKit::NetworkCache::makeCacheKey): Deleted.
+* NetworkProcess/cache/NetworkCache.h:
+
+Increment cache version.
+
+* NetworkProcess/cache/NetworkCacheBlobStorage.cpp:
+(WebKit::NetworkCache::BlobStorage::BlobStorage):
+(WebKit::NetworkCache::BlobStorage::add):
+(WebKit::NetworkCache::BlobStorage::get):
+
+Use salt for blob content hash.
+
+* NetworkProcess/cache/NetworkCacheBlobStorage.h:
+* NetworkProcess/cache/NetworkCacheData.cpp:
+(WebKit::NetworkCache::computeSHA1):
+
+For simplicity all SHA1s are now salted.
+
+(WebKit::NetworkCache::makeSalt):
+(WebKit::NetworkCache::readOrMakeSalt):
+
+Read salt if it exists, generate and persist it otherwise.
+
+* NetworkProcess/cache/NetworkCacheData.h:
+* NetworkProcess/cache/NetworkCacheKey.cpp:
+(WebKit::NetworkCache::Key::Key):
+
+Remove the "No partition" string and just empty.
+That was only needed to have a directory name of some sort.
+
+(WebKit::NetworkCache::Key::computeHash):
+
+Use salt for key hash.
+
+(WebKit::NetworkCache::Key::computePartitionHash):
+
+Separate hash for partition.
+
+* NetworkProcess/cache/NetworkCacheKey.h:
+* NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
+(WebKit::NetworkCache::makeSubresourcesKey):
+(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::saveToDiskIfReady):
+(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):
+* NetworkProcess/cache/NetworkCacheStorage.cpp:
+(WebKit::NetworkCache::makeSaltFilePath):
+(WebKit::NetworkCache::Storage::open):
+
+Cache can't be opened if we can't read or persist a salt.
+
+(WebKit::NetworkCache::traverseRecordsFiles):
+(WebKit::NetworkCache::Storage::Storage):
+(WebKit::NetworkCache::Storage::synchronize):
+(WebKit::NetworkCache::Storage::recordDirectoryPathForKey):
+
+Use the partition hash in the directory name instead of a plain text name.
+
+(WebKit::NetworkCache::decodeRecordHeader):
+(WebKit::NetworkCache::Storage::readRecord):
+(WebKit::NetworkCache::Storage::encodeRecord):
+(WebKit::NetworkCache::Storage::traverse):
+(WebKit::NetworkCache::Storage::clear):
+* NetworkProcess/cache/NetworkCacheStorage.h:
+(WebKit::NetworkCache::Storage::salt):
+
+2017-01-12  Matthew Hanson  
+
 Merge r210586. rdar://problem/29861147
 
 2017-01-11  Chris Dumez  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [210724] branches/safari-603-branch

[matthew_hanson]

Title: [210724] branches/safari-603-branch








Revision 210724
Author matthew_han...@apple.com
Date 2017-01-12 23:05:20 -0800 (Thu, 12 Jan 2017)


Log Message
Merge r210447. rdar://problem/29872292

Modified Paths

branches/safari-603-branch/LayoutTests/ChangeLog
branches/safari-603-branch/LayoutTests/platform/ios-simulator/TestExpectations
branches/safari-603-branch/Source/WebCore/ChangeLog
branches/safari-603-branch/Source/WebCore/English.lproj/Localizable.strings
branches/safari-603-branch/Source/WebCore/WebCore.xcodeproj/project.pbxproj
branches/safari-603-branch/Source/WebCore/extract-localizable-strings.pl
branches/safari-603-branch/Source/WebCore/platform/LocalizedStrings.cpp
branches/safari-603-branch/Source/WebCore/platform/LocalizedStrings.h
branches/safari-603-branch/Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm


Added Paths

branches/safari-603-branch/LayoutTests/fast/forms/validation-message-maxLength-expected.txt
branches/safari-603-branch/LayoutTests/fast/forms/validation-message-maxLength.html
branches/safari-603-branch/Source/WebCore/English.lproj/Localizable.stringsdict




Diff

Modified: branches/safari-603-branch/LayoutTests/ChangeLog (210723 => 210724)

--- branches/safari-603-branch/LayoutTests/ChangeLog	2017-01-13 07:05:15 UTC (rev 210723)
+++ branches/safari-603-branch/LayoutTests/ChangeLog	2017-01-13 07:05:20 UTC (rev 210724)
@@ -1,5 +1,23 @@
 2017-01-12  Matthew Hanson  
 
+Merge r210447. rdar://problem/29872292
+
+2017-01-06  Chris Dumez  
+
+[Form Validation] "character" in maxlength validation message should be singular when maxlength is 1
+https://bugs.webkit.org/show_bug.cgi?id=166712
+
+
+Reviewed by Darin Adler.
+
+Add layout test coverage.
+
+* fast/forms/validation-message-maxLength-expected.txt: Added.
+* fast/forms/validation-message-maxLength.html: Added.
+* platform/ios-simulator/TestExpectations:
+
+2017-01-12  Matthew Hanson  
+
 Merge r210586. rdar://problem/29861147
 
 2017-01-11  Chris Dumez  


Added: branches/safari-603-branch/LayoutTests/fast/forms/validation-message-maxLength-expected.txt (0 => 210724)

--- branches/safari-603-branch/LayoutTests/fast/forms/validation-message-maxLength-expected.txt	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/forms/validation-message-maxLength-expected.txt	2017-01-13 07:05:20 UTC (rev 210724)
@@ -0,0 +1,18 @@
+Tests the validation message when maxlength is used.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS input.value is "abc"
+PASS input.checkValidity() is false
+PASS input.validationMessage is "Use no more than 2 characters"
+PASS input.value is "ab"
+PASS input.checkValidity() is false
+PASS input.validationMessage is "Use no more than one character"
+PASS input.value is "a"
+PASS input.checkValidity() is false
+PASS input.validationMessage is "Use no more than 0 characters"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+ 


Added: branches/safari-603-branch/LayoutTests/fast/forms/validation-message-maxLength.html (0 => 210724)

--- branches/safari-603-branch/LayoutTests/fast/forms/validation-message-maxLength.html	(rev 0)
+++ branches/safari-603-branch/LayoutTests/fast/forms/validation-message-maxLength.html	2017-01-13 07:05:20 UTC (rev 210724)
@@ -0,0 +1,39 @@
+
+
+
+
+
+
+