[webkit-changes] [224007] trunk/Source/WebCore
Title: [224007] trunk/Source/WebCore
Revision 224007
Author carlo...@webkit.org
Date 2017-10-25 23:03:35 -0700 (Wed, 25 Oct 2017)
Log Message
[HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer
https://bugs.webkit.org/show_bug.cgi?id=178788
Reviewed by Michael Catanzaro.
Instead of using the TextRun direction. If the TextRun is ltr, but the harfbuzz buffer is rtl, the character
indexes will be swapped in m_coreTextIndices.
* platform/graphics/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::create): Remove the ltr parameter.
* platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_isLTR using hb_buffer_get_direction().
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Do not pass ltr to ComplexTextRun::create().
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ComplexTextController.h
trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (224006 => 224007)
--- trunk/Source/WebCore/ChangeLog 2017-10-26 05:23:12 UTC (rev 224006)
+++ trunk/Source/WebCore/ChangeLog 2017-10-26 06:03:35 UTC (rev 224007)
@@ -1,3 +1,19 @@
+2017-10-25 Carlos Garcia Campos
+
+[HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer
+https://bugs.webkit.org/show_bug.cgi?id=178788
+
+Reviewed by Michael Catanzaro.
+
+Instead of using the TextRun direction. If the TextRun is ltr, but the harfbuzz buffer is rtl, the character
+indexes will be swapped in m_coreTextIndices.
+
+* platform/graphics/ComplexTextController.h:
+(WebCore::ComplexTextController::ComplexTextRun::create): Remove the ltr parameter.
+* platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
+(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_isLTR using hb_buffer_get_direction().
+(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Do not pass ltr to ComplexTextRun::create().
+
2017-10-25 Keith Miller
Move remaining platform independent sources to unified sources
Modified: trunk/Source/WebCore/platform/graphics/ComplexTextController.h (224006 => 224007)
--- trunk/Source/WebCore/platform/graphics/ComplexTextController.h 2017-10-26 05:23:12 UTC (rev 224006)
+++ trunk/Source/WebCore/platform/graphics/ComplexTextController.h 2017-10-26 06:03:35 UTC (rev 224007)
@@ -79,9 +79,9 @@
return adoptRef(*new ComplexTextRun(ctRun, font, characters, stringLocation, stringLength, indexBegin, indexEnd));
}
-static Ref create(hb_buffer_t* buffer, const Font& font, const UChar* characters, unsigned stringLocation, unsigned stringLength, unsigned indexBegin, unsigned indexEnd, bool ltr)
+static Ref create(hb_buffer_t* buffer, const Font& font, const UChar* characters, unsigned stringLocation, unsigned stringLength, unsigned indexBegin, unsigned indexEnd)
{
-return adoptRef(*new ComplexTextRun(buffer, font, characters, stringLocation, stringLength, indexBegin, indexEnd, ltr));
+return adoptRef(*new ComplexTextRun(buffer, font, characters, stringLocation, stringLength, indexBegin, indexEnd));
}
static Ref create(const Font& font, const UChar* characters, unsigned stringLocation, unsigned stringLength, unsigned indexBegin, unsigned indexEnd, bool ltr)
@@ -142,7 +142,7 @@
private:
ComplexTextRun(CTRunRef, const Font&, const UChar* characters, unsigned stringLocation, unsigned stringLength, unsigned indexBegin, unsigned indexEnd);
-ComplexTextRun(hb_buffer_t*, const Font&, const UChar* characters, unsigned stringLocation, unsigned stringLength, unsigned indexBegin, unsigned indexEnd, bool ltr);
+ComplexTextRun(hb_buffer_t*, const Font&, const UChar* characters, unsigned stringLocation, unsigned stringLength, unsigned indexBegin, unsigned indexEnd);
ComplexTextRun(const Font&, const UChar* characters, unsigned stringLocation, unsigned stringLength, unsigned indexBegin, unsigned indexEnd, bool ltr);
WEBCORE_EXPORT ComplexTextRun(const Vector& advances, const Vector& origins, const Vector& glyphs, const Vector& stringIndices, FloatSize initialAdvance, const Font&, const UChar* characters, unsigned stringLocation, unsigned stringLength, unsigned indexBegin, unsigned indexEnd, bool ltr);
Modified: trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp (224006 => 224007)
--- trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp 2017-10-26 05:23:12 UTC (rev 224006)
+++ trunk/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp 2017-10-26 06:03:35 UTC (rev 224007)
@@ -38,7 +38,7 @@
return static_cast(value) / (1 << 1
[webkit-changes] [224004] trunk/Source/WebCore
Title: [224004] trunk/Source/WebCore
Revision 224004
Author keith_mil...@apple.com
Date 2017-10-25 21:27:59 -0700 (Wed, 25 Oct 2017)
Log Message
Unreviewed, add FEMorphology.cpp back to the regular build after r224003.
* WebCore.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebCore/ChangeLog (224003 => 224004)
--- trunk/Source/WebCore/ChangeLog 2017-10-26 04:24:02 UTC (rev 224003)
+++ trunk/Source/WebCore/ChangeLog 2017-10-26 04:27:59 UTC (rev 224004)
@@ -1,5 +1,11 @@
2017-10-25 Keith Miller
+Unreviewed, add FEMorphology.cpp back to the regular build after r224003.
+
+* WebCore.xcodeproj/project.pbxproj:
+
+2017-10-25 Keith Miller
+
Unreviewed, Windows build fix.
* Sources.txt:
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (224003 => 224004)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-10-26 04:24:02 UTC (rev 224003)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-10-26 04:27:59 UTC (rev 224004)
@@ -1804,6 +1804,7 @@
5351D4B11DF916B4008010CD /* FileHandle.h in Headers */ = {isa = PBXBuildFile; fileRef = 5351D4AF1DF916AC008010CD /* FileHandle.h */; settings = {ATTRIBUTES = (Private, ); }; };
536D5A20193E18E900CE4CAB /* HTMLSrcsetParser.h in Headers */ = {isa = PBXBuildFile; fileRef = 536D5A1F193E18E900CE4CAB /* HTMLSrcsetParser.h */; };
536D5A23193E8E0C00CE4CAB /* ParsingUtilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 536D5A22193E8E0C00CE4CAB /* ParsingUtilities.h */; };
+ 537202291FA19AE200016B2B /* FEMorphology.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 84730D671248F0B300D3A9C9 /* FEMorphology.cpp */; };
538EC8021F96AF81004D22A8 /* UnifiedSource1.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538EC7FA1F96AA70004D22A8 /* UnifiedSource1.cpp */; };
538EC8031F96AF81004D22A8 /* UnifiedSource1.mm in Sources */ = {isa = PBXBuildFile; fileRef = 538EC7F31F96AA5B004D22A8 /* UnifiedSource1.mm */; };
538EC8041F96AF81004D22A8 /* UnifiedSource2.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 538EC7EE1F96AA56004D22A8 /* UnifiedSource2.cpp */; };
@@ -30857,6 +30858,7 @@
1C21E57C183ED1FF001C289D /* IOSurfacePool.cpp in Sources */,
AD9FF6E11908391D003B61E0 /* IOSurfacePoolCocoa.mm in Sources */,
A1DF5A9A1F7EC8C00058A477 /* JSApplePayContactField.cpp in Sources */,
+537202291FA19AE200016B2B /* FEMorphology.cpp in Sources */,
1ADFDFEC1E71E455008F5D34 /* JSApplePayError.cpp in Sources */,
7C6579EF1E00856600E3A27A /* JSApplePayLineItem.cpp in Sources */,
A1DF5A8D1F7EC0020058A477 /* JSApplePayMerchantCapability.cpp in Sources */,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224003] trunk/Source/WebCore
Title: [224003] trunk/Source/WebCore Revision 224003 Author keith_mil...@apple.com Date 2017-10-25 21:24:02 -0700 (Wed, 25 Oct 2017) Log Message Unreviewed, Windows build fix. * Sources.txt: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt Diff Modified: trunk/Source/WebCore/ChangeLog (224002 => 224003) --- trunk/Source/WebCore/ChangeLog 2017-10-26 04:07:59 UTC (rev 224002) +++ trunk/Source/WebCore/ChangeLog 2017-10-26 04:24:02 UTC (rev 224003) @@ -1,3 +1,9 @@ +2017-10-25 Keith Miller + +Unreviewed, Windows build fix. + +* Sources.txt: + 2017-10-25 Devin Rousso Web Inspector: provide a way to enable/disable event listeners Modified: trunk/Source/WebCore/Sources.txt (224002 => 224003) --- trunk/Source/WebCore/Sources.txt 2017-10-26 04:07:59 UTC (rev 224002) +++ trunk/Source/WebCore/Sources.txt 2017-10-26 04:24:02 UTC (rev 224003) @@ -1554,7 +1554,7 @@ platform/graphics/filters/FEGaussianBlur.cpp platform/graphics/filters/FELighting.cpp platform/graphics/filters/FEMerge.cpp -platform/graphics/filters/FEMorphology.cpp +platform/graphics/filters/FEMorphology.cpp @no-unify // FIXME: Unified sources for FEMorphology.cpp seems to break the windows build. https://bugs.webkit.org/show_bug.cgi?id=178847 platform/graphics/filters/FEOffset.cpp platform/graphics/filters/FESpecularLighting.cpp platform/graphics/filters/FETile.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [224000] trunk/Source/WebCore
Title: [224000] trunk/Source/WebCore
Revision 224000
Author cdu...@apple.com
Date 2017-10-25 19:57:08 -0700 (Wed, 25 Oct 2017)
Log Message
messageEvent.source can also be a ServiceWorker
https://bugs.webkit.org/show_bug.cgi?id=178839
Reviewed by Brady Eidson.
messageEvent.source can also be a ServiceWorker:
- https://html.spec.whatwg.org/multipage/comms.html#messageeventsource
This enables calling postMessage() from a ServiceWorker via Bug 178794.
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::source const): Deleted.
* dom/MessageEvent.h:
* dom/MessageEvent.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MessageEvent.cpp
trunk/Source/WebCore/dom/MessageEvent.h
trunk/Source/WebCore/dom/MessageEvent.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (223999 => 224000)
--- trunk/Source/WebCore/ChangeLog 2017-10-26 00:30:03 UTC (rev 223999)
+++ trunk/Source/WebCore/ChangeLog 2017-10-26 02:57:08 UTC (rev 224000)
@@ -1,3 +1,20 @@
+2017-10-25 Chris Dumez
+
+messageEvent.source can also be a ServiceWorker
+https://bugs.webkit.org/show_bug.cgi?id=178839
+
+Reviewed by Brady Eidson.
+
+messageEvent.source can also be a ServiceWorker:
+- https://html.spec.whatwg.org/multipage/comms.html#messageeventsource
+
+This enables calling postMessage() from a ServiceWorker via Bug 178794.
+
+* dom/MessageEvent.cpp:
+(WebCore::MessageEvent::source const): Deleted.
+* dom/MessageEvent.h:
+* dom/MessageEvent.idl:
+
2017-10-25 Ryosuke Niwa
Style::Scope::flushPendingUpdate() can replace the entire document in XSLTProcessor::createDocumentFromSource
Modified: trunk/Source/WebCore/dom/MessageEvent.cpp (223999 => 224000)
--- trunk/Source/WebCore/dom/MessageEvent.cpp 2017-10-26 00:30:03 UTC (rev 223999)
+++ trunk/Source/WebCore/dom/MessageEvent.cpp 2017-10-26 02:57:08 UTC (rev 224000)
@@ -150,17 +150,6 @@
m_ports = WTFMove(ports);
}
-EventTarget* MessageEvent::source() const
-{
-if (!m_source)
-return nullptr;
-
-return WTF::switchOn(m_source.value(),
-[] (const RefPtr& window) -> EventTarget* { return const_cast(window.get()); },
-[] (const RefPtr& messagePort) -> EventTarget* { return const_cast(messagePort.get()); }
-);
-}
-
RefPtr MessageEvent::trySerializeData(ExecState* exec)
{
ASSERT(!m_dataAsScriptValue.hasNoValue());
Modified: trunk/Source/WebCore/dom/MessageEvent.h (223999 => 224000)
--- trunk/Source/WebCore/dom/MessageEvent.h 2017-10-26 00:30:03 UTC (rev 223999)
+++ trunk/Source/WebCore/dom/MessageEvent.h 2017-10-26 02:57:08 UTC (rev 224000)
@@ -31,6 +31,7 @@
#include "Event.h"
#include "MessagePort.h"
#include "SerializedScriptValue.h"
+#include "ServiceWorker.h"
#include
#include
@@ -38,7 +39,11 @@
class Blob;
+#if ENABLE(SERVICE_WORKER)
+using MessageEventSource = Variant, RefPtr, RefPtr>;
+#else
using MessageEventSource = Variant, RefPtr>;
+#endif
class MessageEvent final : public Event {
public:
@@ -64,7 +69,7 @@
const String& origin() const { return m_origin; }
const String& lastEventId() const { return m_lastEventId; }
-EventTarget* source() const;
+const std::optional& source() const { return m_source; }
const Vector>& ports() const { return m_ports; }
// FIXME: Remove this when we have custom ObjC binding support.
Modified: trunk/Source/WebCore/dom/MessageEvent.idl (223999 => 224000)
--- trunk/Source/WebCore/dom/MessageEvent.idl 2017-10-26 00:30:03 UTC (rev 223999)
+++ trunk/Source/WebCore/dom/MessageEvent.idl 2017-10-26 02:57:08 UTC (rev 224000)
@@ -26,6 +26,12 @@
*
*/
+#if defined(ENABLE_SERVICE_WORKER) && ENABLE_SERVICE_WORKER
+typedef (DOMWindow or MessagePort or ServiceWorker) MessageEventSource;
+#else
+typedef (DOMWindow or MessagePort) MessageEventSource;
+#endif
+
[
Constructor(DOMString type, optional MessageEventInit eventInitDict),
ConstructorCallWith=ScriptState,
@@ -33,12 +39,12 @@
] interface MessageEvent : Event {
readonly attribute USVString origin;
readonly attribute DOMString lastEventId;
-readonly attribute EventTarget? source;
+readonly attribute MessageEventSource? source;
[CachedAttribute, CustomGetter] readonly attribute any data;
readonly attribute FrozenArray ports;
[CallWith=ScriptState] void initMessageEvent(DOMString type, optional boolean bubbles = false, optional boolean cancelable = false,
-optional any data = "" optional USVString originArg = "", optional DOMString lastEventId = "", optional (DOMWindow or MessagePort)? source = null,
+optional any data = "" optional USVString originArg = "", optional DOMString lastEventId = "", optional MessageEventSource? source = null,
optional sequence messagePorts = []);
};
@@ -46,6 +52,6 @@
any data = ""
USVString origin = "";
DOMString lastEventId = "";
- (DOMWindow or MessagePort)? so
[webkit-changes] [223999] trunk/Source/WebCore
Title: [223999] trunk/Source/WebCore Revision 223999 Author rn...@webkit.org Date 2017-10-25 17:30:03 -0700 (Wed, 25 Oct 2017) Log Message Style::Scope::flushPendingUpdate() can replace the entire document in XSLTProcessor::createDocumentFromSource https://bugs.webkit.org/show_bug.cgi?id=178715 Reviewed by Brent Fulgham. Apply XLS tranforms when a 0s timer fires or the document finishes parsing or loading whichever comes first instead of in the middle of collecting a list of stylesheets. * dom/Document.cpp: (WebCore::Document::Document): Initialize the newly added timer. (WebCore::Document::implicitClose): Apply any pending XSLT before we fire load events since some of the event handlers may be expecting to see the document after XSLT had been applied. (WebCore::Document::scheduleToApplyXSLTransforms): Added. (WebCore::Document::applyPendingXSLTransformsNowIfScheduled): Added. (WebCore::Document::applyPendingXSLTransformsTimerFired): Added. Moved the logic to apply XSL transforms from Style::Scope::collectActiveStyleSheets, and merged applyXSLTransform into this function. (WebCore::Document::applyXSLTransform): Deleted. (WebCore::Document::finishedParsing): Apply XSLT right before updating the style. This is where used to apply inline XSLT and it happens much earlier than implicitClose. * dom/Document.h: * dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Schedule XSLT in the document instead of flushing pending stylesheets, which would have synchronously applied XSLT. We can't apply XSLT synchronously here because this function can be called from a non-script-resilient call stack. (WebCore::ProcessingInstruction::sheetLoaded): Ditto. * style/StyleScope.cpp: (WebCore::Style::Scope::collectXSLTransforms): Added. (WebCore::Style::Scope::collectActiveStyleSheets): Removed the code to apply XSLT. Skip ProcessingInstructions that applies XSLT. Also use RefPtr instead of a raw pointer to store StyleSheet. * style/StyleScope.h: * xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::doEnd): Apply any pending XSLTs synchronously here as the comment suggests. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/ProcessingInstruction.cpp trunk/Source/WebCore/style/StyleScope.cpp trunk/Source/WebCore/style/StyleScope.h trunk/Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (223998 => 223999) --- trunk/Source/WebCore/ChangeLog 2017-10-25 23:50:11 UTC (rev 223998) +++ trunk/Source/WebCore/ChangeLog 2017-10-26 00:30:03 UTC (rev 223999) @@ -1,3 +1,39 @@ +2017-10-25 Ryosuke Niwa + +Style::Scope::flushPendingUpdate() can replace the entire document in XSLTProcessor::createDocumentFromSource +https://bugs.webkit.org/show_bug.cgi?id=178715 + + +Reviewed by Brent Fulgham. + +Apply XLS tranforms when a 0s timer fires or the document finishes parsing or loading whichever comes first +instead of in the middle of collecting a list of stylesheets. + +* dom/Document.cpp: +(WebCore::Document::Document): Initialize the newly added timer. +(WebCore::Document::implicitClose): Apply any pending XSLT before we fire load events since some of the event +handlers may be expecting to see the document after XSLT had been applied. +(WebCore::Document::scheduleToApplyXSLTransforms): Added. +(WebCore::Document::applyPendingXSLTransformsNowIfScheduled): Added. +(WebCore::Document::applyPendingXSLTransformsTimerFired): Added. Moved the logic to apply XSL transforms from +Style::Scope::collectActiveStyleSheets, and merged applyXSLTransform into this function. +(WebCore::Document::applyXSLTransform): Deleted. +(WebCore::Document::finishedParsing): Apply XSLT right before updating the style. This is where used to apply +inline XSLT and it happens much earlier than implicitClose. +* dom/Document.h: +* dom/ProcessingInstruction.cpp: +(WebCore::ProcessingInstruction::checkStyleSheet): Schedule XSLT in the document instead of flushing pending +stylesheets, which would have synchronously applied XSLT. We can't apply XSLT synchronously here because this +function can be called from a non-script-resilient call stack. +(WebCore::ProcessingInstruction::sheetLoaded): Ditto. +* style/StyleScope.cpp: +(WebCore::Style::Scope::collectXSLTransforms): Added. +(WebCore::Style::Scope::collectActiveStyleSheets): Removed the code to apply XSLT. Skip ProcessingInstructions +that applies XSLT. Also use RefPtr instead of a raw pointer to store StyleSheet. +* style/StyleScope.h: +* xml/parser/XMLDocumentParserLibxml2.cpp: +(WebCore::XMLDocumentParser::doEnd): Apply any pending XSLTs synchronously here as the comment suggests.
[webkit-changes] [223995] trunk/Source/WebCore
Title: [223995] trunk/Source/WebCore
Revision 223995
Author commit-qu...@webkit.org
Date 2017-10-25 16:39:09 -0700 (Wed, 25 Oct 2017)
Log Message
[Curl] Delete temporally downloaded file when it cancelled
https://bugs.webkit.org/show_bug.cgi?id=134393
Patch by Basuke Suzuki on 2017-10-25
Reviewed by Alex Christensen.
* platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::didCancelTransfer):
(WebCore::CurlRequest::writeDataToDownloadFileIfEnabled):
(WebCore::CurlRequest::closeDownloadFile):
(WebCore::CurlRequest::cleanupDownloadFile):
* platform/network/curl/CurlRequest.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
trunk/Source/WebCore/platform/network/curl/CurlRequest.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (223994 => 223995)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 23:32:49 UTC (rev 223994)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 23:39:09 UTC (rev 223995)
@@ -1,3 +1,17 @@
+2017-10-25 Basuke Suzuki
+
+[Curl] Delete temporally downloaded file when it cancelled
+https://bugs.webkit.org/show_bug.cgi?id=134393
+
+Reviewed by Alex Christensen.
+
+* platform/network/curl/CurlRequest.cpp:
+(WebCore::CurlRequest::didCancelTransfer):
+(WebCore::CurlRequest::writeDataToDownloadFileIfEnabled):
+(WebCore::CurlRequest::closeDownloadFile):
+(WebCore::CurlRequest::cleanupDownloadFile):
+* platform/network/curl/CurlRequest.h:
+
2017-10-25 Youenn Fablet
Add service worker handle fetch support for all subresource requests
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (223994 => 223995)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2017-10-25 23:32:49 UTC (rev 223994)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp 2017-10-25 23:39:09 UTC (rev 223995)
@@ -377,6 +377,7 @@
void CurlRequest::didCancelTransfer()
{
finalizeTransfer();
+cleanupDownloadFile();
}
void CurlRequest::finalizeTransfer()
@@ -610,13 +611,15 @@
void CurlRequest::writeDataToDownloadFileIfEnabled(const SharedBuffer& buffer)
{
-LockHolder locker(m_downloadMutex);
+{
+LockHolder locker(m_downloadMutex);
-if (!m_isEnabledDownloadToFile)
-return;
+if (!m_isEnabledDownloadToFile)
+return;
-if (m_downloadFilePath.isEmpty())
-m_downloadFilePath = openTemporaryFile("download", m_downloadFileHandle);
+if (m_downloadFilePath.isEmpty())
+m_downloadFilePath = openTemporaryFile("download", m_downloadFileHandle);
+}
if (m_downloadFileHandle != invalidPlatformFileHandle)
writeToFile(m_downloadFileHandle, buffer.data(), buffer.size());
@@ -629,10 +632,20 @@
if (m_downloadFileHandle == invalidPlatformFileHandle)
return;
-WebCore::closeFile(m_downloadFileHandle);
+closeFile(m_downloadFileHandle);
m_downloadFileHandle = invalidPlatformFileHandle;
}
+void CurlRequest::cleanupDownloadFile()
+{
+LockHolder locker(m_downloadMutex);
+
+if (!m_downloadFilePath.isEmpty()) {
+deleteFile(m_downloadFilePath);
+m_downloadFilePath = String();
+}
+}
+
CURLcode CurlRequest::willSetupSslCtxCallback(CURL*, void* sslCtx, void* userData)
{
return static_cast(userData)->willSetupSslCtx(sslCtx);
Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.h (223994 => 223995)
--- trunk/Source/WebCore/platform/network/curl/CurlRequest.h 2017-10-25 23:32:49 UTC (rev 223994)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.h 2017-10-25 23:39:09 UTC (rev 223995)
@@ -117,6 +117,7 @@
// Download
void writeDataToDownloadFileIfEnabled(const SharedBuffer&);
void closeDownloadFile();
+void cleanupDownloadFile();
// Callback functions for curl
static CURLcode willSetupSslCtxCallback(CURL*, void*, void*);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223994] trunk
Title: [223994] trunk Revision 223994 Author commit-qu...@webkit.org Date 2017-10-25 16:32:49 -0700 (Wed, 25 Oct 2017) Log Message Add service worker handle fetch support for all subresource requests https://bugs.webkit.org/show_bug.cgi?id=178769 Patch by Youenn Fablet on 2017-10-25 Reviewed by Chris Dumez. Source/WebCore: Test: http/tests/workers/service/image-fetch.https.html Moving DocumentThreadableLoader logic to CachedResourceLoader to apply it for all resource loads. Setting the selected service worker identifier for subresource only at the moment. Testing is limited to images, future wpt tests should cover other subresource cases. * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::prepareFetch): * loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::setSelectedServiceWorkerIdentifierIfNeeded): * loader/cache/CachedResourceRequest.h: LayoutTests: * http/tests/workers/service/image-fetch.https-expected.txt: Added. * http/tests/workers/service/image-fetch.https.html: Added. * http/tests/workers/service/resources/image-fetch-worker.js: Added. (event.event.request.url.indexOf): (event.event.request.url.endsWith): * http/tests/workers/service/resources/image-fetch.js: Added. (done): (async.loadedImage): (async.erroredImage): (async.logStatus): (async.test): Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp trunk/Source/WebCore/loader/cache/CachedResourceRequest.h trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp Added Paths trunk/LayoutTests/http/tests/workers/service/image-fetch.https-expected.txt trunk/LayoutTests/http/tests/workers/service/image-fetch.https.html trunk/LayoutTests/http/tests/workers/service/resources/image-fetch-worker.js trunk/LayoutTests/http/tests/workers/service/resources/image-fetch.js Diff Modified: trunk/LayoutTests/ChangeLog (223993 => 223994) --- trunk/LayoutTests/ChangeLog 2017-10-25 23:24:15 UTC (rev 223993) +++ trunk/LayoutTests/ChangeLog 2017-10-25 23:32:49 UTC (rev 223994) @@ -1,3 +1,22 @@ +2017-10-25 Youenn Fablet + +Add service worker handle fetch support for all subresource requests +https://bugs.webkit.org/show_bug.cgi?id=178769 + +Reviewed by Chris Dumez. + +* http/tests/workers/service/image-fetch.https-expected.txt: Added. +* http/tests/workers/service/image-fetch.https.html: Added. +* http/tests/workers/service/resources/image-fetch-worker.js: Added. +(event.event.request.url.indexOf): +(event.event.request.url.endsWith): +* http/tests/workers/service/resources/image-fetch.js: Added. +(done): +(async.loadedImage): +(async.erroredImage): +(async.logStatus): +(async.test): + 2017-10-25 Simon Fraser Aliasing of text in CSS specs is blocky and ugly Added: trunk/LayoutTests/http/tests/workers/service/image-fetch.https-expected.txt (0 => 223994) --- trunk/LayoutTests/http/tests/workers/service/image-fetch.https-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/workers/service/image-fetch.https-expected.txt 2017-10-25 23:32:49 UTC (rev 223994) @@ -0,0 +1,6 @@ + +Status is no status +Status is https://127.0.0.1:8443/resources/square100.png +PASS: Loaded image +Image size: 100x100 + Added: trunk/LayoutTests/http/tests/workers/service/image-fetch.https.html (0 => 223994) --- trunk/LayoutTests/http/tests/workers/service/image-fetch.https.html (rev 0) +++ trunk/LayoutTests/http/tests/workers/service/image-fetch.https.html 2017-10-25 23:32:49 UTC (rev 223994) @@ -0,0 +1,9 @@ + + +
[webkit-changes] [223993] trunk/Source/WebKit
Title: [223993] trunk/Source/WebKit Revision 223993 Author pvol...@apple.com Date 2017-10-25 16:24:15 -0700 (Wed, 25 Oct 2017) Log Message Network process crash under WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge. https://bugs.webkit.org/show_bug.cgi?id=160234 rdar://problem/30675510 Reviewed by Geoffrey Garen. An exception is raised because we call the method rejectProtectionSpaceAndContinueWithChallenge on the CFNetwork challenge sender, which does not implement this optional method. The methods on the authentication challenge sender are deprecated when network session is used, so we should not call them in that case. * Shared/Authentication/AuthenticationManager.cpp: (WebKit::AuthenticationManager::useCredentialForSingleChallenge): (WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge): (WebKit::AuthenticationManager::cancelSingleChallenge): (WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge): (WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge): * Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: (WebKit::AuthenticationManager::receivedCredential): (WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential): (WebKit::AuthenticationManager::receivedCancellation): (WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling): (WebKit::AuthenticationManager::receivedChallengeRejection): * Shared/Authentication/soup/AuthenticationManagerSoup.cpp: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.cpp trunk/Source/WebKit/Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm trunk/Source/WebKit/Shared/Authentication/soup/AuthenticationManagerSoup.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (223992 => 223993) --- trunk/Source/WebKit/ChangeLog 2017-10-25 23:21:38 UTC (rev 223992) +++ trunk/Source/WebKit/ChangeLog 2017-10-25 23:24:15 UTC (rev 223993) @@ -1,3 +1,29 @@ +2017-10-25 Per Arne Vollan + +Network process crash under WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge. +https://bugs.webkit.org/show_bug.cgi?id=160234 +rdar://problem/30675510 + +Reviewed by Geoffrey Garen. + +An exception is raised because we call the method rejectProtectionSpaceAndContinueWithChallenge on the CFNetwork +challenge sender, which does not implement this optional method. The methods on the authentication challenge +sender are deprecated when network session is used, so we should not call them in that case. + +* Shared/Authentication/AuthenticationManager.cpp: +(WebKit::AuthenticationManager::useCredentialForSingleChallenge): +(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge): +(WebKit::AuthenticationManager::cancelSingleChallenge): +(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge): +(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge): +* Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: +(WebKit::AuthenticationManager::receivedCredential): +(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential): +(WebKit::AuthenticationManager::receivedCancellation): +(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling): +(WebKit::AuthenticationManager::receivedChallengeRejection): +* Shared/Authentication/soup/AuthenticationManagerSoup.cpp: + 2017-10-25 Youenn Fablet Move DNS resolution outside of NetworkRTCProvider Modified: trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.cpp (223992 => 223993) --- trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.cpp 2017-10-25 23:21:38 UTC (rev 223992) +++ trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.cpp 2017-10-25 23:24:15 UTC (rev 223993) @@ -226,12 +226,15 @@ completionHandler(AuthenticationChallengeDisposition::UseCredential, credential); return; } +ASSERT(coreClient); #endif if (coreClient) coreClient->receivedCredential(challenge.challenge, credential); +#if !USE(CFURLCONNECTION) && !USE(NETWORK_SESSION) else receivedCredential(challenge.challenge, credential); +#endif } void AuthenticationManager::continueWithoutCredentialForChallenge(uint64_t challengeID) @@ -254,12 +257,15 @@ challenge.completionHandler(AuthenticationChallengeDisposition::UseCredential, Credential()); return; } +ASSERT(coreClient); #endif if (coreClient) coreClient->receivedRequestToContinueWithoutCredential(challenge.challenge); +#if !USE(CFURLCONNECTION) && !USE(NETWORK_SESSION) else receivedRequestToContinueWithoutCredential(challenge.challenge); +#endif } void AuthenticationManager::can
[webkit-changes] [223992] trunk
Title: [223992] trunk
Revision 223992
Author simon.fra...@apple.com
Date 2017-10-25 16:21:38 -0700 (Wed, 25 Oct 2017)
Log Message
Aliasing of text in CSS specs is blocky and ugly
https://bugs.webkit.org/show_bug.cgi?id=174946
Source/WebCore:
rdar://problem/33594542
Reviewed by Dean Jackson.
The PaintedContentRequest relating to subpixel-antialiased text was failing to be
satisfied if the text content in a composited layer was nested inside descendant
RenderLayers, because RenderLayer::isVisuallyNonEmpty() returned early. If this
function is passed a request, we can't return until we've satisfied the request
(which triggers the checking of descendant layers).
Test: compositing/contents-format/subpixel-antialiased-nested-layer.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
LayoutTests:
Reviewed by Dean Jackson.
* compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt: Added.
* compositing/contents-format/subpixel-antialiased-nested-layer.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt
trunk/LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer.html
trunk/LayoutTests/platform/ios/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (223991 => 223992)
--- trunk/LayoutTests/ChangeLog 2017-10-25 23:13:19 UTC (rev 223991)
+++ trunk/LayoutTests/ChangeLog 2017-10-25 23:21:38 UTC (rev 223992)
@@ -1,5 +1,15 @@
2017-10-25 Simon Fraser
+Aliasing of text in CSS specs is blocky and ugly
+https://bugs.webkit.org/show_bug.cgi?id=174946
+
+Reviewed by Dean Jackson.
+
+* compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt: Added.
+* compositing/contents-format/subpixel-antialiased-nested-layer.html: Added.
+
+2017-10-25 Simon Fraser
+
When navigating back to a page, compositing layers may not use accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=178749
rdar://problem/35158946
Added: trunk/LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt (0 => 223992)
--- trunk/LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt 2017-10-25 23:21:38 UTC (rev 223992)
@@ -0,0 +1,20 @@
+This layer should get smoothing.
+(GraphicsLayer
+ (anchor 0.00 0.00)
+ (bounds 800.00 600.00)
+ (children 1
+(GraphicsLayer
+ (bounds 800.00 600.00)
+ (contentsOpaque 1)
+ (children 1
+(GraphicsLayer
+ (position 12.00 4.00)
+ (bounds 162.00 162.00)
+ (supports subpixel antialiased text 1)
+ (drawsContent 1)
+)
+ )
+)
+ )
+)
+
Added: trunk/LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer.html (0 => 223992)
--- trunk/LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer.html (rev 0)
+++ trunk/LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer.html 2017-10-25 23:21:38 UTC (rev 223992)
@@ -0,0 +1,56 @@
+
+
+
+
+
+.container {
+height: 150px;
+width: 150px;
+position: relative;
+border: 1px solid black;
+padding: 20px;
+margin: 10px;
+box-sizing: border-box;
+box-shadow: 0 0 4px rgba(0, 0, 0, 0.2);
+}
+
+
+.composited {
+will-change: transform;
+}
+
+.positioned {
+position: absolute;
+border: 1px solid rgba(0, 0, 0, 0.5);
+}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+if (window.internals) {
+internals.setFontSmoothingEnabled(true);
+internals.settings.setSubpixelAntialiasedLayerTextEnabled(true)
+}
+
+function doTest()
+{
+
+if (window.internals)
+document.getElementById('layers').innerText = internals.layerTreeAsText(document);
+}
+
+window.addEventListener('load', doTest, false);
+
+
+
+
+
+
+This layer should get smoothing.
+
+
+
+
+
+
Added: trunk/LayoutTests/platform/ios/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt (0 => 223992)
--- trunk/LayoutTests/platform/ios/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/ios/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt 2017-10-25 23:21:38 UTC (rev 223992)
@@ -0,0 +1,19 @@
+This l
[webkit-changes] [223990] trunk/Source/WebKit
Title: [223990] trunk/Source/WebKit
Revision 223990
Author commit-qu...@webkit.org
Date 2017-10-25 15:27:06 -0700 (Wed, 25 Oct 2017)
Log Message
Move DNS resolution outside of NetworkRTCProvider
https://bugs.webkit.org/show_bug.cgi?id=178796
Patch by Youenn Fablet on 2017-10-25
Reviewed by Geoffrey Garen.
Tested through manual testing on external STUN servers.
Moving NetworkRTCProvider::Resolver into NetworkRTCResolver.
Updating the implementation to use a completion handler.
* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createResolver):
* NetworkProcess/webrtc/NetworkRTCProvider.h:
* NetworkProcess/webrtc/NetworkRTCResolver.cpp:
(WebKit::NetworkRTCResolver::NetworkRTCResolver):
(WebKit::NetworkRTCResolver::~NetworkRTCResolver):
(WebKit::NetworkRTCResolver::start):
(WebKit::NetworkRTCResolver::stop):
(WebKit::NetworkRTCResolver::completed):
(WebKit::NetworkRTCProvider::Resolver::~Resolver): Deleted.
(WebKit::NetworkRTCProvider::stop): Deleted.
(WebKit::NetworkRTCProvider::resolutionCompleted): Deleted.
* NetworkProcess/webrtc/NetworkRTCResolver.h:
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Added Paths
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolver.cpp
trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCResolver.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (223989 => 223990)
--- trunk/Source/WebKit/ChangeLog 2017-10-25 22:15:39 UTC (rev 223989)
+++ trunk/Source/WebKit/ChangeLog 2017-10-25 22:27:06 UTC (rev 223990)
@@ -1,3 +1,29 @@
+2017-10-25 Youenn Fablet
+
+Move DNS resolution outside of NetworkRTCProvider
+https://bugs.webkit.org/show_bug.cgi?id=178796
+
+Reviewed by Geoffrey Garen.
+
+ Tested through manual testing on external STUN servers.
+ Moving NetworkRTCProvider::Resolver into NetworkRTCResolver.
+ Updating the implementation to use a completion handler.
+
+* NetworkProcess/webrtc/NetworkRTCProvider.cpp:
+(WebKit::NetworkRTCProvider::createResolver):
+* NetworkProcess/webrtc/NetworkRTCProvider.h:
+* NetworkProcess/webrtc/NetworkRTCResolver.cpp:
+(WebKit::NetworkRTCResolver::NetworkRTCResolver):
+(WebKit::NetworkRTCResolver::~NetworkRTCResolver):
+(WebKit::NetworkRTCResolver::start):
+(WebKit::NetworkRTCResolver::stop):
+(WebKit::NetworkRTCResolver::completed):
+(WebKit::NetworkRTCProvider::Resolver::~Resolver): Deleted.
+(WebKit::NetworkRTCProvider::stop): Deleted.
+(WebKit::NetworkRTCProvider::resolutionCompleted): Deleted.
+* NetworkProcess/webrtc/NetworkRTCResolver.h:
+* WebKit.xcodeproj/project.pbxproj:
+
2017-10-25 Eric Carlson
[MediaStream] Clear cached gUM prompt state
Modified: trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp (223989 => 223990)
--- trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2017-10-25 22:15:39 UTC (rev 223989)
+++ trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp 2017-10-25 22:27:06 UTC (rev 223990)
@@ -31,6 +31,7 @@
#include "Logging.h"
#include "NetworkConnectionToWebProcess.h"
#include "NetworkProcess.h"
+#include "NetworkRTCResolver.h"
#include "NetworkRTCSocket.h"
#include "WebRTCResolverMessages.h"
#include "WebRTCSocketMessages.h"
@@ -163,62 +164,24 @@
void NetworkRTCProvider::createResolver(uint64_t identifier, const String& address)
{
-auto resolver = std::make_unique(identifier, *this, adoptCF(CFHostCreateWithName(kCFAllocatorDefault, address.createCFString().get(;
-
-CFHostClientContext context = { 0, resolver.get(), nullptr, nullptr, nullptr };
-CFHostSetClient(resolver->host.get(), NetworkRTCProvider::resolvedName, &context);
-CFHostScheduleWithRunLoop(resolver->host.get(), CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
-Boolean result = CFHostStartInfoResolution(resolver->host.get(), kCFHostAddresses, nullptr);
-ASSERT_UNUSED(result, result);
-
+auto resolver = std::make_unique([this, identifier](NetworkRTCResolver::AddressesOrError&& result) mutable {
+if (!result.hasValue()) {
+if (result.error() != NetworkRTCResolver::Error::Cancelled)
+m_connection->connection().send(Messages::WebRTCResolver::ResolvedAddressError(1), identifier);
+return;
+}
+m_connection->connection().send(Messages::WebRTCResolver::SetResolvedAddress(result.value()), identifier);
+});
+resolver->start(address);
m_resolvers.add(identifier, WTFMove(resolver));
}
-NetworkRTCProvider::Resolver::~Resolver()
-{
-CFHostUnscheduleFromRunLoop(host.get(), CFRunLoopGetCurrent(), kCFRunLoopDefaultMode);
-CFHostSetClient(host.get(), nullptr, n
[webkit-changes] [223989] trunk
Title: [223989] trunk
Revision 223989
Author commit-qu...@webkit.org
Date 2017-10-25 15:15:39 -0700 (Wed, 25 Oct 2017)
Log Message
Unreviewed, rolling out r223691 and r223729.
https://bugs.webkit.org/show_bug.cgi?id=178834
Broke Speedometer 2 React-Redux-TodoMVC test case (Requested
by rniwa on #webkit).
Reverted changesets:
"Turn recursive tail calls into loops"
https://bugs.webkit.org/show_bug.cgi?id=176601
https://trac.webkit.org/changeset/223691
"REGRESSION(r223691): DFGByteCodeParser.cpp:1483:83: warning:
comparison is always false due to limited range of data type
[-Wtype-limits]"
https://bugs.webkit.org/show_bug.cgi?id=178543
https://trac.webkit.org/changeset/223729
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecode/PreciseJumpTargets.cpp
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
Removed Paths
trunk/JSTests/stress/inline-call-to-recursive-tail-call.js
Diff
Modified: trunk/JSTests/ChangeLog (223988 => 223989)
--- trunk/JSTests/ChangeLog 2017-10-25 22:15:05 UTC (rev 223988)
+++ trunk/JSTests/ChangeLog 2017-10-25 22:15:39 UTC (rev 223989)
@@ -1,3 +1,23 @@
+2017-10-25 Commit Queue
+
+Unreviewed, rolling out r223691 and r223729.
+https://bugs.webkit.org/show_bug.cgi?id=178834
+
+Broke Speedometer 2 React-Redux-TodoMVC test case (Requested
+by rniwa on #webkit).
+
+Reverted changesets:
+
+"Turn recursive tail calls into loops"
+https://bugs.webkit.org/show_bug.cgi?id=176601
+https://trac.webkit.org/changeset/223691
+
+"REGRESSION(r223691): DFGByteCodeParser.cpp:1483:83: warning:
+comparison is always false due to limited range of data type
+[-Wtype-limits]"
+https://bugs.webkit.org/show_bug.cgi?id=178543
+https://trac.webkit.org/changeset/223729
+
2017-10-25 Ryan Haddad
Mark test262.yaml/test262/test/language/statements/try/tco-catch.js as passing.
Deleted: trunk/JSTests/stress/inline-call-to-recursive-tail-call.js (223988 => 223989)
--- trunk/JSTests/stress/inline-call-to-recursive-tail-call.js 2017-10-25 22:15:05 UTC (rev 223988)
+++ trunk/JSTests/stress/inline-call-to-recursive-tail-call.js 2017-10-25 22:15:39 UTC (rev 223989)
@@ -1,94 +0,0 @@
-"use strict";
-
-// factorial calls aux that tail-calls back into factorial.
-// It is not OK to turn that tail call into a jump back to the top of the function, because the call to aux is not a tail call.
-function factorial(n) {
-function aux(n) {
-if (n == 1)
-return 1;
-return factorial(n - 1);
-}
-
-return n * aux(n);
-}
-
-// Same, but this time with an irrelevant tail call in factorial.
-// This exercises a different code path because the recursive tail call optimization aborts early if the op_enter block is not split, and it is split by the detection of a tail call.
-function factorial2(n) {
-function aux2(n) {
-if (n == 1)
-return 1;
-return factorial2(n - 1);
-}
-function id(n) {
-return n;
-}
-
-return id(n * aux2(n));
-}
-
-// This time, aux is tail-calling itself: the optimization is valid but must jump to the start of aux3, not of factorial3.
-function factorial3(n) {
-function aux3(n, acc) {
-if (n == 1)
-return acc;
-return aux3 (n-1, n*acc);
-}
-
-return n * aux3(n-1, 1);
-}
-
-// In this case, it is valid to jump all the way to the top of factorial4, because all calls are tail calls.
-function factorial4(n, acc) {
-function aux4(n, acc) {
-if (n == 1)
-return acc;
-return factorial4(n-1, n*acc);
-}
-
-if (acc)
-return aux4(n, acc);
-return aux4(n, 1);
-}
-
-// This function is used to test that recursing with a different number of arguments doesn't mess up with the stack.
-// The first two tail calls should be optimized, but not the last one (no place on the stack for the third argument).
-function foo(a, b) {
-if (a == 0)
-return 42;
-if (a == 1)
-return foo(a - 1);
-if (a == 2)
-return foo(b - 1, a);
-return foo (b - 1, a, 43);
-}
-
-// Same deal as foo, just with an inlining thrown into the mix.
-// Even the first tail call should not be optimized in this case, for subtle reasons.
-function bar(x, y) {
-function auxBar(a, b) {
-if (a == 0)
-return 42;
-if (a == 1)
-return foo(a - 1);
-if (a == 2)
-return foo(b - 1, a);
-return foo (b - 1, a, 43);
-}
-
-return auxBar(x, y);
-}
-
-function test(result, expected, name) {
-if (result != expected)
-throw "Wrong result for "
[webkit-changes] [223988] trunk
Title: [223988] trunk Revision 223988 Author eric.carl...@apple.com Date 2017-10-25 15:15:05 -0700 (Wed, 25 Oct 2017) Log Message [MediaStream] Clear cached gUM prompt state https://bugs.webkit.org/show_bug.cgi?id=178754 Reviewed by Youenn Fablet. Source/WebKit: * Shared/WebPreferences.yaml: Define new settings. * Shared/WebPreferencesDefinitionsBase.h: New default values. * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetInactiveMediaCaptureSteamRepromptIntervalInMinutes): New. (WKPreferencesGetInactiveMediaCaptureSteamRepromptIntervalInMinutes): Ditto. * UIProcess/API/C/WKPreferencesRefPrivate.h: * UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _inactiveMediaCaptureSteamRepromptIntervalInMinutes]): Ditto. (-[WKPreferences _setInactiveMediaCaptureSteamRepromptIntervalInMinutes:]): Ditto. * UIProcess/API/Cocoa/WKPreferencesPrivate.h: * UIProcess/UserMediaPermissionRequestManagerProxy.cpp: (WebKit::UserMediaPermissionRequestManagerProxy::UserMediaPermissionRequestManagerProxy): Initialize the timer. (WebKit::UserMediaPermissionRequestManagerProxy::createRequest): Remove unneeded namespace. (WebKit::toWebCore): Remove unneeded breaks. (WebKit::UserMediaPermissionRequestManagerProxy::searchForGrantedRequest const): Remove unneeded namespace. (WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied): Ditto. (WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Ditto. (WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Ditto. (WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Ditto. (WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const): Ditto. (WebKit::UserMediaPermissionRequestManagerProxy::captureStateChanged): Set the watchdog timer to the correct interval based on capture state. (WebKit::UserMediaPermissionRequestManagerProxy::watchdogTimerFired): Clear cached state. * UIProcess/UserMediaPermissionRequestManagerProxy.h: Tools: * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm: Added. (-[GetUserMediaRepromptUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]): (-[GetUserMediaRepromptUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]): (TestWebKitAPI::TEST): * TestWebKitAPI/Tests/WebKit/getUserMedia.html: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferences.yaml trunk/Source/WebKit/Shared/WebPreferencesDefinitionsBase.h trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj trunk/Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html Added Paths trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm Diff Modified: trunk/Source/WebKit/ChangeLog (223987 => 223988) --- trunk/Source/WebKit/ChangeLog 2017-10-25 22:06:51 UTC (rev 223987) +++ trunk/Source/WebKit/ChangeLog 2017-10-25 22:15:05 UTC (rev 223988) @@ -1,3 +1,41 @@ +2017-10-25 Eric Carlson + +[MediaStream] Clear cached gUM prompt state +https://bugs.webkit.org/show_bug.cgi?id=178754 + + +Reviewed by Youenn Fablet. + +* Shared/WebPreferences.yaml: Define new settings. + +* Shared/WebPreferencesDefinitionsBase.h: New default values. + +* UIProcess/API/C/WKPreferences.cpp: +(WKPreferencesSetInactiveMediaCaptureSteamRepromptIntervalInMinutes): New. +(WKPreferencesGetInactiveMediaCaptureSteamRepromptIntervalInMinutes): Ditto. +* UIProcess/API/C/WKPreferencesRefPrivate.h: + +* UIProcess/API/Cocoa/WKPreferences.mm: +(-[WKPreferences _inactiveMediaCaptureSteamRepromptIntervalInMinutes]): Ditto. +(-[WKPreferences _setInactiveMediaCaptureSteamRepromptIntervalInMinutes:]): Ditto. +* UIProcess/API/Cocoa/WKPreferencesPrivate.h: + +* UIProcess/UserMediaPermissionRequestManagerProxy.cpp: +(WebKit::UserMediaPermissionRequestManagerProxy::UserMediaPermissionRequestManagerProxy): Initialize +the timer. +(WebKit::UserMediaPermissionRequestManagerProxy::createRequest): Remove unneeded namespace. +(WebKit::toWebCore): Remove unneeded breaks. +(WebKit::UserMediaPermissionRequestManagerProxy::searchForGrantedRequest const): Remove unneeded namespace. +(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied): Ditto. +(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Ditto. +(WebKit::User
[webkit-changes] [223986] trunk/Source/WebCore
Title: [223986] trunk/Source/WebCore Revision 223986 Author cdu...@apple.com Date 2017-10-25 14:47:13 -0700 (Wed, 25 Oct 2017) Log Message Unreviewed, add missing copyright header to ServiceWorkerClientType.idl. * workers/service/ServiceWorkerClientType.idl: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/ServiceWorkerClientType.idl Diff Modified: trunk/Source/WebCore/ChangeLog (223985 => 223986) --- trunk/Source/WebCore/ChangeLog 2017-10-25 21:36:39 UTC (rev 223985) +++ trunk/Source/WebCore/ChangeLog 2017-10-25 21:47:13 UTC (rev 223986) @@ -1,5 +1,11 @@ 2017-10-25 Chris Dumez +Unreviewed, add missing copyright header to ServiceWorkerClientType.idl. + +* workers/service/ServiceWorkerClientType.idl: + +2017-10-25 Chris Dumez + Make toJS() do the right thing for ServiceWorkerClient https://bugs.webkit.org/show_bug.cgi?id=178816 Modified: trunk/Source/WebCore/workers/service/ServiceWorkerClientType.idl (223985 => 223986) --- trunk/Source/WebCore/workers/service/ServiceWorkerClientType.idl 2017-10-25 21:36:39 UTC (rev 223985) +++ trunk/Source/WebCore/workers/service/ServiceWorkerClientType.idl 2017-10-25 21:47:13 UTC (rev 223986) @@ -1,3 +1,27 @@ +/* + * Copyright (C) 2017 Apple Inc. All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + *notice, this list of conditions and the following disclaimer in the + *documentation and/or other materials provided with the distribution. + * + * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS + * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF + * THE POSSIBILITY OF SUCH DAMAGE. + */ [ Conditional=SERVICE_WORKER, ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223985] trunk/Source/WebCore
Title: [223985] trunk/Source/WebCore
Revision 223985
Author cdu...@apple.com
Date 2017-10-25 14:36:39 -0700 (Wed, 25 Oct 2017)
Log Message
Make toJS() do the right thing for ServiceWorkerClient
https://bugs.webkit.org/show_bug.cgi?id=178816
Reviewed by Youenn Fablet.
Make toJS() do the right thing for ServiceWorkerClient. In particular,
it needs to construct a JSServiceWorkerWindowClient wrapper if the
implementation object is a ServiceWorkerWindowClient.
Also, ServiceWorkerClient does not need to be an ActiveDOMObject as
it does not have any long-running tasks. Make it a ContextDestructionObject
instead for now.
* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* workers/service/ServiceWorkerClient.cpp:
(WebCore::ServiceWorkerClient::postMessage):
* workers/service/ServiceWorkerClient.h:
(WebCore::ServiceWorkerClient::create):
* workers/service/ServiceWorkerClient.idl:
* workers/service/ServiceWorkerClientType.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl.
* workers/service/ServiceWorkerClientType.idl: Added.
* workers/service/ServiceWorkerClients.h:
* workers/service/ServiceWorkerClients.idl:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/workers/service/ServiceWorkerClient.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerClient.h
trunk/Source/WebCore/workers/service/ServiceWorkerClient.idl
trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerWindowClient.h
Added Paths
trunk/Source/WebCore/bindings/js/JSServiceWorkerClientCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (223984 => 223985)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 21:32:08 UTC (rev 223984)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 21:36:39 UTC (rev 223985)
@@ -1,3 +1,32 @@
+2017-10-25 Chris Dumez
+
+Make toJS() do the right thing for ServiceWorkerClient
+https://bugs.webkit.org/show_bug.cgi?id=178816
+
+Reviewed by Youenn Fablet.
+
+Make toJS() do the right thing for ServiceWorkerClient. In particular,
+it needs to construct a JSServiceWorkerWindowClient wrapper if the
+implementation object is a ServiceWorkerWindowClient.
+
+Also, ServiceWorkerClient does not need to be an ActiveDOMObject as
+it does not have any long-running tasks. Make it a ContextDestructionObject
+instead for now.
+
+* CMakeLists.txt:
+* DerivedSources.make:
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* workers/service/ServiceWorkerClient.cpp:
+(WebCore::ServiceWorkerClient::postMessage):
+* workers/service/ServiceWorkerClient.h:
+(WebCore::ServiceWorkerClient::create):
+* workers/service/ServiceWorkerClient.idl:
+* workers/service/ServiceWorkerClientType.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl.
+* workers/service/ServiceWorkerClientType.idl: Added.
+* workers/service/ServiceWorkerClients.h:
+* workers/service/ServiceWorkerClients.idl:
+
2017-10-25 Simon Fraser
When navigating back to a page, compositing layers may not use accelerated drawing
Modified: trunk/Source/WebCore/Sources.txt (223984 => 223985)
--- trunk/Source/WebCore/Sources.txt 2017-10-25 21:32:08 UTC (rev 223984)
+++ trunk/Source/WebCore/Sources.txt 2017-10-25 21:36:39 UTC (rev 223985)
@@ -403,6 +403,7 @@
bindings/js/JSReadableStreamSourceCustom.cpp
bindings/js/JSSVGPathSegCustom.cpp
bindings/js/JSStyleSheetCustom.cpp
+bindings/js/JSServiceWorkerClientCustom.cpp
bindings/js/JSTextCustom.cpp
bindings/js/JSTextTrackCueCustom.cpp
bindings/js/JSTextTrackCustom.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (223984 => 223985)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-10-25 21:32:08 UTC (rev 223984)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-10-25 21:36:39 UTC (rev 223985)
@@ -10703,6 +10703,7 @@
83EE598C1F50958B003E8B30 /* JSErrorCallback.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSErrorCallback.cpp; sourceTree = ""; };
83F570AD1C53268E007FD6CB /* JSXMLDocument.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSXMLDocument.h; sourceTree = ""; };
83F570AE1C53268E007FD6CB /* JSXMLDocument.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSXMLDocument.cpp; sourceTree = ""; };
+ 83F572941FA1066F003837BE /* JSServiceWorkerClientCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSServiceWorkerClientCustom.cpp; sourceTree = ""; };
83FB33671F508A4E00986E54 /* FileSystemFileEntry.idl */ = {isa = PBXFileReference; fil
[webkit-changes] [223984] trunk
Title: [223984] trunk Revision 223984 Author simon.fra...@apple.com Date 2017-10-25 14:32:08 -0700 (Wed, 25 Oct 2017) Log Message When navigating back to a page, compositing layers may not use accelerated drawing https://bugs.webkit.org/show_bug.cgi?id=178749 rdar://problem/35158946 Reviewed by Dean Jackson. Source/WebCore: There were two issues with setting GraphicsLayerCA's "acceleratesDrawing" state which occurred on back navigation, related to the ordering of style recalcs and layout. First, at style recalc time, we created a RenderLayerCompositor but hadn't yet called its cacheAcceleratedCompositingFlags(), so any layers created during style update didn't get accelerated drawing. Fix by making cacheAcceleratedCompositingFlags() internal to RenderLayerCompositor and calling it from willRecalcStyle() and updateCompositingLayers(). Secondly, GraphicsLayerCA::commitLayerChangesBeforeSublayers() needs to updateAcceleratesDrawing() before updating tiles, so that new tiles fetch the right acceleratesDrawing state from the TileController. Test: compositing/accelerated-layers-after-back.html * page/FrameView.cpp: (WebCore::FrameView::updateCompositingLayersAfterLayout): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): * rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::willRecalcStyle): (WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout): (WebCore::RenderLayerCompositor::updateCompositingLayers): * rendering/RenderLayerCompositor.h: Source/WebKit: Avoid assertions when a test enables accelerated drawing (which we can't support in the iOS simulator). * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::ensureBackingStore): Tools: Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options and use it to set the state of the web view. * DumpRenderTree/TestOptions.h: * DumpRenderTree/TestOptions.mm: (TestOptions::TestOptions): * DumpRenderTree/mac/DumpRenderTree.mm: (setWebPreferencesForTestOptions): * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): (WTR::updateTestOptionsFromTestHeader): * WebKitTestRunner/TestOptions.h: (WTR::TestOptions::hasSameInitializationOptions const): LayoutTests: Moved iframes/resources/page-cache-helper.html up to compositing/resources/go-back.html. * compositing/accelerated-layers-after-back-expected.txt: Added. * compositing/accelerated-layers-after-back.html: Added. * compositing/iframes/page-cache-layer-tree.html: * compositing/page-cache-back-crash.html: * compositing/resources/go-back.html: Renamed from LayoutTests/compositing/iframes/resources/page-cache-helper.html. * platform/ios/compositing/accelerated-layers-after-back-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/compositing/iframes/page-cache-layer-tree.html trunk/LayoutTests/compositing/page-cache-back-crash.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp trunk/Source/WebCore/rendering/RenderLayerCompositor.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestOptions.h trunk/Tools/DumpRenderTree/TestOptions.mm trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/WebKitTestRunner/TestController.cpp trunk/Tools/WebKitTestRunner/TestOptions.h Added Paths trunk/LayoutTests/compositing/accelerated-layers-after-back-expected.txt trunk/LayoutTests/compositing/accelerated-layers-after-back.html trunk/LayoutTests/compositing/resources/go-back.html trunk/LayoutTests/platform/ios/compositing/accelerated-layers-after-back-expected.txt Removed Paths trunk/LayoutTests/compositing/iframes/resources/page-cache-helper.html Diff Modified: trunk/LayoutTests/ChangeLog (223983 => 223984) --- trunk/LayoutTests/ChangeLog 2017-10-25 21:30:16 UTC (rev 223983) +++ trunk/LayoutTests/ChangeLog 2017-10-25 21:32:08 UTC (rev 223984) @@ -1,3 +1,20 @@ +2017-10-25 Simon Fraser + +When navigating back to a page, compositing layers may not use accelerated drawing +https://bugs.webkit.org/show_bug.cgi?id=178749 +rdar://problem/35158946 + +Reviewed by Dean Jackson. + +Moved iframes/resources/page-cache-helper.html up to compositing/resources/go-back.html. + +* compositing/accelerated-layers-after-back-expected.txt: Added. +* compositing/accelerated-layers-after-back.html: Added. +* compositing/iframes/page-cache-layer-tree.html: +* compositing/page-cache-back-crash.html: +* compositing/resources/go-back.html: Renamed from LayoutTests/compositing/iframes/resources/page-cache-helper.html. +* platform/ios/compositing/accelerated-layers-after-b
[webkit-changes] [223983] trunk/Source/WebInspectorUI
Title: [223983] trunk/Source/WebInspectorUI
Revision 223983
Author commit-qu...@webkit.org
Date 2017-10-25 14:30:16 -0700 (Wed, 25 Oct 2017)
Log Message
Web Inspector: Display fetch() initiated loads as "fetch" instead of "xhr" in the Network Tab
https://bugs.webkit.org/show_bug.cgi?id=178826
Patch by Joseph Pecoraro on 2017-10-25
Reviewed by Youenn Fablet.
* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.shortDisplayNameForResourceType):
Fetch and XHR loads are still grouped under the succinct "XHR" filter, but
at least display the better type name in the "Type" column of the table.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (223982 => 223983)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-25 21:19:19 UTC (rev 223982)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-25 21:30:16 UTC (rev 223983)
@@ -1,3 +1,15 @@
+2017-10-25 Joseph Pecoraro
+
+Web Inspector: Display fetch() initiated loads as "fetch" instead of "xhr" in the Network Tab
+https://bugs.webkit.org/show_bug.cgi?id=178826
+
+Reviewed by Youenn Fablet.
+
+* UserInterface/Views/NetworkTableContentView.js:
+(WI.NetworkTableContentView.shortDisplayNameForResourceType):
+Fetch and XHR loads are still grouped under the succinct "XHR" filter, but
+at least display the better type name in the "Type" column of the table.
+
2017-10-25 Devin Rousso
Web Inspector: Canvas Tab: selected canvas card loses selection outline style while recording
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (223982 => 223983)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2017-10-25 21:19:19 UTC (rev 223982)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js 2017-10-25 21:30:16 UTC (rev 223983)
@@ -144,8 +144,9 @@
case WI.Resource.Type.Script:
return "JS";
case WI.Resource.Type.XHR:
+return "XHR";
case WI.Resource.Type.Fetch:
-return "XHR";
+return WI.UIString("Fetch");
case WI.Resource.Type.Ping:
return WI.UIString("Ping");
case WI.Resource.Type.Beacon:
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223982] trunk/LayoutTests
Title: [223982] trunk/LayoutTests
Revision 223982
Author achristen...@apple.com
Date 2017-10-25 14:19:19 -0700 (Wed, 25 Oct 2017)
Log Message
LayoutTest http/tests/loading/basic-credentials-sent-automatically.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=159427
Reviewed by Youenn Fablet.
Use setTimeout to make load delegate callback printing more deterministic.
The important part is that the credentials are printed, and they still are.
* http/tests/loading/basic-credentials-sent-automatically-expected.txt:
* http/tests/loading/basic-credentials-sent-automatically.html:
* platform/mac/TestExpectations:
* platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt
trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (223981 => 223982)
--- trunk/LayoutTests/ChangeLog 2017-10-25 21:17:46 UTC (rev 223981)
+++ trunk/LayoutTests/ChangeLog 2017-10-25 21:19:19 UTC (rev 223982)
@@ -1,3 +1,18 @@
+2017-10-25 Alex Christensen
+
+LayoutTest http/tests/loading/basic-credentials-sent-automatically.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=159427
+
+Reviewed by Youenn Fablet.
+
+Use setTimeout to make load delegate callback printing more deterministic.
+The important part is that the credentials are printed, and they still are.
+
+* http/tests/loading/basic-credentials-sent-automatically-expected.txt:
+* http/tests/loading/basic-credentials-sent-automatically.html:
+* platform/mac/TestExpectations:
+* platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
+
2017-10-25 Youenn Fablet
Enable ServiceWorker to fetch resources
Modified: trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt (223981 => 223982)
--- trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt 2017-10-25 21:17:46 UTC (rev 223981)
+++ trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt 2017-10-25 21:19:19 UTC (rev 223982)
@@ -1,30 +1,30 @@
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - didFinishDocumentLoadForFrame
+main frame - didHandleOnloadEventsForFrame
+main frame - didFinishLoadForFrame
frame "-->" - didStartProvisionalLoadForFrame
-main frame - didHandleOnloadEventsForFrame
http://127.0.0.1:8000/loading/resources/subresources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with first:first-pw
frame "-->" - didCommitLoadForFrame
frame "-->" - didFinishDocumentLoadForFrame
-frame "-->" - didStartProvisionalLoadForFrame
frame "-->" - didHandleOnloadEventsForFrame
frame "-->" - didFinishLoadForFrame
+frame "-->" - didStartProvisionalLoadForFrame
http://127.0.0.1:8000/loading/resources/protected-resource.php - didReceiveAuthenticationChallenge - Responding with second:second-pw
frame "-->" - didCommitLoadForFrame
frame "-->" - didFinishDocumentLoadForFrame
-frame "-->" - didStartProvisionalLoadForFrame
frame "-->" - didHandleOnloadEventsForFrame
frame "-->" - didFinishLoadForFrame
+frame "-->" - didStartProvisionalLoadForFrame
frame "-->" - didCommitLoadForFrame
frame "-->" - didFinishDocumentLoadForFrame
-frame "-->" - didStartProvisionalLoadForFrame
frame "-->" - didHandleOnloadEventsForFrame
frame "-->" - didFinishLoadForFrame
+frame "-->" - didStartProvisionalLoadForFrame
frame "-->" - didCommitLoadForFrame
frame "-->" - didFinishDocumentLoadForFrame
frame "-->" - didHandleOnloadEventsForFrame
frame "-->" - didFinishLoadForFrame
-main frame - didFinishLoadForFrame
This test makes sure that once an HTTP Basic Auth. protected path is authenticated once, urls that emanate from that path automatically have their credentials sent without a challenge.
The first frame's path is /loading/resources/subresources/protected-resource.php, and we should get a challenge for it.
It will be authorized with first/first-pw.
Modified: trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html (223981 => 223982)
--- trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html 2017-10-25 21:17:46 UTC (rev 223981)
+++ trunk/LayoutTests/http/tests/loading/basic-credentials-sent-automatically.html 2017-10-25 21:19:19 UTC (rev 223982)
@@ -18,7 +18,7 @@
}
var frame = document.createElement("iframe");
frame.setAttribute("src", "http://127.0.0.1:8000/loading/resources/protected-resource.php");
-frame.setAttribute("onload", "secondFrameLoaded()");
+frame.setAttribute("onload", "setTimeou
[webkit-changes] [223981] trunk
Title: [223981] trunk Revision 223981 Author commit-qu...@webkit.org Date 2017-10-25 14:17:46 -0700 (Wed, 25 Oct 2017) Log Message Enable ServiceWorker to fetch resources https://bugs.webkit.org/show_bug.cgi?id=178673 Patch by Youenn Fablet on 2017-10-25 Reviewed by Brady Eidson. Source/WebCore: Test: http/tests/workers/service/service-worker-fetch.html Allow reusing of EmptyFrameLoaderClient for network loading in WebKit Service Worker environment. Allow overriding the creation of a document loader, pageID, frameID and sessionID getters. Allow the possibility to create synthetic documents for all ports. Beefing up ServiceWorkerThreadProxy as it owns a Document and a Page that do nothing but server the purpose of loading resources for a service worker thread. * WebCore.xcodeproj/project.pbxproj: * loader/DocumentLoader.h: (WebCore::DocumentLoader::setResponse): * loader/EmptyClients.cpp: (WebCore::EmptyFrameLoaderClient::sessionID const): (WebCore::EmptyFrameLoaderClient::createNetworkingContext): (WebCore::createEmptyFrameNetworkingContext): * loader/EmptyClients.h: * loader/EmptyFrameLoaderClient.h: Added. * loader/FrameLoader.cpp: (WebCore::FrameLoader::initForSynthesizedDocument): * loader/FrameLoader.h: * loader/FrameLoaderClient.h: * workers/service/context/ServiceWorkerThread.cpp: (WebCore::ServiceWorkerThread::ServiceWorkerThread): (WebCore::m_workerObjectProxy): * workers/service/context/ServiceWorkerThread.h: * workers/service/context/ServiceWorkerThreadProxy.cpp: (WebCore::ServiceWorkerThreadProxy::create): (WebCore::createPageForServiceWorker): (WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy): (WebCore::ServiceWorkerThreadProxy::postTaskToLoader): * workers/service/context/ServiceWorkerThreadProxy.h: Test: http/tests/workers/service/service-worker-fetch.html Source/WebKit: ServiceWorkerContextManager makes use of the new ServiceWorkerThreadProxy. It creates the necessary environment for the thread to make use of network loads, web sockets and cache storage. Fetch is functional with these changes. ServiceWorkerProcessProxy is introduced as a UIProcess proxy to the service worker process. This process proxy is responsible to give the pageID used by all service worker thread instances for network loads. ServiceWorkerContextManager is responsible to give a unique frameID for all service worker threads. This is necessary as these two ids are currently needed for any network load. ServiceWorkerThreadProxy creates its own FrameLoaderClient which is now used to get pageID, frameID and sessionID. * UIProcess/ServiceWorkerProcessProxy.cpp: Added. (WebKit::ServiceWorkerProcessProxy::ServiceWorkerProcessProxy): (WebKit::m_serviceWorkerPageID): (WebKit::ServiceWorkerProcessProxy::~ServiceWorkerProcessProxy): (WebKit::ServiceWorkerProcessProxy::start): * UIProcess/ServiceWorkerProcessProxy.h: Added. * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::getWorkerContextProcessConnection): (WebKit::WebProcessPool::createNewWebProcess): (WebKit::WebProcessPool::initializeNewWebProcess): (WebKit::WebProcessPool::disconnectProcess): (WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit): (WebKit::WebProcessPool::createWebPage): * UIProcess/WebProcessPool.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::generatePageID): * UIProcess/WebProcessProxy.h: * WebKit.xcodeproj/project.pbxproj: * WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoad): (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): (WebKit::WebLoaderStrategy::startPingLoad): * WebProcess/Network/WebLoaderStrategy.h: * WebProcess/Storage/ServiceWorkerContextManager.cpp: (WebKit::ServiceWorkerContextManager::ServiceWorkerContextManager): (WebKit::ServiceWorkerContextManager::startServiceWorker): (WebKit::ServiceWorkerContextManager::startFetch): * WebProcess/Storage/ServiceWorkerContextManager.h: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::pageID const): (WebKit::WebFrameLoaderClient::frameID const): (WebKit::WebFrameLoaderClient::sessionID const): * WebProcess/WebCoreSupport/WebFrameLoaderClient.h: * WebProcess/WebProcess.cpp: (WebKit::WebProcess::getWorkerContextConnection): * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: Source/WebKitLegacy/mac: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::pageID const): (WebFrameLoaderClient::frameID const): (WebFrameLoaderClient::sessionID const): Added implementation to the new getters. They are noop in the context of WK1. Source/WebKitLegacy/win: Added implementation to the new getters. They are noop in the context of WK1. * WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::pageID const): (WebFrameLoaderClient::frameID const): (WebFrameLoaderClient::sessionID const): * WebCoreSupport/WebFrameLoaderClient.h: LayoutTests: * http/tests/workers/service/resources/service-worker-fetch-worker.js: Added. * http/tests/w
[webkit-changes] [223980] trunk/Source/JavaScriptCore
Title: [223980] trunk/Source/_javascript_Core Revision 223980 Author msab...@apple.com Date 2017-10-25 14:12:38 -0700 (Wed, 25 Oct 2017) Log Message REGRESSION(r223937): Use of -fobjc-weak causes build failures with older compilers https://bugs.webkit.org/show_bug.cgi?id=178825 Reviewed by Mark Lam. Enable ARC for ARM64_32. This eliminate the need for setting CLANG_ENABLE_OBJC_WEAK. * Configurations/ToolExecutable.xcconfig: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig Diff Modified: trunk/Source/_javascript_Core/ChangeLog (223979 => 223980) --- trunk/Source/_javascript_Core/ChangeLog 2017-10-25 21:12:00 UTC (rev 223979) +++ trunk/Source/_javascript_Core/ChangeLog 2017-10-25 21:12:38 UTC (rev 223980) @@ -1,3 +1,14 @@ +2017-10-25 Michael Saboff + +REGRESSION(r223937): Use of -fobjc-weak causes build failures with older compilers +https://bugs.webkit.org/show_bug.cgi?id=178825 + +Reviewed by Mark Lam. + +Enable ARC for ARM64_32. This eliminate the need for setting CLANG_ENABLE_OBJC_WEAK. + +* Configurations/ToolExecutable.xcconfig: + 2017-10-25 Keith Miller Fix implicit cast of enum, which seems to break the windows build of unified sources. Modified: trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig (223979 => 223980) --- trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig 2017-10-25 21:12:00 UTC (rev 223979) +++ trunk/Source/_javascript_Core/Configurations/ToolExecutable.xcconfig 2017-10-25 21:12:38 UTC (rev 223980) @@ -50,9 +50,8 @@ CLANG_ENABLE_OBJC_ARC_armv7s = YES; CLANG_ENABLE_OBJC_ARC_arm64 = YES; CLANG_ENABLE_OBJC_ARC_arm64e = YES; +CLANG_ENABLE_OBJC_ARC_arm64_32 = YES; -CLANG_ENABLE_OBJC_WEAK = YES; - OTHER_CFLAGS = $(ASAN_OTHER_CFLAGS) -isystem icu; OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223978] trunk/Source/WebInspectorUI
Title: [223978] trunk/Source/WebInspectorUI
Revision 223978
Author nvasil...@apple.com
Date 2017-10-25 14:09:45 -0700 (Wed, 25 Oct 2017)
Log Message
Web Inspector: [PARITY] Styles Redesign: Add color gradient, bezier curve, and spring inline widgets
https://bugs.webkit.org/show_bug.cgi?id=178404
Reviewed by Devin Rousso.
Add inline widgets for the following CSS values:
- Gradients, e.g. `background-image: linear-gradient(yellow, orange)`
- Bezier curves, e.g. `transition-timing-function: cubic-bezier(0.68, -0.55, 0.265, 1.55)`
- Spring functions, e.g. `transition-timing-function: spring(1, 2, 2, 4)`
* UserInterface/Models/Color.js:
(WI.Color.prototype.toString):
Don't throw. The are never try/catch blocks on the callsites.
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
(WI.SpreadsheetStyleProperty.prototype._addGradientTokens):
(WI.SpreadsheetStyleProperty.prototype._addColorTokens):
(WI.SpreadsheetStyleProperty.prototype._addTimingFunctionTokens):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/Color.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (223977 => 223978)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-25 20:44:29 UTC (rev 223977)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-25 21:09:45 UTC (rev 223978)
@@ -1,5 +1,29 @@
2017-10-25 Nikita Vasilyev
+Web Inspector: [PARITY] Styles Redesign: Add color gradient, bezier curve, and spring inline widgets
+https://bugs.webkit.org/show_bug.cgi?id=178404
+
+
+Reviewed by Devin Rousso.
+
+Add inline widgets for the following CSS values:
+- Gradients, e.g. `background-image: linear-gradient(yellow, orange)`
+- Bezier curves, e.g. `transition-timing-function: cubic-bezier(0.68, -0.55, 0.265, 1.55)`
+- Spring functions, e.g. `transition-timing-function: spring(1, 2, 2, 4)`
+
+* UserInterface/Models/Color.js:
+(WI.Color.prototype.toString):
+Don't throw. The are never try/catch blocks on the callsites.
+
+* UserInterface/Views/SpreadsheetStyleProperty.js:
+(WI.SpreadsheetStyleProperty.prototype._renderValue):
+(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
+(WI.SpreadsheetStyleProperty.prototype._addGradientTokens):
+(WI.SpreadsheetStyleProperty.prototype._addColorTokens):
+(WI.SpreadsheetStyleProperty.prototype._addTimingFunctionTokens):
+
+2017-10-25 Nikita Vasilyev
+
Web Inspector: Styles Redesign: Newly added invalid property isn't immediately shown as invalid
https://bugs.webkit.org/show_bug.cgi?id=178488
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/Color.js (223977 => 223978)
--- trunk/Source/WebInspectorUI/UserInterface/Models/Color.js 2017-10-25 20:44:29 UTC (rev 223977)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/Color.js 2017-10-25 21:09:45 UTC (rev 223978)
@@ -379,7 +379,8 @@
return this._toKeywordString();
}
-throw "invalid color format";
+console.error("Invalid color format: " + format);
+return "";
}
isKeyword()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (223977 => 223978)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2017-10-25 20:44:29 UTC (rev 223977)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2017-10-25 21:09:45 UTC (rev 223978)
@@ -253,9 +253,11 @@
let tokens = WI.tokenizeCSSValue(value);
if (this._property.enabled) {
-// Don't show color widgets for CSS gradients, show dedicated gradient widgets instead.
-// FIXME: Web Inspector: [PARITY] Styles Redesign: Add bezier curve, color gradient, and CSS variable inline widgets
+// FIXME: Web Inspector: Styles: Make inline widgets work with CSS functions (var(), calc(), etc.)
+tokens = this._addGradientTokens(tokens);
tokens = this._addColorTokens(tokens);
+tokens = this._addTimingFunctionTokens(tokens, "cubic-bezier");
+tokens = this._addTimingFunctionTokens(tokens, "spring");
}
tokens = tokens.map((token) => {
@@ -287,48 +289,79 @@
this._valueElement.append(...tokens);
}
-_addColorTokens(tokens)
+_createInlineSwatch(type, text, valueObject)
{
-let newTokens = [];
+let tokenElement = document.createElement("span");
+let innerElement = document.createElement("span");
+innerElement.textContent = text;
-let createColorTokenElement = (colorString, color) => {
-let colorTokenElement = document.createElement("span");
-colorTokenE
[webkit-changes] [223977] trunk/Source
Title: [223977] trunk/Source Revision 223977 Author jmarc...@apple.com Date 2017-10-25 13:44:29 -0700 (Wed, 25 Oct 2017) Log Message Versioning. Modified Paths trunk/Source/_javascript_Core/Configurations/Version.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig trunk/Source/WebCore/Configurations/Version.xcconfig trunk/Source/WebCore/PAL/Configurations/Version.xcconfig trunk/Source/WebInspectorUI/Configurations/Version.xcconfig trunk/Source/WebKit/Configurations/Version.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (223976 => 223977) --- trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2017-10-25 20:18:46 UTC (rev 223976) +++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig 2017-10-25 20:44:29 UTC (rev 223977) @@ -23,7 +23,7 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (223976 => 223977) --- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-10-25 20:18:46 UTC (rev 223976) +++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-10-25 20:44:29 UTC (rev 223977) @@ -23,7 +23,7 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (223976 => 223977) --- trunk/Source/WebCore/Configurations/Version.xcconfig 2017-10-25 20:18:46 UTC (rev 223976) +++ trunk/Source/WebCore/Configurations/Version.xcconfig 2017-10-25 20:44:29 UTC (rev 223977) @@ -23,7 +23,7 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (223976 => 223977) --- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-10-25 20:18:46 UTC (rev 223976) +++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-10-25 20:44:29 UTC (rev 223977) @@ -23,7 +23,7 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (223976 => 223977) --- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-10-25 20:18:46 UTC (rev 223976) +++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-10-25 20:44:29 UTC (rev 223977) @@ -1,6 +1,6 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (223976 => 223977) --- trunk/Source/WebKit/Configurations/Version.xcconfig 2017-10-25 20:18:46 UTC (rev 223976) +++ trunk/Source/WebKit/Configurations/Version.xcconfig 2017-10-25 20:44:29 UTC (rev 223977) @@ -23,7 +23,7 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (223976 => 223977) --- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2017-10-25 20:18:46 UTC (rev 223976) +++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig 2017-10-25 20:44:29 UTC (rev 223977) @@ -23,7 +23,7 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223976] tags/Safari-605.1.12/
Title: [223976] tags/Safari-605.1.12/ Revision 223976 Author jmarc...@apple.com Date 2017-10-25 13:18:46 -0700 (Wed, 25 Oct 2017) Log Message Tag Safari-605.1.12. Added Paths tags/Safari-605.1.12/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223975] trunk/Websites/perf.webkit.org
Title: [223975] trunk/Websites/perf.webkit.org
Revision 223975
Author dewei_...@apple.com
Date 2017-10-25 12:48:57 -0700 (Wed, 25 Oct 2017)
Log Message
Fix a bug in syncing script that test/build syncer is never set.
https://bugs.webkit.org/show_bug.cgi?id=178772
Reviewed by Ryosuke Niwa.
Neither 'buildSyncer' nor 'testSyncer' is ever set.
Added a unit test to cover this case.
* server-tests/tools-sync-buildbot-integration-tests.js:
(createTriggerable): Refactor it to allow customized name.
* tools/js/buildbot-triggerable.js:
(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers): Update syncer info accordingly.
(BuildbotTriggerable._testGroupMapForBuildRequests): Initialize build and test syncer to null.
Modified Paths
trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/server-tests/tools-sync-buildbot-integration-tests.js
trunk/Websites/perf.webkit.org/tools/js/buildbot-triggerable.js
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (223974 => 223975)
--- trunk/Websites/perf.webkit.org/ChangeLog 2017-10-25 19:42:16 UTC (rev 223974)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-10-25 19:48:57 UTC (rev 223975)
@@ -1,5 +1,21 @@
2017-10-24 Dewei Zhu
+Fix a bug in syncing script that test/build syncer is never set.
+https://bugs.webkit.org/show_bug.cgi?id=178772
+
+Reviewed by Ryosuke Niwa.
+
+Neither 'buildSyncer' nor 'testSyncer' is ever set.
+Added a unit test to cover this case.
+
+* server-tests/tools-sync-buildbot-integration-tests.js:
+(createTriggerable): Refactor it to allow customized name.
+* tools/js/buildbot-triggerable.js:
+(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers): Update syncer info accordingly.
+(BuildbotTriggerable._testGroupMapForBuildRequests): Initialize build and test syncer to null.
+
+2017-10-24 Dewei Zhu
+
Owner commit does not necessarily exist in the same commit set for an owned commit.
https://bugs.webkit.org/show_bug.cgi?id=178763
Modified: trunk/Websites/perf.webkit.org/server-tests/tools-sync-buildbot-integration-tests.js (223974 => 223975)
--- trunk/Websites/perf.webkit.org/server-tests/tools-sync-buildbot-integration-tests.js 2017-10-25 19:42:16 UTC (rev 223974)
+++ trunk/Websites/perf.webkit.org/server-tests/tools-sync-buildbot-integration-tests.js 2017-10-25 19:48:57 UTC (rev 223975)
@@ -13,52 +13,90 @@
const addSlaveForReport = require('./resources/common-operations.js').addSlaveForReport;
const prepareServerTest = require('./resources/common-operations.js').prepareServerTest;
-function createTriggerable()
+const configWithOneTesterTwoBuilders = {
+triggerableName: 'build-webkit',
+lookbackCount: 2,
+buildRequestArgument: 'build-request-id',
+slaveName: 'sync-slave',
+slavePassword: 'password',
+repositoryGroups: {
+'webkit': {
+repositories: {'WebKit': {acceptsPatch: true}},
+testProperties: {'wk': {'revision': 'WebKit'}, 'roots': {'roots': {}}},
+buildProperties: {'wk': {'revision': 'WebKit'}, 'wk-patch': {'patch': 'WebKit'},
+'checkbox': {'ifRepositorySet': ['WebKit'], 'value': 'build-wk'},
+'owned-commits': {'ownedRevisions': 'WebKit'}},
+acceptsRoots: true,
+}
+},
+types: {
+'some': {
+test: ['some test'],
+properties: {'test': 'some-test'},
+}
+},
+builders: {
+'builder-1': {
+builder: 'some tester',
+properties: {forcescheduler: 'force-ab-tests'},
+},
+'builder-2': {
+builder: 'some builder',
+properties: {forcescheduler: 'force-ab-builds'},
+},
+'builder-3': {
+builder: 'other builder',
+properties: {forcescheduler: 'force-ab-builds'},
+},
+},
+buildConfigurations: [
+{platforms: ['some platform'], builders: ['builder-2', 'builder-3']},
+],
+testConfigurations: [
+{types: ['some'], platforms: ['some platform'], builders: ['builder-1']},
+],
+};
+
+const configWithTwoTesters = {
+triggerableName: 'build-webkit',
+lookbackCount: 2,
+buildRequestArgument: 'build-request-id',
+slaveName: 'sync-slave',
+slavePassword: 'password',
+repositoryGroups: {
+'webkit': {
+repositories: {'WebKit': {acceptsPatch: true}},
+testProperties: {'wk': {'revision': 'WebKit'}, 'roots': {'roots': {}}},
+buildProperties: {'wk': {'revision': 'WebKit'}, 'wk-patch': {'patch': 'WebKit'},
+'checkbox': {'ifRepositorySet': ['WebKit'], 'value': 'build-wk'},
+'owned-commits': {'ownedRevisions': 'WebKit'}},
+acceptsRoots: true,
+}
+},
+types: {
+'some': {
+test: ['some test'],
+properties: {'test': 'some-test'},
+}
+},
+
[webkit-changes] [223973] trunk/Source/WebCore
Title: [223973] trunk/Source/WebCore
Revision 223973
Author cdu...@apple.com
Date 2017-10-25 12:36:08 -0700 (Wed, 25 Oct 2017)
Log Message
[Service Worker] Add stubs for serviceWorkerClient.type
https://bugs.webkit.org/show_bug.cgi?id=178812
Reviewed by Youenn Fablet.
Add stubs for serviceWorkerClient.type to match the latest specification:
- https://w3c.github.io/ServiceWorker/#enumdef-clienttype
* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* workers/service/ServiceWorkerClient.cpp:
(WebCore::ServiceWorkerClient::type const):
* workers/service/ServiceWorkerClient.h:
* workers/service/ServiceWorkerClient.idl:
* workers/service/ServiceWorkerClientType.h: Added.
* workers/service/ServiceWorkerClientType.idl: Added.
* workers/service/ServiceWorkerClients.h:
* workers/service/ServiceWorkerClients.idl:
Modified Paths
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/workers/service/ServiceWorkerClient.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerClient.h
trunk/Source/WebCore/workers/service/ServiceWorkerClient.idl
trunk/Source/WebCore/workers/service/ServiceWorkerClients.h
trunk/Source/WebCore/workers/service/ServiceWorkerClients.idl
Added Paths
trunk/Source/WebCore/workers/service/ServiceWorkerClientType.h
trunk/Source/WebCore/workers/service/ServiceWorkerClientType.idl
Diff
Modified: trunk/Source/WebCore/CMakeLists.txt (223972 => 223973)
--- trunk/Source/WebCore/CMakeLists.txt 2017-10-25 19:27:05 UTC (rev 223972)
+++ trunk/Source/WebCore/CMakeLists.txt 2017-10-25 19:36:08 UTC (rev 223973)
@@ -806,6 +806,7 @@
workers/service/FetchEvent.idl
workers/service/ServiceWorker.idl
workers/service/ServiceWorkerClient.idl
+workers/service/ServiceWorkerClientType.idl
workers/service/ServiceWorkerClients.idl
workers/service/ServiceWorkerContainer.idl
workers/service/ServiceWorkerGlobalScope.idl
Modified: trunk/Source/WebCore/ChangeLog (223972 => 223973)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 19:27:05 UTC (rev 223972)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 19:36:08 UTC (rev 223973)
@@ -1,3 +1,26 @@
+2017-10-25 Chris Dumez
+
+[Service Worker] Add stubs for serviceWorkerClient.type
+https://bugs.webkit.org/show_bug.cgi?id=178812
+
+Reviewed by Youenn Fablet.
+
+Add stubs for serviceWorkerClient.type to match the latest specification:
+- https://w3c.github.io/ServiceWorker/#enumdef-clienttype
+
+* CMakeLists.txt:
+* DerivedSources.make:
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* workers/service/ServiceWorkerClient.cpp:
+(WebCore::ServiceWorkerClient::type const):
+* workers/service/ServiceWorkerClient.h:
+* workers/service/ServiceWorkerClient.idl:
+* workers/service/ServiceWorkerClientType.h: Added.
+* workers/service/ServiceWorkerClientType.idl: Added.
+* workers/service/ServiceWorkerClients.h:
+* workers/service/ServiceWorkerClients.idl:
+
2017-10-24 Keith Miller
Move mathml and page to unified souces
Modified: trunk/Source/WebCore/DerivedSources.make (223972 => 223973)
--- trunk/Source/WebCore/DerivedSources.make 2017-10-25 19:27:05 UTC (rev 223972)
+++ trunk/Source/WebCore/DerivedSources.make 2017-10-25 19:36:08 UTC (rev 223973)
@@ -927,6 +927,7 @@
$(WebCore)/workers/service/FetchEvent.idl \
$(WebCore)/workers/service/ServiceWorker.idl \
$(WebCore)/workers/service/ServiceWorkerClient.idl \
+$(WebCore)/workers/service/ServiceWorkerClientType.idl \
$(WebCore)/workers/service/ServiceWorkerClients.idl \
$(WebCore)/workers/service/ServiceWorkerContainer.idl \
$(WebCore)/workers/service/ServiceWorkerGlobalScope.idl \
Modified: trunk/Source/WebCore/Sources.txt (223972 => 223973)
--- trunk/Source/WebCore/Sources.txt 2017-10-25 19:27:05 UTC (rev 223972)
+++ trunk/Source/WebCore/Sources.txt 2017-10-25 19:36:08 UTC (rev 223973)
@@ -1799,6 +1799,7 @@
JSSecurityPolicyViolationEvent.cpp
JSServiceWorker.cpp
JSServiceWorkerClient.cpp
+JSServiceWorkerClientType.cpp
JSServiceWorkerClients.cpp
JSServiceWorkerContainer.cpp
JSServiceWorkerGlobalScope.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (223972 => 223973)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-10-25 19:27:05 UTC (rev 223972)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-10-25 19:36:08 UTC (rev 223973)
@@ -2834,8 +2834,8 @@
830519961BB0F11000F3772E /* HTMLTimeElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 830519931BB0F0E700F3772E /* HTMLTimeElement.h */; };
830784B21C52EE2C00104D1D /* XMLDocument.h in Headers */ = {isa = PBXBuildFile; fileRef = 830784B11C52EE1900104D1D /* XMLDocument.h */; settings
[webkit-changes] [223971] trunk/Source/JavaScriptCore
Title: [223971] trunk/Source/_javascript_Core
Revision 223971
Author keith_mil...@apple.com
Date 2017-10-25 12:06:42 -0700 (Wed, 25 Oct 2017)
Log Message
Fix implicit cast of enum, which seems to break the windows build of unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178822
Reviewed by Saam Barati.
* bytecode/DFGExitProfile.h:
(JSC::DFG::FrequentExitSite::hash const):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (223970 => 223971)
--- trunk/Source/_javascript_Core/ChangeLog 2017-10-25 19:02:28 UTC (rev 223970)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-10-25 19:06:42 UTC (rev 223971)
@@ -1,3 +1,13 @@
+2017-10-25 Keith Miller
+
+Fix implicit cast of enum, which seems to break the windows build of unified sources.
+https://bugs.webkit.org/show_bug.cgi?id=178822
+
+Reviewed by Saam Barati.
+
+* bytecode/DFGExitProfile.h:
+(JSC::DFG::FrequentExitSite::hash const):
+
2017-10-24 Michael Saboff
Allow OjbC Weak References when building TestAPI
Modified: trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h (223970 => 223971)
--- trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2017-10-25 19:02:28 UTC (rev 223970)
+++ trunk/Source/_javascript_Core/bytecode/DFGExitProfile.h 2017-10-25 19:06:42 UTC (rev 223971)
@@ -97,7 +97,7 @@
unsigned hash() const
{
-return WTF::intHash(m_bytecodeOffset) + m_kind + m_jitType * 7;
+return WTF::intHash(m_bytecodeOffset) + m_kind + static_cast>(m_jitType) * 7;
}
unsigned bytecodeOffset() const { return m_bytecodeOffset; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223970] trunk/Source/WebInspectorUI
Title: [223970] trunk/Source/WebInspectorUI
Revision 223970
Author nvasil...@apple.com
Date 2017-10-25 12:02:28 -0700 (Wed, 25 Oct 2017)
Log Message
Web Inspector: Styles Redesign: Newly added invalid property isn't immediately shown as invalid
https://bugs.webkit.org/show_bug.cgi?id=178488
Reviewed by Brian Burg.
* UserInterface/Models/CSSStyleDeclaration.js:
(WI.CSSStyleDeclaration.prototype.newBlankProperty):
Call this.update to update _properties, _allProperties, _visibleProperties, and _allVisibleProperties.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled)):
(.spreadsheet-style-declaration-editor .property.invalid-name:not(.disabled)):
(.spreadsheet-style-declaration-editor .property.invalid-value:not(.disabled) .value):
When the property name is valid, but the value isn't, display red line-through only for the value.
This is how it works in the old styles sidebar as well.
* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
(WI.SpreadsheetCSSStyleDeclarationEditor):
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.updateClassNames):
(WI.SpreadsheetStyleProperty.prototype._update):
Introduce updateClassNames method. Unlike _update, it doesn't change text selection or focus and
can be safely called on a property while it's being edited.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (223969 => 223970)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-10-25 19:01:41 UTC (rev 223969)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-10-25 19:02:28 UTC (rev 223970)
@@ -1,3 +1,31 @@
+2017-10-25 Nikita Vasilyev
+
+Web Inspector: Styles Redesign: Newly added invalid property isn't immediately shown as invalid
+https://bugs.webkit.org/show_bug.cgi?id=178488
+
+Reviewed by Brian Burg.
+
+* UserInterface/Models/CSSStyleDeclaration.js:
+(WI.CSSStyleDeclaration.prototype.newBlankProperty):
+Call this.update to update _properties, _allProperties, _visibleProperties, and _allVisibleProperties.
+
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
+(.spreadsheet-style-declaration-editor .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled)):
+(.spreadsheet-style-declaration-editor .property.invalid-name:not(.disabled)):
+(.spreadsheet-style-declaration-editor .property.invalid-value:not(.disabled) .value):
+When the property name is valid, but the value isn't, display red line-through only for the value.
+This is how it works in the old styles sidebar as well.
+
+* UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
+(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
+(WI.SpreadsheetCSSStyleDeclarationEditor):
+* UserInterface/Views/SpreadsheetStyleProperty.js:
+(WI.SpreadsheetStyleProperty):
+(WI.SpreadsheetStyleProperty.prototype.updateClassNames):
+(WI.SpreadsheetStyleProperty.prototype._update):
+Introduce updateClassNames method. Unlike _update, it doesn't change text selection or focus and
+can be safely called on a property while it's being edited.
+
2017-10-25 Devin Rousso
Web Inspector: preserve Recordings for each Canvas after closing the Canvas tab
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js (223969 => 223970)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js 2017-10-25 19:01:41 UTC (rev 223969)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js 2017-10-25 19:02:28 UTC (rev 223970)
@@ -361,11 +361,16 @@
{
let text, name, value, priority, overridden, implicit, anonymous;
let enabled = true;
-let valid = true;
+let valid = false;
let styleSheetTextRange = this._rangeAfterPropertyAtIndex(insertAfterIndex);
-let property = new WI.CSSProperty(insertAfterIndex + 1, text, name, value, priority, enabled, overridden, implicit, anonymous, valid, styleSheetTextRange);
-property.ownerStyle = this;
+let propertyIndex = insertAfterIndex + 1;
+let property = new WI.CSSProperty(propertyIndex, text, name, value, priority, enabled, overridden, implicit, anonymous, valid, styleSheetTextRange);
+
+this._allProperties.insertAtInde
[webkit-changes] [223969] branches/safari-604-branch/Source/WebCore
Title: [223969] branches/safari-604-branch/Source/WebCore
Revision 223969
Author jmarc...@apple.com
Date 2017-10-25 12:01:41 -0700 (Wed, 25 Oct 2017)
Log Message
Cherry-pick r223960. rdar://problem/35178892
Modified Paths
branches/safari-604-branch/Source/WebCore/ChangeLog
branches/safari-604-branch/Source/WebCore/html/HTMLAudioElement.cpp
branches/safari-604-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-604-branch/Source/WebCore/html/HTMLMediaElement.h
branches/safari-604-branch/Source/WebCore/html/HTMLVideoElement.cpp
Diff
Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (223968 => 223969)
--- branches/safari-604-branch/Source/WebCore/ChangeLog 2017-10-25 18:54:58 UTC (rev 223968)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog 2017-10-25 19:01:41 UTC (rev 223969)
@@ -1,3 +1,36 @@
+2017-10-25 Jason Marcell
+
+Cherry-pick r223960. rdar://problem/35178892
+
+2017-10-25 Jer Noble
+
+Autoplay muted videos still stop playback of other streaming apps in the background
+https://bugs.webkit.org/show_bug.cgi?id=177920
+
+Reviewed by Eric Carlson.
+
+When creating a new or element, the global AudioSession can sometimes have
+its sessionCategory() set to "MediaPlayback", even if the element does not yet have a
+source. This is because the constructor for the MediaElementSession is called before
+m_isPlayingToWirelessTarget is initialized, and so in the MediaElementSession constructor,
+the media element's m_isPlayingToWirelessTarget ivar is sometimes (uninitialized) true.
+
+We could move the MediaElementSession ivar to the very end of the header, so it's
+initialized last, but that still leaves the possibility of the MediaElementSession et. all
+calling into the HTMLMediaElement before it's subclass's constructors have a chance to
+initialize their own ivars (much less their vtables). So instead, we'll create and set the
+MediaElementSession in a finishInitialization() method called from the HTMLVideoElement and
+HTMLAudioElement's create() factory methods.
+
+* html/HTMLAudioElement.cpp:
+(WebCore::HTMLAudioElement::create):
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::HTMLMediaElement):
+(WebCore::HTMLMediaElement::finishInitialization):
+* html/HTMLMediaElement.h:
+* html/HTMLVideoElement.cpp:
+(WebCore::HTMLVideoElement::create):
+
2017-10-21 Jason Marcell
Cherry-pick r223578. rdar://problem/34891313
Modified: branches/safari-604-branch/Source/WebCore/html/HTMLAudioElement.cpp (223968 => 223969)
--- branches/safari-604-branch/Source/WebCore/html/HTMLAudioElement.cpp 2017-10-25 18:54:58 UTC (rev 223968)
+++ branches/safari-604-branch/Source/WebCore/html/HTMLAudioElement.cpp 2017-10-25 19:01:41 UTC (rev 223969)
@@ -44,6 +44,7 @@
Ref HTMLAudioElement::create(const QualifiedName& tagName, Document& document, bool createdByParser)
{
auto element = adoptRef(*new HTMLAudioElement(tagName, document, createdByParser));
+element->finishInitialization();
element->suspendIfNeeded();
return element;
}
Modified: branches/safari-604-branch/Source/WebCore/html/HTMLMediaElement.cpp (223968 => 223969)
--- branches/safari-604-branch/Source/WebCore/html/HTMLMediaElement.cpp 2017-10-25 18:54:58 UTC (rev 223968)
+++ branches/safari-604-branch/Source/WebCore/html/HTMLMediaElement.cpp 2017-10-25 19:01:41 UTC (rev 223969)
@@ -441,13 +441,17 @@
, m_haveVisibleTextTrack(false)
, m_processingPreferenceChange(false)
#endif
-, m_mediaSession(std::make_unique(*this))
{
allMediaElements().add(this);
LOG(Media, "HTMLMediaElement::HTMLMediaElement(%p)", this);
setHasCustomStyleResolveCallbacks();
+}
+void HTMLMediaElement::finishInitialization()
+{
+m_mediaSession = std::make_unique(*this);
+
m_mediaSession->addBehaviorRestriction(MediaElementSession::RequireUserGestureForFullscreen);
m_mediaSession->addBehaviorRestriction(MediaElementSession::RequirePageConsentToLoadMedia);
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
@@ -456,6 +460,7 @@
m_mediaSession->addBehaviorRestriction(MediaElementSession::RequireUserGestureToControlControlsManager);
m_mediaSession->addBehaviorRestriction(MediaElementSession::RequirePlaybackToControlControlsManager);
+auto& document = this->document();
auto* page = document.page();
if (document.settings().invisibleAutoplayNotPermitted())
Modified: branches/safari-604-branch/Source/WebCore/html/HTMLMediaElement.h (223968 => 223969)
--- branches/safari-604-branch/Source/WebCore/html/HTMLMediaElement.h 2017-10-25 18:54:58 UTC (rev 223968)
+++ branches/safari-604-branch/Source/WebCore/html/HTMLMediaElement.h 2017-10-25 19:01:41 UTC (rev 223969)
@@ -525,6 +525,7
[webkit-changes] [223968] trunk/Source/WebCore
Title: [223968] trunk/Source/WebCore
Revision 223968
Author commit-qu...@webkit.org
Date 2017-10-25 11:54:58 -0700 (Wed, 25 Oct 2017)
Log Message
fast/images/animated-gif-paint-after-animation.html flaky crash
https://bugs.webkit.org/show_bug.cgi?id=178510
Patch by Fujii Hironori on 2017-10-25
Reviewed by Said Abou-Hallawa.
ScalableImageDecoder was accessed from the main thread and the
image decoding thread without a mutex.
No new tests because there is no behavior change.
* platform/image-decoders/ScalableImageDecoder.h: Add m_mutex. Lock the mutex in setData.
* platform/image-decoders/ScalableImageDecoder.cpp:
(WebCore::ScalableImageDecoder::frameIsCompleteAtIndex const): Lock the mutex.
(WebCore::ScalableImageDecoder::frameHasAlphaAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::frameBytesAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::frameDurationAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::createFrameImageAtIndex): Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp
trunk/Source/WebCore/platform/image-decoders/ScalableImageDecoder.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (223967 => 223968)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 18:42:11 UTC (rev 223967)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 18:54:58 UTC (rev 223968)
@@ -1,3 +1,23 @@
+2017-10-25 Fujii Hironori
+
+fast/images/animated-gif-paint-after-animation.html flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=178510
+
+Reviewed by Said Abou-Hallawa.
+
+ScalableImageDecoder was accessed from the main thread and the
+image decoding thread without a mutex.
+
+No new tests because there is no behavior change.
+
+* platform/image-decoders/ScalableImageDecoder.h: Add m_mutex. Lock the mutex in setData.
+* platform/image-decoders/ScalableImageDecoder.cpp:
+(WebCore::ScalableImageDecoder::frameIsCompleteAtIndex const): Lock the mutex.
+(WebCore::ScalableImageDecoder::frameHasAlphaAtIndex const): Ditto.
+(WebCore::ScalableImageDecoder::frameBytesAtIndex const): Ditto.
+(WebCore::ScalableImageDecoder::frameDurationAtIndex const): Ditto.
+(WebCore::ScalableImageDecoder::createFrameImageAtIndex): Ditto.
+
2017-10-25 Chris Dumez
Add support for unregistering a service worker
Modified: trunk/Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp (223967 => 223968)
--- trunk/Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp 2017-10-25 18:42:11 UTC (rev 223967)
+++ trunk/Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp 2017-10-25 18:54:58 UTC (rev 223968)
@@ -172,6 +172,7 @@
bool ScalableImageDecoder::frameIsCompleteAtIndex(size_t index) const
{
+LockHolder lockHolder(m_mutex);
// FIXME(176089): asking whether enough data has been appended for a decode
// operation to succeed should not require decoding the entire frame.
// This function should be implementable in a way that allows const.
@@ -181,6 +182,7 @@
bool ScalableImageDecoder::frameHasAlphaAtIndex(size_t index) const
{
+LockHolder lockHolder(m_mutex);
if (m_frameBufferCache.size() <= index)
return true;
if (m_frameBufferCache[index].isComplete())
@@ -190,6 +192,7 @@
unsigned ScalableImageDecoder::frameBytesAtIndex(size_t index, SubsamplingLevel) const
{
+LockHolder lockHolder(m_mutex);
if (m_frameBufferCache.size() <= index)
return 0;
// FIXME: Use the dimension of the requested frame.
@@ -198,6 +201,7 @@
Seconds ScalableImageDecoder::frameDurationAtIndex(size_t index) const
{
+LockHolder lockHolder(m_mutex);
// FIXME(176089): asking for the duration of a sub-image should not require decoding
// the entire frame. This function should be implementable in a way that
// allows const.
@@ -216,6 +220,7 @@
NativeImagePtr ScalableImageDecoder::createFrameImageAtIndex(size_t index, SubsamplingLevel, const DecodingOptions&)
{
+LockHolder lockHolder(m_mutex);
// Zero-height images can cause problems for some ports. If we have an empty image dimension, just bail.
if (size().isEmpty())
return nullptr;
Modified: trunk/Source/WebCore/platform/image-decoders/ScalableImageDecoder.h (223967 => 223968)
--- trunk/Source/WebCore/platform/image-decoders/ScalableImageDecoder.h 2017-10-25 18:42:11 UTC (rev 223967)
+++ trunk/Source/WebCore/platform/image-decoders/ScalableImageDecoder.h 2017-10-25 18:54:58 UTC (rev 223968)
@@ -33,6 +33,7 @@
#include "IntRect.h"
#include "SharedBuffer.h"
#include
+#include
#include
#include
#include
@@ -72,6 +73,7 @@
void setData(SharedBuffer& data, bool allDataReceived) override
{
+LockHolder lockHolder(m_mutex);
if (m_encodedDataStatus == EncodedDataStatus::Error)
return;
@@ -205,6 +207,7 @@
RefPtr m_data; /
[webkit-changes] [223967] trunk/LayoutTests
Title: [223967] trunk/LayoutTests Revision 223967 Author ryanhad...@apple.com Date 2017-10-25 11:42:11 -0700 (Wed, 25 Oct 2017) Log Message Mark http/tests/loading/basic-credentials-sent-automatically.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=159427 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (223966 => 223967) --- trunk/LayoutTests/ChangeLog 2017-10-25 18:38:48 UTC (rev 223966) +++ trunk/LayoutTests/ChangeLog 2017-10-25 18:42:11 UTC (rev 223967) @@ -1,3 +1,12 @@ +2017-10-25 Ryan Haddad + +Mark http/tests/loading/basic-credentials-sent-automatically.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=159427 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + 2017-10-25 Chris Dumez Add support for unregistering a service worker Modified: trunk/LayoutTests/platform/mac/TestExpectations (223966 => 223967) --- trunk/LayoutTests/platform/mac/TestExpectations 2017-10-25 18:38:48 UTC (rev 223966) +++ trunk/LayoutTests/platform/mac/TestExpectations 2017-10-25 18:42:11 UTC (rev 223967) @@ -1788,3 +1788,5 @@ webkit.org/b/178190 imported/w3c/web-platform-tests/XMLHttpRequest/open-url-worker-origin.htm [ Pass Failure ] webkit.org/b/178465 [ Debug ] fast/html/marquee-reparent-check.html [ Skip ] + +webkit.org/b/159427 http/tests/loading/basic-credentials-sent-automatically.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223966] trunk/Source/WebKit
Title: [223966] trunk/Source/WebKit Revision 223966 Author commit-qu...@webkit.org Date 2017-10-25 11:38:48 -0700 (Wed, 25 Oct 2017) Log Message [WinCairo] Add WebKit platform files for wincairo webkit https://bugs.webkit.org/show_bug.cgi?id=178000 Patch by Yousuke Kimoto on 2017-10-25 Reviewed by Alex Christensen. * Platform/Module.h: * Platform/SharedMemory.h: (WebKit::SharedMemory::handle const): * Platform/win/LoggingWin.cpp: Added. It is based on Source/WebCore/platform/win/LoggingWin.cpp (WebKit::logLevelString): * Platform/win/ModuleWin.cpp: Added. (WebKit::Module::load): (WebKit::Module::unload): (WebKit::Module::platformFunctionPointer const): * Platform/win/SharedMemoryWin.cpp: Added. (WebKit::SharedMemory::Handle::Handle): (WebKit::SharedMemory::Handle::~Handle): (WebKit::SharedMemory::Handle::isNull const): (WebKit::SharedMemory::Handle::encode const): (WebKit::SharedMemory::Handle::clear): (WebKit::getDuplicatedHandle): (WebKit::SharedMemory::Handle::decode): (WebKit::protectAttribute): (WebKit::SharedMemory::allocate): (WebKit::SharedMemory::create): (WebKit::accessRights): (WebKit::SharedMemory::map): (WebKit::SharedMemory::adopt): (WebKit::SharedMemory::~SharedMemory): (WebKit::SharedMemory::createHandle): (WebKit::SharedMemory::systemPageSize): * PlatformWin.cmake: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/Module.h trunk/Source/WebKit/Platform/SharedMemory.h trunk/Source/WebKit/PlatformWin.cmake Added Paths trunk/Source/WebKit/Platform/win/ trunk/Source/WebKit/Platform/win/LoggingWin.cpp trunk/Source/WebKit/Platform/win/ModuleWin.cpp trunk/Source/WebKit/Platform/win/SharedMemoryWin.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (223965 => 223966) --- trunk/Source/WebKit/ChangeLog 2017-10-25 18:32:46 UTC (rev 223965) +++ trunk/Source/WebKit/ChangeLog 2017-10-25 18:38:48 UTC (rev 223966) @@ -1,3 +1,38 @@ +2017-10-25 Yousuke Kimoto + +[WinCairo] Add WebKit platform files for wincairo webkit +https://bugs.webkit.org/show_bug.cgi?id=178000 + +Reviewed by Alex Christensen. + +* Platform/Module.h: +* Platform/SharedMemory.h: +(WebKit::SharedMemory::handle const): +* Platform/win/LoggingWin.cpp: Added. It is based on Source/WebCore/platform/win/LoggingWin.cpp +(WebKit::logLevelString): +* Platform/win/ModuleWin.cpp: Added. +(WebKit::Module::load): +(WebKit::Module::unload): +(WebKit::Module::platformFunctionPointer const): +* Platform/win/SharedMemoryWin.cpp: Added. +(WebKit::SharedMemory::Handle::Handle): +(WebKit::SharedMemory::Handle::~Handle): +(WebKit::SharedMemory::Handle::isNull const): +(WebKit::SharedMemory::Handle::encode const): +(WebKit::SharedMemory::Handle::clear): +(WebKit::getDuplicatedHandle): +(WebKit::SharedMemory::Handle::decode): +(WebKit::protectAttribute): +(WebKit::SharedMemory::allocate): +(WebKit::SharedMemory::create): +(WebKit::accessRights): +(WebKit::SharedMemory::map): +(WebKit::SharedMemory::adopt): +(WebKit::SharedMemory::~SharedMemory): +(WebKit::SharedMemory::createHandle): +(WebKit::SharedMemory::systemPageSize): +* PlatformWin.cmake: + 2017-10-25 Chris Dumez Add support for unregistering a service worker Modified: trunk/Source/WebKit/Platform/Module.h (223965 => 223966) --- trunk/Source/WebKit/Platform/Module.h 2017-10-25 18:32:46 UTC (rev 223965) +++ trunk/Source/WebKit/Platform/Module.h 2017-10-25 18:38:48 UTC (rev 223966) @@ -1,5 +1,6 @@ /* * Copyright (C) 2010 Apple Inc. All rights reserved. + * Copyright (C) 2017 Sony Interactive Entertainment Inc. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -23,8 +24,7 @@ * THE POSSIBILITY OF SUCH DAMAGE. */ -#ifndef Module_h -#define Module_h +#pragma once #include #include @@ -64,6 +64,9 @@ void* platformFunctionPointer(const char* functionName) const; String m_path; +#if PLATFORM(WIN) +HMODULE m_module; +#endif #if USE(CF) RetainPtr m_bundle; #if !defined(__LP64__) @@ -80,5 +83,3 @@ } } - -#endif Modified: trunk/Source/WebKit/Platform/SharedMemory.h (223965 => 223966) --- trunk/Source/WebKit/Platform/SharedMemory.h 2017-10-25 18:32:46 UTC (rev 223965) +++ trunk/Source/WebKit/Platform/SharedMemory.h 2017-10-25 18:38:48 UTC (rev 223966) @@ -1,5 +1,6 @@ /* * Copyright (C) 2010 Apple Inc. All rights reserved. + * Copyright (C) 2017 Sony Interactive Entertainment Inc. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -23,8 +24,7 @@ * THE POSSIBILITY OF SUCH DAMAGE. */ -#ifndef SharedMemory_h -#define SharedMemory_h +#pragma once #include #include @@ -7
[webkit-changes] [223965] trunk/Source
Title: [223965] trunk/Source
Revision 223965
Author commit-qu...@webkit.org
Date 2017-10-25 11:32:46 -0700 (Wed, 25 Oct 2017)
Log Message
Unreviewed, rolling out r222945.
https://bugs.webkit.org/show_bug.cgi?id=178818
"It made WasmBench crash" (Requested by saamyjoon on #webkit).
Reverted changeset:
"bmalloc mutex should be adaptive"
https://bugs.webkit.org/show_bug.cgi?id=177839
https://trac.webkit.org/changeset/222945
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/LockAlgorithmInlines.h
trunk/Source/WTF/wtf/WordLock.cpp
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Algorithm.h
trunk/Source/bmalloc/bmalloc/PerThread.h
trunk/Source/bmalloc/bmalloc/StaticMutex.cpp
trunk/Source/bmalloc/bmalloc/StaticMutex.h
Diff
Modified: trunk/Source/WTF/ChangeLog (223964 => 223965)
--- trunk/Source/WTF/ChangeLog 2017-10-25 18:28:54 UTC (rev 223964)
+++ trunk/Source/WTF/ChangeLog 2017-10-25 18:32:46 UTC (rev 223965)
@@ -1,3 +1,16 @@
+2017-10-25 Commit Queue
+
+Unreviewed, rolling out r222945.
+https://bugs.webkit.org/show_bug.cgi?id=178818
+
+"It made WasmBench crash" (Requested by saamyjoon on #webkit).
+
+Reverted changeset:
+
+"bmalloc mutex should be adaptive"
+https://bugs.webkit.org/show_bug.cgi?id=177839
+https://trac.webkit.org/changeset/222945
+
2017-10-25 Zan Dobersek
Make SERVICE_WORKER feature buildable on GTK, WPE
Modified: trunk/Source/WTF/wtf/LockAlgorithmInlines.h (223964 => 223965)
--- trunk/Source/WTF/wtf/LockAlgorithmInlines.h 2017-10-25 18:28:54 UTC (rev 223964)
+++ trunk/Source/WTF/wtf/LockAlgorithmInlines.h 2017-10-25 18:32:46 UTC (rev 223965)
@@ -33,10 +33,6 @@
// the lock algorithm slow path without recompiling the world. Right now this should be included in two
// places (Lock.cpp and JSCell.cpp).
-// NOTE: It's a bug to use any memory order other than seq_cst in this code. The cost of seq_cst
-// fencing is negligible on slow paths, so any use of a more relaxed memory model is all risk and no
-// reward.
-
namespace WTF {
template
Modified: trunk/Source/WTF/wtf/WordLock.cpp (223964 => 223965)
--- trunk/Source/WTF/wtf/WordLock.cpp 2017-10-25 18:28:54 UTC (rev 223964)
+++ trunk/Source/WTF/wtf/WordLock.cpp 2017-10-25 18:32:46 UTC (rev 223965)
@@ -76,10 +76,6 @@
} // anonymous namespace
-// NOTE: It's a bug to use any memory order other than seq_cst in this code. The cost of seq_cst
-// fencing is negligible on slow paths, so any use of a more relaxed memory model is all risk and no
-// reward.
-
NEVER_INLINE void WordLockBase::lockSlow()
{
unsigned spinCount = 0;
@@ -227,8 +223,7 @@
ASSERT(currentWordValue & isLockedBit);
ASSERT(currentWordValue & isQueueLockedBit);
ThreadData* queueHead = bitwise_cast(currentWordValue & ~queueHeadMask);
-RELEASE_ASSERT(queueHead);
-RELEASE_ASSERT(queueHead->shouldPark); // This would have been set before the thread was enqueued, so it must still be set now.
+ASSERT(queueHead);
ThreadData* newQueueHead = queueHead->nextInQueue;
// Either this was the only thread on the queue, in which case we delete the queue, or there
@@ -261,12 +256,10 @@
{
std::lock_guard locker(queueHead->parkingLock);
queueHead->shouldPark = false;
-// We have to do the notify while still holding the lock, since otherwise, we could try to
-// do it after the queueHead has destructed. It's impossible for queueHead to destruct
-// while we hold the lock, since it is either currently in the wait loop or it's before it
-// so it has to grab the lock before destructing.
-queueHead->parkingCondition.notify_one();
}
+// Doesn't matter if we notify_all() or notify_one() here since the only thread that could be
+// waiting is queueHead.
+queueHead->parkingCondition.notify_one();
// The old queue head can now contend for the lock again. We're done!
}
Modified: trunk/Source/bmalloc/ChangeLog (223964 => 223965)
--- trunk/Source/bmalloc/ChangeLog 2017-10-25 18:28:54 UTC (rev 223964)
+++ trunk/Source/bmalloc/ChangeLog 2017-10-25 18:32:46 UTC (rev 223965)
@@ -1,3 +1,16 @@
+2017-10-25 Commit Queue
+
+Unreviewed, rolling out r222945.
+https://bugs.webkit.org/show_bug.cgi?id=178818
+
+"It made WasmBench crash" (Requested by saamyjoon on #webkit).
+
+Reverted changeset:
+
+"bmalloc mutex should be adaptive"
+https://bugs.webkit.org/show_bug.cgi?id=177839
+https://trac.webkit.org/changeset/222945
+
2017-10-24 Zan Dobersek
[Linux] Enable Gigacage in x64 Linux environment
Modified: trunk/Source/bmalloc/bmalloc/Algorithm.h (223964 => 223965)
--- trunk/Source/bmalloc/bmalloc/Algorithm.h 2017-10-25 18:28:54 UTC (rev 223964)
+++ trunk/Source/bmalloc/bmalloc/Algorithm.h 2017-10-25 18:32:46 UTC (rev 223965)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2014-2017 Apple Inc. All rig
[webkit-changes] [223964] trunk
Title: [223964] trunk Revision 223964 Author cdu...@apple.com Date 2017-10-25 11:28:54 -0700 (Wed, 25 Oct 2017) Log Message Add support for unregistering a service worker https://bugs.webkit.org/show_bug.cgi?id=178735 Reviewed by Brady Eidson. Source/WebCore: Add support for unregistering a service worker: - https://w3c.github.io/ServiceWorker/#navigator-service-worker-unregister Test: http/tests/workers/service/basic-unregister.https.html * workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::addRegistration): (WebCore::ServiceWorkerContainer::removeRegistration): (WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult): * workers/service/ServiceWorkerContainer.h: * workers/service/ServiceWorkerJob.cpp: (WebCore::ServiceWorkerJob::resolvedWithUnregistrationResult): * workers/service/ServiceWorkerJob.h: * workers/service/ServiceWorkerJobClient.h: * workers/service/ServiceWorkerJobData.h: (WebCore::ServiceWorkerJobData::encode const): (WebCore::ServiceWorkerJobData::decode): * workers/service/ServiceWorkerJobType.h: * workers/service/ServiceWorkerRegistration.cpp: (WebCore::containerForScriptExecutionContext): (WebCore::ServiceWorkerRegistration::unregister): * workers/service/server/SWClientConnection.cpp: (WebCore::SWClientConnection::registrationJobResolvedInServer): (WebCore::SWClientConnection::unregistrationJobResolvedInServer): * workers/service/server/SWClientConnection.h: * workers/service/server/SWServer.cpp: (WebCore::SWServer::resolveRegistationJob): (WebCore::SWServer::resolveUnregistrationJob): * workers/service/server/SWServer.h: * workers/service/server/SWServerRegistration.cpp: (WebCore::SWServerRegistration::scriptContextStarted): (WebCore::SWServerRegistration::startNextJob): (WebCore::SWServerRegistration::runUnregisterJob): (WebCore::SWServerRegistration::resolveWithRegistrationOnMainThread): (WebCore::SWServerRegistration::resolveWithUnregistrationResultOnMainThread): (WebCore::SWServerRegistration::resolveCurrentRegistrationJob): (WebCore::SWServerRegistration::resolveCurrentUnregistrationJob): * workers/service/server/SWServerRegistration.h: Source/WebKit: Add support for unregistering a service worker: - https://w3c.github.io/ServiceWorker/#navigator-service-worker-unregister * StorageProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::resolveRegistrationJobInClient): (WebKit::WebSWServerConnection::resolveUnregistrationJobInClient): * StorageProcess/ServiceWorker/WebSWServerConnection.h: * WebProcess/Storage/WebSWClientConnection.messages.in: LayoutTests: Add layout test coverage. * http/tests/workers/service/basic-unregister.https-expected.txt: Added. * http/tests/workers/service/basic-unregister.https.html: Added. * http/tests/workers/service/resources/basic-unregister.js: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp trunk/Source/WebCore/workers/service/ServiceWorkerJob.h trunk/Source/WebCore/workers/service/ServiceWorkerJobClient.h trunk/Source/WebCore/workers/service/ServiceWorkerJobData.h trunk/Source/WebCore/workers/service/ServiceWorkerJobType.h trunk/Source/WebCore/workers/service/ServiceWorkerRegistration.cpp trunk/Source/WebCore/workers/service/server/SWClientConnection.cpp trunk/Source/WebCore/workers/service/server/SWClientConnection.h trunk/Source/WebCore/workers/service/server/SWServer.cpp trunk/Source/WebCore/workers/service/server/SWServer.h trunk/Source/WebCore/workers/service/server/SWServerRegistration.cpp trunk/Source/WebCore/workers/service/server/SWServerRegistration.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.cpp trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.h trunk/Source/WebKit/WebProcess/Storage/WebSWClientConnection.messages.in Added Paths trunk/LayoutTests/http/tests/workers/service/basic-unregister.https-expected.txt trunk/LayoutTests/http/tests/workers/service/basic-unregister.https.html trunk/LayoutTests/http/tests/workers/service/resources/basic-unregister.js Diff Modified: trunk/LayoutTests/ChangeLog (223963 => 223964) --- trunk/LayoutTests/ChangeLog 2017-10-25 18:21:41 UTC (rev 223963) +++ trunk/LayoutTests/ChangeLog 2017-10-25 18:28:54 UTC (rev 223964) @@ -1,3 +1,16 @@ +2017-10-25 Chris Dumez + +Add support for unregistering a service worker +https://bugs.webkit.org/show_bug.cgi?id=178735 + +Reviewed by Brady Eidson. + +Add layout test coverage. + +* http/tests/workers/service/basic-unregister.https-expected.txt: Added. +* http/tests/workers/service/basic-unregister.https.html: Added. +* http/tests/workers/service/resources/basic-unregister.js: Added. + 2017-10-25 Andy Estes [Pa
[webkit-changes] [223963] trunk/Source/WebCore
Title: [223963] trunk/Source/WebCore
Revision 223963
Author simon.fra...@apple.com
Date 2017-10-25 11:21:41 -0700 (Wed, 25 Oct 2017)
Log Message
MediaSessionManager* needs to catch Obj-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=178813
Reviewed by Tim Horton.
Wrap all calls out to Objective-C with BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS.
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::MediaSessionManageriOS):
(WebCore::MediaSessionManageriOS::~MediaSessionManageriOS):
(WebCore::MediaSessionManageriOS::hasWirelessTargetsAvailable):
(WebCore::MediaSessionManageriOS::configureWireLessTargetMonitoring):
(WebCore::MediaSessionManageriOS::updateNowPlayingInfo):
(WebCore::MediaSessionManageriOS::externalOutputDeviceAvailableDidChange):
(-[WebMediaSessionHelper allocateVolumeView]):
(-[WebMediaSessionHelper initWithCallback:]):
* platform/audio/mac/MediaSessionManagerMac.mm:
(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm
trunk/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (223962 => 223963)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 18:00:28 UTC (rev 223962)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 18:21:41 UTC (rev 223963)
@@ -1,3 +1,24 @@
+2017-10-25 Simon Fraser
+
+MediaSessionManager* needs to catch Obj-C exceptions
+https://bugs.webkit.org/show_bug.cgi?id=178813
+
+Reviewed by Tim Horton.
+
+Wrap all calls out to Objective-C with BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS.
+
+* platform/audio/ios/MediaSessionManagerIOS.mm:
+(WebCore::MediaSessionManageriOS::MediaSessionManageriOS):
+(WebCore::MediaSessionManageriOS::~MediaSessionManageriOS):
+(WebCore::MediaSessionManageriOS::hasWirelessTargetsAvailable):
+(WebCore::MediaSessionManageriOS::configureWireLessTargetMonitoring):
+(WebCore::MediaSessionManageriOS::updateNowPlayingInfo):
+(WebCore::MediaSessionManageriOS::externalOutputDeviceAvailableDidChange):
+(-[WebMediaSessionHelper allocateVolumeView]):
+(-[WebMediaSessionHelper initWithCallback:]):
+* platform/audio/mac/MediaSessionManagerMac.mm:
+(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):
+
2017-10-25 Andy Estes
[Payment Request] Implement the "user aborts the payment request" algorithm
Modified: trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm (223962 => 223963)
--- trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm 2017-10-25 18:00:28 UTC (rev 223962)
+++ trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm 2017-10-25 18:21:41 UTC (rev 223963)
@@ -40,6 +40,7 @@
#import
#import
#import
+#import
#import
#import
#import
@@ -130,14 +131,19 @@
MediaSessionManageriOS::MediaSessionManageriOS()
: PlatformMediaSessionManager()
-, m_objcObserver(adoptNS([[WebMediaSessionHelper alloc] initWithCallback:this]))
{
+BEGIN_BLOCK_OBJC_EXCEPTIONS
+m_objcObserver = adoptNS([[WebMediaSessionHelper alloc] initWithCallback:this]);
+END_BLOCK_OBJC_EXCEPTIONS
resetRestrictions();
}
MediaSessionManageriOS::~MediaSessionManageriOS()
{
+BEGIN_BLOCK_OBJC_EXCEPTIONS
[m_objcObserver clearCallback];
+m_objcObserver = nil;
+END_BLOCK_OBJC_EXCEPTIONS
}
void MediaSessionManageriOS::resetRestrictions()
@@ -159,7 +165,9 @@
bool MediaSessionManageriOS::hasWirelessTargetsAvailable()
{
+BEGIN_BLOCK_OBJC_EXCEPTIONS
return [m_objcObserver hasWirelessTargetsAvailable];
+END_BLOCK_OBJC_EXCEPTIONS
}
void MediaSessionManageriOS::configureWireLessTargetMonitoring()
@@ -170,10 +178,14 @@
LOG(Media, "MediaSessionManageriOS::configureWireLessTargetMonitoring - requiresMonitoring = %s", requiresMonitoring ? "true" : "false");
+BEGIN_BLOCK_OBJC_EXCEPTIONS
+
if (requiresMonitoring)
[m_objcObserver startMonitoringAirPlayRoutes];
else
[m_objcObserver stopMonitoringAirPlayRoutes];
+
+END_BLOCK_OBJC_EXCEPTIONS
}
bool MediaSessionManageriOS::sessionWillBeginPlayback(PlatformMediaSession& session)
@@ -222,6 +234,7 @@
void MediaSessionManageriOS::updateNowPlayingInfo()
{
+BEGIN_BLOCK_OBJC_EXCEPTIONS
MPNowPlayingInfoCenter *nowPlaying = (MPNowPlayingInfoCenter *)[getMPNowPlayingInfoCenterClass() defaultCenter];
const PlatformMediaSession* currentSession = this->nowPlayingEligibleSession();
@@ -266,6 +279,7 @@
m_nowPlayingActive = true;
[nowPlaying setNowPlayingInfo:info.get()];
+END_BLOCK_OBJC_EXCEPTIONS
}
bool MediaSessionManageriOS::sessionCanLoadMedia(const PlatformMediaSession& session) const
@@ -278,9 +292,11 @@
void MediaSessionManageriOS::externalOutputDeviceAvailableDidChange()
{
+BEGIN_BLOCK_OBJC_EXCEP
[webkit-changes] [223962] trunk
Title: [223962] trunk
Revision 223962
Author aes...@apple.com
Date 2017-10-25 11:00:28 -0700 (Wed, 25 Oct 2017)
Log Message
[Payment Request] Implement the "user aborts the payment request" algorithm
https://bugs.webkit.org/show_bug.cgi?id=178810
Reviewed by Tim Horton.
Source/WebCore:
* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::didCancelPaymentSession):
* Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
* Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::cancel):
* Modules/paymentrequest/PaymentRequest.h:
* testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::cancelPayment):
* testing/MockPaymentCoordinator.h:
* testing/MockPaymentCoordinator.idl:
LayoutTests:
* http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
* http/tests/paymentrequest/payment-request-show-method.https.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https-expected.txt
trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.h
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp
trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.h
trunk/Source/WebCore/testing/MockPaymentCoordinator.cpp
trunk/Source/WebCore/testing/MockPaymentCoordinator.h
trunk/Source/WebCore/testing/MockPaymentCoordinator.idl
Diff
Modified: trunk/LayoutTests/ChangeLog (223961 => 223962)
--- trunk/LayoutTests/ChangeLog 2017-10-25 17:42:20 UTC (rev 223961)
+++ trunk/LayoutTests/ChangeLog 2017-10-25 18:00:28 UTC (rev 223962)
@@ -1,3 +1,13 @@
+2017-10-25 Andy Estes
+
+[Payment Request] Implement the "user aborts the payment request" algorithm
+https://bugs.webkit.org/show_bug.cgi?id=178810
+
+Reviewed by Tim Horton.
+
+* http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
+* http/tests/paymentrequest/payment-request-show-method.https.html:
+
2017-10-25 Daniel Bates
Attempt to fix flaky test fast/writing-mode/english-bt-text-with-spelling-marker.html following r223938
Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https-expected.txt (223961 => 223962)
--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https-expected.txt 2017-10-25 17:42:20 UTC (rev 223961)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https-expected.txt 2017-10-25 18:00:28 UTC (rev 223962)
@@ -3,4 +3,5 @@
PASS Throws if the promise [[state]] is not "created"
PASS If the user agent's "payment request is showing" boolean is true, then return a promise rejected with an "AbortError" DOMException.
PASS If payment method consultation produces no supported method of payment, then return a promise rejected with a "NotSupportedError" DOMException.
+PASS If the user aborts the payment request algorithm, then return a promise rejected with an "AbortError" DOMException.
Modified: trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html (223961 => 223962)
--- trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html 2017-10-25 17:42:20 UTC (rev 223961)
+++ trunk/LayoutTests/http/tests/paymentrequest/payment-request-show-method.https.html 2017-10-25 18:00:28 UTC (rev 223962)
@@ -65,4 +65,11 @@
const acceptPromise = request.show();
await promise_rejects(t, "NotSupportedError", acceptPromise);
}, `If payment method consultation produces no supported method of payment, then return a promise rejected with a "NotSupportedError" DOMException.`);
+
+promise_test(async t => {
+ const request = new PaymentRequest(defaultMethods, defaultDetails);
+ const acceptPromise = request.show(); // Sets state to "interactive"
+ internals.mockPaymentCoordinator.cancelPayment();
+ await promise_rejects(t, "AbortError", acceptPromise);
+}, `If the user aborts the payment request algorithm, then return a promise rejected with an "AbortError" DOMException.`);
Modified: trunk/Source/WebCore/ChangeLog (223961 => 223962)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 17:42:20 UTC (rev 223961)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 18:00:28 UTC (rev 223962)
@@ -1,3 +1,21 @@
+2017-10-25 Andy Estes
+
+[Payment Request] Implement the "user aborts the payment request" algorithm
+https://bugs.webkit.org/show_bug.cgi?id=178810
+
+Reviewed by Tim Horton.
+
+* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
+(WebCore::ApplePayPaymentHandler::didCancelPaymentSession):
+* Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
+* Modules/paymentrequest/PaymentRequest.cpp:
+(WebCore::Paym
[webkit-changes] [223961] trunk/JSTests
Title: [223961] trunk/JSTests Revision 223961 Author ryanhad...@apple.com Date 2017-10-25 10:42:20 -0700 (Wed, 25 Oct 2017) Log Message Mark test262.yaml/test262/test/language/statements/try/tco-catch.js as passing. https://bugs.webkit.org/show_bug.cgi?id=178592 Unreviewed test gardening. * test262.yaml: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262.yaml Diff Modified: trunk/JSTests/ChangeLog (223960 => 223961) --- trunk/JSTests/ChangeLog 2017-10-25 17:39:47 UTC (rev 223960) +++ trunk/JSTests/ChangeLog 2017-10-25 17:42:20 UTC (rev 223961) @@ -1,3 +1,12 @@ +2017-10-25 Ryan Haddad + +Mark test262.yaml/test262/test/language/statements/try/tco-catch.js as passing. +https://bugs.webkit.org/show_bug.cgi?id=178592 + +Unreviewed test gardening. + +* test262.yaml: + 2017-10-24 Yusuke Suzuki [FTL] Support NewStringObject Modified: trunk/JSTests/test262.yaml (223960 => 223961) --- trunk/JSTests/test262.yaml 2017-10-25 17:39:47 UTC (rev 223960) +++ trunk/JSTests/test262.yaml 2017-10-25 17:42:20 UTC (rev 223961) @@ -109630,7 +109630,7 @@ - path: test262/test/language/statements/try/tco-catch-finally.js cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js", "../../../../harness/tcoHelper.js"], [:strict] - path: test262/test/language/statements/try/tco-catch.js - cmd: runTest262 :fail, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js", "../../../../harness/tcoHelper.js"], [:strict] + cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js", "../../../../harness/tcoHelper.js"], [:strict] - path: test262/test/language/statements/try/tco-finally.js cmd: runTest262 :normal, "NoException", ["../../../../harness/assert.js", "../../../../harness/sta.js", "../../../../harness/tcoHelper.js"], [:strict] - path: test262/test/language/statements/variable/12.2.1-1-s.js ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223960] trunk/Source/WebCore
Title: [223960] trunk/Source/WebCore
Revision 223960
Author jer.no...@apple.com
Date 2017-10-25 10:39:47 -0700 (Wed, 25 Oct 2017)
Log Message
Autoplay muted videos still stop playback of other streaming apps in the background
https://bugs.webkit.org/show_bug.cgi?id=177920
Reviewed by Eric Carlson.
When creating a new or element, the global AudioSession can sometimes have
its sessionCategory() set to "MediaPlayback", even if the element does not yet have a
source. This is because the constructor for the MediaElementSession is called before
m_isPlayingToWirelessTarget is initialized, and so in the MediaElementSession constructor,
the media element's m_isPlayingToWirelessTarget ivar is sometimes (uninitialized) true.
We could move the MediaElementSession ivar to the very end of the header, so it's
initialized last, but that still leaves the possibility of the MediaElementSession et. all
calling into the HTMLMediaElement before it's subclass's constructors have a chance to
initialize their own ivars (much less their vtables). So instead, we'll create and set the
MediaElementSession in a finishInitialization() method called from the HTMLVideoElement and
HTMLAudioElement's create() factory methods.
* html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::finishInitialization):
* html/HTMLMediaElement.h:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLAudioElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLVideoElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (223959 => 223960)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 17:27:24 UTC (rev 223959)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 17:39:47 UTC (rev 223960)
@@ -1,3 +1,32 @@
+2017-10-25 Jer Noble
+
+Autoplay muted videos still stop playback of other streaming apps in the background
+https://bugs.webkit.org/show_bug.cgi?id=177920
+
+Reviewed by Eric Carlson.
+
+When creating a new or element, the global AudioSession can sometimes have
+its sessionCategory() set to "MediaPlayback", even if the element does not yet have a
+source. This is because the constructor for the MediaElementSession is called before
+m_isPlayingToWirelessTarget is initialized, and so in the MediaElementSession constructor,
+the media element's m_isPlayingToWirelessTarget ivar is sometimes (uninitialized) true.
+
+We could move the MediaElementSession ivar to the very end of the header, so it's
+initialized last, but that still leaves the possibility of the MediaElementSession et. all
+calling into the HTMLMediaElement before it's subclass's constructors have a chance to
+initialize their own ivars (much less their vtables). So instead, we'll create and set the
+MediaElementSession in a finishInitialization() method called from the HTMLVideoElement and
+HTMLAudioElement's create() factory methods.
+
+* html/HTMLAudioElement.cpp:
+(WebCore::HTMLAudioElement::create):
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::HTMLMediaElement):
+(WebCore::HTMLMediaElement::finishInitialization):
+* html/HTMLMediaElement.h:
+* html/HTMLVideoElement.cpp:
+(WebCore::HTMLVideoElement::create):
+
2017-10-25 Javier Fernandez
[css-grid] Avoid clearing the overrideContainingBlockWidth if possible
Modified: trunk/Source/WebCore/html/HTMLAudioElement.cpp (223959 => 223960)
--- trunk/Source/WebCore/html/HTMLAudioElement.cpp 2017-10-25 17:27:24 UTC (rev 223959)
+++ trunk/Source/WebCore/html/HTMLAudioElement.cpp 2017-10-25 17:39:47 UTC (rev 223960)
@@ -44,6 +44,7 @@
Ref HTMLAudioElement::create(const QualifiedName& tagName, Document& document, bool createdByParser)
{
auto element = adoptRef(*new HTMLAudioElement(tagName, document, createdByParser));
+element->finishInitialization();
element->suspendIfNeeded();
return element;
}
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (223959 => 223960)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-10-25 17:27:24 UTC (rev 223959)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2017-10-25 17:39:47 UTC (rev 223960)
@@ -457,7 +457,6 @@
, m_haveVisibleTextTrack(false)
, m_processingPreferenceChange(false)
#endif
-, m_mediaSession(std::make_unique(*this))
#if !RELEASE_LOG_DISABLED
, m_logger(&document.logger())
, m_logIdentifier(nextLogIdentifier())
@@ -468,7 +467,12 @@
ALWAYS_LOG(LOGIDENTIFIER);
setHasCustomStyleResolveCallbacks();
+}
+void HTMLMediaElement::finishInitialization()
+{
+m_mediaSession = std::make_unique(*this);
+
m_mediaSession->addBehavior
[webkit-changes] [223959] trunk/LayoutTests
Title: [223959] trunk/LayoutTests Revision 223959 Author dba...@webkit.org Date 2017-10-25 10:27:24 -0700 (Wed, 25 Oct 2017) Log Message Attempt to fix flaky test fast/writing-mode/english-bt-text-with-spelling-marker.html following r223938 (https://bugs.webkit.org/show_bug.cgi?id=178759) Call internals.updateEditorUINowIfScheduled() to force the editor UI to update and add spelling markers. * fast/writing-mode/english-bt-text-with-spelling-marker-expected.html: * fast/writing-mode/english-bt-text-with-spelling-marker.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html Diff Modified: trunk/LayoutTests/ChangeLog (223958 => 223959) --- trunk/LayoutTests/ChangeLog 2017-10-25 17:19:41 UTC (rev 223958) +++ trunk/LayoutTests/ChangeLog 2017-10-25 17:27:24 UTC (rev 223959) @@ -1,3 +1,13 @@ +2017-10-25 Daniel Bates + +Attempt to fix flaky test fast/writing-mode/english-bt-text-with-spelling-marker.html following r223938 +(https://bugs.webkit.org/show_bug.cgi?id=178759) + +Call internals.updateEditorUINowIfScheduled() to force the editor UI to update and add spelling markers. + +* fast/writing-mode/english-bt-text-with-spelling-marker-expected.html: +* fast/writing-mode/english-bt-text-with-spelling-marker.html: + 2017-10-25 Eric Carlson Web Inspector: Enable WebKit logging configuration and display Modified: trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html (223958 => 223959) --- trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html 2017-10-25 17:19:41 UTC (rev 223958) +++ trunk/LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html 2017-10-25 17:27:24 UTC (rev 223959) @@ -23,8 +23,8 @@
[webkit-changes] [223958] trunk/Source/WebKit
Title: [223958] trunk/Source/WebKit Revision 223958 Author cdu...@apple.com Date 2017-10-25 10:19:41 -0700 (Wed, 25 Oct 2017) Log Message Make SharedStringHashTable less error prone https://bugs.webkit.org/show_bug.cgi?id=178764 Reviewed by Youenn Fablet. SharedStringHashTable is backed by SharedMemory and this SharedMemory may be readonly (and is when used in the WebContent process). As a result, some of the operations on SharedStringHashTable that write to this shared memory will crash if called and the SharedMemory is readonly. To make this less error prone, introduce a new SharedStringHashTableReadOnly base class for SharedStringHashTable and only keep the operations that write to the shared memory on SharedStringHashTableReadOnly (namely, add() / remove() / clear(). Update VisitedLinkTableController and WebSWOriginTable to use SharedStringHashTableReadOnly since they are instantiated in the WebContent process and use readonly shared memory. * Shared/SharedStringHashTable.cpp: (WebKit::SharedStringHashTableReadOnly::SharedStringHashTableReadOnly): (WebKit::SharedStringHashTableReadOnly::~SharedStringHashTableReadOnly): (WebKit::SharedStringHashTableReadOnly::setSharedMemory): (WebKit::doubleHash): (WebKit::SharedStringHashTableReadOnly::contains const): (WebKit::SharedStringHashTableReadOnly::findSlot const): (WebKit::SharedStringHashTable::SharedStringHashTable): (WebKit::SharedStringHashTable::~SharedStringHashTable): (WebKit::SharedStringHashTable::add): (WebKit::SharedStringHashTable::remove): (WebKit::SharedStringHashTable::clear): * Shared/SharedStringHashTable.h: * WebProcess/Storage/WebSWOriginTable.h: * WebProcess/WebPage/VisitedLinkTableController.cpp: (WebKit::VisitedLinkTableController::removeAllVisitedLinks): * WebProcess/WebPage/VisitedLinkTableController.h: Modified Paths trunk/Source/WebKit/CMakeLists.txt trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/SharedStringHashTable.cpp trunk/Source/WebKit/Shared/SharedStringHashTable.h trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj trunk/Source/WebKit/WebProcess/Storage/WebSWOriginTable.h trunk/Source/WebKit/WebProcess/WebPage/VisitedLinkTableController.cpp trunk/Source/WebKit/WebProcess/WebPage/VisitedLinkTableController.h Added Paths trunk/Source/WebKit/Shared/SharedStringHashTableReadOnly.cpp trunk/Source/WebKit/Shared/SharedStringHashTableReadOnly.h Diff Modified: trunk/Source/WebKit/CMakeLists.txt (223957 => 223958) --- trunk/Source/WebKit/CMakeLists.txt 2017-10-25 17:18:13 UTC (rev 223957) +++ trunk/Source/WebKit/CMakeLists.txt 2017-10-25 17:19:41 UTC (rev 223958) @@ -181,6 +181,7 @@ Shared/ShareableBitmap.cpp Shared/ShareableResource.cpp Shared/SharedStringHashStore.cpp +Shared/SharedStringHashTableReadOnly.cpp Shared/SharedStringHashTable.cpp Shared/StatisticsData.cpp Shared/UpdateInfo.cpp Modified: trunk/Source/WebKit/ChangeLog (223957 => 223958) --- trunk/Source/WebKit/ChangeLog 2017-10-25 17:18:13 UTC (rev 223957) +++ trunk/Source/WebKit/ChangeLog 2017-10-25 17:19:41 UTC (rev 223958) @@ -1,3 +1,40 @@ +2017-10-25 Chris Dumez + +Make SharedStringHashTable less error prone +https://bugs.webkit.org/show_bug.cgi?id=178764 + +Reviewed by Youenn Fablet. + +SharedStringHashTable is backed by SharedMemory and this SharedMemory +may be readonly (and is when used in the WebContent process). As a result, +some of the operations on SharedStringHashTable that write to this shared +memory will crash if called and the SharedMemory is readonly. + +To make this less error prone, introduce a new SharedStringHashTableReadOnly +base class for SharedStringHashTable and only keep the operations that +write to the shared memory on SharedStringHashTableReadOnly (namely, add() / +remove() / clear(). Update VisitedLinkTableController and WebSWOriginTable +to use SharedStringHashTableReadOnly since they are instantiated in the +WebContent process and use readonly shared memory. + +* Shared/SharedStringHashTable.cpp: +(WebKit::SharedStringHashTableReadOnly::SharedStringHashTableReadOnly): +(WebKit::SharedStringHashTableReadOnly::~SharedStringHashTableReadOnly): +(WebKit::SharedStringHashTableReadOnly::setSharedMemory): +(WebKit::doubleHash): +(WebKit::SharedStringHashTableReadOnly::contains const): +(WebKit::SharedStringHashTableReadOnly::findSlot const): +(WebKit::SharedStringHashTable::SharedStringHashTable): +(WebKit::SharedStringHashTable::~SharedStringHashTable): +(WebKit::SharedStringHashTable::add): +(WebKit::SharedStringHashTable::remove): +(WebKit::SharedStringHashTable::clear): +* Shared/SharedStringHashTable.h: +* WebProcess/Storage/WebSWOriginTable.h: +* WebProcess/WebPage/VisitedLinkTableController.cpp: +(WebKit::VisitedLinkTableController::re
[webkit-changes] [223957] trunk/LayoutTests
Title: [223957] trunk/LayoutTests
Revision 223957
Author eric.carl...@apple.com
Date 2017-10-25 10:18:13 -0700 (Wed, 25 Oct 2017)
Log Message
Web Inspector: Enable WebKit logging configuration and display
https://bugs.webkit.org/show_bug.cgi?id=177027
Unreviewed, fix flakey test.
* inspector/console/webcore-logging-expected.txt:
* inspector/console/webcore-logging.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/webcore-logging-expected.txt
trunk/LayoutTests/inspector/console/webcore-logging.html
Diff
Modified: trunk/LayoutTests/ChangeLog (223956 => 223957)
--- trunk/LayoutTests/ChangeLog 2017-10-25 16:58:57 UTC (rev 223956)
+++ trunk/LayoutTests/ChangeLog 2017-10-25 17:18:13 UTC (rev 223957)
@@ -1,3 +1,14 @@
+2017-10-25 Eric Carlson
+
+Web Inspector: Enable WebKit logging configuration and display
+https://bugs.webkit.org/show_bug.cgi?id=177027
+
+
+Unreviewed, fix flakey test.
+
+* inspector/console/webcore-logging-expected.txt:
+* inspector/console/webcore-logging.html:
+
2017-10-25 Devin Rousso
Web Inspector: preserve Recordings for each Canvas after closing the Canvas tab
Modified: trunk/LayoutTests/inspector/console/webcore-logging-expected.txt (223956 => 223957)
--- trunk/LayoutTests/inspector/console/webcore-logging-expected.txt 2017-10-25 16:58:57 UTC (rev 223956)
+++ trunk/LayoutTests/inspector/console/webcore-logging-expected.txt 2017-10-25 17:18:13 UTC (rev 223957)
@@ -29,6 +29,4 @@
PASS: Media logging disabled.
PASS: Media logging has been enabled.
PASS: Media log message should have source 'media'.
-Started Playing
-Stopped Playing
Modified: trunk/LayoutTests/inspector/console/webcore-logging.html (223956 => 223957)
--- trunk/LayoutTests/inspector/console/webcore-logging.html 2017-10-25 16:58:57 UTC (rev 223956)
+++ trunk/LayoutTests/inspector/console/webcore-logging.html 2017-10-25 17:18:13 UTC (rev 223957)
@@ -145,14 +145,6 @@
resolve();
});
-InspectorTest.awaitEvent("PlayEvent").then((event) => {
-InspectorTest.log("Started Playing");
-});
-
-InspectorTest.awaitEvent("PauseEvent").then((event) => {
-InspectorTest.log("Stopped Playing");
-}).then(resolve, reject);
-
InspectorTest.evaluateInPage(`play()`);
InspectorTest.evaluateInPage(`pause()`);
})
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223956] trunk
Title: [223956] trunk
Revision 223956
Author rmoris...@apple.com
Date 2017-10-25 09:58:57 -0700 (Wed, 25 Oct 2017)
Log Message
Support the TailBench9000 benchmark in run-jsc-benchmarks
https://bugs.webkit.org/show_bug.cgi?id=178451
Reviewed by Saam Barati.
PerformanceTests:
The separation between the definition of the benchmarks (in merge-sort.js and n-body.js) and their loops (in *-run.js)
was causing trouble since the load of the js files only succeeded from the same directory. So I chose to merge them, following
the example of the other benchmarks.
* TailBench9000/merge-sort-run.js: Removed.
* TailBench9000/merge-sort.js:
* TailBench9000/n-body-run.js: Removed.
* TailBench9000/n-body.js:
Tools:
* Scripts/run-jsc-benchmarks:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/TailBench9000/merge-sort.js
trunk/PerformanceTests/TailBench9000/n-body.js
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-benchmarks
Removed Paths
trunk/PerformanceTests/TailBench9000/merge-sort-run.js
trunk/PerformanceTests/TailBench9000/n-body-run.js
Diff
Modified: trunk/PerformanceTests/ChangeLog (223955 => 223956)
--- trunk/PerformanceTests/ChangeLog 2017-10-25 16:38:14 UTC (rev 223955)
+++ trunk/PerformanceTests/ChangeLog 2017-10-25 16:58:57 UTC (rev 223956)
@@ -1,3 +1,19 @@
+2017-10-25 Robin Morisset
+
+Support the TailBench9000 benchmark in run-jsc-benchmarks
+https://bugs.webkit.org/show_bug.cgi?id=178451
+
+Reviewed by Saam Barati.
+
+The separation between the definition of the benchmarks (in merge-sort.js and n-body.js) and their loops (in *-run.js)
+was causing trouble since the load of the js files only succeeded from the same directory. So I chose to merge them, following
+the example of the other benchmarks.
+
+* TailBench9000/merge-sort-run.js: Removed.
+* TailBench9000/merge-sort.js:
+* TailBench9000/n-body-run.js: Removed.
+* TailBench9000/n-body.js:
+
2017-10-19 Michael Catanzaro
-Wsign-compare triggered by MallocBench
Deleted: trunk/PerformanceTests/TailBench9000/merge-sort-run.js (223955 => 223956)
--- trunk/PerformanceTests/TailBench9000/merge-sort-run.js 2017-10-25 16:38:14 UTC (rev 223955)
+++ trunk/PerformanceTests/TailBench9000/merge-sort-run.js 2017-10-25 16:58:57 UTC (rev 223956)
@@ -1,4 +0,0 @@
-load("merge-sort.js");
-
-for (var i = 0; i < 3000; ++i)
-TEST_mergeSort();
Modified: trunk/PerformanceTests/TailBench9000/merge-sort.js (223955 => 223956)
--- trunk/PerformanceTests/TailBench9000/merge-sort.js 2017-10-25 16:38:14 UTC (rev 223955)
+++ trunk/PerformanceTests/TailBench9000/merge-sort.js 2017-10-25 16:58:57 UTC (rev 223956)
@@ -152,3 +152,6 @@
test(0);
}
+
+for (var i = 0; i < 3000; ++i)
+TEST_mergeSort();
Deleted: trunk/PerformanceTests/TailBench9000/n-body-run.js (223955 => 223956)
--- trunk/PerformanceTests/TailBench9000/n-body-run.js 2017-10-25 16:38:14 UTC (rev 223955)
+++ trunk/PerformanceTests/TailBench9000/n-body-run.js 2017-10-25 16:58:57 UTC (rev 223956)
@@ -1,4 +0,0 @@
-load("n-body.js");
-
-for (var i = 0; i < 300; ++i)
-TEST_nBody();
Modified: trunk/PerformanceTests/TailBench9000/n-body.js (223955 => 223956)
--- trunk/PerformanceTests/TailBench9000/n-body.js 2017-10-25 16:38:14 UTC (rev 223955)
+++ trunk/PerformanceTests/TailBench9000/n-body.js 2017-10-25 16:58:57 UTC (rev 223956)
@@ -235,3 +235,6 @@
if (ret != expected)
throw "ERROR: bad result: expected " + expected + " but got " + ret;
}
+
+for (var i = 0; i < 300; ++i)
+TEST_nBody();
Modified: trunk/Tools/ChangeLog (223955 => 223956)
--- trunk/Tools/ChangeLog 2017-10-25 16:38:14 UTC (rev 223955)
+++ trunk/Tools/ChangeLog 2017-10-25 16:58:57 UTC (rev 223956)
@@ -1,3 +1,12 @@
+2017-10-25 Robin Morisset
+
+Support the TailBench9000 benchmark in run-jsc-benchmarks
+https://bugs.webkit.org/show_bug.cgi?id=178451
+
+Reviewed by Saam Barati.
+
+* Scripts/run-jsc-benchmarks:
+
2017-10-25 Adrian Perez de Castro
[WPE] Remove GLib API functions which use Cairo
Modified: trunk/Tools/Scripts/run-jsc-benchmarks (223955 => 223956)
--- trunk/Tools/Scripts/run-jsc-benchmarks 2017-10-25 16:38:14 UTC (rev 223955)
+++ trunk/Tools/Scripts/run-jsc-benchmarks 2017-10-25 16:58:57 UTC (rev 223956)
@@ -48,6 +48,7 @@
SUNSPIDER_PATH = PERFORMANCETESTS_PATH + "SunSpider" + "tests" + "sunspider-1.0"
LONGSPIDER_PATH = PERFORMANCETESTS_PATH + "LongSpider"
V8_PATH = PERFORMANCETESTS_PATH + "SunSpider" + "tests" + "v8-v6"
+TAILBENCH_PATH = PERFORMANCETESTS_PATH + "TailBench9000"
MICROBENCHMARKS_PATH = OPENSOURCE_PATH + "JSTests" + "microbenchmarks"
OCTANE_WRAPPER_PATH = PERFORMANCETESTS_PATH + "Octane" + "wrappers"
JSBENCH_PATH = PERFORMANCETESTS_PATH + "JSBench"
@@ -226,6 +227,7 @@
$includeOctane=true
$includeCompressionBench = true
$includeSixSpeed = true
+$includeTailBench = true
$measureGC=false
$b
[webkit-changes] [223955] trunk/Source/WebCore
Title: [223955] trunk/Source/WebCore
Revision 223955
Author jfernan...@igalia.com
Date 2017-10-25 09:38:14 -0700 (Wed, 25 Oct 2017)
Log Message
[css-grid] Avoid clearing the overrideContainingBlockWidth if possible
https://bugs.webkit.org/show_bug.cgi?id=178260
Reviewed by Sergio Villar Senin.
Since the intrinsic width computation uses the same logic than the
track sizing algorithm we are clearing the overrideContainingBlockWidth
of some grid items that are required to laid out them properly.
It's very uncommon that any intrinsic size computation isn't performed
as part of a layout process. However, if it happens, once cleared the
overrideContainingBlockWidth it may lead to an incorrect layout of the
affected grid items.
This change is a defensive approach to avoid the issues caused by
such off-layout preferred size requests, which may imply recomputing
the grid container intrinsic size.
No new tests, because we are only removing some redundant logic.
* rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::updateOverrideContainingBlockContentSizeForChild const):
(WebCore::IndefiniteSizeStrategy::minLogicalWidthForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
* rendering/GridTrackSizingAlgorithm.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (223954 => 223955)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 15:11:07 UTC (rev 223954)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 16:38:14 UTC (rev 223955)
@@ -1,3 +1,34 @@
+2017-10-25 Javier Fernandez
+
+[css-grid] Avoid clearing the overrideContainingBlockWidth if possible
+https://bugs.webkit.org/show_bug.cgi?id=178260
+
+Reviewed by Sergio Villar Senin.
+
+Since the intrinsic width computation uses the same logic than the
+track sizing algorithm we are clearing the overrideContainingBlockWidth
+of some grid items that are required to laid out them properly.
+
+It's very uncommon that any intrinsic size computation isn't performed
+as part of a layout process. However, if it happens, once cleared the
+overrideContainingBlockWidth it may lead to an incorrect layout of the
+affected grid items.
+
+This change is a defensive approach to avoid the issues caused by
+such off-layout preferred size requests, which may imply recomputing
+the grid container intrinsic size.
+
+No new tests, because we are only removing some redundant logic.
+
+* rendering/GridTrackSizingAlgorithm.cpp:
+(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
+(WebCore::GridTrackSizingAlgorithmStrategy::updateOverrideContainingBlockContentSizeForChild const):
+(WebCore::IndefiniteSizeStrategy::minLogicalWidthForChild const):
+(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
+* rendering/GridTrackSizingAlgorithm.h:
+
2017-10-25 Gustavo Noronha Silva
Unreviewed follow up changing one more enum value as discussed in the bug
Modified: trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp (223954 => 223955)
--- trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp 2017-10-25 15:11:07 UTC (rev 223954)
+++ trunk/Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp 2017-10-25 16:38:14 UTC (rev 223955)
@@ -742,11 +742,6 @@
{
GridTrackSizingDirection childInlineDirection = flowAwareDirectionForChild(renderGrid(), child, ForColumns);
if (direction() == childInlineDirection) {
-// If |child| has a relative logical width, we shouldn't let it override its intrinsic width, which is
-// what we are interested in here. Thus we need to set the override logical width to std::nullopt (no possible resolution).
-if (shouldClearOverrideContainingBlockContentSizeForChild(child, ForColumns))
-setOverrideContainingBlockContentSizeForChild(child, childInlineDirection, std::nullopt);
-
// FIXME: It's unclear if we should return the intrinsic width or the preferred width.
// See http://lists.w3.org/Archives/Public/www-style/2013Jan/0245.html
LayoutUnit marginLogicalWidth = child.needsLayout() ? computeMarginLogicalSizeForChild(childInlineDirection, *renderGrid(), child) : child.marginLogicalWidth();
@@ -762,11 +757,6 @@
{
GridTrackSizingDirection childInlineDirection = flowAwareDirectionForChild(renderGrid(), ch
[webkit-changes] [223954] trunk/Source/WebCore
Title: [223954] trunk/Source/WebCore
Revision 223954
Author g...@gnome.org
Date 2017-10-25 08:11:07 -0700 (Wed, 25 Oct 2017)
Log Message
Unreviewed follow up changing one more enum value as discussed in the bug
https://bugs.webkit.org/show_bug.cgi?id=177810
* platform/glib/LowPowerModeNotifierGLib.cpp:
(WebCore::LowPowerModeNotifier::updateState): use NONE instead of DISCHARGING, to ensure
it will build even with older upower.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (223953 => 223954)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 08:34:13 UTC (rev 223953)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 15:11:07 UTC (rev 223954)
@@ -1,3 +1,12 @@
+2017-10-25 Gustavo Noronha Silva
+
+Unreviewed follow up changing one more enum value as discussed in the bug
+https://bugs.webkit.org/show_bug.cgi?id=177810
+
+* platform/glib/LowPowerModeNotifierGLib.cpp:
+(WebCore::LowPowerModeNotifier::updateState): use NONE instead of DISCHARGING, to ensure
+it will build even with older upower.
+
2017-10-25 Zan Dobersek
Make SERVICE_WORKER feature buildable on GTK, WPE
Modified: trunk/Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp (223953 => 223954)
--- trunk/Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp 2017-10-25 08:34:13 UTC (rev 223953)
+++ trunk/Source/WebCore/platform/glib/LowPowerModeNotifierGLib.cpp 2017-10-25 15:11:07 UTC (rev 223954)
@@ -36,7 +36,7 @@
{
UpDeviceLevel warningLevel;
g_object_get(G_OBJECT(m_device.get()), "warning-level", &warningLevel, nullptr);
-m_lowPowerModeEnabled = warningLevel > UP_DEVICE_LEVEL_DISCHARGING && warningLevel <= UP_DEVICE_LEVEL_ACTION;
+m_lowPowerModeEnabled = warningLevel > UP_DEVICE_LEVEL_NONE && warningLevel <= UP_DEVICE_LEVEL_ACTION;
}
void LowPowerModeNotifier::warningLevelCallback(LowPowerModeNotifier* notifier)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [223953] trunk
Title: [223953] trunk Revision 223953 Author ape...@igalia.com Date 2017-10-25 01:34:13 -0700 (Wed, 25 Oct 2017) Log Message [WPE] Remove GLib API functions which use Cairo https://bugs.webkit.org/show_bug.cgi?id=178205 Reviewed by Michael Catanzaro. Source/WebKit: Add PLATFORM(GTK) guards for the parts of of the GLib API which use cairo_surface_t (web page snapshots and favicons), and remove the affected function prototypes from public API headers. This way, the WPE version of the API is not tied to Cairo. * PlatformWPE.cmake: * UIProcess/API/glib/WebKitFaviconDatabase.cpp: * UIProcess/API/glib/WebKitFaviconDatabasePrivate.h: * UIProcess/API/glib/WebKitInjectedBundleClient.cpp: * UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewConstructed): (webkitWebViewGetProperty): (webkitWebViewDispose): (webkit_web_view_class_init): (webkitWebViewLoadChanged): * UIProcess/API/glib/WebKitWebViewPrivate.h: * UIProcess/API/wpe/WebKitFaviconDatabase.h: * UIProcess/API/wpe/WebKitWebView.h: * WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp: (webkitWebPageDidReceiveMessage): Tools: Add PLATFORM(GTK) guards for the API tests (or parts of them) which use cairo_surface_t (web page snapshots and favicons) which are not available in the WPE version of the GLib API. * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: (testNotInitialized): (testPrivateBrowsing): (testFaviconDatabase): * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: (testFindControllerHide): (beforeAll): * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/PlatformWPE.cmake trunk/Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp trunk/Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabasePrivate.h trunk/Source/WebKit/UIProcess/API/glib/WebKitInjectedBundleClient.cpp trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp trunk/Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h trunk/Source/WebKit/UIProcess/API/wpe/WebKitFaviconDatabase.h trunk/Source/WebKit/UIProcess/API/wpe/WebKitWebView.h trunk/Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp trunk/Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp trunk/Tools/TestWebKitAPI/glib/WebKitGLib/WebViewTest.h Diff Modified: trunk/Source/WebKit/ChangeLog (223952 => 223953) --- trunk/Source/WebKit/ChangeLog 2017-10-25 07:39:05 UTC (rev 223952) +++ trunk/Source/WebKit/ChangeLog 2017-10-25 08:34:13 UTC (rev 223953) @@ -1,3 +1,30 @@ +2017-10-25 Adrian Perez de Castro + +[WPE] Remove GLib API functions which use Cairo +https://bugs.webkit.org/show_bug.cgi?id=178205 + +Reviewed by Michael Catanzaro. + +Add PLATFORM(GTK) guards for the parts of of the GLib API which use cairo_surface_t (web +page snapshots and favicons), and remove the affected function prototypes from public API +headers. This way, the WPE version of the API is not tied to Cairo. + +* PlatformWPE.cmake: +* UIProcess/API/glib/WebKitFaviconDatabase.cpp: +* UIProcess/API/glib/WebKitFaviconDatabasePrivate.h: +* UIProcess/API/glib/WebKitInjectedBundleClient.cpp: +* UIProcess/API/glib/WebKitWebView.cpp: +(webkitWebViewConstructed): +(webkitWebViewGetProperty): +(webkitWebViewDispose): +(webkit_web_view_class_init): +(webkitWebViewLoadChanged): +* UIProcess/API/glib/WebKitWebViewPrivate.h: +* UIProcess/API/wpe/WebKitFaviconDatabase.h: +* UIProcess/API/wpe/WebKitWebView.h: +* WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp: +(webkitWebPageDidReceiveMessage): + 2017-10-25 Zan Dobersek Make SERVICE_WORKER feature buildable on GTK, WPE Modified: trunk/Source/WebKit/PlatformWPE.cmake (223952 => 223953) --- trunk/Source/WebKit/PlatformWPE.cmake 2017-10-25 07:39:05 UTC (rev 223952) +++ trunk/Source/WebKit/PlatformWPE.cmake 2017-10-25 08:34:13 UTC (rev 223953) @@ -164,7 +164,6 @@ UIProcess/API/glib/WebKitFormSubmissionRequest.cpp UIProcess/API/glib/WebKitGeolocationPermissionRequest.cpp UIProcess/API/glib/WebKitGeolocationProvider.cpp -UIProcess/API/glib/WebKitIconLoadingClient.cpp UIProcess/API/glib/WebKitInjectedBundleClient.cpp UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequest.cpp UIProcess/API/glib/WebKitJavascriptResult.cpp Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp (223952 => 223953) --- trunk/Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp 2017-10-25 07:39:05 UTC (rev 223952) +++ trunk/Source/WebKit/UIProcess/API/glib/WebKitFaviconDatabase.cpp 2017-10-25 08:34:13 UTC (rev 223953) @@ -1,5 +1,5 @@ /* - * Copyright (C)
[webkit-changes] [223951] trunk
Title: [223951] trunk
Revision 223951
Author zandober...@gmail.com
Date 2017-10-25 00:17:21 -0700 (Wed, 25 Oct 2017)
Log Message
Make SERVICE_WORKER feature buildable on GTK, WPE
https://bugs.webkit.org/show_bug.cgi?id=178574
Reviewed by Carlos Garcia Campos.
Source/WebCore:
* CMakeLists.txt: Add missing include paths and files to the build.
* Sources.txt: Add missing files to the build.
* WebCore.xcodeproj/project.pbxproj: Remove the JSDOMPromise.cpp and
JSFetchEventCustom.cpp targets, they're now built via unified sources.
* bindings/js/JSFetchEventCustom.cpp: Guard custom JSFetchEvent code
with the ENABLE(SERVICE_WORKER) guards.
Source/WebKit:
* CMakeLists.txt: Add missing files to the build.
* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didGetWorkerContextProcessConnection):
IPC::Attachment object should be accessed through an rvalue reference,
making it mutable and enabling releasing the file descriptor.
* StorageProcess/StorageProcess.h: Adjust the method signature.
* WebProcess/Storage/ServiceWorkerClientFetch.cpp:
Explicitly include the ResourceError header from WebCore (using a forwarding header).
* WebProcess/Storage/WebServiceWorkerProvider.cpp:
Include the CachedResource header from WebCore (again using a forwarding header).
* WebProcess/Storage/WebServiceWorkerProvider.h: Forward-declare the WebCore::CachedResource type.
Source/WTF:
* wtf/Identified.h: Explicitly include the header since
std::atomic<> is used in the ThreadSafeIdentified definition.
Tools:
* Scripts/webkitperl/FeatureList.pm: Add the --service-worker option
that enables the SERVICE_WORKER feature flag. For now it's enabled
on Apple's Cocoa ports (even when build-webkit isn't used for those
builds, the flag is enabled here for consistency).
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Identified.h
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/JSFetchEventCustom.cpp
trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/StorageProcess/StorageProcess.cpp
trunk/Source/WebKit/StorageProcess/StorageProcess.h
trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp
trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp
trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
Diff
Modified: trunk/Source/WTF/ChangeLog (223950 => 223951)
--- trunk/Source/WTF/ChangeLog 2017-10-25 06:55:36 UTC (rev 223950)
+++ trunk/Source/WTF/ChangeLog 2017-10-25 07:17:21 UTC (rev 223951)
@@ -1,3 +1,13 @@
+2017-10-25 Zan Dobersek
+
+Make SERVICE_WORKER feature buildable on GTK, WPE
+https://bugs.webkit.org/show_bug.cgi?id=178574
+
+Reviewed by Carlos Garcia Campos.
+
+* wtf/Identified.h: Explicitly include the header since
+std::atomic<> is used in the ThreadSafeIdentified definition.
+
2017-10-24 Michael Saboff
WTF: Eliminated PLATFORM checks for HAVE_MACH_EXCEPTIONS
Modified: trunk/Source/WTF/wtf/Identified.h (223950 => 223951)
--- trunk/Source/WTF/wtf/Identified.h 2017-10-25 06:55:36 UTC (rev 223950)
+++ trunk/Source/WTF/wtf/Identified.h 2017-10-25 07:17:21 UTC (rev 223951)
@@ -25,6 +25,8 @@
#pragma once
+#include
+
namespace WTF {
template
Modified: trunk/Source/WebCore/CMakeLists.txt (223950 => 223951)
--- trunk/Source/WebCore/CMakeLists.txt 2017-10-25 06:55:36 UTC (rev 223950)
+++ trunk/Source/WebCore/CMakeLists.txt 2017-10-25 07:17:21 UTC (rev 223951)
@@ -129,6 +129,7 @@
"${WEBCORE_DIR}/websockets"
"${WEBCORE_DIR}/workers"
"${WEBCORE_DIR}/workers/service"
+"${WEBCORE_DIR}/workers/service/context"
"${WEBCORE_DIR}/workers/service/server"
"${WEBCORE_DIR}/xml"
"${WEBCORE_DIR}/xml/parser"
@@ -2123,6 +2124,7 @@
workers/service/ServiceWorkerClient.cpp
workers/service/ServiceWorkerClients.cpp
workers/service/ServiceWorkerContainer.cpp
+workers/service/ServiceWorkerContextData.cpp
workers/service/ServiceWorkerGlobalScope.cpp
workers/service/ServiceWorkerJob.cpp
workers/service/ServiceWorkerJobData.cpp
@@ -2133,6 +2135,10 @@
workers/service/ServiceWorkerRegistrationOptions.cpp
workers/service/ServiceWorkerWindowClient.cpp
+workers/service/context/ServiceWorkerFetch.cpp
+workers/service/context/ServiceWorkerThread.cpp
+workers/service/context/ServiceWorkerThreadProxy.cpp
+
workers/service/server/SWClientConnection.cpp
workers/service/server/SWServer.cpp
workers/service/server/SWServerRegistration.cpp
Modified: trunk/Source/WebCore/ChangeLog (223950 => 223951)
--- trunk/Source/WebCore/ChangeLog 2017-10-25 06:55:36 UTC (rev 223950)
+++ trunk/Source/WebCore/ChangeLog 2017-10-25 07:17:21 UTC (rev 223951)
@@ -1,3 +1,17 @@
+2017-10-25 Zan Dobersek
+
+
