[webkit-changes] [225445] trunk/Source/WebKit

2017-12-01 Thread zandobersek 
Title: [225445] trunk/Source/WebKit








Revision 225445
Author zandober...@gmail.com
Date 2017-12-01 22:55:52 -0800 (Fri, 01 Dec 2017)


Log Message
Unreviewed GTK+ debug build fix. Replace ASSERT_UNUSED() with UNUSED_PARAM()
in WebKit::WebPage methods that used to operate on HTMLMenuElement pointer
values (which have been converted to references).

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didInsertMenuElement):
(WebKit::WebPage::didRemoveMenuElement):
(WebKit::WebPage::didInsertMenuItemElement):
(WebKit::WebPage::didRemoveMenuItemElement):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (225444 => 225445)

--- trunk/Source/WebKit/ChangeLog	2017-12-02 06:48:27 UTC (rev 225444)
+++ trunk/Source/WebKit/ChangeLog	2017-12-02 06:55:52 UTC (rev 225445)
@@ -1,3 +1,15 @@
+2017-12-01  Zan Dobersek  
+
+Unreviewed GTK+ debug build fix. Replace ASSERT_UNUSED() with UNUSED_PARAM()
+in WebKit::WebPage methods that used to operate on HTMLMenuElement pointer
+values (which have been converted to references).
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::didInsertMenuElement):
+(WebKit::WebPage::didRemoveMenuElement):
+(WebKit::WebPage::didInsertMenuItemElement):
+(WebKit::WebPage::didRemoveMenuItemElement):
+
 2017-12-01  Simon Fraser  
 
 Reduce the number of calls to ViewportConfiguration::updateConfiguration()


Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (225444 => 225445)

--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2017-12-02 06:48:27 UTC (rev 225444)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2017-12-02 06:55:52 UTC (rev 225445)
@@ -5127,7 +5127,7 @@
 #if PLATFORM(COCOA)
 sendTouchBarMenuDataAddedUpdate(element);
 #else
-ASSERT_UNUSED(element, element);
+UNUSED_PARAM(element);
 #endif
 }
 
@@ -5136,7 +5136,7 @@
 #if PLATFORM(COCOA)
 sendTouchBarMenuDataRemovedUpdate(element);
 #else
-ASSERT_UNUSED(element, element);
+UNUSED_PARAM(element);
 #endif
 }
 
@@ -5145,7 +5145,7 @@
 #if PLATFORM(COCOA)
 sendTouchBarMenuItemDataAddedUpdate(element);
 #else
-ASSERT_UNUSED(element, element);
+UNUSED_PARAM(element);
 #endif
 }
 
@@ -5154,7 +5154,7 @@
 #if PLATFORM(COCOA)
 sendTouchBarMenuItemDataRemovedUpdate(element);
 #else
-ASSERT_UNUSED(element, element);
+UNUSED_PARAM(element);
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225444] trunk/JSTests

2017-12-01 Thread jfbastien 
Title: [225444] trunk/JSTests








Revision 225444
Author jfbast...@apple.com
Date 2017-12-01 22:48:27 -0800 (Fri, 01 Dec 2017)


Log Message
Try proxying all function arguments
https://bugs.webkit.org/show_bug.cgi?id=180306

Reviewed by Saam Barati.

* stress/proxy-all-the-parameters.js: Added.
(isPropertyOfType):
(getProperties):
(generateObjects):
(getObjects):
(getFunctions):
(get throw):
(let.o.of.getObjects.let.f.of.getFunctions.catch):

Modified Paths

trunk/JSTests/ChangeLog


Added Paths

trunk/JSTests/stress/proxy-all-the-parameters.js




Diff

Modified: trunk/JSTests/ChangeLog (225443 => 225444)

--- trunk/JSTests/ChangeLog	2017-12-02 05:44:04 UTC (rev 225443)
+++ trunk/JSTests/ChangeLog	2017-12-02 06:48:27 UTC (rev 225444)
@@ -1,5 +1,21 @@
 2017-12-01  JF Bastien  
 
+Try proxying all function arguments
+https://bugs.webkit.org/show_bug.cgi?id=180306
+
+Reviewed by Saam Barati.
+
+* stress/proxy-all-the-parameters.js: Added.
+(isPropertyOfType):
+(getProperties):
+(generateObjects):
+(getObjects):
+(getFunctions):
+(get throw):
+(let.o.of.getObjects.let.f.of.getFunctions.catch):
+
+2017-12-01  JF Bastien  
+
 _javascript_Core: missing exception checks in Math functions that take more than one argument
 https://bugs.webkit.org/show_bug.cgi?id=180297
 


Added: trunk/JSTests/stress/proxy-all-the-parameters.js (0 => 225444)

--- trunk/JSTests/stress/proxy-all-the-parameters.js	(rev 0)
+++ trunk/JSTests/stress/proxy-all-the-parameters.js	2017-12-02 06:48:27 UTC (rev 225444)
@@ -0,0 +1,70 @@
+const verbose = false;
+
+const ignore = ['quit', 'readline', 'waitForReport', 'flashHeapAccess', 'leaving', 'getReport'];
+
+function isPropertyOfType(obj, name, type) {
+let desc;
+desc = Object.getOwnPropertyDescriptor(obj, name)
+return typeof type === 'undefined' || typeof desc.value === type;
+}
+
+function getProperties(obj, type) {
+let properties = [];
+for (let name of Object.getOwnPropertyNames(obj)) {
+if (isPropertyOfType(obj, name, type))
+properties.push(name);
+}
+return properties;
+}
+
+function* generateObjects(root = this, level = 0) {
+if (level > 4)
+return;
+let obj_names = getProperties(root, 'object');
+for (let obj_name of obj_names) {
+let obj = root[obj_name];
+yield obj;
+yield* generateObjects(obj, level + 1);
+}
+}
+
+function getObjects() {
+let objects = [];
+for (let obj of generateObjects())
+if (!objects.includes(obj))
+objects.push(obj);
+return objects;
+}
+
+function getFunctions(obj) {
+return getProperties(obj, 'function');
+}
+
+const thrower = new Proxy({}, { get() { throw 0xc0defefe; } });
+
+for (let o of getObjects()) {
+for (let f of getFunctions(o)) {
+if (ignore.includes(f))
+continue;
+const arityPlusOne = o[f].length + 1;
+if (verbose)
+print(`Calling ${o}['${f}'](${Array(arityPlusOne).fill("thrower")})`);
+try {
+o[f](Array(arityPlusOne).fill(thrower));
+} catch (e) {
+if (`${e}`.includes('constructor without new is invalid')) {
+try {
+if (verbose)
+print(`Constructing instead`);
+new o[f](Array(arityPlusOne).fill(thrower));
+} catch (e) {
+if (verbose)
+print(`threw ${e}`);
+}
+} else {
+if (verbose)
+print(`threw ${e}`);
+}
+}
+}
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225443] trunk

2017-12-01 Thread jfbastien 
Title: [225443] trunk








Revision 225443
Author jfbast...@apple.com
Date 2017-12-01 21:44:04 -0800 (Fri, 01 Dec 2017)


Log Message
_javascript_Core: missing exception checks in Math functions that take more than one argument
https://bugs.webkit.org/show_bug.cgi?id=180297


Reviewed by Mark Lam.

JSTests:

* stress/math-exceptions.js: Added.
(get try):
(catch):

Source/_javascript_Core:

* runtime/MathObject.cpp:
(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/MathObject.cpp


Added Paths

trunk/JSTests/stress/math-exceptions.js




Diff

Modified: trunk/JSTests/ChangeLog (225442 => 225443)

--- trunk/JSTests/ChangeLog	2017-12-02 05:39:30 UTC (rev 225442)
+++ trunk/JSTests/ChangeLog	2017-12-02 05:44:04 UTC (rev 225443)
@@ -1,5 +1,17 @@
 2017-12-01  JF Bastien  
 
+_javascript_Core: missing exception checks in Math functions that take more than one argument
+https://bugs.webkit.org/show_bug.cgi?id=180297
+
+
+Reviewed by Mark Lam.
+
+* stress/math-exceptions.js: Added.
+(get try):
+(catch):
+
+2017-12-01  JF Bastien  
+
 _javascript_Core: add test for weird class static getters
 https://bugs.webkit.org/show_bug.cgi?id=180281
 


Added: trunk/JSTests/stress/math-exceptions.js (0 => 225443)

--- trunk/JSTests/stress/math-exceptions.js	(rev 0)
+++ trunk/JSTests/stress/math-exceptions.js	2017-12-02 05:44:04 UTC (rev 225443)
@@ -0,0 +1,47 @@
+const foo = new Proxy({}, {
+get() { throw 0xc0defefe; }
+});
+
+const bar = new Proxy({}, {
+get() { throw 0xdeadbeef; }
+});
+
+const check = value => {
+if (value !== 0xc0defefe)
+throw new Error(`bad ${value}!`);
+}
+
+try { Math.acos(foo, bar); } catch (e) { check(e); }
+try { Math.acosh(foo, bar); } catch (e) { check(e); }
+try { Math.asin(foo, bar); } catch (e) { check(e); }
+try { Math.asinh(foo, bar); } catch (e) { check(e); }
+try { Math.atan(foo, bar); } catch (e) { check(e); }
+try { Math.atanh(foo, bar); } catch (e) { check(e); }
+try { Math.atan2(foo, bar); } catch (e) { check(e); }
+try { Math.cbrt(foo, bar); } catch (e) { check(e); }
+try { Math.ceil(foo, bar); } catch (e) { check(e); }
+try { Math.clz32(foo, bar); } catch (e) { check(e); }
+try { Math.cos(foo, bar); } catch (e) { check(e); }
+try { Math.cosh(foo, bar); } catch (e) { check(e); }
+try { Math.exp(foo, bar); } catch (e) { check(e); }
+try { Math.expm1(foo, bar); } catch (e) { check(e); }
+try { Math.floor(foo, bar); } catch (e) { check(e); }
+try { Math.fround(foo, bar); } catch (e) { check(e); }
+try { Math.hypot(foo, bar); } catch (e) { check(e); }
+try { Math.imul(foo, bar); } catch (e) { check(e); }
+try { Math.log(foo, bar); } catch (e) { check(e); }
+try { Math.log1p(foo, bar); } catch (e) { check(e); }
+try { Math.log10(foo, bar); } catch (e) { check(e); }
+try { Math.log2(foo, bar); } catch (e) { check(e); }
+try { Math.max(foo, bar); } catch (e) { check(e); }
+try { Math.min(foo, bar); } catch (e) { check(e); }
+try { Math.pow(foo, bar); } catch (e) { check(e); }
+Math.random(foo, bar);
+try { Math.round(foo, bar); } catch (e) { check(e); }
+try { Math.sign(foo, bar); } catch (e) { check(e); }
+try { Math.sin(foo, bar); } catch (e) { check(e); }
+try { Math.sinh(foo, bar); } catch (e) { check(e); }
+try { Math.sqrt(foo, bar); } catch (e) { check(e); }
+try { Math.tan(foo, bar); } catch (e) { check(e); }
+try { Math.tanh(foo, bar); } catch (e) { check(e); }
+try { Math.trunc(foo, bar); } catch (e) { check(e); }


Modified: trunk/Source/_javascript_Core/ChangeLog (225442 => 225443)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-02 05:39:30 UTC (rev 225442)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-02 05:44:04 UTC (rev 225443)
@@ -1,3 +1,17 @@
+2017-12-01  JF Bastien  
+
+_javascript_Core: missing exception checks in Math functions that take more than one argument
+https://bugs.webkit.org/show_bug.cgi?id=180297
+
+
+Reviewed by Mark Lam.
+
+* runtime/MathObject.cpp:
+(JSC::mathProtoFuncATan2):
+(JSC::mathProtoFuncMax):
+(JSC::mathProtoFuncMin):
+(JSC::mathProtoFuncPow):
+
 2017-12-01  Mark Lam  
 
 Let's scramble ClassInfo pointers in cells.


Modified: trunk/Source/_javascript_Core/runtime/MathObject.cpp (225442 => 225443)

--- trunk/Source/_javascript_Core/runtime/MathObject.cpp	2017-12-02 05:39:30 UTC (rev 225442)
+++ trunk/Source/_javascript_Core/runtime/MathObject.cpp	2017-12-02 05:44:04 UTC (rev 225443)
@@ -149,8 +149,12 @@
 
 EncodedJSValue JSC_HOST_CALL mathProtoFuncATan2(ExecState* exec)
 {
+VM& vm = exec->vm();
+auto scope = DECLARE_THROW_SCOPE(vm);
 double arg0 =

[webkit-changes] [225442] trunk

2017-12-01 Thread commit-queue 
Title: [225442] trunk








Revision 225442
Author commit-qu...@webkit.org
Date 2017-12-01 21:39:30 -0800 (Fri, 01 Dec 2017)


Log Message
[MSE] Use correct range end checks in sourceBufferPrivateDidReceiveSample()
https://bugs.webkit.org/show_bug.cgi?id=179690

Patch by Alicia Boya García  on 2017-12-01
Reviewed by Jer Noble.

Source/WebCore:

The Coded Frame Processing algorithm as defined in
https://www.w3.org/TR/media-source/#sourcebuffer-coded-frame-processing states:

1.14. Remove existing coded frames in track buffer:
 -> If highest end timestamp for track buffer is not set:
   [...]
 -> If highest end timestamp for track buffer is set and less than or
equal to presentation timestamp:
   Remove all coded frames from track buffer that have a
   presentation timestamp greater than or equal to highest end
   timestamp and less than frame end timestamp.

Note the removal range is closed-open [a, b). WebKit is actually removing
frames using an open-closed range (a, b], which causes frames not to be removed
in situations where they should and frames to be removed in situations when
they should not.

Tests: media/media-source/media-source-range-end-frame-not-removed.html
   media/media-source/media-source-range-start-frame-replaced.html

* Modules/mediasource/SampleMap.cpp:
(WebCore::PresentationOrderSampleMap::findSamplesBetweenPresentationTimesFromEnd):
* Modules/mediasource/SampleMap.h:
* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

LayoutTests:

Added test cases for bug #179690.

* media/media-source/media-source-range-end-frame-not-removed-expected.txt: Added.
* media/media-source/media-source-range-end-frame-not-removed.html: Added.
* media/media-source/media-source-range-start-frame-replaced-expected.txt: Added.
* media/media-source/media-source-range-start-frame-replaced.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/SampleMap.cpp
trunk/Source/WebCore/Modules/mediasource/SampleMap.h
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
trunk/Tools/TestWebKitAPI/Tests/WebCore/SampleMap.cpp


Added Paths

trunk/LayoutTests/media/media-source/media-source-range-end-frame-not-removed-expected.txt
trunk/LayoutTests/media/media-source/media-source-range-end-frame-not-removed.html
trunk/LayoutTests/media/media-source/media-source-range-start-frame-replaced-expected.txt
trunk/LayoutTests/media/media-source/media-source-range-start-frame-replaced.html




Diff

Modified: trunk/LayoutTests/ChangeLog (225441 => 225442)

--- trunk/LayoutTests/ChangeLog	2017-12-02 03:19:16 UTC (rev 225441)
+++ trunk/LayoutTests/ChangeLog	2017-12-02 05:39:30 UTC (rev 225442)
@@ -1,3 +1,17 @@
+2017-12-01  Alicia Boya García  
+
+[MSE] Use correct range end checks in sourceBufferPrivateDidReceiveSample()
+https://bugs.webkit.org/show_bug.cgi?id=179690
+
+Reviewed by Jer Noble.
+
+Added test cases for bug #179690.
+
+* media/media-source/media-source-range-end-frame-not-removed-expected.txt: Added.
+* media/media-source/media-source-range-end-frame-not-removed.html: Added.
+* media/media-source/media-source-range-start-frame-replaced-expected.txt: Added.
+* media/media-source/media-source-range-start-frame-replaced.html: Added.
+
 2017-12-01  Ms2ger  
 
 [WPE] Enable wpt css tests.


Added: trunk/LayoutTests/media/media-source/media-source-range-end-frame-not-removed-expected.txt (0 => 225442)

--- trunk/LayoutTests/media/media-source/media-source-range-end-frame-not-removed-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-range-end-frame-not-removed-expected.txt	2017-12-02 05:39:30 UTC (rev 225442)
@@ -0,0 +1,22 @@
+
+RUN(video.src = ""
+EVENT(sourceopen)
+RUN(sourceBuffer = source.addSourceBuffer("video/mock; codecs=mock"))
+RUN(sourceBuffer.appendBuffer(initSegment))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(samples))
+EVENT(updateend)
+RUN(sourceBuffer.appendBuffer(samples))
+EVENT(updateend)
+EXPECTED (bufferedSamples.length == '6') OK
+{PTS({0/1000 = 0.00}), DTS({0/1000 = 0.00}), duration({1000/1000 = 1.00}), flags(1), generation(0)}
+{PTS({1000/1000 = 1.00}), DTS({1000/1000 = 1.00}), duration({1000/1000 = 1.00}), flags(1), generation(0)}
+{PTS({2000/1000 = 2.00}), DTS({2000/1000 = 2.00}), duration({1000/1000 = 1.00}), flags(1), generation(0)}
+{PTS({3000/1000 = 3.00}), DTS({3000/1000 = 3.00}), duration({1000/1000 = 1.00}), flags(1), generation(0)}
+{PTS({4000/1000 = 4.00}), DTS({4000/1000 = 4.00}), duration({1000/1000 = 1.00}), flags(1), generation(0)}
+{PTS({5000/1000 = 5.00}), DTS({5000/1000 = 5.00}), duration({1000/1000 = 1.00}), flags(1), generation(0)}
+EXPECTED (sourceBuffer.buffered.length == '1') OK

[webkit-changes] [225441] trunk/Source

2017-12-01 Thread simon . fraser 
Title: [225441] trunk/Source








Revision 225441
Author simon.fra...@apple.com
Date 2017-12-01 19:19:16 -0800 (Fri, 01 Dec 2017)


Log Message
Reduce the number of calls to ViewportConfiguration::updateConfiguration()
https://bugs.webkit.org/show_bug.cgi?id=180299

Reviewed by Zalan Bujtas.

There are several calls to ViewportConfiguration::setDefaultConfiguration() during loading
with the same arguments. We can avoid unnecessary calls to updateConfiguration() by returning
early if the configuration hasn't changed.

Source/WebCore:

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::setDefaultConfiguration):
* page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::Parameters::operator== const):

Source/WebKit:

Also move the fetching of ViewportConfiguration::xhtmlMobileParameters() from didReceiveMobileDocType()
into resetViewportDefaultConfiguration() where we grab all the other default configs.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didReceiveMobileDocType):
(WebKit::WebPage::resetViewportDefaultConfiguration):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ViewportConfiguration.cpp
trunk/Source/WebCore/page/ViewportConfiguration.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (225440 => 225441)

--- trunk/Source/WebCore/ChangeLog	2017-12-02 01:56:40 UTC (rev 225440)
+++ trunk/Source/WebCore/ChangeLog	2017-12-02 03:19:16 UTC (rev 225441)
@@ -1,3 +1,19 @@
+2017-12-01  Simon Fraser  
+
+Reduce the number of calls to ViewportConfiguration::updateConfiguration()
+https://bugs.webkit.org/show_bug.cgi?id=180299
+
+Reviewed by Zalan Bujtas.
+
+There are several calls to ViewportConfiguration::setDefaultConfiguration() during loading
+with the same arguments. We can avoid unnecessary calls to updateConfiguration() by returning
+early if the configuration hasn't changed.
+
+* page/ViewportConfiguration.cpp:
+(WebCore::ViewportConfiguration::setDefaultConfiguration):
+* page/ViewportConfiguration.h:
+(WebCore::ViewportConfiguration::Parameters::operator== const):
+
 2017-12-01  Aishwarya Nirmal  
 
 [Touch Bar Web API] Object representing Touch Bar Menu to send between Web and UI Processes


Modified: trunk/Source/WebCore/page/ViewportConfiguration.cpp (225440 => 225441)

--- trunk/Source/WebCore/page/ViewportConfiguration.cpp	2017-12-02 01:56:40 UTC (rev 225440)
+++ trunk/Source/WebCore/page/ViewportConfiguration.cpp	2017-12-02 03:19:16 UTC (rev 225441)
@@ -62,6 +62,9 @@
 ASSERT(defaultConfiguration.minimumScale > 0);
 ASSERT(defaultConfiguration.maximumScale >= defaultConfiguration.minimumScale);
 
+if (m_defaultConfiguration == defaultConfiguration)
+return;
+
 m_defaultConfiguration = defaultConfiguration;
 updateConfiguration();
 }


Modified: trunk/Source/WebCore/page/ViewportConfiguration.h (225440 => 225441)

--- trunk/Source/WebCore/page/ViewportConfiguration.h	2017-12-02 01:56:40 UTC (rev 225440)
+++ trunk/Source/WebCore/page/ViewportConfiguration.h	2017-12-02 03:19:16 UTC (rev 225441)
@@ -56,6 +56,14 @@
 bool widthIsSet { false };
 bool heightIsSet { false };
 bool initialScaleIsSet { false };
+
+bool operator==(const Parameters& other) const
+{
+return width == other.width && height == other.height
+&& initialScale == other.initialScale && minimumScale == other.minimumScale && maximumScale == other.maximumScale
+&& allowsUserScaling == other.allowsUserScaling && allowsShrinkToFit == other.allowsShrinkToFit && avoidsUnsafeArea == other.avoidsUnsafeArea
+&& widthIsSet == other.widthIsSet && heightIsSet == other.heightIsSet && initialScaleIsSet == other.initialScaleIsSet;
+}
 };
 
 WEBCORE_EXPORT ViewportConfiguration();


Modified: trunk/Source/WebKit/ChangeLog (225440 => 225441)

--- trunk/Source/WebKit/ChangeLog	2017-12-02 01:56:40 UTC (rev 225440)
+++ trunk/Source/WebKit/ChangeLog	2017-12-02 03:19:16 UTC (rev 225441)
@@ -1,3 +1,22 @@
+2017-12-01  Simon Fraser  
+
+Reduce the number of calls to ViewportConfiguration::updateConfiguration()
+https://bugs.webkit.org/show_bug.cgi?id=180299
+
+Reviewed by Zalan Bujtas.
+
+There are several calls to ViewportConfiguration::setDefaultConfiguration() during loading
+with the same arguments. We can avoid unnecessary calls to updateConfiguration() by returning
+early if the configuration hasn't changed.
+
+Also move the fetching of ViewportConfiguration::xhtmlMobileParameters() from didReceiveMobileDocType()
+into resetViewportDefaultConfiguration() where we

[webkit-changes] [225440] trunk/Tools

2017-12-01 Thread dewei_zhu 
Title: [225440] trunk/Tools








Revision 225440
Author dewei_...@apple.com
Date 2017-12-01 17:56:40 -0800 (Fri, 01 Dec 2017)


Log Message
Hardcoded python path is not compatible with virtual environment.
https://bugs.webkit.org/show_bug.cgi?id=180300

Reviewed by Stephanie Lewis.

Hardcoding '/usr/bin/python' does not work with python virtual environment.
Use 'python' instead.

* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver.serve):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py




Diff

Modified: trunk/Tools/ChangeLog (225439 => 225440)

--- trunk/Tools/ChangeLog	2017-12-02 01:56:20 UTC (rev 225439)
+++ trunk/Tools/ChangeLog	2017-12-02 01:56:40 UTC (rev 225440)
@@ -1,3 +1,16 @@
+2017-12-01  Dewei Zhu  
+
+Hardcoded python path is not compatible with virtual environment.
+https://bugs.webkit.org/show_bug.cgi?id=180300
+
+Reviewed by Stephanie Lewis.
+
+Hardcoding '/usr/bin/python' does not work with python virtual environment.
+Use 'python' instead.
+
+* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
+(SimpleHTTPServerDriver.serve):
+
 2017-12-01  Aakash Jain  
 
 [build.webkit.org] Move python code to load config from master.cfg in separate file


Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py (225439 => 225440)

--- trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py	2017-12-02 01:56:20 UTC (rev 225439)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py	2017-12-02 01:56:40 UTC (rev 225440)
@@ -30,7 +30,7 @@
 def serve(self, web_root):
 _log.info('Launching an http server')
 http_server_path = os.path.join(os.path.dirname(os.path.abspath(__file__)), "http_server/twisted_http_server.py")
-self._server_process = subprocess.Popen(["/usr/bin/python", http_server_path, web_root], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+self._server_process = subprocess.Popen(["python", http_server_path, web_root], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
 
 max_attempt = 5
 interval = 0.5






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225439] trunk/LayoutTests

2017-12-01 Thread Ms2ger 
Title: [225439] trunk/LayoutTests








Revision 225439
Author ms2...@igalia.com
Date 2017-12-01 17:56:20 -0800 (Fri, 01 Dec 2017)


Log Message
[WPE] Enable wpt css tests.
https://bugs.webkit.org/show_bug.cgi?id=180289

Unreviewed test gardening.


* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225438 => 225439)

--- trunk/LayoutTests/ChangeLog	2017-12-02 01:38:50 UTC (rev 225438)
+++ trunk/LayoutTests/ChangeLog	2017-12-02 01:56:20 UTC (rev 225439)
@@ -1,3 +1,12 @@
+2017-12-01  Ms2ger  
+
+[WPE] Enable wpt css tests.
+https://bugs.webkit.org/show_bug.cgi?id=180289
+
+Unreviewed test gardening.
+
+* platform/wpe/TestExpectations:
+
 2017-12-01  Matt Lewis  
 
 Marked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky timeout on wk1.


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (225438 => 225439)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2017-12-02 01:38:50 UTC (rev 225438)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2017-12-02 01:56:20 UTC (rev 225439)
@@ -208,7 +208,6 @@
 Bug(WPE) imported/w3c/web-platform-tests/background-fetch [ Skip ]
 Bug(WPE) imported/w3c/web-platform-tests/beacon [ Skip ]
 Bug(WPE) imported/w3c/web-platform-tests/cors [ Skip ]
-Bug(WPE) imported/w3c/web-platform-tests/css [ Skip ]
 Bug(WPE) imported/w3c/web-platform-tests/css-timing-1 [ Skip ]
 Bug(WPE) imported/w3c/web-platform-tests/custom-elements [ Skip ]
 Bug(WPE) imported/w3c/web-platform-tests/feature-policy [ Skip ]
@@ -228,6 +227,41 @@
 imported/w3c/web-platform-tests/dom/nodes/Document-constructor-svg.svg [ Timeout ]
 
 
+# WPT: css
+# 
+imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-items-sizing-alignment-001.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-grid-1/grid-layout-properties.html [ Pass ]
+
+webkit.org/b/177362 imported/w3c/web-platform-tests/css/css-pseudo-4/marker-font-properties.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-pseudo-4/first-letter-002.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-pseudo-4/first-letter-003.html [ Pass ]
+
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/supported-shapes/circle/shape-outside-circle-027.html [ ImageOnlyFailure ]
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-margin-001.html [ Failure ]
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-004.html [ Failure ]
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-circle-005.html [ Failure ]
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-004.html [ Failure ]
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-ellipse-005.html [ Failure ]
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-inset-003.html [ Failure ]
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-polygon-004.html [ Failure ]
+webkit.org/b/136065 imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/values/shape-outside-shape-arguments-000.html [ Failure ]
+imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-shapes-1/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003.html [ Pass ]
+
+webkit.org/b/179113 imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-013.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/css/css-ui-3/box-sizing-026.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-ui-3/outline-006.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-012.html [ Pass ]
+webkit.org/b/175290 imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-005.html [ Pass ]
+
+imported/w3c/web-platform-tests/css/selectors4/selector-placeholder-shown-type-change-001.html [ Pass ]
+imported/w3c/web-platform-tests/css/selectors4/selector-placeholder-shown-type-change-002.html [ Pass ]
+imported/w3c/web-platform-tests/css/selectors4/selector-placeholder-shown-type-change-003.html [ Pass ]
+imported/w3c/web-platform-tests/css/selectors4/selector-read-write-type-change-002.html [ Pass ]
+imported/w3c/web-platform-tests/css/selectors4/selector-required-type-change-002.html [ Pass ]
+
+
 # WPT: cssom
 # ==
 imported/w3c/web-platform-tests/cssom [ Pass ]

[webkit-changes] [225438] trunk/Source

2017-12-01 Thread commit-queue 
Title: [225438] trunk/Source








Revision 225438
Author commit-qu...@webkit.org
Date 2017-12-01 17:38:50 -0800 (Fri, 01 Dec 2017)


Log Message
[Touch Bar Web API] Object representing Touch Bar Menu to send between Web and UI Processes
https://bugs.webkit.org/show_bug.cgi?id=179714

Patch by Aishwarya Nirmal  on 2017-12-01
Reviewed by Wenson Hsieh.

Source/WebCore:

These changes allow the HTMLMenuElement and HTMLMenuItemElement to parse attributes relating
to the touch bar and convey changes to the elements that will eventually be propogated to the
UI process.

No new tests at this point because the changes to HTMLMenuElement and HTMLMenuItemElement are
new properties, which might not be worth testing, and overriden methods for insertedIntoAncestor
and removedFromAncestor, which are involved in sending a message to a UI process but might be
difficult to test at this point since the UI process only receives (and does not yet process)
the message.

* html/HTMLMenuElement.cpp:
(WebCore::HTMLMenuElement::insertedIntoAncestor):
(WebCore::HTMLMenuElement::removedFromAncestor):
(WebCore::HTMLMenuElement::parseAttribute):
* html/HTMLMenuElement.h:
* html/HTMLMenuItemElement.cpp:
(WebCore::HTMLMenuItemElement::insertedIntoAncestor):
(WebCore::HTMLMenuItemElement::removedFromAncestor):
* html/HTMLMenuItemElement.h:
* page/ChromeClient.h:

Source/WebKit:

These changes define the TouchBarMenuData and TouchBarMenuItemData objects which draw information
from touch bar HTMLMenuElement and HTMLMenuItemElement. These objects represent the contents of
the page-customized touch bar. Changes to the html elements representing the touch bar are sent
to the UI process.

* Shared/TouchBarMenuData.cpp: Copied from Source/WebCore/html/HTMLMenuItemElement.cpp.
(WebKit::TouchBarMenuData::TouchBarMenuData):
(WebKit::TouchBarMenuData::addMenuItem):
(WebKit::TouchBarMenuData::removeMenuItem):
(WebKit::TouchBarMenuData::encode const):
(WebKit::TouchBarMenuData::decode):
* Shared/TouchBarMenuData.h: Copied from Source/WebCore/html/HTMLMenuItemElement.h.
(WebKit::TouchBarMenuData::items):
(WebKit::TouchBarMenuData::isPageCustomized):
(WebKit::TouchBarMenuData::setIsPageCustomized):
* Shared/TouchBarMenuItemData.cpp: Added.
(WebKit::TouchBarMenuItemData::getItemType):
(WebKit::TouchBarMenuItemData::TouchBarMenuItemData):
(WebKit::TouchBarMenuItemData::encode const):
(WebKit::TouchBarMenuItemData::decode):
* Shared/TouchBarMenuItemData.h: Added.
(WebKit::operator<):
(WebKit::operator>):
(WebKit::operator<=):
(WebKit::operator>=):
(WebKit::operator==):
(WebKit::operator!=):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::touchBarMenuDataChanged):
(WebKit::WebPageProxy::touchBarMenuItemDataAdded):
(WebKit::WebPageProxy::touchBarMenuItemDataRemoved):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::touchBarMenuData const):
* UIProcess/WebPageProxy.messages.in:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didInsertMenuElement):
(WebKit::WebChromeClient::didRemoveMenuElement):
(WebKit::WebChromeClient::didInsertMenuItemElement):
(WebKit::WebChromeClient::didRemoveMenuItemElement):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didInsertMenuElement):
(WebKit::WebPage::didRemoveMenuElement):
(WebKit::WebPage::didInsertMenuItemElement):
(WebKit::WebPage::didRemoveMenuItemElement):
(WebKit::WebPage::sendTouchBarMenuDataRemovedUpdate):
(WebKit::WebPage::sendTouchBarMenuDataAddedUpdate):
(WebKit::WebPage::sendTouchBarMenuItemDataAddedUpdate):
(WebKit::WebPage::sendTouchBarMenuItemDataRemovedUpdate):
* WebProcess/WebPage/WebPage.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMenuElement.cpp
trunk/Source/WebCore/html/HTMLMenuElement.h
trunk/Source/WebCore/html/HTMLMenuItemElement.cpp
trunk/Source/WebCore/html/HTMLMenuItemElement.h
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h


Added Paths

trunk/Source/WebKit/Shared/TouchBarMenuData.cpp
trunk/Source/WebKit/Shared/TouchBarMenuData.h
trunk/Source/WebKit/Shared/TouchBarMenuItemData.cpp
trunk/Source/WebKit/Shared/TouchBarMenuItemData.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225437 => 225438)

--- trunk/Source/WebCore/ChangeLog	2017-12-02 01:12:48 UTC (rev 225437)
+++ trunk/Source/WebCore/ChangeLog	2017-12-02 01:38:50 UTC (rev 225438)
@@ -1,3 +1,31 @@
+2017-12-01  Aishwarya Nirmal  
+
+[Touch Bar Web API] Object representing Touch Bar Menu

[webkit-changes] [225437] trunk/Source

2017-12-01 Thread mark . lam 
Title: [225437] trunk/Source








Revision 225437
Author mark@apple.com
Date 2017-12-01 17:12:48 -0800 (Fri, 01 Dec 2017)


Log Message
Let's scramble ClassInfo pointers in cells.
https://bugs.webkit.org/show_bug.cgi?id=180291


Reviewed by JF Bastien.

Source/_javascript_Core:

* API/JSCallbackObject.h:
* API/JSObjectRef.cpp:
(classInfoPrivate):
* _javascript_Core.xcodeproj/project.pbxproj:
* Sources.txt:
* assembler/MacroAssemblerCodeRef.cpp:
(JSC::MacroAssemblerCodePtr::initialize): Deleted.
* assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr:: const):
(JSC::MacroAssemblerCodePtr::hash const):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::compileCheckSubClass):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNewStringObject):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitAllocateDestructibleObject):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::loadArgumentWithSpecificClass):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreading):
* runtime/JSCScrambledPtr.cpp: Added.
(JSC::initializeScrambledPtrKeys):
* runtime/JSCScrambledPtr.h: Added.
* runtime/JSDestructibleObject.h:
(JSC::JSDestructibleObject::classInfo const):
* runtime/JSSegmentedVariableObject.h:
(JSC::JSSegmentedVariableObject::classInfo const):
* runtime/Structure.h:
* runtime/VM.h:

Source/WTF:

* wtf/ScrambledPtr.h:
(WTF::ScrambledPtr::descrambled const):
(WTF::ScrambledPtr::bits const):
(WTF::ScrambledPtr::operator==):
(WTF::ScrambledPtr::operator=):
(WTF::ScrambledPtr::scramble):
(WTF::ScrambledPtr::descramble):
(WTF::ScrambledPtr:: const): Deleted.
(WTF::ScrambledPtr::scrambledBits const): Deleted.

Modified Paths

trunk/Source/_javascript_Core/API/JSCallbackObject.h
trunk/Source/_javascript_Core/API/JSObjectRef.cpp
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/Sources.txt
trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerCodeRef.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
trunk/Source/_javascript_Core/jit/SpecializedThunkJIT.h
trunk/Source/_javascript_Core/runtime/InitializeThreading.cpp
trunk/Source/_javascript_Core/runtime/JSDestructibleObject.h
trunk/Source/_javascript_Core/runtime/JSSegmentedVariableObject.h
trunk/Source/_javascript_Core/runtime/Structure.h
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ScrambledPtr.h


Added Paths

trunk/Source/_javascript_Core/runtime/JSCScrambledPtr.cpp
trunk/Source/_javascript_Core/runtime/JSCScrambledPtr.h




Diff

Modified: trunk/Source/_javascript_Core/API/JSCallbackObject.h (225436 => 225437)

--- trunk/Source/_javascript_Core/API/JSCallbackObject.h	2017-12-02 01:04:52 UTC (rev 225436)
+++ trunk/Source/_javascript_Core/API/JSCallbackObject.h	2017-12-02 01:12:48 UTC (rev 225437)
@@ -27,6 +27,7 @@
 #ifndef JSCallbackObject_h
 #define JSCallbackObject_h
 
+#include "JSCScrambledPtr.h"
 #include "JSObjectRef.h"
 #include "JSValueRef.h"
 #include "JSObject.h"
@@ -233,7 +234,7 @@
 static EncodedJSValue callbackGetter(ExecState*, EncodedJSValue, PropertyName);
 
 std::unique_ptr m_callbackObjectData;
-const ClassInfo* m_classInfo;
+ClassInfoScrambledPtr m_classInfo;
 };
 
 } // namespace JSC


Modified: trunk/Source/_javascript_Core/API/JSObjectRef.cpp (225436 => 225437)

--- trunk/Source/_javascript_Core/API/JSObjectRef.cpp	2017-12-02 01:04:52 UTC (rev 225436)
+++ trunk/Source/_javascript_Core/API/JSObjectRef.cpp	2017-12-02 01:12:48 UTC (rev 225437)
@@ -431,7 +431,7 @@
 if (vm.currentlyDestructingCallbackObject != jsObject)
 return jsObject->classInfo(vm);
 
-return vm.currentlyDestructingCallbackObjectClassInfo;
+return vm.currentlyDestructingCallbackObjectClassInfo.descrambled();
 }
 
 void* JSObjectGetPrivate(JSObjectRef object)


Modified: trunk/Source/_javascript_Core/ChangeLog (225436 => 225437)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-02 01:04:52 UTC (rev 225436)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-02 01:12:48 UTC (rev 225437)
@@ -1,3 +1,44 @@
+2017-12-01  Mark Lam  
+
+Let's scramble ClassInfo pointers in cells.
+https://bugs.webkit.org/show_bug.cgi?id=180291
+
+
+Reviewed by JF Bastien.
+
+* API/JSCallbackObject.h:
+* API/JSObjectRef.cpp:
+(classInfoPrivate):
+* _javascript_Core.xcodeproj/project.pbxproj:
+* Sources.txt:
+* assembler/MacroAssemblerCodeRef.cpp:
+(JSC::MacroAssemblerCodePtr::initialize): Deleted.
+* assembler/MacroAssemblerCodeRef.h:
+

[webkit-changes] [225436] trunk/Source/ThirdParty/ANGLE

2017-12-01 Thread mcatanzaro 
Title: [225436] trunk/Source/ThirdParty/ANGLE








Revision 225436
Author mcatanz...@igalia.com
Date 2017-12-01 17:04:52 -0800 (Fri, 01 Dec 2017)


Log Message
Unreviewed, fix byte order macros and address new -Wunknown-pragmas warnings
https://bugs.webkit.org/show_bug.cgi?id=180177


I'm not sure how this code was developed, as it seems to have been designed for GCC, but it
does not use any of GCC's documented byte order macros, and accordingly does not work. Let's
fix it to guarantee there are no problems when building with GCC. I presume it should help
Clang as well.

This time, hopefully without breaking 32-bit macOS, where __BYTE_ORDER actually is defined.

* src/common/third_party/smhasher/src/PMurHash.cpp:
(angle::PMurHash32_Process):

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/common/third_party/smhasher/src/PMurHash.cpp




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (225435 => 225436)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-02 00:41:53 UTC (rev 225435)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-02 01:04:52 UTC (rev 225436)
@@ -1,3 +1,19 @@
+2017-12-01  Michael Catanzaro  
+
+Unreviewed, fix byte order macros and address new -Wunknown-pragmas warnings
+https://bugs.webkit.org/show_bug.cgi?id=180177
+
+
+I'm not sure how this code was developed, as it seems to have been designed for GCC, but it
+does not use any of GCC's documented byte order macros, and accordingly does not work. Let's
+fix it to guarantee there are no problems when building with GCC. I presume it should help
+Clang as well.
+
+This time, hopefully without breaking 32-bit macOS, where __BYTE_ORDER actually is defined.
+
+* src/common/third_party/smhasher/src/PMurHash.cpp:
+(angle::PMurHash32_Process):
+
 2017-12-01  Ryan Haddad  
 
 Unreviewed, rolling out r225412.


Modified: trunk/Source/ThirdParty/ANGLE/src/common/third_party/smhasher/src/PMurHash.cpp (225435 => 225436)

--- trunk/Source/ThirdParty/ANGLE/src/common/third_party/smhasher/src/PMurHash.cpp	2017-12-02 00:41:53 UTC (rev 225435)
+++ trunk/Source/ThirdParty/ANGLE/src/common/third_party/smhasher/src/PMurHash.cpp	2017-12-02 01:04:52 UTC (rev 225436)
@@ -74,6 +74,12 @@
  * ROTL32(x,r)  Rotate x left by r bits
  */
 
+#if !defined(__BYTE_ORDER) && defined(__GNUC__)
+  #define __BIG_ENDIAN __ORDER_BIG_ENDIAN__
+  #define __LITTLE_ENDIAN __ORDER_LITTLE_ENDIAN__
+  #define __BYTE_ORDER __BYTE_ORDER__
+#endif
+
 /* Convention is to define __BYTE_ORDER == to one of these values */
 #if !defined(__BIG_ENDIAN)
   #define __BIG_ENDIAN 4321
@@ -84,7 +90,9 @@
 
 /* I386 */
 #if defined(_M_IX86) || defined(__i386__) || defined(__i386) || defined(i386)
-  #define __BYTE_ORDER __LITTLE_ENDIAN
+  #if !defined(__BYTE_ORDER)
+#define __BYTE_ORDER __LITTLE_ENDIAN
+  #endif
   #define UNALIGNED_SAFE
 #endif
 
@@ -111,10 +119,14 @@
 /* Now find best way we can to READ_UINT32 */
 #if __BYTE_ORDER==__LITTLE_ENDIAN
   /* CPU endian matches murmurhash algorithm, so read 32-bit word directly */
+#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
+#endif
   #define READ_UINT32(ptr)   (*((uint32_t*)(ptr)))
+#if defined(__clang__)
 #pragma clang diagnostic pop
+#endif
 #elif __BYTE_ORDER==__BIG_ENDIAN
   /* TODO: Add additional cases below where a compiler provided bswap32 is available */
   #if defined(__GNUC__) && (__GNUC__>4 || (__GNUC__==4 && __GNUC_MINOR__>=3))
@@ -221,10 +233,14 @@
   switch(n) { /* how many bytes in c */
   case 0: /* c=[]  w=[3210]  b=[3210]=wc'=[] */
 for( ; ptr < end ; ptr+=4) {
+#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
+#endif
   uint32_t k1 = READ_UINT32(ptr);
+#if defined(__clang__)
 #pragma clang diagnostic pop
+#endif
   DOBLOCK(h1, k1);
 }
 break;
@@ -231,10 +247,14 @@
   case 1: /* c=[0---]  w=[4321]  b=[3210]=c>>24|w<<8   c'=[4---] */
 for( ; ptr < end ; ptr+=4) {
   uint32_t k1 = c>>24;
+#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
+#endif
   c = READ_UINT32(ptr);
+#if defined(__clang__)
 #pragma clang diagnostic pop
+#endif
   k1 |= c<<8;
   DOBLOCK(h1, k1);
 }
@@ -242,10 +262,14 @@
   case 2: /* c=[10--]  w=[5432]  b=[3210]=c>>16|w<<16  c'=[54--] */
 for( ; ptr < end ; ptr+=4) {
   uint32_t k1 = c>>16;
+#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
+#endif
   c = READ_UINT32(ptr);
+#if defined(__clang__)
 #pragma clang diagnostic pop
+#endif
   k1 |= c<<16;
   DOBLOCK(h1, k1);
 }
@@ -253,10 +277,14 @@
   case 3: /* c=[210-]  w=[6543]  b=[3210]=c>>8|w<<24   c'=[654-] */
 for( ; ptr < end ; ptr+=4) {
   uint32_t k1 = c>>8;

[webkit-changes] [225435] trunk/JSTests

2017-12-01 Thread jfbastien 
Title: [225435] trunk/JSTests








Revision 225435
Author jfbast...@apple.com
Date 2017-12-01 16:41:53 -0800 (Fri, 01 Dec 2017)


Log Message
_javascript_Core: add test for weird class static getters
https://bugs.webkit.org/show_bug.cgi?id=180281


Reviewed by Mark Lam.

I fixed a bug for it in r224927 and didn't add a test. Do so.

* stress/class-static-get-weird.js: Added.
(c.prototype.get name):
(c):
(c.prototype.get arguments):
(c.prototype.get caller):
(c.prototype.get length):

Modified Paths

trunk/JSTests/ChangeLog


Added Paths

trunk/JSTests/stress/class-static-get-weird.js




Diff

Modified: trunk/JSTests/ChangeLog (225434 => 225435)

--- trunk/JSTests/ChangeLog	2017-12-02 00:40:19 UTC (rev 225434)
+++ trunk/JSTests/ChangeLog	2017-12-02 00:41:53 UTC (rev 225435)
@@ -1,3 +1,20 @@
+2017-12-01  JF Bastien  
+
+_javascript_Core: add test for weird class static getters
+https://bugs.webkit.org/show_bug.cgi?id=180281
+
+
+Reviewed by Mark Lam.
+
+I fixed a bug for it in r224927 and didn't add a test. Do so.
+
+* stress/class-static-get-weird.js: Added.
+(c.prototype.get name):
+(c):
+(c.prototype.get arguments):
+(c.prototype.get caller):
+(c.prototype.get length):
+
 2017-12-01  Saam Barati  
 
 Having a bad time needs to handle ArrayClass indexing type as well


Added: trunk/JSTests/stress/class-static-get-weird.js (0 => 225435)

--- trunk/JSTests/stress/class-static-get-weird.js	(rev 0)
+++ trunk/JSTests/stress/class-static-get-weird.js	2017-12-02 00:41:53 UTC (rev 225435)
@@ -0,0 +1,19 @@
+{
+class c { static get name() { return 42; } }
+if (c.name !== 42) throw "Fail";
+}
+
+{
+class c { static get arguments() { return 42; } }
+if (c.arguments !== 42) throw "Fail";
+}
+
+{
+class c { static get caller() { return 42; } }
+if (c.caller !== 42) throw "Fail";
+}
+
+{
+class c { static get length() { return 42; } }
+if (c.length !== 42) throw "Fail";
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225434] tags/Safari-605.1.15.1/Source

2017-12-01 Thread jmarcell 
Title: [225434] tags/Safari-605.1.15.1/Source








Revision 225434
Author jmarc...@apple.com
Date 2017-12-01 16:40:19 -0800 (Fri, 01 Dec 2017)


Log Message
Versioning.

Modified Paths

tags/Safari-605.1.15.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-605.1.15.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-605.1.15.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-605.1.15.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-605.1.15.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-605.1.15.1/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-605.1.15.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-605.1.15.1/Source/_javascript_Core/Configurations/Version.xcconfig (225433 => 225434)

--- tags/Safari-605.1.15.1/Source/_javascript_Core/Configurations/Version.xcconfig	2017-12-02 00:39:32 UTC (rev 225433)
+++ tags/Safari-605.1.15.1/Source/_javascript_Core/Configurations/Version.xcconfig	2017-12-02 00:40:19 UTC (rev 225434)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-605.1.15.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (225433 => 225434)

--- tags/Safari-605.1.15.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-12-02 00:39:32 UTC (rev 225433)
+++ tags/Safari-605.1.15.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-12-02 00:40:19 UTC (rev 225434)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-605.1.15.1/Source/WebCore/Configurations/Version.xcconfig (225433 => 225434)

--- tags/Safari-605.1.15.1/Source/WebCore/Configurations/Version.xcconfig	2017-12-02 00:39:32 UTC (rev 225433)
+++ tags/Safari-605.1.15.1/Source/WebCore/Configurations/Version.xcconfig	2017-12-02 00:40:19 UTC (rev 225434)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-605.1.15.1/Source/WebCore/PAL/Configurations/Version.xcconfig (225433 => 225434)

--- tags/Safari-605.1.15.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-12-02 00:39:32 UTC (rev 225433)
+++ tags/Safari-605.1.15.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-12-02 00:40:19 UTC (rev 225434)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-605.1.15.1/Source/WebInspectorUI/Configurations/Version.xcconfig (225433 => 225434)

--- tags/Safari-605.1.15.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-12-02 00:39:32 UTC (rev 225433)
+++ tags/Safari-605.1.15.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-12-02 00:40:19 UTC (rev 225434)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-605.1.15.1/Source/WebKit/Configurations/Version.xcconfig (225433 => 225434)

--- tags/Safari-605.1.15.1/Source/WebKit/Configurations/Version.xcconfig	2017-12-02 00:39:32 UTC (rev 225433)
+++ tags/Safari-605.1.15.1/Source/WebKit/Configurations/Version.xcconfig	2017-12-02 00:40:19 UTC (rev 225434)
@@ -24,9

[webkit-changes] [225433] trunk/Tools

2017-12-01 Thread aakash_jain 
Title: [225433] trunk/Tools








Revision 225433
Author aakash_j...@apple.com
Date 2017-12-01 16:39:32 -0800 (Fri, 01 Dec 2017)


Log Message
[build.webkit.org] Move python code to load config from master.cfg in separate file
https://bugs.webkit.org/show_bug.cgi?id=180278

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved appropriate code to loadConfig.py
* BuildSlaveSupport/build.webkit.org-config/loadConfig.py: Ditto.
* BuildSlaveSupport/build.webkit.org-config/steps.py: Removed extra import.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/ChangeLog


Added Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py




Diff

Copied: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py (from rev 225432, trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg) (0 => 225433)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py	(rev 0)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py	2017-12-02 00:39:32 UTC (rev 225433)
@@ -0,0 +1,130 @@
+# Copyright (C) 2017 Apple Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+from buildbot.buildslave import BuildSlave
+from buildbot.scheduler import AnyBranchScheduler, Triggerable
+from buildbot.schedulers.forcesched import FixedParameter, ForceScheduler, StringParameter, BooleanParameter
+from buildbot.schedulers.filter import ChangeFilter
+from buildbot.process import buildstep, factory, properties
+
+from factories import *
+
+import re
+import json
+import operator
+
+from committer_auth import CommitterAuth
+import wkbuild
+
+trunk_filter = ChangeFilter(branch=["trunk", None])
+
+
+def pickLatestBuild(builder, requests):
+return max(requests, key=operator.attrgetter("submittedAt"))
+
+
+def loadBuilderConfig(c):
+# FIXME: These file handles are leaked.
+passwords = json.load(open('passwords.json'))
+config = json.load(open('config.json'))
+
+c['slaves'] = [BuildSlave(slave['name'], passwords[slave['name']], max_builds=1) for slave in config['slaves']]
+
+c['schedulers'] = []
+for scheduler in config['schedulers']:
+if "change_filter" in scheduler:
+scheduler["change_filter"] = globals()[scheduler["change_filter"]]
+kls = globals()[scheduler.pop('type')]
+# Python 2.6 can't handle unicode keys as keyword arguments:
+# http://bugs.python.org/issue2646.  Modern versions of json return
+# unicode strings from json.load, so we map all keys to str objects.
+scheduler = dict(map(lambda key_value_pair: (str(key_value_pair[0]), key_value_pair[1]), scheduler.items()))
+
+c['schedulers'].append(kls(**scheduler))
+
+forceScheduler = ForceScheduler(
+name="force",
+builderNames=[str(builder['name']) for builder in config['builders']],
+reason=StringParameter(name="reason", default="", size=40),
+
+# Validate SVN revision: number or empty string
+revision=StringParameter(name="revision", default="", regex=re.compile(r'^(\d*)$')),
+
+# Disable default enabled input fields: branch, repository, project, additional properties
+branch=FixedParameter(name="branch"),
+repository=FixedParameter(name="repository"),
+project=FixedParameter(name="project"),
+properties=[BooleanParameter(name="is_clean", label="Force Clean build")]
+)
+c['schedulers'].append(forceScheduler)
+
+c['builders'] = []
+for builder in config['builders']:
+for slaveName in builder['slavenames']:
+

[webkit-changes] [225432] trunk/LayoutTests

2017-12-01 Thread jlewis3 
Title: [225432] trunk/LayoutTests








Revision 225432
Author jlew...@apple.com
Date 2017-12-01 16:29:26 -0800 (Fri, 01 Dec 2017)


Log Message
Marked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky timeout on wk1.
https://bugs.webkit.org/show_bug.cgi?id=172044

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225431 => 225432)

--- trunk/LayoutTests/ChangeLog	2017-12-02 00:28:46 UTC (rev 225431)
+++ trunk/LayoutTests/ChangeLog	2017-12-02 00:29:26 UTC (rev 225432)
@@ -1,3 +1,12 @@
+2017-12-01  Matt Lewis  
+
+Marked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky timeout on wk1.
+https://bugs.webkit.org/show_bug.cgi?id=172044
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2017-12-01  Daniel Bates  
 
 AlternativePresentationButtonSubstitution::unapply() may not undo substitution


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (225431 => 225432)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-12-02 00:28:46 UTC (rev 225431)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-12-02 00:29:26 UTC (rev 225432)
@@ -470,3 +470,6 @@
 webkit.org/b/172397 [ Debug ] animations/needs-layout.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/179775 imported/w3c/web-platform-tests/XMLHttpRequest/firing-events-http-no-content-length.html [ Pass Failure ]
+
+webkit.org/b/172044 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html [ Pass Timeout ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225431] trunk

2017-12-01 Thread dbates 
Title: [225431] trunk








Revision 225431
Author dba...@webkit.org
Date 2017-12-01 16:28:46 -0800 (Fri, 01 Dec 2017)


Log Message
AlternativePresentationButtonSubstitution::unapply() may not undo substitution
https://bugs.webkit.org/show_bug.cgi?id=180279


Reviewed by Simon Fraser.

Source/WebCore:

Fixes an issue where removing an alternative presentation button substituted for a non-HTML input
element did not restore the original appearance of the element before the substitution.

To substitute the alternative presentation button for a non-HTML input element we attach a
user-agent shadow root to it. Adding a shadow root, including a user-agent shadow root,
tears down the existing renderers for the element. Currently when we unapply such a substitution
we ultimately just remove the shadow root and do not create new renderers for the subtree
that the shadow root was removed from. We need to create new renderers for this subtree
to restore the original appearance of the element before the substitution.

* editing/cocoa/AlternativePresentationButtonSubstitution.cpp:
(WebCore::AlternativePresentationButtonSubstitution::unapply):

LayoutTests:

Update test to ensure that we undo the alternative presentation button substitution
made to an HTML label element.

* fast/forms/alternative-presentation-button/replace-and-remove-expected.html:
* fast/forms/alternative-presentation-button/replace-and-remove.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove-expected.html
trunk/LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/AlternativePresentationButtonSubstitution.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (225430 => 225431)

--- trunk/LayoutTests/ChangeLog	2017-12-02 00:20:57 UTC (rev 225430)
+++ trunk/LayoutTests/ChangeLog	2017-12-02 00:28:46 UTC (rev 225431)
@@ -1,5 +1,19 @@
 2017-12-01  Daniel Bates  
 
+AlternativePresentationButtonSubstitution::unapply() may not undo substitution
+https://bugs.webkit.org/show_bug.cgi?id=180279
+
+
+Reviewed by Simon Fraser.
+
+Update test to ensure that we undo the alternative presentation button substitution
+made to an HTML label element.
+
+* fast/forms/alternative-presentation-button/replace-and-remove-expected.html:
+* fast/forms/alternative-presentation-button/replace-and-remove.html:
+
+2017-12-01  Daniel Bates  
+
 Alternative Presentation Button: Provide a way to query for the replaced elements
 https://bugs.webkit.org/show_bug.cgi?id=180114
 


Modified: trunk/LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove-expected.html (225430 => 225431)

--- trunk/LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove-expected.html	2017-12-02 00:20:57 UTC (rev 225430)
+++ trunk/LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove-expected.html	2017-12-02 00:28:46 UTC (rev 225431)
@@ -39,6 +39,9 @@
 
 
 
+
+First name 
+
 Name
 
 


Modified: trunk/LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove.html (225430 => 225431)

--- trunk/LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove.html	2017-12-02 00:20:57 UTC (rev 225430)
+++ trunk/LayoutTests/fast/forms/alternative-presentation-button/replace-and-remove.html	2017-12-02 00:28:46 UTC (rev 225431)
@@ -39,6 +39,9 @@
 
 
 
+
+First name 
+

[webkit-changes] [225430] trunk/Source

2017-12-01 Thread commit-queue 
Title: [225430] trunk/Source








Revision 225430
Author commit-qu...@webkit.org
Date 2017-12-01 16:20:57 -0800 (Fri, 01 Dec 2017)


Log Message
Move DateComponents into WTF
https://bugs.webkit.org/show_bug.cgi?id=180211

Patch by Christopher Reid  on 2017-12-01
Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests no change in behavior.

Moved DateComponents from platform into WTF.

* Sources.txt: Removed DateComponents
* WebCore.xcodeproj/project.pbxproj: Removed DateComponents
* dom/Document.cpp:
* html/BaseDateAndTimeInputType.h:
* html/DateTimeInputType.h: Fixed a call to the wrong parent constructor
* html/HTMLInputElement.h:
* html/InputType.cpp:
* html/InputType.h:
* platform/text/PlatformLocale.cpp:
* platform/text/PlatformLocale.h:
* platform/text/ios/LocalizedDateCache.h:
* platform/text/mac/LocaleMac.h:
* platform/text/win/LocaleWin.cpp:
* platform/text/win/LocaleWin.h:
* rendering/RenderThemeIOS.mm:

Source/WTF:

Moved DateComponents from WebCore/platform into WTF.
Removed isLeapYear from DateComponents as DateMath already has that function.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/DateComponents.cpp: Renamed from Source\WebCore\platform\DateComponents.cpp.
* wtf/DateComponents.h: Renamed from Source\WebCore\platform\DateComponents.h.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/WTF.xcodeproj/project.pbxproj
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/BaseDateAndTimeInputType.h
trunk/Source/WebCore/html/DateTimeInputType.h
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/InputType.cpp
trunk/Source/WebCore/html/InputType.h
trunk/Source/WebCore/platform/text/PlatformLocale.h
trunk/Source/WebCore/platform/text/ios/LocalizedDateCache.h
trunk/Source/WebCore/platform/text/mac/LocaleMac.h
trunk/Source/WebCore/platform/text/win/LocaleWin.cpp
trunk/Source/WebCore/platform/text/win/LocaleWin.h
trunk/Source/WebCore/rendering/RenderThemeIOS.mm


Added Paths

trunk/Source/WTF/wtf/DateComponents.cpp
trunk/Source/WTF/wtf/DateComponents.h


Removed Paths

trunk/Source/WebCore/platform/DateComponents.cpp
trunk/Source/WebCore/platform/DateComponents.h




Diff

Modified: trunk/Source/WTF/ChangeLog (225429 => 225430)

--- trunk/Source/WTF/ChangeLog	2017-12-02 00:09:02 UTC (rev 225429)
+++ trunk/Source/WTF/ChangeLog	2017-12-02 00:20:57 UTC (rev 225430)
@@ -1,3 +1,18 @@
+2017-12-01  Christopher Reid  
+
+Move DateComponents into WTF
+https://bugs.webkit.org/show_bug.cgi?id=180211
+
+Reviewed by Myles C. Maxfield.
+
+Moved DateComponents from WebCore/platform into WTF.
+Removed isLeapYear from DateComponents as DateMath already has that function.
+
+* WTF.xcodeproj/project.pbxproj:
+* wtf/CMakeLists.txt:
+* wtf/DateComponents.cpp: Renamed from Source\WebCore\platform\DateComponents.cpp.
+* wtf/DateComponents.h: Renamed from Source\WebCore\platform\DateComponents.h.
+
 2017-12-01  Youenn Fablet  
 
 Implement https://w3c.github.io/ServiceWorker/#clients-get


Modified: trunk/Source/WTF/WTF.xcodeproj/project.pbxproj (225429 => 225430)

--- trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2017-12-02 00:09:02 UTC (rev 225429)
+++ trunk/Source/WTF/WTF.xcodeproj/project.pbxproj	2017-12-02 00:20:57 UTC (rev 225430)
@@ -82,6 +82,7 @@
 		93F1993E19D7958D00C2390B /* StringView.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 93F1993D19D7958D00C2390B /* StringView.cpp */; };
 		9BC70F05176C379D00101DEC /* AtomicStringTable.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9BC70F04176C379D00101DEC /* AtomicStringTable.cpp */; };
 		A3B725EC987446AD93F1A440 /* RandomDevice.cpp in Sources */ = {isa = PBXBuildFile; fileRef = C8F597CA2A57417FBAB92FD6 /* RandomDevice.cpp */; };
+		A3CABA081FD095110007A4DE /* DateComponents.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3CABA061FD095110007A4DE /* DateComponents.cpp */; };
 		A3E4DD931F3A803400DED0B4 /* TextStream.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A3E4DD911F3A803400DED0B4 /* TextStream.cpp */; };
 		A5BA15F3182433A900A82E69 /* StringMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = A5BA15F2182433A900A82E69 /* StringMac.mm */; };
 		A5BA15F51824348000A82E69 /* StringImplMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = A5BA15F41824348000A82E69 /* StringImplMac.mm */; };
@@ -387,6 +388,8 @@
 		A30D412C1F0DE0BA00B71954 /* SoftLinking.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SoftLinking.h; sourceTree = ""; };
 		A30D412D1F0DE13F00B71954 /* SoftLinking.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SoftLinking.h; sourceTree = ""; };
 		A3AB6E6A1F3E1AD6009C14B1 /* ValueToString.h */ =

[webkit-changes] [225429] trunk

2017-12-01 Thread dbates 
Title: [225429] trunk








Revision 225429
Author dba...@webkit.org
Date 2017-12-01 16:09:02 -0800 (Fri, 01 Dec 2017)


Log Message
Alternative Presentation Button: Provide a way to query for the replaced elements
https://bugs.webkit.org/show_bug.cgi?id=180114


Reviewed by Tim Horton.

Source/WebCore:

Add SPI to query for the elements that were replaced by an Alternative Presentation Button.

Test: fast/forms/alternative-presentation-button/replaced-elements.html

* editing/Editor.cpp:
(WebCore::Editor::elementsReplacedByAlternativePresentationButton): Added.
* editing/Editor.h:
* editing/cocoa/AlternativePresentationButtonSubstitution.cpp:
(WebCore::AlternativePresentationButtonSubstitution::replacedElements): Added.
* editing/cocoa/AlternativePresentationButtonSubstitution.h:
* testing/Internals.cpp:
(WebCore::Internals::elementsReplacedByAlternativePresentationButton): Added.
* testing/Internals.h:
* testing/Internals.idl: Expose internals function elementsReplacedByAlternativePresentationButton()
so as to test Editor::elementsReplacedByAlternativePresentationButton().

Source/WebKit:

Add SPI to query for the elements that were replaced by an Alternative Presentation Button.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame elementsReplacedByAlternativePresentationButtonWithIdentifier:]): Added.
* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleElementsReplacedByAlternativePresentationButton): Added.
* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:

LayoutTests:

Add a test to ensure that Editor::elementsReplacedByAlternativePresentationButton()
returns the same list of elements that were specified to Editor::substituteWithAlternativePresentationButton()
up to ordering.

* fast/forms/alternative-presentation-button/replaced-elements-expected.txt: Added.
* fast/forms/alternative-presentation-button/replaced-elements.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/editing/cocoa/AlternativePresentationButtonSubstitution.cpp
trunk/Source/WebCore/editing/cocoa/AlternativePresentationButtonSubstitution.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm
trunk/Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp
trunk/Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h


Added Paths

trunk/LayoutTests/fast/forms/alternative-presentation-button/replaced-elements-expected.txt
trunk/LayoutTests/fast/forms/alternative-presentation-button/replaced-elements.html




Diff

Modified: trunk/LayoutTests/ChangeLog (225428 => 225429)

--- trunk/LayoutTests/ChangeLog	2017-12-02 00:01:54 UTC (rev 225428)
+++ trunk/LayoutTests/ChangeLog	2017-12-02 00:09:02 UTC (rev 225429)
@@ -1,3 +1,18 @@
+2017-12-01  Daniel Bates  
+
+Alternative Presentation Button: Provide a way to query for the replaced elements
+https://bugs.webkit.org/show_bug.cgi?id=180114
+
+
+Reviewed by Tim Horton.
+
+Add a test to ensure that Editor::elementsReplacedByAlternativePresentationButton()
+returns the same list of elements that were specified to Editor::substituteWithAlternativePresentationButton()
+up to ordering.
+
+* fast/forms/alternative-presentation-button/replaced-elements-expected.txt: Added.
+* fast/forms/alternative-presentation-button/replaced-elements.html: Added.
+
 2017-12-01  Youenn Fablet  
 
 Implement https://w3c.github.io/ServiceWorker/#clients-get


Added: trunk/LayoutTests/fast/forms/alternative-presentation-button/replaced-elements-expected.txt (0 => 225429)

--- trunk/LayoutTests/fast/forms/alternative-presentation-button/replaced-elements-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/alternative-presentation-button/replaced-elements-expected.txt	2017-12-02 00:09:02 UTC (rev 225429)
@@ -0,0 +1,13 @@
+Tests that the elements returned by internals.elementsReplacedByAlternativePresentationButton() are the same as the elements passed to internals.substituteWithAlternativePresentationButton() ignoring order.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS internals.elementsReplacedByAlternativePresentationButton(1).length is 0
+PASS single input element
+PASS multiple elements
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
+


Added: trunk/LayoutTests/fast/forms/alternative-presentation-button/replaced-elements.html (0 => 225429)

---

[webkit-changes] [225428] trunk/Source/WebCore

2017-12-01 Thread commit-queue 
Title: [225428] trunk/Source/WebCore








Revision 225428
Author commit-qu...@webkit.org
Date 2017-12-01 16:01:54 -0800 (Fri, 01 Dec 2017)


Log Message
Rename ImageFrameCache to ImageSource
https://bugs.webkit.org/show_bug.cgi?id=180172

Patch by Said Abou-Hallawa  on 2017-12-01
Reviewed by Per Arne Vollan.

This is a follow-up for r225300. ImageSource is the intended name after
merging ImageFrameCache and ImageSource.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage):
* platform/graphics/BitmapImage.h:
* platform/graphics/ImageFrame.h:
* platform/graphics/ImageFrameCache.cpp: Removed.
* platform/graphics/ImageFrameCache.h: Removed.
* platform/graphics/ImageSource.cpp: Added.
(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::~ImageSource):
(WebCore::ImageSource::ensureDecoderAvailable):
(WebCore::ImageSource::setData):
(WebCore::ImageSource::resetData):
(WebCore::ImageSource::dataChanged):
(WebCore::ImageSource::isAllDataReceived):
(WebCore::ImageSource::destroyDecodedData):
(WebCore::ImageSource::destroyIncompleteDecodedData):
(WebCore::ImageSource::clearFrameBufferCache):
(WebCore::ImageSource::decodedSizeChanged):
(WebCore::ImageSource::decodedSizeIncreased):
(WebCore::ImageSource::decodedSizeDecreased):
(WebCore::ImageSource::decodedSizeReset):
(WebCore::ImageSource::didDecodeProperties):
(WebCore::ImageSource::growFrames):
(WebCore::ImageSource::setNativeImage):
(WebCore::ImageSource::cacheMetadataAtIndex):
(WebCore::ImageSource::cacheNativeImageAtIndex):
(WebCore::ImageSource::cacheNativeImageAtIndexAsync):
(WebCore::ImageSource::decodingQueue):
(WebCore::ImageSource::frameRequestQueue):
(WebCore::ImageSource::canUseAsyncDecoding):
(WebCore::ImageSource::startAsyncDecodingQueue):
(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex):
(WebCore::ImageSource::isAsyncDecodingQueueIdle const):
(WebCore::ImageSource::stopAsyncDecodingQueue):
(WebCore::ImageSource::frameAtIndexCacheIfNeeded):
(WebCore::ImageSource::clearMetadata):
(WebCore::ImageSource::sourceURL const):
(WebCore::ImageSource::mimeType const):
(WebCore::ImageSource::expectedContentLength const):
(WebCore::ImageSource::metadata):
(WebCore::ImageSource::frameMetadataAtIndex):
(WebCore::ImageSource::frameMetadataAtIndexCacheIfNeeded):
(WebCore::ImageSource::encodedDataStatus):
(WebCore::ImageSource::frameCount):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::uti):
(WebCore::ImageSource::filenameExtension):
(WebCore::ImageSource::hotSpot):
(WebCore::ImageSource::size):
(WebCore::ImageSource::sizeRespectingOrientation):
(WebCore::ImageSource::singlePixelSolidColor):
(WebCore::ImageSource::maximumSubsamplingLevel):
(WebCore::ImageSource::frameIsBeingDecodedAndIsCompatibleWithOptionsAtIndex):
(WebCore::ImageSource::frameDecodingStatusAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):
(WebCore::ImageSource::frameHasFullSizeNativeImageAtIndex):
(WebCore::ImageSource::frameHasDecodedNativeImageCompatibleWithOptionsAtIndex):
(WebCore::ImageSource::frameSubsamplingLevelAtIndex):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameOrientationAtIndex):
(WebCore::ImageSource::setTargetContext):
(WebCore::ImageSource::createFrameImageAtIndex):
(WebCore::ImageSource::frameImageAtIndex):
(WebCore::ImageSource::frameImageAtIndexCacheIfNeeded):
(WebCore::ImageSource::dump):
* platform/graphics/ImageSource.h: Added.
(WebCore::ImageSource::create):
(WebCore::ImageSource::decodedSize const):
(WebCore::ImageSource::destroyAllDecodedData):
(WebCore::ImageSource::destroyAllDecodedDataExcludeFrame):
(WebCore::ImageSource::destroyDecodedDataBeforeFrame):
(WebCore::ImageSource::clearImage):
(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex):
(WebCore::ImageSource::hasAsyncDecodingQueue const):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::isDecoderAvailable const):
(WebCore::ImageSource::frameAtIndexCacheIfNeeded):
(WebCore::ImageSource::ImageFrameRequest::operator== const):
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/graphics/BitmapImage.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/ImageFrame.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp


Added Paths

trunk/Source/WebCore/platform/graphics/ImageSource.cpp
trunk/Source/WebCore/platform/graphics/ImageSource.h


Removed Paths

[webkit-changes] [225427] trunk

2017-12-01 Thread commit-queue 
Title: [225427] trunk








Revision 225427
Author commit-qu...@webkit.org
Date 2017-12-01 16:00:40 -0800 (Fri, 01 Dec 2017)


Log Message
Implement https://w3c.github.io/ServiceWorker/#clients-get
https://bugs.webkit.org/show_bug.cgi?id=180167

Patch by Youenn Fablet  on 2017-12-01
Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/workers/service/serviceworkerclients-get.https.html

Implement clients get by having service worker clients do the following:
- Go to main thread to query the SWClientConnection for getting the client.
- SWClientConnection requests it through IPC to StorageProcess SWServer.
- SWServer looks at its client map and returns client data based on the given identifier.
- SWClientConnection sends it back to the right clients for resolving the promise.

Identifier is parsed at service worker process level.

Made ServiceWorkerClients no longer an ActiveDOMObject since it is owned by ServiceWorkerGlobalScope
and is only exposed in service workers.

* workers/service/ServiceWorkerClientIdentifier.h:
(WebCore::ServiceWorkerClientIdentifier::fromString):
* workers/service/ServiceWorkerClients.cpp:
(WebCore::ServiceWorkerClients::ServiceWorkerClients):
(WebCore::ServiceWorkerClients::get):
* workers/service/ServiceWorkerClients.h:
(WebCore::ServiceWorkerClients::create):
* workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::postTaskToServiceWorker):
* workers/service/context/SWContextManager.h:
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::getClientFromId):
* workers/service/server/SWServer.h:
* workers/service/server/SWServerToContextConnection.cpp:
(WebCore::SWServerToContextConnection::findClientByIdentifier):
* workers/service/server/SWServerToContextConnection.h:
* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::origin const):
(WebCore::SWServerWorker::findClientByIdentifier):
* workers/service/server/SWServerWorker.h:

Source/WebKit:

Add IPC plumbery for clientFromId between ServiceWorker process and Storage process.

* StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:
(WebKit::WebSWServerToContextConnection::clientFromIdCompleted):
* StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
* StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::findClientByIdentifier):
(WebKit::WebSWContextManagerConnection::findClientByIdentifierCompleted):
* WebProcess/Storage/WebSWContextManagerConnection.h:
* WebProcess/Storage/WebSWContextManagerConnection.messages.in:

Source/WTF:

* wtf/text/StringView.h:
(WTF::StringView::toUInt64Strict const):
* wtf/text/WTFString.h:

LayoutTests:

* http/tests/workers/service/resources/serviceworkerclients-get-worker.js: Added.
* http/tests/workers/service/serviceworkerclients-get.https-expected.txt: Added.
* http/tests/workers/service/serviceworkerclients-get.https.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringView.h
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/ServiceWorkerClientIdentifier.h
trunk/Source/WebCore/workers/service/ServiceWorkerClients.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerClients.h
trunk/Source/WebCore/workers/service/ServiceWorkerClients.idl
trunk/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
trunk/Source/WebCore/workers/service/context/SWContextManager.cpp
trunk/Source/WebCore/workers/service/context/SWContextManager.h
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.cpp
trunk/Source/WebCore/workers/service/server/SWServerToContextConnection.h
trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp
trunk/Source/WebCore/workers/service/server/SWServerWorker.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp
trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.h
trunk/Source/WebKit/StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.h
trunk/Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in


Added Paths

trunk/LayoutTests/http/tests/workers/service/resources/serviceworkerclients-get-worker.js
trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-get.https-expected.txt
trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-get.https.html




Diff

Modified: trunk/LayoutTests/ChangeLog (225426 => 225427)

--- trunk/LayoutTests/ChangeLog	2017-12-01 23:52:01 UTC (rev 225426)
+++ trunk/LayoutTests/ChangeLog	2017-12-02 00:00:40 UTC (rev

[webkit-changes] [225426] trunk/LayoutTests

2017-12-01 Thread ryanhaddad 
Title: [225426] trunk/LayoutTests








Revision 225426
Author ryanhad...@apple.com
Date 2017-12-01 15:52:01 -0800 (Fri, 01 Dec 2017)


Log Message
Update TestExpectations for editing/input tests on iOS.

Unreviewed test gardening.

* platform/ios-wk1/TestExpectations:
* platform/ios-wk2/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-wk1/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (225425 => 225426)

--- trunk/LayoutTests/ChangeLog	2017-12-01 23:45:49 UTC (rev 225425)
+++ trunk/LayoutTests/ChangeLog	2017-12-01 23:52:01 UTC (rev 225426)
@@ -1,3 +1,13 @@
+2017-12-01  Ryan Haddad  
+
+Update TestExpectations for editing/input tests on iOS.
+
+Unreviewed test gardening.
+
+* platform/ios-wk1/TestExpectations:
+* platform/ios-wk2/TestExpectations:
+* platform/ios/TestExpectations:
+
 2017-12-01  Myles C. Maxfield  
 
 Free FontFaceSets may include fonts that were never actually added to them


Modified: trunk/LayoutTests/platform/ios/TestExpectations (225425 => 225426)

--- trunk/LayoutTests/platform/ios/TestExpectations	2017-12-01 23:45:49 UTC (rev 225425)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2017-12-01 23:52:01 UTC (rev 225426)
@@ -789,7 +789,14 @@
 editing/deleting/skip-virama-001.html [ Skip ]
 editing/input/option-page-up-down.html [ Skip ]
 editing/input/page-up-down-scrolls.html [ Skip ]
+editing/input/password-echo-passnode.html [ Skip ]
+editing/input/password-echo-passnode2.html [ Skip ]
+editing/input/password-echo-passnode3.html [ Skip ]
 editing/input/reveal-caret-of-transformed-multiline-input.html [ Skip ]
+editing/input/reveal-edit-on-input-vertically.html [ Skip ]
+editing/input/reveal-contenteditable-on-input-vertically.html [ Skip ]
+editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html [ Skip ]
+editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html [ Skip ]
 editing/input/scroll-viewport-page-up-down.html [ Skip ]
 editing/input/setting-input-value-cancel-ime-composition.html [ Skip ]
 editing/input/style-change-during-input.html [ Skip ]
@@ -1334,6 +1341,8 @@
 webkit.org/b/180275 editing/caret/color-span-inside-editable-background.html [ ImageOnlyFailure ]
 webkit.org/b/180725 editing/caret/color-span-inside-editable.html [ ImageOnlyFailure ]
 
+webkit.org/b/180286 editing/input/editable-container-with-word-wrap-normal.html [ Failure ]
+
 # Font tests that fail:
 fonts/font-fallback-prefers-pictographs.html [ ImageOnlyFailure ]
 


Modified: trunk/LayoutTests/platform/ios-wk1/TestExpectations (225425 => 225426)

--- trunk/LayoutTests/platform/ios-wk1/TestExpectations	2017-12-01 23:45:49 UTC (rev 225425)
+++ trunk/LayoutTests/platform/ios-wk1/TestExpectations	2017-12-01 23:52:01 UTC (rev 225426)
@@ -124,7 +124,6 @@
 # Editing tests that time out:
 editing/deleting/delete-button-background-image-none.html
 editing/input/page-up-down-scrolls.html
-editing/input/reveal-contenteditable-on-input-vertically.html
 editing/selection/caret-at-bidi-boundary.html
 editing/spelling/context-menu-suggestions-multiword-selection.html
 editing/spelling/delete-into-misspelled-word.html


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (225425 => 225426)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-12-01 23:45:49 UTC (rev 225425)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2017-12-01 23:52:01 UTC (rev 225426)
@@ -588,13 +588,6 @@
 transforms/2d/transform-fixed-container.html [ Failure ]
 
 # Editing tests that fail:
-editing/input/editable-container-with-word-wrap-normal.html [ Failure ]
-editing/input/password-echo-passnode.html [ Failure ]
-editing/input/password-echo-passnode2.html [ Failure ]
-editing/input/password-echo-passnode3.html [ Failure ]
-editing/input/reveal-edit-on-input-vertically.html [ Failure ]
-editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html [ Failure ]
-editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html [ Failure ]
 editing/inserting/caret-position.html [ Failure ]
 editing/inserting/insert-3654864-fix.html [ Failure ]
 editing/inserting/insert-3775316-fix.html [ Failure ]
@@ -703,7 +696,6 @@
 editing/undo/undo-typing-001.html [ Failure ]
 
 # Editing tests that time out:
-editing/input/reveal-contenteditable-on-input-vertically.html
 editing/selection/designmode-no-caret.html
 editing/selection/move-by-character-brute-force.html
 editing/spelling/delete-into-misspelled-word.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225424] tags/Safari-604.5.100.1/

2017-12-01 Thread jmarcell 
Title: [225424] tags/Safari-604.5.100.1/








Revision 225424
Author jmarc...@apple.com
Date 2017-12-01 15:44:10 -0800 (Fri, 01 Dec 2017)


Log Message
Tag Safari-604.5.100.1.

Added Paths

tags/Safari-604.5.100.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225423] trunk

2017-12-01 Thread sbarati 
Title: [225423] trunk








Revision 225423
Author sbar...@apple.com
Date 2017-12-01 15:40:13 -0800 (Fri, 01 Dec 2017)


Log Message
Having a bad time needs to handle ArrayClass indexing type as well
https://bugs.webkit.org/show_bug.cgi?id=180274


Reviewed by Keith Miller and Mark Lam.

JSTests:

* stress/array-prototype-slow-put-having-a-bad-time-2.js: Added.
(assert):
* stress/array-prototype-slow-put-having-a-bad-time.js: Added.
(assert):

Source/_javascript_Core:

We need to make sure to transition ArrayClass to SlowPutArrayStorage as well.
Otherwise, we'll end up with the wrong Structure, which will lead us to not
adhere to the spec. The bug was that we were not considering ArrayClass inside
hasBrokenIndexing. This patch rewrites that function to automatically opt
in non-empty indexing types as broken, instead of having to opt out all
non-empty indexing types besides SlowPutArrayStorage.

* runtime/IndexingType.h:
(JSC::hasSlowPutArrayStorage):
(JSC::shouldUseSlowPut):
* runtime/JSGlobalObject.cpp:
* runtime/JSObject.cpp:
(JSC::JSObject::switchToSlowPutArrayStorage):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/IndexingType.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp


Added Paths

trunk/JSTests/stress/array-prototype-slow-put-having-a-bad-time-2.js
trunk/JSTests/stress/array-prototype-slow-put-having-a-bad-time.js




Diff

Modified: trunk/JSTests/ChangeLog (225422 => 225423)

--- trunk/JSTests/ChangeLog	2017-12-01 23:36:41 UTC (rev 225422)
+++ trunk/JSTests/ChangeLog	2017-12-01 23:40:13 UTC (rev 225423)
@@ -1,3 +1,16 @@
+2017-12-01  Saam Barati  
+
+Having a bad time needs to handle ArrayClass indexing type as well
+https://bugs.webkit.org/show_bug.cgi?id=180274
+
+
+Reviewed by Keith Miller and Mark Lam.
+
+* stress/array-prototype-slow-put-having-a-bad-time-2.js: Added.
+(assert):
+* stress/array-prototype-slow-put-having-a-bad-time.js: Added.
+(assert):
+
 2017-12-01  JF Bastien  
 
 WebAssembly: restore cached stack limit after out-call


Added: trunk/JSTests/stress/array-prototype-slow-put-having-a-bad-time-2.js (0 => 225423)

--- trunk/JSTests/stress/array-prototype-slow-put-having-a-bad-time-2.js	(rev 0)
+++ trunk/JSTests/stress/array-prototype-slow-put-having-a-bad-time-2.js	2017-12-01 23:40:13 UTC (rev 225423)
@@ -0,0 +1,14 @@
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+let result;
+Object.defineProperty(Object.prototype, '1', {
+get() { return result; },
+set(x) { result = x; }
+});
+Array.prototype.length = 0x1000;
+Array.prototype[1] = 42;
+assert(result === 42);
+assert(Array.prototype[1] === 42);


Added: trunk/JSTests/stress/array-prototype-slow-put-having-a-bad-time.js (0 => 225423)

--- trunk/JSTests/stress/array-prototype-slow-put-having-a-bad-time.js	(rev 0)
+++ trunk/JSTests/stress/array-prototype-slow-put-having-a-bad-time.js	2017-12-01 23:40:13 UTC (rev 225423)
@@ -0,0 +1,15 @@
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+let result;
+Object.defineProperty(Object.prototype, '1', {
+get() { return result; },
+set(x) { result = x; }
+});
+
+Array.prototype.length = 5;
+Array.prototype[1] = 42;
+assert(result === 42);
+assert(Array.prototype[1] === 42);


Modified: trunk/Source/_javascript_Core/ChangeLog (225422 => 225423)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-01 23:36:41 UTC (rev 225422)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-01 23:40:13 UTC (rev 225423)
@@ -1,3 +1,25 @@
+2017-12-01  Saam Barati  
+
+Having a bad time needs to handle ArrayClass indexing type as well
+https://bugs.webkit.org/show_bug.cgi?id=180274
+
+
+Reviewed by Keith Miller and Mark Lam.
+
+We need to make sure to transition ArrayClass to SlowPutArrayStorage as well.
+Otherwise, we'll end up with the wrong Structure, which will lead us to not
+adhere to the spec. The bug was that we were not considering ArrayClass inside 
+hasBrokenIndexing. This patch rewrites that function to automatically opt
+in non-empty indexing types as broken, instead of having to opt out all
+non-empty indexing types besides SlowPutArrayStorage.
+
+* runtime/IndexingType.h:
+(JSC::hasSlowPutArrayStorage):
+(JSC::shouldUseSlowPut):
+* runtime/JSGlobalObject.cpp:
+* runtime/JSObject.cpp:
+(JSC::JSObject::switchToSlowPutArrayStorage):
+
 2017-12-01  JF Bastien  
 
 WebAssembly: stack trace improvement follow-ups


Modified: trunk/Source/_javascript_Core/runtime/IndexingType.h (225422 => 225423)

--- trunk/Source/_javascript_Core/runtime/IndexingType.h	2017-12-01 23:36:41 UTC

[webkit-changes] [225422] trunk

2017-12-01 Thread wenson_hsieh 
Title: [225422] trunk








Revision 225422
Author wenson_hs...@apple.com
Date 2017-12-01 15:36:41 -0800 (Fri, 01 Dec 2017)


Log Message
[Attachment Support] Implement SPI for clients to update a given attachment's data
https://bugs.webkit.org/show_bug.cgi?id=180184


Reviewed by Tim Horton.

Source/WebCore:

Add native API support for Mail to update the data (and optionally, the name and type) of a given attachment
element. See per-method comments below for more detail.

Test: WKAttachmentTests.ChangeAttachmentDataAndFileInformation
  WKAttachmentTests.ChangeAttachmentDataUpdatesWithInPlaceDisplay

* editing/Editor.cpp:
(WebCore::Editor::insertAttachment):
* html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::setFile):
(WebCore::HTMLAttachmentElement::invalidateShadowRootChildrenIfNecessary):

Pull out logic to hide and reset shadow DOM state into a separate helper, and additionally hide both the image
and video child elements if they exist. This prevents us from getting into a state where both image and video
elements may appear side-by-side when changing data from an image to a video or vice versa.

(WebCore::HTMLAttachmentElement::updateFileWithData):

Add a new helper to update the backing File of an attachment element from data, optionally updating the filename
and content type as well.

(WebCore::HTMLAttachmentElement::populateShadowRootIfNecessary):
* html/HTMLAttachmentElement.h:

Source/WebKit:

Add plumbing to the web process for setting the attachment data (and optionally, the content type and/or file
name) of a given attachment. See WebCore ChangeLog for more detail. Changes covered by new API tests.

* UIProcess/API/APIAttachment.cpp:
(API::Attachment::setDataAndContentType):
* UIProcess/API/APIAttachment.h:
* UIProcess/API/Cocoa/_WKAttachment.h:

Add nullability annotations around _WKAttachment SPI methods.

* UIProcess/API/Cocoa/_WKAttachment.mm:
(-[_WKAttachment setData:newContentType:newFilename:completion:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setAttachmentDataAndContentType):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setAttachmentDataAndContentType):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

Adds two new API tests to exercise the attachment data update flow.

* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::ObserveAttachmentUpdatesForScope::ObserveAttachmentUpdatesForScope):
(-[_WKAttachment synchronouslySetDisplayOptions:error:]):
(-[_WKAttachment synchronouslyRequestData:]):
(-[_WKAttachment synchronouslySetData:newContentType:newFilename:error:]):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/html/HTMLAttachmentElement.cpp
trunk/Source/WebCore/html/HTMLAttachmentElement.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIAttachment.cpp
trunk/Source/WebKit/UIProcess/API/APIAttachment.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAttachment.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (225421 => 225422)

--- trunk/Source/WebCore/ChangeLog	2017-12-01 23:16:32 UTC (rev 225421)
+++ trunk/Source/WebCore/ChangeLog	2017-12-01 23:36:41 UTC (rev 225422)
@@ -1,3 +1,35 @@
+2017-12-01  Wenson Hsieh  
+
+[Attachment Support] Implement SPI for clients to update a given attachment's data
+https://bugs.webkit.org/show_bug.cgi?id=180184
+
+
+Reviewed by Tim Horton.
+
+Add native API support for Mail to update the data (and optionally, the name and type) of a given attachment
+element. See per-method comments below for more detail.
+
+Test: WKAttachmentTests.ChangeAttachmentDataAndFileInformation
+  WKAttachmentTests.ChangeAttachmentDataUpdatesWithInPlaceDisplay
+
+* editing/Editor.cpp:
+(WebCore::Editor::insertAttachment):
+* html/HTMLAttachmentElement.cpp:
+(WebCore::HTMLAttachmentElement::setFile):
+(WebCore::HTMLAttachmentElement::invalidateShadowRootChildrenIfNecessary):
+
+Pull out logic to hide and reset shadow DOM state into a separate helper, and additionally hide both the image
+and video child elements if they exist. This prevents us from getting into a state where both image and video
+elements may appear side-by-side when changing data from an image to a video or vice versa.
+
+(WebCore::HTMLAttachmentElement::updateFileWithData):
+
+Add a new helper to update the backing File of an

[webkit-changes] [225421] trunk

2017-12-01 Thread annulen 
Title: [225421] trunk








Revision 225421
Author annu...@yandex.ru
Date 2017-12-01 15:16:32 -0800 (Fri, 01 Dec 2017)


Log Message
[cmake] Make description of ENABLE_DRAG_SUPPORT more informative
https://bugs.webkit.org/show_bug.cgi?id=180266

Reviewed by Michael Catanzaro.

When disabled, it also disables selection of text with dragging, and this
comes as a surprise for many people.

* Source/cmake/WebKitFeatures.cmake:

Modified Paths

trunk/ChangeLog
trunk/Source/cmake/WebKitFeatures.cmake




Diff

Modified: trunk/ChangeLog (225420 => 225421)

--- trunk/ChangeLog	2017-12-01 23:16:03 UTC (rev 225420)
+++ trunk/ChangeLog	2017-12-01 23:16:32 UTC (rev 225421)
@@ -1,3 +1,15 @@
+2017-12-01  Konstantin Tokarev  
+
+[cmake] Make description of ENABLE_DRAG_SUPPORT more informative
+https://bugs.webkit.org/show_bug.cgi?id=180266
+
+Reviewed by Michael Catanzaro.
+
+When disabled, it also disables selection of text with dragging, and this
+comes as a surprise for many people.
+
+* Source/cmake/WebKitFeatures.cmake:
+
 2017-12-01  Michael Catanzaro  
 
 [GStreamer] Fix USE_GSTREAMER_GL check for GStreamer 1.10


Modified: trunk/Source/cmake/WebKitFeatures.cmake (225420 => 225421)

--- trunk/Source/cmake/WebKitFeatures.cmake	2017-12-01 23:16:03 UTC (rev 225420)
+++ trunk/Source/cmake/WebKitFeatures.cmake	2017-12-01 23:16:32 UTC (rev 225421)
@@ -102,7 +102,7 @@
 WEBKIT_OPTION_DEFINE(ENABLE_DEVICE_ORIENTATION "Toggle DeviceOrientation support" PRIVATE OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_DFG_JIT "Toggle data flow graph JIT tier" PRIVATE ON)
 WEBKIT_OPTION_DEFINE(ENABLE_DOWNLOAD_ATTRIBUTE "Toggle download attribute support" PRIVATE OFF)
-WEBKIT_OPTION_DEFINE(ENABLE_DRAG_SUPPORT "Toggle Drag Support" PRIVATE OFF)
+WEBKIT_OPTION_DEFINE(ENABLE_DRAG_SUPPORT "Toggle support of drag actions (including selection of text with mouse)" PRIVATE OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_ENCRYPTED_MEDIA "Toggle EME support" PRIVATE OFF)
 WEBKIT_OPTION_DEFINE(ENABLE_FETCH_API "Toggle Fetch API support" PRIVATE ON)
 WEBKIT_OPTION_DEFINE(ENABLE_FILTERS_LEVEL_2 "Toggle Filters Module Level 2" PRIVATE OFF)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225420] tags/Safari-605.1.15.1/

2017-12-01 Thread jmarcell 
Title: [225420] tags/Safari-605.1.15.1/








Revision 225420
Author jmarc...@apple.com
Date 2017-12-01 15:16:03 -0800 (Fri, 01 Dec 2017)


Log Message
New tag.

Added Paths

tags/Safari-605.1.15.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225419] trunk/Source/ThirdParty/ANGLE

2017-12-01 Thread ryanhaddad 
Title: [225419] trunk/Source/ThirdParty/ANGLE








Revision 225419
Author ryanhad...@apple.com
Date 2017-12-01 15:13:48 -0800 (Fri, 01 Dec 2017)


Log Message
Unreviewed, rolling out r225412.

Breaks 32-bit macOS builds.

Reverted changeset:

"Unreviewed, fix byte order macros and address new -Wunknown-
pragmas warnings"
https://bugs.webkit.org/show_bug.cgi?id=180177
https://trac.webkit.org/changeset/225412

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/common/third_party/smhasher/src/PMurHash.cpp




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (225418 => 225419)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-01 22:34:48 UTC (rev 225418)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2017-12-01 23:13:48 UTC (rev 225419)
@@ -1,3 +1,16 @@
+2017-12-01  Ryan Haddad  
+
+Unreviewed, rolling out r225412.
+
+Breaks 32-bit macOS builds.
+
+Reverted changeset:
+
+"Unreviewed, fix byte order macros and address new -Wunknown-
+pragmas warnings"
+https://bugs.webkit.org/show_bug.cgi?id=180177
+https://trac.webkit.org/changeset/225412
+
 2017-12-01  Michael Catanzaro  
 
 Unreviewed, fix byte order macros and address new -Wunknown-pragmas warnings


Modified: trunk/Source/ThirdParty/ANGLE/src/common/third_party/smhasher/src/PMurHash.cpp (225418 => 225419)

--- trunk/Source/ThirdParty/ANGLE/src/common/third_party/smhasher/src/PMurHash.cpp	2017-12-01 22:34:48 UTC (rev 225418)
+++ trunk/Source/ThirdParty/ANGLE/src/common/third_party/smhasher/src/PMurHash.cpp	2017-12-01 23:13:48 UTC (rev 225419)
@@ -74,12 +74,6 @@
  * ROTL32(x,r)  Rotate x left by r bits
  */
 
-#if defined(__GNUC__)
-  #define __BIG_ENDIAN __ORDER_BIG_ENDIAN__
-  #define __LITTLE_ENDIAN __ORDER_LITTLE_ENDIAN__
-  #define __BYTE_ORDER __BYTE_ORDER__
-#endif
-
 /* Convention is to define __BYTE_ORDER == to one of these values */
 #if !defined(__BIG_ENDIAN)
   #define __BIG_ENDIAN 4321
@@ -117,14 +111,10 @@
 /* Now find best way we can to READ_UINT32 */
 #if __BYTE_ORDER==__LITTLE_ENDIAN
   /* CPU endian matches murmurhash algorithm, so read 32-bit word directly */
-#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
-#endif
   #define READ_UINT32(ptr)   (*((uint32_t*)(ptr)))
-#if defined(__clang__)
 #pragma clang diagnostic pop
-#endif
 #elif __BYTE_ORDER==__BIG_ENDIAN
   /* TODO: Add additional cases below where a compiler provided bswap32 is available */
   #if defined(__GNUC__) && (__GNUC__>4 || (__GNUC__==4 && __GNUC_MINOR__>=3))
@@ -231,14 +221,10 @@
   switch(n) { /* how many bytes in c */
   case 0: /* c=[]  w=[3210]  b=[3210]=wc'=[] */
 for( ; ptr < end ; ptr+=4) {
-#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
-#endif
   uint32_t k1 = READ_UINT32(ptr);
-#if defined(__clang__)
 #pragma clang diagnostic pop
-#endif
   DOBLOCK(h1, k1);
 }
 break;
@@ -245,14 +231,10 @@
   case 1: /* c=[0---]  w=[4321]  b=[3210]=c>>24|w<<8   c'=[4---] */
 for( ; ptr < end ; ptr+=4) {
   uint32_t k1 = c>>24;
-#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
-#endif
   c = READ_UINT32(ptr);
-#if defined(__clang__)
 #pragma clang diagnostic pop
-#endif
   k1 |= c<<8;
   DOBLOCK(h1, k1);
 }
@@ -260,14 +242,10 @@
   case 2: /* c=[10--]  w=[5432]  b=[3210]=c>>16|w<<16  c'=[54--] */
 for( ; ptr < end ; ptr+=4) {
   uint32_t k1 = c>>16;
-#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
-#endif
   c = READ_UINT32(ptr);
-#if defined(__clang__)
 #pragma clang diagnostic pop
-#endif
   k1 |= c<<16;
   DOBLOCK(h1, k1);
 }
@@ -275,14 +253,10 @@
   case 3: /* c=[210-]  w=[6543]  b=[3210]=c>>8|w<<24   c'=[654-] */
 for( ; ptr < end ; ptr+=4) {
   uint32_t k1 = c>>8;
-#if defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wcast-align"
-#endif
   c = READ_UINT32(ptr);
-#if defined(__clang__)
 #pragma clang diagnostic pop
-#endif
   k1 |= c<<24;
   DOBLOCK(h1, k1);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225418] branches/safari-604.5.100-branch/Source

2017-12-01 Thread jmarcell 
Title: [225418] branches/safari-604.5.100-branch/Source








Revision 225418
Author jmarc...@apple.com
Date 2017-12-01 14:34:48 -0800 (Fri, 01 Dec 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.5.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.5.100-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.5.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig (225417 => 225418)

--- branches/safari-604.5.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-12-01 22:30:28 UTC (rev 225417)
+++ branches/safari-604.5.100-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-12-01 22:34:48 UTC (rev 225418)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 2;
-MICRO_VERSION = 0;
+TINY_VERSION = 100;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.5.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (225417 => 225418)

--- branches/safari-604.5.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-12-01 22:30:28 UTC (rev 225417)
+++ branches/safari-604.5.100-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-12-01 22:34:48 UTC (rev 225418)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 2;
-MICRO_VERSION = 0;
+TINY_VERSION = 100;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.5.100-branch/Source/WebCore/Configurations/Version.xcconfig (225417 => 225418)

--- branches/safari-604.5.100-branch/Source/WebCore/Configurations/Version.xcconfig	2017-12-01 22:30:28 UTC (rev 225417)
+++ branches/safari-604.5.100-branch/Source/WebCore/Configurations/Version.xcconfig	2017-12-01 22:34:48 UTC (rev 225418)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 2;
-MICRO_VERSION = 0;
+TINY_VERSION = 100;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.5.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (225417 => 225418)

--- branches/safari-604.5.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-12-01 22:30:28 UTC (rev 225417)
+++ branches/safari-604.5.100-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-12-01 22:34:48 UTC (rev 225418)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 2;
-MICRO_VERSION = 0;
+TINY_VERSION = 100;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.5.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (225417 => 225418)

--- branches/safari-604.5.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-12-01 22:30:28 UTC (rev 225417)
+++ branches/safari-604.5.100-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-12-01 22:34:48 UTC (rev 225418)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 5;
-TINY_VERSION = 2;
-MICRO_VERSION = 0;
+TINY_VERSION = 100;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.

[webkit-changes] [225417] branches/safari-604.5.100-branch/

2017-12-01 Thread jmarcell 
Title: [225417] branches/safari-604.5.100-branch/








Revision 225417
Author jmarc...@apple.com
Date 2017-12-01 14:30:28 -0800 (Fri, 01 Dec 2017)


Log Message
New branch.

Added Paths

branches/safari-604.5.100-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225416] trunk/Source/JavaScriptCore

2017-12-01 Thread jfbastien 
Title: [225416] trunk/Source/_javascript_Core








Revision 225416
Author jfbast...@apple.com
Date 2017-12-01 14:19:03 -0800 (Fri, 01 Dec 2017)


Log Message
WebAssembly: stack trace improvement follow-ups
https://bugs.webkit.org/show_bug.cgi?id=180273

Reviewed by Saam Barati.

* wasm/WasmIndexOrName.cpp:
(JSC::Wasm::makeString):
* wasm/WasmIndexOrName.h:
(JSC::Wasm::IndexOrName::nameSection const):
* wasm/WasmNameSection.h:
(JSC::Wasm::NameSection::NameSection):
(JSC::Wasm::NameSection::get):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmIndexOrName.cpp
trunk/Source/_javascript_Core/wasm/WasmIndexOrName.h
trunk/Source/_javascript_Core/wasm/WasmNameSection.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (225415 => 225416)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-01 22:14:55 UTC (rev 225415)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-01 22:19:03 UTC (rev 225416)
@@ -1,5 +1,20 @@
 2017-12-01  JF Bastien  
 
+WebAssembly: stack trace improvement follow-ups
+https://bugs.webkit.org/show_bug.cgi?id=180273
+
+Reviewed by Saam Barati.
+
+* wasm/WasmIndexOrName.cpp:
+(JSC::Wasm::makeString):
+* wasm/WasmIndexOrName.h:
+(JSC::Wasm::IndexOrName::nameSection const):
+* wasm/WasmNameSection.h:
+(JSC::Wasm::NameSection::NameSection):
+(JSC::Wasm::NameSection::get):
+
+2017-12-01  JF Bastien  
+
 WebAssembly: restore cached stack limit after out-call
 https://bugs.webkit.org/show_bug.cgi?id=179106
 


Modified: trunk/Source/_javascript_Core/wasm/WasmIndexOrName.cpp (225415 => 225416)

--- trunk/Source/_javascript_Core/wasm/WasmIndexOrName.cpp	2017-12-01 22:14:55 UTC (rev 225415)
+++ trunk/Source/_javascript_Core/wasm/WasmIndexOrName.cpp	2017-12-01 22:19:03 UTC (rev 225416)
@@ -46,11 +46,11 @@
 String makeString(const IndexOrName& ion)
 {
 if (ion.isEmpty())
-return String("wasm-stub");
+return ASCIILiteral("wasm-stub");
 const String moduleName = ion.nameSection()->moduleName.size() ? String(ion.nameSection()->moduleName.data(), ion.nameSection()->moduleName.size()) : String(ion.nameSection()->moduleHash.data(), ion.nameSection()->moduleHash.size());
 if (ion.isIndex())
-return makeString(moduleName, ".wasm-function[", String::number(ion.m_indexName.index & ~IndexOrName::indexTag), "]");
-return makeString(moduleName, ".wasm-function[", String(ion.m_indexName.name->data(), ion.m_indexName.name->size()), "]");
+return makeString(moduleName, ".wasm-function[", String::number(ion.m_indexName.index & ~IndexOrName::indexTag), ']');
+return makeString(moduleName, ".wasm-function[", String(ion.m_indexName.name->data(), ion.m_indexName.name->size()), ']');
 }
 
 } } // namespace JSC::Wasm


Modified: trunk/Source/_javascript_Core/wasm/WasmIndexOrName.h (225415 => 225416)

--- trunk/Source/_javascript_Core/wasm/WasmIndexOrName.h	2017-12-01 22:14:55 UTC (rev 225415)
+++ trunk/Source/_javascript_Core/wasm/WasmIndexOrName.h	2017-12-01 22:19:03 UTC (rev 225416)
@@ -43,7 +43,7 @@
 bool isEmpty() const { return bitwise_cast(m_indexName) & emptyTag; }
 bool isIndex() const { return bitwise_cast(m_indexName) & indexTag; }
 bool isName() const { return !(isEmpty() || isName()); }
-NameSection* nameSection() const { return m_nameSection ? m_nameSection.get() : nullptr; }
+NameSection* nameSection() const { return m_nameSection.get(); }
 
 friend String makeString(const IndexOrName&);
 


Modified: trunk/Source/_javascript_Core/wasm/WasmNameSection.h (225415 => 225416)

--- trunk/Source/_javascript_Core/wasm/WasmNameSection.h	2017-12-01 22:14:55 UTC (rev 225415)
+++ trunk/Source/_javascript_Core/wasm/WasmNameSection.h	2017-12-01 22:19:03 UTC (rev 225416)
@@ -26,6 +26,7 @@
 #pragma once
 
 #include "WasmName.h"
+#include 
 #include 
 #include 
 #include 
@@ -34,6 +35,9 @@
 namespace JSC { namespace Wasm {
 
 struct NameSection : public ThreadSafeRefCounted {
+WTF_MAKE_NONCOPYABLE(NameSection);
+
+public:
 NameSection(const CString )
 : moduleHash(hash.length())
 {
@@ -40,11 +44,10 @@
 for (size_t i = 0; i < hash.length(); ++i)
 moduleHash[i] = static_cast(*(hash.data() + i));
 }
-NameSection(const NameSection&) = delete;
 
 std::pair> get(size_t functionIndexSpace)
 {
-return std::make_pair(functionIndexSpace < functionNames.size() ? [functionIndexSpace] : nullptr, RefPtr(this));
+return std::make_pair(functionIndexSpace < functionNames.size() ? [functionIndexSpace] : nullptr, makeRefPtr(this));
 }
 Name moduleName;
 Name moduleHash;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [225415] trunk/Source/WebCore

2017-12-01 Thread cdumez 
Title: [225415] trunk/Source/WebCore








Revision 225415
Author cdu...@apple.com
Date 2017-12-01 14:14:55 -0800 (Fri, 01 Dec 2017)


Log Message
Get rid of microtask in ServiceWorkerContainer::jobResolvedWithRegistration()
https://bugs.webkit.org/show_bug.cgi?id=180263

Reviewed by Youenn Fablet.

Get rid of microtask in ServiceWorkerContainer::jobResolvedWithRegistration(). It
is no longer needed and MicrotaskQueue::mainThreadQueue() is only safe to use from
the main thread, as its name suggest. ServiceWorkerContainer are also instantiated
in Service worker threads nowadays.

* workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::registrationJobResolvedInServer):
* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
* workers/service/ServiceWorkerContainer.h:
* workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::resolvedWithRegistration):
* workers/service/ServiceWorkerJob.h:
* workers/service/ServiceWorkerJobClient.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/SWClientConnection.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h
trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp
trunk/Source/WebCore/workers/service/ServiceWorkerJob.h
trunk/Source/WebCore/workers/service/ServiceWorkerJobClient.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (225414 => 225415)

--- trunk/Source/WebCore/ChangeLog	2017-12-01 22:13:37 UTC (rev 225414)
+++ trunk/Source/WebCore/ChangeLog	2017-12-01 22:14:55 UTC (rev 225415)
@@ -1,3 +1,25 @@
+2017-12-01  Chris Dumez  
+
+Get rid of microtask in ServiceWorkerContainer::jobResolvedWithRegistration()
+https://bugs.webkit.org/show_bug.cgi?id=180263
+
+Reviewed by Youenn Fablet.
+
+Get rid of microtask in ServiceWorkerContainer::jobResolvedWithRegistration(). It
+is no longer needed and MicrotaskQueue::mainThreadQueue() is only safe to use from
+the main thread, as its name suggest. ServiceWorkerContainer are also instantiated
+in Service worker threads nowadays.
+
+* workers/service/SWClientConnection.cpp:
+(WebCore::SWClientConnection::registrationJobResolvedInServer):
+* workers/service/ServiceWorkerContainer.cpp:
+(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
+* workers/service/ServiceWorkerContainer.h:
+* workers/service/ServiceWorkerJob.cpp:
+(WebCore::ServiceWorkerJob::resolvedWithRegistration):
+* workers/service/ServiceWorkerJob.h:
+* workers/service/ServiceWorkerJobClient.h:
+
 2017-12-01  Myles C. Maxfield  
 
 Free FontFaceSets may include fonts that were never actually added to them


Modified: trunk/Source/WebCore/workers/service/SWClientConnection.cpp (225414 => 225415)

--- trunk/Source/WebCore/workers/service/SWClientConnection.cpp	2017-12-01 22:13:37 UTC (rev 225414)
+++ trunk/Source/WebCore/workers/service/SWClientConnection.cpp	2017-12-01 22:14:55 UTC (rev 225415)
@@ -87,10 +87,7 @@
 }
 
 auto key = registrationData.key;
-job->resolvedWithRegistration(WTFMove(registrationData), [this, protectedThis = makeRef(*this), key, shouldNotifyWhenResolved] {
-if (shouldNotifyWhenResolved == ShouldNotifyWhenResolved::Yes)
-didResolveRegistrationPromise(key);
-});
+job->resolvedWithRegistration(WTFMove(registrationData), shouldNotifyWhenResolved);
 }
 
 void SWClientConnection::unregistrationJobResolvedInServer(const ServiceWorkerJobDataIdentifier& jobDataIdentifier, bool unregistrationResult)


Modified: trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp (225414 => 225415)

--- trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp	2017-12-01 22:13:37 UTC (rev 225414)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp	2017-12-01 22:14:55 UTC (rev 225415)
@@ -35,7 +35,6 @@
 #include "JSDOMPromiseDeferred.h"
 #include "JSServiceWorkerRegistration.h"
 #include "Logging.h"
-#include "Microtasks.h"
 #include "NavigatorBase.h"
 #include "ResourceError.h"
 #include "ScriptExecutionContext.h"
@@ -308,20 +307,29 @@
 registration->scheduleTaskToFireUpdateFoundEvent();
 }
 
-void ServiceWorkerContainer::jobResolvedWithRegistration(ServiceWorkerJob& job, ServiceWorkerRegistrationData&& data, WTF::Function&& promiseResolvedHandler)
+void ServiceWorkerContainer::jobResolvedWithRegistration(ServiceWorkerJob& job, ServiceWorkerRegistrationData&& data, ShouldNotifyWhenResolved shouldNotifyWhenResolved)
 {
 auto guard = WTF::makeScopeExit([this, ] {
 jobDidFinish(job);
 });
 
+WTF::Function notifyWhenResolvedIfNeeded = [] { };
+if (shouldNotifyWhenResolved == ShouldNotifyWhenResolved::Yes) {
+notifyWhenResolvedIfNeeded = [connection = m_swConnection,

[webkit-changes] [225414] trunk

2017-12-01 Thread mmaxfield 
Title: [225414] trunk








Revision 225414
Author mmaxfi...@apple.com
Date 2017-12-01 14:13:37 -0800 (Fri, 01 Dec 2017)


Log Message
Free FontFaceSets may include fonts that were never actually added to them
https://bugs.webkit.org/show_bug.cgi?id=180164

Reviewed by Simon Fraser.

Source/WebCore:

There are two circumstances where this can occur:

- If script makes a so-called "free" FontFaceSet, by using "new FontFaceSet". This object is not
associated with the document, and should therefore only include fonts which have been manually
added to it from script. However, today, this object includes preinstalled fonts which have the
same names as any fonts manually added to it. (So, if you manually add "Helvetica", the object
would have two objects - the one you just added and the preinstalled version too).

- For the document's FontFaceSet, the same thing would happen. This one is a little trickier
because the spec is not clear whether or not the document's FontFaceSet should include these
preinstalled fonts. However, running this test in Firefox and Chrome, they both agree that
preinstalled fonts should not be present, so this patch adheres to this behavior.

We can't actually remove the preinstalled fonts from the document's FontFaceSet (because that's
how normal font lookups are performed), but we can filter them out at the point they meet the
_javascript_ API. And, for "free" FontFaceSets, we can avoid adding them in the first place for
performance.

Test: fast/text/font-face-api-preinstalled.html

* css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::CSSFontFaceSet):
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
(WebCore::CSSFontFaceSet::addToFacesLookupTable):
(WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):
(WebCore::CSSFontFaceSet::check):
(WebCore::CSSFontFaceSet::matchingFaces): Deleted.
* css/CSSFontFaceSet.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
* css/FontFaceSet.cpp:
(WebCore::FontFaceSet::load):

LayoutTests:

* fast/text/font-face-api-preinstalled-expected.txt: Added.
* fast/text/font-face-api-preinstalled.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontFaceSet.cpp
trunk/Source/WebCore/css/CSSFontFaceSet.h
trunk/Source/WebCore/css/CSSFontSelector.cpp
trunk/Source/WebCore/css/FontFaceSet.cpp


Added Paths

trunk/LayoutTests/fast/text/font-face-api-preinstalled-expected.txt
trunk/LayoutTests/fast/text/font-face-api-preinstalled.html




Diff

Modified: trunk/LayoutTests/ChangeLog (225413 => 225414)

--- trunk/LayoutTests/ChangeLog	2017-12-01 22:12:01 UTC (rev 225413)
+++ trunk/LayoutTests/ChangeLog	2017-12-01 22:13:37 UTC (rev 225414)
@@ -1,3 +1,13 @@
+2017-12-01  Myles C. Maxfield  
+
+Free FontFaceSets may include fonts that were never actually added to them
+https://bugs.webkit.org/show_bug.cgi?id=180164
+
+Reviewed by Simon Fraser.
+
+* fast/text/font-face-api-preinstalled-expected.txt: Added.
+* fast/text/font-face-api-preinstalled.html: Added.
+
 2017-12-01  Ryan Haddad  
 
 Update TestExpectations for various editing tests on iOS.


Added: trunk/LayoutTests/fast/text/font-face-api-preinstalled-expected.txt (0 => 225414)

--- trunk/LayoutTests/fast/text/font-face-api-preinstalled-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/text/font-face-api-preinstalled-expected.txt	2017-12-01 22:13:37 UTC (rev 225414)
@@ -0,0 +1,11 @@
+This test makes sure that preinstalled fonts are never returned from the CSS Font Loading API.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS result.length is 0
+PASS result.length is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/text/font-face-api-preinstalled.html (0 => 225414)

--- trunk/LayoutTests/fast/text/font-face-api-preinstalled.html	(rev 0)
+++ trunk/LayoutTests/fast/text/font-face-api-preinstalled.html	2017-12-01 22:13:37 UTC (rev 225414)
@@ -0,0 +1,35 @@
+
+
+
+
+
+