[webkit-changes] [225895] trunk/Source/WebInspectorUI
Title: [225895] trunk/Source/WebInspectorUI Revision 225895 Author commit-qu...@webkit.org Date 2017-12-13 23:45:29 -0800 (Wed, 13 Dec 2017) Log Message Web Inspector: Network Tab - Make text filter just a URL filter and update incrementally https://bugs.webkit.org/show_bug.cgi?id=180796 Patch by Joseph Pecoraro on 2017-12-13 Reviewed by Brian Burg. Revert the Network Tab's text filter back to being just a URL filter with the normal behaviors of our other text filters that update as you type (incremental). This also renames the "text filter" to "url filter" everywhere in the ContentView for clarity. A follow-up change will make the url filter be case-insensitive to fully match the filter bars in other tabs. * Localizations/en.lproj/localizedStrings.js: * UserInterface/Views/NetworkTableContentView.js: (WI.NetworkTableContentView): (WI.NetworkTableContentView.prototype.get filterNavigationItems): (WI.NetworkTableContentView.prototype._checkURLFilterAgainstFinishedResource): (WI.NetworkTableContentView.prototype._updateURLFilterActiveIndicator): (WI.NetworkTableContentView.prototype._resourceLoadingDidFinish): (WI.NetworkTableContentView.prototype._resourceLoadingDidFail): (WI.NetworkTableContentView.prototype._hasURLFilter): (WI.NetworkTableContentView.prototype._hasActiveFilter): (WI.NetworkTableContentView.prototype._passURLFilter): (WI.NetworkTableContentView.prototype._passFilter): (WI.NetworkTableContentView.prototype._updateFilteredEntries): (WI.NetworkTableContentView.prototype._resetFilters): (WI.NetworkTableContentView.prototype._urlFilterDidChange): (WI.NetworkTableContentView.prototype._checkTextFilterAgainstFinishedResource): Deleted. (WI.NetworkTableContentView.prototype._checkTextFilterAgainstFailedResource): Deleted. (WI.NetworkTableContentView.prototype._updateTextFilterActiveIndicator): Deleted. (WI.NetworkTableContentView.prototype._hasTextFilter): Deleted. (WI.NetworkTableContentView.prototype._passTextFilter): Deleted. (WI.NetworkTableContentView.prototype._textFilterDidChange): Deleted. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (225894 => 225895) --- trunk/Source/WebInspectorUI/ChangeLog 2017-12-14 07:00:57 UTC (rev 225894) +++ trunk/Source/WebInspectorUI/ChangeLog 2017-12-14 07:45:29 UTC (rev 225895) @@ -1,5 +1,40 @@ 2017-12-13 Joseph Pecoraro +Web Inspector: Network Tab - Make text filter just a URL filter and update incrementally +https://bugs.webkit.org/show_bug.cgi?id=180796 + +Reviewed by Brian Burg. + +Revert the Network Tab's text filter back to being just a URL filter with the +normal behaviors of our other text filters that update as you type (incremental). +This also renames the "text filter" to "url filter" everywhere in the ContentView +for clarity. A follow-up change will make the url filter be case-insensitive +to fully match the filter bars in other tabs. + +* Localizations/en.lproj/localizedStrings.js: +* UserInterface/Views/NetworkTableContentView.js: +(WI.NetworkTableContentView): +(WI.NetworkTableContentView.prototype.get filterNavigationItems): +(WI.NetworkTableContentView.prototype._checkURLFilterAgainstFinishedResource): +(WI.NetworkTableContentView.prototype._updateURLFilterActiveIndicator): +(WI.NetworkTableContentView.prototype._resourceLoadingDidFinish): +(WI.NetworkTableContentView.prototype._resourceLoadingDidFail): +(WI.NetworkTableContentView.prototype._hasURLFilter): +(WI.NetworkTableContentView.prototype._hasActiveFilter): +(WI.NetworkTableContentView.prototype._passURLFilter): +(WI.NetworkTableContentView.prototype._passFilter): +(WI.NetworkTableContentView.prototype._updateFilteredEntries): +(WI.NetworkTableContentView.prototype._resetFilters): +(WI.NetworkTableContentView.prototype._urlFilterDidChange): +(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFinishedResource): Deleted. +(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFailedResource): Deleted. +(WI.NetworkTableContentView.prototype._updateTextFilterActiveIndicator): Deleted. +(WI.NetworkTableContentView.prototype._hasTextFilter): Deleted. +(WI.NetworkTableContentView.prototype._passTextFilter): Deleted. +(WI.NetworkTableContentView.prototype._textFilterDidChange): Deleted. + +2017-12-13 Joseph Pecoraro + REGRESSION: Web Inspector: Opening inspector crashes page if there are empty resources https://bugs.webkit.org/show_bug.cgi?id=180787 Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (225894 => 225895) --- trunk/Source/WebInspectorUI/Localiz
[webkit-changes] [225894] trunk/LayoutTests
Title: [225894] trunk/LayoutTests
Revision 225894
Author dba...@webkit.org
Date 2017-12-13 23:00:57 -0800 (Wed, 13 Dec 2017)
Log Message
Add more auto fill button types
https://bugs.webkit.org/show_bug.cgi?id=180651
And
Add macOS El Capitan-specific and Windows expected results. I included results from the Apple Windows bot
as a baseline. The results are incorrect as they render the password field text using bullets instead of
plain text. Further investigation required.
* platform/mac-elcapitan/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
* platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Added.
* platform/win/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac-elcapitan/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt
trunk/LayoutTests/platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt
trunk/LayoutTests/platform/win/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (225893 => 225894)
--- trunk/LayoutTests/ChangeLog 2017-12-14 06:04:51 UTC (rev 225893)
+++ trunk/LayoutTests/ChangeLog 2017-12-14 07:00:57 UTC (rev 225894)
@@ -1,3 +1,19 @@
+2017-12-13 Daniel Bates
+
+Add more auto fill button types
+https://bugs.webkit.org/show_bug.cgi?id=180651
+
+And
+
+
+Add macOS El Capitan-specific and Windows expected results. I included results from the Apple Windows bot
+as a baseline. The results are incorrect as they render the password field text using bullets instead of
+plain text. Further investigation required.
+
+* platform/mac-elcapitan/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
+* platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Added.
+* platform/win/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
+
2017-12-13 Joseph Pecoraro
REGRESSION: Web Inspector: Opening inspector crashes page if there are empty resources
Added: trunk/LayoutTests/platform/mac-elcapitan/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt (0 => 225894)
--- trunk/LayoutTests/platform/mac-elcapitan/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-elcapitan/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt 2017-12-14 07:00:57 UTC (rev 225894)
@@ -0,0 +1,53 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x104
+ RenderBlock {HTML} at (0,0) size 800x104
+RenderBody {BODY} at (8,16) size 784x80
+ RenderBlock {P} at (0,0) size 784x18
+RenderText {#text} at (0,0) size 757x18
+ text run at (0,0) width 757: "This tests that the Strong Password AutoFill button renders in an auto-filled input. It can only be tested in the test tool."
+ RenderBlock {DIV} at (0,34) size 784x46
+RenderTextControl {INPUT} at (2,2) size 158x19 [bgcolor=#FAFFBD] [border: (2px inset #00)]
+ RenderFlexibleBox {DIV} at (3,3) size 152x13
+RenderBlock {DIV} at (0,0) size 58x13
+RenderBlock {DIV} at (57,0) size 95x13
+ RenderText {#text} at (6,0) size 89x13
+text run at (6,0) width 89: "strong password"
+RenderText {#text} at (162,2) size 4x18
+ text run at (162,2) width 4: " "
+RenderTextControl {INPUT} at (168,2) size 158x19 [bgcolor=#FAFFBD] [border: (2px inset #00)]
+ RenderFlexibleBox {DIV} at (3,3) size 152x13
+RenderBlock {DIV} at (0,0) size 58x13
+RenderBlock {DIV} at (57,0) size 95x13
+ RenderText {#text} at (6,0) size 89x13
+text run at (6,0) width 89: "strong password"
+RenderText {#text} at (328,2) size 4x18
+ text run at (328,2) width 4: " "
+RenderTextControl {INPUT} at (332,2) size 306x19 [bgcolor=#FAFFBD] [border: (2px inset #00)]
+ RenderFlexibleBox {DIV} at (3,3) size 300x13
+RenderBlock {DIV} at (0,0) size 206x13
+RenderBlock {DIV} at (205,0) size 95x13
+ RenderText {#text} at (6,0) size 89x13
+text run at (6,0) width 89: "strong password"
+RenderText {#text} at (638,2) size 4x18
+ text run at (638,2) width 4: " "
+RenderTextControl {INPUT} at (2,25) size 158x19 [bgcolor=#FAFFBD] [border: (2px inset #00)]
+ RenderFlexibleBox {DIV} at (3,3) size 152x13
+RenderBlock {DIV} at (0,0) size 5
[webkit-changes] [225893] trunk/Source/JavaScriptCore
Title: [225893] trunk/Source/_javascript_Core
Revision 225893
Author fpi...@apple.com
Date 2017-12-13 22:04:51 -0800 (Wed, 13 Dec 2017)
Log Message
Octane/richards regressed by a whopping 20% because eliminateCommonSubexpressions has a weird fixpoint requirement
https://bugs.webkit.org/show_bug.cgi?id=180783
Reviewed by Saam Barati.
This fixes the regression by fixpointing CSE. We need to fixpoint CSE because of this case:
BB#1:
a: Load(@x)
b: Load(@x)
c: Load(@b)
BB#2:
d: Load(@b)
BB#3:
e: Load(@b)
Lets assume that #3 loops around to #2, so to eliminate @d, we need to prove that it's redundant
with both @c and @e. The problem is that by the time we get to @d, the CSE state will look like
this:
BB#1:
a: Load(@x)
b: Load(@x)
c: Load(@a)
memoryAtTail: {@x=>@a, @a=>@c}
BB#2:
d: Load(@a) [sic]
memoryAtTail: {@b=>@d}
BB#3:
e: Load(@b)
memoryAtTail: {@b=>@e} [sic]
Note that #3's atTail map is keyed on @b, which was the old (no longer canonical) version of @a.
But @d's children were already substituted, so it refers to @a. Since @a is not in #3's atTail
map, we don't find it and leave the redundancy.
I think that the cleanest solution is to fixpoint. CSE is pretty cheap, so hopefully we can afford
this. It fixes the richards regression, since richards is super dependent on B3 CSE.
* b3/B3EliminateCommonSubexpressions.cpp: Logging.
* b3/B3Generate.cpp:
(JSC::B3::generateToAir): Fix the bug.
* b3/air/AirReportUsedRegisters.cpp:
(JSC::B3::Air::reportUsedRegisters): Logging.
* dfg/DFGByteCodeParser.cpp:
* dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run): Don't generate EntrySwitch if we don't need it (makes IR easier to read).
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower): Don't generate EntrySwitch if we don't need it (makes IR easier to read).
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3EliminateCommonSubexpressions.cpp
trunk/Source/_javascript_Core/b3/B3Generate.cpp
trunk/Source/_javascript_Core/b3/air/AirReportUsedRegisters.cpp
trunk/Source/_javascript_Core/dfg/DFGSSAConversionPhase.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225892 => 225893)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-14 04:47:34 UTC (rev 225892)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-14 06:04:51 UTC (rev 225893)
@@ -1,3 +1,55 @@
+2017-12-13 Filip Pizlo
+
+Octane/richards regressed by a whopping 20% because eliminateCommonSubexpressions has a weird fixpoint requirement
+https://bugs.webkit.org/show_bug.cgi?id=180783
+
+Reviewed by Saam Barati.
+
+This fixes the regression by fixpointing CSE. We need to fixpoint CSE because of this case:
+
+BB#1:
+a: Load(@x)
+b: Load(@x)
+c: Load(@b)
+BB#2:
+d: Load(@b)
+BB#3:
+e: Load(@b)
+
+Lets assume that #3 loops around to #2, so to eliminate @d, we need to prove that it's redundant
+with both @c and @e. The problem is that by the time we get to @d, the CSE state will look like
+this:
+
+BB#1:
+a: Load(@x)
+b: Load(@x)
+c: Load(@a)
+memoryAtTail: {@x=>@a, @a=>@c}
+BB#2:
+d: Load(@a) [sic]
+memoryAtTail: {@b=>@d}
+BB#3:
+e: Load(@b)
+memoryAtTail: {@b=>@e} [sic]
+
+Note that #3's atTail map is keyed on @b, which was the old (no longer canonical) version of @a.
+But @d's children were already substituted, so it refers to @a. Since @a is not in #3's atTail
+map, we don't find it and leave the redundancy.
+
+I think that the cleanest solution is to fixpoint. CSE is pretty cheap, so hopefully we can afford
+this. It fixes the richards regression, since richards is super dependent on B3 CSE.
+
+* b3/B3EliminateCommonSubexpressions.cpp: Logging.
+* b3/B3Generate.cpp:
+(JSC::B3::generateToAir): Fix the bug.
+* b3/air/AirReportUsedRegisters.cpp:
+(JSC::B3::Air::reportUsedRegisters): Logging.
+* dfg/DFGByteCodeParser.cpp:
+* dfg/DFGSSAConversionPhase.cpp:
+(JSC::DFG::SSAConversionPhase::run): Don't generate EntrySwitch if we don't need it (makes IR easier to read).
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::lower): Don't generate EntrySwitch if we don't need it (makes IR easier to read).
+
2017-12-13 Joseph Pecoraro
REGRESSION: Web Inspector: Opening inspector crashes page if there are empty resources
Modified: trunk/Source/_javascrip
[webkit-changes] [225892] trunk
Title: [225892] trunk
Revision 225892
Author commit-qu...@webkit.org
Date 2017-12-13 20:47:34 -0800 (Wed, 13 Dec 2017)
Log Message
REGRESSION: Web Inspector: Opening inspector crashes page if there are empty resources
https://bugs.webkit.org/show_bug.cgi?id=180787
Patch by Joseph Pecoraro on 2017-12-13
Reviewed by Brian Burg.
Source/_javascript_Core:
* inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::findMagicComment):
For empty / null strings just return. There is no use
trying to search them for a long common syntax.
Source/WebInspectorUI:
* UserInterface/Test/TestUtilities.js:
Add a generic sanitizeURL used by many tests.
* UserInterface/TestStub.html:
Include TestUtilities.
LayoutTests:
* inspector/page/resources/empty.css: Added.
* inspector/page/resources/empty.js: Added.
* inspector/page/empty-or-missing-resources-expected.txt: Added.
* inspector/page/empty-or-missing-resources.html: Added.
Test no crashes inspecting a page with empty/missing resources.
Previously the test would crash.
* inspector/canvas/recording-webgl-snapshots.html:
* inspector/canvas/resources/create-context-utilities.js:
* inspector/canvas/resources/recording-utilities.js:
* inspector/css/getAllStyleSheets.html:
* inspector/css/stylesheet-events-basic.html:
* inspector/css/stylesheet-events-imports.html:
* inspector/css/stylesheet-events-multiple-documents.html:
* inspector/worker/console-basic.html:
* inspector/worker/debugger-scripts.html:
* inspector/worker/resources-in-worker.html:
* inspector/worker/runtime-basic.html:
* inspector/worker/worker-create-and-terminate.html:
Promote sanitizeURL to a TestUtility function since it is common.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html
trunk/LayoutTests/inspector/canvas/resources/create-context-utilities.js
trunk/LayoutTests/inspector/canvas/resources/recording-utilities.js
trunk/LayoutTests/inspector/css/getAllStyleSheets.html
trunk/LayoutTests/inspector/css/stylesheet-events-basic.html
trunk/LayoutTests/inspector/css/stylesheet-events-imports.html
trunk/LayoutTests/inspector/css/stylesheet-events-multiple-documents.html
trunk/LayoutTests/inspector/worker/console-basic.html
trunk/LayoutTests/inspector/worker/debugger-scripts.html
trunk/LayoutTests/inspector/worker/resources-in-worker.html
trunk/LayoutTests/inspector/worker/runtime-basic.html
trunk/LayoutTests/inspector/worker/worker-create-and-terminate.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/ContentSearchUtilities.cpp
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Test/TestUtilities.js
trunk/Source/WebInspectorUI/UserInterface/TestStub.html
Added Paths
trunk/LayoutTests/inspector/page/empty-or-missing-resources-expected.txt
trunk/LayoutTests/inspector/page/empty-or-missing-resources.html
Diff
Modified: trunk/LayoutTests/ChangeLog (225891 => 225892)
--- trunk/LayoutTests/ChangeLog 2017-12-14 04:10:02 UTC (rev 225891)
+++ trunk/LayoutTests/ChangeLog 2017-12-14 04:47:34 UTC (rev 225892)
@@ -1,3 +1,32 @@
+2017-12-13 Joseph Pecoraro
+
+REGRESSION: Web Inspector: Opening inspector crashes page if there are empty resources
+https://bugs.webkit.org/show_bug.cgi?id=180787
+
+
+Reviewed by Brian Burg.
+
+* inspector/page/resources/empty.css: Added.
+* inspector/page/resources/empty.js: Added.
+* inspector/page/empty-or-missing-resources-expected.txt: Added.
+* inspector/page/empty-or-missing-resources.html: Added.
+Test no crashes inspecting a page with empty/missing resources.
+Previously the test would crash.
+
+* inspector/canvas/recording-webgl-snapshots.html:
+* inspector/canvas/resources/create-context-utilities.js:
+* inspector/canvas/resources/recording-utilities.js:
+* inspector/css/getAllStyleSheets.html:
+* inspector/css/stylesheet-events-basic.html:
+* inspector/css/stylesheet-events-imports.html:
+* inspector/css/stylesheet-events-multiple-documents.html:
+* inspector/worker/console-basic.html:
+* inspector/worker/debugger-scripts.html:
+* inspector/worker/resources-in-worker.html:
+* inspector/worker/runtime-basic.html:
+* inspector/worker/worker-create-and-terminate.html:
+Promote sanitizeURL to a TestUtility function since it is common.
+
2017-12-13 Daniel Bates
Add more auto fill button types
Modified: trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html (225891 => 225892)
--- trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html 2017-12-14 04:10:02 UTC (rev 225891)
+++ trunk/LayoutTests/inspector/canvas/recording-webgl-snapshots.html 2017-12-14 04:47:34 UTC (rev 225892)
@@ -88,10 +88,6 @@
function test() {
let suite = InspectorTest.createAsyncSuite("Canvas.recordingWebGL");
-function sa
[webkit-changes] [225891] trunk
Title: [225891] trunk
Revision 225891
Author sbar...@apple.com
Date 2017-12-13 20:10:02 -0800 (Wed, 13 Dec 2017)
Log Message
Arrow functions need their own structure because they have different properties than sloppy functions
https://bugs.webkit.org/show_bug.cgi?id=180779
Reviewed by Mark Lam.
JSTests:
* stress/arrow-function-needs-its-own-structure.js: Added.
(assert):
(readPrototype):
(noInline.let.f1):
(noInline):
Source/_javascript_Core:
We were using the same structure for sloppy functions and
arrow functions. This broke our IC caching machinery because
these two types of functions actually have different properties.
This patch gives them different structures.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewFunction):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/JSFunction.cpp:
(JSC::JSFunction::selectStructureForNewFuncExp):
(JSC::JSFunction::create):
* runtime/JSFunction.h:
* runtime/JSFunctionInlines.h:
(JSC::JSFunction::createWithInvalidatedReallocationWatchpoint):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arrowFunctionStructure const):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/runtime/FunctionConstructor.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
trunk/Source/_javascript_Core/runtime/JSFunction.h
trunk/Source/_javascript_Core/runtime/JSFunctionInlines.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalObject.h
Added Paths
trunk/JSTests/stress/arrow-function-needs-its-own-structure.js
Diff
Modified: trunk/JSTests/ChangeLog (225890 => 225891)
--- trunk/JSTests/ChangeLog 2017-12-14 03:05:39 UTC (rev 225890)
+++ trunk/JSTests/ChangeLog 2017-12-14 04:10:02 UTC (rev 225891)
@@ -1,5 +1,19 @@
2017-12-13 Saam Barati
+Arrow functions need their own structure because they have different properties than sloppy functions
+https://bugs.webkit.org/show_bug.cgi?id=180779
+
+
+Reviewed by Mark Lam.
+
+* stress/arrow-function-needs-its-own-structure.js: Added.
+(assert):
+(readPrototype):
+(noInline.let.f1):
+(noInline):
+
+2017-12-13 Saam Barati
+
Fix how JSFunction handles "caller" and "arguments" for functions that don't have those properties
https://bugs.webkit.org/show_bug.cgi?id=163579
Added: trunk/JSTests/stress/arrow-function-needs-its-own-structure.js (0 => 225891)
--- trunk/JSTests/stress/arrow-function-needs-its-own-structure.js (rev 0)
+++ trunk/JSTests/stress/arrow-function-needs-its-own-structure.js 2017-12-14 04:10:02 UTC (rev 225891)
@@ -0,0 +1,23 @@
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+function readPrototype(f) {
+return f.prototype;
+}
+noInline(readPrototype);
+
+{
+let f1 = function () { };
+let f2 = () => undefined;
+for (let i = 0; i < 100; ++i) {
+assert(!f2.hasOwnProperty("prototype"));
+assert(f1.hasOwnProperty("prototype"));
+}
+
+for (let i = 0; i < 100; ++i)
+assert(readPrototype(f2) === undefined);
+assert(readPrototype(f1) !== undefined);
+assert(readPrototype(f1) === f1.prototype);
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (225890 => 225891)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-14 03:05:39 UTC (rev 225890)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-14 04:10:02 UTC (rev 225891)
@@ -1,3 +1,36 @@
+2017-12-13 Saam Barati
+
+Arrow functions need their own structure because they have different properties than sloppy functions
+https://bugs.webkit.org/show_bug.cgi?id=180779
+
+
+Reviewed by Mark Lam.
+
+We were using the same structure for sloppy functions and
+arrow functions. This broke our IC caching machinery because
+these two types of functions actually have different properties.
+This patch gives them different structures.
+
+* dfg/DFGAbstractInterpreterInlines.h:
+(JSC::DFG::AbstractInterpreter::executeEffects):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileNewFunction):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
+* runtime/FunctionConstructor.cpp:
+(JSC::constructFunctionSkippingEvalEnabledCheck):
+* runtime/JSFunction.cpp:
+(JSC::JSFunction::selectStructureForN
[webkit-changes] [225890] trunk/Source/WebKit
Title: [225890] trunk/Source/WebKit Revision 225890 Author cdu...@apple.com Date 2017-12-13 19:05:39 -0800 (Wed, 13 Dec 2017) Log Message Fix copy/paste error in ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration() https://bugs.webkit.org/show_bug.cgi?id=180782 Reviewed by Youenn Fablet. * UIProcess/API/APIProcessPoolConfiguration.cpp: (API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (225889 => 225890) --- trunk/Source/WebKit/ChangeLog 2017-12-14 02:37:48 UTC (rev 225889) +++ trunk/Source/WebKit/ChangeLog 2017-12-14 03:05:39 UTC (rev 225890) @@ -1,3 +1,13 @@ +2017-12-13 Chris Dumez + +Fix copy/paste error in ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration() +https://bugs.webkit.org/show_bug.cgi?id=180782 + +Reviewed by Youenn Fablet. + +* UIProcess/API/APIProcessPoolConfiguration.cpp: +(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration): + 2017-12-13 Daniel Bates Add more auto fill button types Modified: trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp (225889 => 225890) --- trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp 2017-12-14 02:37:48 UTC (rev 225889) +++ trunk/Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.cpp 2017-12-14 03:05:39 UTC (rev 225890) @@ -67,7 +67,7 @@ configuration->m_diskCacheDirectory = legacyConfiguration.networkCacheDirectory; configuration->m_mediaCacheDirectory = legacyConfiguration.mediaCacheDirectory; configuration->m_indexedDBDatabaseDirectory = WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory(); -configuration->m_serviceWorkerRegistrationDirectory = WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory(); +configuration->m_serviceWorkerRegistrationDirectory = WebKit::WebProcessPool::legacyPlatformDefaultServiceWorkerRegistrationDirectory(); configuration->m_localStorageDirectory = legacyConfiguration.localStorageDirectory; configuration->m_mediaKeysStorageDirectory = legacyConfiguration.mediaKeysStorageDirectory; configuration->m_resourceLoadStatisticsDirectory = legacyConfiguration.resourceLoadStatisticsDirectory; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225889] trunk/LayoutTests
Title: [225889] trunk/LayoutTests
Revision 225889
Author dba...@webkit.org
Date 2017-12-13 18:37:48 -0800 (Wed, 13 Dec 2017)
Log Message
Add more auto fill button types
https://bugs.webkit.org/show_bug.cgi?id=180651
And
Update expected results. I included results from the GTK bot as a baseline. The results are incorrect as they
render the password field text using bullets instead of plain text. This likely indicates that the bots did not
regenerate the user-agent style sheet.
* platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Added.
* platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
* platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
* platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
* platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
* platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt
trunk/LayoutTests/platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt
trunk/LayoutTests/platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt
Added Paths
trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (225888 => 225889)
--- trunk/LayoutTests/ChangeLog 2017-12-14 01:45:03 UTC (rev 225888)
+++ trunk/LayoutTests/ChangeLog 2017-12-14 02:37:48 UTC (rev 225889)
@@ -1,3 +1,22 @@
+2017-12-13 Daniel Bates
+
+Add more auto fill button types
+https://bugs.webkit.org/show_bug.cgi?id=180651
+
+And
+
+
+Update expected results. I included results from the GTK bot as a baseline. The results are incorrect as they
+render the password field text using bullets instead of plain text. This likely indicates that the bots did not
+regenerate the user-agent style sheet.
+
+* platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Added.
+* platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
+* platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
+* platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
+* platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
+* platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
+
2017-12-13 Matt Lewis
Marked security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html as flaky.
Added: trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt (0 => 225889)
--- trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt 2017-12-14 02:37:48 UTC (rev 225889)
@@ -0,0 +1,46 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x132
+ RenderBlock {HTML} at (0,0) size 800x132
+RenderBody {BODY} at (8,16) size 784x108
+ RenderBlock {P} at (0,0) size 784x36
+RenderText {#text} at (0,0) size 771x35
+ text run at (0,0) width 771: "This tests that the Strong Confirmation Password AutoFill button renders in an auto-filled input. It can only be tested in the"
+ text run at (0,18) width 53: "test tool."
+ RenderBlock {DIV} at (0,52) size 784x56
+RenderTextControl {INPUT} at (2,2) size 191x24 [bgcolor=#FF] [border: (2px inset #00)]
+ RenderFlexibleBox {DIV} at (3,3) size 185x18
+RenderBlock {DIV} at (0,0) size 185x18
+RenderBlock {DIV} at (185,9) size 0x0
+RenderText {#text} at (195,5) size 4x17
+ text run at (195,5) width 4: " "
+RenderTextControl {INPUT} at (201,2) size 191x24 [bgcolor=#FF] [border: (2px inset #00)]
+ RenderFlexibleBox {DIV} at (3,3) size 185x18
+RenderBlock {DIV} at (0,0) size 185x18
+
[webkit-changes] [225888] trunk
Title: [225888] trunk
Revision 225888
Author clo...@igalia.com
Date 2017-12-13 17:45:03 -0800 (Wed, 13 Dec 2017)
Log Message
[WPE] WebCrypto should be a public option.
https://bugs.webkit.org/show_bug.cgi?id=180780
Reviewed by Konstantin Tokarev.
Make ENABLE_WEB_CRYPTO public and lower the dependency requirements
when this option is not enabled. This is also how the GTK+ port
configures the visibility of this option and its dependencies.
* Source/cmake/OptionsWPE.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsWPE.cmake
Diff
Modified: trunk/ChangeLog (225887 => 225888)
--- trunk/ChangeLog 2017-12-14 01:12:03 UTC (rev 225887)
+++ trunk/ChangeLog 2017-12-14 01:45:03 UTC (rev 225888)
@@ -1,3 +1,16 @@
+2017-12-13 Carlos Alberto Lopez Perez
+
+[WPE] WebCrypto should be a public option.
+https://bugs.webkit.org/show_bug.cgi?id=180780
+
+Reviewed by Konstantin Tokarev.
+
+Make ENABLE_WEB_CRYPTO public and lower the dependency requirements
+when this option is not enabled. This is also how the GTK+ port
+configures the visibility of this option and its dependencies.
+
+* Source/cmake/OptionsWPE.cmake:
+
2017-12-13 Carlos Garcia Campos
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release.
Modified: trunk/Source/cmake/OptionsWPE.cmake (225887 => 225888)
--- trunk/Source/cmake/OptionsWPE.cmake 2017-12-14 01:12:03 UTC (rev 225887)
+++ trunk/Source/cmake/OptionsWPE.cmake 2017-12-14 01:45:03 UTC (rev 225888)
@@ -17,6 +17,7 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ENCRYPTED_MEDIA PUBLIC ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEBDRIVER PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_CRYPTO PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_XSLT PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(USE_SYSTEM_MALLOC PUBLIC OFF)
@@ -60,9 +61,8 @@
find_package(ICU REQUIRED)
find_package(JPEG REQUIRED)
find_package(LibEpoxy 1.4.0 REQUIRED)
-find_package(LibGcrypt 1.7.0 REQUIRED)
+find_package(LibGcrypt 1.6.0 REQUIRED)
find_package(LibSoup 2.42.0 REQUIRED)
-find_package(Libtasn1 REQUIRED)
find_package(LibXml2 2.8.0 REQUIRED)
find_package(PNG REQUIRED)
find_package(Sqlite REQUIRED)
@@ -75,6 +75,16 @@
find_package(CairoGL 1.10.2 REQUIRED COMPONENTS cairo-egl)
endif ()
+if (ENABLE_SUBTLE_CRYPTO)
+find_package(Libtasn1 REQUIRED)
+if (NOT LIBTASN1_FOUND)
+message(FATAL_ERROR "libtasn1 is required to enable Web Crypto API support.")
+endif ()
+if (LIBGCRYPT_VERSION VERSION_LESS 1.7.0)
+message(FATAL_ERROR "libgcrypt 1.7.0 is required to enable Web Crypto API support.")
+endif ()
+endif ()
+
if (ENABLE_XSLT)
find_package(LibXslt 1.1.7 REQUIRED)
endif ()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225887] trunk/Source/JavaScriptCore
Title: [225887] trunk/Source/_javascript_Core
Revision 225887
Author fpi...@apple.com
Date 2017-12-13 17:12:03 -0800 (Wed, 13 Dec 2017)
Log Message
InferredValue should use IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=180738
Reviewed by Keith Miller.
This moves InferredValue into an IsoSubspace and then takes advantage of this to get rid of
its UnconditionalFinalizer.
* _javascript_Core.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
(JSC::Heap::finalizeUnconditionalFinalizers):
* runtime/InferredValue.cpp:
(JSC::InferredValue::visitChildren):
(JSC::InferredValue::ValueCleanup::ValueCleanup): Deleted.
(JSC::InferredValue::ValueCleanup::~ValueCleanup): Deleted.
(JSC::InferredValue::ValueCleanup::finalizeUnconditionally): Deleted.
* runtime/InferredValue.h:
(JSC::InferredValue::subspaceFor):
* runtime/InferredValueInlines.h: Added.
(JSC::InferredValue::finalizeUnconditionally):
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/runtime/InferredValue.cpp
trunk/Source/_javascript_Core/runtime/InferredValue.h
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
Added Paths
trunk/Source/_javascript_Core/runtime/InferredValueInlines.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225886 => 225887)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-14 01:07:23 UTC (rev 225886)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-14 01:12:03 UTC (rev 225887)
@@ -1,3 +1,29 @@
+2017-12-12 Filip Pizlo
+
+InferredValue should use IsoSubspace
+https://bugs.webkit.org/show_bug.cgi?id=180738
+
+Reviewed by Keith Miller.
+
+This moves InferredValue into an IsoSubspace and then takes advantage of this to get rid of
+its UnconditionalFinalizer.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* heap/Heap.cpp:
+(JSC::Heap::finalizeUnconditionalFinalizers):
+* runtime/InferredValue.cpp:
+(JSC::InferredValue::visitChildren):
+(JSC::InferredValue::ValueCleanup::ValueCleanup): Deleted.
+(JSC::InferredValue::ValueCleanup::~ValueCleanup): Deleted.
+(JSC::InferredValue::ValueCleanup::finalizeUnconditionally): Deleted.
+* runtime/InferredValue.h:
+(JSC::InferredValue::subspaceFor):
+* runtime/InferredValueInlines.h: Added.
+(JSC::InferredValue::finalizeUnconditionally):
+* runtime/VM.cpp:
+(JSC::VM::VM):
+* runtime/VM.h:
+
2017-12-13 Devin Rousso
Web Inspector: add instrumentation for ImageBitmapRenderingContext
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (225886 => 225887)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2017-12-14 01:07:23 UTC (rev 225886)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2017-12-14 01:12:03 UTC (rev 225887)
@@ -310,6 +310,7 @@
0F485328187DFDEC0083B687 /* FTLAvailableRecovery.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F485324187DFDEC0083B687 /* FTLAvailableRecovery.h */; settings = {ATTRIBUTES = (Private, ); }; };
0F48532A187DFDEC0083B687 /* FTLRecoveryOpcode.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F485326187DFDEC0083B687 /* FTLRecoveryOpcode.h */; settings = {ATTRIBUTES = (Private, ); }; };
0F4A38FA1C8E13DF00190318 /* SuperSampler.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F4A38F81C8E13DF00190318 /* SuperSampler.h */; settings = {ATTRIBUTES = (Private, ); }; };
+ 0F4AE0431FE0D25700E20839 /* InferredValueInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F4AE0421FE0D25400E20839 /* InferredValueInlines.h */; };
0F4B94DC17B9F07500DD03A4 /* TypedArrayInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F4B94DB17B9F07500DD03A4 /* TypedArrayInlines.h */; settings = {ATTRIBUTES = (Private, ); }; };
0F4C91661C29F4F2004341A6 /* B3OriginDump.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F4C91651C29F4F2004341A6 /* B3OriginDump.h */; };
0F4D8C741FC7A97A001D32AC /* VisitCounter.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F4D8C721FC7A973001D32AC /* VisitCounter.h */; };
@@ -2282,6 +2283,7 @@
0F493AF816D0CAD10084508B /* SourceProvider.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SourceProvider.cpp; sourceTree = ""; };
0F4A38F71C8E13DF00190318 /* SuperSampler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SuperSampler.cpp; sourceTree = ""; };
0F4A38F81C8E13DF00190318 /* SuperSampler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SuperSampler.h; sourceTree = ""; };
+ 0F4AE0421FE0D25400E20839 /* InferredValueInlines.h */ = {isa = PBXFileRe
[webkit-changes] [225886] trunk/LayoutTests
Title: [225886] trunk/LayoutTests Revision 225886 Author jlew...@apple.com Date 2017-12-13 17:07:23 -0800 (Wed, 13 Dec 2017) Log Message Marked security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html as flaky. https://bugs.webkit.org/show_bug.cgi?id=173742 Unreviewed test gardening * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (225885 => 225886) --- trunk/LayoutTests/ChangeLog 2017-12-14 01:02:14 UTC (rev 225885) +++ trunk/LayoutTests/ChangeLog 2017-12-14 01:07:23 UTC (rev 225886) @@ -1,3 +1,12 @@ +2017-12-13 Matt Lewis + +Marked security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html as flaky. +https://bugs.webkit.org/show_bug.cgi?id=173742 + +Unreviewed test gardening + +* platform/mac-wk2/TestExpectations: + 2017-12-13 Devin Rousso Web Inspector: add instrumentation for ImageBitmapRenderingContext Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (225885 => 225886) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-12-14 01:02:14 UTC (rev 225885) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-12-14 01:07:23 UTC (rev 225886) @@ -845,3 +845,5 @@ webkit.org/b/179351 imported/w3c/web-platform-tests/service-workers/service-worker/worker-interception.https.html [ Pass Failure ] +webkit.org/b/173742 security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225885] trunk/Source/WebCore
Title: [225885] trunk/Source/WebCore
Revision 225885
Author dba...@webkit.org
Date 2017-12-13 17:02:14 -0800 (Wed, 13 Dec 2017)
Log Message
Fix the Windows build after
(https://bugs.webkit.org/show_bug.cgi?id=180651)
* html/TextFieldInputType.cpp:
(WebCore::autoFillButtonTypeToAccessibilityLabel):
(WebCore::autoFillButtonTypeToAutoFillButtonText):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/TextFieldInputType.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (225884 => 225885)
--- trunk/Source/WebCore/ChangeLog 2017-12-14 00:57:35 UTC (rev 225884)
+++ trunk/Source/WebCore/ChangeLog 2017-12-14 01:02:14 UTC (rev 225885)
@@ -1,3 +1,13 @@
+2017-12-13 Daniel Bates
+
+Fix the Windows build after
+(https://bugs.webkit.org/show_bug.cgi?id=180651)
+
+* html/TextFieldInputType.cpp:
+(WebCore::autoFillButtonTypeToAccessibilityLabel):
+(WebCore::autoFillButtonTypeToAutoFillButtonText):
+(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
+
2017-12-13 Devin Rousso
Web Inspector: add instrumentation for ImageBitmapRenderingContext
Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (225884 => 225885)
--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2017-12-14 00:57:35 UTC (rev 225884)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2017-12-14 01:02:14 UTC (rev 225885)
@@ -414,6 +414,8 @@
ASSERT_NOT_REACHED();
return { };
}
+ASSERT_NOT_REACHED();
+return { };
}
static String autoFillButtonTypeToAutoFillButtonText(AutoFillButtonType autoFillButtonType)
@@ -429,6 +431,8 @@
ASSERT_NOT_REACHED();
return { };
}
+ASSERT_NOT_REACHED();
+return { };
}
static AtomicString autoFillButtonTypeToAutoFillButtonPseudoClassName(AutoFillButtonType autoFillButtonType)
@@ -446,6 +450,8 @@
ASSERT_NOT_REACHED();
return emptyAtom();
}
+ASSERT_NOT_REACHED();
+return { };
}
static bool isAutoFillButtonTypeChanged(const AtomicString& attribute, AutoFillButtonType autoFillButtonType)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225883] tags/Safari-605.1.17.1/Source
Title: [225883] tags/Safari-605.1.17.1/Source
Revision 225883
Author jmarc...@apple.com
Date 2017-12-13 16:50:49 -0800 (Wed, 13 Dec 2017)
Log Message
Cherry-pick r225863. rdar://problem/35996158
Modified Paths
tags/Safari-605.1.17.1/Source/WebCore/ChangeLog
tags/Safari-605.1.17.1/Source/WebCore/platform/mac/EventLoopMac.mm
tags/Safari-605.1.17.1/Source/WebKit/ChangeLog
tags/Safari-605.1.17.1/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm
tags/Safari-605.1.17.1/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm
tags/Safari-605.1.17.1/Source/WebKit/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist
tags/Safari-605.1.17.1/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: tags/Safari-605.1.17.1/Source/WebCore/ChangeLog (225882 => 225883)
--- tags/Safari-605.1.17.1/Source/WebCore/ChangeLog 2017-12-14 00:49:44 UTC (rev 225882)
+++ tags/Safari-605.1.17.1/Source/WebCore/ChangeLog 2017-12-14 00:50:49 UTC (rev 225883)
@@ -1,3 +1,20 @@
+2017-12-13 Jason Marcell
+
+Cherry-pick r225863. rdar://problem/35996158
+
+2017-12-13 Per Arne Vollan
+
+REGRESSION(225597): Can't select a text box or web view on a page when VO is on.
+https://bugs.webkit.org/show_bug.cgi?id=180756
+
+
+Reviewed by Brent Fulgham.
+
+No new tests.
+
+* platform/mac/EventLoopMac.mm:
+(WebCore::EventLoop::cycle):
+
2017-12-11 Manuel Rego Casasnovas
REGRESSION(r221931): Row stretch doesn't work for grid container with min-height
Modified: tags/Safari-605.1.17.1/Source/WebCore/platform/mac/EventLoopMac.mm (225882 => 225883)
--- tags/Safari-605.1.17.1/Source/WebCore/platform/mac/EventLoopMac.mm 2017-12-14 00:49:44 UTC (rev 225882)
+++ tags/Safari-605.1.17.1/Source/WebCore/platform/mac/EventLoopMac.mm 2017-12-14 00:50:49 UTC (rev 225883)
@@ -30,10 +30,12 @@
void EventLoop::cycle()
{
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
if (![NSApp isRunning]) {
[[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:0.05]];
return;
}
+#endif
[NSApp setWindowsNeedUpdate:YES];
if (NSEvent *event = [NSApp nextEventMatchingMask:NSEventMaskAny untilDate:[NSDate dateWithTimeIntervalSinceNow:0.05] inMode:NSDefaultRunLoopMode dequeue:YES])
[NSApp sendEvent:event];
Modified: tags/Safari-605.1.17.1/Source/WebKit/ChangeLog (225882 => 225883)
--- tags/Safari-605.1.17.1/Source/WebKit/ChangeLog 2017-12-14 00:49:44 UTC (rev 225882)
+++ tags/Safari-605.1.17.1/Source/WebKit/ChangeLog 2017-12-14 00:50:49 UTC (rev 225883)
@@ -1,3 +1,23 @@
+2017-12-13 Jason Marcell
+
+Cherry-pick r225863. rdar://problem/35996158
+
+2017-12-13 Per Arne Vollan
+
+REGRESSION(225597): Can't select a text box or web view on a page when VO is on.
+https://bugs.webkit.org/show_bug.cgi?id=180756
+
+
+Reviewed by Brent Fulgham.
+
+* Platform/IPC/mac/ConnectionMac.mm:
+(IPC::AccessibilityProcessSuspendedNotification):
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::shouldLeakBoost):
+* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeProcess):
+
2017-12-10 Stephan Szabo
APIClient.h uses things from without including it explicitly
Modified: tags/Safari-605.1.17.1/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm (225882 => 225883)
--- tags/Safari-605.1.17.1/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm 2017-12-14 00:49:44 UTC (rev 225882)
+++ tags/Safari-605.1.17.1/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm 2017-12-14 00:50:49 UTC (rev 225883)
@@ -586,9 +586,11 @@
static void AccessibilityProcessSuspendedNotification(bool suspended)
{
#if PLATFORM(MAC)
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
// Calling _AXUIElementNotifyProcessSuspendStatus will crash if the NSApplication event loop is not running.
if (![NSApp isRunning])
return;
+#endif
_AXUIElementNotifyProcessSuspendStatus(suspended ? AXSuspendStatusSuspended : AXSuspendStatusRunning);
#elif PLATFORM(IOS)
UIAccessibilityPostNotification(kAXPidStatusChangedNotification, @{ @"pid" : @(getpid()), @"suspended" : @(suspended) });
Modified: tags/Safari-605.1.17.1/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm (225882 => 225883)
--- tags/Safari-605.1.17.1/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2017-12-14 00:49:44 UTC (rev 225882)
+++ tags/Safari-605.1.17.1/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2017-12-14 00:50:49 UTC (rev 225883)
@@ -76,9 +76,13 @@
UNUSED_PARAM(launchOptions);
return true;
#else
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+// Boost the WebContent process if the NSApplication run loop is not used.
+if (launchOptions.processTy
[webkit-changes] [225882] tags/Safari-605.1.17.1/Source
Title: [225882] tags/Safari-605.1.17.1/Source Revision 225882 Author jmarc...@apple.com Date 2017-12-13 16:49:44 -0800 (Wed, 13 Dec 2017) Log Message Versioning. Modified Paths tags/Safari-605.1.17.1/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-605.1.17.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig tags/Safari-605.1.17.1/Source/WebCore/Configurations/Version.xcconfig tags/Safari-605.1.17.1/Source/WebCore/PAL/Configurations/Version.xcconfig tags/Safari-605.1.17.1/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-605.1.17.1/Source/WebKit/Configurations/Version.xcconfig tags/Safari-605.1.17.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: tags/Safari-605.1.17.1/Source/_javascript_Core/Configurations/Version.xcconfig (225881 => 225882) --- tags/Safari-605.1.17.1/Source/_javascript_Core/Configurations/Version.xcconfig 2017-12-14 00:47:25 UTC (rev 225881) +++ tags/Safari-605.1.17.1/Source/_javascript_Core/Configurations/Version.xcconfig 2017-12-14 00:49:44 UTC (rev 225882) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 17; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.17.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (225881 => 225882) --- tags/Safari-605.1.17.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-12-14 00:47:25 UTC (rev 225881) +++ tags/Safari-605.1.17.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-12-14 00:49:44 UTC (rev 225882) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 17; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.17.1/Source/WebCore/Configurations/Version.xcconfig (225881 => 225882) --- tags/Safari-605.1.17.1/Source/WebCore/Configurations/Version.xcconfig 2017-12-14 00:47:25 UTC (rev 225881) +++ tags/Safari-605.1.17.1/Source/WebCore/Configurations/Version.xcconfig 2017-12-14 00:49:44 UTC (rev 225882) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 17; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.17.1/Source/WebCore/PAL/Configurations/Version.xcconfig (225881 => 225882) --- tags/Safari-605.1.17.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-12-14 00:47:25 UTC (rev 225881) +++ tags/Safari-605.1.17.1/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-12-14 00:49:44 UTC (rev 225882) @@ -24,9 +24,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 17; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: tags/Safari-605.1.17.1/Source/WebInspectorUI/Configurations/Version.xcconfig (225881 => 225882) --- tags/Safari-605.1.17.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-12-14 00:47:25 UTC (rev 225881) +++ tags/Safari-605.1.17.1/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-12-14 00:49:44 UTC (rev 225882) @@ -1,9 +1,9 @@ MAJOR_VERSION = 605; MINOR_VERSION = 1; TINY_VERSION = 17; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: tags/Safari-605.1.17.1/Source/WebKit/Configurations/Version.xcconfig (225881 => 225882) --- tags/Safari-605.1.17.1/Source/WebKit/Configurations/Version.xcconfig 2017-12-14 00:47:25 UTC (rev 225881) +++ tags/Safari-605.1.17.1/Source/WebKit/Configurations/Version.xcconfig 2017-12-14 00:49:44 UTC (rev 225882) @@ -24,9 +
[webkit-changes] [225881] tags/Safari-605.1.17.1/
Title: [225881] tags/Safari-605.1.17.1/ Revision 225881 Author jmarc...@apple.com Date 2017-12-13 16:47:25 -0800 (Wed, 13 Dec 2017) Log Message New tag. Added Paths tags/Safari-605.1.17.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225880] trunk/Source/JavaScriptCore
Title: [225880] trunk/Source/_javascript_Core
Revision 225880
Author sbar...@apple.com
Date 2017-12-13 16:31:58 -0800 (Wed, 13 Dec 2017)
Log Message
Take a value driven approach to how we emit structure checks in TypeCheckHoistingPhase to obviate the need for static_assert guards
https://bugs.webkit.org/show_bug.cgi?id=180771
Reviewed by JF Bastien.
* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225879 => 225880)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-14 00:29:31 UTC (rev 225879)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-14 00:31:58 UTC (rev 225880)
@@ -1,5 +1,15 @@
2017-12-13 Saam Barati
+Take a value driven approach to how we emit structure checks in TypeCheckHoistingPhase to obviate the need for static_assert guards
+https://bugs.webkit.org/show_bug.cgi?id=180771
+
+Reviewed by JF Bastien.
+
+* dfg/DFGTypeCheckHoistingPhase.cpp:
+(JSC::DFG::TypeCheckHoistingPhase::run):
+
+2017-12-13 Saam Barati
+
REGRESSION(r225844): Around 850 new JSC failures on 32-bit
https://bugs.webkit.org/show_bug.cgi?id=180764
Modified: trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp (225879 => 225880)
--- trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp 2017-12-14 00:29:31 UTC (rev 225879)
+++ trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp 2017-12-14 00:31:58 UTC (rev 225880)
@@ -145,8 +145,7 @@
OpInfo(variable), Edge(node));
if (iter->value.m_structure) {
auto checkOp = CheckStructure;
-if (is64Bit()) {
-static_assert(is64Bit() || !(SpecCellCheck & SpecEmpty), "");
+if (SpecCellCheck & SpecEmpty) {
VirtualRegister local = node->variableAccessData()->local();
auto* inlineCallFrame = node->origin.semantic.inlineCallFrame;
if ((local - (inlineCallFrame ? inlineCallFrame->stackOffset : 0)) == virtualRegisterForArgument(0)) {
@@ -195,9 +194,8 @@
// to emit a node that explicitly handles the empty value. Most of the time, CheckStructureOrEmpty
// will be folded to CheckStructure because AI proves that the incoming value is
// definitely not empty.
-static_assert(is64Bit() || !(SpecCellCheck & SpecEmpty), "");
insertionSet.insertNode(
-indexForChecks, SpecNone, is64Bit() ? CheckStructureOrEmpty : CheckStructure,
+indexForChecks, SpecNone, (SpecCellCheck & SpecEmpty) ? CheckStructureOrEmpty : CheckStructure,
originForChecks.withSemantic(origin.semantic),
OpInfo(m_graph.addStructureSet(iter->value.m_structure)),
Edge(child1.node(), CellUse));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225879] trunk
Title: [225879] trunk Revision 225879 Author dba...@webkit.org Date 2017-12-13 16:29:31 -0800 (Wed, 13 Dec 2017) Log Message Add more auto fill button types https://bugs.webkit.org/show_bug.cgi?id=180651 And Reviewed by Brent Fulgham. Source/WebCore: Tests: fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html * English.lproj/Localizable.strings: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): Add strings for new auto fill button types. * css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText const): * css/CSSSelector.h: * css/SelectorChecker.cpp: (WebCore::SelectorChecker::checkOne const): * css/SelectorCheckerTestFunctions.h: (WebCore::isAutofilledStrongPassword): * css/SelectorPseudoClassAndCompatibilityElementMap.in: * css/html.css: (input::-webkit-strong-password-auto-fill-button): (input:-webkit-autofill-strong-password): (input:-webkit-autofill, input:-webkit-autofill-strong-password): (input:-webkit-autofill): Deleted. * cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::addPseudoClassType): Add new CSS pseudo class and CSS styles. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset): Hide the auto fill button when the form is reset. This is also called whenever we suspend the page to put it into the page cache. (WebCore::HTMLInputElement::setShowAutoFillButton): Modified to update the editability of the inner text element and invalidate styles for the subtree as the editability may have changed depending on the auto fill button type. (WebCore::autoFillStrongPasswordMaskImage): (WebCore::HTMLInputElement::createInnerTextStyle): (WebCore::HTMLInputElement::createInnerTextStyle const): Deleted. Adjust the look of the inner text field. This function is not const because we may need to resolve style to generate a mask image. * html/HTMLInputElement.h: (WebCore::HTMLInputElement::autoFillButtonType const): Fix style nit; use a C++ style cast while I am in this area. (WebCore::HTMLInputElement::hasAutoFillStrongPasswordButton const): Added. * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::createInnerTextStyle): (WebCore::HTMLTextAreaElement::createInnerTextStyle const): Deleted. Made this non-const because HTMLInputElement::createInnerTextStyle() needs to be non-const. See above. * html/HTMLTextAreaElement.h: * html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::isInnerTextElementEditable const): (WebCore::HTMLTextFormControlElement::updateInnerTextElementEditability): Extract out the query to determine if the inner text element is editable into a virtual function isInnerTextElementEditable() and have updateInnerTextElementEditability() make use of it. By default a field is considered editable if it is not disabled or read-only. We override updateInnerTextElementEditability() in HTMLInputElement to also consider the auto fill button type. * html/HTMLTextFormControlElement.h: * html/TextFieldInputType.cpp: (WebCore::autoFillButtonTypeToAccessibilityLabel): (WebCore::autoFillButtonTypeToAutoFillButtonText): (WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName): (WebCore::isAutoFillButtonTypeChanged): (WebCore::TextFieldInputType::createAutoFillButton): (WebCore::TextFieldInputType::updateAutoFillButton): Support having text for the auto fill button. * platform/LocalizedStrings.cpp: (WebCore::AXAutoFillStrongPasswordLabel): (WebCore::AXAutoFillStrongConfirmationPasswordLabel): (WebCore::autoFillStrongPasswordLabel): * platform/LocalizedStrings.h: Add localized strings. * rendering/RenderTextControlSingleLine.h: Disallow scrolling depending on the auto fill button type. * testing/Internals.cpp: (WebCore::toAutoFillButtonType): * testing/Internals.h: * testing/Internals.idl: Add support for testing. Source/WebKit: Adds enumerators for the new auto fill button types. * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm: (toAutoFillButtonType): * WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h: * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: (toAutoFillButtonType): * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: LayoutTests: * fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button-expected.html: Added. * fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html: Added. * fa
[webkit-changes] [225878] trunk/Source/WebCore
Title: [225878] trunk/Source/WebCore Revision 225878 Author rn...@webkit.org Date 2017-12-13 16:05:42 -0800 (Wed, 13 Dec 2017) Log Message Crash inside ImageLoader::updateFromElement() https://bugs.webkit.org/show_bug.cgi?id=180769 Reviewed by Antti Koivisto. Fixed the crash by moving all call sites of ImageLoader::updateFromElement() to be post insertion callbacks where it's safe to execute arbitrary scripts. No new test since existing tests cover this with a newly added release assert in ImageLoader. * html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::insertedIntoAncestor): (WebCore::HTMLImageElement::didFinishInsertingNode): Extracted from insertedIntoAncestor to call selectImageSource or updateFromElement. * html/HTMLImageElement.h: Made many member functions final. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::didAttachRenderers): Delay the call to ImageLoader::updateFromElement() in ImageInputType using a post style resolution callback. * html/HTMLMetaElement.h: * html/HTMLPictureElement.cpp: (WebCore::HTMLPictureElement::sourcesChanged): Store the list of child image elements into a vector before calling selectImageSource since each call may execute arbitrary scripts. * html/HTMLSourceElement.cpp: (WebCore::HTMLSourceElement::insertedIntoAncestor): Delay the call to ImageLoader::updateFromElement() using a post style resolution callback. (WebCore::HTMLSourceElement::didFinishInsertingNode): Extracted from insertedIntoAncestor. * html/HTMLSourceElement.h: * html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::didAttachRenderers): (WebCore::HTMLVideoElement::updateAfterStyleResolution): Extracted from didAttachRenderers. * html/HTMLVideoElement.h: * html/ImageInputType.cpp: (WebCore::ImageInputType::needsPostStyleResolutionCallback): Added. Returns true so that HTMLInputElement's didAttachRenderers would register a post style resolution callback. (WebCore::ImageInputType::updateAfterStyleResolution): Extracted from attach. (WebCore::ImageInputType::attach): Deleted. * html/ImageInputType.h: * html/InputType.cpp: (WebCore::InputType::needsPostStyleResolutionCallback): Added. All but ImageInputType returns false. (WebCore::InputType::updateAfterStyleResolution): Added. (WebCore::InputType::attach): Deleted. * html/InputType.h: * loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): Added a release assertion. There is no direct security implication so there is no need to use RELEASE_ASSERT_WITH_SECURITY_IMPLICATION here. * svg/SVGImageElement.cpp: (WebCore::SVGImageElement::insertedIntoAncestor): (WebCore::SVGImageElement::didFinishInsertingNode): * svg/SVGImageElement.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLImageElement.cpp trunk/Source/WebCore/html/HTMLImageElement.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLMetaElement.h trunk/Source/WebCore/html/HTMLPictureElement.cpp trunk/Source/WebCore/html/HTMLSourceElement.cpp trunk/Source/WebCore/html/HTMLSourceElement.h trunk/Source/WebCore/html/HTMLVideoElement.cpp trunk/Source/WebCore/html/HTMLVideoElement.h trunk/Source/WebCore/html/ImageInputType.cpp trunk/Source/WebCore/html/ImageInputType.h trunk/Source/WebCore/html/InputType.cpp trunk/Source/WebCore/html/InputType.h trunk/Source/WebCore/loader/ImageLoader.cpp trunk/Source/WebCore/svg/SVGImageElement.cpp trunk/Source/WebCore/svg/SVGImageElement.h Diff Modified: trunk/Source/WebCore/ChangeLog (225877 => 225878) --- trunk/Source/WebCore/ChangeLog 2017-12-13 23:58:37 UTC (rev 225877) +++ trunk/Source/WebCore/ChangeLog 2017-12-14 00:05:42 UTC (rev 225878) @@ -1,3 +1,56 @@ +2017-12-13 Ryosuke Niwa + +Crash inside ImageLoader::updateFromElement() +https://bugs.webkit.org/show_bug.cgi?id=180769 + + +Reviewed by Antti Koivisto. + +Fixed the crash by moving all call sites of ImageLoader::updateFromElement() to be post insertion callbacks +where it's safe to execute arbitrary scripts. + +No new test since existing tests cover this with a newly added release assert in ImageLoader. + +* html/HTMLImageElement.cpp: +(WebCore::HTMLImageElement::insertedIntoAncestor): +(WebCore::HTMLImageElement::didFinishInsertingNode): Extracted from insertedIntoAncestor to call +selectImageSource or updateFromElement. +* html/HTMLImageElement.h: Made many member functions final. +* html/HTMLInputElement.cpp: +(WebCore::HTMLInputElement::didAttachRenderers): Delay the call to ImageLoader::updateFromElement() in +ImageInputType using a post style resolution callback. +* html/HTMLMetaElement.h: +* html/HTMLPictureElement.cpp: +(WebCore::HTMLPictureElement::sourcesChanged): Store the list of child image elements into a vector before +calling selectImageSource since each call may execute arbitrary scripts. +* html/HTMLSourceElement.cpp: +(WebCor
[webkit-changes] [225877] trunk
Title: [225877] trunk
Revision 225877
Author jlew...@apple.com
Date 2017-12-13 15:58:37 -0800 (Wed, 13 Dec 2017)
Log Message
Unreviewed, rolling out r225864.
This caused the Layout test step to crash out on Debug testers
Reverted changeset:
"REGRESSION (r225789): API tests
WKProcessPool.InitialWarmedProcessUsed and
WebKit.WebsiteDataStoreCustomPaths are failing."
https://bugs.webkit.org/show_bug.cgi?id=180722
https://trac.webkit.org/changeset/225864
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/StorageProcess/StorageProcess.cpp
trunk/Source/WebKit/StorageProcess/StorageProcess.h
trunk/Source/WebKit/StorageProcess/StorageToWebProcessConnection.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h
trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp
trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.h
trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.messages.in
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (225876 => 225877)
--- trunk/Source/WebKit/ChangeLog 2017-12-13 23:10:22 UTC (rev 225876)
+++ trunk/Source/WebKit/ChangeLog 2017-12-13 23:58:37 UTC (rev 225877)
@@ -1,3 +1,17 @@
+2017-12-13 Matt Lewis
+
+Unreviewed, rolling out r225864.
+
+This caused the Layout test step to crash out on Debug testers
+
+Reverted changeset:
+
+"REGRESSION (r225789): API tests
+WKProcessPool.InitialWarmedProcessUsed and
+WebKit.WebsiteDataStoreCustomPaths are failing."
+https://bugs.webkit.org/show_bug.cgi?id=180722
+https://trac.webkit.org/changeset/225864
+
2017-12-13 Brady Eidson
REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing.
Modified: trunk/Source/WebKit/StorageProcess/StorageProcess.cpp (225876 => 225877)
--- trunk/Source/WebKit/StorageProcess/StorageProcess.cpp 2017-12-13 23:10:22 UTC (rev 225876)
+++ trunk/Source/WebKit/StorageProcess/StorageProcess.cpp 2017-12-13 23:58:37 UTC (rev 225877)
@@ -111,7 +111,7 @@
swServer->markAllWorkersAsTerminated();
if (shouldRelaunch)
-createServerToContextConnection(std::nullopt);
+createServerToContextConnection();
}
// The rule is that we need a context process (and a connection to it) as long as we have SWServerConnections to regular WebProcesses.
@@ -427,16 +427,13 @@
return m_serverToContextConnection.get();
}
-void StorageProcess::createServerToContextConnection(std::optional sessionID)
+void StorageProcess::createServerToContextConnection()
{
if (m_waitingForServerToContextProcessConnection)
return;
m_waitingForServerToContextProcessConnection = true;
-if (sessionID)
-parentProcessConnection()->send(Messages::StorageProcessProxy::EstablishWorkerContextConnectionToStorageProcessForExplicitSession(*sessionID), 0);
-else
-parentProcessConnection()->send(Messages::StorageProcessProxy::EstablishWorkerContextConnectionToStorageProcess(), 0);
+parentProcessConnection()->send(Messages::StorageProcessProxy::EstablishWorkerContextConnectionToStorageProcess(), 0);
}
void StorageProcess::didFailFetch(SWServerConnectionIdentifier serverConnectionIdentifier, uint64_t fetchIdentifier)
Modified: trunk/Source/WebKit/StorageProcess/StorageProcess.h (225876 => 225877)
--- trunk/Source/WebKit/StorageProcess/StorageProcess.h 2017-12-13 23:10:22 UTC (rev 225876)
+++ trunk/Source/WebKit/StorageProcess/StorageProcess.h 2017-12-13 23:58:37 UTC (rev 225877)
@@ -89,7 +89,7 @@
// For now we just have one global connection to service worker context processes.
// This will change in the future.
WebSWServerToContextConnection* globalServerToContextConnection();
-void createServerToContextConnection(std::optional);
+void createServerToContextConnection();
WebCore::SWServer& swServerForSession(PAL::SessionID);
void registerSWServerConnection(WebSWServerConnection&);
Modified: trunk/Source/WebKit/StorageProcess/StorageToWebProcessConnection.cpp (225876 => 225877)
--- trunk/Source/WebKit/StorageProcess/StorageToWebProcessConnection.cpp 2017-12-13 23:10:22 UTC (rev 225876)
+++ trunk/Source/WebKit/StorageProcess/StorageToWebProcessConnection.cpp 2017-12-13 23:58:37 UTC (rev 225877)
@@ -171,7 +171,7 @@
ASSERT_UNUSED(addResult, addResult.isNewEntry);
if (!StorageProcess::singleton().globalServerToContextConnection())
-StorageProcess::singleton().createServerToContextConnection(sessionID);
+StorageProcess::singleton().createServerToContextConnection(
[webkit-changes] [225876] tags/Safari-604.5.2.1/
Title: [225876] tags/Safari-604.5.2.1/ Revision 225876 Author jmarc...@apple.com Date 2017-12-13 15:10:22 -0800 (Wed, 13 Dec 2017) Log Message Tag Safari-604.5.2.1. Added Paths tags/Safari-604.5.2.1/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225875] branches/safari-604.5.2-branch/Source
Title: [225875] branches/safari-604.5.2-branch/Source
Revision 225875
Author jmarc...@apple.com
Date 2017-12-13 15:07:46 -0800 (Wed, 13 Dec 2017)
Log Message
Cherry-pick r225535. rdar://problem/34531264
Modified Paths
branches/safari-604.5.2-branch/Source/WebCore/ChangeLog
branches/safari-604.5.2-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp
branches/safari-604.5.2-branch/Source/WebKitLegacy/win/ChangeLog
branches/safari-604.5.2-branch/Source/WebKitLegacy/win/WebView.cpp
branches/safari-604.5.2-branch/Source/WebKitLegacy/win/WebView.h
Diff
Modified: branches/safari-604.5.2-branch/Source/WebCore/ChangeLog (225874 => 225875)
--- branches/safari-604.5.2-branch/Source/WebCore/ChangeLog 2017-12-13 23:05:52 UTC (rev 225874)
+++ branches/safari-604.5.2-branch/Source/WebCore/ChangeLog 2017-12-13 23:07:46 UTC (rev 225875)
@@ -1,3 +1,24 @@
+2017-12-13 Jason Marcell
+
+Cherry-pick r225535. rdar://problem/34531264
+
+2017-12-05 Per Arne Vollan
+
+[Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
+https://bugs.webkit.org/show_bug.cgi?id=180431
+
+
+Reviewed by Simon Fraser.
+
+No new tests, covered by existing tests.
+
+When a scroll layer is required, we will create an overflow control hosts layer.
+In this case the method RenderLayerCompositor::shouldCompositeOverflowControls()
+should return true, otherwise the scrollbars will not be rendered.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls const):
+
2017-12-05 Jason Marcell
Cherry-pick r225528. rdar://problem/35838154
Modified: branches/safari-604.5.2-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp (225874 => 225875)
--- branches/safari-604.5.2-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp 2017-12-13 23:05:52 UTC (rev 225874)
+++ branches/safari-604.5.2-branch/Source/WebCore/rendering/RenderLayerCompositor.cpp 2017-12-13 23:07:46 UTC (rev 225875)
@@ -3031,6 +3031,9 @@
if (documentUsesTiledBacking())
return true;
+if (m_overflowControlsHostLayer && isMainFrameCompositor())
+return true;
+
#if !USE(COORDINATED_GRAPHICS_THREADED)
if (!frameView.hasOverlayScrollbars())
return false;
Modified: branches/safari-604.5.2-branch/Source/WebKitLegacy/win/ChangeLog (225874 => 225875)
--- branches/safari-604.5.2-branch/Source/WebKitLegacy/win/ChangeLog 2017-12-13 23:05:52 UTC (rev 225874)
+++ branches/safari-604.5.2-branch/Source/WebKitLegacy/win/ChangeLog 2017-12-13 23:07:46 UTC (rev 225875)
@@ -1,3 +1,23 @@
+2017-12-13 Jason Marcell
+
+Cherry-pick r225535. rdar://problem/34531264
+
+2017-12-05 Per Arne Vollan
+
+[Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
+https://bugs.webkit.org/show_bug.cgi?id=180431
+
+
+Reviewed by Simon Fraser.
+
+Fix the signatures of GraphicsLayerClient that should have been overridden, and use
+'override' to make sure this doesn't break in the future.
+
+* WebView.cpp:
+(WebView::notifyAnimationStarted):
+(WebView::paintContents):
+* WebView.h:
+
2017-08-09 Jason Marcell
Cherry-pick r220459. rdar://problem/33820790
Modified: branches/safari-604.5.2-branch/Source/WebKitLegacy/win/WebView.cpp (225874 => 225875)
--- branches/safari-604.5.2-branch/Source/WebKitLegacy/win/WebView.cpp 2017-12-13 23:05:52 UTC (rev 225874)
+++ branches/safari-604.5.2-branch/Source/WebKitLegacy/win/WebView.cpp 2017-12-13 23:07:46 UTC (rev 225875)
@@ -7335,7 +7335,7 @@
return S_OK;
}
-void WebView::notifyAnimationStarted(const GraphicsLayer*, double)
+void WebView::notifyAnimationStarted(const GraphicsLayer*, const String&, double)
{
// We never set any animations on our backing layer.
ASSERT_NOT_REACHED();
@@ -7346,7 +7346,7 @@
flushPendingGraphicsLayerChangesSoon();
}
-void WebView::paintContents(const GraphicsLayer*, GraphicsContext& context, GraphicsLayerPaintingPhase, const FloatRect& inClipPixels)
+void WebView::paintContents(const GraphicsLayer*, GraphicsContext& context, GraphicsLayerPaintingPhase, const FloatRect& inClipPixels, GraphicsLayerPaintBehavior)
{
Frame* frame = core(m_mainFrame);
if (!frame)
Modified: branches/safari-604.5.2-branch/Source/WebKitLegacy/win/WebView.h (225874 => 225875)
--- branches/safari-604.5.2-branch/Source/WebKitLegacy/win/WebView.h 2017-12-13 23:05:52 UTC (rev 225874)
+++ branches/safari-604.5.2-branch/Source/WebKitLegacy/win/WebView.h 2017-12-13 23:07:46 UTC (rev 225875)
@@ -568,9 +568,9 @@
DWORD m_lastDropEffect { 0 };
// GraphicsLayerClient
-virtual void notifyAnimationStarted(const WebCore::GraphicsLayer*, double time);
-virtual void notifyFlushRequired(co
[webkit-changes] [225874] branches/safari-604.5.2-branch/Source
Title: [225874] branches/safari-604.5.2-branch/Source Revision 225874 Author jmarc...@apple.com Date 2017-12-13 15:05:52 -0800 (Wed, 13 Dec 2017) Log Message Versioning. Modified Paths branches/safari-604.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-604.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-604.5.2-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-604.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-604.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-604.5.2-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-604.5.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-604.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (225873 => 225874) --- branches/safari-604.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-12-13 22:55:44 UTC (rev 225873) +++ branches/safari-604.5.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2017-12-13 23:05:52 UTC (rev 225874) @@ -24,9 +24,9 @@ MAJOR_VERSION = 604; MINOR_VERSION = 5; TINY_VERSION = 2; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-604.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (225873 => 225874) --- branches/safari-604.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-12-13 22:55:44 UTC (rev 225873) +++ branches/safari-604.5.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2017-12-13 23:05:52 UTC (rev 225874) @@ -24,9 +24,9 @@ MAJOR_VERSION = 604; MINOR_VERSION = 5; TINY_VERSION = 2; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-604.5.2-branch/Source/WebCore/Configurations/Version.xcconfig (225873 => 225874) --- branches/safari-604.5.2-branch/Source/WebCore/Configurations/Version.xcconfig 2017-12-13 22:55:44 UTC (rev 225873) +++ branches/safari-604.5.2-branch/Source/WebCore/Configurations/Version.xcconfig 2017-12-13 23:05:52 UTC (rev 225874) @@ -24,9 +24,9 @@ MAJOR_VERSION = 604; MINOR_VERSION = 5; TINY_VERSION = 2; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-604.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (225873 => 225874) --- branches/safari-604.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-12-13 22:55:44 UTC (rev 225873) +++ branches/safari-604.5.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2017-12-13 23:05:52 UTC (rev 225874) @@ -24,9 +24,9 @@ MAJOR_VERSION = 604; MINOR_VERSION = 5; TINY_VERSION = 2; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION)); Modified: branches/safari-604.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (225873 => 225874) --- branches/safari-604.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-12-13 22:55:44 UTC (rev 225873) +++ branches/safari-604.5.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2017-12-13 23:05:52 UTC (rev 225874) @@ -1,9 +1,9 @@ MAJOR_VERSION = 604; MINOR_VERSION = 5; TINY_VERSION = 2; -MICRO_VERSION = 0; +MICRO_VERSION = 1; NANO_VERSION = 0; -FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); +FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); // The system version prefix is based on the current system version. SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8; Modified: branches/safari-604.5.2-branch/Source/WebKit/Configurations/Version.xcconfig (225873 => 225874) --- branches/safari-604.5.2-branch/Source/W
[webkit-changes] [225873] branches/safari-604.5.2-branch/
Title: [225873] branches/safari-604.5.2-branch/ Revision 225873 Author jmarc...@apple.com Date 2017-12-13 14:55:44 -0800 (Wed, 13 Dec 2017) Log Message New branch. Added Paths branches/safari-604.5.2-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225872] trunk
Title: [225872] trunk
Revision 225872
Author za...@apple.com
Date 2017-12-13 14:13:32 -0800 (Wed, 13 Dec 2017)
Log Message
RenderImage can be destroyed even before setting the style on it.
https://bugs.webkit.org/show_bug.cgi?id=180767
Reviewed by Simon Fraser.
Source/WebCore:
In certain cases, when the newly constructed renderer can't be inserted into the tree (parent can only have specific type of children etc),
RenderTreeUpdater destroys it right away. While destroying a RenderImage, the associated image resource assumes
that the image renderer has been initialized through RenderElement::initializeStyle(). This is an incorrect
assumption.
This patch also makes RenderImageResource's m_renderer a weak pointer.
Test: fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html
* rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::setCachedImage):
(WebCore::RenderImageResource::resetAnimation):
(WebCore::RenderImageResource::image const):
(WebCore::RenderImageResource::setContainerContext):
(WebCore::RenderImageResource::imageSize const):
* rendering/RenderImageResource.h:
(WebCore::RenderImageResource::renderer const):
* rendering/RenderImageResourceStyleImage.cpp:
(WebCore::RenderImageResourceStyleImage::shutdown):
LayoutTests:
* fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle-expected.txt: Added.
* fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderImageResource.cpp
trunk/Source/WebCore/rendering/RenderImageResource.h
trunk/Source/WebCore/rendering/RenderImageResourceStyleImage.cpp
Added Paths
trunk/LayoutTests/fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle-expected.txt
trunk/LayoutTests/fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html
Diff
Modified: trunk/LayoutTests/ChangeLog (225871 => 225872)
--- trunk/LayoutTests/ChangeLog 2017-12-13 21:58:19 UTC (rev 225871)
+++ trunk/LayoutTests/ChangeLog 2017-12-13 22:13:32 UTC (rev 225872)
@@ -1,3 +1,14 @@
+2017-12-13 Zalan Bujtas
+
+RenderImage can be destroyed even before setting the style on it.
+https://bugs.webkit.org/show_bug.cgi?id=180767
+
+
+Reviewed by Simon Fraser.
+
+* fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle-expected.txt: Added.
+* fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html: Added.
+
2017-12-13 Matt Lewis
Marked accessibility/mac/html5-input-number.html as flaky on macOS.
Added: trunk/LayoutTests/fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle-expected.txt (0 => 225872)
--- trunk/LayoutTests/fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle-expected.txt 2017-12-13 22:13:32 UTC (rev 225872)
@@ -0,0 +1,2 @@
+PASS if no crash.
+
Added: trunk/LayoutTests/fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html (0 => 225872)
--- trunk/LayoutTests/fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html (rev 0)
+++ trunk/LayoutTests/fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html 2017-12-13 22:13:32 UTC (rev 225872)
@@ -0,0 +1,17 @@
+
+
+
+
+col { content: url(data:image/gif;base64,foobar); }
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+
+PASS if no crash.
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (225871 => 225872)
--- trunk/Source/WebCore/ChangeLog 2017-12-13 21:58:19 UTC (rev 225871)
+++ trunk/Source/WebCore/ChangeLog 2017-12-13 22:13:32 UTC (rev 225872)
@@ -1,3 +1,31 @@
+2017-12-13 Zalan Bujtas
+
+RenderImage can be destroyed even before setting the style on it.
+https://bugs.webkit.org/show_bug.cgi?id=180767
+
+
+Reviewed by Simon Fraser.
+
+In certain cases, when the newly constructed renderer can't be inserted into the tree (parent can only have specific type of children etc),
+RenderTreeUpdater destroys it right away. While destroying a RenderImage, the associated image resource assumes
+that the image renderer has been initialized through RenderElement::initializeStyle(). This is an incorrect
+assumption.
+This patch also makes RenderImageResource's m_renderer a weak pointer.
+
+Test: fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html
+
+* rendering/RenderImageResource.cpp:
+(WebCore::RenderImageResource::initialize):
+
[webkit-changes] [225871] tags/Safari-605.1.18/Source
Title: [225871] tags/Safari-605.1.18/Source
Revision 225871
Author jmarc...@apple.com
Date 2017-12-13 13:58:19 -0800 (Wed, 13 Dec 2017)
Log Message
Cherry-pick r225863. rdar://problem/35996158
Modified Paths
tags/Safari-605.1.18/Source/WebCore/ChangeLog
tags/Safari-605.1.18/Source/WebCore/platform/mac/EventLoopMac.mm
tags/Safari-605.1.18/Source/WebKit/ChangeLog
tags/Safari-605.1.18/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm
tags/Safari-605.1.18/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm
tags/Safari-605.1.18/Source/WebKit/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist
tags/Safari-605.1.18/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: tags/Safari-605.1.18/Source/WebCore/ChangeLog (225870 => 225871)
--- tags/Safari-605.1.18/Source/WebCore/ChangeLog 2017-12-13 21:46:24 UTC (rev 225870)
+++ tags/Safari-605.1.18/Source/WebCore/ChangeLog 2017-12-13 21:58:19 UTC (rev 225871)
@@ -1,3 +1,20 @@
+2017-12-13 Jason Marcell
+
+Cherry-pick r225863. rdar://problem/35996158
+
+2017-12-13 Per Arne Vollan
+
+REGRESSION(225597): Can't select a text box or web view on a page when VO is on.
+https://bugs.webkit.org/show_bug.cgi?id=180756
+
+
+Reviewed by Brent Fulgham.
+
+No new tests.
+
+* platform/mac/EventLoopMac.mm:
+(WebCore::EventLoop::cycle):
+
2017-12-12 Zalan Bujtas
is reports the input type.
Modified: tags/Safari-605.1.18/Source/WebCore/platform/mac/EventLoopMac.mm (225870 => 225871)
--- tags/Safari-605.1.18/Source/WebCore/platform/mac/EventLoopMac.mm 2017-12-13 21:46:24 UTC (rev 225870)
+++ tags/Safari-605.1.18/Source/WebCore/platform/mac/EventLoopMac.mm 2017-12-13 21:58:19 UTC (rev 225871)
@@ -30,10 +30,12 @@
void EventLoop::cycle()
{
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
if (![NSApp isRunning]) {
[[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:0.05]];
return;
}
+#endif
[NSApp setWindowsNeedUpdate:YES];
if (NSEvent *event = [NSApp nextEventMatchingMask:NSEventMaskAny untilDate:[NSDate dateWithTimeIntervalSinceNow:0.05] inMode:NSDefaultRunLoopMode dequeue:YES])
[NSApp sendEvent:event];
Modified: tags/Safari-605.1.18/Source/WebKit/ChangeLog (225870 => 225871)
--- tags/Safari-605.1.18/Source/WebKit/ChangeLog 2017-12-13 21:46:24 UTC (rev 225870)
+++ tags/Safari-605.1.18/Source/WebKit/ChangeLog 2017-12-13 21:58:19 UTC (rev 225871)
@@ -1,3 +1,23 @@
+2017-12-13 Jason Marcell
+
+Cherry-pick r225863. rdar://problem/35996158
+
+2017-12-13 Per Arne Vollan
+
+REGRESSION(225597): Can't select a text box or web view on a page when VO is on.
+https://bugs.webkit.org/show_bug.cgi?id=180756
+
+
+Reviewed by Brent Fulgham.
+
+* Platform/IPC/mac/ConnectionMac.mm:
+(IPC::AccessibilityProcessSuspendedNotification):
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::shouldLeakBoost):
+* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeProcess):
+
2017-12-13 Carlos Garcia Campos
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release.
Modified: tags/Safari-605.1.18/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm (225870 => 225871)
--- tags/Safari-605.1.18/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm 2017-12-13 21:46:24 UTC (rev 225870)
+++ tags/Safari-605.1.18/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm 2017-12-13 21:58:19 UTC (rev 225871)
@@ -586,9 +586,11 @@
static void AccessibilityProcessSuspendedNotification(bool suspended)
{
#if PLATFORM(MAC)
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
// Calling _AXUIElementNotifyProcessSuspendStatus will crash if the NSApplication event loop is not running.
if (![NSApp isRunning])
return;
+#endif
_AXUIElementNotifyProcessSuspendStatus(suspended ? AXSuspendStatusSuspended : AXSuspendStatusRunning);
#elif PLATFORM(IOS)
UIAccessibilityPostNotification(kAXPidStatusChangedNotification, @{ @"pid" : @(getpid()), @"suspended" : @(suspended) });
Modified: tags/Safari-605.1.18/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm (225870 => 225871)
--- tags/Safari-605.1.18/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2017-12-13 21:46:24 UTC (rev 225870)
+++ tags/Safari-605.1.18/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2017-12-13 21:58:19 UTC (rev 225871)
@@ -76,9 +76,13 @@
UNUSED_PARAM(launchOptions);
return true;
#else
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+// Boost the WebContent process if the NSApplication run loop is not used.
+if (launchOptions.processType == ProcessLauncher::ProcessType::Web)
+return true;
+#endif
// On Mac, leak a boost
[webkit-changes] [225870] trunk/Tools
Title: [225870] trunk/Tools Revision 225870 Author commit-qu...@webkit.org Date 2017-12-13 13:46:24 -0800 (Wed, 13 Dec 2017) Log Message Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework https://bugs.webkit.org/show_bug.cgi?id=180713 Patch by Youenn Fablet on 2017-12-13 Reviewed by Andy Estes. Reenable the check for non High Sierra builds. * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm: (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]): Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm Diff Modified: trunk/Tools/ChangeLog (225869 => 225870) --- trunk/Tools/ChangeLog 2017-12-13 21:16:34 UTC (rev 225869) +++ trunk/Tools/ChangeLog 2017-12-13 21:46:24 UTC (rev 225870) @@ -1,3 +1,16 @@ +2017-12-13 Youenn Fablet + +Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework +https://bugs.webkit.org/show_bug.cgi?id=180713 + + +Reviewed by Andy Estes. + +Reenable the check for non High Sierra builds. + +* TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm: +(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]): + 2017-12-13 Brady Eidson REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing. Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm (225869 => 225870) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm 2017-12-13 21:16:34 UTC (rev 225869) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm 2017-12-13 21:46:24 UTC (rev 225870) @@ -364,10 +364,12 @@ #endif #if HAVE(NETWORK_EXTENSION) // FIXME: Libwebrtc is linking on some configurations to VideoProcessing framework which brings up NetworkExtension framework. +// Disable this test until we find a more robust test or libwebrtc weak link VideoProcessing framework. // https://bugs.webkit.org/show_bug.cgi?id=180713 -// Disable this test until we find a more robust test or libwebrtc weak link VideoProcessing framework. -// EXPECT_EQ(static_cast(networkExtensionShouldBeLoaded), static_cast(networkExtensionLoaded)); +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300 +EXPECT_EQ(static_cast(networkExtensionShouldBeLoaded), static_cast(networkExtensionLoaded)); #endif +#endif // HAVE(NETWORK_EXTENSION) isDone = true; }]; TestWebKitAPI::Util::run(&isDone); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225869] trunk/LayoutTests
Title: [225869] trunk/LayoutTests Revision 225869 Author jlew...@apple.com Date 2017-12-13 13:16:34 -0800 (Wed, 13 Dec 2017) Log Message Marked accessibility/mac/html5-input-number.html as flaky on macOS. https://bugs.webkit.org/show_bug.cgi?id=180560 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (225868 => 225869) --- trunk/LayoutTests/ChangeLog 2017-12-13 21:12:42 UTC (rev 225868) +++ trunk/LayoutTests/ChangeLog 2017-12-13 21:16:34 UTC (rev 225869) @@ -1,5 +1,14 @@ 2017-12-13 Matt Lewis +Marked accessibility/mac/html5-input-number.html as flaky on macOS. +https://bugs.webkit.org/show_bug.cgi?id=180560 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2017-12-13 Matt Lewis + Removed debug only expectations from platform/ios/ios/plugin/youtube-flash-plugin-iframe.html https://bugs.webkit.org/show_bug.cgi?id=163362 Modified: trunk/LayoutTests/platform/mac/TestExpectations (225868 => 225869) --- trunk/LayoutTests/platform/mac/TestExpectations 2017-12-13 21:12:42 UTC (rev 225868) +++ trunk/LayoutTests/platform/mac/TestExpectations 2017-12-13 21:16:34 UTC (rev 225869) @@ -1762,3 +1762,6 @@ webkit.org/b/180062 [ ElCapitan Sierra HighSierra ] fast/text/user-installed-fonts/disable.html [ ImageOnlyFailure ] webkit.org/b/180062 [ ElCapitan Sierra HighSierra ] fast/text/user-installed-fonts/shadow-postscript.html [ ImageOnlyFailure ] webkit.org/b/180062 [ ElCapitan Sierra HighSierra ] fast/text/user-installed-fonts/shadow.html [ ImageOnlyFailure ] + +webkit.org/b/180560 accessibility/mac/html5-input-number.html [ Pass Failure ] + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225868] trunk/Source/WebCore
Title: [225868] trunk/Source/WebCore Revision 225868 Author rn...@webkit.org Date 2017-12-13 13:12:42 -0800 (Wed, 13 Dec 2017) Log Message Update the SVG use element's shadow trees explicitly before the style recall https://bugs.webkit.org/show_bug.cgi?id=180729 Reviewed by Antti Koivisto. Update the SVG use element's shadow trees before start resolving styles. Document now has a hash set of all connected SVG use elements with invalidated shadow trees. SVGUseElement adds itself to this set when its shadow tree gets invalidated, or it gets newly connected to a document with the invalidated shadow tree. SVGUseElement removes itself from this set when it updates its shadow tree or it gets disconnected from a document with the invalidated shadow tree. No new tests. Covered by existing tests. * dom/Document.cpp: (WebCore::Document::~Document): Assert that m_svgUseElements has been cleared. (WebCore::Document::resolveStyle): Update the shadow trees of SVG use elements with invalidated shadow trees. (WebCore::Document::addSVGUseElement): Added. (WebCore::Document::removeSVGUseElement): Added. * dom/Document.h: (WebCore::Document::svgUseElements const): Added. * dom/Element.cpp: (WebCore::Element::cloneElementWithChildren): Removed EventAllowedScope since the SVG use element's shadow tree is no longer updated when there is a NoEventDispatchAssertion in the stack. (WebCore::Element::cloneElementWithoutChildren): Ditto. * style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveComposedTree): No longer drops the assertion now that SVG use element's shadow tree is updated before calling this function. * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::insertedIntoAncestor): Add the element to the document's hash set if this use element's shadow tree needs to be updated (m_shadowTreeNeedsUpdate is set), and it got newly connected. (WebCore::SVGUseElement::removedFromAncestor): Ditto for removal. We have to check m_shadowTreeNeedsUpdate before calling SVGGraphicsElement::removedFromAncestor or updateExternalDocument since either function can invoke m_shadowTreeNeedsUpdate to true. (WebCore::SVGUseElement::willRecalcStyle): Deleted. We no longer call updateShadowTree during style recalc. (WebCore::SVGUseElement::updateShadowTree): Remove this element from the document's hah set. We can't clear all the entries in the map at once in Document::resolveStyle because updating the shadow trees of a SVG use element can result in a sync IPC in ImageLoader::updateFromElement, which end up executing arbitrary author scripts. (WebCore::SVGUseElement::cloneTarget const): Removed EventAllowedScope since the SVG use element's shadow tree is no longer updated when there is a NoEventDispatchAssertion in the stack. (WebCore::SVGUseElement::expandUseElementsInShadowTree const): Ditto. (WebCore::SVGUseElement::expandSymbolElementsInShadowTree const): Ditto. (WebCore::SVGUseElement::invalidateShadowTree): Add the element to the document's hash set if it's connected. * svg/SVGUseElement.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/style/StyleTreeResolver.cpp trunk/Source/WebCore/svg/SVGUseElement.cpp trunk/Source/WebCore/svg/SVGUseElement.h Diff Modified: trunk/Source/WebCore/ChangeLog (225867 => 225868) --- trunk/Source/WebCore/ChangeLog 2017-12-13 20:54:39 UTC (rev 225867) +++ trunk/Source/WebCore/ChangeLog 2017-12-13 21:12:42 UTC (rev 225868) @@ -1,3 +1,50 @@ +2017-12-13 Ryosuke Niwa + +Update the SVG use element's shadow trees explicitly before the style recall +https://bugs.webkit.org/show_bug.cgi?id=180729 + + +Reviewed by Antti Koivisto. + +Update the SVG use element's shadow trees before start resolving styles. Document now has a hash set of all +connected SVG use elements with invalidated shadow trees. SVGUseElement adds itself to this set when its +shadow tree gets invalidated, or it gets newly connected to a document with the invalidated shadow tree. +SVGUseElement removes itself from this set when it updates its shadow tree or it gets disconnected from +a document with the invalidated shadow tree. + +No new tests. Covered by existing tests. + +* dom/Document.cpp: +(WebCore::Document::~Document): Assert that m_svgUseElements has been cleared. +(WebCore::Document::resolveStyle): Update the shadow trees of SVG use elements with invalidated shadow trees. +(WebCore::Document::addSVGUseElement): Added. +(WebCore::Document::removeSVGUseElement): Added. +* dom/Document.h: +(WebCore::Document::svgUseElements const): Added. +* dom/Element.cpp: +(WebCore::Element::cloneElementWithChildren): Removed EventAllowedScope since the SVG use element's shadow +tree is no longer updated when there is a NoEventDispatchAssertio
[webkit-changes] [225867] trunk/LayoutTests
Title: [225867] trunk/LayoutTests Revision 225867 Author jlew...@apple.com Date 2017-12-13 12:54:39 -0800 (Wed, 13 Dec 2017) Log Message Removed debug only expectations from platform/ios/ios/plugin/youtube-flash-plugin-iframe.html https://bugs.webkit.org/show_bug.cgi?id=163362 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (225866 => 225867) --- trunk/LayoutTests/ChangeLog 2017-12-13 20:47:03 UTC (rev 225866) +++ trunk/LayoutTests/ChangeLog 2017-12-13 20:54:39 UTC (rev 225867) @@ -1,5 +1,14 @@ 2017-12-13 Matt Lewis +Removed debug only expectations from platform/ios/ios/plugin/youtube-flash-plugin-iframe.html +https://bugs.webkit.org/show_bug.cgi?id=163362 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2017-12-13 Matt Lewis + Updated expectations for contentextension tests to be flaky. https://bugs.webkit.org/show_bug.cgi?id=162942 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (225866 => 225867) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-12-13 20:47:03 UTC (rev 225866) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2017-12-13 20:54:39 UTC (rev 225867) @@ -1202,7 +1202,7 @@ webkit.org/b/127116 [ Debug ] svg/custom/animate-initial-pause-unpause.html [ Pass Failure ] -webkit.org/b/163362 [ Debug ] platform/ios/ios/plugin/youtube-flash-plugin-iframe.html [ Pass Failure ] +webkit.org/b/163362 platform/ios/ios/plugin/youtube-flash-plugin-iframe.html [ Pass Failure ] webkit.org/b/164960 http/tests/security/module-correct-mime-types.html [ Slow ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225865] trunk/Source/JavaScriptCore
Title: [225865] trunk/Source/_javascript_Core
Revision 225865
Author sbar...@apple.com
Date 2017-12-13 12:46:33 -0800 (Wed, 13 Dec 2017)
Log Message
REGRESSION(r225844): Around 850 new JSC failures on 32-bit
https://bugs.webkit.org/show_bug.cgi?id=180764
Unreviewed. We should only emit CheckStructureOrEmpty on 64 bit platforms.
* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225864 => 225865)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-13 20:20:18 UTC (rev 225864)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-13 20:46:33 UTC (rev 225865)
@@ -1,3 +1,13 @@
+2017-12-13 Saam Barati
+
+REGRESSION(r225844): Around 850 new JSC failures on 32-bit
+https://bugs.webkit.org/show_bug.cgi?id=180764
+
+Unreviewed. We should only emit CheckStructureOrEmpty on 64 bit platforms.
+
+* dfg/DFGTypeCheckHoistingPhase.cpp:
+(JSC::DFG::TypeCheckHoistingPhase::run):
+
2017-12-13 Michael Saboff
Unreviewed rollout of r225695. Caused a crash on yahoo login page.
Modified: trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp (225864 => 225865)
--- trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp 2017-12-13 20:20:18 UTC (rev 225864)
+++ trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp 2017-12-13 20:46:33 UTC (rev 225865)
@@ -145,12 +145,15 @@
OpInfo(variable), Edge(node));
if (iter->value.m_structure) {
auto checkOp = CheckStructure;
-VirtualRegister local = node->variableAccessData()->local();
-auto* inlineCallFrame = node->origin.semantic.inlineCallFrame;
-if ((local - (inlineCallFrame ? inlineCallFrame->stackOffset : 0)) == virtualRegisterForArgument(0)) {
-// |this| can be the TDZ value. The call entrypoint won't have |this| as TDZ,
-// but a catch or a loop OSR entry may have |this| be TDZ.
-checkOp = CheckStructureOrEmpty;
+if (is64Bit()) {
+static_assert(is64Bit() || !(SpecCellCheck & SpecEmpty), "");
+VirtualRegister local = node->variableAccessData()->local();
+auto* inlineCallFrame = node->origin.semantic.inlineCallFrame;
+if ((local - (inlineCallFrame ? inlineCallFrame->stackOffset : 0)) == virtualRegisterForArgument(0)) {
+// |this| can be the TDZ value. The call entrypoint won't have |this| as TDZ,
+// but a catch or a loop OSR entry may have |this| be TDZ.
+checkOp = CheckStructureOrEmpty;
+}
}
insertionSet.insertNode(
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225866] trunk/LayoutTests
Title: [225866] trunk/LayoutTests Revision 225866 Author jlew...@apple.com Date 2017-12-13 12:47:03 -0800 (Wed, 13 Dec 2017) Log Message Updated expectations for contentextension tests to be flaky. https://bugs.webkit.org/show_bug.cgi?id=162942 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (225865 => 225866) --- trunk/LayoutTests/ChangeLog 2017-12-13 20:46:33 UTC (rev 225865) +++ trunk/LayoutTests/ChangeLog 2017-12-13 20:47:03 UTC (rev 225866) @@ -1,3 +1,12 @@ +2017-12-13 Matt Lewis + +Updated expectations for contentextension tests to be flaky. +https://bugs.webkit.org/show_bug.cgi?id=162942 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2017-12-13 Antoine Quint [Web Animations] Implement the "updating the finished state" procedure Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (225865 => 225866) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-12-13 20:46:33 UTC (rev 225865) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-12-13 20:47:03 UTC (rev 225866) @@ -527,8 +527,8 @@ # Content Extensions tests must be enabled explicitly on mac-wk2. -http/tests/contentextensions [ Pass ] -http/tests/websocket/tests/hybi/contentextensions [ Pass ] +http/tests/contentextensions [ Pass Failure ] +http/tests/websocket/tests/hybi/contentextensions [ Pass Failure ] webkit.org/b/179557 http/tests/websocket/tests/hybi/contentextensions/upgrade-worker.html [ Pass Failure ] webkit.org/b/179256 [ Sierra+ ] http/wpt/beacon/contentextensions [ Pass Failure ] webkit.org/b/168081 http/tests/contentextensions/async-xhr-onerror.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225864] trunk
Title: [225864] trunk Revision 225864 Author beid...@apple.com Date 2017-12-13 12:20:18 -0800 (Wed, 13 Dec 2017) Log Message REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing. https://bugs.webkit.org/show_bug.cgi?id=180722 Reviewed by Chris Dumez. Source/WebKit: - Add a test-only accessor to get the number of WebProcesses hosting WebPages - Have WebsiteDataStore keep track of all instances so they can be looked up by SessionID - When the StorageProcess needs to establish a SW context connection on behalf of a specific SessionID, the UI process will now prefer using the WebsiteDataStore associated with that SessionID. This allows us to continue deferring creation of the default data store if it's not needed. * StorageProcess/StorageProcess.cpp: (WebKit::StorageProcess::connectionToContextProcessWasClosed): (WebKit::StorageProcess::createServerToContextConnection): * StorageProcess/StorageProcess.h: * StorageProcess/StorageToWebProcessConnection.cpp: (WebKit::StorageToWebProcessConnection::establishSWServerConnection): * UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _webPageContentProcessCount]): * UIProcess/API/Cocoa/WKProcessPoolPrivate.h: * UIProcess/Storage/StorageProcessProxy.cpp: (WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcess): (WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcessForExplicitSession): * UIProcess/Storage/StorageProcessProxy.h: * UIProcess/Storage/StorageProcessProxy.messages.in: * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess): * UIProcess/WebProcessPool.h: * UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::WebsiteDataStore): (WebKit::WebsiteDataStore::~WebsiteDataStore): (WebKit::WebsiteDataStore::existingDataStoreForSessionID): * UIProcess/WebsiteData/WebsiteDataStore.h: Tools: * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm: (TEST): Call a new SPI to get the count of WebProcesses hosting WebPages. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/StorageProcess/StorageProcess.cpp trunk/Source/WebKit/StorageProcess/StorageProcess.h trunk/Source/WebKit/StorageProcess/StorageToWebProcessConnection.cpp trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPool.mm trunk/Source/WebKit/UIProcess/API/Cocoa/WKProcessPoolPrivate.h trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.h trunk/Source/WebKit/UIProcess/Storage/StorageProcessProxy.messages.in trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.h trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm Diff Modified: trunk/Source/WebKit/ChangeLog (225863 => 225864) --- trunk/Source/WebKit/ChangeLog 2017-12-13 20:19:08 UTC (rev 225863) +++ trunk/Source/WebKit/ChangeLog 2017-12-13 20:20:18 UTC (rev 225864) @@ -1,3 +1,44 @@ +2017-12-13 Brady Eidson + +REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing. +https://bugs.webkit.org/show_bug.cgi?id=180722 + +Reviewed by Chris Dumez. + +- Add a test-only accessor to get the number of WebProcesses hosting WebPages +- Have WebsiteDataStore keep track of all instances so they can be looked up by SessionID +- When the StorageProcess needs to establish a SW context connection on behalf of a specific SessionID, + the UI process will now prefer using the WebsiteDataStore associated with that SessionID. This allows + us to continue deferring creation of the default data store if it's not needed. + +* StorageProcess/StorageProcess.cpp: +(WebKit::StorageProcess::connectionToContextProcessWasClosed): +(WebKit::StorageProcess::createServerToContextConnection): +* StorageProcess/StorageProcess.h: + +* StorageProcess/StorageToWebProcessConnection.cpp: +(WebKit::StorageToWebProcessConnection::establishSWServerConnection): + +* UIProcess/API/Cocoa/WKProcessPool.mm: +(-[WKProcessPool _webPageContentProcessCount]): +* UIProcess/API/Cocoa/WKProcessPoolPrivate.h: + +* UIProcess/Storage/StorageProcessProxy.cpp: +(WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcess): +(WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcessForExplicitSession): +* UIProcess/Storage/StorageProcessProxy.h: +* UIProcess/Storage/StorageProcessProxy.messages.in: + +* UIProcess/WebProcessPool.cpp: +(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess): +* UIProcess/
[webkit-changes] [225863] trunk/Source
Title: [225863] trunk/Source
Revision 225863
Author pvol...@apple.com
Date 2017-12-13 12:19:08 -0800 (Wed, 13 Dec 2017)
Log Message
REGRESSION(225597): Can't select a text box or web view on a page when VO is on.
https://bugs.webkit.org/show_bug.cgi?id=180756
Reviewed by Brent Fulgham.
Source/WebCore:
No new tests.
* platform/mac/EventLoopMac.mm:
(WebCore::EventLoop::cycle):
Source/WebKit:
* Platform/IPC/mac/ConnectionMac.mm:
(IPC::AccessibilityProcessSuspendedNotification):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::shouldLeakBoost):
* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeProcess):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/EventLoopMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm
trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm
trunk/Source/WebKit/WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist
trunk/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (225862 => 225863)
--- trunk/Source/WebCore/ChangeLog 2017-12-13 20:01:48 UTC (rev 225862)
+++ trunk/Source/WebCore/ChangeLog 2017-12-13 20:19:08 UTC (rev 225863)
@@ -1,3 +1,16 @@
+2017-12-13 Per Arne Vollan
+
+REGRESSION(225597): Can't select a text box or web view on a page when VO is on.
+https://bugs.webkit.org/show_bug.cgi?id=180756
+
+
+Reviewed by Brent Fulgham.
+
+No new tests.
+
+* platform/mac/EventLoopMac.mm:
+(WebCore::EventLoop::cycle):
+
2017-12-13 Antoine Quint
[Web Animations] Implement the "updating the finished state" procedure
Modified: trunk/Source/WebCore/platform/mac/EventLoopMac.mm (225862 => 225863)
--- trunk/Source/WebCore/platform/mac/EventLoopMac.mm 2017-12-13 20:01:48 UTC (rev 225862)
+++ trunk/Source/WebCore/platform/mac/EventLoopMac.mm 2017-12-13 20:19:08 UTC (rev 225863)
@@ -30,10 +30,12 @@
void EventLoop::cycle()
{
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
if (![NSApp isRunning]) {
[[NSRunLoop currentRunLoop] runUntilDate:[NSDate dateWithTimeIntervalSinceNow:0.05]];
return;
}
+#endif
[NSApp setWindowsNeedUpdate:YES];
if (NSEvent *event = [NSApp nextEventMatchingMask:NSEventMaskAny untilDate:[NSDate dateWithTimeIntervalSinceNow:0.05] inMode:NSDefaultRunLoopMode dequeue:YES])
[NSApp sendEvent:event];
Modified: trunk/Source/WebKit/ChangeLog (225862 => 225863)
--- trunk/Source/WebKit/ChangeLog 2017-12-13 20:01:48 UTC (rev 225862)
+++ trunk/Source/WebKit/ChangeLog 2017-12-13 20:19:08 UTC (rev 225863)
@@ -1,3 +1,19 @@
+2017-12-13 Per Arne Vollan
+
+REGRESSION(225597): Can't select a text box or web view on a page when VO is on.
+https://bugs.webkit.org/show_bug.cgi?id=180756
+
+
+Reviewed by Brent Fulgham.
+
+* Platform/IPC/mac/ConnectionMac.mm:
+(IPC::AccessibilityProcessSuspendedNotification):
+* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+(WebKit::shouldLeakBoost):
+* WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::initializeProcess):
+
2017-12-13 Brent Fulgham
[iOS] Further Trim WebContent Process sandbox
Modified: trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm (225862 => 225863)
--- trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm 2017-12-13 20:01:48 UTC (rev 225862)
+++ trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm 2017-12-13 20:19:08 UTC (rev 225863)
@@ -586,9 +586,11 @@
static void AccessibilityProcessSuspendedNotification(bool suspended)
{
#if PLATFORM(MAC)
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
// Calling _AXUIElementNotifyProcessSuspendStatus will crash if the NSApplication event loop is not running.
if (![NSApp isRunning])
return;
+#endif
_AXUIElementNotifyProcessSuspendStatus(suspended ? AXSuspendStatusSuspended : AXSuspendStatusRunning);
#elif PLATFORM(IOS)
UIAccessibilityPostNotification(kAXPidStatusChangedNotification, @{ @"pid" : @(getpid()), @"suspended" : @(suspended) });
Modified: trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm (225862 => 225863)
--- trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2017-12-13 20:01:48 UTC (rev 225862)
+++ trunk/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm 2017-12-13 20:19:08 UTC (rev 225863)
@@ -76,9 +76,13 @@
UNUSED_PARAM(launchOptions);
return true;
#else
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+// Boost the WebContent process if the NSApplication run loop is not used.
+if (launchOptions.processType == ProcessLauncher::ProcessType::Web)
+return true;
+#endif
// On Mac, leak a boost onto the NetworkProcess.
-return launchOptions.pr
[webkit-changes] [225862] trunk
Title: [225862] trunk Revision 225862 Author grao...@webkit.org Date 2017-12-13 12:01:48 -0800 (Wed, 13 Dec 2017) Log Message [Web Animations] Implement the "updating the finished state" procedure https://bugs.webkit.org/show_bug.cgi?id=180743 Reviewed by Simon Fraser. Source/WebCore: The Web Animations spec defines a procedure for "updating the finished state", which should run as the timeline time changes and is responsible for ultimately triggering finish events and fulfil the "finished" promise. The procedure allows for two flags to control its behavior: didSeek and synchronouslyNotify. When synchronouslyNotify is true, the "finish notification steps" procedure is ran right away, otherwise it's queued as a microtask. In this patch we introduce the notion of "hold time", which is the time held while an animation is paused. It will be set by the pause() and play() method in future patches. * animation/DocumentTimeline.cpp: (WebCore::DocumentTimeline::updateAnimations): Update the finished state as the timeline time changes with both flags set to false. * animation/WebAnimation.cpp: (WebCore::WebAnimation::currentTime const): Add a private currentTime(bool) variant which allows for the hold time to be ignored in case updateFinishedState() was called with the didSeek flag set to false. (WebCore::WebAnimation::updateFinishedState): Implement the procedure as specified with all spec-mandated steps inline. (WebCore::WebAnimation::scheduleMicrotaskIfNeeded): Schedule a microtask to complete the "finish notification steps" if we haven't scheduled a microtask before. (WebCore::WebAnimation::performMicrotask): Perform the microtask if the "finish notification steps" procedure hasn't been canceled after it was originally scheduled, as tracked by the m_finishNotificationStepsMicrotaskPending flag, since microtasks are not presently cancelable. (WebCore::WebAnimation::finishNotificationSteps): Implement the procedure as specified with all spec-mandated steps inline, dispatching a "finish" events and fulfilling the "finished" promise. * animation/WebAnimation.h: * animation/WebAnimation.idl: * dom/EventNames.h: LayoutTests: Rebase some WPT expectations with minor progressions due to exposing the "onfinish" property. * http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/animation/DocumentTimeline.cpp trunk/Source/WebCore/animation/WebAnimation.cpp trunk/Source/WebCore/animation/WebAnimation.h trunk/Source/WebCore/animation/WebAnimation.idl trunk/Source/WebCore/dom/EventNames.h Diff Modified: trunk/LayoutTests/ChangeLog (225861 => 225862) --- trunk/LayoutTests/ChangeLog 2017-12-13 19:38:51 UTC (rev 225861) +++ trunk/LayoutTests/ChangeLog 2017-12-13 20:01:48 UTC (rev 225862) @@ -1,3 +1,15 @@ +2017-12-13 Antoine Quint + +[Web Animations] Implement the "updating the finished state" procedure +https://bugs.webkit.org/show_bug.cgi?id=180743 + + +Reviewed by Simon Fraser. + +Rebase some WPT expectations with minor progressions due to exposing the "onfinish" property. + +* http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt: + 2017-12-13 Matt Lewis Updated Expectations for http/tests/cache/disk-cache/disk-cache-204-status-code.html Modified: trunk/LayoutTests/http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt (225861 => 225862) --- trunk/LayoutTests/http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt 2017-12-13 19:38:51 UTC (rev 225861) +++ trunk/LayoutTests/http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt 2017-12-13 20:01:48 UTC (rev 225862) @@ -14,7 +14,7 @@ PASS Animation interface: attribute playState PASS Animation interface: attribute ready PASS Animation interface: attribute finished -FAIL Animation interface: attribute onfinish assert_true: The prototype object must have a property "onfinish" expected true got false +PASS Animation interface: attribute onfinish FAIL Animation interface: attribute oncancel assert_true: The prototype object must have a property "oncancel" expected true got false FAIL Animation interface: operation cancel() assert_own_property: interface prototype object missing non-static operation expected property "cancel" missing FAIL Animation interface: operation finish() assert_own_property: interface prototype object missing non-static operation expected property "finish" missing @@ -32,7 +32,7 @@ PASS Animation interface: new Animation() must inherit property "playState" with the proper type PASS Animation interface: new Animation() must inherit property "ready" with the proper type PASS Animation interface: new Animation() must inherit property "finished" with the proper type -FAIL Animation interface: new Animation()
[webkit-changes] [225861] trunk/Source/JavaScriptCore
Title: [225861] trunk/Source/_javascript_Core
Revision 225861
Author msab...@apple.com
Date 2017-12-13 11:38:51 -0800 (Wed, 13 Dec 2017)
Log Message
Unreviewed rollout of r225695. Caused a crash on yahoo login page.
That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=180761.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/RegExp.cpp
trunk/Source/_javascript_Core/runtime/RegExp.h
trunk/Source/_javascript_Core/runtime/RegExpInlines.h
trunk/Source/_javascript_Core/testRegExp.cpp
trunk/Source/_javascript_Core/yarr/Yarr.h
trunk/Source/_javascript_Core/yarr/YarrInterpreter.cpp
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp
trunk/Source/_javascript_Core/yarr/YarrJIT.h
trunk/Source/_javascript_Core/yarr/YarrPattern.cpp
trunk/Source/_javascript_Core/yarr/YarrPattern.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225860 => 225861)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-13 19:31:39 UTC (rev 225860)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-13 19:38:51 UTC (rev 225861)
@@ -1,3 +1,68 @@
+2017-12-13 Michael Saboff
+
+Unreviewed rollout of r225695. Caused a crash on yahoo login page.
+
+That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=180761.
+
+* runtime/RegExp.cpp:
+(JSC::RegExp::compile):
+(JSC::RegExp::compileMatchOnly):
+(JSC::byteCodeCompilePattern): Deleted.
+(JSC::RegExp::byteCodeCompileIfNecessary): Deleted.
+* runtime/RegExp.h:
+* runtime/RegExpInlines.h:
+(JSC::RegExp::matchInline):
+* testRegExp.cpp:
+(parseRegExpLine):
+(runFromFiles):
+* yarr/Yarr.h:
+* yarr/YarrInterpreter.cpp:
+(JSC::Yarr::ByteCompiler::compile):
+(JSC::Yarr::ByteCompiler::dumpDisjunction):
+(JSC::Yarr::ByteCompiler::emitDisjunction):
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::YarrGenerator::tryReadUnicodeCharImpl):
+(JSC::Yarr::YarrGenerator::generate):
+(JSC::Yarr::YarrGenerator::backtrack):
+(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
+(JSC::Yarr::YarrGenerator::generateEnter):
+(JSC::Yarr::YarrGenerator::generateReturn):
+(JSC::Yarr::YarrGenerator::YarrGenerator):
+(JSC::Yarr::YarrGenerator::compile):
+(JSC::Yarr::YarrGenerator::ParenContextSizes::ParenContextSizes): Deleted.
+(JSC::Yarr::YarrGenerator::ParenContextSizes::numSubpatterns): Deleted.
+(JSC::Yarr::YarrGenerator::ParenContextSizes::frameSlots): Deleted.
+(JSC::Yarr::YarrGenerator::ParenContext::sizeFor): Deleted.
+(JSC::Yarr::YarrGenerator::ParenContext::nextOffset): Deleted.
+(JSC::Yarr::YarrGenerator::ParenContext::beginOffset): Deleted.
+(JSC::Yarr::YarrGenerator::ParenContext::matchAmountOffset): Deleted.
+(JSC::Yarr::YarrGenerator::ParenContext::subpatternOffset): Deleted.
+(JSC::Yarr::YarrGenerator::ParenContext::savedFrameOffset): Deleted.
+(JSC::Yarr::YarrGenerator::initParenContextFreeList): Deleted.
+(JSC::Yarr::YarrGenerator::allocatePatternContext): Deleted.
+(JSC::Yarr::YarrGenerator::freePatternContext): Deleted.
+(JSC::Yarr::YarrGenerator::savePatternContext): Deleted.
+(JSC::Yarr::YarrGenerator::restorePatternContext): Deleted.
+(JSC::Yarr::YarrGenerator::generateJITFailReturn): Deleted.
+(JSC::Yarr::YarrGenerator::clearMatches): Deleted.
+* yarr/YarrJIT.h:
+(JSC::Yarr::YarrCodeBlock::execute):
+* yarr/YarrPattern.cpp:
+(JSC::Yarr::indentForNestingLevel):
+(JSC::Yarr::dumpUChar32):
+(JSC::Yarr::PatternTerm::dump):
+(JSC::Yarr::YarrPattern::dumpPattern):
+(JSC::Yarr::dumpCharacterClass): Deleted.
+* yarr/YarrPattern.h:
+(JSC::Yarr::BackTrackInfoAlternative::offsetIndex):
+(JSC::Yarr::BackTrackInfoParenthesesOnce::beginIndex):
+(JSC::Yarr::PatternTerm::containsAnyCaptures): Deleted.
+(JSC::Yarr::BackTrackInfoParenthesesOnce::returnAddressIndex): Deleted.
+(JSC::Yarr::BackTrackInfoParentheses::beginIndex): Deleted.
+(JSC::Yarr::BackTrackInfoParentheses::returnAddressIndex): Deleted.
+(JSC::Yarr::BackTrackInfoParentheses::matchAmountIndex): Deleted.
+(JSC::Yarr::BackTrackInfoParentheses::patternContextHeadIndex): Deleted.
+
2017-12-13 Mark Lam
Fill out some Poisoned APIs, fix some bugs, and add some tests.
Modified: trunk/Source/_javascript_Core/runtime/RegExp.cpp (225860 => 225861)
--- trunk/Source/_javascript_Core/runtime/RegExp.cpp 2017-12-13 19:31:39 UTC (rev 225860)
+++ trunk/Source/_javascript_Core/runtime/RegExp.cpp 2017-12-13 19:38:51 UTC (rev 225861)
@@ -271,30 +271,6 @@
return vm.regExpCache()->lookupOrCreate(patternString, flags);
}
-
-static std::unique_ptr byteCodeCompilePattern(VM* vm, Yarr::YarrPattern& pattern)
-{
-retur
[webkit-changes] [225860] tags/Safari-605.1.18/Source/JavaScriptCore
Title: [225860] tags/Safari-605.1.18/Source/_javascript_Core
Revision 225860
Author jmarc...@apple.com
Date 2017-12-13 11:31:39 -0800 (Wed, 13 Dec 2017)
Log Message
Revert r225695. rdar://problem/35914716
Modified Paths
tags/Safari-605.1.18/Source/_javascript_Core/ChangeLog
tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExp.cpp
tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExp.h
tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExpInlines.h
tags/Safari-605.1.18/Source/_javascript_Core/testRegExp.cpp
tags/Safari-605.1.18/Source/_javascript_Core/yarr/Yarr.h
tags/Safari-605.1.18/Source/_javascript_Core/yarr/YarrInterpreter.cpp
tags/Safari-605.1.18/Source/_javascript_Core/yarr/YarrJIT.cpp
tags/Safari-605.1.18/Source/_javascript_Core/yarr/YarrJIT.h
tags/Safari-605.1.18/Source/_javascript_Core/yarr/YarrPattern.cpp
tags/Safari-605.1.18/Source/_javascript_Core/yarr/YarrPattern.h
Diff
Modified: tags/Safari-605.1.18/Source/_javascript_Core/ChangeLog (225859 => 225860)
--- tags/Safari-605.1.18/Source/_javascript_Core/ChangeLog 2017-12-13 19:26:08 UTC (rev 225859)
+++ tags/Safari-605.1.18/Source/_javascript_Core/ChangeLog 2017-12-13 19:31:39 UTC (rev 225860)
@@ -1,3 +1,7 @@
+2017-12-13 Jason Marcell
+
+Revert r225695. rdar://problem/35914716
+
2017-12-12 Yusuke Suzuki
[JSC] Optimize Object.assign by single transition acceleration
Modified: tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExp.cpp (225859 => 225860)
--- tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExp.cpp 2017-12-13 19:26:08 UTC (rev 225859)
+++ tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExp.cpp 2017-12-13 19:31:39 UTC (rev 225860)
@@ -271,30 +271,6 @@
return vm.regExpCache()->lookupOrCreate(patternString, flags);
}
-
-static std::unique_ptr byteCodeCompilePattern(VM* vm, Yarr::YarrPattern& pattern)
-{
-return Yarr::byteCompile(pattern, &vm->m_regExpAllocator, &vm->m_regExpAllocatorLock);
-}
-
-void RegExp::byteCodeCompileIfNecessary(VM* vm)
-{
-if (m_regExpBytecode)
-return;
-
-Yarr::YarrPattern pattern(m_patternString, m_flags, &m_constructionError, vm->stackLimit());
-if (m_constructionError) {
-RELEASE_ASSERT_NOT_REACHED();
-#if COMPILER_QUIRK(CONSIDERS_UNREACHABLE_CODE)
-m_state = ParseError;
-return;
-#endif
-}
-ASSERT(m_numSubpatterns == pattern.m_numSubpatterns);
-
-m_regExpBytecode = byteCodeCompilePattern(vm, pattern);
-}
-
void RegExp::compile(VM* vm, Yarr::YarrCharSize charSize)
{
ConcurrentJSLocker locker(m_lock);
@@ -327,11 +303,8 @@
UNUSED_PARAM(charSize);
#endif
-if (Options::dumpCompiledRegExpPatterns())
-dataLog("Can't JIT this regular _expression_: \"", m_patternString, "\"\n");
-
m_state = ByteCode;
-m_regExpBytecode = byteCodeCompilePattern(vm, pattern);
+m_regExpBytecode = Yarr::byteCompile(pattern, &vm->m_regExpAllocator, &vm->m_regExpAllocatorLock);
}
int RegExp::match(VM& vm, const String& s, unsigned startOffset, Vector& ovector)
@@ -383,11 +356,8 @@
UNUSED_PARAM(charSize);
#endif
-if (Options::dumpCompiledRegExpPatterns())
-dataLog("Can't JIT this regular _expression_: \"", m_patternString, "\"\n");
-
m_state = ByteCode;
-m_regExpBytecode = byteCodeCompilePattern(vm, pattern);
+m_regExpBytecode = Yarr::byteCompile(pattern, &vm->m_regExpAllocator, &vm->m_regExpAllocatorLock);
}
MatchResult RegExp::match(VM& vm, const String& s, unsigned startOffset)
Modified: tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExp.h (225859 => 225860)
--- tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExp.h 2017-12-13 19:26:08 UTC (rev 225859)
+++ tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExp.h 2017-12-13 19:31:39 UTC (rev 225860)
@@ -140,8 +140,6 @@
RegExpState m_state;
-void byteCodeCompileIfNecessary(VM*);
-
void compile(VM*, Yarr::YarrCharSize);
void compileIfNecessary(VM&, Yarr::YarrCharSize);
Modified: tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExpInlines.h (225859 => 225860)
--- tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExpInlines.h 2017-12-13 19:26:08 UTC (rev 225859)
+++ tags/Safari-605.1.18/Source/_javascript_Core/runtime/RegExpInlines.h 2017-12-13 19:31:39 UTC (rev 225860)
@@ -110,25 +110,11 @@
int result;
#if ENABLE(YARR_JIT)
-#ifdef JIT_ALL_PARENS_EXPRESSIONS
-char patternContextBuffer[patternContextBufferSize];
-#define EXTRA_JIT_PARAMS , patternContextBuffer, patternContextBufferSize
-#else
-#define EXTRA_JIT_PARAMS
-#endif
-
if (m_state == JITCode) {
if (s.is8Bit())
-result = m_regExpJITCode.execute(s.characters8(), startOffset, s.length(), offsetVector EXTRA_JIT_PARAMS).start;
+result = m_regExpJITCode.execute(s.characters8(), startOffset, s.length(), offsetVector).start;
else
-result = m_regExpJITCode.execute(s.characters16()
[webkit-changes] [225859] trunk/Source/WebCore
Title: [225859] trunk/Source/WebCore
Revision 225859
Author simon.fra...@apple.com
Date 2017-12-13 11:26:08 -0800 (Wed, 13 Dec 2017)
Log Message
Fix crash under Document::visualUpdatesSuppressionTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=180758
Document::visualUpdatesSuppressionTimerFired
Reviewed by Zalan Bujtas.
Speculative fix for crash under visualUpdatesSuppressionTimerFired() where view()
can be null. Add null checks for the view() in all code called from this function.
* dom/Document.cpp:
(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::visualUpdatesSuppressionTimerFired):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (225858 => 225859)
--- trunk/Source/WebCore/ChangeLog 2017-12-13 19:24:47 UTC (rev 225858)
+++ trunk/Source/WebCore/ChangeLog 2017-12-13 19:26:08 UTC (rev 225859)
@@ -1,3 +1,18 @@
+2017-12-13 Simon Fraser
+
+Fix crash under Document::visualUpdatesSuppressionTimerFired()
+https://bugs.webkit.org/show_bug.cgi?id=180758
+Document::visualUpdatesSuppressionTimerFired
+
+Reviewed by Zalan Bujtas.
+
+Speculative fix for crash under visualUpdatesSuppressionTimerFired() where view()
+can be null. Add null checks for the view() in all code called from this function.
+
+* dom/Document.cpp:
+(WebCore::Document::setVisualUpdatesAllowed):
+(WebCore::Document::visualUpdatesSuppressionTimerFired):
+
2017-12-13 Zalan Bujtas
ASSERT(LayoutDisallowedScope::isLayoutAllowed()) whenever hitting Enter in Web Inspector console
Modified: trunk/Source/WebCore/dom/Document.cpp (225858 => 225859)
--- trunk/Source/WebCore/dom/Document.cpp 2017-12-13 19:24:47 UTC (rev 225858)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-12-13 19:26:08 UTC (rev 225859)
@@ -1234,7 +1234,7 @@
if (m_visualUpdatesSuppressionTimer.isActive()) {
ASSERT(!m_visualUpdatesAllowed);
-if (!view()->visualUpdatesAllowedByClient())
+if (view() && !view()->visualUpdatesAllowedByClient())
return;
setVisualUpdatesAllowed(true);
@@ -1272,8 +1272,8 @@
}
}
-if (view())
-view()->updateCompositingLayersAfterLayout();
+if (frameView)
+frameView->updateCompositingLayersAfterLayout();
if (RenderView* renderView = this->renderView())
renderView->repaintViewAndCompositedLayers();
@@ -1288,7 +1288,7 @@
// If the client is extending the visual update suppression period explicitly, the
// watchdog should not re-enable visual updates itself, but should wait for the client.
-if (!view()->visualUpdatesAllowedByClient())
+if (view() && !view()->visualUpdatesAllowedByClient())
return;
setVisualUpdatesAllowed(true);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225858] trunk/Source/WebKit
Title: [225858] trunk/Source/WebKit Revision 225858 Author bfulg...@apple.com Date 2017-12-13 11:24:47 -0800 (Wed, 13 Dec 2017) Log Message [iOS] Further Trim WebContent Process sandbox https://bugs.webkit.org/show_bug.cgi?id=180727 Reviewed by Eric Carlson. Take another pass over the contents of the file and remove addition items that don't have call sites in WebKit. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb Diff Modified: trunk/Source/WebKit/ChangeLog (225857 => 225858) --- trunk/Source/WebKit/ChangeLog 2017-12-13 19:22:14 UTC (rev 225857) +++ trunk/Source/WebKit/ChangeLog 2017-12-13 19:24:47 UTC (rev 225858) @@ -1,3 +1,16 @@ +2017-12-13 Brent Fulgham + +[iOS] Further Trim WebContent Process sandbox +https://bugs.webkit.org/show_bug.cgi?id=180727 + + +Reviewed by Eric Carlson. + +Take another pass over the contents of the file and remove addition items that +don't have call sites in WebKit. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: + 2017-12-13 Daniel Bates Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (225857 => 225858) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2017-12-13 19:22:14 UTC (rev 225857) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2017-12-13 19:24:47 UTC (rev 225858) @@ -60,15 +60,6 @@ (global-name "com.apple.UIKit.KeyboardManagement") (global-name "com.apple.UIKit.KeyboardManagement.hosted")) -;; For Allow UIKit-based apps to access com.apple.remote-text-editing mach service -;; and REM: Allow UIKit-based apps to access com.apple.remote-input-limiting mach service -(when tv? -(allow mach-lookup -(global-name "com.apple.remote-input-limiting") -(global-name "com.apple.remote-text-editing") -(global-name "com.apple.remote-text-editing-legacy") -(global-name "com.apple.sharing.remote-text-editing"))) - ;; TextInput framework (allow mach-lookup (global-name "com.apple.TextInput") @@ -135,10 +126,6 @@ (allow-well-known-system-group-container-literal-read "/systemgroup.com.apple.nsurlstoragedresources/Library/dafsaData.bin") -;; AirPlay -(allow mach-lookup -(global-name "com.apple.airplaydiagnostics.server")) - ;; Access the keyboards (allow file-read* (home-subpath "/Library/Caches/com.apple.keyboards")) @@ -152,33 +139,12 @@ ;; (allow mach-lookup (xpc-service-name-regex #"\.viewservice$")) -;; DataDetectors -> CallKit so user can place calls by tapping on phone numbers. -(allow mach-lookup -(global-name "com.apple.callkit.callcontrollerhost")) - -;; DataDetectors; update CoreRecents with recently-detected addresses, etc. -(allow mach-lookup -(xpc-service-name "com.apple.datadetectors.AddToRecentsService")) - -;; -(nano-preferences-read ".GlobalPreferences") - (mobile-preferences-read -; To determine whether the dictation opt-in alert should be suppressed. -"com.apple.assistant.backedup" -; Keyboard Dictation reads the list of supported languages from com.apple.assistant.support.plist. -; And Dictation checks whether Assistant is enabled by reading the same plist. -; com.apple.assistant.support preference domain needs to be unsandboxed -"com.apple.assistant.support" "com.apple.EmojiPreferences" -; For CarPlay screen aspect ratio (rdar://problem/20062770). -"com.apple.iapd" ; com.apple.InputModePreferences "com.apple.InputModePreferences" ; Weather(1038) deny file-read-data ~/Library/Preferences/com.apple.keyboard.plist "com.apple.keyboard" -; Spotlight suggestions in Lookup preference should be readable by any process -"com.apple.lookup.shared" ; "com.apple.Preferences") @@ -186,17 +152,6 @@ (allow file-read* (home-subpath "/Library/Fonts")) -;; , , -(allow mach-lookup -(global-name "com.apple.assistant.analytics") -(global-name "com.apple.assistant.dictation") -(global-name "com.apple.dictationd.recognition")) - -;; For copy-and-paste. -(allow mach-lookup -(global-name "com.apple.UIKit.pasteboardd") -(global-name "com.apple.pasteboard.pasted")) - ;; LaunchServices app icons (allow file-read* (well-known-system-group-container-subpath "/systemgroup.com.apple.lsd.iconscache")) @@ -207,12 +162,9 @@ (allow mach-lookup (global-name "com.apple.CARenderServer") (global-name "com.apple.KeyboardServices.TextReplacementService") -(global-name "com.apple.UIKit.statusbarserver") -(global-name "com.apple.uikit.GestureServer") (global-name "com.apple.assertiond.applicationstateconnection")
[webkit-changes] [225857] trunk
Title: [225857] trunk
Revision 225857
Author mark@apple.com
Date 2017-12-13 11:22:14 -0800 (Wed, 13 Dec 2017)
Log Message
Fill out some Poisoned APIs, fix some bugs, and add some tests.
https://bugs.webkit.org/show_bug.cgi?id=180724
Reviewed by JF Bastien.
Source/_javascript_Core:
* runtime/StructureTransitionTable.h:
Source/WTF:
Also rename Int32Poisoned to ConstExprPoisoned. The key it takes is actually a
uint32_t. So, Int32 is really a misnomer. In addition, the key needs to be a
constexpr. So, ConstExprPoisoned is a better name for it.
* wtf/Poisoned.cpp:
(WTF::makePoison):
* wtf/Poisoned.h:
(WTF::PoisonedImplHelper::asReference):
(WTF::PoisonedImpl::PoisonedImpl):
(WTF::PoisonedImpl::clear):
(WTF::PoisonedImpl::operator* const):
(WTF::PoisonedImpl::operator-> const):
(WTF::PoisonedImpl::operator== const):
(WTF::PoisonedImpl::operator!= const):
(WTF::PoisonedImpl::operator< const):
(WTF::PoisonedImpl::operator<= const):
(WTF::PoisonedImpl::operator> const):
(WTF::PoisonedImpl::operator>= const):
(WTF::PoisonedImpl::operator=):
(WTF::PoisonedImpl::swap):
(WTF::PoisonedImpl::exchange):
(WTF::swap):
(WTF::makePoison):
(WTF::PoisonedImpl::operator==): Deleted.
Tools:
* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Added.
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/Poisoned.cpp: Added.
(TestWebKitAPI::initializeTestPoison):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/StructureTransitionTable.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Poisoned.cpp
trunk/Source/WTF/wtf/Poisoned.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/CMakeLists.txt
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
Added Paths
trunk/Tools/TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/Poisoned.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (225856 => 225857)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-13 19:04:04 UTC (rev 225856)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-13 19:22:14 UTC (rev 225857)
@@ -1,3 +1,13 @@
+2017-12-13 Mark Lam
+
+Fill out some Poisoned APIs, fix some bugs, and add some tests.
+https://bugs.webkit.org/show_bug.cgi?id=180724
+
+
+Reviewed by JF Bastien.
+
+* runtime/StructureTransitionTable.h:
+
2017-12-13 Caio Lima
[ESNext][BigInt] Breking tests on Debug build and 32-bits due to missing Exception check
Modified: trunk/Source/_javascript_Core/runtime/StructureTransitionTable.h (225856 => 225857)
--- trunk/Source/_javascript_Core/runtime/StructureTransitionTable.h 2017-12-13 19:04:04 UTC (rev 225856)
+++ trunk/Source/_javascript_Core/runtime/StructureTransitionTable.h 2017-12-13 19:22:14 UTC (rev 225857)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2008, 2009, 2013 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2017 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -187,8 +187,8 @@
private:
friend class SingleSlotTransitionWeakOwner;
-using PoisonedTransitionMapPtr = Int32Poisoned;
-using PoisonedWeakImplPtr = Int32Poisoned;
+using PoisonedTransitionMapPtr = ConstExprPoisoned;
+using PoisonedWeakImplPtr = ConstExprPoisoned;
bool isUsingSingleSlot() const
{
Modified: trunk/Source/WTF/ChangeLog (225856 => 225857)
--- trunk/Source/WTF/ChangeLog 2017-12-13 19:04:04 UTC (rev 225856)
+++ trunk/Source/WTF/ChangeLog 2017-12-13 19:22:14 UTC (rev 225857)
@@ -1,3 +1,36 @@
+2017-12-13 Mark Lam
+
+Fill out some Poisoned APIs, fix some bugs, and add some tests.
+https://bugs.webkit.org/show_bug.cgi?id=180724
+
+
+Reviewed by JF Bastien.
+
+Also rename Int32Poisoned to ConstExprPoisoned. The key it takes is actually a
+uint32_t. So, Int32 is really a misnomer. In addition, the key needs to be a
+constexpr. So, ConstExprPoisoned is a better name for it.
+
+* wtf/Poisoned.cpp:
+(WTF::makePoison):
+* wtf/Poisoned.h:
+(WTF::PoisonedImplHelper::asReference):
+(WTF::PoisonedImpl::PoisonedImpl):
+(WTF::PoisonedImpl::clear):
+(WTF::PoisonedImpl::operator* const):
+(WTF::PoisonedImpl::operator-> const):
+(WTF::PoisonedImpl::operator== const):
+(WTF::PoisonedImpl::operator!= const):
+(WTF::PoisonedImpl::operator< const):
+(WTF::PoisonedImpl::operator<= const):
+(WTF::PoisonedImpl::operator> const):
+(WTF::PoisonedImpl::operator>= const):
+(WTF::PoisonedImpl::operator=):
+(WTF::PoisonedImpl::swap):
+(WTF::PoisonedImpl::exchange):
+(WTF::swap):
+(WTF::makePoison):
+(WTF::PoisonedImpl::operator==): Delet
[webkit-changes] [225856] trunk/Tools
Title: [225856] trunk/Tools Revision 225856 Author jbed...@apple.com Date 2017-12-13 11:04:04 -0800 (Wed, 13 Dec 2017) Log Message webkitpy: Better name-version mapping (Part 2) https://bugs.webkit.org/show_bug.cgi?id=179621 Reviewed by David Kilzer. Now that we have a central mapping of version numbers to version names, this mapping should be used to compute version names. This patch treats passes versions as objects, only mapping them to names when strings are needed. * Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo.__init__): Store os_version as a version object instead of a string. (PlatformInfo.os_version_name): Convert os_version to a string through the VersionNameMap. * Scripts/webkitpy/common/system/platforminfo_mock.py: (MockPlatformInfo.__init__): Store os_version as a version object. (MockPlatformInfo.os_version_name): Mirror PlatformInfo. * Scripts/webkitpy/common/system/platforminfo_unittest.py: (TestPlatformInfo.test_real_code): Only Mac and Windows have defined version objects. (TestPlatformInfo.test_os_version): Deleted, this behavior is now managed by VersionNameMap. * Scripts/webkitpy/common/version.py: (Version.__cmp__): Allow a version object to be compared with 'None'. * Scripts/webkitpy/common/version_name_map.py: (VersionNameMap.map): Check for the apple_additions VersionNameMap. (VersionNameMap.__init__): Add a wincairo mapping, the same as the win mapping. * Scripts/webkitpy/common/version_unittest.py: (VersionTestCase.test_compare_versions): Test comparing a version object to 'None'. * Scripts/webkitpy/layout_tests/models/test_configuration.py: (TestConfiguration.__init__): Strip formatting from version name. Note that this object still accepts a string because the version string implicitly contains the platform as well. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Win7 should be 7SP0 as it is in the VersionNameMap. * Scripts/webkitpy/port/apple.py: (ApplePort): Replace VERSION_FALLBACK_ORDER with a minimum and maximum version. This is required because it may be the case that scripts are aware of more versions than the port actually supports. (ApplePort.determine_full_port_name): Use the host operating system to compute the full port name. (ApplePort._allowed_versions): Return a list of valid port versions by iterating through the VersionNameMap. (ApplePort._generate_all_test_configurations): Compute a list of configurations by iterating through _allowed_versions and converting each version to a string. (ApplePort._apple_baseline_path): Return a layout test expectation directory inside apple_additions. (ApplePort._skipped_file_search_paths): Deleted. (ApplePort._allowed_port_names): Deleted. (ApplePort._future_port_name): Deleted. * Scripts/webkitpy/port/base.py: (Port.__init__): Replace _version string with _os_version object. (Port.version_name): Convert version object to string. (Port.test_configuration): Pass version string to TestConfiguration. (Port.version): Deleted. * Scripts/webkitpy/port/darwin_testcase.py: (DarwinTest.assert_name): Convert an os_version_string to a version object and construct a port. * Scripts/webkitpy/port/factory_unittest.py: (FactoryTest.test_mac): Replace version strings with version objects. (FactoryTest.test_win): Ditto. * Scripts/webkitpy/port/gtk.py: (GtkPort._generate_all_test_configurations): Replace _version with version_name(). * Scripts/webkitpy/port/ios.py: (IOSPort.version_name): Both Simulator and device share the same version-name convention. (IOSPort._generate_all_test_configurations): Replace _version with version_name(). (IOSPort.default_baseline_search_path): Use the internal mapping of version names to construct apple_additions expectations. (IOSPort._apple_additions_path): Deleted. * Scripts/webkitpy/port/ios_device.py: (IOSDevicePort.ios_version): Return None if no version is defined. * Scripts/webkitpy/port/ios_device_unittest.py: (IOSDeviceTest): (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Conform with the new mock apple_additions. (IOSDeviceTest.make_port): Deleted. * Scripts/webkitpy/port/ios_simulator.py: (IOSSimulatorPort._create_devices): Use Version object over list of version strings. * Scripts/webkitpy/port/ios_simulator_unittest.py: (IOSSimulatorTest): (IOSSimulatorTest.make_port): Use iOS 11 as the default version for testing. (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Conform with the new mock apple_additions. * Scripts/webkitpy/port/ios_testcase.py: (IOSTest.make_port): Use iOS 11 as the default version for testing. * Scripts/webkitpy/port/mac.py: (MacPort): (MacPort.__init__): Use Version object for _os_version. (MacPort.default_baseline_search_path): Use the internal mapping of version names to construct apple_additions expectations. (MacPort.configuration_specifier_macros): Automatically construct macros based on VersionNameMap. (MacPort._apple_additions_path): Deleted. * Scripts/webkitpy/port/mac_unittest.py: (
[webkit-changes] [225855] trunk/Source/WebCore
Title: [225855] trunk/Source/WebCore
Revision 225855
Author za...@apple.com
Date 2017-12-13 10:43:05 -0800 (Wed, 13 Dec 2017)
Log Message
ASSERT(LayoutDisallowedScope::isLayoutAllowed()) whenever hitting Enter in Web Inspector console
https://bugs.webkit.org/show_bug.cgi?id=180690
Reviewed by Simon Fraser.
Defer text replacement notification until after layout is done to avoid unexpected forced layouts.
Covered by existing tests.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::disableAccessibility):
(WebCore::AXObjectCache::remove):
(WebCore::filterMapForRemoval):
(WebCore::filterListForRemoval):
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferTextReplacementNotificationForTextControl):
(WebCore::filterForRemoval): Deleted.
* accessibility/AXObjectCache.h: Need to use the base (Element) class since
we can't call is in Node d'tor.
(WebCore::AXObjectCache::deferTextReplacementNotificationForTextControl):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (225854 => 225855)
--- trunk/Source/WebCore/ChangeLog 2017-12-13 18:36:26 UTC (rev 225854)
+++ trunk/Source/WebCore/ChangeLog 2017-12-13 18:43:05 UTC (rev 225855)
@@ -1,3 +1,29 @@
+2017-12-13 Zalan Bujtas
+
+ASSERT(LayoutDisallowedScope::isLayoutAllowed()) whenever hitting Enter in Web Inspector console
+https://bugs.webkit.org/show_bug.cgi?id=180690
+
+Reviewed by Simon Fraser.
+
+Defer text replacement notification until after layout is done to avoid unexpected forced layouts.
+
+Covered by existing tests.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::disableAccessibility):
+(WebCore::AXObjectCache::remove):
+(WebCore::filterMapForRemoval):
+(WebCore::filterListForRemoval):
+(WebCore::AXObjectCache::prepareForDocumentDestruction):
+(WebCore::AXObjectCache::performDeferredCacheUpdate):
+(WebCore::AXObjectCache::deferTextReplacementNotificationForTextControl):
+(WebCore::filterForRemoval): Deleted.
+* accessibility/AXObjectCache.h: Need to use the base (Element) class since
+we can't call is in Node d'tor.
+(WebCore::AXObjectCache::deferTextReplacementNotificationForTextControl):
+* html/HTMLTextFormControlElement.cpp:
+(WebCore::HTMLTextFormControlElement::setInnerTextValue):
+
2017-12-13 Ryan Haddad
Unreviewed, rolling out r225836.
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (225854 => 225855)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2017-12-13 18:36:26 UTC (rev 225854)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2017-12-13 18:43:05 UTC (rev 225855)
@@ -721,6 +721,7 @@
if (is(node)) {
m_deferredRecomputeIsIgnoredList.remove(downcast(&node));
m_deferredSelectedChildredChangedList.remove(downcast(&node));
+m_deferredTextFormControlValue.remove(downcast(&node));
}
m_deferredTextChangedList.remove(&node);
removeNodeForUse(node);
@@ -2725,8 +2726,19 @@
return result;
}
+template
+static void filterMapForRemoval(const HashMap& list, const Document& document, HashSet& nodesToRemove)
+{
+for (auto& entry : list) {
+auto* node = entry.key;
+if (node->isConnected() && &node->document() != &document)
+continue;
+nodesToRemove.add(node);
+}
+}
+
template
-static void filterForRemoval(const ListHashSet& list, const Document& document, HashSet& nodesToRemove)
+static void filterListForRemoval(const ListHashSet& list, const Document& document, HashSet& nodesToRemove)
{
for (auto* node : list) {
if (node->isConnected() && &node->document() != &document)
@@ -2738,11 +2750,12 @@
void AXObjectCache::prepareForDocumentDestruction(const Document& document)
{
HashSet nodesToRemove;
-filterForRemoval(m_textMarkerNodes, document, nodesToRemove);
-filterForRemoval(m_modalNodesSet, document, nodesToRemove);
-filterForRemoval(m_deferredRecomputeIsIgnoredList, document, nodesToRemove);
-filterForRemoval(m_deferredTextChangedList, document, nodesToRemove);
-filterForRemoval(m_deferredSelectedChildredChangedList, document, nodesToRemove);
+filterListForRemoval(m_textMarkerNodes, document, nodesToRemove);
+filterListForRemoval(m_modalNodesSet, document, nodesToRemove);
+filterListForRemoval(m_deferredRecomputeIsIgnoredList, document, nodesToRemove);
+filterListForRemoval(m_deferredTextChangedList, document, nodesToRemove);
+filterListForRemoval(m_deferredSelectedChildredChange
[webkit-changes] [225854] trunk/Source/WebCore
Title: [225854] trunk/Source/WebCore
Revision 225854
Author ryanhad...@apple.com
Date 2017-12-13 10:36:26 -0800 (Wed, 13 Dec 2017)
Log Message
Unreviewed, rolling out r225836.
Broke the Windows build.
Reverted changeset:
"Unify some WebGL sources"
https://bugs.webkit.org/show_bug.cgi?id=180726
https://trac.webkit.org/changeset/225836
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (225853 => 225854)
--- trunk/Source/WebCore/ChangeLog 2017-12-13 18:35:14 UTC (rev 225853)
+++ trunk/Source/WebCore/ChangeLog 2017-12-13 18:36:26 UTC (rev 225854)
@@ -1,3 +1,15 @@
+2017-12-13 Ryan Haddad
+
+Unreviewed, rolling out r225836.
+
+Broke the Windows build.
+
+Reverted changeset:
+
+"Unify some WebGL sources"
+https://bugs.webkit.org/show_bug.cgi?id=180726
+https://trac.webkit.org/changeset/225836
+
2017-12-13 Andy Estes
[Payment Request] Remove ApplePayPaymentMethodUpdateEvent and use PaymentDetailsModifiers instead
Modified: trunk/Source/WebCore/Sources.txt (225853 => 225854)
--- trunk/Source/WebCore/Sources.txt 2017-12-13 18:35:14 UTC (rev 225853)
+++ trunk/Source/WebCore/Sources.txt 2017-12-13 18:36:26 UTC (rev 225854)
@@ -1054,7 +1054,6 @@
html/ValidationMessage.cpp
html/WeekInputType.cpp
-html/canvas/ANGLEInstancedArrays.cpp
html/canvas/CanvasGradient.cpp
html/canvas/CanvasPath.cpp
html/canvas/CanvasPattern.cpp
@@ -1063,48 +1062,9 @@
html/canvas/CanvasRenderingContext2DBase.cpp
html/canvas/CanvasStyle.cpp
html/canvas/ImageBitmapRenderingContext.cpp
-html/canvas/OESElementIndexUint.cpp
-html/canvas/OESStandardDerivatives.cpp
-html/canvas/OESTextureFloat.cpp
-html/canvas/OESTextureFloatLinear.cpp
-html/canvas/OESTextureHalfFloat.cpp
-html/canvas/OESTextureHalfFloatLinear.cpp
-html/canvas/OESVertexArrayObject.cpp
html/canvas/OffscreenCanvasRenderingContext2D.cpp
html/canvas/Path2D.cpp
html/canvas/PlaceholderRenderingContext.cpp
-html/canvas/WebGL2RenderingContext.cpp
-html/canvas/WebGLBuffer.cpp
-html/canvas/WebGLCompressedTextureATC.cpp
-html/canvas/WebGLCompressedTexturePVRTC.cpp
-html/canvas/WebGLCompressedTextureS3TC.cpp
-html/canvas/WebGLContextEvent.cpp
-html/canvas/WebGLContextGroup.cpp
-html/canvas/WebGLContextObject.cpp
-html/canvas/WebGLDebugRendererInfo.cpp
-html/canvas/WebGLDebugShaders.cpp
-html/canvas/WebGLDepthTexture.cpp
-html/canvas/WebGLDrawBuffers.cpp
-html/canvas/WebGLExtension.cpp
-html/canvas/WebGLFramebuffer.cpp
-html/canvas/WebGLLoseContext.cpp
-html/canvas/WebGLObject.cpp
-html/canvas/WebGLProgram.cpp
-html/canvas/WebGLQuery.cpp
-html/canvas/WebGLRenderbuffer.cpp
-html/canvas/WebGLRenderingContext.cpp
-html/canvas/WebGLRenderingContextBase.cpp
-html/canvas/WebGLSampler.cpp
-html/canvas/WebGLShader.cpp
-html/canvas/WebGLShaderPrecisionFormat.cpp
-html/canvas/WebGLSharedObject.cpp
-html/canvas/WebGLSync.cpp
-html/canvas/WebGLTexture.cpp
-html/canvas/WebGLTransformFeedback.cpp
-html/canvas/WebGLUniformLocation.cpp
-html/canvas/WebGLVertexArrayObject.cpp
-html/canvas/WebGLVertexArrayObjectBase.cpp
-html/canvas/WebGLVertexArrayObjectOES.cpp
html/canvas/WebGPUBuffer.cpp
html/canvas/WebGPUCommandBuffer.cpp
html/canvas/WebGPUCommandQueue.cpp
@@ -1538,7 +1498,6 @@
platform/encryptedmedia/CDMFactory.cpp
-platform/graphics/ANGLEWebKitBridge.cpp
platform/graphics/BitmapImage.cpp
platform/graphics/Color.cpp
platform/graphics/ColorUtilities.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (225853 => 225854)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-12-13 18:35:14 UTC (rev 225853)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-12-13 18:36:26 UTC (rev 225854)
@@ -52,8 +52,11 @@
00B9318813BA8DBA0035A948 /* XMLDocumentParser.h in Headers */ = {isa = PBXBuildFile; fileRef = 00B9318213BA867F0035A948 /* XMLDocumentParser.h */; };
00B9318C13BA8DCC0035A948 /* XMLDocumentParserScope.h in Headers */ = {isa = PBXBuildFile; fileRef = 00B9318613BA867F0035A948 /* XMLDocumentParserScope.h */; };
00C60E3F13D76D7E0092A275 /* MarkupTokenizerInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = 00C60E3E13D76D7E0092A275 /* MarkupTokenizerInlines.h */; };
+ 01D3CF8214BD0A3000FE9970 /* WebGLContextGroup.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 01D3CF7C14BD0A3000FE9970 /* WebGLContextGroup.cpp */; };
01D3CF8314BD0A3000FE9970 /* WebGLContextGroup.h in Headers */ = {isa = PBXBuildFile; fileRef = 01D3CF7D14BD0A3000FE9970 /* WebGLContextGroup.h */; };
+ 01D3CF8414BD0A3000FE9970 /* WebGLContextObject.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 01D3CF7E14BD0A3000FE9970 /* WebGLContextObject.cpp */; };
01D3CF8514BD0A3000FE9970 /* WebGLContextObject.h in Headers */ = {isa = PBXBuildFile; fileRef = 01D3CF7F14BD0A3000FE9970 /* WebGLContext
[webkit-changes] [225853] trunk/Source/WebKit
Title: [225853] trunk/Source/WebKit
Revision 225853
Author dba...@webkit.org
Date 2017-12-13 10:35:14 -0800 (Wed, 13 Dec 2017)
Log Message
Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list
https://bugs.webkit.org/show_bug.cgi?id=180754
Reviewed by Wenson Hsieh.
Group all in-parameters in the signature of API::FormClient::willBeginInputSession() at
the front of the parameter list instead of interspersing in- and out- parameters.
No functionality changed. So, no new tests.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
* WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:
(API::InjectedBundle::FormClient::willBeginInputSession):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::elementDidFocus):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm
trunk/Source/WebKit/WebProcess/InjectedBundle/APIInjectedBundleFormClient.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (225852 => 225853)
--- trunk/Source/WebKit/ChangeLog 2017-12-13 18:26:41 UTC (rev 225852)
+++ trunk/Source/WebKit/ChangeLog 2017-12-13 18:35:14 UTC (rev 225853)
@@ -1,3 +1,22 @@
+2017-12-13 Daniel Bates
+
+Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list
+https://bugs.webkit.org/show_bug.cgi?id=180754
+
+Reviewed by Wenson Hsieh.
+
+Group all in-parameters in the signature of API::FormClient::willBeginInputSession() at
+the front of the parameter list instead of interspersing in- and out- parameters.
+
+No functionality changed. So, no new tests.
+
+* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
+(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):
+* WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:
+(API::InjectedBundle::FormClient::willBeginInputSession):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::elementDidFocus):
+
2017-12-13 Chris Dumez
[iOS] Take process assertion to prevent the service worker process from getting suspended
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm (225852 => 225853)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm 2017-12-13 18:26:41 UTC (rev 225852)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm 2017-12-13 18:35:14 UTC (rev 225853)
@@ -528,7 +528,7 @@
[formDelegate _webProcessPlugInBrowserContextController:m_controller textDidChangeInTextField:wrapper(*WebKit::InjectedBundleNodeHandle::getOrCreate(inputElement)) inFrame:wrapper(*frame) initiatedByUserTyping:initiatedByUserTyping];
}
-void willBeginInputSession(WebPage*, Element* element, WebFrame* frame, RefPtr& userData, bool userIsInteracting) override
+void willBeginInputSession(WebPage*, Element* element, WebFrame* frame, bool userIsInteracting, RefPtr& userData) override
{
auto formDelegate = m_controller->_formDelegate.get();
Modified: trunk/Source/WebKit/WebProcess/InjectedBundle/APIInjectedBundleFormClient.h (225852 => 225853)
--- trunk/Source/WebKit/WebProcess/InjectedBundle/APIInjectedBundleFormClient.h 2017-12-13 18:26:41 UTC (rev 225852)
+++ trunk/Source/WebKit/WebProcess/InjectedBundle/APIInjectedBundleFormClient.h 2017-12-13 18:35:14 UTC (rev 225853)
@@ -71,7 +71,7 @@
virtual void willSendSubmitEvent(WebKit::WebPage*, WebCore::HTMLFormElement*, WebKit::WebFrame*, WebKit::WebFrame*, const Vector>&) { }
virtual void didAssociateFormControls(WebKit::WebPage*, const Vector>&) { }
virtual bool shouldNotifyOnFormChanges(WebKit::WebPage*) { return false; }
-virtual void willBeginInputSession(WebKit::WebPage*, WebCore::Element*, WebKit::WebFrame*, RefPtr& userData, bool userIsInteracting) { UNUSED_PARAM(userData); }
+virtual void willBeginInputSession(WebKit::WebPage*, WebCore::Element*, WebKit::WebFrame*, bool userIsInteracting, RefPtr& userData) { UNUSED_PARAM(userData); }
};
} // namespace InjectedBundle
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (225852 => 225853)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2017-12-13 18:26:41 UTC (rev 225852)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2017-12-13 18:35:14 UTC (rev 225853)
@@ -4857,7 +4857,7 @@
getAssistedNodeInformation(information);
RefPtr userData;
-m_formClient->willBeginInputSession(this, downcast(node), WebFrame::fromCoreFrame(*node->document().frame()), userData, m_userIsInteracting);
+m_formClient->willBeginInp
[webkit-changes] [225852] trunk/LayoutTests
Title: [225852] trunk/LayoutTests Revision 225852 Author jlew...@apple.com Date 2017-12-13 10:26:41 -0800 (Wed, 13 Dec 2017) Log Message Updated Expectations for http/tests/cache/disk-cache/disk-cache-204-status-code.html https://bugs.webkit.org/show_bug.cgi?id=162685 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (225851 => 225852) --- trunk/LayoutTests/ChangeLog 2017-12-13 18:20:53 UTC (rev 225851) +++ trunk/LayoutTests/ChangeLog 2017-12-13 18:26:41 UTC (rev 225852) @@ -1,3 +1,12 @@ +2017-12-13 Matt Lewis + +Updated Expectations for http/tests/cache/disk-cache/disk-cache-204-status-code.html +https://bugs.webkit.org/show_bug.cgi?id=162685 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2017-12-13 Andy Estes [Payment Request] Remove ApplePayPaymentMethodUpdateEvent and use PaymentDetailsModifiers instead Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (225851 => 225852) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-12-13 18:20:53 UTC (rev 225851) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2017-12-13 18:26:41 UTC (rev 225852) @@ -639,7 +639,7 @@ webkit.org/b/161926 storage/indexeddb/index-cursor.html [ Pass Timeout ] -webkit.org/b/162685 [ Debug ] http/tests/cache/disk-cache/disk-cache-204-status-code.html [ Pass Failure ] +webkit.org/b/162685 http/tests/cache/disk-cache/disk-cache-204-status-code.html [ Pass Failure ] webkit.org/b/161649 [ Debug ] http/tests/cache/disk-cache/resource-becomes-uncacheable.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225850] trunk/Source/WebKit
Title: [225850] trunk/Source/WebKit
Revision 225850
Author cdu...@apple.com
Date 2017-12-13 10:13:47 -0800 (Wed, 13 Dec 2017)
Log Message
[iOS] Take process assertion to prevent the service worker process from getting suspended
https://bugs.webkit.org/show_bug.cgi?id=180735
Reviewed by Brady Eidson.
Take process assertion to prevent the service worker process from getting suspended while
it is still needed. We use the same policy as for the network process, meaning that
unsuspended WebContent processes prevent the service worker process from getting suspended.
This patch still does not enable service workers on iOS. The demo at https://mdn.github.io/sw-test/
appears to work. However, things are not working as expected for mobile.twitter.com where I
see the fetches intercepted by the service worker fail when offline for some reason (unrelated
to process suspension).
* UIProcess/WebProcessPool.cpp:
(WebKit::m_foregroundWebProcessCounter):
(WebKit::m_backgroundWebProcessCounter):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::updateProcessAssertions):
(WebKit::WebProcessPool::reinstateNetworkProcessAssertionState):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didSetAssertionState):
* UIProcess/WebProcessProxy.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Source/WebKit/UIProcess/WebProcessPool.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (225849 => 225850)
--- trunk/Source/WebKit/ChangeLog 2017-12-13 18:02:28 UTC (rev 225849)
+++ trunk/Source/WebKit/ChangeLog 2017-12-13 18:13:47 UTC (rev 225850)
@@ -1,3 +1,32 @@
+2017-12-13 Chris Dumez
+
+[iOS] Take process assertion to prevent the service worker process from getting suspended
+https://bugs.webkit.org/show_bug.cgi?id=180735
+
+Reviewed by Brady Eidson.
+
+Take process assertion to prevent the service worker process from getting suspended while
+it is still needed. We use the same policy as for the network process, meaning that
+unsuspended WebContent processes prevent the service worker process from getting suspended.
+
+This patch still does not enable service workers on iOS. The demo at https://mdn.github.io/sw-test/
+appears to work. However, things are not working as expected for mobile.twitter.com where I
+see the fetches intercepted by the service worker fail when offline for some reason (unrelated
+to process suspension).
+
+* UIProcess/WebProcessPool.cpp:
+(WebKit::m_foregroundWebProcessCounter):
+(WebKit::m_backgroundWebProcessCounter):
+(WebKit::WebProcessPool::ensureNetworkProcess):
+(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):
+(WebKit::WebProcessPool::disconnectProcess):
+(WebKit::WebProcessPool::updateProcessAssertions):
+(WebKit::WebProcessPool::reinstateNetworkProcessAssertionState):
+* UIProcess/WebProcessPool.h:
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::didSetAssertionState):
+* UIProcess/WebProcessProxy.h:
+
2017-12-13 Carlos Garcia Campos
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release.
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (225849 => 225850)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-12-13 18:02:28 UTC (rev 225849)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2017-12-13 18:13:47 UTC (rev 225850)
@@ -234,6 +234,10 @@
, m_hiddenPageThrottlingAutoIncreasesCounter([this](RefCounterEvent) { m_hiddenPageThrottlingTimer.startOneShot(0_s); })
, m_hiddenPageThrottlingTimer(RunLoop::main(), this, &WebProcessPool::updateHiddenPageThrottlingAutoIncreaseLimit)
, m_serviceWorkerProcessTerminationTimer(RunLoop::main(), this, &WebProcessPool::terminateServiceWorkerProcess)
+#if PLATFORM(IOS)
+, m_foregroundWebProcessCounter([this](RefCounterEvent) { updateProcessAssertions(); })
+, m_backgroundWebProcessCounter([this](RefCounterEvent) { updateProcessAssertions(); })
+#endif
{
if (m_configuration->shouldHaveLegacyDataStore())
m_websiteDataStore = API::WebsiteDataStore::createLegacy(legacyWebsiteDataStoreConfiguration(m_configuration));
@@ -486,8 +490,7 @@
if (m_didNetworkProcessCrash) {
m_didNetworkProcessCrash = false;
-for (auto& process : m_processes)
-process->reinstateNetworkProcessAssertionState(*m_networkProcess);
+reinstateNetworkProcessAssertionState(*m_networkProcess);
if (m_websiteDataStore)
m_websiteDataStore->websiteDataStore().networkProcessDidCrash();
}
@@ -598,6 +601,7
[webkit-changes] [225849] trunk
Title: [225849] trunk Revision 225849 Author aes...@apple.com Date 2017-12-13 10:02:28 -0800 (Wed, 13 Dec 2017) Log Message [Payment Request] Remove ApplePayPaymentMethodUpdateEvent and use PaymentDetailsModifiers instead https://bugs.webkit.org/show_bug.cgi?id=180737 Reviewed by Brady Eidson. Source/WebCore: Instead of firing a non-standard "applepaypaymentmethodupdate" event when the payment method changes, use the PaymentDetailsModifier mechanism to allow the merchant to specify override totals and additional display items per payment method type. Test: http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https.html * DerivedSources.make: * Modules/applepay/ApplePayLineItem.idl: * Modules/applepay/ApplePayPaymentMethod.h: * Modules/applepay/ApplePayPaymentMethod.idl: * Modules/applepay/ApplePayPaymentMethodType.h: Added. * Modules/applepay/ApplePayPaymentMethodType.idl: Added. * Modules/applepay/cocoa/PaymentMethodCocoa.mm: * Modules/applepay/paymentrequest/ApplePayModifier.h: Added. * Modules/applepay/paymentrequest/ApplePayModifier.idl: Added. * Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp: (WebCore::ApplePayPaymentHandler::show): (WebCore::ApplePayPaymentHandler::computeTotalAndLineItems): (WebCore::ApplePayPaymentHandler::detailsUpdated): (WebCore::ApplePayPaymentHandler::shippingAddressUpdated): (WebCore::ApplePayPaymentHandler::shippingOptionUpdated): (WebCore::ApplePayPaymentHandler::paymentMethodUpdated): (WebCore::ApplePayPaymentHandler::didSelectPaymentMethod): * Modules/applepay/paymentrequest/ApplePayPaymentHandler.h: * Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.cpp: Removed. * Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.h: Removed. * Modules/paymentrequest/PaymentRequest.h: * Modules/paymentrequest/PaymentRequest.idl: * WebCore.xcodeproj/project.pbxproj: * dom/EventNames.h: * dom/EventNames.in: * testing/MockPaymentCoordinator.cpp: (WebCore::convert): (WebCore::MockPaymentCoordinator::updateTotalAndLineItems): (WebCore::MockPaymentCoordinator::completeShippingMethodSelection): (WebCore::MockPaymentCoordinator::completeShippingContactSelection): (WebCore::MockPaymentCoordinator::completePaymentMethodSelection): * testing/MockPaymentCoordinator.h: * testing/MockPaymentCoordinator.idl: LayoutTests: * http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https-expected.txt: Added. * http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https.html: Added. * http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https-expected.txt: Removed. * http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/Modules/applepay/ApplePayLineItem.idl trunk/Source/WebCore/Modules/applepay/ApplePayPaymentMethod.h trunk/Source/WebCore/Modules/applepay/ApplePayPaymentMethod.idl trunk/Source/WebCore/Modules/applepay/cocoa/PaymentMethodCocoa.mm trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.h trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.h trunk/Source/WebCore/Modules/paymentrequest/PaymentRequest.idl trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/EventNames.h trunk/Source/WebCore/dom/EventNames.in trunk/Source/WebCore/testing/MockPaymentCoordinator.cpp trunk/Source/WebCore/testing/MockPaymentCoordinator.h trunk/Source/WebCore/testing/MockPaymentCoordinator.idl Added Paths trunk/LayoutTests/http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https-expected.txt trunk/LayoutTests/http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https.html trunk/Source/WebCore/Modules/applepay/ApplePayPaymentMethodType.h trunk/Source/WebCore/Modules/applepay/ApplePayPaymentMethodType.idl trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.h trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayModifier.idl Removed Paths trunk/LayoutTests/http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https-expected.txt trunk/LayoutTests/http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https.html trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.cpp trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.h trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.idl Diff Modified: trunk/LayoutTests/ChangeLog (225848 => 225849) --- trunk/LayoutTests/ChangeLog 2017-12-13 17:57:29 UTC (rev 225848) +++ trunk/LayoutTests/ChangeLog 2017-12-13 18:02:28 UTC (rev 225849) @@ -1,3 +1,16 @@ +2017-12-13 Andy Estes + +[Payment Request] Remove ApplePayPaymentMethodUpdateEvent and use PaymentDetailsModifiers instead +https://bugs.webkit.org/show_bug.cgi?id=180737 + + +Reviewed by Brady Eidson
[webkit-changes] [225848] trunk/LayoutTests
Title: [225848] trunk/LayoutTests Revision 225848 Author jlew...@apple.com Date 2017-12-13 09:57:29 -0800 (Wed, 13 Dec 2017) Log Message Added missing expectation file for fast/text/user-installed-fonts/shadow-postscript-family.html https://bugs.webkit.org/show_bug.cgi?id=180062 Unreviewed test gardening. * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (225847 => 225848) --- trunk/LayoutTests/ChangeLog 2017-12-13 17:37:31 UTC (rev 225847) +++ trunk/LayoutTests/ChangeLog 2017-12-13 17:57:29 UTC (rev 225848) @@ -1,3 +1,12 @@ +2017-12-13 Matt Lewis + +Added missing expectation file for fast/text/user-installed-fonts/shadow-postscript-family.html +https://bugs.webkit.org/show_bug.cgi?id=180062 + +Unreviewed test gardening. + +* platform/ios/TestExpectations: + 2017-12-13 Ms2ger [GTK][WPE] Test gardening Modified: trunk/LayoutTests/platform/ios/TestExpectations (225847 => 225848) --- trunk/LayoutTests/platform/ios/TestExpectations 2017-12-13 17:37:31 UTC (rev 225847) +++ trunk/LayoutTests/platform/ios/TestExpectations 2017-12-13 17:57:29 UTC (rev 225848) @@ -3314,3 +3314,4 @@ webkit.org/b/180062 fast/text/user-installed-fonts/shadow-family.html [ ImageOnlyFailure ] webkit.org/b/180062 fast/text/user-installed-fonts/shadow-postscript.html [ ImageOnlyFailure ] webkit.org/b/180062 fast/text/user-installed-fonts/shadow.html [ ImageOnlyFailure ] +webkit.org/b/180062 fast/text/user-installed-fonts/shadow-postscript-family.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225847] tags/Safari-605.1.18/
Title: [225847] tags/Safari-605.1.18/ Revision 225847 Author jmarc...@apple.com Date 2017-12-13 09:37:31 -0800 (Wed, 13 Dec 2017) Log Message Tag Safari-605.1.18. Added Paths tags/Safari-605.1.18/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225845] trunk
Title: [225845] trunk
Revision 225845
Author sbar...@apple.com
Date 2017-12-13 09:29:21 -0800 (Wed, 13 Dec 2017)
Log Message
Fix how JSFunction handles "caller" and "arguments" for functions that don't have those properties
https://bugs.webkit.org/show_bug.cgi?id=163579
Reviewed by Mark Lam.
JSTests:
* stress/caller-and-arguments-properties-for-functions-that-dont-have-them.js: Added.
(assert):
(test1):
(i.test1):
(i.test1.C):
(i.test1.async.foo):
(i.test1.foo):
(test2):
Source/_javascript_Core:
Some functions in _javascript_ do not have the "caller" and "arguments" properties.
For example, strict functions do not. When reading our code that dealt with these
types of functions, it was simply all wrong. We were doing weird things depending
on the method table hook. This patch fixes this by doing what we should've been
doing all along: when the JSFunction does not own the "caller"/"arguments" property,
it should defer to its base class implementation for the various method table hooks.
* runtime/JSFunction.cpp:
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
Added Paths
trunk/JSTests/stress/caller-and-arguments-properties-for-functions-that-dont-have-them.js
Diff
Modified: trunk/JSTests/ChangeLog (225844 => 225845)
--- trunk/JSTests/ChangeLog 2017-12-13 17:19:24 UTC (rev 225844)
+++ trunk/JSTests/ChangeLog 2017-12-13 17:29:21 UTC (rev 225845)
@@ -1,5 +1,22 @@
2017-12-13 Saam Barati
+Fix how JSFunction handles "caller" and "arguments" for functions that don't have those properties
+https://bugs.webkit.org/show_bug.cgi?id=163579
+
+
+Reviewed by Mark Lam.
+
+* stress/caller-and-arguments-properties-for-functions-that-dont-have-them.js: Added.
+(assert):
+(test1):
+(i.test1):
+(i.test1.C):
+(i.test1.async.foo):
+(i.test1.foo):
+(test2):
+
+2017-12-13 Saam Barati
+
TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this|
https://bugs.webkit.org/show_bug.cgi?id=180734
Added: trunk/JSTests/stress/caller-and-arguments-properties-for-functions-that-dont-have-them.js (0 => 225845)
--- trunk/JSTests/stress/caller-and-arguments-properties-for-functions-that-dont-have-them.js (rev 0)
+++ trunk/JSTests/stress/caller-and-arguments-properties-for-functions-that-dont-have-them.js 2017-12-13 17:29:21 UTC (rev 225845)
@@ -0,0 +1,74 @@
+function assert(b) {
+if (!b)
+throw new Error;
+}
+
+function test1(f) {
+f.__proto__ = {};
+Object.defineProperty(f, "caller", {value:42});
+assert(f.caller === 42);
+Object.defineProperty(f, "arguments", {value:32});
+assert(f.arguments === 32);
+}
+for (let i = 0; i < 1000; ++i) {
+test1(function () { "use strict"; });
+test1(class C { });
+test1(() => undefined);
+test1(async function foo(){});
+test1(function* foo() { });
+}
+
+function test2(f, p = {}) {
+f.__proto__ = p;
+f.caller = 42;
+assert(f.caller === 42);
+f.arguments = 44;
+assert(f.arguments === 44);
+}
+
+{
+let proxy = new Proxy({}, {
+has(...args) {
+throw new Error("Should not be called!");
+}
+});
+for (let i = 0; i < 1000; ++i) {
+test2(function () { "use strict"; }, proxy);
+test2(class C { }, proxy);
+test2(() => undefined, proxy);
+test2(async function foo(){}, proxy);
+test2(function* foo() { }, proxy);
+}
+}
+
+for (let i = 0; i < 1000; ++i) {
+test2(function () { "use strict"; });
+test2(class C { });
+test2(() => undefined);
+test2(async function foo(){});
+test2(function* foo() { });
+}
+
+function test3(f) {
+f.__proto__ = {};
+f.caller = 42;
+assert(f.caller === 42);
+assert(f.hasOwnProperty("caller"));
+assert(delete f.caller === true);
+assert(f.caller === undefined);
+assert(!f.hasOwnProperty("caller"));
+
+f.arguments = 44;
+assert(f.arguments === 44);
+assert(f.hasOwnProperty("arguments"));
+assert(delete f.arguments === true);
+assert(f.arguments === undefined);
+assert(!f.hasOwnProperty("arguments"));
+}
+for (let i = 0; i < 1000; ++i) {
+test3(function () { "use strict"; });
+test3(class C { });
+test3(() => undefined);
+test3(async function foo(){});
+test3(function* foo() { });
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (225844 => 225845)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-13 17:19:24 UTC (rev 225844)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-13 17:29:21 UTC (rev 225845)
@@ -1,5 +1,25 @@
2017-12-13 Saam Barati
+Fix how JSFunction handles "caller" and "arguments" for functions that don't have those properties
+
[webkit-changes] [225844] trunk
Title: [225844] trunk
Revision 225844
Author sbar...@apple.com
Date 2017-12-13 09:19:24 -0800 (Wed, 13 Dec 2017)
Log Message
TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this|
https://bugs.webkit.org/show_bug.cgi?id=180734
Reviewed by Yusuke Suzuki.
JSTests:
* stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js: Added.
(__isPropertyOfType):
(__getProperties):
(__getObjects):
(__getRandomObject):
(theClass.):
(theClass):
(childClass):
(counter.catch):
Source/_javascript_Core:
The |this| value may be TDZ. If type check hoisting phase
hoists a CheckStructure to it, it will crash. This patch
makes it so we emit CheckStructureOrEmpty for |this|.
* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp
Added Paths
trunk/JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js
Diff
Modified: trunk/JSTests/ChangeLog (225843 => 225844)
--- trunk/JSTests/ChangeLog 2017-12-13 12:39:42 UTC (rev 225843)
+++ trunk/JSTests/ChangeLog 2017-12-13 17:19:24 UTC (rev 225844)
@@ -1,3 +1,21 @@
+2017-12-13 Saam Barati
+
+TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this|
+https://bugs.webkit.org/show_bug.cgi?id=180734
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js: Added.
+(__isPropertyOfType):
+(__getProperties):
+(__getObjects):
+(__getRandomObject):
+(theClass.):
+(theClass):
+(childClass):
+(counter.catch):
+
2017-12-12 Saam Barati
We need to model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize
Added: trunk/JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js (0 => 225844)
--- trunk/JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js (rev 0)
+++ trunk/JSTests/stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js 2017-12-13 17:19:24 UTC (rev 225844)
@@ -0,0 +1,51 @@
+function __isPropertyOfType(obj, name, type) {
+desc = Object.getOwnPropertyDescriptor(obj, name)
+return typeof type === 'undefined' || typeof desc.value === type;
+}
+function __getProperties(obj, type) {
+let properties = [];
+for (let name of Object.getOwnPropertyNames(obj)) {
+if (__isPropertyOfType(obj, name, type)) properties.push(name);
+}
+let proto = Object.getPrototypeOf(obj);
+while (proto && proto != Object.prototype) {
+Object.getOwnPropertyNames(proto).forEach(name => {
+});
+proto = Object.getPrototypeOf(proto);
+}
+return properties;
+}
+function* __getObjects(root = this, level = 0) {
+if (level > 4) return;
+let obj_names = __getProperties(root, 'object');
+for (let obj_name of obj_names) {
+let obj = root[obj_name];
+yield* __getObjects(obj, level + 1);
+}
+}
+function __getRandomObject() {
+for (let obj of __getObjects()) {
+}
+}
+var theClass = class {
+constructor() {
+if (242487 != null && typeof __getRandomObject() == "object") try {
+} catch (e) {}
+}
+};
+var childClass = class Class extends theClass {
+constructor() {
+var arrow = () => {
+try {
+super();
+} catch (e) {}
+this.idValue
+};
+arrow()()();
+}
+};
+for (var counter = 0; counter < 1000; counter++) {
+try {
+new childClass();
+} catch (e) {}
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (225843 => 225844)
--- trunk/Source/_javascript_Core/ChangeLog 2017-12-13 12:39:42 UTC (rev 225843)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-12-13 17:19:24 UTC (rev 225844)
@@ -1,3 +1,18 @@
+2017-12-13 Saam Barati
+
+TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this|
+https://bugs.webkit.org/show_bug.cgi?id=180734
+
+
+Reviewed by Yusuke Suzuki.
+
+The |this| value may be TDZ. If type check hoisting phase
+hoists a CheckStructure to it, it will crash. This patch
+makes it so we emit CheckStructureOrEmpty for |this|.
+
+* dfg/DFGTypeCheckHoistingPhase.cpp:
+(JSC::DFG::TypeCheckHoistingPhase::run):
+
2017-12-12 Yusuke Suzuki
[JSC] Optimize Object.assign by single transition acceleration
Modified: trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp (225843 => 225844)
--- trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp 2017-12-13 12:39:42 UTC (rev 225843)
+++ trunk/Source/_javascript_Core/dfg/DFGTypeCheckHoistingPhase.cpp 2017-12-13 17:19:24 UTC (rev 225844)
@@ -
[webkit-changes] [225843] trunk/LayoutTests/ChangeLog
Title: [225843] trunk/LayoutTests/ChangeLog Revision 225843 Author annu...@yandex.ru Date 2017-12-13 04:39:42 -0800 (Wed, 13 Dec 2017) Log Message Unreviewed, rolling out r179000. There are tests failing in 32-bits and Debug builds Reverted changeset: https://trac.webkit.org/changeset/179000 Modified Paths trunk/LayoutTests/ChangeLog Diff Modified: trunk/LayoutTests/ChangeLog (225842 => 225843) --- trunk/LayoutTests/ChangeLog 2017-12-13 12:09:20 UTC (rev 225842) +++ trunk/LayoutTests/ChangeLog 2017-12-13 12:39:42 UTC (rev 225843) @@ -1,3 +1,13 @@ +2017-12-13 Konstantin Tokarev + +Unreviewed, rolling out r179000. + +There are tests failing in 32-bits and Debug builds + +Reverted changeset: + +https://trac.webkit.org/changeset/179000 + 2017-12-12 Youenn Fablet getUserMedia is resolving before the document knows it is capturing ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225842] releases/WebKitGTK/webkit-2.19.3/
Title: [225842] releases/WebKitGTK/webkit-2.19.3/ Revision 225842 Author carlo...@webkit.org Date 2017-12-13 04:09:20 -0800 (Wed, 13 Dec 2017) Log Message WebKitGTK+ 2.19.3 Added Paths releases/WebKitGTK/webkit-2.19.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [225841] trunk
Title: [225841] trunk Revision 225841 Author carlo...@webkit.org Date 2017-12-13 04:08:06 -0800 (Wed, 13 Dec 2017) Log Message Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release. .: * Source/cmake/OptionsGTK.cmake: Bump version numbers. Source/WebKit: * gtk/NEWS: Add release notes for 2.19.3. Modified Paths trunk/ChangeLog trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/gtk/NEWS trunk/Source/cmake/OptionsGTK.cmake Diff Modified: trunk/ChangeLog (225840 => 225841) --- trunk/ChangeLog 2017-12-13 07:51:16 UTC (rev 225840) +++ trunk/ChangeLog 2017-12-13 12:08:06 UTC (rev 225841) @@ -1,3 +1,9 @@ +2017-12-13 Carlos Garcia Campos + +Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release. + +* Source/cmake/OptionsGTK.cmake: Bump version numbers. + 2017-12-12 Don Olmstead [WinCairo] Enable WebP support Modified: trunk/Source/WebKit/ChangeLog (225840 => 225841) --- trunk/Source/WebKit/ChangeLog 2017-12-13 07:51:16 UTC (rev 225840) +++ trunk/Source/WebKit/ChangeLog 2017-12-13 12:08:06 UTC (rev 225841) @@ -1,3 +1,9 @@ +2017-12-13 Carlos Garcia Campos + +Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release. + +* gtk/NEWS: Add release notes for 2.19.3. + 2017-12-12 Daniel Bates [WK] Add modern WebKit SPI to set auto fill button type and query if the auto fill button is enabled Modified: trunk/Source/WebKit/gtk/NEWS (225840 => 225841) --- trunk/Source/WebKit/gtk/NEWS 2017-12-13 07:51:16 UTC (rev 225840) +++ trunk/Source/WebKit/gtk/NEWS 2017-12-13 12:08:06 UTC (rev 225841) @@ -1,4 +1,15 @@ = +WebKitGTK+ 2.19.3 += + +What's new in WebKitGTK+ 2.19.3? + + - Fix web process crash at startup in bmalloc. + - Fix several memory leaks in GStreamer media backend. + - WebKitWebDriver process no longer links to libjavascriptcoregtk. + - Fix several crashes and rendering issues. + += WebKitGTK+ 2.19.2 = Modified: trunk/Source/cmake/OptionsGTK.cmake (225840 => 225841) --- trunk/Source/cmake/OptionsGTK.cmake 2017-12-13 07:51:16 UTC (rev 225840) +++ trunk/Source/cmake/OptionsGTK.cmake 2017-12-13 12:08:06 UTC (rev 225841) @@ -1,11 +1,11 @@ include(GNUInstallDirs) include(VersioningUtils) -SET_PROJECT_VERSION(2 19 2) +SET_PROJECT_VERSION(2 19 3) set(WEBKITGTK_API_VERSION 4.0) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 63 0 26) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 25 1 7) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 63 1 26) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 25 2 7) # These are shared variables, but we special case their definition so that we can use the # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
