[webkit-changes] [226216] trunk

[rniwa]

Title: [226216] trunk








Revision 226216
Author rn...@webkit.org
Date 2017-12-20 22:48:48 -0800 (Wed, 20 Dec 2017)


Log Message
DeferredLoadingScope incorrectly disabled images or enables deferred loading
https://bugs.webkit.org/show_bug.cgi?id=181077

Reviewed by Wenson Hsieh.

Source/WebCore:

Fixed the bug that DeferredLoadingScope::~DeferredLoadingScope was checking the wrong flag
for restoring the disabledness of images and deferred loading.

Test: editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html

* editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::DeferredLoadingScope::~DeferredLoadingScope): Fixed the bug.
* testing/Internals.cpp:
(WebCore::Internals::pageDefersLoading): Added for testing.
* testing/Internals.h:
* testing/Internals.idl: Added pageDefersLoading.

LayoutTests:

Added a regression test.

* editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading-expected.txt: Added.
* editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Added Paths

trunk/LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading-expected.txt
trunk/LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html




Diff

Modified: trunk/LayoutTests/ChangeLog (226215 => 226216)

--- trunk/LayoutTests/ChangeLog	2017-12-21 05:39:31 UTC (rev 226215)
+++ trunk/LayoutTests/ChangeLog	2017-12-21 06:48:48 UTC (rev 226216)
@@ -1,3 +1,15 @@
+2017-12-20  Ryosuke Niwa  
+
+DeferredLoadingScope incorrectly disabled images or enables deferred loading
+https://bugs.webkit.org/show_bug.cgi?id=181077
+
+Reviewed by Wenson Hsieh.
+
+Added a regression test.
+
+* editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading-expected.txt: Added.
+* editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html: Added.
+
 2017-12-20  Eric Carlson  
 
 [MediaStream] Add screen capture IDL and stub functions


Added: trunk/LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading-expected.txt (0 => 226216)

--- trunk/LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading-expected.txt	2017-12-21 06:48:48 UTC (rev 226216)
@@ -0,0 +1,17 @@
+This tests makes sure that pasting content while images are disabled does not enable deferred loading.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+internals.settings.setImagesEnabled(false)
+document.execCommand("copy")
+PASS editor.querySelector("img").width is 76
+setTimeout(waitForImagesToBeDisabled, 0)
+PASS internals.pageDefersLoading() is false
+document.execCommand("paste")
+PASS internals.pageDefersLoading() is false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+hello
+


Added: trunk/LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html (0 => 226216)

--- trunk/LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html	(rev 0)
+++ trunk/LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html	2017-12-21 06:48:48 UTC (rev 226216)
@@ -0,0 +1,37 @@
+
+
+
+hello
+
+description('This tests makes sure that pasting content while images are disabled does not enable deferred loading.')
+
+if (!window.internals)
+testFailed('This test requires internals.settings');
+else {
+jsTestIsAsync = true;
+
+window._onload_ = () => {
+editor.focus();
+document.execCommand("selectAll");
+evalAndLog('internals.settings.setImagesEnabled(false)');
+evalAndLog('document.execCommand("copy")');
+shouldBe('editor.querySelector("img").width', '76');
+evalAndLog('setTimeout(waitForImagesToBeDisabled, 0)');
+}
+
+function waitForImagesToBeDisabled()
+{
+shouldBeFalse('internals.pageDefersLoading()');
+evalAndLog('document.execCommand("paste")');
+shouldBeFalse('internals.pageDefersLoading()');
+finishJSTest();
+}
+
+}
+
+

[webkit-changes] [226215] trunk/Source/WebCore

[rniwa]

Title: [226215] trunk/Source/WebCore








Revision 226215
Author rn...@webkit.org
Date 2017-12-20 21:39:31 -0800 (Wed, 20 Dec 2017)


Log Message
isSafari check should take Safari Technology Preview into account
https://bugs.webkit.org/show_bug.cgi?id=181076

Reviewed by Alex Christensen.

Fixed isSafari() so that it returns true for Safari Technology Preview. This bug resulted in the custom pasteboard
types not being enabled in Safari Technology Preview. In long term, we should eliminate these isSafari() checks.

* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::MacApplication::isSafari):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (226214 => 226215)

--- trunk/Source/WebCore/ChangeLog	2017-12-21 04:37:55 UTC (rev 226214)
+++ trunk/Source/WebCore/ChangeLog	2017-12-21 05:39:31 UTC (rev 226215)
@@ -1,3 +1,16 @@
+2017-12-20  Ryosuke Niwa  
+
+isSafari check should take Safari Technology Preview into account
+https://bugs.webkit.org/show_bug.cgi?id=181076
+
+Reviewed by Alex Christensen.
+
+Fixed isSafari() so that it returns true for Safari Technology Preview. This bug resulted in the custom pasteboard
+types not being enabled in Safari Technology Preview. In long term, we should eliminate these isSafari() checks.
+
+* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+(WebCore::MacApplication::isSafari):
+
 2017-12-20  Wenson Hsieh  
 
 [Attachment Support] Attachment replacement logic should not depend on subresource URL attribute replacement


Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (226214 => 226215)

--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm	2017-12-21 04:37:55 UTC (rev 226214)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm	2017-12-21 05:39:31 UTC (rev 226215)
@@ -82,7 +82,7 @@
 
 bool MacApplication::isSafari()
 {
-static bool isSafari = applicationBundleIsEqualTo("com.apple.Safari");
+static bool isSafari = applicationBundleIsEqualTo("com.apple.Safari") || applicationBundleIsEqualTo("com.apple.SafariTechnologyPreview");
 return isSafari;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226214] trunk/Tools

[jbedard]

Title: [226214] trunk/Tools








Revision 226214
Author jbed...@apple.com
Date 2017-12-20 20:37:55 -0800 (Wed, 20 Dec 2017)


Log Message
webkitpy: simctl cannot handle partial runtime version matches
https://bugs.webkit.org/show_bug.cgi?id=181055


Reviewed by Alexey Proskuryakov.

A request for a simulator runtime of iOS 11 should be fulfilled by
iOS 11.0.1.

* Scripts/webkitpy/xcode/simulator.py:
(Simulator.runtime): Allow for partial matching of iOS runtime versions.
* Scripts/webkitpy/xcode/simulator_unittest.py:
(test_failed_partial_version_match): Test that partial version mapping does
not give false positives.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/simulator.py
trunk/Tools/Scripts/webkitpy/xcode/simulator_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (226213 => 226214)

--- trunk/Tools/ChangeLog	2017-12-21 03:50:16 UTC (rev 226213)
+++ trunk/Tools/ChangeLog	2017-12-21 04:37:55 UTC (rev 226214)
@@ -1,3 +1,20 @@
+2017-12-20  Jonathan Bedard  
+
+webkitpy: simctl cannot handle partial runtime version matches
+https://bugs.webkit.org/show_bug.cgi?id=181055
+
+
+Reviewed by Alexey Proskuryakov.
+
+A request for a simulator runtime of iOS 11 should be fulfilled by
+iOS 11.0.1.
+
+* Scripts/webkitpy/xcode/simulator.py:
+(Simulator.runtime): Allow for partial matching of iOS runtime versions.
+* Scripts/webkitpy/xcode/simulator_unittest.py:
+(test_failed_partial_version_match): Test that partial version mapping does
+not give false positives.
+
 2017-12-20  Daniel Bates  
 
 MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange} are failing


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulator.py (226213 => 226214)

--- trunk/Tools/Scripts/webkitpy/xcode/simulator.py	2017-12-21 03:50:16 UTC (rev 226213)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulator.py	2017-12-21 04:37:55 UTC (rev 226214)
@@ -410,6 +410,16 @@
 if identifier and runtime.identifier != identifier:
 continue
 return runtime
+
+# Allow for a partial version match
+for runtime in self.runtimes:
+if version and runtime.version not in version:
+continue
+if is_internal_runtime and runtime.is_internal_runtime != is_internal_runtime:
+continue
+if identifier and runtime.identifier != identifier:
+continue
+return runtime
 return None
 
 def find_device_by_udid(self, udid):


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulator_unittest.py (226213 => 226214)

--- trunk/Tools/Scripts/webkitpy/xcode/simulator_unittest.py	2017-12-21 03:50:16 UTC (rev 226213)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulator_unittest.py	2017-12-21 04:37:55 UTC (rev 226214)
@@ -58,6 +58,7 @@
 tvOS 9.0 (9.0 - 13T5347l) (com.apple.CoreSimulator.SimRuntime.tvOS-9-0)
 watchOS 2.0 (2.0 - 13S343) (com.apple.CoreSimulator.SimRuntime.watchOS-2-0)
 iOS 10.0 (10.0 - 14280) - com.apple.CoreSimulator.SimRuntime.iOS-10-0
+iOS 11.0.1 (11.0.1 - 15280) - com.apple.CoreSimulator.SimRuntime.iOS-11-0
 == Devices ==
 -- iOS 8.0 --
 iPhone 4s (68D9A792-E3A9-462B-B211-762C6A5D3779) (Shutdown)
@@ -77,6 +78,8 @@
 -- watchOS 2.0 --
 Apple Watch - 38mm (00138CD2-D30C-4380-A30E-A70B88E1A3C5) (Shutdown)
 Apple Watch - 42mm (186AD85E-9BE5-4734-BC33-DF50484AAFF0) (Shutdown)
+-- iOS 11.0 --
+iPhone 7 (48E6CA73-4BF7-4153-BEE2-736CD881FEBD) (Shutdown) (unavailable, runtime profile not found)
 ''')
 simulator = Simulator(host=self._host)
 self.assertEqual(12, len(simulator.device_types))
@@ -129,7 +132,7 @@
 self.assertEqual('Apple Watch - 42mm', device_type_apple_watch_42mm.name)
 self.assertEqual('com.apple.CoreSimulator.SimDeviceType.Apple-Watch-42mm', device_type_apple_watch_42mm.identifier)
 
-self.assertEqual(6, len(simulator.runtimes))
+self.assertEqual(7, len(simulator.runtimes))
 
 runtime_ios_8 = simulator.runtimes[0]
 self.assertEqual('com.apple.CoreSimulator.SimRuntime.iOS-8-0', runtime_ios_8.identifier)
@@ -332,6 +335,17 @@
 self.assertEqual(Version(8, 0), runtime_ios_8_internal.version)
 self.assertEqual(0, len(runtime_ios_8_internal.devices))
 
+def test_failed_partial_version_match(self):
+self._set_expected_xcrun_simctl_list('''== Device Types ==
+iPhone 6 (com.apple.CoreSimulator.SimDeviceType.iPhone-6)
+== Runtimes ==
+iOS 11.0.1 (11.0.1 - 15280) - com.apple.CoreSimulator.SimRuntime.iOS-11-0
+== Devices ==
+-- iOS 11.1 --
+iPhone 6 (48E6CA73-4BF7-4153-BEE2-736CD881FEBD) (Shutdown)
+''')
+self.assertRaises(AssertionError, lambda: Simulator(host=self._host))
+
 def test_device_pairs(self):
 """ Tests that Device Pairs header does not cause parsing exception """

[webkit-changes] [226213] trunk/Source/WebCore

[wenson_hsieh]

Title: [226213] trunk/Source/WebCore








Revision 226213
Author wenson_hs...@apple.com
Date 2017-12-20 19:50:16 -0800 (Wed, 20 Dec 2017)


Log Message
[Attachment Support] Attachment replacement logic should not depend on subresource URL attribute replacement
https://bugs.webkit.org/show_bug.cgi?id=181068


Reviewed by Ryosuke Niwa.

Refactors attachment replacement logic, so that it doesn't require us to first replace element attributes that
contain subresource URLs with blob URLs before performing attachment element replacement. See below comments for
more detail.

Covered by existing API tests in WKAttachmentTests.

* editing/WebContentReader.h:
(WebCore::BlobReplacementInfo::isEmpty const): Deleted.

Remove BlobReplacementInfo. Instead, augment `replaceRichContentWithAttachments` so that it takes in the list of
subresources directly and generates blobs for each subresource.

* editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::replaceSelectionWithAttributedString):
* editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::shouldReplaceRichContentWithAttachments):
(WebCore::createFragmentForImageAttachment):
(WebCore::replaceRichContentWithAttachments):
(WebCore::createFragmentAndAddResources):
(WebCore::sanitizeMarkupWithArchive):

In these helper functions that currently convert subresource URLs to blob URLs, if attachment elements are not
defined out, and the runtime feature for attachment elements is enabled, then use an alternate codepath to
adjust the markup (via replaceRichContentWithAttachments).

Otherwise, fall back to default subresource URL conversion logic, which (at the moment) still converts
subresources to blobs, but will soon be changed to emit data URLs instead.

(WebCore::WebContentReader::readWebArchive):
(WebCore::WebContentMarkupReader::readWebArchive):
(WebCore::WebContentReader::readRTFD):
(WebCore::WebContentMarkupReader::readRTFD):
(WebCore::WebContentReader::readRTF):
(WebCore::WebContentMarkupReader::readRTF):
(WebCore::WebContentReader::readImage):

Remove the createFragmentFromAttributedString helper and revert to just calling createFragmentAndAddResources.

(WebCore::createFragmentFromAttributedString): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/WebContentReader.h
trunk/Source/WebCore/editing/cocoa/EditorCocoa.mm
trunk/Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (226212 => 226213)

--- trunk/Source/WebCore/ChangeLog	2017-12-21 03:39:49 UTC (rev 226212)
+++ trunk/Source/WebCore/ChangeLog	2017-12-21 03:50:16 UTC (rev 226213)
@@ -1,3 +1,51 @@
+2017-12-20  Wenson Hsieh  
+
+[Attachment Support] Attachment replacement logic should not depend on subresource URL attribute replacement
+https://bugs.webkit.org/show_bug.cgi?id=181068
+
+
+Reviewed by Ryosuke Niwa.
+
+Refactors attachment replacement logic, so that it doesn't require us to first replace element attributes that
+contain subresource URLs with blob URLs before performing attachment element replacement. See below comments for
+more detail.
+
+Covered by existing API tests in WKAttachmentTests.
+
+* editing/WebContentReader.h:
+(WebCore::BlobReplacementInfo::isEmpty const): Deleted.
+
+Remove BlobReplacementInfo. Instead, augment `replaceRichContentWithAttachments` so that it takes in the list of
+subresources directly and generates blobs for each subresource.
+
+* editing/cocoa/EditorCocoa.mm:
+(WebCore::Editor::replaceSelectionWithAttributedString):
+* editing/cocoa/WebContentReaderCocoa.mm:
+(WebCore::shouldReplaceRichContentWithAttachments):
+(WebCore::createFragmentForImageAttachment):
+(WebCore::replaceRichContentWithAttachments):
+(WebCore::createFragmentAndAddResources):
+(WebCore::sanitizeMarkupWithArchive):
+
+In these helper functions that currently convert subresource URLs to blob URLs, if attachment elements are not
+defined out, and the runtime feature for attachment elements is enabled, then use an alternate codepath to
+adjust the markup (via replaceRichContentWithAttachments).
+
+Otherwise, fall back to default subresource URL conversion logic, which (at the moment) still converts
+subresources to blobs, but will soon be changed to emit data URLs instead.
+
+(WebCore::WebContentReader::readWebArchive):
+(WebCore::WebContentMarkupReader::readWebArchive):
+(WebCore::WebContentReader::readRTFD):
+(WebCore::WebContentMarkupReader::readRTFD):
+(WebCore::WebContentReader::readRTF):
+(WebCore::WebContentMarkupReader::readRTF):
+(WebCore::WebContentReader::readImage):
+
+Remove the createFragmentFromAttributedString helper and revert to just calling createFragmentAndAddResources.
+
+

[webkit-changes] [226211] trunk

[eric . carlson]

Title: [226211] trunk








Revision 226211
Author eric.carl...@apple.com
Date 2017-12-20 18:45:36 -0800 (Wed, 20 Dec 2017)


Log Message
[MediaStream] Add screen capture IDL and stub functions
https://bugs.webkit.org/show_bug.cgi?id=181070


Reviewed by Youenn Fablet.

Source/WebCore:

Tests: fast/mediastream/screencapture-disabled.html
   fast/mediastream/screencapture-enabled.html

* Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::getDisplayMedia const):
(WebCore::MediaDevices::getSupportedConstraints):
* Modules/mediastream/MediaDevices.h:
* Modules/mediastream/MediaDevices.idl:
* Modules/mediastream/MediaTrackConstraints.cpp:
(WebCore::convertToInternalForm):
* Modules/mediastream/MediaTrackConstraints.h:
* Modules/mediastream/MediaTrackConstraints.idl:
* Modules/mediastream/MediaTrackSupportedConstraints.h:
* Modules/mediastream/MediaTrackSupportedConstraints.idl:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::start):
(WebCore::UserMediaRequest::allow):
(WebCore::UserMediaRequest::deny):
* Modules/mediastream/UserMediaRequest.h:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::screenCaptureEnabled const):
(WebCore::RuntimeEnabledFeatures::setScreenCaptureEnabled):
* platform/mediastream/CaptureDevice.h:
* platform/mediastream/MediaConstraints.cpp:
(WebCore::MediaTrackConstraintSetMap::set):
* platform/mediastream/MediaConstraints.h:
(WebCore::MediaTrackConstraintSetMap::displaySurface const):
(WebCore::MediaTrackConstraintSetMap::logicalSurface const):
(WebCore::MediaTrackConstraintSetMap::encode const):
(WebCore::MediaTrackConstraintSetMap::decode):
* platform/mediastream/MediaStreamRequest.h:
* platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::fitnessDistance):
(WebCore::RealtimeMediaSource::applyConstraint):
(WebCore::RealtimeMediaSource::supportsConstraint const):
* platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::RealtimeMediaSourceCenter::captureDeviceWithPersistentID):
* platform/mediastream/RealtimeMediaSourceSettings.h:
(WebCore::RealtimeMediaSourceSettings::supportsDisplaySurface const):
(WebCore::RealtimeMediaSourceSettings::displaySurface const):
(WebCore::RealtimeMediaSourceSettings::setDisplaySurface):
(WebCore::RealtimeMediaSourceSettings::supportsLogicalSurface const):
(WebCore::RealtimeMediaSourceSettings::logicalSurface const):
(WebCore::RealtimeMediaSourceSettings::setLogicalSurface):
* platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:
(WebCore::RealtimeMediaSourceSupportedConstraints::supportsConstraint const):
* platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
(WebCore::RealtimeMediaSourceSupportedConstraints::supportsDisplaySurface const):
(WebCore::RealtimeMediaSourceSupportedConstraints::setSupportsDisplaySurface):
(WebCore::RealtimeMediaSourceSupportedConstraints::supportsLogicalSurface const):
(WebCore::RealtimeMediaSourceSupportedConstraints::setSupportsLogicalSurface):
(WebCore::RealtimeMediaSourceSupportedConstraints::encode const):
(WebCore::RealtimeMediaSourceSupportedConstraints::decode):
* platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
* platform/mock/MockRealtimeVideoSource.cpp:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setScreenCaptureEnabled):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit:

* Shared/WebPreferences.yaml:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _screenCaptureEnabled]):
(-[WKPreferences _setScreenCaptureEnabled:]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

LayoutTests:

* fast/mediastream/screencapture-disabled-expected.txt: Added.
* fast/mediastream/screencapture-disabled.html: Added.
* fast/mediastream/screencapture-enabled-expected.txt: Added.
* fast/mediastream/screencapture-enabled.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp
trunk/Source/WebCore/Modules/mediastream/MediaDevices.h
trunk/Source/WebCore/Modules/mediastream/MediaDevices.idl
trunk/Source/WebCore/Modules/mediastream/MediaTrackConstraints.cpp
trunk/Source/WebCore/Modules/mediastream/MediaTrackConstraints.h
trunk/Source/WebCore/Modules/mediastream/MediaTrackConstraints.idl
trunk/Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.h
trunk/Source/WebCore/Modules/mediastream/MediaTrackSupportedConstraints.idl
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.h
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebCore/platform/mediastream/CaptureDevice.h
trunk/Source/WebCore/platform/mediastream/MediaConstraints.cpp

[webkit-changes] [226209] trunk

[utatane . tea]

Title: [226209] trunk








Revision 226209
Author utatane@gmail.com
Date 2017-12-20 17:58:28 -0800 (Wed, 20 Dec 2017)


Log Message
[JSC] Do not check isValid() in op_new_regexp
https://bugs.webkit.org/show_bug.cgi?id=180970

Reviewed by Saam Barati.

JSTests:

* stress/regexp-syntax-error-invalid-flags.js: Added.
(shouldThrow):

Source/_javascript_Core:

We should not check `isValid()` inside op_new_regexp.
This simplifies the semantics of NewRegexp node in DFG.

* bytecompiler/NodesCodegen.cpp:
(JSC::RegExpNode::emitBytecode):
* dfg/DFGMayExit.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewRegexp):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp):
* jit/JITOperations.cpp:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/dfg/DFGMayExit.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/JITOperations.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp


Added Paths

trunk/JSTests/stress/regexp-syntax-error-invalid-flags.js




Diff

Modified: trunk/JSTests/ChangeLog (226208 => 226209)

--- trunk/JSTests/ChangeLog	2017-12-21 01:54:46 UTC (rev 226208)
+++ trunk/JSTests/ChangeLog	2017-12-21 01:58:28 UTC (rev 226209)
@@ -1,3 +1,13 @@
+2017-12-19  Yusuke Suzuki  
+
+[JSC] Do not check isValid() in op_new_regexp
+https://bugs.webkit.org/show_bug.cgi?id=180970
+
+Reviewed by Saam Barati.
+
+* stress/regexp-syntax-error-invalid-flags.js: Added.
+(shouldThrow):
+
 2017-12-18  Guillaume Emont  
 
 Skip stress/call-apply-exponential-bytecode-size.js unless x86-64 or arm64


Added: trunk/JSTests/stress/regexp-syntax-error-invalid-flags.js (0 => 226209)

--- trunk/JSTests/stress/regexp-syntax-error-invalid-flags.js	(rev 0)
+++ trunk/JSTests/stress/regexp-syntax-error-invalid-flags.js	2017-12-21 01:58:28 UTC (rev 226209)
@@ -0,0 +1,23 @@
+function shouldThrow(func, errorMessage) {
+var errorThrown = false;
+var error = null;
+try {
+func();
+} catch (e) {
+errorThrown = true;
+error = e;
+}
+if (!errorThrown)
+throw new Error('not thrown');
+if (String(error) !== errorMessage)
+throw new Error(`bad error: ${String(error)}`);
+}
+
+function test()
+{
+return /Hello/cocoa;
+}
+noInline(test);
+
+for (var i = 0; i < 1e4; ++i)
+shouldThrow(test, `SyntaxError: Invalid regular _expression_: invalid flags`);


Modified: trunk/Source/_javascript_Core/ChangeLog (226208 => 226209)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-21 01:54:46 UTC (rev 226208)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-21 01:58:28 UTC (rev 226209)
@@ -1,3 +1,24 @@
+2017-12-19  Yusuke Suzuki  
+
+[JSC] Do not check isValid() in op_new_regexp
+https://bugs.webkit.org/show_bug.cgi?id=180970
+
+Reviewed by Saam Barati.
+
+We should not check `isValid()` inside op_new_regexp.
+This simplifies the semantics of NewRegexp node in DFG.
+
+* bytecompiler/NodesCodegen.cpp:
+(JSC::RegExpNode::emitBytecode):
+* dfg/DFGMayExit.cpp:
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileNewRegexp):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp):
+* jit/JITOperations.cpp:
+* llint/LLIntSlowPaths.cpp:
+(JSC::LLInt::LLINT_SLOW_PATH_DECL):
+
 2017-12-20  Saam Barati  
 
 GetPropertyEnumerator in DFG/FTL should not unconditionally speculate cell


Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (226208 => 226209)

--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp	2017-12-21 01:54:46 UTC (rev 226208)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp	2017-12-21 01:58:28 UTC (rev 226209)
@@ -141,8 +141,14 @@
 RegisterID* RegExpNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
 {
 if (dst == generator.ignoredResult())
-return 0;
-return generator.emitNewRegExp(generator.finalDestination(dst), RegExp::create(*generator.vm(), m_pattern.string(), regExpFlags(m_flags.string(;
+return nullptr;
+RegExp* regExp = RegExp::create(*generator.vm(), m_pattern.string(), regExpFlags(m_flags.string()));
+if (regExp->isValid())
+return generator.emitNewRegExp(generator.finalDestination(dst), regExp);
+const char* messageCharacters = regExp->errorMessage();
+const Identifier& message = generator.parserArena().identifierArena().makeIdentifier(generator.vm(), bitwise_cast(messageCharacters), strlen(messageCharacters));
+

[webkit-changes] [226208] trunk/Source/JavaScriptCore

[sbarati]

Title: [226208] trunk/Source/_javascript_Core








Revision 226208
Author sbar...@apple.com
Date 2017-12-20 17:54:46 -0800 (Wed, 20 Dec 2017)


Log Message
GetPropertyEnumerator in DFG/FTL should not unconditionally speculate cell
https://bugs.webkit.org/show_bug.cgi?id=181054

Reviewed by Mark Lam.

Speedometer's react subtest has a function that is in an OSR exit loop because
we used to unconditionally speculate cell for the operand to GetPropertyEnumerator.
This fix doesn't seem to speed up Speedometer at all, but it's good hygiene
for our compiler to not have this pathology. This patch adds a generic
GetPropertyEnumerator to prevent the exit loop.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator):
* jit/JITOperations.cpp:
* jit/JITOperations.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/JITOperations.cpp
trunk/Source/_javascript_Core/jit/JITOperations.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (226207 => 226208)

--- trunk/Source/_javascript_Core/ChangeLog	2017-12-21 01:49:00 UTC (rev 226207)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-12-21 01:54:46 UTC (rev 226208)
@@ -1,3 +1,27 @@
+2017-12-20  Saam Barati  
+
+GetPropertyEnumerator in DFG/FTL should not unconditionally speculate cell
+https://bugs.webkit.org/show_bug.cgi?id=181054
+
+Reviewed by Mark Lam.
+
+Speedometer's react subtest has a function that is in an OSR exit loop because
+we used to unconditionally speculate cell for the operand to GetPropertyEnumerator.
+This fix doesn't seem to speed up Speedometer at all, but it's good hygiene 
+for our compiler to not have this pathology. This patch adds a generic
+GetPropertyEnumerator to prevent the exit loop.
+
+* dfg/DFGFixupPhase.cpp:
+(JSC::DFG::FixupPhase::fixupNode):
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator):
+* jit/JITOperations.cpp:
+* jit/JITOperations.h:
+
 2017-12-20  Daniel Bates  
 
 Remove Alternative Presentation Button


Modified: trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp (226207 => 226208)

--- trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp	2017-12-21 01:49:00 UTC (rev 226207)
+++ trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp	2017-12-21 01:54:46 UTC (rev 226208)
@@ -1725,7 +1725,8 @@
 break;
 }
 case GetPropertyEnumerator: {
-fixEdge(node->child1());
+if (node->child1()->shouldSpeculateCell())
+fixEdge(node->child1());
 break;
 }
 case GetEnumeratorStructurePname: {


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp (226207 => 226208)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2017-12-21 01:49:00 UTC (rev 226207)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp	2017-12-21 01:54:46 UTC (rev 226208)
@@ -5358,14 +5358,25 @@
 break;
 }
 case GetPropertyEnumerator: {
-SpeculateCellOperand base(this, node->child1());
-GPRFlushedCallResult result(this);
-GPRReg resultGPR = result.gpr();
+if (node->child1().useKind() == CellUse) {
+SpeculateCellOperand base(this, node->child1());
+GPRFlushedCallResult result(this);
+GPRReg resultGPR = result.gpr();
 
-flushRegisters();
-callOperation(operationGetPropertyEnumerator, resultGPR, base.gpr());
-m_jit.exceptionCheck();
-cellResult(resultGPR, node);
+flushRegisters();
+callOperation(operationGetPropertyEnumeratorCell, resultGPR, base.gpr());
+m_jit.exceptionCheck();
+cellResult(resultGPR, node);
+} else {
+JSValueOperand base(this, node->child1());
+GPRFlushedCallResult result(this);
+GPRReg resultGPR = result.gpr();
+
+flushRegisters();
+callOperation(operationGetPropertyEnumerator, resultGPR, base.jsValueRegs());
+m_jit.exceptionCheck();
+cellResult(resultGPR, node);
+}
 break;
 }
 case GetEnumeratorStructurePname:


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (226207 

[webkit-changes] [226207] trunk/LayoutTests

[jlewis3]

Title: [226207] trunk/LayoutTests








Revision 226207
Author jlew...@apple.com
Date 2017-12-20 17:49:00 -0800 (Wed, 20 Dec 2017)


Log Message
Unreviewed, rolling out r226155.

This caused test failures.

Reverted changeset:

"Web Inspector: add TestPage.debug() to inspect evaluations
being sent to Inspector page"
https://bugs.webkit.org/show_bug.cgi?id=181005
https://trac.webkit.org/changeset/226155

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js




Diff

Modified: trunk/LayoutTests/ChangeLog (226206 => 226207)

--- trunk/LayoutTests/ChangeLog	2017-12-21 01:39:08 UTC (rev 226206)
+++ trunk/LayoutTests/ChangeLog	2017-12-21 01:49:00 UTC (rev 226207)
@@ -1,3 +1,16 @@
+2017-12-20  Matt Lewis  
+
+Unreviewed, rolling out r226155.
+
+This caused test failures.
+
+Reverted changeset:
+
+"Web Inspector: add TestPage.debug() to inspect evaluations
+being sent to Inspector page"
+https://bugs.webkit.org/show_bug.cgi?id=181005
+https://trac.webkit.org/changeset/226155
+
 2017-12-20  Brady Eidson  
 
 Assertion failure in MessagePort::contextDestroyed in http/tests/security/MessagePort/event-listener-context.html, usually attributed to later tests.


Modified: trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js (226206 => 226207)

--- trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js	2017-12-21 01:39:08 UTC (rev 226206)
+++ trunk/LayoutTests/http/tests/inspector/resources/inspector-test.js	2017-12-21 01:49:00 UTC (rev 226207)
@@ -97,8 +97,8 @@
 let initializationCodeString = `(${runInitializationMethodsInFrontend.toString()})([${TestPage._initializers}]);`;
 let testFunctionCodeString = `(${runTestMethodInFrontend.toString()})(${testFunction.toString()});`;
 
-TestPage.evaluateInWebInspector(initializationCodeString);
-TestPage.evaluateInWebInspector(testFunctionCodeString);
+testRunner.evaluateInWebInspector(initializationCodeString);
+testRunner.evaluateInWebInspector(testFunctionCodeString);
 }
 
 function runTestHTTPS()
@@ -139,20 +139,6 @@
 window.alert(message);
 }
 
-// Use this to dump evaluations that are sent from the TestPage to the InspectorTest page.
-TestPage.debug = function()
-{
-this.dumpInspectorPageEvaluations = true;
-}
-
-TestPage.evaluateInWebInspector = function(code)
-{
-if (this.dumpInspectorPageEvaluations)
-this.debugLog(code);
-
-testRunner.evaluateInWebInspector(code);
-}
-
 // Add and clear test output from the results window.
 TestPage.addResult = function(text)
 {
@@ -176,7 +162,7 @@
 TestPage.dispatchEventToFrontend = function(eventName, data)
 {
 let dispatchEventCodeString = `InspectorTest.dispatchEventToListeners(${JSON.stringify(eventName)}, ${JSON.stringify(data)});`;
-this.evaluateInWebInspector(dispatchEventCodeString);
+testRunner.evaluateInWebInspector(dispatchEventCodeString);
 };
 
 TestPage.allowUncaughtExceptions = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226206] trunk/Source/WebKit

[commit-queue]

Title: [226206] trunk/Source/WebKit








Revision 226206
Author commit-qu...@webkit.org
Date 2017-12-20 17:39:08 -0800 (Wed, 20 Dec 2017)


Log Message
Crash when clearing std::optional
https://bugs.webkit.org/show_bug.cgi?id=181061

Patch by Youenn Fablet  on 2017-12-20
Reviewed by Alex Christensen.

* WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::didFinishBlobLoading): moving the object to not destroy 'this' too soon.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (226205 => 226206)

--- trunk/Source/WebKit/ChangeLog	2017-12-21 01:10:52 UTC (rev 226205)
+++ trunk/Source/WebKit/ChangeLog	2017-12-21 01:39:08 UTC (rev 226206)
@@ -1,5 +1,15 @@
 2017-12-20  Youenn Fablet  
 
+Crash when clearing std::optional
+https://bugs.webkit.org/show_bug.cgi?id=181061
+
+Reviewed by Alex Christensen.
+
+* WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
+(WebKit::WebServiceWorkerFetchTaskClient::didFinishBlobLoading): moving the object to not destroy 'this' too soon.
+
+2017-12-20  Youenn Fablet  
+
 Support service worker interception of request with blob body
 https://bugs.webkit.org/show_bug.cgi?id=181035
 


Modified: trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp (226205 => 226206)

--- trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp	2017-12-21 01:10:52 UTC (rev 226205)
+++ trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp	2017-12-21 01:39:08 UTC (rev 226206)
@@ -114,7 +114,7 @@
 {
 didFinish();
 
-m_blobLoader = std::nullopt;
+std::exchange(m_blobLoader, std::nullopt);
 }
 
 void WebServiceWorkerFetchTaskClient::didFail()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226204] trunk/Source/bmalloc

[commit-queue]

Title: [226204] trunk/Source/bmalloc








Revision 226204
Author commit-qu...@webkit.org
Date 2017-12-20 17:07:49 -0800 (Wed, 20 Dec 2017)


Log Message
Include stdio.h before using stderr and _IONBF
https://bugs.webkit.org/show_bug.cgi?id=181046

Patch by Ting-Wei Lan  on 2017-12-20
Reviewed by Alex Christensen.

* bmalloc/IsoTLS.cpp:

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/IsoTLS.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (226203 => 226204)

--- trunk/Source/bmalloc/ChangeLog	2017-12-21 00:13:09 UTC (rev 226203)
+++ trunk/Source/bmalloc/ChangeLog	2017-12-21 01:07:49 UTC (rev 226204)
@@ -1,3 +1,12 @@
+2017-12-20  Ting-Wei Lan  
+
+Include stdio.h before using stderr and _IONBF
+https://bugs.webkit.org/show_bug.cgi?id=181046
+
+Reviewed by Alex Christensen.
+
+* bmalloc/IsoTLS.cpp:
+
 2017-12-14  David Kilzer  
 
 Enable -Wstrict-prototypes for WebKit


Modified: trunk/Source/bmalloc/bmalloc/IsoTLS.cpp (226203 => 226204)

--- trunk/Source/bmalloc/bmalloc/IsoTLS.cpp	2017-12-21 00:13:09 UTC (rev 226203)
+++ trunk/Source/bmalloc/bmalloc/IsoTLS.cpp	2017-12-21 01:07:49 UTC (rev 226204)
@@ -31,6 +31,8 @@
 #include "IsoTLSInlines.h"
 #include "IsoTLSLayout.h"
 
+#include 
+
 namespace bmalloc {
 
 #if !HAVE_PTHREAD_MACHDEP_H






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226203] trunk/Source/WebCore

[commit-queue]

Title: [226203] trunk/Source/WebCore








Revision 226203
Author commit-qu...@webkit.org
Date 2017-12-20 16:13:09 -0800 (Wed, 20 Dec 2017)


Log Message
com.apple.WebKit.WebContent.Development crashed in com.apple.WebCore: WebCore::UserMediaRequest::stop + 126
https://bugs.webkit.org/show_bug.cgi?id=181057

Patch by Youenn Fablet  on 2017-12-20
Reviewed by Eric Carlson.

Covered by fast/mediastream tests to not crash anymore.

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::stop):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226202 => 226203)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 22:47:20 UTC (rev 226202)
+++ trunk/Source/WebCore/ChangeLog	2017-12-21 00:13:09 UTC (rev 226203)
@@ -1,3 +1,15 @@
+2017-12-20  Youenn Fablet  
+
+com.apple.WebKit.WebContent.Development crashed in com.apple.WebCore: WebCore::UserMediaRequest::stop + 126
+https://bugs.webkit.org/show_bug.cgi?id=181057
+
+Reviewed by Eric Carlson.
+
+Covered by fast/mediastream tests to not crash anymore.
+
+* Modules/mediastream/UserMediaRequest.cpp:
+(WebCore::UserMediaRequest::stop):
+
 2017-12-20  Brady Eidson  
 
 Assertion failure in MessagePort::contextDestroyed in http/tests/security/MessagePort/event-listener-context.html, usually attributed to later tests.


Modified: trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp (226202 => 226203)

--- trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp	2017-12-20 22:47:20 UTC (rev 226202)
+++ trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp	2017-12-21 00:13:09 UTC (rev 226203)
@@ -277,15 +277,14 @@
 
 void UserMediaRequest::stop()
 {
-auto& document = downcast(*m_scriptExecutionContext);
-auto* controller = UserMediaController::from(document.page());
+// Protecting 'it'this' since nulling m_pendingActivationMediaStream might destroy it.
+Ref protectedThis(*this);
 
 m_pendingActivationMediaStream = nullptr;
-if (!controller)
-return;
 
-Ref protectedThis(*this);
-controller->cancelUserMediaAccessRequest(*this);
+auto& document = downcast(*m_scriptExecutionContext);
+if (auto* controller = UserMediaController::from(document.page()))
+controller->cancelUserMediaAccessRequest(*this);
 }
 
 const char* UserMediaRequest::activeDOMObjectName() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226202] trunk

[beidson]

Title: [226202] trunk








Revision 226202
Author beid...@apple.com
Date 2017-12-20 14:47:20 -0800 (Wed, 20 Dec 2017)


Log Message
Assertion failure in MessagePort::contextDestroyed in http/tests/security/MessagePort/event-listener-context.html, usually attributed to later tests.
https://bugs.webkit.org/show_bug.cgi?id=94458

Reviewed by Chris Dumez.

Source/WebCore:

No new tests (Changed existing test to reliably crash before this change, and work after it)

There was already a glaring FIXME that said "MessagePorts should be ActiveDOMObjects"

It was right, and it fixes up this subtle lifetime issue.

* dom/MessagePort.cpp:
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::hasPendingActivity const):
(WebCore::MessagePort::locallyEntangledPort const):
(WebCore::MessagePort::activeDOMObjectName const):
(WebCore::MessagePort::hasPendingActivity): Deleted.
(WebCore::MessagePort::locallyEntangledPort): Deleted.
* dom/MessagePort.h:

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::hasPendingActivity const):

LayoutTests:

* fast/events/message-port-constructor-for-deleted-document-expected.txt:
* fast/events/message-port-constructor-for-deleted-document.html:
* fast/events/resources/copy-of-message-port-context-destroyed.html: Added.
* platform/mac/TestExpectations: Reenable the now-reliable and now-passing test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/message-port-constructor-for-deleted-document-expected.txt
trunk/LayoutTests/fast/events/message-port-constructor-for-deleted-document.html
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/MessagePort.cpp
trunk/Source/WebCore/dom/MessagePort.h
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp


Added Paths

trunk/LayoutTests/fast/events/resources/copy-of-message-port-context-destroyed.html




Diff

Modified: trunk/LayoutTests/ChangeLog (226201 => 226202)

--- trunk/LayoutTests/ChangeLog	2017-12-20 22:09:01 UTC (rev 226201)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 22:47:20 UTC (rev 226202)
@@ -1,3 +1,15 @@
+2017-12-20  Brady Eidson  
+
+Assertion failure in MessagePort::contextDestroyed in http/tests/security/MessagePort/event-listener-context.html, usually attributed to later tests.
+https://bugs.webkit.org/show_bug.cgi?id=94458
+
+Reviewed by Chris Dumez.
+
+* fast/events/message-port-constructor-for-deleted-document-expected.txt:
+* fast/events/message-port-constructor-for-deleted-document.html:
+* fast/events/resources/copy-of-message-port-context-destroyed.html: Added.
+* platform/mac/TestExpectations: Reenable the now-reliable and now-passing test.
+
 2017-12-20  Youenn Fablet  
 
 LayoutTests/http/tests/workers/service/service-worker-cache-api.https.html is failing on most platforms


Modified: trunk/LayoutTests/fast/events/message-port-constructor-for-deleted-document-expected.txt (226201 => 226202)

--- trunk/LayoutTests/fast/events/message-port-constructor-for-deleted-document-expected.txt	2017-12-20 22:09:01 UTC (rev 226201)
+++ trunk/LayoutTests/fast/events/message-port-constructor-for-deleted-document-expected.txt	2017-12-20 22:47:20 UTC (rev 226202)
@@ -1,4 +1 @@
-Test that destroying a document doesn't cause a crash when executing MessageChannel constructor saved from its Window object.
-
 Didn't crash: SUCCESS
-


Modified: trunk/LayoutTests/fast/events/message-port-constructor-for-deleted-document.html (226201 => 226202)

--- trunk/LayoutTests/fast/events/message-port-constructor-for-deleted-document.html	2017-12-20 22:09:01 UTC (rev 226201)
+++ trunk/LayoutTests/fast/events/message-port-constructor-for-deleted-document.html	2017-12-20 22:47:20 UTC (rev 226202)
@@ -44,10 +44,7 @@
 } catch (ex) {
 }
 
-log("Didn't crash: SUCCESS");
-
-if (window.testRunner)
-testRunner.notifyDone();
+location.href='';
 }
 
 


Added: trunk/LayoutTests/fast/events/resources/copy-of-message-port-context-destroyed.html (0 => 226202)

--- trunk/LayoutTests/fast/events/resources/copy-of-message-port-context-destroyed.html	(rev 0)
+++ trunk/LayoutTests/fast/events/resources/copy-of-message-port-context-destroyed.html	2017-12-20 22:47:20 UTC (rev 226202)
@@ -0,0 +1,41 @@
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+var port;
+var gc_stuff = new Array();
+
+gc_and_crash = function() {
+if (this.GCController)
+GCController.collect();
+else {
+// V8 needs that many objects to run GC.
+for(i = 0; i < 10; i++) {
+p = new Object();
+gc_stuff.push(p);
+gc_stuff.push(p + p);
+}
+}
+
+// If the bug 43140 is regressed, this will crash, at least in 

[webkit-changes] [226201] releases/Apple

[mitz]

Title: [226201] releases/Apple








Revision 226201
Author m...@apple.com
Date 2017-12-20 14:09:01 -0800 (Wed, 20 Dec 2017)


Log Message
Added a tag for Safari Technology Preview release 46.

Added Paths

releases/Apple/Safari Technology Preview 46/
releases/Apple/Safari Technology Preview 46/ANGLE/
releases/Apple/Safari Technology Preview 46/_javascript_Core/
releases/Apple/Safari Technology Preview 46/WTF/
releases/Apple/Safari Technology Preview 46/WebCore/
releases/Apple/Safari Technology Preview 46/WebInspectorUI/
releases/Apple/Safari Technology Preview 46/WebKit/
releases/Apple/Safari Technology Preview 46/WebKitLegacy/
releases/Apple/Safari Technology Preview 46/bmalloc/
releases/Apple/Safari Technology Preview 46/libwebrtc/




Diff
Index: releases/Apple/Safari Technology Preview 46/ANGLE
===
--- tags/Safari-605.1.18.2/Source/ThirdParty/ANGLE	2017-12-20 21:51:38 UTC (rev 226200)
+++ releases/Apple/Safari Technology Preview 46/ANGLE	2017-12-20 22:09:01 UTC (rev 226201)

Property changes: releases/Apple/Safari Technology Preview 46/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 46/_javascript_Core
===
--- tags/Safari-605.1.18.2/Source/_javascript_Core	2017-12-20 21:51:38 UTC (rev 226200)
+++ releases/Apple/Safari Technology Preview 46/_javascript_Core	2017-12-20 22:09:01 UTC (rev 226201)

Property changes: releases/Apple/Safari Technology Preview 46/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 46/WTF
===
--- tags/Safari-605.1.18.2/Source/WTF	2017-12-20 21:51:38 UTC (rev 226200)
+++ releases/Apple/Safari Technology Preview 46/WTF	2017-12-20 22:09:01 UTC (rev 226201)

Property changes: releases/Apple/Safari Technology Preview 46/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 46/WebInspectorUI
===
--- tags/Safari-605.1.18.2/Source/WebInspectorUI	2017-12-20 21:51:38 UTC (rev 226200)
+++ releases/Apple/Safari Technology Preview 46/WebInspectorUI	2017-12-20 22:09:01 UTC (rev 226201)

Property changes: releases/Apple/Safari Technology Preview 46/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 46/bmalloc
===
--- tags/Safari-605.1.18.2/Source/bmalloc	2017-12-20 21:51:38 UTC (rev 226200)
+++ releases/Apple/Safari Technology Preview 46/bmalloc	2017-12-20 22:09:01 UTC (rev 226201)

Property changes: releases/Apple/Safari Technology Preview 46/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property
Index: releases/Apple/Safari Technology Preview 46/libwebrtc
===
--- tags/Safari-605.1.18.2/Source/ThirdParty/libwebrtc	2017-12-20 21:51:38 UTC (rev 226200)
+++ releases/Apple/Safari Technology Preview 46/libwebrtc	2017-12-20 22:09:01 UTC (rev 226201)

Property changes: releases/Apple/Safari Technology Preview 46/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226200] trunk/Source/WebCore

[commit-queue]

Title: [226200] trunk/Source/WebCore








Revision 226200
Author commit-qu...@webkit.org
Date 2017-12-20 13:51:38 -0800 (Wed, 20 Dec 2017)


Log Message
Do not search for service worker registration in case of non HTTP navigation loads
https://bugs.webkit.org/show_bug.cgi?id=180976


Unreviewed.

Patch by Youenn Fablet  on 2017-12-20

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Removing unneeded spaces.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226199 => 226200)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 21:38:50 UTC (rev 226199)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 21:51:38 UTC (rev 226200)
@@ -1,3 +1,14 @@
+2017-12-20  Youenn Fablet  
+
+Do not search for service worker registration in case of non HTTP navigation loads
+https://bugs.webkit.org/show_bug.cgi?id=180976
+
+
+Unreviewed.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::startLoadingMainResource): Removing unneeded spaces.
+
 2017-12-20  Alex Christensen  
 
 Remove some SVN files accidentally committed with r226160


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (226199 => 226200)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2017-12-20 21:38:50 UTC (rev 226199)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2017-12-20 21:51:38 UTC (rev 226200)
@@ -1570,7 +1570,7 @@
 
 #if ENABLE(SERVICE_WORKER)
 // FIXME: Implement local URL interception by getting the service worker of the parent.
-auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled()&& SchemeRegistry::canServiceWorkersHandleURLScheme(request.url().protocol().toStringWithoutCopying());
+auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled() && SchemeRegistry::canServiceWorkersHandleURLScheme(request.url().protocol().toStringWithoutCopying());
 if (tryLoadingThroughServiceWorker) {
 auto origin = (!m_frame->isMainFrame() && m_frame->document()) ? makeRef(m_frame->document()->topOrigin()) : SecurityOrigin::create(request.url());
 auto& connection = ServiceWorkerProvider::singleton().serviceWorkerConnectionForSession(m_frame->page()->sessionID());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226199] trunk/LayoutTests

[commit-queue]

Title: [226199] trunk/LayoutTests








Revision 226199
Author commit-qu...@webkit.org
Date 2017-12-20 13:38:50 -0800 (Wed, 20 Dec 2017)


Log Message
LayoutTests/http/tests/workers/service/service-worker-cache-api.https.html is failing on most platforms
https://bugs.webkit.org/show_bug.cgi?id=181052

Patch by Youenn Fablet  on 2017-12-20
Reviewed by Chris Dumez.

Fixing buggy test: load was probably not intercepted.

* TestExpectations:
* http/tests/workers/service/resources/service-worker-cache-api.js: Removed.
* http/tests/workers/service/service-worker-cache-api.https-expected.txt:
* http/tests/workers/service/service-worker-cache-api.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https-expected.txt
trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https.html


Removed Paths

trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api.js




Diff

Modified: trunk/LayoutTests/ChangeLog (226198 => 226199)

--- trunk/LayoutTests/ChangeLog	2017-12-20 21:08:57 UTC (rev 226198)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 21:38:50 UTC (rev 226199)
@@ -1,3 +1,17 @@
+2017-12-20  Youenn Fablet  
+
+LayoutTests/http/tests/workers/service/service-worker-cache-api.https.html is failing on most platforms
+https://bugs.webkit.org/show_bug.cgi?id=181052
+
+Reviewed by Chris Dumez.
+
+Fixing buggy test: load was probably not intercepted.
+
+* TestExpectations:
+* http/tests/workers/service/resources/service-worker-cache-api.js: Removed.
+* http/tests/workers/service/service-worker-cache-api.https-expected.txt:
+* http/tests/workers/service/service-worker-cache-api.https.html:
+
 2017-12-20  Alicia Boya García  
 
 [GTK] imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.html is failing


Modified: trunk/LayoutTests/TestExpectations (226198 => 226199)

--- trunk/LayoutTests/TestExpectations	2017-12-20 21:08:57 UTC (rev 226198)
+++ trunk/LayoutTests/TestExpectations	2017-12-20 21:38:50 UTC (rev 226199)
@@ -165,7 +165,6 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/shared-worker-controlled.https.html [ Skip ]
 
 webkit.org/b/179342 http/tests/workers/service/registration-task-queue-scheduling-1.html [ Pass Failure ]
-http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/about-blank-replacement.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ DumpJSConsoleLogInStdErr Pass Failure ]
 webkit.org/b/179248 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html [ Pass Failure ]


Deleted: trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api.js (226198 => 226199)

--- trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api.js	2017-12-20 21:08:57 UTC (rev 226198)
+++ trunk/LayoutTests/http/tests/workers/service/resources/service-worker-cache-api.js	2017-12-20 21:38:50 UTC (rev 226199)
@@ -1,35 +0,0 @@
-function done()
-{
-finishSWTest();
-}
-
-async function logStatus()
-{
-var response = await fetch("status");
-log("Status is " + response.statusText);
-}
-
-async function test()
-{
-setTimeout(finishSWTest, 1);
-try {
-log("Registering service worker");
-await navigator.serviceWorker.register("resources/service-worker-cache-api-worker.js", { });
-log("Service worker registered");
-
-await logStatus();
-
-log("Fetching");
-var response = await fetch("/resources/square100.png.fromserviceworker");
-var buffer =  await response.arrayBuffer();
-log("Response buffer byte length is " + buffer.byteLength);
-
-await logStatus();
-} catch(e) {
-await logStatus();
-log("Got exception: " + e);
-}
-finishSWTest();
-}
-
-test();


Modified: trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https-expected.txt (226198 => 226199)

--- trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https-expected.txt	2017-12-20 21:08:57 UTC (rev 226198)
+++ trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https-expected.txt	2017-12-20 21:38:50 UTC (rev 226199)
@@ -1,7 +1,4 @@
-Registering service worker
-Service worker registered
-Status is Not Found
-Fetching
-Response buffer byte length is 338
-Status is Not Found
 
+
+PASS Testing cache API in service worker 
+


Modified: trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https.html (226198 => 226199)

--- trunk/LayoutTests/http/tests/workers/service/service-worker-cache-api.https.html	2017-12-20 21:08:57 UTC (rev 226198)
+++ 

[webkit-changes] [226198] trunk/LayoutTests

[commit-queue]

Title: [226198] trunk/LayoutTests








Revision 226198
Author commit-qu...@webkit.org
Date 2017-12-20 13:08:57 -0800 (Wed, 20 Dec 2017)


Log Message
[GTK] imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.html is failing
https://bugs.webkit.org/show_bug.cgi?id=181029

Patch by Alicia Boya García  on 2017-12-20
Reviewed by Carlos Alberto Lopez Perez.

* platform/gtk/TestExpectations:
* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (226197 => 226198)

--- trunk/LayoutTests/ChangeLog	2017-12-20 20:10:24 UTC (rev 226197)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 21:08:57 UTC (rev 226198)
@@ -1,3 +1,14 @@
+2017-12-20  Alicia Boya García  
+
+[GTK] imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=181029
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
+* platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:
+
 2017-12-20  Youenn Fablet  
 
 LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (226197 => 226198)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 20:10:24 UTC (rev 226197)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 21:08:57 UTC (rev 226198)
@@ -1202,8 +1202,6 @@
 #
 
 webkit.org/b/178781 http/tests/inspector/network/har/har-page.html [ Failure ]
-webkit.org/b/181029 imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.html [ Failure ]
-webkit.org/b/181029 imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker.html [ Failure ]
 
 #
 # 3. TESTS CRASHING


Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt (226197 => 226198)

--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt	2017-12-20 20:10:24 UTC (rev 226197)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt	2017-12-20 21:08:57 UTC (rev 226198)
@@ -7,7 +7,7 @@
 PASS Fetch with POST with text body 
 PASS Fetch with POST with FormData body 
 PASS Fetch with POST with URLSearchParams body 
-FAIL Fetch with POST with Blob body assert_equals: Request should have header content-type: null expected (object) null but got (string) ""
+PASS Fetch with POST with Blob body 
 PASS Fetch with POST with ArrayBuffer body 
 PASS Fetch with POST with Uint8Array body 
 PASS Fetch with POST with Int8Array body 


Modified: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt (226197 => 226198)

--- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt	2017-12-20 20:10:24 UTC (rev 226197)
+++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt	2017-12-20 21:08:57 UTC (rev 226198)
@@ -7,7 +7,7 @@
 PASS Fetch with POST with text body 
 FAIL Fetch with POST with FormData body Can't find variable: FormData
 PASS Fetch with POST with URLSearchParams body 
-FAIL Fetch with POST with Blob body assert_equals: Request should have header content-type: null expected (object) null but got (string) ""
+PASS Fetch with POST with Blob body 
 PASS Fetch with POST with ArrayBuffer body 
 PASS Fetch with POST with Uint8Array body 
 PASS Fetch with POST with Int8Array body 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226196] trunk/Source/WebCore

[zalan]

Title: [226196] trunk/Source/WebCore








Revision 226196
Author za...@apple.com
Date 2017-12-20 12:07:52 -0800 (Wed, 20 Dec 2017)


Log Message
[RenderTreeBuilder] Replace remaining addChild calls with RenderTreeBuilder::insert
https://bugs.webkit.org/show_bug.cgi?id=181044


Reviewed by Antti Koivisto.

Covered by existing test cases.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringContinuation):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::addChildIgnoringContinuation):
* rendering/RenderElement.h:
(WebCore::RenderElement::addChildIgnoringContinuation): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226195 => 226196)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 20:04:54 UTC (rev 226195)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 20:07:52 UTC (rev 226196)
@@ -1,3 +1,20 @@
+2017-12-20  Zalan Bujtas  
+
+[RenderTreeBuilder] Replace remaining addChild calls with RenderTreeBuilder::insert
+https://bugs.webkit.org/show_bug.cgi?id=181044
+
+
+Reviewed by Antti Koivisto.
+
+Covered by existing test cases.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::addChildIgnoringContinuation):
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::addChildIgnoringContinuation):
+* rendering/RenderElement.h:
+(WebCore::RenderElement::addChildIgnoringContinuation): Deleted.
+
 2017-12-20  Daniel Bates  
 
 Cleanup: Dereference value of optional directly instead of using checked value in WebCore::subdivide()


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (226195 => 226196)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2017-12-20 20:04:54 UTC (rev 226195)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2017-12-20 20:07:52 UTC (rev 226196)
@@ -562,9 +562,9 @@
 ) {
 // Insert the child into the anonymous block box instead of here.
 if (newChild->isInline() || beforeChild->parent()->firstChild() != beforeChild)
-beforeChild->parent()->addChild(builder, WTFMove(newChild), beforeChild);
+builder.insertChild(*beforeChild->parent(), WTFMove(newChild), beforeChild);
 else
-addChild(builder, WTFMove(newChild), beforeChild->parent());
+builder.insertChild(*this, WTFMove(newChild), beforeChild->parent());
 return;
 }
 


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (226195 => 226196)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2017-12-20 20:04:54 UTC (rev 226195)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2017-12-20 20:07:52 UTC (rev 226196)
@@ -511,6 +511,11 @@
 SVGRenderSupport::childAdded(*this, child);
 }
 
+void RenderElement::addChildIgnoringContinuation(RenderTreeBuilder& builder, RenderPtr newChild, RenderObject* beforeChild)
+{
+builder.insertChild(*this, WTFMove(newChild), beforeChild);
+}
+
 RenderPtr RenderElement::takeChild(RenderObject& oldChild)
 {
 return takeChildInternal(oldChild);


Modified: trunk/Source/WebCore/rendering/RenderElement.h (226195 => 226196)

--- trunk/Source/WebCore/rendering/RenderElement.h	2017-12-20 20:04:54 UTC (rev 226195)
+++ trunk/Source/WebCore/rendering/RenderElement.h	2017-12-20 20:07:52 UTC (rev 226196)
@@ -88,7 +88,7 @@
 
 virtual bool isChildAllowed(const RenderObject&, const RenderStyle&) const { return true; }
 virtual void addChild(RenderTreeBuilder&, RenderPtr, RenderObject* beforeChild);
-virtual void addChildIgnoringContinuation(RenderTreeBuilder& builder, RenderPtr newChild, RenderObject* beforeChild = nullptr) { addChild(builder, WTFMove(newChild), beforeChild); }
+virtual void addChildIgnoringContinuation(RenderTreeBuilder&, RenderPtr newChild, RenderObject* beforeChild = nullptr);
 virtual RenderPtr takeChild(RenderObject&) WARN_UNUSED_RETURN;
 void removeAndDestroyChild(RenderObject&);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226195] trunk/Source/WebCore

[dbates]

Title: [226195] trunk/Source/WebCore








Revision 226195
Author dba...@webkit.org
Date 2017-12-20 12:04:54 -0800 (Wed, 20 Dec 2017)


Log Message
Cleanup: Dereference value of optional directly instead of using checked value in WebCore::subdivide()
https://bugs.webkit.org/show_bug.cgi?id=181050

Reviewed by Simon Fraser.

It is sufficient and more efficient to dereference a std::optional directly when we know that it has
a value as opposed to using the checked dereference member function std::optional<>::value().

No functionality changed. So, no new tests.

* rendering/MarkerSubrange.cpp:
(WebCore::subdivide):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/MarkerSubrange.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226194 => 226195)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 19:59:35 UTC (rev 226194)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 20:04:54 UTC (rev 226195)
@@ -1,5 +1,20 @@
 2017-12-20  Daniel Bates  
 
+Cleanup: Dereference value of optional directly instead of using checked value in WebCore::subdivide()
+https://bugs.webkit.org/show_bug.cgi?id=181050
+
+Reviewed by Simon Fraser.
+
+It is sufficient and more efficient to dereference a std::optional directly when we know that it has
+a value as opposed to using the checked dereference member function std::optional<>::value().
+
+No functionality changed. So, no new tests.
+
+* rendering/MarkerSubrange.cpp:
+(WebCore::subdivide):
+
+2017-12-20  Daniel Bates  
+
 MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange} are failing
 https://bugs.webkit.org/show_bug.cgi?id=181014
 


Modified: trunk/Source/WebCore/rendering/MarkerSubrange.cpp (226194 => 226195)

--- trunk/Source/WebCore/rendering/MarkerSubrange.cpp	2017-12-20 19:59:35 UTC (rev 226194)
+++ trunk/Source/WebCore/rendering/MarkerSubrange.cpp	2017-12-20 20:04:54 UTC (rev 226195)
@@ -76,12 +76,12 @@
 if (frontmost) {
 if (overlapStrategy == OverlapStrategy::FrontmostWithLongestEffectiveRange && !result.isEmpty()) {
 auto& previous = result.last();
-if (previous.endOffset == offsetSoFar && previous.type == offsets[frontmost.value()].subrange->type && previous.marker == offsets[frontmost.value()].subrange->marker)
+if (previous.endOffset == offsetSoFar && previous.type == offsets[*frontmost].subrange->type && previous.marker == offsets[*frontmost].subrange->marker)
 previous.endOffset = offsets[i].value;
 else
-result.append({ offsetSoFar, offsets[i].value, offsets[frontmost.value()].subrange->type, offsets[frontmost.value()].subrange->marker });
+result.append({ offsetSoFar, offsets[i].value, offsets[*frontmost].subrange->type, offsets[*frontmost].subrange->marker });
 } else
-result.append({ offsetSoFar, offsets[i].value, offsets[frontmost.value()].subrange->type, offsets[frontmost.value()].subrange->marker });
+result.append({ offsetSoFar, offsets[i].value, offsets[*frontmost].subrange->type, offsets[*frontmost].subrange->marker });
 }
 } else {
 // The appended subranges may not be in paint order. We will fix this up at the end of this function.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226194] trunk

[dbates]

Title: [226194] trunk








Revision 226194
Author dba...@webkit.org
Date 2017-12-20 11:59:35 -0800 (Wed, 20 Dec 2017)


Log Message
MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange} are failing
https://bugs.webkit.org/show_bug.cgi?id=181014

Reviewed by Simon Fraser.

Source/WebCore:

Fixes an issue in the subdivision algorithm where the returned subranges may not be paint order
or reverse paint order when using the default overlap strategy (OverlapStrategy::None) and
either OverlapStrategy::Frontmost or OverlapStrategy::FrontmostWithLongestEffectiveRange, respectively.

Currently we compute the overlapping subranges up to some point p_i on the line by sweeping from the
start of the line through all the unclosed subranges. The unclosed subranges are sorted along the line.
That is, they are not sorted by paint order or reverse paint order. Therefore we must take care to
ensure that we return the computed overlapping subranges with respect to paint order/reverse paint order.

* rendering/MarkerSubrange.cpp:
(WebCore::subdivide):

Tools:

Adds a new test to ensure we compute overlapping subranges in paint order for the default
overlap strategy. Enable tests MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange}
now that they pass.

* TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/MarkerSubrange.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226193 => 226194)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 19:29:08 UTC (rev 226193)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 19:59:35 UTC (rev 226194)
@@ -1,3 +1,22 @@
+2017-12-20  Daniel Bates  
+
+MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange} are failing
+https://bugs.webkit.org/show_bug.cgi?id=181014
+
+Reviewed by Simon Fraser.
+
+Fixes an issue in the subdivision algorithm where the returned subranges may not be paint order
+or reverse paint order when using the default overlap strategy (OverlapStrategy::None) and
+either OverlapStrategy::Frontmost or OverlapStrategy::FrontmostWithLongestEffectiveRange, respectively.
+
+Currently we compute the overlapping subranges up to some point p_i on the line by sweeping from the
+start of the line through all the unclosed subranges. The unclosed subranges are sorted along the line.
+That is, they are not sorted by paint order or reverse paint order. Therefore we must take care to
+ensure that we return the computed overlapping subranges with respect to paint order/reverse paint order.
+
+* rendering/MarkerSubrange.cpp:
+(WebCore::subdivide):
+
 2017-12-20  Youenn Fablet  
 
 LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure


Modified: trunk/Source/WebCore/rendering/MarkerSubrange.cpp (226193 => 226194)

--- trunk/Source/WebCore/rendering/MarkerSubrange.cpp	2017-12-20 19:29:08 UTC (rev 226193)
+++ trunk/Source/WebCore/rendering/MarkerSubrange.cpp	2017-12-20 19:59:35 UTC (rev 226194)
@@ -70,7 +70,7 @@
 if (overlapStrategy == OverlapStrategy::Frontmost || overlapStrategy == OverlapStrategy::FrontmostWithLongestEffectiveRange) {
 std::optional frontmost;
 for (unsigned j = 0; j < i; ++j) {
-if (!processedSubranges.contains(offsets[j].subrange))
+if (!processedSubranges.contains(offsets[j].subrange) && (!frontmost || offsets[j].subrange->type > offsets[*frontmost].subrange->type))
 frontmost = j;
 }
 if (frontmost) {
@@ -84,6 +84,7 @@
 result.append({ offsetSoFar, offsets[i].value, offsets[frontmost.value()].subrange->type, offsets[frontmost.value()].subrange->marker });
 }
 } else {
+// The appended subranges may not be in paint order. We will fix this up at the end of this function.
 for (unsigned j = 0; j < i; ++j) {
 if (!processedSubranges.contains(offsets[j].subrange))
 result.append({ offsetSoFar, offsets[i].value, offsets[j].subrange->type, offsets[j].subrange->marker });
@@ -94,6 +95,9 @@
 if (offsets[i].kind == Offset::End)
 processedSubranges.add(offsets[i].subrange);
 }
+// Fix up; sort the subranges so that they are in paint order.
+if (overlapStrategy == OverlapStrategy::None)
+std::sort(result.begin(), result.end(), [] (const MarkerSubrange& a, const MarkerSubrange& b) { return a.startOffset < b.startOffset || (a.startOffset == b.startOffset && a.type < 

[webkit-changes] [226193] trunk

[commit-queue]

Title: [226193] trunk








Revision 226193
Author commit-qu...@webkit.org
Date 2017-12-20 11:29:08 -0800 (Wed, 20 Dec 2017)


Log Message
LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179137


Patch by Youenn Fablet  on 2017-12-20
Reviewed by Chris Dumez.

Source/WebCore:

Covered by unflaked test.

* workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::postTaskToLoader): ThreadableBlobRegistry is using callOnMainThread.
Use it also for postTaskToLoader so that there is no race condition between registering a blob and reading it.

LayoutTests:

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (226192 => 226193)

--- trunk/LayoutTests/ChangeLog	2017-12-20 19:19:13 UTC (rev 226192)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 19:29:08 UTC (rev 226193)
@@ -1,3 +1,13 @@
+2017-12-20  Youenn Fablet  
+
+LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=179137
+
+
+Reviewed by Chris Dumez.
+
+* TestExpectations:
+
 2017-12-20  Alicia Boya García  
 
 [GTK] Test gardening


Modified: trunk/LayoutTests/TestExpectations (226192 => 226193)

--- trunk/LayoutTests/TestExpectations	2017-12-20 19:19:13 UTC (rev 226192)
+++ trunk/LayoutTests/TestExpectations	2017-12-20 19:29:08 UTC (rev 226193)
@@ -167,7 +167,6 @@
 webkit.org/b/179342 http/tests/workers/service/registration-task-queue-scheduling-1.html [ Pass Failure ]
 http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/about-blank-replacement.https.html [ Pass Failure ]
-webkit.org/b/179137 imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ DumpJSConsoleLogInStdErr Pass Failure ]
 webkit.org/b/179248 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https.html [ Pass Failure ]


Modified: trunk/Source/WebCore/ChangeLog (226192 => 226193)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 19:19:13 UTC (rev 226192)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 19:29:08 UTC (rev 226193)
@@ -1,5 +1,19 @@
 2017-12-20  Youenn Fablet  
 
+LayoutTest imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=179137
+
+
+Reviewed by Chris Dumez.
+
+Covered by unflaked test.
+
+* workers/service/context/ServiceWorkerThreadProxy.cpp:
+(WebCore::ServiceWorkerThreadProxy::postTaskToLoader): ThreadableBlobRegistry is using callOnMainThread.
+Use it also for postTaskToLoader so that there is no race condition between registering a blob and reading it.
+
+2017-12-20  Youenn Fablet  
+
 Support service worker interception of request with blob body
 https://bugs.webkit.org/show_bug.cgi?id=181035
 


Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp (226192 => 226193)

--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp	2017-12-20 19:19:13 UTC (rev 226192)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThreadProxy.cpp	2017-12-20 19:29:08 UTC (rev 226193)
@@ -32,6 +32,7 @@
 #include "FrameLoader.h"
 #include "MainFrame.h"
 #include 
+#include 
 #include 
 
 namespace WebCore {
@@ -80,7 +81,7 @@
 
 void ServiceWorkerThreadProxy::postTaskToLoader(ScriptExecutionContext::Task&& task)
 {
-RunLoop::main().dispatch([task = WTFMove(task), this, protectedThis = makeRef(*this)] () mutable {
+callOnMainThread([task = WTFMove(task), this, protectedThis = makeRef(*this)] () mutable {
 task.performTask(m_document.get());
 });
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226192] trunk/LayoutTests

[commit-queue]

Title: [226192] trunk/LayoutTests








Revision 226192
Author commit-qu...@webkit.org
Date 2017-12-20 11:19:13 -0800 (Wed, 20 Dec 2017)


Log Message
[GTK] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=181045

Patch by Alicia Boya García  on 2017-12-20
Reviewed by Michael Catanzaro.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (226191 => 226192)

--- trunk/LayoutTests/ChangeLog	2017-12-20 19:16:10 UTC (rev 226191)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 19:19:13 UTC (rev 226192)
@@ -1,3 +1,12 @@
+2017-12-20  Alicia Boya García  
+
+[GTK] Test gardening
+https://bugs.webkit.org/show_bug.cgi?id=181045
+
+Reviewed by Michael Catanzaro.
+
+* platform/gtk/TestExpectations:
+
 2017-12-20  Daniel Bates  
 
 Remove Alternative Presentation Button


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (226191 => 226192)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 19:16:10 UTC (rev 226191)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 19:19:13 UTC (rev 226192)
@@ -779,7 +779,7 @@
 webkit.org/b/128172 fast/events/touch/multi-touch-inside-iframes.html [ Timeout ]
 webkit.org/b/128172 fast/events/touch/basic-single-touch-events.html [ Crash Timeout ]
 webkit.org/b/128172 fast/events/touch/page-scaled-touch-gesture-click.html [ Timeout ]
-webkit.org/b/128172 fast/events/touch/touch-target.html [ Timeout ]
+webkit.org/b/128172 fast/events/touch/touch-target.html [ Crash Timeout ]
 webkit.org/b/128172 fast/events/touch/touch-target-limited.html [ Crash Timeout ]
 webkit.org/b/128172 fast/events/touch/send-oncancel-event.html [ Timeout ]
 
@@ -1201,6 +1201,10 @@
 # Don't add anything above here without a comment explaining why the test should fail.
 #
 
+webkit.org/b/178781 http/tests/inspector/network/har/har-page.html [ Failure ]
+webkit.org/b/181029 imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.html [ Failure ]
+webkit.org/b/181029 imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker.html [ Failure ]
+
 #
 # 3. TESTS CRASHING
 #
@@ -1902,6 +1906,10 @@
 
 webkit.org/b/179174 inspector/console/webcore-logging.html [ Failure Crash ]
 
+webkit.org/b/181030 wasm/iframe-postmessage.html [ Pass Failure ]
+webkit.org/b/179948 [ Release ] fast/hidpi/filters-reference.html [ Pass ImageOnlyFailure ]
+webkit.org/b/181031 fast/frames/crash-when-iframe-is-remove-in-eventhandler.html [ Pass Crash ]
+
 #
 # End of Flaky tests
 #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226191] trunk

[commit-queue]

Title: [226191] trunk








Revision 226191
Author commit-qu...@webkit.org
Date 2017-12-20 11:16:10 -0800 (Wed, 20 Dec 2017)


Log Message
Support service worker interception of request with blob body
https://bugs.webkit.org/show_bug.cgi?id=181035

Patch by Youenn Fablet  on 2017-12-20
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt:

Source/WebCore:

Covered by updated test.

Add support for getting blob request bodies within service worker.
Disable interception of requests with form datas.

* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::fromFormData):
* Modules/fetch/FetchBody.h:
* workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
* workers/service/context/ServiceWorkerFetch.h:
* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::postFetchTask):

Source/WebKit:

In case of service worker, remove the connection check to get access to the blob registry.
Apply this for cloning blobs registered by another process.

* NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
* NetworkProcess/FileAPI/NetworkBlobRegistry.h:
* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerBlobURL):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp
trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.h
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp
trunk/Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.h
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
trunk/Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226190 => 226191)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-12-20 18:55:53 UTC (rev 226190)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-12-20 19:16:10 UTC (rev 226191)
@@ -1,3 +1,13 @@
+2017-12-20  Youenn Fablet  
+
+Support service worker interception of request with blob body
+https://bugs.webkit.org/show_bug.cgi?id=181035
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
+* web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt:
+
 2017-12-20  Chris Dumez  
 
 Do not reuse resource for memory cache if selected service worker differs


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt (226190 => 226191)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt	2017-12-20 18:55:53 UTC (rev 226190)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt	2017-12-20 19:16:10 UTC (rev 226191)
@@ -16,6 +16,6 @@
 PASS Service Worker should intercept EventSource 
 PASS Service Worker responds to fetch event with the correct integrity_metadata 
 PASS FetchEvent#body is a string 
-FAIL FetchEvent#body is a blob assert_equals: expected "it's me the blob and more blob!" but got ""
+PASS FetchEvent#body is a blob 
 PASS Service Worker responds to fetch event with the correct keepalive value 
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt (226190 => 226191)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt	2017-12-20 18:55:53 UTC (rev 226190)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt	2017-12-20 19:16:10 UTC (rev 226191)
@@ -5,10 +5,10 @@
 PASS event.request has the expected headers for cross-origin GET. 
 

[webkit-changes] [226190] trunk/Source/WebCore

[commit-queue]

Title: [226190] trunk/Source/WebCore








Revision 226190
Author commit-qu...@webkit.org
Date 2017-12-20 10:55:53 -0800 (Wed, 20 Dec 2017)


Log Message
Send fullscreenChange earlier, in webkitWillEnterFullscreen
https://bugs.webkit.org/show_bug.cgi?id=181016

Patch by Jeremy Jones  on 2017-12-20
Reviewed by Jer Noble.

Sending the event earlier, allows pages to update their interface state before the fullscreen animation.

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidEnterFullScreenForElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226189 => 226190)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 18:43:22 UTC (rev 226189)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 18:55:53 UTC (rev 226190)
@@ -1,3 +1,16 @@
+2017-12-20  Jeremy Jones  
+
+Send fullscreenChange earlier, in webkitWillEnterFullscreen
+https://bugs.webkit.org/show_bug.cgi?id=181016
+
+Reviewed by Jer Noble.
+
+Sending the event earlier, allows pages to update their interface state before the fullscreen animation.
+
+* dom/Document.cpp:
+(WebCore::Document::webkitWillEnterFullScreenForElement):
+(WebCore::Document::webkitDidEnterFullScreenForElement):
+
 2017-12-20  Daniel Bates  
 
 Remove Alternative Presentation Button


Modified: trunk/Source/WebCore/dom/Document.cpp (226189 => 226190)

--- trunk/Source/WebCore/dom/Document.cpp	2017-12-20 18:43:22 UTC (rev 226189)
+++ trunk/Source/WebCore/dom/Document.cpp	2017-12-20 18:55:53 UTC (rev 226190)
@@ -6213,6 +6213,9 @@
 m_fullScreenElement->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(true);
 
 resolveStyle(ResolveStyleType::Rebuild);
+#if PLATFORM(IOS) && ENABLE(FULLSCREEN_API)
+m_fullScreenChangeDelayTimer.startOneShot(0_s);
+#endif
 }
 
 void Document::webkitDidEnterFullScreenForElement(Element*)
@@ -6225,7 +6228,9 @@
 
 m_fullScreenElement->didBecomeFullscreenElement();
 
+#if !PLATFORM(IOS) || !ENABLE(FULLSCREEN_API)
 m_fullScreenChangeDelayTimer.startOneShot(0_s);
+#endif
 }
 
 void Document::webkitWillExitFullScreenForElement(Element*)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226188] trunk

[cdumez]

Title: [226188] trunk








Revision 226188
Author cdu...@apple.com
Date 2017-12-20 10:30:06 -0800 (Wed, 20 Dec 2017)


Log Message
Do not reuse resource for memory cache if selected service worker differs
https://bugs.webkit.org/show_bug.cgi?id=181042

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is consistently passing.

* web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:

Source/WebCore:

No new tests, rebaselined existing test.

* loader/cache/CachedResource.h:
(WebCore::CachedResource::options const):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):

LayoutTests:

Drop test from flaky list now that it is consistently passing.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (226187 => 226188)

--- trunk/LayoutTests/ChangeLog	2017-12-20 18:08:51 UTC (rev 226187)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 18:30:06 UTC (rev 226188)
@@ -1,3 +1,14 @@
+2017-12-20  Chris Dumez  
+
+Do not reuse resource for memory cache if selected service worker differs
+https://bugs.webkit.org/show_bug.cgi?id=181042
+
+Reviewed by Youenn Fablet.
+
+Drop test from flaky list now that it is consistently passing.
+
+* TestExpectations:
+
 2017-12-20  Matt Lewis  
 
 Marked svg/animations/smil-leak-element-instances-noBaseValRef.svg as flaky on macOS WK1.


Modified: trunk/LayoutTests/TestExpectations (226187 => 226188)

--- trunk/LayoutTests/TestExpectations	2017-12-20 18:08:51 UTC (rev 226187)
+++ trunk/LayoutTests/TestExpectations	2017-12-20 18:30:06 UTC (rev 226188)
@@ -180,7 +180,6 @@
 imported/w3c/web-platform-tests/service-workers/service-worker/registration-service-worker-attributes.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/uncontrolled-page.https.html [ Pass Failure ]
-imported/w3c/web-platform-tests/service-workers/service-worker/unregister-controller.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/websocket.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.serviceworker.https.html [ Pass Failure ]


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (226187 => 226188)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-12-20 18:08:51 UTC (rev 226187)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-12-20 18:30:06 UTC (rev 226188)
@@ -1,3 +1,14 @@
+2017-12-20  Chris Dumez  
+
+Do not reuse resource for memory cache if selected service worker differs
+https://bugs.webkit.org/show_bug.cgi?id=181042
+
+Reviewed by Youenn Fablet.
+
+Rebaseline WPT test now that it is consistently passing.
+
+* web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
+
 2017-12-19  Chris Dumez  
 
 [Fetch] Extracting a body of type Blob should not set Content-Type to the empty string


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt (226187 => 226188)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt	2017-12-20 18:08:51 UTC (rev 226187)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt	2017-12-20 18:30:06 UTC (rev 226188)
@@ -1,6 +1,6 @@
 
 
 PASS Unregister does not affect existing controller 
-FAIL Unregister prevents control of subsequent navigations assert_unreached: unexpected rejection: assert_equals: requests should not be intercepted expected "a simple text file\n" but got "intercepted by service worker" Reached unreachable code
+PASS Unregister prevents control of subsequent navigations 
 PASS Unregister prevents new controllee even if registration is still in use 
 


Modified: trunk/Source/WebCore/ChangeLog (226187 => 226188)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 18:08:51 UTC (rev 226187)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 18:30:06 UTC (rev 226188)
@@ -1,3 +1,17 @@
+2017-12-20  Chris Dumez  
+
+Do not reuse resource for memory cache 

[webkit-changes] [226187] trunk/LayoutTests

[jlewis3]

Title: [226187] trunk/LayoutTests








Revision 226187
Author jlew...@apple.com
Date 2017-12-20 10:08:51 -0800 (Wed, 20 Dec 2017)


Log Message
Marked svg/animations/smil-leak-element-instances-noBaseValRef.svg as flaky on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=180997

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (226186 => 226187)

--- trunk/LayoutTests/ChangeLog	2017-12-20 17:32:01 UTC (rev 226186)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 18:08:51 UTC (rev 226187)
@@ -1,3 +1,12 @@
+2017-12-20  Matt Lewis  
+
+Marked svg/animations/smil-leak-element-instances-noBaseValRef.svg as flaky on macOS WK1.
+https://bugs.webkit.org/show_bug.cgi?id=180997
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2017-12-20  Ms2ger  
 
 Remove some obsolete test expectations for GTK.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (226186 => 226187)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-12-20 17:32:01 UTC (rev 226186)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2017-12-20 18:08:51 UTC (rev 226187)
@@ -482,3 +482,5 @@
 
 webkit.org/b/181008 http/tests/images/image-supports-video.html [ Pass Failure ]
 
+webkit.org/b/180997 svg/animations/smil-leak-element-instances-noBaseValRef.svg [ Pass Failure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226186] trunk/LayoutTests

[Ms2ger]

Title: [226186] trunk/LayoutTests








Revision 226186
Author ms2...@igalia.com
Date 2017-12-20 09:32:01 -0800 (Wed, 20 Dec 2017)


Log Message
Remove some obsolete test expectations for GTK.
https://bugs.webkit.org/show_bug.cgi?id=181038

Unreviewed test gardening.


* platform/gtk/TestExpectations:
  - Remove tests that now use a matching expectation.
  - Move a test out of the "Unexplained failures" section.
  - Remove a test that is now skipped in all wk2 ports.
* platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
  Removed: the generic file is correct for GTK as well.
* platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
  Removed: the generic file is correct for GTK as well.
* platform/mac-wk2/TestExpectations:
  Remove a test that is now skipped in all wk2 ports.
* platform/wk2/TestExpectations:
  Add another test to the list of skipped tests that use beginDragWithFiles,
  which is only implemented in DumpRenderTree.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations


Removed Paths

trunk/LayoutTests/platform/gtk/fast/forms/mailto/




Diff

Modified: trunk/LayoutTests/ChangeLog (226185 => 226186)

--- trunk/LayoutTests/ChangeLog	2017-12-20 17:22:36 UTC (rev 226185)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 17:32:01 UTC (rev 226186)
@@ -1,5 +1,26 @@
 2017-12-20  Ms2ger  
 
+Remove some obsolete test expectations for GTK.
+https://bugs.webkit.org/show_bug.cgi?id=181038
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+  - Remove tests that now use a matching expectation.
+  - Move a test out of the "Unexplained failures" section.
+  - Remove a test that is now skipped in all wk2 ports.
+* platform/gtk/fast/forms/mailto/formenctype-attribute-button-html-expected.txt:
+  Removed: the generic file is correct for GTK as well.
+* platform/gtk/fast/forms/mailto/formenctype-attribute-input-html-expected.txt:
+  Removed: the generic file is correct for GTK as well.
+* platform/mac-wk2/TestExpectations:
+  Remove a test that is now skipped in all wk2 ports.
+* platform/wk2/TestExpectations:
+  Add another test to the list of skipped tests that use beginDragWithFiles,
+  which is only implemented in DumpRenderTree.
+
+2017-12-20  Ms2ger  
+
 [GTK] Rebaseline fast/canvas/canvas-imageSmoothingQuality.html
 https://bugs.webkit.org/show_bug.cgi?id=163973
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (226185 => 226186)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 17:22:36 UTC (rev 226185)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 17:32:01 UTC (rev 226186)
@@ -2402,6 +2402,9 @@
 # https://bugs.webkit.org/show_bug.cgi?id=39160
 webkit.org/b/39160 security/block-test-no-port.html [ Failure ]
 
+# Missing support for the modifierArray argument to EventSendingController::mouseMoveTo().
+Bug(GTK) platform/gtk/fast/events/event-sender-metakey.html [ Failure ]
+
 # Unexplained failures
 Bug(GTK) fast/css/disabled-author-styles.html [ Failure ]
 Bug(GTK) fast/events/keydown-numpad-keys.html [ Failure ]
@@ -2408,8 +2411,6 @@
 Bug(GTK) fast/events/remove-target-with-shadow-in-drag.html [ Failure ]
 Bug(GTK) fast/forms/listbox-typeahead-cyrillic.html [ Failure ]
 Bug(GTK) fast/forms/listbox-typeahead-greek.html [ Failure ]
-Bug(GTK) fast/forms/mailto/formenctype-attribute-button-html.html [ Failure ]
-Bug(GTK) fast/forms/mailto/formenctype-attribute-input-html.html [ Failure ]
 Bug(GTK) fast/forms/select-type-ahead-non-latin.html [ Failure ]
 Bug(GTK) fast/ruby/nested-ruby.html [ Failure ]
 Bug(GTK) fast/ruby/ruby-beforeafter.html [ Failure ]
@@ -2434,7 +2435,6 @@
 Bug(GTK) http/tests/security/cross-origin-xsl-redirect-BLOCKED.html [ Failure ]
 Bug(GTK) http/tests/security/storage-blocking-strengthened-plugin.html [ Failure ]
 Bug(GTK) http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html [ Failure ]
-Bug(GTK) platform/gtk/fast/events/event-sender-metakey.html [ Failure ]
 Bug(GTK) plugins/keyboard-events.html [ Failure ]
 Bug(GTK) plugins/netscape-plugin-setwindow-size-2.html [ Failure ]
 Bug(GTK) plugins/npp-set-window-called-during-destruction.html [ Failure ]
@@ -2455,8 +2455,6 @@
 
 Bug(GTK) fast/css/sticky/sticky-top-zoomed.html [ ImageOnlyFailure ]
 
-Bug(GTK) fast/forms/file/input-file-value.html [ Failure ]
-
 Bug(GTK) fast/forms/select/popup-closes-on-blur.html [ Failure ]
 
 # Shared workers disabled with the Network Process


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (226185 => 226186)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-12-20 17:22:36 UTC (rev 226185)
+++ 

[webkit-changes] [226185] trunk/Source/WebCore

[commit-queue]

Title: [226185] trunk/Source/WebCore








Revision 226185
Author commit-qu...@webkit.org
Date 2017-12-20 09:22:36 -0800 (Wed, 20 Dec 2017)


Log Message
Do not search for service worker registration in case of non HTTP navigation loads
https://bugs.webkit.org/show_bug.cgi?id=180976

Patch by Youenn Fablet  on 2017-12-20
Reviewed by Chris Dumez.

Covered by manual testing using perf test app uploaded in https://bugs.webkit.org/show_bug.cgi?id=180929.
In case we are sure there is no possiblity for getting a service worker, skip the search step.
Simialrly, do not report any Document as a Service Worker client if it can never be controlled.
A follow-up patch should handle the case of local URLs service worker selection.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
(WebCore::DocumentLoader::commitData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226184 => 226185)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 17:19:39 UTC (rev 226184)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 17:22:36 UTC (rev 226185)
@@ -1,3 +1,19 @@
+2017-12-20  Youenn Fablet  
+
+Do not search for service worker registration in case of non HTTP navigation loads
+https://bugs.webkit.org/show_bug.cgi?id=180976
+
+Reviewed by Chris Dumez.
+
+Covered by manual testing using perf test app uploaded in https://bugs.webkit.org/show_bug.cgi?id=180929.
+In case we are sure there is no possiblity for getting a service worker, skip the search step.
+Simialrly, do not report any Document as a Service Worker client if it can never be controlled.
+A follow-up patch should handle the case of local URLs service worker selection.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::startLoadingMainResource):
+(WebCore::DocumentLoader::commitData):
+
 2017-12-20  Andy Estes  
 
 [Apple Pay] Tell PassKit whether Apple Pay JS or Payment Request was used to start an Apple Pay session


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (226184 => 226185)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2017-12-20 17:19:39 UTC (rev 226184)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2017-12-20 17:22:36 UTC (rev 226185)
@@ -890,7 +890,8 @@
 m_frame->document()->setActiveServiceWorker(ServiceWorker::getOrCreate(*m_frame->document(), WTFMove(m_serviceWorkerRegistrationData->activeWorker.value(;
 m_serviceWorkerRegistrationData = { };
 }
-m_frame->document()->setServiceWorkerConnection(::singleton().serviceWorkerConnectionForSession(m_frame->page()->sessionID()));
+if (SchemeRegistry::canServiceWorkersHandleURLScheme(m_frame->document()->url().protocol().toStringWithoutCopying()))
+m_frame->document()->setServiceWorkerConnection(::singleton().serviceWorkerConnectionForSession(m_frame->page()->sessionID()));
 }
 #endif
 // Call receivedFirstData() exactly once per load. We should only reach this point multiple times
@@ -1568,7 +1569,8 @@
 RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Starting load (frame = %p, main = %d)", m_frame, m_frame->isMainFrame());
 
 #if ENABLE(SERVICE_WORKER)
-auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled();
+// FIXME: Implement local URL interception by getting the service worker of the parent.
+auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled()&& SchemeRegistry::canServiceWorkersHandleURLScheme(request.url().protocol().toStringWithoutCopying());
 if (tryLoadingThroughServiceWorker) {
 auto origin = (!m_frame->isMainFrame() && m_frame->document()) ? makeRef(m_frame->document()->topOrigin()) : SecurityOrigin::create(request.url());
 auto& connection = ServiceWorkerProvider::singleton().serviceWorkerConnectionForSession(m_frame->page()->sessionID());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226184] trunk/LayoutTests

[Ms2ger]

Title: [226184] trunk/LayoutTests








Revision 226184
Author ms2...@igalia.com
Date 2017-12-20 09:19:39 -0800 (Wed, 20 Dec 2017)


Log Message
[GTK] Rebaseline fast/canvas/canvas-imageSmoothingQuality.html
https://bugs.webkit.org/show_bug.cgi?id=163973

Unreviewed test gardening.


* platform/gtk/TestExpectations: Remove failure annotation.
* platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt:
  Rebaseline: r202609 added additional output when one of the assertions
  fails, which happens in this test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (226183 => 226184)

--- trunk/LayoutTests/ChangeLog	2017-12-20 17:16:11 UTC (rev 226183)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 17:19:39 UTC (rev 226184)
@@ -1,3 +1,15 @@
+2017-12-20  Ms2ger  
+
+[GTK] Rebaseline fast/canvas/canvas-imageSmoothingQuality.html
+https://bugs.webkit.org/show_bug.cgi?id=163973
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations: Remove failure annotation.
+* platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt:
+  Rebaseline: r202609 added additional output when one of the assertions
+  fails, which happens in this test.
+
 2017-12-20  Matt Lewis  
 
 Marked two imported/w3c/web-platform-tests/service-workers/service-worker/ test as slow.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (226183 => 226184)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 17:16:11 UTC (rev 226183)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 17:19:39 UTC (rev 226184)
@@ -3080,8 +3080,6 @@
 
 webkit.org/b/163972 fast/canvas/canvas-gradient-addStop-error.html [ Failure ]
 
-webkit.org/b/163973 fast/canvas/canvas-imageSmoothingQuality.html [ Failure ]
-
 webkit.org/b/163974 fast/canvas/drawImage-with-negative-source-destination.html [ Failure ]
 
 webkit.org/b/163976 fast/css/user-drag-none.html [ Failure ]


Modified: trunk/LayoutTests/platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt (226183 => 226184)

--- trunk/LayoutTests/platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt	2017-12-20 17:16:11 UTC (rev 226183)
+++ trunk/LayoutTests/platform/gtk/fast/canvas/canvas-imageSmoothingQuality-expected.txt	2017-12-20 17:19:39 UTC (rev 226184)
@@ -35,6 +35,7 @@
 PASS scaleImageData(highCanvas, highCanvas.imageSmoothingQuality); is highData
 
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
  






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226183] trunk/LayoutTests

[jlewis3]

Title: [226183] trunk/LayoutTests








Revision 226183
Author jlew...@apple.com
Date 2017-12-20 09:16:11 -0800 (Wed, 20 Dec 2017)


Log Message
Marked two imported/w3c/web-platform-tests/service-workers/service-worker/ test as slow.
https://bugs.webkit.org/show_bug.cgi?id=180982
https://bugs.webkit.org/show_bug.cgi?id=179194

Unreviewed test expectations.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (226182 => 226183)

--- trunk/LayoutTests/ChangeLog	2017-12-20 17:11:29 UTC (rev 226182)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 17:16:11 UTC (rev 226183)
@@ -1,3 +1,13 @@
+2017-12-20  Matt Lewis  
+
+Marked two imported/w3c/web-platform-tests/service-workers/service-worker/ test as slow.
+https://bugs.webkit.org/show_bug.cgi?id=180982
+https://bugs.webkit.org/show_bug.cgi?id=179194
+
+Unreviewed test expectations.
+
+* platform/mac-wk2/TestExpectations:
+
 2017-12-20  Frederic Wang  
 
 Split layout of RenderMathMLRow into smaller steps


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (226182 => 226183)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-12-20 17:11:29 UTC (rev 226182)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-12-20 17:16:11 UTC (rev 226183)
@@ -849,3 +849,7 @@
 
 webkit.org/b/173742 security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html [ Pass Failure ]
 
+webkit.org/b/179194 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-mime-types.https.html [ Slow ]
+
+webkit.org/b/180982 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html [ Slow ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226182] trunk/Source

[aestes]

Title: [226182] trunk/Source








Revision 226182
Author aes...@apple.com
Date 2017-12-20 09:11:29 -0800 (Wed, 20 Dec 2017)


Log Message
[Apple Pay] Tell PassKit whether Apple Pay JS or Payment Request was used to start an Apple Pay session
https://bugs.webkit.org/show_bug.cgi?id=181001


Reviewed by Tim Horton.

Source/WebCore:

* Modules/applepay/ApplePaySession.cpp:
(WebCore::convertAndValidate):
* Modules/applepay/ApplePaySessionPaymentRequest.h:
(WebCore::ApplePaySessionPaymentRequest::requester const):
(WebCore::ApplePaySessionPaymentRequest::setRequester):
* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::show):

Source/WebCore/PAL:

* pal/spi/cocoa/PassKitSPI.h:

Source/WebKit:

* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toAPIType):
(WebKit::toPKPaymentRequest):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp
trunk/Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h
trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/PassKitSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm
trunk/Source/WebKit/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (226181 => 226182)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 16:52:59 UTC (rev 226181)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 17:11:29 UTC (rev 226182)
@@ -1,3 +1,19 @@
+2017-12-20  Andy Estes  
+
+[Apple Pay] Tell PassKit whether Apple Pay JS or Payment Request was used to start an Apple Pay session
+https://bugs.webkit.org/show_bug.cgi?id=181001
+
+
+Reviewed by Tim Horton.
+
+* Modules/applepay/ApplePaySession.cpp:
+(WebCore::convertAndValidate):
+* Modules/applepay/ApplePaySessionPaymentRequest.h:
+(WebCore::ApplePaySessionPaymentRequest::requester const):
+(WebCore::ApplePaySessionPaymentRequest::setRequester):
+* Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
+(WebCore::ApplePayPaymentHandler::show):
+
 2017-12-20  Zalan Bujtas  
 
 [RenderTreeBuilder] Move finding-the-parent/creating-wrapper logic from RenderTable::addChild to RenderTreeBuilder


Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp (226181 => 226182)

--- trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp	2017-12-20 16:52:59 UTC (rev 226181)
+++ trunk/Source/WebCore/Modules/applepay/ApplePaySession.cpp	2017-12-20 17:11:29 UTC (rev 226182)
@@ -214,6 +214,7 @@
 return convertedRequest.releaseException();
 
 auto result = convertedRequest.releaseReturnValue();
+result.setRequester(ApplePaySessionPaymentRequest::Requester::ApplePayJS);
 result.setCurrencyCode(paymentRequest.currencyCode);
 
 auto total = convertAndValidateTotal(WTFMove(paymentRequest.total));


Modified: trunk/Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h (226181 => 226182)

--- trunk/Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h	2017-12-20 16:52:59 UTC (rev 226181)
+++ trunk/Source/WebCore/Modules/applepay/ApplePaySessionPaymentRequest.h	2017-12-20 17:11:29 UTC (rev 226182)
@@ -127,6 +127,14 @@
 const Vector& supportedCountries() const { return m_supportedCountries; }
 void setSupportedCountries(Vector&& supportedCountries) { m_supportedCountries = WTFMove(supportedCountries); }
 
+enum class Requester {
+ApplePayJS,
+PaymentRequest,
+};
+
+Requester requester() const { return m_requester; }
+void setRequester(Requester requester) { m_requester = requester; }
+
 private:
 String m_countryCode;
 String m_currencyCode;
@@ -148,6 +156,8 @@
 
 String m_applicationData;
 Vector m_supportedCountries;
+
+Requester m_requester { Requester::ApplePayJS };
 };
 
 struct PaymentError {


Modified: trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp (226181 => 226182)

--- trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp	2017-12-20 16:52:59 UTC (rev 226181)
+++ trunk/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp	2017-12-20 17:11:29 UTC (rev 226182)
@@ -179,6 +179,7 @@
 return validatedRequest.releaseException();
 
 ApplePaySessionPaymentRequest request = validatedRequest.releaseReturnValue();
+request.setRequester(ApplePaySessionPaymentRequest::Requester::PaymentRequest);
 
 String expectedCurrency = m_paymentRequest->paymentDetails().total.amount.currency;
 request.setCurrencyCode(expectedCurrency);


Modified: trunk/Source/WebCore/PAL/ChangeLog (226181 => 226182)

--- 

[webkit-changes] [226181] trunk/Source/WebCore

[zalan]

Title: [226181] trunk/Source/WebCore








Revision 226181
Author za...@apple.com
Date 2017-12-20 08:52:59 -0800 (Wed, 20 Dec 2017)


Log Message
[RenderTreeBuilder] Move finding-the-parent/creating-wrapper logic from RenderTable::addChild to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181018


Reviewed by Antti Koivisto.

This is in preparation for removing all tree mutation from renderering code.

Covered by existing tests.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringContinuation):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::insertChild):
* rendering/updating/RenderTreeBuilderTable.cpp:
(WebCore::RenderTreeBuilder::Table::findOrCreateParentForChild):
* rendering/updating/RenderTreeBuilderTable.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderTable.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderTable.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderTable.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226180 => 226181)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 16:34:43 UTC (rev 226180)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 16:52:59 UTC (rev 226181)
@@ -1,3 +1,25 @@
+2017-12-20  Zalan Bujtas  
+
+[RenderTreeBuilder] Move finding-the-parent/creating-wrapper logic from RenderTable::addChild to RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=181018
+
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for removing all tree mutation from renderering code.
+
+Covered by existing tests.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::addChildIgnoringContinuation):
+* rendering/RenderTable.cpp:
+(WebCore::RenderTable::addChild):
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::insertChild):
+* rendering/updating/RenderTreeBuilderTable.cpp:
+(WebCore::RenderTreeBuilder::Table::findOrCreateParentForChild):
+* rendering/updating/RenderTreeBuilderTable.h:
+
 2017-12-20  Frederic Wang  
 
 Split layout of RenderMathMLRow into smaller steps


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (226180 => 226181)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2017-12-20 16:34:43 UTC (rev 226180)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2017-12-20 16:52:59 UTC (rev 226181)
@@ -572,7 +572,7 @@
 
 if (newChild->isTablePart()) {
 // Insert into the anonymous table.
-beforeChildAnonymousContainer->addChild(builder, WTFMove(newChild), beforeChild);
+builder.insertChild(*beforeChildAnonymousContainer, WTFMove(newChild), beforeChild);
 return;
 }
 


Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (226180 => 226181)

--- trunk/Source/WebCore/rendering/RenderTable.cpp	2017-12-20 16:34:43 UTC (rev 226180)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp	2017-12-20 16:52:59 UTC (rev 226181)
@@ -135,13 +135,8 @@
 
 void RenderTable::addChild(RenderTreeBuilder& builder, RenderPtr child, RenderObject* beforeChild)
 {
-bool wrapInAnonymousSection = !child->isOutOfFlowPositioned();
-
-if (is(*child))
-wrapInAnonymousSection = false;
-else if (is(*child)) {
+if (is(*child)) {
 m_hasColElements = true;
-wrapInAnonymousSection = false;
 } else if (is(*child)) {
 switch (child->style().display()) {
 case TABLE_HEADER_GROUP:
@@ -153,13 +148,11 @@
 if (!m_firstBody) 
 m_firstBody = makeWeakPtr(downcast(child.get()));
 }
-wrapInAnonymousSection = false;
 break;
 case TABLE_FOOTER_GROUP:
 resetSectionPointerIfNotBefore(m_foot, beforeChild);
 if (!m_foot) {
 m_foot = makeWeakPtr(downcast(child.get()));
-wrapInAnonymousSection = false;
 break;
 }
 FALLTHROUGH;
@@ -167,58 +160,19 @@
 resetSectionPointerIfNotBefore(m_firstBody, beforeChild);
 if (!m_firstBody)
 m_firstBody = makeWeakPtr(downcast(child.get()));
-wrapInAnonymousSection = false;
 break;
 default:
 ASSERT_NOT_REACHED();
 }
-} else if (is(*child) || is(*child))
-wrapInAnonymousSection = true;
-else
-wrapInAnonymousSection = true;
+}
 
 if (is(*child))
 setNeedsSectionRecalc();
 
-if (!wrapInAnonymousSection) {
-if (beforeChild && beforeChild->parent() != this)
-beforeChild 

[webkit-changes] [226180] trunk

[commit-queue]

Title: [226180] trunk








Revision 226180
Author commit-qu...@webkit.org
Date 2017-12-20 08:34:43 -0800 (Wed, 20 Dec 2017)


Log Message
Split layout of RenderMathMLRow into smaller steps
https://bugs.webkit.org/show_bug.cgi?id=180348

Patch by Frederic Wang  on 2017-12-20
Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

Currently, RenderMathMLRow mixes too many steps in the same layout functions: layout children,
calculate stretch size, stretch vertical operators, calculate final ascent/descent, handle
out-of-flow positioned children, set logical height, set logical width for non-display
 tag, center display  tag etc This situation is inherited from the old flexbox
implementation but it makes difficult to read the code and to re-use layout & metrics
calculation for follow-up work on -like elements (, ,  or
). See for example bug 160547 for  or bug 161126 for .
This patch rewrites RenderMathMLRow into smaller steps:
- stretchVerticalOperatorsAndLayoutChildren() which calls layoutIfNeeded() or
insertPositionedObject() on children and stretch vertical operators.
- getContentBoundingBox() to determine the metrics of the mrow-like element without calling
layout on children or positioning them, so that we can improve mrow-like element in the
future.
- layoutRowItems() which sets the position of children.

Setting the logical width/height or centering children is now moved into layoutBlock() since
derived class overriding layoutBlock() will do their own adjustment for width, height and
positions.

Test: mathml/mrow-preferred-width-with-out-of-flow-child.html
The rest of the behavior is unchanged and already covered by existing tests.

* rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::layoutBlock): Use the new function and get contentWidth
directly from getContentBoundingBox().
* rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::layoutBlock): Ditto.
* rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::layoutBlock): Ditto, also remove useless statement
baseAscent = baseDescent.
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::toVerticalStretchyOperator): New helper function to cast to a vertical stretchy
operator.
(WebCore::RenderMathMLRow::stretchVerticalOperatorsAndLayoutChildren): New helper function
to ensure layoutIfNeeded()/insertPositionedObject() is called on children and that the
vertical operators are stretched.
(WebCore::RenderMathMLRow::getContentBoundingBox const): New helper function to determine
the width/ascent/descent to use for the mrow content.
(WebCore::RenderMathMLRow::computePreferredLogicalWidths): Skip out-of-flow children in the
preferred width calculation. This is verified by the new test.
(WebCore::RenderMathMLRow::layoutRowItems): Only keep the positioning of children with the
specified width and ascent.
(WebCore::RenderMathMLRow::layoutBlock): Center children for  tag and
set the logical width in other cases. Also set the logical height here.
(WebCore::RenderMathMLRow::computeLineVerticalStretch): Deleted. This work is included in
stretchVerticalOperatorsAndLayoutChildren() now.
* rendering/mathml/RenderMathMLRow.h: Update declaration of functions.

LayoutTests:

New test to verify that out-of-flow positioned children are not taken into account in the
calculation of the preferred width of the mrow element.

* mathml/mrow-preferred-width-with-out-of-flow-child-expected.html: Added.
* mathml/mrow-preferred-width-with-out-of-flow-child.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLPadded.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.h


Added Paths

trunk/LayoutTests/mathml/mrow-preferred-width-with-out-of-flow-child-expected.html
trunk/LayoutTests/mathml/mrow-preferred-width-with-out-of-flow-child.html




Diff

Modified: trunk/LayoutTests/ChangeLog (226179 => 226180)

--- trunk/LayoutTests/ChangeLog	2017-12-20 16:33:36 UTC (rev 226179)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 16:34:43 UTC (rev 226180)
@@ -1,3 +1,16 @@
+2017-12-20  Frederic Wang  
+
+Split layout of RenderMathMLRow into smaller steps
+https://bugs.webkit.org/show_bug.cgi?id=180348
+
+Reviewed by Manuel Rego Casasnovas.
+
+New test to verify that out-of-flow positioned children are not taken into account in the
+calculation of the preferred width of the mrow element.
+
+* mathml/mrow-preferred-width-with-out-of-flow-child-expected.html: Added.
+* mathml/mrow-preferred-width-with-out-of-flow-child.html: Added.
+
 2017-12-20  Ms2ger  
 
 Make fast/css-generated-content/quotes-lang.html pass on GTK


Added: 

[webkit-changes] [226179] trunk/Source/WebCore

[antti]

Title: [226179] trunk/Source/WebCore








Revision 226179
Author an...@apple.com
Date 2017-12-20 08:33:36 -0800 (Wed, 20 Dec 2017)


Log Message
Move list and multicolumn building code from RenderTreeUpdater to RenderTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=181021

Reviewed by Zalan Bujtas.

RenderTreeUpdater::ListItem -> RenderTreeBuilder::List
RenderTreeUpdater::MultiColumn -> RenderTreeBuilder::MultiColumn

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
* rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::RenderTreeBuilder):
(WebCore::RenderTreeBuilder::updateAfterDescendants):
* rendering/updating/RenderTreeBuilder.h:
(WebCore::RenderTreeBuilder::listBuilder):
(WebCore::RenderTreeBuilder::multiColumnBuilder):
* rendering/updating/RenderTreeBuilderList.cpp: Copied from Source/WebCore/rendering/updating/RenderTreeUpdaterListItem.cpp.
(WebCore::RenderTreeBuilder::List::List):
(WebCore::RenderTreeBuilder::List::updateItemMarker):
(WebCore::RenderTreeUpdater::ListItem::updateMarker): Deleted.
* rendering/updating/RenderTreeBuilderList.h: Copied from Source/WebCore/rendering/updating/RenderTreeUpdaterListItem.h.
* rendering/updating/RenderTreeBuilderMultiColumn.cpp: Copied from Source/WebCore/rendering/updating/RenderTreeUpdaterMultiColumn.cpp.
(WebCore::RenderTreeBuilder::MultiColumn::MultiColumn):
(WebCore::RenderTreeBuilder::MultiColumn::updateAfterDescendants):
(WebCore::RenderTreeBuilder::MultiColumn::createFragmentedFlow):
(WebCore::RenderTreeBuilder::MultiColumn::destroyFragmentedFlow):
(WebCore::RenderTreeUpdater::MultiColumn::update): Deleted.
(WebCore::RenderTreeUpdater::MultiColumn::createFragmentedFlow): Deleted.
(WebCore::RenderTreeUpdater::MultiColumn::destroyFragmentedFlow): Deleted.
* rendering/updating/RenderTreeBuilderMultiColumn.h: Copied from Source/WebCore/rendering/updating/RenderTreeUpdaterMultiColumn.h.
* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::commit):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
* rendering/updating/RenderTreeUpdater.h:
* rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
* rendering/updating/RenderTreeUpdaterListItem.cpp: Removed.
* rendering/updating/RenderTreeUpdaterListItem.h: Removed.
* rendering/updating/RenderTreeUpdaterMultiColumn.cpp: Removed.
* rendering/updating/RenderTreeUpdaterMultiColumn.h: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/rendering/TextAutoSizing.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.h
trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeUpdater.h
trunk/Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp


Added Paths

trunk/Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderList.h
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.h


Removed Paths

trunk/Source/WebCore/rendering/updating/RenderTreeUpdaterListItem.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeUpdaterListItem.h
trunk/Source/WebCore/rendering/updating/RenderTreeUpdaterMultiColumn.cpp
trunk/Source/WebCore/rendering/updating/RenderTreeUpdaterMultiColumn.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226178 => 226179)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 14:31:58 UTC (rev 226178)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 16:33:36 UTC (rev 226179)
@@ -1,3 +1,48 @@
+2017-12-20  Antti Koivisto  
+
+Move list and multicolumn building code from RenderTreeUpdater to RenderTreeBuilder
+https://bugs.webkit.org/show_bug.cgi?id=181021
+
+Reviewed by Zalan Bujtas.
+
+RenderTreeUpdater::ListItem -> RenderTreeBuilder::List
+RenderTreeUpdater::MultiColumn -> RenderTreeBuilder::MultiColumn
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* rendering/TextAutoSizing.cpp:
+(WebCore::TextAutoSizingValue::adjustTextNodeSizes):
+* rendering/updating/RenderTreeBuilder.cpp:
+(WebCore::RenderTreeBuilder::RenderTreeBuilder):
+(WebCore::RenderTreeBuilder::updateAfterDescendants):
+* rendering/updating/RenderTreeBuilder.h:
+(WebCore::RenderTreeBuilder::listBuilder):
+(WebCore::RenderTreeBuilder::multiColumnBuilder):
+* rendering/updating/RenderTreeBuilderList.cpp: Copied from Source/WebCore/rendering/updating/RenderTreeUpdaterListItem.cpp.
+(WebCore::RenderTreeBuilder::List::List):
+(WebCore::RenderTreeBuilder::List::updateItemMarker):
+  

[webkit-changes] [226178] trunk/Source

[Ms2ger]

Title: [226178] trunk/Source








Revision 226178
Author ms2...@igalia.com
Date 2017-12-20 06:31:58 -0800 (Wed, 20 Dec 2017)


Log Message
REGRESSION(r226160) Build broken when MEDIA_STREAM is disabled with MediaStreamRequest namespace confusion
https://bugs.webkit.org/show_bug.cgi?id=181026

Unreviewed build fix.


Source/WebCore:

* platform/mediastream/MediaStreamRequest.h: Fix namespace, unconditionally include header.

Source/WebKit:

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
  Remove UNUSED_PARAM macros that check for (undefined) members rather than params.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/MediaStreamRequest.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226177 => 226178)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 14:28:05 UTC (rev 226177)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 14:31:58 UTC (rev 226178)
@@ -1,3 +1,12 @@
+2017-12-20  Ms2ger  
+
+REGRESSION(r226160) Build broken when MEDIA_STREAM is disabled with MediaStreamRequest namespace confusion
+https://bugs.webkit.org/show_bug.cgi?id=181026
+
+Unreviewed build fix.
+
+* platform/mediastream/MediaStreamRequest.h: Fix namespace, unconditionally include header.
+
 2017-12-20  Frederic Wang  
 
 Refactor RenderMathMLFraction to remove members modified during layout


Modified: trunk/Source/WebCore/platform/mediastream/MediaStreamRequest.h (226177 => 226178)

--- trunk/Source/WebCore/platform/mediastream/MediaStreamRequest.h	2017-12-20 14:28:05 UTC (rev 226177)
+++ trunk/Source/WebCore/platform/mediastream/MediaStreamRequest.h	2017-12-20 14:31:58 UTC (rev 226178)
@@ -25,10 +25,11 @@
 
 #pragma once
 
+#include 
+
 #if ENABLE(MEDIA_STREAM)
 
 #include "MediaConstraints.h"
-#include 
 
 namespace WebCore {
 
@@ -60,11 +61,15 @@
 
 #else
 
+namespace WebCore {
+
 struct MediaStreamRequest {
 enum class Type { UserMedia };
 Type type;
 };
 
+} // namespace WebCore
+
 #endif // ENABLE(MEDIA_STREAM)
 
 namespace WTF {


Modified: trunk/Source/WebKit/ChangeLog (226177 => 226178)

--- trunk/Source/WebKit/ChangeLog	2017-12-20 14:28:05 UTC (rev 226177)
+++ trunk/Source/WebKit/ChangeLog	2017-12-20 14:31:58 UTC (rev 226178)
@@ -1,3 +1,14 @@
+2017-12-20  Ms2ger  
+
+REGRESSION(r226160) Build broken when MEDIA_STREAM is disabled with MediaStreamRequest namespace confusion
+https://bugs.webkit.org/show_bug.cgi?id=181026
+
+Unreviewed build fix.
+
+* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
+  Remove UNUSED_PARAM macros that check for (undefined) members rather than params.
+
 2017-12-19  Myles C. Maxfield  
 
 Refactor user-installed font setting for clarity


Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (226177 => 226178)

--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp	2017-12-20 14:28:05 UTC (rev 226177)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp	2017-12-20 14:31:58 UTC (rev 226178)
@@ -331,8 +331,6 @@
 UNUSED_PARAM(frameID);
 UNUSED_PARAM(userMediaDocumentOrigin);
 UNUSED_PARAM(topLevelDocumentOrigin);
-UNUSED_PARAM(audioConstraints);
-UNUSED_PARAM(videoConstraints);
 UNUSED_PARAM(userRequest);
 #endif
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226177] trunk/Source/WebCore

[commit-queue]

Title: [226177] trunk/Source/WebCore








Revision 226177
Author commit-qu...@webkit.org
Date 2017-12-20 06:28:05 -0800 (Wed, 20 Dec 2017)


Log Message
Refactor RenderMathMLFraction to remove members modified during layout
https://bugs.webkit.org/show_bug.cgi?id=180151

Patch by Frederic Wang  on 2017-12-20
Reviewed by Manuel Rego Casasnovas.

Currently, RenderMathMLFraction has three LayoutUnit members m_defaultLineThickness,
m_lineThickness and m_ascent that are set during layout. In the past such members have caused
MathML rendering bugs due to update issues. This patch refactors the layout of MathML
fractions so that it does not require to store and keep these LayoutUnit members up-to-date.
New helper functions are introduced to perform the simple arithmetic calculations required.

No new tests, behavior unchanged and already covered by existing tests.

* rendering/mathml/RenderMathMLFraction.cpp: We add new helper functions to calculate line
thickness values. This allows to remove updateLineThickness(), m_defaultLineThickness and
m_lineThickness. We also introduce the ascentOverHorizontalAxis() helper function to
calculate the ascent over the middle of its fraction bar or stack gap. This allows to remove
the m_ascent member.
(WebCore::RenderMathMLFraction::defaultLineThickness const): Helper function to calculate
the default thickness of the fraction bar given in the MATH table or a fallback value.
This replaces the use of m_defaultLineThickness.
(WebCore::RenderMathMLFraction::lineThickness const): Helper function to resolve the
actual thickness based on the @linethickness attribute and the default value. This replaces
the use of m_lineThickness.
(WebCore::RenderMathMLFraction::relativeLineThickness const): Rewrite this function using
the new helper functions.
(WebCore::RenderMathMLFraction::fractionParameters const): Make this const and replaces
isStack() with !lineThickness().
(WebCore::RenderMathMLFraction::stackParameters const): Ditto. Also move from layoutBlock
the adjustment of parameters to ensure a minimum gap. Doing so assumes that the fraction is
valid so we add an ASSERT.
(WebCore::RenderMathMLFraction::horizontalOffset const): Make this a const since it does not
mutate anything.
(WebCore::RenderMathMLFraction::ascentOverHorizontalAxis const): Move this code from
layoutBlock() to determine the middle of the stack gap or of the fraction bar. This helper
function replaces m_ascent - mathAxisHeight(). Note that the adjustment of topShiftUp is now
done in stackParameters().
(WebCore::RenderMathMLFraction::layoutBlock): Remove the call to updateLineThickness().
Rely on stackParameters() and ascentOverHorizontalAxis() to perform the necessary calculation
of bottomShiftDown and ascent respectively.
(WebCore::RenderMathMLFraction::paint): Use lineThickness() and ascentOverHorizontalAxis()
instead of m_lineThickness, m_ascent and isStack().
(WebCore::RenderMathMLFraction::firstLineBaseline const): Use ascentOverHorizontalAxis() and
mathAxisHeight() instead of m_ascent.
(WebCore::RenderMathMLFraction::updateLineThickness): Deleted.
* rendering/mathml/RenderMathMLFraction.h: Declare new helper functions for line thickness
values and ascent and remove the old LayoutUnit members. Make horizontalOffset(),
fractionParameter() and stackParameters() const since they do not modify anything and the two
last are used in the const function ascentOverHorizontalAxis(), itself used in
firstLineBaseline().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (226176 => 226177)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 14:25:50 UTC (rev 226176)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 14:28:05 UTC (rev 226177)
@@ -1,3 +1,56 @@
+2017-12-20  Frederic Wang  
+
+Refactor RenderMathMLFraction to remove members modified during layout
+https://bugs.webkit.org/show_bug.cgi?id=180151
+
+Reviewed by Manuel Rego Casasnovas.
+
+Currently, RenderMathMLFraction has three LayoutUnit members m_defaultLineThickness,
+m_lineThickness and m_ascent that are set during layout. In the past such members have caused
+MathML rendering bugs due to update issues. This patch refactors the layout of MathML
+fractions so that it does not require to store and keep these LayoutUnit members up-to-date.
+New helper functions are introduced to perform the simple arithmetic calculations required.
+
+No new tests, behavior unchanged and already covered by existing tests.
+
+* rendering/mathml/RenderMathMLFraction.cpp: We add new helper functions to calculate line
+thickness values. This allows to remove updateLineThickness(), m_defaultLineThickness and
+m_lineThickness. We also introduce the ascentOverHorizontalAxis() helper function to
+  

[webkit-changes] [226176] trunk

[commit-queue]

Title: [226176] trunk








Revision 226176
Author commit-qu...@webkit.org
Date 2017-12-20 06:25:50 -0800 (Wed, 20 Dec 2017)


Log Message
[CMake][WTF] Lowercase ForwardingHeaders directory name of WTF
https://bugs.webkit.org/show_bug.cgi?id=181022

Patch by Fujii Hironori  on 2017-12-20
Reviewed by Konstantin Tokarev.

.:

ForwardingHeaders of WTF are included as . But, the
directory name was uppercase DerivedSources/ForwardingHeaders/WTF.
This confuses Ninja dependency tracking. It should be lowercase.

* Source/cmake/WebKitMacros.cmake: Renamed ForwardingHeaders directory name WTF to wtf.

Source/WTF:

* wtf/CMakeLists.txt: Renamed ForwardingHeaders directory name WTF to wtf.
* wtf/PlatformWin.cmake: Ditto.

Modified Paths

trunk/ChangeLog
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CMakeLists.txt
trunk/Source/WTF/wtf/PlatformWin.cmake
trunk/Source/cmake/WebKitMacros.cmake




Diff

Modified: trunk/ChangeLog (226175 => 226176)

--- trunk/ChangeLog	2017-12-20 14:24:00 UTC (rev 226175)
+++ trunk/ChangeLog	2017-12-20 14:25:50 UTC (rev 226176)
@@ -1,3 +1,16 @@
+2017-12-20  Fujii Hironori  
+
+[CMake][WTF] Lowercase ForwardingHeaders directory name of WTF
+https://bugs.webkit.org/show_bug.cgi?id=181022
+
+Reviewed by Konstantin Tokarev.
+
+ForwardingHeaders of WTF are included as . But, the
+directory name was uppercase DerivedSources/ForwardingHeaders/WTF.
+This confuses Ninja dependency tracking. It should be lowercase.
+
+* Source/cmake/WebKitMacros.cmake: Renamed ForwardingHeaders directory name WTF to wtf.
+
 2017-12-16  Basuke Suzuki  
 
 [WinCairo] Move the destination of WinCairoRequirements.zip into WebKitLibraries and register it and related files as git ignore files.


Modified: trunk/Source/WTF/ChangeLog (226175 => 226176)

--- trunk/Source/WTF/ChangeLog	2017-12-20 14:24:00 UTC (rev 226175)
+++ trunk/Source/WTF/ChangeLog	2017-12-20 14:25:50 UTC (rev 226176)
@@ -1,3 +1,13 @@
+2017-12-20  Fujii Hironori  
+
+[CMake][WTF] Lowercase ForwardingHeaders directory name of WTF
+https://bugs.webkit.org/show_bug.cgi?id=181022
+
+Reviewed by Konstantin Tokarev.
+
+* wtf/CMakeLists.txt: Renamed ForwardingHeaders directory name WTF to wtf.
+* wtf/PlatformWin.cmake: Ditto.
+
 2017-12-19  Brian Burg  
 
 SLEEP_THREAD_FOR_DEBUGGER() macro should try to print out the PID of the affected process


Modified: trunk/Source/WTF/wtf/CMakeLists.txt (226175 => 226176)

--- trunk/Source/WTF/wtf/CMakeLists.txt	2017-12-20 14:24:00 UTC (rev 226175)
+++ trunk/Source/WTF/wtf/CMakeLists.txt	2017-12-20 14:25:50 UTC (rev 226176)
@@ -415,10 +415,10 @@
 VERBATIM)
 endif ()
 
-file(MAKE_DIRECTORY ${FORWARDING_HEADERS_DIR}/WTF/Scripts)
+file(MAKE_DIRECTORY ${FORWARDING_HEADERS_DIR}/wtf/Scripts)
 
 file(COPY
 ../Scripts/generate-unified-source-bundles.rb
 DESTINATION
-${FORWARDING_HEADERS_DIR}/WTF/Scripts
+${FORWARDING_HEADERS_DIR}/wtf/Scripts
 )


Modified: trunk/Source/WTF/wtf/PlatformWin.cmake (226175 => 226176)

--- trunk/Source/WTF/wtf/PlatformWin.cmake	2017-12-20 14:24:00 UTC (rev 226175)
+++ trunk/Source/WTF/wtf/PlatformWin.cmake	2017-12-20 14:25:50 UTC (rev 226176)
@@ -27,7 +27,7 @@
 endif ()
 
 set(WTF_PRE_BUILD_COMMAND "${CMAKE_BINARY_DIR}/DerivedSources/WTF/preBuild.cmd")
-file(WRITE "${WTF_PRE_BUILD_COMMAND}" "@xcopy /y /s /d /f \"${WTF_DIR}/wtf/*.h\" \"${DERIVED_SOURCES_DIR}/ForwardingHeaders/WTF\" >nul 2>nul\n@xcopy /y /s /d /f \"${DERIVED_SOURCES_DIR}/WTF/*.h\" \"${DERIVED_SOURCES_DIR}/ForwardingHeaders/WTF\" >nul 2>nul\n")
-file(MAKE_DIRECTORY ${DERIVED_SOURCES_DIR}/ForwardingHeaders/WTF)
+file(WRITE "${WTF_PRE_BUILD_COMMAND}" "@xcopy /y /s /d /f \"${WTF_DIR}/wtf/*.h\" \"${FORWARDING_HEADERS_DIR}/wtf\" >nul 2>nul\n@xcopy /y /s /d /f \"${DERIVED_SOURCES_DIR}/WTF/*.h\" \"${FORWARDING_HEADERS_DIR}/wtf\" >nul 2>nul\n")
+file(MAKE_DIRECTORY ${FORWARDING_HEADERS_DIR}/wtf)
 
 set(WTF_OUTPUT_NAME WTF${DEBUG_SUFFIX})


Modified: trunk/Source/cmake/WebKitMacros.cmake (226175 => 226176)

--- trunk/Source/cmake/WebKitMacros.cmake	2017-12-20 14:24:00 UTC (rev 226175)
+++ trunk/Source/cmake/WebKitMacros.cmake	2017-12-20 14:25:50 UTC (rev 226176)
@@ -13,7 +13,7 @@
 if (WIN32 AND INTERNAL_BUILD)
 set(WTF_SCRIPTS_DIR "${CMAKE_BINARY_DIR}/../include/private/WTF/Scripts")
 else ()
-set(WTF_SCRIPTS_DIR "${FORWARDING_HEADERS_DIR}/WTF/Scripts")
+set(WTF_SCRIPTS_DIR "${FORWARDING_HEADERS_DIR}/wtf/Scripts")
 endif ()
 
 execute_process(COMMAND ${RUBY_EXECUTABLE} ${WTF_SCRIPTS_DIR}/generate-unified-source-bundles.rb






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226175] trunk/LayoutTests

[Ms2ger]

Title: [226175] trunk/LayoutTests








Revision 226175
Author ms2...@igalia.com
Date 2017-12-20 06:24:00 -0800 (Wed, 20 Dec 2017)


Log Message
Make fast/css-generated-content/quotes-lang.html pass on GTK
https://bugs.webkit.org/show_bug.cgi?id=93976

Unreviewed test gardening.

Adding a span to the reference file avoids a one-pixel difference in the
font rendering between test and reference on GTK.


* fast/css-generated-content/quotes-lang-expected.html:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-generated-content/quotes-lang-expected.html
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (226174 => 226175)

--- trunk/LayoutTests/ChangeLog	2017-12-20 12:46:29 UTC (rev 226174)
+++ trunk/LayoutTests/ChangeLog	2017-12-20 14:24:00 UTC (rev 226175)
@@ -1,3 +1,16 @@
+2017-12-20  Ms2ger  
+
+Make fast/css-generated-content/quotes-lang.html pass on GTK
+https://bugs.webkit.org/show_bug.cgi?id=93976
+
+Unreviewed test gardening.
+
+Adding a span to the reference file avoids a one-pixel difference in the
+font rendering between test and reference on GTK.
+
+* fast/css-generated-content/quotes-lang-expected.html:
+* platform/gtk/TestExpectations:
+
 2017-12-19  Myles C. Maxfield  
 
 Refactor user-installed font setting for clarity


Modified: trunk/LayoutTests/fast/css-generated-content/quotes-lang-expected.html (226174 => 226175)

--- trunk/LayoutTests/fast/css-generated-content/quotes-lang-expected.html	2017-12-20 12:46:29 UTC (rev 226174)
+++ trunk/LayoutTests/fast/css-generated-content/quotes-lang-expected.html	2017-12-20 14:24:00 UTC (rev 226175)
@@ -159,7 +159,7 @@
 
 
 
-ACcustomDB
+ACcustomDB
 default
 af
 agq


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (226174 => 226175)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 12:46:29 UTC (rev 226174)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-12-20 14:24:00 UTC (rev 226175)
@@ -2624,8 +2624,6 @@
 # This failure appears to be GTK-specific
 webkit.org/b/91319 css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]
 
-webkit.org/b/93976 fast/css-generated-content/quotes-lang.html [ ImageOnlyFailure ]
-
 # This has always failed on Gtk/Efl - exposed by bug 89826
 webkit.org/b/94009 css2.1/20110323/c541-word-sp-000.htm [ ImageOnlyFailure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226174] trunk/Source/WebCore

[clopez]

Title: [226174] trunk/Source/WebCore








Revision 226174
Author clo...@igalia.com
Date 2017-12-20 04:46:29 -0800 (Wed, 20 Dec 2017)


Log Message
[GTK][Clang] Build fix after r226138
https://bugs.webkit.org/show_bug.cgi?id=180984

Unreviewed build fix.

No new tests, its a build fix.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::collectSubrangesForDocumentMarkers):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineTextBox.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (226173 => 226174)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 12:44:10 UTC (rev 226173)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 12:46:29 UTC (rev 226174)
@@ -1,3 +1,15 @@
+2017-12-20  Carlos Alberto Lopez Perez  
+
+[GTK][Clang] Build fix after r226138
+https://bugs.webkit.org/show_bug.cgi?id=180984
+
+Unreviewed build fix.
+
+No new tests, its a build fix.
+
+* rendering/InlineTextBox.cpp:
+(WebCore::InlineTextBox::collectSubrangesForDocumentMarkers):
+
 2017-12-20  Ryosuke Niwa  
 
 REGRESSION(r222699): Drag & drop from a web page to Gmail fails


Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (226173 => 226174)

--- trunk/Source/WebCore/rendering/InlineTextBox.cpp	2017-12-20 12:44:10 UTC (rev 226173)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp	2017-12-20 12:46:29 UTC (rev 226174)
@@ -849,8 +849,8 @@
 case DocumentMarker::TextMatch:
 if (!renderer().frame().editor().markedTextMatchesAreHighlighted())
 continue;
+#if ENABLE(TELEPHONE_NUMBER_DETECTION)
 FALLTHROUGH;
-#if ENABLE(TELEPHONE_NUMBER_DETECTION)
 case DocumentMarker::TelephoneNumber:
 #endif
 if (phase == TextPaintPhase::Foreground)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [226173] trunk

[rniwa]

Title: [226173] trunk








Revision 226173
Author rn...@webkit.org
Date 2017-12-20 04:44:10 -0800 (Wed, 20 Dec 2017)


Log Message
REGRESSION(r222699): Drag & drop from a web page to Gmail fails
https://bugs.webkit.org/show_bug.cgi?id=181019

Reviewed by Wenson Hsieh.

Source/WebCore:

The bug was caused by imageTypeToFakeFilename returning "image/png" instead of "image.png" for
the filename for a PING image converted from a TIFF image. Fixed the bug by correcting this typo.

Tests: PasteImage.PasteLegacyTIFFImage
   PasteImage.PasteTIFFImage

* platform/cocoa/PasteboardCocoa.mm:
(WebCore::imageTypeToFakeFilename):

Tools:

Added assertions for filenames.

* TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (226172 => 226173)

--- trunk/Source/WebCore/ChangeLog	2017-12-20 03:24:15 UTC (rev 226172)
+++ trunk/Source/WebCore/ChangeLog	2017-12-20 12:44:10 UTC (rev 226173)
@@ -1,3 +1,19 @@
+2017-12-20  Ryosuke Niwa  
+
+REGRESSION(r222699): Drag & drop from a web page to Gmail fails
+https://bugs.webkit.org/show_bug.cgi?id=181019
+
+Reviewed by Wenson Hsieh.
+
+The bug was caused by imageTypeToFakeFilename returning "image/png" instead of "image.png" for
+the filename for a PING image converted from a TIFF image. Fixed the bug by correcting this typo.
+
+Tests: PasteImage.PasteLegacyTIFFImage
+   PasteImage.PasteTIFFImage 
+
+* platform/cocoa/PasteboardCocoa.mm:
+(WebCore::imageTypeToFakeFilename):
+
 2017-12-19  Myles C. Maxfield  
 
 Refactor user-installed font setting for clarity


Modified: trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm (226172 => 226173)

--- trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm	2017-12-20 03:24:15 UTC (rev 226172)
+++ trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm	2017-12-20 12:44:10 UTC (rev 226173)
@@ -107,7 +107,7 @@
 return nullptr;
 case ImageType::TIFF:
 #if PLATFORM(MAC)
-return "image/png"; // For Web compatibility, we pretend to have PNG instead.
+return "image.png"; // For Web compatibility, we pretend to have PNG instead.
 #else
 ASSERT_NOT_REACHED();
 return nullptr;


Modified: trunk/Tools/ChangeLog (226172 => 226173)

--- trunk/Tools/ChangeLog	2017-12-20 03:24:15 UTC (rev 226172)
+++ trunk/Tools/ChangeLog	2017-12-20 12:44:10 UTC (rev 226173)
@@ -1,3 +1,14 @@
+2017-12-20  Ryosuke Niwa  
+
+REGRESSION(r222699): Drag & drop from a web page to Gmail fails
+https://bugs.webkit.org/show_bug.cgi?id=181019
+
+Reviewed by Wenson Hsieh.
+
+Added assertions for filenames.
+
+* TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
+
 2017-12-19  Daniel Bates  
 
 MarkerSubrange.SubdivideGrammarAndSelectionOverlap{Frontmost, FrontmostWithLongestEffectiveRange} are failing


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm (226172 => 226173)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm	2017-12-20 03:24:15 UTC (rev 226172)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm	2017-12-20 12:44:10 UTC (rev 226173)
@@ -67,6 +67,7 @@
 EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"gifItem = dataTransfer.items.find((item) => item.type == 'image/gif'); (!!gifItem).toString()"]);
 EXPECT_WK_STREQ("file", [webView stringByEvaluatingJavaScript:@"gifItem.kind"]);
 EXPECT_WK_STREQ("image/gif", [webView stringByEvaluatingJavaScript:@"gifItem.file.type"]);
+EXPECT_WK_STREQ("image.gif", [webView stringByEvaluatingJavaScript:@"gifItem.file.name"]);
 EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(gifItem.file).toString()"]);
 
 [webView stringByEvaluatingJavaScript:@"insertFileAsImage(gifItem.file)"];
@@ -88,6 +89,7 @@
 EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"jpegItem = dataTransfer.items.find((item) => item.type == 'image/jpeg'); (!!jpegItem).toString()"]);
 EXPECT_WK_STREQ("file", [webView stringByEvaluatingJavaScript:@"jpegItem.kind"]);
 EXPECT_WK_STREQ("image/jpeg", [webView stringByEvaluatingJavaScript:@"jpegItem.file.type"]);
+EXPECT_WK_STREQ("image.jpeg", [webView stringByEvaluatingJavaScript:@"jpegItem.file.name"]);
 EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"dataTransfer.files.includes(jpegItem.file).toString()"]);
 
 [webView stringByEvaluatingJavaScript:@"insertFileAsImage(jpegItem.file)"];
@@ -109,6 +111,7 @@
 EXPECT_WK_STREQ("true", [webView stringByEvaluatingJavaScript:@"pngItem = dataTransfer.items.find((item) => item.type == 'image/png'); (!!pngItem).toString()"]);