[webkit-changes] [227476] releases/Apple

[mitz]

Title: [227476] releases/Apple








Revision 227476
Author m...@apple.com
Date 2018-01-23 21:46:31 -0800 (Tue, 23 Jan 2018)


Log Message
Added a tag for iOS 11.2.5.

Added Paths

releases/Apple/iOS 11.2.5/
releases/Apple/iOS 11.2.5/ANGLE/
releases/Apple/iOS 11.2.5/_javascript_Core/
releases/Apple/iOS 11.2.5/WTF/
releases/Apple/iOS 11.2.5/WebCore/
releases/Apple/iOS 11.2.5/WebKit/
releases/Apple/iOS 11.2.5/WebKitLegacy/
releases/Apple/iOS 11.2.5/bmalloc/
releases/Apple/iOS 11.2.5/libwebrtc/




Diff
Index: releases/Apple/iOS 11.2.5/ANGLE
===
--- tags/Safari-604.5.6.0.1/Source/ThirdParty/ANGLE	2018-01-24 05:22:43 UTC (rev 227475)
+++ releases/Apple/iOS 11.2.5/ANGLE	2018-01-24 05:46:31 UTC (rev 227476)

Property changes: releases/Apple/iOS 11.2.5/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455
\ No newline at end of property
Index: releases/Apple/iOS 11.2.5/_javascript_Core
===
--- tags/Safari-604.5.6.0.1/Source/_javascript_Core	2018-01-24 05:22:43 UTC (rev 227475)
+++ releases/Apple/iOS 11.2.5/_javascript_Core	2018-01-24 05:46:31 UTC (rev 227476)

Property changes: releases/Apple/iOS 11.2.5/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455
\ No newline at end of property
Index: releases/Apple/iOS 11.2.5/WTF
===
--- tags/Safari-604.5.6.0.1/Source/WTF	2018-01-24 05:22:43 UTC (rev 227475)
+++ releases/Apple/iOS 11.2.5/WTF	2018-01-24 05:46:31 UTC (rev 227476)

Property changes: releases/Apple/iOS 11.2.5/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455
\ No newline at end of property
Index: releases/Apple/iOS 11.2.5/bmalloc
===
--- tags/Safari-604.5.6.0.1/Source/bmalloc	2018-01-24 05:22:43 UTC (rev 227475)
+++ releases/Apple/iOS 11.2.5/bmalloc	2018-01-24 05:46:31 UTC (rev 227476)

Property changes: releases/Apple/iOS 11.2.5/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455
\ No newline at end of property
Index: releases/Apple/iOS 11.2.5/libwebrtc
===
--- tags/Safari-604.5.6.0.1/Source/ThirdParty/libwebrtc	2018-01-24 05:22:43 UTC (rev 227475)
+++ releases/Apple/iOS 11.2.5/libwebrtc	2018-01-24 05:46:31 UTC (rev 227476)

Property changes: releases/Apple/iOS 11.2.5/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227472] branches/safari-605-branch

[jmarcell]

Title: [227472] branches/safari-605-branch








Revision 227472
Author jmarc...@apple.com
Date 2018-01-23 21:22:25 -0800 (Tue, 23 Jan 2018)


Log Message
Cherry-pick r227457. rdar://problem/36807161

Modified Paths

branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-605-branch/Source/WebCore/html/HTMLMediaElement.h
branches/safari-605-branch/Source/WebCore/html/MediaElementSession.cpp
branches/safari-605-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
branches/safari-605-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
branches/safari-605-branch/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h
branches/safari-605-branch/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.h
branches/safari-605-branch/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm
branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
branches/safari-605-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
branches/safari-605-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-605-branch/Source/WebKit/UIProcess/WebPageProxy.h
branches/safari-605-branch/Source/WebKit/UIProcess/WebPageProxy.messages.in
branches/safari-605-branch/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
branches/safari-605-branch/Tools/ChangeLog
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm
branches/safari-605-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html




Diff

Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (227471 => 227472)

--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-24 04:59:24 UTC (rev 227471)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-24 05:22:25 UTC (rev 227472)
@@ -1,5 +1,45 @@
 2018-01-23  Jason Marcell  
 
+Cherry-pick r227457. rdar://problem/36807161
+
+2018-01-23  Eric Carlson  
+
+Resign NowPlaying status when no media element is eligible
+https://bugs.webkit.org/show_bug.cgi?id=181914
+
+
+Reviewed by Jer Noble.
+
+Updated API test.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::removedFromAncestor): Call mediaSession->clientCharacteristicsChanged
+so NowPlaying status will be updated.
+
+* html/MediaElementSession.cpp:
+(WebCore::MediaElementSession::playbackPermitted const): Return early when the media
+element has been suspended.
+(WebCore::MediaElementSession::canShowControlsManager const): Return false when being queried
+for NowPlaying status in an inactive document or when element has been suspended.
+(WebCore::isMainContentForPurposesOfAutoplay): Return early if it isn't safe to update
+style because HitTest can force a layout.
+(WebCore::MediaElementSession::updateIsMainContent const): Ditto.
+
+* platform/audio/PlatformMediaSessionManager.cpp:
+(WebCore::PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary): Implement in for all
+ports.
+* platform/audio/PlatformMediaSessionManager.h:
+(WebCore::PlatformMediaSessionManager::registeredAsNowPlayingApplication const):
+* platform/audio/ios/MediaSessionManagerIOS.h:
+* platform/audio/mac/MediaSessionManagerMac.h:
+* platform/audio/mac/MediaSessionManagerMac.mm:
+(WebCore::MediaSessionManagerMac::updateNowPlayingInfo): Call MRMediaRemoteSetCanBeNowPlayingApplication
+whenever status changes.
+(WebCore::PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary): Deleted, implemented
+in the base class.
+
+2018-01-23  Jason Marcell  
+
 Cherry-pick r227425. rdar://problem/36791667
 
 2018-01-23  Brady Eidson  


Modified: branches/safari-605-branch/Source/WebCore/html/HTMLMediaElement.cpp (227471 => 227472)

--- branches/safari-605-branch/Source/WebCore/html/HTMLMediaElement.cpp	2018-01-24 04:59:24 UTC (rev 227471)
+++ branches/safari-605-branch/Source/WebCore/html/HTMLMediaElement.cpp	2018-01-24 05:22:25 UTC (rev 227472)
@@ -971,6 +971,9 @@
 m_pauseAfterDetachedTaskQueue.enqueueTask(std::bind(&HTMLMediaElement::pauseAfterDetachedTask, this));
 }
 
+if (m_mediaSession)
+m_mediaSession->clientCharacteristicsChanged();
+
 HTMLElement::removedFromAncestor(removalType, oldParentOfRemovedTree);
 }
 


Modified: branches/safari-605-branch/Source/WebCore/html/HTMLMediaElement.h (227471 => 227472)

--- branches/safari-605-branch/Source/WebCore/html/HTMLMediaElement.h	2018-01-24 04:59:24 UTC (rev 227471)
+++ branches/safari-605-branch/Source/WebCore/html/HTMLMediaElement.h	2018-01-24 05:22:25 UTC (rev 227472)
@@ -551,6 +551,8

[webkit-changes] [227473] branches/safari-605-branch/Source/JavaScriptCore

[jmarcell]

Title: [227473] branches/safari-605-branch/Source/_javascript_Core








Revision 227473
Author jmarc...@apple.com
Date 2018-01-23 21:22:30 -0800 (Tue, 23 Jan 2018)


Log Message
Cherry-pick r227462. rdar://problem/36807140

Modified Paths

branches/safari-605-branch/Source/_javascript_Core/ChangeLog
branches/safari-605-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
branches/safari-605-branch/Source/_javascript_Core/dfg/DFGGraph.cpp
branches/safari-605-branch/Source/_javascript_Core/dfg/DFGNode.h
branches/safari-605-branch/Source/_javascript_Core/dfg/DFGStackLayoutPhase.cpp
branches/safari-605-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp




Diff

Modified: branches/safari-605-branch/Source/_javascript_Core/ChangeLog (227472 => 227473)

--- branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-24 05:22:25 UTC (rev 227472)
+++ branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-24 05:22:30 UTC (rev 227473)
@@ -1,5 +1,33 @@
 2018-01-23  Jason Marcell  
 
+Cherry-pick r227462. rdar://problem/36807140
+
+2018-01-23  Filip Pizlo  
+
+Use precise index masking for FTL GetByArgumentByVal
+https://bugs.webkit.org/show_bug.cgi?id=182006
+
+Reviewed by Keith Miller.
+
+This protects speculative out-of-bounds on arguments[index].
+
+Making this work right involved fixing a possible overflow situation with
+numberOfArgumentsToSkip.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::dump):
+* dfg/DFGNode.h:
+(JSC::DFG::Node::hasNumberOfArgumentsToSkip):
+(JSC::DFG::Node::numberOfArgumentsToSkip):
+* dfg/DFGStackLayoutPhase.cpp:
+(JSC::DFG::StackLayoutPhase::run):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
+
+2018-01-23  Jason Marcell  
+
 Cherry-pick r227434. rdar://problem/36791632
 
 2018-01-23  Mark Lam  


Modified: branches/safari-605-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (227472 => 227473)

--- branches/safari-605-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-24 05:22:25 UTC (rev 227472)
+++ branches/safari-605-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-24 05:22:30 UTC (rev 227473)
@@ -502,8 +502,6 @@
 break;
 if (operand.offset() < static_cast(inlineCallFrame->stackOffset + CallFrame::headerSizeInRegisters))
 continue;
-if (operand.offset() == inlineCallFrame->stackOffset + CallFrame::thisArgumentOffset())
-continue;
 if (operand.offset() >= static_cast(inlineCallFrame->stackOffset + CallFrame::thisArgumentOffset() + inlineCallFrame->argumentsWithFixup.size()))
 continue;
 int argument = VirtualRegister(operand.offset() - inlineCallFrame->stackOffset).toArgument();


Modified: branches/safari-605-branch/Source/_javascript_Core/dfg/DFGGraph.cpp (227472 => 227473)

--- branches/safari-605-branch/Source/_javascript_Core/dfg/DFGGraph.cpp	2018-01-24 05:22:25 UTC (rev 227472)
+++ branches/safari-605-branch/Source/_javascript_Core/dfg/DFGGraph.cpp	2018-01-24 05:22:30 UTC (rev 227473)
@@ -217,6 +217,8 @@
 out.print(comma, NodeFlagsDump(node->flags()));
 if (node->prediction())
 out.print(comma, SpeculationDump(node->prediction()));
+if (node->hasNumberOfArgumentsToSkip())
+out.print(comma, "numberOfArgumentsToSkip = ", node->numberOfArgumentsToSkip());
 if (node->hasArrayMode())
 out.print(comma, node->arrayMode());
 if (node->hasArithUnaryType())


Modified: branches/safari-605-branch/Source/_javascript_Core/dfg/DFGNode.h (227472 => 227473)

--- branches/safari-605-branch/Source/_javascript_Core/dfg/DFGNode.h	2018-01-24 05:22:25 UTC (rev 227472)
+++ branches/safari-605-branch/Source/_javascript_Core/dfg/DFGNode.h	2018-01-24 05:22:30 UTC (rev 227473)
@@ -2619,10 +2619,15 @@
 {
 m_misc.epoch = epoch.toUnsigned();
 }
+
+bool hasNumberOfArgumentsToSkip()
+{
+return op() == CreateRest || op() == PhantomCreateRest || op() == GetRestLength || op() == GetMyArgumentByVal || op() == GetMyArgumentByValOutOfBounds;
+}
 
 unsigned numberOfArgumentsToSkip()
 {
-ASSERT(op() == CreateRest || op() == PhantomCreateRest || op() == GetRestLength || op() == GetMyArgumentByVal || op() == GetMyArgumentByValOutOfBounds);
+ASSERT(hasNumberOfArgumentsToSkip());
 return m_opInfo.as();
 }
 


Modified: branches/safari-605-branch/Source/_javascript_Core/dfg/DFGStackLayoutPhase.cpp (227472 => 227473)

--- branches/safari-605-branch/Source/_javascript_Core/dfg/DFGStackLayoutPhase.cpp	2018-01-24 05:22:25 UTC (rev 227472)
+++ branches/safari-605-branch/Source/_ja

[webkit-changes] [227474] branches/safari-605-branch/Source/WebInspectorUI

[jmarcell]

Title: [227474] branches/safari-605-branch/Source/WebInspectorUI








Revision 227474
Author jmarc...@apple.com
Date 2018-01-23 21:22:32 -0800 (Tue, 23 Jan 2018)


Log Message
Cherry-pick r227463. rdar://problem/36807123

Modified Paths

branches/safari-605-branch/Source/WebInspectorUI/ChangeLog
branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/Table.js




Diff

Modified: branches/safari-605-branch/Source/WebInspectorUI/ChangeLog (227473 => 227474)

--- branches/safari-605-branch/Source/WebInspectorUI/ChangeLog	2018-01-24 05:22:30 UTC (rev 227473)
+++ branches/safari-605-branch/Source/WebInspectorUI/ChangeLog	2018-01-24 05:22:32 UTC (rev 227474)
@@ -1,3 +1,20 @@
+2018-01-23  Jason Marcell  
+
+Cherry-pick r227463. rdar://problem/36807123
+
+2018-01-23  Joseph Pecoraro  
+
+Web Inspector: Network's columns shake when scrolling at non-default zoom level
+https://bugs.webkit.org/show_bug.cgi?id=181998
+
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/Table.js:
+When zoomed the bounding client rect values were fractional, which was
+unexpected by this area of code. Floor the values to get a value we expect
+to be able to evenly distribute.
+
 2018-01-22  Jason Marcell  
 
 Cherry-pick r227370. rdar://problem/36763189


Modified: branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/Table.js (227473 => 227474)

--- branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/Table.js	2018-01-24 05:22:30 UTC (rev 227473)
+++ branches/safari-605-branch/Source/WebInspectorUI/UserInterface/Views/Table.js	2018-01-24 05:22:32 UTC (rev 227474)
@@ -709,8 +709,8 @@
 
 if (isNaN(this._cachedWidth)) {
 let boundingClientRect = this._scrollContainerElement.getBoundingClientRect();
-this._cachedWidth = boundingClientRect.width;
-this._cachedHeight = boundingClientRect.height;
+this._cachedWidth = Math.floor(boundingClientRect.width);
+this._cachedHeight = Math.floor(boundingClientRect.height);
 }
 
 // Not visible yet.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227468] trunk

[utatane . tea]

Title: [227468] trunk








Revision 227468
Author utatane@gmail.com
Date 2018-01-23 20:35:18 -0800 (Tue, 23 Jan 2018)


Log Message
Add more module scope related tests with code evaluation by string
https://bugs.webkit.org/show_bug.cgi?id=181983

Reviewed by Sam Weinig.

JSTests:

Add more module scope related tests. When the original tests are landed,
we do not have browser integration. This patch adds more module scope tests
with dynamically created script evaluation. We add tests with Function
constructor, direct eval, indirect eval, setTimeout, setInterval, and event handlers.

* modules/scopes-eval.js: Added.
(shouldBe):
* modules/scopes.js:
(shouldBe):

LayoutTests:

* js/dom/modules/module-scope-event-handler-expected.txt: Added.
* js/dom/modules/module-scope-event-handler.html: Added.
* js/dom/modules/module-scope-set-interval-expected.txt: Added.
* js/dom/modules/module-scope-set-interval.html: Added.
* js/dom/modules/module-scope-set-timeout-expected.txt: Added.
* js/dom/modules/module-scope-set-timeout.html: Added.

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/modules/scopes.js
trunk/LayoutTests/ChangeLog


Added Paths

trunk/JSTests/modules/scopes-eval.js
trunk/LayoutTests/js/dom/modules/module-scope-event-handler-expected.txt
trunk/LayoutTests/js/dom/modules/module-scope-event-handler.html
trunk/LayoutTests/js/dom/modules/module-scope-set-interval-expected.txt
trunk/LayoutTests/js/dom/modules/module-scope-set-interval.html
trunk/LayoutTests/js/dom/modules/module-scope-set-timeout-expected.txt
trunk/LayoutTests/js/dom/modules/module-scope-set-timeout.html




Diff

Modified: trunk/JSTests/ChangeLog (227467 => 227468)

--- trunk/JSTests/ChangeLog	2018-01-24 02:27:56 UTC (rev 227467)
+++ trunk/JSTests/ChangeLog	2018-01-24 04:35:18 UTC (rev 227468)
@@ -1,3 +1,20 @@
+2018-01-23  Yusuke Suzuki  
+
+Add more module scope related tests with code evaluation by string
+https://bugs.webkit.org/show_bug.cgi?id=181983
+
+Reviewed by Sam Weinig.
+
+Add more module scope related tests. When the original tests are landed,
+we do not have browser integration. This patch adds more module scope tests
+with dynamically created script evaluation. We add tests with Function
+constructor, direct eval, indirect eval, setTimeout, setInterval, and event handlers.
+
+* modules/scopes-eval.js: Added.
+(shouldBe):
+* modules/scopes.js:
+(shouldBe):
+
 2018-01-23  Filip Pizlo  
 
 Unreviewed, retire some microbenchmarks that are proportionately very slow. Benchmark running time should be proportional to their value. Microbenchmarks have little value, so they should be very fast.


Added: trunk/JSTests/modules/scopes-eval.js (0 => 227468)

--- trunk/JSTests/modules/scopes-eval.js	(rev 0)
+++ trunk/JSTests/modules/scopes-eval.js	2018-01-24 04:35:18 UTC (rev 227468)
@@ -0,0 +1,24 @@
+import { Cappuccino } from "./scopes/drink.js"
+import { shouldBe } from "./resources/assert.js";
+
+// Separate test from scopes.js since direct eval can taint variables.
+var global = Function("return this")();
+var globalEval = (0, eval);
+global.Cappuccino = 'Global Scope';
+shouldBe(Cappuccino, 'Cappuccino');
+
+(function () {
+let Cappuccino = 'Function Scope';
+shouldBe(Cappuccino, 'Function Scope');
+{
+let Cappuccino = 'Block Scope';
+{
+(function () {
+shouldBe(Cappuccino, 'Block Scope');
+shouldBe(eval(`Cappuccino`), 'Block Scope');
+}());
+}
+}
+shouldBe(Object, global.Object);
+}());
+shouldBe(Object, global.Object)


Modified: trunk/JSTests/modules/scopes.js (227467 => 227468)

--- trunk/JSTests/modules/scopes.js	2018-01-24 02:27:56 UTC (rev 227467)
+++ trunk/JSTests/modules/scopes.js	2018-01-24 04:35:18 UTC (rev 227468)
@@ -1,26 +1,36 @@
 import { Cocoa, Cappuccino, Matcha } from "./scopes/drink.js"
 import { shouldBe } from "./resources/assert.js";
 
+var global = Function("return this")();
+var globalEval = (0, eval);
+global.Cappuccino = 'Global Scope';
+
 {
 let Cocoa = 42;
 shouldBe(Cocoa, 42);
 }
 shouldBe(Cocoa, 'Cocoa');
-shouldBe(Cappuccino, 'Cappuccino');
+shouldBe(Cappuccino, 'Cappuccino'); // Module Scope.
 shouldBe(Matcha, 'Matcha');
 
-var global = Function("return this")();
-
 (function () {
 var Cocoa = 42;
-let Cappuccino = 'CPO';
+let Cappuccino = 'Function Scope';
 shouldBe(Cocoa, 42);
-shouldBe(Cappuccino, 'CPO');
+shouldBe(Cappuccino, 'Function Scope');
 shouldBe(Matcha, 'Matcha');
 {
+let Cappuccino = 'Block Scope';
 const Matcha = 50;
 shouldBe(Matcha, 50);
 shouldBe(Object, global.Object);
+{
+(function () {
+shouldBe(Cappuccino, 'Block Scope');
+shouldBe(globalEval(`Cappuccino`), 'Global Scope');
+shouldBe(Function(`return Cappuccino`)(),

[webkit-changes] [227467] trunk/Source

[achristensen]

Title: [227467] trunk/Source








Revision 227467
Author achristen...@apple.com
Date 2018-01-23 18:27:56 -0800 (Tue, 23 Jan 2018)


Log Message
Remove pre-Sierra-OS-specific code in WTF and _javascript_Core
https://bugs.webkit.org/show_bug.cgi?id=182028

Reviewed by Keith Miller.

Source/_javascript_Core:

* inspector/remote/cocoa/RemoteInspectorXPCConnection.h:
* inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:
(Inspector::RemoteInspectorXPCConnection::handleEvent):

Source/WTF:

* wtf/Platform.h:
* wtf/mac/AppKitCompatibilityDeclarations.h:
* wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
(WTF::MainThreadFunctionTracker::singleton): Deleted.
(WTF::MainThreadFunctionTracker::callOnMainThread): Deleted.
(WTF::MainThreadFunctionTracker::cancelCallOnMainThread): Deleted.
(WTF::MainThreadFunctionTracker::addFunction): Deleted.
(WTF::MainThreadFunctionTracker::removeIdentifier): Deleted.
(WTF::MainThreadFunctionTracker::removeFunctions): Deleted.
(WTF::callOnMainThread): Deleted.
(WTF::cancelCallOnMainThread): Deleted.
* wtf/spi/cocoa/SecuritySPI.h:
* wtf/spi/darwin/dyldSPI.h:
* wtf/text/icu/TextBreakIteratorICU.h:
(WTF::TextBreakIteratorICU::TextBreakIteratorICU):
(WTF::caretRules): Deleted.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorXPCConnection.h
trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorXPCConnection.mm
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WTF/wtf/mac/AppKitCompatibilityDeclarations.h
trunk/Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm
trunk/Source/WTF/wtf/spi/cocoa/SecuritySPI.h
trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h
trunk/Source/WTF/wtf/text/icu/TextBreakIteratorICU.h
trunk/Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227466 => 227467)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-24 01:09:36 UTC (rev 227466)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-24 02:27:56 UTC (rev 227467)
@@ -1,3 +1,14 @@
+2018-01-23  Alex Christensen  
+
+Remove pre-Sierra-OS-specific code in WTF and _javascript_Core
+https://bugs.webkit.org/show_bug.cgi?id=182028
+
+Reviewed by Keith Miller.
+
+* inspector/remote/cocoa/RemoteInspectorXPCConnection.h:
+* inspector/remote/cocoa/RemoteInspectorXPCConnection.mm:
+(Inspector::RemoteInspectorXPCConnection::handleEvent):
+
 2018-01-23  Filip Pizlo  
 
 Use precise index masking for FTL GetByArgumentByVal


Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorXPCConnection.h (227466 => 227467)

--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorXPCConnection.h	2018-01-24 01:09:36 UTC (rev 227466)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorXPCConnection.h	2018-01-24 02:27:56 UTC (rev 227467)
@@ -67,7 +67,7 @@
 dispatch_queue_t m_queue;
 Client* m_client;
 bool m_closed { false };
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)
+#if PLATFORM(MAC)
 bool m_validated { false };
 #endif
 };


Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorXPCConnection.mm (227466 => 227467)

--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorXPCConnection.mm	2018-01-24 01:09:36 UTC (rev 227466)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorXPCConnection.mm	2018-01-24 02:27:56 UTC (rev 227467)
@@ -46,7 +46,7 @@
 }
 #endif
 
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)
+#if PLATFORM(MAC)
 static bool auditTokenHasEntitlement(audit_token_t token, NSString *entitlement)
 {
 auto task = adoptCF(SecTaskCreateWithAuditToken(kCFAllocatorDefault, token));
@@ -169,7 +169,7 @@
 return;
 }
 
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)
+#if PLATFORM(MAC)
 if (!m_validated) {
 audit_token_t token;
 xpc_connection_get_audit_token(m_connection, &token);


Modified: trunk/Source/WTF/ChangeLog (227466 => 227467)

--- trunk/Source/WTF/ChangeLog	2018-01-24 01:09:36 UTC (rev 227466)
+++ trunk/Source/WTF/ChangeLog	2018-01-24 02:27:56 UTC (rev 227467)
@@ -1,3 +1,27 @@
+2018-01-23  Alex Christensen  
+
+Remove pre-Sierra-OS-specific code in WTF and _javascript_Core
+https://bugs.webkit.org/show_bug.cgi?id=182028
+
+Reviewed by Keith Miller.
+
+* wtf/Platform.h:
+* wtf/mac/AppKitCompatibilityDeclarations.h:
+* wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
+(WTF::MainThreadFunctionTracker::singleton): Deleted.
+(WTF::MainThreadFunctionTracker::callOnMainThread): Deleted.
+(WTF::MainThreadFunctionTracker::cancelCallOnMainThread): Deleted.
+(WTF::MainThreadFunctionTracker::addFunction): Deleted.
+(WTF::MainThreadFunctionTracker::removeIdentifier): Deleted.
+(WTF::MainThreadFunctionTrac

[webkit-changes] [227466] branches/safari-605-branch

[jmarcell]

Title: [227466] branches/safari-605-branch








Revision 227466
Author jmarc...@apple.com
Date 2018-01-23 17:09:36 -0800 (Tue, 23 Jan 2018)


Log Message
Revert r227216. rdar://problem/36722508

Modified Paths

branches/safari-605-branch/LayoutTests/ChangeLog
branches/safari-605-branch/Source/WebCore/ChangeLog
branches/safari-605-branch/Source/WebCore/page/ChromeClient.h
branches/safari-605-branch/Source/WebCore/testing/Internals.cpp
branches/safari-605-branch/Source/WebCore/testing/Internals.h
branches/safari-605-branch/Source/WebCore/testing/Internals.idl
branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/Platform/IPC/Connection.cpp
branches/safari-605-branch/Source/WebKit/Platform/IPC/Connection.h
branches/safari-605-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp
branches/safari-605-branch/Source/WebKit/UIProcess/WebProcessProxy.h
branches/safari-605-branch/Source/WebKit/UIProcess/WebProcessProxy.messages.in
branches/safari-605-branch/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/Storage/WebToStorageProcessConnection.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/WebConnectionToUIProcess.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
branches/safari-605-branch/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/WebProcess.cpp
branches/safari-605-branch/Source/WebKit/WebProcess/WebProcess.h
branches/safari-605-branch/Source/WebKit/WebProcess/WebProcess.messages.in


Removed Paths

branches/safari-605-branch/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt
branches/safari-605-branch/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html




Diff

Modified: branches/safari-605-branch/LayoutTests/ChangeLog (227465 => 227466)

--- branches/safari-605-branch/LayoutTests/ChangeLog	2018-01-24 01:08:29 UTC (rev 227465)
+++ branches/safari-605-branch/LayoutTests/ChangeLog	2018-01-24 01:09:36 UTC (rev 227466)
@@ -1,3 +1,7 @@
+2018-01-23  Jason Marcell  
+
+Revert r227216. rdar://problem/36722508
+
 2018-01-22  Jason Marcell  
 
 Cherry-pick r227370. rdar://problem/36763189


Deleted: branches/safari-605-branch/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt (227465 => 227466)

--- branches/safari-605-branch/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt	2018-01-24 01:08:29 UTC (rev 227465)
+++ branches/safari-605-branch/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt	2018-01-24 01:09:36 UTC (rev 227466)
@@ -1,10 +0,0 @@
-Tests that the WebProcess does not process incoming sync IPC while waiting for a sync reply.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Did not crash
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: branches/safari-605-branch/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html (227465 => 227466)

--- branches/safari-605-branch/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html	2018-01-24 01:08:29 UTC (rev 227465)
+++ branches/safari-605-branch/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html	2018-01-24 01:09:36 UTC (rev 227466)
@@ -1,12 +0,0 @@
-
-
-
-
-description("Tests that the WebProcess does not process incoming sync IPC while waiting for a sync reply.");
-
-internals.testIncomingSyncIPCMessageWhileWaitingForSyncReply();
-testPassed("Did not crash");
-
-
-


Modified: branches/safari-605-branch/Source/WebCore/ChangeLog (227465 => 227466)

--- branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-24 01:08:29 UTC (rev 227465)
+++ branches/safari-605-branch/Source/WebCore/ChangeLog	2018-01-24 01:09:36 UTC (rev 227466)
@@ -1,3 +1,7 @@
+2018-01-23  Jason Marcell  
+
+Revert r227216. rdar://problem/36722508
+
 2018-01-22  Jason Marcell  
 
 Cherry-pick r227351. rdar://problem/36746029


Modified: branches/safari-605-branch/Source/WebCore/page/ChromeClient.h (227465 => 227466)

--- branches/safari-605-branch/Source/WebCore/page/ChromeClient.h	2018-01-24 01:08:29 UTC (rev 227465)
+++ branches/safari-605-branch/Source/WebCore/page/ChromeClient.h	2018-01-24 01:09:36 UTC (rev 227466)
@@ -474,8 +474,6 @@
 virtual void didInsertMenuItemElement(HTMLMenuItemElement&) { }
 virtual void didRemoveMenuItemElement(HTMLMenuItemElement&) { }
 
-virtual void testIncomingSyncIPCMessageWhileWaitingForSyncReply() { }
-
 protected:
 virtual ~ChromeClient() = default;
 };


Modified: branches/safari-605-branch/Source/WebCore/testing/Internals.cpp (227465 => 227466)

--- branches/safari-605-branch/Source/WebCore/testing/Internals.cpp	2018-01-

[webkit-changes] [227465] trunk/Source/WebCore

[commit-queue]

Title: [227465] trunk/Source/WebCore








Revision 227465
Author commit-qu...@webkit.org
Date 2018-01-23 17:08:29 -0800 (Tue, 23 Jan 2018)


Log Message
[Curl] Fix wrong redirection with relative url when it happens from
different host than original host.
https://bugs.webkit.org/show_bug.cgi?id=181873

Patch by Basuke Suzuki  on 2018-01-23
Reviewed by Alex Christensen.

* platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::willSendRequest):
* platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::willSendRequest):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp
trunk/Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (227464 => 227465)

--- trunk/Source/WebCore/ChangeLog	2018-01-24 01:07:31 UTC (rev 227464)
+++ trunk/Source/WebCore/ChangeLog	2018-01-24 01:08:29 UTC (rev 227465)
@@ -1,3 +1,16 @@
+2018-01-23  Basuke Suzuki  
+
+[Curl] Fix wrong redirection with relative url when it happens from
+different host than original host.
+https://bugs.webkit.org/show_bug.cgi?id=181873
+
+Reviewed by Alex Christensen.
+
+* platform/network/curl/CurlDownload.cpp:
+(WebCore::CurlDownload::willSendRequest):
+* platform/network/curl/ResourceHandleCurlDelegate.cpp:
+(WebCore::ResourceHandleCurlDelegate::willSendRequest):
+
 2018-01-23  Eric Carlson  
 
 Resign NowPlaying status when no media element is eligible


Modified: trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp (227464 => 227465)

--- trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp	2018-01-24 01:07:31 UTC (rev 227464)
+++ trunk/Source/WebCore/platform/network/curl/CurlDownload.cpp	2018-01-24 01:08:29 UTC (rev 227465)
@@ -174,7 +174,7 @@
 }
 
 String location = m_response.httpHeaderField(HTTPHeaderName::Location);
-URL newURL = URL(m_request.url(), location);
+URL newURL = URL(m_response.url(), location);
 bool crossOrigin = !protocolHostAndPortAreEqual(m_request.url(), newURL);
 
 ResourceRequest newRequest = m_request;


Modified: trunk/Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp (227464 => 227465)

--- trunk/Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp	2018-01-24 01:07:31 UTC (rev 227464)
+++ trunk/Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp	2018-01-24 01:08:29 UTC (rev 227465)
@@ -322,7 +322,7 @@
 }
 
 String location = response().httpHeaderField(HTTPHeaderName::Location);
-URL newURL = URL(m_firstRequest.url(), location);
+URL newURL = URL(m_handle->getInternal()->m_response.url(), location);
 bool crossOrigin = !protocolHostAndPortAreEqual(m_firstRequest.url(), newURL);
 
 ResourceRequest newRequest = m_firstRequest;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227464] trunk/LayoutTests

[jlewis3]

Title: [227464] trunk/LayoutTests








Revision 227464
Author jlew...@apple.com
Date 2018-01-23 17:07:31 -0800 (Tue, 23 Jan 2018)


Log Message
Marked http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=181958

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227463 => 227464)

--- trunk/LayoutTests/ChangeLog	2018-01-24 00:46:39 UTC (rev 227463)
+++ trunk/LayoutTests/ChangeLog	2018-01-24 01:07:31 UTC (rev 227464)
@@ -1,5 +1,14 @@
 2018-01-23  Matt Lewis  
 
+Marked http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=181958
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2018-01-23  Matt Lewis  
+
 Marked fast/visual-viewport/ios/caret-after-focus-in-fixed.html as flaky
 https://bugs.webkit.org/show_bug.cgi?id=181821
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (227463 => 227464)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-01-24 00:46:39 UTC (rev 227463)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-01-24 01:07:31 UTC (rev 227464)
@@ -803,7 +803,6 @@
 [ HighSierra+ ] http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html [ Pass ]
 [ HighSierra+ ] http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html [ Pass Timeout ]
 [ HighSierra+ ] http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context.html [ Pass ]
-[ HighSierra+ ] http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html [ Pass ]
 [ HighSierra+ ] http/tests/resourceLoadStatistics/add-blocking-to-redirect.html [ Pass ]
 [ HighSierra+ ] http/tests/resourceLoadStatistics/remove-partitioning-in-redirect.html [ Pass ]
 [ HighSierra+ ] http/tests/resourceLoadStatistics/remove-blocking-in-redirect.html [ Pass ]
@@ -810,6 +809,8 @@
 [ HighSierra+ ] http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store.html [ Pass ]
 [ HighSierra+ ] http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html [ Pass ]
 
+webkit.org/b/181958 [ HighSierra+ ] http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html [ Pass Failure ]
+
 # 
 webkit.org/b/177616 [ HighSierra+ ] http/tests/media/video-buffered-range-contains-currentTime.html [ Pass Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227463] trunk/Source/WebInspectorUI

[commit-queue]

Title: [227463] trunk/Source/WebInspectorUI








Revision 227463
Author commit-qu...@webkit.org
Date 2018-01-23 16:46:39 -0800 (Tue, 23 Jan 2018)


Log Message
Web Inspector: Network's columns shake when scrolling at non-default zoom level
https://bugs.webkit.org/show_bug.cgi?id=181998


Patch by Joseph Pecoraro  on 2018-01-23
Reviewed by Matt Baker.

* UserInterface/Views/Table.js:
When zoomed the bounding client rect values were fractional, which was
unexpected by this area of code. Floor the values to get a value we expect
to be able to evenly distribute.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/Table.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (227462 => 227463)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-01-24 00:40:12 UTC (rev 227462)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-01-24 00:46:39 UTC (rev 227463)
@@ -1,3 +1,16 @@
+2018-01-23  Joseph Pecoraro  
+
+Web Inspector: Network's columns shake when scrolling at non-default zoom level
+https://bugs.webkit.org/show_bug.cgi?id=181998
+
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/Table.js:
+When zoomed the bounding client rect values were fractional, which was
+unexpected by this area of code. Floor the values to get a value we expect
+to be able to evenly distribute.
+
 2018-01-22  Nikita Vasilyev  
 
 Web Inspector: Styles Redesign: data corruption when updating values quickly


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (227462 => 227463)

--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js	2018-01-24 00:40:12 UTC (rev 227462)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js	2018-01-24 00:46:39 UTC (rev 227463)
@@ -709,8 +709,8 @@
 
 if (isNaN(this._cachedWidth)) {
 let boundingClientRect = this._scrollContainerElement.getBoundingClientRect();
-this._cachedWidth = boundingClientRect.width;
-this._cachedHeight = boundingClientRect.height;
+this._cachedWidth = Math.floor(boundingClientRect.width);
+this._cachedHeight = Math.floor(boundingClientRect.height);
 }
 
 // Not visible yet.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227462] trunk/Source/JavaScriptCore

[fpizlo]

Title: [227462] trunk/Source/_javascript_Core








Revision 227462
Author fpi...@apple.com
Date 2018-01-23 16:40:12 -0800 (Tue, 23 Jan 2018)


Log Message
Use precise index masking for FTL GetByArgumentByVal
https://bugs.webkit.org/show_bug.cgi?id=182006

Reviewed by Keith Miller.

This protects speculative out-of-bounds on arguments[index].

Making this work right involved fixing a possible overflow situation with
numberOfArgumentsToSkip.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasNumberOfArgumentsToSkip):
(JSC::DFG::Node::numberOfArgumentsToSkip):
* dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGStackLayoutPhase.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227461 => 227462)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-24 00:31:03 UTC (rev 227461)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-24 00:40:12 UTC (rev 227462)
@@ -1,3 +1,27 @@
+2018-01-23  Filip Pizlo  
+
+Use precise index masking for FTL GetByArgumentByVal
+https://bugs.webkit.org/show_bug.cgi?id=182006
+
+Reviewed by Keith Miller.
+
+This protects speculative out-of-bounds on arguments[index].
+
+Making this work right involved fixing a possible overflow situation with
+numberOfArgumentsToSkip.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
+* dfg/DFGGraph.cpp:
+(JSC::DFG::Graph::dump):
+* dfg/DFGNode.h:
+(JSC::DFG::Node::hasNumberOfArgumentsToSkip):
+(JSC::DFG::Node::numberOfArgumentsToSkip):
+* dfg/DFGStackLayoutPhase.cpp:
+(JSC::DFG::StackLayoutPhase::run):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
+
 2018-01-23  David Kilzer  
 
 Follow-up for: oss-fuzz jsc build is broken: StringImpl.h:27:10: fatal error: 'unicode/ustring.h' file not found


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (227461 => 227462)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-24 00:31:03 UTC (rev 227461)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-24 00:40:12 UTC (rev 227462)
@@ -502,8 +502,6 @@
 break;
 if (operand.offset() < static_cast(inlineCallFrame->stackOffset + CallFrame::headerSizeInRegisters))
 continue;
-if (operand.offset() == inlineCallFrame->stackOffset + CallFrame::thisArgumentOffset())
-continue;
 if (operand.offset() >= static_cast(inlineCallFrame->stackOffset + CallFrame::thisArgumentOffset() + inlineCallFrame->argumentsWithFixup.size()))
 continue;
 int argument = VirtualRegister(operand.offset() - inlineCallFrame->stackOffset).toArgument();


Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (227461 => 227462)

--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp	2018-01-24 00:31:03 UTC (rev 227461)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp	2018-01-24 00:40:12 UTC (rev 227462)
@@ -217,6 +217,8 @@
 out.print(comma, NodeFlagsDump(node->flags()));
 if (node->prediction())
 out.print(comma, SpeculationDump(node->prediction()));
+if (node->hasNumberOfArgumentsToSkip())
+out.print(comma, "numberOfArgumentsToSkip = ", node->numberOfArgumentsToSkip());
 if (node->hasArrayMode())
 out.print(comma, node->arrayMode());
 if (node->hasArithUnaryType())


Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (227461 => 227462)

--- trunk/Source/_javascript_Core/dfg/DFGNode.h	2018-01-24 00:31:03 UTC (rev 227461)
+++ trunk/Source/_javascript_Core/dfg/DFGNode.h	2018-01-24 00:40:12 UTC (rev 227462)
@@ -2640,10 +2640,15 @@
 {
 m_misc.epoch = epoch.toUnsigned();
 }
+
+bool hasNumberOfArgumentsToSkip()
+{
+return op() == CreateRest || op() == PhantomCreateRest || op() == GetRestLength || op() == GetMyArgumentByVal || op() == GetMyArgumentByValOutOfBounds;
+}
 
 unsigned numberOfArgumentsToSkip()
 {
-ASSERT(op() == CreateRest || op() == PhantomCreateRest || op() == GetRestLength || op() == GetMyArgumentByVal || op() == GetMyArgumentByValOutOfBounds);
+ASSERT(hasNumberOfArgumentsToSkip());
 return m_opInfo.as();
 }
 


Modified: trunk/Source/_javascript_Core/dfg/DFGStackLayoutPhase.cpp (227461 => 227462)

--- trunk/Source/_javascript_Core/dfg/D

[webkit-changes] [227460] trunk/Tools

[rniwa]

Title: [227460] trunk/Tools








Revision 227460
Author rn...@webkit.org
Date 2018-01-23 16:30:06 -0800 (Tue, 23 Jan 2018)


Log Message
Mac Sierra perf bots have been failing due to CG errors
https://bugs.webkit.org/show_bug.cgi?id=181955

Reviewed by Antti Koivisto.

Ignore the CoreGraphics error messages on macOS Sierra.

Also added tests for ignoring lines in stdout and stderr.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest.run_failed): Refactored for clarity.
(PerfTest):
(PerfTest.filter_ignored_lines): Added.
(PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
are now used to ignore lines in other kinds of tests than parser tests.
(PerfTest._errors_to_ignore_in_sierra): Added.
(PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(test_parse_output_with_ignored_stdout): Added.
(test_parse_output_with_ignored_stderr): Added.
(test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (227459 => 227460)

--- trunk/Tools/ChangeLog	2018-01-23 23:53:04 UTC (rev 227459)
+++ trunk/Tools/ChangeLog	2018-01-24 00:30:06 UTC (rev 227460)
@@ -1,3 +1,27 @@
+2018-01-22  Ryosuke Niwa  
+
+Mac Sierra perf bots have been failing due to CG errors
+https://bugs.webkit.org/show_bug.cgi?id=181955
+
+Reviewed by Antti Koivisto.
+
+Ignore the CoreGraphics error messages on macOS Sierra.
+
+Also added tests for ignoring lines in stdout and stderr.
+
+* Scripts/webkitpy/performance_tests/perftest.py:
+(PerfTest.run_failed): Refactored for clarity.
+(PerfTest):
+(PerfTest.filter_ignored_lines): Added.
+(PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
+are now used to ignore lines in other kinds of tests than parser tests.
+(PerfTest._errors_to_ignore_in_sierra): Added.
+(PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
+* Scripts/webkitpy/performance_tests/perftest_unittest.py:
+(test_parse_output_with_ignored_stdout): Added.
+(test_parse_output_with_ignored_stderr): Added.
+(test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
+
 2018-01-23  Eric Carlson  
 
 Resign NowPlaying status when no media element is eligible


Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py (227459 => 227460)

--- trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2018-01-23 23:53:04 UTC (rev 227459)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftest.py	2018-01-24 00:30:06 UTC (rev 227460)
@@ -218,8 +218,10 @@
 return driver.run_test(DriverInput(test_path, time_out_ms, image_hash=None, should_run_pixel_test=should_run_pixel_test), stop_when_done=False)
 
 def run_failed(self, output):
-if output.text == None or output.error:
+if output.text == None:
 pass
+elif output.error:
+_log.error('error: %s\n%s' % (self.test_name(), output.error))
 elif output.timeout:
 _log.error('timeout: %s' % self.test_name())
 elif output.crash:
@@ -227,9 +229,6 @@
 else:
 return False
 
-if output.error:
-_log.error('error: %s\n%s' % (self.test_name(), output.error))
-
 return True
 
 @staticmethod
@@ -241,7 +240,13 @@
 return True
 return False
 
-_lines_to_ignore_in_parser_result = [
+@staticmethod
+def filter_ignored_lines(regexps, text):
+lines = re.split('\n', text)
+filtered_lines = [line for line in lines if not PerfTest._should_ignore_line(regexps, line)]
+return '\n'.join(filtered_lines)
+
+_lines_to_ignore = [
 re.compile("^\s+$"),
 # Following are for handle existing test like Dromaeo
 re.compile(re.escape("""main frame - has 1 onunload handler(s)""")),
@@ -257,9 +262,17 @@
 re.compile(r'CONSOLE MESSAGE: line \d+: DEBUG: jQuery\s+: (\d\.)+'),
 ]
 
+_errors_to_ignore_in_sierra = [
+# GC errors on macOS 10.12.6
+re.compile(r'WebKitTestRunner\[\d+\] : CGContext\w+: invalid context 0x0\. If you want to see the backtrace, please set CG_CONTEXT_SHOW_BACKTRACE environmental variable.'),
+]
+
 def _filter_output(self, output):
 if output.text:
-output.text = '\n'.join([line for line in re.split('\n', output.text) if not self._should_ignore_line(self._lines_to_ignore_in_parser_result, line)])
+output.text = self.filter_ignored_lines(self._lines_to_ignore, output.text)
+if output.error:
+if self._port.

[webkit-changes] [227457] trunk

[eric . carlson]

Title: [227457] trunk








Revision 227457
Author eric.carl...@apple.com
Date 2018-01-23 15:34:06 -0800 (Tue, 23 Jan 2018)


Log Message
Resign NowPlaying status when no media element is eligible
https://bugs.webkit.org/show_bug.cgi?id=181914


Reviewed by Jer Noble.

Source/WebCore:

Updated API test.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFromAncestor): Call mediaSession->clientCharacteristicsChanged
so NowPlaying status will be updated.

* html/MediaElementSession.cpp:
(WebCore::MediaElementSession::playbackPermitted const): Return early when the media
element has been suspended.
(WebCore::MediaElementSession::canShowControlsManager const): Return false when being queried
for NowPlaying status in an inactive document or when element has been suspended.
(WebCore::isMainContentForPurposesOfAutoplay): Return early if it isn't safe to update
style because HitTest can force a layout.
(WebCore::MediaElementSession::updateIsMainContent const): Ditto.

* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary): Implement in for all
ports.
* platform/audio/PlatformMediaSessionManager.h:
(WebCore::PlatformMediaSessionManager::registeredAsNowPlayingApplication const):
* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/mac/MediaSessionManagerMac.h:
* platform/audio/mac/MediaSessionManagerMac.mm:
(WebCore::MediaSessionManagerMac::updateNowPlayingInfo): Call MRMediaRemoteSetCanBeNowPlayingApplication
whenever status changes.
(WebCore::PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary): Deleted, implemented
in the base class.

Source/WebKit:

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _requestActiveNowPlayingSessionInfo:]): Return registeredAsNowPlayingApplication
status.
* UIProcess/API/Cocoa/WKWebViewPrivate.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::nowPlayingInfoCallback): Ditto.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::requestActiveNowPlayingSessionInfo): Ditto.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
(-[NowPlayingTestWebView hasActiveNowPlayingSession]):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/MediaElementSession.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h
trunk/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.h
trunk/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (227456 => 227457)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 23:25:19 UTC (rev 227456)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 23:34:06 UTC (rev 227457)
@@ -1,3 +1,39 @@
+2018-01-23  Eric Carlson  
+
+Resign NowPlaying status when no media element is eligible
+https://bugs.webkit.org/show_bug.cgi?id=181914
+
+
+Reviewed by Jer Noble.
+
+Updated API test.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::removedFromAncestor): Call mediaSession->clientCharacteristicsChanged
+so NowPlaying status will be updated.
+
+* html/MediaElementSession.cpp:
+(WebCore::MediaElementSession::playbackPermitted const): Return early when the media 
+element has been suspended.
+(WebCore::MediaElementSession::canShowControlsManager const): Return false when being queried
+for NowPlaying status in an inactive document or when element has been suspended.
+(WebCore::isMainContentForPurposesOfAutoplay): Return early if it isn't safe to update
+style because HitTest can force a layout.
+(WebCore::MediaElementSession::updateIsMainContent const): Ditto.
+
+* platform/audio/PlatformMediaSessionManager.cpp:
+(WebCore::PlatformMediaSessionManager::updateNowPlayingInfoIfNecessary): Implement in for all
+ports.
+* platform/audio/PlatformMediaSessionManager.h:
+(WebCore::PlatformMediaSessionManager::registeredAsNowPlayingApplication const):
+* platform/audio/ios/MediaSessionManagerIOS.h:
+ 

[webkit-changes] [227456] trunk/LayoutTests

[jlewis3]

Title: [227456] trunk/LayoutTests








Revision 227456
Author jlew...@apple.com
Date 2018-01-23 15:25:19 -0800 (Tue, 23 Jan 2018)


Log Message
Skipped fast/events/message-port.html on macOS
https://bugs.webkit.org/show_bug.cgi?id=181969

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227455 => 227456)

--- trunk/LayoutTests/ChangeLog	2018-01-23 23:22:19 UTC (rev 227455)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 23:25:19 UTC (rev 227456)
@@ -1,5 +1,14 @@
 2018-01-23  Matt Lewis  
 
+Skipped fast/events/message-port.html on macOS
+https://bugs.webkit.org/show_bug.cgi?id=181969
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2018-01-23  Matt Lewis  
+
 Marked media/W3C/audio/events/event_progress.html and media/W3C/video/events/event_order_loadstart_progress.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=181966
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (227455 => 227456)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-01-23 23:22:19 UTC (rev 227455)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-01-23 23:25:19 UTC (rev 227456)
@@ -1790,3 +1790,5 @@
 webkit.org/b/181966 [ Debug ] media/W3C/audio/events/event_progress.html [ Pass Failure ]
 webkit.org/b/181966 media/W3C/video/events/event_order_loadstart_progress.html [ Pass Failure ]
 
+webkit.org/b/181969 fast/events/message-port.html [ Skip ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227455] trunk/Source

[achristensen]

Title: [227455] trunk/Source








Revision 227455
Author achristen...@apple.com
Date 2018-01-23 15:22:19 -0800 (Tue, 23 Jan 2018)


Log Message
Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
https://bugs.webkit.org/show_bug.cgi?id=181961

Reviewed by Michael Catanzaro.

Source/WebCore:

No change in behavior.

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponseAsync):
* loader/ResourceLoader.h:
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponseAsync):
* loader/appcache/ApplicationCacheGroup.h:
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
(WebCore::BlobResourceHandle::notifyResponseOnError):
(WebCore::BlobResourceHandle::continueDidReceiveResponse): Deleted.
* platform/network/BlobResourceHandle.h:
* platform/network/PingHandle.h:
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::didReceiveResponse):
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* platform/network/SynchronousLoaderClient.cpp:
(WebCore::SynchronousLoaderClient::didReceiveResponseAsync):
* platform/network/SynchronousLoaderClient.h:
* platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::continueDidReceiveResponse): Deleted.
* platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::curlDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::handleDataURL):
(WebCore::ResourceHandleCurlDelegate::continueDidReceiveResponse): Deleted.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::continueDidReceiveResponse): Deleted.
* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:
* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate continueDidReceiveResponse]): Deleted.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::continueDidReceiveResponse): Deleted.

Source/WebKit:

* NetworkProcess/Downloads/Download.h:
* NetworkProcess/NetworkLoad.cpp:
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/NetworkResourceLoadParameters.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
* WebProcess/WebPage/mac/WebPageMac.mm:
* WebProcess/WebProcess.cpp:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:

Source/WebKitLegacy/mac:

* WebView/WebPreferences.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ResourceLoader.cpp
trunk/Source/WebCore/loader/ResourceLoader.h
trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp
trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.h
trunk/Source/WebCore/platform/network/BlobResourceHandle.cpp
trunk/Source/WebCore/platform/network/BlobResourceHandle.h
trunk/Source/WebCore/platform/network/PingHandle.h
trunk/Source/WebCore/platform/network/ResourceHandle.cpp
trunk/Source/WebCore/platform/network/ResourceHandle.h
trunk/Source/WebCore/platform/network/ResourceHandleClient.h
trunk/Source/WebCore/platform/network/SynchronousLoaderClient.cpp
trunk/Source/WebCore/platform/network/SynchronousLoaderClient.h
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.h
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h
trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp
trunk/Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp
trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h
trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Downloads/Download.h
trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoad.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h
trunk/Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm
trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKitLegacy/ChangeLog
trunk/Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/So

[webkit-changes] [227454] trunk/LayoutTests

[jlewis3]

Title: [227454] trunk/LayoutTests








Revision 227454
Author jlew...@apple.com
Date 2018-01-23 15:21:32 -0800 (Tue, 23 Jan 2018)


Log Message
Marked media/W3C/audio/events/event_progress.html and media/W3C/video/events/event_order_loadstart_progress.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=181966

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227453 => 227454)

--- trunk/LayoutTests/ChangeLog	2018-01-23 23:19:02 UTC (rev 227453)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 23:21:32 UTC (rev 227454)
@@ -1,3 +1,12 @@
+2018-01-23  Matt Lewis  
+
+Marked media/W3C/audio/events/event_progress.html and media/W3C/video/events/event_order_loadstart_progress.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=181966
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2018-01-23  Chris Dumez  
 
 Unreviewed, rollout r227216 as it seems to be causing deadlocks


Modified: trunk/LayoutTests/platform/mac/TestExpectations (227453 => 227454)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-01-23 23:19:02 UTC (rev 227453)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-01-23 23:21:32 UTC (rev 227454)
@@ -1786,3 +1786,7 @@
 webkit.org/b/181565 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-a-bitrate.html [ Pass Failure ]
 webkit.org/b/181565 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-bitrate.html [ Pass Failure ]
 webkit.org/b/181565 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Pass Failure ]
+
+webkit.org/b/181966 [ Debug ] media/W3C/audio/events/event_progress.html [ Pass Failure ]
+webkit.org/b/181966 media/W3C/video/events/event_order_loadstart_progress.html [ Pass Failure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227453] trunk/Source/JavaScriptCore

[ddkilzer]

Title: [227453] trunk/Source/_javascript_Core








Revision 227453
Author ddkil...@apple.com
Date 2018-01-23 15:19:02 -0800 (Tue, 23 Jan 2018)


Log Message
Follow-up for: oss-fuzz jsc build is broken: StringImpl.h:27:10: fatal error: 'unicode/ustring.h' file not found



Address feedback for this change.

* CMakeLists.txt: Change "SYSTEM PUBLIC" to "SYSTEM PRIVATE" per
feedback from Konstantin Tokarev.

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (227452 => 227453)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2018-01-23 23:15:39 UTC (rev 227452)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2018-01-23 23:19:02 UTC (rev 227453)
@@ -596,7 +596,7 @@
 WEBKIT_CREATE_FORWARDING_HEADERS(_javascript_Core DIRECTORIES ${_javascript_Core_FORWARDING_HEADERS_DIRECTORIES} FILES ${_javascript_Core_FORWARDING_HEADERS_FILES})
 
 target_include_directories(LLIntOffsetsExtractor PRIVATE ${_javascript_Core_INCLUDE_DIRECTORIES})
-target_include_directories(LLIntOffsetsExtractor SYSTEM PUBLIC ${_javascript_Core_SYSTEM_INCLUDE_DIRECTORIES})
+target_include_directories(LLIntOffsetsExtractor SYSTEM PRIVATE ${_javascript_Core_SYSTEM_INCLUDE_DIRECTORIES})
 
 add_subdirectory(shell)
 


Modified: trunk/Source/_javascript_Core/ChangeLog (227452 => 227453)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-23 23:15:39 UTC (rev 227452)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-23 23:19:02 UTC (rev 227453)
@@ -1,3 +1,14 @@
+2018-01-23  David Kilzer  
+
+Follow-up for: oss-fuzz jsc build is broken: StringImpl.h:27:10: fatal error: 'unicode/ustring.h' file not found
+
+
+
+Address feedback for this change.
+
+* CMakeLists.txt: Change "SYSTEM PUBLIC" to "SYSTEM PRIVATE" per
+feedback from Konstantin Tokarev.
+
 2018-01-23  Robin Morisset  
 
 Rollout r219636






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227452] trunk

[cdumez]

Title: [227452] trunk








Revision 227452
Author cdu...@apple.com
Date 2018-01-23 15:15:39 -0800 (Tue, 23 Jan 2018)


Log Message
Unreviewed, rollout r227216 as it seems to be causing deadlocks
https://bugs.webkit.org/show_bug.cgi?id=182013

Source/WebCore:

* page/ChromeClient.h:
* testing/Internals.cpp:
(WebCore::Internals::testIncomingSyncIPCMessageWhileWaitingForSyncReply): Deleted.
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

* Platform/IPC/Connection.cpp:
(IPC::Connection::waitForSyncReply):
* Platform/IPC/Connection.h:
(IPC::Connection::setShouldProcessIncomingMessagesWhileWaitingForSyncReply): Deleted.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::testIncomingSyncIPCMessageWhileWaitingForSyncReply): Deleted.
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::NetworkProcessConnection):
* WebProcess/Storage/WebToStorageProcessConnection.cpp:
(WebKit::WebToStorageProcessConnection::WebToStorageProcessConnection):
* WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::testIncomingSyncIPCMessageWhileWaitingForSyncReply): Deleted.
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::undo):
(WebKit::WebEditorClient::redo):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::syncIPCMessageWhileWaitingForSyncReplyForTesting): Deleted.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

LayoutTests:

* fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt: Removed.
* fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/IPC/Connection.cpp
trunk/Source/WebKit/Platform/IPC/Connection.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.messages.in
trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
trunk/Source/WebKit/WebProcess/Storage/WebToStorageProcessConnection.cpp
trunk/Source/WebKit/WebProcess/WebConnectionToUIProcess.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Source/WebKit/WebProcess/WebProcess.messages.in


Removed Paths

trunk/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt
trunk/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html




Diff

Modified: trunk/LayoutTests/ChangeLog (227451 => 227452)

--- trunk/LayoutTests/ChangeLog	2018-01-23 23:14:20 UTC (rev 227451)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 23:15:39 UTC (rev 227452)
@@ -1,3 +1,11 @@
+2018-01-23  Chris Dumez  
+
+Unreviewed, rollout r227216 as it seems to be causing deadlocks
+https://bugs.webkit.org/show_bug.cgi?id=182013
+
+* fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt: Removed.
+* fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html: Removed.
+
 2018-01-23  Matt Lewis  
 
 Marked http/tests/misc/resource-timing-resolution.html as flaky.


Deleted: trunk/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt (227451 => 227452)

--- trunk/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt	2018-01-23 23:14:20 UTC (rev 227451)
+++ trunk/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply-expected.txt	2018-01-23 23:15:39 UTC (rev 227452)
@@ -1,10 +0,0 @@
-Tests that the WebProcess does not process incoming sync IPC while waiting for a sync reply.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Did not crash
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html (227451 => 227452)

--- trunk/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html	2018-01-23 23:14:20 UTC (rev 227451)
+++ trunk/LayoutTests/fast/misc/testIncomingSyncIPCMessageWhileWaitingForSyncReply.html	2018-01-23 23:15:39 UTC (rev 227452)
@@ -1,12 +0,0 @@
-
-
-
-
-description("Tests that the WebProcess does not process incoming sync IPC while waiting for a sync reply.");
-
-internals.testIncomingSyncIPCMessageWhileWaitingForSyncReply();
-testPasse

[webkit-changes] [227449] trunk/Source/WebCore

[commit-queue]

Title: [227449] trunk/Source/WebCore








Revision 227449
Author commit-qu...@webkit.org
Date 2018-01-23 14:30:39 -0800 (Tue, 23 Jan 2018)


Log Message
[Curl] CurlRequest must protect its client from disposal while it's on duty.
https://bugs.webkit.org/show_bug.cgi?id=181875

Patch by Basuke Suzuki  on 2018-01-23
Reviewed by Alex Christensen.

No new tests. It's covered by existing tests.

* platform/network/curl/CurlDownload.h:
* platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::callClient):
(WebCore::CurlRequest::didReceiveData):
(WebCore::CurlRequest::didReceiveDataFromMultipart):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::invokeDidReceiveResponse):
* platform/network/curl/CurlRequest.h:
* platform/network/curl/CurlRequestClient.h:
* platform/network/curl/ResourceHandleCurlDelegate.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlDownload.h
trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
trunk/Source/WebCore/platform/network/curl/CurlRequest.h
trunk/Source/WebCore/platform/network/curl/CurlRequestClient.h
trunk/Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (227448 => 227449)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 22:30:19 UTC (rev 227448)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 22:30:39 UTC (rev 227449)
@@ -1,3 +1,23 @@
+2018-01-23  Basuke Suzuki  
+
+[Curl] CurlRequest must protect its client from disposal while it's on duty.
+https://bugs.webkit.org/show_bug.cgi?id=181875
+
+Reviewed by Alex Christensen.
+
+No new tests. It's covered by existing tests.
+
+* platform/network/curl/CurlDownload.h:
+* platform/network/curl/CurlRequest.cpp:
+(WebCore::CurlRequest::callClient):
+(WebCore::CurlRequest::didReceiveData):
+(WebCore::CurlRequest::didReceiveDataFromMultipart):
+(WebCore::CurlRequest::didCompleteTransfer):
+(WebCore::CurlRequest::invokeDidReceiveResponse):
+* platform/network/curl/CurlRequest.h:
+* platform/network/curl/CurlRequestClient.h:
+* platform/network/curl/ResourceHandleCurlDelegate.h:
+
 2018-01-23  Commit Queue  
 
 Unreviewed, rolling out r227437.


Modified: trunk/Source/WebCore/platform/network/curl/CurlDownload.h (227448 => 227449)

--- trunk/Source/WebCore/platform/network/curl/CurlDownload.h	2018-01-23 22:30:19 UTC (rev 227448)
+++ trunk/Source/WebCore/platform/network/curl/CurlDownload.h	2018-01-23 22:30:39 UTC (rev 227449)
@@ -52,6 +52,9 @@
 CurlDownload() = default;
 ~CurlDownload();
 
+void ref() override { ThreadSafeRefCounted::ref(); }
+void deref() override { ThreadSafeRefCounted::deref(); }
+
 void init(CurlDownloadListener&, const URL&);
 void init(CurlDownloadListener&, ResourceHandle*, const ResourceRequest&, const ResourceResponse&);
 


Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (227448 => 227449)

--- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp	2018-01-23 22:30:19 UTC (rev 227448)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp	2018-01-23 22:30:39 UTC (rev 227449)
@@ -142,15 +142,19 @@
 }
 
 /* `this` is protected inside this method. */
-void CurlRequest::callClient(WTF::Function task)
+void CurlRequest::callClient(WTF::Function task)
 {
 if (isMainThread()) {
-if (CurlRequestClient* client = m_client)
-task(client);
+if (CurlRequestClient* client = m_client) {
+RefPtr protectedClient(client);
+task(*client);
+}
 } else {
 callOnMainThread([protectedThis = makeRef(*this), task = WTFMove(task)]() mutable {
-if (CurlRequestClient* client = protectedThis->m_client)
-task(client);
+if (CurlRequestClient* client = protectedThis->m_client) {
+RefPtr protectedClient(client);
+task(*client);
+}
 });
 }
 }
@@ -356,9 +360,8 @@
 if (m_multipartHandle)
 m_multipartHandle->didReceiveData(buffer);
 else {
-callClient([this, buffer = WTFMove(buffer)](CurlRequestClient* client) mutable {
-if (client)
-client->curlDidReceiveBuffer(WTFMove(buffer));
+callClient([buffer = WTFMove(buffer)](CurlRequestClient& client) mutable {
+client.curlDidReceiveBuffer(WTFMove(buffer));
 });
 }
 }
@@ -389,9 +392,8 @@
 auto receiveBytes = buffer->size();
 
 if (receiveBytes) {
-callClient([this, buffer = WTFMove(buffer)](CurlRequestClient* client) mutable {
-if (client)
-client->curlDidReceiveBuffer(WTFMove(buffer));
+callClient([buffer = WTFMove(buffer)](CurlRequestClient& client) mutable {
+client.curlDidReceiveBuffer(WTFMove(buffer));
 });
 }
 }
@@ -41

[webkit-changes] [227446] branches/safari-605-branch/Source/WebKit

[jmarcell]

Title: [227446] branches/safari-605-branch/Source/WebKit








Revision 227446
Author jmarc...@apple.com
Date 2018-01-23 14:30:13 -0800 (Tue, 23 Jan 2018)


Log Message
Cherry-pick r227429. rdar://problem/36791608

Modified Paths

branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm




Diff

Modified: branches/safari-605-branch/Source/WebKit/ChangeLog (227445 => 227446)

--- branches/safari-605-branch/Source/WebKit/ChangeLog	2018-01-23 22:30:11 UTC (rev 227445)
+++ branches/safari-605-branch/Source/WebKit/ChangeLog	2018-01-23 22:30:13 UTC (rev 227446)
@@ -1,5 +1,23 @@
 2018-01-23  Jason Marcell  
 
+Cherry-pick r227429. rdar://problem/36791608
+
+2018-01-23  Joseph Pecoraro  
+
+Web Inspector: Window resizing is broken after detaching to separate window
+https://bugs.webkit.org/show_bug.cgi?id=181992
+
+
+Reviewed by Brian Burg.
+
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(WebKit::WebInspectorProxy::platformDetach):
+Restore the inspector view's autoresizingMask to the initial value
+that works with a detached window. This gets changed when the view
+gets attached to bottom/side, so we need to revert it on detaching.
+
+2018-01-23  Jason Marcell  
+
 Cherry-pick r227419. rdar://problem/36791643
 
 2018-01-23  Youenn Fablet  


Modified: branches/safari-605-branch/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm (227445 => 227446)

--- branches/safari-605-branch/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm	2018-01-23 22:30:11 UTC (rev 227445)
+++ branches/safari-605-branch/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm	2018-01-23 22:30:13 UTC (rev 227446)
@@ -606,6 +606,8 @@
 
 [inspectorView removeFromSuperview];
 
+[inspectorView setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
+
 // Make sure that we size the inspected view's frame after detaching so that it takes up the space that the
 // attached inspector used to. Preserve the top position of the inspected view so banners in Safari still work.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227448] branches/safari-605-branch/Source/JavaScriptCore

[jmarcell]

Title: [227448] branches/safari-605-branch/Source/_javascript_Core








Revision 227448
Author jmarc...@apple.com
Date 2018-01-23 14:30:19 -0800 (Tue, 23 Jan 2018)


Log Message
Cherry-pick r227434. rdar://problem/36791632

Modified Paths

branches/safari-605-branch/Source/_javascript_Core/ChangeLog
branches/safari-605-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
branches/safari-605-branch/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
branches/safari-605-branch/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
branches/safari-605-branch/Source/_javascript_Core/ftl/FTLOSRExit.cpp
branches/safari-605-branch/Source/_javascript_Core/llint/LowLevelInterpreter.asm
branches/safari-605-branch/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
branches/safari-605-branch/Source/_javascript_Core/runtime/JSGlobalObject.cpp
branches/safari-605-branch/Source/_javascript_Core/runtime/JSType.h
branches/safari-605-branch/Source/_javascript_Core/runtime/TypedArrayType.cpp
branches/safari-605-branch/Source/_javascript_Core/runtime/TypedArrayType.h




Diff

Modified: branches/safari-605-branch/Source/_javascript_Core/ChangeLog (227447 => 227448)

--- branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-23 22:30:15 UTC (rev 227447)
+++ branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-23 22:30:19 UTC (rev 227448)
@@ -1,5 +1,67 @@
 2018-01-23  Jason Marcell  
 
+Cherry-pick r227434. rdar://problem/36791632
+
+2018-01-23  Mark Lam  
+
+Re-arrange TypedArray JSTypes to match the order of the TypedArrayType enum list.
+https://bugs.webkit.org/show_bug.cgi?id=181976
+
+
+Reviewed by Filip Pizlo.
+
+1. The order of TypedArray JSTypes now matches the order the TypedArrayType enum
+   list.  I also added static asserts in TypedArrayType.h to enforce this.
+
+   Also redefined FOR_EACH_TYPED_ARRAY_TYPE() in terms of
+
+2. Define 4 new values:
+   a. FirstTypedArrayType
+   b. LastTypedArrayType
+   c. NumberOfTypedArrayTypesExcludingDataView
+   d. NumberOfTypedArrayTypes
+
+   Use these everywhere where we iterate or bisect the TypedArray JSTypes.
+
+3. Removed NUMBER_OF_TYPED_ARRAY_TYPES, and use NumberOfTypedArrayTypes instead.
+
+4. Simplify the code that converts between TypedArrayType and JSType.
+
+   Changed typedArrayTypeForType() to be the mirror image of typeForTypedArrayType().
+   Previously, typedArrayTypeForType() converts DataViewType to NotTypedArray
+   instead of TypeDataView.  Now, it converts to TypeDataView.
+
+   This does not result in any change of behavior because typedArrayTypeForType()
+   is only called in Structure::hasIndexingHeader(), and its result is passed to
+   isTypedView(), which handles TypeDataView correctly.
+
+5. Also fixed a bug in SpeculativeJIT::compileGetTypedArrayByteOffset().
+   If the vector is null, we can skip the rest of the checks.  While the current
+   code does not result in incorrect behavior, it is inefficient, and communicates
+   wrong information to the reader i.e. implying that there's something in the
+   dataGPR when there's not.  The dataGPR should also be null in this case.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileIsTypedArrayView):
+(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::isTypedArrayView):
+* ftl/FTLOSRExit.cpp:
+* llint/LowLevelInterpreter.asm:
+* llint/LowLevelInterpreter64.asm:
+* runtime/JSGlobalObject.cpp:
+(JSC::JSGlobalObject::visitChildren):
+* runtime/JSType.h:
+* runtime/TypedArrayType.cpp:
+(JSC::typeForTypedArrayType): Deleted.
+* runtime/TypedArrayType.h:
+(JSC::typedArrayTypeForType):
+(JSC::typeForTypedArrayType):
+
+2018-01-23  Jason Marcell  
+
 Cherry-pick r227431. rdar://problem/36791656
 
 2018-01-23  Filip Pizlo  


Modified: branches/safari-605-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (227447 => 227448)

--- branches/safari-605-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-23 22:30:15 UTC (rev 227447)
+++ branches/safari-605-branch/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-23 22:30:19 UTC (rev 227448)
@@ -3429,7 +3429,7 @@
 return true;
 }
 
-for (unsigned typeIndex = 0; typeIndex < NUMBER_OF_TYPED_ARRAY_TYPES; ++typeIndex) {
+for (unsigned typeIndex = 0; typeIndex < NumberOfTypedArray

[webkit-changes] [227444] branches/safari-605-branch/Source/WebKit

[jmarcell]

Title: [227444] branches/safari-605-branch/Source/WebKit








Revision 227444
Author jmarc...@apple.com
Date 2018-01-23 14:30:08 -0800 (Tue, 23 Jan 2018)


Log Message
Cherry-pick r227419. rdar://problem/36791643

Modified Paths

branches/safari-605-branch/Source/WebKit/ChangeLog
branches/safari-605-branch/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp




Diff

Modified: branches/safari-605-branch/Source/WebKit/ChangeLog (227443 => 227444)

--- branches/safari-605-branch/Source/WebKit/ChangeLog	2018-01-23 22:14:41 UTC (rev 227443)
+++ branches/safari-605-branch/Source/WebKit/ChangeLog	2018-01-23 22:30:08 UTC (rev 227444)
@@ -1,3 +1,22 @@
+2018-01-23  Jason Marcell  
+
+Cherry-pick r227419. rdar://problem/36791643
+
+2018-01-23  Youenn Fablet  
+
+REGRESSION (r227348): ASSERT_NOT_REACHED in WebKit::ServiceWorkerClientFetch::didFinish()
+https://bugs.webkit.org/show_bug.cgi?id=181956
+
+
+Reviewed by Chris Dumez.
+
+Covered by test no longer crashing in Debug builds.
+Reset m_redirectionStatus to None when starting an SW fetch.
+
+* WebProcess/Storage/ServiceWorkerClientFetch.cpp:
+(WebKit::ServiceWorkerClientFetch::start):
+(WebKit::ServiceWorkerClientFetch::didFinish):
+
 2018-01-22  Jason Marcell  
 
 Cherry-pick r227358. rdar://problem/36763023


Modified: branches/safari-605-branch/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp (227443 => 227444)

--- branches/safari-605-branch/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp	2018-01-23 22:14:41 UTC (rev 227443)
+++ branches/safari-605-branch/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp	2018-01-23 22:30:08 UTC (rev 227444)
@@ -73,6 +73,8 @@
 
 ASSERT(options.serviceWorkersMode != ServiceWorkersMode::None);
 m_connection->startFetch(m_loader->identifier(), options.serviceWorkerRegistrationIdentifier.value(), request, options, referrer);
+
+m_redirectionStatus = RedirectionStatus::None;
 }
 
 // https://fetch.spec.whatwg.org/#http-fetch step 3.3
@@ -158,7 +160,6 @@
 m_redirectionStatus = RedirectionStatus::Received;
 return;
 case RedirectionStatus::Following:
-m_redirectionStatus = RedirectionStatus::None;
 start();
 return;
 case RedirectionStatus::Received:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227445] branches/safari-605-branch/Source

[jmarcell]

Title: [227445] branches/safari-605-branch/Source








Revision 227445
Author jmarc...@apple.com
Date 2018-01-23 14:30:11 -0800 (Tue, 23 Jan 2018)


Log Message
Cherry-pick r227424. rdar://problem/36791625

Modified Paths

branches/safari-605-branch/Source/_javascript_Core/ChangeLog
branches/safari-605-branch/Source/_javascript_Core/runtime/JSLock.cpp
branches/safari-605-branch/Source/WTF/ChangeLog
branches/safari-605-branch/Source/WTF/wtf/Atomics.h




Diff

Modified: branches/safari-605-branch/Source/_javascript_Core/ChangeLog (227444 => 227445)

--- branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-23 22:30:08 UTC (rev 227444)
+++ branches/safari-605-branch/Source/_javascript_Core/ChangeLog	2018-01-23 22:30:11 UTC (rev 227445)
@@ -1,3 +1,23 @@
+2018-01-23  Jason Marcell  
+
+Cherry-pick r227424. rdar://problem/36791625
+
+2018-01-23  Filip Pizlo  
+
+JSC should use a speculation fence on VM entry/exit
+https://bugs.webkit.org/show_bug.cgi?id=181991
+
+Reviewed by JF Bastien and Mark Lam.
+
+This adds a WTF::speculationFence on VM entry and exit.
+
+For a microbenchmark that just calls a native function (supplied via an Objective-C block) in a
+tight loop from JS is a 0% regression on x86 and a 11% regression on ARM64.
+
+* runtime/JSLock.cpp:
+(JSC::JSLock::didAcquireLock):
+(JSC::JSLock::willReleaseLock):
+
 2018-01-22  Jason Marcell  
 
 Cherry-pick r227341. rdar://problem/36746038


Modified: branches/safari-605-branch/Source/_javascript_Core/runtime/JSLock.cpp (227444 => 227445)

--- branches/safari-605-branch/Source/_javascript_Core/runtime/JSLock.cpp	2018-01-23 22:30:08 UTC (rev 227444)
+++ branches/safari-605-branch/Source/_javascript_Core/runtime/JSLock.cpp	2018-01-23 22:30:11 UTC (rev 227445)
@@ -123,6 +123,8 @@
 
 void JSLock::didAcquireLock()
 {
+WTF::speculationFence();
+
 // FIXME: What should happen to the per-thread identifier table if we don't have a VM?
 if (!m_vm)
 return;
@@ -191,6 +193,8 @@
 
 void JSLock::willReleaseLock()
 {
+WTF::speculationFence();
+
 RefPtr vm = m_vm;
 if (vm) {
 vm->drainMicrotasks();


Modified: branches/safari-605-branch/Source/WTF/ChangeLog (227444 => 227445)

--- branches/safari-605-branch/Source/WTF/ChangeLog	2018-01-23 22:30:08 UTC (rev 227444)
+++ branches/safari-605-branch/Source/WTF/ChangeLog	2018-01-23 22:30:11 UTC (rev 227445)
@@ -1,3 +1,21 @@
+2018-01-23  Jason Marcell  
+
+Cherry-pick r227424. rdar://problem/36791625
+
+2018-01-23  Filip Pizlo  
+
+JSC should use a speculation fence on VM entry/exit
+https://bugs.webkit.org/show_bug.cgi?id=181991
+
+Reviewed by JF Bastien and Mark Lam.
+
+Implement speculationFence as lfence on x86 and isb on ARM64. I'm not sure if isb is
+appropriate for all ARM64's.
+
+* wtf/Atomics.h:
+(WTF::speculationFence):
+(WTF::x86_lfence):
+
 2018-01-22  Jason Marcell  
 
 Cherry-pick r227174. rdar://problem/36723030


Modified: branches/safari-605-branch/Source/WTF/wtf/Atomics.h (227444 => 227445)

--- branches/safari-605-branch/Source/WTF/wtf/Atomics.h	2018-01-23 22:30:08 UTC (rev 227444)
+++ branches/safari-605-branch/Source/WTF/wtf/Atomics.h	2018-01-23 22:30:11 UTC (rev 227445)
@@ -276,9 +276,17 @@
 inline void memoryBarrierAfterLock() { arm_dmb(); }
 inline void memoryBarrierBeforeUnlock() { arm_dmb(); }
 inline void crossModifyingCodeFence() { arm_isb(); }
+inline void speculationFence() { arm_isb(); }
 
 #elif CPU(X86) || CPU(X86_64)
 
+inline void x86_lfence()
+{
+#if !OS(WINDOWS)
+asm volatile("lfence" ::: "memory");
+#endif
+}
+
 inline void x86_ortop()
 {
 #if OS(WINDOWS)
@@ -326,6 +334,7 @@
 inline void memoryBarrierAfterLock() { compilerFence(); }
 inline void memoryBarrierBeforeUnlock() { compilerFence(); }
 inline void crossModifyingCodeFence() { x86_cpuid(); }
+inline void speculationFence() { x86_lfence(); }
 
 #else
 
@@ -336,6 +345,7 @@
 inline void memoryBarrierAfterLock() { std::atomic_thread_fence(std::memory_order_seq_cst); }
 inline void memoryBarrierBeforeUnlock() { std::atomic_thread_fence(std::memory_order_seq_cst); }
 inline void crossModifyingCodeFence() { std::atomic_thread_fence(std::memory_order_seq_cst); } // Probably not strong enough.
+inline void speculationFence() { } // Probably not strong enough.
 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227443] trunk/Tools

[commit-queue]

Title: [227443] trunk/Tools








Revision 227443
Author commit-qu...@webkit.org
Date 2018-01-23 14:14:41 -0800 (Tue, 23 Jan 2018)


Log Message
[WinCairo] Use 64-bit toolset
https://bugs.webkit.org/show_bug.cgi?id=181979

Patch by Yoshiaki Jitsukawa  on 2018-01-23
Reviewed by Alex Christensen.

Use 64-bit toolset for 64-bit build in order to improve build time.

* Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (227442 => 227443)

--- trunk/Tools/ChangeLog	2018-01-23 21:42:51 UTC (rev 227442)
+++ trunk/Tools/ChangeLog	2018-01-23 22:14:41 UTC (rev 227443)
@@ -1,3 +1,15 @@
+2018-01-23  Yoshiaki Jitsukawa  
+
+[WinCairo] Use 64-bit toolset
+https://bugs.webkit.org/show_bug.cgi?id=181979
+
+Reviewed by Alex Christensen.
+
+Use 64-bit toolset for 64-bit build in order to improve build time. 
+
+* Scripts/webkitdirs.pm:
+(generateBuildSystemFromCMakeProject):
+
 2018-01-23  Simon Fraser  
 
 Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.


Modified: trunk/Tools/Scripts/webkitdirs.pm (227442 => 227443)

--- trunk/Tools/Scripts/webkitdirs.pm	2018-01-23 21:42:51 UTC (rev 227442)
+++ trunk/Tools/Scripts/webkitdirs.pm	2018-01-23 22:14:41 UTC (rev 227443)
@@ -2140,6 +2140,7 @@
 }
 } elsif (isAnyWindows() && isWin64()) {
 push @args, '-G "Visual Studio 15 2017 Win64"';
+push @args, '-DCMAKE_GENERATOR_TOOLSET="host=x64"';
 }
 # Do not show progress of generating bindings in interactive Ninja build not to leave noisy lines on tty
 push @args, '-DSHOW_BINDINGS_GENERATION_PROGRESS=1' unless ($willUseNinja && -t STDOUT);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227442] trunk/Source

[commit-queue]

Title: [227442] trunk/Source








Revision 227442
Author commit-qu...@webkit.org
Date 2018-01-23 13:42:51 -0800 (Tue, 23 Jan 2018)


Log Message
Unreviewed, rolling out r227437.
https://bugs.webkit.org/show_bug.cgi?id=182011

broke build (Requested by alexchristensen on #webkit).

Reverted changeset:

"Remove unused QTKit preference"
https://bugs.webkit.org/show_bug.cgi?id=181968
https://trac.webkit.org/changeset/227437

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp
trunk/Source/WebCore/page/DeprecatedGlobalSettings.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (227441 => 227442)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 21:40:44 UTC (rev 227441)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 21:42:51 UTC (rev 227442)
@@ -1,3 +1,16 @@
+2018-01-23  Commit Queue  
+
+Unreviewed, rolling out r227437.
+https://bugs.webkit.org/show_bug.cgi?id=182011
+
+broke build (Requested by alexchristensen on #webkit).
+
+Reverted changeset:
+
+"Remove unused QTKit preference"
+https://bugs.webkit.org/show_bug.cgi?id=181968
+https://trac.webkit.org/changeset/227437
+
 2018-01-23  Antoine Quint  
 
 [Web Animations] Expose getKeyframes() and parsing of remaining keyframe properties


Modified: trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp (227441 => 227442)

--- trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp	2018-01-23 21:40:44 UTC (rev 227441)
+++ trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp	2018-01-23 21:42:51 UTC (rev 227442)
@@ -46,6 +46,10 @@
 bool DeprecatedGlobalSettings::gAVFoundationNSURLSessionEnabled = true;
 #endif
 
+#if PLATFORM(COCOA)
+bool DeprecatedGlobalSettings::gQTKitEnabled = false;
+#endif
+
 #if USE(GSTREAMER)
 bool DeprecatedGlobalSettings::gGStreamerEnabled = true;
 #endif
@@ -101,6 +105,17 @@
 }
 #endif
 
+#if PLATFORM(COCOA)
+void DeprecatedGlobalSettings::setQTKitEnabled(bool enabled)
+{
+if (gQTKitEnabled == enabled)
+return;
+
+gQTKitEnabled = enabled;
+HTMLMediaElement::resetMediaEngines();
+}
+#endif
+
 #if USE(GSTREAMER)
 void DeprecatedGlobalSettings::setGStreamerEnabled(bool enabled)
 {


Modified: trunk/Source/WebCore/page/DeprecatedGlobalSettings.h (227441 => 227442)

--- trunk/Source/WebCore/page/DeprecatedGlobalSettings.h	2018-01-23 21:40:44 UTC (rev 227441)
+++ trunk/Source/WebCore/page/DeprecatedGlobalSettings.h	2018-01-23 21:42:51 UTC (rev 227442)
@@ -55,6 +55,13 @@
 static bool isAVFoundationNSURLSessionEnabled() { return gAVFoundationNSURLSessionEnabled; }
 #endif
 
+#if PLATFORM(COCOA)
+WEBCORE_EXPORT static void setQTKitEnabled(bool flag);
+static bool isQTKitEnabled() { return gQTKitEnabled; }
+#else
+static bool isQTKitEnabled() { return false; }
+#endif
+
 #if USE(GSTREAMER)
 WEBCORE_EXPORT static void setGStreamerEnabled(bool flag);
 static bool isGStreamerEnabled() { return gGStreamerEnabled; }
@@ -119,6 +126,10 @@
 WEBCORE_EXPORT static bool gAVFoundationNSURLSessionEnabled;
 #endif
 
+#if PLATFORM(COCOA)
+WEBCORE_EXPORT static bool gQTKitEnabled;
+#endif
+
 #if USE(GSTREAMER)
 WEBCORE_EXPORT static bool gGStreamerEnabled;
 #endif


Modified: trunk/Source/WebKit/ChangeLog (227441 => 227442)

--- trunk/Source/WebKit/ChangeLog	2018-01-23 21:40:44 UTC (rev 227441)
+++ trunk/Source/WebKit/ChangeLog	2018-01-23 21:42:51 UTC (rev 227442)
@@ -1,3 +1,16 @@
+2018-01-23  Commit Queue  
+
+Unreviewed, rolling out r227437.
+https://bugs.webkit.org/show_bug.cgi?id=182011
+
+broke build (Requested by alexchristensen on #webkit).
+
+Reverted changeset:
+
+"Remove unused QTKit preference"
+https://bugs.webkit.org/show_bug.cgi?id=181968
+https://trac.webkit.org/changeset/227437
+
 2018-01-23  Alex Christensen  
 
 Remove compile guard around beacon API


Modified: trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp (227441 => 227442)

--- trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp	2018-01-23 21:40:44 UTC (rev 227441)
+++ trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp	2018-01-23 21:42:51 UTC (rev 227442)
@@ -51,12 +51,3 @@
 void WKContextSetProcessModel(WKContextRef, WKProcessModel)
 {
 }
-
-void WKPreferencesSetQTKitEnabled(WKPreferencesRef, bool)
-{
-}
-
-bool WKPreferencesGetQTKitEnabled(WKPreferencesRef)
-{

[webkit-changes] [227441] trunk/Source/WebCore

[graouts]

Title: [227441] trunk/Source/WebCore








Revision 227441
Author grao...@webkit.org
Date 2018-01-23 13:40:44 -0800 (Tue, 23 Jan 2018)


Log Message
[Web Animations] Expose getKeyframes() and parsing of remaining keyframe properties
https://bugs.webkit.org/show_bug.cgi?id=181978

Not reviewed.

Fix failures for http/wpt/web-animations/interfaces/AnimationEffectTiming/easing.html introduced in the previous patch.
Those keyword values are not expected.

* platform/animation/TimingFunction.cpp:
(WebCore::TimingFunction::cssText const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/animation/TimingFunction.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (227440 => 227441)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 21:39:12 UTC (rev 227440)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 21:40:44 UTC (rev 227441)
@@ -1,3 +1,16 @@
+2018-01-23  Antoine Quint  
+
+[Web Animations] Expose getKeyframes() and parsing of remaining keyframe properties
+https://bugs.webkit.org/show_bug.cgi?id=181978
+
+Not reviewed.
+
+Fix failures for http/wpt/web-animations/interfaces/AnimationEffectTiming/easing.html introduced in the previous patch.
+Those keyword values are not expected.
+
+* platform/animation/TimingFunction.cpp:
+(WebCore::TimingFunction::cssText const):
+
 2018-01-23  Simon Fraser  
 
 feMorphology stops applying if either x or y radius is 0 but should not.


Modified: trunk/Source/WebCore/platform/animation/TimingFunction.cpp (227440 => 227441)

--- trunk/Source/WebCore/platform/animation/TimingFunction.cpp	2018-01-23 21:39:12 UTC (rev 227440)
+++ trunk/Source/WebCore/platform/animation/TimingFunction.cpp	2018-01-23 21:40:44 UTC (rev 227441)
@@ -175,11 +175,8 @@
 
 if (m_type == TimingFunction::StepsFunction) {
 auto& function = downcast(*this);
-auto numberOfSteps = function.numberOfSteps();
-if (numberOfSteps == 1)
-return function.stepAtStart() ? "step-start" : "step-end";
 if (!function.stepAtStart())
-return String::format("steps(%d)", numberOfSteps);
+return String::format("steps(%d)", function.numberOfSteps());
 }
 
 TextStream stream;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227440] trunk

[simon . fraser]

Title: [227440] trunk








Revision 227440
Author simon.fra...@apple.com
Date 2018-01-23 13:39:12 -0800 (Tue, 23 Jan 2018)


Log Message
feMorphology stops applying if either x or y radius is 0 but should not.
https://bugs.webkit.org/show_bug.cgi?id=181903

Reviewed by Dean Jackson.
Source/WebCore:

feMorphology should allow the radius on one axis to be zero but still apply the effect
(it's akin to a blur on just one axis). Also, any negative radius, or zero on both axes
should act like a pass-through, rather than outputting transparent blank (this is a spec
change from SVG 1.1 to SVG 2).

Tests: svg/filters/feMorphology-zero-radius-one-axis-expected.svg
   svg/filters/feMorphology-zero-radius-one-axis.svg

* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::platformApplyDegenerate):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::createImageBufferResult):

LayoutTests:

* svg/filters/feMorphology-zero-radius-one-axis-expected.svg: Added.
* svg/filters/feMorphology-zero-radius-one-axis.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp
trunk/Source/WebCore/platform/graphics/filters/FilterEffect.cpp


Added Paths

trunk/LayoutTests/svg/filters/feMorphology-zero-radius-one-axis-expected.svg
trunk/LayoutTests/svg/filters/feMorphology-zero-radius-one-axis.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (227439 => 227440)

--- trunk/LayoutTests/ChangeLog	2018-01-23 21:33:35 UTC (rev 227439)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 21:39:12 UTC (rev 227440)
@@ -1,3 +1,13 @@
+2018-01-23  Simon Fraser  
+
+feMorphology stops applying if either x or y radius is 0 but should not.
+https://bugs.webkit.org/show_bug.cgi?id=181903
+
+Reviewed by Dean Jackson.
+
+* svg/filters/feMorphology-zero-radius-one-axis-expected.svg: Added.
+* svg/filters/feMorphology-zero-radius-one-axis.svg: Added.
+
 2018-01-23  Javier Fernandez  
 
 [css-align] 'left' and 'right' should parse as invalid in block/cross-axis alignment


Added: trunk/LayoutTests/svg/filters/feMorphology-zero-radius-one-axis-expected.svg (0 => 227440)

--- trunk/LayoutTests/svg/filters/feMorphology-zero-radius-one-axis-expected.svg	(rev 0)
+++ trunk/LayoutTests/svg/filters/feMorphology-zero-radius-one-axis-expected.svg	2018-01-23 21:39:12 UTC (rev 227440)
@@ -0,0 +1,5 @@
+
+
+
+
+


Added: trunk/LayoutTests/svg/filters/feMorphology-zero-radius-one-axis.svg (0 => 227440)

--- trunk/LayoutTests/svg/filters/feMorphology-zero-radius-one-axis.svg	(rev 0)
+++ trunk/LayoutTests/svg/filters/feMorphology-zero-radius-one-axis.svg	2018-01-23 21:39:12 UTC (rev 227440)
@@ -0,0 +1,17 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (227439 => 227440)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 21:33:35 UTC (rev 227439)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 21:39:12 UTC (rev 227440)
@@ -1,3 +1,23 @@
+2018-01-23  Simon Fraser  
+
+feMorphology stops applying if either x or y radius is 0 but should not.
+https://bugs.webkit.org/show_bug.cgi?id=181903
+
+Reviewed by Dean Jackson.
+
+feMorphology should allow the radius on one axis to be zero but still apply the effect
+(it's akin to a blur on just one axis). Also, any negative radius, or zero on both axes
+should act like a pass-through, rather than outputting transparent blank (this is a spec
+change from SVG 1.1 to SVG 2).
+
+Tests: svg/filters/feMorphology-zero-radius-one-axis-expected.svg
+   svg/filters/feMorphology-zero-radius-one-axis.svg
+
+* platform/graphics/filters/FEMorphology.cpp:
+(WebCore::FEMorphology::platformApplyDegenerate):
+* platform/graphics/filters/FilterEffect.cpp:
+(WebCore::FilterEffect::createImageBufferResult):
+
 2018-01-23  Alex Christensen  
 
 Remove unused MediaPlayerSupportsTypeClient


Modified: trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp (227439 => 227440)

--- trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp	2018-01-23 21:33:35 UTC (rev 227439)
+++ trunk/Source/WebCore/platform/graphics/filters/FEMorphology.cpp	2018-01-23 21:39:12 UTC (rev 227440)
@@ -221,15 +221,7 @@
 
 bool FEMorphology::platformApplyDegenerate(Uint8ClampedArray& dstPixelArray, const IntRect& imageRect, int radiusX, int radiusY)
 {
-// Input radius is less than zero or an overflow happens when scaling it.
-if (radiusX < 0 || radiusY < 0) {
-dstPixelArray.zeroFill();
-return true;
-}
-
-// FIXME: this should allow erode/dilate on one axis. webkit.org/b/181903.
-// Also if both x radiusX and radiusY are zero, the result should be transparent black.
-if (!radiusX || !radiusY) {
+if (radiusX < 0 || radiusY < 

[webkit-changes] [227439] trunk/Source/WebCore

[achristensen]

Title: [227439] trunk/Source/WebCore








Revision 227439
Author achristen...@apple.com
Date 2018-01-23 13:33:35 -0800 (Tue, 23 Jan 2018)


Log Message
Remove unused MediaPlayerSupportsTypeClient
https://bugs.webkit.org/show_bug.cgi?id=182003

Reviewed by Sam Weinig.

This was used for a QTKit-specific hack I removed in r227372.

* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::getSupportedCapabilitiesForAudioVideoType):
* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::isTypeSupported):
* dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementationSupportsTypeClient::DOMImplementationSupportsTypeClient): Deleted.
(): Deleted.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType const):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::mediaPlayerNeedsSiteSpecificHacks const): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerDocumentHost const): Deleted.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::supportsType):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerSupportsTypeClient::mediaPlayerNeedsSiteSpecificHacks const): Deleted.
(WebCore::MediaPlayerSupportsTypeClient::mediaPlayerDocumentHost const): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
trunk/Source/WebCore/dom/DOMImplementation.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (227438 => 227439)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 21:32:39 UTC (rev 227438)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 21:33:35 UTC (rev 227439)
@@ -1,5 +1,34 @@
 2018-01-23  Alex Christensen  
 
+Remove unused MediaPlayerSupportsTypeClient
+https://bugs.webkit.org/show_bug.cgi?id=182003
+
+Reviewed by Sam Weinig.
+
+This was used for a QTKit-specific hack I removed in r227372.
+
+* Modules/encryptedmedia/CDM.cpp:
+(WebCore::CDM::getSupportedCapabilitiesForAudioVideoType):
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::isTypeSupported):
+* dom/DOMImplementation.cpp:
+(WebCore::DOMImplementation::createDocument):
+(WebCore::DOMImplementationSupportsTypeClient::DOMImplementationSupportsTypeClient): Deleted.
+(): Deleted.
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::canPlayType const):
+(WebCore::HTMLMediaElement::selectNextSourceChild):
+(WebCore::HTMLMediaElement::mediaPlayerNeedsSiteSpecificHacks const): Deleted.
+(WebCore::HTMLMediaElement::mediaPlayerDocumentHost const): Deleted.
+* html/HTMLMediaElement.h:
+* platform/graphics/MediaPlayer.cpp:
+(WebCore::MediaPlayer::supportsType):
+* platform/graphics/MediaPlayer.h:
+(WebCore::MediaPlayerSupportsTypeClient::mediaPlayerNeedsSiteSpecificHacks const): Deleted.
+(WebCore::MediaPlayerSupportsTypeClient::mediaPlayerDocumentHost const): Deleted.
+
+2018-01-23  Alex Christensen  
+
 Remove unused QTKit preference
 https://bugs.webkit.org/show_bug.cgi?id=181968
 


Modified: trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp (227438 => 227439)

--- trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp	2018-01-23 21:32:39 UTC (rev 227438)
+++ trunk/Source/WebCore/Modules/encryptedmedia/CDM.cpp	2018-01-23 21:33:35 UTC (rev 227439)
@@ -468,10 +468,10 @@
 //   with restrictions:
 MediaEngineSupportParameters parameters;
 parameters.type = ContentType(contentType.mimeType());
-if (!MediaPlayer::supportsType(parameters, nullptr)) {
+if (!MediaPlayer::supportsType(parameters)) {
 // Try with Media Source:
 parameters.isMediaSource = true;
-if (!MediaPlayer::supportsType(parameters, nullptr))
+if (!MediaPlayer::supportsType(parameters))
 continue;
 }
 


Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (227438 => 227439)

--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp	2018-01-23 21:32:39 UTC (rev 227438)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp	2018-01-23 21:33:35 UTC (rev 227439)
@@ -850,7 +850,7 @@
 MediaEngineSupportParameters parameters;
 parameters.type = contentType;
 parameters.isMediaSource = true;
-MediaPlayer::SupportsType supported = MediaPlayer::supportsType(parameters, 0);
+MediaPlayer::SupportsType supported = MediaPlayer::supportsType(parameters);
 
 if (codecs.isEmpty())
 return supported != MediaPlayer::IsNotSupported;


Modified: trunk/Source/WebCore/dom/DOMImplementation.cpp (227438 => 227439)

--- trunk/Source

[webkit-changes] [227438] trunk/Source/WebKit

[achristensen]

Title: [227438] trunk/Source/WebKit








Revision 227438
Author achristen...@apple.com
Date 2018-01-23 13:32:39 -0800 (Tue, 23 Jan 2018)


Log Message
Remove compile guard around beacon API
https://bugs.webkit.org/show_bug.cgi?id=182002

Reviewed by Sam Weinig.

It's enabled everywhere now.

* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBeaconAPIEnabled):
(WKPreferencesGetBeaconAPIEnabled):
* config.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/config.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (227437 => 227438)

--- trunk/Source/WebKit/ChangeLog	2018-01-23 21:06:39 UTC (rev 227437)
+++ trunk/Source/WebKit/ChangeLog	2018-01-23 21:32:39 UTC (rev 227438)
@@ -1,5 +1,20 @@
 2018-01-23  Alex Christensen  
 
+Remove compile guard around beacon API
+https://bugs.webkit.org/show_bug.cgi?id=182002
+
+Reviewed by Sam Weinig.
+
+It's enabled everywhere now.
+
+* Shared/WebPreferences.yaml:
+* UIProcess/API/C/WKPreferences.cpp:
+(WKPreferencesSetBeaconAPIEnabled):
+(WKPreferencesGetBeaconAPIEnabled):
+* config.h:
+
+2018-01-23  Alex Christensen  
+
 Remove unused QTKit preference
 https://bugs.webkit.org/show_bug.cgi?id=181968
 


Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (227437 => 227438)

--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2018-01-23 21:06:39 UTC (rev 227437)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2018-01-23 21:32:39 UTC (rev 227438)
@@ -733,7 +733,6 @@
   defaultValue: true
   humanReadableName: "Beacon API"
   humanReadableDescription: "Beacon API"
-  condition: ENABLE(BEACON_API)
 
 LegacyEncryptedMediaAPIEnabled:
   type: bool


Modified: trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp (227437 => 227438)

--- trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp	2018-01-23 21:06:39 UTC (rev 227437)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp	2018-01-23 21:32:39 UTC (rev 227438)
@@ -826,18 +826,12 @@
 
 void WKPreferencesSetBeaconAPIEnabled(WKPreferencesRef preferencesRef, bool flag)
 {
-#if ENABLE(BEACON_API)
 toImpl(preferencesRef)->setBeaconAPIEnabled(flag);
-#endif
 }
 
 bool WKPreferencesGetBeaconAPIEnabled(WKPreferencesRef preferencesRef)
 {
-#if ENABLE(BEACON_API)
 return toImpl(preferencesRef)->beaconAPIEnabled();
-#else
-return false;
-#endif
 }
 
 void WKPreferencesSetDirectoryUploadEnabled(WKPreferencesRef preferencesRef, bool flag)


Modified: trunk/Source/WebKit/config.h (227437 => 227438)

--- trunk/Source/WebKit/config.h	2018-01-23 21:06:39 UTC (rev 227437)
+++ trunk/Source/WebKit/config.h	2018-01-23 21:32:39 UTC (rev 227438)
@@ -78,16 +78,10 @@
 #endif
 #endif
 
-#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || PLATFORM(IOS) || PLATFORM(APPLETV) || PLATFORM(WATCHOS) || USE(SOUP)
-#ifndef ENABLE_BEACON_API
-#define ENABLE_BEACON_API 1
-#endif
-
-// FIXME: We should work towards not using CredentialStorage in WebKit2 to not have problems with digest authentication.
+// FIXME: We should work towards not using CredentialStorage in WebKit to not have problems with digest authentication.
 #ifndef USE_CREDENTIAL_STORAGE_WITH_NETWORK_SESSION
 #define USE_CREDENTIAL_STORAGE_WITH_NETWORK_SESSION 1
 #endif
-#endif
 
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11)
 #ifndef ENABLE_SERVER_PRECONNECT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227437] trunk/Source

[achristensen]

Title: [227437] trunk/Source








Revision 227437
Author achristen...@apple.com
Date 2018-01-23 13:06:39 -0800 (Tue, 23 Jan 2018)


Log Message
Remove unused QTKit preference
https://bugs.webkit.org/show_bug.cgi?id=181968

Reviewed by Alexey Proskuryakov.

Source/WebCore:

They weren't used and didn't do anything.

* page/DeprecatedGlobalSettings.cpp:
(WebCore::DeprecatedGlobalSettings::setQTKitEnabled): Deleted.
* page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::isQTKitEnabled): Deleted.

Source/WebKit:

* Shared/API/c/WKDeprecatedFunctions.cpp:
(WKPreferencesSetQTKitEnabled):
(WKPreferencesGetQTKitEnabled):
* Shared/WebPreferences.yaml:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetQTKitEnabled): Deleted.
(WKPreferencesGetQTKitEnabled): Deleted.
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setQTKitEnabled:]): Deleted.
(-[WKPreferences _qtKitEnabled]): Deleted.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setQTKitEnabled:]): Deleted.
(-[WebPreferences isQTKitEnabled]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp
trunk/Source/WebCore/page/DeprecatedGlobalSettings.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/c/WKDeprecatedFunctions.cpp
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (227436 => 227437)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 21:06:39 UTC (rev 227437)
@@ -1,3 +1,17 @@
+2018-01-23  Alex Christensen  
+
+Remove unused QTKit preference
+https://bugs.webkit.org/show_bug.cgi?id=181968
+
+Reviewed by Alexey Proskuryakov.
+
+They weren't used and didn't do anything.
+
+* page/DeprecatedGlobalSettings.cpp:
+(WebCore::DeprecatedGlobalSettings::setQTKitEnabled): Deleted.
+* page/DeprecatedGlobalSettings.h:
+(WebCore::DeprecatedGlobalSettings::isQTKitEnabled): Deleted.
+
 2018-01-23  Javier Fernandez  
 
 [css-align] 'left' and 'right' should parse as invalid in block/cross-axis alignment


Modified: trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp (227436 => 227437)

--- trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp	2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebCore/page/DeprecatedGlobalSettings.cpp	2018-01-23 21:06:39 UTC (rev 227437)
@@ -46,10 +46,6 @@
 bool DeprecatedGlobalSettings::gAVFoundationNSURLSessionEnabled = true;
 #endif
 
-#if PLATFORM(COCOA)
-bool DeprecatedGlobalSettings::gQTKitEnabled = false;
-#endif
-
 #if USE(GSTREAMER)
 bool DeprecatedGlobalSettings::gGStreamerEnabled = true;
 #endif
@@ -105,17 +101,6 @@
 }
 #endif
 
-#if PLATFORM(COCOA)
-void DeprecatedGlobalSettings::setQTKitEnabled(bool enabled)
-{
-if (gQTKitEnabled == enabled)
-return;
-
-gQTKitEnabled = enabled;
-HTMLMediaElement::resetMediaEngines();
-}
-#endif
-
 #if USE(GSTREAMER)
 void DeprecatedGlobalSettings::setGStreamerEnabled(bool enabled)
 {


Modified: trunk/Source/WebCore/page/DeprecatedGlobalSettings.h (227436 => 227437)

--- trunk/Source/WebCore/page/DeprecatedGlobalSettings.h	2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebCore/page/DeprecatedGlobalSettings.h	2018-01-23 21:06:39 UTC (rev 227437)
@@ -55,13 +55,6 @@
 static bool isAVFoundationNSURLSessionEnabled() { return gAVFoundationNSURLSessionEnabled; }
 #endif
 
-#if PLATFORM(COCOA)
-WEBCORE_EXPORT static void setQTKitEnabled(bool flag);
-static bool isQTKitEnabled() { return gQTKitEnabled; }
-#else
-static bool isQTKitEnabled() { return false; }
-#endif
-
 #if USE(GSTREAMER)
 WEBCORE_EXPORT static void setGStreamerEnabled(bool flag);
 static bool isGStreamerEnabled() { return gGStreamerEnabled; }
@@ -126,10 +119,6 @@
 WEBCORE_EXPORT static bool gAVFoundationNSURLSessionEnabled;
 #endif
 
-#if PLATFORM(COCOA)
-WEBCORE_EXPORT static bool gQTKitEnabled;
-#endif
-
 #if USE(GSTREAMER)
 WEBCORE_EXPORT static bool gGStreamerEnabled;
 #endif


Modified: trunk/Source/WebKit/ChangeLog (227436 => 227437)

--- trunk/Source/WebKit/ChangeLog	2018-01-23 20:50:50 UTC (rev 227436)
+++ trunk/Source/WebKit/ChangeLog	2018-01-23 21:06:39 UTC (rev 227437)
@@ -1,3 +1,22 @@
+2018-01-23  Alex Chri

[webkit-changes] [227435] trunk/Source/JavaScriptCore

[rmorisset]

Title: [227435] trunk/Source/_javascript_Core








Revision 227435
Author rmoris...@apple.com
Date 2018-01-23 12:49:26 -0800 (Tue, 23 Jan 2018)


Log Message
Rollout r219636
https://bugs.webkit.org/show_bug.cgi?id=181997


Unreviewed, as it is a rollout.


* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
* runtime/JSArray.cpp:
(JSC::JSArray::tryCreateUninitializedRestricted):
* runtime/JSArray.h:
(JSC::JSArray::tryCreate):
* runtime/JSObject.cpp:
(JSC::JSObject::ensureLengthSlow):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/runtime/JSArray.cpp
trunk/Source/_javascript_Core/runtime/JSArray.h
trunk/Source/_javascript_Core/runtime/JSObject.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227434 => 227435)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-23 20:39:34 UTC (rev 227434)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-23 20:49:26 UTC (rev 227435)
@@ -1,3 +1,20 @@
+2018-01-23  Robin Morisset  
+
+Rollout r219636
+https://bugs.webkit.org/show_bug.cgi?id=181997
+
+
+Unreviewed, as it is a rollout.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
+* runtime/JSArray.cpp:
+(JSC::JSArray::tryCreateUninitializedRestricted):
+* runtime/JSArray.h:
+(JSC::JSArray::tryCreate):
+* runtime/JSObject.cpp:
+(JSC::JSObject::ensureLengthSlow):
+
 2018-01-23  Mark Lam  
 
 Re-arrange TypedArray JSTypes to match the order of the TypedArrayType enum list.


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (227434 => 227435)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-01-23 20:39:34 UTC (rev 227434)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-01-23 20:49:26 UTC (rev 227435)
@@ -144,7 +144,7 @@
 slowCases, this, operationNewRawObject, resultGPR, storageGPR,
 structure, vectorLength));
 
-if (numElements < vectorLength && LIKELY(!hasUndecided(structure->indexingType( {
+if (numElements < vectorLength) {
 #if USE(JSVALUE64)
 if (hasDouble(structure->indexingType()))
 m_jit.move(TrustedImm64(bitwise_cast(PNaN)), scratchGPR);


Modified: trunk/Source/_javascript_Core/runtime/JSArray.cpp (227434 => 227435)

--- trunk/Source/_javascript_Core/runtime/JSArray.cpp	2018-01-23 20:39:34 UTC (rev 227434)
+++ trunk/Source/_javascript_Core/runtime/JSArray.cpp	2018-01-23 20:49:26 UTC (rev 227435)
@@ -91,7 +91,7 @@
 if (hasDouble(indexingType)) {
 for (; i < vectorLength; ++i)
 butterfly->contiguousDouble().at(std::numeric_limits::max(), i) = PNaN;
-} else if (LIKELY(!hasUndecided(indexingType))) {
+} else {
 for (; i < vectorLength; ++i)
 butterfly->contiguous().at(std::numeric_limits::max(), i).clear();
 }


Modified: trunk/Source/_javascript_Core/runtime/JSArray.h (227434 => 227435)

--- trunk/Source/_javascript_Core/runtime/JSArray.h	2018-01-23 20:39:34 UTC (rev 227434)
+++ trunk/Source/_javascript_Core/runtime/JSArray.h	2018-01-23 20:49:26 UTC (rev 227435)
@@ -247,7 +247,7 @@
 butterfly->setPublicLength(initialLength);
 if (hasDouble(indexingType))
 clearArray(butterfly->contiguousDouble().data(), vectorLength);
-else if (LIKELY(!hasUndecided(indexingType)))
+else
 clearArray(butterfly->contiguous().data(), vectorLength);
 } else {
 ASSERT(


Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (227434 => 227435)

--- trunk/Source/_javascript_Core/runtime/JSObject.cpp	2018-01-23 20:39:34 UTC (rev 227434)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp	2018-01-23 20:49:26 UTC (rev 227435)
@@ -3222,7 +3222,7 @@
 if (hasDouble(indexingType())) {
 for (unsigned i = oldVectorLength; i < newVectorLength; ++i)
 butterfly->indexingPayload()[i] = PNaN;
-} else if (LIKELY(!hasUndecided(indexingType( {
+} else {
 for (unsigned i = oldVectorLength; i < newVectorLength; ++i)
 butterfly->indexingPayload>()[i].clear();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227434] trunk/Source/JavaScriptCore

[mark . lam]

Title: [227434] trunk/Source/_javascript_Core








Revision 227434
Author mark@apple.com
Date 2018-01-23 12:39:34 -0800 (Tue, 23 Jan 2018)


Log Message
Re-arrange TypedArray JSTypes to match the order of the TypedArrayType enum list.
https://bugs.webkit.org/show_bug.cgi?id=181976


Reviewed by Filip Pizlo.

1. The order of TypedArray JSTypes now matches the order the TypedArrayType enum
   list.  I also added static asserts in TypedArrayType.h to enforce this.

   Also redefined FOR_EACH_TYPED_ARRAY_TYPE() in terms of

2. Define 4 new values:
   a. FirstTypedArrayType
   b. LastTypedArrayType
   c. NumberOfTypedArrayTypesExcludingDataView
   d. NumberOfTypedArrayTypes

   Use these everywhere where we iterate or bisect the TypedArray JSTypes.

3. Removed NUMBER_OF_TYPED_ARRAY_TYPES, and use NumberOfTypedArrayTypes instead.

4. Simplify the code that converts between TypedArrayType and JSType.

   Changed typedArrayTypeForType() to be the mirror image of typeForTypedArrayType().
   Previously, typedArrayTypeForType() converts DataViewType to NotTypedArray
   instead of TypeDataView.  Now, it converts to TypeDataView.

   This does not result in any change of behavior because typedArrayTypeForType()
   is only called in Structure::hasIndexingHeader(), and its result is passed to
   isTypedView(), which handles TypeDataView correctly.

5. Also fixed a bug in SpeculativeJIT::compileGetTypedArrayByteOffset().
   If the vector is null, we can skip the rest of the checks.  While the current
   code does not result in incorrect behavior, it is inefficient, and communicates
   wrong information to the reader i.e. implying that there's something in the
   dataGPR when there's not.  The dataGPR should also be null in this case.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIsTypedArrayView):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::isTypedArrayView):
* ftl/FTLOSRExit.cpp:
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildren):
* runtime/JSType.h:
* runtime/TypedArrayType.cpp:
(JSC::typeForTypedArrayType): Deleted.
* runtime/TypedArrayType.h:
(JSC::typedArrayTypeForType):
(JSC::typeForTypedArrayType):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/ftl/FTLOSRExit.cpp
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
trunk/Source/_javascript_Core/runtime/JSType.h
trunk/Source/_javascript_Core/runtime/TypedArrayType.cpp
trunk/Source/_javascript_Core/runtime/TypedArrayType.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227433 => 227434)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-23 20:32:18 UTC (rev 227433)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-23 20:39:34 UTC (rev 227434)
@@ -1,3 +1,61 @@
+2018-01-23  Mark Lam  
+
+Re-arrange TypedArray JSTypes to match the order of the TypedArrayType enum list.
+https://bugs.webkit.org/show_bug.cgi?id=181976
+
+
+Reviewed by Filip Pizlo.
+
+1. The order of TypedArray JSTypes now matches the order the TypedArrayType enum
+   list.  I also added static asserts in TypedArrayType.h to enforce this.
+
+   Also redefined FOR_EACH_TYPED_ARRAY_TYPE() in terms of
+
+2. Define 4 new values:
+   a. FirstTypedArrayType
+   b. LastTypedArrayType
+   c. NumberOfTypedArrayTypesExcludingDataView
+   d. NumberOfTypedArrayTypes
+
+   Use these everywhere where we iterate or bisect the TypedArray JSTypes.
+
+3. Removed NUMBER_OF_TYPED_ARRAY_TYPES, and use NumberOfTypedArrayTypes instead.
+
+4. Simplify the code that converts between TypedArrayType and JSType.
+
+   Changed typedArrayTypeForType() to be the mirror image of typeForTypedArrayType().
+   Previously, typedArrayTypeForType() converts DataViewType to NotTypedArray
+   instead of TypeDataView.  Now, it converts to TypeDataView.
+
+   This does not result in any change of behavior because typedArrayTypeForType()
+   is only called in Structure::hasIndexingHeader(), and its result is passed to
+   isTypedView(), which handles TypeDataView correctly.
+
+5. Also fixed a bug in SpeculativeJIT::compileGetTypedArrayByteOffset().
+   If the vector is null, we can skip the rest of the checks.  While the current
+   code does not result in incorrect behavior, it is inefficient, and communicates
+   wrong information to the rea

[webkit-changes] [227433] trunk/Source/WebKit

[mitz]

Title: [227433] trunk/Source/WebKit








Revision 227433
Author m...@apple.com
Date 2018-01-23 12:32:18 -0800 (Tue, 23 Jan 2018)


Log Message
[Cocoa] Disable header postprocessing when building for macOS High Sierra
https://bugs.webkit.org/show_bug.cgi?id=181972

Reviewed by Anders Carlsson.

* Configurations/WebKit.xcconfig: Adopt macOSTargetConditionals.xcconfig helpers and disable postprocessing
  when building for macOS 10.13.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig




Diff

Modified: trunk/Source/WebKit/ChangeLog (227432 => 227433)

--- trunk/Source/WebKit/ChangeLog	2018-01-23 20:30:21 UTC (rev 227432)
+++ trunk/Source/WebKit/ChangeLog	2018-01-23 20:32:18 UTC (rev 227433)
@@ -1,3 +1,13 @@
+2018-01-23  Dan Bernstein  
+
+[Cocoa] Disable header postprocessing when building for macOS High Sierra
+https://bugs.webkit.org/show_bug.cgi?id=181972
+
+Reviewed by Anders Carlsson.
+
+* Configurations/WebKit.xcconfig: Adopt macOSTargetConditionals.xcconfig helpers and disable postprocessing
+  when building for macOS 10.13.
+
 2018-01-23  Joseph Pecoraro  
 
 Web Inspector: Window resizing is broken after detaching to separate window


Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (227432 => 227433)

--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2018-01-23 20:30:21 UTC (rev 227432)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2018-01-23 20:32:18 UTC (rev 227433)
@@ -75,9 +75,8 @@
 
 INSTALLHDRS_SCRIPT_PHASE = YES;
 
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=macosx*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_macosx_$(TARGET_MAC_OS_X_VERSION_MAJOR));
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_macosx_101100 = YES;
-WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_macosx_101200 = YES;
+WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=macosx*] = $(WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED$(WK_MACOS_1014));
+WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED_MACOS_BEFORE_1014 = YES;
 WK_FRAMEWORK_HEADER_POSTPROCESSING_DISABLED[sdk=iphone*11.0*] = YES;
 
 WK_RELOCATABLE_FRAMEWORK_LDFLAGS = $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS_$(WK_RELOCATABLE_FRAMEWORKS));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227431] trunk/Source/JavaScriptCore

[fpizlo]

Title: [227431] trunk/Source/_javascript_Core








Revision 227431
Author fpi...@apple.com
Date 2018-01-23 12:16:56 -0800 (Tue, 23 Jan 2018)


Log Message
DFG should always flush `this`
https://bugs.webkit.org/show_bug.cgi?id=181999

Reviewed by Saam Barati and Mark Lam.

This is going to make it possible to use precise index masking for arguments-on-the-stack
accesses with an index adjusted so that 0 is this. Without this change, we would have no way
of masking when the argument count is 0, unless we padded the argument area so that there was
always an argument slot after `this` and it was always initialized.

This is neutral on all benchmarks.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushImpl):
(JSC::DFG::ByteCodeParser::flushForTerminalImpl):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushForTerminal):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::flushImpl): Deleted.
(JSC::DFG::flushForTerminalImpl): Deleted.
* dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGPreciseLocalClobberize.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227430 => 227431)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-23 20:11:10 UTC (rev 227430)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-23 20:16:56 UTC (rev 227431)
@@ -1,5 +1,30 @@
 2018-01-23  Filip Pizlo  
 
+DFG should always flush `this`
+https://bugs.webkit.org/show_bug.cgi?id=181999
+
+Reviewed by Saam Barati and Mark Lam.
+
+This is going to make it possible to use precise index masking for arguments-on-the-stack
+accesses with an index adjusted so that 0 is this. Without this change, we would have no way
+of masking when the argument count is 0, unless we padded the argument area so that there was
+always an argument slot after `this` and it was always initialized.
+
+This is neutral on all benchmarks.
+
+* dfg/DFGByteCodeParser.cpp:
+(JSC::DFG::ByteCodeParser::flushImpl):
+(JSC::DFG::ByteCodeParser::flushForTerminalImpl):
+(JSC::DFG::ByteCodeParser::flush):
+(JSC::DFG::ByteCodeParser::flushForTerminal):
+(JSC::DFG::ByteCodeParser::parse):
+(JSC::DFG::flushImpl): Deleted.
+(JSC::DFG::flushForTerminalImpl): Deleted.
+* dfg/DFGPreciseLocalClobberize.h:
+(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
+
+2018-01-23  Filip Pizlo  
+
 JSC should use a speculation fence on VM entry/exit
 https://bugs.webkit.org/show_bug.cgi?id=181991
 


Modified: trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp (227430 => 227431)

--- trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-23 20:11:10 UTC (rev 227430)
+++ trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp	2018-01-23 20:16:56 UTC (rev 227431)
@@ -82,51 +82,6 @@
 dataLog(__VA_ARGS__); \
 } while (false)
 
-template 
-static ALWAYS_INLINE void flushImpl(Graph& graph, InlineCallFrame* inlineCallFrame, const F1& addFlushDirect, const F2& addPhantomLocalDirect)
-{
-int numArguments;
-if (inlineCallFrame) {
-ASSERT(!graph.hasDebuggerEnabled());
-numArguments = inlineCallFrame->argumentsWithFixup.size();
-if (inlineCallFrame->isClosureCall)
-addFlushDirect(remapOperand(inlineCallFrame, VirtualRegister(CallFrameSlot::callee)));
-if (inlineCallFrame->isVarargs())
-addFlushDirect(remapOperand(inlineCallFrame, VirtualRegister(CallFrameSlot::argumentCount)));
-} else
-numArguments = graph.baselineCodeBlockFor(inlineCallFrame)->numParameters();
-
-for (unsigned argument = numArguments; argument-- > 1;)
-addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(argument)));
-
-if (!inlineCallFrame && graph.needsFlushedThis())
-addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(0)));
-else
-addPhantomLocalDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(0)));
-
-if (graph.needsScopeRegister())
-addFlushDirect(graph.m_codeBlock->scopeRegister());
-}
-
-template 
-static ALWAYS_INLINE void flushForTerminalImpl(Graph& graph, CodeOrigin origin, const F1& addFlushDirect, const F2& addPhantomLocalDirect)
-{
-origin.walkUpInlineStack([&] (CodeOrigin origin) {
-unsigned bytecodeIndex = origin.bytecodeIndex;
-InlineCallFrame* inlineCallFrame = origin.inlineCallFrame;
-flushImpl(graph, inlineCallFrame, addFlushDirect, addPhantomLocalDirect);
-
-CodeBlock* codeBlock = graph.baselineCodeBlockFor(inlineCallFrame);
-FullBytecodeLiveness& fullLiveness = graph.livenessFor(codeBlock);
-const FastBitVector& livenessAtBytecode = fullLiveness.getLiveness(bytecodeIndex);
-
-

[webkit-changes] [227430] trunk

[simon . fraser]

Title: [227430] trunk








Revision 227430
Author simon.fra...@apple.com
Date 2018-01-23 12:11:10 -0800 (Tue, 23 Jan 2018)


Log Message
Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
https://bugs.webkit.org/show_bug.cgi?id=181741
rdar://problem/36593581

Reviewed by Tim Horton.
Source/WebCore:

The #ifdef for iOS was wrong; on iOS, visibleSize() is in content coordinates and matches
unscaledDocumentRect, so there's no need to scale it. Doing so computed the wrong unscaledMaximumScrollPosition
which broke hit-testing when the document minimum scale was > 1.

Test: fast/visual-viewport/ios/min-scale-greater-than-one.html

* page/FrameView.cpp:
(WebCore::FrameView::unscaledMaximumScrollPosition const):

Tools:

If zoomToScale:animated: is called with the current zoom level, call the callback
rather than doing nothing.

* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):

LayoutTests:

* fast/visual-viewport/ios/min-scale-greater-than-one-expected.txt: Added.
* fast/visual-viewport/ios/min-scale-greater-than-one.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm


Added Paths

trunk/LayoutTests/fast/visual-viewport/ios/min-scale-greater-than-one-expected.txt
trunk/LayoutTests/fast/visual-viewport/ios/min-scale-greater-than-one.html




Diff

Modified: trunk/LayoutTests/ChangeLog (227429 => 227430)

--- trunk/LayoutTests/ChangeLog	2018-01-23 20:08:36 UTC (rev 227429)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 20:11:10 UTC (rev 227430)
@@ -1,3 +1,14 @@
+2018-01-23  Simon Fraser  
+
+Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
+https://bugs.webkit.org/show_bug.cgi?id=181741
+rdar://problem/36593581
+
+Reviewed by Tim Horton.
+
+* fast/visual-viewport/ios/min-scale-greater-than-one-expected.txt: Added.
+* fast/visual-viewport/ios/min-scale-greater-than-one.html: Added.
+
 2018-01-23  Antoine Quint  
 
 [Web Animations] Expose getKeyframes() and parsing of remaining keyframe properties


Added: trunk/LayoutTests/fast/visual-viewport/ios/min-scale-greater-than-one-expected.txt (0 => 227430)

--- trunk/LayoutTests/fast/visual-viewport/ios/min-scale-greater-than-one-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/visual-viewport/ios/min-scale-greater-than-one-expected.txt	2018-01-23 20:11:10 UTC (rev 227430)
@@ -0,0 +1,10 @@
+PASS Math.round(boundingClientRect.top) is expectedTop
+Scrolling to bottom
+PASS window.scrollY is expectedTop
+PASS Math.round(boundingClientRect.top) is expectedTop
+Tap dispatched
+Target clicked
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/visual-viewport/ios/min-scale-greater-than-one.html (0 => 227430)

--- trunk/LayoutTests/fast/visual-viewport/ios/min-scale-greater-than-one.html	(rev 0)
+++ trunk/LayoutTests/fast/visual-viewport/ios/min-scale-greater-than-one.html	2018-01-23 20:11:10 UTC (rev 227430)
@@ -0,0 +1,83 @@
+ 
+
+
+
+
+
+jsTestIsAsync = true;
+
+function scrollToBottom(offsetTop)
+{
+return `(function() {
+uiController.immediateScrollToOffset(0, ${offsetTop});
+uiController.doAfterPresentationUpdate(function() {
+uiController.uiScriptComplete();
+});
+})()`;
+}
+
+var boundingClientRect;
+var expectedTop;
+function checkBoundingClientRect(top)
+{
+var target = document.getElementById('target');
+boundingClientRect = target.getBoundingClientRect();
+expectedTop = top;
+shouldBe('Math.round(boundingClientRect.top)', 'expectedTop');
+}
+
+function targetClicked()
+{
+debug('Target clicked');
+finishJSTest();
+}
+
+function doTest()
+{
+var scale = 320 / 250;
+
+checkBoundingClientRect(300);
+debug('Scrolling to bottom');
+testRunner.runUIScript(scrollToBottom(2000), function() {
+
+expectedTop = 1578;
+shouldBe('window.scrollY', 'expectedTop');
+checkBoundingClientRect(300);
+
+// Tap coordinates are document coordinates.
+var top = window.scrollY + 300 + 10;
+UIHelper.tapAt(50, top).then(() => {
+debug('Tap dispatched');
+setTimeout(function watchdog() {
+debug('Failed to receive click');
+finishJSTest();
+}, 400);
+   

[webkit-changes] [227429] trunk/Source/WebKit

[commit-queue]

Title: [227429] trunk/Source/WebKit








Revision 227429
Author commit-qu...@webkit.org
Date 2018-01-23 12:08:36 -0800 (Tue, 23 Jan 2018)


Log Message
Web Inspector: Window resizing is broken after detaching to separate window
https://bugs.webkit.org/show_bug.cgi?id=181992


Patch by Joseph Pecoraro  on 2018-01-23
Reviewed by Brian Burg.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDetach):
Restore the inspector view's autoresizingMask to the initial value
that works with a detached window. This gets changed when the view
gets attached to bottom/side, so we need to revert it on detaching.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (227428 => 227429)

--- trunk/Source/WebKit/ChangeLog	2018-01-23 20:03:58 UTC (rev 227428)
+++ trunk/Source/WebKit/ChangeLog	2018-01-23 20:08:36 UTC (rev 227429)
@@ -1,3 +1,17 @@
+2018-01-23  Joseph Pecoraro  
+
+Web Inspector: Window resizing is broken after detaching to separate window
+https://bugs.webkit.org/show_bug.cgi?id=181992
+
+
+Reviewed by Brian Burg.
+
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(WebKit::WebInspectorProxy::platformDetach):
+Restore the inspector view's autoresizingMask to the initial value
+that works with a detached window. This gets changed when the view
+gets attached to bottom/side, so we need to revert it on detaching.
+
 2018-01-23  Brady Eidson  
 
 Allow passing MessagePorts across processes (e.g. ServiceWorkers).


Modified: trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm (227428 => 227429)

--- trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm	2018-01-23 20:03:58 UTC (rev 227428)
+++ trunk/Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm	2018-01-23 20:08:36 UTC (rev 227429)
@@ -607,6 +607,8 @@
 
 [inspectorView removeFromSuperview];
 
+[inspectorView setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
+
 // Make sure that we size the inspected view's frame after detaching so that it takes up the space that the
 // attached inspector used to. Preserve the top position of the inspected view so banners in Safari still work.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227427] trunk/Tools

[ddkilzer]

Title: [227427] trunk/Tools








Revision 227427
Author ddkil...@apple.com
Date 2018-01-23 11:31:04 -0800 (Tue, 23 Jan 2018)


Log Message
Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
https://bugs.webkit.org/show_bug.cgi?id=180820

Patch by Basuke Suzuki  on 2018-01-23
Reviewed by David Kilzer.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.in_working_directory):
(Git.clone):
(Git.read_git_config):
(Git.apply_reverse_diff):
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.run):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm):
* Scripts/webkitpy/common/net/credentials_unittest.py:
* Scripts/webkitpy/common/system/abstractexecutive.py:
(AbstractExecutive.run_command):
* Scripts/webkitpy/common/system/executive.py:
(Executive.kill_process.is):
(Executive.running_pids):
(Executive.kill_all):
(Executive.run_command):
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.run_command):
(MockExecutive2.run_command):
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.xcode_sdk_version):
* Scripts/webkitpy/layout_tests/servers/http_server.py:
(Lighttpd._check_and_kill):
* Scripts/webkitpy/port/base.py:
(Port._symbols_string):
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/port/win.py:
(WinPort._runtime_feature_list):
(WinPort.read_registry_value):
* Scripts/webkitpy/port/win_unittest.py:
(WinPortTest.test_runtime_feature_list):
* Scripts/webkitpy/tool/commands/analyzechangelog.py:
* Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/checkout/scm/git.py
trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm.py
trunk/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py
trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py
trunk/Tools/Scripts/webkitpy/common/net/credentials_unittest.py
trunk/Tools/Scripts/webkitpy/common/system/abstractexecutive.py
trunk/Tools/Scripts/webkitpy/common/system/executive.py
trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py
trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py
trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py
trunk/Tools/Scripts/webkitpy/layout_tests/servers/http_server.py
trunk/Tools/Scripts/webkitpy/port/base.py
trunk/Tools/Scripts/webkitpy/port/gtk.py
trunk/Tools/Scripts/webkitpy/port/win.py
trunk/Tools/Scripts/webkitpy/port/win_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py
trunk/Tools/Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (227426 => 227427)

--- trunk/Tools/ChangeLog	2018-01-23 19:29:48 UTC (rev 227426)
+++ trunk/Tools/ChangeLog	2018-01-23 19:31:04 UTC (rev 227427)
@@ -1,3 +1,49 @@
+2018-01-23  Basuke Suzuki  
+
+Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
+https://bugs.webkit.org/show_bug.cgi?id=180820
+
+Reviewed by David Kilzer.
+
+* Scripts/webkitpy/common/checkout/scm/git.py:
+(Git.in_working_directory):
+(Git.clone):
+(Git.read_git_config):
+(Git.apply_reverse_diff):
+* Scripts/webkitpy/common/checkout/scm/scm.py:
+(SCM.run):
+* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
+* Scripts/webkitpy/common/checkout/scm/svn.py:
+(SVNRepository.has_authorization_for_realm):
+* Scripts/webkitpy/common/net/credentials_unittest.py:
+* Scripts/webkitpy/common/system/abstractexecutive.py:
+(AbstractExecutive.run_command):
+* Scripts/webkitpy/common/system/executive.py:
+(Executive.kill_process.is):
+(Executive.running_pids):
+(Executive.kill_all):
+(Executive.run_command):
+* Scripts/webkitpy/common/system/executive_mock.py:
+(MockExecutive.run_command):
+(MockExecutive2.run_command):
+* Scripts/webkitpy/common/system/executive_unittest.py:
+(ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
+* Scripts/webkitpy/common/system/platforminfo.py:
+(PlatformInfo.xcode_sdk_version):
+* Scripts/webkitpy/layout_tests/servers/http_server.py:
+(Lighttpd._check_and_kill):
+* Scripts/webkitpy/port/base.py:
+(Port._symbols_string):
+* Scripts/webkitpy/port/gtk.py:
+(GtkPort.setup_environ_for_server):
+* Scripts/webkitpy/port/win.py:
+(WinPort._runtime_feature_list):
+(WinPort.read_registry_value):
+* Scripts/webkitpy/port/win_unittest.py:
+(WinPortTest.test_runtime_feature_list):
+* Scripts/webkitpy/tool

[webkit-changes] [227426] trunk/LayoutTests

[ryanhaddad]

Title: [227426] trunk/LayoutTests








Revision 227426
Author ryanhad...@apple.com
Date 2018-01-23 11:29:48 -0800 (Tue, 23 Jan 2018)


Log Message
Mark inspector/unit-tests/throttle.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=181832

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227425 => 227426)

--- trunk/LayoutTests/ChangeLog	2018-01-23 19:24:23 UTC (rev 227425)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 19:29:48 UTC (rev 227426)
@@ -1,3 +1,12 @@
+2018-01-23  Ryan Haddad  
+
+Mark inspector/unit-tests/throttle.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=181832
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2018-01-23  Brady Eidson  
 
 Allow passing MessagePorts across processes (e.g. ServiceWorkers).


Modified: trunk/LayoutTests/platform/mac/TestExpectations (227425 => 227426)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-01-23 19:24:23 UTC (rev 227425)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-01-23 19:29:48 UTC (rev 227426)
@@ -1106,6 +1106,7 @@
 webkit.org/b/164278 inspector/storage/domStorage-events.html [ Pass Failure ]
 webkit.org/b/155607 inspector/unit-tests/heap-snapshot.html [ Pass Timeout ]
 webkit.org/b/157999 inspector/unit-tests/heap-snapshot-collection-event.html [ Pass Timeout ]
+webkit.org/b/181832 inspector/unit-tests/throttle.html [ Pass Failure ]
 webkit.org/b/161361 inspector/unit-tests/yieldable-task.html [ Pass Failure ]
 webkit.org/b/169228 inspector/worker/console-basic.html [ Pass Timeout ]
 webkit.org/b/164872 inspector/worker/debugger-multiple-targets-pause.html [ Pass Failure Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227425] trunk

[beidson]

Title: [227425] trunk








Revision 227425
Author beid...@apple.com
Date 2018-01-23 11:24:23 -0800 (Tue, 23 Jan 2018)


Log Message
Allow passing MessagePorts across processes (e.g. ServiceWorkers).
https://bugs.webkit.org/show_bug.cgi?id=181178

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

Re-baseline for many new passes and a few new failure modes.

* web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt:
* web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/postmessage.https-expected.txt:
* web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https-expected.txt:
* web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/unregister.https-expected.txt:
* web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https-expected.txt:
* web-platform-tests/service-workers/service-worker/claim-fetch.https-expected.txt:
* web-platform-tests/service-workers/service-worker/claim-not-using-registration.https-expected.txt:
* web-platform-tests/service-workers/service-worker/claim-using-registration.https-expected.txt:
* web-platform-tests/service-workers/service-worker/claim-worker-fetch.https-expected.txt:
* web-platform-tests/service-workers/service-worker/client-id.https-expected.txt:
* web-platform-tests/service-workers/service-worker/clients-get-cross-origin.https-expected.txt:
* web-platform-tests/service-workers/service-worker/clients-get.https-expected.txt:
* web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
* web-platform-tests/service-workers/service-worker/clients-matchall-exact-controller.https-expected.txt:
* web-platform-tests/service-workers/service-worker/clients-matchall-order.https-expected.txt:
* web-platform-tests/service-workers/service-worker/clients-matchall.https-expected.txt:
* web-platform-tests/service-workers/service-worker/extendable-event-async-waituntil.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-event-async-respond-with.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-event-throws-after-respond-with.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-request-css-base-url.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-request-css-images.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-request-fallback.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-request-resources.https-expected.txt:
* web-platform-tests/service-workers/service-worker/immutable-prototype-serviceworker.https-expected.txt:
* web-platform-tests/service-workers/service-worker/registration-end-to-end.https-expected.txt:
* web-platform-tests/service-workers/service-worker/registration-events.https-expected.txt:
* web-platform-tests/service-workers/service-worker/skip-waiting-installed.https-expected.txt:

Source/WebCore:

Test: http/tests/workers/service/basic-messageport.html

* dom/MessagePort.cpp:
(WebCore::MessagePort::MessagePort):
(WebCore::MessagePort::~MessagePort):

* dom/messageports/MessagePortChannel.cpp:
(WebCore::MessagePortChannel::entanglePortWithProcess):
* dom/messageports/MessagePortChannel.h:

* workers/service/SWClientConnection.cpp:
(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
* workers/service/SWClientConnection.h:

* workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::postMessage):

* workers/service/ServiceWorkerClient.cpp:
(WebCore::ServiceWorkerClient::postMessage):

* workers/service/context/SWContextManager.cpp:
(WebCore::SWContextManager::postMessageToServiceWorker):
* workers/service/context/SWContextManager.h:

Source/WebKit:

* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::postMessageToServiceWorker):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerClient):
* StorageProcess/ServiceWorker/WebSWServerConnection.h:
* StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:

* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::postMessageToServiceWorkerClient):
* StorageProcess/StorageProcess.h:
* StorageProcess/StorageProcess.messages.in:

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::entangleLocalPortInThisProcessToRemote):
(WebKit::WebProcessProxy::postMessageToRemote):

* WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::postMessageToServiceWorker):
(WebKit::WebSWClientConnection::postMessageToServiceWorkerClient):
* WebProcess/Storage/WebSWClientConnection.h:
* WebProcess/Storage/WebSWClientConnection.messages.in:

* WebProcess/Sto

[webkit-changes] [227424] trunk/Source

[fpizlo]

Title: [227424] trunk/Source








Revision 227424
Author fpi...@apple.com
Date 2018-01-23 10:26:35 -0800 (Tue, 23 Jan 2018)


Log Message
JSC should use a speculation fence on VM entry/exit
https://bugs.webkit.org/show_bug.cgi?id=181991

Reviewed by JF Bastien and Mark Lam.

Source/_javascript_Core:

This adds a WTF::speculationFence on VM entry and exit.

For a microbenchmark that just calls a native function (supplied via an Objective-C block) in a
tight loop from JS is a 0% regression on x86 and a 11% regression on ARM64.

* runtime/JSLock.cpp:
(JSC::JSLock::didAcquireLock):
(JSC::JSLock::willReleaseLock):

Source/WTF:

Implement speculationFence as lfence on x86 and isb on ARM64. I'm not sure if isb is
appropriate for all ARM64's.

* wtf/Atomics.h:
(WTF::speculationFence):
(WTF::x86_lfence):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSLock.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (227423 => 227424)

--- trunk/Source/_javascript_Core/ChangeLog	2018-01-23 18:22:50 UTC (rev 227423)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-01-23 18:26:35 UTC (rev 227424)
@@ -1,3 +1,19 @@
+2018-01-23  Filip Pizlo  
+
+JSC should use a speculation fence on VM entry/exit
+https://bugs.webkit.org/show_bug.cgi?id=181991
+
+Reviewed by JF Bastien and Mark Lam.
+
+This adds a WTF::speculationFence on VM entry and exit.
+
+For a microbenchmark that just calls a native function (supplied via an Objective-C block) in a
+tight loop from JS is a 0% regression on x86 and a 11% regression on ARM64.
+
+* runtime/JSLock.cpp:
+(JSC::JSLock::didAcquireLock):
+(JSC::JSLock::willReleaseLock):
+
 2018-01-23  Yusuke Suzuki  
 
 [JSC] JIT requires sizeof(bool) == 1


Modified: trunk/Source/_javascript_Core/runtime/JSLock.cpp (227423 => 227424)

--- trunk/Source/_javascript_Core/runtime/JSLock.cpp	2018-01-23 18:22:50 UTC (rev 227423)
+++ trunk/Source/_javascript_Core/runtime/JSLock.cpp	2018-01-23 18:26:35 UTC (rev 227424)
@@ -123,6 +123,8 @@
 
 void JSLock::didAcquireLock()
 {
+WTF::speculationFence();
+
 // FIXME: What should happen to the per-thread identifier table if we don't have a VM?
 if (!m_vm)
 return;
@@ -191,6 +193,8 @@
 
 void JSLock::willReleaseLock()
 {
+WTF::speculationFence();
+
 RefPtr vm = m_vm;
 if (vm) {
 vm->drainMicrotasks();


Modified: trunk/Source/WTF/ChangeLog (227423 => 227424)

--- trunk/Source/WTF/ChangeLog	2018-01-23 18:22:50 UTC (rev 227423)
+++ trunk/Source/WTF/ChangeLog	2018-01-23 18:26:35 UTC (rev 227424)
@@ -1,3 +1,17 @@
+2018-01-23  Filip Pizlo  
+
+JSC should use a speculation fence on VM entry/exit
+https://bugs.webkit.org/show_bug.cgi?id=181991
+
+Reviewed by JF Bastien and Mark Lam.
+
+Implement speculationFence as lfence on x86 and isb on ARM64. I'm not sure if isb is
+appropriate for all ARM64's.
+
+* wtf/Atomics.h:
+(WTF::speculationFence):
+(WTF::x86_lfence):
+
 2018-01-22  Alex Christensen  
 
 Begin removing QTKit code


Modified: trunk/Source/WTF/wtf/Atomics.h (227423 => 227424)

--- trunk/Source/WTF/wtf/Atomics.h	2018-01-23 18:22:50 UTC (rev 227423)
+++ trunk/Source/WTF/wtf/Atomics.h	2018-01-23 18:26:35 UTC (rev 227424)
@@ -276,9 +276,17 @@
 inline void memoryBarrierAfterLock() { arm_dmb(); }
 inline void memoryBarrierBeforeUnlock() { arm_dmb(); }
 inline void crossModifyingCodeFence() { arm_isb(); }
+inline void speculationFence() { arm_isb(); }
 
 #elif CPU(X86) || CPU(X86_64)
 
+inline void x86_lfence()
+{
+#if !OS(WINDOWS)
+asm volatile("lfence" ::: "memory");
+#endif
+}
+
 inline void x86_ortop()
 {
 #if OS(WINDOWS)
@@ -326,6 +334,7 @@
 inline void memoryBarrierAfterLock() { compilerFence(); }
 inline void memoryBarrierBeforeUnlock() { compilerFence(); }
 inline void crossModifyingCodeFence() { x86_cpuid(); }
+inline void speculationFence() { x86_lfence(); }
 
 #else
 
@@ -336,6 +345,7 @@
 inline void memoryBarrierAfterLock() { std::atomic_thread_fence(std::memory_order_seq_cst); }
 inline void memoryBarrierBeforeUnlock() { std::atomic_thread_fence(std::memory_order_seq_cst); }
 inline void crossModifyingCodeFence() { std::atomic_thread_fence(std::memory_order_seq_cst); } // Probably not strong enough.
+inline void speculationFence() { } // Probably not strong enough.
 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227423] trunk/LayoutTests

[ryanhaddad]

Title: [227423] trunk/LayoutTests








Revision 227423
Author ryanhad...@apple.com
Date 2018-01-23 10:22:50 -0800 (Tue, 23 Jan 2018)


Log Message
Unskip http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html on Sierra.
https://bugs.webkit.org/show_bug.cgi?id=181833

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227422 => 227423)

--- trunk/LayoutTests/ChangeLog	2018-01-23 17:52:53 UTC (rev 227422)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 18:22:50 UTC (rev 227423)
@@ -1,3 +1,12 @@
+2018-01-23  Ryan Haddad  
+
+Unskip http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html on Sierra.
+https://bugs.webkit.org/show_bug.cgi?id=181833
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2018-01-23  Andy Estes  
 
 Follow-up layout test fix after r227260.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (227422 => 227423)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-01-23 17:52:53 UTC (rev 227422)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-01-23 18:22:50 UTC (rev 227423)
@@ -24,7 +24,6 @@
 [ Sierra ] http/tests/ssl/applepay/ApplePayError.html [ Skip ]
 [ Sierra ] http/tests/ssl/applepay/ApplePaySessionV3.html [ Skip ]
 [ Sierra ] http/tests/ssl/applepay/ApplePayRequestShippingContactV3.https.html [ Skip ]
-webkit.org/b/181833 [ Sierra ] http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html [ Skip ]
 
 fast/visual-viewport/rubberbanding-viewport-rects.html [ Pass ]
 fast/visual-viewport/rubberbanding-viewport-rects-header-footer.html  [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227422] trunk

[commit-queue]

Title: [227422] trunk








Revision 227422
Author commit-qu...@webkit.org
Date 2018-01-23 09:52:53 -0800 (Tue, 23 Jan 2018)


Log Message
Unreviewed, rolling out r227279 and r227373.
https://bugs.webkit.org/show_bug.cgi?id=181988

The LayoutTest crash fix introduced an API test failure.
(Requested by ryanhaddad on #webkit).

Reverted changesets:

"Resign NowPlaying status when no media element is eligible"
https://bugs.webkit.org/show_bug.cgi?id=181914
https://trac.webkit.org/changeset/227279

"Resign NowPlaying status when no media element is eligible"
https://bugs.webkit.org/show_bug.cgi?id=181914
https://trac.webkit.org/changeset/227373

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/MediaElementSession.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h
trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.h
trunk/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.h
trunk/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewPrivate.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (227421 => 227422)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 17:38:53 UTC (rev 227421)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 17:52:53 UTC (rev 227422)
@@ -1,3 +1,21 @@
+2018-01-23  Commit Queue  
+
+Unreviewed, rolling out r227279 and r227373.
+https://bugs.webkit.org/show_bug.cgi?id=181988
+
+The LayoutTest crash fix introduced an API test failure.
+(Requested by ryanhaddad on #webkit).
+
+Reverted changesets:
+
+"Resign NowPlaying status when no media element is eligible"
+https://bugs.webkit.org/show_bug.cgi?id=181914
+https://trac.webkit.org/changeset/227279
+
+"Resign NowPlaying status when no media element is eligible"
+https://bugs.webkit.org/show_bug.cgi?id=181914
+https://trac.webkit.org/changeset/227373
+
 2018-01-23  Michael Catanzaro  
 
 Unreviewed, fix some format specifiers added in r227190


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (227421 => 227422)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2018-01-23 17:38:53 UTC (rev 227421)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2018-01-23 17:52:53 UTC (rev 227422)
@@ -971,9 +971,6 @@
 m_pauseAfterDetachedTaskQueue.enqueueTask(std::bind(&HTMLMediaElement::pauseAfterDetachedTask, this));
 }
 
-if (m_mediaSession)
-m_mediaSession->clientCharacteristicsChanged();
-
 HTMLElement::removedFromAncestor(removalType, oldParentOfRemovedTree);
 }
 


Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (227421 => 227422)

--- trunk/Source/WebCore/html/HTMLMediaElement.h	2018-01-23 17:38:53 UTC (rev 227421)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h	2018-01-23 17:52:53 UTC (rev 227422)
@@ -551,8 +551,6 @@
 
 bool willLog(WTFLogLevel) const;
 
-bool isSuspended() const final;
-
 protected:
 HTMLMediaElement(const QualifiedName&, Document&, bool createdByParser);
 virtual void finishInitialization();
@@ -866,6 +864,7 @@
 bool shouldOverrideBackgroundLoadingRestriction() const override;
 bool canProduceAudio() const final;
 bool processingUserGestureForMedia() const final;
+bool isSuspended() const final;
 
 void pageMutedStateDidChange() override;
 


Modified: trunk/Source/WebCore/html/MediaElementSession.cpp (227421 => 227422)

--- trunk/Source/WebCore/html/MediaElementSession.cpp	2018-01-23 17:38:53 UTC (rev 227421)
+++ trunk/Source/WebCore/html/MediaElementSession.cpp	2018-01-23 17:52:53 UTC (rev 227422)
@@ -162,9 +162,6 @@
 
 SuccessOr MediaElementSession::playbackPermitted(const HTMLMediaElement& element) const
 {
-if (m_element.isSuspended())
-return { };
-
 if (element.document().isMediaDocument() && !element.document().ownerElement())
 return { };
 
@@ -298,11 +295,6 @@
 
 bool MediaElementSession::canShowControlsManager(PlaybackControlsPurpose purpose) const
 {
-if (m_element.isSuspended()) {
-LOG(Media, "MediaElementSession::canShowControlsManager - returning FALSE: isSuspended()");
-return false;
-}
-
 if (m_element.isFullscreen()) {
 LOG(Media, "MediaElementSession::canShowControlsManager - returning TRUE: Is fullscreen");
 return true;
@@ -343,6 +335,11 @@
  

[webkit-changes] [227421] trunk/LayoutTests

[aestes]

Title: [227421] trunk/LayoutTests








Revision 227421
Author aes...@apple.com
Date 2018-01-23 09:38:53 -0800 (Tue, 23 Jan 2018)


Log Message
Follow-up layout test fix after r227260.

I missed a few places that were still using version 3 API requests.

* http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html




Diff

Modified: trunk/LayoutTests/ChangeLog (227420 => 227421)

--- trunk/LayoutTests/ChangeLog	2018-01-23 17:26:41 UTC (rev 227420)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 17:38:53 UTC (rev 227421)
@@ -1,3 +1,11 @@
+2018-01-23  Andy Estes  
+
+Follow-up layout test fix after r227260.
+
+I missed a few places that were still using version 3 API requests.
+
+* http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html:
+
 2018-01-23  Youenn Fablet  
 
 Mark some service-worker fetch tests as DumpJSConsoleLogInStdErr


Modified: trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html (227420 => 227421)

--- trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html	2018-01-23 17:26:41 UTC (rev 227420)
+++ trunk/LayoutTests/http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html	2018-01-23 17:38:53 UTC (rev 227421)
@@ -135,7 +135,7 @@
 await new Promise((resolve, reject) => {
 debug("Test setting a default shipping contact that only specifies an email address.");
 
-var paymentRequest = new PaymentRequest([validPaymentMethod(3, { emailAddress: expectedEmailAddress })], validPaymentDetails(), { requestPayerEmail: true });
+var paymentRequest = new PaymentRequest([validPaymentMethod(2, { emailAddress: expectedEmailAddress })], validPaymentDetails(), { requestPayerEmail: true });
 
 activateThen(() => {
 paymentRequest.show().then((response) => {
@@ -158,7 +158,7 @@
 await new Promise((resolve, reject) => {
 debug("Test setting a default shipping contact that only specifies a phone number.");
 
-var paymentRequest = new PaymentRequest([validPaymentMethod(3, { phoneNumber: expectedPhoneNumber })], validPaymentDetails(), { requestPayerPhone: true });
+var paymentRequest = new PaymentRequest([validPaymentMethod(2, { phoneNumber: expectedPhoneNumber })], validPaymentDetails(), { requestPayerPhone: true });
 
 activateThen(() => {
 paymentRequest.show().then((response) => {
@@ -181,7 +181,7 @@
 await new Promise((resolve, reject) => {
 debug("Test setting a default shipping contact that only specifies a name.");
 
-var paymentRequest = new PaymentRequest([validPaymentMethod(3, { givenName: expectedGivenName, familyName: expectedFamilyName })], validPaymentDetails(), { requestPayerName: true });
+var paymentRequest = new PaymentRequest([validPaymentMethod(2, { givenName: expectedGivenName, familyName: expectedFamilyName })], validPaymentDetails(), { requestPayerName: true });
 
 activateThen(() => {
 paymentRequest.show().then((response) => {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227420] trunk/Source/WebCore

[mcatanzaro]

Title: [227420] trunk/Source/WebCore








Revision 227420
Author mcatanz...@igalia.com
Date 2018-01-23 09:26:41 -0800 (Tue, 23 Jan 2018)


Log Message
Unreviewed, fix some format specifiers added in r227190
https://bugs.webkit.org/show_bug.cgi?id=181454

* dom/messageports/MessagePortChannel.cpp:
(WebCore::MessagePortChannel::takeAllMessagesForPort):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/messageports/MessagePortChannel.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (227419 => 227420)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 17:21:08 UTC (rev 227419)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 17:26:41 UTC (rev 227420)
@@ -1,3 +1,11 @@
+2018-01-23  Michael Catanzaro  
+
+Unreviewed, fix some format specifiers added in r227190
+https://bugs.webkit.org/show_bug.cgi?id=181454
+
+* dom/messageports/MessagePortChannel.cpp:
+(WebCore::MessagePortChannel::takeAllMessagesForPort):
+
 2018-01-23  Ting-Wei Lan  
 
 [GTK] Add user agent quirk for Microsoft Outlook Web App


Modified: trunk/Source/WebCore/dom/messageports/MessagePortChannel.cpp (227419 => 227420)

--- trunk/Source/WebCore/dom/messageports/MessagePortChannel.cpp	2018-01-23 17:21:08 UTC (rev 227419)
+++ trunk/Source/WebCore/dom/messageports/MessagePortChannel.cpp	2018-01-23 17:26:41 UTC (rev 227420)
@@ -184,7 +184,7 @@
 
 ++m_messageBatchesInFlight;
 
-LOG(MessagePorts, "There are %zu messages to take for port %s. Taking them now, messages in flight is now %llu", result.size(), port.logString().utf8().data(), m_messageBatchesInFlight);
+LOG(MessagePorts, "There are %zu messages to take for port %s. Taking them now, messages in flight is now %" PRIu64, result.size(), port.logString().utf8().data(), m_messageBatchesInFlight);
 
 auto size = result.size();
 HashSet> transferredPortProtectors;
@@ -196,7 +196,7 @@
 UNUSED_PARAM(size);
 #endif
 --m_messageBatchesInFlight;
-LOG(MessagePorts, "Message port channel %s was notified that a batch of %zu message port messages targeted for port %s just completed dispatch, in flight is now %llu", logString().utf8().data(), size, port.logString().utf8().data(), m_messageBatchesInFlight);
+LOG(MessagePorts, "Message port channel %s was notified that a batch of %zu message port messages targeted for port %s just completed dispatch, in flight is now %" PRIu64, logString().utf8().data(), size, port.logString().utf8().data(), m_messageBatchesInFlight);
 
 });
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227417] trunk/JSTests

[fpizlo]

Title: [227417] trunk/JSTests








Revision 227417
Author fpi...@apple.com
Date 2018-01-23 09:11:40 -0800 (Tue, 23 Jan 2018)


Log Message
Unreviewed, retire some microbenchmarks that are proportionately very slow. Benchmark running time should be proportional to their value. Microbenchmarks have little value, so they should be very fast.

* microbenchmarks/array-push-3.js: Removed.
* microbenchmarks/bigswitch-indirect-symbol-or-undefined.js: Removed.
* microbenchmarks/double-to-int32.js: Removed.
* microbenchmarks/fake-iterators-that-throw-when-finished.js: Removed.
* microbenchmarks/ftl-polymorphic-bitand.js: Removed.
* microbenchmarks/ftl-polymorphic-bitor.js: Removed.
* microbenchmarks/ftl-polymorphic-bitxor.js: Removed.
* microbenchmarks/ftl-polymorphic-lshift.js: Removed.
* microbenchmarks/ftl-polymorphic-rshift.js: Removed.
* microbenchmarks/ftl-polymorphic-sub.js: Removed.
* microbenchmarks/ftl-polymorphic-urshift.js: Removed.
* microbenchmarks/map-constant-key.js: Removed.
* microbenchmarks/nested-function-parsing.js: Removed.
* microbenchmarks/rest-parameter-allocation-elimination.js: Removed.
* microbenchmarks/spread-large-array.js: Removed.
* microbenchmarks/string-add-constant-folding.js: Removed.
* microbenchmarks/to-lower-case.js: Removed.
* microbenchmarks/undefined-property-access.js: Removed.
* slowMicrobenchmarks/array-push-3.js: Copied from JSTests/microbenchmarks/array-push-3.js.
* slowMicrobenchmarks/bigswitch-indirect-symbol-or-undefined.js: Copied from JSTests/microbenchmarks/bigswitch-indirect-symbol-or-undefined.js.
* slowMicrobenchmarks/double-to-int32.js: Copied from JSTests/microbenchmarks/double-to-int32.js.
* slowMicrobenchmarks/fake-iterators-that-throw-when-finished.js: Copied from JSTests/microbenchmarks/fake-iterators-that-throw-when-finished.js.
* slowMicrobenchmarks/ftl-polymorphic-bitand.js: Copied from JSTests/microbenchmarks/ftl-polymorphic-bitand.js.
* slowMicrobenchmarks/ftl-polymorphic-bitor.js: Copied from JSTests/microbenchmarks/ftl-polymorphic-bitor.js.
* slowMicrobenchmarks/ftl-polymorphic-bitxor.js: Copied from JSTests/microbenchmarks/ftl-polymorphic-bitxor.js.
* slowMicrobenchmarks/ftl-polymorphic-lshift.js: Copied from JSTests/microbenchmarks/ftl-polymorphic-lshift.js.
* slowMicrobenchmarks/ftl-polymorphic-rshift.js: Copied from JSTests/microbenchmarks/ftl-polymorphic-rshift.js.
* slowMicrobenchmarks/ftl-polymorphic-sub.js: Copied from JSTests/microbenchmarks/ftl-polymorphic-sub.js.
* slowMicrobenchmarks/ftl-polymorphic-urshift.js: Copied from JSTests/microbenchmarks/ftl-polymorphic-urshift.js.
* slowMicrobenchmarks/map-constant-key.js: Copied from JSTests/microbenchmarks/map-constant-key.js.
* slowMicrobenchmarks/nested-function-parsing.js: Copied from JSTests/microbenchmarks/nested-function-parsing.js.
* slowMicrobenchmarks/rest-parameter-allocation-elimination.js: Copied from JSTests/microbenchmarks/rest-parameter-allocation-elimination.js.
* slowMicrobenchmarks/spread-large-array.js: Copied from JSTests/microbenchmarks/spread-large-array.js.
* slowMicrobenchmarks/string-add-constant-folding.js: Copied from JSTests/microbenchmarks/string-add-constant-folding.js.
* slowMicrobenchmarks/to-lower-case.js: Copied from JSTests/microbenchmarks/to-lower-case.js.
* slowMicrobenchmarks/undefined-property-access.js: Copied from JSTests/microbenchmarks/undefined-property-access.js.

Modified Paths

trunk/JSTests/ChangeLog


Added Paths

trunk/JSTests/slowMicrobenchmarks/array-push-3.js
trunk/JSTests/slowMicrobenchmarks/bigswitch-indirect-symbol-or-undefined.js
trunk/JSTests/slowMicrobenchmarks/double-to-int32.js
trunk/JSTests/slowMicrobenchmarks/fake-iterators-that-throw-when-finished.js
trunk/JSTests/slowMicrobenchmarks/ftl-polymorphic-bitand.js
trunk/JSTests/slowMicrobenchmarks/ftl-polymorphic-bitor.js
trunk/JSTests/slowMicrobenchmarks/ftl-polymorphic-bitxor.js
trunk/JSTests/slowMicrobenchmarks/ftl-polymorphic-lshift.js
trunk/JSTests/slowMicrobenchmarks/ftl-polymorphic-rshift.js
trunk/JSTests/slowMicrobenchmarks/ftl-polymorphic-sub.js
trunk/JSTests/slowMicrobenchmarks/ftl-polymorphic-urshift.js
trunk/JSTests/slowMicrobenchmarks/map-constant-key.js
trunk/JSTests/slowMicrobenchmarks/nested-function-parsing.js
trunk/JSTests/slowMicrobenchmarks/rest-parameter-allocation-elimination.js
trunk/JSTests/slowMicrobenchmarks/spread-large-array.js
trunk/JSTests/slowMicrobenchmarks/string-add-constant-folding.js
trunk/JSTests/slowMicrobenchmarks/to-lower-case.js
trunk/JSTests/slowMicrobenchmarks/undefined-property-access.js


Removed Paths

trunk/JSTests/microbenchmarks/array-push-3.js
trunk/JSTests/microbenchmarks/bigswitch-indirect-symbol-or-undefined.js
trunk/JSTests/microbenchmarks/double-to-int32.js
trunk/JSTests/microbenchmarks/fake-iterators-that-throw-when-finished.js
trunk/JSTests/microbenchmarks/ftl-polymorphic-bitand.js
trunk/JSTests/microbenchmarks/ftl-polymorphic-bitor.js
trunk/JSTests/microbenchmarks/ftl-polymorphic-bitxor.js
trunk/JSTests/microbenchmarks/ftl-

[webkit-changes] [227416] trunk/Source/WebCore

[commit-queue]

Title: [227416] trunk/Source/WebCore








Revision 227416
Author commit-qu...@webkit.org
Date 2018-01-23 09:10:47 -0800 (Tue, 23 Jan 2018)


Log Message
[GTK] Add user agent quirk for Microsoft Outlook Web App
https://bugs.webkit.org/show_bug.cgi?id=181982

Patch by Ting-Wei Lan  on 2018-01-23
Reviewed by Michael Catanzaro.

Microsoft Outlook Web App forces users to switch to the lite version on
the login page with our standard user agent on all non-macOS systems.
Since it is an application that can be installed by different companies,
schools and organizations, it is not possible to fix the issue unless
we keep a big list of host names that are known to run it. We check the
host name instead of the base domain name here because it is not
expected to run all sites under a base domain on this webmail and
calendar application.

https://mail.ntu.edu.tw is a site that is known to run Microsoft Outlook
Web App for several years, and it is not likely to change. When there
are other sites found to run it and having the same user agent problem,
we can expand the list to include them.

* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresMacintoshPlatform):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/UserAgentQuirks.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (227415 => 227416)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 16:51:22 UTC (rev 227415)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 17:10:47 UTC (rev 227416)
@@ -1,3 +1,27 @@
+2018-01-23  Ting-Wei Lan  
+
+[GTK] Add user agent quirk for Microsoft Outlook Web App
+https://bugs.webkit.org/show_bug.cgi?id=181982
+
+Reviewed by Michael Catanzaro.
+
+Microsoft Outlook Web App forces users to switch to the lite version on
+the login page with our standard user agent on all non-macOS systems.
+Since it is an application that can be installed by different companies,
+schools and organizations, it is not possible to fix the issue unless
+we keep a big list of host names that are known to run it. We check the
+host name instead of the base domain name here because it is not
+expected to run all sites under a base domain on this webmail and
+calendar application.
+
+https://mail.ntu.edu.tw is a site that is known to run Microsoft Outlook
+Web App for several years, and it is not likely to change. When there
+are other sites found to run it and having the same user agent problem,
+we can expand the list to include them.
+
+* platform/UserAgentQuirks.cpp:
+(WebCore::urlRequiresMacintoshPlatform):
+
 2018-01-23  Yacine Bandou  
 
 [EME] Add support of multi keys from different sessions in CDMinstanceClearKey


Modified: trunk/Source/WebCore/platform/UserAgentQuirks.cpp (227415 => 227416)

--- trunk/Source/WebCore/platform/UserAgentQuirks.cpp	2018-01-23 16:51:22 UTC (rev 227415)
+++ trunk/Source/WebCore/platform/UserAgentQuirks.cpp	2018-01-23 17:10:47 UTC (rev 227416)
@@ -72,7 +72,8 @@
 
 static bool urlRequiresMacintoshPlatform(const URL& url)
 {
-String baseDomain = topPrivatelyControlledDomain(url.host());
+String domain = url.host();
+String baseDomain = topPrivatelyControlledDomain(domain);
 
 // At least finance.yahoo.com displays a mobile version with WebKitGTK+'s standard user agent.
 if (baseDomain == "yahoo.com")
@@ -86,6 +87,12 @@
 if (baseDomain == "whatsapp.com")
 return true;
 
+// Microsoft Outlook Web App forces users with WebKitGTK+'s standard user
+// agent to use the light version. Earlier versions even blocks users from
+// accessing the calendar.
+if (domain == "mail.ntu.edu.tw")
+return true;
+
 return false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [227413] trunk

[carlosgc]

Title: [227413] trunk








Revision 227413
Author carlo...@webkit.org
Date 2018-01-23 08:21:43 -0800 (Tue, 23 Jan 2018)


Log Message
WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/response.py::test_timeouts fails
https://bugs.webkit.org/show_bug.cgi?id=180412

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

Include all missing capabilities in the new session response message.

Fixes: imported/w3c/webdriver/tests/sessions/new_session/response.py::test_resp_capabilites
   imported/w3c/webdriver/tests/sessions/new_session/response.py::test_resp_data
   imported/w3c/webdriver/tests/sessions/new_session/response.py::test_timeouts

* Session.h:
(WebDriver::Session::scriptTimeout const):
(WebDriver::Session::pageLoadTimeout const):
(WebDriver::Session::implicitWaitTimeout const):
* WebDriverService.cpp:
(WebDriver::WebDriverService::newSession):

WebDriverTests:

Remove expectations for imported/w3c/webdriver/tests/sessions/new_session/response.py since all tests are
passing now.

* TestExpectations.json:

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/Session.h
trunk/Source/WebDriver/WebDriverService.cpp
trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/TestExpectations.json




Diff

Modified: trunk/Source/WebDriver/ChangeLog (227412 => 227413)

--- trunk/Source/WebDriver/ChangeLog	2018-01-23 16:20:36 UTC (rev 227412)
+++ trunk/Source/WebDriver/ChangeLog	2018-01-23 16:21:43 UTC (rev 227413)
@@ -1,5 +1,25 @@
 2018-01-23  Carlos Garcia Campos  
 
+WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/response.py::test_timeouts fails
+https://bugs.webkit.org/show_bug.cgi?id=180412
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Include all missing capabilities in the new session response message.
+
+Fixes: imported/w3c/webdriver/tests/sessions/new_session/response.py::test_resp_capabilites
+   imported/w3c/webdriver/tests/sessions/new_session/response.py::test_resp_data
+   imported/w3c/webdriver/tests/sessions/new_session/response.py::test_timeouts
+
+* Session.h:
+(WebDriver::Session::scriptTimeout const):
+(WebDriver::Session::pageLoadTimeout const):
+(WebDriver::Session::implicitWaitTimeout const):
+* WebDriverService.cpp:
+(WebDriver::WebDriverService::newSession):
+
+2018-01-23  Carlos Garcia Campos  
+
 WebDriver: matched capabilities should include setWindowRect
 https://bugs.webkit.org/show_bug.cgi?id=180411
 


Modified: trunk/Source/WebDriver/Session.h (227412 => 227413)

--- trunk/Source/WebDriver/Session.h	2018-01-23 16:20:36 UTC (rev 227412)
+++ trunk/Source/WebDriver/Session.h	2018-01-23 16:21:43 UTC (rev 227413)
@@ -48,10 +48,12 @@
 
 const String& id() const { return m_id; }
 const Capabilities& capabilities() const;
+Seconds scriptTimeout() const  { return m_scriptTimeout; }
+Seconds pageLoadTimeout() const { return m_pageLoadTimeout; }
+Seconds implicitWaitTimeout() const { return m_implicitWaitTimeout; }
 
 enum class FindElementsMode { Single, Multiple };
 enum class ExecuteScriptMode { Sync, Async };
-enum class Timeout { Script, PageLoad, Implicit };
 
 struct Cookie {
 String name;


Modified: trunk/Source/WebDriver/WebDriverService.cpp (227412 => 227413)

--- trunk/Source/WebDriver/WebDriverService.cpp	2018-01-23 16:20:36 UTC (rev 227412)
+++ trunk/Source/WebDriver/WebDriverService.cpp	2018-01-23 16:21:43 UTC (rev 227413)
@@ -647,29 +647,6 @@
 capabilitiesObject->setString(ASCIILiteral("platformName"), capabilities.platformName.value());
 if (capabilities.acceptInsecureCerts)
 capabilitiesObject->setBoolean(ASCIILiteral("acceptInsecureCerts"), capabilities.acceptInsecureCerts.value());
-if (capabilities.timeouts) {
-RefPtr timeoutsObject = JSON::Object::create();
-if (capabilities.timeouts.value().script)
-timeoutsObject->setInteger(ASCIILiteral("script"), capabilities.timeouts.value().script.value().millisecondsAs());
-if (capabilities.timeouts.value().pageLoad)
-timeoutsObject->setInteger(ASCIILiteral("pageLoad"), capabilities.timeouts.value().pageLoad.value().millisecondsAs());
-if (capabilities.timeouts.value().implicit)
-timeoutsObject->setInteger(ASCIILiteral("implicit"), capabilities.timeouts.value().implicit.value().millisecondsAs());
-capabilitiesObject->setObject(ASCIILiteral("timeouts"), WTFMove(timeoutsObject));
-}
-if (capabilities.pageLoadStrategy) {
-switch (capabilities.pageLoadStrategy.value()) {
-case PageLoadStrategy::None:
-capabilitiesObject->setString(ASCIILiteral("pageLoadStrategy"), "none");
-break;
-case PageLoadStr

[webkit-changes] [227410] trunk

[rmorisset]

Title: [227410] trunk








Revision 227410
Author rmoris...@apple.com
Date 2018-01-23 06:28:10 -0800 (Tue, 23 Jan 2018)


Log Message
Update the argument count in DFGByteCodeParser::handleRecursiveCall
https://bugs.webkit.org/show_bug.cgi?id=181739


Reviewed by Saam Barati.

JSTests:

* stress/recursive-tail-call-with-different-argument-count.js: Added.
(foo):
(bar):

Source/_javascript_Core:

When calling a function, its number of arguments is set on the stack. When we turn a recursive tail call
into a jump, we should update that stack slot as there is no guarantee that the function was originally
called with the same number of arguments. Forgetting to do this is observable through 'arguments.length'.

It required adding a new DFG node: 'SetArgumentCountIncludingThis', that takes an unsigned int
as its first OpInfo field, and stores it to the stack at the right place.

We must be a bit careful in where we put this new node, as it ClobbersExit.
We must also fix DFGArgumentsEliminationPhase and DFGPutStackSinkingPhase as they assumed that any node that writes to the stack must write to either an argument or a local.

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter::executeEffects):
* dfg/DFGArgumentsEliminationPhase.cpp:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGMayExit.cpp:
* dfg/DFGNode.h:
(JSC::DFG::Node::argumentCountIncludingThis):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGPutStackSinkingPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSetArgumentCountIncludingThis):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileSetArgumentCountIncludingThis):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h
trunk/Source/_javascript_Core/dfg/DFGArgumentsEliminationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGDoesGC.cpp
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGMayExit.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGNodeType.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGPutStackSinkingPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGSafeToExecute.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp


Added Paths

trunk/JSTests/stress/recursive-tail-call-with-different-argument-count.js




Diff

Modified: trunk/JSTests/ChangeLog (227409 => 227410)

--- trunk/JSTests/ChangeLog	2018-01-23 12:07:42 UTC (rev 227409)
+++ trunk/JSTests/ChangeLog	2018-01-23 14:28:10 UTC (rev 227410)
@@ -1,3 +1,15 @@
+2018-01-23  Robin Morisset  
+
+Update the argument count in DFGByteCodeParser::handleRecursiveCall
+https://bugs.webkit.org/show_bug.cgi?id=181739
+
+
+Reviewed by Saam Barati.
+
+* stress/recursive-tail-call-with-different-argument-count.js: Added.
+(foo):
+(bar):
+
 2018-01-22  Michael Saboff  
 
 DFG abstract interpreter needs to properly model effects of some Math ops


Added: trunk/JSTests/stress/recursive-tail-call-with-different-argument-count.js (0 => 227410)

--- trunk/JSTests/stress/recursive-tail-call-with-different-argument-count.js	(rev 0)
+++ trunk/JSTests/stress/recursive-tail-call-with-different-argument-count.js	2018-01-23 14:28:10 UTC (rev 227410)
@@ -0,0 +1,25 @@
+"use strict";
+function foo(x, y)
+{
+if (arguments.length >= 2)
+return foo(x+y)
+return x;
+}
+noInline(foo);
+
+function bar(x)
+{
+if (arguments.length >= 2)
+return bar(arguments[0] + arguments[1])
+return x;
+}
+noInline(bar);
+
+for (var i = 0; i < 1; ++i) {
+var result = foo(40, 2);
+if (result !== 42)
+throw "Wrong result for foo, expected 42, got " + result;
+result = bar(40, 2);
+if (result !== 42)
+throw "Wrong result for bar, expected 42, got " + result;
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (227409 => 227410)

--- trunk/Source/_javascript_Core/Chan

[webkit-changes] [227409] trunk/Source/WebCore

[commit-queue]

Title: [227409] trunk/Source/WebCore








Revision 227409
Author commit-qu...@webkit.org
Date 2018-01-23 04:07:42 -0800 (Tue, 23 Jan 2018)


Log Message
[EME] Add support of multi keys from different sessions in CDMinstanceClearKey
https://bugs.webkit.org/show_bug.cgi?id=180083

Patch by Yacine Bandou  on 2018-01-23
Reviewed by Xabier Rodriguez-Calvar.

Add support of multi keys from different MediaKeySession in CDMInstanceClearKey.

Currently the CDMInstanceClearKey manages two "m_keys", one is a WTF::Vector
where it stores the list of last added keys, an other which is defined in the
ClearKeyState::singleton it is a WTF::HashMap, in this last one, it stores the
keys lists of each created session.

The method "keys()" of CDMInstanceClearKey returns the first "m_keys" which
contains just the list of last keys.

The goal of this commit is to return all keys lists of all sessions, thus
we remove the "m_keys" which is WTF::Vector and we modify the method
"keys()" to return all keys lists, which is stored in "m_keys" WTF::HashMap,
in one Vector instead of return just the list of last keys.

* platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::CDMInstanceClearKey::keys const):
(WebCore::CDMInstanceClearKey::updateLicense):
* platform/encryptedmedia/clearkey/CDMClearKey.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp
trunk/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (227408 => 227409)

--- trunk/Source/WebCore/ChangeLog	2018-01-23 09:43:46 UTC (rev 227408)
+++ trunk/Source/WebCore/ChangeLog	2018-01-23 12:07:42 UTC (rev 227409)
@@ -1,3 +1,30 @@
+2018-01-23  Yacine Bandou  
+
+[EME] Add support of multi keys from different sessions in CDMinstanceClearKey
+https://bugs.webkit.org/show_bug.cgi?id=180083
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Add support of multi keys from different MediaKeySession in CDMInstanceClearKey.
+
+Currently the CDMInstanceClearKey manages two "m_keys", one is a WTF::Vector
+where it stores the list of last added keys, an other which is defined in the
+ClearKeyState::singleton it is a WTF::HashMap, in this last one, it stores the
+keys lists of each created session.
+
+The method "keys()" of CDMInstanceClearKey returns the first "m_keys" which
+contains just the list of last keys.
+
+The goal of this commit is to return all keys lists of all sessions, thus
+we remove the "m_keys" which is WTF::Vector and we modify the method
+"keys()" to return all keys lists, which is stored in "m_keys" WTF::HashMap,
+in one Vector instead of return just the list of last keys.
+
+* platform/encryptedmedia/clearkey/CDMClearKey.cpp:
+(WebCore::CDMInstanceClearKey::keys const):
+(WebCore::CDMInstanceClearKey::updateLicense):
+* platform/encryptedmedia/clearkey/CDMClearKey.h:
+
 2018-01-22  Simon Fraser  
 
 Optimize building the non-fast scrollable region with multiple iframes


Modified: trunk/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp (227408 => 227409)

--- trunk/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp	2018-01-23 09:43:46 UTC (rev 227408)
+++ trunk/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp	2018-01-23 12:07:42 UTC (rev 227409)
@@ -480,6 +480,16 @@
 });
 }
 
+const Vector CDMInstanceClearKey::keys() const
+{
+// Return the keys of all sessions.
+Vector allKeys { };
+for (auto& key : ClearKeyState::singleton().keys().values())
+allKeys.appendVector(key);
+
+return allKeys;
+}
+
 void CDMInstanceClearKey::updateLicense(const String& sessionId, LicenseType, const SharedBuffer& response, LicenseUpdateCallback callback)
 {
 // Use a helper functor that schedules the callback dispatch, avoiding
@@ -565,9 +575,6 @@
 changedKeys = WTFMove(keyStatusVector);
 }
 
-// Cache the key information Vector on CDMInstance for easier access from the pipeline.
-m_keys = keyVector;
-
 dispatchCallback(false, WTFMove(changedKeys), SuccessValue::Succeeded);
 return;
 }
@@ -576,7 +583,6 @@
 if (parseLicenseReleaseAcknowledgementFormat(*root)) {
 // FIXME: Retrieve the key ID information and use it to validate the keys for this sessionId.
 ClearKeyState::singleton().keys().remove(sessionId);
-m_keys.clear();
 dispatchCallback(true, std::nullopt, SuccessValue::Succeeded);
 return;
 }


Modified: trunk/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h (227408 => 227409)

--- trunk/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h	2018-01-23 09:43:46 UTC (rev 227408)
+++ trunk/Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.h	2018-01-23 12:07:42 UTC (rev 227409)
@@ -102,11 +102,10 @@
 

[webkit-changes] [227408] trunk

[carlosgc]

Title: [227408] trunk








Revision 227408
Author carlo...@webkit.org
Date 2018-01-23 01:43:46 -0800 (Tue, 23 Jan 2018)


Log Message
WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize fails
https://bugs.webkit.org/show_bug.cgi?id=181728

Reviewed by Sergio Villar Senin.

Source/WebDriver:

Due to a copy-paste error we are getting the window height using the width variable.

Fixes: imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize
   imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py::testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort
   imported/w3c/webdriver/tests/get_window_rect.py::test_payload
   imported/w3c/webdriver/tests/set_window_rect.py::test_width_height_floats
   imported/w3c/webdriver/tests/set_window_rect.py::test_height_width
   imported/w3c/webdriver/tests/set_window_rect.py::test_height_width_larger_than_max
   imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py::test_window_resize

* Session.cpp:
(WebDriver::Session::getToplevelBrowsingContextRect):

WebDriverTests:

Remove expectations for tests that are now passing.

* TestExpectations.json:

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/Session.cpp
trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/TestExpectations.json




Diff

Modified: trunk/Source/WebDriver/ChangeLog (227407 => 227408)

--- trunk/Source/WebDriver/ChangeLog	2018-01-23 09:26:31 UTC (rev 227407)
+++ trunk/Source/WebDriver/ChangeLog	2018-01-23 09:43:46 UTC (rev 227408)
@@ -1,3 +1,23 @@
+2018-01-23  Carlos Garcia Campos  
+
+WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize fails
+https://bugs.webkit.org/show_bug.cgi?id=181728
+
+Reviewed by Sergio Villar Senin.
+
+Due to a copy-paste error we are getting the window height using the width variable.
+
+Fixes: imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize
+   imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py::testShouldScrollPageAndGetCoordinatesOfAnElementThatIsOutOfViewPort
+   imported/w3c/webdriver/tests/get_window_rect.py::test_payload
+   imported/w3c/webdriver/tests/set_window_rect.py::test_width_height_floats
+   imported/w3c/webdriver/tests/set_window_rect.py::test_height_width
+   imported/w3c/webdriver/tests/set_window_rect.py::test_height_width_larger_than_max
+   imported/w3c/webdriver/tests/contexts/resizing_and_positioning.py::test_window_resize
+
+* Session.cpp:
+(WebDriver::Session::getToplevelBrowsingContextRect):
+
 2018-01-22  Carlos Garcia Campos  
 
 WebDriver: implement get element CSS value command


Modified: trunk/Source/WebDriver/Session.cpp (227407 => 227408)

--- trunk/Source/WebDriver/Session.cpp	2018-01-23 09:26:31 UTC (rev 227407)
+++ trunk/Source/WebDriver/Session.cpp	2018-01-23 09:43:46 UTC (rev 227408)
@@ -698,7 +698,7 @@
 double width, height;
 if (!browsingContext->getObject(ASCIILiteral("windowSize"), windowSize)
 || !windowSize->getDouble(ASCIILiteral("width"), width)
-|| !windowSize->getDouble(ASCIILiteral("height"), width)) {
+|| !windowSize->getDouble(ASCIILiteral("height"), height)) {
 completionHandler(CommandResult::fail(CommandResult::ErrorCode::UnknownError));
 return;
 }


Modified: trunk/WebDriverTests/ChangeLog (227407 => 227408)

--- trunk/WebDriverTests/ChangeLog	2018-01-23 09:26:31 UTC (rev 227407)
+++ trunk/WebDriverTests/ChangeLog	2018-01-23 09:43:46 UTC (rev 227408)
@@ -1,3 +1,14 @@
+2018-01-23  Carlos Garcia Campos  
+
+WebDriver: test imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py::testChangeWindowSize fails
+https://bugs.webkit.org/show_bug.cgi?id=181728
+
+Reviewed by Sergio Villar Senin.
+
+Remove expectations for tests that are now passing.
+
+* TestExpectations.json:
+
 2018-01-22  Carlos Garcia Campos  
 
 WebDriver: implement get element CSS value command


Modified: trunk/WebDriverTests/TestExpectations.json (227407 => 227408)

--- trunk/WebDriverTests/TestExpectations.json	2018-01-23 09:26:31 UTC (rev 227407)
+++ trunk/WebDriverTests/TestExpectations.json	2018-01-23 09:43:46 UTC (rev 227408)
@@ -11,9 +11,6 @@
 },
 "imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py": {
 "subtests": {
-"testChangeWindowSize": {
-"expected": {"all": {"status": ["FAIL"], "bug": "webkit.org/b/181728"}}
-},
 "testGetLogTypes": {
 "expected": {"all": {"status": ["SKIP"]}}
 },
@@ -75,9 +72,6 @@
 },
 "imported/selen

[webkit-changes] [227407] trunk/LayoutTests

[commit-queue]

Title: [227407] trunk/LayoutTests








Revision 227407
Author commit-qu...@webkit.org
Date 2018-01-23 01:26:31 -0800 (Tue, 23 Jan 2018)


Log Message
Mark some service-worker fetch tests as DumpJSConsoleLogInStdErr
https://bugs.webkit.org/show_bug.cgi?id=181975

Unreviewed.

Patch by Youenn Fablet  on 2018-01-23

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (227406 => 227407)

--- trunk/LayoutTests/ChangeLog	2018-01-23 07:11:37 UTC (rev 227406)
+++ trunk/LayoutTests/ChangeLog	2018-01-23 09:26:31 UTC (rev 227407)
@@ -1,3 +1,12 @@
+2018-01-23  Youenn Fablet  
+
+Mark some service-worker fetch tests as DumpJSConsoleLogInStdErr
+https://bugs.webkit.org/show_bug.cgi?id=181975
+
+Unreviewed.
+
+* TestExpectations:
+
 2018-01-22  Simon Fraser  
 
 Optimize building the non-fast scrollable region with multiple iframes


Modified: trunk/LayoutTests/TestExpectations (227406 => 227407)

--- trunk/LayoutTests/TestExpectations	2018-01-23 07:11:37 UTC (rev 227406)
+++ trunk/LayoutTests/TestExpectations	2018-01-23 09:26:31 UTC (rev 227407)
@@ -178,9 +178,9 @@
 imported/w3c/web-platform-tests/streams/readable-byte-streams/detached-buffers.serviceworker.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/update.https.html [ Pass Failure ]
 
-webkit.org/b/181901 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ Pass Failure ]
-webkit.org/b/181897 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ Pass Failure ]
-webkit.org/b/181900 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ Pass Failure ]
+webkit.org/b/181901 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html [ DumpJSConsoleLogInStdErr Pass Failure ]
+webkit.org/b/181897 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https.html [ DumpJSConsoleLogInStdErr Pass Failure ]
+webkit.org/b/181900 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https.html [ DumpJSConsoleLogInStdErr Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html [ DumpJSConsoleLogInStdErr ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/service-workers/service-worker/getregistrations.https.html [ Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes