date:20180312

[webkit-changes] [229573] trunk/Source

2018-03-12 Thread dino

Title: [229573] trunk/Source








Revision 229573
Author d...@apple.com
Date 2018-03-12 21:11:06 -0700 (Mon, 12 Mar 2018)


Log Message
Add a WKWebViewContentProvider for system previews
https://bugs.webkit.org/show_bug.cgi?id=183582


Reviewed by Tim Horton.

Source/WebCore/PAL:

Add some QuickLook SPI.

* pal/spi/ios/QuickLookSPI.h:

Source/WebKit:

Implement WKSystemPreviewView, which conforms to WKWebViewContentProvider, in
order to view content as a "system preview". This effectively replaces the
SystemPreviewController, which will be removed soon.

Some of the required methods of WKWebViewContentProvider are not necessary on
this instance, so a follow-up patch will clean the protocol up a bit.

* UIProcess/Cocoa/NavigationState.mm: Don't trigger a SystemPreview when downloading.
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):

* UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry init]): Register the WKSystemPreviewView for
MIME types retrieved from WebKitAdditions.

* UIProcess/ios/WKSystemPreviewView.h: Added.
* UIProcess/ios/WKSystemPreviewView.mm: Added.

(-[WKSystemPreviewView web_initWithFrame:webView:]):
(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]): This is the
method that actually creates a QuickLook preview and provides the data.
(-[WKSystemPreviewView web_setMinimumSize:]):
(-[WKSystemPreviewView web_setOverlaidAccessoryViewsInset:]):
(-[WKSystemPreviewView web_computedContentInsetDidChange]):
(-[WKSystemPreviewView web_setFixedOverlayView:]):
(-[WKSystemPreviewView web_didSameDocumentNavigation:]):
(-[WKSystemPreviewView web_countStringMatches:options:maxCount:]):
(-[WKSystemPreviewView web_findString:options:maxCount:]):
(-[WKSystemPreviewView web_hideFindUI]):

(-[WKSystemPreviewView numberOfPreviewItemsInPreviewController:]): QuickLook delegates.
(-[WKSystemPreviewView previewController:previewItemAtIndex:]):
(-[WKSystemPreviewView provideDataForItem:]):
(-[WKSystemPreviewView previewControllerWillDismiss:]):

* WebKit.xcodeproj/project.pbxproj: Add new files.

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/ios/QuickLookSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.h
trunk/Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (229572 => 229573)

--- trunk/Source/WebCore/PAL/ChangeLog	2018-03-13 03:19:21 UTC (rev 229572)
+++ trunk/Source/WebCore/PAL/ChangeLog	2018-03-13 04:11:06 UTC (rev 229573)
@@ -1,3 +1,15 @@
+2018-03-12  Dean Jackson  
+
+Add a WKWebViewContentProvider for system previews
+https://bugs.webkit.org/show_bug.cgi?id=183582
+
+
+Reviewed by Tim Horton.
+
+Add some QuickLook SPI.
+
+* pal/spi/ios/QuickLookSPI.h:
+
 2018-03-12  Don Olmstead  
 
 [CMake][Win] Forwarding headers of WTF and PAL are copied twice in Visual Studio builds


Modified: trunk/Source/WebCore/PAL/pal/spi/ios/QuickLookSPI.h (229572 => 229573)

--- trunk/Source/WebCore/PAL/pal/spi/ios/QuickLookSPI.h	2018-03-13 03:19:21 UTC (rev 229572)
+++ trunk/Source/WebCore/PAL/pal/spi/ios/QuickLookSPI.h	2018-03-13 04:11:06 UTC (rev 229573)
@@ -34,6 +34,9 @@
 @interface QLPreviewConverter : NSObject
 @end
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wnullability-completeness"
+
 @interface QLPreviewConverter ()
 - (NSURLRequest *)safeRequestForRequest:(NSURLRequest *)request;
 - (id)initWithConnection:(NSURLConnection *)connection delegate:(id)delegate response:(NSURLResponse *)response options:(NSDictionary *)options;
@@ -47,6 +50,17 @@
 @property (readonly, nonatomic) NSURLResponse *previewResponse;
 @end
 
+@class QLItem;
+
+@protocol QLPreviewItemDataProvider 
+- (NSData *)provideDataForItem:(QLItem *)item;
+@end
+
+@interface QLItem : NSObject
+- (instancetype)initWithDataProvider:(id _Nonnull)data contentType:(NSString *_Nonnull)contentType previewTitle:(NSString *_Nonnull)previewTitle;
+@end
+
+
 #if __IPHONE_OS_VERSION_MIN_REQUIRED >= 11
 #define kQLReturnPasswordProtected 1 << 2
 #else
@@ -70,3 +84,5 @@
 NSString *QLTypeCopyUTIForURLAndMimeType(NSURL *, NSString *mimeType);
 
 WTF_EXTERN_C_END
+
+#pragma clang diagnostic pop


Modified: trunk/Source/WebKit/ChangeLog (229572 => 229573)

--- trunk/Source/WebKit/ChangeLog	2018-03-13 03:19:21 UTC (rev 229572)
+++ trunk/Source/WebKit/ChangeLog	2018-03-13 04:11:06 UTC (rev 229573)
@@ -1,3 +1,47 @@
+2018-03-12  Dean Jackson  
+
+Add a WKWebViewContentProvider for system previews
+https://bugs.webkit.org/show_bug.cgi?id=183582
+
+
+Reviewed by Tim Horton.
+
+Implement

[webkit-changes] [229571] trunk/Source/WTF

2018-03-12 Thread utatane . tea

Title: [229571] trunk/Source/WTF








Revision 229571
Author utatane@gmail.com
Date 2018-03-12 20:10:44 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed, include time.h
https://bugs.webkit.org/show_bug.cgi?id=183312

Attempt to fix oss-fuzz build.

* wtf/CurrentTime.cpp:
* wtf/unix/CPUTimeUnix.cpp:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CurrentTime.cpp
trunk/Source/WTF/wtf/unix/CPUTimeUnix.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (229570 => 229571)

--- trunk/Source/WTF/ChangeLog	2018-03-13 03:04:25 UTC (rev 229570)
+++ trunk/Source/WTF/ChangeLog	2018-03-13 03:10:44 UTC (rev 229571)
@@ -1,3 +1,13 @@
+2018-03-12  Yusuke Suzuki  
+
+Unreviewed, include time.h
+https://bugs.webkit.org/show_bug.cgi?id=183312
+
+Attempt to fix oss-fuzz build.
+
+* wtf/CurrentTime.cpp:
+* wtf/unix/CPUTimeUnix.cpp:
+
 2018-03-12  Yoav Weiss  
 
 Runtime flag for link prefetch and remove link subresource.


Modified: trunk/Source/WTF/wtf/CurrentTime.cpp (229570 => 229571)

--- trunk/Source/WTF/wtf/CurrentTime.cpp	2018-03-13 03:04:25 UTC (rev 229570)
+++ trunk/Source/WTF/wtf/CurrentTime.cpp	2018-03-13 03:10:44 UTC (rev 229571)
@@ -34,6 +34,7 @@
 #include "config.h"
 #include "MonotonicTime.h"
 #include "WallTime.h"
+#include 
 
 #if OS(DARWIN)
 #include 
@@ -49,7 +50,6 @@
 #include 
 #include 
 #include 
-#include 
 #else
 #include 
 #endif


Modified: trunk/Source/WTF/wtf/unix/CPUTimeUnix.cpp (229570 => 229571)

--- trunk/Source/WTF/wtf/unix/CPUTimeUnix.cpp	2018-03-13 03:04:25 UTC (rev 229570)
+++ trunk/Source/WTF/wtf/unix/CPUTimeUnix.cpp	2018-03-13 03:10:44 UTC (rev 229571)
@@ -28,6 +28,7 @@
 
 #include 
 #include 
+#include 
 
 namespace WTF {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229570] trunk/Source/JavaScriptCore

2018-03-12 Thread utatane . tea

Title: [229570] trunk/Source/_javascript_Core








Revision 229570
Author utatane@gmail.com
Date 2018-03-12 20:04:25 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed, fix obsolete ASSERT
https://bugs.webkit.org/show_bug.cgi?id=183310

Now NewObject can be conereted from CallObjectConstructor and CreateThis.

* dfg/DFGNode.h:
(JSC::DFG::Node::convertToNewObject):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGNode.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (229569 => 229570)

--- trunk/Source/_javascript_Core/ChangeLog	2018-03-13 02:05:56 UTC (rev 229569)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-03-13 03:04:25 UTC (rev 229570)
@@ -1,3 +1,13 @@
+2018-03-12  Yusuke Suzuki  
+
+Unreviewed, fix obsolete ASSERT
+https://bugs.webkit.org/show_bug.cgi?id=183310
+
+Now NewObject can be conereted from CallObjectConstructor and CreateThis.
+
+* dfg/DFGNode.h:
+(JSC::DFG::Node::convertToNewObject):
+
 2018-03-12  Tim Horton  
 
 Stop using SDK conditionals to control feature definitions


Modified: trunk/Source/_javascript_Core/dfg/DFGNode.h (229569 => 229570)

--- trunk/Source/_javascript_Core/dfg/DFGNode.h	2018-03-13 02:05:56 UTC (rev 229569)
+++ trunk/Source/_javascript_Core/dfg/DFGNode.h	2018-03-13 03:04:25 UTC (rev 229570)
@@ -726,7 +726,7 @@
 
 void convertToNewObject(RegisteredStructure structure)
 {
-ASSERT(m_op == CallObjectConstructor);
+ASSERT(m_op == CallObjectConstructor || m_op == CreateThis);
 setOpAndDefaultFlags(NewObject);
 children.reset();
 m_opInfo = structure;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229569] trunk/Source

2018-03-12 Thread wilander

Title: [229569] trunk/Source

Revision 229569
Author wilan...@apple.com
Date 2018-03-12 19:05:56 -0700 (Mon, 12 Mar 2018)

Log Message
Resource Load Statistics: Immediately forward cookie access at user interaction when there's an opener document
https://bugs.webkit.org/show_bug.cgi?id=183577

Reviewed by Brent Fulgham.

Source/WebCore:

Tested manually on live websites.
No new automated tests because of a bug in WebKitTestRunner:
https://bugs.webkit.org/show_bug.cgi?id=183578
The event sender triggers gestures in the opener rather than
in the popup.

* dom/Document.cpp:
(WebCore::Document::removedLastRef):
Clears the new m_primaryDomainsGrantedPageSpecificStorageAccess.
(WebCore::Document::hasGrantedPageSpecificStorageAccess):
(WebCore::Document::setHasGrantedPageSpecificStorageAccess):
* dom/Document.h:
Added member m_primaryDomainsGrantedPageSpecificStorageAccess
where we store domains that have been granted access.
* loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::setGrantStorageAccessUnderOpenerCallback):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
Now checks if there is a cross-origin opener and if so, immediately
grants cookie access to the popup's domain if it is partitioned or
blocked.
* loader/ResourceLoadObserver.h:
* platform/network/NetworkStorageSession.h:
Added member m_pagesGrantedStorageAccess.
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::cookieStoragePartition const):
(WebCore::NetworkStorageSession::hasStorageAccess const):
Renamed from hasStorageAccessForFrame since the frameID now is optional.
(WebCore::NetworkStorageSession::grantStorageAccess):
Renamed from grantStorageAccessForFrame since the frameID now is optional.
(WebCore::NetworkStorageSession::removeStorageAccessForAllFramesOnPage):
Now removes the pageID entry in m_pagesGrantedStorageAccess.
(WebCore::NetworkStorageSession::hasStorageAccessForFrame const): Deleted.
Renamed since the frameID now is optional.
(WebCore::NetworkStorageSession::grantStorageAccessForFrame): Deleted.
Renamed since the frameID now is optional.

Source/WebKit:

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::hasStorageAccessForFrame):
Now also checks for general page access.
(WebKit::NetworkProcess::grantStorageAccess):
Renamed from grantStorageAccessForFrame since the frameID now is optional.
(WebKit::NetworkProcess::grantStorageAccessForFrame): Deleted.
Renamed since the frameID now is optional.
* NetworkProcess/NetworkProcess.h:
Renaming since the frameID now is optional.
* NetworkProcess/NetworkProcess.messages.in:
Renaming since the frameID now is optional.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::logCookieInformation):
Consequence of function renaming.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::grantStorageAccess):
(WebKit::NetworkProcessProxy::grantStorageAccessForFrame): Deleted.
Renaming since the frameID now is optional.
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
Renaming since the frameID now is optional.
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
Handler renaming since the frameID now is optional.
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessUnderOpener):
New function for that grants cookie access under a whole page.
* UIProcess/WebResourceLoadStatisticsStore.h:
Member renaming since the frameID now is optional.
* UIProcess/WebResourceLoadStatisticsStore.messages.in:
New message received straight from WebCore::ResourceLoadObserver.
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::grantStorageAccessHandler):
Renamed and made frameID optional.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
Consequence of renaming and making frameID optional.
(WebKit::WebsiteDataStore::grantStorageAccessForFrameHandler): Deleted.
Renamed and made frameID optional.
* UIProcess/WebsiteData/WebsiteDataStore.h:
* WebProcess/WebProcess.cpp:
(WebProcess::WebProcess):
Now calls setGrantStorageAccessUnderOpenerCallback() on the shared
WebCore::ResourceLoadObserver.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/loader/ResourceLoadObserver.cpp
trunk/Source/WebCore/loader/ResourceLoadObserver.h
trunk/Source/WebCore/platform/network/NetworkStorageSession.h
trunk/Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.messages.in

[webkit-changes] [229568] tags/Safari-606.1.9/Source/WebCore

2018-03-12 Thread jmarcell

Title: [229568] tags/Safari-606.1.9/Source/WebCore








Revision 229568
Author jmarc...@apple.com
Date 2018-03-12 18:54:14 -0700 (Mon, 12 Mar 2018)


Log Message
Cherry-pick r229564. rdar://problem/38395317

Modified Paths

tags/Safari-606.1.9/Source/WebCore/ChangeLog
tags/Safari-606.1.9/Source/WebCore/editing/TextIterator.cpp
tags/Safari-606.1.9/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp
tags/Safari-606.1.9/Source/WebCore/platform/text/TextEncoding.cpp




Diff

Modified: tags/Safari-606.1.9/Source/WebCore/ChangeLog (229567 => 229568)

--- tags/Safari-606.1.9/Source/WebCore/ChangeLog	2018-03-13 01:38:34 UTC (rev 229567)
+++ tags/Safari-606.1.9/Source/WebCore/ChangeLog	2018-03-13 01:54:14 UTC (rev 229568)
@@ -1,3 +1,23 @@
+2018-03-12  Jason Marcell  
+
+Cherry-pick r229564. rdar://problem/38395317
+
+2018-03-12  Brian Burg  
+
+Ignore some deprecation warnings encountered when compiling with newer versions of ICU
+https://bugs.webkit.org/show_bug.cgi?id=183584
+
+
+Reviewed by Daniel Bates.
+
+Ignore new deprecation warnings. Where a function has more than one
+deprecation warning, mark out the entire function so it remains readable.
+
+* editing/TextIterator.cpp:
+* platform/graphics/SurrogatePairAwareTextIterator.cpp:
+(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
+* platform/text/TextEncoding.cpp:
+
 2018-03-12  Javier Fernandez  
 
 Remove GridLayout runtime flag


Modified: tags/Safari-606.1.9/Source/WebCore/editing/TextIterator.cpp (229567 => 229568)

--- tags/Safari-606.1.9/Source/WebCore/editing/TextIterator.cpp	2018-03-13 01:38:34 UTC (rev 229567)
+++ tags/Safari-606.1.9/Source/WebCore/editing/TextIterator.cpp	2018-03-13 01:54:14 UTC (rev 229568)
@@ -1999,6 +1999,12 @@
 return false;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_normalize function is deprecated in some SDKs.
+
 static void normalizeCharacters(const UChar* characters, unsigned length, Vector& buffer)
 {
 ASSERT(length);
@@ -2020,6 +2026,10 @@
 ASSERT(status == U_STRING_NOT_TERMINATED_WARNING);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 static bool isNonLatin1Separator(UChar32 character)
 {
 ASSERT_ARG(character, character >= 256);


Modified: tags/Safari-606.1.9/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp (229567 => 229568)

--- tags/Safari-606.1.9/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp	2018-03-13 01:38:34 UTC (rev 229567)
+++ tags/Safari-606.1.9/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp	2018-03-13 01:54:14 UTC (rev 229568)
@@ -69,6 +69,12 @@
 return true;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_normalize function is deprecated in some SDKs.
+
 UChar32 SurrogatePairAwareTextIterator::normalizeVoicingMarks()
 {
 // According to http://www.unicode.org/Public/UNIDATA/UCD.html#Canonical_Combining_Class_Values
@@ -89,4 +95,8 @@
 return 0;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 }


Modified: tags/Safari-606.1.9/Source/WebCore/platform/text/TextEncoding.cpp (229567 => 229568)

--- tags/Safari-606.1.9/Source/WebCore/platform/text/TextEncoding.cpp	2018-03-13 01:38:34 UTC (rev 229567)
+++ tags/Safari-606.1.9/Source/WebCore/platform/text/TextEncoding.cpp	2018-03-13 01:54:14 UTC (rev 229568)
@@ -69,6 +69,12 @@
 return newTextCodec(*this)->decode(data, length, true, stopOnError, sawError);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_quickCheck and unorm_normalize functions are deprecated in some SDKs.
+
 Vector TextEncoding::encode(StringView text, UnencodableHandling handling) const
 {
 if (!m_name || text.isEmpty())
@@ -106,6 +112,10 @@
 return newTextCodec(*this)->encode(StringView { source, sourceLength }, handling);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 const char* TextEncoding::domName() const
 {
 if (noExtendedTextEncodingNameUsed())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229566] trunk

2018-03-12 Thread cdumez

Title: [229566] trunk








Revision 229566
Author cdu...@apple.com
Date 2018-03-12 18:37:23 -0700 (Mon, 12 Mar 2018)


Log Message
Return boolean from DOMTokenList's replace() method
https://bugs.webkit.org/show_bug.cgi?id=183567

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline web platform test now that all checks are passing.

* web-platform-tests/dom/nodes/Element-classlist-expected.txt:

Source/WebCore:

Have DOMTokenList's replace() method return a boolean indicating if the
token was replaced, as per:
- https://dom.spec.whatwg.org/#dom-domtokenlist-replace

This is a recent addition to the DOM specification:
- https://github.com/whatwg/dom/pull/582

No new tests, rebaselined existing test.

* html/DOMTokenList.cpp:
(WebCore::replaceInOrderedSet):
(WebCore::DOMTokenList::replace):
* html/DOMTokenList.h:
* html/DOMTokenList.idl:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/DOMTokenList.cpp
trunk/Source/WebCore/html/DOMTokenList.h
trunk/Source/WebCore/html/DOMTokenList.idl




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (229565 => 229566)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-03-13 01:29:46 UTC (rev 229565)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-03-13 01:37:23 UTC (rev 229566)
@@ -1,3 +1,14 @@
+2018-03-12  Chris Dumez  
+
+Return boolean from DOMTokenList's replace() method
+https://bugs.webkit.org/show_bug.cgi?id=183567
+
+Reviewed by Youenn Fablet.
+
+Rebaseline web platform test now that all checks are passing.
+
+* web-platform-tests/dom/nodes/Element-classlist-expected.txt:
+
 2018-03-12  Ryan Haddad  
 
 Unreviewed, rebaseline two cssom tests after r229544.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt (229565 => 229566)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt	2018-03-13 01:29:46 UTC (rev 229565)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt	2018-03-13 01:37:23 UTC (rev 229566)
@@ -258,31 +258,31 @@
 PASS classList.replace("b", "a\r") with attribute value null (HTML node) 
 PASS classList.replace("b", " a") with attribute value null (HTML node) 
 PASS classList.replace("b", "a ") with attribute value null (HTML node) 
-FAIL classList.replace("a", "a") with attribute value "a" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value "a" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("A", "b") with attribute value "a" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("b", "A") with attribute value "a b" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("c", "a") with attribute value "a b" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("d", "e") with attribute value "a b c" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "a") with attribute value "a a a  b" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("c", "d") with attribute value "a a a  b" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value null (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value "" (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value " " (HTML node) assert_equals: wrong return value expected (boolean) false but got (undefined) undefined
-FAIL classList.replace("a", "b") with attribute value " a  \f" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("b", "d") with attribute value "a b c" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("c", "a") with attribute value "a b c" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("c", "a") with attribute value "c b a" (HTML node) assert_equals: wrong return value expected (boolean) true but got (undefined) undefined
-FAIL classList.replace("a", "c")

[webkit-changes] [229565] trunk/Tools

2018-03-12 Thread ross . kirsling

Title: [229565] trunk/Tools








Revision 229565
Author ross.kirsl...@sony.com
Date 2018-03-12 18:29:46 -0700 (Mon, 12 Mar 2018)


Log Message
[DRT] TestOptions should not be ObjC.
https://bugs.webkit.org/show_bug.cgi?id=183487

Reviewed by Per Arne Vollan.

* DumpRenderTree/CMakeLists.txt:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/PlatformMac.cmake:
Move TestOptions to platform-agnostic sources.

* DumpRenderTree/TestOptions.h:
* DumpRenderTree/TestOptions.cpp: Renamed from Tools/DumpRenderTree/TestOptions.mm.
* DumpRenderTree/mac/DumpRenderTree.mm:
Remove NSURL dependency and align with WTR as much as possible.

* DumpRenderTree/win/DumpRenderTree.cpp:
Consume TestOptions (recognizing just the ones that have WebPreferences defined for now).

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/CMakeLists.txt
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/DumpRenderTree/PlatformMac.cmake
trunk/Tools/DumpRenderTree/TestOptions.h
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp


Added Paths

trunk/Tools/DumpRenderTree/TestOptions.cpp


Removed Paths

trunk/Tools/DumpRenderTree/TestOptions.mm




Diff

Modified: trunk/Tools/ChangeLog (229564 => 229565)

--- trunk/Tools/ChangeLog	2018-03-12 23:46:06 UTC (rev 229564)
+++ trunk/Tools/ChangeLog	2018-03-13 01:29:46 UTC (rev 229565)
@@ -1,3 +1,23 @@
+2018-03-12  Ross Kirsling  
+
+[DRT] TestOptions should not be ObjC.
+https://bugs.webkit.org/show_bug.cgi?id=183487
+
+Reviewed by Per Arne Vollan.
+
+* DumpRenderTree/CMakeLists.txt:
+* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+* DumpRenderTree/PlatformMac.cmake:
+Move TestOptions to platform-agnostic sources.
+
+* DumpRenderTree/TestOptions.h:
+* DumpRenderTree/TestOptions.cpp: Renamed from Tools/DumpRenderTree/TestOptions.mm.
+* DumpRenderTree/mac/DumpRenderTree.mm:
+Remove NSURL dependency and align with WTR as much as possible.
+
+* DumpRenderTree/win/DumpRenderTree.cpp:
+Consume TestOptions (recognizing just the ones that have WebPreferences defined for now).
+
 2018-03-12  Yoav Weiss  
 
 Runtime flag for link prefetch and remove link subresource.


Modified: trunk/Tools/DumpRenderTree/CMakeLists.txt (229564 => 229565)

--- trunk/Tools/DumpRenderTree/CMakeLists.txt	2018-03-12 23:46:06 UTC (rev 229564)
+++ trunk/Tools/DumpRenderTree/CMakeLists.txt	2018-03-13 01:29:46 UTC (rev 229565)
@@ -13,6 +13,7 @@
 GCController.cpp
 _javascript_Threading.cpp
 PixelDumpSupport.cpp
+TestOptions.cpp
 TestRunner.cpp
 WorkQueue.cpp
 ${WEBKIT_TESTRUNNER_UISCRIPTCONTEXT_DIR}/UIScriptContext.cpp


Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (229564 => 229565)

--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2018-03-12 23:46:06 UTC (rev 229564)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj	2018-03-13 01:29:46 UTC (rev 229565)
@@ -101,7 +101,6 @@
 		5DB9AC9E0F722C3600684641 /* WebKitWeightWatcher700.ttf in Copy Font Files */ = {isa = PBXBuildFile; fileRef = 375F09770DAC3CB600C8B4E5 /* WebKitWeightWatcher700.ttf */; };
 		5DB9AC9F0F722C3600684641 /* WebKitWeightWatcher800.ttf in Copy Font Files */ = {isa = PBXBuildFile; fileRef = 375F09780DAC3CB600C8B4E5 /* WebKitWeightWatcher800.ttf */; };
 		5DB9ACA00F722C3600684641 /* WebKitWeightWatcher900.ttf in Copy Font Files */ = {isa = PBXBuildFile; fileRef = 375F09790DAC3CB600C8B4E5 /* WebKitWeightWatcher900.ttf */; };
-		7CBBC3231DDFCF9A00786B9D /* TestOptions.mm in Sources */ = {isa = PBXBuildFile; fileRef = 7CBBC3211DDFCF9A00786B9D /* TestOptions.mm */; };
 		80045AEE147718E7008290A8 /* AccessibilityNotificationHandler.mm in Sources */ = {isa = PBXBuildFile; fileRef = 80045AEC147718E7008290A8 /* AccessibilityNotificationHandler.mm */; };
 		8465E2C70FFA8DF2003B8342 /* PixelDumpSupport.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 8465E2C60FFA8DF2003B8342 /* PixelDumpSupport.cpp */; };
 		9830F31F15C81181005AB206 /* DumpRenderTreeCommon.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9830F31E15C81181005AB206 /* DumpRenderTreeCommon.cpp */; };
@@ -109,6 +108,7 @@
 		A1158D59189274360088C17B /* PixelDumpSupportIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = A1158D57189273EB0088C17B /* PixelDumpSupportIOS.mm */; };
 		A134E531188FC27000901D06 /* DumpRenderTreeMain.mm in Sources */ = {isa = PBXBuildFile; fileRef = A134E52F188FC27000901D06 /* DumpRenderTreeMain.mm */; };
 		A134E53618905EFF00901D06 /* AccessibilityCommonMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = BC0E26140E2DA4C6001B6BC3 /* AccessibilityCommonMac.mm */; };
+		A30A21F82051D8C40008FF42 /* TestOptions.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A30A21F72051D8960008FF42 /* TestOptions.cpp */; };

[webkit-changes] [229564] trunk/Source/WebCore

2018-03-12 Thread bburg

Title: [229564] trunk/Source/WebCore








Revision 229564
Author bb...@apple.com
Date 2018-03-12 16:46:06 -0700 (Mon, 12 Mar 2018)


Log Message
Ignore some deprecation warnings encountered when compiling with newer versions of ICU
https://bugs.webkit.org/show_bug.cgi?id=183584


Reviewed by Daniel Bates.

Ignore new deprecation warnings. Where a function has more than one
deprecation warning, mark out the entire function so it remains readable.

* editing/TextIterator.cpp:
* platform/graphics/SurrogatePairAwareTextIterator.cpp:
(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
* platform/text/TextEncoding.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/TextIterator.cpp
trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp
trunk/Source/WebCore/platform/text/TextEncoding.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (229563 => 229564)

--- trunk/Source/WebCore/ChangeLog	2018-03-12 23:28:45 UTC (rev 229563)
+++ trunk/Source/WebCore/ChangeLog	2018-03-12 23:46:06 UTC (rev 229564)
@@ -1,3 +1,19 @@
+2018-03-12  Brian Burg  
+
+Ignore some deprecation warnings encountered when compiling with newer versions of ICU
+https://bugs.webkit.org/show_bug.cgi?id=183584
+
+
+Reviewed by Daniel Bates.
+
+Ignore new deprecation warnings. Where a function has more than one
+deprecation warning, mark out the entire function so it remains readable.
+
+* editing/TextIterator.cpp:
+* platform/graphics/SurrogatePairAwareTextIterator.cpp:
+(WebCore::SurrogatePairAwareTextIterator::normalizeVoicingMarks):
+* platform/text/TextEncoding.cpp:
+
 2018-03-12  Yoav Weiss  
 
 Runtime flag for link prefetch and remove link subresource.


Modified: trunk/Source/WebCore/editing/TextIterator.cpp (229563 => 229564)

--- trunk/Source/WebCore/editing/TextIterator.cpp	2018-03-12 23:28:45 UTC (rev 229563)
+++ trunk/Source/WebCore/editing/TextIterator.cpp	2018-03-12 23:46:06 UTC (rev 229564)
@@ -1999,6 +1999,12 @@
 return false;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_normalize function is deprecated in some SDKs.
+
 static void normalizeCharacters(const UChar* characters, unsigned length, Vector& buffer)
 {
 ASSERT(length);
@@ -2020,6 +2026,10 @@
 ASSERT(status == U_STRING_NOT_TERMINATED_WARNING);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 static bool isNonLatin1Separator(UChar32 character)
 {
 ASSERT_ARG(character, character >= 256);


Modified: trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp (229563 => 229564)

--- trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp	2018-03-12 23:28:45 UTC (rev 229563)
+++ trunk/Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp	2018-03-12 23:46:06 UTC (rev 229564)
@@ -69,6 +69,12 @@
 return true;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_normalize function is deprecated in some SDKs.
+
 UChar32 SurrogatePairAwareTextIterator::normalizeVoicingMarks()
 {
 // According to http://www.unicode.org/Public/UNIDATA/UCD.html#Canonical_Combining_Class_Values
@@ -89,4 +95,8 @@
 return 0;
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 }


Modified: trunk/Source/WebCore/platform/text/TextEncoding.cpp (229563 => 229564)

--- trunk/Source/WebCore/platform/text/TextEncoding.cpp	2018-03-12 23:28:45 UTC (rev 229563)
+++ trunk/Source/WebCore/platform/text/TextEncoding.cpp	2018-03-12 23:46:06 UTC (rev 229564)
@@ -69,6 +69,12 @@
 return newTextCodec(*this)->decode(data, length, true, stopOnError, sawError);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
+#endif
+// NOTE: ICU's unorm_quickCheck and unorm_normalize functions are deprecated in some SDKs.
+
 Vector TextEncoding::encode(StringView text, UnencodableHandling handling) const
 {
 if (!m_name || text.isEmpty())
@@ -106,6 +112,10 @@
 return newTextCodec(*this)->encode(StringView { source, sourceLength }, handling);
 }
 
+#if COMPILER(CLANG)
+#pragma clang diagnostic pop
+#endif
+
 const char* TextEncoding::domName() const
 {
 if (noExtendedTextEncodingNameUsed())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229563] trunk

2018-03-12 Thread yoav

Title: [229563] trunk








Revision 229563
Author y...@yoav.ws
Date 2018-03-12 16:28:45 -0700 (Mon, 12 Mar 2018)


Log Message
Runtime flag for link prefetch and remove link subresource.
https://bugs.webkit.org/show_bug.cgi?id=183540

Reviewed by Chris Dumez.

.:

Remove the LINK_PREFETCH build time flag.

* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/_javascript_Core:

Remove the LINK_PREFETCH build time flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This patch removes the LINK_PREFETCH build time flag, removes
link subresource, adds an off-by-default runtime flag for link
prefetch and makes sure link prefetch only works when this flag is on.

Subresource is removed as it's not a part of any spec, nor supported by any
other browser. It was replaced by link preload.

No new tests as this is not adding any new functionality.

* Configurations/FeatureDefines.xcconfig: Remove the LINK_PREFETCH flag.
* html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute): Put prefetch support behind the runtime flag.
(WebCore::LinkRelAttribute::isSupported): Add prefetch.
* html/LinkRelAttribute.h: Remove the LINK_PREFETCH flag.
* loader/LinkLoader.cpp:
(WebCore::createLinkPreloadResourceClient): Remove the LINK_PREFETCH flag.
(WebCore::LinkLoader::prefetchIfNeeded): Move the prefetch code to `prefetchIfNeeded()`. Remove subresource bits.
(WebCore::LinkLoader::loadLink): Call `prefetchIfNeeded()`.
* loader/LinkLoader.h:
* loader/ResourceLoadInfo.cpp:
(WebCore::toResourceType): Remove the LINK_PREFETCH flag as well as subresource.
* loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded): Remove the LINK_PREFETCH flag as well as subresource.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::defaultPriorityForResourceType): Remove the LINK_PREFETCH flag as well as subresource.
(WebCore::CachedResource::load): Remove the LINK_PREFETCH flag.
* loader/cache/CachedResource.h:
(WebCore::CachedResource::ignoreForRequestCount const): Remove the LINK_PREFETCH flag as well as subresource.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource): Remove the LINK_PREFETCH flag as well as subresource.
(WebCore::CachedResourceLoader::requestLinkResource): Remove subresource.
(WebCore::contentTypeFromResourceType): Remove the LINK_PREFETCH flag as well as subresource.
(WebCore::CachedResourceLoader::checkInsecureContent const): Remove the LINK_PREFETCH flag as well as subresource.
(WebCore::CachedResourceLoader::shouldUpdateCachedResourceWithCurrentRequest): Remove the LINK_PREFETCH flag as well as subresource.
* loader/cache/CachedResourceLoader.h:
* page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setLinkPrefetchEnabled): Set the prefetch flag.
(WebCore::RuntimeEnabledFeatures::linkPrefetchEnabled const): Get the prefetch flag.

Source/WebCore/PAL:

Remove the LINK_PREFETCH build time flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Remove the LINK_PREFETCH build time flag.

* Configurations/FeatureDefines.xcconfig:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime):

Source/WebKitLegacy/mac:

Remove the LINK_PREFETCH build time flag.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Remove the LINK_PREFETCH build time flag.

* wtf/FeatureDefines.h:

Tools:

Remove the LINK_PREFETCH build time flag.

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/html/LinkRelAttribute.cpp
trunk/Source/WebCore/html/LinkRelAttribute.h
trunk/Source/WebCore/loader/LinkLoader.cpp
trunk/Source/WebCore/loader/LinkLoader.h
trunk/Source/WebCore/loader/ResourceLoadInfo.cpp
trunk/Source/WebCore/loader/SubresourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceLoader.h
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/cmake/OptionsWin.cmake
trunk/Source/cmake/WebKitFeatures.cmake
trunk/Source/cmake/tools/vsprops/FeatureDefines.props
trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props
trunk/Tools/ChangeLog

[webkit-changes] [229562] trunk/Source

2018-03-12 Thread jmarcell

Title: [229562] trunk/Source








Revision 229562
Author jmarc...@apple.com
Date 2018-03-12 16:21:32 -0700 (Mon, 12 Mar 2018)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (229561 => 229562)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-12 23:21:32 UTC (rev 229562)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229561] tags/Safari-606.1.9/Source

2018-03-12 Thread jmarcell

Title: [229561] tags/Safari-606.1.9/Source








Revision 229561
Author jmarc...@apple.com
Date 2018-03-12 16:15:25 -0700 (Mon, 12 Mar 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-606.1.9/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-606.1.9/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-606.1.9/Source/_javascript_Core/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/_javascript_Core/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebCore/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebCore/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebCore/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebCore/PAL/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebInspectorUI/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebKit/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebKit/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebKit/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: tags/Safari-606.1.9/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (229560 => 229561)

--- tags/Safari-606.1.9/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-12 23:06:51 UTC (rev 229560)
+++ tags/Safari-606.1.9/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-03-12 23:15:25 UTC (rev 229561)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [229560] trunk

2018-03-12 Thread cdumez

Title: [229560] trunk








Revision 229560
Author cdu...@apple.com
Date 2018-03-12 16:06:51 -0700 (Mon, 12 Mar 2018)


Log Message
Load may get committed before receiving policy for the resource response
https://bugs.webkit.org/show_bug.cgi?id=183579


Reviewed by Youenn Fablet.

Source/WebKit:

r228852 updated WebResourceLoader::didReceiveResponse to only send the
ContinueDidReceiveResponse IPC back to the Networkprocess *after* the
policy decision for the resource response has been made. This is necessary
now that policy decisions can be made asynchronously.

However, one of the 2 code paths in NetworkProcess side (code path when
the resource is already in the HTTP disk cache) failed to wait for the
ContinueDidReceiveResponse IPC before sending over the data to the WebProcess.
As a result, the WebProcess could commit the load before even receiving the
policy response from the client.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
(WebKit::NetworkResourceLoader::continueProcessingCachedEntryAfterDidReceiveResponse):
* NetworkProcess/NetworkResourceLoader.h:
Make sure NetworkResourceLoader::didRetrieveCacheEntry() does not start sending the data
until the network process gets the ContinueDidReceiveResponse IPC back from the WebProcess.

* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
* WebProcess/Network/WebResourceLoader.h:
Add assertion to make sure didReceiveData() never gets called before didReceiveResponse's
completion handler has been called. If this hits, then the load may get committed even
though the client did not reply to the policy for the resource response yet.

LayoutTests:

Add layout test coverage.

* http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt: Added.
* http/tests/cache/cachedEntry-waits-for-response-policy.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.h
trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.cpp
trunk/Source/WebKit/WebProcess/Network/WebResourceLoader.h


Added Paths

trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt
trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy.html




Diff

Modified: trunk/LayoutTests/ChangeLog (229559 => 229560)

--- trunk/LayoutTests/ChangeLog	2018-03-12 23:01:26 UTC (rev 229559)
+++ trunk/LayoutTests/ChangeLog	2018-03-12 23:06:51 UTC (rev 229560)
@@ -1,3 +1,16 @@
+2018-03-12  Chris Dumez  
+
+Load may get committed before receiving policy for the resource response
+https://bugs.webkit.org/show_bug.cgi?id=183579
+
+
+Reviewed by Youenn Fablet.
+
+Add layout test coverage.
+
+* http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt: Added.
+* http/tests/cache/cachedEntry-waits-for-response-policy.html: Added.
+
 2018-03-12  Ali Juma  
 
 http/tests/workers/service/service-worker-download.https.html times out with async policy delegates


Added: trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt (0 => 229560)

--- trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy-expected.txt	2018-03-12 23:06:51 UTC (rev 229560)
@@ -0,0 +1,3 @@
+This test passes if it does not crash.
+
+ 


Added: trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy.html (0 => 229560)

--- trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy.html	(rev 0)
+++ trunk/LayoutTests/http/tests/cache/cachedEntry-waits-for-response-policy.html	2018-03-12 23:06:51 UTC (rev 229560)
@@ -0,0 +1,34 @@
+
+
+
+This test passes if it does not crash.
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+if (testRunner.setShouldDecideNavigationPolicyAfterDelay)
+testRunner.setShouldDecideNavigationPolicyAfterDelay(true);
+if (testRunner.setShouldDecideResponsePolicyAfterDelay)
+testRunner.setShouldDecideResponsePolicyAfterDelay(true);
+}
+function createFrame(url) {
+return new Promise((resolve) => {
+let frame = document.createElement('iframe');
+frame.src = ""
+frame._onload_ = function() { resolve(frame); };
+document.body.appendChild(frame);
+});
+}
+
+createFrame("/cache/resources/cacheable-random-text.php").then(function(frame) {
+frame.remove();
+internals.clearMemoryCache();
+createFrame("/cache/resources/cacheable-random-text.php").then(function(frame) {
+if

[webkit-changes] [229559] trunk/LayoutTests/imported/w3c

2018-03-12 Thread ryanhaddad

Title: [229559] trunk/LayoutTests/imported/w3c








Revision 229559
Author ryanhad...@apple.com
Date 2018-03-12 16:01:26 -0700 (Mon, 12 Mar 2018)


Log Message
Unreviewed, rebaseline two cssom tests after r229544.

* web-platform-tests/cssom-view/interfaces-expected.txt:
* web-platform-tests/cssom/interfaces-expected.txt:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/cssom-view/interfaces-expected.txt




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (229558 => 229559)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-03-12 22:58:54 UTC (rev 229558)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-03-12 23:01:26 UTC (rev 229559)
@@ -1,3 +1,10 @@
+2018-03-12  Ryan Haddad  
+
+Unreviewed, rebaseline two cssom tests after r229544.
+
+* web-platform-tests/cssom-view/interfaces-expected.txt:
+* web-platform-tests/cssom/interfaces-expected.txt:
+
 2018-03-12  Youenn Fablet  
 
 RTCPeerConnection's close method should update signalingState


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt (229558 => 229559)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt	2018-03-12 22:58:54 UTC (rev 229558)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/cssom/interfaces-expected.txt	2018-03-12 23:01:26 UTC (rev 229559)
@@ -1,20 +1,24 @@
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
-CONSOLE MESSAGE: line 251: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
+CONSOLE MESSAGE: line 309: callback not yet supported
 CSSOM IDL tests
 
 
 PASS Test driver 
 PASS HTMLElement interface: attribute style 
+PASS Unscopable handled correctly for style property on HTMLElement 
 PASS HTMLElement interface: style_element must inherit property "style" with the proper type 
 PASS HTMLElement interface: document.createElement('unknownelement') must inherit property "style" with the proper type 
 PASS HTMLLinkElement interface: attribute sheet 
+PASS Unscopable handled correctly for sheet property on HTMLLinkElement 
 PASS HTMLStyleElement interface: attribute sheet 
+PASS Unscopable handled correctly for sheet property on HTMLStyleElement 
 PASS Window interface: operation getComputedStyle(Element, CSSOMString) 
+PASS Unscopable handled correctly for getComputedStyle(Element, CSSOMString) on Window 
 PASS Window interface: window must inherit property "getComputedStyle(Element, CSSOMString)" with the proper type 
 PASS Window interface: calling getComputedStyle(Element, CSSOMString) on window with too few arguments must throw TypeError 
 PASS WorkerGlobalScope interface: existence and properties of interface object 
@@ -23,21 +27,32 @@
 PASS WorkerNavigator interface: existence and properties of interface object 
 PASS WorkerLocation interface: existence and properties of interface object 
 PASS Document interface: attribute styleSheets 
+PASS Unscopable handled correctly for styleSheets property on Document 
 PASS Document interface: document must inherit property "styleSheets" with the proper type 
 PASS Document interface: new Document() must inherit property "styleSheets" with the proper type 
 PASS ProcessingInstruction interface: attribute sheet 
+PASS Unscopable handled correctly for sheet property on ProcessingInstruction 
 PASS ProcessingInstruction interface: xmlss_pi must inherit property "sheet" with the proper type 
+PASS SVGElement interface: attribute style 
+PASS Unscopable handled correctly for style property on SVGElement 
+PASS SVGElement interface: svg_element must inherit property "style" with the proper type 
 PASS MediaList interface: existence and properties of interface object 
 PASS MediaList interface object length 
 PASS MediaList interface object name 
 FAIL MediaList interface: existence and properties of interface prototype object assert_equals: prototype of MediaList.prototype is not Array.prototype expected [] but got object "[object Object]"
 PASS MediaList interface: existence and properties of interface prototype object's "constructor" property 
+PASS MediaList interface: existence and properties of interface prototype object's @@unscopables property 
 PASS MediaList interface: attribute mediaText 
+PASS Unscopable

[webkit-changes] [229558] trunk

2018-03-12 Thread ajuma

Title: [229558] trunk








Revision 229558
Author aj...@chromium.org
Date 2018-03-12 15:58:54 -0700 (Mon, 12 Mar 2018)


Log Message
http/tests/workers/service/service-worker-download.https.html times out with async policy delegates
https://bugs.webkit.org/show_bug.cgi?id=183479

Reviewed by Youenn Fablet.

Source/WebKit:

Ensure that ServiceWorkerFetchClient::m_isCheckingResponse is set before code that depends on it
executes. This bit was set by code that's posted to the runloop using 'callOnMainThread' in
ServiceWorkerFetchClient::didReceiveResponse. But when didReceiveResponse is executing, tasks for
handling didReceiveData, didFail, or didFinish may already have been posted to the runloop, and in
that case would execute before m_isCheckingResponse gets set, and then incorrectly fail to
early-out. Fix this by directly setting m_isCheckingResponse in didReceiveResponse.

* WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::start):
(WebKit::ServiceWorkerClientFetch::didReceiveResponse):

LayoutTests:

Add layout test coverage.

* http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt: Added.
* http/tests/workers/service/service-worker-download-async-delegates.https.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp


Added Paths

trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt
trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https.html




Diff

Modified: trunk/LayoutTests/ChangeLog (229557 => 229558)

--- trunk/LayoutTests/ChangeLog	2018-03-12 22:24:37 UTC (rev 229557)
+++ trunk/LayoutTests/ChangeLog	2018-03-12 22:58:54 UTC (rev 229558)
@@ -1,3 +1,15 @@
+2018-03-12  Ali Juma  
+
+http/tests/workers/service/service-worker-download.https.html times out with async policy delegates
+https://bugs.webkit.org/show_bug.cgi?id=183479
+
+Reviewed by Youenn Fablet.
+
+Add layout test coverage.
+
+* http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt: Added.
+* http/tests/workers/service/service-worker-download-async-delegates.https.html: Added.
+
 2018-03-12  Chris Dumez  
 
 http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates


Added: trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt (0 => 229558)

--- trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https-expected.txt	2018-03-12 22:58:54 UTC (rev 229558)
@@ -0,0 +1,4 @@
+Download started.
+Downloading URL with suggested filename "download-binary.php"
+Download completed.
+


Added: trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https.html (0 => 229558)

--- trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https.html	(rev 0)
+++ trunk/LayoutTests/http/tests/workers/service/service-worker-download-async-delegates.https.html	2018-03-12 22:58:54 UTC (rev 229558)
@@ -0,0 +1,24 @@
+
+
+
+
+