date:20180806

[webkit-changes] [234641] trunk/LayoutTests

2018-08-06 Thread simon . fraser

Title: [234641] trunk/LayoutTests








Revision 234641
Author simon.fra...@apple.com
Date 2018-08-06 20:28:56 -0700 (Mon, 06 Aug 2018)


Log Message
De-flake some animation tests
https://bugs.webkit.org/show_bug.cgi?id=188356

Reviewed by Dean Jackson.

The tests in legacy-animation-engine were flakey because the animation can start before
we get a chance to register the event listener. Fix by starting the animation after the
load event fires. Make the non-legacy tests match.

* compositing/visible-rect/animated-from-none.html:
* compositing/visible-rect/animated.html:
* legacy-animation-engine/compositing/visible-rect/animated-from-none.html:
* legacy-animation-engine/compositing/visible-rect/animated.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/visible-rect/animated-from-none.html
trunk/LayoutTests/compositing/visible-rect/animated.html
trunk/LayoutTests/legacy-animation-engine/compositing/visible-rect/animated-from-none.html
trunk/LayoutTests/legacy-animation-engine/compositing/visible-rect/animated.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234640 => 234641)

--- trunk/LayoutTests/ChangeLog	2018-08-07 01:13:37 UTC (rev 234640)
+++ trunk/LayoutTests/ChangeLog	2018-08-07 03:28:56 UTC (rev 234641)
@@ -1,3 +1,19 @@
+2018-08-06  Simon Fraser  
+
+De-flake some animation tests
+https://bugs.webkit.org/show_bug.cgi?id=188356
+
+Reviewed by Dean Jackson.
+
+The tests in legacy-animation-engine were flakey because the animation can start before
+we get a chance to register the event listener. Fix by starting the animation after the
+load event fires. Make the non-legacy tests match.
+
+* compositing/visible-rect/animated-from-none.html:
+* compositing/visible-rect/animated.html:
+* legacy-animation-engine/compositing/visible-rect/animated-from-none.html:
+* legacy-animation-engine/compositing/visible-rect/animated.html:
+
 2018-08-06  Alex Christensen  
 
 Check with SafeBrowsing during navigation in WKWebView


Modified: trunk/LayoutTests/compositing/visible-rect/animated-from-none.html (234640 => 234641)

--- trunk/LayoutTests/compositing/visible-rect/animated-from-none.html	2018-08-07 01:13:37 UTC (rev 234640)
+++ trunk/LayoutTests/compositing/visible-rect/animated-from-none.html	2018-08-07 03:28:56 UTC (rev 234641)
@@ -34,7 +34,8 @@
 
 function doTest()
 {
-document.getElementById('animated').addEventListener('webkitAnimationStart', function() {
+let animated = document.getElementById('animated');
+animated.addEventListener('webkitAnimationStart', function() {
 if (window.internals)
 document.getElementById('layers').innerText = internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_VISIBLE_RECTS)
 
@@ -41,6 +42,8 @@
 if (window.testRunner)
 testRunner.notifyDone();
 }, false);
+
+animated.classList.add('animating');
 }
 window.addEventListener('load', doTest, false);
 


Modified: trunk/LayoutTests/compositing/visible-rect/animated.html (234640 => 234641)

--- trunk/LayoutTests/compositing/visible-rect/animated.html	2018-08-07 01:13:37 UTC (rev 234640)
+++ trunk/LayoutTests/compositing/visible-rect/animated.html	2018-08-07 03:28:56 UTC (rev 234641)
@@ -17,6 +17,9 @@
 width: 200px;
 height: 200px;
 background-color: blue;
+}
+
+.box.animating {
 -webkit-animation: move 2000s linear;
 }
 
@@ -33,15 +36,16 @@
 
 function doTest()
 {
-document.getElementById('animated').addEventListener('webkitAnimationStart', function() {
-requestAnimationFrame(() => {
-if (window.internals)
-document.getElementById('layers').innerText = internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_VISIBLE_RECTS)
+let animated = document.getElementById('animated');
+animated.addEventListener('webkitAnimationStart', function() {
+if (window.internals)
+document.getElementById('layers').innerText = internals.layerTreeAsText(document, internals.LAYER_TREE_INCLUDES_VISIBLE_RECTS)
 
-if (window.testRunner)
-testRunner.notifyDone();
-});
+if (window.testRunner)
+testRunner.notifyDone();
 }, false);
+
+animated.classList.add('animating');
 }
 window.addEventListener('load', doTest, false);
 


Modified: trunk/LayoutTests/legacy-animation-engine/compositing/visible-rect/animated-from-none.html (234640 => 234641)

--- trunk/LayoutTests/legacy-animation-engine/compositing/visible-rect/animated-from-none.html	2018-08-07 01:13:37

[webkit-changes] [234640] trunk

2018-08-06 Thread commit-queue

Title: [234640] trunk








Revision 234640
Author commit-qu...@webkit.org
Date 2018-08-06 18:13:37 -0700 (Mon, 06 Aug 2018)


Log Message
Check with SafeBrowsing during navigation in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=188133

Patch by Alex Christensen  on 2018-08-06
Source/WebKit:

Reviewed by Chris Dumez.

This turns WebFramePolicyListenerProxy into an object that now listens for the results
of two processes happening in parallel: the API::NavigationClient's decidePolicyForNavigation{Action, Response}
(which it was already waiting for) and, on platforms that support it, the SafariSafeBrowsing framework's check.
The first result is stored as it waits for the second result unless the first result is the API::NavigationClient
saying to cancel or convert the navigation to a download, in which cases we don't care what the safe browsing
framework results are because we won't show the URL in the browser.

Nothing is done with the safe browsing results yet.

* UIProcess/Cocoa/SafeBrowsingResultCocoa.mm: Added.
(WebKit::SafeBrowsingResult::SafeBrowsingResult):
* UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
* UIProcess/SafeBrowsingResult.h: Added.
(WebKit::SafeBrowsingResult::provider const):
(WebKit::SafeBrowsingResult::isPhishing const):
(WebKit::SafeBrowsingResult::isMalware const):
(WebKit::SafeBrowsingResult::isUnwantedSoftware const):
(WebKit::SafeBrowsingResult::isKnownToBeUnsafe const):
* UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):
(WebKit::WebFramePolicyListenerProxy::didReceiveSafeBrowsingResults):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
* UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::create):
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
* UIProcess/WebFrameProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
* UIProcess/WebPageProxy.h:
* WebKit.xcodeproj/project.pbxproj:

LayoutTests:

Reviewed by Andy Estes.

* platform/wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Copied from http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
This test verifies that keys cannot be entered during navigation, and the keys seen in WebKitTestRunner
are before the navigation.  This is seen now because there is a brief moment in time between when
WebKitTestRunner calls decidePolicyForNavigationAction and when the WebContent receives it.
* svg/custom/anchor-on-use.svg:
This test verifies what the page looks like after navigation.  It used to just call testRunner.notifyDone
when the link was clicked and because of the timing of messages sent with the UIProcess, WebKitTestRunner
would see the results after the page navigated.  Because we are adding a delay during navigation, the
message order can no longer be relied on in this way.  To fix this, we are just calling notifyDone in an
unload handler.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/svg/custom/anchor-on-use.svg
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp
trunk/Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h
trunk/Source/WebKit/UIProcess/WebFrameProxy.cpp
trunk/Source/WebKit/UIProcess/WebFrameProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/config.h


Added Paths

trunk/LayoutTests/platform/wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt
trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingResultCocoa.mm
trunk/Source/WebKit/UIProcess/SafeBrowsingResult.h




Diff

Modified: trunk/LayoutTests/ChangeLog (234639 => 234640)

--- trunk/LayoutTests/ChangeLog	2018-08-07 00:58:54 UTC (rev 234639)
+++ trunk/LayoutTests/ChangeLog	2018-08-07 01:13:37 UTC (rev 234640)
@@ -1,3 +1,21 @@
+2018-08-06  Alex Christensen  
+
+Check with SafeBrowsing during navigation in WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=188133
+
+Reviewed by Andy Estes.
+
+* platform/wk2/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Copied from http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
+This test verifies that keys cannot be entered during navigation, and the keys seen in WebKitTestRunner
+are before the navigation.  This is seen now because there is a brief moment in time between when
+WebKitTestRunner calls

[webkit-changes] [234639] tags/Safari-606.1.36.1.1/

2018-08-06 Thread kocsen_chung

Title: [234639] tags/Safari-606.1.36.1.1/








Revision 234639
Author kocsen_ch...@apple.com
Date 2018-08-06 17:58:54 -0700 (Mon, 06 Aug 2018)


Log Message
Tag Safari-606.1.36.1.1.

Added Paths

tags/Safari-606.1.36.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234638] trunk/LayoutTests

2018-08-06 Thread rniwa

Title: [234638] trunk/LayoutTests








Revision 234638
Author rn...@webkit.org
Date 2018-08-06 17:39:25 -0700 (Mon, 06 Aug 2018)


Log Message
fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
https://bugs.webkit.org/show_bug.cgi?id=188353

Remove the timeout expectation now that the test is passing on debug bots.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (234637 => 234638)

--- trunk/LayoutTests/ChangeLog	2018-08-07 00:25:52 UTC (rev 234637)
+++ trunk/LayoutTests/ChangeLog	2018-08-07 00:39:25 UTC (rev 234638)
@@ -1,3 +1,12 @@
+2018-08-06  Ryosuke Niwa  
+
+fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
+https://bugs.webkit.org/show_bug.cgi?id=188353
+
+Remove the timeout expectation now that the test is passing on debug bots.
+
+* TestExpectations:
+
 2018-08-04  Ryosuke Niwa  
 
 Add CEReactions=NotNeeded for reactions only needed for customized builtins


Modified: trunk/LayoutTests/TestExpectations (234637 => 234638)

--- trunk/LayoutTests/TestExpectations	2018-08-07 00:25:52 UTC (rev 234637)
+++ trunk/LayoutTests/TestExpectations	2018-08-07 00:39:25 UTC (rev 234638)
@@ -2218,5 +2218,3 @@
 webkit.org/b/187762 http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html [ Failure ]
 
 webkit.org/b/187269 [ Debug ] imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_abort.html [ Skip ]
-
-webkit.org/b/188353 [ Debug ] fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html [ Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234637] trunk/Source/WebInspectorUI

2018-08-06 Thread joepeck

Title: [234637] trunk/Source/WebInspectorUI








Revision 234637
Author joep...@webkit.org
Date 2018-08-06 17:25:52 -0700 (Mon, 06 Aug 2018)


Log Message
Web Inspector: Global search sometimes returns duplicate results for a resource
https://bugs.webkit.org/show_bug.cgi?id=188270


Reviewed by Brian Burg.

* UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
Avoid duplicate search results in the frontend. We should also fix the backend
but a frontend fix will also be desired for backends that have the issue.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (234636 => 234637)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-08-07 00:13:16 UTC (rev 234636)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-08-07 00:25:52 UTC (rev 234637)
@@ -1,3 +1,16 @@
+2018-08-06  Joseph Pecoraro  
+
+Web Inspector: Global search sometimes returns duplicate results for a resource
+https://bugs.webkit.org/show_bug.cgi?id=188270
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/SearchSidebarPanel.js:
+(WI.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
+Avoid duplicate search results in the frontend. We should also fix the backend
+but a frontend fix will also be desired for backends that have the issue.
+
 2018-08-03  Alex Christensen  
 
 Fix spelling of "overridden"


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (234636 => 234637)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js	2018-08-07 00:13:16 UTC (rev 234636)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js	2018-08-07 00:25:52 UTC (rev 234637)
@@ -170,11 +170,21 @@
 updateEmptyContentPlaceholder.call(this);
 }
 
-for (var i = 0; i < result.length; ++i) {
-var searchResult = result[i];
+let preventDuplicates = new Set;
+
+for (let i = 0; i < result.length; ++i) {
+let searchResult = result[i];
 if (!searchResult.url || !searchResult.frameId)
 continue;
 
+// FIXME: Backend sometimes searches files twice.
+//  Web Inspector: [Backend] Page.searchInResources sometimes returns duplicate results for a resource
+// Note we will still want this to fix legacy backends.
+let key = searchResult.frameId + ":" + searchResult.url;
+if (preventDuplicates.has(key))
+continue;
+preventDuplicates.add(key);
+
 // COMPATIBILITY (iOS 9): Page.searchInResources did not have the optional requestId parameter.
 PageAgent.searchInResource(searchResult.frameId, searchResult.url, searchQuery, isCaseSensitive, isRegex, searchResult.requestId, resourceCallback.bind(this, searchResult.frameId, searchResult.url));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234636] trunk

2018-08-06 Thread rniwa

Title: [234636] trunk








Revision 234636
Author rn...@webkit.org
Date 2018-08-06 17:13:16 -0700 (Mon, 06 Aug 2018)


Log Message
Add CEReactions=NotNeeded for reactions only needed for customized builtins
https://bugs.webkit.org/show_bug.cgi?id=187851

Reviewed by Chris Dumez.

Source/WebCore:

Because WebKit doesn't and will not support customized builtin elements, there are many DOM APIs marked with
[CEReactions] which don't actually need CustomElementReactionStack.

To clarify and document this difference, this patch introduces WebKit extention: [CEReactions=NotNeeded].
When this IDL attribute is specified, we generate CustomElementReactionDisallowedScope in the bindings code
to assert that there are no custom elements reactions being enqueued within the DOM API.

We suppress this assertion in CustomElementReactionStack since a DOM API with [CEReactions=NotNeeded] can
synchronously fire an event and otherwise execute arbirary scripts, which in turn could invoke a DOM API
with [CEReactions].

This patch deployes this change to HTMLIFrameElement since "src" IDL attribute triggers this second scenario.

Test: fast/custom-elements/custom-element-reaction-within-disallowed-scope.html

* bindings/scripts/CodeGeneratorJS.pm:
(GeneratePut):
(GeneratePutByIndex):
(GenerateDefineOwnProperty):
(GenerateDeletePropertyCommon):
(GenerateAttributeSetterBodyDefinition):
(GenerateCustomElementReactionsStackIfNeeded): Added. Generate CustomElementReactionStack for [CEReactions]
and CustomElementReactionDisallowedScope for [CEReactions=NotNeeded].
* bindings/scripts/test/JS/JSTestCEReactions.cpp:
* bindings/scripts/test/TestCEReactions.idl: Added test cases for [CEReactions=NotNeeded].
* bindings/scripts/test/TestCEReactionsStringifier.idl: Ditto.
* dom/CustomElementReactionQueue.cpp:
(WebCore::CustomElementReactionQueue::enqueueElementUpgrade): Added an assertion to catch cases where
a DOM API with [CEReactions=NotNeeded] enqueues a custom element reaction; i.e. cases where [CEReactions]
should have been used.
(WebCore::CustomElementReactionQueue::enqueueElementUpgradeIfDefined): Ditto.
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded): Ditto.
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded): Ditto.
(WebCore::CustomElementReactionQueue::enqueueAdoptedCallbackIfNeeded): Ditto.
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded): Ditto.
(WebCore::CustomElementReactionQueue::enqueuePostUpgradeReactions): Ditto.
* dom/CustomElementReactionQueue.h:
(WebCore::CustomElementReactionDisallowedScope): Added. Enables the assertion in enqueue* functions above.
(WebCore::CustomElementReactionDisallowedScope::CustomElementReactionDisallowedScope): Added.
(WebCore::CustomElementReactionDisallowedScope::~CustomElementReactionDisallowedScope): Added.
(WebCore::CustomElementReactionDisallowedScope::isReactionAllowed): Added.
(WebCore::CustomElementReactionDisallowedScope::AllowedScope): Added.
(WebCore::CustomElementReactionDisallowedScope::AllowedScope::AllowedScope): Added.
(WebCore::CustomElementReactionDisallowedScope::AllowedScope::~AllowedScope): Added.
(WebCore::CustomElementReactionStack): Suppress the assertion. See above for why this is needed.
* html/HTMLIFrameElement.idl:

LayoutTests:

Added a regression test for enqueuing a custom element reaction in a DOM API marked as [CEReaction]
inside another DOM API with [CEReaction=NotNeeded]. WebKit should not hit a debug assertion added
by this patch.

* fast/custom-elements/custom-element-reaction-within-disallowed-scope-expected.txt: Added.
* fast/custom-elements/custom-element-reaction-within-disallowed-scope.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp
trunk/Source/WebCore/bindings/scripts/test/TestCEReactions.idl
trunk/Source/WebCore/bindings/scripts/test/TestCEReactionsStringifier.idl
trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp
trunk/Source/WebCore/dom/CustomElementReactionQueue.h
trunk/Source/WebCore/html/HTMLIFrameElement.idl


Added Paths

trunk/LayoutTests/fast/custom-elements/custom-element-reaction-within-disallowed-scope-expected.txt
trunk/LayoutTests/fast/custom-elements/custom-element-reaction-within-disallowed-scope.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234635 => 234636)

--- trunk/LayoutTests/ChangeLog	2018-08-06 23:53:33 UTC (rev 234635)
+++ trunk/LayoutTests/ChangeLog	2018-08-07 00:13:16 UTC (rev 234636)
@@ -1,3 +1,17 @@
+2018-08-04  Ryosuke Niwa  
+
+Add CEReactions=NotNeeded for reactions only needed for customized builtins
+https://bugs.webkit.org/show_bug.cgi?id=187851
+
+Reviewed by Chris Dumez.
+
+Added a regression test for enqueuing a custom element reaction in a DOM API

[webkit-changes] [234635] trunk/LayoutTests

2018-08-06 Thread mattbaker

Title: [234635] trunk/LayoutTests








Revision 234635
Author mattba...@apple.com
Date 2018-08-06 16:53:33 -0700 (Mon, 06 Aug 2018)


Log Message
Web Inspector: split-up async stack trace test suite to improve clarity and maintainability
https://bugs.webkit.org/show_bug.cgi?id=185398


Reviewed by Joseph Pecoraro.

* inspector/debugger/async-stack-trace-basic-expected.txt: Added.
* inspector/debugger/async-stack-trace-basic.html: Added.
Basic tests that check for the existence of an asynchronous stack trace
when pausing inside an asynchronous callback function.

* inspector/debugger/async-stack-trace-event-listener-expected.txt: Added.
* inspector/debugger/async-stack-trace-event-listener.html: Added.
* inspector/debugger/async-stack-trace-expected.txt: Removed.

* inspector/debugger/async-stack-trace-truncate-expected.txt: Added.
* inspector/debugger/async-stack-trace-truncate.html: Added.
Test scenarios where the number of call frames in the async stack trace
exceeds the maximum depth and is truncated.

* inspector/debugger/async-stack-trace.html: Removed.

* inspector/debugger/resources/async-stack-trace-test.js: Added.
(TestPage.registerInitializer.window.getAsyncStackTrace):
(TestPage.registerInitializer.logCallFrame):
(TestPage.registerInitializer.window.logAsyncStackTrace):
(TestPage.registerInitializer.window.addAsyncStackTraceTestCase):
(TestPage.registerInitializer):
Utility functions used across tests.

* inspector/debugger/resources/postMessage-echo.html: Removed.
This was unnecessary. To check that an async stack trace exists when
pausing in a postMessage handler, all we need is an iframe that posts a
message to its parent as soon as it is created. The iframe is now created
inline in async-stack-trace-basic.html.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations


Added Paths

trunk/LayoutTests/inspector/debugger/async-stack-trace-basic-expected.txt
trunk/LayoutTests/inspector/debugger/async-stack-trace-basic.html
trunk/LayoutTests/inspector/debugger/async-stack-trace-event-listener-expected.txt
trunk/LayoutTests/inspector/debugger/async-stack-trace-event-listener.html
trunk/LayoutTests/inspector/debugger/async-stack-trace-truncate-expected.txt
trunk/LayoutTests/inspector/debugger/async-stack-trace-truncate.html
trunk/LayoutTests/inspector/debugger/resources/async-stack-trace-test.js


Removed Paths

trunk/LayoutTests/inspector/debugger/async-stack-trace-expected.txt
trunk/LayoutTests/inspector/debugger/async-stack-trace.html
trunk/LayoutTests/inspector/debugger/resources/postMessage-echo.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234634 => 234635)

--- trunk/LayoutTests/ChangeLog	2018-08-06 23:49:09 UTC (rev 234634)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 23:53:33 UTC (rev 234635)
@@ -1,3 +1,43 @@
+2018-08-06  Matt Baker  
+
+Web Inspector: split-up async stack trace test suite to improve clarity and maintainability
+https://bugs.webkit.org/show_bug.cgi?id=185398
+
+
+Reviewed by Joseph Pecoraro.
+
+* inspector/debugger/async-stack-trace-basic-expected.txt: Added.
+* inspector/debugger/async-stack-trace-basic.html: Added.
+Basic tests that check for the existence of an asynchronous stack trace
+when pausing inside an asynchronous callback function.
+
+* inspector/debugger/async-stack-trace-event-listener-expected.txt: Added.
+* inspector/debugger/async-stack-trace-event-listener.html: Added.
+* inspector/debugger/async-stack-trace-expected.txt: Removed.
+
+* inspector/debugger/async-stack-trace-truncate-expected.txt: Added.
+* inspector/debugger/async-stack-trace-truncate.html: Added.
+Test scenarios where the number of call frames in the async stack trace
+exceeds the maximum depth and is truncated.
+
+* inspector/debugger/async-stack-trace.html: Removed.
+
+* inspector/debugger/resources/async-stack-trace-test.js: Added.
+(TestPage.registerInitializer.window.getAsyncStackTrace):
+(TestPage.registerInitializer.logCallFrame):
+(TestPage.registerInitializer.window.logAsyncStackTrace):
+(TestPage.registerInitializer.window.addAsyncStackTraceTestCase):
+(TestPage.registerInitializer):
+Utility functions used across tests.
+
+* inspector/debugger/resources/postMessage-echo.html: Removed.
+This was unnecessary. To check that an async stack trace exists when
+pausing in a postMessage handler, all we need is an iframe that posts a
+message to its parent as soon as it is created. The iframe is now created
+inline in async-stack-trace-basic.html.
+
+* platform/mac/TestExpectations:
+
 2018-08-06  Daniel Bates  
 
 Setting table layout to fixed causes incorrect cell width calculations


Added: trunk/LayoutTests/inspector/debugger/async-stack-trace-basic-expected.txt (0 =>

[webkit-changes] [234634] trunk/Tools

2018-08-06 Thread david_quesada

Title: [234634] trunk/Tools








Revision 234634
Author david_ques...@apple.com
Date 2018-08-06 16:49:09 -0700 (Mon, 06 Aug 2018)


Log Message
webkitdirs.pm should default to iPhone SE for 64-bit testing
https://bugs.webkit.org/show_bug.cgi?id=188361

Reviewed by Daniel Bates.

Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.

* Scripts/webkitdirs.pm:
(findOrCreateSimulatorForIOSDevice):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
Update the help text for --device-type to reflect the new default device.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py




Diff

Modified: trunk/Tools/ChangeLog (234633 => 234634)

--- trunk/Tools/ChangeLog	2018-08-06 22:35:50 UTC (rev 234633)
+++ trunk/Tools/ChangeLog	2018-08-06 23:49:09 UTC (rev 234634)
@@ -1,3 +1,18 @@
+2018-08-06  David Quesada  
+
+webkitdirs.pm should default to iPhone SE for 64-bit testing
+https://bugs.webkit.org/show_bug.cgi?id=188361
+
+Reviewed by Daniel Bates.
+
+Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
+
+* Scripts/webkitdirs.pm:
+(findOrCreateSimulatorForIOSDevice):
+* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+(parse_args):
+Update the help text for --device-type to reflect the new default device.
+
 2018-08-06  Wenson Hsieh  
 
 [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained


Modified: trunk/Tools/Scripts/webkitdirs.pm (234633 => 234634)

--- trunk/Tools/Scripts/webkitdirs.pm	2018-08-06 22:35:50 UTC (rev 234633)
+++ trunk/Tools/Scripts/webkitdirs.pm	2018-08-06 23:49:09 UTC (rev 234634)
@@ -2670,8 +2670,8 @@
 my $simulatorName;
 my $simulatorDeviceType;
 if (architecture() eq "x86_64") {
-$simulatorName = "iPhone 5s " . $simulatorNameSuffix;
-$simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-5s";
+$simulatorName = "iPhone SE " . $simulatorNameSuffix;
+$simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-SE";
 } else {
 $simulatorName = "iPhone 5 " . $simulatorNameSuffix;
 $simulatorDeviceType = "com.apple.CoreSimulator.SimDeviceType.iPhone-5";


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (234633 => 234634)

--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2018-08-06 22:35:50 UTC (rev 234633)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2018-08-06 23:49:09 UTC (rev 234634)
@@ -296,7 +296,7 @@
 optparse.make_option('--no-install', action='', const=False, default=True, dest='install',
 help='Skip install step for device and simulator testing'),
 optparse.make_option('--version', help='Specify the version of iOS to be used. By default, this will adopt the runtime for iOS Simulator.'),
-optparse.make_option('--device-type', help='iOS Simulator device type identifier (default: i386 -> iPhone 5, x86_64 -> iPhone 5s)'),
+optparse.make_option('--device-type', help='iOS Simulator device type identifier (default: i386 -> iPhone 5, x86_64 -> iPhone SE)'),
 optparse.make_option('--dedicated-simulators', action="" default=False,
 help="If set, dedicated iOS simulators will always be created.  If not set, the script will attempt to use any currently running simulator."),
 optparse.make_option('--show-touches', action="" default=False, help="If set, a small dot will be shown where the generated touches are. Helpful for debugging touch tests."),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234633] trunk/Source/WebCore

2018-08-06 Thread simon . fraser

Title: [234633] trunk/Source/WebCore








Revision 234633
Author simon.fra...@apple.com
Date 2018-08-06 15:35:50 -0700 (Mon, 06 Aug 2018)


Log Message
Clean up initialization of some RenderLayer members
https://bugs.webkit.org/show_bug.cgi?id=188330

Reviewed by Dean Jackson.

Use initializers for the pointers. No need to initialize LayoutUnits, which initialize to zero.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
* rendering/RenderLayer.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (234632 => 234633)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 22:34:50 UTC (rev 234632)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 22:35:50 UTC (rev 234633)
@@ -1,3 +1,16 @@
+2018-08-06  Simon Fraser  
+
+Clean up initialization of some RenderLayer members
+https://bugs.webkit.org/show_bug.cgi?id=188330
+
+Reviewed by Dean Jackson.
+
+Use initializers for the pointers. No need to initialize LayoutUnits, which initialize to zero.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::RenderLayer):
+* rendering/RenderLayer.h:
+
 2018-08-06  Said Abou-Hallawa  
 
 Remove the SVG elements' attributes macros


Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (234632 => 234633)

--- trunk/Source/WebCore/rendering/RenderLayer.cpp	2018-08-06 22:34:50 UTC (rev 234632)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp	2018-08-06 22:35:50 UTC (rev 234633)
@@ -319,13 +319,6 @@
 , m_hasNotIsolatedBlendingDescendantsStatusDirty(false)
 #endif
 , m_renderer(rendererLayerModelObject)
-, m_parent(nullptr)
-, m_previous(nullptr)
-, m_next(nullptr)
-, m_first(nullptr)
-, m_last(nullptr)
-, m_staticInlinePosition(0)
-, m_staticBlockPosition(0)
 {
 m_isNormalFlowOnly = shouldBeNormalFlowOnly();
 m_isSelfPaintingLayer = shouldBeSelfPaintingLayer();


Modified: trunk/Source/WebCore/rendering/RenderLayer.h (234632 => 234633)

--- trunk/Source/WebCore/rendering/RenderLayer.h	2018-08-06 22:34:50 UTC (rev 234632)
+++ trunk/Source/WebCore/rendering/RenderLayer.h	2018-08-06 22:35:50 UTC (rev 234633)
@@ -1109,11 +1109,11 @@
 
 RenderLayerModelObject& m_renderer;
 
-RenderLayer* m_parent;
-RenderLayer* m_previous;
-RenderLayer* m_next;
-RenderLayer* m_first;
-RenderLayer* m_last;
+RenderLayer* m_parent { nullptr };
+RenderLayer* m_previous { nullptr };
+RenderLayer* m_next { nullptr };
+RenderLayer* m_first { nullptr };
+RenderLayer* m_last { nullptr };
 
 // Our current relative position offset.
 LayoutSize m_offsetForInFlowPosition;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234632] branches/safari-606.1.36.2-branch/Source

2018-08-06 Thread kocsen_chung

Title: [234632] branches/safari-606.1.36.2-branch/Source








Revision 234632
Author kocsen_ch...@apple.com
Date 2018-08-06 15:34:50 -0700 (Mon, 06 Aug 2018)


Log Message
Versioning.

Modified Paths

branches/safari-606.1.36.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-606.1.36.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-606.1.36.2-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-606.1.36.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-606.1.36.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-606.1.36.2-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-606.1.36.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-606.1.36.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (234631 => 234632)

--- branches/safari-606.1.36.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
+++ branches/safari-606.1.36.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 22:34:50 UTC (rev 234632)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (234631 => 234632)

--- branches/safari-606.1.36.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
+++ branches/safari-606.1.36.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 22:34:50 UTC (rev 234632)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.2-branch/Source/WebCore/Configurations/Version.xcconfig (234631 => 234632)

--- branches/safari-606.1.36.2-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
+++ branches/safari-606.1.36.2-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 22:34:50 UTC (rev 234632)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (234631 => 234632)

--- branches/safari-606.1.36.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
+++ branches/safari-606.1.36.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 22:34:50 UTC (rev 234632)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (234631 => 234632)

--- branches/safari-606.1.36.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
+++ branches/safari-606.1.36.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 22:34:50 UTC (rev 234632)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 2;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The

[webkit-changes] [234631] branches/safari-606-branch/Source

2018-08-06 Thread kocsen_chung

Title: [234631] branches/safari-606-branch/Source








Revision 234631
Author kocsen_ch...@apple.com
Date 2018-08-06 15:25:45 -0700 (Mon, 06 Aug 2018)


Log Message
Versioning.

Modified Paths

branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig (234630 => 234631)

--- branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 22:23:24 UTC (rev 234630)
+++ branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 606;
-MINOR_VERSION = 1;
-TINY_VERSION = 37;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (234630 => 234631)

--- branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 22:23:24 UTC (rev 234630)
+++ branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 606;
-MINOR_VERSION = 1;
-TINY_VERSION = 37;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig (234630 => 234631)

--- branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 22:23:24 UTC (rev 234630)
+++ branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 606;
-MINOR_VERSION = 1;
-TINY_VERSION = 37;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (234630 => 234631)

--- branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 22:23:24 UTC (rev 234630)
+++ branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 606;
-MINOR_VERSION = 1;
-TINY_VERSION = 37;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (234630 => 234631)

--- branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 22:23:24 UTC (rev 234630)
+++ branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
-MINOR_VERSION = 1;
-TINY_VERSION = 37;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig (234630 => 234631)

--- branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig	2018-08-06 22:23:24 UTC (rev 234630)
+++ branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
@@ -22,8 +22,8 @@
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
 
 MAJOR_VERSION = 606;
-MINOR_VERSION = 1;
-TINY_VERSION = 37;
+MINOR_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (234630 => 234631)

--- branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-08-06 22:23:24 UTC (rev 234630)
+++ branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-08-06 22:25:45 UTC (rev 234631)
@@ -22,8 +22,8 @@
 // OF THIS

[webkit-changes] [234630] trunk/LayoutTests

2018-08-06 Thread dbates

Title: [234630] trunk/LayoutTests








Revision 234630
Author dba...@webkit.org
Date 2018-08-06 15:23:24 -0700 (Mon, 06 Aug 2018)


Log Message
Setting table layout to fixed causes incorrect cell width calculations
https://bugs.webkit.org/show_bug.cgi?id=90068

Reviewed by Simon Fraser.

Derived from the test case written by Pravin D.

Add a test case to ensure we do not regress cell width computation in fixed table layout
when colspan is greater than the number of columns in the table.

* fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html: Added.
* fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html
trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234629 => 234630)

--- trunk/LayoutTests/ChangeLog	2018-08-06 22:21:25 UTC (rev 234629)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 22:23:24 UTC (rev 234630)
@@ -1,5 +1,20 @@
 2018-08-06  Daniel Bates  
 
+Setting table layout to fixed causes incorrect cell width calculations
+https://bugs.webkit.org/show_bug.cgi?id=90068
+
+Reviewed by Simon Fraser.
+
+Derived from the test case written by Pravin D.
+
+Add a test case to ensure we do not regress cell width computation in fixed table layout
+when colspan is greater than the number of columns in the table.
+
+* fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html: Added.
+* fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html: Added.
+
+2018-08-06  Daniel Bates  
+
 Add tests to ensure that Same-Site cookies are stored when set as the first party
 https://bugs.webkit.org/show_bug.cgi?id=188080
 


Added: trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html (0 => 234630)

--- trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns-expected.html	2018-08-06 22:23:24 UTC (rev 234630)
@@ -0,0 +1,38 @@
+
+
+
+
+table, tr, td {
+border: 1px solid black;
+}
+
+td {
+width: 1%;
+}
+table {
+background: red;
+}
+tr {
+background: green;
+height: 35px;
+}
+
+
+
+This test verifies that the width of table cells are computed correctly in fixed table layout regardless of whether colspan  than the number of columns.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+


Added: trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html (0 => 234630)

--- trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html	(rev 0)
+++ trunk/LayoutTests/fast/table/fixed-table-layout/width-distribution-when-colspan-greater-than-table-columns.html	2018-08-06 22:23:24 UTC (rev 234630)
@@ -0,0 +1,38 @@
+
+
+
+
+table, tr, td {
+border: 1px solid black;
+}
+
+td {
+width: 1%;
+}
+table {
+background: red;
+}
+tr {
+background: green;
+height: 35px;
+}
+
+
+
+This test verifies that the width of table cells are computed correctly in fixed table layout regardless of whether colspan  than the number of columns.
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234629] trunk/LayoutTests

2018-08-06 Thread dbates

Title: [234629] trunk/LayoutTests








Revision 234629
Author dba...@webkit.org
Date 2018-08-06 15:21:25 -0700 (Mon, 06 Aug 2018)


Log Message
Add tests to ensure that Same-Site cookies are stored when set as the first party
https://bugs.webkit.org/show_bug.cgi?id=188080

Reviewed by Alexey Proskuryakov.

* http/tests/cookies/resources/cookie-utilities.js:
(getDOMCookies): Return an empty dictionary when there are no DOM cookies. Currently we
return {"": undefined}.
* http/tests/cookies/resources/cookie-utilities.php: Added.
* http/tests/cookies/resources/echo-http-and-dom-cookies-and-notify-done.php: Added.
* http/tests/cookies/same-site/set-first-party-cross-site-cookies-expected.txt: Added.
* http/tests/cookies/same-site/set-first-party-cross-site-cookies.php: Added.
* http/tests/cookies/same-site/set-first-party-same-site-cookies-expected.txt: Added.
* http/tests/cookies/same-site/set-first-party-same-site-cookies.php: Added.
* platform/ios-12/TestExpectations: Skip the tests until the fix for 
is shipped.
* platform/mac/TestExpectations: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.js
trunk/LayoutTests/platform/ios-12/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations


Added Paths

trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.php
trunk/LayoutTests/http/tests/cookies/resources/echo-http-and-dom-cookies-and-notify-done.php
trunk/LayoutTests/http/tests/cookies/same-site/set-first-party-cross-site-cookies-expected.txt
trunk/LayoutTests/http/tests/cookies/same-site/set-first-party-cross-site-cookies.php
trunk/LayoutTests/http/tests/cookies/same-site/set-first-party-same-site-cookies-expected.txt
trunk/LayoutTests/http/tests/cookies/same-site/set-first-party-same-site-cookies.php




Diff

Modified: trunk/LayoutTests/ChangeLog (234628 => 234629)

--- trunk/LayoutTests/ChangeLog	2018-08-06 22:16:30 UTC (rev 234628)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 22:21:25 UTC (rev 234629)
@@ -1,3 +1,23 @@
+2018-08-06  Daniel Bates  
+
+Add tests to ensure that Same-Site cookies are stored when set as the first party
+https://bugs.webkit.org/show_bug.cgi?id=188080
+
+Reviewed by Alexey Proskuryakov.
+
+* http/tests/cookies/resources/cookie-utilities.js:
+(getDOMCookies): Return an empty dictionary when there are no DOM cookies. Currently we
+return {"": undefined}.
+* http/tests/cookies/resources/cookie-utilities.php: Added.
+* http/tests/cookies/resources/echo-http-and-dom-cookies-and-notify-done.php: Added.
+* http/tests/cookies/same-site/set-first-party-cross-site-cookies-expected.txt: Added.
+* http/tests/cookies/same-site/set-first-party-cross-site-cookies.php: Added.
+* http/tests/cookies/same-site/set-first-party-same-site-cookies-expected.txt: Added.
+* http/tests/cookies/same-site/set-first-party-same-site-cookies.php: Added.
+* platform/ios-12/TestExpectations: Skip the tests until the fix for 
+is shipped.
+* platform/mac/TestExpectations: Ditto.
+
 2018-08-06  Ryosuke Niwa  
 
 fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots


Modified: trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.js (234628 => 234629)

--- trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.js	2018-08-06 22:16:30 UTC (rev 234628)
+++ trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.js	2018-08-06 22:21:25 UTC (rev 234629)
@@ -32,6 +32,8 @@
 {
 if (!g_baseDocumentWhenFetchingDOMCookies)
 g_baseDocumentWhenFetchingDOMCookies = document;
+if (!g_baseDocumentWhenFetchingDOMCookies.cookie)
+return {};
 let cookies = g_baseDocumentWhenFetchingDOMCookies.cookie.split("; ");
 let result = {};
 for (let keyAndValuePair of cookies) {


Added: trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.php (0 => 234629)

--- trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.php	(rev 0)
+++ trunk/LayoutTests/http/tests/cookies/resources/cookie-utilities.php	2018-08-06 22:21:25 UTC (rev 234629)
@@ -0,0 +1,53 @@
+ $value) {
+$cookieValue .= "; " . $name;
+if (isset($value))
+$cookieValue .= "=" . $value;
+}
+header("Set-Cookie: " . $cookieValue, FALSE /* replace */);
+}
+
+function deleteCookie($name)
+{
+setcookie($name, "deleted", time() - 86400, "/");
+}
+
+function _deleteCookieCallback($value, $name)
+{
+deleteCookie($name);
+}
+
+function resetCookiesForCurrentOrigin()
+{
+array_walk($_COOKIE, _deleteCookieCallback);
+}
+?>


Added: trunk/LayoutTests/http/tests/cookies/resources/echo-http-and-dom-cookies-and-notify-done.php (0 => 234629)

--- trunk/LayoutTests/http/tests/cookies/resources/echo-http-and-dom-cookies-and-notify-done.php	(rev 0)
+++

[webkit-changes] [234628] branches/safari-606-branch/Source/JavaScriptCore

2018-08-06 Thread kocsen_chung

Title: [234628] branches/safari-606-branch/Source/_javascript_Core








Revision 234628
Author kocsen_ch...@apple.com
Date 2018-08-06 15:16:30 -0700 (Mon, 06 Aug 2018)


Log Message
Cherry-pick r234576. rdar://problem/42973449

Give the `jsc` shell the JIT entitlement
https://bugs.webkit.org/show_bug.cgi?id=188324


Reviewed by Dan Bernstein.

This should help us in ensuring the system jsc is able to JIT.

* Configurations/JSC.xcconfig:
* _javascript_Core.xcodeproj/project.pbxproj:
* allow-jit-macOS.entitlements: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606-branch/Source/_javascript_Core/ChangeLog
branches/safari-606-branch/Source/_javascript_Core/Configurations/JSC.xcconfig
branches/safari-606-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj


Added Paths

branches/safari-606-branch/Source/_javascript_Core/allow-jit-macOS.entitlements




Diff

Modified: branches/safari-606-branch/Source/_javascript_Core/ChangeLog (234627 => 234628)

--- branches/safari-606-branch/Source/_javascript_Core/ChangeLog	2018-08-06 22:16:26 UTC (rev 234627)
+++ branches/safari-606-branch/Source/_javascript_Core/ChangeLog	2018-08-06 22:16:30 UTC (rev 234628)
@@ -1,3 +1,36 @@
+2018-08-06  Kocsen Chung  
+
+Cherry-pick r234576. rdar://problem/42973449
+
+Give the `jsc` shell the JIT entitlement
+https://bugs.webkit.org/show_bug.cgi?id=188324
+
+
+Reviewed by Dan Bernstein.
+
+This should help us in ensuring the system jsc is able to JIT.
+
+* Configurations/JSC.xcconfig:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* allow-jit-macOS.entitlements: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-08-03  Saam Barati  
+
+Give the `jsc` shell the JIT entitlement
+https://bugs.webkit.org/show_bug.cgi?id=188324
+
+
+Reviewed by Dan Bernstein.
+
+This should help us in ensuring the system jsc is able to JIT.
+
+* Configurations/JSC.xcconfig:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* allow-jit-macOS.entitlements: Added.
+
 2018-08-02  Babak Shafiei  
 
 Cherry-pick r234528. rdar://problem/42883788


Modified: branches/safari-606-branch/Source/_javascript_Core/Configurations/JSC.xcconfig (234627 => 234628)

--- branches/safari-606-branch/Source/_javascript_Core/Configurations/JSC.xcconfig	2018-08-06 22:16:26 UTC (rev 234627)
+++ branches/safari-606-branch/Source/_javascript_Core/Configurations/JSC.xcconfig	2018-08-06 22:16:30 UTC (rev 234628)
@@ -32,6 +32,7 @@
 
 PRODUCT_NAME = jsc;
 CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = entitlements.plist;
+CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = allow-jit-macOS.entitlements;
 OTHER_CODE_SIGN_FLAGS[sdk=iphone*] = -i com.apple.jsc;
 
 // Explicitly add the PrivateHeaders directory to the search path so that generated header files can be found in production builds.


Modified: branches/safari-606-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (234627 => 234628)

--- branches/safari-606-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2018-08-06 22:16:26 UTC (rev 234627)
+++ branches/safari-606-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2018-08-06 22:16:30 UTC (rev 234628)
@@ -3678,6 +3678,8 @@
 		79CFC6EF1C33B1C768EA /* LLIntPCRanges.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = LLIntPCRanges.h; path = llint/LLIntPCRanges.h; sourceTree = ""; };
 		79D5CD581C1106A900CECA07 /* SamplingProfiler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SamplingProfiler.cpp; sourceTree = ""; };
 		79D5CD591C1106A900CECA07 /* SamplingProfiler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SamplingProfiler.h; sourceTree = ""; };
+		79D7B0E121152FD200FE7C64 /* entitlements.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = entitlements.plist; sourceTree = ""; };
+		79D7B0E221152FD300FE7C64 /* allow-jit-macOS.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = "allow-jit-macOS.entitlements"; sourceTree = ""; };
 		79DAE2791E03C82200B526AA /* WasmExceptionType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WasmExceptionType.h; sourceTree = ""; };
 		79DFCBDA1D88C59600527D03 /* HasOwnPropertyCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HasOwnPropertyCache.h; sourceTree = ""; };
 		79EE0BFD1B4AFB85000385C9 /* VariableEnvironment.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;

[webkit-changes] [234627] branches/safari-606-branch/Source

2018-08-06 Thread kocsen_chung

Title: [234627] branches/safari-606-branch/Source








Revision 234627
Author kocsen_ch...@apple.com
Date 2018-08-06 15:16:26 -0700 (Mon, 06 Aug 2018)


Log Message
Versioning.

Modified Paths

branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig (234626 => 234627)

--- branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 22:14:05 UTC (rev 234626)
+++ branches/safari-606-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 22:16:26 UTC (rev 234627)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 36;
+TINY_VERSION = 37;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (234626 => 234627)

--- branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 22:14:05 UTC (rev 234626)
+++ branches/safari-606-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 22:16:26 UTC (rev 234627)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 36;
+TINY_VERSION = 37;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig (234626 => 234627)

--- branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 22:14:05 UTC (rev 234626)
+++ branches/safari-606-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 22:16:26 UTC (rev 234627)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 36;
+TINY_VERSION = 37;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (234626 => 234627)

--- branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 22:14:05 UTC (rev 234626)
+++ branches/safari-606-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 22:16:26 UTC (rev 234627)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 36;
+TINY_VERSION = 37;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (234626 => 234627)

--- branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 22:14:05 UTC (rev 234626)
+++ branches/safari-606-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 22:16:26 UTC (rev 234627)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 36;
+TINY_VERSION = 37;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig (234626 => 234627)

--- branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig	2018-08-06 22:14:05 UTC (rev 234626)
+++ branches/safari-606-branch/Source/WebKit/Configurations/Version.xcconfig	2018-08-06 22:16:26 UTC (rev 234627)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 36;
+TINY_VERSION = 37;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (234626 => 234627)

--- branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-08-06 22:14:05 UTC (rev 234626)
+++ branches/safari-606-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-08-06 22:16:26 UTC (rev 234627)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 36;
+TINY_VERSION = 37;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234626] trunk/Source/WebKit

2018-08-06 Thread cdumez

Title: [234626] trunk/Source/WebKit








Revision 234626
Author cdu...@apple.com
Date 2018-08-06 15:14:05 -0700 (Mon, 06 Aug 2018)


Log Message
Regression(NetworkLoadChecker): CORS preflights are no longer able to deal with client certificate authentication
https://bugs.webkit.org/show_bug.cgi?id=188355


Reviewed by Alex Christensen.

Before we started using the NetworkLoadChecker to do CORS-preflighting in the Network process, challenges would
use the NetworkLoad::completeAuthenticationChallenge() code path with isAllowedToAskUserForCredentials to set
to false. This would call:
1. completionHandler(AuthenticationChallengeDisposition::UseCredential, { }); for TLS handshakes (server trust
   evaluation & client certification authentication)
2. NetworkProcess::singleton().authenticationManager().didReceiveAuthenticationChallenge() otherwise

However, NetworkCORSPreflightChecker::didReceiveChallenge() was behaving differently and calling:
1. completionHandler(AuthenticationChallengeDisposition::RejectProtectionSpace, { }); for server trust evaluations
2. completionHandler(AuthenticationChallengeDisposition::Cancel, { }); otherwise

Restore previous behavior by aligning NetworkCORSPreflightChecker::didReceiveChallenge() with
NetworkLoad::completeAuthenticationChallenge() when isAllowedToAskUserForCredentials is set to false. This means
we end up asking the AuthenticationManager for client certificate authentication instead or cancelling the
preflight.

This fixes CORS-preflighting on some internal sites.

* NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
* NetworkProcess/NetworkCORSPreflightChecker.h:
* NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):
* NetworkProcess/NetworkLoadChecker.h:
* NetworkProcess/NetworkResourceLoader.cpp:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.h
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoadChecker.h
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
trunk/Source/WebKit/NetworkProcess/PingLoad.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (234625 => 234626)

--- trunk/Source/WebKit/ChangeLog	2018-08-06 22:05:56 UTC (rev 234625)
+++ trunk/Source/WebKit/ChangeLog	2018-08-06 22:14:05 UTC (rev 234626)
@@ -1,3 +1,40 @@
+2018-08-06  Chris Dumez  
+
+Regression(NetworkLoadChecker): CORS preflights are no longer able to deal with client certificate authentication
+https://bugs.webkit.org/show_bug.cgi?id=188355
+
+
+Reviewed by Alex Christensen.
+
+Before we started using the NetworkLoadChecker to do CORS-preflighting in the Network process, challenges would
+use the NetworkLoad::completeAuthenticationChallenge() code path with isAllowedToAskUserForCredentials to set
+to false. This would call:
+1. completionHandler(AuthenticationChallengeDisposition::UseCredential, { }); for TLS handshakes (server trust
+   evaluation & client certification authentication)
+2. NetworkProcess::singleton().authenticationManager().didReceiveAuthenticationChallenge() otherwise
+
+However, NetworkCORSPreflightChecker::didReceiveChallenge() was behaving differently and calling:
+1. completionHandler(AuthenticationChallengeDisposition::RejectProtectionSpace, { }); for server trust evaluations
+2. completionHandler(AuthenticationChallengeDisposition::Cancel, { }); otherwise
+
+Restore previous behavior by aligning NetworkCORSPreflightChecker::didReceiveChallenge() with
+NetworkLoad::completeAuthenticationChallenge() when isAllowedToAskUserForCredentials is set to false. This means
+we end up asking the AuthenticationManager for client certificate authentication instead or cancelling the
+preflight.
+
+This fixes CORS-preflighting on some internal sites.
+
+* NetworkProcess/NetworkCORSPreflightChecker.cpp:
+(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
+* NetworkProcess/NetworkCORSPreflightChecker.h:
+* NetworkProcess/NetworkLoadChecker.cpp:
+(WebKit::NetworkLoadChecker::NetworkLoadChecker):
+(WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):
+* NetworkProcess/NetworkLoadChecker.h:
+* NetworkProcess/NetworkResourceLoader.cpp:
+* NetworkProcess/PingLoad.cpp:
+(WebKit::PingLoad::PingLoad):
+
 2018-08-06  Alex Christensen  
 
 Use enum classes and OptionSets for PaintPhase and PaintBehavior


Modified: trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp (234625 => 234626)

---

[webkit-changes] [234625] branches/safari-606.1.36.2-branch/

2018-08-06 Thread kocsen_chung

Title: [234625] branches/safari-606.1.36.2-branch/








Revision 234625
Author kocsen_ch...@apple.com
Date 2018-08-06 15:05:56 -0700 (Mon, 06 Aug 2018)


Log Message
New branch.

Added Paths

branches/safari-606.1.36.2-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234624] branches/safari-606.1.36.0-branch/Source

2018-08-06 Thread kocsen_chung

Title: [234624] branches/safari-606.1.36.0-branch/Source








Revision 234624
Author kocsen_ch...@apple.com
Date 2018-08-06 15:02:43 -0700 (Mon, 06 Aug 2018)


Log Message
Versioning.

Modified Paths

branches/safari-606.1.36.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-606.1.36.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-606.1.36.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-606.1.36.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-606.1.36.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-606.1.36.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-606.1.36.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-606.1.36.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (234623 => 234624)

--- branches/safari-606.1.36.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 21:59:08 UTC (rev 234623)
+++ branches/safari-606.1.36.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 22:02:43 UTC (rev 234624)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (234623 => 234624)

--- branches/safari-606.1.36.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 21:59:08 UTC (rev 234623)
+++ branches/safari-606.1.36.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 22:02:43 UTC (rev 234624)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.0-branch/Source/WebCore/Configurations/Version.xcconfig (234623 => 234624)

--- branches/safari-606.1.36.0-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 21:59:08 UTC (rev 234623)
+++ branches/safari-606.1.36.0-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 22:02:43 UTC (rev 234624)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (234623 => 234624)

--- branches/safari-606.1.36.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 21:59:08 UTC (rev 234623)
+++ branches/safari-606.1.36.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 22:02:43 UTC (rev 234624)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (234623 => 234624)

--- branches/safari-606.1.36.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 21:59:08 UTC (rev 234623)
+++ branches/safari-606.1.36.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 22:02:43 UTC (rev 234624)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: branches/safari-606.1.36.0-branch/Source/WebKit/Configurations/Version.xcconfig (234623 =>

[webkit-changes] [234623] branches/safari-606.1.36.1-branch/Source/JavaScriptCore

2018-08-06 Thread kocsen_chung

Title: [234623] branches/safari-606.1.36.1-branch/Source/_javascript_Core








Revision 234623
Author kocsen_ch...@apple.com
Date 2018-08-06 14:59:08 -0700 (Mon, 06 Aug 2018)


Log Message
Cherry-pick r234576. rdar://problem/42973449

Give the `jsc` shell the JIT entitlement
https://bugs.webkit.org/show_bug.cgi?id=188324


Reviewed by Dan Bernstein.

This should help us in ensuring the system jsc is able to JIT.

* Configurations/JSC.xcconfig:
* _javascript_Core.xcodeproj/project.pbxproj:
* allow-jit-macOS.entitlements: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-606.1.36.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-606.1.36.1-branch/Source/_javascript_Core/Configurations/JSC.xcconfig
branches/safari-606.1.36.1-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj


Added Paths

branches/safari-606.1.36.1-branch/Source/_javascript_Core/allow-jit-macOS.entitlements




Diff

Modified: branches/safari-606.1.36.1-branch/Source/_javascript_Core/ChangeLog (234622 => 234623)

--- branches/safari-606.1.36.1-branch/Source/_javascript_Core/ChangeLog	2018-08-06 21:56:53 UTC (rev 234622)
+++ branches/safari-606.1.36.1-branch/Source/_javascript_Core/ChangeLog	2018-08-06 21:59:08 UTC (rev 234623)
@@ -1,3 +1,36 @@
+2018-08-06  Kocsen Chung  
+
+Cherry-pick r234576. rdar://problem/42973449
+
+Give the `jsc` shell the JIT entitlement
+https://bugs.webkit.org/show_bug.cgi?id=188324
+
+
+Reviewed by Dan Bernstein.
+
+This should help us in ensuring the system jsc is able to JIT.
+
+* Configurations/JSC.xcconfig:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* allow-jit-macOS.entitlements: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-08-03  Saam Barati  
+
+Give the `jsc` shell the JIT entitlement
+https://bugs.webkit.org/show_bug.cgi?id=188324
+
+
+Reviewed by Dan Bernstein.
+
+This should help us in ensuring the system jsc is able to JIT.
+
+* Configurations/JSC.xcconfig:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* allow-jit-macOS.entitlements: Added.
+
 2018-08-02  Babak Shafiei  
 
 Cherry-pick r234528. rdar://problem/42883788


Modified: branches/safari-606.1.36.1-branch/Source/_javascript_Core/Configurations/JSC.xcconfig (234622 => 234623)

--- branches/safari-606.1.36.1-branch/Source/_javascript_Core/Configurations/JSC.xcconfig	2018-08-06 21:56:53 UTC (rev 234622)
+++ branches/safari-606.1.36.1-branch/Source/_javascript_Core/Configurations/JSC.xcconfig	2018-08-06 21:59:08 UTC (rev 234623)
@@ -32,6 +32,7 @@
 
 PRODUCT_NAME = jsc;
 CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = entitlements.plist;
+CODE_SIGN_ENTITLEMENTS[sdk=macosx*] = allow-jit-macOS.entitlements;
 OTHER_CODE_SIGN_FLAGS[sdk=iphone*] = -i com.apple.jsc;
 
 // Explicitly add the PrivateHeaders directory to the search path so that generated header files can be found in production builds.


Modified: branches/safari-606.1.36.1-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (234622 => 234623)

--- branches/safari-606.1.36.1-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2018-08-06 21:56:53 UTC (rev 234622)
+++ branches/safari-606.1.36.1-branch/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj	2018-08-06 21:59:08 UTC (rev 234623)
@@ -3678,6 +3678,8 @@
 		79CFC6EF1C33B1C768EA /* LLIntPCRanges.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = LLIntPCRanges.h; path = llint/LLIntPCRanges.h; sourceTree = ""; };
 		79D5CD581C1106A900CECA07 /* SamplingProfiler.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SamplingProfiler.cpp; sourceTree = ""; };
 		79D5CD591C1106A900CECA07 /* SamplingProfiler.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SamplingProfiler.h; sourceTree = ""; };
+		79D7B0E121152FD200FE7C64 /* entitlements.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = entitlements.plist; sourceTree = ""; };
+		79D7B0E221152FD300FE7C64 /* allow-jit-macOS.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = "allow-jit-macOS.entitlements"; sourceTree = ""; };
 		79DAE2791E03C82200B526AA /* WasmExceptionType.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WasmExceptionType.h; sourceTree = ""; };
 		79DFCBDA1D88C59600527D03 /* HasOwnPropertyCache.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HasOwnPropertyCache.h; sourceTree = ""; };
 		79EE0BFD1B4AFB85000385C9 /*

[webkit-changes] [234622] branches/safari-606.1.36.1-branch/Source

2018-08-06 Thread kocsen_chung

Title: [234622] branches/safari-606.1.36.1-branch/Source








Revision 234622
Author kocsen_ch...@apple.com
Date 2018-08-06 14:56:53 -0700 (Mon, 06 Aug 2018)


Log Message
Versioning.

Modified Paths

branches/safari-606.1.36.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-606.1.36.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-606.1.36.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-606.1.36.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-606.1.36.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-606.1.36.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-606.1.36.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-606.1.36.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (234621 => 234622)

--- branches/safari-606.1.36.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 21:56:32 UTC (rev 234621)
+++ branches/safari-606.1.36.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-08-06 21:56:53 UTC (rev 234622)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (234621 => 234622)

--- branches/safari-606.1.36.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 21:56:32 UTC (rev 234621)
+++ branches/safari-606.1.36.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-08-06 21:56:53 UTC (rev 234622)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.1-branch/Source/WebCore/Configurations/Version.xcconfig (234621 => 234622)

--- branches/safari-606.1.36.1-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 21:56:32 UTC (rev 234621)
+++ branches/safari-606.1.36.1-branch/Source/WebCore/Configurations/Version.xcconfig	2018-08-06 21:56:53 UTC (rev 234622)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (234621 => 234622)

--- branches/safari-606.1.36.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 21:56:32 UTC (rev 234621)
+++ branches/safari-606.1.36.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-08-06 21:56:53 UTC (rev 234622)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-606.1.36.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (234621 => 234622)

--- branches/safari-606.1.36.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 21:56:32 UTC (rev 234621)
+++ branches/safari-606.1.36.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-08-06 21:56:53 UTC (rev 234622)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 36;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The

[webkit-changes] [234621] trunk/LayoutTests

2018-08-06 Thread rniwa

Title: [234621] trunk/LayoutTests








Revision 234621
Author rn...@webkit.org
Date 2018-08-06 14:56:32 -0700 (Mon, 06 Aug 2018)


Log Message
fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
https://bugs.webkit.org/show_bug.cgi?id=188353

Reviewed by Saam Barati.

Rely on GCController.collect() instead of allocating 1,000,000 objects in WebKitTestRunner / DumpRenderTree
so that debug builders won't timeout.

* fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234620 => 234621)

--- trunk/LayoutTests/ChangeLog	2018-08-06 21:08:53 UTC (rev 234620)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 21:56:32 UTC (rev 234621)
@@ -3,6 +3,18 @@
 fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
 https://bugs.webkit.org/show_bug.cgi?id=188353
 
+Reviewed by Saam Barati.
+
+Rely on GCController.collect() instead of allocating 1,000,000 objects in WebKitTestRunner / DumpRenderTree
+so that debug builders won't timeout.
+
+* fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html:
+
+2018-08-06  Ryosuke Niwa  
+
+fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
+https://bugs.webkit.org/show_bug.cgi?id=188353
+
 Add a timeout expectation to the test while I verify the fix for the test.
 
 * TestExpectations:


Modified: trunk/LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html (234620 => 234621)

--- trunk/LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html	2018-08-06 21:08:53 UTC (rev 234620)
+++ trunk/LayoutTests/fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html	2018-08-06 21:56:32 UTC (rev 234621)
@@ -13,10 +13,12 @@
 iframe.contentWindow.eval(`
 window.customElements.someProperty = 'storedValue';
 const a = [];
-for (let i = 0; i < 100; i++)
-a.push({});
 if (window.GCController)
 GCController.collect();
+else {
+for (let i = 0; i < 100; i++)
+a.push({});
+}
 top.check(window.customElements.someProperty);`);
 iframe.remove();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234618] trunk/LayoutTests

2018-08-06 Thread rniwa

Title: [234618] trunk/LayoutTests








Revision 234618
Author rn...@webkit.org
Date 2018-08-06 13:35:53 -0700 (Mon, 06 Aug 2018)


Log Message
fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
https://bugs.webkit.org/show_bug.cgi?id=188353

Add a timeout expectation to the test while I verify the fix for the test.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (234617 => 234618)

--- trunk/LayoutTests/ChangeLog	2018-08-06 20:30:05 UTC (rev 234617)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 20:35:53 UTC (rev 234618)
@@ -1,3 +1,12 @@
+2018-08-06  Ryosuke Niwa  
+
+fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html always timeouts on debug bots
+https://bugs.webkit.org/show_bug.cgi?id=188353
+
+Add a timeout expectation to the test while I verify the fix for the test.
+
+* TestExpectations:
+
 2018-08-03  Ryan Haddad  
 
 Unreviewed test gardening for mac-wk1.


Modified: trunk/LayoutTests/TestExpectations (234617 => 234618)

--- trunk/LayoutTests/TestExpectations	2018-08-06 20:30:05 UTC (rev 234617)
+++ trunk/LayoutTests/TestExpectations	2018-08-06 20:35:53 UTC (rev 234618)
@@ -2218,3 +2218,5 @@
 webkit.org/b/187762 http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html [ Failure ]
 
 webkit.org/b/187269 [ Debug ] imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_abort.html [ Skip ]
+
+webkit.org/b/188353 [ Debug ] fast/custom-elements/custom-element-registry-wrapper-should-stay-alive.html [ Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234617] branches/safari-606.1.36.1-branch/

2018-08-06 Thread kocsen_chung

Title: [234617] branches/safari-606.1.36.1-branch/








Revision 234617
Author kocsen_ch...@apple.com
Date 2018-08-06 13:30:05 -0700 (Mon, 06 Aug 2018)


Log Message
New branch.

Added Paths

branches/safari-606.1.36.1-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234616] branches/safari-606.1.36.0-branch/

2018-08-06 Thread kocsen_chung

Title: [234616] branches/safari-606.1.36.0-branch/








Revision 234616
Author kocsen_ch...@apple.com
Date 2018-08-06 13:23:58 -0700 (Mon, 06 Aug 2018)


Log Message
New branch.

Added Paths

branches/safari-606.1.36.0-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234615] trunk/Source/WebKit

2018-08-06 Thread ryanhaddad

Title: [234615] trunk/Source/WebKit








Revision 234615
Author ryanhad...@apple.com
Date 2018-08-06 13:17:04 -0700 (Mon, 06 Aug 2018)


Log Message
Unreviewed, rolling out r234552.

Introduced 2 layout test failures on High Sierra.

Reverted changeset:

"Check with SafeBrowsing during navigation in WKWebView"
https://bugs.webkit.org/show_bug.cgi?id=188133
https://trac.webkit.org/changeset/234552

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h
trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
trunk/Source/WebKit/UIProcess/WebFramePolicyListenerProxy.cpp
trunk/Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h
trunk/Source/WebKit/UIProcess/WebFrameProxy.cpp
trunk/Source/WebKit/UIProcess/WebFrameProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/config.h


Removed Paths

trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingResultCocoa.mm
trunk/Source/WebKit/UIProcess/SafeBrowsingResult.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (234614 => 234615)

--- trunk/Source/WebKit/ChangeLog	2018-08-06 19:31:06 UTC (rev 234614)
+++ trunk/Source/WebKit/ChangeLog	2018-08-06 20:17:04 UTC (rev 234615)
@@ -1,5 +1,17 @@
 2018-08-06  Ryan Haddad  
 
+Unreviewed, rolling out r234552.
+
+Introduced 2 layout test failures on High Sierra.
+
+Reverted changeset:
+
+"Check with SafeBrowsing during navigation in WKWebView"
+https://bugs.webkit.org/show_bug.cgi?id=188133
+https://trac.webkit.org/changeset/234552
+
+2018-08-06  Ryan Haddad  
+
 Unreviewed, rolling out r234569.
 
 Breaks internal builds.


Modified: trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h (234614 => 234615)

--- trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h	2018-08-06 19:31:06 UTC (rev 234614)
+++ trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h	2018-08-06 20:17:04 UTC (rev 234615)
@@ -25,7 +25,7 @@
 
 #pragma once
 
-#if HAVE(SAFE_BROWSING)
+#if WK_API_ENABLED && ((PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 11))
 
 #import 
 
@@ -73,3 +73,4 @@
 #endif
 
 #endif
+


Deleted: trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingResultCocoa.mm (234614 => 234615)

--- trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingResultCocoa.mm	2018-08-06 19:31:06 UTC (rev 234614)
+++ trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingResultCocoa.mm	2018-08-06 20:17:04 UTC (rev 234615)
@@ -1,44 +0,0 @@
-/*
- * Copyright (C) 2018 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *notice, this list of conditions and the following disclaimer in the
- *documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#import "config.h"
-#import "SafeBrowsingResult.h"
-
-#import "SafeBrowsingSPI.h"
-
-namespace WebKit {
-
-#if HAVE(SAFE_BROWSING)
-SafeBrowsingResult::SafeBrowsingResult(SSBServiceLookupResult *result)
-: m_provider([result provider])
-, m_isPhishing([result isPhishing])
-, m_isMalware([result isMalware])
-, m_isUnwantedSoftware([result isUnwantedSoftware])
-, m_isKnownToBeUnsafe([result isKnownToBeUnsafe])
-{
-}
-#endif
-
-}


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm (234614 => 234615)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm	2018-08-06 19:31:06 UTC (rev 234614)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm	2018-08-06 20:17:04 UTC (rev 234615)
@@ -30,14 +30,11 @@
 #import "DataDetectionResult.h"
 #import "LoadParameters.h"
 #import "PageClient.h"
-#import "SafeBrowsingResult.h"
-#import "SafeBrowsingSPI.h"
 #import "WebProcessProxy.h"
 #import 
 #import 
 #import 
 #import 
-#import 
 #import

[webkit-changes] [234614] trunk/Tools

2018-08-06 Thread wenson_hsieh

Title: [234614] trunk/Tools








Revision 234614
Author wenson_hs...@apple.com
Date 2018-08-06 12:31:06 -0700 (Mon, 06 Aug 2018)


Log Message
[iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
https://bugs.webkit.org/show_bug.cgi?id=188322


Reviewed by Tim Horton.

Fixes an API test added in r234600, which had incorrect test expectations — namely, the width of the caret rect
was not in content view coordinates, unlike the x, y, and height.

* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(rounded):
(-[TestWKWebView waitForCaretViewFrameToBecome:]):
(-[TestWKWebView waitForSelectionViewRectsToBecome:]):
(TestWebKitAPI::TEST):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm




Diff

Modified: trunk/Tools/ChangeLog (234613 => 234614)

--- trunk/Tools/ChangeLog	2018-08-06 18:46:59 UTC (rev 234613)
+++ trunk/Tools/ChangeLog	2018-08-06 19:31:06 UTC (rev 234614)
@@ -1,3 +1,20 @@
+2018-08-06  Wenson Hsieh  
+
+[iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
+https://bugs.webkit.org/show_bug.cgi?id=188322
+
+
+Reviewed by Tim Horton.
+
+Fixes an API test added in r234600, which had incorrect test expectations — namely, the width of the caret rect
+was not in content view coordinates, unlike the x, y, and height.
+
+* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
+(rounded):
+(-[TestWKWebView waitForCaretViewFrameToBecome:]):
+(-[TestWKWebView waitForSelectionViewRectsToBecome:]):
+(TestWebKitAPI::TEST):
+
 2018-08-06  Ryan Haddad  
 
 Unreviewed, rolling out r234569.


Modified: trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm (234613 => 234614)

--- trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm	2018-08-06 18:46:59 UTC (rev 234613)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm	2018-08-06 19:31:06 UTC (rev 234614)
@@ -36,6 +36,11 @@
 
 @implementation TestWKWebView (KeyboardInputTests)
 
+static CGRect rounded(CGRect rect)
+{
+return CGRectMake(roundl(rect.origin.x), roundl(rect.origin.y), roundl(rect.size.width), roundl(rect.size.height));
+}
+
 - (void)waitForCaretViewFrameToBecome:(CGRect)frame
 {
 BOOL hasEmittedWarning = NO;
@@ -42,7 +47,7 @@
 NSTimeInterval secondsToWaitUntilWarning = 2;
 NSTimeInterval startTime = [NSDate timeIntervalSinceReferenceDate];
 while ([[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantPast]]) {
-CGRect currentFrame = self.caretViewRectInContentCoordinates;
+CGRect currentFrame = rounded(self.caretViewRectInContentCoordinates);
 if (CGRectEqualToRect(currentFrame, frame))
 break;
 
@@ -64,7 +69,7 @@
 BOOL selectionRectsMatch = YES;
 if (currentRects.count == selectionRects.count) {
 for (NSUInteger index = 0; index < selectionRects.count; ++index)
-selectionRectsMatch |= [selectionRects[index] isEqualToValue:currentRects[index]];
+selectionRectsMatch |= CGRectEqualToRect(selectionRects[index].CGRectValue, rounded(currentRects[index].CGRectValue));
 } else
 selectionRectsMatch = NO;
 
@@ -124,7 +129,7 @@
 
 TEST(KeyboardInputTests, CaretSelectionRectAfterRestoringFirstResponder)
 {
-auto expectedCaretRect = CGRectMake(16, 13, 3, 15);
+auto expectedCaretRect = CGRectMake(16, 13, 2, 15);
 auto webView = webViewWithAutofocusedInput();
 EXPECT_WK_STREQ("INPUT", [webView stringByEvaluatingJavaScript:@"document.activeElement.tagName"]);
 [webView waitForCaretViewFrameToBecome:expectedCaretRect];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234613] trunk

2018-08-06 Thread ryanhaddad

Title: [234613] trunk








Revision 234613
Author ryanhad...@apple.com
Date 2018-08-06 11:46:59 -0700 (Mon, 06 Aug 2018)


Log Message
Unreviewed, rolling out r234569.

Breaks internal builds.

Reverted changeset:

"We should cache the compiled sandbox profile in a data vault"
https://bugs.webkit.org/show_bug.cgi?id=184991
https://trac.webkit.org/changeset/234569

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/SystemTracing.h
trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FileHandle.cpp
trunk/Source/WebCore/platform/FileHandle.h
trunk/Source/WebCore/platform/FileSystem.h
trunk/Source/WebCore/platform/cocoa/FileSystemCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/StorageService.xcconfig
trunk/Source/WebKit/Configurations/WebKit.xcconfig
trunk/Source/WebKit/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit/PluginProcess/PluginProcess.h
trunk/Source/WebKit/Shared/ChildProcess.h
trunk/Source/WebKit/Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h
trunk/Source/WebKit/Shared/SandboxInitializationParameters.h
trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm
trunk/Source/WebKit/Shared/mac/SandboxInitialiationParametersMac.mm
trunk/Source/WebKit/StorageProcess/StorageProcess.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebProcess.h
trunk/Tools/ChangeLog
trunk/Tools/Tracing/SystemTracePoints.plist


Removed Paths

trunk/Source/WebKit/Configurations/Network-OSX-sandbox.entitlements
trunk/Source/WebKit/Configurations/Storage-OSX-sandbox.entitlements
trunk/Source/WebKit/Configurations/WebContent-OSX-sandbox.entitlements
trunk/Source/WebKit/Scripts/process-network-sandbox-entitlements.sh
trunk/Source/WebKit/Scripts/process-webcontent-sandbox-entitlements.sh




Diff

Modified: trunk/Source/WTF/ChangeLog (234612 => 234613)

--- trunk/Source/WTF/ChangeLog	2018-08-06 18:37:24 UTC (rev 234612)
+++ trunk/Source/WTF/ChangeLog	2018-08-06 18:46:59 UTC (rev 234613)
@@ -1,3 +1,15 @@
+2018-08-06  Ryan Haddad  
+
+Unreviewed, rolling out r234569.
+
+Breaks internal builds.
+
+Reverted changeset:
+
+"We should cache the compiled sandbox profile in a data vault"
+https://bugs.webkit.org/show_bug.cgi?id=184991
+https://trac.webkit.org/changeset/234569
+
 2018-08-03  Ryan Haddad  
 
 Unreviewed, fix the build by ignoring some deprecation warnings.


Modified: trunk/Source/WTF/wtf/SystemTracing.h (234612 => 234613)

--- trunk/Source/WTF/wtf/SystemTracing.h	2018-08-06 18:37:24 UTC (rev 234612)
+++ trunk/Source/WTF/wtf/SystemTracing.h	2018-08-06 18:46:59 UTC (rev 234613)
@@ -96,8 +96,6 @@
 CommitLayerTreeEnd,
 ProcessLaunchStart,
 ProcessLaunchEnd,
-InitializeSandboxStart,
-InitializeSandboxEnd,
 };
 
 #ifdef __cplusplus


Modified: trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h (234612 => 234613)

--- trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h	2018-08-06 18:37:24 UTC (rev 234612)
+++ trunk/Source/WTF/wtf/spi/darwin/SandboxSPI.h	2018-08-06 18:46:59 UTC (rev 234613)
@@ -42,21 +42,6 @@
 
 WTF_EXTERN_C_BEGIN
 
-typedef struct {
-char* builtin;
-unsigned char* data;
-size_t size;
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101300
-char* trace;
-#endif
-} *sandbox_profile_t;
-
-typedef struct {
-const char **params;
-size_t size;
-size_t available;
-} *sandbox_params_t;
-
 extern const char *const APP_SANDBOX_READ;
 extern const char *const APP_SANDBOX_READ_WRITE;
 extern const enum sandbox_filter_type SANDBOX_CHECK_NO_REPORT;
@@ -69,12 +54,6 @@
 int sandbox_extension_release(int64_t extension_handle);
 int sandbox_init_with_parameters(const char *profile, uint64_t flags, const char *const parameters[], char **errorbuf);
 int64_t sandbox_extension_consume(const char *extension_token);
-sandbox_params_t sandbox_create_params(void);
-int sandbox_set_param(sandbox_params_t, const char *key, const char *value);
-void sandbox_free_params(sandbox_params_t);
-sandbox_profile_t sandbox_compile_file(const char *path, sandbox_params_t, char **error);
-void sandbox_free_profile(sandbox_profile_t);
-int sandbox_apply(sandbox_profile_t);
 
 WTF_EXTERN_C_END
 


Modified: trunk/Source/WebCore/ChangeLog (234612 => 234613)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 18:37:24 UTC (rev 234612)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 18:46:59 UTC (rev 234613)
@@ -1,3 +1,15 @@
+2018-08-06  Ryan Haddad  
+
+Unreviewed, rolling out r234569.
+
+Breaks internal builds.
+
+Reverted changeset:
+
+"We should cache the compiled sandbox profile in a data vault"
+https://bugs.webkit.org/show_bug.cgi?id=184991
+https://trac.webkit.org/changeset/234569
+
 2018-08-06  Alex Christensen  
 
 Make BlendMode an enum class


Modified: trunk/Source/WebCore/platform/FileHandle.cpp (234612 => 234613)

---

[webkit-changes] [234612] trunk/LayoutTests

2018-08-06 Thread ryanhaddad

Title: [234612] trunk/LayoutTests








Revision 234612
Author ryanhad...@apple.com
Date 2018-08-06 11:37:24 -0700 (Mon, 06 Aug 2018)


Log Message
Unreviewed test gardening for mac-wk1.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (234611 => 234612)

--- trunk/LayoutTests/ChangeLog	2018-08-06 18:31:36 UTC (rev 234611)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 18:37:24 UTC (rev 234612)
@@ -1,3 +1,9 @@
+2018-08-03  Ryan Haddad  
+
+Unreviewed test gardening for mac-wk1.
+
+* platform/mac-wk1/TestExpectations:
+
 2018-08-06  Aditya Keerthi  
 
 [iOS] Indeterminate checkboxes appear unchecked


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (234611 => 234612)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-08-06 18:31:36 UTC (rev 234611)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-08-06 18:37:24 UTC (rev 234612)
@@ -606,3 +606,6 @@
 [ Mojave+ ] displaylists/extent-includes-transforms.html [ Failure ]
 [ Mojave+ ] displaylists/layer-dispay-list.html [ Failure ]
 [ Mojave+ ] displaylists/replay-skip-clipped-rect.html [ Failure ]
+
+# 
+[ Mojave+ ] compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234611] trunk/Source/WebKit

2018-08-06 Thread cdumez

Title: [234611] trunk/Source/WebKit








Revision 234611
Author cdu...@apple.com
Date 2018-08-06 11:31:36 -0700 (Mon, 06 Aug 2018)


Log Message
Fix IPC::Connection leak in StorageManager
https://bugs.webkit.org/show_bug.cgi?id=188321


Reviewed by Alex Christensen.

When a StorageMap is destroyed on WebContent process side, StorageManager::destroyStorageMap()
gets called via IPC with a (IPC::Connection, StorageMapID) pair. Normally, it removes this
pair from m_storageAreasByConnection. However, if this is a *transient* StorageMap (sessionStorage),
then we keep the pair in the map and we merely remove the StorageMapID as a listener from the
StorageArea. We do this so that:
1. The StorageArea stays alive so that it can be reused later on for the same security origin, on
   the same IPC::Connection (logic for this is in StorageManager::createTransientLocalStorageMap()
2. Removing the StorageMapID as a listener from the StorageArea is important because
   StorageArea::m_eventListeners holds a strong reference to the IPC::Connection in a std::pair
   with the StorageMapID (HashSet, uint64_t>> m_eventListeners).

As mentioned in 1 above, in StorageManager::createTransientLocalStorageMap(), there is logic to
check if there is already an existing StorageArea for the given IPC::Connection that is transient
and is for the same security origin. In this case, we could avoid constructing a new StorageArea
and we would:
1. Add a new entry to m_storageAreasByConnection with the key (connection, newStorageMapID), using
   same same StorageArea as value.
2. Remove the previous (connection, oldStorageMapID) key from m_storageAreasByConnection.

Step 2 here is wrong and is updated in this patch. It is only safe to remove the previous
(connection, oldStorageMapID) if this oldStorageMapID no longer exists (i.e. destroyStorageMap()
was already called for it). This patch thus adds a check before removing (connection, oldStorageMapID)
from the HashMap to make sure that the oldStorageMapID is no longer a listener of the StorageArea).

This would cause leaks in the following case:
1. We construct a StorageArea for (connection1, storageMapId1)
2. We ask for a StorageArea for (connection1, storageMapId2) and decide to reuse the existing StorageArea
   since it has the same SecurityOrigin.
3. As a result of step2, we would remove (connection1, storageMapId1) from m_storageAreasByConnection
   and add (connection1, storageMapId2), even though there is still a StorageMap with storageMapId1
   on WebContent process side.
4. Later on, we would try to call destroyStorageMap(connection1, storageMap1), it would fail to find
   it in m_storageAreasByConnection and return early. It would therefore fail to remove storageMapId1
   as a listener of the StorageArea which still exists.
-> This would leak the IPC::Connection that there would be a std::pair, StorageMapID>
   with value (connection1, storageMap1) which would get leaked and it would ref the IPC::Connection.

This code should really be refactored to be less leak prone but I have kept the patch minimal for now
to facilitate cherry-picking.

Note that this would reproduce very easily on sina.com.cn, when clicking bold links at the top, which
opens new tabs to different pages in the same WebContent process. When closing all Safari windows, the
IPC::Connection for this WebContent process would stay alive.

* UIProcess/WebStorage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::hasListener const):
(WebKit::StorageManager::createTransientLocalStorageMap):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebStorage/StorageManager.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (234610 => 234611)

--- trunk/Source/WebKit/ChangeLog	2018-08-06 18:19:43 UTC (rev 234610)
+++ trunk/Source/WebKit/ChangeLog	2018-08-06 18:31:36 UTC (rev 234611)
@@ -1,3 +1,59 @@
+2018-08-06  Chris Dumez  
+
+Fix IPC::Connection leak in StorageManager
+https://bugs.webkit.org/show_bug.cgi?id=188321
+
+
+Reviewed by Alex Christensen.
+
+When a StorageMap is destroyed on WebContent process side, StorageManager::destroyStorageMap()
+gets called via IPC with a (IPC::Connection, StorageMapID) pair. Normally, it removes this
+pair from m_storageAreasByConnection. However, if this is a *transient* StorageMap (sessionStorage),
+then we keep the pair in the map and we merely remove the StorageMapID as a listener from the
+StorageArea. We do this so that:
+1. The StorageArea stays alive so that it can be reused later on for the same security origin, on
+   the same IPC::Connection (logic for this is in StorageManager::createTransientLocalStorageMap()
+2. Removing the StorageMapID as a listener from the StorageArea is important because
+   StorageArea::m_eventListeners holds a strong reference to the IPC::Connection in a std::pair
+   with the StorageMapID (HashSet,

[webkit-changes] [234610] trunk/Source

2018-08-06 Thread commit-queue

Title: [234610] trunk/Source








Revision 234610
Author commit-qu...@webkit.org
Date 2018-08-06 11:19:43 -0700 (Mon, 06 Aug 2018)


Log Message
Make BlendMode an enum class
https://bugs.webkit.org/show_bug.cgi?id=188325

Patch by Alex Christensen  on 2018-08-06
Reviewed by Darin Adler.

Source/WebCore:

No change in behavior.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator BlendMode const):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
* html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::State::State):
(WebCore::CanvasRenderingContext2DBase::setGlobalCompositeOperation):
(WebCore::CanvasRenderingContext2DBase::drawImageFromRect):
* platform/graphics/BitmapImage.h:
* platform/graphics/GraphicsContext.h:
(WebCore::ImagePaintingOptions::ImagePaintingOptions):
* platform/graphics/GraphicsContextImpl.h:
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties const):
* platform/graphics/GraphicsLayer.h:
* platform/graphics/GraphicsTypes.cpp:
(WebCore::parseBlendMode):
(WebCore::parseCompositeAndBlendOperator):
(WebCore::compositeOperatorName):
(WebCore::blendModeName):
(WebCore::operator<<):
* platform/graphics/GraphicsTypes.h:
* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
(PlatformCAFilters::setBlendingFiltersOnLayer):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::selectCGBlendMode):
* platform/graphics/cpu/arm/filters/FEBlendNEON.h:
(WebCore::FEBlend::platformApplyNEON):
* platform/graphics/displaylists/DisplayListItems.h:
* platform/graphics/displaylists/DisplayListRecorder.h:
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::externalRepresentation const):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateBlendMode):
(WebCore::RenderLayer::beginTransparencyLayers):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateBlendMode):
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::FillLayer):
(WebCore::FillLayer::hasOpaqueImage const):
* rendering/style/FillLayer.h:
(WebCore::FillLayer::initialFillBlendMode):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::setBlendMode):
(WebCore::RenderStyle::hasBlendMode const):
(WebCore::RenderStyle::blendMode const):
(WebCore::RenderStyle::initialBlendMode):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* svg/SVGAnimatedEnumeration.cpp:
(WebCore::enumerationValueForTargetAttribute):
* svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::SVGFEBlendElement):
(WebCore::SVGFEBlendElement::parseAttribute):
* svg/SVGFEBlendElement.h:
(WebCore::SVGPropertyTraits::highestEnumValue):
(WebCore::SVGPropertyTraits::toString):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::nativeImage):
(WebCore::SVGImage::drawPatternForContainer):
(WebCore::SVGImage::draw):

Source/WebKit:

* Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/html/HTMLImageElement.cpp
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
trunk/Source/WebCore/platform/graphics/BitmapImage.h
trunk/Source/WebCore/platform/graphics/GraphicsContext.h
trunk/Source/WebCore/platform/graphics/GraphicsContextImpl.h
trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp
trunk/Source/WebCore/platform/graphics/GraphicsLayer.h
trunk/Source/WebCore/platform/graphics/GraphicsTypes.cpp
trunk/Source/WebCore/platform/graphics/GraphicsTypes.h
trunk/Source/WebCore/platform/graphics/Image.cpp
trunk/Source/WebCore/platform/graphics/Image.h
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm
trunk/Source/WebCore/platform/graphics/cairo/CairoOperations.cpp
trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.cpp
trunk/Source/WebCore/platform/graphics/cairo/CairoUtilities.h
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.cpp
trunk/Source/WebCore/platform/graphics/cairo/GraphicsContextImplCairo.h
trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp
trunk/Source/WebCore/platform/graphics/cpu/arm/filters/FEBlendNEON.h
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h

[webkit-changes] [234609] trunk

2018-08-06 Thread commit-queue

Title: [234609] trunk








Revision 234609
Author commit-qu...@webkit.org
Date 2018-08-06 11:06:25 -0700 (Mon, 06 Aug 2018)


Log Message
[iOS] Indeterminate checkboxes appear unchecked
https://bugs.webkit.org/show_bug.cgi?id=160484


Patch by Aditya Keerthi  on 2018-08-06
Reviewed by Wenson Hsieh.

Source/WebCore:

Add support for rendering indeterminate checkboxes on iOS.

We now paint the unchecked appearance only if the checkbox is not checked and is
not indeterminate. Otherwise, we draw a checkmark if the checkbox is in the
checked state and a dash if the checkbox is in the indeterminate state. Both of
these states share the same dark background.

Test: fast/forms/ios/render-indeterminate-checkbox.html

* css/html.css:
(input[type="checkbox"]:indeterminate):
(input[type="checkbox"]:indeterminate:disabled):
* rendering/RenderThemeIOS.mm:
(WebCore::drawJoinedLines):
(WebCore::RenderThemeIOS::paintCheckboxDecorations):

LayoutTests:

Added reftest to ensure that the indeterminate checkbox does not appear the same
as an unchecked checkbox.

* fast/forms/ios/render-indeterminate-checkbox-expected-mismatch.html: Added.
* fast/forms/ios/render-indeterminate-checkbox.html: Added.
* platform/ios/fast/forms/indeterminate-expected.txt: Rebaseline.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/fast/forms/indeterminate-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/rendering/RenderThemeIOS.mm


Added Paths

trunk/LayoutTests/fast/forms/ios/render-indeterminate-checkbox-expected-mismatch.html
trunk/LayoutTests/fast/forms/ios/render-indeterminate-checkbox.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234608 => 234609)

--- trunk/LayoutTests/ChangeLog	2018-08-06 17:45:41 UTC (rev 234608)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 18:06:25 UTC (rev 234609)
@@ -1,3 +1,18 @@
+2018-08-06  Aditya Keerthi  
+
+[iOS] Indeterminate checkboxes appear unchecked
+https://bugs.webkit.org/show_bug.cgi?id=160484
+
+
+Reviewed by Wenson Hsieh.
+
+Added reftest to ensure that the indeterminate checkbox does not appear the same
+as an unchecked checkbox.  
+
+* fast/forms/ios/render-indeterminate-checkbox-expected-mismatch.html: Added.
+* fast/forms/ios/render-indeterminate-checkbox.html: Added.
+* platform/ios/fast/forms/indeterminate-expected.txt: Rebaseline.
+
 2018-08-06  Truitt Savell  
 
 storage/indexeddb/modern/opendatabase-after-storage-crash.html is causing tests in directory svg/ to timeout at random


Added: trunk/LayoutTests/fast/forms/ios/render-indeterminate-checkbox-expected-mismatch.html (0 => 234609)

--- trunk/LayoutTests/fast/forms/ios/render-indeterminate-checkbox-expected-mismatch.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/ios/render-indeterminate-checkbox-expected-mismatch.html	2018-08-06 18:06:25 UTC (rev 234609)
@@ -0,0 +1,10 @@
+
+
+
+
+Test passes if indeterminate checkbox appears different from unchecked checkbox.
+
+
+document.querySelector("input").indeterminate = true;
+
+


Added: trunk/LayoutTests/fast/forms/ios/render-indeterminate-checkbox.html (0 => 234609)

--- trunk/LayoutTests/fast/forms/ios/render-indeterminate-checkbox.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/ios/render-indeterminate-checkbox.html	2018-08-06 18:06:25 UTC (rev 234609)
@@ -0,0 +1,7 @@
+
+
+
+
+Test passes if indeterminate checkbox appears different from unchecked checkbox.
+
+


Modified: trunk/LayoutTests/platform/ios/fast/forms/indeterminate-expected.txt (234608 => 234609)

--- trunk/LayoutTests/platform/ios/fast/forms/indeterminate-expected.txt	2018-08-06 17:45:41 UTC (rev 234608)
+++ trunk/LayoutTests/platform/ios/fast/forms/indeterminate-expected.txt	2018-08-06 18:06:25 UTC (rev 234609)
@@ -7,4 +7,4 @@
 text run at (20,2) width 500: " This checkbox should look 50% transparent and should be in the mixed state."
   RenderText {#text} at (0,0) size 0x0
 layer at (10,11) size 16x16
-  RenderBlock {INPUT} at (2,3) size 16x16 [bgcolor=#FF02] [border: (1px solid #4C4C4C)]
+  RenderBlock {INPUT} at (2,3) size 16x16 [bgcolor=#00CC] [border: (1px solid #4C4C4C)]


Modified: trunk/Source/WebCore/ChangeLog (234608 => 234609)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 17:45:41 UTC (rev 234608)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 18:06:25 UTC (rev 234609)
@@ -1,3 +1,27 @@
+2018-08-06  Aditya Keerthi  
+
+[iOS] Indeterminate checkboxes appear unchecked
+https://bugs.webkit.org/show_bug.cgi?id=160484
+
+
+Reviewed by Wenson Hsieh.
+
+Add support for rendering indeterminate checkboxes on iOS.
+
+We now paint the unchecked appearance only if the checkbox is not checked and is
+not indeterminate. Otherwise, we draw a checkmark if the checkbox is in the
+checked state and a dash if the checkbox is in the

[webkit-changes] [234608] trunk

2018-08-06 Thread rniwa

Title: [234608] trunk








Revision 234608
Author rn...@webkit.org
Date 2018-08-06 10:45:41 -0700 (Mon, 06 Aug 2018)


Log Message
HTML parser should execute custom element reactions for setting attributes immediately after creating a custom element
https://bugs.webkit.org/show_bug.cgi?id=188336

Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Rebaseline the test now that the relevant test case is passing.

* web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children-expected.txt:

Source/WebCore:

Push and pop an element queue from the custom element reactions stack when constructing a custom element:
https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token

To do this, we instantiate CustomElementReactionStack in HTMLDocumentParser::runScriptsForPausedTreeBuilder
where we synchronously construct a custom element. We don't have to worry about whether *will execute script*
is set or not since the presence of an element queue should not be observable in the case where we're constructing
a fallback element (since it would not enqueue any new custom element reaction).

Tests: imported/w3c/web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children.html

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): Instantiate CustomElementReactionStack. Note that we
don't insert the custom element into the parser until we finish processing the custom element reactions.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (234607 => 234608)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-08-06 17:43:42 UTC (rev 234607)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-08-06 17:45:41 UTC (rev 234608)
@@ -1,3 +1,14 @@
+2018-08-06  Ryosuke Niwa  
+
+HTML parser should execute custom element reactions for setting attributes immediately after creating a custom element
+https://bugs.webkit.org/show_bug.cgi?id=188336
+
+Reviewed by Frédéric Wang.
+
+Rebaseline the test now that the relevant test case is passing.
+
+* web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children-expected.txt:
+
 2018-08-05  Yusuke Suzuki  
 
 Add support for microtasks in workers


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children-expected.txt (234607 => 234608)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children-expected.txt	2018-08-06 17:43:42 UTC (rev 234607)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children-expected.txt	2018-08-06 17:45:41 UTC (rev 234608)
@@ -3,5 +3,5 @@
 PASS HTML parser must append child nodes 
 PASS HTML parser must set the attributes or append children before calling constructor 
 FAIL HTML parser should call connectedCallback before appending child nodes. assert_equals: expected 0 but got 2
-FAIL HTML parser must enqueue attributeChanged reactions assert_equals: attributeChangedCallback should be called before appending a child expected 0 but got 2
+PASS HTML parser must enqueue attributeChanged reactions 
 hello world


Modified: trunk/Source/WebCore/ChangeLog (234607 => 234608)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 17:43:42 UTC (rev 234607)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 17:45:41 UTC (rev 234608)
@@ -1,3 +1,24 @@
+2018-08-06  Ryosuke Niwa  
+
+HTML parser should execute custom element reactions for setting attributes immediately after creating a custom element
+https://bugs.webkit.org/show_bug.cgi?id=188336
+
+Reviewed by Frédéric Wang.
+
+Push and pop an element queue from the custom element reactions stack when constructing a custom element:
+https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
+
+To do this, we instantiate CustomElementReactionStack in HTMLDocumentParser::runScriptsForPausedTreeBuilder
+where we synchronously construct a custom element. We don't have to worry about whether *will execute script*
+is set or not since the presence of an element queue should not be observable in the case where we're constructing
+a fallback element (since it would not enqueue any new custom element reaction).
+
+Tests: imported/w3c/web-platform-tests/custom-elements/parser/parser-sets-attributes-and-children.html
+
+* html/parser/HTMLDocumentParser.cpp:
+(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): Instantiate CustomElementReactionStack. Note that we
+don't insert the custom element into the

[webkit-changes] [234607] trunk/Tools

2018-08-06 Thread Hironori . Fujii

Title: [234607] trunk/Tools








Revision 234607
Author hironori.fu...@sony.com
Date 2018-08-06 10:43:42 -0700 (Mon, 06 Aug 2018)


Log Message
[Win][DLLLauncher] Remove --highDPI switch
https://bugs.webkit.org/show_bug.cgi?id=188255

Reviewed by Yusuke Suzuki.

Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
became useless since the change. Remove the switch.

This change fixes the issue all dump render tree tests are failing
in WinCairo port if high DPI display is connected.

* MiniBrowser/win/Common.cpp:
(parseCommandLine): Removed `--highDPI` switch.
* win/DLLLauncher/DLLLauncherMain.cpp:
(wWinMain): Do not call SetProcessDPIAware.
(shouldUseHighDPI): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/win/Common.cpp
trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp




Diff

Modified: trunk/Tools/ChangeLog (234606 => 234607)

--- trunk/Tools/ChangeLog	2018-08-06 17:25:13 UTC (rev 234606)
+++ trunk/Tools/ChangeLog	2018-08-06 17:43:42 UTC (rev 234607)
@@ -1,3 +1,23 @@
+2018-08-06  Fujii Hironori  
+
+[Win][DLLLauncher] Remove --highDPI switch
+https://bugs.webkit.org/show_bug.cgi?id=188255
+
+Reviewed by Yusuke Suzuki.
+
+Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
+aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
+became useless since the change. Remove the switch.
+
+This change fixes the issue all dump render tree tests are failing
+in WinCairo port if high DPI display is connected.
+
+* MiniBrowser/win/Common.cpp:
+(parseCommandLine): Removed `--highDPI` switch.
+* win/DLLLauncher/DLLLauncherMain.cpp:
+(wWinMain): Do not call SetProcessDPIAware.
+(shouldUseHighDPI): Deleted.
+
 2018-08-06  Wenson Hsieh  
 
 [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+


Modified: trunk/Tools/MiniBrowser/win/Common.cpp (234606 => 234607)

--- trunk/Tools/MiniBrowser/win/Common.cpp	2018-08-06 17:25:13 UTC (rev 234606)
+++ trunk/Tools/MiniBrowser/win/Common.cpp	2018-08-06 17:43:42 UTC (rev 234607)
@@ -178,8 +178,6 @@
 options.useFullDesktop = true;
 else if (!wcsicmp(argv[i], L"--performance"))
 options.pageLoadTesting = true;
-else if (!wcsicmp(argv[i], L"--highDPI"))
-continue; // ignore
 else if (!wcsicmp(argv[i], L"--wk1") || !wcsicmp(argv[i], L"--legacy"))
 options.windowType = MainWindow::BrowserWindowType::WebKitLegacy;
 #if ENABLE(WEBKIT)


Modified: trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp (234606 => 234607)

--- trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp	2018-08-06 17:25:13 UTC (rev 234606)
+++ trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp	2018-08-06 17:43:42 UTC (rev 234607)
@@ -167,22 +167,6 @@
 return errorMessage;
 }
 
-static bool shouldUseHighDPI()
-{
-#ifdef WIN_CAIRO
-return true;
-#else
-int argc = 0;
-WCHAR** argv = CommandLineToArgvW(GetCommandLineW(), );
-for (int i = 1; i < argc; ++i) {
-if (!wcsicmp(argv[i], L"--highDPI"))
-return true;
-}
-
-return false;
-#endif
-}
-
 #if USE_CONSOLE_ENTRY_POINT
 int main(int argc, const char* argv[])
 #else
@@ -189,11 +173,6 @@
 int WINAPI wWinMain(_In_ HINSTANCE hInstance, _In_opt_ HINSTANCE hPrevInstance, _In_ LPWSTR lpstrCmdLine, _In_ int nCmdShow)
 #endif
 {
-if (shouldUseHighDPI()) {
-BOOL didIt = SetProcessDPIAware();
-_ASSERT(didIt);
-}
-
 #ifdef _CRTDBG_MAP_ALLOC
 _CrtSetReportFile(_CRT_WARN, _CRTDBG_FILE_STDERR);
 _CrtSetReportMode(_CRT_WARN, _CRTDBG_MODE_FILE);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234606] trunk/Source/WTF

2018-08-06 Thread ryanhaddad

Title: [234606] trunk/Source/WTF








Revision 234606
Author ryanhad...@apple.com
Date 2018-08-06 10:25:13 -0700 (Mon, 06 Aug 2018)


Log Message
Unreviewed, fix the build by ignoring some deprecation warnings.

* wtf/MD5.cpp:
(WTF::MD5::MD5):
(WTF::MD5::addBytes):
(WTF::MD5::checksum):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/MD5.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (234605 => 234606)

--- trunk/Source/WTF/ChangeLog	2018-08-06 17:12:24 UTC (rev 234605)
+++ trunk/Source/WTF/ChangeLog	2018-08-06 17:25:13 UTC (rev 234606)
@@ -1,3 +1,12 @@
+2018-08-03  Ryan Haddad  
+
+Unreviewed, fix the build by ignoring some deprecation warnings.
+
+* wtf/MD5.cpp:
+(WTF::MD5::MD5):
+(WTF::MD5::addBytes):
+(WTF::MD5::checksum):
+
 2018-08-03  Ben Richards  
 
 We should cache the compiled sandbox profile in a data vault


Modified: trunk/Source/WTF/wtf/MD5.cpp (234605 => 234606)

--- trunk/Source/WTF/wtf/MD5.cpp	2018-08-06 17:12:24 UTC (rev 234605)
+++ trunk/Source/WTF/wtf/MD5.cpp	2018-08-06 17:25:13 UTC (rev 234606)
@@ -59,17 +59,26 @@
 
 MD5::MD5()
 {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 CC_MD5_Init(_context);
+#pragma clang diagnostic pop
 }
 
 void MD5::addBytes(const uint8_t* input, size_t length)
 {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 CC_MD5_Update(_context, input, length);
+#pragma clang diagnostic pop
 }
 
 void MD5::checksum(Digest& hash)
 {
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 CC_MD5_Final(hash.data(), _context);
+#pragma clang diagnostic pop
 }
 
 #else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234605] releases/WPE WebKit/webkit-2.20.2/

2018-08-06 Thread aperez

Title: [234605] releases/WPE WebKit/webkit-2.20.2/








Revision 234605
Author ape...@igalia.com
Date 2018-08-06 10:12:24 -0700 (Mon, 06 Aug 2018)


Log Message
WPE WebKit 2.20.2

Added Paths

releases/WPE WebKit/webkit-2.20.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234604] releases/WebKitGTK/webkit-2.20/Source

2018-08-06 Thread aperez

Title: [234604] releases/WebKitGTK/webkit-2.20/Source








Revision 234604
Author ape...@igalia.com
Date 2018-08-06 10:11:11 -0700 (Mon, 06 Aug 2018)


Log Message
Unreviewed. Update OptionsWPE.cmake and NEWS for 2.20.2 release.

Modified Paths

releases/WebKitGTK/webkit-2.20/Source/WebKit/wpe/NEWS
releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsWPE.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/wpe/NEWS (234603 => 234604)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/wpe/NEWS	2018-08-06 16:47:21 UTC (rev 234603)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/wpe/NEWS	2018-08-06 17:11:11 UTC (rev 234604)
@@ -1,4 +1,15 @@
 =
+WPE WebKit 2.20.2
+=
+
+What's new in WPE WebKit 2.20.1?
+
+  - Fix a rendering bug which would occasionally cause frames to be dropped when animating
+elements using requestAnimationFrame().
+  - Security fixes: CVE-2018-4261, CVE-2018-4262, CVE-2018-4263, CVE-2018-4264, CVE-2018-4265, CVE-2018-4266,
+CVE-2018-4267, CVE-2018-4270, CVE-2018-4272, CVE-2018-4273, CVE-2018-4278, CVE-2018-4284.
+
+=
 WPE WebKit 2.20.1
 =
 


Modified: releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsWPE.cmake (234603 => 234604)

--- releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsWPE.cmake	2018-08-06 16:47:21 UTC (rev 234603)
+++ releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsWPE.cmake	2018-08-06 17:11:11 UTC (rev 234604)
@@ -1,10 +1,10 @@
 include(GNUInstallDirs)
 include(VersioningUtils)
 
-SET_PROJECT_VERSION(2 20 1)
+SET_PROJECT_VERSION(2 20 2)
 set(WPE_API_VERSION 0.1)
 
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 4 1)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 5 1)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234603] trunk/Source/WebCore

2018-08-06 Thread cturner

Title: [234603] trunk/Source/WebCore








Revision 234603
Author ctur...@igalia.com
Date 2018-08-06 09:47:21 -0700 (Mon, 06 Aug 2018)


Log Message
Return extracted key ids as an optional
https://bugs.webkit.org/show_bug.cgi?id=188303

Reviewed by Darin Adler.

An empty list of extracted key ids was being considered a failure
case before this patch. In the PSSH boxes from the CENC standard,
it's not uncommon for the box to be version 0, meaning it has no
embedded key ids, so the case when there's an empty list should
not be treated as an error. Given this, the interface should be
more general and allow for a sentinel value indicating a parsing
error rather than an absence of key ids.

Covered by existing tests.

* Modules/encryptedmedia/InitDataRegistry.cpp:
(WebCore::extractKeyIDsKeyids): Change return type to be wrapped
in an optional, and make parsing errors return a nullopt rather
than an empty vector.
(WebCore::sanitizeKeyids): Use the new optional interface, return
a null RefPtr in the case of a parsing error, this method may now
return an empty vector.
(WebCore::extractKeyIDsCenc): Not implemented, so return an error
value rather than an empty vector.
(WebCore::extractKeyIDsWebM): Ditto.
(WebCore::InitDataRegistry::extractKeyIDs): Ditto.
* Modules/encryptedmedia/InitDataRegistry.h: Update the interface
to use an optional return type.
* platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsSinf): Update
to use the new interface.
(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsSkd): Ditto.
* platform/graphics/avfoundation/CDMFairPlayStreaming.h: Ditto.
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::keyIDs): Convert
the optional value into a vector, since it is assumed you can not
have an empty vector of key ids in the init datas FPS supports.
* testing/MockCDMFactory.cpp:
(WebCore::MockCDMInstance::requestLicense): Only return an error
if there really was a parsing error, rather than the case of there
being zero key ids in the init data payload.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp
trunk/Source/WebCore/Modules/encryptedmedia/InitDataRegistry.h
trunk/Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp
trunk/Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm
trunk/Source/WebCore/testing/MockCDMFactory.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (234602 => 234603)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 16:13:19 UTC (rev 234602)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 16:47:21 UTC (rev 234603)
@@ -1,3 +1,47 @@
+2018-08-06  Charlie Turner  
+
+Return extracted key ids as an optional
+https://bugs.webkit.org/show_bug.cgi?id=188303
+
+Reviewed by Darin Adler.
+
+An empty list of extracted key ids was being considered a failure
+case before this patch. In the PSSH boxes from the CENC standard,
+it's not uncommon for the box to be version 0, meaning it has no
+embedded key ids, so the case when there's an empty list should
+not be treated as an error. Given this, the interface should be
+more general and allow for a sentinel value indicating a parsing
+error rather than an absence of key ids.
+
+Covered by existing tests.
+
+* Modules/encryptedmedia/InitDataRegistry.cpp:
+(WebCore::extractKeyIDsKeyids): Change return type to be wrapped
+in an optional, and make parsing errors return a nullopt rather
+than an empty vector.
+(WebCore::sanitizeKeyids): Use the new optional interface, return
+a null RefPtr in the case of a parsing error, this method may now
+return an empty vector.
+(WebCore::extractKeyIDsCenc): Not implemented, so return an error
+value rather than an empty vector.
+(WebCore::extractKeyIDsWebM): Ditto.
+(WebCore::InitDataRegistry::extractKeyIDs): Ditto.
+* Modules/encryptedmedia/InitDataRegistry.h: Update the interface
+to use an optional return type.
+* platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
+(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsSinf): Update
+to use the new interface.
+(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsSkd): Ditto.
+* platform/graphics/avfoundation/CDMFairPlayStreaming.h: Ditto.
+* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
+(WebCore::CDMInstanceFairPlayStreamingAVFObjC::keyIDs): Convert
+the optional value into a vector, since it is assumed you can not
+have an empty vector of key ids in the init datas FPS supports.
+* testing/MockCDMFactory.cpp:
+

[webkit-changes] [234602] trunk/LayoutTests

2018-08-06 Thread tsavell

Title: [234602] trunk/LayoutTests








Revision 234602
Author tsav...@apple.com
Date 2018-08-06 09:13:19 -0700 (Mon, 06 Aug 2018)


Log Message
storage/indexeddb/modern/opendatabase-after-storage-crash.html is causing tests in directory svg/ to timeout at random
https://bugs.webkit.org/show_bug.cgi?id=187931

Unreviewed test gardening.

* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (234601 => 234602)

--- trunk/LayoutTests/ChangeLog	2018-08-06 15:01:47 UTC (rev 234601)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 16:13:19 UTC (rev 234602)
@@ -1,3 +1,12 @@
+2018-08-06  Truitt Savell  
+
+storage/indexeddb/modern/opendatabase-after-storage-crash.html is causing tests in directory svg/ to timeout at random
+https://bugs.webkit.org/show_bug.cgi?id=187931
+
+Unreviewed test gardening.
+
+* platform/wk2/TestExpectations:
+
 2018-08-06  Wenson Hsieh  
 
 [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+


Modified: trunk/LayoutTests/platform/wk2/TestExpectations (234601 => 234602)

--- trunk/LayoutTests/platform/wk2/TestExpectations	2018-08-06 15:01:47 UTC (rev 234601)
+++ trunk/LayoutTests/platform/wk2/TestExpectations	2018-08-06 16:13:19 UTC (rev 234602)
@@ -732,7 +732,7 @@
 http/wpt/cross-origin-resource-policy/ [ Pass ]
 
 http/tests/navigation/useragent-reload.php [ Pass ]
-storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Pass ]
+webkit.org/b/187931 storage/indexeddb/modern/opendatabase-after-storage-crash.html [ Skip ]
 
 
 ### END OF (5) Progressions, expected successes that are expected failures in WebKit1.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234601] trunk

2018-08-06 Thread wenson_hsieh

Title: [234601] trunk








Revision 234601
Author wenson_hs...@apple.com
Date 2018-08-06 08:01:47 -0700 (Mon, 06 Aug 2018)


Log Message
[iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
https://bugs.webkit.org/show_bug.cgi?id=188335
 and 

Reviewed by Tim Horton.

Tools:

Remove a UIScriptController helper method that attempted to wait for QuickType buttons to appear, and then send
touch events to the buttons. These were only used for the two tests which this patch refactors. See the
LayoutTests ChangeLog for more detail.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
(WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* TestRunnerShared/spi/UIKitTestSPI.h:

Remove an internal class declaration that is now unnecessary.

* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
(WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.

LayoutTests:

Refactors a couple of tests that currently rely on the QuickType bar being shown when the hardware keyboard is
presented in the iOS simulator, so that it can insert text suggestions by tapping QuickType bar buttons; in the
first place, it was never guaranteed that this bar would show up, or even have more than 1 text suggestion.
Instead, we use the existing UIScriptController::applyAutocorrection method to trigger text replacement in the
same way tapping a button on the QuickType bar would replace the current word with the suggested word.

* fast/events/ios/before-input-events-prevent-candidate-insertion-expected.txt:
* fast/events/ios/before-input-events-prevent-candidate-insertion.html:
* fast/events/ios/input-events-insert-replacement-text-expected.txt:
* fast/events/ios/input-events-insert-replacement-text.html:
* platform/ios/TestExpectations:

Removes a [Timeout] expectation.

* resources/ui-helper.js:
(window.UIHelper.typeCharacter):

Add a new UIHelper method to type a character using the keyboard. Sends hardware keyboard events on the WebKit2
port of iOS, and uses EventSender elsewhere.

(window.UIHelper.applyAutocorrection):

Add a new UIHelper method that wraps UIScriptController::applyAutocorrection. Only supported in WebKit2
currently.

(window.UIHelper):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/ios/before-input-events-prevent-candidate-insertion-expected.txt
trunk/LayoutTests/fast/events/ios/before-input-events-prevent-candidate-insertion.html
trunk/LayoutTests/fast/events/ios/input-events-insert-replacement-text-expected.txt
trunk/LayoutTests/fast/events/ios/input-events-insert-replacement-text.html
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/resources/ui-helper.js
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/ios/UIScriptControllerIOS.mm
trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp
trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
trunk/Tools/TestRunnerShared/spi/UIKitTestSPI.h
trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (234600 => 234601)

--- trunk/LayoutTests/ChangeLog	2018-08-06 14:14:42 UTC (rev 234600)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 15:01:47 UTC (rev 234601)
@@ -1,5 +1,40 @@
 2018-08-06  Wenson Hsieh  
 
+[iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
+https://bugs.webkit.org/show_bug.cgi?id=188335
+ and 
+
+Reviewed by Tim Horton.
+
+Refactors a couple of tests that currently rely on the QuickType bar being shown when the hardware keyboard is
+presented in the iOS simulator, so that it can insert text suggestions by tapping QuickType bar buttons; in the
+first place, it was never guaranteed that this bar would show up, or even have more than 1 text suggestion.
+Instead, we use the existing UIScriptController::applyAutocorrection method to trigger text replacement in the
+same way tapping a button on the QuickType bar would replace the current word with the suggested word.
+
+* fast/events/ios/before-input-events-prevent-candidate-insertion-expected.txt:
+* fast/events/ios/before-input-events-prevent-candidate-insertion.html:
+* fast/events/ios/input-events-insert-replacement-text-expected.txt:
+* fast/events/ios/input-events-insert-replacement-text.html:
+* platform/ios/TestExpectations:
+
+Removes a [Timeout] expectation.
+
+* resources/ui-helper.js:
+

[webkit-changes] [234600] trunk

2018-08-06 Thread wenson_hsieh

Title: [234600] trunk








Revision 234600
Author wenson_hs...@apple.com
Date 2018-08-06 07:14:42 -0700 (Mon, 06 Aug 2018)


Log Message
[iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
https://bugs.webkit.org/show_bug.cgi?id=188322


Reviewed by Tim Horton.

Source/WebKit:

Prior to r230745, when a user selects a word in non-editable web content without a prior selection, we would
always try to activate the text interaction assistant, creating a selection view (a UITextSelectionView). After
the long press is recognized, this text selection view is configured for "highlight mode", which is a special
mode for presenting selection UI where the grabber handles at the start and end of the selection are suppressed.
UIKit then prepares to show the selection by asking WKContentView for the number of selection rects; if this
number is zero, the UITextSelectionView is removed from the superview, and state that keeps track of whether the
selection view is in "highlight mode" is reset.

In the case where there's no prior selection, our cached EditorState in the UI process will not be up to date
yet when the gesture is recognized. This means that when UIKit asks us for the number of selection rects, we'll
return 0, which causes any state tracking "highlight mode" for the selection to be reset, subsequently resulting
in selection handles showing up before the user has ended the initial loupe gesture.

r230745 addressed this bug by removing logic to activate the text selection when becoming first responder,
instead deferring until the next `-_selectionChanged` call with post-layout editor state data to activate the
selection. While this does ensure that selection handles don't erroneously appear, it also means that clients
that call -becomeFirstResponder to show selection UI and the keyboard in a web view while an element is already
focused will not have an active selection assistant (i.e. the selection view will still be hidden). One way this
happens is when Safari uses `-_retainActiveFocusedState` in combination with `-resignFirstResponder` and
`-becomeFirstResponder` to temporarily switch focus away from the web view when the URL bar is tapped.

To fix both the inactive selection after `-becomeFirstResponder` as well as the selection handles showing up
when performing a loupe gesture, we simply make the check in `-becomeFirstResponderForWebView` more nuanced.
Instead of always activating the selection or never activating the selection, only activate the selection if the
current editor state has information about a selection to avoid causing the selection view to be immediately
removed and "highlight mode" to be reset when selecting a word via loupe gesture for the first time.

Tests:  KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder
KeyboardInputTests.RangedSelectionRectAfterRestoringFirstResponder
editing/selection/ios/selection-handles-after-touch-end.html

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView becomeFirstResponderForWebView]):
(-[WKContentView canShowNonEmptySelectionView]):

Tools:

Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
test. Also adds new API tests to verify that when a web view resigns first responder, both caret and range
selection views are hidden, and when first responder status is restored, both caret and range selection views
are made visible again.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::selectionStartGrabberViewRect const):
(WTR::UIScriptController::selectionEndGrabberViewRect const):
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::selectionStartGrabberViewRect const):
(WTR::UIScriptController::selectionEndGrabberViewRect const):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(-[TestWKWebView waitForCaretViewFrameToBecome:]):
(-[TestWKWebView waitForSelectionViewRectsToBecome:]):
(webViewWithAutofocusedInput):

Pull out some common logic for creating a web view that allows programmatic focus to present the keyboard, and
immediately loading a web page with an autofocusing text field.

(TestWebKitAPI::TEST):
* TestWebKitAPI/cocoa/TestWKWebView.h:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView caretViewRectInContentCoordinates]):
(-[TestWKWebView selectionViewRectsInContentCoordinates]):
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::selectionStartGrabberViewRect const):
(WTR::UIScriptController::selectionEndGrabberViewRect const):

LayoutTests:

Adds a new layout test to verify that (1) selection handles are not shown when selecting a word by long
pressing prior to ending the touch, and (2) selection handles are shown after ending the touch.

*

[webkit-changes] [234599] trunk/Tools

2018-08-06 Thread wenson_hsieh

Title: [234599] trunk/Tools








Revision 234599
Author wenson_hs...@apple.com
Date 2018-08-06 06:59:04 -0700 (Mon, 06 Aug 2018)


Log Message
[iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
https://bugs.webkit.org/show_bug.cgi?id=188334


Reviewed by Tim Horton.

To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
and stores the completion callback ID for the previously dispatched events as vendor-defined data. When this
vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
it to a completion block, and invoke the completion block to signal that the previous HID event has been
processed.

This callback ID is an unsigned, so we tell IOKit that we need `sizeof(unsigned)` (4 bytes) to store it. On
shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `sizeof(CFIndex)`. When we later call
IOHIDEventGetIntegerValue to read the value of our vendor-defined data as a CFIndex, we get our expected
callback ID because the buffer was clamped to 8 bytes.

However, on recent iOS SDKs that contain the fix for , IOKit no longer clamps the size
of the vendor-defined data buffer to 8 bytes. This means that when we try to use IOHIDEventGetIntegerValue to
read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
the upper 4 bytes are garbage. In the case where any of these upper 4 bytes are non-zero, we fail to map the
callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
be thrown.

To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDEventGetIntegerValue's return type.

* WebKitTestRunner/ios/HIDEventGenerator.mm:
(+[HIDEventGenerator nextEventCallbackID]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):

Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by using auto and move semantics.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm




Diff

Modified: trunk/Tools/ChangeLog (234598 => 234599)

--- trunk/Tools/ChangeLog	2018-08-06 12:59:41 UTC (rev 234598)
+++ trunk/Tools/ChangeLog	2018-08-06 13:59:04 UTC (rev 234599)
@@ -1,3 +1,37 @@
+2018-08-06  Wenson Hsieh  
+
+[iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
+https://bugs.webkit.org/show_bug.cgi?id=188334
+
+
+Reviewed by Tim Horton.
+
+To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
+and stores the completion callback ID for the previously dispatched events as vendor-defined data. When this
+vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
+it to a completion block, and invoke the completion block to signal that the previous HID event has been
+processed.
+
+This callback ID is an unsigned, so we tell IOKit that we need `sizeof(unsigned)` (4 bytes) to store it. On
+shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `sizeof(CFIndex)`. When we later call
+IOHIDEventGetIntegerValue to read the value of our vendor-defined data as a CFIndex, we get our expected
+callback ID because the buffer was clamped to 8 bytes.
+
+However, on recent iOS SDKs that contain the fix for , IOKit no longer clamps the size
+of the vendor-defined data buffer to 8 bytes. This means that when we try to use IOHIDEventGetIntegerValue to
+read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
+the upper 4 bytes are garbage. In the case where any of these upper 4 bytes are non-zero, we fail to map the
+callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
+be thrown.
+
+To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDEventGetIntegerValue's return type.
+
+* WebKitTestRunner/ios/HIDEventGenerator.mm:
+(+[HIDEventGenerator nextEventCallbackID]):
+(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
+
+Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by using auto and move semantics.
+
 2018-08-03  Ben Richards  
 
 We should cache the compiled sandbox profile in a data vault


Modified: trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm (234598 => 234599)

--- trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm	2018-08-06 12:59:41 UTC (rev 234598)
+++ trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm	2018-08-06 13:59:04 UTC (rev 234599)
@@ -171,9 +171,9 @@
 return eventGenerator;
 }
 
-+ (unsigned)nextEventCallbackID
++ (CFIndex)nextEventCallbackID
 {
-static unsigned

[webkit-changes] [234598] trunk/LayoutTests

2018-08-06 Thread csaavedra

Title: [234598] trunk/LayoutTests








Revision 234598
Author csaave...@igalia.com
Date 2018-08-06 05:59:41 -0700 (Mon, 06 Aug 2018)


Log Message
[WPE] New webgl 2.0 failures.

Unreviewed gardening.
* platform/wpe/TestExpectations: Two webgl 2.0 tests are failing,
mark them.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (234597 => 234598)

--- trunk/LayoutTests/ChangeLog	2018-08-06 12:45:38 UTC (rev 234597)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 12:59:41 UTC (rev 234598)
@@ -1,5 +1,13 @@
 2018-08-06  Claudio Saavedra  
 
+[WPE] New webgl 2.0 failures.
+
+Unreviewed gardening.
+* platform/wpe/TestExpectations: Two webgl 2.0 tests are failing,
+mark them.
+
+2018-08-06  Claudio Saavedra  
+
 [GTK] Skip new webgl 2.0 tests. Unreviewed gardening.
 
 * platform/gtk/TestExpectations: Expanded webgl 2.0 skipped


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (234597 => 234598)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-08-06 12:45:38 UTC (rev 234597)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-08-06 12:59:41 UTC (rev 234598)
@@ -213,6 +213,10 @@
 webkit.org/b/169917 webgl/1.0.2/conformance/glsl/misc/shader-with-non-reserved-words.html [ Slow ]
 webkit.org/b/169917 webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Slow ]
 
+# webgl 2.0
+webkit.org/b/188346 webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader.html [ Failure ]
+webkit.org/b/188346 webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object.html [ Failure ]
+
 # fast/canvas/
 fast/canvas/canvas-blend-image.html [ Failure ]
 fast/canvas/canvas-blend-solid.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234597] trunk/LayoutTests

2018-08-06 Thread csaavedra

Title: [234597] trunk/LayoutTests








Revision 234597
Author csaave...@igalia.com
Date 2018-08-06 05:45:38 -0700 (Mon, 06 Aug 2018)


Log Message
[GTK] Skip new webgl 2.0 tests. Unreviewed gardening.

* platform/gtk/TestExpectations: Expanded webgl 2.0 skipped
test to include all, since there were new failures.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (234596 => 234597)

--- trunk/LayoutTests/ChangeLog	2018-08-06 09:56:08 UTC (rev 234596)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 12:45:38 UTC (rev 234597)
@@ -1,3 +1,10 @@
+2018-08-06  Claudio Saavedra  
+
+[GTK] Skip new webgl 2.0 tests. Unreviewed gardening.
+
+* platform/gtk/TestExpectations: Expanded webgl 2.0 skipped
+test to include all, since there were new failures.
+
 2018-08-06  Frederic Wang  
 
 ASSERTION !data.customElementReactionQueue() when creating custom element inside an SVG document


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (234596 => 234597)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-08-06 09:56:08 UTC (rev 234596)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-08-06 12:45:38 UTC (rev 234597)
@@ -551,7 +551,7 @@
 webkit.org/b/166536 inspector/canvas/requestContent-webgl2.html [ Skip ]
 webkit.org/b/166536 inspector/canvas/resolveCanvasContext-webgl2.html [ Skip ]
 webkit.org/b/166536 inspector/canvas/shaderProgram-add-remove-webgl2.html [ Skip ]
-webkit.org/b/166536 webgl/2.0.0/conformance2/glsl3 [ Skip ]
+webkit.org/b/166536 webgl/2.0.0/ [ Skip ]
 
 # These tests reference specific fonts on Mac port.
 Bug(GTK) fast/text/font-weights.html [ WontFix ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234596] trunk/Source/WebCore

2018-08-06 Thread commit-queue

Title: [234596] trunk/Source/WebCore








Revision 234596
Author commit-qu...@webkit.org
Date 2018-08-06 02:56:08 -0700 (Mon, 06 Aug 2018)


Log Message
Make two-arguments versions of scrollBy/scrollTo depend on the one-argument versions
https://bugs.webkit.org/show_bug.cgi?id=188300

Patch by Frederic Wang  on 2018-08-06
Reviewed by Darin Adler.

This patch refactors a bit the scrollBy/scrollTo code, so that the two-arguments versions
share the same code path as the more generic one-argument versions. In particular, this
helps to implement the ScrollBehavior option (bug 188043) since the one-argument versions
will require to distinguish between smooth and instant scrolling. The logic to normalize
non finite left/right values or to use a fallback when they are absent is also factored out
into ScrollToOptions.

References:
https://drafts.csswg.org/cssom-view/#dom-element-scroll
https://drafts.csswg.org/cssom-view/#dom-element-scrollby
https://drafts.csswg.org/cssom-view/#dom-window-scroll
https://drafts.csswg.org/cssom-view/#dom-window-scrollby

No new tests, behavior is unchanged.

* dom/Element.cpp:
(WebCore::Element::scrollBy): Make two-parameter version depends on one-parameter version
and rewrite the normalize / fallback logic.
(WebCore::Element::scrollTo): Rewrite the normalize / fallback logic.
(WebCore::normalizeNonFiniteValue): Deleted. The logic is moved to ScrollToOptions.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::scrollBy const): Make two-parameter version depends on one-parameter
version and rewrite the normalize / fallback logic.
(WebCore::DOMWindow::scrollTo const): Make two-parameter version depends on one-parameter
version and rewrite the normalize / fallback logic.
* page/ScrollToOptions.h: Add  to use std::isfinite
(WebCore::ScrollToOptions::normalizeNonFiniteCoordinatesOrFallBackTo): New function to
normalize left/right values or fallback to the specified value if it is missing.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/ScrollToOptions.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (234595 => 234596)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 09:24:36 UTC (rev 234595)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 09:56:08 UTC (rev 234596)
@@ -1,3 +1,39 @@
+2018-08-06  Frederic Wang  
+
+Make two-arguments versions of scrollBy/scrollTo depend on the one-argument versions
+https://bugs.webkit.org/show_bug.cgi?id=188300
+
+Reviewed by Darin Adler.
+
+This patch refactors a bit the scrollBy/scrollTo code, so that the two-arguments versions
+share the same code path as the more generic one-argument versions. In particular, this
+helps to implement the ScrollBehavior option (bug 188043) since the one-argument versions
+will require to distinguish between smooth and instant scrolling. The logic to normalize
+non finite left/right values or to use a fallback when they are absent is also factored out
+into ScrollToOptions.
+
+References:
+https://drafts.csswg.org/cssom-view/#dom-element-scroll
+https://drafts.csswg.org/cssom-view/#dom-element-scrollby
+https://drafts.csswg.org/cssom-view/#dom-window-scroll
+https://drafts.csswg.org/cssom-view/#dom-window-scrollby
+
+No new tests, behavior is unchanged.
+
+* dom/Element.cpp:
+(WebCore::Element::scrollBy): Make two-parameter version depends on one-parameter version
+and rewrite the normalize / fallback logic.
+(WebCore::Element::scrollTo): Rewrite the normalize / fallback logic.
+(WebCore::normalizeNonFiniteValue): Deleted. The logic is moved to ScrollToOptions.
+* page/DOMWindow.cpp:
+(WebCore::DOMWindow::scrollBy const): Make two-parameter version depends on one-parameter
+version and rewrite the normalize / fallback logic.
+(WebCore::DOMWindow::scrollTo const): Make two-parameter version depends on one-parameter
+version and rewrite the normalize / fallback logic.
+* page/ScrollToOptions.h: Add  to use std::isfinite
+(WebCore::ScrollToOptions::normalizeNonFiniteCoordinatesOrFallBackTo): New function to
+normalize left/right values or fallback to the specified value if it is missing.
+
 2018-08-06  Zan Dobersek  
 
 Unreviewed follow-up to r234594.


Modified: trunk/Source/WebCore/dom/Element.cpp (234595 => 234596)

--- trunk/Source/WebCore/dom/Element.cpp	2018-08-06 09:24:36 UTC (rev 234595)
+++ trunk/Source/WebCore/dom/Element.cpp	2018-08-06 09:56:08 UTC (rev 234596)
@@ -692,17 +692,15 @@
 
 void Element::scrollBy(const ScrollToOptions& options)
 {
-return scrollBy(options.left.value_or(0), options.top.value_or(0));
+ScrollToOptions scrollToOptions = normalizeNonFiniteCoordinatesOrFallBackTo(options, 0, 0);
+scrollToOptions.left.value() += scrollLeft();
+

[webkit-changes] [234595] trunk/Source/WebCore

2018-08-06 Thread zandobersek

Title: [234595] trunk/Source/WebCore








Revision 234595
Author zandober...@gmail.com
Date 2018-08-06 02:24:36 -0700 (Mon, 06 Aug 2018)


Log Message
Unreviewed follow-up to r234594.

Add missing constructor and destructor definitions for the bunch of new
classes that were added in that revision.

* platform/graphics/nicosia/NicosiaPlatformLayer.cpp:
(Nicosia::ContentLayer::ContentLayer):
(Nicosia::BackingStore::BackingStore):
(Nicosia::ImageBacking::ImageBacking):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (234594 => 234595)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 08:48:01 UTC (rev 234594)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 09:24:36 UTC (rev 234595)
@@ -1,5 +1,17 @@
 2018-08-06  Zan Dobersek  
 
+Unreviewed follow-up to r234594.
+
+Add missing constructor and destructor definitions for the bunch of new
+classes that were added in that revision.
+
+* platform/graphics/nicosia/NicosiaPlatformLayer.cpp:
+(Nicosia::ContentLayer::ContentLayer):
+(Nicosia::BackingStore::BackingStore):
+(Nicosia::ImageBacking::ImageBacking):
+
+2018-08-06  Zan Dobersek  
+
 [Nicosia] Add additional layer state classes, use impl-based approach to make them extendable
 https://bugs.webkit.org/show_bug.cgi?id=188341
 


Modified: trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.cpp (234594 => 234595)

--- trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.cpp	2018-08-06 08:48:01 UTC (rev 234594)
+++ trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.cpp	2018-08-06 09:24:36 UTC (rev 234595)
@@ -48,4 +48,32 @@
 CompositionLayer::~CompositionLayer() = default;
 CompositionLayer::Impl::~Impl() = default;
 
+
+ContentLayer::ContentLayer(const Impl::Factory& factory)
+: PlatformLayer(0)
+, m_impl(factory(*this))
+{
+}
+
+ContentLayer::~ContentLayer() = default;
+ContentLayer::Impl::~Impl() = default;
+
+
+BackingStore::BackingStore(const Impl::Factory& factory)
+: m_impl(factory(*this))
+{
+}
+
+BackingStore::~BackingStore() = default;
+BackingStore::Impl::~Impl() = default;
+
+
+ImageBacking::ImageBacking(const Impl::Factory& factory)
+: m_impl(factory(*this))
+{
+}
+
+ImageBacking::~ImageBacking() = default;
+ImageBacking::Impl::~Impl() = default;
+
 } // namespace Nicosia






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234594] trunk/Source/WebCore

2018-08-06 Thread zandobersek

Title: [234594] trunk/Source/WebCore








Revision 234594
Author zandober...@gmail.com
Date 2018-08-06 01:48:01 -0700 (Mon, 06 Aug 2018)


Log Message
[Nicosia] Add additional layer state classes, use impl-based approach to make them extendable
https://bugs.webkit.org/show_bug.cgi?id=188341

Reviewed by Carlos Garcia Campos.

Add the ContentLayer, BackingStore and ImageBacking classes in the
Nicosia namespace. State objects of CompositionLayer instances keep
references to objects of these classes depending on the content that's
presented in the associated GraphicsLayer.

ContentLayer derives from the PlatformLayer class. It's used for layers
that display things like WebGL and HTML5 canvas and media content in a
platform-specific way. In case of TextureMapper the hardware-accelerated
content is piped into that rendering pipeline.

BackingStore is meant to represent the painted contents of a layer. The
equivalent current functionality is using a tiled backing store that
has its contents copied into the CoordinatedBackingStore instance.

ImageBacking is used for a layer whose content is a simple Image object.
Image's pixel data is rasterized and again managed through
CoordinatedBackingStore for rendering.

All these classes, along with the CompositionLayer class, should now be
constructed with a factory function that returns an object that derives
the class-specific Impl interface. This will allow for simpler
implementation of different approaches in parallel. The TextureMapper
variants will be the first ones, replicating the current behavior as it
is implemented across classes in the CoordinatedGraphics and
TextureMapper layers.

* platform/graphics/nicosia/NicosiaPlatformLayer.cpp:
(Nicosia::CompositionLayer::CompositionLayer):
* platform/graphics/nicosia/NicosiaPlatformLayer.h:
(Nicosia::PlatformLayer::isContentLayer const):
(Nicosia::CompositionLayer::Impl::isTextureMapperImpl const):
(Nicosia::CompositionLayer::create):
(Nicosia::CompositionLayer::impl const):
(Nicosia::ContentLayer::Impl::isTextureMapperImpl const):
(Nicosia::ContentLayer::create):
(Nicosia::ContentLayer::impl const):
(Nicosia::BackingStore::Impl::isTextureMapperImpl const):
(Nicosia::BackingStore::create):
(Nicosia::BackingStore::impl const):
(Nicosia::ImageBacking::Impl::isTextureMapperImpl const):
(Nicosia::ImageBacking::create):
(Nicosia::ImageBacking::impl const):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.cpp
trunk/Source/WebCore/platform/graphics/nicosia/NicosiaPlatformLayer.h
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (234593 => 234594)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 08:46:30 UTC (rev 234593)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 08:48:01 UTC (rev 234594)
@@ -1,5 +1,57 @@
 2018-08-06  Zan Dobersek  
 
+[Nicosia] Add additional layer state classes, use impl-based approach to make them extendable
+https://bugs.webkit.org/show_bug.cgi?id=188341
+
+Reviewed by Carlos Garcia Campos.
+
+Add the ContentLayer, BackingStore and ImageBacking classes in the
+Nicosia namespace. State objects of CompositionLayer instances keep
+references to objects of these classes depending on the content that's
+presented in the associated GraphicsLayer.
+
+ContentLayer derives from the PlatformLayer class. It's used for layers
+that display things like WebGL and HTML5 canvas and media content in a
+platform-specific way. In case of TextureMapper the hardware-accelerated
+content is piped into that rendering pipeline.
+
+BackingStore is meant to represent the painted contents of a layer. The
+equivalent current functionality is using a tiled backing store that
+has its contents copied into the CoordinatedBackingStore instance.
+
+ImageBacking is used for a layer whose content is a simple Image object.
+Image's pixel data is rasterized and again managed through
+CoordinatedBackingStore for rendering.
+
+All these classes, along with the CompositionLayer class, should now be
+constructed with a factory function that returns an object that derives
+the class-specific Impl interface. This will allow for simpler
+implementation of different approaches in parallel. The TextureMapper
+variants will be the first ones, replicating the current behavior as it
+is implemented across classes in the CoordinatedGraphics and
+TextureMapper layers.
+
+* platform/graphics/nicosia/NicosiaPlatformLayer.cpp:
+(Nicosia::CompositionLayer::CompositionLayer):
+* platform/graphics/nicosia/NicosiaPlatformLayer.h:
+

[webkit-changes] [234593] trunk/Source

2018-08-06 Thread zandobersek

Title: [234593] trunk/Source








Revision 234593
Author zandober...@gmail.com
Date 2018-08-06 01:46:30 -0700 (Mon, 06 Aug 2018)


Log Message
[Nicosia] Add Nicosia::Scene
https://bugs.webkit.org/show_bug.cgi?id=188340

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Add the Nicosia::Scene class that controls the scene's state and enables
thread-safe updates to that state.

The State struct itself holds a set of all the layers in the scene, and
separates out the root layer specifically. An ID counter is also present
there, allowing consumers of this state to easily check for any updates.

A reference to the Nicosia::Scene object now replaces the
HashSet-and-root-layer pair in the CoordinatedGraphicsState struct.

* platform/TextureMapper.cmake:
* platform/graphics/nicosia/NicosiaScene.cpp: Added.
* platform/graphics/nicosia/NicosiaScene.h: Added.
(Nicosia::Scene::create):
(Nicosia::Scene::accessState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

Source/WebKit:

CompositingCoordinator spawns a Nicosia::Scene object that it shares
with the CoordinatedGraphicsSceneState instance. All the
Nicosia::CompositionLayer objects indirectly managed by
CompositingCoordinator are now stored in a local Nicosia::Scene::State
member object. Upon each flush that requires frame synchronization the
Nicosia::Scene object is updated in a thread-safe manner, increasing
the scene ID value as well as copying the local HashSet and root layer
values into the shared Scene object, allowing for the consumer (which
currently is the related CoordinatedGraphicsScene instance) to update
its output accordingly.

* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::CompositingCoordinator):
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit::CompositingCoordinator::createGraphicsLayer):
(WebKit::CompositingCoordinator::detachLayer):
(WebKit::CompositingCoordinator::attachLayer):
* WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/TextureMapper.cmake
trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp
trunk/Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h


Added Paths

trunk/Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp
trunk/Source/WebCore/platform/graphics/nicosia/NicosiaScene.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (234592 => 234593)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 08:25:34 UTC (rev 234592)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 08:46:30 UTC (rev 234593)
@@ -1,3 +1,27 @@
+2018-08-06  Zan Dobersek  
+
+[Nicosia] Add Nicosia::Scene
+https://bugs.webkit.org/show_bug.cgi?id=188340
+
+Reviewed by Carlos Garcia Campos.
+
+Add the Nicosia::Scene class that controls the scene's state and enables
+thread-safe updates to that state.
+
+The State struct itself holds a set of all the layers in the scene, and
+separates out the root layer specifically. An ID counter is also present
+there, allowing consumers of this state to easily check for any updates.
+
+A reference to the Nicosia::Scene object now replaces the
+HashSet-and-root-layer pair in the CoordinatedGraphicsState struct.
+
+* platform/TextureMapper.cmake:
+* platform/graphics/nicosia/NicosiaScene.cpp: Added.
+* platform/graphics/nicosia/NicosiaScene.h: Added.
+(Nicosia::Scene::create):
+(Nicosia::Scene::accessState):
+* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
+
 2018-08-06  Carlos Eduardo Ramalho  
 
 [GTK] Buttons are drawn too large, text not centered


Modified: trunk/Source/WebCore/platform/TextureMapper.cmake (234592 => 234593)

--- trunk/Source/WebCore/platform/TextureMapper.cmake	2018-08-06 08:25:34 UTC (rev 234592)
+++ trunk/Source/WebCore/platform/TextureMapper.cmake	2018-08-06 08:46:30 UTC (rev 234593)
@@ -52,6 +52,7 @@
 platform/graphics/nicosia/NicosiaPaintingEngineBasic.cpp
 platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp
 platform/graphics/nicosia/NicosiaPlatformLayer.cpp
+platform/graphics/nicosia/NicosiaScene.cpp
 
 platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp
 platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp


Added: trunk/Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp (0 => 234593)

--- trunk/Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp	(rev 0)
+++ trunk/Source/WebCore/platform/graphics/nicosia/NicosiaScene.cpp	2018-08-06 08:46:30 UTC (rev 234593)
@@ -0,0 +1,42 @@
+/*
+ * Copyright (C) 2018

[webkit-changes] [234592] trunk/Source/WebCore

2018-08-06 Thread commit-queue

Title: [234592] trunk/Source/WebCore








Revision 234592
Author commit-qu...@webkit.org
Date 2018-08-06 01:25:34 -0700 (Mon, 06 Aug 2018)


Log Message
[GTK] Buttons are drawn too large, text not centered
https://bugs.webkit.org/show_bug.cgi?id=185854

Patch by Carlos Eduardo Ramalho  on 2018-08-06
Reviewed by Carlos Garcia Campos.

Some pages require small buttons and the GTK theme was
drawing only down to a minimum size.

No new tests required. Current layout tests and ManualTests/gtk/theme.html
already cover it.

* platform/gtk/RenderThemeGadget.cpp:
(WebCore::RenderThemeGadget::create):
(WebCore::RenderThemeButtonGadget::RenderThemeButtonGadget): Added
(WebCore::RenderThemeButtonGadget::minimumSize const):
Allow sizes smaller than the minimum size.
* platform/gtk/RenderThemeGadget.h:
* platform/gtk/RenderThemeWidget.cpp:
(WebCore::RenderThemeButton::RenderThemeButton):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/RenderThemeGadget.cpp
trunk/Source/WebCore/platform/gtk/RenderThemeGadget.h
trunk/Source/WebCore/platform/gtk/RenderThemeWidget.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (234591 => 234592)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 08:25:29 UTC (rev 234591)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 08:25:34 UTC (rev 234592)
@@ -1,3 +1,25 @@
+2018-08-06  Carlos Eduardo Ramalho  
+
+[GTK] Buttons are drawn too large, text not centered
+https://bugs.webkit.org/show_bug.cgi?id=185854
+
+Reviewed by Carlos Garcia Campos.
+
+Some pages require small buttons and the GTK theme was
+drawing only down to a minimum size.
+
+No new tests required. Current layout tests and ManualTests/gtk/theme.html
+already cover it.
+
+* platform/gtk/RenderThemeGadget.cpp:
+(WebCore::RenderThemeGadget::create):
+(WebCore::RenderThemeButtonGadget::RenderThemeButtonGadget): Added
+(WebCore::RenderThemeButtonGadget::minimumSize const):
+Allow sizes smaller than the minimum size.
+* platform/gtk/RenderThemeGadget.h:
+* platform/gtk/RenderThemeWidget.cpp:
+(WebCore::RenderThemeButton::RenderThemeButton):
+
 2018-08-05  Yusuke Suzuki  
 
 Implement self.queueMicrotask in Workers


Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGadget.cpp (234591 => 234592)

--- trunk/Source/WebCore/platform/gtk/RenderThemeGadget.cpp	2018-08-06 08:25:29 UTC (rev 234591)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGadget.cpp	2018-08-06 08:25:34 UTC (rev 234592)
@@ -49,6 +49,8 @@
 return std::make_unique(info, parent, siblings, position);
 case RenderThemeGadget::Type::Scrollbar:
 return std::make_unique(info, parent, siblings, position);
+case RenderThemeGadget::Type::Button:
+return std::make_unique(info, parent, siblings, position);
 }
 
 ASSERT_NOT_REACHED();
@@ -386,6 +388,17 @@
 contentsRect.y() + (contentsRect.height() - stepperSize) / 2, stepperSize);
 }
 
+RenderThemeButtonGadget::RenderThemeButtonGadget(const Info& info, RenderThemeGadget* parent, const Vector siblings, unsigned position)
+: RenderThemeGadget(info, parent, siblings, position)
+{
+}
+
+IntSize RenderThemeButtonGadget::minimumSize() const
+{
+// Allow buttons to be smaller than the minimum size
+return IntSize();
+}
+
 } // namespace WebCore
 
 #endif // GTK_CHECK_VERSION(3, 20, 0)


Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGadget.h (234591 => 234592)

--- trunk/Source/WebCore/platform/gtk/RenderThemeGadget.h	2018-08-06 08:25:29 UTC (rev 234591)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGadget.h	2018-08-06 08:25:34 UTC (rev 234592)
@@ -50,7 +50,8 @@
 Radio,
 Arrow,
 Icon,
-Scrollbar
+Scrollbar,
+Button
 };
 
 struct Info {
@@ -169,6 +170,13 @@
 OptionSet m_steppers;
 };
 
+class RenderThemeButtonGadget final : public RenderThemeGadget {
+public:
+RenderThemeButtonGadget(const Info&, RenderThemeGadget* parent, const Vector siblings, unsigned position);
+
+IntSize minimumSize() const override;
+};
+
 } // namespace WebCore
 
 #endif // GTK_CHECK_VERSION(3, 20, 0)


Modified: trunk/Source/WebCore/platform/gtk/RenderThemeWidget.cpp (234591 => 234592)

--- trunk/Source/WebCore/platform/gtk/RenderThemeWidget.cpp	2018-08-06 08:25:29 UTC (rev 234591)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeWidget.cpp	2018-08-06 08:25:34 UTC (rev 234592)
@@ -182,7 +182,7 @@
 
 RenderThemeButton::RenderThemeButton(Default isDefault)
 {
-RenderThemeGadget::Info info = { RenderThemeGadget::Type::Generic, "button", { "text-button" } };
+RenderThemeGadget::Info info = { RenderThemeGadget::Type::Button, "button", { "text-button" } };
 if (isDefault == Default::Yes)
 info.classList.append("default");
 m_button = RenderThemeGadget::create(info);






___
webkit-changes mailing list

[webkit-changes] [234591] trunk/LayoutTests

2018-08-06 Thread commit-queue

Title: [234591] trunk/LayoutTests








Revision 234591
Author commit-qu...@webkit.org
Date 2018-08-06 01:25:29 -0700 (Mon, 06 Aug 2018)


Log Message
ASSERTION !data.customElementReactionQueue() when creating custom element inside an SVG document
https://bugs.webkit.org/show_bug.cgi?id=187802

The assertion has been removed in bug 188327. This patch updates the test expectations and
add some non-regression test to verify different cases of XML custom element construction.

Patch by Frederic Wang  on 2018-08-06
Reviewed by Ryosuke Niwa.

* TestExpectations: This test no longer crashes but times out because of bug 187800.
* fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt: Added.
* fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations


Added Paths

trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt
trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (234590 => 234591)

--- trunk/LayoutTests/ChangeLog	2018-08-06 08:14:21 UTC (rev 234590)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 08:25:29 UTC (rev 234591)
@@ -1,3 +1,17 @@
+2018-08-06  Frederic Wang  
+
+ASSERTION !data.customElementReactionQueue() when creating custom element inside an SVG document
+https://bugs.webkit.org/show_bug.cgi?id=187802
+
+The assertion has been removed in bug 188327. This patch updates the test expectations and
+add some non-regression test to verify different cases of XML custom element construction.
+
+Reviewed by Ryosuke Niwa.
+
+* TestExpectations: This test no longer crashes but times out because of bug 187800.
+* fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt: Added.
+* fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg: Added.
+
 2018-08-05  Yusuke Suzuki  
 
 Implement self.queueMicrotask in Workers


Modified: trunk/LayoutTests/TestExpectations (234590 => 234591)

--- trunk/LayoutTests/TestExpectations	2018-08-06 08:14:21 UTC (rev 234590)
+++ trunk/LayoutTests/TestExpectations	2018-08-06 08:25:29 UTC (rev 234591)
@@ -570,7 +570,7 @@
 
 # WPT tests for custom elements
 webkit.org/b/187800 imported/w3c/web-platform-tests/custom-elements/Document-createElement-svg.svg [ Skip ]
-webkit.org/b/187802 imported/w3c/web-platform-tests/custom-elements/parser/parser-uses-create-an-element-for-a-token-svg.svg [ Skip ]
+webkit.org/b/187800 imported/w3c/web-platform-tests/custom-elements/parser/parser-uses-create-an-element-for-a-token-svg.svg [ Skip ]
 
 # selectors
 webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-001.html [ ImageOnlyFailure ]


Added: trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt (0 => 234591)

--- trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt	2018-08-06 08:25:29 UTC (rev 234591)
@@ -0,0 +1 @@
+This test passes if it does not crash.


Added: trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg (0 => 234591)

--- trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg	(rev 0)
+++ trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg	2018-08-06 08:25:29 UTC (rev 234591)
@@ -0,0 +1,16 @@
+
+
+This test passes if it does not crash.
+
+
+
+");
+]]>
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234590] releases/WebKitGTK/webkit-2.20.4/

2018-08-06 Thread carlosgc

Title: [234590] releases/WebKitGTK/webkit-2.20.4/








Revision 234590
Author carlo...@webkit.org
Date 2018-08-06 01:14:21 -0700 (Mon, 06 Aug 2018)


Log Message
WebKitGTK+ 2.20.4

Added Paths

releases/WebKitGTK/webkit-2.20.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234589] releases/WebKitGTK/webkit-2.20

2018-08-06 Thread carlosgc

Title: [234589] releases/WebKitGTK/webkit-2.20








Revision 234589
Author carlo...@webkit.org
Date 2018-08-06 01:13:47 -0700 (Mon, 06 Aug 2018)


Log Message
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.20.4 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

* gtk/NEWS: Add release notes for 2.20.4.

Modified Paths

releases/WebKitGTK/webkit-2.20/ChangeLog
releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.20/Source/WebKit/gtk/NEWS
releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsGTK.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.20/ChangeLog (234588 => 234589)

--- releases/WebKitGTK/webkit-2.20/ChangeLog	2018-08-06 07:59:13 UTC (rev 234588)
+++ releases/WebKitGTK/webkit-2.20/ChangeLog	2018-08-06 08:13:47 UTC (rev 234589)
@@ -1,3 +1,9 @@
+2018-08-06  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.20.4 release.
+
+* Source/cmake/OptionsGTK.cmake: Bump version numbers.
+
 2018-06-11  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.20.3 release.


Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog (234588 => 234589)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog	2018-08-06 07:59:13 UTC (rev 234588)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/ChangeLog	2018-08-06 08:13:47 UTC (rev 234589)
@@ -1,3 +1,9 @@
+2018-08-06  Carlos Garcia Campos  
+
+Unreviewed. Update OptionsGTK.cmake and NEWS for 2.20.4 release.
+
+* gtk/NEWS: Add release notes for 2.20.4.
+
 2018-06-29  Miguel Gomez  
 
 [WPE] Some frames are dropped when using rAF to animate an element


Modified: releases/WebKitGTK/webkit-2.20/Source/WebKit/gtk/NEWS (234588 => 234589)

--- releases/WebKitGTK/webkit-2.20/Source/WebKit/gtk/NEWS	2018-08-06 07:59:13 UTC (rev 234588)
+++ releases/WebKitGTK/webkit-2.20/Source/WebKit/gtk/NEWS	2018-08-06 08:13:47 UTC (rev 234589)
@@ -1,4 +1,15 @@
 ==
+WebKitGTK+  2.20.4
+==
+
+What's new in WebKitGTK+ 2.20.4?
+
+  - Fix a crash when leaving accelerated compositing mode.
+  - Fix non-deterministic build failure due to missing _javascript_Core/JSContextRef.h.
+  - Security fixes: CVE-2018-4261, CVE-2018-4262, CVE-2018-4263, CVE-2018-4264, CVE-2018-4265, CVE-2018-4266,
+CVE-2018-4267, CVE-2018-4270, CVE-2018-4272, CVE-2018-4273, CVE-2018-4278, CVE-2018-4284.
+
+==
 WebKitGTK+  2.20.3
 ==
 


Modified: releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsGTK.cmake (234588 => 234589)

--- releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsGTK.cmake	2018-08-06 07:59:13 UTC (rev 234588)
+++ releases/WebKitGTK/webkit-2.20/Source/cmake/OptionsGTK.cmake	2018-08-06 08:13:47 UTC (rev 234589)
@@ -1,11 +1,11 @@
 include(GNUInstallDirs)
 include(VersioningUtils)
 
-SET_PROJECT_VERSION(2 20 3)
+SET_PROJECT_VERSION(2 20 4)
 set(WEBKITGTK_API_VERSION 4.0)
 
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 65 3 28)
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 25 11 7)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 65 4 28)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 25 12 7)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [234588] trunk

2018-08-06 Thread utatane . tea

Title: [234588] trunk








Revision 234588
Author utatane@gmail.com
Date 2018-08-06 00:59:13 -0700 (Mon, 06 Aug 2018)


Log Message
Implement self.queueMicrotask in Workers
https://bugs.webkit.org/show_bug.cgi?id=188247

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds support for self.queueMicrotask to workers.

Tests: http/wpt/workers/queue-microtask.any.html
   http/wpt/workers/queue-microtask.any.worker.html

* bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::queueMicrotask):
* page/DOMWindow.idl:
Move queueMicrotask declaration to WindowOrWorkerGlobalScope.idl.
* page/WindowOrWorkerGlobalScope.idl:

LayoutTests:

* http/wpt/workers/queue-microtask.any-expected.txt: Added.
* http/wpt/workers/queue-microtask.any.html: Added.
* http/wpt/workers/queue-microtask.any.js: Added.
(promise_test):
(promise_test.):
(queueMicrotask.promise_test):
(test):
* http/wpt/workers/queue-microtask.any.worker-expected.txt: Added.
* http/wpt/workers/queue-microtask.any.worker.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp
trunk/Source/WebCore/page/DOMWindow.idl
trunk/Source/WebCore/page/WindowOrWorkerGlobalScope.idl


Added Paths

trunk/LayoutTests/http/wpt/workers/queue-microtask.any-expected.txt
trunk/LayoutTests/http/wpt/workers/queue-microtask.any.html
trunk/LayoutTests/http/wpt/workers/queue-microtask.any.js
trunk/LayoutTests/http/wpt/workers/queue-microtask.any.worker-expected.txt
trunk/LayoutTests/http/wpt/workers/queue-microtask.any.worker.html




Diff

Modified: trunk/LayoutTests/ChangeLog (234587 => 234588)

--- trunk/LayoutTests/ChangeLog	2018-08-06 06:43:51 UTC (rev 234587)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 07:59:13 UTC (rev 234588)
@@ -1,3 +1,20 @@
+2018-08-05  Yusuke Suzuki  
+
+Implement self.queueMicrotask in Workers
+https://bugs.webkit.org/show_bug.cgi?id=188247
+
+Reviewed by Ryosuke Niwa.
+
+* http/wpt/workers/queue-microtask.any-expected.txt: Added.
+* http/wpt/workers/queue-microtask.any.html: Added.
+* http/wpt/workers/queue-microtask.any.js: Added.
+(promise_test):
+(promise_test.):
+(queueMicrotask.promise_test):
+(test):
+* http/wpt/workers/queue-microtask.any.worker-expected.txt: Added.
+* http/wpt/workers/queue-microtask.any.worker.html: Added.
+
 2018-08-05  Rob Buis  
 
 [GTK][WPE] Fetch tests assert in SubresourceLoader::didReceiveResponse()


Added: trunk/LayoutTests/http/wpt/workers/queue-microtask.any-expected.txt (0 => 234588)

--- trunk/LayoutTests/http/wpt/workers/queue-microtask.any-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/wpt/workers/queue-microtask.any-expected.txt	2018-08-06 07:59:13 UTC (rev 234588)
@@ -0,0 +1,6 @@
+
+PASS Queued microtasks should be drained before executing macrotasks 
+PASS queueMicrotask's callback has zero arguments and self as |this| 
+PASS queueMicrotask and Promise uses the same Microtask queue 
+PASS queueMicrotask should reject non-function arguments 
+


Added: trunk/LayoutTests/http/wpt/workers/queue-microtask.any.html (0 => 234588)

--- trunk/LayoutTests/http/wpt/workers/queue-microtask.any.html	(rev 0)
+++ trunk/LayoutTests/http/wpt/workers/queue-microtask.any.html	2018-08-06 07:59:13 UTC (rev 234588)
@@ -0,0 +1 @@
+
\ No newline at end of file


Added: trunk/LayoutTests/http/wpt/workers/queue-microtask.any.js (0 => 234588)

--- trunk/LayoutTests/http/wpt/workers/queue-microtask.any.js	(rev 0)
+++ trunk/LayoutTests/http/wpt/workers/queue-microtask.any.js	2018-08-06 07:59:13 UTC (rev 234588)
@@ -0,0 +1,93 @@
+promise_test(() => {
+var counter = 0;
+self.queueMicrotask(() => {
+assert_equals(counter++, 1);
+self.queueMicrotask(() => {
+assert_equals(counter++, 2);
+});
+});
+var promise = new Promise((resolve, reject) => {
+setTimeout(() => {
+assert_equals(counter++, 3);
+resolve();
+}, 0);
+});
+assert_equals(counter++, 0);
+return promise;
+}, `Queued microtasks should be drained before executing macrotasks`);
+
+promise_test(() => {
+return new Promise((resolve, reject) => {
+self.queueMicrotask(function () {
+try {
+assert_equals(arguments.length, 0);
+assert_equals(this, self);
+self.queueMicrotask(function () {
+try {
+assert_equals(this, self);
+self.queueMicrotask(function () {
+'use strict';
+try {
+assert_equals(this, undefined);
+resolve();
+} catch (e) {
+reject(e);
+

[webkit-changes] [234587] trunk

2018-08-06 Thread commit-queue

Title: [234587] trunk








Revision 234587
Author commit-qu...@webkit.org
Date 2018-08-05 23:43:51 -0700 (Sun, 05 Aug 2018)


Log Message
[GTK][WPE] Fetch tests assert in SubresourceLoader::didReceiveResponse()
https://bugs.webkit.org/show_bug.cgi?id=188163

Patch by Rob Buis  on 2018-08-05
Reviewed by Frédéric Wang.

Source/WebCore:

Fetch in manual redirect mode uses didReceiveResponse instead of
willSendRequestInternal, so update the ASSERT.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):

LayoutTests:

Unskip since this will not crash in Debug anymore.

* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wpe/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubresourceLoader.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (234586 => 234587)

--- trunk/LayoutTests/ChangeLog	2018-08-06 04:37:10 UTC (rev 234586)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 06:43:51 UTC (rev 234587)
@@ -1,3 +1,14 @@
+2018-08-05  Rob Buis  
+
+[GTK][WPE] Fetch tests assert in SubresourceLoader::didReceiveResponse()
+https://bugs.webkit.org/show_bug.cgi?id=188163
+
+Reviewed by Frédéric Wang.
+
+Unskip since this will not crash in Debug anymore.
+
+* platform/wpe/TestExpectations:
+
 2018-08-05  Yusuke Suzuki  
 
 Add support for microtasks in workers


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (234586 => 234587)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2018-08-06 04:37:10 UTC (rev 234586)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2018-08-06 06:43:51 UTC (rev 234587)
@@ -1328,10 +1328,3 @@
 
 webkit.org/b/188162 [ Debug ] fast/canvas/webgl/texImage2D-video-flipY-false.html [ Crash ]
 webkit.org/b/188162 [ Debug ] fast/canvas/webgl/texImage2D-video-flipY-true.html [ Crash ]
-
-webkit.org/b/188163 [ Debug ] http/tests/fetch/caching-with-different-options.html [ Crash ]
-webkit.org/b/188163 [ Debug ] http/tests/fetch/redirectmode-and-preload.html [ Crash ]
-webkit.org/b/188163 [ Debug ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-worker.html [ Crash ]
-webkit.org/b/188163 [ Debug ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location.html [ Crash ]
-webkit.org/b/188163 [ Debug ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode-worker.html [ Crash ]
-webkit.org/b/188163 [ Debug ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-mode.html[ Crash ]


Modified: trunk/Source/WebCore/ChangeLog (234586 => 234587)

--- trunk/Source/WebCore/ChangeLog	2018-08-06 04:37:10 UTC (rev 234586)
+++ trunk/Source/WebCore/ChangeLog	2018-08-06 06:43:51 UTC (rev 234587)
@@ -1,3 +1,16 @@
+2018-08-05  Rob Buis  
+
+[GTK][WPE] Fetch tests assert in SubresourceLoader::didReceiveResponse()
+https://bugs.webkit.org/show_bug.cgi?id=188163
+
+Reviewed by Frédéric Wang.
+
+Fetch in manual redirect mode uses didReceiveResponse instead of
+willSendRequestInternal, so update the ASSERT.
+
+* loader/SubresourceLoader.cpp:
+(WebCore::SubresourceLoader::didReceiveResponse):
+
 2018-08-05  Yusuke Suzuki  
 
 Add support for microtasks in workers


Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (234586 => 234587)

--- trunk/Source/WebCore/loader/SubresourceLoader.cpp	2018-08-06 04:37:10 UTC (rev 234586)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp	2018-08-06 06:43:51 UTC (rev 234587)
@@ -318,11 +318,11 @@
 }
 #endif
 
-// We want redirect responses to be processed through willSendRequestInternal.
-// The only exception is redirection with no Location headers. Or in rare circumstances,
+// We want redirect responses to be processed through willSendRequestInternal. Exceptions are
+// redirection with no Location headers and fetch in manual redirect mode. Or in rare circumstances,
 // cases of too many redirects from CFNetwork ().
 #if !PLATFORM(COCOA)
-ASSERT(response.httpStatusCode() < 300 || response.httpStatusCode() >= 400 || response.httpStatusCode() == 304 || !response.httpHeaderField(HTTPHeaderName::Location));
+ASSERT(response.httpStatusCode() < 300 || response.httpStatusCode() >= 400 || response.httpStatusCode() == 304 || !response.httpHeaderField(HTTPHeaderName::Location) || response.type() == ResourceResponse::Type::Opaqueredirect);
 #endif
 
 // Reference the object in this method since the additional processing can do






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

53 matches

Mail list logo