Title: [238273] trunk
Revision 238273
Author za...@apple.com
Date 2018-11-15 21:46:48 -0800 (Thu, 15 Nov 2018)
Log Message
[iOS] Do not get stuck in indeterminate content observation state.
https://bugs.webkit.org/show_bug.cgi?id=191719
Reviewed by Simon Fraser.
Source/WebCore:
Reset the _WKContentChange flag to WKContentNoChange when the last observing timer is removed and we are in
the "can't decide yet if it's a hover or click" state.
This bug prevents us from firing click event when JS installs and removes the same set of timer(s) during mouse-move dispatch.
Test: fast/events/touch/ios/stuck-with-hover-state.html
* platform/ios/wak/WKContentObservation.cpp:
(WebThreadRemoveObservedContentModifier):
LayoutTests:
* fast/events/touch/ios/stuck-with-hover-state-expected.txt: Added.
* fast/events/touch/ios/stuck-with-hover-state.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/wak/WKContentObservation.cpp
Added Paths
trunk/LayoutTests/fast/events/touch/ios/stuck-with-hover-state-expected.txt
trunk/LayoutTests/fast/events/touch/ios/stuck-with-hover-state.html
Diff
Modified: trunk/LayoutTests/ChangeLog (238272 => 238273)
--- trunk/LayoutTests/ChangeLog 2018-11-16 05:42:40 UTC (rev 238272)
+++ trunk/LayoutTests/ChangeLog 2018-11-16 05:46:48 UTC (rev 238273)
@@ -1,3 +1,13 @@
+2018-11-15 Zalan Bujtas
+
+[iOS] Do not get stuck in indeterminate content observation state.
+https://bugs.webkit.org/show_bug.cgi?id=191719
+
+Reviewed by Simon Fraser.
+
+* fast/events/touch/ios/stuck-with-hover-state-expected.txt: Added.
+* fast/events/touch/ios/stuck-with-hover-state.html: Added.
+
2018-11-15 Simon Fraser
Add layout test for iframe contents disappearing on view unparent/reparent
Added: trunk/LayoutTests/fast/events/touch/ios/stuck-with-hover-state-expected.txt (0 => 238273)
--- trunk/LayoutTests/fast/events/touch/ios/stuck-with-hover-state-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/stuck-with-hover-state-expected.txt 2018-11-16 05:46:48 UTC (rev 238273)
@@ -0,0 +1,2 @@
+PASS if clicked.
+clicked
Added: trunk/LayoutTests/fast/events/touch/ios/stuck-with-hover-state.html (0 => 238273)
--- trunk/LayoutTests/fast/events/touch/ios/stuck-with-hover-state.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/stuck-with-hover-state.html 2018-11-16 05:46:48 UTC (rev 238273)
@@ -0,0 +1,43 @@
+
+
+This test that we trigger click when hover would not display non-clickable content.
+
+#tapthis {
+width: 400px;
+height: 400px;
+border: 1px solid green;
+}
+
+