[webkit-changes] [244239] trunk/Source
Title: [244239] trunk/Source
Revision 244239
Author wenson_hs...@apple.com
Date 2019-04-12 20:54:10 -0700 (Fri, 12 Apr 2019)
Log Message
Enable modern compatibility mode by default in WKWebView on some devices
https://bugs.webkit.org/show_bug.cgi?id=196883
Reviewed by Tim Horton.
Source/WebCore:
Add a new helper function to determine whether an app is pre-installed on iOS, for the purposes of ensuring
compatibility with existing Apple apps that are not affected by linked-on-or-after. This involves all apps with
a bundle ID that begins with "com.apple.".
* platform/RuntimeApplicationChecks.h:
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::setApplicationBundleIdentifier):
(WebCore::applicationBundleStartsWith):
(WebCore::IOSApplication::isAppleApplication):
Source/WebKit:
Make some minor adjustments to new API.
* Shared/WebCompatibilityMode.h:
Rename WebCompatibilityMode::Default to WebCompatibilityMode::Recommended.
* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h:
Now that the role of the UseModernCompatibilityModeByDefault debug preference is limited to bypassing linked-on-
or-after and app bundle compatibility hacks, we no longer make this default to true in iOSMac.
* UIProcess/API/APIWebsitePolicies.h:
* UIProcess/API/Cocoa/WKNavigationDelegate.h:
Rename the withPreferences: label to just preferences:.
* UIProcess/API/Cocoa/WKWebViewConfiguration.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::setNavigationDelegate):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
* UIProcess/Cocoa/VersionChecks.h:
* UIProcess/ios/WebPageProxyIOS.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebCompatibilityMode.h
trunk/Source/WebKit/Shared/WebPreferences.yaml
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegate.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit/UIProcess/Cocoa/VersionChecks.h
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (244238 => 244239)
--- trunk/Source/WebCore/ChangeLog 2019-04-13 03:04:18 UTC (rev 244238)
+++ trunk/Source/WebCore/ChangeLog 2019-04-13 03:54:10 UTC (rev 244239)
@@ -1,3 +1,21 @@
+2019-04-12 Wenson Hsieh
+
+Enable modern compatibility mode by default in WKWebView on some devices
+https://bugs.webkit.org/show_bug.cgi?id=196883
+
+
+Reviewed by Tim Horton.
+
+Add a new helper function to determine whether an app is pre-installed on iOS, for the purposes of ensuring
+compatibility with existing Apple apps that are not affected by linked-on-or-after. This involves all apps with
+a bundle ID that begins with "com.apple.".
+
+* platform/RuntimeApplicationChecks.h:
+* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+(WebCore::setApplicationBundleIdentifier):
+(WebCore::applicationBundleStartsWith):
+(WebCore::IOSApplication::isAppleApplication):
+
2019-04-12 Justin Fan
[Web GPU] Prevent narrowing conversions during Metal function calls on 32-bit platforms
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (244238 => 244239)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2019-04-13 03:04:18 UTC (rev 244238)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h 2019-04-13 03:54:10 UTC (rev 244239)
@@ -91,6 +91,7 @@
WEBCORE_EXPORT bool isNike();
bool isMoviStarPlus();
WEBCORE_EXPORT bool isFirefox();
+WEBCORE_EXPORT bool isAppleApplication();
} // IOSApplication
Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (244238 => 244239)
--- trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2019-04-13 03:04:18 UTC (rev 244238)
+++ trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm 2019-04-13 03:54:10 UTC (rev 244239)
@@ -62,7 +62,7 @@
void setApplicationBundleIdentifier(const String& bundleIdentifier)
{
ASSERT(RunLoop::isMain());
-ASSERT_WITH_MESSAGE(!applicationBundleIdentifierOverrideWasQueried, "applicationBundleIsEqualTo() should not be called before setApplicationBundleIdentifier()");
+ASSERT_WITH_MESSAGE(!applicationBundleIdentifierOverrideWasQueried, "applicationBundleIsEqualTo() and applicationBundleStartsWith() should not be called before setApplicationBundleIdentifier()");
applicationBundleIdentifierOverride() = bundleIdentifier;
}
@@ -191,6 +191,11 @@
#if PLATFORM(IOS_FAMILY)
+static bool applicationBundleStartsWith(const String& bundleIdentifierPrefix)
+{
+return applicationBu
[webkit-changes] [244238] trunk
Title: [244238] trunk
Revision 244238
Author sbar...@apple.com
Date 2019-04-12 20:04:18 -0700 (Fri, 12 Apr 2019)
Log Message
r244079 logically broke shouldSpeculateInt52
https://bugs.webkit.org/show_bug.cgi?id=196884
Reviewed by Yusuke Suzuki.
JSTests:
* microbenchmarks/int52-rand-function.js: Added.
(Math.random):
Source/_javascript_Core:
In r244079, I changed shouldSpeculateInt52 to only return true
when the prediction is isAnyInt52Speculation(). However, it was
wrong to not to include SpecInt32 in this for two reasons:
1. We diligently write code that first checks if we should speculate Int32.
For example:
if (shouldSpeculateInt32()) ...
else if (shouldSpeculateInt52()) ...
It would be wrong not to fall back to Int52 if we're dealing with the union of
Int32 and Int52.
It would be a performance mistake to not include Int32 here because
data flow can easily tell us that we have variables that are the union
of Int32 and Int52 values. It's better to speculate Int52 than Double
in that situation.
2. We also write code where we ask if the inputs can be Int52, e.g, if
we know via profiling that an Add overflows, we may not emit an Int32 add.
However, we only emit such an add if both inputs can be Int52, and Int32
can trivially become Int52.
This patch recovers the 0.5-1% regression r244079 caused on JetStream 2.
* bytecode/SpeculatedType.h:
(JSC::isInt32SpeculationForArithmetic):
(JSC::isInt32OrBooleanSpeculationForArithmetic):
(JSC::isInt32OrInt52Speculation):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::observeUseKindOnNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateInt52):
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGVariableAccessData.cpp:
(JSC::DFG::VariableAccessData::couldRepresentInt52Impl):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/SpeculatedType.h
trunk/Source/_javascript_Core/dfg/DFGFixupPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/dfg/DFGPredictionPropagationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGVariableAccessData.cpp
Added Paths
trunk/JSTests/microbenchmarks/int52-rand-function.js
Diff
Modified: trunk/JSTests/ChangeLog (244237 => 244238)
--- trunk/JSTests/ChangeLog 2019-04-13 00:05:27 UTC (rev 244237)
+++ trunk/JSTests/ChangeLog 2019-04-13 03:04:18 UTC (rev 244238)
@@ -1,3 +1,13 @@
+2019-04-12 Saam barati
+
+r244079 logically broke shouldSpeculateInt52
+https://bugs.webkit.org/show_bug.cgi?id=196884
+
+Reviewed by Yusuke Suzuki.
+
+* microbenchmarks/int52-rand-function.js: Added.
+(Math.random):
+
2019-04-11 Yusuke Suzuki
[JSC] op_has_indexed_property should not assume subscript part is Uint32
Added: trunk/JSTests/microbenchmarks/int52-rand-function.js (0 => 244238)
--- trunk/JSTests/microbenchmarks/int52-rand-function.js (rev 0)
+++ trunk/JSTests/microbenchmarks/int52-rand-function.js 2019-04-13 03:04:18 UTC (rev 244238)
@@ -0,0 +1,20 @@
+let seed = 49734321;
+
+Math.random = (function() {
+return function() {
+// Robert Jenkins' 32 bit integer hash function.
+seed = ((seed + 0x7ed55d16) + (seed << 12)) & 0x;
+seed = ((seed ^ 0xc761c23c) ^ (seed >>> 19)) & 0x;
+seed = ((seed + 0x165667b1) + (seed << 5)) & 0x;
+seed = ((seed + 0xd3a2646c) ^ (seed << 9)) & 0x;
+seed = ((seed + 0xfd7046c5) + (seed << 3)) & 0x;
+seed = ((seed ^ 0xb55a4f09) ^ (seed >>> 16)) & 0x;
+return (seed & 0xfff) / 0x1000;
+};
+})();
+
+noInline(Math.random);
+
+for (let i = 0; i < 1000; ++i) {
+Math.random();
+}
Modified: trunk/Source/_javascript_Core/ChangeLog (244237 => 244238)
--- trunk/Source/_javascript_Core/ChangeLog 2019-04-13 00:05:27 UTC (rev 244237)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-04-13 03:04:18 UTC (rev 244238)
@@ -1,5 +1,48 @@
2019-04-12 Saam barati
+r244079 logically broke shouldSpeculateInt52
+https://bugs.webkit.org/show_bug.cgi?id=196884
+
+Reviewed by Yusuke Suzuki.
+
+In r244079, I changed shouldSpeculateInt52 to only return true
+when the prediction is isAnyInt52Speculation(). However, it was
+wrong to not to include SpecInt32 in this for two reasons:
+
+1. We diligently write code that first checks if we should speculate Int32.
+For example:
+if (shouldSpeculateInt32()) ...
+else if (shouldSpeculateInt52()) ...
+
+It would be wrong not to fall back to Int52 if we're dealing with the union of
+Int32 and Int52.
+
+It would be a performance mistake to not include Int32 here because
+data flow can easily tell us that we have variables that are the union
+of Int32 and Int52 values. It's better to speculate Int52 than Double
+in that situation.
+
+2. We a
[webkit-changes] [244237] trunk/Source/JavaScriptCore
Title: [244237] trunk/Source/_javascript_Core Revision 244237 Author sbar...@apple.com Date 2019-04-12 17:05:27 -0700 (Fri, 12 Apr 2019) Log Message Unreviewed. Build fix after r244233. * assembler/CPU.cpp: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/CPU.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (244236 => 244237) --- trunk/Source/_javascript_Core/ChangeLog 2019-04-12 23:45:20 UTC (rev 244236) +++ trunk/Source/_javascript_Core/ChangeLog 2019-04-13 00:05:27 UTC (rev 244237) @@ -1,5 +1,11 @@ 2019-04-12 Saam barati +Unreviewed. Build fix after r244233. + +* assembler/CPU.cpp: + +2019-04-12 Saam barati + Sometimes we need to user fewer CPUs in our threading calculations https://bugs.webkit.org/show_bug.cgi?id=196794 Modified: trunk/Source/_javascript_Core/assembler/CPU.cpp (244236 => 244237) --- trunk/Source/_javascript_Core/assembler/CPU.cpp 2019-04-12 23:45:20 UTC (rev 244236) +++ trunk/Source/_javascript_Core/assembler/CPU.cpp 2019-04-13 00:05:27 UTC (rev 244237) @@ -27,6 +27,7 @@ #include "CPU.h" #if (CPU(X86) || CPU(X86_64)) && OS(DARWIN) +#include #include #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244236] trunk/Source/WebKit
Title: [244236] trunk/Source/WebKit
Revision 244236
Author bb...@apple.com
Date 2019-04-12 16:45:20 -0700 (Fri, 12 Apr 2019)
Log Message
WebDriver: fix typo in EnterFullscreen.js in error-handling code
https://bugs.webkit.org/show_bug.cgi?id=196882
Reviewed by Devin Rousso.
* UIProcess/Automation/atoms/EnterFullscreen.js:
(enterFullscreen):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/atoms/EnterFullscreen.js
Diff
Modified: trunk/Source/WebKit/ChangeLog (244235 => 244236)
--- trunk/Source/WebKit/ChangeLog 2019-04-12 23:40:53 UTC (rev 244235)
+++ trunk/Source/WebKit/ChangeLog 2019-04-12 23:45:20 UTC (rev 244236)
@@ -1,3 +1,14 @@
+2019-04-12 Brian Burg
+
+WebDriver: fix typo in EnterFullscreen.js in error-handling code
+https://bugs.webkit.org/show_bug.cgi?id=196882
+
+
+Reviewed by Devin Rousso.
+
+* UIProcess/Automation/atoms/EnterFullscreen.js:
+(enterFullscreen):
+
2019-04-12 Ross Kirsling
Unreviewed fix for non-unified build.
Modified: trunk/Source/WebKit/UIProcess/Automation/atoms/EnterFullscreen.js (244235 => 244236)
--- trunk/Source/WebKit/UIProcess/Automation/atoms/EnterFullscreen.js 2019-04-12 23:40:53 UTC (rev 244235)
+++ trunk/Source/WebKit/UIProcess/Automation/atoms/EnterFullscreen.js 2019-04-12 23:45:20 UTC (rev 244236)
@@ -56,7 +56,7 @@
document.removeEventListener("webkitfullscreenchange", fullscreenChangeListener);
document.documentElement.removeEventListener("webkitfullscreenerror", fullscreenErrorListener);
-callback(document.webkitIsFullscreen);
+callback(!!document.webkitIsFullScreen);
};
// The document fires change events, but the fullscreen element fires error events.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244235] trunk/Source/WebCore
Title: [244235] trunk/Source/WebCore
Revision 244235
Author justin_...@apple.com
Date 2019-04-12 16:40:53 -0700 (Fri, 12 Apr 2019)
Log Message
[Web GPU] Prevent narrowing conversions during Metal function calls on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=196793
Reviewed by Darin Adler.
On 32-bit platforms, NSUInteger is 32-bit, which limits certain Web GPU parameters.
Ensure that valid parameters are properly converted to NSUInteger for Metal calls, regardless of platform.
* platform/graphics/gpu/GPUBuffer.h:
(WebCore::GPUBuffer::byteLength const):
* platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm:
(WebCore::tryGetResourceAsBufferBinding):
(WebCore::setBufferOnEncoder):
* platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
(WebCore::GPUBuffer::validateBufferUsage):
(WebCore::GPUBuffer::tryCreate):
(WebCore::GPUBuffer::GPUBuffer):
(WebCore::GPUBuffer::setSubData):
* platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm:
(WebCore::GPUCommandBuffer::copyBufferToBuffer):
(WebCore::GPUCommandBuffer::copyBufferToTexture):
(WebCore::GPUCommandBuffer::copyTextureToBuffer):
* platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:
(WebCore::GPURenderPassEncoder::drawIndexed):
* platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
(WebCore::trySetInputStateForPipelineDescriptor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/GPUBuffer.h
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBufferMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm
trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (244234 => 244235)
--- trunk/Source/WebCore/ChangeLog 2019-04-12 23:32:38 UTC (rev 244234)
+++ trunk/Source/WebCore/ChangeLog 2019-04-12 23:40:53 UTC (rev 244235)
@@ -1,3 +1,32 @@
+2019-04-12 Justin Fan
+
+[Web GPU] Prevent narrowing conversions during Metal function calls on 32-bit platforms
+https://bugs.webkit.org/show_bug.cgi?id=196793
+
+Reviewed by Darin Adler.
+
+On 32-bit platforms, NSUInteger is 32-bit, which limits certain Web GPU parameters.
+Ensure that valid parameters are properly converted to NSUInteger for Metal calls, regardless of platform.
+
+* platform/graphics/gpu/GPUBuffer.h:
+(WebCore::GPUBuffer::byteLength const):
+* platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm:
+(WebCore::tryGetResourceAsBufferBinding):
+(WebCore::setBufferOnEncoder):
+* platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
+(WebCore::GPUBuffer::validateBufferUsage):
+(WebCore::GPUBuffer::tryCreate):
+(WebCore::GPUBuffer::GPUBuffer):
+(WebCore::GPUBuffer::setSubData):
+* platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm:
+(WebCore::GPUCommandBuffer::copyBufferToBuffer):
+(WebCore::GPUCommandBuffer::copyBufferToTexture):
+(WebCore::GPUCommandBuffer::copyTextureToBuffer):
+* platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:
+(WebCore::GPURenderPassEncoder::drawIndexed):
+* platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:
+(WebCore::trySetInputStateForPipelineDescriptor):
+
2019-04-12 Ross Kirsling
Unreviewed fix for non-unified build.
Modified: trunk/Source/WebCore/platform/graphics/gpu/GPUBuffer.h (244234 => 244235)
--- trunk/Source/WebCore/platform/graphics/gpu/GPUBuffer.h 2019-04-12 23:32:38 UTC (rev 244234)
+++ trunk/Source/WebCore/platform/graphics/gpu/GPUBuffer.h 2019-04-12 23:40:53 UTC (rev 244235)
@@ -71,7 +71,7 @@
static RefPtr tryCreate(Ref&&, const GPUBufferDescriptor&);
PlatformBuffer *platformBuffer() const { return m_platformBuffer.get(); }
-uint64_t byteLength() const { return m_byteLength; }
+size_t byteLength() const { return m_byteLength; }
bool isTransferSource() const { return m_usage.contains(GPUBufferUsage::Flags::TransferSource); }
bool isTransferDestination() const { return m_usage.contains(GPUBufferUsage::Flags::TransferDestination); }
bool isIndex() const { return m_usage.contains(GPUBufferUsage::Flags::Index); }
@@ -110,7 +110,7 @@
static bool validateBufferUsage(const GPUDevice&, OptionSet);
-GPUBuffer(PlatformBufferSmartPtr&&, uint64_t, OptionSet, Ref&&);
+GPUBuffer(PlatformBufferSmartPtr&&, size_t, OptionSet, Ref&&);
JSC::ArrayBuffer* stagingBufferForRead();
JSC::ArrayBuffer* stagingBufferForWrite();
@@ -132,7 +132,7 @@
RefPtr m_mappingCallback;
DeferrableTask m_mappingCallbackTask;
-uint64_t m_byteLength;
+size_t m_byteLength;
OptionSet m_usage;
unsigned m_numScheduledCommandBuffers { 0 };
};
Modified: trunk/Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm (2
[webkit-changes] [244234] trunk/Source
Title: [244234] trunk/Source Revision 244234 Author ross.kirsl...@sony.com Date 2019-04-12 16:32:38 -0700 (Fri, 12 Apr 2019) Log Message Unreviewed fix for non-unified build. Source/WebCore: * dom/ScriptedAnimationController.h: Add missing include from r244182. Source/WebKit: * Shared/PrintInfo.cpp: Add missing include from r244202. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ScriptedAnimationController.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/PrintInfo.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (244233 => 244234) --- trunk/Source/WebCore/ChangeLog 2019-04-12 23:26:43 UTC (rev 244233) +++ trunk/Source/WebCore/ChangeLog 2019-04-12 23:32:38 UTC (rev 244234) @@ -1,3 +1,10 @@ +2019-04-12 Ross Kirsling + +Unreviewed fix for non-unified build. + +* dom/ScriptedAnimationController.h: +Add missing include from r244182. + 2019-04-11 Ryosuke Niwa WebThread should run at a higher priority than user initiated Modified: trunk/Source/WebCore/dom/ScriptedAnimationController.h (244233 => 244234) --- trunk/Source/WebCore/dom/ScriptedAnimationController.h 2019-04-12 23:26:43 UTC (rev 244233) +++ trunk/Source/WebCore/dom/ScriptedAnimationController.h 2019-04-12 23:32:38 UTC (rev 244234) @@ -25,6 +25,7 @@ #pragma once +#include "DOMHighResTimeStamp.h" #include "Timer.h" #include #include Modified: trunk/Source/WebKit/ChangeLog (244233 => 244234) --- trunk/Source/WebKit/ChangeLog 2019-04-12 23:26:43 UTC (rev 244233) +++ trunk/Source/WebKit/ChangeLog 2019-04-12 23:32:38 UTC (rev 244234) @@ -1,3 +1,10 @@ +2019-04-12 Ross Kirsling + +Unreviewed fix for non-unified build. + +* Shared/PrintInfo.cpp: +Add missing include from r244202. + 2019-04-12 Saam barati Sometimes we need to user fewer CPUs in our threading calculations Modified: trunk/Source/WebKit/Shared/PrintInfo.cpp (244233 => 244234) --- trunk/Source/WebKit/Shared/PrintInfo.cpp 2019-04-12 23:26:43 UTC (rev 244233) +++ trunk/Source/WebKit/Shared/PrintInfo.cpp 2019-04-12 23:32:38 UTC (rev 244234) @@ -26,8 +26,7 @@ #include "config.h" #include "PrintInfo.h" -#include "Decoder.h" -#include "Encoder.h" +#include "WebCoreArgumentCoders.h" #if PLATFORM(GTK) #include "ArgumentCodersGtk.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244233] trunk/Source
Title: [244233] trunk/Source
Revision 244233
Author sbar...@apple.com
Date 2019-04-12 16:26:43 -0700 (Fri, 12 Apr 2019)
Log Message
Sometimes we need to user fewer CPUs in our threading calculations
https://bugs.webkit.org/show_bug.cgi?id=196794
Reviewed by Yusuke Suzuki.
Source/_javascript_Core:
* _javascript_Core.xcodeproj/project.pbxproj:
* Sources.txt:
* assembler/CPU.cpp: Added.
(JSC::isKernTCSMAvailable):
(JSC::enableKernTCSM):
(JSC::kernTCSMAwareNumberOfProcessorCores):
* assembler/CPU.h:
(JSC::isKernTCSMAvailable):
(JSC::enableKernTCSM):
(JSC::kernTCSMAwareNumberOfProcessorCores):
* heap/MachineStackMarker.h:
(JSC::MachineThreads::addCurrentThread):
* runtime/JSLock.cpp:
(JSC::JSLock::didAcquireLock):
* runtime/Options.cpp:
(JSC::computeNumberOfWorkerThreads):
(JSC::computePriorityDeltaOfWorkerThreads):
* wasm/WasmWorklist.cpp:
(JSC::Wasm::Worklist::Worklist):
Source/WebKit:
* WebProcess/com.apple.WebProcess.sb.in:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/Sources.txt
trunk/Source/_javascript_Core/assembler/CPU.h
trunk/Source/_javascript_Core/heap/MachineStackMarker.h
trunk/Source/_javascript_Core/runtime/JSLock.cpp
trunk/Source/_javascript_Core/runtime/Options.cpp
trunk/Source/_javascript_Core/wasm/WasmWorklist.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in
Added Paths
trunk/Source/_javascript_Core/assembler/CPU.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (244232 => 244233)
--- trunk/Source/_javascript_Core/ChangeLog 2019-04-12 22:44:21 UTC (rev 244232)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-04-12 23:26:43 UTC (rev 244233)
@@ -1,3 +1,31 @@
+2019-04-12 Saam barati
+
+Sometimes we need to user fewer CPUs in our threading calculations
+https://bugs.webkit.org/show_bug.cgi?id=196794
+
+
+Reviewed by Yusuke Suzuki.
+
+* _javascript_Core.xcodeproj/project.pbxproj:
+* Sources.txt:
+* assembler/CPU.cpp: Added.
+(JSC::isKernTCSMAvailable):
+(JSC::enableKernTCSM):
+(JSC::kernTCSMAwareNumberOfProcessorCores):
+* assembler/CPU.h:
+(JSC::isKernTCSMAvailable):
+(JSC::enableKernTCSM):
+(JSC::kernTCSMAwareNumberOfProcessorCores):
+* heap/MachineStackMarker.h:
+(JSC::MachineThreads::addCurrentThread):
+* runtime/JSLock.cpp:
+(JSC::JSLock::didAcquireLock):
+* runtime/Options.cpp:
+(JSC::computeNumberOfWorkerThreads):
+(JSC::computePriorityDeltaOfWorkerThreads):
+* wasm/WasmWorklist.cpp:
+(JSC::Wasm::Worklist::Worklist):
+
2019-04-12 Robin Morisset
Use padding at end of ArrayBuffer
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (244232 => 244233)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2019-04-12 22:44:21 UTC (rev 244232)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2019-04-12 23:26:43 UTC (rev 244233)
@@ -3392,6 +3392,7 @@
521131F61F82BF11007CCEEE /* PolyProtoAccessChain.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PolyProtoAccessChain.h; sourceTree = ""; };
521322431ECBCE8200F65615 /* WebAssemblyFunctionBase.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = WebAssemblyFunctionBase.cpp; path = js/WebAssemblyFunctionBase.cpp; sourceTree = ""; };
521322441ECBCE8200F65615 /* WebAssemblyFunctionBase.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = WebAssemblyFunctionBase.h; path = js/WebAssemblyFunctionBase.h; sourceTree = ""; };
+ 52335628225EB8E900268BD2 /* CPU.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = CPU.cpp; sourceTree = ""; };
523FD88C225566C3003B3DCC /* WebAssemblyFunctionHeapCellType.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = WebAssemblyFunctionHeapCellType.h; path = js/WebAssemblyFunctionHeapCellType.h; sourceTree = ""; };
523FD88D225566C4003B3DCC /* WebAssemblyFunctionHeapCellType.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = WebAssemblyFunctionHeapCellType.cpp; path = js/WebAssemblyFunctionHeapCellType.cpp; sourceTree = ""; };
524E9D7122092B4500A6BEEE /* AirAllocateRegistersAndStackAndGenerateCode.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = AirAllocateRegistersAndStackAndGenerateCode.cpp; path = b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp; sourceTree = ""; };
@@ -7798,6 +7799,7 @@
43C392AA1C3BEB241F53 /* AssemblerCommon.h */,
86E116B00FE75AC800B512BC /* CodeLocation.h */,
0F30D7BF1D95D62F0053089D /* CPU.h */,
+52335628225EB8E900268BD2 /* CPU.cpp */,
0F37308E1C0CD68500052BFA /*
[webkit-changes] [244232] tags/Safari-607.2.4/
Title: [244232] tags/Safari-607.2.4/ Revision 244232 Author alanc...@apple.com Date 2019-04-12 15:44:21 -0700 (Fri, 12 Apr 2019) Log Message Tag Safari-607.2.4. Added Paths tags/Safari-607.2.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244231] trunk/LayoutTests
Title: [244231] trunk/LayoutTests Revision 244231 Author ross.kirsl...@sony.com Date 2019-04-12 15:31:07 -0700 (Fri, 12 Apr 2019) Log Message [WinCairo][WKL] Unreviewed test gardening. * platform/wincairo-wk1/TestExpectations: r244182 causes all animations tests to time out. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/wincairo-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (244230 => 244231) --- trunk/LayoutTests/ChangeLog 2019-04-12 20:46:55 UTC (rev 244230) +++ trunk/LayoutTests/ChangeLog 2019-04-12 22:31:07 UTC (rev 244231) @@ -1,3 +1,10 @@ +2019-04-12 Ross Kirsling + +[WinCairo][WKL] Unreviewed test gardening. + +* platform/wincairo-wk1/TestExpectations: +r244182 causes all animations tests to time out. + 2019-04-12 Ryan Haddad Unreviewed test gardening for Windows. Modified: trunk/LayoutTests/platform/wincairo-wk1/TestExpectations (244230 => 244231) --- trunk/LayoutTests/platform/wincairo-wk1/TestExpectations 2019-04-12 20:46:55 UTC (rev 244230) +++ trunk/LayoutTests/platform/wincairo-wk1/TestExpectations 2019-04-12 22:31:07 UTC (rev 244231) @@ -27,3 +27,7 @@ # There is not NetworkProcess in WK1, so it can't crash. http/tests/websocket/tests/hybi/network-process-crash-error.html [ Skip ] + +# Broken by r244182 +animations/ [ Skip ] +legacy-animation-engine/ [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244230] trunk/Source/WebKit
Title: [244230] trunk/Source/WebKit
Revision 244230
Author drou...@apple.com
Date 2019-04-12 13:46:55 -0700 (Fri, 12 Apr 2019)
Log Message
WebDriver: evaluating _javascript_ shouldn't fail if a dialog is shown
https://bugs.webkit.org/show_bug.cgi?id=196847
Reviewed by Brian Burg.
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::willShowJavaScriptDialog):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (244229 => 244230)
--- trunk/Source/WebKit/ChangeLog 2019-04-12 20:37:38 UTC (rev 244229)
+++ trunk/Source/WebKit/ChangeLog 2019-04-12 20:46:55 UTC (rev 244230)
@@ -1,3 +1,14 @@
+2019-04-12 Devin Rousso
+
+WebDriver: evaluating _javascript_ shouldn't fail if a dialog is shown
+https://bugs.webkit.org/show_bug.cgi?id=196847
+
+
+Reviewed by Brian Burg.
+
+* UIProcess/Automation/WebAutomationSession.cpp:
+(WebKit::WebAutomationSession::willShowJavaScriptDialog):
+
2019-04-12 Ross Kirsling
WebKit should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF
Modified: trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp (244229 => 244230)
--- trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2019-04-12 20:37:38 UTC (rev 244229)
+++ trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp 2019-04-12 20:46:55 UTC (rev 244230)
@@ -652,10 +652,9 @@
}
if (!m_evaluateJavaScriptFunctionCallbacks.isEmpty()) {
-Inspector::ErrorString unexpectedAlertOpenError = STRING_FOR_PREDEFINED_ERROR_NAME(UnexpectedAlertOpen);
for (auto key : copyToVector(m_evaluateJavaScriptFunctionCallbacks.keys())) {
auto callback = m_evaluateJavaScriptFunctionCallbacks.take(key);
-callback->sendFailure(unexpectedAlertOpenError);
+callback->sendSuccess(emptyString());
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244229] trunk/Source/WebCore
Title: [244229] trunk/Source/WebCore
Revision 244229
Author rn...@webkit.org
Date 2019-04-12 13:37:38 -0700 (Fri, 12 Apr 2019)
Log Message
WebThread should run at a higher priority than user initiated
https://bugs.webkit.org/show_bug.cgi?id=196849
Reviewed by Geoffrey Garen.
Use QOS_CLASS_USER_INTERACTIVE on WebThread with -10 relative priority so that WebThread
won't wait for other threads with priority 30-37 but does not content with the main thread.
Also removed the call to pthread_attr_setschedparam which disables QoS.
This improves the blocked time in StartWebThread from 2~3ms to 250μs while cold launching
iBooks to an opened book.
* platform/ios/wak/WebCoreThread.mm:
(StartWebThread): Replaced 200 * 4096 by 800 * KB for a better readability.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (244228 => 244229)
--- trunk/Source/WebCore/ChangeLog 2019-04-12 18:52:01 UTC (rev 244228)
+++ trunk/Source/WebCore/ChangeLog 2019-04-12 20:37:38 UTC (rev 244229)
@@ -1,3 +1,22 @@
+2019-04-11 Ryosuke Niwa
+
+WebThread should run at a higher priority than user initiated
+https://bugs.webkit.org/show_bug.cgi?id=196849
+
+
+Reviewed by Geoffrey Garen.
+
+Use QOS_CLASS_USER_INTERACTIVE on WebThread with -10 relative priority so that WebThread
+won't wait for other threads with priority 30-37 but does not content with the main thread.
+
+Also removed the call to pthread_attr_setschedparam which disables QoS.
+
+This improves the blocked time in StartWebThread from 2~3ms to 250μs while cold launching
+iBooks to an opened book.
+
+* platform/ios/wak/WebCoreThread.mm:
+(StartWebThread): Replaced 200 * 4096 by 800 * KB for a better readability.
+
2019-04-12 Ryosuke Niwa
Add CSS Shadow Parts as a feature under consideration
Modified: trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm (244228 => 244229)
--- trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm 2019-04-12 18:52:01 UTC (rev 244228)
+++ trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm 2019-04-12 20:37:38 UTC (rev 244229)
@@ -667,12 +667,9 @@
// The web thread is a secondary thread, and secondary threads are usually given
// a 512 kb stack, but we need more space in order to have room for the _javascript_Core
// reentrancy limit. This limit works on both the simulator and the device.
-pthread_attr_setstacksize(&tattr, 200 * 4096);
+pthread_attr_setstacksize(&tattr, 800 * KB);
-struct sched_param param;
-pthread_attr_getschedparam(&tattr, ¶m);
-param.sched_priority--;
-pthread_attr_setschedparam(&tattr, ¶m);
+pthread_attr_set_qos_class_np(&tattr, QOS_CLASS_USER_INTERACTIVE, -10);
// Wait for the web thread to startup completely before we continue.
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244228] trunk
Title: [244228] trunk Revision 244228 Author simon.fra...@apple.com Date 2019-04-12 11:52:01 -0700 (Fri, 12 Apr 2019) Log Message [iOS WK2] Make -webkit-overflow-scrolling be a no-op https://bugs.webkit.org/show_bug.cgi?id=196803 rdar://problem/49078202 Reviewed by Antti Koivisto. Source/WebKit: Flip LegacyOverflowScrollingTouchEnabled to false. * Shared/WebPreferences.yaml: LayoutTests: Rebase some tests, if I thought that non-stacking context overflow was interesting. For others, make overflow be stacking context by adding z-index. Add to those that need it. * compositing/overflow/scrolling-content-clip-to-viewport.html: * compositing/rtl/rtl-scrolling-with-transformed-descendants.html: * fast/scrolling/ios/change-scrollability-on-content-resize-nested.html: * fast/scrolling/ios/overflow-scroll-inherited-expected.txt: * fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html: * fast/scrolling/ios/overflow-scrolling-ancestor-clip.html: * fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt: * fast/scrolling/ios/reconcile-layer-position-recursive.html: * fast/scrolling/ios/scrolling-content-clip-to-viewport.html: * fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html: * fast/scrolling/ios/touch-scroll-pointer-events-none.html: * fast/scrolling/ios/touch-scroll-visibility-hidden.html: * platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt: * platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt: * scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html: * scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html: * scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html: * scrollingcoordinator/scrolling-tree/coordinated-frame.html: * scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport.html trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt trunk/LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html trunk/LayoutTests/fast/scrolling/ios/change-scrollability-on-content-resize-nested.html trunk/LayoutTests/fast/scrolling/ios/overflow-scroll-inherited-expected.txt trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html trunk/LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip.html trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt trunk/LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html trunk/LayoutTests/fast/scrolling/ios/scrolling-content-clip-to-viewport.html trunk/LayoutTests/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html trunk/LayoutTests/fast/scrolling/ios/touch-scroll-pointer-events-none.html trunk/LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden.html trunk/LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt trunk/LayoutTests/platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt trunk/LayoutTests/platform/mac-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html trunk/LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame.html trunk/LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebPreferences.yaml Diff Modified: trunk/LayoutTests/ChangeLog (244227 => 244228) --- trunk/LayoutTests/ChangeLog 2019-04-12 18:34:43 UTC (rev 244227) +++ trunk/LayoutTests/ChangeLog 2019-04-12 18:52:01 UTC (rev 244228) @@ -4,6 +4,39 @@ * platform/win/TestExpectations: +2019-04-12 Simon Fraser + +[iOS WK2] Make -webkit-overflow-scrolling be a no-op +https://bugs.webkit.org/show_bug.cgi?id=196803 +rdar://problem/49078202 + +Reviewed by Antti Koivisto. + +Rebase some tests, if I thought that non-stacking context overflow was interesting. +For others, make overflow be stacking context by adding z-index. +Add to those that +need it. + +* compositing/overflow/scrolling-content-clip-to-viewport.html: +
[webkit-changes] [244227] trunk/LayoutTests
Title: [244227] trunk/LayoutTests Revision 244227 Author ryanhad...@apple.com Date 2019-04-12 11:34:43 -0700 (Fri, 12 Apr 2019) Log Message Unreviewed test gardening for Windows. * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (244226 => 244227) --- trunk/LayoutTests/ChangeLog 2019-04-12 18:26:44 UTC (rev 244226) +++ trunk/LayoutTests/ChangeLog 2019-04-12 18:34:43 UTC (rev 244227) @@ -1,3 +1,9 @@ +2019-04-12 Ryan Haddad + +Unreviewed test gardening for Windows. + +* platform/win/TestExpectations: + 2019-04-12 Wenson Hsieh [iOS] Software keyboard is shown too frequently on some websites Modified: trunk/LayoutTests/platform/win/TestExpectations (244226 => 244227) --- trunk/LayoutTests/platform/win/TestExpectations 2019-04-12 18:26:44 UTC (rev 244226) +++ trunk/LayoutTests/platform/win/TestExpectations 2019-04-12 18:34:43 UTC (rev 244227) @@ -4323,3 +4323,10 @@ [ Win10 ] svg/text/svg-zoom-large-value.xhtml [ Crash ] [ Win10 ] svg/text/text-style-recalc-crash.html [ Crash ] [ Win10 ] fast/dom/crash-with-bad-url.html [ Timeout ] + +webkit.org/b/196680 printing/page-with-10mm-left-margin.html [ Failure ] +webkit.org/b/196680 printing/page-with-zero-margin.html [ Failure ] + +webkit.org/b/196869 animations/animation-multiple-callbacks-timestamp.html [ Failure ] +webkit.org/b/196869 legacy-animation-engine/animations/animation-multiple-callbacks-timestamp.html [ Failure ] +webkit.org/b/196869 imported/mozilla/css-animations/test_animation-currenttime.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244226] trunk/Source/WebCore
Title: [244226] trunk/Source/WebCore
Revision 244226
Author rn...@webkit.org
Date 2019-04-12 11:26:44 -0700 (Fri, 12 Apr 2019)
Log Message
Add CSS Shadow Parts as a feature under consideration
https://bugs.webkit.org/show_bug.cgi?id=196835
Reviewed by Antti Koivisto.
This feature is under consideration.
* features.json:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json
Diff
Modified: trunk/Source/WebCore/ChangeLog (244225 => 244226)
--- trunk/Source/WebCore/ChangeLog 2019-04-12 18:18:25 UTC (rev 244225)
+++ trunk/Source/WebCore/ChangeLog 2019-04-12 18:26:44 UTC (rev 244226)
@@ -1,3 +1,14 @@
+2019-04-12 Ryosuke Niwa
+
+Add CSS Shadow Parts as a feature under consideration
+https://bugs.webkit.org/show_bug.cgi?id=196835
+
+Reviewed by Antti Koivisto.
+
+This feature is under consideration.
+
+* features.json:
+
2019-04-12 Ross Kirsling
WebKit should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF
Modified: trunk/Source/WebCore/features.json (244225 => 244226)
--- trunk/Source/WebCore/features.json 2019-04-12 18:18:25 UTC (rev 244225)
+++ trunk/Source/WebCore/features.json 2019-04-12 18:26:44 UTC (rev 244226)
@@ -214,6 +214,21 @@
}
},
{
+"name": "CSS Shadow Parts",
+"status": {
+"status": "Under Consideration"
+},
+"url": "https://drafts.csswg.org/css-shadow-parts/",
+"webkit-url": "https://webkit.org/b/149443",
+"keywords": ["css selectors", "selectors", "shadow dom", "shadow parts"],
+"category": "css",
+"description": "Allows web components to define and expose stylable parts",
+"contact": {
+"name": "Ryosuke Niwa",
+"email": "rn...@webkit.org"
+}
+},
+{
"name": "CSS Text Decoration Level 4",
"status": {
"status": "Supported in Preview",
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244225] trunk/Source
Title: [244225] trunk/Source Revision 244225 Author ross.kirsl...@sony.com Date 2019-04-12 11:18:25 -0700 (Fri, 12 Apr 2019) Log Message WebKit should build successfully even with -DENABLE_UNIFIED_BUILDS=OFF https://bugs.webkit.org/show_bug.cgi?id=196845 Reviewed by Ryosuke Niwa. Source/WebCore: * html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::FontProxy::initialize): (WebCore::CanvasRenderingContext2DBase::FontProxy::fontMetrics const): (WebCore::CanvasRenderingContext2DBase::FontProxy::fontDescription const): (WebCore::CanvasRenderingContext2DBase::FontProxy::width const): (WebCore::CanvasRenderingContext2DBase::FontProxy::drawBidiText const): (WebCore::CanvasRenderingContext2DBase::beginCompositeLayer): (WebCore::CanvasRenderingContext2DBase::endCompositeLayer): Remove inline specifier to address linking errors (regardless of CMake platform). Doing this in a .cpp file interferes with symbol creation. * Modules/mediastream/MediaStreamTrack.cpp: * Modules/webvr/VREyeParameters.cpp: * Modules/webvr/VRFrameData.cpp: * Modules/webvr/VRPose.cpp: * accessibility/AccessibilityList.cpp: * accessibility/isolatedtree/AXIsolatedTree.cpp: * accessibility/isolatedtree/AXIsolatedTreeNode.cpp: * bindings/js/JSDOMConvertWebGL.cpp: * bindings/js/JSHistoryCustom.cpp: * bindings/js/JSIDBCursorWithValueCustom.cpp: * bindings/js/JSPerformanceObserverCustom.cpp: * bindings/js/WindowProxy.cpp: * platform/ColorData.gperf: * platform/mediastream/RealtimeMediaSourceSettings.cpp: * platform/network/DNSResolveQueue.cpp: * workers/service/ServiceWorkerClientQueryOptions.h: * workers/service/ServiceWorkerContainer.cpp: Add missing includes to address compiler errors on GTK. Source/WebKit: * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h: * NetworkProcess/NetworkCORSPreflightChecker.cpp: * NetworkProcess/NetworkDataTask.cpp: * NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: * NetworkProcess/NetworkHTTPSUpgradeChecker.h: Include wtf/Forward.h for String and CompletionHandler fwd decls. * NetworkProcess/NetworkProcess.cpp: * NetworkProcess/NetworkResourceLoadMap.cpp: * NetworkProcess/NetworkResourceLoadMap.h: * NetworkProcess/NetworkResourceLoader.cpp: * NetworkProcess/PingLoad.h: * Shared/WebCompiledContentRuleListData.cpp: * Shared/gtk/WebEventFactory.cpp: * UIProcess/API/C/WKWebsiteDataStoreRef.cpp: (WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStore): (WKWebsiteDataStoreStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours): (WKWebsiteDataStoreStatisticsResetToConsistentState): * UIProcess/Downloads/DownloadProxyMap.cpp: * UIProcess/InspectorTargetProxy.cpp: * UIProcess/PageClient.h: * UIProcess/ProcessAssertion.cpp: * UIProcess/ProvisionalPageProxy.h: * UIProcess/WebPageInspectorTargetAgent.h: * UIProcess/geoclue/GeoclueGeolocationProvider.cpp: * WebProcess/Cache/WebCacheStorageConnection.cpp: (WebKit::WebCacheStorageConnection::updateQuotaBasedOnSpaceUsage): * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetDatabaseQuota): * WebProcess/Storage/WebServiceWorkerFetchTaskClient.h: Add missing includes / forward declarations to address compiler errors on GTK / WinCairo. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp trunk/Source/WebCore/Modules/webvr/VREyeParameters.cpp trunk/Source/WebCore/Modules/webvr/VRFrameData.cpp trunk/Source/WebCore/Modules/webvr/VRPose.cpp trunk/Source/WebCore/accessibility/AccessibilityList.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTreeNode.cpp trunk/Source/WebCore/bindings/js/JSDOMConvertWebGL.cpp trunk/Source/WebCore/bindings/js/JSHistoryCustom.cpp trunk/Source/WebCore/bindings/js/JSIDBCursorWithValueCustom.cpp trunk/Source/WebCore/bindings/js/JSPerformanceObserverCustom.cpp trunk/Source/WebCore/bindings/js/WindowProxy.cpp trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp trunk/Source/WebCore/platform/ColorData.gperf trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.cpp trunk/Source/WebCore/platform/network/DNSResolveQueue.cpp trunk/Source/WebCore/workers/service/ServiceWorkerClientQueryOptions.h trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp trunk/Source/WebKit/NetworkProcess/NetworkDataTask.cpp trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.cpp trunk/Source/WebKit/NetworkProcess/NetworkHTTPSUpgradeChecker.h trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadMap.cpp trunk/Source/WebKit/NetworkProcess/NetworkResourceLoadMap.h trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp trunk/Source/WebKit/NetworkProcess/PingLoad.h trunk/Source/WebKit/Shared/WebCompi
[webkit-changes] [244224] trunk/Source/WebCore
Title: [244224] trunk/Source/WebCore
Revision 244224
Author za...@apple.com
Date 2019-04-12 11:14:21 -0700 (Fri, 12 Apr 2019)
Log Message
REGRESSION (r244098): [ Mac WK1 ] Layout Test fast/dynamic/paused-event-dispatch.html is Timing out
https://bugs.webkit.org/show_bug.cgi?id=196789
Reviewed by Tim Horton.
Disable auto-sizing mode at the start of each test.
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/testing/Internals.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (244223 => 244224)
--- trunk/Source/WebCore/ChangeLog 2019-04-12 18:04:56 UTC (rev 244223)
+++ trunk/Source/WebCore/ChangeLog 2019-04-12 18:14:21 UTC (rev 244224)
@@ -1,3 +1,16 @@
+2019-04-12 Zalan Bujtas
+
+REGRESSION (r244098): [ Mac WK1 ] Layout Test fast/dynamic/paused-event-dispatch.html is Timing out
+https://bugs.webkit.org/show_bug.cgi?id=196789
+
+
+Reviewed by Tim Horton.
+
+Disable auto-sizing mode at the start of each test.
+
+* testing/Internals.cpp:
+(WebCore::Internals::resetToConsistentState):
+
2019-04-12 Eric Carlson
Update AudioSession route sharing policy
Modified: trunk/Source/WebCore/testing/Internals.cpp (244223 => 244224)
--- trunk/Source/WebCore/testing/Internals.cpp 2019-04-12 18:04:56 UTC (rev 244223)
+++ trunk/Source/WebCore/testing/Internals.cpp 2019-04-12 18:14:21 UTC (rev 244224)
@@ -459,6 +459,7 @@
page.setTopContentInset(0);
mainFrameView->setUseFixedLayout(false);
mainFrameView->setFixedLayoutSize(IntSize());
+mainFrameView->enableAutoSizeMode(false, { });
#if USE(COORDINATED_GRAPHICS)
mainFrameView->setFixedVisibleContentRect(IntRect());
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244223] trunk
Title: [244223] trunk
Revision 244223
Author eric.carl...@apple.com
Date 2019-04-12 11:04:56 -0700 (Fri, 12 Apr 2019)
Log Message
Update AudioSession route sharing policy
https://bugs.webkit.org/show_bug.cgi?id=196776
Reviewed by Jer Noble.
Source/WebCore:
No new tests, updated an API test.
* platform/audio/AudioSession.cpp:
(WebCore::convertEnumerationToString):
* platform/audio/AudioSession.h:
(WTF::LogArgument::toString):
(WTF::LogArgument::toString):
* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(MediaSessionManagerCocoa::updateSessionState):
* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::setCategory):
(WebCore::AudioSession::routeSharingPolicy const):
* platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::setCategory):
Source/WebKit:
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker showFromView:routeSharingPolicy:routingContextUID:hasVideo:]):
Source/WTF:
* wtf/Platform.h: Define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO.
Tools:
* TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
(TestWebKitAPI::routeSharingPolicyLongFormVideo):
(TestWebKitAPI::routeSharingPolicyLongFormAudio):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/AudioSession.cpp
trunk/Source/WebCore/platform/audio/AudioSession.h
trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm
trunk/Source/WebCore/platform/audio/mac/AudioSessionMac.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm
trunk/Source/WebKitLegacy/mac/Plugins/WebPluginController.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm
Diff
Modified: trunk/Source/WTF/ChangeLog (244222 => 244223)
--- trunk/Source/WTF/ChangeLog 2019-04-12 18:02:20 UTC (rev 244222)
+++ trunk/Source/WTF/ChangeLog 2019-04-12 18:04:56 UTC (rev 244223)
@@ -1,3 +1,13 @@
+2019-04-12 Eric Carlson
+
+Update AudioSession route sharing policy
+https://bugs.webkit.org/show_bug.cgi?id=196776
+
+
+Reviewed by Jer Noble.
+
+* wtf/Platform.h: Define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO.
+
2019-04-10 Said Abou-Hallawa
requestAnimationFrame should execute before the next frame
Modified: trunk/Source/WTF/wtf/Platform.h (244222 => 244223)
--- trunk/Source/WTF/wtf/Platform.h 2019-04-12 18:02:20 UTC (rev 244222)
+++ trunk/Source/WTF/wtf/Platform.h 2019-04-12 18:04:56 UTC (rev 244223)
@@ -1521,3 +1521,7 @@
#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 6) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 13)
#define HAVE_ALLOWS_SENSITIVE_LOGGING 1
#endif
+
+#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 13)
+#define HAVE_ROUTE_SHARING_POLICY_LONG_FORM_VIDEO 1
+#endif
Modified: trunk/Source/WebCore/ChangeLog (244222 => 244223)
--- trunk/Source/WebCore/ChangeLog 2019-04-12 18:02:20 UTC (rev 244222)
+++ trunk/Source/WebCore/ChangeLog 2019-04-12 18:04:56 UTC (rev 244223)
@@ -1,3 +1,26 @@
+2019-04-12 Eric Carlson
+
+Update AudioSession route sharing policy
+https://bugs.webkit.org/show_bug.cgi?id=196776
+
+
+Reviewed by Jer Noble.
+
+No new tests, updated an API test.
+
+* platform/audio/AudioSession.cpp:
+(WebCore::convertEnumerationToString):
+* platform/audio/AudioSession.h:
+(WTF::LogArgument::toString):
+(WTF::LogArgument::toString):
+* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
+(MediaSessionManagerCocoa::updateSessionState):
+* platform/audio/ios/AudioSessionIOS.mm:
+(WebCore::AudioSession::setCategory):
+(WebCore::AudioSession::routeSharingPolicy const):
+* platform/audio/mac/AudioSessionMac.cpp:
+(WebCore::AudioSession::setCategory):
+
2019-04-12 Antoine Quint
Opt some websites into the simulated mouse events dispatch quirk when in modern compatibility mode
Modified: trunk/Source/WebCore/platform/audio/AudioSession.cpp (244222 => 244223)
--- trunk/Source/WebCore/platform/audio/AudioSession.cpp 2019-04-12 18:02:20 UTC (rev 244222)
+++ trunk/Source/WebCore/platform/audio/AudioSession.cpp 2019-04-12 18:04:56 UTC (rev 244223)
@@ -60,7 +60,7 @@
AudioSession::~AudioSession() = default;
-void AudioSession::setCategory(CategoryType)
+void AudioSession::setCategory(CategoryType, RouteSharingPolicy)
{
notImplemented();
}
@@ -129,6 +129,43 @@
#endif // !PLATFORM(COCOA)
+String convertEnumerationToString(RouteSharingPolicy enumerationValue)
+{
+static const NeverDestroyed values[] = {
+MAKE_STATIC_STRING_IMPL("Default"
[webkit-changes] [244222] trunk/Source/JavaScriptCore
Title: [244222] trunk/Source/_javascript_Core
Revision 244222
Author rmoris...@apple.com
Date 2019-04-12 11:02:20 -0700 (Fri, 12 Apr 2019)
Log Message
Use padding at end of ArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=196823
Reviewed by Filip Pizlo.
* runtime/ArrayBuffer.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayBuffer.h
trunk/Source/_javascript_Core/runtime/JSBoundFunction.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (244221 => 244222)
--- trunk/Source/_javascript_Core/ChangeLog 2019-04-12 17:59:05 UTC (rev 244221)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-04-12 18:02:20 UTC (rev 244222)
@@ -1,3 +1,12 @@
+2019-04-12 Robin Morisset
+
+Use padding at end of ArrayBuffer
+https://bugs.webkit.org/show_bug.cgi?id=196823
+
+Reviewed by Filip Pizlo.
+
+* runtime/ArrayBuffer.h:
+
2019-04-11 Yusuke Suzuki
[JSC] op_has_indexed_property should not assume subscript part is Uint32
Modified: trunk/Source/_javascript_Core/runtime/ArrayBuffer.h (244221 => 244222)
--- trunk/Source/_javascript_Core/runtime/ArrayBuffer.h 2019-04-12 17:59:05 UTC (rev 244221)
+++ trunk/Source/_javascript_Core/runtime/ArrayBuffer.h 2019-04-12 18:02:20 UTC (rev 244222)
@@ -29,6 +29,7 @@
#include "GCIncomingRefCounted.h"
#include "Weak.h"
#include
+#include
#include
#include
#include
@@ -161,11 +162,11 @@
void notifyIncommingReferencesOfTransfer(VM&);
ArrayBufferContents m_contents;
-unsigned m_pinCount : 30;
-bool m_isWasmMemory : 1;
+Checked m_pinCount;
+bool m_isWasmMemory;
// m_locked == true means that some API user fetched m_contents directly from a TypedArray object,
// the buffer is backed by a WebAssembly.Memory, or is a SharedArrayBuffer.
-bool m_locked : 1;
+bool m_locked;
public:
Weak m_wrapper;
Modified: trunk/Source/_javascript_Core/runtime/JSBoundFunction.cpp (244221 => 244222)
--- trunk/Source/_javascript_Core/runtime/JSBoundFunction.cpp 2019-04-12 17:59:05 UTC (rev 244221)
+++ trunk/Source/_javascript_Core/runtime/JSBoundFunction.cpp 2019-04-12 18:02:20 UTC (rev 244222)
@@ -157,7 +157,7 @@
Structure* result = globalObject->boundFunctionStructure();
// It would be nice if the structure map was keyed global objects in addition to the other things. Unfortunately, it is not
-// currently. Whoever works on caching structure changes for prototype transistions should consider this problem as well.
+// currently. Whoever works on caching structure changes for prototype transitions should consider this problem as well.
// See: https://bugs.webkit.org/show_bug.cgi?id=152738
if (prototype.isObject() && prototype.getObject()->globalObject(vm) == globalObject) {
result = vm.structureCache.emptyStructureForPrototypeFromBaseStructure(globalObject, prototype.getObject(), result);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244221] trunk/Source/WebKit
Title: [244221] trunk/Source/WebKit Revision 244221 Author wenson_hs...@apple.com Date 2019-04-12 10:59:05 -0700 (Fri, 12 Apr 2019) Log Message WebsitePolicies doesn't copy its media source policy in WebsitePolicies::copy https://bugs.webkit.org/show_bug.cgi?id=196862 Reviewed by Darin Adler. Add a missing bit of code to copy m_mediaSourcePolicy over when making a copy of WebsitePolicies. This doesn't have any observable effect, since m_mediaSourcePolicy isn't currently exposed as SPI on WKWebpagePreferences. * UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::copy const): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (244220 => 244221) --- trunk/Source/WebKit/ChangeLog 2019-04-12 17:30:00 UTC (rev 244220) +++ trunk/Source/WebKit/ChangeLog 2019-04-12 17:59:05 UTC (rev 244221) @@ -1,5 +1,18 @@ 2019-04-12 Wenson Hsieh +WebsitePolicies doesn't copy its media source policy in WebsitePolicies::copy +https://bugs.webkit.org/show_bug.cgi?id=196862 + +Reviewed by Darin Adler. + +Add a missing bit of code to copy m_mediaSourcePolicy over when making a copy of WebsitePolicies. This doesn't +have any observable effect, since m_mediaSourcePolicy isn't currently exposed as SPI on WKWebpagePreferences. + +* UIProcess/API/APIWebsitePolicies.cpp: +(API::WebsitePolicies::copy const): + +2019-04-12 Wenson Hsieh + [iOS] Software keyboard is shown too frequently on some websites https://bugs.webkit.org/show_bug.cgi?id=195856 Modified: trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp (244220 => 244221) --- trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp 2019-04-12 17:30:00 UTC (rev 244220) +++ trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp 2019-04-12 17:59:05 UTC (rev 244221) @@ -56,6 +56,7 @@ policies->setCustomNavigatorPlatform(m_customNavigatorPlatform); policies->setPreferredCompatibilityMode(m_preferredCompatibilityMode); policies->setMetaViewportPolicy(m_metaViewportPolicy); +policies->setMediaSourcePolicy(m_mediaSourcePolicy); policies->setSimulatedMouseEventsDispatchPolicy(m_simulatedMouseEventsDispatchPolicy); Vector customHeaderFields; customHeaderFields.reserveInitialCapacity(m_customHeaderFields.size()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244220] trunk
Title: [244220] trunk Revision 244220 Author wenson_hs...@apple.com Date 2019-04-12 10:30:00 -0700 (Fri, 12 Apr 2019) Log Message [iOS] Software keyboard is shown too frequently on some websites https://bugs.webkit.org/show_bug.cgi?id=195856 Reviewed by Darin Adler. Source/WebCore/PAL: Declare new GraphicsServices SPI. * pal/spi/ios/GraphicsServicesSPI.h: Source/WebKit: On some websites, hidden editable elements are very frequently focused upon user interaction. Currently, this causes the software keyboard to pop in and out unexpectedly; luckily, these same sites also apply inputmode="none" to the hidden editable element, which ought to ensure that the software keyboard doesn't appear when the element is focused. However, since we disabled support for inputmode="none" in r240497, the software keyboard is no longer suppressed, and becomes a big nuissance. r240497 removed support for this feature because, when using a hardware keyboard, pressing the globe key no longer showed UI for switching languages. However, support for inputmode none makes a much larger impact when a software keyboard is used (since the entire software keyboard animates in and out), whereas a hardware keyboard only displays an input accessory view. For this reason, we can mitigate this bug without reintroducing by re-enabling inputmode="none", but only when a hardware keyboard is not attached. * UIProcess/API/Cocoa/WKWebView.mm: (hardwareKeyboardAvailabilityChangedCallback): * UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView shouldShowAutomaticKeyboardUI]): Don't show the keyboard if inputmode is none and a hardware keyboard is not attached. (-[WKContentView _hardwareKeyboardAvailabilityChanged]): Reload input views if the inputmode is none to ensure that if a hardware keyboard is attached while editing an element with inputmode="none", we'll show the input accessory view once again. Tools: Add support for attaching or detaching the hardware keyboard on iOS in layout tests. * DumpRenderTree/ios/UIScriptControllerIOS.mm: (WTR::UIScriptController::setHardwareKeyboardAttached): * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: * TestRunnerShared/UIScriptContext/UIScriptController.cpp: (WTR::UIScriptController::setHardwareKeyboardAttached): * TestRunnerShared/UIScriptContext/UIScriptController.h: * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Additionally link against GraphicsServices in WebKitTestRunner. * WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::TestController::platformResetStateToConsistentValues): (WTR::UIScriptController::setHardwareKeyboardAttached): WebKitLibraries: Add a symbol for GSEventSetHardwareKeyboardAttached. * WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd: LayoutTests: Fix a failing layout test, which (among other reasons) is currently failing because support for inputmode="none" is disabled. * fast/forms/ios/inputmode-none-expected.txt: * fast/forms/ios/inputmode-none.html: * resources/ui-helper.js: Add a UIHelper method for attaching or detaching the hardware keyboard. (window.UIHelper.setHardwareKeyboardAttached): (window.UIHelper): Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/ios/inputmode-none-expected.txt trunk/LayoutTests/fast/forms/ios/inputmode-none.html trunk/LayoutTests/resources/ui-helper.js trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/ios/UIScriptControllerIOS.mm trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig trunk/Tools/WebKitTestRunner/ios/TestControllerIOS.mm trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm trunk/WebKitLibraries/ChangeLog trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/12/GraphicsServices.framework/GraphicsServices.tbd Diff Modified: trunk/LayoutTests/ChangeLog (244219 => 244220) --- trunk/LayoutTests/ChangeLog 2019-04-12 17:12:37 UTC (rev 244219) +++ trunk/LayoutTests/ChangeLog 2019-04-12 17:30:00 UTC (rev 244220) @@ -1,3 +1,23 @@ +2019-04-12 Wenson Hsieh + +[iOS] Software keyboard is shown too frequently on some websites +https://bugs.webkit.org/show_bug.cgi?id=195856 + + +Reviewed by Darin Adler. + +Fix a failing layout test, which (among other reasons) is currently failing because support for inputmode="none" +is disabled. + +* fast/forms/ios/inputmode-none-expected.txt: +
[webkit-changes] [244219] trunk/LayoutTests
Title: [244219] trunk/LayoutTests Revision 244219 Author ryanhad...@apple.com Date 2019-04-12 10:12:37 -0700 (Fri, 12 Apr 2019) Log Message [macOS WK1] ASSERTION FAILED: formData in WebCore::ResourceRequest::doUpdateResourceHTTPBody() https://bugs.webkit.org/show_bug.cgi?id=196864 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Skip test since it consistently crashes, update bug number. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (244218 => 244219) --- trunk/LayoutTests/ChangeLog 2019-04-12 16:52:35 UTC (rev 244218) +++ trunk/LayoutTests/ChangeLog 2019-04-12 17:12:37 UTC (rev 244219) @@ -1,3 +1,12 @@ +2019-04-12 Ryan Haddad + +[macOS WK1] ASSERTION FAILED: formData in WebCore::ResourceRequest::doUpdateResourceHTTPBody() +https://bugs.webkit.org/show_bug.cgi?id=196864 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: Skip test since it consistently crashes, update bug number. + 2019-04-11 Simon Fraser [iOS WK2] Wrong scrolling behavior for nested absolute position elements inside overflow scroll Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (244218 => 244219) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2019-04-12 16:52:35 UTC (rev 244218) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2019-04-12 17:12:37 UTC (rev 244219) @@ -432,7 +432,7 @@ [ Sierra+ ] svg/hixie/text/003.html [ Failure ] webkit.org/b/159893 [ Debug ] imported/w3c/web-platform-tests/xhr/event-readystatechange-loaded.htm [ Pass Failure ] -webkit.org/b/188816 [ Debug ] imported/w3c/web-platform-tests/xhr/event-upload-progress.htm [ Pass Crash ] +webkit.org/b/196864 [ Debug ] imported/w3c/web-platform-tests/xhr/event-upload-progress.htm [ Skip ] webkit.org/b/160101 userscripts/window-onerror-for-isolated-world-3.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244218] trunk/Source
Title: [244218] trunk/Source Revision 244218 Author grao...@webkit.org Date 2019-04-12 09:52:35 -0700 (Fri, 12 Apr 2019) Log Message Opt some websites into the simulated mouse events dispatch quirk when in modern compatibility mode https://bugs.webkit.org/show_bug.cgi?id=196830 Reviewed by Wenson Hsieh. Source/WebCore: We add a new policy to determine whether simulated mouse events dispatch are allowed and use it to determine whether the simulated mouse events dispatch quirk can be used for a given website. We then check the domain name for the current page's document to see if it matches some known websites that require this quirk. We needed to add some calls into Quirks::shouldDispatchSimulateMouseEvents() where we used to only consult the RuntimeEnabledFeature flag to ensure we correctly created touch regions for simulated mouse events. * dom/EventNames.h: (WebCore::EventNames::isTouchRelatedEventType const): * dom/Node.cpp: (WebCore::Node::moveNodeToNewDocument): (WebCore::tryAddEventListener): (WebCore::tryRemoveEventListener): (WebCore::Node::defaultEventHandler): * loader/DocumentLoader.h: (WebCore::DocumentLoader::simulatedMouseEventsDispatchPolicy const): (WebCore::DocumentLoader::setSimulatedMouseEventsDispatchPolicy): * page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener): (WebCore::DOMWindow::removeEventListener): * page/Quirks.cpp: (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const): (WebCore::Quirks::shouldDispatchSimulateMouseEvents const): Deleted. * page/Quirks.h: Source/WebKit: We add a new policy to determine whether simulated mouse events dispatch are allowed. * Shared/WebsitePoliciesData.cpp: (WebKit::WebsitePoliciesData::encode const): (WebKit::WebsitePoliciesData::decode): (WebKit::WebsitePoliciesData::applyToDocumentLoader): * Shared/WebsitePoliciesData.h: * Shared/WebsiteSimulatedMouseEventsDispatchPolicy.h: Added. * UIProcess/API/APIWebsitePolicies.cpp: (API::WebsitePolicies::copy const): (API::WebsitePolicies::data): * UIProcess/API/APIWebsitePolicies.h: * WebKit.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/EventNames.h trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/loader/DocumentLoader.h trunk/Source/WebCore/page/DOMWindow.cpp trunk/Source/WebCore/page/Quirks.cpp trunk/Source/WebCore/page/Quirks.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/WebsitePoliciesData.cpp trunk/Source/WebKit/Shared/WebsitePoliciesData.h trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp trunk/Source/WebKit/UIProcess/API/APIWebsitePolicies.h trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit/Shared/WebsiteSimulatedMouseEventsDispatchPolicy.h Diff Modified: trunk/Source/WebCore/ChangeLog (244217 => 244218) --- trunk/Source/WebCore/ChangeLog 2019-04-12 16:11:46 UTC (rev 244217) +++ trunk/Source/WebCore/ChangeLog 2019-04-12 16:52:35 UTC (rev 244218) @@ -1,3 +1,36 @@ +2019-04-12 Antoine Quint + +Opt some websites into the simulated mouse events dispatch quirk when in modern compatibility mode +https://bugs.webkit.org/show_bug.cgi?id=196830 + + +Reviewed by Wenson Hsieh. + +We add a new policy to determine whether simulated mouse events dispatch are allowed and use it to determine whether the +simulated mouse events dispatch quirk can be used for a given website. We then check the domain name for the current page's +document to see if it matches some known websites that require this quirk. + +We needed to add some calls into Quirks::shouldDispatchSimulateMouseEvents() where we used to only consult the RuntimeEnabledFeature +flag to ensure we correctly created touch regions for simulated mouse events. + +* dom/EventNames.h: +(WebCore::EventNames::isTouchRelatedEventType const): +* dom/Node.cpp: +(WebCore::Node::moveNodeToNewDocument): +(WebCore::tryAddEventListener): +(WebCore::tryRemoveEventListener): +(WebCore::Node::defaultEventHandler): +* loader/DocumentLoader.h: +(WebCore::DocumentLoader::simulatedMouseEventsDispatchPolicy const): +(WebCore::DocumentLoader::setSimulatedMouseEventsDispatchPolicy): +* page/DOMWindow.cpp: +(WebCore::DOMWindow::addEventListener): +(WebCore::DOMWindow::removeEventListener): +* page/Quirks.cpp: +(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const): +(WebCore::Quirks::shouldDispatchSimulateMouseEvents const): Deleted. +* page/Quirks.h: + 2019-04-11 Simon Fraser [iOS WK2] Wrong scrolling behavior for nested absolute position elements inside overflow scroll Modified: trunk/Source/WebCore/dom/EventNames.h (244217 => 244218) --- trunk/Source/WebCore/dom/EventNames.h 2019-04-12 16:11:46 UTC (rev 244217) +++ trunk/Source/WebCore/dom/EventNames.h 2019-04-12 16:52:35 UTC (rev 244218) @@ -21,6 +21,8
[webkit-changes] [244217] trunk/Source/WebKit
Title: [244217] trunk/Source/WebKit
Revision 244217
Author cdu...@apple.com
Date 2019-04-12 09:11:46 -0700 (Fri, 12 Apr 2019)
Log Message
[iOS Sim Debug] ASSERTION FAILED: m_downloads.isEmpty() Layout Test http/tests/websocket/tests/hybi/network-process-crash-error.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=196781
Reviewed by Darin Adler.
When the network process gets terminated by the client, the NetworkProcessProxy object (and thus its DownloadProxyMap member) get
destroyed right away, before we get a call to didClose(IPC::Connection&). As a result, if there are ongoing downloads at the time
of the termination, we will hit the assertion above. To address the issue, update the NetworkProcessProxy destructor to invalidate
its DownloadProxyMap member, similator to what it does in didClose(IPC::Connection&).
* UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::invalidate):
(WebKit::DownloadProxyMap::processDidClose): Deleted.
* UIProcess/Downloads/DownloadProxyMap.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didClose):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp
trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h
trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (244216 => 244217)
--- trunk/Source/WebKit/ChangeLog 2019-04-12 15:54:11 UTC (rev 244216)
+++ trunk/Source/WebKit/ChangeLog 2019-04-12 16:11:46 UTC (rev 244217)
@@ -1,3 +1,24 @@
+2019-04-12 Chris Dumez
+
+[iOS Sim Debug] ASSERTION FAILED: m_downloads.isEmpty() Layout Test http/tests/websocket/tests/hybi/network-process-crash-error.html is a flaky crash
+https://bugs.webkit.org/show_bug.cgi?id=196781
+
+
+Reviewed by Darin Adler.
+
+When the network process gets terminated by the client, the NetworkProcessProxy object (and thus its DownloadProxyMap member) get
+destroyed right away, before we get a call to didClose(IPC::Connection&). As a result, if there are ongoing downloads at the time
+of the termination, we will hit the assertion above. To address the issue, update the NetworkProcessProxy destructor to invalidate
+its DownloadProxyMap member, similator to what it does in didClose(IPC::Connection&).
+
+* UIProcess/Downloads/DownloadProxyMap.cpp:
+(WebKit::DownloadProxyMap::invalidate):
+(WebKit::DownloadProxyMap::processDidClose): Deleted.
+* UIProcess/Downloads/DownloadProxyMap.h:
+* UIProcess/Network/NetworkProcessProxy.cpp:
+(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
+(WebKit::NetworkProcessProxy::didClose):
+
2019-04-11 Carlos Garcia Campos
[GTK] REGRESSION(r243860): Many tests failing
Modified: trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp (244216 => 244217)
--- trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp 2019-04-12 15:54:11 UTC (rev 244216)
+++ trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp 2019-04-12 16:11:46 UTC (rev 244217)
@@ -110,7 +110,7 @@
}
}
-void DownloadProxyMap::processDidClose()
+void DownloadProxyMap::invalidate()
{
// Invalidate all outstanding downloads.
for (const auto& download : m_downloads.values()) {
Modified: trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h (244216 => 244217)
--- trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h 2019-04-12 15:54:11 UTC (rev 244216)
+++ trunk/Source/WebKit/UIProcess/Downloads/DownloadProxyMap.h 2019-04-12 16:11:46 UTC (rev 244217)
@@ -59,7 +59,7 @@
bool isEmpty() const { return m_downloads.isEmpty(); }
-void processDidClose();
+void invalidate();
void applicationDidEnterBackground();
void applicationWillEnterForeground();
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (244216 => 244217)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2019-04-12 15:54:11 UTC (rev 244216)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2019-04-12 16:11:46 UTC (rev 244217)
@@ -97,6 +97,9 @@
proxy->removeNetworkProcess(*this);
#endif
+if (m_downloadProxyMap)
+m_downloadProxyMap->invalidate();
+
for (auto& reply : m_pendingConnectionReplies)
reply.second({ });
}
@@ -273,7 +276,7 @@
auto protectedProcessPool = makeRef(m_processPool);
if (m_downloadProxyMap)
-m_downloadProxyMap->processDidClose();
+m_downloadProxyMap->invalidate();
#if ENABLE(LEGACY_CUSTOM_PROTOCOL_MANAGER)
m_customProtocolManagerProxy.invalidate();
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244216] trunk/LayoutTests/imported/w3c
Title: [244216] trunk/LayoutTests/imported/w3c Revision 244216 Author commit-qu...@webkit.org Date 2019-04-12 08:54:11 -0700 (Fri, 12 Apr 2019) Log Message Import WPT preload tests https://bugs.webkit.org/show_bug.cgi?id=196439 Patch by Rob Buis on 2019-04-12 Reviewed by Youenn Fablet. * web-platform-tests/preload/avoid-delaying-onload-link-preload-expected.txt: Added. * web-platform-tests/preload/avoid-delaying-onload-link-preload.html: Added. * web-platform-tests/preload/delaying-onload-link-preload-after-discovery-expected.txt: Added. * web-platform-tests/preload/delaying-onload-link-preload-after-discovery.html: Added. * web-platform-tests/preload/dynamic-adding-preload-expected.txt: Added. * web-platform-tests/preload/dynamic-adding-preload.html: Added. * web-platform-tests/preload/preload-csp.sub-expected.txt: Added. * web-platform-tests/preload/preload-csp.sub.html: Added. * web-platform-tests/preload/preload-default-csp.sub-expected.txt: Added. * web-platform-tests/preload/preload-default-csp.sub.html: Added. * web-platform-tests/preload/resources/dummy.css: Added. * web-platform-tests/preload/resources/dummy.css.sub.headers: Added. * web-platform-tests/preload/resources/dummy.js: Added. * web-platform-tests/preload/resources/dummy.js.sub.headers: Added. * web-platform-tests/preload/resources/dummy.xml: Added. * web-platform-tests/preload/resources/dummy.xml.sub.headers: Added. * web-platform-tests/preload/resources/foo.vtt: Added. * web-platform-tests/preload/resources/preload_helper.js: Added. (verifyPreloadAndRTSupport): (getAbsoluteURL): (verifyNumberOfResourceTimingEntries): (verifyLoadedAndNoDoubleDownload): * web-platform-tests/preload/resources/sound_5.oga: Added. * web-platform-tests/preload/resources/square.png: Added. * web-platform-tests/preload/resources/white.mp4: Added. * web-platform-tests/preload/single-download-late-used-preload-expected.txt: Added. * web-platform-tests/preload/single-download-late-used-preload.html: Added. * web-platform-tests/preload/single-download-preload-expected.txt: Added. * web-platform-tests/preload/single-download-preload.html: Added. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/preload/avoid-delaying-onload-link-preload-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/preload/avoid-delaying-onload-link-preload.html trunk/LayoutTests/imported/w3c/web-platform-tests/preload/delaying-onload-link-preload-after-discovery-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/preload/delaying-onload-link-preload-after-discovery.html trunk/LayoutTests/imported/w3c/web-platform-tests/preload/dynamic-adding-preload-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/preload/dynamic-adding-preload.html trunk/LayoutTests/imported/w3c/web-platform-tests/preload/preload-csp.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/preload/preload-csp.sub.html trunk/LayoutTests/imported/w3c/web-platform-tests/preload/preload-default-csp.sub-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/preload/preload-default-csp.sub.html trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/ trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/dummy.css trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/dummy.css.sub.headers trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/dummy.js trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/dummy.js.sub.headers trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/dummy.xml trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/dummy.xml.sub.headers trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/foo.vtt trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/preload_helper.js trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/sound_5.oga trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/square.png trunk/LayoutTests/imported/w3c/web-platform-tests/preload/resources/white.mp4 trunk/LayoutTests/imported/w3c/web-platform-tests/preload/single-download-late-used-preload-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/preload/single-download-late-used-preload.html trunk/LayoutTests/imported/w3c/web-platform-tests/preload/single-download-preload-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/preload/single-download-preload.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (244215 => 244216) --- trunk/LayoutTests/imported/w3c/ChangeLog 2019-04-12 14:54:12 UTC (rev 244215) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2019-04-12 15:54:11 UTC (rev 244216) @@ -1,3 +1,40 @@ +2019-04-12 Rob Buis + +Import WPT preload tests +https://bugs.webkit.org/show_bug.cgi?id=196439 + +Reviewed by Youenn Fablet. + +* web-platform-tests/preload/avoid-delaying-onload-l
[webkit-changes] [244215] trunk
Title: [244215] trunk Revision 244215 Author simon.fra...@apple.com Date 2019-04-12 07:54:12 -0700 (Fri, 12 Apr 2019) Log Message [iOS WK2] Wrong scrolling behavior for nested absolute position elements inside overflow scroll https://bugs.webkit.org/show_bug.cgi?id=196146 Reviewed by Antti Koivisto. Source/WebCore: computeCoordinatedPositioningForLayer() failed to handle nested positions elements inside overflow scroll, because it only walked up to the first containing block of a nested position:absolute. We need to walk all the way up the ancestor layer chain, looking at containing block, scroller and composited ancestor relationships. Make this code easier to understand by writing it in terms of "is foo scrolled by bar", rather than trying to collapse all the logic into a single ancestor walk, which was really hard. This is a few more ancestor traversals, but we now only run this code if there's composited scrolling in the ancestor chain. Tests: scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow.html scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow.html scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow.html scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html * rendering/RenderLayerCompositor.cpp: (WebCore::enclosingCompositedScrollingLayer): (WebCore::isScrolledByOverflowScrollLayer): (WebCore::isNonScrolledLayerInsideScrolledCompositedAncestor): (WebCore::RenderLayerCompositor::layerContainingBlockCrossesCoordinatedScrollingBoundary): (WebCore::collectStationaryLayerRelatedOverflowNodes): (WebCore::RenderLayerCompositor::computeCoordinatedPositioningForLayer const): (WebCore::collectRelatedCoordinatedScrollingNodes): (WebCore::layerParentedAcrossCoordinatedScrollingBoundary): Deleted. LayoutTests: Dump the scrolling tree for various configurations of positioned, overflow and stacking context elements. * fast/scrolling/ios/overflow-scroll-overlap-6-expected.txt: Progressed results. * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt: Added. * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt: Added. * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt: Added. * platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt: Added. * scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt: Added. * scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow.html: Added. * scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt: Added. * scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow.html: Added. * scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt: Added. * scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow.html: Added. * scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt: Added. * scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/scrolling/ios/overflow-scroll-overlap-6-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp Added Paths trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt trunk/LayoutTests/platform/ios-wk2/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-absolute-overflow.html trunk/LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-overflow.html trunk/LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-relative-in-overflow.html trunk/LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow-expected.txt trunk/LayoutTests/scrollingcoordinator/scrolling-tree/nested-absolute-in-sc-overflow.html Diff Modified: trunk/LayoutTests/ChangeLog (244214 => 244215) --- trunk/LayoutTests/ChangeLog 2019-04-12 13:29:42 UTC (rev 244214) +++ trunk/LayoutTests/ChangeLog 2019-04-12 14:54:12 UTC (rev 244215) @@ -1,3 +1,27 @@ +2019-04-11 Simon Fraser + +[iOS WK2] Wrong scrolling behavior for nested absolute position elements
[webkit-changes] [244214] trunk/Tools
Title: [244214] trunk/Tools
Revision 244214
Author commit-qu...@webkit.org
Date 2019-04-12 06:29:42 -0700 (Fri, 12 Apr 2019)
Log Message
[GTK][WPE] Fix pacman install-dependencies packages
https://bugs.webkit.org/show_bug.cgi?id=196817
Patch by Ludovico de Nittis on 2019-04-12
Reviewed by Žan Doberšek.
python3-setuptools is called python-setuptools
ruby-highline is only available on AUR
libv4l-devel is incorporated in v4l-utils
* gtk/install-dependencies:
* wpe/install-dependencies:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies
trunk/Tools/wpe/install-dependencies
Diff
Modified: trunk/Tools/ChangeLog (244213 => 244214)
--- trunk/Tools/ChangeLog 2019-04-12 12:04:20 UTC (rev 244213)
+++ trunk/Tools/ChangeLog 2019-04-12 13:29:42 UTC (rev 244214)
@@ -1,3 +1,17 @@
+2019-04-12 Ludovico de Nittis
+
+[GTK][WPE] Fix pacman install-dependencies packages
+https://bugs.webkit.org/show_bug.cgi?id=196817
+
+Reviewed by Žan Doberšek.
+
+python3-setuptools is called python-setuptools
+ruby-highline is only available on AUR
+libv4l-devel is incorporated in v4l-utils
+
+* gtk/install-dependencies:
+* wpe/install-dependencies:
+
2019-04-11 Carlos Garcia Campos
[GTK] REGRESSION(r243860): Many tests failing
Modified: trunk/Tools/gtk/install-dependencies (244213 => 244214)
--- trunk/Tools/gtk/install-dependencies 2019-04-12 12:04:20 UTC (rev 244213)
+++ trunk/Tools/gtk/install-dependencies 2019-04-12 13:29:42 UTC (rev 244214)
@@ -370,7 +370,7 @@
perl-xml-libxml\
python2 \
python2-lxml \
-python3-setuptools \
+python-setuptools \
ragel \
bigreqsproto \
compositeproto \
Modified: trunk/Tools/wpe/install-dependencies (244213 => 244214)
--- trunk/Tools/wpe/install-dependencies 2019-04-12 12:04:20 UTC (rev 244213)
+++ trunk/Tools/wpe/install-dependencies 2019-04-12 13:29:42 UTC (rev 244214)
@@ -191,7 +191,7 @@
zlib"
# These are dependencies necessary for running tests.
-# Note: apache-mod_bw and ruby-json is available in the AUR
+# Note: apache-mod_bw, ruby-json and ruby-highline are available in the AUR
packages="$packages \
apache \
curl \
@@ -204,8 +204,7 @@
python2-gobject \
python2-lxml \
python2-psutil \
-ruby \
-ruby-highline"
+ruby"
# These are dependencies necessary for building the jhbuild.
packages="$packages \
@@ -217,7 +216,6 @@
libpulse \
libsrtp \
libtheora \
-libv4l-dev \
libvorbis \
libvpx \
libxcb \
@@ -228,7 +226,7 @@
opus \
orc \
perl-xml-libxml \
-python3-setuptools \
+python-setuptools \
util-linux \
v4l-utils \
xorg-xrandr \
@@ -240,9 +238,26 @@
svn"
pacman -S --needed $packages
-echo "You will also need to follow the instructions on the Arch Wiki to make"
-echo "'python' call python2 in the webkit folder"
-echo "https://wiki.archlinux.org/index.php/Python#Dealing_with_version_problem_in_build_scripts"
+ cat <<-EOF
+
+The following packages are available from AUR, and needed for running tests:
+
+apache-mod_bw ruby-json ruby-highline
+
+Instructions on how to use the AUR can be found on the Arch Wiki:
+
+https://wiki.archlinux.org/index.php/Arch_User_Repository
+
+You will also need to follow the instructions on the wiki to make 'python'
+call python2 in the WebKit folder:
+
+https://wiki.archlinux.org/index.php/Python#Dealing_with_version_problem_in_build_scripts
+
+Alternatively, you may use a Python 2.x virtualenv while hacking on WebKitGTK+:
+
+https://wiki.archlinux.org/index.php/Python/Virtual_environment
+
+EOF
}
function installDependenciesWithDnf {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [244213] trunk
Title: [244213] trunk Revision 244213 Author r...@igalia.com Date 2019-04-12 05:04:20 -0700 (Fri, 12 Apr 2019) Log Message [css-flex][css-grid] Fix synthesized baseline https://bugs.webkit.org/show_bug.cgi?id=196312 Reviewed by Javier Fernandez. LayoutTests/imported/w3c: Imported some tests from WPT css-align test suite that are fixed with this patch. * resources/import-expectations.json: * web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-flexbox-001-expected.txt: Added. * web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-flexbox-001.html: Added. * web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-grid-001-expected.txt: Added. * web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-grid-001.html: Added. * web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-inline-block-001-expected.txt: Added. * web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-inline-block-001.html: Added. * web-platform-tests/css/css-align/baseline-rules/w3c-import.log: Added. Source/WebCore: When a flex or grid container has no baseline, its baseline should be synthesized from the border edges. The same happens for flex and grid items. Right now we were using the content box in some cases and even using the margin box in a particular scenario. The patch fixes this. At the same time this is also fixing the baseline for inline flex/grid containers to make it interoperable with Firefox. Inline blocks have a special behavior per legacy reasons, which applies to inline flex/grid containers when they have no items; otherwise the items should be used to compute its baseline. See more at: https://github.com/w3c/csswg-drafts/issues/3416 Note that we need to keep current behavior for buttons, as the flexbox spec doesn't apply to them. Tests: css3/flexbox/flexbox-baseline-margins.html fast/css-grid-layout/grid-baseline-margins-1.html fast/css-grid-layout/grid-baseline-margins-2.html imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-flexbox-001.html imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-grid-001.html imported/w3c/web-platform-tests/css/css-align/baseline-rules/synthesized-baseline-inline-block-001.html * rendering/RenderButton.cpp: (WebCore::synthesizedBaselineFromContentBox): (WebCore::RenderButton::baselinePosition const): * rendering/RenderButton.h: * rendering/RenderFlexibleBox.cpp: (WebCore::synthesizedBaselineFromBorderBox): (WebCore::RenderFlexibleBox::baselinePosition const): (WebCore::RenderFlexibleBox::firstLineBaseline const): (WebCore::RenderFlexibleBox::inlineBlockBaseline const): * rendering/RenderGrid.cpp: (WebCore::RenderGrid::baselinePosition const): (WebCore::RenderGrid::inlineBlockBaseline const): LayoutTests: Some of the tests were not checking the right behavior changed them to test the expected one. We need new rebaselines for some tests. * TestExpectations: * css3/flexbox/flexbox-baseline-margins.html: * fast/css-grid-layout/grid-baseline-expected.html: * fast/css-grid-layout/grid-baseline-margins-1-expected.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-margins-expected.html. * fast/css-grid-layout/grid-baseline-margins-1.html: Renamed from LayoutTests/fast/css-grid-layout/grid-baseline-margins.html. * fast/css-grid-layout/grid-baseline-margins-2-expected.html: Added. * fast/css-grid-layout/grid-baseline-margins-2.html: Added. * fast/css-grid-layout/grid-baseline.html: This test is modified and split in two parts as it doesn't fit in the viewport. * platform/gtk/css3/flexbox/flexbox-baseline-margins-expected.png: * platform/gtk/css3/flexbox/flexbox-baseline-margins-expected.txt: * platform/ios/css3/flexbox/flexbox-baseline-margins-expected.png: Added. * platform/ios/css3/flexbox/flexbox-baseline-margins-expected.txt: * platform/mac/css3/flexbox/flexbox-baseline-margins-expected.png: Added. * platform/mac/css3/flexbox/flexbox-baseline-margins-expected.txt: * platform/win/css3/flexbox/flexbox-baseline-margins-expected.png: Added. * platform/win/css3/flexbox/flexbox-baseline-margins-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/css3/flexbox/flexbox-baseline-margins.html trunk/LayoutTests/fast/css-grid-layout/grid-baseline-expected.html trunk/LayoutTests/fast/css-grid-layout/grid-baseline.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/resources/import-expectations.json trunk/LayoutTests/platform/gtk/css3/flexbox/flexbox-baseline-margins-expected.png trunk/LayoutTests/platform/gtk/css3/flexbox/flexbox-baseline-margins-expected.txt trunk/LayoutTests/platform/ios/css3/flexbox/flexbox-baseline-margins-expected.txt trunk/LayoutTests/platform/mac/css3/flexbox/flexbox-baseline-margins-expected.txt trunk/LayoutTests/platform/win/css3/flexbox/flexbox-baseline-margins-expected.txt trunk
[webkit-changes] [244212] trunk
Title: [244212] trunk Revision 244212 Author carlo...@webkit.org Date 2019-04-12 01:46:57 -0700 (Fri, 12 Apr 2019) Log Message [GTK] REGRESSION(r243860): Many tests failing https://bugs.webkit.org/show_bug.cgi?id=196791 Reviewed by Joanmarie Diggs. Source/WebKit: Calling updateAccessibilityTree() on document loaded was causing a re-layout because of the backing store update that confused all those tests. We shouldn't need to update the accessibility tree on document load, it should happen automatically when root object is attached/detached. This patch emits children-changed::add when the root object wrapper is attached and children-changed::remove when the root object is detached. That way ATs are notified of the changes in the accessibility tree. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad): Remove call to WebPage::updateAccessibilityTree(). * WebProcess/WebPage/WebPage.h: Remove updateAccessibilityTree(). * WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp: (coreRootObjectWrapperDetachedCallback): Emit children-changed::remove. (rootWebAreaWrapper): Helper to get the root WebArea wrapper. (accessibilityRootObjectWrapper): Set the parent here when root object is created and emit children-changed::add. (webkitWebPageAccessibilityObjectRefChild): Dot no set the parent here, it's now set when the root object is created. * WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.h: Remove webkitWebPageAccessibilityObjectRefresh(). * WebProcess/WebPage/gtk/WebPageGtk.cpp: Tools: Rework the accessibility unit test to use DBus for the communication with the server. This way we can load multiple documents and check that accessibility hierarchy is updated after a navigation. * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp: (loadChangedCallback): * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp: (AccessibilityTest::AccessibilityTest): (AccessibilityTest::~AccessibilityTest): (AccessibilityTest::loadHTMLAndWaitUntilFinished): (AccessibilityTest::findTestServerApplication): (AccessibilityTest::findDocumentWeb): (AccessibilityTest::findRootObject): (AccessibilityTest::waitUntilChildrenRemoved): (AccessibilityTest::ensureProxy): (testAtspiBasicHierarchy): (beforeAll): (afterAll): LayoutTests: Remove expectations for tests that pass now. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.cpp trunk/Source/WebKit/WebProcess/WebPage/atk/WebKitWebPageAccessibilityObject.h trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp Diff Modified: trunk/LayoutTests/ChangeLog (244211 => 244212) --- trunk/LayoutTests/ChangeLog 2019-04-12 06:35:17 UTC (rev 244211) +++ trunk/LayoutTests/ChangeLog 2019-04-12 08:46:57 UTC (rev 244212) @@ -1,3 +1,14 @@ +2019-04-11 Carlos Garcia Campos + +[GTK] REGRESSION(r243860): Many tests failing +https://bugs.webkit.org/show_bug.cgi?id=196791 + +Reviewed by Joanmarie Diggs. + +Remove expectations for tests that pass now. + +* platform/gtk/TestExpectations: + 2019-04-11 Megan Gardner Fix flaky LayoutTests/fast/events/autoscroll-when-input-is-offscreen.html Modified: trunk/LayoutTests/platform/gtk/TestExpectations (244211 => 244212) --- trunk/LayoutTests/platform/gtk/TestExpectations 2019-04-12 06:35:17 UTC (rev 244211) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2019-04-12 08:46:57 UTC (rev 244212) @@ -1893,7 +1893,7 @@ webkit.org/b/181030 wasm/iframe-postmessage.html [ Pass Failure ] webkit.org/b/179948 [ Release ] fast/hidpi/filters-reference.html [ Pass ImageOnlyFailure ] -webkit.org/b/196791 webkit.org/b/181031 fast/frames/crash-when-iframe-is-remove-in-eventhandler.html [ Pass Crash Failure ] +webkit.org/b/181031 fast/frames/crash-when-iframe-is-remove-in-eventhandler.html [ Pass Crash ] webkit.org/b/181528 http/tests/cache/memory-cache-pruning.html [ Pass Crash ] @@ -3817,49 +3817,6 @@ webkit.org/b/196541 editing/pasteboard/paste-content-with-overflow-auto-parent-across-origin.html [ Failure ] -webkit.org/b/196791 tables/mozilla/dom/deleteCol1.html [ Failure ] -webkit.org/b/196791 tables/mozilla/dom/deleteCol2.html [ Failure ] -webkit.org/b/196791 tables/mozilla/dom/deleteCol3.html [ Failure ] -webkit.org/b/196791 tables/mozilla/dom/deleteColGroup1.html [ Failure ] -webkit.org/b/196791 tables/mozilla/dom/deleteColGroup2.html [ Failure ] -webkit.org/b/196791 tables/mozilla/dom/insertColGroups1.html [ Failure ] -webkit.org/b/196791
