[webkit-changes] [251768] trunk/Source/WebCore

[rniwa]

Title: [251768] trunk/Source/WebCore








Revision 251768
Author rn...@webkit.org
Date 2019-10-29 22:12:28 -0700 (Tue, 29 Oct 2019)


Log Message
Remove HTMLMediaElementDestructorScope
https://bugs.webkit.org/show_bug.cgi?id=203600

Reviewed by Chris Dumez.

Removed the workaround introduced in r231392 for the bug 185284 now that it's been fixed.

No new tests since this code should be dead code.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::isRunningDestructor): Deleted.
(WebCore::HTMLMediaElementDestructorScope::HTMLMediaElementDestructorScope): Deleted.
(WebCore::HTMLMediaElementDestructorScope::~HTMLMediaElementDestructorScope): Deleted.
* html/HTMLMediaElement.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/loader/FrameLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (251767 => 251768)

--- trunk/Source/WebCore/ChangeLog	2019-10-30 04:29:48 UTC (rev 251767)
+++ trunk/Source/WebCore/ChangeLog	2019-10-30 05:12:28 UTC (rev 251768)
@@ -1,3 +1,23 @@
+2019-10-29  Ryosuke Niwa  
+
+Remove HTMLMediaElementDestructorScope
+https://bugs.webkit.org/show_bug.cgi?id=203600
+
+Reviewed by Chris Dumez.
+
+Removed the workaround introduced in r231392 for the bug 185284 now that it's been fixed.
+
+No new tests since this code should be dead code.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::~HTMLMediaElement):
+(WebCore::HTMLMediaElement::isRunningDestructor): Deleted.
+(WebCore::HTMLMediaElementDestructorScope::HTMLMediaElementDestructorScope): Deleted.
+(WebCore::HTMLMediaElementDestructorScope::~HTMLMediaElementDestructorScope): Deleted.
+* html/HTMLMediaElement.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::checkCompleted):
+
 2019-10-29  Andy Estes  
 
 [Quick Look] Clean up LegacyPreviewLoaderClients


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (251767 => 251768)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2019-10-30 04:29:48 UTC (rev 251767)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2019-10-30 05:12:28 UTC (rev 251768)
@@ -554,23 +554,8 @@
 mediaSession().clientWillBeginAutoplaying();
 }
 
-// FIXME: Remove this code once https://webkit.org/b/185284 is fixed.
-static unsigned s_destructorCount = 0;
-
-bool HTMLMediaElement::isRunningDestructor()
-{
-return !!s_destructorCount;
-}
-
-class HTMLMediaElementDestructorScope {
-public:
-HTMLMediaElementDestructorScope() { ++s_destructorCount; }
-~HTMLMediaElementDestructorScope() { --s_destructorCount; }
-};
-
 HTMLMediaElement::~HTMLMediaElement()
 {
-HTMLMediaElementDestructorScope destructorScope;
 ALWAYS_LOG(LOGIDENTIFIER);
 
 beginIgnoringTrackDisplayUpdateRequests();


Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (251767 => 251768)

--- trunk/Source/WebCore/html/HTMLMediaElement.h	2019-10-30 04:29:48 UTC (rev 251767)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h	2019-10-30 05:12:28 UTC (rev 251768)
@@ -166,8 +166,6 @@
 
 WEBCORE_EXPORT static RefPtr bestMediaElementForShowingPlaybackControlsManager(MediaElementSession::PlaybackControlsPurpose);
 
-static bool isRunningDestructor();
-
 WEBCORE_EXPORT void rewind(double timeDelta);
 WEBCORE_EXPORT void returnToRealtime() override;
 


Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (251767 => 251768)

--- trunk/Source/WebCore/loader/FrameLoader.cpp	2019-10-30 04:29:48 UTC (rev 251767)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp	2019-10-30 05:12:28 UTC (rev 251768)
@@ -842,15 +842,6 @@
 // Have we completed before?
 if (m_isComplete)
 return;
-
-#if ENABLE(VIDEO)
-// FIXME: Remove this code once https://webkit.org/b/185284 is fixed.
-if (HTMLMediaElement::isRunningDestructor()) {
-ASSERT_NOT_REACHED();
-scheduleCheckCompleted();
-return;
-}
-#endif
 
 // FIXME: It would be better if resource loads were kicked off after render tree update (or didn't complete synchronously).
 //https://bugs.webkit.org/show_bug.cgi?id=171729






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251767] releases/Apple

[mitz]

Title: [251767] releases/Apple








Revision 251767
Author m...@apple.com
Date 2019-10-29 21:29:48 -0700 (Tue, 29 Oct 2019)


Log Message
Added a tag for iOS 13.2.

Added Paths

releases/Apple/iOS 13.2/
releases/Apple/iOS 13.2/ANGLE/
releases/Apple/iOS 13.2/_javascript_Core/
releases/Apple/iOS 13.2/WTF/
releases/Apple/iOS 13.2/WebCore/
releases/Apple/iOS 13.2/WebKit/
releases/Apple/iOS 13.2/WebKitLegacy/
releases/Apple/iOS 13.2/bmalloc/
releases/Apple/iOS 13.2/libwebrtc/




Diff
Index: releases/Apple/iOS 13.2/ANGLE
===
--- tags/Safari-608.3.10.0.3/Source/ThirdParty/ANGLE	2019-10-30 04:26:35 UTC (rev 251766)
+++ releases/Apple/iOS 13.2/ANGLE	2019-10-30 04:29:48 UTC (rev 251767)

Property changes: releases/Apple/iOS 13.2/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/iOS 13.2/_javascript_Core
===
--- tags/Safari-608.3.10.0.3/Source/_javascript_Core	2019-10-30 04:26:35 UTC (rev 251766)
+++ releases/Apple/iOS 13.2/_javascript_Core	2019-10-30 04:29:48 UTC (rev 251767)

Property changes: releases/Apple/iOS 13.2/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/iOS 13.2/WTF
===
--- tags/Safari-608.3.10.0.3/Source/WTF	2019-10-30 04:26:35 UTC (rev 251766)
+++ releases/Apple/iOS 13.2/WTF	2019-10-30 04:29:48 UTC (rev 251767)

Property changes: releases/Apple/iOS 13.2/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/iOS 13.2/bmalloc
===
--- tags/Safari-608.3.10.0.3/Source/bmalloc	2019-10-30 04:26:35 UTC (rev 251766)
+++ releases/Apple/iOS 13.2/bmalloc	2019-10-30 04:29:48 UTC (rev 251767)

Property changes: releases/Apple/iOS 13.2/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/iOS 13.2/libwebrtc
===
--- tags/Safari-608.3.10.0.3/Source/ThirdParty/libwebrtc	2019-10-30 04:26:35 UTC (rev 251766)
+++ releases/Apple/iOS 13.2/libwebrtc	2019-10-30 04:29:48 UTC (rev 251767)

Property changes: releases/Apple/iOS 13.2/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455,248143,248162
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251766] releases/Apple

[mitz]

Title: [251766] releases/Apple








Revision 251766
Author m...@apple.com
Date 2019-10-29 21:26:35 -0700 (Tue, 29 Oct 2019)


Log Message
Added a tag for Safari 13.0.3.

Added Paths

releases/Apple/Safari 13.0.3/
releases/Apple/Safari 13.0.3/ANGLE/
releases/Apple/Safari 13.0.3/_javascript_Core/
releases/Apple/Safari 13.0.3/WTF/
releases/Apple/Safari 13.0.3/WebCore/
releases/Apple/Safari 13.0.3/WebInspectorUI/
releases/Apple/Safari 13.0.3/WebKit/
releases/Apple/Safari 13.0.3/WebKitLegacy/
releases/Apple/Safari 13.0.3/bmalloc/
releases/Apple/Safari 13.0.3/libwebrtc/




Diff
Index: releases/Apple/Safari 13.0.3/ANGLE
===
--- tags/Safari-608.3.10.10.1/Source/ThirdParty/ANGLE	2019-10-30 04:14:39 UTC (rev 251765)
+++ releases/Apple/Safari 13.0.3/ANGLE	2019-10-30 04:26:35 UTC (rev 251766)

Property changes: releases/Apple/Safari 13.0.3/ANGLE



Added: allow-tabs
+true
\ No newline at end of property

Added: svn:mergeinfo
+/trunk/Source/ThirdParty/ANGLE:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.3/_javascript_Core
===
--- tags/Safari-608.3.10.10.1/Source/_javascript_Core	2019-10-30 04:14:39 UTC (rev 251765)
+++ releases/Apple/Safari 13.0.3/_javascript_Core	2019-10-30 04:26:35 UTC (rev 251766)

Property changes: releases/Apple/Safari 13.0.3/_javascript_Core



Added: svn:mergeinfo
+/trunk/Source/_javascript_Core:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.3/WTF
===
--- tags/Safari-608.3.10.10.1/Source/WTF	2019-10-30 04:14:39 UTC (rev 251765)
+++ releases/Apple/Safari 13.0.3/WTF	2019-10-30 04:26:35 UTC (rev 251766)

Property changes: releases/Apple/Safari 13.0.3/WTF



Added: svn:mergeinfo
+/trunk/Source/WTF:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.3/WebInspectorUI
===
--- tags/Safari-608.3.10.10.1/Source/WebInspectorUI	2019-10-30 04:14:39 UTC (rev 251765)
+++ releases/Apple/Safari 13.0.3/WebInspectorUI	2019-10-30 04:26:35 UTC (rev 251766)

Property changes: releases/Apple/Safari 13.0.3/WebInspectorUI



Added: svn:mergeinfo
+/trunk/Source/WebInspectorUI:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.3/bmalloc
===
--- tags/Safari-608.3.10.10.1/Source/bmalloc	2019-10-30 04:14:39 UTC (rev 251765)
+++ releases/Apple/Safari 13.0.3/bmalloc	2019-10-30 04:26:35 UTC (rev 251766)

Property changes: releases/Apple/Safari 13.0.3/bmalloc



Added: svn:mergeinfo
+/trunk/Source/bmalloc:53455,248143,248162
\ No newline at end of property
Index: releases/Apple/Safari 13.0.3/libwebrtc
===
--- tags/Safari-608.3.10.10.1/Source/ThirdParty/libwebrtc	2019-10-30 04:14:39 UTC (rev 251765)
+++ releases/Apple/Safari 13.0.3/libwebrtc	2019-10-30 04:26:35 UTC (rev 251766)

Property changes: releases/Apple/Safari 13.0.3/libwebrtc



Added: svn:mergeinfo
+/trunk/Source/ThirdParty/libwebrtc:53455,248143,248162
\ No newline at end of property




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251765] trunk

[aestes]

Title: [251765] trunk








Revision 251765
Author aes...@apple.com
Date 2019-10-29 21:14:39 -0700 (Tue, 29 Oct 2019)


Log Message
[Quick Look] Clean up LegacyPreviewLoaderClients
https://bugs.webkit.org/show_bug.cgi?id=203472

Reviewed by Brady Eidson.

Source/WebCore:

* loader/ios/LegacyPreviewLoader.mm:
(WebCore::LegacyPreviewLoader::didReceiveBuffer):
* platform/network/ios/LegacyPreviewLoaderClient.h:
(WebCore::LegacyPreviewLoaderClient::didReceiveBuffer):
(WebCore::LegacyPreviewLoaderClient::didReceiveDataArray): Deleted.

Source/WebKit:

Replaced QuickLookDocumentData with ShareableResource.

Removed messages WebPageProxy::DidRequestPasswordForQuickLookDocumentInMainFrame and
WebPage::DidReceivePasswordForQuickLookDocument, replacing them with async message
WebPageProxy::RequestPasswordForQuickLookDocumentInMainFrame.

* Shared/ios/QuickLookDocumentData.cpp: Removed.
* Shared/ios/QuickLookDocumentData.h: Removed.
* SourcesCocoa.txt:
* UIProcess/API/APILoaderClient.h:
* UIProcess/API/APINavigationClient.h:
(API::NavigationClient::didFinishLoadForQuickLookDocumentInMainFrame):
* UIProcess/Cocoa/NavigationState.h:
* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::didFinishLoadForQuickLookDocumentInMainFrame):
* UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::requestPasswordForQuickLookDocumentInMainFrame):
(WebKit::ProvisionalPageProxy::didReceiveMessage):
(WebKit::ProvisionalPageProxy::didRequestPasswordForQuickLookDocumentInMainFrame): Deleted.
* UIProcess/ProvisionalPageProxy.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didFinishLoadForQuickLookDocumentInMainFrame):
(WebKit::WebPageProxy::requestPasswordForQuickLookDocumentInMainFrame):
(WebKit::WebPageProxy::requestPasswordForQuickLookDocumentInMainFrameShared):
(WebKit::WebPageProxy::didRequestPasswordForQuickLookDocumentInMainFrame): Deleted.
(WebKit::WebPageProxy::didRequestPasswordForQuickLookDocumentInMainFrameShared): Deleted.
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp:
(WebKit::WebPreviewLoaderClient::WebPreviewLoaderClient):
(WebKit::WebPreviewLoaderClient::didReceiveBuffer):
(WebKit::WebPreviewLoaderClient::didFinishLoading):
(WebKit::WebPreviewLoaderClient::didFail):
(WebKit::WebPreviewLoaderClient::didRequestPassword):
(WebKit::passwordCallbacks): Deleted.
(WebKit::WebPreviewLoaderClient::~WebPreviewLoaderClient): Deleted.
(WebKit::WebPreviewLoaderClient::didReceiveDataArray): Deleted.
(WebKit::WebPreviewLoaderClient::didReceivePassword): Deleted.
* WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::didStartLoadForQuickLookDocumentInMainFrame):
(WebKit::WebPage::didFinishLoadForQuickLookDocumentInMainFrame):
(WebKit::WebPage::requestPasswordForQuickLookDocumentInMainFrame):
(WebKit::WebPage::didReceivePasswordForQuickLookDocument): Deleted.

Source/WebKitLegacy/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPreviewLoaderClient):

Tools:

Updated API tests to compare data received in
-_webView:didFinishLoadForQuickLookDocumentInMainFrame: with expected data.

* TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
(readFile):
(-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
(-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
(-[QuickLookDelegate verifyDownload]):
(TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ios/LegacyPreviewLoader.mm
trunk/Source/WebCore/platform/network/ios/LegacyPreviewLoaderClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/SharedMemory.h
trunk/Source/WebKit/Sources.txt
trunk/Source/WebKit/SourcesCocoa.txt
trunk/Source/WebKit/UIProcess/API/APILoaderClient.h
trunk/Source/WebKit/UIProcess/API/APINavigationClient.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.h
trunk/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in
trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebPreviewLoaderClient.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm


Added Paths

[webkit-changes] [251763] trunk/Tools

[jbedard]

Title: [251763] trunk/Tools








Revision 251763
Author jbed...@apple.com
Date 2019-10-29 20:14:44 -0700 (Tue, 29 Oct 2019)


Log Message
results.webkit.org: Fix tooltip with drawer
https://bugs.webkit.org/show_bug.cgi?id=203527

Rubber-stamped by Aakash Jain.

The interaction between tooltips and drawers needs improvement, tooltips
are inconsistently under the drawer, do not treat the drawer as a boundary.

* resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
(.tooltip): Use topZIndex variable.
* resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(xAxisFromScale): Pass viewport to ToolTip.
(TimelineFromEndpoint): Ditto.
(TimelineFromEndpoint.prototype.update): Ditto.
(TimelineFromEndpoint.prototype.render): Ditto.
(TimelineFromEndpoint.prototype.render.onDotEnterFactory): Ditto.
* resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
(_ToolTip.prototype.toString): Use passed viewport instead of the document size.
(_ToolTip.prototype.setByElement): Set the viewport based on the passed viewport.
* resultsdbpy/resultsdbpy/view/templates/search.html: Define the viewport as the
content element.
* resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/tooltip.css
trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js
trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/tooltip.js
trunk/Tools/resultsdbpy/resultsdbpy/view/templates/search.html
trunk/Tools/resultsdbpy/resultsdbpy/view/templates/suite_results.html




Diff

Modified: trunk/Tools/ChangeLog (251762 => 251763)

--- trunk/Tools/ChangeLog	2019-10-30 02:50:31 UTC (rev 251762)
+++ trunk/Tools/ChangeLog	2019-10-30 03:14:44 UTC (rev 251763)
@@ -1,3 +1,28 @@
+2019-10-29  Jonathan Bedard  
+
+results.webkit.org: Fix tooltip with drawer
+https://bugs.webkit.org/show_bug.cgi?id=203527
+
+Rubber-stamped by Aakash Jain.
+
+The interaction between tooltips and drawers needs improvement, tooltips
+are inconsistently under the drawer, do not treat the drawer as a boundary.
+
+* resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
+(.tooltip): Use topZIndex variable.
+* resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+(xAxisFromScale): Pass viewport to ToolTip.
+(TimelineFromEndpoint): Ditto.
+(TimelineFromEndpoint.prototype.update): Ditto.
+(TimelineFromEndpoint.prototype.render): Ditto.
+(TimelineFromEndpoint.prototype.render.onDotEnterFactory): Ditto.
+* resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
+(_ToolTip.prototype.toString): Use passed viewport instead of the document size.
+(_ToolTip.prototype.setByElement): Set the viewport based on the passed viewport.
+* resultsdbpy/resultsdbpy/view/templates/search.html: Define the viewport as the
+content element.
+* resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
+
 2019-10-29  Jiewen Tan  
 
 [WebAuthn] Add more information to _WKWebAuthenticationPanel


Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/tooltip.css (251762 => 251763)

--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/tooltip.css	2019-10-30 02:50:31 UTC (rev 251762)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/css/tooltip.css	2019-10-30 03:14:44 UTC (rev 251763)
@@ -24,7 +24,7 @@
  */
  
 .tooltip {
-z-index: 50;
+z-index: var(--topZIndex);
 position: absolute;
 opacity: 80%;
 width: 0;


Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js (251762 => 251763)

--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js	2019-10-30 02:50:31 UTC (rev 251762)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js	2019-10-30 03:14:44 UTC (rev 251763)
@@ -155,7 +155,7 @@
 return repositories;
 }
 
-function xAxisFromScale(scale, repository, updatesArray, isTop=false)
+function xAxisFromScale(scale, repository, updatesArray, isTop=false, viewport=null)
 {
 function scaleForRepository(scale) {
 return scale.map(node => {
@@ -197,6 +197,7 @@
 return {x: canvas.x + point.x, y: canvas.y + scrollDelta + point.y};
 }),
 (event) => {return onScaleClick(node);},
+viewport,
 );
 },
 onScaleLeave: (event, canvas) => {
@@ -342,7 +343,7 @@
 }
 
 class TimelineFromEndpoint {
-constructor(endpoint, suite = null) {
+constructor(endpoint, suite = null, viewport = null) {
 this.endpoint = endpoint;
 this.displayAllCommits = true;
 
@@ -355,6 +356,7 @@
 this.timelineUpdate = null;
 this.notifyRerender = () => {};
 this.repositories = [];
+this.viewport = viewport;
 
 const self = this;
 
@@ -398,7 +400,7 @@
 let components = [];
 
 newRepositories.forEach(repository => {
-

[webkit-changes] [251764] trunk

[commit-queue]

Title: [251764] trunk








Revision 251764
Author commit-qu...@webkit.org
Date 2019-10-29 20:14:51 -0700 (Tue, 29 Oct 2019)


Log Message
[SVG2] SVGSymbolElement should inherits SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=203573

Patch by Said Abou-Hallawa  on 2019-10-29
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

* web-platform-tests/svg/idlharness.window-expected.txt:

Source/WebCore:

The spec link is:
https://www.w3.org/TR/SVG2/struct.html#InterfaceSVGSymbolElement

* svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::SVGSymbolElement):
(WebCore::SVGSymbolElement::parseAttribute):
* svg/SVGSymbolElement.h:
* svg/SVGSymbolElement.idl:

LayoutTests:

* svg/dom/svg2-inheritance-expected.txt:
* svg/dom/svg2-inheritance.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt
trunk/LayoutTests/svg/dom/svg2-inheritance-expected.txt
trunk/LayoutTests/svg/dom/svg2-inheritance.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGSymbolElement.cpp
trunk/Source/WebCore/svg/SVGSymbolElement.h
trunk/Source/WebCore/svg/SVGSymbolElement.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (251763 => 251764)

--- trunk/LayoutTests/ChangeLog	2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/LayoutTests/ChangeLog	2019-10-30 03:14:51 UTC (rev 251764)
@@ -1,3 +1,13 @@
+2019-10-29  Said Abou-Hallawa  
+
+[SVG2] SVGSymbolElement should inherits SVGGraphicsElement
+https://bugs.webkit.org/show_bug.cgi?id=203573
+
+Reviewed by Simon Fraser.
+
+* svg/dom/svg2-inheritance-expected.txt:
+* svg/dom/svg2-inheritance.html:
+
 2019-10-29  Wenson Hsieh  
 
 REGRESSION (r251693): [iOS] Unable to change selection after focusing an element with keyboard attached


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (251763 => 251764)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2019-10-30 03:14:51 UTC (rev 251764)
@@ -1,3 +1,12 @@
+2019-10-29  Said Abou-Hallawa  
+
+[SVG2] SVGSymbolElement should inherits SVGGraphicsElement
+https://bugs.webkit.org/show_bug.cgi?id=203573
+
+Reviewed by Simon Fraser.
+
+* web-platform-tests/svg/idlharness.window-expected.txt:
+
 2019-10-29  Simon Fraser  
 
 Align CSS hsl() -> rgb() color conversion with the spec


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt (251763 => 251764)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt	2019-10-30 03:14:44 UTC (rev 251763)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt	2019-10-30 03:14:51 UTC (rev 251764)
@@ -511,14 +511,10 @@
 PASS SVGElement interface: objects.title must inherit property "viewportElement" with the proper type 
 FAIL SVGElement interface: objects.title must inherit property "correspondingElement" with the proper type assert_inherits: property "correspondingElement" not found in prototype chain
 FAIL SVGElement interface: objects.title must inherit property "correspondingUseElement" with the proper type assert_inherits: property "correspondingUseElement" not found in prototype chain
-FAIL SVGSymbolElement interface: existence and properties of interface object assert_equals: prototype of SVGSymbolElement is not SVGGraphicsElement expected function "function SVGGraphicsElement() {
-[native code]
-}" but got function "function SVGElement() {
-[native code]
-}"
+PASS SVGSymbolElement interface: existence and properties of interface object 
 PASS SVGSymbolElement interface object length 
 PASS SVGSymbolElement interface object name 
-FAIL SVGSymbolElement interface: existence and properties of interface prototype object assert_equals: prototype of SVGSymbolElement.prototype is not SVGGraphicsElement.prototype expected object "[object SVGGraphicsElementPrototype]" but got object "[object SVGElementPrototype]"
+PASS SVGSymbolElement interface: existence and properties of interface prototype object 
 PASS SVGSymbolElement interface: existence and properties of interface prototype object's "constructor" property 
 PASS SVGSymbolElement interface: existence and properties of interface prototype object's @@unscopables property 
 PASS SVGSymbolElement interface: attribute viewBox 
@@ -527,13 +523,13 @@
 PASS Stringification of objects.symbol 
 PASS SVGSymbolElement interface: objects.symbol must inherit property "viewBox" with the proper type 
 PASS SVGSymbolElement interface: objects.symbol must inherit property "preserveAspectRatio" with the proper type 
-FAIL SVGGraphicsElement interface: objects.symbol must inherit property "transform" with the proper type assert_inherits: property "transform" not found in prototype chain
-FAIL SVGGraphicsElement interface: objects.symbol must inherit 

[webkit-changes] [251762] trunk

[jiewen_tan]

Title: [251762] trunk








Revision 251762
Author jiewen_...@apple.com
Date 2019-10-29 19:50:31 -0700 (Tue, 29 Oct 2019)


Log Message
[WebAuthn] Add more information to _WKWebAuthenticationPanel
https://bugs.webkit.org/show_bug.cgi?id=202561


Reviewed by Youenn Fablet and Brent Fulgham.

Source/WebCore:

Covered by new tests within existing test files.

* Modules/webauthn/AuthenticatorCoordinator.cpp:
* Modules/webauthn/WebAuthenticationConstants.h:

Source/WebKit:

This change adds transports and type to _WKWebAuthenticationPanel such that
clients can know what transport the current ceremony demands and the type of
the current ceremony. These extra information allow clients to give users
more specific instructions to interact with authenticators.

To pass transports to client, the way how them is collected is changed significantly:
1) The timing is moved to runPanel before the client delegate call.
2) NfcService::isAvailable is added for AuthenticatorManager to determine if NFC
is available in the current device.
3) AuthenticatorManager::filterTransports is added to filter transports requested
by RP to ones that are available. This process is handled by each service naturally
before.
4) AuthenticatorManager::startRequest is now being splitted into AuthenticatorManager::handleRequest,
AuthenticatorManager::runPanel and AuthenticatorManager::getTransports.

To pass type to _WKWebAuthenticationPanel, ClientDataType is moved from
WebCore::AuthenticatorCoordinator to WebCore::WebAuthenticationConstants in
order to be reused to indicate the ceremony type.

* UIProcess/API/APIWebAuthenticationPanel.cpp:
(API::WebAuthenticationPanel::create):
(API::WebAuthenticationPanel::WebAuthenticationPanel):
* UIProcess/API/APIWebAuthenticationPanel.h:
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(-[_WKWebAuthenticationPanel relyingPartyID]):
(wkWebAuthenticationTransport):
(-[_WKWebAuthenticationPanel transports]):
(wkWebAuthenticationType):
(-[_WKWebAuthenticationPanel type]):
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::WebCore::collectTransports):
(WebKit::WebCore::getClientDataType):
(WebKit::AuthenticatorManager::handleRequest):
(WebKit::AuthenticatorManager::filterTransports const):
(WebKit::AuthenticatorManager::startDiscovery):
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::runPanel):
(WebKit::AuthenticatorManager::getTransports const):
(WebKit::AuthenticatorManager::respondReceivedInternal): Deleted.
(WebKit::AuthenticatorManager::startRequest): Deleted.
* UIProcess/WebAuthentication/AuthenticatorManager.h:
(WebKit::AuthenticatorManager::respondReceivedInternal):
* UIProcess/WebAuthentication/Cocoa/NfcService.h:
* UIProcess/WebAuthentication/Cocoa/NfcService.mm:
(WebKit::NfcService::isAvailable):
(WebKit::NfcService::platformStartDiscovery):
* UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:
(WebKit::MockAuthenticatorManager::filterTransports const):
* UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.h:

Tools:

Adds new API tests.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
(-[TestWebAuthenticationPanelUIDelegate panel]):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid.html: Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
trunk/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp
trunk/Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.h
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.mm
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp
trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm


Added Paths

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (251761 => 251762)

--- trunk/Source/WebCore/ChangeLog	2019-10-30 02:48:45 UTC (rev 251761)
+++ trunk/Source/WebCore/ChangeLog	2019-10-30 02:50:31 UTC (rev 251762)
@@ -1,3 +1,16 @@
+2019-10-29  Jiewen Tan  
+
+[WebAuthn] Add more information to 

[webkit-changes] [251761] trunk

[wenson_hsieh]

Title: [251761] trunk








Revision 251761
Author wenson_hs...@apple.com
Date 2019-10-29 19:48:45 -0700 (Tue, 29 Oct 2019)


Log Message
Source/WebCore:
REGRESSION (r251693): [iOS] Unable to change selection after focusing an element with keyboard attached
https://bugs.webkit.org/show_bug.cgi?id=203582

Reviewed by Tim Horton.

Introduces a new helper method to check whether two ElementContexts refer to the same element. Importantly, this
ignores any information on ElementContext that is not either the element, document, or page identifier (for now,
this only includes the element's bounding rect, which may change over time).

Test: editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html

* dom/ElementContext.h:
(WebCore::ElementContext::isSameElement const):
(WebCore::operator==):

Source/WebKit:
REGRESSION (r251693): [iOS] Unable to change selection in a focused element if the element's bounds change
https://bugs.webkit.org/show_bug.cgi?id=203582

Reviewed by Tim Horton.

The refactoring in r251693 broke the ability to change selection in an editable area by tapping in iOS Safari,
in the case where the editable element's bounds change after focus. This is because the aforementioned change
now compares position informations' element context against the focused element information's element context to
check whether or not the position information request was inside the focused element. However, if the bounds of
the focused element change in between the position information request and when the element is initially
focused, the `operator==` comparison will fail, causing us to prevent text selection.

To fix this, only check whether or not the two element contexts refer to the same element in the DOM by
comparing page, document and element identifiers, but not the element's bounding rect.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:nodeHasBuiltInClickHandling:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

LayoutTests:
REGRESSION (r251693): [iOS] Unable to change selection after focusing an element with keyboard attached
https://bugs.webkit.org/show_bug.cgi?id=203582

Reviewed by Tim Horton.

Add a new layout test to cover this scenario.

* editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds-expected.txt: Added.
* editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ElementContext.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm


Added Paths

trunk/LayoutTests/editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds-expected.txt
trunk/LayoutTests/editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html




Diff

Modified: trunk/LayoutTests/ChangeLog (251760 => 251761)

--- trunk/LayoutTests/ChangeLog	2019-10-30 02:29:19 UTC (rev 251760)
+++ trunk/LayoutTests/ChangeLog	2019-10-30 02:48:45 UTC (rev 251761)
@@ -1,3 +1,15 @@
+2019-10-29  Wenson Hsieh  
+
+REGRESSION (r251693): [iOS] Unable to change selection after focusing an element with keyboard attached
+https://bugs.webkit.org/show_bug.cgi?id=203582
+
+Reviewed by Tim Horton.
+
+Add a new layout test to cover this scenario.
+
+* editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds-expected.txt: Added.
+* editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds.html: Added.
+
 2019-10-29  Chris Dumez  
 
 UserMediaRequest should not prevent entering the back/forward cache


Added: trunk/LayoutTests/editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds-expected.txt (0 => 251761)

--- trunk/LayoutTests/editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/ios/set-selection-by-tapping-after-changing-focused-element-bounds-expected.txt	2019-10-30 02:48:45 UTC (rev 251761)
@@ -0,0 +1,11 @@
+Verifies that tapping to change selection works when the focused element's bounds change after focusing the element. To manually run the test, first tap the editable area to focus it, then tap the button to shrink the editable area, and finally, verify that it's possible to change selection in the editable area by tapping it.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS getSelection().rangeCount is 1
+PASS Successfully changed selection after shrinking editable area.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: 

[webkit-changes] [251760] trunk/Source

[alancoon]

Title: [251760] trunk/Source








Revision 251760
Author alanc...@apple.com
Date 2019-10-29 19:29:19 -0700 (Tue, 29 Oct 2019)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (251759 => 251760)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-30 02:25:53 UTC (rev 251759)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-30 02:29:19 UTC (rev 251760)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (251759 => 251760)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-30 02:25:53 UTC (rev 251759)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-30 02:29:19 UTC (rev 251760)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (251759 => 251760)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2019-10-30 02:25:53 UTC (rev 251759)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2019-10-30 02:29:19 UTC (rev 251760)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (251759 => 251760)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-30 02:25:53 UTC (rev 251759)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-30 02:29:19 UTC (rev 251760)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (251759 => 251760)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-30 02:25:53 UTC (rev 251759)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-30 02:29:19 UTC (rev 251760)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (251759 => 251760)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2019-10-30 02:25:53 UTC (rev 251759)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2019-10-30 02:29:19 UTC (rev 251760)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (251759 => 251760)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-10-30 02:25:53 UTC (rev 251759)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-10-30 02:29:19 UTC (rev 251760)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 9;
+TINY_VERSION = 10;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251759] tags/Safari-609.1.9/

[alancoon]

Title: [251759] tags/Safari-609.1.9/








Revision 251759
Author alanc...@apple.com
Date 2019-10-29 19:25:53 -0700 (Tue, 29 Oct 2019)


Log Message
Tag Safari-609.1.9.

Added Paths

tags/Safari-609.1.9/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251758] branches/safari-608-branch/Source/WebKit/UIProcess/ WebAuthentication/Cocoa/NfcService.mm

[alancoon]

Title: [251758] branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.mm








Revision 251758
Author alanc...@apple.com
Date 2019-10-29 18:30:34 -0700 (Tue, 29 Oct 2019)


Log Message
Unreviewed build fix. rdar://problem/56579657

Modified Paths

branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.mm




Diff

Modified: branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.mm (251757 => 251758)

--- branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.mm	2019-10-30 01:26:03 UTC (rev 251757)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/NfcService.mm	2019-10-30 01:30:34 UTC (rev 251758)
@@ -54,7 +54,7 @@
 #if HAVE(NEAR_FIELD)
 auto connection = m_connection;
 ASSERT(connection);
-getInfo(WTF::makeUnique(connection.releaseNonNull()));
+getInfo(std::make_unique(connection.releaseNonNull()));
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251755] branches/safari-608-branch

[alancoon]

Title: [251755] branches/safari-608-branch








Revision 251755
Author alanc...@apple.com
Date 2019-10-29 18:25:48 -0700 (Tue, 29 Oct 2019)


Log Message
Cherry-pick r251489. rdar://problem/56579665

[WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=202563


Reviewed by Brent Fulgham.

Source/WebCore:

Covered by new test contents within existing tests.

* Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource const):
* Modules/webauthn/AuthenticatorCoordinatorClient.h:

Source/WebKit:

This patch makes WKFrameInfo available to clients via the above SPI. To do so,
SecuirtyOrigin of the caller document is passed from WebContent Process.

* UIProcess/API/APIUIClient.h:
(API::UIClient::runWebAuthenticationPanel):
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::runWebAuthenticationPanel):
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::runPanel):
* UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
* UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
(WebKit::WebAuthenticatorCoordinatorProxy::makeCredential):
(WebKit::WebAuthenticatorCoordinatorProxy::getAssertion):
(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest):
* UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h:
* UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in:
* WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):
* WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h:

Tools:

Adds new test contents into existing tests.

* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelUIDelegate init]):
(-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
(-[TestWebAuthenticationPanelUIDelegate frame]):
(TestWebKitAPI::TEST):

LayoutTests:

* http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
Imporves the flakiness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html
branches/safari-608-branch/Source/WebCore/ChangeLog
branches/safari-608-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
branches/safari-608-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinatorClient.h
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/UIProcess/API/APIUIClient.h
branches/safari-608-branch/Source/WebKit/UIProcess/API/C/WKPage.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/UIDelegate.h
branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationRequestData.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.messages.in
branches/safari-608-branch/Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp
branches/safari-608-branch/Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.h
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: branches/safari-608-branch/LayoutTests/ChangeLog (251754 => 251755)

--- branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-30 01:25:40 UTC (rev 251754)
+++ branches/safari-608-branch/LayoutTests/ChangeLog	2019-10-30 01:25:48 UTC (rev 251755)
@@ -1,5 +1,78 @@
 2019-10-29  Alan Coon  
 
+Cherry-pick r251489. rdar://problem/56579665
+
+[WebAuthn] Supply FrameInfo in -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
+https://bugs.webkit.org/show_bug.cgi?id=202563
+
+
+Reviewed by Brent Fulgham.
+
+Source/WebCore:
+
+Covered by new test contents within existing tests.
+
+* Modules/webauthn/AuthenticatorCoordinator.cpp:
+

[webkit-changes] [251757] branches/safari-608-branch

[alancoon]

Title: [251757] branches/safari-608-branch








Revision 251757
Author alanc...@apple.com
Date 2019-10-29 18:26:03 -0700 (Tue, 29 Oct 2019)


Log Message
Cherry-pick r251317. rdar://problem/56598357

[WebAuthn] Warn users when no credentials are found
https://bugs.webkit.org/show_bug.cgi?id=203147


Reviewed by Brent Fulgham.

Source/WebKit:

This patch returns _WKWebAuthenticationPanelUpdateNoCredentialsFound to client via
-[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:] when either
CtapAuthenticator receives kCtap2ErrNoCredentials or U2fAuthenticator exhausts the
allow list.

This patch also enhances CtapAuthenticator::tryDowngrade to check if the CTAP command
can be converted to U2F commands to ensure kCtap2ErrNoCredentials is returned if it
is the case. Otherwise, after downgrading, U2fAuthenticator will return NotSupportedError
given it can't convert the commands.

* UIProcess/API/APIUIClient.h:
* UIProcess/API/APIWebAuthenticationPanelClient.h:
(API::WebAuthenticationPanelClient::updatePanel const):
* UIProcess/WebAuthentication/Authenticator.h:
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::authenticatorStatusUpdated):
* UIProcess/WebAuthentication/AuthenticatorManager.h:
* UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.h:
* UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:
(WebKit::WebAuthenticationPanelClient::WebAuthenticationPanelClient):
(WebKit::wkWebAuthenticationPanelUpdate):
(WebKit::WebAuthenticationPanelClient::updatePanel const):
* UIProcess/WebAuthentication/WebAuthenticationFlags.h: Renamed from Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationPanelFlags.h.
* UIProcess/WebAuthentication/WebAuthenticationRequestData.h:
* UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp:
* UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived):
(WebKit::CtapAuthenticator::tryDowngrade):
* UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:
(WebKit::U2fAuthenticator::issueSignCommand):
* WebKit.xcodeproj/project.pbxproj:

Tools:

Adds new tests for _WKWebAuthenticationPanelUpdateNoCredentialsFound.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-cancel.html:
* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-no-credentials.html: Added.
* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html:
* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html:
* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-u2f-no-credentials.html: Added.

LayoutTests:

Adds new tests for CtapAuthenticator::tryDowngrade enhancement.

* http/wpt/webauthn/public-key-credential-get-failure-hid.https-expected.txt:
* http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/LayoutTests/ChangeLog
branches/safari-608-branch/LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-hid.https-expected.txt
branches/safari-608-branch/LayoutTests/http/wpt/webauthn/public-key-credential-get-failure-hid.https.html
branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/UIProcess/API/APIUIClient.h
branches/safari-608-branch/Source/WebKit/UIProcess/API/APIWebAuthenticationPanelClient.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/Authenticator.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticationRequestData.h
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp
branches/safari-608-branch/Source/WebKit/UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp
branches/safari-608-branch/Source/WebKit/WebKit.xcodeproj/project.pbxproj
branches/safari-608-branch/Tools/ChangeLog

[webkit-changes] [251756] branches/safari-608-branch

[alancoon]

Title: [251756] branches/safari-608-branch








Revision 251756
Author alanc...@apple.com
Date 2019-10-29 18:25:55 -0700 (Tue, 29 Oct 2019)


Log Message
Cherry-pick r251500. rdar://problem/56579657

[WebAuthn] Warn users when multiple NFC tags present
https://bugs.webkit.org/show_bug.cgi?id=200932


Reviewed by Brent Fulgham.

Source/WebCore:

Covered by new tests in existing test file.

* testing/MockWebAuthenticationConfiguration.h:
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::encode const):
(WebCore::MockWebAuthenticationConfiguration::NfcConfiguration::decode):
* testing/MockWebAuthenticationConfiguration.idl:
Adds a new test option.

Source/WebKit:

This patch utilizes -[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:] to
inform clients about multiple physical tags are presenting such that clients can instruct users
to select only one of them physically. Given a physical tag could have multiple different
interfaces, which NearField will treat them into different NFTags, the tagID is then used to
identify if there are actually multiple physical tags.

This patch also adds the ability to restart polling of a partiuclar NFReaderSession to NfcConnection
and the ability to restart the whole session to NfcService. The former is used to recover from errors
in the discovery stages, and the latter is used to recover from errors returned from authenticators
in the request stages. For the latter, given NfcConnection is not awared of the syntax of FIDO2/U2F
protocol, and CtapAuthenticator/U2fAuthenticator are not awared the transport of the underneath driver.
A generic restartDiscovery process is added to each service and it is up to the actual service to
implement the actual process such that AuthenticatorManager can arbitrarily call it after exceptions
are returned to restart the whole NFC session. To achieve restartDiscovery, NfcConnection is made
RefCounted as well such that both the NfcService and the CtapNfcDriver could hold it at the same time.
CtapNfcDriver uses the connection to complete requests as before while NfcService has the new capability
to use it to stop the current session when restartDiscovery kicks off.

* Platform/spi/Cocoa/NearFieldSPI.h:
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::serviceStatusUpdated):
(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::restartDiscovery):
* UIProcess/WebAuthentication/AuthenticatorManager.h:
* UIProcess/WebAuthentication/AuthenticatorTransportService.cpp:
(WebKit::AuthenticatorTransportService::startDiscovery):
(WebKit::AuthenticatorTransportService::restartDiscovery):
* UIProcess/WebAuthentication/AuthenticatorTransportService.h:
(WebKit::AuthenticatorTransportService::restartDiscoveryInternal):
* UIProcess/WebAuthentication/Cocoa/NfcConnection.h:
* UIProcess/WebAuthentication/Cocoa/NfcConnection.mm:
(WebKit::NfcConnection::create):
(WebKit::NfcConnection::NfcConnection):
(WebKit::NfcConnection::~NfcConnection):
(WebKit::NfcConnection::stop const):
(WebKit::NfcConnection::didDetectTags):
(WebKit::NfcConnection::restartPolling):
(WebKit::NfcConnection::startPolling):
(WebKit::NfcConnection::didDetectTags const): Deleted.
* UIProcess/WebAuthentication/Cocoa/NfcService.h:
* UIProcess/WebAuthentication/Cocoa/NfcService.mm:
(WebKit::NfcService::NfcService):
(WebKit::NfcService::didConnectTag):
(WebKit::NfcService::didDetectMultipleTags const):
(WebKit::NfcService::setConnection):
(WebKit::NfcService::restartDiscoveryInternal):
(WebKit::NfcService::platformStartDiscovery):
(WebKit::NfcService::setDriver): Deleted.
* UIProcess/WebAuthentication/Mock/MockNfcService.h:
* UIProcess/WebAuthentication/Mock/MockNfcService.mm:
(-[WKMockNFTag tagID]):
(-[WKMockNFTag initWithNFTag:]):
(-[WKMockNFTag dealloc]):
(-[WKMockNFTag initWithType:]):
(-[WKMockNFTag initWithType:tagID:]):
(WebKit::MockNfcService::receiveStopPolling):
(WebKit::MockNfcService::receiveStartPolling):
(WebKit::MockNfcService::platformStartDiscovery):
(WebKit::MockNfcService::detectTags):
(WebKit::MockNfcService::detectTags const): Deleted.
* UIProcess/WebAuthentication/fido/CtapNfcDriver.cpp:
(WebKit::CtapNfcDriver::CtapNfcDriver):
* UIProcess/WebAuthentication/fido/CtapNfcDriver.h:
* UIProcess/WebAuthentication/fido/U2fAuthenticator.cpp:

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
(TestWebKitAPI::TEST):
Adds a new test for -[_WKWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:].
* 

[webkit-changes] [251752] branches/safari-608-branch/Tools

[alancoon]

Title: [251752] branches/safari-608-branch/Tools








Revision 251752
Author alanc...@apple.com
Date 2019-10-29 18:25:23 -0700 (Tue, 29 Oct 2019)


Log Message
Cherry-pick r251148. rdar://problem/56598349

[WebAuthn] Write more tests for _WKWebAuthenticationPanel
https://bugs.webkit.org/show_bug.cgi?id=202565


Reviewed by Brent Fulgham.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:]):
(-[TestWebAuthenticationPanelUIDelegate init]):
(-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html: Added.
* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm


Added Paths

branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html




Diff

Modified: branches/safari-608-branch/Tools/ChangeLog (251751 => 251752)

--- branches/safari-608-branch/Tools/ChangeLog	2019-10-30 01:25:17 UTC (rev 251751)
+++ branches/safari-608-branch/Tools/ChangeLog	2019-10-30 01:25:23 UTC (rev 251752)
@@ -1,5 +1,44 @@
 2019-10-29  Alan Coon  
 
+Cherry-pick r251148. rdar://problem/56598349
+
+[WebAuthn] Write more tests for _WKWebAuthenticationPanel
+https://bugs.webkit.org/show_bug.cgi?id=202565
+
+
+Reviewed by Brent Fulgham.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
+(-[TestWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:]):
+(-[TestWebAuthenticationPanelUIDelegate init]):
+(-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html: Added.
+* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-15  Jiewen Tan  
+
+[WebAuthn] Write more tests for _WKWebAuthenticationPanel
+https://bugs.webkit.org/show_bug.cgi?id=202565
+
+
+Reviewed by Brent Fulgham.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
+(-[TestWebAuthenticationPanelDelegate panel:dismissWebAuthenticationPanelWithResult:]):
+(-[TestWebAuthenticationPanelUIDelegate init]):
+(-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
+(TestWebKitAPI::TEST):
+* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid.html: Added.
+* TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-nfc.html: Added.
+
+2019-10-29  Alan Coon  
+
 Cherry-pick r250940. rdar://problem/56598350
 
 [WebAuthn] Move the mock testing entrance to Internals


Modified: branches/safari-608-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (251751 => 251752)

--- branches/safari-608-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2019-10-30 01:25:17 UTC (rev 251751)
+++ branches/safari-608-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj	2019-10-30 01:25:23 UTC (rev 251752)
@@ -319,6 +319,8 @@
 		57599E281F071AA000A3FB8C /* IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm in Copy Resources */ = {isa = PBXBuildFile; fileRef = 57599E261F07192C00A3FB8C /* IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm */; };
 		57599E2A1F071AA000A3FB8C /* IndexedDBStructuredCloneBackwardCompatibilityRead.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 57599E251F07192C00A3FB8C /* IndexedDBStructuredCloneBackwardCompatibilityRead.html */; };
 		57599E2B1F071AA000A3FB8C /* IndexedDBStructuredCloneBackwardCompatibilityWrite.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 57599E231F07192C00A3FB8C /* IndexedDBStructuredCloneBackwardCompatibilityWrite.html */; };
+		57663DEA234EA66D00E85E09 /* web-authentication-get-assertion-nfc.html in Copy Resources */ = {isa = 

[webkit-changes] [251753] branches/safari-608-branch

[alancoon]

Title: [251753] branches/safari-608-branch








Revision 251753
Author alanc...@apple.com
Date 2019-10-29 18:25:26 -0700 (Tue, 29 Oct 2019)


Log Message
Cherry-pick r251154. rdar://problem/56715899

[WebAuthn] Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
https://bugs.webkit.org/show_bug.cgi?id=202564


Reviewed by Brent Fulgham.

Source/WebKit:

Rename the SPI to a proper SPI style.

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::runWebAuthenticationPanel):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
(-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-608-branch/Source/WebKit/ChangeLog
branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
branches/safari-608-branch/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
branches/safari-608-branch/Tools/ChangeLog
branches/safari-608-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm




Diff

Modified: branches/safari-608-branch/Source/WebKit/ChangeLog (251752 => 251753)

--- branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-30 01:25:23 UTC (rev 251752)
+++ branches/safari-608-branch/Source/WebKit/ChangeLog	2019-10-30 01:25:26 UTC (rev 251753)
@@ -1,5 +1,48 @@
 2019-10-29  Alan Coon  
 
+Cherry-pick r251154. rdar://problem/56715899
+
+[WebAuthn] Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
+https://bugs.webkit.org/show_bug.cgi?id=202564
+
+
+Reviewed by Brent Fulgham.
+
+Source/WebKit:
+
+Rename the SPI to a proper SPI style.
+
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::setDelegate):
+(WebKit::UIDelegate::UIClient::runWebAuthenticationPanel):
+
+Tools:
+
+* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
+(-[TestWebAuthenticationPanelUIDelegate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]):
+(-[TestWebAuthenticationPanelUIDelegate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]): Deleted.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2019-10-15  Jiewen Tan  
+
+[WebAuthn] Rename -[WKUIDelegatePrivate webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:] to -[WKUIDelegatePrivate _webView:runWebAuthenticationPanel:initiatedByFrame:completionHandler:]
+https://bugs.webkit.org/show_bug.cgi?id=202564
+
+
+Reviewed by Brent Fulgham.
+
+Rename the SPI to a proper SPI style.
+
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::setDelegate):
+(WebKit::UIDelegate::UIClient::runWebAuthenticationPanel):
+
+2019-10-29  Alan Coon  
+
 Cherry-pick r250940. rdar://problem/56598350
 
 [WebAuthn] Move the mock testing entrance to Internals


Modified: branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (251752 => 251753)

--- branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2019-10-30 01:25:23 UTC (rev 251752)
+++ branches/safari-608-branch/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2019-10-30 01:25:26 UTC (rev 251753)
@@ -137,7 +137,7 @@
 
 - (void)_webView:(WKWebView *)webView takeFocus:(_WKFocusDirection)direction WK_API_AVAILABLE(macos(10.13.4), ios(12.2));
 
-- (void)webView:(WKWebView *)webView runWebAuthenticationPanel:(_WKWebAuthenticationPanel *)panel initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(_WKWebAuthenticationPanelResult))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+- (void)_webView:(WKWebView *)webView runWebAuthenticationPanel:(_WKWebAuthenticationPanel *)panel initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)(_WKWebAuthenticationPanelResult))completionHandler WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
 
 #if TARGET_OS_IPHONE
 - (BOOL)_webView:(WKWebView *)webView shouldIncludeAppLinkActionsForElement:(_WKActivatedElementInfo *)element WK_API_AVAILABLE(ios(9.0));


Modified: 

[webkit-changes] [251749] branches/safari-608-branch/Source

[alancoon]

Title: [251749] branches/safari-608-branch/Source








Revision 251749
Author alanc...@apple.com
Date 2019-10-29 17:43:42 -0700 (Tue, 29 Oct 2019)


Log Message
Versioning.

Modified Paths

branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig (251748 => 251749)

--- branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-30 00:32:55 UTC (rev 251748)
+++ branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-30 00:43:42 UTC (rev 251749)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (251748 => 251749)

--- branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-30 00:32:55 UTC (rev 251748)
+++ branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-30 00:43:42 UTC (rev 251749)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig (251748 => 251749)

--- branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-30 00:32:55 UTC (rev 251748)
+++ branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-30 00:43:42 UTC (rev 251749)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (251748 => 251749)

--- branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-30 00:32:55 UTC (rev 251748)
+++ branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-30 00:43:42 UTC (rev 251749)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (251748 => 251749)

--- branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-30 00:32:55 UTC (rev 251748)
+++ branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-30 00:43:42 UTC (rev 251749)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig (251748 => 251749)

--- branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2019-10-30 00:32:55 UTC (rev 251748)
+++ branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2019-10-30 00:43:42 UTC (rev 251749)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (251748 => 251749)

--- branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-10-30 00:32:55 UTC (rev 251748)
+++ branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-10-30 00:43:42 UTC (rev 251749)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251748] tags/Safari-608.4.4/

[alancoon]

Title: [251748] tags/Safari-608.4.4/








Revision 251748
Author alanc...@apple.com
Date 2019-10-29 17:32:55 -0700 (Tue, 29 Oct 2019)


Log Message
Tag Safari-608.4.4.

Added Paths

tags/Safari-608.4.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251747] branches/safari-608-branch/Source

[alancoon]

Title: [251747] branches/safari-608-branch/Source








Revision 251747
Author alanc...@apple.com
Date 2019-10-29 17:29:01 -0700 (Tue, 29 Oct 2019)


Log Message
Versioning.

Modified Paths

branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig (251746 => 251747)

--- branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-30 00:28:20 UTC (rev 251746)
+++ branches/safari-608-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2019-10-30 00:29:01 UTC (rev 251747)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (251746 => 251747)

--- branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-30 00:28:20 UTC (rev 251746)
+++ branches/safari-608-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2019-10-30 00:29:01 UTC (rev 251747)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig (251746 => 251747)

--- branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-30 00:28:20 UTC (rev 251746)
+++ branches/safari-608-branch/Source/WebCore/Configurations/Version.xcconfig	2019-10-30 00:29:01 UTC (rev 251747)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (251746 => 251747)

--- branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-30 00:28:20 UTC (rev 251746)
+++ branches/safari-608-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2019-10-30 00:29:01 UTC (rev 251747)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (251746 => 251747)

--- branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-30 00:28:20 UTC (rev 251746)
+++ branches/safari-608-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2019-10-30 00:29:01 UTC (rev 251747)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig (251746 => 251747)

--- branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2019-10-30 00:28:20 UTC (rev 251746)
+++ branches/safari-608-branch/Source/WebKit/Configurations/Version.xcconfig	2019-10-30 00:29:01 UTC (rev 251747)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (251746 => 251747)

--- branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-10-30 00:28:20 UTC (rev 251746)
+++ branches/safari-608-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2019-10-30 00:29:01 UTC (rev 251747)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 608;
 MINOR_VERSION = 4;
-TINY_VERSION = 3;
+TINY_VERSION = 4;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251746] trunk

[cdumez]

Title: [251746] trunk








Revision 251746
Author cdu...@apple.com
Date 2019-10-29 17:28:20 -0700 (Tue, 29 Oct 2019)


Log Message
UserMediaRequest should not prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203098


Reviewed by Eric Carlson.

Source/WebCore:

Allow pages to enter the back/forward cache, even if they have a pending
getUserMedia promise. Whenever we get a permission decision from the
UIProcess, we now schedule a task to resolve/reject the promise on the
WindowEventLoop. The WindowEventLoop properly gets suspended while in
the back/forward cache.

Test: http/tests/navigation/page-cache-getUserMedia-pending-promise.html

* Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::getUserMedia const):
If the document is not fully active, reject the promise with an InvalidStateError, as per:
- https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia (Step 4)

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::allow):
(WebCore::UserMediaRequest::deny):
(WebCore::UserMediaRequest::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted.
* Modules/mediastream/UserMediaRequest.h:

LayoutTests:

Add layout test coverage.

* fast/mediastream/MediaDevices-getUserMedia-expected.txt:
* http/tests/navigation/page-cache-getUserMedia-pending-promise-expected.txt: Added.
* http/tests/navigation/page-cache-getUserMedia-pending-promise.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia-expected.txt
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.cpp
trunk/Source/WebCore/Modules/mediastream/UserMediaRequest.h


Added Paths

trunk/LayoutTests/http/tests/navigation/page-cache-getUserMedia-pending-promise-expected.txt
trunk/LayoutTests/http/tests/navigation/page-cache-getUserMedia-pending-promise.html




Diff

Modified: trunk/LayoutTests/ChangeLog (251745 => 251746)

--- trunk/LayoutTests/ChangeLog	2019-10-30 00:21:19 UTC (rev 251745)
+++ trunk/LayoutTests/ChangeLog	2019-10-30 00:28:20 UTC (rev 251746)
@@ -1,3 +1,17 @@
+2019-10-29  Chris Dumez  
+
+UserMediaRequest should not prevent entering the back/forward cache
+https://bugs.webkit.org/show_bug.cgi?id=203098
+
+
+Reviewed by Eric Carlson.
+
+Add layout test coverage.
+
+* fast/mediastream/MediaDevices-getUserMedia-expected.txt:
+* http/tests/navigation/page-cache-getUserMedia-pending-promise-expected.txt: Added.
+* http/tests/navigation/page-cache-getUserMedia-pending-promise.html: Added.
+
 2019-10-29  Peng Liu  
 
 [Picture-in-Picture Web API] Implement PictureInPictureWindow


Modified: trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia-expected.txt (251745 => 251746)

--- trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia-expected.txt	2019-10-30 00:21:19 UTC (rev 251745)
+++ trunk/LayoutTests/fast/mediastream/MediaDevices-getUserMedia-expected.txt	2019-10-30 00:28:20 UTC (rev 251746)
@@ -6,9 +6,9 @@
 PASS typeof navigator.mediaDevices.webkitGetUserMedia is 'undefined'
 
 PASS navigator.mediaDevices.getUserMedia({audio:true}).then(gotStream1); did not throw exception.
+PASS navigator.mediaDevices.getUserMedia.apply(undefined) rejected with error: TypeError: Can only call MediaDevices.getUserMedia on instances of MediaDevices
 PASS navigator.mediaDevices.getUserMedia() rejected with error: TypeError: Type error
 PASS navigator.mediaDevices.getUserMedia({}) rejected with error: TypeError: Type error
-PASS navigator.mediaDevices.getUserMedia.apply(undefined) rejected with error: TypeError: Can only call MediaDevices.getUserMedia on instances of MediaDevices
 PASS Stream 1 generated.
 PASS stream.getAudioTracks().length is 1
 PASS stream.getVideoTracks().length is 0


Added: trunk/LayoutTests/http/tests/navigation/page-cache-getUserMedia-pending-promise-expected.txt (0 => 251746)

--- trunk/LayoutTests/http/tests/navigation/page-cache-getUserMedia-pending-promise-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/navigation/page-cache-getUserMedia-pending-promise-expected.txt	2019-10-30 00:28:20 UTC (rev 251746)
@@ -0,0 +1,15 @@
+Tests that a page with a pending getUserMedia request is able to go into the back/forward cache.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+pageshow - not from cache
+pagehide - entering cache
+pageshow - from cache
+PASS Page was restored from Page Cache
+PASS Promised was resolved
+PASS restoredFromPageCache is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/http/tests/navigation/page-cache-getUserMedia-pending-promise.html (0 => 251746)

--- 

[webkit-changes] [251745] trunk

[commit-queue]

Title: [251745] trunk








Revision 251745
Author commit-qu...@webkit.org
Date 2019-10-29 17:21:19 -0700 (Tue, 29 Oct 2019)


Log Message
[Picture-in-Picture Web API] Implement PictureInPictureWindow
https://bugs.webkit.org/show_bug.cgi?id=202615

Patch by Peng Liu  on 2019-10-29
Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/picture-in-picture-api-enter-pip-1.html
   media/picture-in-picture-api-enter-pip-2.html
   media/picture-in-picture-api-enter-pip-3.html
   media/picture-in-picture-api-enter-pip-4.html
   media/picture-in-picture-api-exit-pip-1.html
   media/picture-in-picture-api-exit-pip-2.html
   media/picture-in-picture-api-pip-events.html
   media/picture-in-picture-api-pip-window.html

* Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp:
(WebCore::HTMLVideoElementPictureInPicture::HTMLVideoElementPictureInPicture):
(WebCore::HTMLVideoElementPictureInPicture::requestPictureInPicture):
(WebCore::HTMLVideoElementPictureInPicture::didEnterPictureInPicture):
(WebCore::HTMLVideoElementPictureInPicture::didExitPictureInPicture):
(WebCore::HTMLVideoElementPictureInPicture::pictureInPictureWindowResized):
* Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h:
* Modules/pictureinpicture/PictureInPictureWindow.cpp:
(WebCore::PictureInPictureWindow::create):
(WebCore::PictureInPictureWindow::PictureInPictureWindow):
(WebCore::PictureInPictureWindow::setSize):
(WebCore::PictureInPictureWindow::close):
* Modules/pictureinpicture/PictureInPictureWindow.h:
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::fullscreenModeChanged):
(WebCore::HTMLVideoElement::didBecomeFullscreenElement):
(WebCore::HTMLVideoElement::setPictureInPictureObserver):
(WebCore::HTMLVideoElement::setVideoFullscreenFrame):
* html/HTMLVideoElement.h:
* platform/PictureInPictureObserver.h:

LayoutTests:

Add layout test cases for the Picture-in-Picture API.

* TestExpectations:
* media/picture-in-picture-api-enter-pip-1-expected.txt: Added.
* media/picture-in-picture-api-enter-pip-1.html: Added.
* media/picture-in-picture-api-enter-pip-2-expected.txt: Added.
* media/picture-in-picture-api-enter-pip-2.html: Added.
* media/picture-in-picture-api-enter-pip-3-expected.txt: Added.
* media/picture-in-picture-api-enter-pip-3.html: Added.
* media/picture-in-picture-api-enter-pip-4-expected.txt: Added.
* media/picture-in-picture-api-enter-pip-4.html: Added.
* media/picture-in-picture-api-exit-pip-1-expected.txt: Added.
* media/picture-in-picture-api-exit-pip-1.html: Added.
* media/picture-in-picture-api-exit-pip-2-expected.txt: Added.
* media/picture-in-picture-api-exit-pip-2.html: Added.
* media/picture-in-picture-api-pip-events-expected.txt: Added.
* media/picture-in-picture-api-pip-events.html: Added.
* media/picture-in-picture-api-pip-window-expected.txt: Added.
* media/picture-in-picture-api-pip-window.html: Added.
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.cpp
trunk/Source/WebCore/Modules/pictureinpicture/HTMLVideoElementPictureInPicture.h
trunk/Source/WebCore/Modules/pictureinpicture/PictureInPictureWindow.cpp
trunk/Source/WebCore/Modules/pictureinpicture/PictureInPictureWindow.h
trunk/Source/WebCore/html/HTMLVideoElement.cpp
trunk/Source/WebCore/html/HTMLVideoElement.h
trunk/Source/WebCore/platform/PictureInPictureObserver.h


Added Paths

trunk/LayoutTests/media/picture-in-picture-api-enter-pip-1-expected.txt
trunk/LayoutTests/media/picture-in-picture-api-enter-pip-1.html
trunk/LayoutTests/media/picture-in-picture-api-enter-pip-2-expected.txt
trunk/LayoutTests/media/picture-in-picture-api-enter-pip-2.html
trunk/LayoutTests/media/picture-in-picture-api-enter-pip-3-expected.txt
trunk/LayoutTests/media/picture-in-picture-api-enter-pip-3.html
trunk/LayoutTests/media/picture-in-picture-api-enter-pip-4-expected.txt
trunk/LayoutTests/media/picture-in-picture-api-enter-pip-4.html
trunk/LayoutTests/media/picture-in-picture-api-exit-pip-1-expected.txt
trunk/LayoutTests/media/picture-in-picture-api-exit-pip-1.html
trunk/LayoutTests/media/picture-in-picture-api-exit-pip-2-expected.txt
trunk/LayoutTests/media/picture-in-picture-api-exit-pip-2.html
trunk/LayoutTests/media/picture-in-picture-api-pip-events-expected.txt
trunk/LayoutTests/media/picture-in-picture-api-pip-events.html
trunk/LayoutTests/media/picture-in-picture-api-pip-window-expected.txt
trunk/LayoutTests/media/picture-in-picture-api-pip-window.html




Diff

Modified: trunk/LayoutTests/ChangeLog (251744 => 251745)

--- trunk/LayoutTests/ChangeLog	2019-10-30 00:10:28 UTC (rev 251744)
+++ trunk/LayoutTests/ChangeLog	2019-10-30 00:21:19 UTC (rev 251745)
@@ -1,3 +1,31 @@
+2019-10-29  Peng Liu  
+
+[Picture-in-Picture Web API] Implement PictureInPictureWindow
+

[webkit-changes] [251744] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [251744] trunk/Source/WebInspectorUI








Revision 251744
Author nvasil...@apple.com
Date 2019-10-29 17:10:28 -0700 (Tue, 29 Oct 2019)


Log Message
Web Inspector: Opacity slider background doesn't update when when hue slider moves
https://bugs.webkit.org/show_bug.cgi?id=203593


Reviewed by Matt Baker.

* UserInterface/Views/ColorPicker.js:
(WI.ColorPicker.prototype.set color):
(WI.ColorPicker.prototype.colorSquareColorDidChange):
Remove unused function arguments.

(WI.ColorPicker.prototype.sliderValueDidChange):
Update the background of the opacity slider when the hue slider changes.

(WI.ColorPicker.prototype._updateOpacitySlider): Renamed from _updateSliders.
Drive-by: replace `var` with `let`.

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (251743 => 251744)

--- trunk/Source/WebInspectorUI/ChangeLog	2019-10-30 00:02:19 UTC (rev 251743)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-10-30 00:10:28 UTC (rev 251744)
@@ -1,3 +1,22 @@
+2019-10-29  Nikita Vasilyev  
+
+Web Inspector: Opacity slider background doesn't update when when hue slider moves
+https://bugs.webkit.org/show_bug.cgi?id=203593
+
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/ColorPicker.js:
+(WI.ColorPicker.prototype.set color):
+(WI.ColorPicker.prototype.colorSquareColorDidChange):
+Remove unused function arguments.
+
+(WI.ColorPicker.prototype.sliderValueDidChange):
+Update the background of the opacity slider when the hue slider changes.
+
+(WI.ColorPicker.prototype._updateOpacitySlider): Renamed from _updateSliders.
+Drive-by: replace `var` with `let`.
+
 2019-10-28  Nikita Vasilyev  
 
 Web Inspector: Right-clicking in color picker should not select color


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js (251743 => 251744)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js	2019-10-30 00:02:19 UTC (rev 251743)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js	2019-10-30 00:10:28 UTC (rev 251744)
@@ -123,7 +123,7 @@
 this._hueSlider.value = this._color.hsl[0] / 360;
 
 this._opacitySlider.value = this._color.alpha;
-this._updateSliders(this._colorSquare.rawColor, this._color);
+this._updateOpacitySlider();
 
 this._showColorComponentInputs();
 
@@ -143,7 +143,7 @@
 colorSquareColorDidChange(colorSquare)
 {
 this._updateColor();
-this._updateSliders(this._colorSquare.rawColor, this._colorSquare.tintedColor);
+this._updateOpacitySlider();
 }
 
 sliderValueDidChange(slider, value)
@@ -153,6 +153,7 @@
 else if (slider === this._hueSlider) {
 this._colorSquare.hue = value * 360;
 this._updateColor();
+this._updateOpacitySlider();
 }
 }
 
@@ -189,11 +190,11 @@
 this._handleFormatChange();
 }
 
-_updateSliders(rawColor, tintedColor)
+_updateOpacitySlider()
 {
-var rgb = this._colorSquare.tintedColor.rgb;
-var opaque = new WI.Color(WI.Color.Format.RGBA, rgb.concat(1)).toString();
-var transparent = new WI.Color(WI.Color.Format.RGBA, rgb.concat(0)).toString();
+let rgb = this._colorSquare.tintedColor.rgb;
+let opaque = new WI.Color(WI.Color.Format.RGBA, rgb.concat(1)).toString();
+let transparent = new WI.Color(WI.Color.Format.RGBA, rgb.concat(0)).toString();
 this._opacitySlider.element.style.setProperty("background-image", "linear-gradient(90deg, " + transparent + ", " + opaque + "), " + this._opacityPattern);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251743] tags/Safari-608.4.3/

[alancoon]

Title: [251743] tags/Safari-608.4.3/








Revision 251743
Author alanc...@apple.com
Date 2019-10-29 17:02:19 -0700 (Tue, 29 Oct 2019)


Log Message
Tag Safari-608.4.3.

Added Paths

tags/Safari-608.4.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [251742] trunk

[commit-queue]

Title: [251742] trunk








Revision 251742
Author commit-qu...@webkit.org
Date 2019-10-29 16:07:16 -0700 (Tue, 29 Oct 2019)


Log Message
WebAnimation should never prevent entering the back/forward cache
https://bugs.webkit.org/show_bug.cgi?id=203088


Patch by Antoine Quint  on 2019-10-29
Reviewed by Antti Koivisto.

Source/WebCore:

Test: webanimations/animation-page-cache.html

We remove the Web Animation override of the deprecated method ActiveDOMObject::shouldPreventEnteringBackForwardCache_DEPRECATED()
and instead ensure event dispatch is suspended along with the WebAnimation object through the adoption of a SuspendableTaskQueue.

We also ensure an animation correctly suspends itself when ActiveDOMObject::suspend() and ActiveDOMObject::resume() are called.
Implementing these methods showed that we have some placeholders in DeclarativeAnimation that were not necessary, so we remove those.

Finally, we no longer need to track the stopped state since the SuspendableTaskQueue will close itself when ActiveDOMObject::stop()
is called.

* animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::stop): Deleted.
(WebCore::DeclarativeAnimation::suspend): Deleted.
(WebCore::DeclarativeAnimation::resume): Deleted.
* animation/DeclarativeAnimation.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::WebAnimation):
(WebCore::WebAnimation::enqueueAnimationPlaybackEvent):
(WebCore::WebAnimation::suspend):
(WebCore::WebAnimation::resume):
(WebCore::WebAnimation::stop):
(WebCore::WebAnimation::hasPendingActivity):
(WebCore::WebAnimation::shouldPreventEnteringBackForwardCache_DEPRECATED const): Deleted.
* animation/WebAnimation.h:

LayoutTests:

Add a new test that checks that an Animation that would run past a page's navigation is correctly suspended
and resumed as it enters and leaves the back/forward cache.

* webanimations/animation-page-cache-expected.txt: Added.
* webanimations/animation-page-cache.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webanimations/leak-document-with-web-animation-expected.txt
trunk/LayoutTests/webanimations/leak-document-with-web-animation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/DeclarativeAnimation.cpp
trunk/Source/WebCore/animation/DeclarativeAnimation.h
trunk/Source/WebCore/animation/WebAnimation.cpp
trunk/Source/WebCore/animation/WebAnimation.h
trunk/Source/WebCore/platform/SuspendableTaskQueue.h


Added Paths

trunk/LayoutTests/webanimations/animation-page-cache-expected.txt
trunk/LayoutTests/webanimations/animation-page-cache.html




Diff

Modified: trunk/LayoutTests/ChangeLog (251741 => 251742)

--- trunk/LayoutTests/ChangeLog	2019-10-29 23:04:41 UTC (rev 251741)
+++ trunk/LayoutTests/ChangeLog	2019-10-29 23:07:16 UTC (rev 251742)
@@ -1,3 +1,17 @@
+2019-10-29  Antoine Quint  
+
+WebAnimation should never prevent entering the back/forward cache
+https://bugs.webkit.org/show_bug.cgi?id=203088
+
+
+Reviewed by Antti Koivisto.
+
+Add a new test that checks that an Animation that would run past a page's navigation is correctly suspended
+and resumed as it enters and leaves the back/forward cache.
+
+* webanimations/animation-page-cache-expected.txt: Added.
+* webanimations/animation-page-cache.html: Added.
+
 2019-10-29  Megan Gardner  
 
 Update autocorrect test to have correctly focused contenteditable


Added: trunk/LayoutTests/webanimations/animation-page-cache-expected.txt (0 => 251742)

--- trunk/LayoutTests/webanimations/animation-page-cache-expected.txt	(rev 0)
+++ trunk/LayoutTests/webanimations/animation-page-cache-expected.txt	2019-10-29 23:07:16 UTC (rev 251742)
@@ -0,0 +1,2 @@
+This test verifies that the page cache suspends and resumes Web Animations from the page cache. The test starts an animation, then navigates away, waits a bit, navigates back, confirming that the timeline froze at a given time and resumed in the same spot, advancing the animation. If successful, it outputs 'PASS' below.
+PASS.


Added: trunk/LayoutTests/webanimations/animation-page-cache.html (0 => 251742)

--- trunk/LayoutTests/webanimations/animation-page-cache.html	(rev 0)
+++ trunk/LayoutTests/webanimations/animation-page-cache.html	2019-10-29 23:07:16 UTC (rev 251742)
@@ -0,0 +1,58 @@
+
+
+
+
+let suspended = false;
+let restored = false;
+
+function finish(msg)
+{
+document.getElementById("result").textContent = msg;
+if (window.testRunner)
+testRunner.notifyDone();
+}
+
+window.addEventListener("pagehide", event => {
+suspended = event.persisted;
+if (!suspended)
+finish("FAIL: event.persisted was false for pagehide event.")
+});
+
+window.addEventListener("pageshow", event => {
+// If we haven't been suspended, then this is the initial page load, not the back navigation.
+if (!suspended)
+return;
+
+restored = event.persisted;
+if (!restored)

[webkit-changes] [251741] trunk/LayoutTests

[megan_gardner]

Title: [251741] trunk/LayoutTests








Revision 251741
Author megan_gard...@apple.com
Date 2019-10-29 16:04:41 -0700 (Tue, 29 Oct 2019)


Log Message
Update autocorrect test to have correctly focused contenteditable
https://bugs.webkit.org/show_bug.cgi?id=203552


Reviewed by Wenson Hsieh.

Autocorrection bails when we are not first responder after
https://bugs.webkit.org/show_bug.cgi?id=192824
Therefore, this test must be written to first focus the
contenteditable, and then apply the autocorrection.

* fast/events/ios/autocorrect-with-range-selection.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/ios/autocorrect-with-range-selection.html




Diff

Modified: trunk/LayoutTests/ChangeLog (251740 => 251741)

--- trunk/LayoutTests/ChangeLog	2019-10-29 22:33:42 UTC (rev 251740)
+++ trunk/LayoutTests/ChangeLog	2019-10-29 23:04:41 UTC (rev 251741)
@@ -1,3 +1,18 @@
+2019-10-29  Megan Gardner  
+
+Update autocorrect test to have correctly focused contenteditable
+https://bugs.webkit.org/show_bug.cgi?id=203552
+
+
+Reviewed by Wenson Hsieh.
+
+Autocorrection bails when we are not first responder after 
+https://bugs.webkit.org/show_bug.cgi?id=192824
+Therefore, this test must be written to first focus the 
+contenteditable, and then apply the autocorrection.
+
+* fast/events/ios/autocorrect-with-range-selection.html:
+
 2019-10-07  Jer Noble  
 
 Implement the Remote Playback API.


Modified: trunk/LayoutTests/fast/events/ios/autocorrect-with-range-selection.html (251740 => 251741)

--- trunk/LayoutTests/fast/events/ios/autocorrect-with-range-selection.html	2019-10-29 22:33:42 UTC (rev 251740)
+++ trunk/LayoutTests/fast/events/ios/autocorrect-with-range-selection.html	2019-10-29 23:04:41 UTC (rev 251741)
@@ -2,6 +2,7 @@
 
 
 
+