[webkit-changes] [255418] trunk

[Hironori . Fujii]

Title: [255418] trunk








Revision 255418
Author hironori.fu...@sony.com
Date 2020-01-29 23:02:25 -0800 (Wed, 29 Jan 2020)


Log Message
[MSVC] Add /experimental:newLambdaProcessor switch for better C++ conformance
https://bugs.webkit.org/show_bug.cgi?id=204443

Reviewed by Alex Christensen.

.:

MSVC has a bug of 'this' in lambda captures. It has caused
compilation errors repeatedly.

* Source/cmake/OptionsMSVC.cmake: Added /experimental:newLambdaProcessor switch.

Source/WebCore:

* dom/DocumentStorageAccess.cpp:
(WebCore::DocumentStorageAccess::requestStorageAccess): Reverted MSVC workaround of r252726.

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DocumentStorageAccess.cpp
trunk/Source/cmake/OptionsMSVC.cmake




Diff

Modified: trunk/ChangeLog (255417 => 255418)

--- trunk/ChangeLog	2020-01-30 06:41:59 UTC (rev 255417)
+++ trunk/ChangeLog	2020-01-30 07:02:25 UTC (rev 255418)
@@ -1,3 +1,15 @@
+2020-01-29  Fujii Hironori  
+
+[MSVC] Add /experimental:newLambdaProcessor switch for better C++ conformance
+https://bugs.webkit.org/show_bug.cgi?id=204443
+
+Reviewed by Alex Christensen.
+
+MSVC has a bug of 'this' in lambda captures. It has caused
+compilation errors repeatedly.
+
+* Source/cmake/OptionsMSVC.cmake: Added /experimental:newLambdaProcessor switch.
+
 2020-01-29  Stephan Szabo  
 
 [PlayStation] Allow setting CMAKE_IGNORE_PATH from environment for bots


Modified: trunk/Source/WebCore/ChangeLog (255417 => 255418)

--- trunk/Source/WebCore/ChangeLog	2020-01-30 06:41:59 UTC (rev 255417)
+++ trunk/Source/WebCore/ChangeLog	2020-01-30 07:02:25 UTC (rev 255418)
@@ -1,3 +1,13 @@
+2020-01-29  Fujii Hironori  
+
+[MSVC] Add /experimental:newLambdaProcessor switch for better C++ conformance
+https://bugs.webkit.org/show_bug.cgi?id=204443
+
+Reviewed by Alex Christensen.
+
+* dom/DocumentStorageAccess.cpp:
+(WebCore::DocumentStorageAccess::requestStorageAccess): Reverted MSVC workaround of r252726.
+
 2020-01-29  Eric Carlson  
 
 Do not notify other applications when deactivating the audio session


Modified: trunk/Source/WebCore/dom/DocumentStorageAccess.cpp (255417 => 255418)

--- trunk/Source/WebCore/dom/DocumentStorageAccess.cpp	2020-01-30 06:41:59 UTC (rev 255417)
+++ trunk/Source/WebCore/dom/DocumentStorageAccess.cpp	2020-01-30 07:02:25 UTC (rev 255418)
@@ -182,7 +182,7 @@
 bool shouldPreserveUserGesture = wasGranted == StorageAccessWasGranted::Yes || promptWasShown == StorageAccessPromptWasShown::No;
 
 if (shouldPreserveUserGesture) {
-m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*weakThis)] {
+m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*this)] {
 if (weakThis)
 enableTemporaryTimeUserGesture();
 });
@@ -197,7 +197,7 @@
 }
 
 if (shouldPreserveUserGesture) {
-m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*weakThis)] {
+m_document.eventLoop().queueMicrotask([this, weakThis = makeWeakPtr(*this)] {
 if (weakThis)
 consumeTemporaryTimeUserGesture();
 });


Modified: trunk/Source/cmake/OptionsMSVC.cmake (255417 => 255418)

--- trunk/Source/cmake/OptionsMSVC.cmake	2020-01-30 06:41:59 UTC (rev 255417)
+++ trunk/Source/cmake/OptionsMSVC.cmake	2020-01-30 07:02:25 UTC (rev 255418)
@@ -29,6 +29,11 @@
 # Specify the source code encoding
 add_compile_options(/utf-8 /validate-charset)
 
+# Enable the new lambda processor for better C++ conformance with /std:c++17
+if (NOT COMPILER_IS_CLANG_CL)
+add_compile_options(/experimental:newLambdaProcessor)
+endif ()
+
 if (${CMAKE_BUILD_TYPE} MATCHES "Debug")
 set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} /OPT:NOREF /OPT:NOICF")
 set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /OPT:NOREF /OPT:NOICF")






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255417] trunk/Source/WebCore

[eric . carlson]

Title: [255417] trunk/Source/WebCore








Revision 255417
Author eric.carl...@apple.com
Date 2020-01-29 22:41:59 -0800 (Wed, 29 Jan 2020)


Log Message
Do not notify other applications when deactivating the audio session
https://bugs.webkit.org/show_bug.cgi?id=206963

Reviewed by Jer Noble.

Tested manually because this change is iOS-only and only reproduces on hardware.

* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::tryToSetActiveInternal): Don't pass the AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation
flag to -[AVAudioSession setActive:error].

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (255416 => 255417)

--- trunk/Source/WebCore/ChangeLog	2020-01-30 05:51:43 UTC (rev 255416)
+++ trunk/Source/WebCore/ChangeLog	2020-01-30 06:41:59 UTC (rev 255417)
@@ -1,3 +1,16 @@
+2020-01-29  Eric Carlson  
+
+Do not notify other applications when deactivating the audio session
+https://bugs.webkit.org/show_bug.cgi?id=206963
+
+Reviewed by Jer Noble.
+
+Tested manually because this change is iOS-only and only reproduces on hardware.
+
+* platform/audio/ios/AudioSessionIOS.mm:
+(WebCore::AudioSession::tryToSetActiveInternal): Don't pass the AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation
+flag to -[AVAudioSession setActive:error].
+
 2020-01-29  Tim Horton  
 
 REGRESSION (r255322): macCatalyst: Tapping in an input field doesn't change the selection location


Modified: trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm (255416 => 255417)

--- trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2020-01-30 05:51:43 UTC (rev 255416)
+++ trunk/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm	2020-01-30 06:41:59 UTC (rev 255417)
@@ -224,7 +224,7 @@
 }
 
 dispatch_async(m_private->m_dispatchQueue.get(), ^{
-[[PAL::getAVAudioSessionClass() sharedInstance] setActive:NO withOptions:AVAudioSessionSetActiveOptionNotifyOthersOnDeactivation error:];
+[[PAL::getAVAudioSessionClass() sharedInstance] setActive:NO withOptions:0 error:];
 });
 
 return true;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255416] trunk

[mark . lam]

Title: [255416] trunk








Revision 255416
Author mark@apple.com
Date 2020-01-29 21:51:43 -0800 (Wed, 29 Jan 2020)


Log Message
Fix bad assertion in InternalFunctionAllocationProfile::createAllocationStructureFromBase().
https://bugs.webkit.org/show_bug.cgi?id=206981


Reviewed by Keith Miller.

JSTests:

* stress/InternalFunctionAllocationProfile-createAllocationStructureFromBase-should-allow-for-same-classInfo-from-different-globals.js: Added.

Source/_javascript_Core:

InternalFunctionAllocationProfile::createAllocationStructureFromBase() is only
called from FunctionRareData::createInternalFunctionAllocationStructureFromBase(),
which in turn is only called from InternalFunction::createSubclassStructureSlow().

InternalFunction::createSubclassStructureSlow() only allows a call to
FunctionRareData::createInternalFunctionAllocationStructureFromBase() under
certain conditions.  One of these conditions is that the baseGlobalObject is
different than the newTarget's globalObject.

InternalFunctionAllocationProfile::createAllocationStructureFromBase() has an
ASSERT on the same set of conditions, with one ommission: the one above.  This
patch fixes the ASSERT by adding the missing condition to match the check in
InternalFunction::createSubclassStructureSlow().

* bytecode/InternalFunctionAllocationProfile.h:
(JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/InternalFunctionAllocationProfile.h


Added Paths

trunk/JSTests/stress/InternalFunctionAllocationProfile-createAllocationStructureFromBase-should-allow-for-same-classInfo-from-different-globals.js




Diff

Modified: trunk/JSTests/ChangeLog (255415 => 255416)

--- trunk/JSTests/ChangeLog	2020-01-30 04:47:38 UTC (rev 255415)
+++ trunk/JSTests/ChangeLog	2020-01-30 05:51:43 UTC (rev 255416)
@@ -1,3 +1,13 @@
+2020-01-29  Mark Lam  
+
+Fix bad assertion in InternalFunctionAllocationProfile::createAllocationStructureFromBase().
+https://bugs.webkit.org/show_bug.cgi?id=206981
+
+
+Reviewed by Keith Miller.
+
+* stress/InternalFunctionAllocationProfile-createAllocationStructureFromBase-should-allow-for-same-classInfo-from-different-globals.js: Added.
+
 2020-01-29  Yusuke Suzuki  
 
 Unreviewed, update tests


Added: trunk/JSTests/stress/InternalFunctionAllocationProfile-createAllocationStructureFromBase-should-allow-for-same-classInfo-from-different-globals.js (0 => 255416)

--- trunk/JSTests/stress/InternalFunctionAllocationProfile-createAllocationStructureFromBase-should-allow-for-same-classInfo-from-different-globals.js	(rev 0)
+++ trunk/JSTests/stress/InternalFunctionAllocationProfile-createAllocationStructureFromBase-should-allow-for-same-classInfo-from-different-globals.js	2020-01-30 05:51:43 UTC (rev 255416)
@@ -0,0 +1,6 @@
+global1 = createGlobalObject();
+global2 = createGlobalObject();
+
+function bar() {}
+Reflect.construct(global1.Object, {}, bar);
+Reflect.construct(global2.Object, {}, bar);


Modified: trunk/Source/_javascript_Core/ChangeLog (255415 => 255416)

--- trunk/Source/_javascript_Core/ChangeLog	2020-01-30 04:47:38 UTC (rev 255415)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-30 05:51:43 UTC (rev 255416)
@@ -1,3 +1,28 @@
+2020-01-29  Mark Lam  
+
+Fix bad assertion in InternalFunctionAllocationProfile::createAllocationStructureFromBase().
+https://bugs.webkit.org/show_bug.cgi?id=206981
+
+
+Reviewed by Keith Miller.
+
+InternalFunctionAllocationProfile::createAllocationStructureFromBase() is only
+called from FunctionRareData::createInternalFunctionAllocationStructureFromBase(),
+which in turn is only called from InternalFunction::createSubclassStructureSlow().
+
+InternalFunction::createSubclassStructureSlow() only allows a call to
+FunctionRareData::createInternalFunctionAllocationStructureFromBase() under
+certain conditions.  One of these conditions is that the baseGlobalObject is
+different than the newTarget's globalObject.
+
+InternalFunctionAllocationProfile::createAllocationStructureFromBase() has an
+ASSERT on the same set of conditions, with one ommission: the one above.  This
+patch fixes the ASSERT by adding the missing condition to match the check in
+InternalFunction::createSubclassStructureSlow().
+
+* bytecode/InternalFunctionAllocationProfile.h:
+(JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase):
+
 2020-01-29  Robin Morisset  
 
 Remove Options::enableSpectreMitigations


Modified: trunk/Source/_javascript_Core/bytecode/InternalFunctionAllocationProfile.h (255415 => 255416)

--- trunk/Source/_javascript_Core/bytecode/InternalFunctionAllocationProfile.h	2020-01-30 04:47:38 UTC (rev 255415)
+++ 

[webkit-changes] [255415] trunk/Source

[timothy_horton]

Title: [255415] trunk/Source








Revision 255415
Author timothy_hor...@apple.com
Date 2020-01-29 20:47:38 -0800 (Wed, 29 Jan 2020)


Log Message
REGRESSION (r255322): macCatalyst: Tapping in an input field doesn't change the selection location
https://bugs.webkit.org/show_bug.cgi?id=206978

Reviewed by Wenson Hsieh.

Source/WebCore:

* page/ChromeClient.h:
(WebCore::ChromeClient::shouldUseMouseEventForSelection):
(WebCore::ChromeClient::shouldUseMouseEventsForSelection): Deleted.
* page/EventHandler.cpp:
(WebCore::EventHandler::canMouseDownStartSelect):
(WebCore::EventHandler::handleMousePressEvent):
* page/EventHandler.h:
Plumb the event through to the ChromeClient so it can use it to make decisions.

Source/WebKit:

* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::shouldUseMouseEventForSelection):
(WebKit::WebChromeClient::shouldUseMouseEventsForSelection): Deleted.
Allow single-click events to change the selection; this is required
in order to allow WebCore to set the selection in the case that
the UITextInteraction gestures haven't yet been installed. Continue
to not allow multi-click events to change the selection, because
these are the ones that conflict with UIKit's behaviors.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/ChromeClient.h
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/EventHandler.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKit/WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (255414 => 255415)

--- trunk/Source/WebCore/ChangeLog	2020-01-30 04:15:51 UTC (rev 255414)
+++ trunk/Source/WebCore/ChangeLog	2020-01-30 04:47:38 UTC (rev 255415)
@@ -1,3 +1,19 @@
+2020-01-29  Tim Horton  
+
+REGRESSION (r255322): macCatalyst: Tapping in an input field doesn't change the selection location
+https://bugs.webkit.org/show_bug.cgi?id=206978
+
+Reviewed by Wenson Hsieh.
+
+* page/ChromeClient.h:
+(WebCore::ChromeClient::shouldUseMouseEventForSelection):
+(WebCore::ChromeClient::shouldUseMouseEventsForSelection): Deleted.
+* page/EventHandler.cpp:
+(WebCore::EventHandler::canMouseDownStartSelect):
+(WebCore::EventHandler::handleMousePressEvent):
+* page/EventHandler.h:
+Plumb the event through to the ChromeClient so it can use it to make decisions.
+
 2020-01-29  Ryosuke Niwa  
 
 REGRESSION: [Mac wk1] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html is a flakey failure


Modified: trunk/Source/WebCore/page/ChromeClient.h (255414 => 255415)

--- trunk/Source/WebCore/page/ChromeClient.h	2020-01-30 04:15:51 UTC (rev 255414)
+++ trunk/Source/WebCore/page/ChromeClient.h	2020-01-30 04:47:38 UTC (rev 255415)
@@ -193,7 +193,7 @@
 virtual void setCursorHiddenUntilMouseMoves(bool) = 0;
 virtual bool supportsSettingCursor() { return true; }
 
-virtual bool shouldUseMouseEventsForSelection() { return true; }
+virtual bool shouldUseMouseEventForSelection(const PlatformMouseEvent&) { return true; }
 
 virtual FloatSize screenSize() const { return const_cast(*this).windowRect().size(); }
 virtual FloatSize availableScreenSize() const { return const_cast(*this).windowRect().size(); }


Modified: trunk/Source/WebCore/page/EventHandler.cpp (255414 => 255415)

--- trunk/Source/WebCore/page/EventHandler.cpp	2020-01-30 04:15:51 UTC (rev 255414)
+++ trunk/Source/WebCore/page/EventHandler.cpp	2020-01-30 04:47:38 UTC (rev 255415)
@@ -731,10 +731,12 @@
 return handled;
 }
 
-bool EventHandler::canMouseDownStartSelect(Node* node)
+bool EventHandler::canMouseDownStartSelect(const MouseEventWithHitTestResults& event)
 {
+auto* node = event.targetNode();
+
 if (Page* page = m_frame.page()) {
-if (!page->chrome().client().shouldUseMouseEventsForSelection())
+if (!page->chrome().client().shouldUseMouseEventForSelection(event.event()))
 return false;
 }
 
@@ -768,7 +770,7 @@
 
 // If we got the event back, that must mean it wasn't prevented,
 // so it's allowed to start a drag or selection if it wasn't in a scrollbar.
-m_mouseDownMayStartSelect = canMouseDownStartSelect(event.targetNode()) && !event.scrollbar();
+m_mouseDownMayStartSelect = canMouseDownStartSelect(event) && !event.scrollbar();
 
 #if ENABLE(DRAG_SUPPORT)
 // Careful that the drag starting logic stays in sync with eventMayStartDrag()


Modified: trunk/Source/WebCore/page/EventHandler.h (255414 => 255415)

--- trunk/Source/WebCore/page/EventHandler.h	2020-01-30 04:15:51 UTC (rev 255414)
+++ trunk/Source/WebCore/page/EventHandler.h	2020-01-30 04:47:38 UTC (rev 255415)
@@ -500,7 +500,7 @@
 
 bool shouldSendMouseEventsToInactiveWindows() const;
 
-bool 

[webkit-changes] [255414] trunk

[rniwa]

Title: [255414] trunk








Revision 255414
Author rn...@webkit.org
Date 2020-01-29 20:15:51 -0800 (Wed, 29 Jan 2020)


Log Message
REGRESSION: [Mac wk1] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=205168

Reviewed by Simon Fraser.

Source/WebCore:

The flakiness of the test was caused by document.fonts.ready resolving without waiting for the document
to be loaded if FontFaceSet::FontFaceSet is created after the initial layout had been done.

r249295 introduced this racy code to address the previous behavior of WebKit, which didn't wait for
either document to finish loading or the initial layout to happen at all, and the WebKit workaround in
the offending WPT test was subsequentially removed, resulting in the flaky failure after the test was
synced up in r249760.

This patch address the underlying bug by making ready promise wait until Document::implicitClose is called.

Unfortunately, the specification is extremely vague in terms of when this promise is resolved but new
behavior of WebKit is more or less with Firefox (Chrome seems to have a similar race condition as WebKit).

See also: https://github.com/w3c/csswg-drafts/issues/4248.

Test: fast/css/font-face-set-ready-after-document-load.html

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::fontFaceSetIfExists): Renamed from optionalFontFaceSet for consistency.
* css/CSSFontSelector.h:
* css/FontFaceSet.cpp:
(WebCore::FontFaceSet::FontFaceSet): Fixed the bug.
(WebCore::FontFaceSet::documentDidFinishLoading): Renamed from didFirstLayout to reflect the new semantics.
(WebCore::FontFaceSet::completedLoading):
* css/FontFaceSet.h:
* dom/Document.cpp:
(WebCore::Document::implicitClose): Deployed makeRefPtr to be safe.

LayoutTests:

* fast/css/font-face-set-ready-after-document-load-expected.txt: Added.
* fast/css/font-face-set-ready-after-document-load.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontSelector.cpp
trunk/Source/WebCore/css/CSSFontSelector.h
trunk/Source/WebCore/css/FontFaceSet.cpp
trunk/Source/WebCore/css/FontFaceSet.h
trunk/Source/WebCore/dom/Document.cpp


Added Paths

trunk/LayoutTests/fast/css/font-face-set-ready-after-document-load-expected.txt
trunk/LayoutTests/fast/css/font-face-set-ready-after-document-load.html




Diff

Modified: trunk/LayoutTests/ChangeLog (255413 => 255414)

--- trunk/LayoutTests/ChangeLog	2020-01-30 04:12:57 UTC (rev 255413)
+++ trunk/LayoutTests/ChangeLog	2020-01-30 04:15:51 UTC (rev 255414)
@@ -1,3 +1,13 @@
+2020-01-29  Ryosuke Niwa  
+
+REGRESSION: [Mac wk1] imported/w3c/web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html is a flakey failure
+https://bugs.webkit.org/show_bug.cgi?id=205168
+
+Reviewed by Simon Fraser.
+
+* fast/css/font-face-set-ready-after-document-load-expected.txt: Added.
+* fast/css/font-face-set-ready-after-document-load.html: Added.
+
 2020-01-29  Sunny He  
 
 Clamp paddingBoxWidth/Height to a minimum of zero


Added: trunk/LayoutTests/fast/css/font-face-set-ready-after-document-load-expected.txt (0 => 255414)

--- trunk/LayoutTests/fast/css/font-face-set-ready-after-document-load-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/font-face-set-ready-after-document-load-expected.txt	2020-01-30 04:15:51 UTC (rev 255414)
@@ -0,0 +1,8 @@
+This test records the order by which load and DOMContentLoaded evnets fire relative to when document.fonts.ready is resolved.
+fonts.ready should resolve only after DOMContentLoaded and load event are fired, and fonts.check should return true for Ahem at that point.
+
+Before setting font-family - fonts.check Ahem: false
+DOMContentLoaded
+load
+fonts.ready - fonts.check Ahem: true
+hello


Added: trunk/LayoutTests/fast/css/font-face-set-ready-after-document-load.html (0 => 255414)

--- trunk/LayoutTests/fast/css/font-face-set-ready-after-document-load.html	(rev 0)
+++ trunk/LayoutTests/fast/css/font-face-set-ready-after-document-load.html	2020-01-30 04:15:51 UTC (rev 255414)
@@ -0,0 +1,47 @@
+
+
+
+
+
+@font-face {
+font-family: Ahem;
+src: url("../../resources/fonts/Ahem.ttf");
+}
+
+
+
+This test records the order by which load and DOMContentLoaded evnets fire relative to when document.fonts.ready is resolved.
+fonts.ready should resolve only after DOMContentLoaded and load event are fired, and fonts.check should return true for Ahem at that point.
+
+hello
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function log(message) {
+document.getElementById('log').textContent += message + '\n';
+}
+
+function checkAhem(description) {
+const check = document.fonts.check('10px Ahem');
+log(`${description} - fonts.check Ahem: ${check}`);
+}
+

[webkit-changes] [255413] trunk

[commit-queue]

Title: [255413] trunk








Revision 255413
Author commit-qu...@webkit.org
Date 2020-01-29 20:12:57 -0800 (Wed, 29 Jan 2020)


Log Message
Clamp paddingBoxWidth/Height to a minimum of zero
https://bugs.webkit.org/show_bug.cgi?id=206317
rdar://57102010

Patch by Sunny He  on 2020-01-29
Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

Source/WebCore:

Test: fast/multicol/crash-negative-paddingBoxWidth.html

* rendering/RenderBox.h:
(WebCore::RenderBox::paddingBoxWidth const):
(WebCore::RenderBox::paddingBoxHeight const):

LayoutTests:

* fast/multicol/crash-negative-paddingBoxWidth-expected.txt: Added.
* fast/multicol/crash-negative-paddingBoxWidth.html: Added.

* web-platform-tests/css/cssom-view/scrollLeft-of-scroller-with-wider-scrollbar-expected.txt:

Source/WebCore:

Test: fast/multicol/crash-negative-paddingBoxWidth.html

* rendering/RenderBox.h:
(WebCore::RenderBox::paddingBoxWidth const):
(WebCore::RenderBox::paddingBoxHeight const):

LayoutTests:

* fast/multicol/crash-negative-paddingBoxWidth-expected.txt: Added.
* fast/multicol/crash-negative-paddingBoxWidth.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/scrollLeft-of-scroller-with-wider-scrollbar-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderReplaced.cpp


Added Paths

trunk/LayoutTests/fast/multicol/crash-negative-paddingBoxWidth-expected.txt
trunk/LayoutTests/fast/multicol/crash-negative-paddingBoxWidth.html




Diff

Modified: trunk/LayoutTests/ChangeLog (255412 => 255413)

--- trunk/LayoutTests/ChangeLog	2020-01-30 03:27:41 UTC (rev 255412)
+++ trunk/LayoutTests/ChangeLog	2020-01-30 04:12:57 UTC (rev 255413)
@@ -1,3 +1,14 @@
+2020-01-29  Sunny He  
+
+Clamp paddingBoxWidth/Height to a minimum of zero
+https://bugs.webkit.org/show_bug.cgi?id=206317
+rdar://57102010
+
+Reviewed by Zalan Bujtas.
+
+* fast/multicol/crash-negative-paddingBoxWidth-expected.txt: Added.
+* fast/multicol/crash-negative-paddingBoxWidth.html: Added.
+
 2020-01-29  Justin Fan  
 
 [WebGL] Skip ANGLE-dependent WebGL 2 expected progressions on WebGL bot


Added: trunk/LayoutTests/fast/multicol/crash-negative-paddingBoxWidth-expected.txt (0 => 255413)

--- trunk/LayoutTests/fast/multicol/crash-negative-paddingBoxWidth-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/multicol/crash-negative-paddingBoxWidth-expected.txt	2020-01-30 04:12:57 UTC (rev 255413)
@@ -0,0 +1,4 @@
+
+Check that interactions between column gap, width, and scrollbar width don't cause crashes.
+
+PASS


Added: trunk/LayoutTests/fast/multicol/crash-negative-paddingBoxWidth.html (0 => 255413)

--- trunk/LayoutTests/fast/multicol/crash-negative-paddingBoxWidth.html	(rev 0)
+++ trunk/LayoutTests/fast/multicol/crash-negative-paddingBoxWidth.html	2020-01-30 04:12:57 UTC (rev 255413)
@@ -0,0 +1,14 @@
+
+
+* { width: 25%; grid-gap: 40%; columns: 6px;}
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+
+A
+Check that interactions between column gap, width, and scrollbar width don't cause crashes.
+PASS
+
+
\ No newline at end of file


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (255412 => 255413)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-01-30 03:27:41 UTC (rev 255412)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-01-30 04:12:57 UTC (rev 255413)
@@ -1,3 +1,26 @@
+2020-01-29  Sunny He  
+
+Clamp paddingBoxWidth/Height to a minimum of zero
+https://bugs.webkit.org/show_bug.cgi?id=206317
+rdar://57102010
+
+Reviewed by Zalan Bujtas.
+
+Source/WebCore:
+
+Test: fast/multicol/crash-negative-paddingBoxWidth.html
+
+* rendering/RenderBox.h:
+(WebCore::RenderBox::paddingBoxWidth const):
+(WebCore::RenderBox::paddingBoxHeight const):
+
+LayoutTests:
+
+* fast/multicol/crash-negative-paddingBoxWidth-expected.txt: Added.
+* fast/multicol/crash-negative-paddingBoxWidth.html: Added.
+
+* web-platform-tests/css/cssom-view/scrollLeft-of-scroller-with-wider-scrollbar-expected.txt:
+
 2020-01-29  Carlos Alberto Lopez Perez  
 
 Update WPT tests for css-easing (previously known as css-timing)


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/scrollLeft-of-scroller-with-wider-scrollbar-expected.txt (255412 => 255413)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/scrollLeft-of-scroller-with-wider-scrollbar-expected.txt	2020-01-30 03:27:41 UTC (rev 255412)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom-view/scrollLeft-of-scroller-with-wider-scrollbar-expected.txt	2020-01-30 04:12:57 UTC (rev 255413)
@@ -1,3 +1,3 @@
 
-FAIL Test the maxmium value of scrollLeft 

[webkit-changes] [255412] trunk/LayoutTests/imported/w3c

[clopez]

Title: [255412] trunk/LayoutTests/imported/w3c








Revision 255412
Author clo...@igalia.com
Date 2020-01-29 19:27:41 -0800 (Wed, 29 Jan 2020)


Log Message
Update WPT tests for css-easing (previously known as css-timing)
https://bugs.webkit.org/show_bug.cgi?id=206951

Reviewed by Simon Fraser.

Rename the directory and update WPT tests.

* resources/import-expectations.json:
* web-platform-tests/css-timing-1/OWNERS: Removed.
* web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt: Removed.
* web-platform-tests/css-timing-1/frames-timing-functions-output.html: Removed.
* web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt: Removed.
* web-platform-tests/css-timing-1/frames-timing-functions-syntax.html: Removed.
* web-platform-tests/css-timing-1/step-timing-functions-output-expected.txt: Removed.
* web-platform-tests/css-timing-1/step-timing-functions-output.html: Removed.
* web-platform-tests/css/css-easing/META.yml: Added.
* web-platform-tests/css/css-easing/cubic-bezier-timing-functions-output-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output-expected.txt.
* web-platform-tests/css/css-easing/cubic-bezier-timing-functions-output.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output.html.
* web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: Added.
* web-platform-tests/css/css-easing/step-timing-functions-output.html: Added.
* web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt: Added.
* web-platform-tests/css/css-easing/step-timing-functions-syntax.html: Added.
* web-platform-tests/css/css-easing/testcommon.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/css-timing-1/testcommon.js.
* web-platform-tests/css/css-easing/w3c-import.log: Renamed from LayoutTests/imported/w3c/web-platform-tests/css-timing-1/w3c-import.log.

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/resources/import-expectations.json


Added Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/META.yml
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/cubic-bezier-timing-functions-output-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/cubic-bezier-timing-functions-output.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/step-timing-functions-output.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/step-timing-functions-syntax-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/step-timing-functions-syntax.html
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/testcommon.js
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-easing/w3c-import.log


Removed Paths

trunk/LayoutTests/imported/w3c/web-platform-tests/css-timing-1/




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (255411 => 255412)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-01-30 02:59:28 UTC (rev 255411)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-01-30 03:27:41 UTC (rev 255412)
@@ -1,5 +1,32 @@
 2020-01-29  Carlos Alberto Lopez Perez  
 
+Update WPT tests for css-easing (previously known as css-timing)
+https://bugs.webkit.org/show_bug.cgi?id=206951
+
+Reviewed by Simon Fraser.
+
+Rename the directory and update WPT tests.
+
+* resources/import-expectations.json:
+* web-platform-tests/css-timing-1/OWNERS: Removed.
+* web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt: Removed.
+* web-platform-tests/css-timing-1/frames-timing-functions-output.html: Removed.
+* web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt: Removed.
+* web-platform-tests/css-timing-1/frames-timing-functions-syntax.html: Removed.
+* web-platform-tests/css-timing-1/step-timing-functions-output-expected.txt: Removed.
+* web-platform-tests/css-timing-1/step-timing-functions-output.html: Removed.
+* web-platform-tests/css/css-easing/META.yml: Added.
+* web-platform-tests/css/css-easing/cubic-bezier-timing-functions-output-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output-expected.txt.
+* web-platform-tests/css/css-easing/cubic-bezier-timing-functions-output.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css-timing-1/cubic-bezier-timing-functions-output.html.
+* web-platform-tests/css/css-easing/step-timing-functions-output-expected.txt: Added.
+* web-platform-tests/css/css-easing/step-timing-functions-output.html: Added.
+ 

[webkit-changes] [255411] trunk/LayoutTests

[justin_fan]

Title: [255411] trunk/LayoutTests








Revision 255411
Author justin_...@apple.com
Date 2020-01-29 18:59:28 -0800 (Wed, 29 Jan 2020)


Log Message
[WebGL] Skip ANGLE-dependent WebGL 2 expected progressions on WebGL bot
https://bugs.webkit.org/show_bug.cgi?id=206977

Unreviewed test gardening.

These tests are expected to progress with ANGLE enabled, but since ANGLE is not enabled,
expect failure for now.


* webgl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255410 => 255411)

--- trunk/LayoutTests/ChangeLog	2020-01-30 02:42:49 UTC (rev 255410)
+++ trunk/LayoutTests/ChangeLog	2020-01-30 02:59:28 UTC (rev 255411)
@@ -1,3 +1,15 @@
+2020-01-29  Justin Fan  
+
+[WebGL] Skip ANGLE-dependent WebGL 2 expected progressions on WebGL bot
+https://bugs.webkit.org/show_bug.cgi?id=206977
+
+Unreviewed test gardening.
+
+These tests are expected to progress with ANGLE enabled, but since ANGLE is not enabled,
+expect failure for now.
+
+* webgl/TestExpectations:
+
 2020-01-29  Ryan Haddad  
 
 imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is timing out on Mojave wk1 debug EWS


Modified: trunk/LayoutTests/webgl/TestExpectations (255410 => 255411)

--- trunk/LayoutTests/webgl/TestExpectations	2020-01-30 02:42:49 UTC (rev 255410)
+++ trunk/LayoutTests/webgl/TestExpectations	2020-01-30 02:59:28 UTC (rev 255411)
@@ -3,6 +3,11 @@
 # Currently skipped due to fetching external resources.
 webgl/1.0.3/conformance/more/functions [ Skip ]
 
+# Expected ANGLE-based 2.0.0 progressions; mark as "failing" until ANGLE re-enabled.
+webgl/2.0.0/conformance2/samplers [ Fail ]
+webgl/2.0.0/conformance2/transform_feedback [ Fail ]
+webgl/2.0.0/conformance2/textures/misc/tex-image-and-sub-image-with-array-buffer-view-sub-source.html [ Fail ]
+
 # Tests crashing
 webgl/2.0.0/conformance2/renderbuffers/framebuffer-object-attachment.html [ Skip ]
 webgl/2.0.0/conformance2/rendering/draw-buffers.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255409] tags/Safari-610.1.1.1.1/

[alancoon]

Title: [255409] tags/Safari-610.1.1.1.1/








Revision 255409
Author alanc...@apple.com
Date 2020-01-29 18:08:13 -0800 (Wed, 29 Jan 2020)


Log Message
Tag Safari-610.1.1.1.1.

Added Paths

tags/Safari-610.1.1.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255408] trunk/LayoutTests

[ryanhaddad]

Title: [255408] trunk/LayoutTests








Revision 255408
Author ryanhad...@apple.com
Date 2020-01-29 17:35:49 -0800 (Wed, 29 Jan 2020)


Log Message
imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is timing out on Mojave wk1 debug EWS
https://bugs.webkit.org/show_bug.cgi?id=206503

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations: Limit the failure expectation to debug bots.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255407 => 255408)

--- trunk/LayoutTests/ChangeLog	2020-01-30 01:16:02 UTC (rev 255407)
+++ trunk/LayoutTests/ChangeLog	2020-01-30 01:35:49 UTC (rev 255408)
@@ -1,3 +1,12 @@
+2020-01-29  Ryan Haddad  
+
+imported/w3c/web-platform-tests/html/dom/idlharness.worker.html is timing out on Mojave wk1 debug EWS
+https://bugs.webkit.org/show_bug.cgi?id=206503
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations: Limit the failure expectation to debug bots.
+
 2020-01-29  Jacob Uphoff  
 
 [ macOS wk1 ]http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-xslt-document-in-iframe-with-inherited-policy.html is flaky failing


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (255407 => 255408)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-30 01:16:02 UTC (rev 255407)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-30 01:35:49 UTC (rev 255408)
@@ -846,7 +846,7 @@
 
 webkit.org/b/199117 [ Debug ] storage/indexeddb/modern/objectstore-autoincrement-types.html [ Timeout ]
 
-webkit.org/b/206503 [ Mojave ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Failure ]
+webkit.org/b/206503 [ Mojave Debug ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Failure ]
 
 webkit.org/b/90980 fast/forms/textarea/textarea-state-restore.html [ Pass Failure Timeout ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255407] trunk/LayoutTests

[ryanhaddad]

Title: [255407] trunk/LayoutTests








Revision 255407
Author ryanhad...@apple.com
Date 2020-01-29 17:16:02 -0800 (Wed, 29 Jan 2020)


Log Message
[ macOS wk1 ]http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-xslt-document-in-iframe-with-inherited-policy.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206974

Unreviewed test gardening.

Patch by Jacob Uphoff  on 2020-01-29

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255406 => 255407)

--- trunk/LayoutTests/ChangeLog	2020-01-30 01:06:08 UTC (rev 255406)
+++ trunk/LayoutTests/ChangeLog	2020-01-30 01:16:02 UTC (rev 255407)
@@ -1,3 +1,12 @@
+2020-01-29  Jacob Uphoff  
+
+[ macOS wk1 ]http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-xslt-document-in-iframe-with-inherited-policy.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=206974
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2020-01-29  Ryan Haddad  
 
 REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (255406 => 255407)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-30 01:06:08 UTC (rev 255406)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-30 01:16:02 UTC (rev 255407)
@@ -863,3 +863,5 @@
 webkit.org/b/190830 [ Debug ] media/track/video-track-addition-and-frame-removal.html [ Pass Crash ]
 
 webkit.org/b/206945 [ Catalina ] compositing/repaint/become-overlay-composited-layer.html [ Pass Failure ]
+
+webkit.org/b/206974 http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-xslt-document-in-iframe-with-inherited-policy.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255406] trunk/Source

[rmorisset]

Title: [255406] trunk/Source








Revision 255406
Author rmoris...@apple.com
Date 2020-01-29 17:06:08 -0800 (Wed, 29 Jan 2020)


Log Message
Remove Options::enableSpectreMitigations
https://bugs.webkit.org/show_bug.cgi?id=193885

Reviewed by Saam Barati.

>From what I remember we decided to remove the spectre-specific mitigations we had tried (in favor of things like process-per-origin).
I don't think anyone is using the SpectreGadget we had added for experiments either.
So this patch removes the following three options, and all the code that depended on them:
- enableSpectreMitigations (was true, only used in one place)
- enableSpectreGadgets (was false)
- zeroStackFrame (was false, and was an experiment about Spectre variant 4 if I remember correctly)

Source/_javascript_Core:

* b3/air/AirCode.cpp:
(JSC::B3::Air::defaultPrologueGenerator):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
* jit/AssemblyHelpers.h:
* jit/JIT.cpp:
(JSC::JIT::compileWithoutLinking):
* runtime/OptionsList.h:
* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addCallIndirect):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::initCallFrame):

Source/WebCore:

No new tests as there is no new behaviour added.

* CMakeLists.txt:
* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* dom/SpectreGadget.cpp: Removed.
* dom/SpectreGadget.h: Removed.
* dom/SpectreGadget.idl: Removed.
* page/RuntimeEnabledFeatures.cpp:
* page/RuntimeEnabledFeatures.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/air/AirCode.cpp
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
trunk/Source/_javascript_Core/jit/JIT.cpp
trunk/Source/_javascript_Core/runtime/OptionsList.h
trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.cpp
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources-input.xcfilelist
trunk/Source/WebCore/DerivedSources-output.xcfilelist
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h
trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h


Removed Paths

trunk/Source/WebCore/dom/SpectreGadget.cpp
trunk/Source/WebCore/dom/SpectreGadget.h
trunk/Source/WebCore/dom/SpectreGadget.idl




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (255405 => 255406)

--- trunk/Source/_javascript_Core/ChangeLog	2020-01-30 01:02:17 UTC (rev 255405)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-30 01:06:08 UTC (rev 255406)
@@ -1,3 +1,35 @@
+2020-01-29  Robin Morisset  
+
+Remove Options::enableSpectreMitigations
+https://bugs.webkit.org/show_bug.cgi?id=193885
+
+Reviewed by Saam Barati.
+
+From what I remember we decided to remove the spectre-specific mitigations we had tried (in favor of things like process-per-origin).
+I don't think anyone is using the SpectreGadget we had added for experiments either.
+So this patch removes the following three options, and all the code that depended on them:
+- enableSpectreMitigations (was true, only used in one place)
+- enableSpectreGadgets (was false)
+- zeroStackFrame (was false, and was an experiment about Spectre variant 4 if I remember correctly)
+
+* b3/air/AirCode.cpp:
+(JSC::B3::Air::defaultPrologueGenerator):
+* dfg/DFGJITCompiler.cpp:
+(JSC::DFG::JITCompiler::compile):
+(JSC::DFG::JITCompiler::compileFunction):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::lower):
+* jit/AssemblyHelpers.h:
+* jit/JIT.cpp:
+(JSC::JIT::compileWithoutLinking):
+* runtime/OptionsList.h:
+* wasm/WasmB3IRGenerator.cpp:
+(JSC::Wasm::B3IRGenerator::addCallIndirect):
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::YarrGenerator::initCallFrame):
+
 2020-01-29  Devin Rousso  
 
 Web Inspector: add instrumentation for showing existing Web Animations


Modified: trunk/Source/_javascript_Core/b3/air/AirCode.cpp (255405 => 255406)

--- trunk/Source/_javascript_Core/b3/air/AirCode.cpp	2020-01-30 01:02:17 UTC (rev 255405)
+++ trunk/Source/_javascript_Core/b3/air/AirCode.cpp	2020-01-30 01:06:08 UTC (rev 255406)
@@ -46,8 +46,6 @@
 

[webkit-changes] [255405] trunk/LayoutTests

[ryanhaddad]

Title: [255405] trunk/LayoutTests








Revision 255405
Author ryanhad...@apple.com
Date 2020-01-29 17:02:17 -0800 (Wed, 29 Jan 2020)


Log Message
REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206839

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations: Mark test as flaky.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255404 => 255405)

--- trunk/LayoutTests/ChangeLog	2020-01-30 00:59:06 UTC (rev 255404)
+++ trunk/LayoutTests/ChangeLog	2020-01-30 01:02:17 UTC (rev 255405)
@@ -1,3 +1,12 @@
+2020-01-29  Ryan Haddad  
+
+REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=206839
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations: Mark test as flaky.
+
 2020-01-29  Jason Lawrence  
 
 [ iOS Release wk2 ] animations/change-one-anim.html flaky failing.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (255404 => 255405)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-30 00:59:06 UTC (rev 255404)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-30 01:02:17 UTC (rev 255405)
@@ -944,4 +944,6 @@
 
 webkit.org/b/206958 http/tests/media/media-stream/get-display-media-prompt.html [ Pass Failure Timeout ]
 
-webkit.org/b/206961 [ Mojave ] media/media-fragments/TC0035.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/206961 [ Mojave ] media/media-fragments/TC0035.html [ Pass Failure ]
+
+webkit.org/b/206839 http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255404] trunk/Tools

[jbedard]

Title: [255404] trunk/Tools








Revision 255404
Author jbed...@apple.com
Date 2020-01-29 16:59:06 -0800 (Wed, 29 Jan 2020)


Log Message
run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504)
https://bugs.webkit.org/show_bug.cgi?id=206932

Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.get_runtime_for_device_type): Request for a device running
some version will return a runtime of the same major version with a minor version
that is equal to or greater than the specified minor version.
* Scripts/webkitpy/xcode/simulated_device_unittest.py:
(test_matching_up_success):
(test_matching_up_failure):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py
trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (255403 => 255404)

--- trunk/Tools/ChangeLog	2020-01-30 00:34:48 UTC (rev 255403)
+++ trunk/Tools/ChangeLog	2020-01-30 00:59:06 UTC (rev 255404)
@@ -1,3 +1,18 @@
+2020-01-29  Jonathan Bedard  
+
+run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504)
+https://bugs.webkit.org/show_bug.cgi?id=206932
+
+Reviewed by Alexey Proskuryakov.
+
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager.get_runtime_for_device_type): Request for a device running
+some version will return a runtime of the same major version with a minor version
+that is equal to or greater than the specified minor version.
+* Scripts/webkitpy/xcode/simulated_device_unittest.py:
+(test_matching_up_success):
+(test_matching_up_failure):
+
 2020-01-28  Yusuke Suzuki  
 
 [JSC] Give up IC when unknown structure transition happens


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py (255403 => 255404)

--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py	2020-01-30 00:34:48 UTC (rev 255403)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py	2020-01-30 00:59:06 UTC (rev 255404)
@@ -203,16 +203,19 @@
 
 @staticmethod
 def get_runtime_for_device_type(device_type):
+# Search for an available runtime that best matches the provided device type
+candidate = None
 for runtime in SimulatedDeviceManager.AVAILABLE_RUNTIMES:
-if runtime.os_variant == device_type.software_variant and (device_type.software_version is None or device_type.software_version == runtime.version):
-return runtime
+if runtime.os_variant != device_type.software_variant:
+continue
+if device_type.software_version and runtime.version.major != device_type.software_version.major:
+continue
+if device_type.software_version and runtime.version < device_type.software_version:
+continue
+if not candidate or runtime.version < candidate.version:
+candidate = runtime
+return candidate
 
-# Allow for a partial version match.
-for runtime in SimulatedDeviceManager.AVAILABLE_RUNTIMES:
-if runtime.os_variant == device_type.software_variant and runtime.version in device_type.software_version:
-return runtime
-return None
-
 @staticmethod
 def _disambiguate_device_type(device_type):
 # Copy by value since we do not want to modify the DeviceType passed in.


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py (255403 => 255404)

--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py	2020-01-30 00:34:48 UTC (rev 255403)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device_unittest.py	2020-01-30 00:59:06 UTC (rev 255404)
@@ -626,6 +626,23 @@
 SimulatedDeviceManager.tear_down(host)
 self.assertIsNone(SimulatedDeviceManager.INITIALIZED_DEVICES)
 
+def test_matching_up_success(self):
+SimulatedDeviceTest.reset_simulated_device_manager()
+host = SimulatedDeviceTest.mock_host_for_simctl()
+SimulatedDeviceManager.available_devices(host)
+
+runtime = SimulatedDeviceManager.get_runtime_for_device_type(DeviceType.from_string('iphone 5s', Version(9, 2)))
+self.assertEquals(runtime.os_variant, 'iOS')
+self.assertEquals(runtime.version, Version(9, 3))
+
+def test_matching_up_failure(self):
+SimulatedDeviceTest.reset_simulated_device_manager()
+host = SimulatedDeviceTest.mock_host_for_simctl()
+SimulatedDeviceManager.available_devices(host)
+
+runtime = SimulatedDeviceManager.get_runtime_for_device_type(DeviceType.from_string('iphone 5s', Version(9, 4)))
+self.assertEquals(runtime, None)
+
 @staticmethod
 def change_state_to(device, state):
 assert isinstance(state, int)






___
webkit-changes mailing list

[webkit-changes] [255402] trunk/LayoutTests

[tsavell]

Title: [255402] trunk/LayoutTests








Revision 255402
Author tsav...@apple.com
Date 2020-01-29 16:26:56 -0800 (Wed, 29 Jan 2020)


Log Message
[ iOS Release wk2 ] animations/change-one-anim.html flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=206973

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-29

* platform/ios-simulator-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255401 => 255402)

--- trunk/LayoutTests/ChangeLog	2020-01-30 00:19:31 UTC (rev 255401)
+++ trunk/LayoutTests/ChangeLog	2020-01-30 00:26:56 UTC (rev 255402)
@@ -1,3 +1,12 @@
+2020-01-29  Jason Lawrence  
+
+[ iOS Release wk2 ] animations/change-one-anim.html flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206973
+
+Unreviewed test gardening.
+
+* platform/ios-simulator-wk2/TestExpectations:
+
 2020-01-29  Devin Rousso  
 
 Web Inspector: add instrumentation for showing existing Web Animations


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (255401 => 255402)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2020-01-30 00:19:31 UTC (rev 255401)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2020-01-30 00:26:56 UTC (rev 255402)
@@ -84,4 +84,6 @@
 
 webkit.org/b/206749 crypto/subtle/rsa-indexeddb-private.html [ Pass Timeout ]
 
-webkit.org/b/206751 http/tests/workers/service/service-worker-user-timing.https.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/206751 http/tests/workers/service/service-worker-user-timing.https.html [ Pass Timeout ]
+
+webkit.org/b/206973 animations/change-one-anim.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255400] trunk/Source/WebCore

[sihui_liu]

Title: [255400] trunk/Source/WebCore








Revision 255400
Author sihui_...@apple.com
Date 2020-01-29 16:11:30 -0800 (Wed, 29 Jan 2020)


Log Message
Set QoS of blobUtilityQueue to be Utility
https://bugs.webkit.org/show_bug.cgi?id=206971

Reviewed by Chris Dumez.

* platform/network/BlobRegistryImpl.cpp:
(WebCore::blobUtilityQueue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (255399 => 255400)

--- trunk/Source/WebCore/ChangeLog	2020-01-30 00:09:07 UTC (rev 255399)
+++ trunk/Source/WebCore/ChangeLog	2020-01-30 00:11:30 UTC (rev 255400)
@@ -1,3 +1,13 @@
+2020-01-29  Sihui Liu  
+
+Set QoS of blobUtilityQueue to be Utility
+https://bugs.webkit.org/show_bug.cgi?id=206971
+
+Reviewed by Chris Dumez.
+
+* platform/network/BlobRegistryImpl.cpp:
+(WebCore::blobUtilityQueue):
+
 2020-01-29  Devin Rousso  
 
 Web Inspector: add instrumentation for showing existing Web Animations


Modified: trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp (255399 => 255400)

--- trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp	2020-01-30 00:09:07 UTC (rev 255399)
+++ trunk/Source/WebCore/platform/network/BlobRegistryImpl.cpp	2020-01-30 00:11:30 UTC (rev 255400)
@@ -242,7 +242,7 @@
 
 static WorkQueue& blobUtilityQueue()
 {
-static auto& queue = WorkQueue::create("org.webkit.BlobUtility", WorkQueue::Type::Serial, WorkQueue::QOS::Background).leakRef();
+static auto& queue = WorkQueue::create("org.webkit.BlobUtility", WorkQueue::Type::Serial, WorkQueue::QOS::Utility).leakRef();
 return queue;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255399] branches/safari-610.1.1.1-branch/Source

[repstein]

Title: [255399] branches/safari-610.1.1.1-branch/Source








Revision 255399
Author repst...@apple.com
Date 2020-01-29 16:09:07 -0800 (Wed, 29 Jan 2020)


Log Message
Versioning.

Modified Paths

branches/safari-610.1.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.1.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.1.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.1.1.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.1.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.1.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.1.1.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.1.1.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.1.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (255398 => 255399)

--- branches/safari-610.1.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-30 00:02:35 UTC (rev 255398)
+++ branches/safari-610.1.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-30 00:09:07 UTC (rev 255399)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-610.1.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (255398 => 255399)

--- branches/safari-610.1.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-01-30 00:02:35 UTC (rev 255398)
+++ branches/safari-610.1.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-01-30 00:09:07 UTC (rev 255399)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-610.1.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (255398 => 255399)

--- branches/safari-610.1.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-30 00:02:35 UTC (rev 255398)
+++ branches/safari-610.1.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-30 00:09:07 UTC (rev 255399)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-610.1.1.1-branch/Source/WebCore/Configurations/Version.xcconfig (255398 => 255399)

--- branches/safari-610.1.1.1-branch/Source/WebCore/Configurations/Version.xcconfig	2020-01-30 00:02:35 UTC (rev 255398)
+++ branches/safari-610.1.1.1-branch/Source/WebCore/Configurations/Version.xcconfig	2020-01-30 00:09:07 UTC (rev 255399)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-610.1.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (255398 => 255399)

--- branches/safari-610.1.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-30 00:02:35 UTC (rev 255398)
+++ branches/safari-610.1.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-30 00:09:07 UTC (rev 255399)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
 MICRO_VERSION = 1;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the 

[webkit-changes] [255397] branches/safari-610.1.1.1-branch/

[alancoon]

Title: [255397] branches/safari-610.1.1.1-branch/








Revision 255397
Author alanc...@apple.com
Date 2020-01-29 15:56:49 -0800 (Wed, 29 Jan 2020)


Log Message
New branch.

Added Paths

branches/safari-610.1.1.1-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255395] branches/safari-609-branch/Source

[repstein]

Title: [255395] branches/safari-609-branch/Source








Revision 255395
Author repst...@apple.com
Date 2020-01-29 15:44:56 -0800 (Wed, 29 Jan 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609-branch/Source/_javascript_Core/Configurations/Version.xcconfig (255394 => 255395)

--- branches/safari-609-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-29 23:35:32 UTC (rev 255394)
+++ branches/safari-609-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-01-29 23:44:56 UTC (rev 255395)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (255394 => 255395)

--- branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-01-29 23:35:32 UTC (rev 255394)
+++ branches/safari-609-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-01-29 23:44:56 UTC (rev 255395)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (255394 => 255395)

--- branches/safari-609-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-29 23:35:32 UTC (rev 255394)
+++ branches/safari-609-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-01-29 23:44:56 UTC (rev 255395)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebCore/Configurations/Version.xcconfig (255394 => 255395)

--- branches/safari-609-branch/Source/WebCore/Configurations/Version.xcconfig	2020-01-29 23:35:32 UTC (rev 255394)
+++ branches/safari-609-branch/Source/WebCore/Configurations/Version.xcconfig	2020-01-29 23:44:56 UTC (rev 255395)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (255394 => 255395)

--- branches/safari-609-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-29 23:35:32 UTC (rev 255394)
+++ branches/safari-609-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-01-29 23:44:56 UTC (rev 255395)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (255394 => 255395)

--- branches/safari-609-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-01-29 23:35:32 UTC (rev 255394)
+++ branches/safari-609-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-01-29 23:44:56 UTC (rev 255395)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebKit/Configurations/Version.xcconfig (255394 => 255395)

--- branches/safari-609-branch/Source/WebKit/Configurations/Version.xcconfig	2020-01-29 23:35:32 UTC (rev 255394)
+++ branches/safari-609-branch/Source/WebKit/Configurations/Version.xcconfig	2020-01-29 23:44:56 UTC (rev 255395)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
-TINY_VERSION = 15;
+TINY_VERSION = 16;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-609-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (255394 => 255395)

--- branches/safari-609-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2020-01-29 23:35:32 UTC 

[webkit-changes] [255394] trunk/Source/JavaScriptCore

[rmorisset]

Title: [255394] trunk/Source/_javascript_Core








Revision 255394
Author rmoris...@apple.com
Date 2020-01-29 15:35:32 -0800 (Wed, 29 Jan 2020)


Log Message
Don't include CCallHelpers.h in B3Procedure.h
https://bugs.webkit.org/show_bug.cgi?id=206966

Reviewed by Saam Barati.

I verified through -ftime-trace and it massively speeds up a few of the compilation units (e.g. UnifiedSource10.cpp).

* b3/B3Procedure.cpp:
* b3/B3Procedure.h:
* b3/testb3_6.cpp:
(testEntrySwitchSimple):
(testEntrySwitchNoEntrySwitch):
(testEntrySwitchWithCommonPaths):
(testEntrySwitchWithCommonPathsAndNonTrivialEntrypoint):
(testEntrySwitchLoop):
* ftl/FTLCompile.cpp:
(JSC::FTL::compile):
* wasm/WasmParser.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3Procedure.cpp
trunk/Source/_javascript_Core/b3/B3Procedure.h
trunk/Source/_javascript_Core/b3/testb3_6.cpp
trunk/Source/_javascript_Core/ftl/FTLCompile.cpp
trunk/Source/_javascript_Core/wasm/WasmParser.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (255393 => 255394)

--- trunk/Source/_javascript_Core/ChangeLog	2020-01-29 23:14:36 UTC (rev 255393)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-29 23:35:32 UTC (rev 255394)
@@ -1,3 +1,24 @@
+2020-01-29  Robin Morisset  
+
+Don't include CCallHelpers.h in B3Procedure.h
+https://bugs.webkit.org/show_bug.cgi?id=206966
+
+Reviewed by Saam Barati.
+
+I verified through -ftime-trace and it massively speeds up a few of the compilation units (e.g. UnifiedSource10.cpp).
+
+* b3/B3Procedure.cpp:
+* b3/B3Procedure.h:
+* b3/testb3_6.cpp:
+(testEntrySwitchSimple):
+(testEntrySwitchNoEntrySwitch):
+(testEntrySwitchWithCommonPaths):
+(testEntrySwitchWithCommonPathsAndNonTrivialEntrypoint):
+(testEntrySwitchLoop):
+* ftl/FTLCompile.cpp:
+(JSC::FTL::compile):
+* wasm/WasmParser.h:
+
 2020-01-29  Justin Michaud  
 
 Fix small memory regression caused by r206365


Modified: trunk/Source/_javascript_Core/b3/B3Procedure.cpp (255393 => 255394)

--- trunk/Source/_javascript_Core/b3/B3Procedure.cpp	2020-01-29 23:14:36 UTC (rev 255393)
+++ trunk/Source/_javascript_Core/b3/B3Procedure.cpp	2020-01-29 23:35:32 UTC (rev 255394)
@@ -349,11 +349,6 @@
 return m_fastConstants.contains(constant);
 }
 
-CCallHelpers::Label Procedure::entrypointLabel(unsigned index) const
-{
-return m_code->entrypointLabel(index);
-}
-
 void* Procedure::addDataSection(size_t size)
 {
 if (!size)


Modified: trunk/Source/_javascript_Core/b3/B3Procedure.h (255393 => 255394)

--- trunk/Source/_javascript_Core/b3/B3Procedure.h	2020-01-29 23:14:36 UTC (rev 255393)
+++ trunk/Source/_javascript_Core/b3/B3Procedure.h	2020-01-29 23:35:32 UTC (rev 255394)
@@ -33,7 +33,6 @@
 #include "B3SparseCollection.h"
 #include "B3Type.h"
 #include "B3ValueKey.h"
-#include "CCallHelpers.h"
 #include "PureNaN.h"
 #include "RegisterAtOffsetList.h"
 #include 
@@ -46,8 +45,12 @@
 #include 
 #include 
 
-namespace JSC { namespace B3 {
+namespace JSC {
 
+class CCallHelpers;
+
+namespace B3 {
+
 class BackwardsCFG;
 class BackwardsDominators;
 class BasicBlock;
@@ -197,11 +200,6 @@
 unsigned numEntrypoints() const { return m_numEntrypoints; }
 JS_EXPORT_PRIVATE void setNumEntrypoints(unsigned);
 
-// Only call this after code generation is complete. Note that the label for the 0th entrypoint
-// should point to exactly where the code generation cursor was before you started generating
-// code.
-JS_EXPORT_PRIVATE CCallHelpers::Label entrypointLabel(unsigned entrypointIndex) const;
-
 // The name has to be a string literal, since we don't do any memory management for the string.
 void setLastPhaseName(const char* name)
 {


Modified: trunk/Source/_javascript_Core/b3/testb3_6.cpp (255393 => 255394)

--- trunk/Source/_javascript_Core/b3/testb3_6.cpp	2020-01-29 23:14:36 UTC (rev 255393)
+++ trunk/Source/_javascript_Core/b3/testb3_6.cpp	2020-01-29 23:35:32 UTC (rev 255394)
@@ -1936,9 +1936,9 @@
 CCallHelpers jit;
 generate(proc, jit);
 LinkBuffer linkBuffer(jit, nullptr);
-CodeLocationLabel labelOne = linkBuffer.locationOf(proc.entrypointLabel(0));
-CodeLocationLabel labelTwo = linkBuffer.locationOf(proc.entrypointLabel(1));
-CodeLocationLabel labelThree = linkBuffer.locationOf(proc.entrypointLabel(2));
+CodeLocationLabel labelOne = linkBuffer.locationOf(proc.code().entrypointLabel(0));
+CodeLocationLabel labelTwo = linkBuffer.locationOf(proc.code().entrypointLabel(1));
+CodeLocationLabel labelThree = linkBuffer.locationOf(proc.code().entrypointLabel(2));
 
 MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, B3CompilationPtrTag, "testb3 compilation");
 
@@ -1969,9 +1969,9 @@
 CCallHelpers jit;
 generate(proc, jit);
 LinkBuffer linkBuffer(jit, nullptr);
-CodeLocationLabel labelOne = 

[webkit-changes] [255393] trunk/LayoutTests

[tsavell]

Title: [255393] trunk/LayoutTests








Revision 255393
Author tsav...@apple.com
Date 2020-01-29 15:14:36 -0800 (Wed, 29 Jan 2020)


Log Message
REGRESSION: [ iOS ] scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205309

Unreviewed test gardening.

Adjusted test expectations for an existing bug.

Patch by Jason Lawrence  on 2020-01-29

* platform/ios-wk2/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255392 => 255393)

--- trunk/LayoutTests/ChangeLog	2020-01-29 23:14:06 UTC (rev 255392)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 23:14:36 UTC (rev 255393)
@@ -1,3 +1,15 @@
+2020-01-29  Jason Lawrence  
+
+REGRESSION: [ iOS ] scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205309
+
+Unreviewed test gardening.
+
+Adjusted test expectations for an existing bug.
+
+* platform/ios-wk2/TestExpectations:
+* platform/ios/TestExpectations:
+
 2020-01-29  Diego Pino Garcia  
 
 [GTK] Gardening, expected to fail but passing


Modified: trunk/LayoutTests/platform/ios/TestExpectations (255392 => 255393)

--- trunk/LayoutTests/platform/ios/TestExpectations	2020-01-29 23:14:06 UTC (rev 255392)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-01-29 23:14:36 UTC (rev 255393)
@@ -3455,8 +3455,6 @@
 
 webkit.org/b/204757 imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html [ Pass Failure ]
 
-webkit.org/b/205309 scrollingcoordinator/ios/scroll-position-after-reattach.html [ ImageOnlyFailure ]
-
 webkit.org/b/200043 fast/text/international/system-language/navigator-language [ Pass Failure ]
 
 webkit.org/b/203222 svg/wicd/rightsizing-grid.xhtml [ Pass Failure ]


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (255392 => 255393)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-01-29 23:14:06 UTC (rev 255392)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-01-29 23:14:36 UTC (rev 255393)
@@ -1364,4 +1364,6 @@
 webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]
 
 webkit.org/b/206946 http/tests/security/cookies/third-party-cookie-blocking-main-frame.html [ Pass Timeout ]
-webkit.org/b/206965 storage/indexeddb/intversion-long-queue-private.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/206965 storage/indexeddb/intversion-long-queue-private.html [ Pass Failure ]
+
+webkit.org/b/205309 scrollingcoordinator/ios/scroll-position-after-reattach.html [ ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255391] trunk/Source/WebCore

[ross . kirsling]

Title: [255391] trunk/Source/WebCore








Revision 255391
Author ross.kirsl...@sony.com
Date 2020-01-29 15:09:51 -0800 (Wed, 29 Jan 2020)


Log Message
[PlayStation] Fix MIMETypeRegistry
https://bugs.webkit.org/show_bug.cgi?id=206960

Reviewed by Don Olmstead.

* platform/playstation/MIMETypeRegistryPlayStation.cpp:
(WebCore::platformMediaTypes):
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
Address redeclarations, then fix key/value order of platform-specific MIME type map and make it a static local.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (255390 => 255391)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 23:02:28 UTC (rev 255390)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 23:09:51 UTC (rev 255391)
@@ -1,3 +1,16 @@
+2020-01-29  Ross Kirsling  
+
+[PlayStation] Fix MIMETypeRegistry
+https://bugs.webkit.org/show_bug.cgi?id=206960
+
+Reviewed by Don Olmstead.
+
+* platform/playstation/MIMETypeRegistryPlayStation.cpp:
+(WebCore::platformMediaTypes):
+(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
+(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
+Address redeclarations, then fix key/value order of platform-specific MIME type map and make it a static local.
+
 2020-01-29  Ryan Haddad  
 
 Unreviewed, rolling out r255338.


Modified: trunk/Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp (255390 => 255391)

--- trunk/Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp	2020-01-29 23:02:28 UTC (rev 255390)
+++ trunk/Source/WebCore/platform/playstation/MIMETypeRegistryPlayStation.cpp	2020-01-29 23:09:51 UTC (rev 255391)
@@ -28,39 +28,38 @@
 
 namespace WebCore {
 
-struct TypeExtensionPair {
-ASCIILiteral type;
-ASCIILiteral extension;
-};
+static const std::initializer_list& platformMediaTypes()
+{
+static std::initializer_list platformMediaTypes = {
+{ "image/bmp"_s, "bmp"_s },
+{ "text/css"_s, "css"_s },
+{ "image/gif"_s, "gif"_s },
+{ "text/html"_s, "htm"_s },
+{ "text/html"_s, "html"_s },
+{ "image/x-icon"_s, "ico"_s },
+{ "image/jpeg"_s, "jpeg"_s },
+{ "image/jpeg"_s, "jpg"_s },
+{ "application/x-_javascript_"_s, "js"_s },
+{ "application/pdf"_s, "pdf"_s },
+{ "image/png"_s, "png"_s },
+{ "application/rss+xml"_s, "rss"_s },
+{ "image/svg+xml"_s, "svg"_s },
+{ "application/x-shockwave-flash"_s, "swf"_s },
+{ "text/plain"_s, "text"_s },
+{ "text/plain"_s, "txt"_s },
+{ "text/vnd.wap.wml"_s, "wml"_s },
+{ "application/vnd.wap.wmlc"_s, "wmlc"_s },
+{ "image/x-xbitmap"_s, "xbm"_s },
+{ "application/xhtml+xml"_s, "xhtml"_s },
+{ "text/xml"_s, "xml"_s },
+{ "text/xsl"_s, "xsl"_s },
+};
+return platformMediaTypes;
+}
 
-const TypeExtensionPair commonMediaTypes[] = {
-{ "bmp"_s, "image/bmp"_s },
-{ "css"_s, "text/css"_s },
-{ "gif"_s, "image/gif"_s },
-{ "html"_s, "text/html"_s },
-{ "htm"_s, "text/html"_s },
-{ "ico"_s, "image/x-icon"_s },
-{ "jpeg"_s, "image/jpeg"_s },
-{ "jpg"_s, "image/jpeg"_s },
-{ "js"_s, "application/x-_javascript_"_s },
-{ "pdf"_s, "application/pdf"_s },
-{ "png"_s, "image/png"_s },
-{ "rss"_s, "application/rss+xml"_s },
-{ "svg"_s, "image/svg+xml"_s },
-{ "swf"_s, "application/x-shockwave-flash"_s },
-{ "text"_s, "text/plain"_s },
-{ "txt"_s, "text/plain"_s },
-{ "xbm"_s, "image/x-xbitmap"_s },
-{ "xml"_s, "text/xml"_s },
-{ "xsl"_s, "text/xsl"_s },
-{ "xhtml"_s, "application/xhtml+xml"_s },
-{ "wml"_s, "text/vnd.wap.wml"_s },
-{ "wmlc"_s, "application/vnd.wap.wmlc"_s },
-};
-
 String MIMETypeRegistry::getMIMETypeForExtension(const String& extension)
 {
-for (auto& entry : commonMediaTypes) {
+for (auto& entry : platformMediaTypes()) {
 if (equalIgnoringASCIICase(extension, entry.extension.characters()))
 return entry.type;
 }
@@ -74,7 +73,7 @@
 
 String MIMETypeRegistry::getPreferredExtensionForMIMEType(const String& mimeType)
 {
-for (auto& entry : commonMediaTypes) {
+for (auto& entry : platformMediaTypes()) {
 if (equalIgnoringASCIICase(mimeType, entry.type.characters()))
 return entry.extension;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255390] trunk/JSTests

[ysuzuki]

Title: [255390] trunk/JSTests








Revision 255390
Author ysuz...@apple.com
Date 2020-01-29 15:02:28 -0800 (Wed, 29 Jan 2020)


Log Message
Unreviewed, update tests
https://bugs.webkit.org/show_bug.cgi?id=206846

* stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-debug.js: Copied from JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js.
(shouldBe):
(putter):
(not_string.toString):
* stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js:
* stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js: Copied from JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js.
(shouldBe):
(dictionary):
(putter):
(not_string.toString):
* stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js
trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js


Added Paths

trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-debug.js
trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js




Diff

Modified: trunk/JSTests/ChangeLog (255389 => 255390)

--- trunk/JSTests/ChangeLog	2020-01-29 22:51:11 UTC (rev 255389)
+++ trunk/JSTests/ChangeLog	2020-01-29 23:02:28 UTC (rev 255390)
@@ -1,3 +1,20 @@
+2020-01-29  Yusuke Suzuki  
+
+Unreviewed, update tests
+https://bugs.webkit.org/show_bug.cgi?id=206846
+
+* stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-debug.js: Copied from JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js.
+(shouldBe):
+(putter):
+(not_string.toString):
+* stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js:
+* stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js: Copied from JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js.
+(shouldBe):
+(dictionary):
+(putter):
+(not_string.toString):
+* stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js:
+
 2020-01-28  Yusuke Suzuki  
 
 [JSC] Give up IC when unknown structure transition happens


Copied: trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-debug.js (from rev 255385, trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js) (0 => 255390)

--- trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-debug.js	(rev 0)
+++ trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-debug.js	2020-01-29 23:02:28 UTC (rev 255390)
@@ -0,0 +1,28 @@
+//@ skip if $buildType != "debug"
+//@ crash!
+//@ runDefault("--useLLInt=true")
+
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+var putter = function(o) {
+o._unsupported = not_string;
+}
+
+var object;
+var counter = 0;
+var not_string = {
+toString() {
+counter++;
+object.ok = 42;
+return "Hey";
+}
+};
+
+for (var i = 0; i < 1000; ++i) {
+object = $vm.createObjectDoingSideEffectPutWithoutCorrectSlotStatus();
+putter(object);
+}
+shouldBe(counter, 1000);


Modified: trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js (255389 => 255390)

--- trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js	2020-01-29 22:51:11 UTC (rev 255389)
+++ trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js	2020-01-29 23:02:28 UTC (rev 255390)
@@ -1,3 +1,5 @@
+//@ skip if $buildType == "debug"
+
 function shouldBe(actual, expected) {
 if (actual !== expected)
 throw new Error('bad value: ' + actual);


Copied: trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js (from rev 255385, trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js) (0 => 255390)

--- trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js	(rev 0)
+++ trunk/JSTests/stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten-debug.js	2020-01-29 23:02:28 UTC (rev 255390)
@@ -0,0 +1,35 @@
+//@ skip if $buildType != "debug"
+//@ crash!
+//@ runDefault("--useLLInt=true")
+
+function shouldBe(actual, expected) {
+if (actual !== expected)
+throw new Error('bad value: ' + actual);
+}
+
+function 

[webkit-changes] [255388] trunk/Source/WebCore

[ryanhaddad]

Title: [255388] trunk/Source/WebCore








Revision 255388
Author ryanhad...@apple.com
Date 2020-01-29 14:49:17 -0800 (Wed, 29 Jan 2020)


Log Message
Unreviewed, rolling out r255338.

Introduced flakiness in multiple throttling layout tests

Reverted changeset:

"REGRESSION (r255158): http/tests/frame-throttling/raf-
throttle-in-cross-origin-subframe.html is a flaky failure"
https://bugs.webkit.org/show_bug.cgi?id=206839
https://trac.webkit.org/changeset/255338

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptedAnimationController.cpp
trunk/Source/WebCore/dom/ScriptedAnimationController.h
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/page/Settings.yaml
trunk/Source/WebCore/page/SettingsBase.cpp
trunk/Source/WebCore/page/SettingsBase.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (255387 => 255388)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 22:39:33 UTC (rev 255387)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 22:49:17 UTC (rev 255388)
@@ -1,3 +1,16 @@
+2020-01-29  Ryan Haddad  
+
+Unreviewed, rolling out r255338.
+
+Introduced flakiness in multiple throttling layout tests
+
+Reverted changeset:
+
+"REGRESSION (r255158): http/tests/frame-throttling/raf-
+throttle-in-cross-origin-subframe.html is a flaky failure"
+https://bugs.webkit.org/show_bug.cgi?id=206839
+https://trac.webkit.org/changeset/255338
+
 2020-01-28  Antoine Quint  
 
 [Web Animations] Animations should run accelerated even if other animations targeting the same element are not accelerated


Modified: trunk/Source/WebCore/dom/ScriptedAnimationController.cpp (255387 => 255388)

--- trunk/Source/WebCore/dom/ScriptedAnimationController.cpp	2020-01-29 22:39:33 UTC (rev 255387)
+++ trunk/Source/WebCore/dom/ScriptedAnimationController.cpp	2020-01-29 22:49:17 UTC (rev 255388)
@@ -52,6 +52,13 @@
 return m_document ? m_document->page() : nullptr;
 }
 
+Seconds ScriptedAnimationController::preferredScriptedAnimationInterval() const
+{
+if (auto* page = this->page())
+return page->renderingUpdateThrottlingEnabled() ? preferredFrameInterval(m_throttlingReasons) : FullSpeedAnimationInterval;
+return FullSpeedAnimationInterval;
+}
+
 Seconds ScriptedAnimationController::interval() const
 {
 if (auto* page = this->page())
@@ -75,35 +82,10 @@
 scheduleAnimation();
 }
 
-void ScriptedAnimationController::addThrottlingReason(ThrottlingReason reason)
-{
-if (auto* page = this->page()) {
-if (!page->canUpdateThrottlingReason(reason))
-return;
-}
-m_throttlingReasons.add(reason);
-}
-
-void ScriptedAnimationController::removeThrottlingReason(ThrottlingReason reason)
-{
-if (auto* page = this->page()) {
-if (!page->canUpdateThrottlingReason(reason))
-return;
-}
-m_throttlingReasons.remove(reason);
-}
-
-void ScriptedAnimationController::clearThrottlingReasons()
-{
-m_throttlingReasons = { };
-}
-
 bool ScriptedAnimationController::isThrottled() const
 {
-if (!m_throttlingReasons.isEmpty())
-return true;
 if (auto* page = this->page())
-return page->isRenderingUpdateThrottled();
+return page->renderingUpdateThrottlingEnabled() && (page->isRenderingUpdateThrottled() || !m_throttlingReasons.isEmpty());
 return false;
 }
 


Modified: trunk/Source/WebCore/dom/ScriptedAnimationController.h (255387 => 255388)

--- trunk/Source/WebCore/dom/ScriptedAnimationController.h	2020-01-29 22:39:33 UTC (rev 255387)
+++ trunk/Source/WebCore/dom/ScriptedAnimationController.h	2020-01-29 22:49:17 UTC (rev 255388)
@@ -61,9 +61,8 @@
 void suspend();
 void resume();
 
-void addThrottlingReason(ThrottlingReason);
-void removeThrottlingReason(ThrottlingReason);
-void clearThrottlingReasons();
+void addThrottlingReason(ThrottlingReason reason) { m_throttlingReasons.add(reason); }
+void removeThrottlingReason(ThrottlingReason reason) { m_throttlingReasons.remove(reason); }
 WEBCORE_EXPORT bool isThrottled() const;
 
 private:
@@ -70,7 +69,7 @@
 ScriptedAnimationController(Document&);
 
 Page* page() const;
-Seconds preferredScriptedAnimationInterval() const { return preferredFrameInterval(m_throttlingReasons); }
+Seconds preferredScriptedAnimationInterval() const;
 bool isThrottledRelativeToPage() const;
 bool shouldRescheduleRequestAnimationFrame(DOMHighResTimeStamp) const;
 void scheduleAnimation();


Modified: trunk/Source/WebCore/page/Page.cpp (255387 => 255388)

--- trunk/Source/WebCore/page/Page.cpp	2020-01-29 22:39:33 UTC (rev 255387)
+++ trunk/Source/WebCore/page/Page.cpp	2020-01-29 22:49:17 UTC (rev 255388)
@@ -335,9 +335,6 @@
 m_corsDisablingPatterns.uncheckedAppend(WTFMove(parsedPattern));
 }
 m_corsDisablingPatterns.shrinkToFit();
-
-if (m_lowPowerModeNotifier->isLowPowerModeEnabled())
-

[webkit-changes] [255387] trunk

[commit-queue]

Title: [255387] trunk








Revision 255387
Author commit-qu...@webkit.org
Date 2020-01-29 14:39:33 -0800 (Wed, 29 Jan 2020)


Log Message
Unreviewed, rolling out r254379.
https://bugs.webkit.org/show_bug.cgi?id=206969

Introduced media regressions (Requested by perarne on
#webkit).

Reverted changeset:

"[iOS] Remove used media-related mach services from the
WebContent process sandbox"
https://bugs.webkit.org/show_bug.cgi?id=206089
https://trac.webkit.org/changeset/254379

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: trunk/LayoutTests/ChangeLog (255386 => 255387)

--- trunk/LayoutTests/ChangeLog	2020-01-29 22:38:35 UTC (rev 255386)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 22:39:33 UTC (rev 255387)
@@ -1,3 +1,18 @@
+2020-01-29  Commit Queue  
+
+Unreviewed, rolling out r254379.
+https://bugs.webkit.org/show_bug.cgi?id=206969
+
+Introduced media regressions (Requested by perarne on
+#webkit).
+
+Reverted changeset:
+
+"[iOS] Remove used media-related mach services from the
+WebContent process sandbox"
+https://bugs.webkit.org/show_bug.cgi?id=206089
+https://trac.webkit.org/changeset/254379
+
 2020-01-29  Per Arne Vollan  
 
 [iOS] Deny mach lookup access to aggregate service


Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (255386 => 255387)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-01-29 22:38:35 UTC (rev 255386)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-01-29 22:39:33 UTC (rev 255387)
@@ -8,10 +8,6 @@
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.TextInput") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.awdd") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.cookied") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.cpeprotector.xpc") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.figcontentkeysession.xpc") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.routingsessionmanager.xpc") is false
-PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.coremedia.sts") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.iohideventsystem") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.locationd.registration") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.nehelper") is false


Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (255386 => 255387)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-01-29 22:38:35 UTC (rev 255386)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-01-29 22:39:33 UTC (rev 255387)
@@ -11,10 +11,6 @@
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.TextInput\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.awdd\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.cookied\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.cpeprotector.xpc\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.figcontentkeysession.xpc\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.routingsessionmanager.xpc\")");
-shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.coremedia.sts\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.iohideventsystem\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.locationd.registration\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.nehelper\")");


Modified: trunk/Source/WebKit/ChangeLog (255386 => 255387)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 22:38:35 UTC (rev 255386)
+++ trunk/Source/WebKit/ChangeLog	

[webkit-changes] [255386] trunk

[pvollan]

Title: [255386] trunk








Revision 255386
Author pvol...@apple.com
Date 2020-01-29 14:38:35 -0800 (Wed, 29 Jan 2020)


Log Message
[iOS] Deny mach lookup access to aggregate service
https://bugs.webkit.org/show_bug.cgi?id=206710


Reviewed by Darin Adler.

Source/WebKit:

Tighten sandbox by denying access to this service.

Test: fast/sandbox/ios/sandbox-mach-lookup.html

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
* fast/sandbox/ios/sandbox-mach-lookup.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: trunk/LayoutTests/ChangeLog (255385 => 255386)

--- trunk/LayoutTests/ChangeLog	2020-01-29 22:22:43 UTC (rev 255385)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 22:38:35 UTC (rev 255386)
@@ -1,3 +1,14 @@
+2020-01-29  Per Arne Vollan  
+
+[iOS] Deny mach lookup access to aggregate service
+https://bugs.webkit.org/show_bug.cgi?id=206710
+
+
+Reviewed by Darin Adler.
+
+* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
+* fast/sandbox/ios/sandbox-mach-lookup.html:
+
 2020-01-29  Wenson Hsieh  
 
 [iPadOS] Select popovers on amazon.com sometimes dismiss immediately after appearing


Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (255385 => 255386)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-01-29 22:22:43 UTC (rev 255385)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-01-29 22:38:35 UTC (rev 255386)
@@ -20,4 +20,5 @@
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.pluginkit.pkd") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.powerlog.plxpclogger.xpc") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.system.logger") is false
+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.aggregated") is false
 


Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (255385 => 255386)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-01-29 22:22:43 UTC (rev 255385)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-01-29 22:38:35 UTC (rev 255386)
@@ -23,6 +23,7 @@
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.pluginkit.pkd\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.powerlog.plxpclogger.xpc\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.system.logger\")");
+shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.aggregated\")");
 }
 
 


Modified: trunk/Source/WebKit/ChangeLog (255385 => 255386)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 22:22:43 UTC (rev 255385)
+++ trunk/Source/WebKit/ChangeLog	2020-01-29 22:38:35 UTC (rev 255386)
@@ -1,3 +1,17 @@
+2020-01-29  Per Arne Vollan  
+
+[iOS] Deny mach lookup access to aggregate service
+https://bugs.webkit.org/show_bug.cgi?id=206710
+
+
+Reviewed by Darin Adler.
+
+Tighten sandbox by denying access to this service.
+
+Test: fast/sandbox/ios/sandbox-mach-lookup.html
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-01-29  Wenson Hsieh  
 
 [iPadOS] Select popovers on amazon.com sometimes dismiss immediately after appearing


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (255385 => 255386)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-01-29 22:22:43 UTC (rev 255385)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-01-29 22:38:35 UTC (rev 255386)
@@ -595,7 +595,6 @@
 (global-name "com.apple.cfprefsd.daemon"))
 
 (allow mach-lookup (with report) (with telemetry)
-(global-name "com.apple.aggregated")
 (global-name "com.apple.distributed_notifications@1v3")
 (global-name "com.apple.tccd"))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255385] trunk

[wenson_hsieh]

Title: [255385] trunk








Revision 255385
Author wenson_hs...@apple.com
Date 2020-01-29 14:22:43 -0800 (Wed, 29 Jan 2020)


Log Message
[iPadOS] Select popovers on amazon.com sometimes dismiss immediately after appearing
https://bugs.webkit.org/show_bug.cgi?id=206948


Reviewed by Tim Horton.

Source/WebKit:

Amazon adds active touchstart event listeners to their select elements, where they call preventDefault() and
programmatically focus the select element. Doing so prevents clicks from being dispatched by allowing the web
touch event gesture to recognize instead of the synthetic click gesture, which (inside -_singleTapRecognized:)
would otherwise dismiss any currently presented popover.

After making touchstart events dispatch asynchronously, preventing touchstart no longer causes other native
gestures (such as the synthetic click gesture) to fail in the case where there is a sync touchmove or touchend
event listener, and the touch gesture has ended before the touchstart handler has finished executing and told
the UI process whether or not the touch was handled. This is because the touchend or touchmove is dispatched
synchronously while the touchstart is still being processed; while the web page sees the correct order of
events, the UI process will end up learning that the synchronous touch was handled before the response to the
asynchronously dispatched touchstart event has arrived.

Our current logic in the sync touch event dispatch case then unconditionally ends gesture deferral by calling
`doneDeferringNativeGestures` with `handled` equal to whether or not the touch event (a "touchend", in this
case) had been handled. However, in the case where touchstart event is prevented but the touchend event is not,
this will cause us to prematurely stop deferring gestures even though the page called `preventDefault()` in the
touchstart event handler, and allow the synthetic click gesture to recognize when it shouldn't.

To fix this, keep deferring native gestures after handling a sync touch in the case where a touchstart event is
still being handled; instead, remember whether the touch event was handled using a new member variable
(`m_handledSynchronousTouchEventWhileDispatchingPreventableTouchStart`), and consult this when the response to
the touchstart has been received in the UI process to determine whether platform gestures should be allowed to
recognize. This variable is reset once we're done handling the touchstart.

Test: fast/events/touch/ios/prevent-default-with-slow-touchstart-handler.html

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handlePreventableTouchEvent):
* UIProcess/WebPageProxy.h:

LayoutTests:

Adds a new layout test to verify that preventing default on elements with slow, active touchstart event handlers
actually prevents click events from being dispatched.

* fast/events/touch/ios/prevent-default-with-slow-touchstart-handler-expected.txt: Added.
* fast/events/touch/ios/prevent-default-with-slow-touchstart-handler.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h


Added Paths

trunk/LayoutTests/fast/events/touch/ios/prevent-default-with-slow-touchstart-handler-expected.txt
trunk/LayoutTests/fast/events/touch/ios/prevent-default-with-slow-touchstart-handler.html




Diff

Modified: trunk/LayoutTests/ChangeLog (255384 => 255385)

--- trunk/LayoutTests/ChangeLog	2020-01-29 22:16:13 UTC (rev 255384)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 22:22:43 UTC (rev 255385)
@@ -1,3 +1,17 @@
+2020-01-29  Wenson Hsieh  
+
+[iPadOS] Select popovers on amazon.com sometimes dismiss immediately after appearing
+https://bugs.webkit.org/show_bug.cgi?id=206948
+
+
+Reviewed by Tim Horton.
+
+Adds a new layout test to verify that preventing default on elements with slow, active touchstart event handlers
+actually prevents click events from being dispatched.
+
+* fast/events/touch/ios/prevent-default-with-slow-touchstart-handler-expected.txt: Added.
+* fast/events/touch/ios/prevent-default-with-slow-touchstart-handler.html: Added.
+
 2020-01-29  Jacob Uphoff  
 
 REGRESSION: (253807) [ macOS iOS ] storage/indexeddb/intversion-long-queue-private.html is flaky failing


Added: trunk/LayoutTests/fast/events/touch/ios/prevent-default-with-slow-touchstart-handler-expected.txt (0 => 255385)

--- trunk/LayoutTests/fast/events/touch/ios/prevent-default-with-slow-touchstart-handler-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/prevent-default-with-slow-touchstart-handler-expected.txt	2020-01-29 22:22:43 UTC (rev 255385)
@@ -0,0 +1,11 @@
+Verifies that calling preventDefault() in touchstart and touchend listeners prevents click events from being dispatched when the web page takes a long time to process the touchstart event. To manually run the test, tap the two 

[webkit-changes] [255384] trunk/LayoutTests

[tsavell]

Title: [255384] trunk/LayoutTests








Revision 255384
Author tsav...@apple.com
Date 2020-01-29 14:16:13 -0800 (Wed, 29 Jan 2020)


Log Message
REGRESSION: (253807) [ macOS iOS ] storage/indexeddb/intversion-long-queue-private.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206965

Unreviewed test gardening.

Patch by Jacob Uphoff  on 2020-01-29

* platform/ios-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255383 => 255384)

--- trunk/LayoutTests/ChangeLog	2020-01-29 22:11:51 UTC (rev 255383)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 22:16:13 UTC (rev 255384)
@@ -1,3 +1,13 @@
+2020-01-29  Jacob Uphoff  
+
+REGRESSION: (253807) [ macOS iOS ] storage/indexeddb/intversion-long-queue-private.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=206965
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
 2020-01-28  Antoine Quint  
 
 [Web Animations] Animations should run accelerated even if other animations targeting the same element are not accelerated


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (255383 => 255384)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-01-29 22:11:51 UTC (rev 255383)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-01-29 22:16:13 UTC (rev 255384)
@@ -1363,4 +1363,5 @@
 
 webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]
 
-webkit.org/b/206946 http/tests/security/cookies/third-party-cookie-blocking-main-frame.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/206946 http/tests/security/cookies/third-party-cookie-blocking-main-frame.html [ Pass Timeout ]
+webkit.org/b/206965 storage/indexeddb/intversion-long-queue-private.html [ Pass Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac/TestExpectations (255383 => 255384)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 22:11:51 UTC (rev 255383)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 22:16:13 UTC (rev 255384)
@@ -1958,4 +1958,6 @@
 
 webkit.org/b/205729 webrtc/captureCanvas-webrtc.html [ Pass Failure ]
 
-webkit.org/b/206949 fast/dom/Window/post-message-crash.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/206949 fast/dom/Window/post-message-crash.html [ Pass Failure ]
+
+webkit.org/b/206965 storage/indexeddb/intversion-long-queue-private.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255383] trunk

[graouts]

Title: [255383] trunk








Revision 255383
Author grao...@webkit.org
Date 2020-01-29 14:11:51 -0800 (Wed, 29 Jan 2020)


Log Message
[Web Animations] Animations should run accelerated even if other animations targeting the same element are not accelerated
https://bugs.webkit.org/show_bug.cgi?id=206890


Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/width-and-opacity-separate-animation-yields-compositing.html

In the Web Animations implementation, when an element has some animated properties that can be accelerated and some that cannot be, we would never
run accelerated animations at all. However, in the "legacy" animation engine, we would animate properties that can be acclerated if possible.
We now attempt to run accelerated animations provided at least one animation is accelerated.

To do that, we now keep track of whether none, some or all of the animated properties of a given KeyframeEffect are accelerated using the new
m_acceleratedPropertiesState instance variable. We compute this property when creating the blending keyframes for the effect.

Then, as time progresses and the effect is resolved, updateAcceleratedActions() is called and we simply use the effect's phase to determine
whether we need to enqueue actions to start, pause, seek or end accelerated animations. This is an improvement over how this method used to work
since we would run accelerated animations while in their delay phase, which did not match the "legacy" animation engine's behavior.

We've also removed the single method that provided the accelerated characteristics of a KeyframeEffect, isAccelerated(), with a few more methods:

- isRunningAccelerated(): the effect is currently running accelerated animations.
- isAboutToRunAccelerated(): the effect has pending accelerated actions that should make it run accelerated animations when accelerated actions
are updated next.
- isCompletelyAccelerated(): the effect animates only accelerated properties.
- isCurrentlyAffectingProperty(property, accelerated): the effect is currently animating the given property, with the option to specify whether
that animation is accelerated.

We use this information in a few new places. If an effect returns true for either isRunningAccelerated() or isAboutToRunAccelerated() when
Element::applyKeyframeEffects() is called, we set the AnimationImpact::RequiresRecomposite flag. In RenderLayerCompositor::requiresCompositingForAnimation(),
if an effect returns true for isCurrentlyAffectingProperty() with the accelerated flag set to true, the method returns true, matching the logic
used by the "legacy" animation engine.

All in all, this better aligns the behavior of the "legacy" and Web Animations engines to run accelerated animations in the same circumstances.

* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty): Use KeyframeEfffect::isRunningAccelerated() instead of KeyframeEffect::isAccelerated().
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::isRunningAcceleratedAnimationOnRenderer const): Use KeyframeEffect::isCurrentlyAffectingProperty() instead of checking both
isRunningAccelerated() and manually looking at the effect's animated properties.
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setBlendingKeyframes): Call computeAcceleratedPropertiesState() instead of the now-defunct computeShouldRunAccelerated().
(WebCore::KeyframeEffect::apply): Keep track of the newly computed phase so that we may use it in the new isCurrentlyAffectingProperty() without having
to recompute it on each call.
(WebCore::KeyframeEffect::isCurrentlyAffectingProperty const): Indicates whether a given property is currently animated (active phase) with the option
to specify whether that animation is accelerated.
(WebCore::KeyframeEffect::computeAcceleratedPropertiesState): Compute whether none, some or all of the animated properties of the given effect can be accelerated.
(WebCore::KeyframeEffect::updateAcceleratedActions): Use the phase to determine which accelerated actions to enqueue.
(WebCore::KeyframeEffect::animationDidSeek): Use the new m_isRunningAccelerated state to determine whether the animation is presently running accelerated.
(WebCore::KeyframeEffect::animationWasCanceled): Use the new m_isRunningAccelerated state to determine whether the animation is presently running accelerated.
(WebCore::KeyframeEffect::animationSuspensionStateDidChange): Use the new m_isRunningAccelerated state to determine whether the animation is presently running accelerated.
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):
* animation/KeyframeEffect.h:
(WebCore::KeyframeEffect::isRunningAccelerated const):
(WebCore::KeyframeEffect::isAboutToRunAccelerated const):
(WebCore::KeyframeEffect::isCompletelyAccelerated const):
* animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const): Indicates whether any of the effects in 

[webkit-changes] [255382] trunk/LayoutTests

[tsavell]

Title: [255382] trunk/LayoutTests








Revision 255382
Author tsav...@apple.com
Date 2020-01-29 13:49:27 -0800 (Wed, 29 Jan 2020)


Log Message
[ Mojave wk2 ] media/media-fragments/TC0035.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=206961

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-29

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255381 => 255382)

--- trunk/LayoutTests/ChangeLog	2020-01-29 21:45:52 UTC (rev 255381)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 21:49:27 UTC (rev 255382)
@@ -1,3 +1,12 @@
+2020-01-29  Jason Lawrence  
+
+[ Mojave wk2 ] media/media-fragments/TC0035.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206961
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 020-01-29  Jacob Uphoff  
 
 [ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky failure & flaky timing out


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (255381 => 255382)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-29 21:45:52 UTC (rev 255381)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-29 21:49:27 UTC (rev 255382)
@@ -942,4 +942,6 @@
 
 webkit.org/b/206940 [ Mojave+ Debug ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html [ Pass Failure ]
 
-webkit.org/b/206958 http/tests/media/media-stream/get-display-media-prompt.html [ Pass Failure Timeout ]
\ No newline at end of file
+webkit.org/b/206958 http/tests/media/media-stream/get-display-media-prompt.html [ Pass Failure Timeout ]
+
+webkit.org/b/206961 [ Mojave ] media/media-fragments/TC0035.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255381] trunk/Source/WebCore

[ross . kirsling]

Title: [255381] trunk/Source/WebCore








Revision 255381
Author ross.kirsl...@sony.com
Date 2020-01-29 13:45:52 -0800 (Wed, 29 Jan 2020)


Log Message
Unreviewed !ENABLE(ACCESSIBILITY) build fix.

* accessibility/AccessibilityObjectInterface.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (255380 => 255381)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 21:30:28 UTC (rev 255380)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 21:45:52 UTC (rev 255381)
@@ -1,3 +1,9 @@
+2020-01-29  Ross Kirsling  
+
+Unreviewed !ENABLE(ACCESSIBILITY) build fix.
+
+* accessibility/AccessibilityObjectInterface.h:
+
 2020-01-29  Chris Dumez  
 
 [iOS] Make sure unused service worker processes exit promptly on low memory warning


Modified: trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h (255380 => 255381)

--- trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h	2020-01-29 21:30:28 UTC (rev 255380)
+++ trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h	2020-01-29 21:45:52 UTC (rev 255381)
@@ -1152,11 +1152,13 @@
 setObjectID(InvalidAXID);
 }
 
+#if ENABLE(ACCESSIBILITY)
 inline void AXCoreObject::detachWrapper(AccessibilityDetachmentType detachmentType)
 {
 detachPlatformWrapper(detachmentType);
 m_wrapper = nullptr;
 }
+#endif
 
 namespace Accessibility {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255380] trunk/Source/JavaScriptCore

[justin_michaud]

Title: [255380] trunk/Source/_javascript_Core








Revision 255380
Author justin_mich...@apple.com
Date 2020-01-29 13:30:28 -0800 (Wed, 29 Jan 2020)


Log Message
Fix small memory regression caused by r206365
https://bugs.webkit.org/show_bug.cgi?id=206557

Reviewed by Yusuke Suzuki.

Put StructureRareData::m_giveUpOnObjectToStringValueCache into m_objectToStringValue to prevent increasing StructureRareData's size. We make a special value for the pointer
objectToStringCacheGiveUpMarker() to signal that we should not cache the string value. As a result, adding m_transitionOffset does not increase the size of the class.

* runtime/Structure.h:
* runtime/StructureRareData.cpp:
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):
(JSC::StructureRareData::setObjectToStringValue):
(JSC::StructureRareData::clearObjectToStringValue):
* runtime/StructureRareData.h:
* runtime/StructureRareDataInlines.h:
(JSC::StructureRareData::objectToStringValue const):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/Structure.h
trunk/Source/_javascript_Core/runtime/StructureRareData.cpp
trunk/Source/_javascript_Core/runtime/StructureRareData.h
trunk/Source/_javascript_Core/runtime/StructureRareDataInlines.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (255379 => 255380)

--- trunk/Source/_javascript_Core/ChangeLog	2020-01-29 21:26:06 UTC (rev 255379)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-01-29 21:30:28 UTC (rev 255380)
@@ -1,3 +1,23 @@
+2020-01-29  Justin Michaud  
+
+Fix small memory regression caused by r206365
+https://bugs.webkit.org/show_bug.cgi?id=206557
+
+Reviewed by Yusuke Suzuki.
+
+Put StructureRareData::m_giveUpOnObjectToStringValueCache into m_objectToStringValue to prevent increasing StructureRareData's size. We make a special value for the pointer
+objectToStringCacheGiveUpMarker() to signal that we should not cache the string value. As a result, adding m_transitionOffset does not increase the size of the class.
+
+* runtime/Structure.h:
+* runtime/StructureRareData.cpp:
+(JSC::StructureRareData::StructureRareData):
+(JSC::StructureRareData::visitChildren):
+(JSC::StructureRareData::setObjectToStringValue):
+(JSC::StructureRareData::clearObjectToStringValue):
+* runtime/StructureRareData.h:
+* runtime/StructureRareDataInlines.h:
+(JSC::StructureRareData::objectToStringValue const):
+
 2020-01-28  Yusuke Suzuki  
 
 [JSC] Give up IC when unknown structure transition happens


Modified: trunk/Source/_javascript_Core/runtime/Structure.h (255379 => 255380)

--- trunk/Source/_javascript_Core/runtime/Structure.h	2020-01-29 21:26:06 UTC (rev 255379)
+++ trunk/Source/_javascript_Core/runtime/Structure.h	2020-01-29 21:30:28 UTC (rev 255380)
@@ -123,6 +123,8 @@
 };
 
 class Structure final : public JSCell {
+static constexpr uint16_t shortInvalidOffset = std::numeric_limits::max() - 1;
+static constexpr uint16_t useRareDataFlag = std::numeric_limits::max();
 public:
 friend class StructureTransitionTable;
 
@@ -361,7 +363,7 @@
 return rareData()->m_maxOffset;
 return m_maxOffset;
 }
-
+
 void setMaxOffset(VM& vm, PropertyOffset offset)
 {
 if (offset == invalidOffset)
@@ -824,9 +826,6 @@
 
 COMPILE_ASSERT(firstOutOfLineOffset < 256, firstOutOfLineOffset_fits);
 
-static constexpr uint16_t shortInvalidOffset = std::numeric_limits::max();
-static constexpr uint16_t useRareDataFlag = std::numeric_limits::max() - 1;
-
 uint16_t m_transitionOffset;
 uint16_t m_maxOffset;
 


Modified: trunk/Source/_javascript_Core/runtime/StructureRareData.cpp (255379 => 255380)

--- trunk/Source/_javascript_Core/runtime/StructureRareData.cpp	2020-01-29 21:26:06 UTC (rev 255379)
+++ trunk/Source/_javascript_Core/runtime/StructureRareData.cpp	2020-01-29 21:30:28 UTC (rev 255380)
@@ -57,7 +57,6 @@
 
 StructureRareData::StructureRareData(VM& vm, Structure* previous)
 : JSCell(vm, vm.structureRareDataStructure.get())
-, m_giveUpOnObjectToStringValueCache(false)
 , m_maxOffset(invalidOffset)
 , m_transitionOffset(invalidOffset)
 {
@@ -72,7 +71,7 @@
 
 Base::visitChildren(thisObject, visitor);
 visitor.append(thisObject->m_previous);
-visitor.append(thisObject->m_objectToStringValue);
+visitor.appendUnbarriered(thisObject->objectToStringValue());
 visitor.append(thisObject->m_cachedPropertyNameEnumerator);
 auto* cachedOwnKeys = thisObject->m_cachedOwnKeys.unvalidatedGet();
 if (cachedOwnKeys != cachedOwnKeysSentinel())
@@ -95,7 +94,7 @@
 
 void StructureRareData::setObjectToStringValue(JSGlobalObject* globalObject, VM& vm, Structure* ownStructure, JSString* value, PropertySlot toStringTagSymbolSlot)
 {
-if (m_giveUpOnObjectToStringValueCache)
+if (canCacheObjectToStringValue())
 return;
 
 

[webkit-changes] [255379] trunk/LayoutTests

[tsavell]

Title: [255379] trunk/LayoutTests








Revision 255379
Author tsav...@apple.com
Date 2020-01-29 13:26:06 -0800 (Wed, 29 Jan 2020)


Log Message
020-01-29  Jacob Uphoff  

[ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky failure & flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=206958

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255378 => 255379)

--- trunk/LayoutTests/ChangeLog	2020-01-29 21:20:55 UTC (rev 255378)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 21:26:06 UTC (rev 255379)
@@ -1,3 +1,12 @@
+020-01-29  Jacob Uphoff  
+
+[ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky failure & flaky timing out
+https://bugs.webkit.org/show_bug.cgi?id=206958
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2020-01-29  Jacob Uphoff  
 
 [ macOS wk1 ] inspector/debugger/breakpoints/resolved-dump-each-line.html is flaky failing


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (255378 => 255379)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-29 21:20:55 UTC (rev 255378)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-29 21:26:06 UTC (rev 255379)
@@ -940,4 +940,6 @@
 webkit.org/b/206770 [ Mojave Release ] storage/websql/test-authorizer.html [ Pass Timeout ]
 webkit.org/b/206770 [ Catalina Release ] storage/websql/test-authorizer.html [ Pass Failure Timeout ]
 
-webkit.org/b/206940 [ Mojave+ Debug ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/206940 [ Mojave+ Debug ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html [ Pass Failure ]
+
+webkit.org/b/206958 http/tests/media/media-stream/get-display-media-prompt.html [ Pass Failure Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255378] trunk/Source

[cdumez]

Title: [255378] trunk/Source








Revision 255378
Author cdu...@apple.com
Date 2020-01-29 13:20:55 -0800 (Wed, 29 Jan 2020)


Log Message
[iOS] Make sure unused service worker processes exit promptly on low memory warning
https://bugs.webkit.org/show_bug.cgi?id=206939


Reviewed by Alex Christensen.

Make sure unused service worker processes exit promptly on low memory warning. They normally take 10 seconds to exit
for performance reasons. However, in case of memory pressure, keeping those processes around that long is not the
right thing to do.

Source/WebCore:

* workers/service/server/SWServer.cpp:
(WebCore::SWServer::handleLowMemoryWarning):
* workers/service/server/SWServer.h:

Source/WebKit:

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::lowMemoryHandler):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/server/SWServer.cpp
trunk/Source/WebCore/workers/service/server/SWServer.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (255377 => 255378)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 21:00:40 UTC (rev 255377)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 21:20:55 UTC (rev 255378)
@@ -1,3 +1,19 @@
+2020-01-29  Chris Dumez  
+
+[iOS] Make sure unused service worker processes exit promptly on low memory warning
+https://bugs.webkit.org/show_bug.cgi?id=206939
+
+
+Reviewed by Alex Christensen.
+
+Make sure unused service worker processes exit promptly on low memory warning. They normally take 10 seconds to exit
+for performance reasons. However, in case of memory pressure, keeping those processes around that long is not the
+right thing to do.
+
+* workers/service/server/SWServer.cpp:
+(WebCore::SWServer::handleLowMemoryWarning):
+* workers/service/server/SWServer.h:
+
 2020-01-29  Antoine Quint  
 
 [Web Animations] `DeclarativeAnimation` for CSS Animation is not always destroyed when class that applies `animation-name` is removed


Modified: trunk/Source/WebCore/workers/service/server/SWServer.cpp (255377 => 255378)

--- trunk/Source/WebCore/workers/service/server/SWServer.cpp	2020-01-29 21:00:40 UTC (rev 255377)
+++ trunk/Source/WebCore/workers/service/server/SWServer.cpp	2020-01-29 21:20:55 UTC (rev 255378)
@@ -43,6 +43,7 @@
 #include "ServiceWorkerFetchResult.h"
 #include "ServiceWorkerJobData.h"
 #include 
+#include 
 #include 
 #include 
 
@@ -912,7 +913,7 @@
 
 m_clientIdentifiersPerOrigin.remove(clientOrigin);
 });
-iterator->value.terminateServiceWorkersTimer->startOneShot(m_isProcessTerminationDelayEnabled ? terminationDelay : 0_s);
+iterator->value.terminateServiceWorkersTimer->startOneShot(m_isProcessTerminationDelayEnabled && !MemoryPressureHandler::singleton().isUnderMemoryPressure() ? terminationDelay : 0_s);
 }
 
 auto clientsByRegistrableDomainIterator = m_clientsByRegistrableDomain.find(clientRegistrableDomain);
@@ -932,6 +933,17 @@
 m_clientToControllingRegistration.remove(registrationIterator);
 }
 
+void SWServer::handleLowMemoryWarning()
+{
+// Accelerating the delayed termination of unused service workers due to memory pressure.
+if (m_isProcessTerminationDelayEnabled) {
+for (auto& clients : m_clientIdentifiersPerOrigin.values()) {
+if (clients.terminateServiceWorkersTimer)
+clients.terminateServiceWorkersTimer->startOneShot(0_s);
+}
+}
+}
+
 void SWServer::removeFromScopeToRegistrationMap(const ServiceWorkerRegistrationKey& key)
 {
 m_scopeToRegistrationMap.remove(key);


Modified: trunk/Source/WebCore/workers/service/server/SWServer.h (255377 => 255378)

--- trunk/Source/WebCore/workers/service/server/SWServer.h	2020-01-29 21:00:40 UTC (rev 255377)
+++ trunk/Source/WebCore/workers/service/server/SWServer.h	2020-01-29 21:20:55 UTC (rev 255378)
@@ -210,6 +210,8 @@
 
 void softUpdate(SWServerRegistration&);
 
+WEBCORE_EXPORT void handleLowMemoryWarning();
+
 private:
 void scriptFetchFinished(const ServiceWorkerFetchResult&);
 


Modified: trunk/Source/WebKit/ChangeLog (255377 => 255378)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 21:00:40 UTC (rev 255377)
+++ trunk/Source/WebKit/ChangeLog	2020-01-29 21:20:55 UTC (rev 255378)
@@ -1,5 +1,20 @@
 2020-01-29  Chris Dumez  
 
+[iOS] Make sure unused service worker processes exit promptly on low memory warning
+https://bugs.webkit.org/show_bug.cgi?id=206939
+
+
+Reviewed by Alex Christensen.
+
+Make sure unused service worker processes exit promptly on low memory warning. They normally take 10 seconds to exit
+for performance reasons. However, in case of memory pressure, keeping those processes around that long is not the
+right thing to do.
+
+* NetworkProcess/NetworkProcess.cpp:
+

[webkit-changes] [255377] trunk/LayoutTests

[tsavell]

Title: [255377] trunk/LayoutTests








Revision 255377
Author tsav...@apple.com
Date 2020-01-29 13:00:40 -0800 (Wed, 29 Jan 2020)


Log Message
[ macOS wk1 ] inspector/debugger/breakpoints/resolved-dump-each-line.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206955

Unreviewed test gardening.

Patch by Jacob Uphoff  on 2020-01-29

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255376 => 255377)

--- trunk/LayoutTests/ChangeLog	2020-01-29 20:55:03 UTC (rev 255376)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 21:00:40 UTC (rev 255377)
@@ -1,3 +1,12 @@
+2020-01-29  Jacob Uphoff  
+
+[ macOS wk1 ] inspector/debugger/breakpoints/resolved-dump-each-line.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=206955
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2020-01-29  Jason Lawrence  
 
 [ Mac ] fast/dom/Window/post-message-crash.html is flaky failing


Modified: trunk/LayoutTests/platform/mac/TestExpectations (255376 => 255377)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 20:55:03 UTC (rev 255376)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 21:00:40 UTC (rev 255377)
@@ -1036,7 +1036,7 @@
 webkit.org/b/161387 inspector/debugger/breakpoint-action-with-exception.html [ Pass Failure ]
 webkit.org/b/164293 [ Debug ] inspector/debugger/breakpoint-scope.html [ Pass Timeout ]
 webkit.org/b/168090 [ Debug ] inspector/debugger/breakpoint-columns.html [ Pass Timeout ]
-webkit.org/b/161951 [ Release ] inspector/debugger/breakpoints/resolved-dump-each-line.html [ Pass Timeout ]
+webkit.org/b/161951 [ Release ] inspector/debugger/breakpoints/resolved-dump-each-line.html [ Pass Failure Timeout ]
 webkit.org/b/167711 [ Debug ] inspector/debugger/probe-manager-add-remove-actions.html [ Slow ]
 webkit.org/b/168399 [ Debug ] inspector/debugger/search-scripts.html [ Pass Timeout ]
 webkit.org/b/181952 [ Debug ] inspector/debugger/tail-deleted-frames/tail-deleted-frames-vm-entry.html [ Slow ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255376] trunk/Source/WebKit

[cdumez]

Title: [255376] trunk/Source/WebKit








Revision 255376
Author cdu...@apple.com
Date 2020-01-29 12:55:03 -0800 (Wed, 29 Jan 2020)


Log Message
Unreviewed, fix Catalyst build after r255366

* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultDisallowSyncXHRDuringPageDismissalEnabled):
* Shared/WebPreferencesDefaultValues.h:
* Shared/ios/WebPreferencesDefaultValuesIOS.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (255375 => 255376)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 20:38:40 UTC (rev 255375)
+++ trunk/Source/WebKit/ChangeLog	2020-01-29 20:55:03 UTC (rev 255376)
@@ -1,3 +1,12 @@
+2020-01-29  Chris Dumez  
+
+Unreviewed, fix Catalyst build after r255366
+
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultDisallowSyncXHRDuringPageDismissalEnabled):
+* Shared/WebPreferencesDefaultValues.h:
+* Shared/ios/WebPreferencesDefaultValuesIOS.mm:
+
 2020-01-29  Sihui Liu  
 
 Crash under com.apple.WebKit.Networking at WebKit: WebKit::WebIDBServer::suspend


Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (255375 => 255376)

--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2020-01-29 20:38:40 UTC (rev 255375)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2020-01-29 20:55:03 UTC (rev 255376)
@@ -66,12 +66,12 @@
 
 bool defaultDisallowSyncXHRDuringPageDismissalEnabled()
 {
-#if PLATFORM(MAC)
+#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
 if (CFPreferencesGetAppBooleanValue(CFSTR("allowDeprecatedSynchronousXMLHttpRequestDuringUnload"), CFSTR("com.apple.WebKit"), nullptr)) {
 WTFLogAlways("Allowing synchronous XHR during page unload due to managed preference");
 return false;
 }
-#elif PLATFORM(IOS_FAMILY)
+#elif PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST)
 if (allowsDeprecatedSynchronousXMLHttpRequestDuringUnload()) {
 WTFLogAlways("Allowing synchronous XHR during page unload due to managed preference");
 return false;


Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (255375 => 255376)

--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2020-01-29 20:38:40 UTC (rev 255375)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2020-01-29 20:55:03 UTC (rev 255376)
@@ -315,7 +315,7 @@
 #if ENABLE(TEXT_AUTOSIZING)
 bool defaultTextAutosizingUsesIdempotentMode();
 #endif
-#if PLATFORM(IOS_FAMILY)
+#if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST)
 bool allowsDeprecatedSynchronousXMLHttpRequestDuringUnload();
 #endif
 


Modified: trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm (255375 => 255376)

--- trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm	2020-01-29 20:38:40 UTC (rev 255375)
+++ trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm	2020-01-29 20:55:03 UTC (rev 255376)
@@ -43,10 +43,12 @@
 
 #endif
 
+#if !PLATFORM(MACCATALYST)
 bool allowsDeprecatedSynchronousXMLHttpRequestDuringUnload()
 {
 return [[PAL::getMCProfileConnectionClass() sharedConnection] effectiveBoolValueForSetting:@"allowDeprecatedWebKitSynchronousXHRLoads"] == MCRestrictedBoolExplicitYes;
 }
+#endif
 
 } // namespace WebKit
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255375] trunk/Source/WebKit

[sihui_liu]

Title: [255375] trunk/Source/WebKit








Revision 255375
Author sihui_...@apple.com
Date 2020-01-29 12:38:40 -0800 (Wed, 29 Jan 2020)


Log Message
Crash under com.apple.WebKit.Networking at WebKit: WebKit::WebIDBServer::suspend
https://bugs.webkit.org/show_bug.cgi?id=206904


Reviewed by Maciej Stachowiak.

Wait until m_server is set in constructor of WebIDBServer to make sure m_server can be accessed in
WebIDBServer::suspend.

* NetworkProcess/IndexedDB/WebIDBServer.cpp:
(WebKit::WebIDBServer::WebIDBServer):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (255374 => 255375)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 19:39:41 UTC (rev 255374)
+++ trunk/Source/WebKit/ChangeLog	2020-01-29 20:38:40 UTC (rev 255375)
@@ -1,3 +1,17 @@
+2020-01-29  Sihui Liu  
+
+Crash under com.apple.WebKit.Networking at WebKit: WebKit::WebIDBServer::suspend
+https://bugs.webkit.org/show_bug.cgi?id=206904
+
+
+Reviewed by Maciej Stachowiak.
+
+Wait until m_server is set in constructor of WebIDBServer to make sure m_server can be accessed in 
+WebIDBServer::suspend.
+
+* NetworkProcess/IndexedDB/WebIDBServer.cpp:
+(WebKit::WebIDBServer::WebIDBServer):
+
 2020-01-29  Brent Fulgham  
 
 Unreviewed, rolling out r255217 and r255217.


Modified: trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp (255374 => 255375)

--- trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp	2020-01-29 19:39:41 UTC (rev 255374)
+++ trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp	2020-01-29 20:38:40 UTC (rev 255375)
@@ -46,9 +46,12 @@
 {
 ASSERT(RunLoop::isMain());
 
-postTask([this, protectedThis = makeRef(*this), sessionID, directory = directory.isolatedCopy(), spaceRequester = WTFMove(spaceRequester)] () mutable {
+BinarySemaphore semaphore;
+postTask([this, protectedThis = makeRef(*this), , sessionID, directory = directory.isolatedCopy(), spaceRequester = WTFMove(spaceRequester)] () mutable {
 m_server = makeUnique(sessionID, directory, WTFMove(spaceRequester));
+semaphore.signal();
 });
+semaphore.wait();
 }
 
 void WebIDBServer::closeAndDeleteDatabasesModifiedSince(WallTime modificationTime, CompletionHandler&& callback)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255374] branches/safari-610.1.1-branch/Source/WebKit

[repstein]

Title: [255374] branches/safari-610.1.1-branch/Source/WebKit








Revision 255374
Author repst...@apple.com
Date 2020-01-29 11:39:41 -0800 (Wed, 29 Jan 2020)


Log Message
Cherry-pick r254993. rdar://problem/58778970

[iOS] Unreviewed follow-up sandbox fix.
https://bugs.webkit.org/show_bug.cgi?id=206562


I missed a couple of rules that are being overly chatty in the logs in r254982.
This adds appropriate commands to silence them.

* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.1-branch/Source/WebKit/ChangeLog
branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb
branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: branches/safari-610.1.1-branch/Source/WebKit/ChangeLog (255373 => 255374)

--- branches/safari-610.1.1-branch/Source/WebKit/ChangeLog	2020-01-29 19:39:36 UTC (rev 255373)
+++ branches/safari-610.1.1-branch/Source/WebKit/ChangeLog	2020-01-29 19:39:41 UTC (rev 255374)
@@ -1,5 +1,33 @@
 2020-01-29  Russell Epstein  
 
+Cherry-pick r254993. rdar://problem/58778970
+
+[iOS] Unreviewed follow-up sandbox fix.
+https://bugs.webkit.org/show_bug.cgi?id=206562
+
+
+I missed a couple of rules that are being overly chatty in the logs in r254982.
+This adds appropriate commands to silence them.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-23  Brent Fulgham  
+
+[iOS] Unreviewed follow-up sandbox fix.
+https://bugs.webkit.org/show_bug.cgi?id=206562
+
+
+I missed a couple of rules that are being overly chatty in the logs in r254982.
+This adds appropriate commands to silence them.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
+2020-01-29  Russell Epstein  
+
 Cherry-pick r254982. rdar://problem/58778970
 
 Stop capturing telemetry for well-understood sandbox rules (206562)


Modified: branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (255373 => 255374)

--- branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2020-01-29 19:39:36 UTC (rev 255373)
+++ branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2020-01-29 19:39:41 UTC (rev 255374)
@@ -418,9 +418,14 @@
 (global-name "com.apple.logd.events"))
 
 (allow mach-lookup (with report) (with telemetry)
-(global-name "com.apple.cfprefsd.daemon")
 (global-name "com.apple.cfprefsd.agent")
-(local-name "com.apple.cfprefsd.agent"))
+(local-name "com.apple.cfprefsd.agent")
+)
+
+(allow mach-lookup (with telemetry)
+(global-name "com.apple.cfprefsd.daemon") ;; Needed by _CFPreferencesGetAppBooleanValueWithContainer and others.
+)
+
 (allow ipc-posix-shm-read*
 (ipc-posix-name-prefix "apple.cfprefs."))
 
@@ -480,7 +485,6 @@
 (sysctl-name "kern.ostype")
 (sysctl-name "kern.osversion")
 (sysctl-name "kern.saved_ids")
-(sysctl-name "kern.secure_kernel")
 (sysctl-name "kern.usrstack")
 (sysctl-name "kern.usrstack64")
 (sysctl-name "kern.version")
@@ -505,8 +509,8 @@
 
 (allow mach-lookup (with report) (with telemetry)
 (global-name "com.apple.system.notification_center"))
-(allow ipc-posix-shm-read*  (with report) (with telemetry)
-(ipc-posix-name "apple.shm.notification_center"))
+(allow ipc-posix-shm-read* (with telemetry)
+(ipc-posix-name "apple.shm.notification_center")) ;; Needed by os_log_create
 
 (allow mach-lookup (with report) (with telemetry)
 (global-name "com.apple.distributed_notifications@1v3"))
@@ -562,6 +566,7 @@
 "kern.memorystatus_level"
 "kern.osproductversion" ;; Needed by CFNetwork (HSTS store and others)
 "kern.osvariant_status" ;; Needed for bundle loading
+"kern.secure_kernel" ;; Needed by XPC bundle resolution
 "kern.tcsm_available" ;; Needed for IndexedDB support
 "vm.footprint_suspend"))
 


Modified: branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (255373 => 255374)

--- branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-01-29 19:39:36 UTC (rev 255373)
+++ 

[webkit-changes] [255373] branches/safari-610.1.1-branch/Source/WebKit

[repstein]

Title: [255373] branches/safari-610.1.1-branch/Source/WebKit








Revision 255373
Author repst...@apple.com
Date 2020-01-29 11:39:36 -0800 (Wed, 29 Jan 2020)


Log Message
Cherry-pick r254982. rdar://problem/58778970

Stop capturing telemetry for well-understood sandbox rules (206562)
https://bugs.webkit.org/show_bug.cgi?id=206562


Reviewed by Per Arne Vollan.

Remove logging of sandbox rules that are now understood, and either confirmed to be needed for proper WebKit operation
or identified for removal through a future update.

No new tests. No change in behavior.

* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.1-branch/Source/WebKit/ChangeLog
branches/safari-610.1.1-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in
branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb
branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: branches/safari-610.1.1-branch/Source/WebKit/ChangeLog (255372 => 255373)

--- branches/safari-610.1.1-branch/Source/WebKit/ChangeLog	2020-01-29 19:36:27 UTC (rev 255372)
+++ branches/safari-610.1.1-branch/Source/WebKit/ChangeLog	2020-01-29 19:39:36 UTC (rev 255373)
@@ -1,3 +1,42 @@
+2020-01-29  Russell Epstein  
+
+Cherry-pick r254982. rdar://problem/58778970
+
+Stop capturing telemetry for well-understood sandbox rules (206562)
+https://bugs.webkit.org/show_bug.cgi?id=206562
+
+
+Reviewed by Per Arne Vollan.
+
+Remove logging of sandbox rules that are now understood, and either confirmed to be needed for proper WebKit operation
+or identified for removal through a future update.
+
+No new tests. No change in behavior.
+
+* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@254982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-23  Brent Fulgham  
+
+Stop capturing telemetry for well-understood sandbox rules (206562)
+https://bugs.webkit.org/show_bug.cgi?id=206562
+
+
+Reviewed by Per Arne Vollan.
+
+Remove logging of sandbox rules that are now understood, and either confirmed to be needed for proper WebKit operation
+or identified for removal through a future update.
+
+No new tests. No change in behavior.
+
+* NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-01-28  Russell Epstein  
 
 Cherry-pick r255132. rdar://problem/58871371


Modified: branches/safari-610.1.1-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (255372 => 255373)

--- branches/safari-610.1.1-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2020-01-29 19:36:27 UTC (rev 255372)
+++ branches/safari-610.1.1-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in	2020-01-29 19:39:36 UTC (rev 255373)
@@ -174,9 +174,10 @@
 (sysctl-name
 "hw.availcpu"
 "hw.ncpu"
-"hw.model"
+"hw.model" ;; Needed for bundle loading
 "kern.maxfilesperproc"
 "kern.memorystatus_level"
+"kern.osproductversion" ;; Needed by CFNetwork (HSTS store and others)
 "kern.tcsm_available" ;; Needed for IndexedDB support.
 "vm.footprint_suspend")
 (sysctl-name-regex #"^net.routetable")


Modified: branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (255372 => 255373)

--- branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2020-01-29 19:36:27 UTC (rev 255372)
+++ branches/safari-610.1.1-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2020-01-29 19:39:36 UTC (rev 255373)
@@ -237,8 +237,9 @@
 (allow user-preference-read (apply preference-domain domains)))
 
 (define-once (mobile-keybag-access)
- (allow iokit-open (with report) (with telemetry)
-(iokit-user-client-class "AppleKeyStoreUserClient")))
+(allow iokit-open (with telemetry)
+(iokit-user-client-class "AppleKeyStoreUserClient") ;; Needed by NSURLCache
+))
 
 (define-once (debugging-support)
 ;; 
@@ -432,7 +433,6 @@
 (require-entitlement 

[webkit-changes] [255372] trunk/Source/WebKitLegacy/mac

[timothy_horton]

Title: [255372] trunk/Source/WebKitLegacy/mac








Revision 255372
Author timothy_hor...@apple.com
Date 2020-01-29 11:36:27 -0800 (Wed, 29 Jan 2020)


Log Message
Null deref under -[WebFrame isTelephoneNumberParsingAllowed]
https://bugs.webkit.org/show_bug.cgi?id=206921

Reviewed by Anders Carlsson.

* WebView/WebFrame.mm:
(-[WebFrame isTelephoneNumberParsingAllowed]):
(-[WebFrame isTelephoneNumberParsingEnabled]):
DataDetectors can hold on to a WebFrame on an operation queue before
calling into these methods. In the meantime, it is possible for the
WebView to be closed, resulting in a null core Frame.
This is not reproducible in a test app, but a speculative fix seems fine.

Modified Paths

trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm




Diff

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (255371 => 255372)

--- trunk/Source/WebKitLegacy/mac/ChangeLog	2020-01-29 19:35:21 UTC (rev 255371)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2020-01-29 19:36:27 UTC (rev 255372)
@@ -1,3 +1,18 @@
+2020-01-29  Tim Horton  
+
+Null deref under -[WebFrame isTelephoneNumberParsingAllowed]
+https://bugs.webkit.org/show_bug.cgi?id=206921
+
+Reviewed by Anders Carlsson.
+
+* WebView/WebFrame.mm:
+(-[WebFrame isTelephoneNumberParsingAllowed]):
+(-[WebFrame isTelephoneNumberParsingEnabled]):
+DataDetectors can hold on to a WebFrame on an operation queue before
+calling into these methods. In the meantime, it is possible for the
+WebView to be closed, resulting in a null core Frame.
+This is not reproducible in a test app, but a speculative fix seems fine.
+
 2020-01-27  Antoine Quint  
 
 [Web Animations] Make Animation.timeline read-write only if a runtime flag is enabled


Modified: trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm (255371 => 255372)

--- trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm	2020-01-29 19:35:21 UTC (rev 255371)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm	2020-01-29 19:36:27 UTC (rev 255372)
@@ -1446,14 +1446,18 @@
 
 - (BOOL)isTelephoneNumberParsingAllowed
 {
-auto* document = core(self)->document();
-return document->isTelephoneNumberParsingAllowed();
+WebCore::Frame *frame = core(self);
+if (!frame || !frame->document())
+return false;
+return frame->document()->isTelephoneNumberParsingAllowed();
 }
 
 - (BOOL)isTelephoneNumberParsingEnabled
 {
-auto* document = core(self)->document();
-return document->isTelephoneNumberParsingEnabled();
+WebCore::Frame *frame = core(self);
+if (!frame || !frame->document())
+return false;
+return frame->document()->isTelephoneNumberParsingEnabled();
 }
 
 - (DOMRange *)selectedDOMRange






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255371] trunk/Source/WebCore

[commit-queue]

Title: [255371] trunk/Source/WebCore








Revision 255371
Author commit-qu...@webkit.org
Date 2020-01-29 11:35:21 -0800 (Wed, 29 Jan 2020)


Log Message
[Web Animations] `DeclarativeAnimation` for CSS Animation is not always destroyed when class that applies `animation-name` is removed
https://bugs.webkit.org/show_bug.cgi?id=206899

Patch by Antoine Quint  on 2020-01-29
Reviewed by Devin Rousso.

In case after processing the new animation styles we don't have any CSSAnimation objects anymore, we should make sure we remove the entry
for this element from m_elementToCSSAnimationsCreatedByMarkupMap so as to release ownership of any prior animation.

* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::updateCSSAnimationsForElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/AnimationTimeline.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (255370 => 255371)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 19:14:29 UTC (rev 255370)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 19:35:21 UTC (rev 255371)
@@ -1,3 +1,16 @@
+2020-01-29  Antoine Quint  
+
+[Web Animations] `DeclarativeAnimation` for CSS Animation is not always destroyed when class that applies `animation-name` is removed
+https://bugs.webkit.org/show_bug.cgi?id=206899
+
+Reviewed by Devin Rousso.
+
+In case after processing the new animation styles we don't have any CSSAnimation objects anymore, we should make sure we remove the entry
+for this element from m_elementToCSSAnimationsCreatedByMarkupMap so as to release ownership of any prior animation.
+
+* animation/AnimationTimeline.cpp:
+(WebCore::AnimationTimeline::updateCSSAnimationsForElement):
+
 2020-01-28  Yusuke Suzuki  
 
 [JSC] Give up IC when unknown structure transition happens


Modified: trunk/Source/WebCore/animation/AnimationTimeline.cpp (255370 => 255371)

--- trunk/Source/WebCore/animation/AnimationTimeline.cpp	2020-01-29 19:14:29 UTC (rev 255370)
+++ trunk/Source/WebCore/animation/AnimationTimeline.cpp	2020-01-29 19:35:21 UTC (rev 255371)
@@ -338,7 +338,11 @@
 }
 }
 
-m_elementToCSSAnimationsCreatedByMarkupMap.set(, WTFMove(newAnimations));
+if (newAnimations.isEmpty())
+m_elementToCSSAnimationsCreatedByMarkupMap.remove();
+else
+m_elementToCSSAnimationsCreatedByMarkupMap.set(, WTFMove(newAnimations));
+
 keyframeEffectStack.setCSSAnimationList(currentAnimationList);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255370] trunk/LayoutTests

[tsavell]

Title: [255370] trunk/LayoutTests








Revision 255370
Author tsav...@apple.com
Date 2020-01-29 11:14:29 -0800 (Wed, 29 Jan 2020)


Log Message
[ Mac ] fast/dom/Window/post-message-crash.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206949

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-29

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255369 => 255370)

--- trunk/LayoutTests/ChangeLog	2020-01-29 18:43:15 UTC (rev 255369)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 19:14:29 UTC (rev 255370)
@@ -1,3 +1,12 @@
+2020-01-29  Jason Lawrence  
+
+[ Mac ] fast/dom/Window/post-message-crash.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=206949
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2020-01-29  Jacob Uphoff  
 
 [ Mac wk1 ] compositing/repaint/become-overlay-composited-layer.html is flaky failing


Modified: trunk/LayoutTests/platform/mac/TestExpectations (255369 => 255370)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 18:43:15 UTC (rev 255369)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 19:14:29 UTC (rev 255370)
@@ -1957,3 +1957,5 @@
 webkit.org/b/206883 [ Mojave ] imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-matching.html [ Failure ]
 
 webkit.org/b/205729 webrtc/captureCanvas-webrtc.html [ Pass Failure ]
+
+webkit.org/b/206949 fast/dom/Window/post-message-crash.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255369] trunk/LayoutTests

[tsavell]

Title: [255369] trunk/LayoutTests








Revision 255369
Author tsav...@apple.com
Date 2020-01-29 10:43:15 -0800 (Wed, 29 Jan 2020)


Log Message
[ Mac wk1 ] compositing/repaint/become-overlay-composited-layer.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206945

Unreviewed test gardening.

Patch by Jacob Uphoff  on 2020-01-29

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255368 => 255369)

--- trunk/LayoutTests/ChangeLog	2020-01-29 18:39:09 UTC (rev 255368)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 18:43:15 UTC (rev 255369)
@@ -1,3 +1,12 @@
+2020-01-29  Jacob Uphoff  
+
+[ Mac wk1 ] compositing/repaint/become-overlay-composited-layer.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=206945
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2020-01-29  Jason Lawrence  
 
 [ iOS wk2 ] http/tests/security/cookies/third-party-cookie-blocking-main-frame.html is flaky timing out.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (255368 => 255369)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-29 18:39:09 UTC (rev 255368)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-29 18:43:15 UTC (rev 255369)
@@ -861,3 +861,5 @@
 webkit.org/b/206673 storage/indexeddb/modern/blob-cursor.html [ Pass Timeout ]
 
 webkit.org/b/190830 [ Debug ] media/track/video-track-addition-and-frame-removal.html [ Pass Crash ]
+
+webkit.org/b/206945 [ Catalina ] compositing/repaint/become-overlay-composited-layer.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255368] trunk/LayoutTests

[tsavell]

Title: [255368] trunk/LayoutTests








Revision 255368
Author tsav...@apple.com
Date 2020-01-29 10:39:09 -0800 (Wed, 29 Jan 2020)


Log Message
[ iOS wk2 ] http/tests/security/cookies/third-party-cookie-blocking-main-frame.html is flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=206946

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-29

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255367 => 255368)

--- trunk/LayoutTests/ChangeLog	2020-01-29 18:22:19 UTC (rev 255367)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 18:39:09 UTC (rev 255368)
@@ -1,3 +1,12 @@
+2020-01-29  Jason Lawrence  
+
+[ iOS wk2 ] http/tests/security/cookies/third-party-cookie-blocking-main-frame.html is flaky timing out.
+https://bugs.webkit.org/show_bug.cgi?id=206946
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2020-01-28  Yusuke Suzuki  
 
 [JSC] Give up IC when unknown structure transition happens


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (255367 => 255368)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-01-29 18:22:19 UTC (rev 255367)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-01-29 18:39:09 UTC (rev 255368)
@@ -1361,4 +1361,6 @@
 
 webkit.org/b/206752 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable.html [ Pass Failure ]
 
-webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]
+
+webkit.org/b/206946 http/tests/security/cookies/third-party-cookie-blocking-main-frame.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255367] trunk/Source/WebKit

[bfulgham]

Title: [255367] trunk/Source/WebKit








Revision 255367
Author bfulg...@apple.com
Date 2020-01-29 10:22:19 -0800 (Wed, 29 Jan 2020)


Log Message
Unreviewed, rolling out r255217 and r255217.

* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* WebProcess/com.apple.WebProcess.sb.in:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in
trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: trunk/Source/WebKit/ChangeLog (255366 => 255367)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 18:12:02 UTC (rev 255366)
+++ trunk/Source/WebKit/ChangeLog	2020-01-29 18:22:19 UTC (rev 255367)
@@ -1,3 +1,10 @@
+2020-01-29  Brent Fulgham  
+
+Unreviewed, rolling out r255217 and r255217.
+
+* GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
+* WebProcess/com.apple.WebProcess.sb.in:
+
 2020-01-29  Chris Dumez  
 
 [iOS] Add managed preference to allow legacy sync XHRs during page dismissal


Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (255366 => 255367)

--- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2020-01-29 18:12:02 UTC (rev 255366)
+++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in	2020-01-29 18:22:19 UTC (rev 255367)
@@ -646,12 +646,10 @@
 (global-name "com.apple.windowserver.active"))
 #endif
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
 ;; Needed to support encrypted media playback 
 (allow mach-lookup
 (global-name "com.apple.SecurityServer")
 (global-name "com.apple.ocspd"))
-#endif
 
 (allow file-read* file-write* (subpath "/private/var/db/mds/system")) ;; FIXME: This should be removed when  is fixed.
 


Modified: trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (255366 => 255367)

--- trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-01-29 18:12:02 UTC (rev 255366)
+++ trunk/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-01-29 18:22:19 UTC (rev 255367)
@@ -670,12 +670,10 @@
 (global-name "com.apple.windowserver.active"))
 #endif
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
 ;; Needed to support encrypted media playback 
 (allow mach-lookup
 (global-name "com.apple.SecurityServer")
 (global-name "com.apple.ocspd"))
-#endif
 
 (allow file-read* file-write* (subpath "/private/var/db/mds/system")) ;; FIXME: This should be removed when  is fixed.
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255366] trunk/Source/WebKit

[cdumez]

Title: [255366] trunk/Source/WebKit








Revision 255366
Author cdu...@apple.com
Date 2020-01-29 10:12:02 -0800 (Wed, 29 Jan 2020)


Log Message
[iOS] Add managed preference to allow legacy sync XHRs during page dismissal
https://bugs.webkit.org/show_bug.cgi?id=206944


Reviewed by Alex Christensen.

Add managed preference for iOS to allow enterprise customers to keep using legacy sync XHRs
during page dismissal.

* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultDisallowSyncXHRDuringPageDismissalEnabled):
* Shared/WebPreferencesDefaultValues.h:
* Shared/ios/WebPreferencesDefaultValuesIOS.mm:
(WebKit::allowsDeprecatedSynchronousXMLHttpRequestDuringUnload):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (255365 => 255366)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 18:07:40 UTC (rev 255365)
+++ trunk/Source/WebKit/ChangeLog	2020-01-29 18:12:02 UTC (rev 255366)
@@ -1,3 +1,20 @@
+2020-01-29  Chris Dumez  
+
+[iOS] Add managed preference to allow legacy sync XHRs during page dismissal
+https://bugs.webkit.org/show_bug.cgi?id=206944
+
+
+Reviewed by Alex Christensen.
+
+Add managed preference for iOS to allow enterprise customers to keep using legacy sync XHRs
+during page dismissal.
+
+* Shared/WebPreferencesDefaultValues.cpp:
+(WebKit::defaultDisallowSyncXHRDuringPageDismissalEnabled):
+* Shared/WebPreferencesDefaultValues.h:
+* Shared/ios/WebPreferencesDefaultValuesIOS.mm:
+(WebKit::allowsDeprecatedSynchronousXMLHttpRequestDuringUnload):
+
 2020-01-29  Carlos Garcia Campos  
 
 Unreviewed. Move unsetenv to WebProcessMain.cpp after r255342


Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (255365 => 255366)

--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2020-01-29 18:07:40 UTC (rev 255365)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2020-01-29 18:12:02 UTC (rev 255366)
@@ -71,6 +71,11 @@
 WTFLogAlways("Allowing synchronous XHR during page unload due to managed preference");
 return false;
 }
+#elif PLATFORM(IOS_FAMILY)
+if (allowsDeprecatedSynchronousXMLHttpRequestDuringUnload()) {
+WTFLogAlways("Allowing synchronous XHR during page unload due to managed preference");
+return false;
+}
 #endif
 return true;
 }


Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (255365 => 255366)

--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2020-01-29 18:07:40 UTC (rev 255365)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2020-01-29 18:12:02 UTC (rev 255366)
@@ -315,5 +315,8 @@
 #if ENABLE(TEXT_AUTOSIZING)
 bool defaultTextAutosizingUsesIdempotentMode();
 #endif
+#if PLATFORM(IOS_FAMILY)
+bool allowsDeprecatedSynchronousXMLHttpRequestDuringUnload();
+#endif
 
 } // namespace WebKit


Modified: trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm (255365 => 255366)

--- trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm	2020-01-29 18:07:40 UTC (rev 255365)
+++ trunk/Source/WebKit/Shared/ios/WebPreferencesDefaultValuesIOS.mm	2020-01-29 18:12:02 UTC (rev 255366)
@@ -29,6 +29,8 @@
 #if PLATFORM(IOS_FAMILY)
 
 #import "UserInterfaceIdiom.h"
+#import 
+#import 
 
 namespace WebKit {
 
@@ -41,6 +43,11 @@
 
 #endif
 
+bool allowsDeprecatedSynchronousXMLHttpRequestDuringUnload()
+{
+return [[PAL::getMCProfileConnectionClass() sharedConnection] effectiveBoolValueForSetting:@"allowDeprecatedWebKitSynchronousXHRLoads"] == MCRestrictedBoolExplicitYes;
+}
+
 } // namespace WebKit
 
 #endif // PLATFORM(IOS_FAMILY)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255365] trunk

[ysuzuki]

Title: [255365] trunk








Revision 255365
Author ysuz...@apple.com
Date 2020-01-29 10:07:40 -0800 (Wed, 29 Jan 2020)


Log Message
[JSC] Give up IC when unknown structure transition happens
https://bugs.webkit.org/show_bug.cgi?id=206846

Reviewed by Mark Lam.

JSTests:

* stress/ensure-crash.js: Added.
* stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition-debug.js: Added.
(shouldBe):
(putter):
(not_string.toString):
* stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior-bad-transition.js: Added.
(shouldBe):
(putter):
(not_string.toString):
* stress/incorrect-put-could-generate-invalid-ic-but-still-not-causing-bad-behavior.js: Added.
(shouldBe):
(putter):
(not_string.toString):
* stress/incorrect-put-could-generate-invalid-ic-involving-dictionary-flatten.js: Added.
(shouldBe):
(dictionary):
(putter):
(not_string.toString):

Source/_javascript_Core:

When we are creating Put IC for a new property, we grab the old Structure before performing
the put. For a custom ::put, our convention is that the implemented ::put should mark the PutPropertySlot
as non-cachable. The IC code relies on this in order to work correctly. If we didn't mark it as non-cacheable,
a semantic failure can happen. This patch hardens the code against this semantic failure case by giving up trying
to cache the IC when the newStructure calculated from oldStructure does not match against
the actual structure after the put operation.

* jit/Repatch.cpp:
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure):
* tools/JSDollarVM.cpp:
(JSC::functionCreateObjectDoingSideEffectPutWithoutCorrectSlotStatus):
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::visitChildren):
* tools/JSDollarVM.h:

Source/WebCore:

IDL Code Generator should taint PutPropertySlot or taint implemented object to avoid Put IC caching
when it implements custom ::put operation which has side-effect regardless of Structure. Otherwise, IC can be setup
and IC can do fast path without consulting the custom ::put operation.

Test: js/dom/put-override-should-not-use-ic.html

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h:
* bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h:
* bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h:
* bindings/scripts/test/JS/JSTestPluginInterface.h:

Tools:

Add `crash!` annotation, which allows us to write a crashing JS test.

* Scripts/run-jsc-stress-tests:
* Scripts/webkitruby/jsc-stress-test-writer-default.rb:
* Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
* Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:

LayoutTests:

* js/dom/put-override-should-not-use-ic-expected.txt: Added.
* js/dom/put-override-should-not-use-ic.html: Added.

Modified Paths

trunk/JSTests/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jit/Repatch.cpp
trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/Structure.cpp
trunk/Source/_javascript_Core/tools/JSDollarVM.cpp
trunk/Source/_javascript_Core/tools/JSDollarVM.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterThrowingException.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.h

[webkit-changes] [255364] trunk/Source/WebCore

[andresg_22]

Title: [255364] trunk/Source/WebCore








Revision 255364
Author andresg...@apple.com
Date 2020-01-29 10:01:14 -0800 (Wed, 29 Jan 2020)


Log Message
Crash in AXIsolatedObject destruction.
https://bugs.webkit.org/show_bug.cgi?id=206828

Reviewed by Carlos Alberto Lopez Perez.

Fix for crash on GTK introduced with this IsolatedTree change.

* accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::detachPlatformWrapper):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (255363 => 255364)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 17:39:49 UTC (rev 255363)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 18:01:14 UTC (rev 255364)
@@ -1,3 +1,15 @@
+2020-01-29  Andres Gonzalez  
+
+Crash in AXIsolatedObject destruction.
+https://bugs.webkit.org/show_bug.cgi?id=206828
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Fix for crash on GTK introduced with this IsolatedTree change.
+
+* accessibility/atk/AccessibilityObjectAtk.cpp:
+(WebCore::AccessibilityObject::detachPlatformWrapper):
+
 2020-01-29  Peng Liu  
 
 Always enable some log messages related to audio tracks


Modified: trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp (255363 => 255364)

--- trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp	2020-01-29 17:39:49 UTC (rev 255363)
+++ trunk/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp	2020-01-29 18:01:14 UTC (rev 255364)
@@ -37,8 +37,14 @@
 
 void AccessibilityObject::detachPlatformWrapper(AccessibilityDetachmentType detachmentType)
 {
-if (auto* cache = axObjectCache())
-cache->detachWrapper(this, detachmentType);
+if (detachmentType != AccessibilityDetachmentType::CacheDestroyed) {
+if (auto* cache = axObjectCache())
+cache->detachWrapper(this, detachmentType);
+}
+
+auto* wrapper = this->wrapper();
+ASSERT(wrapper);
+webkitAccessibleDetach(WEBKIT_ACCESSIBLE(wrapper));
 }
 
 bool AccessibilityObject::accessibilityIgnoreAttachment() const






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255363] trunk/LayoutTests

[tsavell]

Title: [255363] trunk/LayoutTests








Revision 255363
Author tsav...@apple.com
Date 2020-01-29 09:39:49 -0800 (Wed, 29 Jan 2020)


Log Message
[ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=206940

Unreviewed test gardening.

Patch by Jacob Uphoff  on 2020-01-29

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255362 => 255363)

--- trunk/LayoutTests/ChangeLog	2020-01-29 17:30:29 UTC (rev 255362)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 17:39:49 UTC (rev 255363)
@@ -1,5 +1,14 @@
 2020-01-29  Jacob Uphoff  
 
+[ Mac wk2 ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=206940
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2020-01-29  Jacob Uphoff  
+
 REGRESSION (Catalina): webrtc/captureCanvas-webrtc.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=205729
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (255362 => 255363)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-29 17:30:29 UTC (rev 255362)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-01-29 17:39:49 UTC (rev 255363)
@@ -938,4 +938,6 @@
 webkit.org/b/206708 fast/animation/request-animation-frame-iframe.html [ Pass Failure ]
 
 webkit.org/b/206770 [ Mojave Release ] storage/websql/test-authorizer.html [ Pass Timeout ]
-webkit.org/b/206770 [ Catalina Release ] storage/websql/test-authorizer.html [ Pass Failure Timeout ]
\ No newline at end of file
+webkit.org/b/206770 [ Catalina Release ] storage/websql/test-authorizer.html [ Pass Failure Timeout ]
+
+webkit.org/b/206940 [ Mojave+ Debug ] tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255362] trunk/Source/WebCore

[peng . liu6]

Title: [255362] trunk/Source/WebCore








Revision 255362
Author peng.l...@apple.com
Date 2020-01-29 09:30:29 -0800 (Wed, 29 Jan 2020)


Log Message
Always enable some log messages related to audio tracks
https://bugs.webkit.org/show_bug.cgi?id=206918

Reviewed by Eric Carlson.

No new tests needed. Just enable some log messages.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (255361 => 255362)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 17:15:25 UTC (rev 255361)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 17:30:29 UTC (rev 255362)
@@ -1,3 +1,17 @@
+2020-01-29  Peng Liu  
+
+Always enable some log messages related to audio tracks
+https://bugs.webkit.org/show_bug.cgi?id=206918
+
+Reviewed by Eric Carlson.
+
+No new tests needed. Just enable some log messages.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
+(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
+(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
+
 2020-01-29  Antti Koivisto  
 
 REGRESSION: WK1 Accessibility: ASSERTION FAILED: FontCache::singleton().generation() == m_generation


Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (255361 => 255362)

--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2020-01-29 17:15:25 UTC (rev 255361)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm	2020-01-29 17:30:29 UTC (rev 255362)
@@ -1869,7 +1869,7 @@
 
 setHasClosedCaptions(hasCaptions);
 
-INFO_LOG(LOGIDENTIFIER, "has video = ", hasVideo(), ", has audio = ", hasAudio(), ", has captions = ", hasClosedCaptions());
+ALWAYS_LOG(LOGIDENTIFIER, "has video = ", hasVideo(), ", has audio = ", hasAudio(), ", has captions = ", hasClosedCaptions());
 
 sizeChanged();
 
@@ -2034,7 +2034,7 @@
 track->resetPropertiesFromTrack();
 
 #if !RELEASE_LOG_DISABLED
-INFO_LOG(LOGIDENTIFIER, "track count was ", count, ", is ", m_audioTracks.size());
+ALWAYS_LOG(LOGIDENTIFIER, "track count was ", count, ", is ", m_audioTracks.size());
 #endif
 }
 
@@ -2058,7 +2058,7 @@
 track->resetPropertiesFromTrack();
 
 #if !RELEASE_LOG_DISABLED
-INFO_LOG(LOGIDENTIFIER, "track count was ", count, ", is ", m_videoTracks.size());
+ALWAYS_LOG(LOGIDENTIFIER, "track count was ", count, ", is ", m_videoTracks.size());
 #endif
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255361] trunk/LayoutTests

[tsavell]

Title: [255361] trunk/LayoutTests








Revision 255361
Author tsav...@apple.com
Date 2020-01-29 09:15:25 -0800 (Wed, 29 Jan 2020)


Log Message
REGRESSION (Catalina): webrtc/captureCanvas-webrtc.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=205729

Unreviewed gardening.

Patch by Jacob Uphoff  on 2020-01-29

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255360 => 255361)

--- trunk/LayoutTests/ChangeLog	2020-01-29 17:09:01 UTC (rev 255360)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 17:15:25 UTC (rev 255361)
@@ -1,3 +1,12 @@
+2020-01-29  Jacob Uphoff  
+
+REGRESSION (Catalina): webrtc/captureCanvas-webrtc.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=205729
+
+Unreviewed gardening.
+
+* platform/mac/TestExpectations:
+
 2020-01-29  Jason Lawrence  
 
 [ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (255360 => 255361)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 17:09:01 UTC (rev 255360)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 17:15:25 UTC (rev 255361)
@@ -1955,3 +1955,5 @@
 webkit.org/b/206883 [ Mojave ] imported/w3c/web-platform-tests/css/css-fonts/font-default-02.html [ ImageOnlyFailure ]
 webkit.org/b/206883 [ Mojave ] imported/w3c/web-platform-tests/css/css-fonts/font-default-03.html [ ImageOnlyFailure ]
 webkit.org/b/206883 [ Mojave ] imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-matching.html [ Failure ]
+
+webkit.org/b/205729 webrtc/captureCanvas-webrtc.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255360] trunk/LayoutTests

[tsavell]

Title: [255360] trunk/LayoutTests








Revision 255360
Author tsav...@apple.com
Date 2020-01-29 09:09:01 -0800 (Wed, 29 Jan 2020)


Log Message
[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=206934

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-29

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255359 => 255360)

--- trunk/LayoutTests/ChangeLog	2020-01-29 16:51:56 UTC (rev 255359)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 17:09:01 UTC (rev 255360)
@@ -1,3 +1,12 @@
+2020-01-29  Jason Lawrence  
+
+[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206934
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2020-01-29  Antti Koivisto  
 
 REGRESSION: WK1 Accessibility: ASSERTION FAILED: FontCache::singleton().generation() == m_generation


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (255359 => 255360)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-01-29 16:51:56 UTC (rev 255359)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-01-29 17:09:01 UTC (rev 255360)
@@ -1359,4 +1359,6 @@
 
 webkit.org/b/206687 imported/w3c/web-platform-tests/beacon/idlharness.any.html [ Pass Timeout ]
 
-webkit.org/b/206752 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/206752 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-serializable.html [ Pass Failure ]
+
+webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255359] trunk

[antti]

Title: [255359] trunk








Revision 255359
Author an...@apple.com
Date 2020-01-29 08:51:56 -0800 (Wed, 29 Jan 2020)


Log Message
REGRESSION: WK1 Accessibility: ASSERTION FAILED: FontCache::singleton().generation() == m_generation
https://bugs.webkit.org/show_bug.cgi?id=206241


Reviewed by Zalan Bujtas.

Source/WebCore:

Font cache generation bump empties all font related caches and triggers full style resolution. However it is possible
for single element computed style resolution (triggeded by  element here) to happen before the full resolution.
In this case a style computed based on parent style with old font generation may get inserted into matched declarations
cache. A subsequent style resolution may then pick up this style and use it as render style.

* style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::updateFont):

Fix by taking care that the font returned by style resolver is always updated to the current generation.

LayoutTests:

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/StyleBuilderState.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (255358 => 255359)

--- trunk/LayoutTests/ChangeLog	2020-01-29 16:39:17 UTC (rev 255358)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 16:51:56 UTC (rev 255359)
@@ -1,3 +1,13 @@
+2020-01-29  Antti Koivisto  
+
+REGRESSION: WK1 Accessibility: ASSERTION FAILED: FontCache::singleton().generation() == m_generation
+https://bugs.webkit.org/show_bug.cgi?id=206241
+
+
+Reviewed by Zalan Bujtas.
+
+* platform/mac-wk1/TestExpectations:
+
 2020-01-29  Carlos Alberto Lopez Perez  
 
 [CSS Backgrounds] Gardening after r255351


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (255358 => 255359)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-29 16:39:17 UTC (rev 255358)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-01-29 16:51:56 UTC (rev 255359)
@@ -844,8 +844,6 @@
 webkit.org/b/206071 editing/spelling/markers.html [ Skip ]
 webkit.org/b/206071 editing/spelling/retro-correction-spelling-markers.html [ Failure ]
 
-webkit.org/b/206241 [ Mojave Debug ] accessibility/mac/search-text/search-text.html [ Skip ]
-
 webkit.org/b/199117 [ Debug ] storage/indexeddb/modern/objectstore-autoincrement-types.html [ Timeout ]
 
 webkit.org/b/206503 [ Mojave ] imported/w3c/web-platform-tests/html/dom/idlharness.worker.html [ Failure ]
@@ -862,4 +860,4 @@
 
 webkit.org/b/206673 storage/indexeddb/modern/blob-cursor.html [ Pass Timeout ]
 
-webkit.org/b/190830 [ Debug ] media/track/video-track-addition-and-frame-removal.html [ Pass Crash ]
\ No newline at end of file
+webkit.org/b/190830 [ Debug ] media/track/video-track-addition-and-frame-removal.html [ Pass Crash ]


Modified: trunk/Source/WebCore/ChangeLog (255358 => 255359)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 16:39:17 UTC (rev 255358)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 16:51:56 UTC (rev 255359)
@@ -1,3 +1,21 @@
+2020-01-29  Antti Koivisto  
+
+REGRESSION: WK1 Accessibility: ASSERTION FAILED: FontCache::singleton().generation() == m_generation
+https://bugs.webkit.org/show_bug.cgi?id=206241
+
+
+Reviewed by Zalan Bujtas.
+
+Font cache generation bump empties all font related caches and triggers full style resolution. However it is possible
+for single element computed style resolution (triggeded by  element here) to happen before the full resolution.
+In this case a style computed based on parent style with old font generation may get inserted into matched declarations
+cache. A subsequent style resolution may then pick up this style and use it as render style.
+
+* style/StyleBuilderState.cpp:
+(WebCore::Style::BuilderState::updateFont):
+
+Fix by taking care that the font returned by style resolver is always updated to the current generation.
+
 2020-01-29  Commit Queue  
 
 Unreviewed, rolling out r255345.


Modified: trunk/Source/WebCore/style/StyleBuilderState.cpp (255358 => 255359)

--- trunk/Source/WebCore/style/StyleBuilderState.cpp	2020-01-29 16:39:17 UTC (rev 255358)
+++ trunk/Source/WebCore/style/StyleBuilderState.cpp	2020-01-29 16:51:56 UTC (rev 255359)
@@ -38,6 +38,7 @@
 #include "CSSImageSetValue.h"
 #include "CSSImageValue.h"
 #include "CSSShadowValue.h"
+#include "FontCache.h"
 #include "HTMLElement.h"
 #include "RenderTheme.h"
 #include "SVGElement.h"
@@ -337,7 +338,22 @@
 
 void BuilderState::updateFont()
 {
-if (!m_fontDirty && m_style.fontCascade().fonts())
+auto& fontSelector = const_cast(document()).fontSelector();
+
+auto needsUpdate = [&] {
+if (m_fontDirty)
+return true;
+auto* fonts = m_style.fontCascade().fonts();
+if (!fonts)
+return true;
+if (fonts->generation() != 

[webkit-changes] [255358] trunk/LayoutTests

[clopez]

Title: [255358] trunk/LayoutTests








Revision 255358
Author clo...@igalia.com
Date 2020-01-29 08:39:17 -0800 (Wed, 29 Jan 2020)


Log Message
[CSS Backgrounds] Gardening after r255351

Unreviewed gardening.

* platform/mac/TestExpectations: Update the list of expected failures for Mojave.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (255357 => 255358)

--- trunk/LayoutTests/ChangeLog	2020-01-29 16:16:52 UTC (rev 255357)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 16:39:17 UTC (rev 255358)
@@ -1,3 +1,11 @@
+2020-01-29  Carlos Alberto Lopez Perez  
+
+[CSS Backgrounds] Gardening after r255351
+
+Unreviewed gardening.
+
+* platform/mac/TestExpectations: Update the list of expected failures for Mojave.
+
 2020-01-29  Commit Queue  
 
 Unreviewed, rolling out r255345.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (255357 => 255358)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 16:16:52 UTC (rev 255357)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-01-29 16:39:17 UTC (rev 255358)
@@ -1953,3 +1953,5 @@
 
 webkit.org/b/206883 [ Mojave ] imported/w3c/web-platform-tests/css/css-fonts/font-default-01.html [ ImageOnlyFailure ]
 webkit.org/b/206883 [ Mojave ] imported/w3c/web-platform-tests/css/css-fonts/font-default-02.html [ ImageOnlyFailure ]
+webkit.org/b/206883 [ Mojave ] imported/w3c/web-platform-tests/css/css-fonts/font-default-03.html [ ImageOnlyFailure ]
+webkit.org/b/206883 [ Mojave ] imported/w3c/web-platform-tests/css/css-fonts/variations/font-weight-matching.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255357] trunk/Tools

[clopez]

Title: [255357] trunk/Tools








Revision 255357
Author clo...@igalia.com
Date 2020-01-29 08:16:52 -0800 (Wed, 29 Jan 2020)


Log Message
[GTK] Add api-gtk to EWS bubbles.
https://bugs.webkit.org/show_bug.cgi?id=206930

Reviewed by Aakash Jain.

A new queue has been added to the EWS to run GTK API tests in r255238.
The queue is now running fine with no pre-existent failures.
Let's add it to the EWS bubbles.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):

Modified Paths

trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (255356 => 255357)

--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	2020-01-29 16:10:23 UTC (rev 255356)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py	2020-01-29 16:16:52 UTC (rev 255357)
@@ -39,8 +39,10 @@
 class StatusBubble(View):
 # These queue names are from shortname in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/config.json
 # FIXME: Auto-generate this list https://bugs.webkit.org/show_bug.cgi?id=195640
+# Note: This list is sorted in the order of which bubbles appear in bugzilla.
 ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'gtk', 'wpe', 'wincairo', 'win',
-  'ios-wk2', 'mac-wk1', 'mac-wk2', 'mac-debug-wk1', 'api-ios', 'api-mac', 'bindings', 'jsc', 'jsc-armv7', 'jsc-mips', 'jsc-i386', 'webkitperl', 'webkitpy', 'services']
+  'ios-wk2', 'mac-wk1', 'mac-wk2', 'mac-debug-wk1', 'api-ios', 'api-mac', 'api-gtk',
+  'bindings', 'jsc', 'jsc-armv7', 'jsc-mips', 'jsc-i386', 'webkitperl', 'webkitpy', 'services']
 # FIXME: Auto-generate the queue's trigger relationship
 QUEUE_TRIGGERS = {
 'api-ios': 'ios-sim',


Modified: trunk/Tools/ChangeLog (255356 => 255357)

--- trunk/Tools/ChangeLog	2020-01-29 16:10:23 UTC (rev 255356)
+++ trunk/Tools/ChangeLog	2020-01-29 16:16:52 UTC (rev 255357)
@@ -1,5 +1,19 @@
 2020-01-29  Carlos Alberto Lopez Perez  
 
+[GTK] Add api-gtk to EWS bubbles.
+https://bugs.webkit.org/show_bug.cgi?id=206930
+
+Reviewed by Aakash Jain.
+
+A new queue has been added to the EWS to run GTK API tests in r255238.
+The queue is now running fine with no pre-existent failures.
+Let's add it to the EWS bubbles.
+
+* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+(StatusBubble):
+
+2020-01-29  Carlos Alberto Lopez Perez  
+
 [GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
 https://bugs.webkit.org/show_bug.cgi?id=206927
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255355] trunk/JSTests

[commit-queue]

Title: [255355] trunk/JSTests








Revision 255355
Author commit-qu...@webkit.org
Date 2020-01-29 06:40:02 -0800 (Wed, 29 Jan 2020)


Log Message
Skip slow test operand-should-fit-in-abstract-heap-encoded-payload-format.js on mips and arm
https://bugs.webkit.org/show_bug.cgi?id=206926

Unreviewed test gardening.

This test has quadratic behaviour with the size of a, and on mips and arm it just takes too
long to run with such high value of a. Therefore we skip.

Patch by Paulo Matos  on 2020-01-29

* stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js




Diff

Modified: trunk/JSTests/ChangeLog (255354 => 255355)

--- trunk/JSTests/ChangeLog	2020-01-29 13:48:21 UTC (rev 255354)
+++ trunk/JSTests/ChangeLog	2020-01-29 14:40:02 UTC (rev 255355)
@@ -1,3 +1,15 @@
+2020-01-29  Paulo Matos  
+
+Skip slow test operand-should-fit-in-abstract-heap-encoded-payload-format.js on mips and arm
+https://bugs.webkit.org/show_bug.cgi?id=206926
+
+Unreviewed test gardening.
+
+This test has quadratic behaviour with the size of a, and on mips and arm it just takes too
+long to run with such high value of a. Therefore we skip.
+
+* stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js:
+
 2020-01-28  Paulo Matos  
 
 Skip test numberingSystemsForLocale-cached-strings-should-be-immortal-and-safe-for-concurrent-access.js in arm and mips


Modified: trunk/JSTests/stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js (255354 => 255355)

--- trunk/JSTests/stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js	2020-01-29 13:48:21 UTC (rev 255354)
+++ trunk/JSTests/stress/operand-should-fit-in-abstract-heap-encoded-payload-format.js	2020-01-29 14:40:02 UTC (rev 255355)
@@ -1,4 +1,4 @@
-//@ skip if $buildType == "debug"
+//@ skip if $buildType == "debug" or ["arm", "mips"].include?($architecture)
 //@ runDefault("--useConcurrentJIT=0", "--jitPolicyScale=0")
 const a = [];
 a.length = 65532;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255354] trunk/Tools

[clopez]

Title: [255354] trunk/Tools








Revision 255354
Author clo...@igalia.com
Date 2020-01-29 05:48:21 -0800 (Wed, 29 Jan 2020)


Log Message
[GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
https://bugs.webkit.org/show_bug.cgi?id=206927

Reviewed by Carlos Garcia Campos.

Update the default value tested from 4MB to 5MB.

* TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp:
(testsJSCOptions):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp




Diff

Modified: trunk/Tools/ChangeLog (255353 => 255354)

--- trunk/Tools/ChangeLog	2020-01-29 13:48:08 UTC (rev 255353)
+++ trunk/Tools/ChangeLog	2020-01-29 13:48:21 UTC (rev 255354)
@@ -1,5 +1,17 @@
 2020-01-29  Carlos Alberto Lopez Perez  
 
+[GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
+https://bugs.webkit.org/show_bug.cgi?id=206927
+
+Reviewed by Carlos Garcia Campos.
+
+Update the default value tested from 4MB to 5MB.
+
+* TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp:
+(testsJSCOptions):
+
+2020-01-29  Carlos Alberto Lopez Perez  
+
 [GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
 https://bugs.webkit.org/show_bug.cgi?id=206925
 


Modified: trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp (255353 => 255354)

--- trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp	2020-01-29 13:48:08 UTC (rev 255353)
+++ trunk/Tools/TestWebKitAPI/Tests/_javascript_Core/glib/TestJSC.cpp	2020-01-29 13:48:21 UTC (rev 255354)
@@ -3527,11 +3527,11 @@
 
 guint maxPerThreadStackUsage;
 g_assert_true(jsc_options_get_uint("maxPerThreadStackUsage", ));
-g_assert_cmpuint(maxPerThreadStackUsage, ==, 4194304);
+g_assert_cmpuint(maxPerThreadStackUsage, ==, 5242880);
 g_assert_true(jsc_options_set_uint("maxPerThreadStackUsage", 4096));
 g_assert_true(jsc_options_get_uint("maxPerThreadStackUsage", ));
 g_assert_cmpuint(maxPerThreadStackUsage, ==, 4096);
-g_assert_true(jsc_options_set_uint("maxPerThreadStackUsage", 4194304));
+g_assert_true(jsc_options_set_uint("maxPerThreadStackUsage", 5242880));
 
 gsize webAssemblyPartialCompileLimit;
 g_assert_true(jsc_options_get_size("webAssemblyPartialCompileLimit", ));
@@ -3684,7 +3684,7 @@
 // Restore options their default values.
 g_assert_true(jsc_options_set_boolean(JSC_OPTIONS_USE_JIT, TRUE));
 g_assert_true(jsc_options_set_int("thresholdForJITAfterWarmUp", 500));
-g_assert_true(jsc_options_set_uint("maxPerThreadStackUsage", 4194304));
+g_assert_true(jsc_options_set_uint("maxPerThreadStackUsage", 5242880));
 g_assert_true(jsc_options_set_size("webAssemblyPartialCompileLimit", 5000));
 g_assert_true(jsc_options_set_double("smallHeapRAMFraction", 0.25));
 g_assert_true(jsc_options_set_string("configFile", nullptr));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255353] trunk/Tools

[clopez]

Title: [255353] trunk/Tools








Revision 255353
Author clo...@igalia.com
Date 2020-01-29 05:48:08 -0800 (Wed, 29 Jan 2020)


Log Message
[GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
https://bugs.webkit.org/show_bug.cgi?id=206925

Reviewed by Carlos Garcia Campos.

Add cups-daemon to the list of packages to be installed, which is necessary to sucessfully
run the printing related GTK API tests. Add also the liberation fonts, which are needed to
run the complex text controller API tests.

* gtk/install-dependencies:
* wpe/install-dependencies: Don't add cups packages, because WPE currently doesn't run print-related API test.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/install-dependencies
trunk/Tools/wpe/install-dependencies




Diff

Modified: trunk/Tools/ChangeLog (255352 => 255353)

--- trunk/Tools/ChangeLog	2020-01-29 13:46:55 UTC (rev 255352)
+++ trunk/Tools/ChangeLog	2020-01-29 13:48:08 UTC (rev 255353)
@@ -1,3 +1,17 @@
+2020-01-29  Carlos Alberto Lopez Perez  
+
+[GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
+https://bugs.webkit.org/show_bug.cgi?id=206925
+
+Reviewed by Carlos Garcia Campos.
+
+Add cups-daemon to the list of packages to be installed, which is necessary to sucessfully
+run the printing related GTK API tests. Add also the liberation fonts, which are needed to
+run the complex text controller API tests.
+
+* gtk/install-dependencies:
+* wpe/install-dependencies: Don't add cups packages, because WPE currently doesn't run print-related API test.
+
 2020-01-28  Tim Horton  
 
 macCatalyst: Right clicking on a link follows it immediately


Modified: trunk/Tools/gtk/install-dependencies (255352 => 255353)

--- trunk/Tools/gtk/install-dependencies	2020-01-29 13:46:55 UTC (rev 255352)
+++ trunk/Tools/gtk/install-dependencies	2020-01-29 13:48:08 UTC (rev 255353)
@@ -155,8 +155,10 @@
 packages="$packages \
 apache2 \
 curl \
+cups-daemon \
 dbus-x11 \
 gdb \
+fonts-liberation \
 hunspell \
 hunspell-en-us \
 hunspell-en-gb \
@@ -329,6 +331,7 @@
 packages="$packages \
 apache \
 curl \
+cups \
 gdb \
 hunspell \
 hunspell-en \
@@ -341,6 +344,7 @@
 python2-psutil \
 python2-yaml \
 ruby \
+ttf-liberation \
 weston \
 xorg-server-xvfb"
 
@@ -494,11 +498,13 @@
 # These are dependencies necessary for running tests.
 packages="$packages \
 curl \
+cups \
 dbus-x11 \
 gdb \
 hunspell-en \
 hunspell-en-GB \
 httpd \
+liberation-fonts \
 libgpg-error-devel \
 mod_bw \
 mod_ssl \


Modified: trunk/Tools/wpe/install-dependencies (255352 => 255353)

--- trunk/Tools/wpe/install-dependencies	2020-01-29 13:46:55 UTC (rev 255352)
+++ trunk/Tools/wpe/install-dependencies	2020-01-29 13:48:08 UTC (rev 255353)
@@ -98,6 +98,7 @@
 apache2 \
 curl \
 gdb \
+fonts-liberation \
 libapache2-mod-bw \
 libapache2-mod-php \
 php-json \
@@ -210,7 +211,8 @@
 python2-gobject \
 python2-lxml \
 python2-psutil \
-ruby"
+ruby \
+ttf-liberation"
 
 # These are dependencies necessary for building the jhbuild.
 packages="$packages \
@@ -310,6 +312,7 @@
 curl \
 gdb \
 httpd \
+liberation-fonts \
 mod_bw \
 mod_ssl \
 perl-CGI \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255352] releases/WebKitGTK/webkit-2.26/Source/WebKit

[carlosgc]

Title: [255352] releases/WebKitGTK/webkit-2.26/Source/WebKit








Revision 255352
Author carlo...@webkit.org
Date 2020-01-29 05:46:55 -0800 (Wed, 29 Jan 2020)


Log Message
Merge r253553 - [GTK] Build with USE_WPE_RENDERER=No fails with undefined EGL_WAYLAND_BUFFER_WL
https://bugs.webkit.org/show_bug.cgi?id=205250

Reviewed by Carlos Garcia Campos.

Define the enum if not present.

No new tests, just a build fix.

* UIProcess/gtk/WaylandCompositor.cpp:

Modified Paths

releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog (255351 => 255352)

--- releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog	2020-01-29 12:57:37 UTC (rev 255351)
+++ releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog	2020-01-29 13:46:55 UTC (rev 255352)
@@ -1,3 +1,16 @@
+2019-12-16  Emilio Cobos Álvarez  
+
+[GTK] Build with USE_WPE_RENDERER=No fails with undefined EGL_WAYLAND_BUFFER_WL
+https://bugs.webkit.org/show_bug.cgi?id=205250
+
+Reviewed by Carlos Garcia Campos.
+
+Define the enum if not present.
+
+No new tests, just a build fix.
+
+* UIProcess/gtk/WaylandCompositor.cpp:
+
 2020-01-28  Carlos Garcia Campos  
 
 [GTK] Should use light theme unless website declares support for dark themes in color-schemes property


Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp (255351 => 255352)

--- releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp	2020-01-29 12:57:37 UTC (rev 255351)
+++ releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/gtk/WaylandCompositor.cpp	2020-01-29 13:46:55 UTC (rev 255352)
@@ -58,6 +58,10 @@
 typedef EGLBoolean (*PFNEGLUNBINDWAYLANDDISPLAYWL) (EGLDisplay, struct wl_display*);
 #endif
 
+#if !defined(EGL_WAYLAND_BUFFER_WL)
+#define EGL_WAYLAND_BUFFER_WL 0x31D5
+#endif
+
 #if !defined(PFNEGLQUERYWAYLANDBUFFERWL)
 typedef EGLBoolean (*PFNEGLQUERYWAYLANDBUFFERWL) (EGLDisplay, struct wl_resource*, EGLint attribute, EGLint* value);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255350] releases/WebKitGTK/webkit-2.26

[carlosgc]

Title: [255350] releases/WebKitGTK/webkit-2.26








Revision 255350
Author carlo...@webkit.org
Date 2020-01-29 02:38:43 -0800 (Wed, 29 Jan 2020)


Log Message
[GTK] Should use light theme unless website declares support for dark themes in color-schemes property
https://bugs.webkit.org/show_bug.cgi?id=197947

Reviewed by Michael Catanzaro.

.:

Do not define HAVE_OS_DARK_MODE_SUPPORT.

* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::useDarkAppearance const): Remove HAVE(OS_DARK_MODE_SUPPORT) because ENABLE(DARK_MODE_CSS)
guards should be enough.
* page/FrameView.cpp:
(WebCore::FrameView::updateBackgroundRecursively): Revert changes made in r244635.
* page/Page.cpp:
(WebCore::Page::effectiveAppearanceDidChange): Use ENABLE(DARK_MODE_CSS) instead of HAVE(OS_DARK_MODE_SUPPORT).
(WebCore::Page::useDarkAppearance const): Ditto.
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::systemColor const): Revert changes made in r244635.
* rendering/RenderThemeGtk.h:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setUseDarkAppearanceInternal): Revert changes made in r244635.

Source/WebKit:

Handle the theme changes in the UI process, converting dark variant to the light one before sending the theme
name to the web process. The web process is still notified when a dark theme is in use, so that if website
prefers a dark color scheme it will be used, but the gtk theme that will be used for controls styling will
always be light.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const): Encode themeName.
(WebKit::WebPageCreationParameters::decode): Decode themeName.
* Shared/WebPageCreationParameters.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::themeName const): Get the theme name that should be used by the web process.
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(themeChanged): Call WebPageProxy::themeDidChange().
(applicationPreferDarkThemeChanged):
(webkitWebViewBaseSetToplevelOnScreenWindow): Use a different callback for the theme name change.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::themeDidChange): Send ThemeDidChange message to the web process with the theme name to use.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize the theme name.
(WebKit::WebPage::effectiveAppearanceDidChange): Use this now for GTK port too.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add ThemeDidChange message.
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::themeDidChange): Set the theme given name in gtk settings.
* WebProcess/gtk/WebProcessMainGtk.cpp:

Source/WTF:

Do not define HAVE_OS_DARK_MODE_SUPPORT for the GTK port.

* wtf/PlatformHave.h:

LayoutTests:

Rebaseline several tests for the new behavior.

* platform/gtk/css-dark-mode/color-scheme-priority-expected.txt: Added.
* platform/gtk/css-dark-mode/default-colors-expected.txt:
* platform/gtk/css-dark-mode/prefers-color-scheme-expected.txt:

Modified Paths

releases/WebKitGTK/webkit-2.26/ChangeLog
releases/WebKitGTK/webkit-2.26/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.26/LayoutTests/platform/gtk/css-dark-mode/default-colors-expected.txt
releases/WebKitGTK/webkit-2.26/LayoutTests/platform/gtk/css-dark-mode/prefers-color-scheme-expected.txt
releases/WebKitGTK/webkit-2.26/Source/WTF/ChangeLog
releases/WebKitGTK/webkit-2.26/Source/WTF/wtf/Platform.h
releases/WebKitGTK/webkit-2.26/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.26/Source/WebCore/dom/Document.cpp
releases/WebKitGTK/webkit-2.26/Source/WebCore/page/FrameView.cpp
releases/WebKitGTK/webkit-2.26/Source/WebCore/page/Page.cpp
releases/WebKitGTK/webkit-2.26/Source/WebCore/rendering/RenderThemeGtk.cpp
releases/WebKitGTK/webkit-2.26/Source/WebCore/rendering/RenderThemeGtk.h
releases/WebKitGTK/webkit-2.26/Source/WebCore/testing/InternalSettings.cpp
releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.26/Source/WebKit/Shared/WebPageCreationParameters.cpp
releases/WebKitGTK/webkit-2.26/Source/WebKit/Shared/WebPageCreationParameters.h
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/PageClient.h
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/WebPageProxy.cpp
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/WebPageProxy.h
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp
releases/WebKitGTK/webkit-2.26/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp
releases/WebKitGTK/webkit-2.26/Source/WebKit/WebProcess/WebPage/WebPage.cpp

[webkit-changes] [255349] releases/WebKitGTK/webkit-2.26/Source/WebKit

[carlosgc]

Title: [255349] releases/WebKitGTK/webkit-2.26/Source/WebKit








Revision 255349
Author carlo...@webkit.org
Date 2020-01-29 02:38:26 -0800 (Wed, 29 Jan 2020)


Log Message
[GTK] Fix logic of dark theme detection
https://bugs.webkit.org/show_bug.cgi?id=202276

- If GTK_THEME is set it has a higher priority to GtkSettings.
- GTK_THEME may be a -dark theme or :dark variant, handle both.

Reviewed by Michael Catanzaro.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::effectiveAppearanceIsDark const):

Modified Paths

releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog (255348 => 255349)

--- releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog	2020-01-29 10:38:04 UTC (rev 255348)
+++ releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog	2020-01-29 10:38:26 UTC (rev 255349)
@@ -1,3 +1,16 @@
+2019-09-26  Patrick Griffis  
+
+[GTK] Fix logic of dark theme detection
+https://bugs.webkit.org/show_bug.cgi?id=202276
+
+- If GTK_THEME is set it has a higher priority to GtkSettings.
+- GTK_THEME may be a -dark theme or :dark variant, handle both.
+
+Reviewed by Michael Catanzaro.
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::effectiveAppearanceIsDark const):
+
 2020-01-28  Carlos Garcia Campos  
 
 [GTK][WPE] QR code not loaded in web.whatsapp.com


Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp (255348 => 255349)

--- releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp	2020-01-29 10:38:04 UTC (rev 255348)
+++ releases/WebKitGTK/webkit-2.26/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp	2020-01-29 10:38:26 UTC (rev 255349)
@@ -561,14 +561,14 @@
 if (preferDarkTheme)
 return true;
 
+if (auto* themeNameEnv = g_getenv("GTK_THEME"))
+return g_str_has_suffix(themeNameEnv, "-dark") || g_str_has_suffix(themeNameEnv, ":dark");
+
 GUniqueOutPtr themeName;
 g_object_get(settings, "gtk-theme-name", (), nullptr);
 if (g_str_has_suffix(themeName.get(), "-dark"))
 return true;
 
-if (auto* themeNameEnv = g_getenv("GTK_THEME"))
-return g_str_has_suffix(themeNameEnv, ":dark");
-
 return false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255348] trunk/Source/WebKit

[carlosgc]

Title: [255348] trunk/Source/WebKit








Revision 255348
Author carlo...@webkit.org
Date 2020-01-29 02:38:04 -0800 (Wed, 29 Jan 2020)


Log Message
Unreviewed. Move unsetenv to WebProcessMain.cpp after r255342

I forgot to do that before landing the patch.

* WebProcess/EntryPoint/unix/WebProcessMain.cpp:
(main):
* WebProcess/gtk/WebProcessMainGtk.cpp:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp
trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (255347 => 255348)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 10:35:27 UTC (rev 255347)
+++ trunk/Source/WebKit/ChangeLog	2020-01-29 10:38:04 UTC (rev 255348)
@@ -1,3 +1,13 @@
+2020-01-29  Carlos Garcia Campos  
+
+Unreviewed. Move unsetenv to WebProcessMain.cpp after r255342
+
+I forgot to do that before landing the patch.
+
+* WebProcess/EntryPoint/unix/WebProcessMain.cpp:
+(main):
+* WebProcess/gtk/WebProcessMainGtk.cpp:
+
 2020-01-29  youenn fablet  
 
 Send WebsiteDataStore media parameters to GPUProcess when needed


Modified: trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp (255347 => 255348)

--- trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp	2020-01-29 10:35:27 UTC (rev 255347)
+++ trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp	2020-01-29 10:38:04 UTC (rev 255348)
@@ -35,6 +35,9 @@
 
 int main(int argc, char** argv)
 {
+// Ignore the GTK_THEME environment variable, the theme is always set by the UI process now.
+unsetenv("GTK_THEME");
+
 #if USE(GCRYPT)
 PAL::GCrypt::initialize();
 #endif


Modified: trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp (255347 => 255348)

--- trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp	2020-01-29 10:35:27 UTC (rev 255347)
+++ trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp	2020-01-29 10:38:04 UTC (rev 255348)
@@ -54,9 +54,6 @@
 XInitThreads();
 #endif
 
-// Ignore the GTK_THEME environment variable, the theme is always set by the UI process now.
-g_unsetenv("GTK_THEME");
-
 gtk_init(nullptr, nullptr);
 
 bindtextdomain(GETTEXT_PACKAGE, LOCALEDIR);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255347] trunk

[youenn]

Title: [255347] trunk








Revision 255347
Author you...@apple.com
Date 2020-01-29 02:35:27 -0800 (Wed, 29 Jan 2020)


Log Message
Blob media loading does not work with GPUProcess
https://bugs.webkit.org/show_bug.cgi?id=206824


Reviewed by Eric Carlson.

Source/WebCore:

GPU process is using WebCoreAVFResourceLoader for various loads, including blob loads.
In GPU process, loads will fail since this loader expects a CachedResource, which only WebProcess can have.
For that reason, move the CachedResource loader part of WebCoreAVFResourceLoader to a dedicated class CachedResourceMediaLoader.
If load cannot happen with a CachedResource, use a new class PlatformResourceMediaLoader, which uses a loader from MediaPlayer::createResourceLoader.
This allows using the loading path in GPUProcess used for HTTP loads, which works for blob loads as well.

Covered by existing and enabled tests.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::CachedResourceMediaLoader::~CachedResourceMediaLoader):
(WebCore::CachedResourceMediaLoader::create):
(WebCore::CachedResourceMediaLoader::CachedResourceMediaLoader):
(WebCore::CachedResourceMediaLoader::stop):
(WebCore::CachedResourceMediaLoader::responseReceived):
(WebCore::CachedResourceMediaLoader::notifyFinished):
(WebCore::CachedResourceMediaLoader::dataReceived):
(WebCore::PlatformResourceMediaLoader::~PlatformResourceMediaLoader):
(WebCore::PlatformResourceMediaLoader::create):
(WebCore::PlatformResourceMediaLoader::PlatformResourceMediaLoader):
(WebCore::PlatformResourceMediaLoader::stop):
(WebCore::PlatformResourceMediaLoader::responseReceived):
(WebCore::PlatformResourceMediaLoader::loadFailed):
(WebCore::PlatformResourceMediaLoader::loadFinished):
(WebCore::PlatformResourceMediaLoader::dataReceived):
(WebCore::WebCoreAVFResourceLoader::startLoading):
(WebCore::WebCoreAVFResourceLoader::stopLoading):
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::loadFailed):
(WebCore::WebCoreAVFResourceLoader::loadFinished):
(WebCore::WebCoreAVFResourceLoader::newDataStoredInSharedBuffer):

LayoutTests:

* gpu-process/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (255346 => 255347)

--- trunk/LayoutTests/ChangeLog	2020-01-29 10:14:06 UTC (rev 255346)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 10:35:27 UTC (rev 255347)
@@ -1,5 +1,15 @@
 2020-01-29  youenn fablet  
 
+Blob media loading does not work with GPUProcess
+https://bugs.webkit.org/show_bug.cgi?id=206824
+
+
+Reviewed by Eric Carlson.
+
+* gpu-process/TestExpectations:
+
+2020-01-29  youenn fablet  
+
 [Cocoa] Use AVAssetWriterDelegate to implement MediaRecorder
 https://bugs.webkit.org/show_bug.cgi?id=206582
 


Modified: trunk/LayoutTests/gpu-process/TestExpectations (255346 => 255347)

--- trunk/LayoutTests/gpu-process/TestExpectations	2020-01-29 10:14:06 UTC (rev 255346)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2020-01-29 10:35:27 UTC (rev 255347)
@@ -182,6 +182,7 @@
 media/media-controller.html [ Pass ]
 media/media-preload-no-delay-loadevent.html [ Pass ]
 media/video-src.html [ Pass ]
+media/video-src-blob-using-open-panel.html [ Pass ]
 media/video-source.html [ Pass ]
 media/audio-as-video-fullscreen.html [ Pass ]
 media/audio-background-playback-playlist.html [ Pass ]


Modified: trunk/Source/WebCore/ChangeLog (255346 => 255347)

--- trunk/Source/WebCore/ChangeLog	2020-01-29 10:14:06 UTC (rev 255346)
+++ trunk/Source/WebCore/ChangeLog	2020-01-29 10:35:27 UTC (rev 255347)
@@ -1,5 +1,45 @@
 2020-01-29  youenn fablet  
 
+Blob media loading does not work with GPUProcess
+https://bugs.webkit.org/show_bug.cgi?id=206824
+
+
+Reviewed by Eric Carlson.
+
+GPU process is using WebCoreAVFResourceLoader for various loads, including blob loads.
+In GPU process, loads will fail since this loader expects a CachedResource, which only WebProcess can have.
+For that reason, move the CachedResource loader part of WebCoreAVFResourceLoader to a dedicated class CachedResourceMediaLoader.
+If load cannot happen with a CachedResource, use a new class PlatformResourceMediaLoader, which uses a loader from MediaPlayer::createResourceLoader.
+This allows using the loading path in GPUProcess used for HTTP loads, which works for blob loads as well.
+
+Covered by existing and enabled tests.
+
+* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
+* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
+

[webkit-changes] [255346] trunk/Source/WebKit

[youenn]

Title: [255346] trunk/Source/WebKit








Revision 255346
Author you...@apple.com
Date 2020-01-29 02:14:06 -0800 (Wed, 29 Jan 2020)


Log Message
Send WebsiteDataStore media parameters to GPUProcess when needed
https://bugs.webkit.org/show_bug.cgi?id=206870

Reviewed by Eric Carlson.

Whenever opening a new WebProcess/GPUProcess connection, make sure GPUProcess knows WebProcess session parameters.
Make sure to remove session parameters when data store is destroyed.
Update media code to no longer send the corresponding parameters for each media load.

Covered by existing tests no longer triggering sandbox violations.

* GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::mediaCacheDirectory const):
(WebKit::GPUConnectionToWebProcess::mediaKeysStorageDirectory const):
* GPUProcess/GPUConnectionToWebProcess.h:
* GPUProcess/GPUProcess.cpp:
(WebKit::GPUProcess::addSession):
(WebKit::GPUProcess::removeSession):
(WebKit::GPUProcess::mediaCacheDirectory const):
(WebKit::GPUProcess::mediaKeysStorageDirectory const):
* GPUProcess/GPUProcess.h:
* GPUProcess/GPUProcess.messages.in:
* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::load):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaKeysStorageDirectory const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaCacheDirectory const):
* GPUProcess/media/RemoteMediaPlayerProxy.h:
* GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
(WebKit::RemoteMediaPlayerProxyConfiguration::encode const):
(WebKit::RemoteMediaPlayerProxyConfiguration::decode):
* UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::singleton):
(WebKit::GPUProcessProxy::openGPUProcessConnection):
(WebKit::gpuProcessSessionParameters):
(WebKit::GPUProcessProxy::addSession):
(WebKit::GPUProcessProxy::removeSession):
* UIProcess/GPU/GPUProcessProxy.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::~WebsiteDataStore):
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.cpp
trunk/Source/WebKit/GPUProcess/GPUProcess.h
trunk/Source/WebKit/GPUProcess/GPUProcess.messages.in
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h
trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp
trunk/Source/WebKit/UIProcess/GPU/GPUProcessProxy.h
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp


Added Paths

trunk/Source/WebKit/GPUProcess/GPUProcessSessionParameters.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (255345 => 255346)

--- trunk/Source/WebKit/ChangeLog	2020-01-29 10:02:38 UTC (rev 255345)
+++ trunk/Source/WebKit/ChangeLog	2020-01-29 10:14:06 UTC (rev 255346)
@@ -1,5 +1,50 @@
 2020-01-29  youenn fablet  
 
+Send WebsiteDataStore media parameters to GPUProcess when needed
+https://bugs.webkit.org/show_bug.cgi?id=206870
+
+Reviewed by Eric Carlson.
+
+Whenever opening a new WebProcess/GPUProcess connection, make sure GPUProcess knows WebProcess session parameters.
+Make sure to remove session parameters when data store is destroyed.
+Update media code to no longer send the corresponding parameters for each media load.
+
+Covered by existing tests no longer triggering sandbox violations.
+
+* GPUProcess/GPUConnectionToWebProcess.cpp:
+(WebKit::GPUConnectionToWebProcess::mediaCacheDirectory const):
+(WebKit::GPUConnectionToWebProcess::mediaKeysStorageDirectory const):
+* GPUProcess/GPUConnectionToWebProcess.h:
+* GPUProcess/GPUProcess.cpp:
+(WebKit::GPUProcess::addSession):
+(WebKit::GPUProcess::removeSession):
+(WebKit::GPUProcess::mediaCacheDirectory const):
+(WebKit::GPUProcess::mediaKeysStorageDirectory const):
+* GPUProcess/GPUProcess.h:
+* GPUProcess/GPUProcess.messages.in:
+* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
+(WebKit::RemoteMediaPlayerProxy::load):
+(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaKeysStorageDirectory const):
+(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaCacheDirectory const):
+* GPUProcess/media/RemoteMediaPlayerProxy.h:
+* GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h:
+(WebKit::RemoteMediaPlayerProxyConfiguration::encode const):
+(WebKit::RemoteMediaPlayerProxyConfiguration::decode):
+* UIProcess/GPU/GPUProcessProxy.cpp:
+(WebKit::GPUProcessProxy::singleton):
+   

[webkit-changes] [255344] releases/WebKitGTK/webkit-2.26/Source/WebKit

[carlosgc]

Title: [255344] releases/WebKitGTK/webkit-2.26/Source/WebKit








Revision 255344
Author carlo...@webkit.org
Date 2020-01-29 01:55:29 -0800 (Wed, 29 Jan 2020)


Log Message
[GTK][WPE] QR code not loaded in web.whatsapp.com
https://bugs.webkit.org/show_bug.cgi?id=203404

Reviewed by Michael Catanzaro.

This is a regression of the switch to use libsoup API for the WebSockets implementation. The QR code is loaded
using a WebSocket connection, but the server is always replying with a 400 Bad Request to the Upgrade requests
coming from an existing HTTP connection. We need to ensure a new dedicated connection is used for WebSockets.

* NetworkProcess/soup/WebSocketTaskSoup.cpp:
(WebKit::WebSocketTask::WebSocketTask): Set the SOUP_MESSAGE_NEW_CONNECTION flag to the SoupMessage before
starting the connection.

Modified Paths

releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.26/Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp




Diff

Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog (255343 => 255344)

--- releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog	2020-01-29 09:52:17 UTC (rev 255343)
+++ releases/WebKitGTK/webkit-2.26/Source/WebKit/ChangeLog	2020-01-29 09:55:29 UTC (rev 255344)
@@ -1,3 +1,18 @@
+2020-01-28  Carlos Garcia Campos  
+
+[GTK][WPE] QR code not loaded in web.whatsapp.com
+https://bugs.webkit.org/show_bug.cgi?id=203404
+
+Reviewed by Michael Catanzaro.
+
+This is a regression of the switch to use libsoup API for the WebSockets implementation. The QR code is loaded
+using a WebSocket connection, but the server is always replying with a 400 Bad Request to the Upgrade requests
+coming from an existing HTTP connection. We need to ensure a new dedicated connection is used for WebSockets.
+
+* NetworkProcess/soup/WebSocketTaskSoup.cpp:
+(WebKit::WebSocketTask::WebSocketTask): Set the SOUP_MESSAGE_NEW_CONNECTION flag to the SoupMessage before
+starting the connection.
+
 2020-01-23  Adrian Perez de Castro  
 
 Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.26.3 release


Modified: releases/WebKitGTK/webkit-2.26/Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp (255343 => 255344)

--- releases/WebKitGTK/webkit-2.26/Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp	2020-01-29 09:52:17 UTC (rev 255343)
+++ releases/WebKitGTK/webkit-2.26/Source/WebKit/NetworkProcess/soup/WebSocketTaskSoup.cpp	2020-01-29 09:55:29 UTC (rev 255344)
@@ -47,6 +47,12 @@
 for (auto& subprotocol : protocolList)
 protocols.get()[i++] = g_strdup(WebCore::stripLeadingAndTrailingHTTPSpaces(subprotocol).utf8().data());
 }
+
+// Ensure a new connection is used for WebSockets.
+// FIXME: this is done by libsoup since 2.69.1 and 2.68.4, so it can be removed when bumping the libsoup requirement.
+// See https://bugs.webkit.org/show_bug.cgi?id=203404
+soup_message_set_flags(msg, static_cast(soup_message_get_flags(msg) | SOUP_MESSAGE_NEW_CONNECTION));
+
 soup_session_websocket_connect_async(session, msg, nullptr, protocols.get(), m_cancellable.get(),
 [] (GObject* session, GAsyncResult* result, gpointer userData) {
 GUniqueOutPtr error;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [255343] trunk/Source

[carlosgc]

Title: [255343] trunk/Source








Revision 255343
Author carlo...@webkit.org
Date 2020-01-29 01:52:17 -0800 (Wed, 29 Jan 2020)


Log Message
[GTK] WebDriver: screenshot ignores CSS transformations or WebGL content.
https://bugs.webkit.org/show_bug.cgi?id=206514

Reviewed by Carlos Alberto Lopez Perez.

Source/WebDriver:

* Session.cpp:
(WebDriver::Session::takeScreenshot): Always set clipToViewport to true.
* WebDriverService.cpp:
(WebDriver::WebDriverService::takeElementScreenshot): Stop pretending a GET command can have body.

Source/WebKit:

WebPage::scaledSnapshotWithOptions() doesn't work when accelerated compositing is enabled. To fix this, we
need to take the screenshot from the UI process, like we do for the layout tests.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::takeViewSnapshot): Pass clip rectangle to webkitWebViewBaseTakeViewSnapshot.
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseTakeViewSnapshot): Use the given clip rectangle if not nullopt.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::takeScreenshot): In case of full web view snapshot just call
WebPageProxy::takeViewSnapshot() with a nullopt clip rectangle. In case of element snapshot, send
SnapshotRectForScreenshot message to the web process to get the clip rectangle and then call
WebPageProxy::takeViewSnapshot().
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData): Empty implementation for other ports.
* UIProcess/Automation/WebAutomationSession.h: Make platformGetBase64EncodedPNGData() static.
* UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp:
(WebKit::base64EncodedPNGData): Moved common code to this new function.
(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData): New function to get the encoded PNG from a ViewSnapshot.
* UIProcess/PageClient.h: Add optional clip rectangle parameter to takeViewSnapshot().
* UIProcess/ViewSnapshotStore.cpp:
(WebKit::ViewSnapshotStore::recordSnapshot): Pass nullopt to takeViewSnapshot().
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::takeViewSnapshot):
* UIProcess/mac/PageClientImplMac.h:
* UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::takeViewSnapshot):
* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::snapshotElementRectForScreenshot): Renamed to avoid conflict with new IPC message handler.
(WebKit::WebAutomationSessionProxy::takeScreenshot): Call snapshotRectForScreenshot() to get the snapshot
rectangle and convert it to document coords.
(WebKit::WebAutomationSessionProxy::snapshotRectForScreenshot): Get the snapshot rectangle in client coords.
(WebKit::snapshotRectForScreenshot): Deleted.
* WebProcess/Automation/WebAutomationSessionProxy.h:
* WebProcess/Automation/WebAutomationSessionProxy.messages.in: Add SnapshotRectForScreenshot message.

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/Session.cpp
trunk/Source/WebDriver/WebDriverService.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h
trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
trunk/Source/WebKit/UIProcess/Automation/WebAutomationSession.h
trunk/Source/WebKit/UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp
trunk/Source/WebKit/UIProcess/PageClient.h
trunk/Source/WebKit/UIProcess/ViewSnapshotStore.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.h
trunk/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.h
trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm
trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.h
trunk/Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.messages.in




Diff

Modified: trunk/Source/WebDriver/ChangeLog (255342 => 255343)

--- trunk/Source/WebDriver/ChangeLog	2020-01-29 09:49:33 UTC (rev 255342)
+++ trunk/Source/WebDriver/ChangeLog	2020-01-29 09:52:17 UTC (rev 255343)
@@ -1,3 +1,15 @@
+2020-01-29  Carlos Garcia Campos  
+
+[GTK] WebDriver: screenshot ignores CSS transformations or WebGL content.
+https://bugs.webkit.org/show_bug.cgi?id=206514
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* Session.cpp:
+(WebDriver::Session::takeScreenshot): Always set clipToViewport to true.
+* WebDriverService.cpp:
+(WebDriver::WebDriverService::takeElementScreenshot): Stop pretending a GET command can have body.
+
 2020-01-13  Carlos 

[webkit-changes] [255342] trunk

[carlosgc]

Title: [255342] trunk








Revision 255342
Author carlo...@webkit.org
Date 2020-01-29 01:49:33 -0800 (Wed, 29 Jan 2020)


Log Message
[GTK] Should use light theme unless website declares support for dark themes in color-schemes property
https://bugs.webkit.org/show_bug.cgi?id=197947

Reviewed by Michael Catanzaro.

.:

Do not define HAVE_OS_DARK_MODE_SUPPORT.

* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::useDarkAppearance const): Remove HAVE(OS_DARK_MODE_SUPPORT) because ENABLE(DARK_MODE_CSS)
guards should be enough.
* page/FrameView.cpp:
(WebCore::FrameView::updateBackgroundRecursively): Revert changes made in r244635.
* page/Page.cpp:
(WebCore::Page::effectiveAppearanceDidChange): Use ENABLE(DARK_MODE_CSS) instead of HAVE(OS_DARK_MODE_SUPPORT).
(WebCore::Page::useDarkAppearance const): Ditto.
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::systemColor const): Revert changes made in r244635.
* rendering/RenderThemeGtk.h:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::setUseDarkAppearanceInternal): Revert changes made in r244635.

Source/WebKit:

Handle the theme changes in the UI process, converting dark variant to the light one before sending the theme
name to the web process. The web process is still notified when a dark theme is in use, so that if website
prefers a dark color scheme it will be used, but the gtk theme that will be used for controls styling will
always be light.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const): Encode themeName.
(WebKit::WebPageCreationParameters::decode): Decode themeName.
* Shared/WebPageCreationParameters.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::themeName const): Get the theme name that should be used by the web process.
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(themeChanged): Call WebPageProxy::themeDidChange().
(applicationPreferDarkThemeChanged):
(webkitWebViewBaseSetToplevelOnScreenWindow): Use a different callback for the theme name change.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::themeDidChange): Send ThemeDidChange message to the web process with the theme name to use.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize the theme name.
(WebKit::WebPage::effectiveAppearanceDidChange): Use this now for GTK port too.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add ThemeDidChange message.
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::themeDidChange): Set the theme given name in gtk settings.
* WebProcess/gtk/WebProcessMainGtk.cpp:

Source/WTF:

Do not define HAVE_OS_DARK_MODE_SUPPORT for the GTK port.

* wtf/PlatformHave.h:

LayoutTests:

Rebaseline several tests for the new behavior.

* platform/gtk/css-dark-mode/color-scheme-priority-expected.txt: Added.
* platform/gtk/css-dark-mode/default-colors-expected.txt:
* platform/gtk/css-dark-mode/prefers-color-scheme-expected.txt:

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/css-dark-mode/default-colors-expected.txt
trunk/LayoutTests/platform/gtk/css-dark-mode/prefers-color-scheme-expected.txt
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp
trunk/Source/WebCore/rendering/RenderThemeGtk.h
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp
trunk/Source/WebKit/Shared/WebPageCreationParameters.h
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.h
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit/UIProcess/PageClient.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp
trunk/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp
trunk/Source/cmake/OptionsGTK.cmake


Added Paths

trunk/LayoutTests/platform/gtk/css-dark-mode/color-scheme-priority-expected.txt




Diff

Modified: trunk/ChangeLog (255341 => 255342)

--- trunk/ChangeLog	2020-01-29 08:58:38 UTC (rev 255341)
+++ trunk/ChangeLog	2020-01-29 09:49:33 UTC (rev 255342)
@@ -1,3 +1,14 @@
+2020-01-28  Carlos Garcia Campos  
+
+[GTK] Should use light theme unless website declares support for dark themes in color-schemes property
+https://bugs.webkit.org/show_bug.cgi?id=197947
+
+

[webkit-changes] [255341] trunk/LayoutTests

[megan_gardner]

Title: [255341] trunk/LayoutTests








Revision 255341
Author megan_gard...@apple.com
Date 2020-01-29 00:58:38 -0800 (Wed, 29 Jan 2020)


Log Message
Fix compositing/video/poster.html test by making blending image opque to deal with flakey failures.
https://bugs.webkit.org/show_bug.cgi?id=206916


Reviewed by Simon Fraser.

Test was failing due to flakey alpha issues. Alpha isn't what we are testing with this test, so use an opaque image instead.

* compositing/resources/simple_image_opaque.png: Added.
* compositing/video/poster-expected.html:
* compositing/video/poster.html:
* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/compositing/video/poster-expected.html
trunk/LayoutTests/compositing/video/poster.html
trunk/LayoutTests/platform/ios-wk2/TestExpectations


Added Paths

trunk/LayoutTests/compositing/resources/simple_image_opaque.png




Diff

Modified: trunk/LayoutTests/ChangeLog (255340 => 255341)

--- trunk/LayoutTests/ChangeLog	2020-01-29 08:04:56 UTC (rev 255340)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 08:58:38 UTC (rev 255341)
@@ -1,3 +1,18 @@
+2020-01-29  Megan Gardner  
+
+Fix compositing/video/poster.html test by making blending image opque to deal with flakey failures.
+https://bugs.webkit.org/show_bug.cgi?id=206916
+
+
+Reviewed by Simon Fraser.
+
+Test was failing due to flakey alpha issues. Alpha isn't what we are testing with this test, so use an opaque image instead.
+
+* compositing/resources/simple_image_opaque.png: Added.
+* compositing/video/poster-expected.html:
+* compositing/video/poster.html:
+* platform/ios-wk2/TestExpectations:
+
 2020-01-29  Sunny He  
 
 Nullptr crash when setting custom properties on detached style


Added: trunk/LayoutTests/compositing/resources/simple_image_opaque.png

(Binary files differ)

Index: trunk/LayoutTests/compositing/resources/simple_image_opaque.png
===
--- trunk/LayoutTests/compositing/resources/simple_image_opaque.png	2020-01-29 08:04:56 UTC (rev 255340)
+++ trunk/LayoutTests/compositing/resources/simple_image_opaque.png	2020-01-29 08:58:38 UTC (rev 255341)
Property changes on: trunk/LayoutTests/compositing/resources/simple_image_opaque.png
___

Added: svn:mime-type
+image/png
\ No newline at end of property

Modified: trunk/LayoutTests/compositing/video/poster-expected.html (255340 => 255341)

--- trunk/LayoutTests/compositing/video/poster-expected.html	2020-01-29 08:04:56 UTC (rev 255340)
+++ trunk/LayoutTests/compositing/video/poster-expected.html	2020-01-29 08:58:38 UTC (rev 255341)
@@ -16,6 +16,6 @@
 
 
 This test makes sure that video posters are displayed even after the source is loaded
-
+
 
 


Modified: trunk/LayoutTests/compositing/video/poster.html (255340 => 255341)

--- trunk/LayoutTests/compositing/video/poster.html	2020-01-29 08:04:56 UTC (rev 255340)
+++ trunk/LayoutTests/compositing/video/poster.html	2020-01-29 08:58:38 UTC (rev 255341)
@@ -17,7 +17,7 @@
 
 
 This test makes sure that video posters are displayed even after the source is loaded
-
+
 

[webkit-changes] [255340] trunk

[commit-queue]

Title: [255340] trunk








Revision 255340
Author commit-qu...@webkit.org
Date 2020-01-29 00:04:56 -0800 (Wed, 29 Jan 2020)


Log Message
Nullptr crash when setting custom properties on detached style
https://bugs.webkit.org/show_bug.cgi?id=206724

Patch by Sunny He  on 2020-01-29
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/StyleSheet/detached-style-set-custom-property.html

* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::StyleRuleCSSStyleDeclaration::clearParentRule):
(WebCore::InlineCSSStyleDeclaration::clearParentElement):

LayoutTests:

* fast/dom/StyleSheet/detached-style-set-custom-property-expected.txt: Added.
* fast/dom/StyleSheet/detached-style-set-custom-property.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp


Added Paths

trunk/LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property-expected.txt
trunk/LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property.html




Diff

Modified: trunk/LayoutTests/ChangeLog (255339 => 255340)

--- trunk/LayoutTests/ChangeLog	2020-01-29 07:18:55 UTC (rev 255339)
+++ trunk/LayoutTests/ChangeLog	2020-01-29 08:04:56 UTC (rev 255340)
@@ -1,3 +1,13 @@
+2020-01-29  Sunny He  
+
+Nullptr crash when setting custom properties on detached style
+https://bugs.webkit.org/show_bug.cgi?id=206724
+
+Reviewed by Darin Adler.
+
+* fast/dom/StyleSheet/detached-style-set-custom-property-expected.txt: Added.
+* fast/dom/StyleSheet/detached-style-set-custom-property.html: Added.
+
 2020-01-28  Pinki Gyanchandani  
 
 Null deref crash in DOMWindow::scrollBy after evoking updateLayoutIgnorePendingStylesheets()


Added: trunk/LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property-expected.txt (0 => 255340)

--- trunk/LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property-expected.txt	2020-01-29 08:04:56 UTC (rev 255340)
@@ -0,0 +1,11 @@
+Test setting custom properties on detached styles
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS element.attributes[0].name is "style"
+PASS inlineStyle.getPropertyValue("--cssvarc") is "inherit"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property.html (0 => 255340)

--- trunk/LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/StyleSheet/detached-style-set-custom-property.html	2020-01-29 08:04:56 UTC (rev 255340)
@@ -0,0 +1,19 @@
+
+
+
+
+