[webkit-changes] [289519] trunk
Title: [289519] trunk
Revision 289519
Author ross.kirsl...@sony.com
Date 2022-02-09 22:00:01 -0800 (Wed, 09 Feb 2022)
Log Message
SharedMemoryUnix should use SHM_ANON when available
https://bugs.webkit.org/show_bug.cgi?id=236416
Reviewed by Don Olmstead.
.:
* Source/cmake/OptionsCommon.cmake: Check for SHM_ANON.
Source/WebKit:
FreeBSD is able to use shm_open(SHM_ANON, ...) to create an anonymous shared memory object which is subject to RAII:
https://www.freebsd.org/cgi/man.cgi?query=shm_open
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::createSharedMemory):
Make use of SHM_ANON if we have it.
Modified Paths
trunk/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp
trunk/Source/cmake/OptionsCommon.cmake
Diff
Modified: trunk/ChangeLog (289518 => 289519)
--- trunk/ChangeLog 2022-02-10 05:18:02 UTC (rev 289518)
+++ trunk/ChangeLog 2022-02-10 06:00:01 UTC (rev 289519)
@@ -1,3 +1,12 @@
+2022-02-09 Ross Kirsling
+
+SharedMemoryUnix should use SHM_ANON when available
+https://bugs.webkit.org/show_bug.cgi?id=236416
+
+Reviewed by Don Olmstead.
+
+* Source/cmake/OptionsCommon.cmake: Check for SHM_ANON.
+
2022-02-09 Adrian Perez de Castro
[CMake] REGRESSION(r288994): Setting multiple values in LDFLAGS causes incorrect linker detection
Modified: trunk/Source/WebKit/ChangeLog (289518 => 289519)
--- trunk/Source/WebKit/ChangeLog 2022-02-10 05:18:02 UTC (rev 289518)
+++ trunk/Source/WebKit/ChangeLog 2022-02-10 06:00:01 UTC (rev 289519)
@@ -1,3 +1,17 @@
+2022-02-09 Ross Kirsling
+
+SharedMemoryUnix should use SHM_ANON when available
+https://bugs.webkit.org/show_bug.cgi?id=236416
+
+Reviewed by Don Olmstead.
+
+FreeBSD is able to use shm_open(SHM_ANON, ...) to create an anonymous shared memory object which is subject to RAII:
+https://www.freebsd.org/cgi/man.cgi?query=shm_open
+
+* Platform/unix/SharedMemoryUnix.cpp:
+(WebKit::createSharedMemory):
+Make use of SHM_ANON if we have it.
+
2022-02-09 Said Abou-Hallawa
[GPU Process] Move ImageBuffer::createCompatibleImageBuffer() and SVGRenderingContext::createImageBuffer to GraphicsContext
Modified: trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp (289518 => 289519)
--- trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp 2022-02-10 05:18:02 UTC (rev 289518)
+++ trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp 2022-02-10 06:00:01 UTC (rev 289519)
@@ -146,6 +146,11 @@
}
#endif
+#if HAVE(SHM_ANON)
+do {
+fileDescriptor = shm_open(SHM_ANON, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR);
+} while (fileDescriptor == -1 && errno == EINTR);
+#else
CString tempName;
for (int tries = 0; fileDescriptor == -1 && tries < 10; ++tries) {
String name = String("/WK2SharedMemory.") + String::number(static_cast(WTF::randomNumber() * (std::numeric_limits::max() + 1.0)));
@@ -158,6 +163,7 @@
if (fileDescriptor != -1)
shm_unlink(tempName.data());
+#endif
return fileDescriptor;
}
Modified: trunk/Source/cmake/OptionsCommon.cmake (289518 => 289519)
--- trunk/Source/cmake/OptionsCommon.cmake 2022-02-10 05:18:02 UTC (rev 289518)
+++ trunk/Source/cmake/OptionsCommon.cmake 2022-02-10 06:00:01 UTC (rev 289519)
@@ -203,6 +203,7 @@
if (NOT (${CMAKE_SYSTEM_NAME} STREQUAL "Darwin"))
WEBKIT_CHECK_HAVE_SYMBOL(HAVE_PTHREAD_MAIN_NP pthread_main_np pthread_np.h)
endif ()
+WEBKIT_CHECK_HAVE_SYMBOL(HAVE_SHM_ANON SHM_ANON sys/mman.h)
WEBKIT_CHECK_HAVE_SYMBOL(HAVE_TIMINGSAFE_BCMP timingsafe_bcmp string.h)
# Windows has signal.h but is missing symbols that are used in calls to signal.
WEBKIT_CHECK_HAVE_SYMBOL(HAVE_SIGNAL_H SIGTRAP signal.h)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289518] trunk/Source
Title: [289518] trunk/Source Revision 289518 Author s...@apple.com Date 2022-02-09 21:18:02 -0800 (Wed, 09 Feb 2022) Log Message [GPU Process] Move ImageBuffer::createCompatibleImageBuffer() and SVGRenderingContext::createImageBuffer to GraphicsContext https://bugs.webkit.org/show_bug.cgi?id=235758 rdar://88478470 Reviewed by Simon Fraser. Source/WebCore: The goal of this patch is to record the drawing if the concrete type of the GraphicsContext is RemoteDisplayListRecorderProxy. Currently all the intermediate compatible ImageBuffers are of type ConcreteImageBuffer. The drawing to these ImageBuffers still happens in the WebProcess. Moreover when we call drawImageBuffer() or clipToImageBuffer() for one of these intermediate ImageBuffers to a remote ImageBuffer, we have to sink the intermediate ImageBuffer to a NativeImage and send it to GPUProcess. To fix this, the new enum 'RenderingMethod' will be used when creating the ImageBuffer methods. The value of RenderingMethod can be one of the following constants: 1. Default: The type of the created ImageBuffer will match the type of the underlying ImageBuffer of the GraphicsContext. 2. DisplayList: A DisplayList::ImageBuffer will be created whose GraphicsContext will be of type DisplayList::RecorderImpl. 3. Local: The ImageBuffer will be of type ConcreteImageBuffer and it will hold a platform GraphicsContext. Also GraphicsContext will provide these functions for creating an ImageBuffer: 1. GraphicsContext::createImageBuffer() (virtual): Creates a ConcreteImageBuffer or a DisplayList::ImageBuffer. The type of the created ImageBuffer is controlled by the argument 'renderingMethod'. Because RemoteDisplayListRecorderProxy is a super class of GraphicsContext, it overrides this method and returns the desired RemoteImageBuffer. RemoteDisplayListRecorderProxy has access to RemotRenderingBackendProxy so it can call its createImageBuffer(). 2. GraphicsContext::createImageBuffer() (non-virtual): Creates a scaled ImageBuffer and sets the context accordingly. The type of the created ImageBuffer is controlled by the argument 'renderingMethod'. 3. GraphicsContext::createCompatibleImageBuffer() (virtual): Takes the scaleFactor() into consideration when creating the ImageBuffer. RemoteDisplayListRecorderProxy will override this function to return an Unaccelerated ImageBuffer if 'renderingMethod != Default'. This is to ensure that for GPUProcess drawing, no intermediate local ImageBuffers will draw to an IOSurface in WebProcess. Two versions of these functions are provided: one takes a FloatSize and the other takes a FloatRecct. The FloatRect version expands the four corners of the rectangle to full pixels. * html/CustomPaintCanvas.cpp: (WebCore::CustomPaintCanvas::replayDisplayList const): * html/CustomPaintImage.cpp: (WebCore::CustomPaintImage::drawPattern): * html/OffscreenCanvas.cpp: (WebCore::OffscreenCanvas::transferToImageBitmap): (WebCore::OffscreenCanvas::commitToPlaceholderCanvas): * html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::drawImage): * platform/cocoa/ThemeCocoa.mm: (WebCore::drawApplePayButton): * platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::drawPattern): * platform/graphics/CrossfadeGeneratedImage.cpp: (WebCore::CrossfadeGeneratedImage::drawPattern): * platform/graphics/GradientImage.cpp: (WebCore::GradientImage::drawPattern): * platform/graphics/GraphicsContext.cpp: (WebCore::scaledImageBufferSize): (WebCore::scaledImageBufferRect): (WebCore::clampingScaleForImageBufferSize): (WebCore::GraphicsContext::compatibleImageBufferSize const): (WebCore::GraphicsContext::createImageBuffer const): (WebCore::GraphicsContext::createCompatibleImageBuffer const): (WebCore::GraphicsContext::clipToDrawingCommands): * platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::createImageBuffer): * platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::clone const): (WebCore::ImageBuffer::createCompatibleBuffer): Deleted. (WebCore::ImageBuffer::compatibleBufferSize): Deleted. (WebCore::ImageBuffer::compatibleBufferInfo): Deleted. (WebCore::ImageBuffer::copyRectToBuffer): Deleted. * platform/graphics/ImageBuffer.h: * platform/graphics/NamedImageGeneratedImage.cpp: (WebCore::NamedImageGeneratedImage::drawPattern): * platform/graphics/RenderingMode.h: * platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::updateCachedImageIfNeeded): (WebCore::PDFDocumentImage::draw): * platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp: (WebCore::DrawGlyphsRecorder::drawOTSVGRun): * platform/graphics/displaylists/DisplayListRecorder.cpp: (WebCore::DisplayList::Recorder::createImageBuffer const): * platform/graphics/displaylists/DisplayListRecorder.h: * platform/graphics/displaylists/DisplayListReplayer.cpp: (WebCore::DisplayList::Replayer::applyItem): * platform/mac/ThemeMac.mm: (WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext): * re
[webkit-changes] [289517] trunk/Source/WebCore
Title: [289517] trunk/Source/WebCore
Revision 289517
Author lmo...@igalia.com
Date 2022-02-09 20:11:48 -0800 (Wed, 09 Feb 2022)
Log Message
Unreviewed, non-unified build fix after r289474
https://bugs.webkit.org/show_bug.cgi?id=236425
* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (289516 => 289517)
--- trunk/Source/WebCore/ChangeLog 2022-02-10 01:50:38 UTC (rev 289516)
+++ trunk/Source/WebCore/ChangeLog 2022-02-10 04:11:48 UTC (rev 289517)
@@ -1,3 +1,10 @@
+2022-02-09 Lauro Moura
+
+Unreviewed, non-unified build fix after r289474
+https://bugs.webkit.org/show_bug.cgi?id=236425
+
+* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
+
2022-02-09 Eric Carlson
WKWebView: WKURLSchemeHandler “request to the end of the resource” produces an invalid header
Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp (289516 => 289517)
--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp 2022-02-10 01:50:38 UTC (rev 289516)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp 2022-02-10 04:11:48 UTC (rev 289517)
@@ -30,6 +30,8 @@
#include "IDBResultData.h"
#include "Logging.h"
#include "UniqueIDBDatabase.h"
+#include "UniqueIDBDatabaseConnection.h"
+#include "UniqueIDBDatabaseManager.h"
namespace WebCore {
namespace IDBServer {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289515] trunk/Source/JavaScriptCore
Title: [289515] trunk/Source/_javascript_Core
Revision 289515
Author ysuz...@apple.com
Date 2022-02-09 17:50:04 -0800 (Wed, 09 Feb 2022)
Log Message
Use local variable pointer for concurrently load value
https://bugs.webkit.org/show_bug.cgi?id=236387
Reviewed by Saam Barati.
Consistently using local pointer to load member fields in
1. WriteBarrierStructureID
2. JSString's fiber
3. Weak
4. WriteBarrier
to encourage compilers not to load the field twice.
* heap/Weak.cpp:
(JSC::weakClearSlowCase):
* heap/Weak.h:
(JSC::Weak::isHashTableEmptyValue const):
(JSC::Weak::unsafeImpl const):
(JSC::Weak::clear):
(JSC::Weak::impl const):
* heap/WeakInlines.h:
(JSC::Weak::isHashTableDeletedValue const):
(JSC:: const):
(JSC::Weak::operator const):
(JSC::Weak::get const):
(JSC::Weak::leakImpl):
* runtime/JSString.cpp:
(JSC::JSString::dumpToStream):
(JSC::JSString::estimatedSize):
(JSC::JSString::visitChildrenImpl):
* runtime/JSString.h:
(JSC::JSString::fiberConcurrently const):
(JSC::JSString::is8Bit const):
(JSC::JSString::length const):
(JSC::JSString::tryGetValueImpl const):
(JSC::JSString::isSubstring const):
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get const):
(JSC::WriteBarrierBase::operator* const):
(JSC::WriteBarrierBase::operator-> const):
(JSC::WriteBarrierBase::operator bool const):
(JSC::WriteBarrierBase::operator! const):
(JSC::WriteBarrierBase::unvalidatedGet const):
(JSC::WriteBarrierBase::cell const):
(JSC::WriteBarrierStructureID::get const):
(JSC::WriteBarrierStructureID::operator* const):
(JSC::WriteBarrierStructureID::operator-> const):
(JSC::WriteBarrierStructureID::operator bool const):
(JSC::WriteBarrierStructureID::operator! const):
(JSC::WriteBarrierStructureID::unvalidatedGet const):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Weak.cpp
trunk/Source/_javascript_Core/heap/Weak.h
trunk/Source/_javascript_Core/heap/WeakInlines.h
trunk/Source/_javascript_Core/runtime/JSString.cpp
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Core/runtime/WriteBarrier.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (289514 => 289515)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-10 01:27:42 UTC (rev 289514)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-10 01:50:04 UTC (rev 289515)
@@ -1,3 +1,57 @@
+2022-02-09 Yusuke Suzuki
+
+Use local variable pointer for concurrently load value
+https://bugs.webkit.org/show_bug.cgi?id=236387
+
+Reviewed by Saam Barati.
+
+Consistently using local pointer to load member fields in
+
+1. WriteBarrierStructureID
+2. JSString's fiber
+3. Weak
+4. WriteBarrier
+
+to encourage compilers not to load the field twice.
+
+* heap/Weak.cpp:
+(JSC::weakClearSlowCase):
+* heap/Weak.h:
+(JSC::Weak::isHashTableEmptyValue const):
+(JSC::Weak::unsafeImpl const):
+(JSC::Weak::clear):
+(JSC::Weak::impl const):
+* heap/WeakInlines.h:
+(JSC::Weak::isHashTableDeletedValue const):
+(JSC:: const):
+(JSC::Weak::operator const):
+(JSC::Weak::get const):
+(JSC::Weak::leakImpl):
+* runtime/JSString.cpp:
+(JSC::JSString::dumpToStream):
+(JSC::JSString::estimatedSize):
+(JSC::JSString::visitChildrenImpl):
+* runtime/JSString.h:
+(JSC::JSString::fiberConcurrently const):
+(JSC::JSString::is8Bit const):
+(JSC::JSString::length const):
+(JSC::JSString::tryGetValueImpl const):
+(JSC::JSString::isSubstring const):
+* runtime/WriteBarrier.h:
+(JSC::WriteBarrierBase::get const):
+(JSC::WriteBarrierBase::operator* const):
+(JSC::WriteBarrierBase::operator-> const):
+(JSC::WriteBarrierBase::operator bool const):
+(JSC::WriteBarrierBase::operator! const):
+(JSC::WriteBarrierBase::unvalidatedGet const):
+(JSC::WriteBarrierBase::cell const):
+(JSC::WriteBarrierStructureID::get const):
+(JSC::WriteBarrierStructureID::operator* const):
+(JSC::WriteBarrierStructureID::operator-> const):
+(JSC::WriteBarrierStructureID::operator bool const):
+(JSC::WriteBarrierStructureID::operator! const):
+(JSC::WriteBarrierStructureID::unvalidatedGet const):
+
2022-02-09 Lauro Moura
Non-unified build fixes after r289247
Modified: trunk/Source/_javascript_Core/heap/Weak.cpp (289514 => 289515)
--- trunk/Source/_javascript_Core/heap/Weak.cpp 2022-02-10 01:27:42 UTC (rev 289514)
+++ trunk/Source/_javascript_Core/heap/Weak.cpp 2022-02-10 01:50:04 UTC (rev 289515)
@@ -30,12 +30,10 @@
namespace JSC {
-void weakClearSlowCase(WeakImpl*& impl)
+void weakClearSlowCase(WeakImpl* impl)
{
ASSERT(impl);
-
WeakSet::deallocate(impl);
-impl = nullptr;
}
} // namespace JSC
Modified: trunk/Source/_java
[webkit-changes] [289514] trunk/Source
Title: [289514] trunk/Source
Revision 289514
Author wenson_hs...@apple.com
Date 2022-02-09 17:27:42 -0800 (Wed, 09 Feb 2022)
Log Message
Add some WebKitAdditions extension points in VisionKitCore SPI and softlinking headers
https://bugs.webkit.org/show_bug.cgi?id=236403
rdar://88709972
Reviewed by Aditya Keerthi.
Source/WebCore/PAL:
Add new WebKitAdditions header includes.
* pal/cocoa/VisionKitCoreSoftLink.h:
* pal/cocoa/VisionKitCoreSoftLink.mm:
Source/WebKit:
Declare a new helper function in TextRecognitionUtilities.h.
* Platform/cocoa/TextRecognitionUtilities.h:
* Platform/cocoa/TextRecognitionUtilities.mm:
Modified Paths
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.h
trunk/Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h
trunk/Source/WebKit/Platform/cocoa/TextRecognitionUtilities.mm
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (289513 => 289514)
--- trunk/Source/WebCore/PAL/ChangeLog 2022-02-10 01:27:00 UTC (rev 289513)
+++ trunk/Source/WebCore/PAL/ChangeLog 2022-02-10 01:27:42 UTC (rev 289514)
@@ -1,3 +1,16 @@
+2022-02-09 Wenson Hsieh
+
+Add some WebKitAdditions extension points in VisionKitCore SPI and softlinking headers
+https://bugs.webkit.org/show_bug.cgi?id=236403
+rdar://88709972
+
+Reviewed by Aditya Keerthi.
+
+Add new WebKitAdditions header includes.
+
+* pal/cocoa/VisionKitCoreSoftLink.h:
+* pal/cocoa/VisionKitCoreSoftLink.mm:
+
2022-02-09 Antoine Quint
[model] improve sizing on macOS
Modified: trunk/Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.h (289513 => 289514)
--- trunk/Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.h 2022-02-10 01:27:00 UTC (rev 289513)
+++ trunk/Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.h 2022-02-10 01:27:42 UTC (rev 289514)
@@ -36,4 +36,8 @@
SOFT_LINK_CLASS_FOR_HEADER(PAL, VKCImageAnalyzer)
SOFT_LINK_CLASS_FOR_HEADER(PAL, VKCImageAnalyzerRequest)
+#if USE(APPLE_INTERNAL_SDK)
+#import
+#endif
+
#endif // HAVE(VK_IMAGE_ANALYSIS)
Modified: trunk/Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.mm (289513 => 289514)
--- trunk/Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.mm 2022-02-10 01:27:00 UTC (rev 289513)
+++ trunk/Source/WebCore/PAL/pal/cocoa/VisionKitCoreSoftLink.mm 2022-02-10 01:27:42 UTC (rev 289514)
@@ -36,4 +36,8 @@
SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_IS_OPTIONAL(PAL, VisionKitCore, VKCImageAnalyzer, PAL_EXPORT, true)
SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT_AND_IS_OPTIONAL(PAL, VisionKitCore, VKCImageAnalyzerRequest, PAL_EXPORT, true)
+#if USE(APPLE_INTERNAL_SDK)
+#import
+#endif
+
#endif // HAVE(VK_IMAGE_ANALYSIS)
Modified: trunk/Source/WebKit/ChangeLog (289513 => 289514)
--- trunk/Source/WebKit/ChangeLog 2022-02-10 01:27:00 UTC (rev 289513)
+++ trunk/Source/WebKit/ChangeLog 2022-02-10 01:27:42 UTC (rev 289514)
@@ -1,3 +1,16 @@
+2022-02-09 Wenson Hsieh
+
+Add some WebKitAdditions extension points in VisionKitCore SPI and softlinking headers
+https://bugs.webkit.org/show_bug.cgi?id=236403
+rdar://88709972
+
+Reviewed by Aditya Keerthi.
+
+Declare a new helper function in TextRecognitionUtilities.h.
+
+* Platform/cocoa/TextRecognitionUtilities.h:
+* Platform/cocoa/TextRecognitionUtilities.mm:
+
2022-02-09 Chris Dumez
[iOS] Take adequate process assertion for the SharedWorker process
Modified: trunk/Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h (289513 => 289514)
--- trunk/Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h 2022-02-10 01:27:00 UTC (rev 289513)
+++ trunk/Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h 2022-02-10 01:27:42 UTC (rev 289514)
@@ -58,6 +58,7 @@
#if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)
void requestImageAnalysisWithIdentifier(CocoaImageAnalyzer *, const String& identifier, CGImageRef, CompletionHandler&&);
+void requestImageAnalysisMarkup(CGImageRef, CompletionHandler&&);
#endif
}
Modified: trunk/Source/WebKit/Platform/cocoa/TextRecognitionUtilities.mm (289513 => 289514)
--- trunk/Source/WebKit/Platform/cocoa/TextRecognitionUtilities.mm 2022-02-10 01:27:00 UTC (rev 289513)
+++ trunk/Source/WebKit/Platform/cocoa/TextRecognitionUtilities.mm 2022-02-10 01:27:42 UTC (rev 289514)
@@ -30,9 +30,11 @@
#import "Logging.h"
#import
-#import
#import
+#import
+#import
+
namespace WebKit {
using namespace WebCore;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289512] branches/safari-613-branch
Title: [289512] branches/safari-613-branch
Revision 289512
Author alanc...@apple.com
Date 2022-02-09 17:26:56 -0800 (Wed, 09 Feb 2022)
Log Message
Cherry-pick r289450. rdar://problem/88483574
[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
https://bugs.webkit.org/show_bug.cgi?id=236332
rdar://88483574
Reviewed by Michael Saboff.
JSTests:
* stress/yarr-inlining-dot-star-enclosure.js: Added.
(test):
Source/_javascript_Core:
YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
* yarr/YarrJIT.cpp:
* yarr/YarrJITRegisters.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613-branch/JSTests/ChangeLog
branches/safari-613-branch/Source/_javascript_Core/ChangeLog
branches/safari-613-branch/Source/_javascript_Core/yarr/YarrJIT.cpp
branches/safari-613-branch/Source/_javascript_Core/yarr/YarrJITRegisters.h
Added Paths
branches/safari-613-branch/JSTests/stress/yarr-inlining-dot-star-enclosure.js
Diff
Modified: branches/safari-613-branch/JSTests/ChangeLog (289511 => 289512)
--- branches/safari-613-branch/JSTests/ChangeLog 2022-02-10 01:24:01 UTC (rev 289511)
+++ branches/safari-613-branch/JSTests/ChangeLog 2022-02-10 01:26:56 UTC (rev 289512)
@@ -1,3 +1,40 @@
+2022-02-09 Alan Coon
+
+Cherry-pick r289450. rdar://problem/88483574
+
+[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
+https://bugs.webkit.org/show_bug.cgi?id=236332
+rdar://88483574
+
+Reviewed by Michael Saboff.
+
+JSTests:
+
+* stress/yarr-inlining-dot-star-enclosure.js: Added.
+(test):
+
+Source/_javascript_Core:
+
+YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
+it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
+This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
+
+* yarr/YarrJIT.cpp:
+* yarr/YarrJITRegisters.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-08 Yusuke Suzuki
+
+[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
+https://bugs.webkit.org/show_bug.cgi?id=236332
+rdar://88483574
+
+Reviewed by Michael Saboff.
+
+* stress/yarr-inlining-dot-star-enclosure.js: Added.
+(test):
+
2022-02-07 Russell Epstein
Cherry-pick r288213. rdar://problem/87538657
Added: branches/safari-613-branch/JSTests/stress/yarr-inlining-dot-star-enclosure.js (0 => 289512)
--- branches/safari-613-branch/JSTests/stress/yarr-inlining-dot-star-enclosure.js (rev 0)
+++ branches/safari-613-branch/JSTests/stress/yarr-inlining-dot-star-enclosure.js 2022-02-10 01:26:56 UTC (rev 289512)
@@ -0,0 +1,9 @@
+function test(string)
+{
+return /.*\:.*/.test(string);
+}
+noInline(test);
+
+for (var i = 0; i < 1e4; ++i) {
+test(String(i));
+}
Modified: branches/safari-613-branch/Source/_javascript_Core/ChangeLog (289511 => 289512)
--- branches/safari-613-branch/Source/_javascript_Core/ChangeLog 2022-02-10 01:24:01 UTC (rev 289511)
+++ branches/safari-613-branch/Source/_javascript_Core/ChangeLog 2022-02-10 01:26:56 UTC (rev 289512)
@@ -1,3 +1,44 @@
+2022-02-09 Alan Coon
+
+Cherry-pick r289450. rdar://problem/88483574
+
+[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
+https://bugs.webkit.org/show_bug.cgi?id=236332
+rdar://88483574
+
+Reviewed by Michael Saboff.
+
+JSTests:
+
+* stress/yarr-inlining-dot-star-enclosure.js: Added.
+(test):
+
+Source/_javascript_Core:
+
+YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
+it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
+This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
+
+* yarr/YarrJIT.cpp:
+* yarr/YarrJITRegisters.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-08 Yusuke Suzuki
+
+[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
+https://bugs.webkit.org/show_bug.cgi?id=236332
+rdar://88483574
+
+Reviewed by Michael Saboff.
+
+YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
+it is not defined in YarrJIT inlining. As a result, we emit
[webkit-changes] [289513] branches/safari-613-branch/Source/WebCore
Title: [289513] branches/safari-613-branch/Source/WebCore Revision 289513 Author alanc...@apple.com Date 2022-02-09 17:27:00 -0800 (Wed, 09 Feb 2022) Log Message Cherry-pick r289383. rdar://problem/88366849 [WebCore] JSValueInWrappedObject is not correct for concurrent GC https://bugs.webkit.org/show_bug.cgi?id=236277 rdar://88366849 Reviewed by Saam Barati. JSValueInWrappedObject is broken for concurrent GC's marking. It is using std::variant<> to store Weak / JSValue, which is not safe if concurrent GC reads it while changing that std::variant. This patch fixes several problems in JSValueInWrappedObject. 1. We must not use std::variant here since concurrent access can happen. We have both JSValue and Weak, and change Weak after fully initialize WeakImpl's content in Weak. To ensure that, we emit storeStoreBarrier before setting Weak to the JSValueInWrappedObject's field. 2. Assignment operator & copy constructor are basically wrong for this class as we need a write-barrier to set a value to the field. We remove them and make it explicit that we do not have write-barrier, which reveals that IDBRequest has a semantic bug. 3. We also add clear() instead of assigning empty JSValueInWrappedObject. And we ensure that this new clear() works well with concurrent GC threads: we clear the underlying WeakImpl* pointer to nullptr. But since WeakImpl* is kept alive until GC clears weak-related things in its end phase, concurrent GC thread can access the old WeakImpl*. * Modules/indexeddb/IDBCursor.cpp: (WebCore::IDBCursor::setGetResult): * Modules/indexeddb/IDBRequest.cpp: (WebCore::IDBRequest::setResult): (WebCore::IDBRequest::setResultToStructuredClone): (WebCore::IDBRequest::setResultToUndefined): (WebCore::IDBRequest::willIterateCursor): (WebCore::IDBRequest::didOpenOrIterateCursor): * Modules/paymentrequest/PaymentMethodChangeEvent.cpp: * Modules/paymentrequest/PaymentResponse.cpp: (WebCore::PaymentResponse::setDetailsFunction): * Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::getChannelData): (WebCore::AudioBuffer::visitChannelWrappers): * bindings/js/JSValueInWrappedObject.h: (WebCore::JSValueInWrappedObject::JSValueInWrappedObject): (WebCore::JSValueInWrappedObject::operator JSC::JSValue const): (WebCore::JSValueInWrappedObject::visit const): (WebCore::JSValueInWrappedObject::setWeakly): (WebCore::JSValueInWrappedObject::set): (WebCore::JSValueInWrappedObject::clear): (WebCore::JSValueInWrappedObject::setWithoutBarrier): (WebCore::cachedPropertyValue): (WebCore::JSValueInWrappedObject::makeValue): Deleted. (WebCore::JSValueInWrappedObject::operator=): Deleted. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289383 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-613-branch/Source/WebCore/ChangeLog branches/safari-613-branch/Source/WebCore/Modules/indexeddb/IDBCursor.cpp branches/safari-613-branch/Source/WebCore/Modules/indexeddb/IDBRequest.cpp branches/safari-613-branch/Source/WebCore/Modules/paymentrequest/PaymentMethodChangeEvent.cpp branches/safari-613-branch/Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp branches/safari-613-branch/Source/WebCore/Modules/webaudio/AudioBuffer.cpp branches/safari-613-branch/Source/WebCore/bindings/js/JSValueInWrappedObject.h Diff Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (289512 => 289513) --- branches/safari-613-branch/Source/WebCore/ChangeLog 2022-02-10 01:26:56 UTC (rev 289512) +++ branches/safari-613-branch/Source/WebCore/ChangeLog 2022-02-10 01:27:00 UTC (rev 289513) @@ -1,3 +1,103 @@ +2022-02-09 Alan Coon + +Cherry-pick r289383. rdar://problem/88366849 + +[WebCore] JSValueInWrappedObject is not correct for concurrent GC +https://bugs.webkit.org/show_bug.cgi?id=236277 +rdar://88366849 + +Reviewed by Saam Barati. + +JSValueInWrappedObject is broken for concurrent GC's marking. It is using std::variant<> to store Weak / JSValue, +which is not safe if concurrent GC reads it while changing that std::variant. This patch fixes several problems +in JSValueInWrappedObject. + +1. We must not use std::variant here since concurrent access can happen. We have both JSValue and Weak, and change + Weak after fully initialize WeakImpl's content in Weak. To ensure that, we emit storeStoreBarrier before setting + Weak to the JSValueInWrappedObject's field. +2. Assignment operator & copy constructor are basically wrong for this class as we need a write-barrier to set a value + to the field. We remove them and make it explicit that we do not have write-barrier, which reveals that IDBRequest + has a semantic bug. +3. We also add clear() instead of assigning empty JSValueInWrappedObject. And we ensure that this new clear() works +
[webkit-changes] [289511] tags/Safari-613.1.16.1.5/
Title: [289511] tags/Safari-613.1.16.1.5/ Revision 289511 Author repst...@apple.com Date 2022-02-09 17:24:01 -0800 (Wed, 09 Feb 2022) Log Message Tag Safari-613.1.16.1.5. Added Paths tags/Safari-613.1.16.1.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289509] trunk/Source/WTF
Title: [289509] trunk/Source/WTF Revision 289509 Author cdu...@apple.com Date 2022-02-09 17:12:05 -0800 (Wed, 09 Feb 2022) Log Message [WK2] Turn on Shared Workers by default https://bugs.webkit.org/show_bug.cgi?id=236396 Reviewed by Geoffrey Garen. * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (289508 => 289509) --- trunk/Source/WTF/ChangeLog 2022-02-10 00:46:37 UTC (rev 289508) +++ trunk/Source/WTF/ChangeLog 2022-02-10 01:12:05 UTC (rev 289509) @@ -1,3 +1,12 @@ +2022-02-09 Chris Dumez + +[WK2] Turn on Shared Workers by default +https://bugs.webkit.org/show_bug.cgi?id=236396 + +Reviewed by Geoffrey Garen. + +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2022-02-09 Commit Queue Unreviewed, reverting r289490. Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (289508 => 289509) --- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-02-10 00:46:37 UTC (rev 289508) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2022-02-10 01:12:05 UTC (rev 289509) @@ -1294,7 +1294,7 @@ WebKitLegacy: default: false WebKit: - default: false + default: true ShouldDeferAsynchronousScriptsUntilAfterDocumentLoadOrFirstPaint: type: bool ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289508] trunk/Source/WebKit
Title: [289508] trunk/Source/WebKit Revision 289508 Author cdu...@apple.com Date 2022-02-09 16:46:37 -0800 (Wed, 09 Feb 2022) Log Message [iOS] Take adequate process assertion for the SharedWorker process https://bugs.webkit.org/show_bug.cgi?id=236271 Reviewed by Brent Fulgham. Keep track of client processes that rely on a particular SharedWorker process and take the adequate process assertion to keep the process running on iOS when necessary. This allows us to get rid of the hack I landed previously to always take a process assertion on behalf of the shared worker process (even if all its clients are suspended). * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::sharedWorkerServerToContextConnectionIsNoLongerNeeded): (WebKit::NetworkConnectionToWebProcess::serviceWorkerServerToContextConnectionNoLongerNeeded): * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::registerServiceWorkerClient): (WebKit::WebSWServerConnection::unregisterServiceWorkerClient): (WebKit::WebSWServerConnection::contextConnectionCreated): * NetworkProcess/SharedWorker/WebSharedWorker.cpp: (WebKit::WebSharedWorker::WebSharedWorker): (WebKit::WebSharedWorker::didCreateContextConnection): (WebKit::WebSharedWorker::addSharedWorkerObject): (WebKit::WebSharedWorker::removeSharedWorkerObject): (WebKit::WebSharedWorker::forEachSharedWorkerObject const): (WebKit::WebSharedWorker::contextConnection const): * NetworkProcess/SharedWorker/WebSharedWorker.h: (WebKit::WebSharedWorker::sharedWorkerObjectsCount const): (WebKit::WebSharedWorker::sharedWorkerObjects): Deleted. * NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp: (WebKit::WebSharedWorkerServer::requestSharedWorker): (WebKit::WebSharedWorkerServer::didFinishFetchingSharedWorkerScript): (WebKit::WebSharedWorkerServer::createContextConnection): (WebKit::WebSharedWorkerServer::removeContextConnection): (WebKit::WebSharedWorkerServer::contextConnectionCreated): (WebKit::WebSharedWorkerServer::sharedWorkerObjectIsGoingAway): (WebKit::WebSharedWorkerServer::shutDownSharedWorker): (WebKit::WebSharedWorkerServer::removeConnection): (WebKit::WebSharedWorkerServer::postExceptionToWorkerObject): * NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp: (WebKit::WebSharedWorkerServerToContextConnection::launchSharedWorker): (WebKit::WebSharedWorkerServerToContextConnection::addSharedWorkerObject): (WebKit::WebSharedWorkerServerToContextConnection::removeSharedWorkerObject): * NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.h: * Shared/RemoteWorkerType.h: Copied from Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorker.cpp. * UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::terminateUnresponsiveServiceWorkerProcesses): (WebKit::NetworkProcessProxy::registerRemoteWorkerClientProcess): (WebKit::NetworkProcessProxy::unregisterRemoteWorkerClientProcess): (WebKit::NetworkProcessProxy::remoteWorkerContextConnectionNoLongerNeeded): (WebKit::NetworkProcessProxy::establishServiceWorkerContextConnectionToNetworkProcess): (WebKit::NetworkProcessProxy::serviceWorkerContextConnectionNoLongerNeeded): Deleted. (WebKit::NetworkProcessProxy::registerServiceWorkerClientProcess): Deleted. (WebKit::NetworkProcessProxy::unregisterServiceWorkerClientProcess): Deleted. (WebKit::NetworkProcessProxy::sharedWorkerContextConnectionNoLongerNeeded): Deleted. * UIProcess/Network/NetworkProcessProxy.h: * UIProcess/Network/NetworkProcessProxy.messages.in: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setUserAgent): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::establishServiceWorkerContextConnectionToNetworkProcess): (WebKit::WebProcessPool::establishSharedWorkerContextConnectionToNetworkProcess): (WebKit::WebProcessPool::createWebPage): (WebKit::WebProcessPool::updateRemoteWorkerUserAgent): (WebKit::WebProcessPool::terminateServiceWorkers): (WebKit::WebProcessPool::updateProcessAssertions): (WebKit::WebProcessPool::updateWorkerUserAgent): Deleted. * UIProcess/WebProcessPool.h: * UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::createForRemoteWorkers): (WebKit::WebProcessProxy::didBecomeUnresponsive): (WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame): (WebKit::WebProcessProxy::setRemoteWorkerUserAgent): (WebKit::WebProcessProxy::updateRemoteWorkerPreferencesStore): (WebKit::WebProcessProxy::updateRemoteWorkerProcessAssertion): (WebKit::WebProcessProxy::registerRemoteWorkerClientProcess): (WebKit::WebProcessProxy::unregisterRemoteWorkerClientProcess): (WebKit::WebProcessProxy::startServiceWorkerBackgroundProcessing): (WebKit::WebProcessProxy::endServiceWorkerBackgroundProcessing): (WebKit::WebProcessProxy::disableRemoteWorkers): (WebKit::WebProcessProxy::enableRemoteWorkers): (WebKit::WebProcessProxy::createForWorkers): Deleted. (WebKit::WebProcessProxy::setWorkerUserAgent): Deleted. (WebKit::WebProcessProxy::updateWorkerPreferences
[webkit-changes] [289507] trunk/LayoutTests
Title: [289507] trunk/LayoutTests Revision 289507 Author jon...@apple.com Date 2022-02-09 15:57:16 -0800 (Wed, 09 Feb 2022) Log Message LayoutTests/imported/w3c: Unreviewed gardening. Add fuzzy data. * web-platform-tests/css/css-grid/alignment/grid-item-aspect-ratio-stretch-2.html: * web-platform-tests/css/motion/offset-rotate-003.html: LayoutTests: Unreviewed gardening Update fuzzy data. * css1/basic/class_as_selector.html: * css3/color-filters/color-filter-color-text-decorations.html: * css3/color-filters/color-filter-text-decoration-shadow.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css1/basic/class_as_selector.html trunk/LayoutTests/css3/color-filters/color-filter-color-text-decorations.html trunk/LayoutTests/css3/color-filters/color-filter-text-decoration-shadow.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-aspect-ratio-stretch-2.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-rotate-003.html Diff Modified: trunk/LayoutTests/ChangeLog (289506 => 289507) --- trunk/LayoutTests/ChangeLog 2022-02-09 23:48:48 UTC (rev 289506) +++ trunk/LayoutTests/ChangeLog 2022-02-09 23:57:16 UTC (rev 289507) @@ -1,3 +1,12 @@ +2022-02-09 Jon Lee + +Unreviewed gardening + +Update fuzzy data. +* css1/basic/class_as_selector.html: +* css3/color-filters/color-filter-color-text-decorations.html: +* css3/color-filters/color-filter-text-decoration-shadow.html: + 2022-02-09 Fujii Hironori compositing/masks/compositing-clip-path-mask-change.html is failing for ports using TextureMapper Modified: trunk/LayoutTests/css1/basic/class_as_selector.html (289506 => 289507) --- trunk/LayoutTests/css1/basic/class_as_selector.html 2022-02-09 23:48:48 UTC (rev 289506) +++ trunk/LayoutTests/css1/basic/class_as_selector.html 2022-02-09 23:57:16 UTC (rev 289507) @@ -4,7 +4,7 @@ CSS1 Test Suite: 1.4 Class as selector - +
[webkit-changes] [289506] trunk/Tools
Title: [289506] trunk/Tools
Revision 289506
Author jbed...@apple.com
Date 2022-02-09 15:48:48 -0800 (Wed, 09 Feb 2022)
Log Message
[EWS] Link commit URL to pull request
https://bugs.webkit.org/show_bug.cgi?id=236399
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(GitHub.commit_url): We should link to commit within pull request
(ConfigureBuild.add_pr_details): Pass pr_number to GitHub.commit_url.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestGitHub.test_pr_url_with_repository):
(TestGitHub):
(TestGitHub.test_pr_url_with_invalid_repository):
(TestGitHub.test_commit_url_with_repository):
(TestGitHub.test_commit_url_with_invalid_repository):
Canonical link: https://commits.webkit.org/247040@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (289505 => 289506)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-02-09 22:59:13 UTC (rev 289505)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-02-09 23:48:48 UTC (rev 289506)
@@ -91,7 +91,7 @@
return '{}/pull/{}'.format(repository_url, pr_number)
@classmethod
-def commit_url(cls, sha, repository_url=None):
+def commit_url(cls, sha, repository_url=None, pr_number=None):
if not repository_url:
repository_url = '{}{}'.format(GITHUB_URL, GITHUB_PROJECTS[0])
if repository_url not in GitHub.repository_urls():
@@ -98,6 +98,8 @@
return ''
if not sha:
return ''
+if pr_number:
+return '{}/pull/{}/commits/{}'.format(repository_url, pr_number, sha)
return '{}/commit/{}'.format(repository_url, sha)
@classmethod
@@ -328,7 +330,7 @@
display_name = '{} ({})'.format(display_name, github_username)
self.addURL('PR by: {}'.format(display_name), '{}{}'.format(GITHUB_URL, github_username))
if revision:
-self.addURL('Hash: {}'.format(revision[:HASH_LENGTH_TO_DISPLAY]), GitHub.commit_url(revision, repository_url))
+self.addURL('Hash: {}'.format(revision[:HASH_LENGTH_TO_DISPLAY]), GitHub.commit_url(revision, repository_url, pr_number))
class CheckOutSource(git.Git):
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (289505 => 289506)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-02-09 22:59:13 UTC (rev 289505)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-02-09 23:48:48 UTC (rev 289506)
@@ -46,7 +46,7 @@
CleanBuild, CleanUpGitIndexLock, CleanGitRepo, CleanWorkingDirectory, CompileJSC, CompileJSCWithoutChange,
CompileWebKit, CompileWebKitWithoutChange, ConfigureBuild, ConfigureBuild, Contributors, CreateLocalGITCommit,
DownloadBuiltProduct, DownloadBuiltProductFromMaster, EWS_BUILD_HOSTNAME, ExtractBuiltProduct, ExtractTestResults,
- FetchBranches, FindModifiedChangeLogs, FindModifiedLayoutTests, GitResetHard,
+ FetchBranches, FindModifiedChangeLogs, FindModifiedLayoutTests, GitHub, GitResetHard,
InstallBuiltProduct, InstallGtkDependencies, InstallWpeDependencies,
KillOldProcesses, PrintConfiguration, PushCommitToWebKitRepo, ReRunAPITests, ReRunWebKitPerlTests,
ReRunWebKitTests, RevertPullRequestChanges, RunAPITests, RunAPITestsWithoutPatch, RunBindingsTests, RunBuildWebKitOrgUnitTests,
@@ -214,6 +214,50 @@
return behavior
+class TestGitHub(unittest.TestCase):
+def test_pr_url(self):
+self.assertEqual(
+GitHub.pr_url(1234),
+'https://github.com/WebKit/WebKit/pull/1234',
+)
+
+def test_pr_url_with_repository(self):
+self.assertEqual(
+GitHub.pr_url(1234, 'https://github.com/WebKit/WebKit'),
+'https://github.com/WebKit/WebKit/pull/1234',
+)
+
+def test_pr_url_with_invalid_repository(self):
+self.assertEqual(
+GitHub.pr_url(1234, 'https://github.example.com/WebKit/WebKit'),
+'',
+)
+
+def test_commit_url(self):
+self.assertEqual(
+GitHub.commit_url('936e3f7cab4a826519121a75bf4481fe56e727e2'),
+'https://github.com/WebKit/WebKit/commit/936e3f7cab4a826519121a75bf4481fe56e727e2',
+)
+
+def test_commit_url_with_repository(self):
+self.assertEqual(
+GitHub.commit_url('936e3f7cab4a826519121a75bf4481fe56e727e2', 'https://github.com/WebKit/WebKit'),
+'https://github.com/WebKit/WebKit/commit/936e3f7cab4a826519121a75bf4481fe56e727e2',
+)
+
+def test_commit_url_with_invalid_repository(self):
+self.assertEqual(
+GitHub.commit_url('936e3f7cab4a826519121a75bf4481fe56e727e2', 'https://github.example.com/WebKit/WebKit'),
+'',
+)
+
+def test_pr_commit_url(self):
+self.asse
[webkit-changes] [289505] tags/Safari-614.1.1.5/
Title: [289505] tags/Safari-614.1.1.5/ Revision 289505 Author repst...@apple.com Date 2022-02-09 14:59:13 -0800 (Wed, 09 Feb 2022) Log Message Tag Safari-614.1.1.5. Added Paths tags/Safari-614.1.1.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289504] branches/safari-614.1.1-branch/Source/JavaScriptCore
Title: [289504] branches/safari-614.1.1-branch/Source/_javascript_Core
Revision 289504
Author repst...@apple.com
Date 2022-02-09 14:58:10 -0800 (Wed, 09 Feb 2022)
Log Message
Cherry-pick r289024. rdar://problem/88710933
SecureARM64EHashPins should check g_jscConfig.useFastJITPermissions
https://bugs.webkit.org/show_bug.cgi?id=236055
Reviewed by Mark Lam.
* assembler/SecureARM64EHashPins.cpp:
(JSC::SecureARM64EHashPins::initializeAtStartup):
(JSC::SecureARM64EHashPins::allocatePinForCurrentThread):
(JSC::SecureARM64EHashPins::deallocatePinForCurrentThread):
* assembler/SecureARM64EHashPinsInlines.h:
(JSC::SecureARM64EHashPins::pinForCurrentThread):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-614.1.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPins.cpp
branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h
Diff
Modified: branches/safari-614.1.1-branch/Source/_javascript_Core/ChangeLog (289503 => 289504)
--- branches/safari-614.1.1-branch/Source/_javascript_Core/ChangeLog 2022-02-09 22:58:07 UTC (rev 289503)
+++ branches/safari-614.1.1-branch/Source/_javascript_Core/ChangeLog 2022-02-09 22:58:10 UTC (rev 289504)
@@ -1,5 +1,40 @@
2022-02-09 Russell Epstein
+Cherry-pick r289024. rdar://problem/88710933
+
+SecureARM64EHashPins should check g_jscConfig.useFastJITPermissions
+https://bugs.webkit.org/show_bug.cgi?id=236055
+
+
+Reviewed by Mark Lam.
+
+* assembler/SecureARM64EHashPins.cpp:
+(JSC::SecureARM64EHashPins::initializeAtStartup):
+(JSC::SecureARM64EHashPins::allocatePinForCurrentThread):
+(JSC::SecureARM64EHashPins::deallocatePinForCurrentThread):
+* assembler/SecureARM64EHashPinsInlines.h:
+(JSC::SecureARM64EHashPins::pinForCurrentThread):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-02 Saam Barati
+
+SecureARM64EHashPins should check g_jscConfig.useFastJITPermissions
+https://bugs.webkit.org/show_bug.cgi?id=236055
+
+
+Reviewed by Mark Lam.
+
+* assembler/SecureARM64EHashPins.cpp:
+(JSC::SecureARM64EHashPins::initializeAtStartup):
+(JSC::SecureARM64EHashPins::allocatePinForCurrentThread):
+(JSC::SecureARM64EHashPins::deallocatePinForCurrentThread):
+* assembler/SecureARM64EHashPinsInlines.h:
+(JSC::SecureARM64EHashPins::pinForCurrentThread):
+
+2022-02-09 Russell Epstein
+
Cherry-pick r288970. rdar://problem/88710933
Update computation of FAST_TLS base.
Modified: branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPins.cpp (289503 => 289504)
--- branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPins.cpp 2022-02-09 22:58:07 UTC (rev 289503)
+++ branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPins.cpp 2022-02-09 22:58:10 UTC (rev 289504)
@@ -100,6 +100,9 @@
void SecureARM64EHashPins::initializeAtStartup()
{
+if (!g_jscConfig.useFastJITPermissions)
+return;
+
VALIDATE_THIS_VALUE();
RELEASE_ASSERT(!m_memory);
@@ -173,6 +176,9 @@
void SecureARM64EHashPins::allocatePinForCurrentThread()
{
+if (!g_jscConfig.useFastJITPermissions)
+return;
+
VALIDATE_THIS_VALUE();
Locker locker { hashPinsLock };
@@ -205,6 +211,9 @@
void SecureARM64EHashPins::deallocatePinForCurrentThread()
{
+if (!g_jscConfig.useFastJITPermissions)
+return;
+
VALIDATE_THIS_VALUE();
Locker locker { hashPinsLock };
Modified: branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h (289503 => 289504)
--- branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h 2022-02-09 22:58:07 UTC (rev 289503)
+++ branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h 2022-02-09 22:58:10 UTC (rev 289504)
@@ -101,7 +101,9 @@
ALWAYS_INLINE uint64_t SecureARM64EHashPins::pinForCurrentThread()
{
-return findFirstEntry().entry->pin;
+if (LIKELY(g_jscConfig.useFastJITPermissions))
+return findFirstEntry().entry->pin;
+return 1;
}
} // namespace JSC
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289503] branches/safari-614.1.1-branch/Source
Title: [289503] branches/safari-614.1.1-branch/Source
Revision 289503
Author repst...@apple.com
Date 2022-02-09 14:58:07 -0800 (Wed, 09 Feb 2022)
Log Message
Cherry-pick r288970. rdar://problem/88710933
Update computation of FAST_TLS base.
https://bugs.webkit.org/show_bug.cgi?id=235934
Reviewed by Yusuke Suzuki.
Source/_javascript_Core:
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::loadFromTLS32):
(JSC::MacroAssemblerARM64::loadFromTLS64):
(JSC::MacroAssemblerARM64::storeToTLS32):
(JSC::MacroAssemblerARM64::storeToTLS64):
* assembler/SecureARM64EHashPinsInlines.h:
(JSC::SecureARM64EHashPins::keyForCurrentThread):
* offlineasm/arm64.rb:
Source/WTF:
* wtf/PlatformHave.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-614.1.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h
branches/safari-614.1.1-branch/Source/_javascript_Core/offlineasm/arm64.rb
branches/safari-614.1.1-branch/Source/WTF/ChangeLog
branches/safari-614.1.1-branch/Source/WTF/wtf/PlatformHave.h
Diff
Modified: branches/safari-614.1.1-branch/Source/_javascript_Core/ChangeLog (289502 => 289503)
--- branches/safari-614.1.1-branch/Source/_javascript_Core/ChangeLog 2022-02-09 22:55:59 UTC (rev 289502)
+++ branches/safari-614.1.1-branch/Source/_javascript_Core/ChangeLog 2022-02-09 22:58:07 UTC (rev 289503)
@@ -1,3 +1,46 @@
+2022-02-09 Russell Epstein
+
+Cherry-pick r288970. rdar://problem/88710933
+
+Update computation of FAST_TLS base.
+https://bugs.webkit.org/show_bug.cgi?id=235934
+
+Reviewed by Yusuke Suzuki.
+
+Source/_javascript_Core:
+
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::loadFromTLS32):
+(JSC::MacroAssemblerARM64::loadFromTLS64):
+(JSC::MacroAssemblerARM64::storeToTLS32):
+(JSC::MacroAssemblerARM64::storeToTLS64):
+* assembler/SecureARM64EHashPinsInlines.h:
+(JSC::SecureARM64EHashPins::keyForCurrentThread):
+* offlineasm/arm64.rb:
+
+Source/WTF:
+
+* wtf/PlatformHave.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-02 Mark Lam
+
+Update computation of FAST_TLS base.
+https://bugs.webkit.org/show_bug.cgi?id=235934
+
+Reviewed by Yusuke Suzuki.
+
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::loadFromTLS32):
+(JSC::MacroAssemblerARM64::loadFromTLS64):
+(JSC::MacroAssemblerARM64::storeToTLS32):
+(JSC::MacroAssemblerARM64::storeToTLS64):
+* assembler/SecureARM64EHashPinsInlines.h:
+(JSC::SecureARM64EHashPins::keyForCurrentThread):
+* offlineasm/arm64.rb:
+
2022-01-21 Commit Queue
Unreviewed, reverting r288400.
Modified: branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/MacroAssemblerARM64.h (289502 => 289503)
--- branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/MacroAssemblerARM64.h 2022-02-09 22:55:59 UTC (rev 289502)
+++ branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/MacroAssemblerARM64.h 2022-02-09 22:58:07 UTC (rev 289503)
@@ -4521,7 +4521,9 @@
void loadFromTLS32(uint32_t offset, RegisterID dst)
{
m_assembler.mrs_TPIDRRO_EL0(dst);
+#if !HAVE(SIMPLIFIED_FAST_TLS_BASE)
and64(TrustedImm32(~7), dst);
+#endif
load32(Address(dst, offset), dst);
}
@@ -4528,7 +4530,9 @@
void loadFromTLS64(uint32_t offset, RegisterID dst)
{
m_assembler.mrs_TPIDRRO_EL0(dst);
+#if !HAVE(SIMPLIFIED_FAST_TLS_BASE)
and64(TrustedImm32(~7), dst);
+#endif
load64(Address(dst, offset), dst);
}
@@ -4542,7 +4546,9 @@
RegisterID tmp = getCachedDataTempRegisterIDAndInvalidate();
ASSERT(src != tmp);
m_assembler.mrs_TPIDRRO_EL0(tmp);
+#if !HAVE(SIMPLIFIED_FAST_TLS_BASE)
and64(TrustedImm32(~7), tmp);
+#endif
store32(src, Address(tmp, offset));
}
@@ -4551,7 +4557,9 @@
RegisterID tmp = getCachedDataTempRegisterIDAndInvalidate();
ASSERT(src != tmp);
m_assembler.mrs_TPIDRRO_EL0(tmp);
+#if !HAVE(SIMPLIFIED_FAST_TLS_BASE)
and64(TrustedImm32(~7), tmp);
+#endif
store64(src, Address(tmp, offset));
}
Modified: branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h (289502 => 289503)
--- branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h 2022-02-09 22:55:59 UTC (rev 289502)
+++ branches/safari-614.1.1-branch/Source/_javascript_Core/assembler/Secur
[webkit-changes] [289502] trunk
Title: [289502] trunk
Revision 289502
Author eric.carl...@apple.com
Date 2022-02-09 14:55:59 -0800 (Wed, 09 Feb 2022)
Log Message
WKWebView: WKURLSchemeHandler “request to the end of the resource” produces an invalid header
https://bugs.webkit.org/show_bug.cgi?id=236401
rdar://88528286
Reviewed by Brent Fulgham.
Source/WebCore:
https://webkit.org/b/203302 added support for Range requests to AVAssetResourceLoadingDataRequest,
but it incorrectly used '*' instead of '' for "last-byte-pos:" for a request to the end of the resource.
API test URLSchemeHandler.Ranges was updated.
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (289501 => 289502)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 22:02:16 UTC (rev 289501)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 22:55:59 UTC (rev 289502)
@@ -1,3 +1,21 @@
+2022-02-09 Eric Carlson
+
+WKWebView: WKURLSchemeHandler “request to the end of the resource” produces an invalid header
+https://bugs.webkit.org/show_bug.cgi?id=236401
+rdar://88528286
+
+Reviewed by Brent Fulgham.
+
+Patch by Jer Noble.
+
+https://webkit.org/b/203302 added support for Range requests to AVAssetResourceLoadingDataRequest,
+but it incorrectly used '*' instead of '' for "last-byte-pos:" for a request to the end of the resource.
+
+API test URLSchemeHandler.Ranges was updated.
+
+* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
+(WebCore::WebCoreAVFResourceLoader::startLoading):
+
2022-02-09 Alan Bujtas
[LFC][IFC] Vertical writing mode with RTL text content has incorrect advances
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm (289501 => 289502)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm 2022-02-09 22:02:16 UTC (rev 289501)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm 2022-02-09 22:55:59 UTC (rev 289502)
@@ -288,7 +288,7 @@
if (AVAssetResourceLoadingDataRequest *dataRequest = [m_avRequest dataRequest]; dataRequest.requestedLength
&& !request.hasHTTPHeaderField(HTTPHeaderName::Range)) {
-String rangeEnd = dataRequest.requestsAllDataToEndOfResource ? "*"_s : makeString(dataRequest.requestedOffset + dataRequest.requestedLength - 1);
+String rangeEnd = dataRequest.requestsAllDataToEndOfResource ? emptyString() : makeString(dataRequest.requestedOffset + dataRequest.requestedLength - 1);
request.addHTTPHeaderField(HTTPHeaderName::Range, makeString("bytes=", dataRequest.requestedOffset, '-', rangeEnd));
}
Modified: trunk/Tools/ChangeLog (289501 => 289502)
--- trunk/Tools/ChangeLog 2022-02-09 22:02:16 UTC (rev 289501)
+++ trunk/Tools/ChangeLog 2022-02-09 22:55:59 UTC (rev 289502)
@@ -1,3 +1,13 @@
+2022-02-09 Eric Carlson
+
+WKWebView: WKURLSchemeHandler “request to the end of the resource” produces an invalid header
+https://bugs.webkit.org/show_bug.cgi?id=236401
+rdar://88528286
+
+Reviewed by Brent Fulgham.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
+
2022-02-09 J Pascoe
[WebAuthn] Specify LocalAuthenticatorAccessGroup when importing credentials
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm (289501 => 289502)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm 2022-02-09 22:02:16 UTC (rev 289501)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm 2022-02-09 22:55:59 UTC (rev 289502)
@@ -1606,7 +1606,7 @@
auto rangeBeginString = requestRangeString.substring(begin + rangeBytes.length(), dash - begin - rangeBytes.length());
auto rangeEndString = requestRangeString.substring(dash + 1, end - dash - 1);
auto rangeBegin = parseInteger(rangeBeginString).value_or(0);
-auto rangeEnd = rangeEndString == "*" ? [videoData length] - 1 : parseInteger(rangeEndString).value_or(0);
+auto rangeEnd = rangeEndString.isEmpty() ? [videoData length] - 1 : parseInteger(rangeEndString).value_or(0);
auto contentLength = rangeEnd - rangeBegin + 1;
auto response = adoptNS([[NSHTTPURLResponse alloc] initWithURL:[NSURL URLWithString:@"https://webkit.org/"] statusCode:206 HTTPVersion:@"HTTP/1.1" headerFields:@{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289501] branches/safari-614.1.1-branch/Source
Title: [289501] branches/safari-614.1.1-branch/Source Revision 289501 Author repst...@apple.com Date 2022-02-09 14:02:16 -0800 (Wed, 09 Feb 2022) Log Message Versioning. WebKit-7614.1.1.5 Modified Paths branches/safari-614.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-614.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-614.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-614.1.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-614.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-614.1.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-614.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-614.1.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-614.1.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-614.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (289500 => 289501) --- branches/safari-614.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-09 21:18:11 UTC (rev 289500) +++ branches/safari-614.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-09 22:02:16 UTC (rev 289501) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (289500 => 289501) --- branches/safari-614.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-09 21:18:11 UTC (rev 289500) +++ branches/safari-614.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-09 22:02:16 UTC (rev 289501) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (289500 => 289501) --- branches/safari-614.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-09 21:18:11 UTC (rev 289500) +++ branches/safari-614.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-09 22:02:16 UTC (rev 289501) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.1-branch/Source/WebCore/Configurations/Version.xcconfig (289500 => 289501) --- branches/safari-614.1.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-09 21:18:11 UTC (rev 289500) +++ branches/safari-614.1.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-09 22:02:16 UTC (rev 289501) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (289500 => 289501) --- branches/safari-614.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-09 21:18:11 UTC (rev 289500) +++ branches/safari-614.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-09 22:02:16 UTC (rev 289501) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.1-branch/Source/WebGPU/Configurations/Version.xcconfig (289500 => 289501) --- branches/safari-614.1.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-09 21:18:11 UTC (rev 289500) +++ branches/safari-614.1.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-09 22:02:16 UTC (rev 289501) @@ -24,7 +24,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-614.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (289500 => 289501) --- branches/safari-614.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-02-09 21:18:11 UTC (rev 289500) +++ branches/safari-614.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-02-09 22:02:16 UTC (rev 289501) @@ -1,7 +1,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; TINY_VERSION = 1; -MICRO_VERSION = 4; +MICRO_VERSION = 5; NAN
[webkit-changes] [289499] trunk/Source/WebCore
Title: [289499] trunk/Source/WebCore
Revision 289499
Author za...@apple.com
Date 2022-02-09 12:53:53 -0800 (Wed, 09 Feb 2022)
Log Message
[LFC][IFC] Vertical writing mode with RTL text content has incorrect advances
https://bugs.webkit.org/show_bug.cgi?id=236345
Reviewed by Antti Koivisto.
contentRightInInlineDirectionVisualOrder is the visual offset of the adjoining runs ignoring the writing mode (horizontal vs. vertical).
It's visual in the inline direction sense (right to left vs. left to right), but it's not transformed in the context of writing mode, i.e. width and height are not flipped.
* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (289498 => 289499)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 20:48:11 UTC (rev 289498)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 20:53:53 UTC (rev 289499)
@@ -1,3 +1,16 @@
+2022-02-09 Alan Bujtas
+
+[LFC][IFC] Vertical writing mode with RTL text content has incorrect advances
+https://bugs.webkit.org/show_bug.cgi?id=236345
+
+Reviewed by Antti Koivisto.
+
+contentRightInInlineDirectionVisualOrder is the visual offset of the adjoining runs ignoring the writing mode (horizontal vs. vertical).
+It's visual in the inline direction sense (right to left vs. left to right), but it's not transformed in the context of writing mode, i.e. width and height are not flipped.
+
+* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
+(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
+
2022-02-09 Antoine Quint
Dialog element only animates once
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp (289498 => 289499)
--- trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp 2022-02-09 20:48:11 UTC (rev 289498)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp 2022-02-09 20:53:53 UTC (rev 289499)
@@ -459,7 +459,7 @@
std::optional last;
};
using IsFirstLastIndexesMap = HashMap;
-void InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox(size_t displayBoxNodeIndex, InlineLayoutUnit& contentRightInVisualOrder, InlineLayoutUnit lineBoxTop, const DisplayBoxTree& displayBoxTree, DisplayBoxes& boxes, const LineBox& lineBox, const IsFirstLastIndexesMap& isFirstLastIndexesMap)
+void InlineDisplayContentBuilder::adjustVisualGeometryForDisplayBox(size_t displayBoxNodeIndex, InlineLayoutUnit& contentRightInInlineDirectionVisualOrder, InlineLayoutUnit lineBoxTop, const DisplayBoxTree& displayBoxTree, DisplayBoxes& boxes, const LineBox& lineBox, const IsFirstLastIndexesMap& isFirstLastIndexesMap)
{
// Non-inline box display boxes just need a horizontal adjustment while
// inline box type of display boxes need
@@ -475,15 +475,15 @@
auto boxMarginLeft = marginLeft(boxGeometry, isLeftToRightDirection);
auto boxMarginRight = marginRight(boxGeometry, isLeftToRightDirection);
-auto borderBoxLeft = LayoutUnit { contentRightInVisualOrder + boxMarginLeft };
+auto borderBoxLeft = LayoutUnit { contentRightInInlineDirectionVisualOrder + boxMarginLeft };
boxGeometry.setLogicalLeft(borderBoxLeft);
displayBox.setLeft(borderBoxLeft);
-contentRightInVisualOrder += boxMarginLeft + displayBox.width() + boxMarginRight;
+contentRightInInlineDirectionVisualOrder += boxMarginLeft + displayBox.width() + boxMarginRight;
} else {
auto wordSpacingMargin = displayBox.isWordSeparator() ? layoutBox.style().fontCascade().wordSpacing() : 0.0f;
-displayBox.setLeft(contentRightInVisualOrder + wordSpacingMargin);
-contentRightInVisualOrder += displayBox.width() + wordSpacingMargin;
+displayBox.setLeft(contentRightInInlineDirectionVisualOrder + wordSpacingMargin);
+contentRightInInlineDirectionVisualOrder += displayBox.width() + wordSpacingMargin;
}
return;
}
@@ -495,29 +495,29 @@
auto isLastBox = isFirstLastIndexes.last && *isFirstLastIndexes.last == displayBoxNodeIndex;
auto beforeInlineBoxContent = [&] {
auto logicalRect = lineBox.logicalBorderBoxForInlineBox(layoutBox, boxGeometry);
-auto visualRect = InlineRect { lineBoxTop + logicalRect.top(), contentRightInVisualOrder, { }, logicalRect.height() };
+auto visualRect = InlineRect { lineBoxTop + logicalRect.top(), contentRightInInlineDirectionVisualOrder, { }, logicalRect.height() };
auto shouldApplyLeftSide = (isLeftToRightDirection && isFirstBox) || (!isLeftToRightD
[webkit-changes] [289498] trunk
Title: [289498] trunk Revision 289498 Author grao...@webkit.org Date 2022-02-09 12:48:11 -0800 (Wed, 09 Feb 2022) Log Message Dialog element only animates once https://bugs.webkit.org/show_bug.cgi?id=236274 rdar://88635487 Reviewed by Tim Nguyen and Dean Jackson. LayoutTests/imported/w3c: Add two new tests that check that we correctly start, stop and resume animations on and ::backdrop as a element is open, closed and open again. * web-platform-tests/css/css-animations/dialog-animation-expected.txt: Added. * web-platform-tests/css/css-animations/dialog-animation.html: Added. * web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt: Added. * web-platform-tests/css/css-animations/dialog-backdrop-animation.html: Added. * web-platform-tests/css/css-animations/support/testcommon.js: (addElement): (addDiv): Source/WebCore: Two issues related to CSS Animation surfaced in this bug which animates both and its ::backdrop as the dialog is open and eventually re-opened. The first issue was that we didn't clear all CSS Animations state when a was closed and its style was set to `display: none`. We now use the clearCSSAnimationsForStyleable() function (static so that it's not exposed on the Styleable struct) to correctly clear such state both when we identify a Styleable is newly getting `display: none` and when cancelDeclarativeAnimations() was called. This allows us to remove removeCSSAnimationCreatedByMarkup() a fair bit of work to clear CSS Animation state per-animation when we only ever used that function for _all_ animations. The second issue was that we never called cancelDeclarativeAnimations() for ::backdrop. We now do that inside of Element::removeFromTopLayer() at a point where the code in Styleable::fromRenderer() will still work as the element will still be contained in Document::topLayerElements(). Tests: imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation.html * dom/Element.cpp: (WebCore::Element::removeFromTopLayer): * style/Styleable.cpp: (WebCore::clearCSSAnimationsForStyleable): (WebCore::Styleable::cancelDeclarativeAnimations const): (WebCore::Styleable::updateCSSAnimations const): (WebCore::removeCSSAnimationCreatedByMarkup): Deleted. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/support/testcommon.js trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/style/Styleable.cpp Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-backdrop-animation.html Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289497 => 289498) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 20:36:06 UTC (rev 289497) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 20:48:11 UTC (rev 289498) @@ -1,3 +1,22 @@ +2022-02-09 Antoine Quint + +Dialog element only animates once +https://bugs.webkit.org/show_bug.cgi?id=236274 +rdar://88635487 + +Reviewed by Tim Nguyen and Dean Jackson. + +Add two new tests that check that we correctly start, stop and resume animations on +and ::backdrop as a element is open, closed and open again. + +* web-platform-tests/css/css-animations/dialog-animation-expected.txt: Added. +* web-platform-tests/css/css-animations/dialog-animation.html: Added. +* web-platform-tests/css/css-animations/dialog-backdrop-animation-expected.txt: Added. +* web-platform-tests/css/css-animations/dialog-backdrop-animation.html: Added. +* web-platform-tests/css/css-animations/support/testcommon.js: +(addElement): +(addDiv): + 2022-02-09 Alex Christensen Add TAO check to PerformanceResourceTiming::fetchStart Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt (0 => 289498) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation-expected.txt 2022-02-09 20:48:11 UTC (rev 289498) @@ -0,0 +1,3 @@ + +PASS CSS Animations tied to are canceled and restarted as the dialog is hidden and shown + Added: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html (0 => 289498) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/dialog-animation.html (rev 0) +++ trunk/LayoutTests/imported/w3c/web-platfo
[webkit-changes] [289497] trunk
Title: [289497] trunk
Revision 289497
Author hironori.fu...@sony.com
Date 2022-02-09 12:36:06 -0800 (Wed, 09 Feb 2022)
Log Message
compositing/masks/compositing-clip-path-mask-change.html is failing for ports using TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=236323
Reviewed by Don Olmstead.
Source/WebCore:
Apple ports don't have this issue because GraphicsLayerCA support
Shape layer for clip-path.
The painting phase of the existing mask layer should be updated if
clip-path or mask are changed.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateMaskingLayer):
LayoutTests:
* platform/gtk/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (289496 => 289497)
--- trunk/LayoutTests/ChangeLog 2022-02-09 20:25:11 UTC (rev 289496)
+++ trunk/LayoutTests/ChangeLog 2022-02-09 20:36:06 UTC (rev 289497)
@@ -1,3 +1,12 @@
+2022-02-09 Fujii Hironori
+
+compositing/masks/compositing-clip-path-mask-change.html is failing for ports using TextureMapper
+https://bugs.webkit.org/show_bug.cgi?id=236323
+
+Reviewed by Don Olmstead.
+
+* platform/gtk/TestExpectations:
+
2022-02-09 Jon Lee
Unreviewed gardening.
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (289496 => 289497)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2022-02-09 20:25:11 UTC (rev 289496)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2022-02-09 20:36:06 UTC (rev 289497)
@@ -430,7 +430,6 @@
webkit.org/b/169918 compositing/hidpi-subpixel-transform-origin.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/hidpi-transform-with-render-layer-on-fractional-pixel-value.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/layer-creation/deep-tree.html [ ImageOnlyFailure ]
-webkit.org/b/169918 compositing/masks/compositing-clip-path-mask-change.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/overlap-blending/nested-overlap-overflow.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/overlap-blending/nested-overlap.html [ ImageOnlyFailure ]
webkit.org/b/169918 compositing/patterns/direct-pattern-compositing-contain.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (289496 => 289497)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 20:25:11 UTC (rev 289496)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 20:36:06 UTC (rev 289497)
@@ -1,3 +1,19 @@
+2022-02-09 Fujii Hironori
+
+compositing/masks/compositing-clip-path-mask-change.html is failing for ports using TextureMapper
+https://bugs.webkit.org/show_bug.cgi?id=236323
+
+Reviewed by Don Olmstead.
+
+Apple ports don't have this issue because GraphicsLayerCA support
+Shape layer for clip-path.
+
+The painting phase of the existing mask layer should be updated if
+clip-path or mask are changed.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::updateMaskingLayer):
+
2022-02-09 Antoine Quint
[model] improve sizing on macOS
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (289496 => 289497)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2022-02-09 20:25:11 UTC (rev 289496)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2022-02-09 20:36:06 UTC (rev 289497)
@@ -2300,13 +2300,13 @@
if (!m_maskLayer) {
m_maskLayer = createGraphicsLayer("mask", requiredLayerType);
-m_maskLayer->setDrawsContent(paintsContent);
-m_maskLayer->setPaintingPhase(maskPhases);
layerChanged = true;
m_graphicsLayer->setMaskLayer(m_maskLayer.copyRef());
// We need a geometry update to size the new mask layer.
m_owningLayer.setNeedsCompositingGeometryUpdate();
}
+m_maskLayer->setDrawsContent(paintsContent);
+m_maskLayer->setPaintingPhase(maskPhases);
} else if (m_maskLayer) {
m_graphicsLayer->setMaskLayer(nullptr);
willDestroyLayer(m_maskLayer.get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289496] trunk/Tools
Title: [289496] trunk/Tools
Revision 289496
Author ryanhad...@apple.com
Date 2022-02-09 12:25:11 -0800 (Wed, 09 Feb 2022)
Log Message
Move macOS EWS to Big Sur
https://bugs.webkit.org/show_bug.cgi?id=236035
Reviewed by Jonathan Bedard.
* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* CISupport/ews-build/config.json:
* CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
Canonical link: https://commits.webkit.org/247033@main
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
trunk/Tools/CISupport/ews-build/config.json
trunk/Tools/CISupport/ews-build/factories_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (289495 => 289496)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2022-02-09 20:20:04 UTC (rev 289495)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2022-02-09 20:25:11 UTC (rev 289496)
@@ -39,24 +39,23 @@
{ "name": "bot1024", "platform": "mac-bigsur" },
{ "name": "bot1027", "platform": "mac-bigsur" },
-{ "name": "bot205", "platform": "mac-catalina" },
-{ "name": "bot241", "platform": "mac-catalina" },
-{ "name": "bot242", "platform": "mac-catalina" },
-{ "name": "bot243", "platform": "mac-catalina" },
-{ "name": "bot244", "platform": "mac-catalina" },
-{ "name": "bot245", "platform": "mac-catalina" },
-{ "name": "bot246", "platform": "mac-catalina" },
-{ "name": "bot247", "platform": "mac-catalina" },
-{ "name": "bot248", "platform": "mac-catalina" },
-{ "name": "bot674", "platform": "mac-catalina" },
-{ "name": "bot683", "platform": "mac-catalina" },
-{ "name": "bot687", "platform": "mac-catalina" },
-{ "name": "bot688", "platform": "mac-catalina" },
-
+{ "name": "bot205", "platform": "*" },
+{ "name": "bot241", "platform": "*" },
+{ "name": "bot242", "platform": "*" },
+{ "name": "bot243", "platform": "*" },
+{ "name": "bot244", "platform": "*" },
+{ "name": "bot245", "platform": "*" },
+{ "name": "bot246", "platform": "*" },
+{ "name": "bot247", "platform": "*" },
+{ "name": "bot248", "platform": "*" },
{ "name": "bot611", "platform": "*" },
{ "name": "bot612", "platform": "*" },
{ "name": "bot613", "platform": "*" },
+{ "name": "bot674", "platform": "*" },
+{ "name": "bot683", "platform": "*" },
{ "name": "bot684", "platform": "*" },
+{ "name": "bot687", "platform": "*" },
+{ "name": "bot688", "platform": "*" },
{ "name": "bot210", "platform": "ios-simulator-15" },
{ "name": "bot600", "platform": "ios-simulator-15" },
@@ -272,15 +271,15 @@
"workernames": ["bot142"]
},
{ "name": "Apple-BigSur-Debug-JSC-Tests", "factory": "TestJSCFactory", "builddir": "bigsur-debug-tests-jsc",
- "platform": "mac-bigsur", "configuration": "debug", "architectures": ["x86_64"],
+ "platform": "mac-bigsur", "configuration": "debug", "architectures": ["x86_64", "arm64"],
"workernames": ["bot638"]
},
{ "name": "Apple-BigSur-Release-JSC-Tests", "factory": "TestJSCFactory", "builddir": "bigsur-release-tests-jsc",
- "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64"],
+ "platform": "mac-bigsur", "configuration": "release", "architectures": ["x86_64", "arm64"],
"workernames": ["bot610"]
},
{ "name": "Apple-BigSur-Debug-WK2-GPUProcess-Tests", "factory": "TestAllButJSCFactory", "builddir": "bigsur-debug-tests-wk2-gpuprocess",
- "platform": "mac-bigsur", "configuration": "debug", "architectures": ["x86_64"],
+ "platform": "mac-bigsur", "configuration": "debug", "architectures": ["x86_64", "arm64"],
"additionalArguments": ["--no-retry-failures", "--use-gpu-process"],
"workernames": ["bot260"]
},
@@ -290,39 +289,9 @@
},
{
"name": "Apple-BigSur-Release-WK2-Perf", "factory": "DownloadAndPerfTestFactory", "builddir":
[webkit-changes] [289495] trunk/Source
Title: [289495] trunk/Source Revision 289495 Author grao...@webkit.org Date 2022-02-09 12:20:04 -0800 (Wed, 09 Feb 2022) Log Message [model] improve sizing on macOS https://bugs.webkit.org/show_bug.cgi?id=236233 Reviewed by Simon Fraser. Source/WebCore: We detect when the layer size changes under RenderLayerBacking::updateGeometry() and inform the associated HTMLModelElement through the new parentLayerSizeMayHaveChanged() method that the size has changed. We then inform the backing player that sizeDidChange(). * Modules/model-element/HTMLModelElement.cpp: (WebCore::HTMLModelElement::createModelPlayer): (WebCore::HTMLModelElement::parentLayerSizeMayHaveChanged): (WebCore::HTMLModelElement::platformLayerSize const): * Modules/model-element/HTMLModelElement.h: * Modules/model-element/ModelPlayer.h: * Modules/model-element/dummy/DummyModelPlayer.cpp: (WebCore::DummyModelPlayer::sizeDidChange): * Modules/model-element/dummy/DummyModelPlayer.h: * Modules/model-element/scenekit/SceneKitModelPlayer.h: * Modules/model-element/scenekit/SceneKitModelPlayer.mm: (WebCore::SceneKitModelPlayer::sizeDidChange): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateConfiguration): (WebCore::RenderLayerBacking::updateGeometry): Source/WebCore/PAL: Add newly-used CAFenceHandle and ASVInlinePreview SPIs. * pal/spi/cocoa/QuartzCoreSPI.h: * pal/spi/mac/SystemPreviewSPI.h: Source/WebKit: We override the new ModelPlayer::sizeDidChange() virtual method on ARKitInlinePreviewModelPlayerMac to be notified when the layer's has changed size. We then send the new ModelElementSizeDidChange message to the UI process which will yield a call to ModelElementController::modelElementSizeDidChange(). In that new method, we call -[ASVInlinePreview updateFrame:completionHandler:] which provides us with a CAFenceHandle which we copy to create a MachSendRight to send back to the Web process in the IPC callback. Back in the Web process, we install this fence on the drawing area and finally call -[ASVInlinePreview setFrameWithinFencedTransaction:] to complete the sizing update on both the ASVInlinePreview instances. * UIProcess/Cocoa/ModelElementControllerCocoa.mm: (WebKit::ModelElementController::modelElementSizeDidChange): * UIProcess/ModelElementController.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::modelElementSizeDidChange): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * WebProcess/Model/ARKitInlinePreviewModelPlayer.h: * WebProcess/Model/ARKitInlinePreviewModelPlayer.mm: (WebKit::ARKitInlinePreviewModelPlayer::sizeDidChange): * WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.h: * WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm: (WebKit::ARKitInlinePreviewModelPlayerMac::load): (WebKit::ARKitInlinePreviewModelPlayerMac::sizeDidChange): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/model-element/HTMLModelElement.cpp trunk/Source/WebCore/Modules/model-element/HTMLModelElement.h trunk/Source/WebCore/Modules/model-element/ModelPlayer.h trunk/Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.cpp trunk/Source/WebCore/Modules/model-element/dummy/DummyModelPlayer.h trunk/Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.h trunk/Source/WebCore/Modules/model-element/scenekit/SceneKitModelPlayer.mm trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h trunk/Source/WebCore/PAL/pal/spi/mac/SystemPreviewSPI.h trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm trunk/Source/WebKit/UIProcess/ModelElementController.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.h trunk/Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm trunk/Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.h trunk/Source/WebKit/WebProcess/Model/mac/ARKitInlinePreviewModelPlayerMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (289494 => 289495) --- trunk/Source/WebCore/ChangeLog 2022-02-09 19:48:43 UTC (rev 289494) +++ trunk/Source/WebCore/ChangeLog 2022-02-09 20:20:04 UTC (rev 289495) @@ -1,3 +1,31 @@ +2022-02-09 Antoine Quint + +[model] improve sizing on macOS +https://bugs.webkit.org/show_bug.cgi?id=236233 + + +Reviewed by Simon Fraser. + +We detect when the layer size changes under RenderLayerBacking::updateGeometry() +and inform the associated HTMLModelElement through the new parentLayerSizeMayHaveChanged() +method that the size has changed. We then inform the backing player that sizeDidChange(). + +* Modules/model-element/HTMLModelElement.cpp: +(WebCore::HTMLModelElement::createModelPlayer): +(WebCore::HTMLModelElement::par
[webkit-changes] [289494] trunk
Title: [289494] trunk
Revision 289494
Author commit-qu...@webkit.org
Date 2022-02-09 11:48:43 -0800 (Wed, 09 Feb 2022)
Log Message
Add TAO check to PerformanceResourceTiming::fetchStart
https://bugs.webkit.org/show_bug.cgi?id=236379
Patch by Alex Christensen on 2022-02-09
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
* web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt:
Source/WebCore:
This matches the spec and was recently changed in Chromium.
Covered by a newly passing WPT test.
* page/PerformanceResourceTiming.cpp:
(WebCore::fetchStart):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PerformanceResourceTiming.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289493 => 289494)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 19:39:13 UTC (rev 289493)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 19:48:43 UTC (rev 289494)
@@ -1,3 +1,12 @@
+2022-02-09 Alex Christensen
+
+Add TAO check to PerformanceResourceTiming::fetchStart
+https://bugs.webkit.org/show_bug.cgi?id=236379
+
+Reviewed by Chris Dumez.
+
+* web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt:
+
2022-02-09 Chris Dumez
Worker scripts should always be decoded as UTF-8
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt (289493 => 289494)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt 2022-02-09 19:39:13 UTC (rev 289493)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/cross-origin-start-end-time-with-redirects-expected.txt 2022-02-09 19:48:43 UTC (rev 289494)
@@ -1,3 +1,3 @@
-FAIL Verify that cross-origin resources don't implicitly expose their redirect timings assert_less_than: startTime should not expose redirect delays expected a number less than 2000 but got 2033
+PASS Verify that cross-origin resources don't implicitly expose their redirect timings
Modified: trunk/Source/WebCore/ChangeLog (289493 => 289494)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 19:39:13 UTC (rev 289493)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 19:48:43 UTC (rev 289494)
@@ -1,3 +1,17 @@
+2022-02-09 Alex Christensen
+
+Add TAO check to PerformanceResourceTiming::fetchStart
+https://bugs.webkit.org/show_bug.cgi?id=236379
+
+Reviewed by Chris Dumez.
+
+This matches the spec and was recently changed in Chromium.
+
+Covered by a newly passing WPT test.
+
+* page/PerformanceResourceTiming.cpp:
+(WebCore::fetchStart):
+
2022-02-09 Gabriel Nava Marino
Register strings in CSSTokenizer created from preprocessing
Modified: trunk/Source/WebCore/page/PerformanceResourceTiming.cpp (289493 => 289494)
--- trunk/Source/WebCore/page/PerformanceResourceTiming.cpp 2022-02-09 19:39:13 UTC (rev 289493)
+++ trunk/Source/WebCore/page/PerformanceResourceTiming.cpp 2022-02-09 19:48:43 UTC (rev 289494)
@@ -53,7 +53,7 @@
static double fetchStart(MonotonicTime timeOrigin, const ResourceTiming& resourceTiming)
{
-if (auto fetchStart = resourceTiming.networkLoadMetrics().fetchStart)
+if (auto fetchStart = resourceTiming.networkLoadMetrics().fetchStart; fetchStart && !resourceTiming.networkLoadMetrics().failsTAOCheck)
return networkLoadTimeToDOMHighResTimeStamp(timeOrigin, fetchStart);
// fetchStart is a required property.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289493] trunk/Source/WebCore
Title: [289493] trunk/Source/WebCore
Revision 289493
Author commit-qu...@webkit.org
Date 2022-02-09 11:39:13 -0800 (Wed, 09 Feb 2022)
Log Message
Register strings in CSSTokenizer created from preprocessing
https://bugs.webkit.org/show_bug.cgi?id=236309
Patch by Gabriel Nava Marino on 2022-02-09
Reviewed by Michael Saboff.
Register strings in CSSTokenizer created from preprocessing. This will align with
what is currently done for strings with escapes in CSSTokenizer::consumeName().
* css/parser/CSSTokenizer.cpp:
(WebCore::CSSTokenizer::preprocessString):
(WebCore::CSSTokenizer::tryCreate):
(WebCore::CSSTokenizer::CSSTokenizer):
(WebCore::preprocessString): Deleted.
* css/parser/CSSTokenizer.h:
* css/parser/CSSTokenizerInputStream.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSTokenizer.cpp
trunk/Source/WebCore/css/parser/CSSTokenizer.h
trunk/Source/WebCore/css/parser/CSSTokenizerInputStream.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (289492 => 289493)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 19:35:24 UTC (rev 289492)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 19:39:13 UTC (rev 289493)
@@ -1,3 +1,21 @@
+2022-02-09 Gabriel Nava Marino
+
+Register strings in CSSTokenizer created from preprocessing
+https://bugs.webkit.org/show_bug.cgi?id=236309
+
+Reviewed by Michael Saboff.
+
+Register strings in CSSTokenizer created from preprocessing. This will align with
+what is currently done for strings with escapes in CSSTokenizer::consumeName().
+
+* css/parser/CSSTokenizer.cpp:
+(WebCore::CSSTokenizer::preprocessString):
+(WebCore::CSSTokenizer::tryCreate):
+(WebCore::CSSTokenizer::CSSTokenizer):
+(WebCore::preprocessString): Deleted.
+* css/parser/CSSTokenizer.h:
+* css/parser/CSSTokenizerInputStream.h:
+
2022-02-09 Kimmo Kinnunen
DisplayListRecorder implementations are not able to obtain extra information out of source ImageBuffers
Modified: trunk/Source/WebCore/css/parser/CSSTokenizer.cpp (289492 => 289493)
--- trunk/Source/WebCore/css/parser/CSSTokenizer.cpp 2022-02-09 19:35:24 UTC (rev 289492)
+++ trunk/Source/WebCore/css/parser/CSSTokenizer.cpp 2022-02-09 19:39:13 UTC (rev 289493)
@@ -43,12 +43,16 @@
namespace WebCore {
// https://drafts.csswg.org/css-syntax/#input-preprocessing
-static String preprocessString(String string)
+String CSSTokenizer::preprocessString(String string)
{
// We don't replace '\r' and '\f' with '\n' as the specification suggests, instead
// we treat them all the same in the isNewLine function below.
+StringImpl* oldImpl = string.impl();
string.replace('\0', replacementCharacter);
-return replaceUnpairedSurrogatesWithReplacementCharacter(WTFMove(string));
+String replaced = replaceUnpairedSurrogatesWithReplacementCharacter(WTFMove(string));
+if (replaced.impl() != oldImpl)
+registerString(replaced);
+return replaced;
}
std::unique_ptr CSSTokenizer::tryCreate(const String& string)
@@ -55,7 +59,7 @@
{
bool success = true;
// We can't use makeUnique here because it does not have access to this private constructor.
-auto tokenizer = std::unique_ptr(new CSSTokenizer(preprocessString(string), nullptr, &success));
+auto tokenizer = std::unique_ptr(new CSSTokenizer(string, nullptr, &success));
if (UNLIKELY(!success))
return nullptr;
return tokenizer;
@@ -65,7 +69,7 @@
{
bool success = true;
// We can't use makeUnique here because it does not have access to this private constructor.
-auto tokenizer = std::unique_ptr(new CSSTokenizer(preprocessString(string), &wrapper, &success));
+auto tokenizer = std::unique_ptr(new CSSTokenizer(string, &wrapper, &success));
if (UNLIKELY(!success))
return nullptr;
return tokenizer;
@@ -72,17 +76,17 @@
}
CSSTokenizer::CSSTokenizer(const String& string)
-: CSSTokenizer(preprocessString(string), nullptr, nullptr)
+: CSSTokenizer(string, nullptr, nullptr)
{
}
CSSTokenizer::CSSTokenizer(const String& string, CSSParserObserverWrapper& wrapper)
-: CSSTokenizer(preprocessString(string), &wrapper, nullptr)
+: CSSTokenizer(string, &wrapper, nullptr)
{
}
-CSSTokenizer::CSSTokenizer(String&& string, CSSParserObserverWrapper* wrapper, bool* constructionSuccessPtr)
-: m_input(string)
+CSSTokenizer::CSSTokenizer(const String& string, CSSParserObserverWrapper* wrapper, bool* constructionSuccessPtr)
+: m_input(preprocessString(string))
{
if (constructionSuccessPtr)
*constructionSuccessPtr = true;
Modified: trunk/Source/WebCore/css/parser/CSSTokenizer.h (289492 => 289493)
--- trunk/Source/WebCore/css/parser/CSSTokenizer.h 2022-02-09 19:35:24 UTC (rev 289492)
+++ trunk/Source/WebCore/css/parser/CSSTokenizer.h 2022-02-09 19:39:13 UTC (rev 289493)
@@ -57,7 +57,7 @@
Vector&& escapedStringsForAdoption() { return WTF
[webkit-changes] [289492] trunk/Source
Title: [289492] trunk/Source
Revision 289492
Author commit-qu...@webkit.org
Date 2022-02-09 11:35:24 -0800 (Wed, 09 Feb 2022)
Log Message
DisplayListRecorder implementations are not able to obtain extra information out of source ImageBuffers
https://bugs.webkit.org/show_bug.cgi?id=236296
Patch by Kimmo Kinnunen on 2022-02-09
Reviewed by Wenson Hsieh.
Source/WebCore:
Pass ImageBuffer& to various recording commands instead of the resource identifier.
This way implementations of DisplayListRecorder can obtain additional information
about the ImageBuffer, such as dependency information. This additional information is
not neccessarily needed for in-process display lists.
* platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawFilteredImageBuffer):
(WebCore::DisplayList::Recorder::drawImageBuffer):
(WebCore::DisplayList::Recorder::clipToImageBuffer):
* platform/graphics/displaylists/DisplayListRecorder.h:
* platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
(WebCore::DisplayList::RecorderImpl::recordClipToImageBuffer):
(WebCore::DisplayList::RecorderImpl::recordDrawFilteredImageBuffer):
(WebCore::DisplayList::RecorderImpl::recordDrawImageBuffer):
* platform/graphics/displaylists/DisplayListRecorderImpl.h:
Source/WebKit:
RecorderImpl now passes ImageBuffers to the DisplayListRecorder calls.
Use the ImageBuffer& to get the resource identifier.
In future commits these places will obtain the read references, which
record the depenedency information needed for RemoteImageBuffers
created in multiple threads.
* WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp:
(WebKit::RemoteDisplayListRecorderProxy::recordClipToImageBuffer):
(WebKit::RemoteDisplayListRecorderProxy::recordDrawFilteredImageBuffer):
(WebKit::RemoteDisplayListRecorderProxy::recordDrawImageBuffer):
* WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.cpp
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorderImpl.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (289491 => 289492)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 19:31:06 UTC (rev 289491)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 19:35:24 UTC (rev 289492)
@@ -1,3 +1,26 @@
+2022-02-09 Kimmo Kinnunen
+
+DisplayListRecorder implementations are not able to obtain extra information out of source ImageBuffers
+https://bugs.webkit.org/show_bug.cgi?id=236296
+
+Reviewed by Wenson Hsieh.
+
+Pass ImageBuffer& to various recording commands instead of the resource identifier.
+This way implementations of DisplayListRecorder can obtain additional information
+about the ImageBuffer, such as dependency information. This additional information is
+not neccessarily needed for in-process display lists.
+
+* platform/graphics/displaylists/DisplayListRecorder.cpp:
+(WebCore::DisplayList::Recorder::drawFilteredImageBuffer):
+(WebCore::DisplayList::Recorder::drawImageBuffer):
+(WebCore::DisplayList::Recorder::clipToImageBuffer):
+* platform/graphics/displaylists/DisplayListRecorder.h:
+* platform/graphics/displaylists/DisplayListRecorderImpl.cpp:
+(WebCore::DisplayList::RecorderImpl::recordClipToImageBuffer):
+(WebCore::DisplayList::RecorderImpl::recordDrawFilteredImageBuffer):
+(WebCore::DisplayList::RecorderImpl::recordDrawImageBuffer):
+* platform/graphics/displaylists/DisplayListRecorderImpl.h:
+
2022-02-09 Chris Dumez
Worker scripts should always be decoded as UTF-8
Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp (289491 => 289492)
--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2022-02-09 19:31:06 UTC (rev 289491)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp 2022-02-09 19:35:24 UTC (rev 289492)
@@ -159,7 +159,7 @@
}
if (!sourceImage) {
-recordDrawFilteredImageBuffer({ }, sourceImageRect, filter);
+recordDrawFilteredImageBuffer(nullptr, sourceImageRect, filter);
return;
}
@@ -168,7 +168,7 @@
return;
}
-recordDrawFilteredImageBuffer(sourceImage->renderingResourceIdentifier(), sourceImageRect, filter);
+recordDrawFilteredImageBuffer(sourceImage, sourceImageRect, filter);
}
void Recorder::drawGlyphs(const Font& font, const GlyphBufferGlyph* glyphs, const GlyphBufferAdvance* advances, unsigned numGlyphs, const FloatPoint& startPoi
[webkit-changes] [289491] trunk/Source/bmalloc
Title: [289491] trunk/Source/bmalloc Revision 289491 Author fpi...@apple.com Date 2022-02-09 11:31:06 -0800 (Wed, 09 Feb 2022) Log Message [libpas] add documentation https://bugs.webkit.org/show_bug.cgi?id=236385 Rubber stamped by Mark Lam. * libpas/Documentation.md: Added. Modified Paths trunk/Source/bmalloc/ChangeLog Added Paths trunk/Source/bmalloc/libpas/Documentation.md Diff Modified: trunk/Source/bmalloc/ChangeLog (289490 => 289491) --- trunk/Source/bmalloc/ChangeLog 2022-02-09 18:56:42 UTC (rev 289490) +++ trunk/Source/bmalloc/ChangeLog 2022-02-09 19:31:06 UTC (rev 289491) @@ -1,3 +1,12 @@ +2022-02-09 Filip Pizlo + +[libpas] add documentation +https://bugs.webkit.org/show_bug.cgi?id=236385 + +Rubber stamped by Mark Lam. + +* libpas/Documentation.md: Added. + 2022-02-05 Yusuke Suzuki Thread suspend and resume should take a global lock to avoid deadlock Added: trunk/Source/bmalloc/libpas/Documentation.md (0 => 289491) --- trunk/Source/bmalloc/libpas/Documentation.md (rev 0) +++ trunk/Source/bmalloc/libpas/Documentation.md 2022-02-09 19:31:06 UTC (rev 289491) @@ -0,0 +1,1326 @@ +# All About Libpas, Phil's Super Fast Malloc + +Filip Pizlo, Apple Inc., February 2022 + +# License + +Copyright (c) 2022 Apple Inc. All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions +are met: + +1. Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. +2. Redistributions in binary form must reproduce the above copyright + notice, this list of conditions and the following disclaimer in the + documentation and/or other materials provided with the distribution. + +THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY +EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR +PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR +CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, +EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, +PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR +PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY +OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +# Introduction + +This document describes how libpas works as of a361efa96ca4b2ff6bdfc28bc7eb1a678cde75be, so a bit ahead of +where WebKit was as of r289146. Libpas is a fast and memory-efficient memory allocation toolkit capable of +supporting many heaps at once, engineered with the hopes that someday it'll be used for comprehensive isoheaping +of all malloc/new callsites in C/C++ programs. + +Since WebKit r213753, we've been steadinly enabling libpas as a replacement for WebKit's bmalloc and +MetaAllocator. This has so far added up to a ~2% Speedometer2 speed-up and a ~8% memory improvement (on multiple +memory benchmarks). Half of the speed-up comes from replacing the MetaAllocator, which was _javascript_Core's old +way of managing executable memory. Now, JSC uses libpas's jit_heap to manage executable memory. The other half +of the speed-up comes from replacing everything that bmalloc provided -- the fastMalloc API, the Gigacage API, +and the IsoHeap<> API. All of the memory improvement comes from replacing bmalloc (the MetaAllocator was already +fairly memory-efficient). + +This document is structured as follows. First I describe the goals of libpas; these are the things that a +malloc-like API created out of libpas should be able to expose as fast and memory-efficient functions. Then I +describe the coding style. Next I tell all about the design. Finally I talk about how libpas is tested. + +# Goals of Libpas + +Libpas tries to be: + +- Fast. The goal is to beat bmalloc performance on single-threaded code. Bmalloc was previously the fastest + known malloc for WebKit. +- Scalable. Libpas is meant to scale well on multi-core devices. +- Memory-efficient. The goal is to beat bmalloc memory usage across the board. Part of the strategy for memory + efficiency is consistent use of first-fit allocation. +- External metadata. Libpas never puts information about a free object inside that object. The metadata is + always elsewhere. So, there's no way for a use-after-free to corrupt libpas's understanding of memory. +- Multiple heap configurations. Not all programs want the same time-memory trade-off. Some malloc users have + very bizarre requirements, like what _javascript_Core does with its ExecutableAllocator. The goal is to support + all kinds of special allocator needs simultaneously in one library. +- Boatloads of heaps. Libpas was written with the dream of obv
[webkit-changes] [289489] trunk
Title: [289489] trunk
Revision 289489
Author cdu...@apple.com
Date 2022-02-09 10:51:23 -0800 (Wed, 09 Feb 2022)
Log Message
Worker scripts should always be decoded as UTF-8
https://bugs.webkit.org/show_bug.cgi?id=236319
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline WPT tests that are now passing.
* web-platform-tests/workers/semantics/encodings/001-expected.txt:
* web-platform-tests/workers/semantics/encodings/002-expected.txt:
Source/WebCore:
Worker scripts should always be decoded as UTF-8:
- https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-script (Step 7)
No new tests, rebaselined existing tests.
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didReceiveData):
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/002-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/WorkerScriptLoader.cpp
trunk/Source/WebCore/workers/WorkerScriptLoader.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289488 => 289489)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 18:50:58 UTC (rev 289488)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 18:51:23 UTC (rev 289489)
@@ -1,5 +1,17 @@
2022-02-09 Chris Dumez
+Worker scripts should always be decoded as UTF-8
+https://bugs.webkit.org/show_bug.cgi?id=236319
+
+Reviewed by Alex Christensen.
+
+Rebaseline WPT tests that are now passing.
+
+* web-platform-tests/workers/semantics/encodings/001-expected.txt:
+* web-platform-tests/workers/semantics/encodings/002-expected.txt:
+
+2022-02-09 Chris Dumez
+
self.location.href is incorrect in shared workers in case of redirects
https://bugs.webkit.org/show_bug.cgi?id=236340
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/001-expected.txt (289488 => 289489)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/001-expected.txt 2022-02-09 18:50:58 UTC (rev 289488)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/001-expected.txt 2022-02-09 18:51:23 UTC (rev 289489)
@@ -1,3 +1,3 @@
-FAIL encoding, dedicated worker assert_equals: expected "å" but got "Ã¥"
+PASS encoding, dedicated worker
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/002-expected.txt (289488 => 289489)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/002-expected.txt 2022-02-09 18:50:58 UTC (rev 289488)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/002-expected.txt 2022-02-09 18:51:23 UTC (rev 289489)
@@ -1,3 +1,3 @@
-FAIL encoding, shared worker assert_equals: expected "å" but got "Ã¥"
+PASS encoding, shared worker
Modified: trunk/Source/WebCore/ChangeLog (289488 => 289489)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 18:50:58 UTC (rev 289488)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 18:51:23 UTC (rev 289489)
@@ -1,5 +1,20 @@
2022-02-09 Chris Dumez
+Worker scripts should always be decoded as UTF-8
+https://bugs.webkit.org/show_bug.cgi?id=236319
+
+Reviewed by Alex Christensen.
+
+Worker scripts should always be decoded as UTF-8:
+- https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-script (Step 7)
+
+No new tests, rebaselined existing tests.
+
+* workers/WorkerScriptLoader.cpp:
+(WebCore::WorkerScriptLoader::didReceiveData):
+
+2022-02-09 Chris Dumez
+
self.location.href is incorrect in shared workers in case of redirects
https://bugs.webkit.org/show_bug.cgi?id=236340
Modified: trunk/Source/WebCore/workers/WorkerScriptLoader.cpp (289488 => 289489)
--- trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2022-02-09 18:50:58 UTC (rev 289488)
+++ trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2022-02-09 18:51:23 UTC (rev 289489)
@@ -197,7 +197,6 @@
m_responseURL = response.url();
m_certificateInfo = response.certificateInfo() ? *response.certificateInfo() : CertificateInfo();
m_responseMIMEType = response.mimeType();
-m_responseEncoding = response.textEncodingName();
m_responseSource = response.source();
m_isRedirected = response.isRedirected();
m_contentSecurityPolicy = ContentSecurityPolicyResponseHeaders { response };
@@ -213,12 +212,8 @@
if (m_failed)
return;
-if (!m_decoder) {
-if (!m_responseEncoding.isEmpty())
-m_decoder = TextResourceDecoder::create("text/_javascript_"_s, m_responseEncoding);
-else
-m_decoder = TextResourceDecoder::create("text/_javascript_"_s, "UTF-8");
-}
+if (!m_decoder)
+m_decoder = TextResourceDecoder:
[webkit-changes] [289488] tags/Safari-613.1.16.31.2/
Title: [289488] tags/Safari-613.1.16.31.2/ Revision 289488 Author repst...@apple.com Date 2022-02-09 10:50:58 -0800 (Wed, 09 Feb 2022) Log Message Tag Safari-613.1.16.31.2. Added Paths tags/Safari-613.1.16.31.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289487] branches/safari-613.1.16.31-branch/Source
Title: [289487] branches/safari-613.1.16.31-branch/Source
Revision 289487
Author repst...@apple.com
Date 2022-02-09 10:50:10 -0800 (Wed, 09 Feb 2022)
Log Message
Cherry-pick r288970. rdar://problem/88459807
Update computation of FAST_TLS base.
https://bugs.webkit.org/show_bug.cgi?id=235934
Reviewed by Yusuke Suzuki.
Source/_javascript_Core:
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::loadFromTLS32):
(JSC::MacroAssemblerARM64::loadFromTLS64):
(JSC::MacroAssemblerARM64::storeToTLS32):
(JSC::MacroAssemblerARM64::storeToTLS64):
* assembler/SecureARM64EHashPinsInlines.h:
(JSC::SecureARM64EHashPins::keyForCurrentThread):
* offlineasm/arm64.rb:
Source/WTF:
* wtf/PlatformHave.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.1.16.31-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.1.16.31-branch/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
branches/safari-613.1.16.31-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h
branches/safari-613.1.16.31-branch/Source/_javascript_Core/offlineasm/arm64.rb
branches/safari-613.1.16.31-branch/Source/WTF/ChangeLog
branches/safari-613.1.16.31-branch/Source/WTF/wtf/PlatformHave.h
Diff
Modified: branches/safari-613.1.16.31-branch/Source/_javascript_Core/ChangeLog (289486 => 289487)
--- branches/safari-613.1.16.31-branch/Source/_javascript_Core/ChangeLog 2022-02-09 18:48:41 UTC (rev 289486)
+++ branches/safari-613.1.16.31-branch/Source/_javascript_Core/ChangeLog 2022-02-09 18:50:10 UTC (rev 289487)
@@ -1,3 +1,46 @@
+2022-02-09 Russell Epstein
+
+Cherry-pick r288970. rdar://problem/88459807
+
+Update computation of FAST_TLS base.
+https://bugs.webkit.org/show_bug.cgi?id=235934
+
+Reviewed by Yusuke Suzuki.
+
+Source/_javascript_Core:
+
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::loadFromTLS32):
+(JSC::MacroAssemblerARM64::loadFromTLS64):
+(JSC::MacroAssemblerARM64::storeToTLS32):
+(JSC::MacroAssemblerARM64::storeToTLS64):
+* assembler/SecureARM64EHashPinsInlines.h:
+(JSC::SecureARM64EHashPins::keyForCurrentThread):
+* offlineasm/arm64.rb:
+
+Source/WTF:
+
+* wtf/PlatformHave.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-02 Mark Lam
+
+Update computation of FAST_TLS base.
+https://bugs.webkit.org/show_bug.cgi?id=235934
+
+Reviewed by Yusuke Suzuki.
+
+* assembler/MacroAssemblerARM64.h:
+(JSC::MacroAssemblerARM64::loadFromTLS32):
+(JSC::MacroAssemblerARM64::loadFromTLS64):
+(JSC::MacroAssemblerARM64::storeToTLS32):
+(JSC::MacroAssemblerARM64::storeToTLS64):
+* assembler/SecureARM64EHashPinsInlines.h:
+(JSC::SecureARM64EHashPins::keyForCurrentThread):
+* offlineasm/arm64.rb:
+
2022-02-08 Russell Epstein
Cherry-pick r289024. rdar://problem/88654211
Modified: branches/safari-613.1.16.31-branch/Source/_javascript_Core/assembler/MacroAssemblerARM64.h (289486 => 289487)
--- branches/safari-613.1.16.31-branch/Source/_javascript_Core/assembler/MacroAssemblerARM64.h 2022-02-09 18:48:41 UTC (rev 289486)
+++ branches/safari-613.1.16.31-branch/Source/_javascript_Core/assembler/MacroAssemblerARM64.h 2022-02-09 18:50:10 UTC (rev 289487)
@@ -4521,7 +4521,9 @@
void loadFromTLS32(uint32_t offset, RegisterID dst)
{
m_assembler.mrs_TPIDRRO_EL0(dst);
+#if !HAVE(SIMPLIFIED_FAST_TLS_BASE)
and64(TrustedImm32(~7), dst);
+#endif
load32(Address(dst, offset), dst);
}
@@ -4528,7 +4530,9 @@
void loadFromTLS64(uint32_t offset, RegisterID dst)
{
m_assembler.mrs_TPIDRRO_EL0(dst);
+#if !HAVE(SIMPLIFIED_FAST_TLS_BASE)
and64(TrustedImm32(~7), dst);
+#endif
load64(Address(dst, offset), dst);
}
@@ -4542,7 +4546,9 @@
RegisterID tmp = getCachedDataTempRegisterIDAndInvalidate();
ASSERT(src != tmp);
m_assembler.mrs_TPIDRRO_EL0(tmp);
+#if !HAVE(SIMPLIFIED_FAST_TLS_BASE)
and64(TrustedImm32(~7), tmp);
+#endif
store32(src, Address(tmp, offset));
}
@@ -4551,7 +4557,9 @@
RegisterID tmp = getCachedDataTempRegisterIDAndInvalidate();
ASSERT(src != tmp);
m_assembler.mrs_TPIDRRO_EL0(tmp);
+#if !HAVE(SIMPLIFIED_FAST_TLS_BASE)
and64(TrustedImm32(~7), tmp);
+#endif
store64(src, Address(tmp, offset));
}
Modified: branches/safari-613.1.16.31-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h (289486 => 289487)
--- branches/safari-613.1.16.31-branch/Source/_javascript_Core/assembler/SecureARM64EHashPinsInlines.h 2022-02-09 18:48:41 UTC (rev 28948
[webkit-changes] [289486] branches/safari-613.1.16.31-branch/Source
Title: [289486] branches/safari-613.1.16.31-branch/Source Revision 289486 Author repst...@apple.com Date 2022-02-09 10:48:41 -0800 (Wed, 09 Feb 2022) Log Message Versioning. WebKit-7613.1.16.31.2 Modified Paths branches/safari-613.1.16.31-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.16.31-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.16.31-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.16.31-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.16.31-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.16.31-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.1.16.31-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.16.31-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.16.31-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.16.31-branch/Source/_javascript_Core/Configurations/Version.xcconfig (289485 => 289486) --- branches/safari-613.1.16.31-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-09 18:45:22 UTC (rev 289485) +++ branches/safari-613.1.16.31-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-09 18:48:41 UTC (rev 289486) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 31; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.31-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (289485 => 289486) --- branches/safari-613.1.16.31-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-09 18:45:22 UTC (rev 289485) +++ branches/safari-613.1.16.31-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-09 18:48:41 UTC (rev 289486) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 31; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.31-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (289485 => 289486) --- branches/safari-613.1.16.31-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-09 18:45:22 UTC (rev 289485) +++ branches/safari-613.1.16.31-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-09 18:48:41 UTC (rev 289486) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 31; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.31-branch/Source/WebCore/Configurations/Version.xcconfig (289485 => 289486) --- branches/safari-613.1.16.31-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-09 18:45:22 UTC (rev 289485) +++ branches/safari-613.1.16.31-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-09 18:48:41 UTC (rev 289486) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 31; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.31-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (289485 => 289486) --- branches/safari-613.1.16.31-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-09 18:45:22 UTC (rev 289485) +++ branches/safari-613.1.16.31-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-09 18:48:41 UTC (rev 289486) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 31; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.31-branch/Source/WebGPU/Configurations/Version.xcconfig (289485 => 289486) --- branches/safari-613.1.16.31-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-09 18:45:22 UTC (rev 289485) +++ branches/safari-613.1.16.31-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-09 18:48:41 UTC (rev 289486) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 31;
[webkit-changes] [289485] trunk/Source
Title: [289485] trunk/Source Revision 289485 Author commit-qu...@webkit.org Date 2022-02-09 10:45:22 -0800 (Wed, 09 Feb 2022) Log Message Move Safe Browsing knowledge into SafariSafeBrowsing framework https://bugs.webkit.org/show_bug.cgi?id=231692 Patch by Eliot Hsu on 2022-02-09 Reviewed by Alex Christensen. Following up on an old FIXME, move Safari Safe Browsing-specific knowledge out of WebKit and into the SafariSafeBrowsing framework. This includes things like the Learn More URL, the Report an Error URL, etc. Source/WebKit: * Platform/spi/Cocoa/SafeBrowsingSPI.h: * UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm: (WebKit::malwareDetailsBase): (WebKit::learnMoreURL): (WebKit::reportAnErrorBase): (WebKit::localizedProvider): Rely on new SafariSafeBrowsing calls to provide URL/provider information about Safe Browsing, when available Source/WTF: * wtf/PlatformHave.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PlatformHave.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm Diff Modified: trunk/Source/WTF/ChangeLog (289484 => 289485) --- trunk/Source/WTF/ChangeLog 2022-02-09 18:39:17 UTC (rev 289484) +++ trunk/Source/WTF/ChangeLog 2022-02-09 18:45:22 UTC (rev 289485) @@ -1,3 +1,17 @@ +2022-02-09 Eliot Hsu + +Move Safe Browsing knowledge into SafariSafeBrowsing framework +https://bugs.webkit.org/show_bug.cgi?id=231692 + +Reviewed by Alex Christensen. + +Following up on an old FIXME, move Safari Safe Browsing-specific +knowledge out of WebKit and into the SafariSafeBrowsing framework. +This includes things like the Learn More URL, the Report an Error URL, +etc. + +* wtf/PlatformHave.h: + 2022-02-08 Eric Carlson [macOS] Update requirements for ScreenCaptureKit Modified: trunk/Source/WTF/wtf/PlatformHave.h (289484 => 289485) --- trunk/Source/WTF/wtf/PlatformHave.h 2022-02-09 18:39:17 UTC (rev 289484) +++ trunk/Source/WTF/wtf/PlatformHave.h 2022-02-09 18:45:22 UTC (rev 289485) @@ -1173,3 +1173,7 @@ #if ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 150400) #define HAVE_UIACTIVITYTYPE_SHAREPLAY 1 #endif + +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 13) || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 16) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 9) +#define HAVE_SAFE_BROWSING_RESULT_DETAILS 1 +#endif Modified: trunk/Source/WebKit/ChangeLog (289484 => 289485) --- trunk/Source/WebKit/ChangeLog 2022-02-09 18:39:17 UTC (rev 289484) +++ trunk/Source/WebKit/ChangeLog 2022-02-09 18:45:22 UTC (rev 289485) @@ -1,3 +1,25 @@ +2022-02-09 Eliot Hsu + +Move Safe Browsing knowledge into SafariSafeBrowsing framework +https://bugs.webkit.org/show_bug.cgi?id=231692 + +Reviewed by Alex Christensen. + +Following up on an old FIXME, move Safari Safe Browsing-specific +knowledge out of WebKit and into the SafariSafeBrowsing framework. +This includes things like the Learn More URL, the Report an Error URL, +etc. + +* Platform/spi/Cocoa/SafeBrowsingSPI.h: +* UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm: +(WebKit::malwareDetailsBase): +(WebKit::learnMoreURL): +(WebKit::reportAnErrorBase): +(WebKit::localizedProvider): +Rely on new SafariSafeBrowsing calls to provide +URL/provider information about Safe Browsing, +when available + 2022-02-09 Chris Dumez self.location.href is incorrect in shared workers in case of redirects Modified: trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h (289484 => 289485) --- trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h 2022-02-09 18:39:17 UTC (rev 289484) +++ trunk/Source/WebKit/Platform/spi/Cocoa/SafeBrowsingSPI.h 2022-02-09 18:45:22 UTC (rev 289485) @@ -50,6 +50,13 @@ @property (nonatomic, readonly, getter=isMalware) BOOL malware; @property (nonatomic, readonly, getter=isUnwantedSoftware) BOOL unwantedSoftware; +#if HAVE(SAFE_BROWSING_RESULT_DETAILS) +@property (nonatomic, readonly) NSString *malwareDetailsBaseURLString; +@property (nonatomic, readonly) NSURL *learnMoreURL; +@property (nonatomic, readonly) NSString *reportAnErrorBaseURLString; +@property (nonatomic, readonly) NSString *localizedProviderDisplayName; +#endif + @end @interface SSBLookupResult : NSObject Modified: trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm (289484 => 289485) --- trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm 2022-02-09 18:39:17 UTC (rev 289484) +++ trunk/Source/WebKit/UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm 2022-02-09 18:45:22 UTC (rev 289485) @@ -35,34 +35,48 @@ #if HAVE(SAFE_BROWSING) -// FIXME: These four functions ought to be API calls to the SafariSafeBrowsing framework when such SPI is av
[webkit-changes] [289484] trunk/LayoutTests
Title: [289484] trunk/LayoutTests Revision 289484 Author jon...@apple.com Date 2022-02-09 10:39:17 -0800 (Wed, 09 Feb 2022) Log Message Unreviewed gardening. Timeout due to turning WebGL on by default on bots. Will be addressed in b234536. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (289483 => 289484) --- trunk/LayoutTests/ChangeLog 2022-02-09 18:30:28 UTC (rev 289483) +++ trunk/LayoutTests/ChangeLog 2022-02-09 18:39:17 UTC (rev 289484) @@ -1,3 +1,10 @@ +2022-02-09 Jon Lee + +Unreviewed gardening. + +Timeout due to turning WebGL on by default on bots. Will be addressed in b234536. +* platform/ios-wk2/TestExpectations: + 2022-02-09 Chris Dumez Resync web-platform-tests/html/dom from upstream Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (289483 => 289484) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-02-09 18:30:28 UTC (rev 289483) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-02-09 18:39:17 UTC (rev 289484) @@ -2218,4 +2218,5 @@ webkit.org/b/234536 webxr/high-performance.html webkit.org/b/234536 fast/mediastream/getUserMedia-to-canvas-1.html [ Crash ] webkit.org/b/234536 fast/mediastream/getUserMedia-to-canvas-2.html [ Crash ] -webkit.org/b/234536 webgl/max-active-contexts-webglcontextlost-prevent-default.html [ Timeout ] \ No newline at end of file +webkit.org/b/234536 webgl/max-active-contexts-webglcontextlost-prevent-default.html [ Timeout ] +webkit.org/b/234536 webgl/1.0.3/conformance/state/gl-object-get-calls.html [ Timeout ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289483] trunk
Title: [289483] trunk Revision 289483 Author cdu...@apple.com Date 2022-02-09 10:30:28 -0800 (Wed, 09 Feb 2022) Log Message self.location.href is incorrect in shared workers in case of redirects https://bugs.webkit.org/show_bug.cgi?id=236340 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Rebaseline WPT tests that are now passing. * web-platform-tests/workers/baseurl/alpha/importScripts-in-sharedworker-expected.txt: * web-platform-tests/workers/baseurl/alpha/xhr-in-sharedworker-expected.txt: * web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-sharedworker-expected.txt: Source/WebCore: self.location.href is incorrect in shared workers in case of redirects. It should be the URL of the last request, not the first one. No new tests, rebaselined existing tests. * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::redirectReceived): * loader/ThreadableLoaderClient.h: (WebCore::ThreadableLoaderClient::redirectReceived): * loader/ThreadableLoaderClientWrapper.h: (WebCore::ThreadableLoaderClientWrapper::redirectReceived): * loader/WorkerThreadableLoader.cpp: (WebCore::WorkerThreadableLoader::MainThreadBridge::redirectReceived): * loader/WorkerThreadableLoader.h: * workers/Worker.cpp: (WebCore::Worker::notifyFinished): * workers/WorkerFetchResult.h: (WebCore::WorkerFetchResult::isolatedCopy const): (WebCore::workerFetchError): (WebCore::WorkerFetchResult::encode const): (WebCore::WorkerFetchResult::decode): * workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): (WebCore::WorkerScriptLoader::loadAsynchronously): (WebCore::WorkerScriptLoader::redirectReceived): (WebCore::WorkerScriptLoader::fetchResult const): * workers/WorkerScriptLoader.h: (WebCore::WorkerScriptLoader::script const): (WebCore::WorkerScriptLoader::lastRequestURL const): (WebCore::WorkerScriptLoader::script): Deleted. * workers/service/ServiceWorkerContainer.cpp: (WebCore::ServiceWorkerContainer::jobFinishedLoadingScript): * workers/service/ServiceWorkerContainer.h: * workers/service/ServiceWorkerJob.cpp: (WebCore::ServiceWorkerJob::notifyFinished): * workers/service/ServiceWorkerJobClient.h: * workers/shared/SharedWorkerScriptLoader.cpp: (WebCore::SharedWorkerScriptLoader::notifyFinished): * workers/shared/context/SharedWorkerThreadProxy.cpp: (WebCore::generateWorkerParameters): (WebCore::SharedWorkerThreadProxy::SharedWorkerThreadProxy): * workers/shared/context/SharedWorkerThreadProxy.h: Source/WebKit: self.location.href is incorrect in shared workers in case of redirects. It should be the URL of the last request, not the first one. * NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp: (WebKit::ServiceWorkerSoftUpdateLoader::didFinishLoading): * NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp: (WebKit::WebSharedWorkerServerToContextConnection::launchSharedWorker): * WebProcess/Storage/WebSharedWorkerContextManagerConnection.cpp: (WebKit::WebSharedWorkerContextManagerConnection::launchSharedWorker): * WebProcess/Storage/WebSharedWorkerContextManagerConnection.h: * WebProcess/Storage/WebSharedWorkerContextManagerConnection.messages.in: Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/importScripts-in-sharedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/baseurl/alpha/xhr-in-sharedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/location/redirect-sharedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/xhr/open-url-redirected-sharedworker-origin-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/xhr/open-url-redirected-sharedworker-origin-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp trunk/Source/WebCore/loader/ThreadableLoaderClient.h trunk/Source/WebCore/loader/ThreadableLoaderClientWrapper.h trunk/Source/WebCore/loader/WorkerThreadableLoader.cpp trunk/Source/WebCore/loader/WorkerThreadableLoader.h trunk/Source/WebCore/workers/Worker.cpp trunk/Source/WebCore/workers/WorkerFetchResult.h trunk/Source/WebCore/workers/WorkerScriptLoader.cpp trunk/Source/WebCore/workers/WorkerScriptLoader.h trunk/Source/WebCore/workers/service/ServiceWorkerContainer.cpp trunk/Source/WebCore/workers/service/ServiceWorkerContainer.h trunk/Source/WebCore/workers/service/ServiceWorkerJob.cpp trunk/Source/WebCore/workers/service/ServiceWorkerJobClient.h trunk/Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp trunk/Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.cpp trunk/Source/WebCore/workers/shared/context/SharedWorkerThreadProxy.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerSoftUpdateLoader.cpp trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp trunk/Source/WebKi
[webkit-changes] [289482] trunk
Title: [289482] trunk
Revision 289482
Author j_pas...@apple.com
Date 2022-02-09 10:17:43 -0800 (Wed, 09 Feb 2022)
Log Message
[WebAuthn] Specify LocalAuthenticatorAccessGroup when importing credentials
https://bugs.webkit.org/show_bug.cgi?id=236311
rdar://88394179
Reviewed by Brent Fulgham.
Source/WebKit:
Tested on device and added check for accessGroup in API test.
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
(+[_WKWebAuthenticationPanel importLocalAuthenticatorCredential:error:]):
(+[_WKWebAuthenticationPanel importLocalAuthenticatorWithAccessGroup:credential:error:]):
Tools:
Added check for accessGroup to API test.
* TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::WebCore::addKeyToKeychain):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (289481 => 289482)
--- trunk/Source/WebKit/ChangeLog 2022-02-09 18:16:32 UTC (rev 289481)
+++ trunk/Source/WebKit/ChangeLog 2022-02-09 18:17:43 UTC (rev 289482)
@@ -1,3 +1,18 @@
+2022-02-09 J Pascoe
+
+[WebAuthn] Specify LocalAuthenticatorAccessGroup when importing credentials
+https://bugs.webkit.org/show_bug.cgi?id=236311
+rdar://88394179
+
+Reviewed by Brent Fulgham.
+
+Tested on device and added check for accessGroup in API test.
+
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h:
+* UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
+(+[_WKWebAuthenticationPanel importLocalAuthenticatorCredential:error:]):
+(+[_WKWebAuthenticationPanel importLocalAuthenticatorWithAccessGroup:credential:error:]):
+
2022-02-09 Sihui Liu
Manage IndexedDB storage by origin
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h (289481 => 289482)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h 2022-02-09 18:16:32 UTC (rev 289481)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.h 2022-02-09 18:17:43 UTC (rev 289482)
@@ -119,6 +119,7 @@
+ (NSData *)exportLocalAuthenticatorCredentialWithID:(NSData *)credentialID error:(NSError **)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+ (NSData *)importLocalAuthenticatorCredential:(NSData *)credentialBlob error:(NSError **)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
++ (NSData *)importLocalAuthenticatorWithAccessGroup:(NSString *)accessGroup credential:(NSData *)credentialBlob error:(NSError **)error WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+ (BOOL)isUserVerifyingPlatformAuthenticatorAvailable WK_API_AVAILABLE(macos(12.0), ios(15.0));
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm (289481 => 289482)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm 2022-02-09 18:16:32 UTC (rev 289481)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm 2022-02-09 18:17:43 UTC (rev 289482)
@@ -398,6 +398,11 @@
+ (NSData *)importLocalAuthenticatorCredential:(NSData *)credentialBlob error:(NSError **)error
{
+return [self importLocalAuthenticatorWithAccessGroup:@(WebCore::LocalAuthenticatorAccessGroup) credential:credentialBlob error:error];
+}
+
++ (NSData *)importLocalAuthenticatorWithAccessGroup:(NSString *)accessGroup credential:(NSData *)credentialBlob error:(NSError **)error
+{
#if ENABLE(WEB_AUTHN)
auto credential = cbor::CBORReader::read(vectorFromNSData(credentialBlob));
if (!credential || !credential->isMap()) {
@@ -481,6 +486,9 @@
]);
updateQueryIfNecessary(query.get());
+if (accessGroup != nil)
+[query setObject:accessGroup forKey:(__bridge id)kSecAttrAccessGroup];
+
OSStatus status = SecItemCopyMatching(bridge_cast(query.get()), nullptr);
if (!status) {
// Credential with same id already exists, duplicate key.
@@ -489,15 +497,22 @@
}
auto secAttrApplicationTag = adoptNS([[NSData alloc] initWithBytes:keyTag->data() length:keyTag->size()]);
-NSDictionary *addQuery = @{
-(id)kSecValueRef: (id)key.get(),
-(id)kSecAttrKeyClass: (id)kSecAttrKeyClassPrivate,
-(id)kSecAttrLabel: rp,
-(id)kSecAttrApplicationTag: secAttrApplicationTag.get(),
-(id)kSecUseDataProtectionKeychain: @YES,
-(id)kSecAttrAccessible: (id)kSecAttrAccessibleAfterFirstUnlock
-};
-status = SecItemAdd(bridge_cast(addQuery), NULL);
+
+auto addQuery = adoptNS([[NSMutableDictionary alloc] initWithObjectsAndKeys:
+(id)key.get(), (id)kSecValueRef,
+(id)kSecAttrKeyClassPrivate, (id)kSecAttrKeyClass,
+(id)rp, (id)kSecAttrLabel,
+secAttrApplicatio
[webkit-changes] [289481] branches/safari-613.1.16.1-branch
Title: [289481] branches/safari-613.1.16.1-branch
Revision 289481
Author repst...@apple.com
Date 2022-02-09 10:16:32 -0800 (Wed, 09 Feb 2022)
Log Message
Cherry-pick r289450. rdar://problem/88483574
[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
https://bugs.webkit.org/show_bug.cgi?id=236332
rdar://88483574
Reviewed by Michael Saboff.
JSTests:
* stress/yarr-inlining-dot-star-enclosure.js: Added.
(test):
Source/_javascript_Core:
YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
* yarr/YarrJIT.cpp:
* yarr/YarrJITRegisters.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-613.1.16.1-branch/JSTests/ChangeLog
branches/safari-613.1.16.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-613.1.16.1-branch/Source/_javascript_Core/yarr/YarrJIT.cpp
branches/safari-613.1.16.1-branch/Source/_javascript_Core/yarr/YarrJITRegisters.h
Added Paths
branches/safari-613.1.16.1-branch/JSTests/stress/yarr-inlining-dot-star-enclosure.js
Diff
Modified: branches/safari-613.1.16.1-branch/JSTests/ChangeLog (289480 => 289481)
--- branches/safari-613.1.16.1-branch/JSTests/ChangeLog 2022-02-09 18:12:49 UTC (rev 289480)
+++ branches/safari-613.1.16.1-branch/JSTests/ChangeLog 2022-02-09 18:16:32 UTC (rev 289481)
@@ -1,3 +1,40 @@
+2022-02-09 Russell Epstein
+
+Cherry-pick r289450. rdar://problem/88483574
+
+[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
+https://bugs.webkit.org/show_bug.cgi?id=236332
+rdar://88483574
+
+Reviewed by Michael Saboff.
+
+JSTests:
+
+* stress/yarr-inlining-dot-star-enclosure.js: Added.
+(test):
+
+Source/_javascript_Core:
+
+YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
+it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
+This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
+
+* yarr/YarrJIT.cpp:
+* yarr/YarrJITRegisters.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-08 Yusuke Suzuki
+
+[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
+https://bugs.webkit.org/show_bug.cgi?id=236332
+rdar://88483574
+
+Reviewed by Michael Saboff.
+
+* stress/yarr-inlining-dot-star-enclosure.js: Added.
+(test):
+
2022-01-07 Alexey Shvayka
Expand the set of objects we take JSArray::fastSlice() path for
Added: branches/safari-613.1.16.1-branch/JSTests/stress/yarr-inlining-dot-star-enclosure.js (0 => 289481)
--- branches/safari-613.1.16.1-branch/JSTests/stress/yarr-inlining-dot-star-enclosure.js (rev 0)
+++ branches/safari-613.1.16.1-branch/JSTests/stress/yarr-inlining-dot-star-enclosure.js 2022-02-09 18:16:32 UTC (rev 289481)
@@ -0,0 +1,9 @@
+function test(string)
+{
+return /.*\:.*/.test(string);
+}
+noInline(test);
+
+for (var i = 0; i < 1e4; ++i) {
+test(String(i));
+}
Modified: branches/safari-613.1.16.1-branch/Source/_javascript_Core/ChangeLog (289480 => 289481)
--- branches/safari-613.1.16.1-branch/Source/_javascript_Core/ChangeLog 2022-02-09 18:12:49 UTC (rev 289480)
+++ branches/safari-613.1.16.1-branch/Source/_javascript_Core/ChangeLog 2022-02-09 18:16:32 UTC (rev 289481)
@@ -1,3 +1,44 @@
+2022-02-09 Russell Epstein
+
+Cherry-pick r289450. rdar://problem/88483574
+
+[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
+https://bugs.webkit.org/show_bug.cgi?id=236332
+rdar://88483574
+
+Reviewed by Michael Saboff.
+
+JSTests:
+
+* stress/yarr-inlining-dot-star-enclosure.js: Added.
+(test):
+
+Source/_javascript_Core:
+
+YarrJITRegisters::initialStart can be used when m_pattern.m_saveInitialStartValue is true while
+it is not defined in YarrJIT inlining. As a result, we emit broken code using InvalidGPRReg.
+This patch makes canInline false when m_pattern.m_saveInitialStartValue is true.
+
+* yarr/YarrJIT.cpp:
+* yarr/YarrJITRegisters.h:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-08 Yusuke Suzuki
+
+[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
+https://bugs.webkit.org/show_bug.cgi?id=236332
+rdar://88483574
+
+Reviewed by Michael Saboff.
+
+YarrJITRegisters::initialStart can
[webkit-changes] [289480] trunk/Source/WebCore
Title: [289480] trunk/Source/WebCore
Revision 289480
Author commit-qu...@webkit.org
Date 2022-02-09 10:12:49 -0800 (Wed, 09 Feb 2022)
Log Message
[GStreamer] MediaPlayerPrivateGStreamer mishandles failure to create WebKitTextCombiner
https://bugs.webkit.org/show_bug.cgi?id=233230
Patch by Philippe Normand on 2022-02-09
Reviewed by Xabier Rodriguez-Calvar.
Fallback to fakesink in case fakevideosink is not available. Also no longer RELEASE_ASSERT
in makeGStreamerElement and makeGStreamerBin. We should gracefully handle call sites when
these functions return nullptr.
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::makeGStreamerElement):
(WebCore::makeGStreamerBin):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::createVideoSink):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (289479 => 289480)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 18:05:48 UTC (rev 289479)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 18:12:49 UTC (rev 289480)
@@ -1,3 +1,21 @@
+2022-02-09 Philippe Normand
+
+[GStreamer] MediaPlayerPrivateGStreamer mishandles failure to create WebKitTextCombiner
+https://bugs.webkit.org/show_bug.cgi?id=233230
+
+
+Reviewed by Xabier Rodriguez-Calvar.
+
+Fallback to fakesink in case fakevideosink is not available. Also no longer RELEASE_ASSERT
+in makeGStreamerElement and makeGStreamerBin. We should gracefully handle call sites when
+these functions return nullptr.
+
+* platform/graphics/gstreamer/GStreamerCommon.cpp:
+(WebCore::makeGStreamerElement):
+(WebCore::makeGStreamerBin):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+(WebCore::MediaPlayerPrivateGStreamer::createVideoSink):
+
2022-02-09 Chris Dumez
Exceptions are not properly reported when initializing a worker as a module
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp (289479 => 289480)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2022-02-09 18:05:48 UTC (rev 289479)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2022-02-09 18:12:49 UTC (rev 289480)
@@ -544,7 +544,8 @@
GstElement* makeGStreamerElement(const char* factoryName, const char* name)
{
auto* element = gst_element_factory_make(factoryName, name);
-RELEASE_ASSERT_WITH_MESSAGE(element, "GStreamer element %s not found. Please install it", factoryName);
+if (!element)
+WTFLogAlways("GStreamer element %s not found. Please install it", factoryName);
return element;
}
@@ -552,7 +553,8 @@
{
GUniqueOutPtr error;
auto* bin = gst_parse_bin_from_description(description, ghostUnlinkedPads, &error.outPtr());
-RELEASE_ASSERT_WITH_MESSAGE(bin, "Unable to create bin for description: \"%s\". Error: %s", description, error->message);
+if (!bin)
+WTFLogAlways("Unable to create bin for description: \"%s\". Error: %s", description, error->message);
return bin;
}
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (289479 => 289480)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2022-02-09 18:05:48 UTC (rev 289479)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2022-02-09 18:12:49 UTC (rev 289480)
@@ -3491,6 +3491,12 @@
if (!m_player->isVideoPlayer()) {
m_videoSink = makeGStreamerElement("fakevideosink", nullptr);
+if (!m_videoSink) {
+GST_DEBUG_OBJECT(m_pipeline.get(), "Falling back to fakesink for video rendering");
+m_videoSink = gst_element_factory_make("fakesink", nullptr);
+g_object_set(m_videoSink.get(), "sync", TRUE, nullptr);
+}
+
return m_videoSink.get();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289479] trunk
Title: [289479] trunk Revision 289479 Author cdu...@apple.com Date 2022-02-09 10:05:48 -0800 (Wed, 09 Feb 2022) Log Message Exceptions are not properly reported when initializing a worker as a module https://bugs.webkit.org/show_bug.cgi?id=236334 Reviewed by Geoffrey Garen. LayoutTests/imported/w3c: Rebaseline WPT tests that are now passing. * web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror-expected.txt: * web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/message-module-DOMException-expected.txt: Source/WebCore: No new tests, rebaselined existing tests. * workers/WorkerOrWorkletScriptController.cpp: (WebCore::WorkerOrWorkletScriptController::linkAndEvaluateModule): linkAndEvaluateModule() was failing to report the exception, unlike evaluate() (which is used for classic workers). Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-workerglobalscope-onerror-module-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-sharedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-2-import-sharedworker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-2-import-worker-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/message-module-DOMException-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/workers/WorkerOrWorkletScriptController.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289478 => 289479) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 17:43:54 UTC (rev 289478) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 18:05:48 UTC (rev 289479) @@ -1,5 +1,17 @@ 2022-02-09 Chris Dumez +Exceptions are not properly reported when initializing a worker as a module +https://bugs.webkit.org/show_bug.cgi?id=236334 + +Reviewed by Geoffrey Garen. + +Rebaseline WPT tests that are now passing. + +* web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/exception-in-onerror-expected.txt: +* web-platform-tests/workers/interfaces/WorkerGlobalScope/onerror/message-module-DOMException-expected.txt: + +2022-02-09 Chris Dumez + Stop obfuscating exceptions thrown by scripts in data URLs https://bugs.webkit.org/show_bug.cgi?id=236329 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-workerglobalscope-onerror-module-expected.txt (289478 => 289479) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-workerglobalscope-onerror-module-expected.txt 2022-02-09 17:43:54 UTC (rev 289478) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/microtasks/checkpoint-after-workerglobalscope-onerror-module-expected.txt 2022-02-09 18:05:48 UTC (rev 289479) @@ -1,4 +1,4 @@ -FAIL Promise resolved during #report-the-error assert_array_equals: lengths differ, expected array ["handler 1", "handler 2", "handler 1 promise", "handler 2 promise"] length 4, got [] length 0 +FAIL Promise resolved during #report-the-error assert_array_equals: expected property 1 to be "handler 2" but got "handler 1 promise" (expected array ["handler 1", "handler 2", "handler 1 promise", "handler 2 promise"] got ["handler 1", "handler 1 promise", "handler 2", "handler 2 promise"]) PASS Promise resolved during event handlers other than error Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-sharedworker-expected.txt (289478 => 289479) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-sharedworker-expected.txt 2022-02-09 17:43:54 UTC (rev 289478) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/evaluation-order-1-sharedworker-expected.txt 2022-02-09 18:05:48 UTC (rev 289479) @@ -1,3 +1,3 @@ -FAIL Test evaluation order of modules assert_array_equals: lengths differ, expected array ["step-1-1", "step-1-2", "microtask", "global-error", "error"] length 5, got ["step-1-1", "step-1-2", "microtask"] length 3 +PASS Test evaluation order of modules Modified: trunk/La
[webkit-changes] [289478] branches/safari-613.1.16.1-branch/Source
Title: [289478] branches/safari-613.1.16.1-branch/Source Revision 289478 Author repst...@apple.com Date 2022-02-09 09:43:54 -0800 (Wed, 09 Feb 2022) Log Message Versioning. WebKit-7613.1.16.1.5 Modified Paths branches/safari-613.1.16.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-613.1.16.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-613.1.16.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-613.1.16.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-613.1.16.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-613.1.16.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-613.1.16.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-613.1.16.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-613.1.16.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-613.1.16.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (289477 => 289478) --- branches/safari-613.1.16.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-09 17:14:01 UTC (rev 289477) +++ branches/safari-613.1.16.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-02-09 17:43:54 UTC (rev 289478) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (289477 => 289478) --- branches/safari-613.1.16.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-09 17:14:01 UTC (rev 289477) +++ branches/safari-613.1.16.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-02-09 17:43:54 UTC (rev 289478) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (289477 => 289478) --- branches/safari-613.1.16.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-09 17:14:01 UTC (rev 289477) +++ branches/safari-613.1.16.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-02-09 17:43:54 UTC (rev 289478) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.1-branch/Source/WebCore/Configurations/Version.xcconfig (289477 => 289478) --- branches/safari-613.1.16.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-09 17:14:01 UTC (rev 289477) +++ branches/safari-613.1.16.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-02-09 17:43:54 UTC (rev 289478) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (289477 => 289478) --- branches/safari-613.1.16.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-09 17:14:01 UTC (rev 289477) +++ branches/safari-613.1.16.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-02-09 17:43:54 UTC (rev 289478) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-613.1.16.1-branch/Source/WebGPU/Configurations/Version.xcconfig (289477 => 289478) --- branches/safari-613.1.16.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-09 17:14:01 UTC (rev 289477) +++ branches/safari-613.1.16.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-02-09 17:43:54 UTC (rev 289478) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 16; MICRO_VERSION = 1; -NANO_VERSION = 4; +NANO_VERSION =
[webkit-changes] [289477] trunk
Title: [289477] trunk Revision 289477 Author cdu...@apple.com Date 2022-02-09 09:14:01 -0800 (Wed, 09 Feb 2022) Log Message Stop obfuscating exceptions thrown by scripts in data URLs https://bugs.webkit.org/show_bug.cgi?id=236329 Reviewed by Brent Fulgham. LayoutTests/imported/w3c: Rebaseline WPT tests that are now passing or whose output looks different. * web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt: * web-platform-tests/workers/interfaces/WorkerUtils/importScripts/004-expected.txt: * web-platform-tests/workers/interfaces/WorkerUtils/importScripts/006-expected.txt: Source/WebCore: Stop obfuscating exceptions thrown by scripts in data URLs. This is causing some WPT tests to fail. No new tests, rebaselined existing tests. * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::canIncludeErrorDetails): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/local-url-inherit-controller.https-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/004-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/006-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/ScriptExecutionContext.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289476 => 289477) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 17:06:14 UTC (rev 289476) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 17:14:01 UTC (rev 289477) @@ -1,5 +1,18 @@ 2022-02-09 Chris Dumez +Stop obfuscating exceptions thrown by scripts in data URLs +https://bugs.webkit.org/show_bug.cgi?id=236329 + +Reviewed by Brent Fulgham. + +Rebaseline WPT tests that are now passing or whose output looks different. + +* web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt: +* web-platform-tests/workers/interfaces/WorkerUtils/importScripts/004-expected.txt: +* web-platform-tests/workers/interfaces/WorkerUtils/importScripts/006-expected.txt: + +2022-02-09 Chris Dumez + Resync web-platform-tests/html/dom from upstream https://bugs.webkit.org/show_bug.cgi?id=236252 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/local-url-inherit-controller.https-expected.txt (289476 => 289477) --- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/local-url-inherit-controller.https-expected.txt 2022-02-09 17:06:14 UTC (rev 289476) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/local-url-inherit-controller.https-expected.txt 2022-02-09 17:14:01 UTC (rev 289477) @@ -4,6 +4,6 @@ FAIL Same-origin blob URL worker should inherit service worker controller. assert_equals: blob URL worker should inherit controller expected (string) "https://localhost:9443/service-workers/service-worker/resources/local-url-inherit-controller-worker.js" but got (object) null PASS Same-origin blob URL worker should intercept fetch(). PASS Data URL iframe should not intercept fetch(). -FAIL Data URL worker should not inherit service worker controller. promise_test: Unhandled rejection with value: "Error: Script error." +FAIL Data URL worker should not inherit service worker controller. promise_test: Unhandled rejection with value: "TypeError: undefined is not an object (evaluating 'navigator.serviceWorker.controller')" FAIL Data URL worker should not intercept fetch(). assert_equals: data URL worker should not intercept fetch expected "" but got "intercepted" Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt (289476 => 289477) --- trunk/LayoutTests/imported/w3c/web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt 2022-02-09 17:06:14 UTC (rev 289476) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/workers/dedicated-worker-in-data-url-context.window-expected.txt 2022-02-09 17:14:01 UTC (rev 289477) @@ -1,7 +1,7 @@ -CONSOLE MESSAGE: Error: Script error. +CONSOLE MESSAGE: ReferenceError: Can't find variable: Worker FAIL Create a dedicated worker in a data url frame assert_equals: expected "PASS" but got "Worker construction unexpectedly synchronously failed" FAIL Create a dedicated worker in a data url dedicated worker assert_equals: expected "PASS" but got "Worker construction unexpectedly synchronously failed" PASS Create a data url dedicated worker in a data url frame -FAIL Create a data url dedicated worker in a data url dedicated worker promise_test: Unhandled rejection with value: "Error: Script error." +FAIL Create a data url dedicated worker in a data url dedi
[webkit-changes] [289476] trunk/Source/WebCore
Title: [289476] trunk/Source/WebCore Revision 289476 Author ysuz...@apple.com Date 2022-02-09 09:06:14 -0800 (Wed, 09 Feb 2022) Log Message AudioBuffer should take a lock while visiting m_channelWrappers https://bugs.webkit.org/show_bug.cgi?id=236279 Reviewed by Keith Miller. This patch fixes AudioBuffer's m_channelWrappers concurrency bug and related issues. 1. This patch removes problematic (and almost always wrong) move operator of JSValueInWrappedObject. To do that, we fixed AudioBuffer's concurrency issue where we access m_channelWrappers while it can be cleared concurrently in AudioBuffer::releaseMemory. 2. MessageEvent's m_data access is broken with concurrent GC thread. We must take a lock. And we must not use JSValueInWrappedObject in std::variant if it can be changed after constructor invocation. 3. Use JSValueInWrappedObject::clear instead of move with empty value. 4. File https://bugs.webkit.org/show_bug.cgi?id=236353. AbortSignal, MessageEvent, and CustomEvent miss write-barrier, which is semantically wrong. * Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::AudioBuffer): (WebCore::AudioBuffer::releaseMemory): (WebCore::AudioBuffer::visitChannelWrappers): * Modules/webaudio/AudioBuffer.h: * Modules/webaudio/AudioWorkletProcessor.cpp: (WebCore::AudioWorkletProcessor::buildJSArguments): * bindings/js/JSMessageEventCustom.cpp: (WebCore::JSMessageEvent::data const): (WebCore::JSMessageEvent::visitAdditionalChildren): * bindings/js/JSValueInWrappedObject.h: * dom/AbortSignal.cpp: (WebCore::AbortSignal::signalAbort): * dom/CustomEvent.cpp: (WebCore::CustomEvent::initCustomEvent): * dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent): (WebCore::m_jsData): (WebCore::MessageEvent::initMessageEvent): (WebCore::MessageEvent::memoryCost const): (WebCore::m_ports): Deleted. * dom/MessageEvent.h: * page/History.cpp: (WebCore::History::stateObjectAdded): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp trunk/Source/WebCore/Modules/webaudio/AudioBuffer.h trunk/Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp trunk/Source/WebCore/bindings/js/JSValueInWrappedObject.h trunk/Source/WebCore/dom/AbortSignal.cpp trunk/Source/WebCore/dom/CustomEvent.cpp trunk/Source/WebCore/dom/MessageEvent.cpp trunk/Source/WebCore/dom/MessageEvent.h trunk/Source/WebCore/page/History.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (289475 => 289476) --- trunk/Source/WebCore/ChangeLog 2022-02-09 16:56:45 UTC (rev 289475) +++ trunk/Source/WebCore/ChangeLog 2022-02-09 17:06:14 UTC (rev 289476) @@ -1,3 +1,46 @@ +2022-02-09 Yusuke Suzuki + +AudioBuffer should take a lock while visiting m_channelWrappers +https://bugs.webkit.org/show_bug.cgi?id=236279 + +Reviewed by Keith Miller. + +This patch fixes AudioBuffer's m_channelWrappers concurrency bug and related issues. + +1. This patch removes problematic (and almost always wrong) move operator of JSValueInWrappedObject. + To do that, we fixed AudioBuffer's concurrency issue where we access m_channelWrappers while it + can be cleared concurrently in AudioBuffer::releaseMemory. +2. MessageEvent's m_data access is broken with concurrent GC thread. We must take a lock. And we must + not use JSValueInWrappedObject in std::variant if it can be changed after constructor invocation. +3. Use JSValueInWrappedObject::clear instead of move with empty value. +4. File https://bugs.webkit.org/show_bug.cgi?id=236353. AbortSignal, MessageEvent, and CustomEvent miss + write-barrier, which is semantically wrong. + +* Modules/webaudio/AudioBuffer.cpp: +(WebCore::AudioBuffer::AudioBuffer): +(WebCore::AudioBuffer::releaseMemory): +(WebCore::AudioBuffer::visitChannelWrappers): +* Modules/webaudio/AudioBuffer.h: +* Modules/webaudio/AudioWorkletProcessor.cpp: +(WebCore::AudioWorkletProcessor::buildJSArguments): +* bindings/js/JSMessageEventCustom.cpp: +(WebCore::JSMessageEvent::data const): +(WebCore::JSMessageEvent::visitAdditionalChildren): +* bindings/js/JSValueInWrappedObject.h: +* dom/AbortSignal.cpp: +(WebCore::AbortSignal::signalAbort): +* dom/CustomEvent.cpp: +(WebCore::CustomEvent::initCustomEvent): +* dom/MessageEvent.cpp: +(WebCore::MessageEvent::MessageEvent): +(WebCore::m_jsData): +(WebCore::MessageEvent::initMessageEvent): +(WebCore::MessageEvent::memoryCost const): +(WebCore::m_ports): Deleted. +* dom/MessageEvent.h: +* page/History.cpp: +(WebCore::History::stateObjectAdded): + 2022-02-09 Sihui Liu Manage IndexedDB storage by origin Modified: trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp (289475 => 289476) --- trunk
[webkit-changes] [289475] trunk/JSTests
Title: [289475] trunk/JSTests
Revision 289475
Author ange...@igalia.com
Date 2022-02-09 08:56:45 -0800 (Wed, 09 Feb 2022)
Log Message
Skip failing shadow realms tests on MIPS
https://bugs.webkit.org/show_bug.cgi?id=236361
Unreviewed gardening.
* stress/shadow-realm-evaluate.js:
* stress/shadow-realm-import-value.js:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/shadow-realm-evaluate.js
trunk/JSTests/stress/shadow-realm-import-value.js
Diff
Modified: trunk/JSTests/ChangeLog (289474 => 289475)
--- trunk/JSTests/ChangeLog 2022-02-09 16:55:15 UTC (rev 289474)
+++ trunk/JSTests/ChangeLog 2022-02-09 16:56:45 UTC (rev 289475)
@@ -1,3 +1,13 @@
+2022-02-09 Angelos Oikonomopoulos
+
+Skip failing shadow realms tests on MIPS
+https://bugs.webkit.org/show_bug.cgi?id=236361
+
+Unreviewed gardening.
+
+* stress/shadow-realm-evaluate.js:
+* stress/shadow-realm-import-value.js:
+
2022-02-08 Yusuke Suzuki
[JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure
Modified: trunk/JSTests/stress/shadow-realm-evaluate.js (289474 => 289475)
--- trunk/JSTests/stress/shadow-realm-evaluate.js 2022-02-09 16:55:15 UTC (rev 289474)
+++ trunk/JSTests/stress/shadow-realm-evaluate.js 2022-02-09 16:56:45 UTC (rev 289475)
@@ -1,3 +1,4 @@
+//@ skip if "mips" == $architecture
//@ requireOptions("--useShadowRealm=1")
function shouldBe(actual, expected) {
Modified: trunk/JSTests/stress/shadow-realm-import-value.js (289474 => 289475)
--- trunk/JSTests/stress/shadow-realm-import-value.js 2022-02-09 16:55:15 UTC (rev 289474)
+++ trunk/JSTests/stress/shadow-realm-import-value.js 2022-02-09 16:56:45 UTC (rev 289475)
@@ -1,3 +1,4 @@
+//@ skip if "mips" == $architecture
//@ requireOptions("--useShadowRealm=1")
var abort = $vm.abort;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289473] trunk
Title: [289473] trunk
Revision 289473
Author ape...@igalia.com
Date 2022-02-09 08:34:31 -0800 (Wed, 09 Feb 2022)
Log Message
[CMake] REGRESSION(r288994): Setting multiple values in LDFLAGS causes incorrect linker detection
https://bugs.webkit.org/show_bug.cgi?id=236365
Reviewed by Martin Robinson.
* Source/cmake/OptionsCommon.cmake: Use separate_arguments() to turn plain command strings
into lists of strings, which can then be passed down to execute_process() as it knows how
to handle lists properly.
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsCommon.cmake
Diff
Modified: trunk/ChangeLog (289472 => 289473)
--- trunk/ChangeLog 2022-02-09 16:15:59 UTC (rev 289472)
+++ trunk/ChangeLog 2022-02-09 16:34:31 UTC (rev 289473)
@@ -1,3 +1,14 @@
+2022-02-09 Adrian Perez de Castro
+
+[CMake] REGRESSION(r288994): Setting multiple values in LDFLAGS causes incorrect linker detection
+https://bugs.webkit.org/show_bug.cgi?id=236365
+
+Reviewed by Martin Robinson.
+
+* Source/cmake/OptionsCommon.cmake: Use separate_arguments() to turn plain command strings
+into lists of strings, which can then be passed down to execute_process() as it knows how
+to handle lists properly.
+
2022-02-09 Carlos Garcia Campos
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release
Modified: trunk/Source/cmake/OptionsCommon.cmake (289472 => 289473)
--- trunk/Source/cmake/OptionsCommon.cmake 2022-02-09 16:15:59 UTC (rev 289472)
+++ trunk/Source/cmake/OptionsCommon.cmake 2022-02-09 16:34:31 UTC (rev 289473)
@@ -36,11 +36,16 @@
endif ()
# Determine which linker is being used with the chosen linker flags.
+separate_arguments(LD_VERSION_COMMAND UNIX_COMMAND
+"${CMAKE_C_COMPILER} ${CMAKE_EXE_LINKER_FLAGS} -Wl,--version"
+)
execute_process(
-COMMAND ${CMAKE_C_COMPILER} ${CMAKE_EXE_LINKER_FLAGS} -Wl,--version
+COMMAND ${LD_VERSION_COMMAND}
OUTPUT_VARIABLE LD_VERSION
ERROR_QUIET
)
+unset(LD_VERSION_COMMAND)
+
set(LD_SUPPORTS_GDB_INDEX TRUE)
set(LD_SUPPORTS_SPLIT_DEBUG TRUE)
set(LD_SUPPORTS_THIN_ARCHIVES TRUE)
@@ -69,12 +74,15 @@
message(STATUS " Linker supports --disable-new-dtags - ${LD_SUPPORTS_DISABLE_NEW_DTAGS}")
# Determine whether the archiver in use supports thin archives.
+separate_arguments(AR_VERSION_COMMAND UNIX_COMMAND "${CMAKE_AR} -V")
execute_process(
-COMMAND ${CMAKE_AR} -V
+COMMAND ${AR_VERSION_COMMAND}
OUTPUT_VARIABLE AR_VERSION
RESULT_VARIABLE AR_STATUS
ERROR_QUIET
)
+unset(AR_VERSION_COMMAND)
+
set(AR_SUPPORTS_THIN_ARCHIVES FALSE)
if (AR_STATUS EQUAL 0)
if (AR_VERSION MATCHES "^GNU ar ")
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289471] trunk/Source/WebCore
Title: [289471] trunk/Source/WebCore Revision 289471 Author za...@apple.com Date 2022-02-09 08:13:55 -0800 (Wed, 09 Feb 2022) Log Message [LFC][IFC] Transform root inline box's logical rect based on the writing mode https://bugs.webkit.org/show_bug.cgi?id=236341 Reviewed by Antti Koivisto. Make sure root inline box has the correct _visual_ coordinates in vertical mode. (also let's rename DisplayLine::contentLeft to contentLogicalOffset. The emphasis is on _logical_. It helps to catch incorrect use (even this diff has a couple)). * layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::build): (WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): (WebCore::Layout::InlineDisplayContentBuilder::flipRootInlineBoxRectToVisualForWritingMode const): * layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h: * layout/formattingContexts/inline/display/InlineDisplayLine.h: (WebCore::InlineDisplay::Line::contentLogicalOffset const): (WebCore::InlineDisplay::Line::Line): (WebCore::InlineDisplay::Line::contentLeft const): Deleted. * layout/integration/InlineIteratorBoxModernPath.h: (WebCore::InlineIterator::BoxModernPath::createTextRun const): * layout/integration/InlineIteratorLineModernPath.h: (WebCore::InlineIterator::LineIteratorModernPath::contentLogicalLeft const): * layout/integration/LayoutIntegrationInlineContentBuilder.cpp: (WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const): * layout/integration/LayoutIntegrationLine.h: (WebCore::LayoutIntegration::Line::Line): (WebCore::LayoutIntegration::Line::contentLogicalOffset const): (WebCore::LayoutIntegration::Line::contentLeft const): Deleted. * layout/integration/LayoutIntegrationPagination.cpp: (WebCore::LayoutIntegration::makeAdjustedContent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h trunk/Source/WebCore/layout/integration/InlineIteratorBoxModernPath.h trunk/Source/WebCore/layout/integration/InlineIteratorLineModernPath.h trunk/Source/WebCore/layout/integration/LayoutIntegrationInlineContentBuilder.cpp trunk/Source/WebCore/layout/integration/LayoutIntegrationLine.h trunk/Source/WebCore/layout/integration/LayoutIntegrationPagination.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (289470 => 289471) --- trunk/Source/WebCore/ChangeLog 2022-02-09 15:58:58 UTC (rev 289470) +++ trunk/Source/WebCore/ChangeLog 2022-02-09 16:13:55 UTC (rev 289471) @@ -1,3 +1,36 @@ +2022-02-09 Alan Bujtas + +[LFC][IFC] Transform root inline box's logical rect based on the writing mode +https://bugs.webkit.org/show_bug.cgi?id=236341 + +Reviewed by Antti Koivisto. + +Make sure root inline box has the correct _visual_ coordinates in vertical mode. +(also let's rename DisplayLine::contentLeft to contentLogicalOffset. The emphasis is on _logical_. It helps to catch incorrect use (even this diff has a couple)). + +* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: +(WebCore::Layout::InlineDisplayContentBuilder::build): +(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent): +(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): +(WebCore::Layout::InlineDisplayContentBuilder::flipRootInlineBoxRectToVisualForWritingMode const): +* layout/formattingContexts/inline/display/InlineDisplayContentBuilder.h: +* layout/formattingContexts/inline/display/InlineDisplayLine.h: +(WebCore::InlineDisplay::Line::contentLogicalOffset const): +(WebCore::InlineDisplay::Line::Line): +(WebCore::InlineDisplay::Line::contentLeft const): Deleted. +* layout/integration/InlineIteratorBoxModernPath.h: +(WebCore::InlineIterator::BoxModernPath::createTextRun const): +* layout/integration/InlineIteratorLineModernPath.h: +(WebCore::InlineIterator::LineIteratorModernPath::contentLogicalLeft const): +* layout/integration/LayoutIntegrationInlineContentBuilder.cpp: +(WebCore::LayoutIntegration::InlineContentBuilder::createDisplayLines const): +* layout/integration/LayoutIntegrationLine.h: +(WebCore::LayoutIntegration::Line::Line): +(WebCore::LayoutIntegration::Line::contentLogicalOffset const): +(WebCore::LayoutIntegration::Line::contentLeft const): Deleted. +* layout/integration/LayoutIntegrationPagination.cpp: +(WebCore::LayoutIntegration::makeAdjustedContent): + 2022-02-09 Lauro Moura Non-unified build fixes after r289247 Modified: trunk/Source/WebCore/layout/forma
[webkit-changes] [289470] trunk/Tools
Title: [289470] trunk/Tools
Revision 289470
Author mrobin...@webkit.org
Date 2022-02-09 07:58:58 -0800 (Wed, 09 Feb 2022)
Log Message
[Flatpak SDK] Add a wrapper for clangd
https://bugs.webkit.org/show_bug.cgi?id=236240
Reviewed by Philippe Normand.
* flatpak/flatpakutils.py: Refactor this file so that the build constants can be
reused in the new script.
(convert_webkit_source_path_to_sandbox_path):
(convert_sandbox_path_to_webkit_source_path):
(get_build_dir):
(WebkitFlatpak.__init__):
(WebkitFlatpak.clean_args):
(WebkitFlatpak.setup_gstbuild):
(WebkitFlatpak.is_build_jsc):
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak.main):
(WebkitFlatpak.check_toolchains_generated):
(WebkitFlatpak.pack_toolchain):
(WebkitFlatpak.host_path_to_sandbox_path): Deleted.
(WebkitFlatpak.sandbox_path_to_host_path): Deleted.
* flatpak/webkit-clangd: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py
Added Paths
trunk/Tools/flatpak/webkit-clangd
Diff
Modified: trunk/Tools/ChangeLog (289469 => 289470)
--- trunk/Tools/ChangeLog 2022-02-09 15:13:24 UTC (rev 289469)
+++ trunk/Tools/ChangeLog 2022-02-09 15:58:58 UTC (rev 289470)
@@ -1,3 +1,27 @@
+2022-02-09 Martin Robinson
+
+[Flatpak SDK] Add a wrapper for clangd
+https://bugs.webkit.org/show_bug.cgi?id=236240
+
+Reviewed by Philippe Normand.
+
+* flatpak/flatpakutils.py: Refactor this file so that the build constants can be
+reused in the new script.
+(convert_webkit_source_path_to_sandbox_path):
+(convert_sandbox_path_to_webkit_source_path):
+(get_build_dir):
+(WebkitFlatpak.__init__):
+(WebkitFlatpak.clean_args):
+(WebkitFlatpak.setup_gstbuild):
+(WebkitFlatpak.is_build_jsc):
+(WebkitFlatpak.run_in_sandbox):
+(WebkitFlatpak.main):
+(WebkitFlatpak.check_toolchains_generated):
+(WebkitFlatpak.pack_toolchain):
+(WebkitFlatpak.host_path_to_sandbox_path): Deleted.
+(WebkitFlatpak.sandbox_path_to_host_path): Deleted.
+* flatpak/webkit-clangd: Added.
+
2022-02-09 Angelos Oikonomopoulos
Allow hanging run-_javascript_core-tests to print backtrace
Modified: trunk/Tools/flatpak/flatpakutils.py (289469 => 289470)
--- trunk/Tools/flatpak/flatpakutils.py 2022-02-09 15:13:24 UTC (rev 289469)
+++ trunk/Tools/flatpak/flatpakutils.py 2022-02-09 15:58:58 UTC (rev 289470)
@@ -35,6 +35,9 @@
import re
import platform
+SCRIPT_DIR = os.path.abspath(os.path.dirname(__file__))
+WEBKIT_SOURCE_DIR = os.path.normpath(os.path.abspath(os.path.join(SCRIPT_DIR, "..", "..")))
+sys.path.insert(0, os.path.join(WEBKIT_SOURCE_DIR, "Tools", "Scripts"))
from webkitpy.common.system.logutils import configure_logging
from webkitcorepy import string_utils
import toml
@@ -59,12 +62,21 @@
FLATPAK_REQUIRED_VERSION = "1.4.4"
-scriptdir = os.path.abspath(os.path.dirname(__file__))
_log = logging.getLogger(__name__)
-FLATPAK_USER_DIR_PATH = os.path.realpath(os.path.join(scriptdir, "../../WebKitBuild", "UserFlatpak"))
+BUILD_ROOT_DIR_NAME = 'WebKitBuild'
+
+# This path doesn't take $WEBKIT_OUTPUTDIR in account because the standalone toolchains
+# paths depend on it and those are also hard-coded in the generated sccache config.
+DEFAULT_BUILD_ROOT = os.path.join(WEBKIT_SOURCE_DIR, BUILD_ROOT_DIR_NAME)
+BUILD_ROOT = os.path.join(os.environ.get("WEBKIT_OUTPUTDIR", WEBKIT_SOURCE_DIR), BUILD_ROOT_DIR_NAME)
+FLATPAK_USER_DIR_PATH = os.path.realpath(os.path.join(DEFAULT_BUILD_ROOT, "UserFlatpak"))
+
DEFAULT_SCCACHE_SCHEDULER='https://sccache.igalia.com'
+# Where the source folder is mounted inside the sandbox.
+SANDBOX_SOURCE_ROOT = "/app/webkit"
+
# Our SDK branch matches with the FDO SDK branch. When updating the FDO SDK release branch
# in our SDK build definitions please don't forget to update the version here as well.
SDK_BRANCH = "21.08"
@@ -198,6 +210,20 @@
return current_version
+def convert_webkit_source_path_to_sandbox_path(source_path):
+'''Convert a path in the WebKit source directory to the same path in the
+ sandboxed source diretory. '''
+return source_path.replace(WEBKIT_SOURCE_DIR, SANDBOX_SOURCE_ROOT)
+
+
+def convert_sandbox_path_to_webkit_source_path(sandbox_path):
+# For now this supports only files in the /app/webkit path
+return sandbox_path.replace(SANDBOX_SOURCE_ROOT, WEBKIT_SOURCE_DIR)
+
+
+def get_build_dir(platform, build_type):
+return os.path.join(BUILD_ROOT, platform, build_type)
+
class FlatpakObject:
def __init__(self, user):
@@ -523,12 +549,7 @@
self.release = False
self.debug = False
-self.source_root = os.path.normpath(os.path.abspath(os.path.join(scriptdir, '../../')))
-# Where the source folder is mounted inside the sandbox.
-self.sandbox_source_root = "/app/webkit"
-self.base_build_dir = 'WebKitBuild'
-
self.build_gst = False
self.platform =
[webkit-changes] [289469] trunk/Source
Title: [289469] trunk/Source Revision 289469 Author lmo...@igalia.com Date 2022-02-09 07:13:24 -0800 (Wed, 09 Feb 2022) Log Message Non-unified build fixes after r289247 https://bugs.webkit.org/show_bug.cgi?id=236343 Reviewed by Fujii Hironori. Source/_javascript_Core: * runtime/JSRemoteFunction.h: Drive-by fix, add missing include. Source/WebCore: * accessibility/AccessibilityNodeObject.cpp: Drive-by fix. Missing include. * layout/formattingContexts/inline/display/InlineDisplayLine.h: Drive-by fix. Missing include. * workers/shared/SharedWorkerObjectConnection.cpp: SharedWorkerScriptLoader only forward-declares WorkerScriptLoader. * workers/shared/SharedWorkerScriptLoader.h: Missing CompletionHandler include. * workers/shared/context/SharedWorkerContextManager.cpp: SharedWorkerThreadProxy only forward-declares SharedWorkerThread Source/WebKit: * NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp: Moved SharedWorkerKey include to .h file, as it declares a HashMap of it and it has custom HashTraits that must be visible. * NetworkProcess/SharedWorker/WebSharedWorkerServer.h: Ditto. * NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp: Add missing includes. * NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h: Add missing includes and forward declarations. * NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp: Add missing include with proper coder/decoder support. Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSRemoteFunction.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp trunk/Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLine.h trunk/Source/WebCore/workers/shared/SharedWorkerObjectConnection.cpp trunk/Source/WebCore/workers/shared/SharedWorkerScriptLoader.h trunk/Source/WebCore/workers/shared/context/SharedWorkerContextManager.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.h trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.cpp trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h trunk/Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerToContextConnection.cpp Diff Modified: trunk/Source/_javascript_Core/ChangeLog (289468 => 289469) --- trunk/Source/_javascript_Core/ChangeLog 2022-02-09 14:56:58 UTC (rev 289468) +++ trunk/Source/_javascript_Core/ChangeLog 2022-02-09 15:13:24 UTC (rev 289469) @@ -1,3 +1,12 @@ +2022-02-09 Lauro Moura + +Non-unified build fixes after r289247 +https://bugs.webkit.org/show_bug.cgi?id=236343 + +Reviewed by Fujii Hironori. + +* runtime/JSRemoteFunction.h: Drive-by fix, add missing include. + 2022-02-08 Yusuke Suzuki [JSC] YarrJIT inlining should be disabled when we have DotStarEnclosure Modified: trunk/Source/_javascript_Core/runtime/JSRemoteFunction.h (289468 => 289469) --- trunk/Source/_javascript_Core/runtime/JSRemoteFunction.h 2022-02-09 14:56:58 UTC (rev 289468) +++ trunk/Source/_javascript_Core/runtime/JSRemoteFunction.h 2022-02-09 15:13:24 UTC (rev 289469) @@ -27,6 +27,7 @@ #pragma once #include "AuxiliaryBarrier.h" +#include "JSFunction.h" #include "JSObject.h" #include Modified: trunk/Source/WebCore/ChangeLog (289468 => 289469) --- trunk/Source/WebCore/ChangeLog 2022-02-09 14:56:58 UTC (rev 289468) +++ trunk/Source/WebCore/ChangeLog 2022-02-09 15:13:24 UTC (rev 289469) @@ -1,3 +1,21 @@ +2022-02-09 Lauro Moura + +Non-unified build fixes after r289247 +https://bugs.webkit.org/show_bug.cgi?id=236343 + +Reviewed by Fujii Hironori. + +* accessibility/AccessibilityNodeObject.cpp: Drive-by fix. Missing +include. +* layout/formattingContexts/inline/display/InlineDisplayLine.h: +Drive-by fix. Missing include. +* workers/shared/SharedWorkerObjectConnection.cpp: +SharedWorkerScriptLoader only forward-declares WorkerScriptLoader. +* workers/shared/SharedWorkerScriptLoader.h: Missing CompletionHandler +include. +* workers/shared/context/SharedWorkerContextManager.cpp: +SharedWorkerThreadProxy only forward-declares SharedWorkerThread + 2022-02-09 Antti Koivisto [CSS Container Queries] Implement inline-size containment Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (289468 => 289469) --- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2022-02-09 14:56:58 UTC (rev 289468) +++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2022-02-09 15:13:24 UTC (rev 289469) @@ -59,6 +59,7 @@ #include "HTMLOptionElement.h" #include "HTMLParserIdioms.h" #include "HTMLSelectElement.h" +#include "HTMLSummaryElement.h" #include "HTMLTextAreaElement.h" #include "HTMLTextFormCo
[webkit-changes] [289468] trunk/Tools
Title: [289468] trunk/Tools Revision 289468 Author ange...@igalia.com Date 2022-02-09 06:56:58 -0800 (Wed, 09 Feb 2022) Log Message Allow hanging run-_javascript_core-tests to print backtrace https://bugs.webkit.org/show_bug.cgi?id=236355 Reviewed by Aakash Jain. This is to debug 'command timed out: 3600 seconds without output' issues on build.webkit.org, same as we do for EWS. * CISupport/build-webkit-org/steps.py: (RunJavaScriptCoreTests.__init__): Modified Paths trunk/Tools/CISupport/build-webkit-org/steps.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (289467 => 289468) --- trunk/Tools/CISupport/build-webkit-org/steps.py 2022-02-09 13:49:12 UTC (rev 289467) +++ trunk/Tools/CISupport/build-webkit-org/steps.py 2022-02-09 14:56:58 UTC (rev 289468) @@ -464,6 +464,8 @@ def __init__(self, *args, **kwargs): kwargs['logEnviron'] = False +if 'sigtermTime' not in kwargs: +kwargs['sigtermTime'] = 10 TestWithFailureCount.__init__(self, *args, **kwargs) def start(self): Modified: trunk/Tools/ChangeLog (289467 => 289468) --- trunk/Tools/ChangeLog 2022-02-09 13:49:12 UTC (rev 289467) +++ trunk/Tools/ChangeLog 2022-02-09 14:56:58 UTC (rev 289468) @@ -1,3 +1,16 @@ +2022-02-09 Angelos Oikonomopoulos + +Allow hanging run-_javascript_core-tests to print backtrace +https://bugs.webkit.org/show_bug.cgi?id=236355 + +Reviewed by Aakash Jain. + +This is to debug 'command timed out: 3600 seconds without output' +issues on build.webkit.org, same as we do for EWS. + +* CISupport/build-webkit-org/steps.py: +(RunJavaScriptCoreTests.__init__): + 2022-02-02 Jonathan Bedard [EWS] Embed added/modified/deleted status into changed files ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289467] trunk
Title: [289467] trunk
Revision 289467
Author carlo...@webkit.org
Date 2022-02-09 05:49:12 -0800 (Wed, 09 Feb 2022)
Log Message
WebDriver: add a _javascript_ atom to get the visible text
https://bugs.webkit.org/show_bug.cgi?id=174617
Reviewed by Adrian Perez de Castro.
Source/WebDriver:
Generate the _javascript_ atoms using the new command and use the new atom to get element text.
* CMakeLists.txt:
* Session.cpp:
(WebDriver::Session::getElementText):
Source/WebKit:
Add a new _javascript_ atom to get the visible text according to the spec. The new atom uses code from other atoms
like ElementDisplayed and it's also used now by FindNodes one. The atoms are now autogenerated using a script to
include the duplicated code from a common source utils.js.
* Scripts/generate-automation-atom.py: Added.
(collect_utils):
(parse_utils):
(append_functions):
(main):
* UIProcess/Automation/atoms/ElementDisplayed.js:
(isShown.nodeIsElement): Deleted.
(isShown.parentElementForElement): Deleted.
(isShown.enclosingNodeOrSelfMatchingPredicate): Deleted.
(isShown.enclosingElementOrSelfMatchingPredicate): Deleted.
(isShown.cascadedStylePropertyForElement): Deleted.
(isShown.elementSubtreeHasNonZeroDimensions): Deleted.
(isShown): Deleted.
(isShown.isElementSubtreeHiddenByOverflow): Deleted.
* UIProcess/Automation/atoms/ElementText.js: Added.
* UIProcess/Automation/atoms/FindNodes.js:
(tryToFindNode):
* UIProcess/Automation/atoms/utils.js: Added.
(utils.nodeIsElement):
(utils.enclosingNodeOrSelfMatchingPredicate):
(utils.parentElementForElement):
(utils.cascadedStylePropertyForElement):
(elementSubtreeHasNonZeroDimensions):
(isElementSubtreeHiddenByOverflow):
(utils.isShown):
(appendLines.currentLine):
(appendLines):
(utils.getText):
WebDriverTests:
Remove expectations of tests that are now passing.
* TestExpectations.json:
Modified Paths
trunk/Source/WebDriver/CMakeLists.txt
trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/Session.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/atoms/ElementDisplayed.js
trunk/Source/WebKit/UIProcess/Automation/atoms/FindNodes.js
trunk/WebDriverTests/ChangeLog
trunk/WebDriverTests/TestExpectations.json
Added Paths
trunk/Source/WebKit/Scripts/generate-automation-atom.py
trunk/Source/WebKit/UIProcess/Automation/atoms/ElementText.js
trunk/Source/WebKit/UIProcess/Automation/atoms/utils.js
Diff
Modified: trunk/Source/WebDriver/CMakeLists.txt (289466 => 289467)
--- trunk/Source/WebDriver/CMakeLists.txt 2022-02-09 12:42:22 UTC (rev 289466)
+++ trunk/Source/WebDriver/CMakeLists.txt 2022-02-09 13:49:12 UTC (rev 289467)
@@ -26,15 +26,33 @@
set(WebDriver_SCRIPTS
-${WEBKIT_DIR}/UIProcess/Automation/atoms/ElementAttribute.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/ElementDisplayed.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/ElementEnabled.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/EnterFullscreen.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/FindNodes.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/FormElementClear.js
-${WEBKIT_DIR}/UIProcess/Automation/atoms/FormSubmit.js
+${WebDriver_DERIVED_SOURCES_DIR}/ElementAttribute.js
+${WebDriver_DERIVED_SOURCES_DIR}/ElementDisplayed.js
+${WebDriver_DERIVED_SOURCES_DIR}/ElementEnabled.js
+${WebDriver_DERIVED_SOURCES_DIR}/ElementText.js
+${WebDriver_DERIVED_SOURCES_DIR}/EnterFullscreen.js
+${WebDriver_DERIVED_SOURCES_DIR}/FindNodes.js
+${WebDriver_DERIVED_SOURCES_DIR}/FormElementClear.js
+${WebDriver_DERIVED_SOURCES_DIR}/FormSubmit.js
)
+macro(GENERATE_ATOMS _inputs)
+foreach (_file IN ITEMS ${_inputs})
+get_filename_component(_name ${_file} NAME)
+add_custom_command(
+OUTPUT ${_file}
+MAIN_DEPENDENCY ${WEBKIT_DIR}/Scripts/generate-automation-atom.py
+DEPENDS
+${WEBKIT_DIR}/UIProcess/Automation/atoms/${_name}
+${WEBKIT_DIR}/UIProcess/Automation/atoms/utils.js
+COMMAND ${PYTHON_EXECUTABLE} ${WEBKIT_DIR}/Scripts/generate-automation-atom.py ${WEBKIT_DIR}/UIProcess/Automation/atoms/${_name} ${_file}
+VERBATIM
+)
+endforeach ()
+endmacro()
+
+GENERATE_ATOMS("${WebDriver_SCRIPTS}")
+
MAKE_JS_FILE_ARRAYS(
${WebDriver_DERIVED_SOURCES_DIR}/WebDriverAtoms.cpp
${WebDriver_DERIVED_SOURCES_DIR}/WebDriverAtoms.h
Modified: trunk/Source/WebDriver/ChangeLog (289466 => 289467)
--- trunk/Source/WebDriver/ChangeLog 2022-02-09 12:42:22 UTC (rev 289466)
+++ trunk/Source/WebDriver/ChangeLog 2022-02-09 13:49:12 UTC (rev 289467)
@@ -1,3 +1,17 @@
+2022-02-09 Carlos Garcia Campos
+
+WebDriver: add a _javascript_ atom to get the visible text
+https://bugs.webkit.org/show_bug.cgi?id=174617
+
+
+Reviewed by Adrian Perez de Castro.
+
+Generate the _javascript_ atoms using the new command and use the new atom to get element text.
+
+* CMakeLists.txt:
+* Session.cpp:
+
[webkit-changes] [289466] trunk
Title: [289466] trunk Revision 289466 Author an...@apple.com Date 2022-02-09 04:42:22 -0800 (Wed, 09 Feb 2022) Log Message [CSS Container Queries] Implement inline-size containment https://bugs.webkit.org/show_bug.cgi?id=236354 Reviewed by Antoine Quint. LayoutTests/imported/w3c: * web-platform-tests/css/css-contain/container-queries/container-type-containment-expected.txt: Source/WebCore: "Giving an element inline-size containment applies size containment to the inline-axis sizing of its principal box. This means the inline-axis intrinsic sizes of the principal box are determined as if the element had no content." https://drafts.csswg.org/css-contain-3/#containment-inline-size * rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const): Compute inline axis preferred width as if the block had no content. * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::effectiveContainment const): * rendering/style/RenderStyleConstants.h: For completeness, add an enum value for inline-size containment. It can only be set by 'container' property for now. * style/StyleScope.cpp: (WebCore::Style::Scope::updateQueryContainerState): Ignore block axis for inline-size containers. Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-containment-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlockFlow.cpp trunk/Source/WebCore/rendering/style/RenderStyle.cpp trunk/Source/WebCore/rendering/style/RenderStyleConstants.h trunk/Source/WebCore/style/StyleScope.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (289465 => 289466) --- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 10:37:47 UTC (rev 289465) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-09 12:42:22 UTC (rev 289466) @@ -1,3 +1,12 @@ +2022-02-09 Antti Koivisto + +[CSS Container Queries] Implement inline-size containment +https://bugs.webkit.org/show_bug.cgi?id=236354 + +Reviewed by Antoine Quint. + +* web-platform-tests/css/css-contain/container-queries/container-type-containment-expected.txt: + 2022-02-09 Ziran Sun [Forms] Improving applyStep() to be in line with specs Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-containment-expected.txt (289465 => 289466) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-containment-expected.txt 2022-02-09 10:37:47 UTC (rev 289465) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-containment-expected.txt 2022-02-09 12:42:22 UTC (rev 289466) @@ -2,7 +2,7 @@ A PASS container-type:inline-size turns on layout containment -FAIL container-type:inline-size turns on inline-size containment assert_equals: expected 0 but got 12 +PASS container-type:inline-size turns on inline-size containment PASS container-type:size turns on full size containment PASS container-type:inline/size turns on style containment Modified: trunk/Source/WebCore/ChangeLog (289465 => 289466) --- trunk/Source/WebCore/ChangeLog 2022-02-09 10:37:47 UTC (rev 289465) +++ trunk/Source/WebCore/ChangeLog 2022-02-09 12:42:22 UTC (rev 289466) @@ -1,3 +1,33 @@ +2022-02-09 Antti Koivisto + +[CSS Container Queries] Implement inline-size containment +https://bugs.webkit.org/show_bug.cgi?id=236354 + +Reviewed by Antoine Quint. + +"Giving an element inline-size containment applies size containment to the inline-axis sizing +of its principal box. This means the inline-axis intrinsic sizes of the principal box are +determined as if the element had no content." + +https://drafts.csswg.org/css-contain-3/#containment-inline-size + +* rendering/RenderBlockFlow.cpp: +(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const): + +Compute inline axis preferred width as if the block had no content. + +* rendering/style/RenderStyle.cpp: +(WebCore::RenderStyle::effectiveContainment const): +* rendering/style/RenderStyleConstants.h: + +For completeness, add an enum value for inline-size containment. It can only be set by 'container' +property for now. + +* style/StyleScope.cpp: +(WebCore::Style::Scope::updateQueryContainerState): + +Ignore block axis for inline-size containers. + 2022-02-09 Ziran Sun [Forms] Improving applyStep() to be in line with specs Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (289465 => 289466) --- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2022-02-09 10:37:47 UTC (rev 289465) +++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2022-02-09 12:42:22 UTC (rev 289466) @@ -4081,6 +4081,11 @@ void RenderBlockFlow::computeInl
[webkit-changes] [289465] trunk
Title: [289465] trunk Revision 289465 Author z...@igalia.com Date 2022-02-09 02:37:47 -0800 (Wed, 09 Feb 2022) Log Message [Forms] Improving applyStep() to be in line with specs https://bugs.webkit.org/show_bug.cgi?id=236134 Reviewed by Chris Dumez. LayoutTests/imported/w3c: * web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt: Source/WebCore: This is to improve applyStep() func to follow specs at https://html.spec.whatwg.org/multipage/input.html#dom-input-stepup Since Chromium implementation follows the specs steps, this patch imports the Chromium implmentation. This is a further patch after https://bugs.webkit.org/show_bug.cgi?id=235509. It has corrected some changes on test files in fast/form directory in the previous patch submitted for Bug 235509. With this CL a few more sub-tests are now passing. * html/InputType.cpp: (WebCore::InputType::applyStep): * html/StepRange.cpp: (WebCore::StepRange::stepSnappedMaximum const): * html/StepRange.h: LayoutTests: Update test expectations. * fast/forms/date/date-stepup-stepdown-expected.txt: * fast/forms/date/date-stepup-stepdown.html: * fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt: * fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html: * fast/forms/month/month-stepup-stepdown-expected.txt: * fast/forms/month/month-stepup-stepdown.html: * fast/forms/number/number-stepup-stepdown-expected.txt: * fast/forms/number/number-stepup-stepdown.html: * fast/forms/range/range-stepup-stepdown-expected.txt: * fast/forms/range/range-stepup-stepdown.html: * fast/forms/time/time-stepup-stepdown-expected.txt: * fast/forms/time/time-stepup-stepdown.html: * fast/forms/week/week-stepup-stepdown-expected.txt: * fast/forms/week/week-stepup-stepdown.html: * platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt: * platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt: * platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/date/date-stepup-stepdown-expected.txt trunk/LayoutTests/fast/forms/date/date-stepup-stepdown.html trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt trunk/LayoutTests/fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html trunk/LayoutTests/fast/forms/month/month-stepup-stepdown-expected.txt trunk/LayoutTests/fast/forms/month/month-stepup-stepdown.html trunk/LayoutTests/fast/forms/number/number-stepup-stepdown-expected.txt trunk/LayoutTests/fast/forms/number/number-stepup-stepdown.html trunk/LayoutTests/fast/forms/range/range-stepup-stepdown-expected.txt trunk/LayoutTests/fast/forms/range/range-stepup-stepdown.html trunk/LayoutTests/fast/forms/time/time-stepup-stepdown-expected.txt trunk/LayoutTests/fast/forms/time/time-stepup-stepdown.html trunk/LayoutTests/fast/forms/week/week-stepup-stepdown-expected.txt trunk/LayoutTests/fast/forms/week/week-stepup-stepdown.html trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/time-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/InputType.cpp trunk/Source/WebCore/html/StepRange.cpp trunk/Source/WebCore/html/StepRange.h Diff Modified: trunk/LayoutTests/ChangeLog (289464 => 289465) --- trunk/LayoutTests/ChangeLog 2022-02-09 09:52:42 UTC (rev 289464) +++ trunk/LayoutTests/ChangeLog 2022-02-09 10:37:47 UTC (rev 289465) @@ -1,3 +1,29 @@ +2022-02-09 Ziran Sun + +[Forms] Improving applyStep() to be in line with specs +https://bugs.webkit.org/show_bug.cgi?id=236134 + +Reviewed by Chris Dumez. + +Update test expectations. +* fast/forms/date/date-stepup-stepdown-expected.txt: +* fast/forms/date/date-stepup-stepdown.html: +* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt: +* fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html: +* fast/forms/month/month-stepup-stepdown-expected.txt: +* fast/forms/month/month-stepup-stepdown.html: +* fast/forms/number/number-stepup-stepdown-expected.txt: +* fast/forms/number/number-stepup-stepdown.html: +* fast/forms/range/range-stepup-stepdown-expected.txt: +* fast/forms/range/range-stepup-stepdown.html: +* fast/forms/time/time-stepup-stepdown-expected.txt: +* fast/forms/time/time-stepup-stepdown.html: +* fast/forms/week/week-stepup-stepd
[webkit-changes] [289464] trunk/LayoutTests
Title: [289464] trunk/LayoutTests Revision 289464 Author dp...@igalia.com Date 2022-02-09 01:52:42 -0800 (Wed, 09 Feb 2022) Log Message [GLIB] Garden several WPT tests that are now passing Unreviewed test gardening. * platform/glib/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (289463 => 289464) --- trunk/LayoutTests/ChangeLog 2022-02-09 09:30:46 UTC (rev 289463) +++ trunk/LayoutTests/ChangeLog 2022-02-09 09:52:42 UTC (rev 289464) @@ -1,3 +1,11 @@ +2022-02-09 Diego Pino Garcia + +[GLIB] Garden several WPT tests that are now passing + +Unreviewed test gardening. + +* platform/glib/TestExpectations: + 2022-02-09 Saam Barati Don't return an empty value from AbortController.signal.reason and make it harder to return empty values from JSValueInWrappedObject Modified: trunk/LayoutTests/platform/glib/TestExpectations (289463 => 289464) --- trunk/LayoutTests/platform/glib/TestExpectations 2022-02-09 09:30:46 UTC (rev 289463) +++ trunk/LayoutTests/platform/glib/TestExpectations 2022-02-09 09:52:42 UTC (rev 289464) @@ -168,15 +168,26 @@ imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-auto-min-width.html [ Pass ] imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-fixed-min-width.html [ Pass ] imported/w3c/web-platform-tests/css/css-images/multiple-position-color-stop-conic.html [ Pass ] +imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-background-image.html [ Pass ] +imported/w3c/web-platform-tests/css/css-images/image-orientation/image-orientation-list-style-image.html [ Pass ] imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-greek.html [ Pass ] imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-latin.html [ Pass ] imported/w3c/web-platform-tests/css/css-lists/counter-increment-inside-display-contents.html [ Pass ] imported/w3c/web-platform-tests/css/css-lists/counter-reset-inside-display-contents.html [ Pass ] +imported/w3c/web-platform-tests/css/css-masking/clip-path/animations/clip-path-animation-three-keyframes2.html [ Pass ] +imported/w3c/web-platform-tests/css/css-pseudo/active-selection-041.html [ Pass ] +imported/w3c/web-platform-tests/css/css-pseudo/file-selector-button-001.html [ Pass ] +imported/w3c/web-platform-tests/css/css-pseudo/file-selector-button-after-part.html [ Pass ] imported/w3c/web-platform-tests/css/css-pseudo/first-letter-002.html [ Pass ] imported/w3c/web-platform-tests/css/css-pseudo/first-letter-003.html [ Pass ] +imported/w3c/web-platform-tests/css/css-pseudo/first-line-with-inline-block.html [ Pass ] +imported/w3c/web-platform-tests/css/css-pseudo/placeholder-input-number.html [ Pass ] +imported/w3c/web-platform-tests/css/css-pseudo/selection-paint-image.html [ Pass ] imported/w3c/web-platform-tests/css/css-scoping/stylesheet-title-001.html [ Pass ] +imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html [ Pass ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/intrinsic-size-005.html [ Pass ] imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/parsing/aspect-ratio-invalid.html [ Pass ] +imported/w3c/web-platform-tests/css/css-sizing/slice-intrinsic-size.html [ Pass ] imported/w3c/web-platform-tests/css/css-ui/text-overflow-012.html [ Pass ] # Passing since r260062. @@ -195,6 +206,12 @@ imported/w3c/web-platform-tests/css/css-writing-modes/mongolian-orientation-001.html [ Pass ] imported/w3c/web-platform-tests/css/css-writing-modes/mongolian-orientation-002.html [ Pass ] +imported/w3c/web-platform-tests/css/filter-effects/effect-reference-merge-no-inputs.tentative.html [ Pass ] +imported/w3c/web-platform-tests/css/filter-effects/filters-sepia-001-test.html [ Pass ] + +imported/w3c/web-platform-tests/css/selectors/selection-image-001.html [ Pass ] +imported/w3c/web-platform-tests/css/selectors/selection-image-002.html [ Pass ] + imported/w3c/web-platform-tests/css/selectors/selector-placeholder-shown-type-change-001.html [ Pass ] imported/w3c/web-platform-tests/css/selectors/selector-placeholder-shown-type-change-002.html [ Pass ] imported/w3c/web-platform-tests/css/selectors/selector-placeholder-shown-type-change-003.html [ Pass ] @@ -201,6 +218,23 @@ imported/w3c/web-platform-tests/css/selectors/selector-read-write-type-change-002.html [ Pass ] imported/w3c/web-platform-tests/css/selectors/selector-required-type-change-002.html [ Pass ] +imported/w3c/web-platform-tests/html/canvas/element/manual/drawing-images-to-the-canvas/image-orientation/drawImage-from-bitmap-swap-width-height.tentative.html [ Pass ] +imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/imageBitmapRendering-transferFromImageBitmap-webgl.html [ Pass ] + +imported/w3c/web-platform-tests/html/dom/elements/global
[webkit-changes] [289463] trunk/Source/WebKit
Title: [289463] trunk/Source/WebKit Revision 289463 Author timothy_hor...@apple.com Date 2022-02-09 01:30:46 -0800 (Wed, 09 Feb 2022) Log Message WKHoverPlatter should scale up the platter content to make it easier to see https://bugs.webkit.org/show_bug.cgi?id=236289 Reviewed by Wenson Hsieh. * Shared/NativeWebMouseEvent.h: * Shared/ios/NativeWebMouseEventIOS.mm: (WebKit::NativeWebMouseEvent::NativeWebMouseEvent): Add a NativeWebMouseEvent constructor that takes most properties from another event, but allows overriding the positions and deltas. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::interactableRegionsInRootViewCoordinates): * UIProcess/WebPageProxy.h: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::interactableRegionsInRootViewCoordinates): * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Add a method to count the number of clickable elements in a given rectangle. This is just a first attempt at the heuristic; this will get more complex in the future. * UIProcess/ios/WKContentViewInteraction.h: Add a selection assistant suppression reason for WKHoverPlatter. * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _createAndConfigureHighlightLongPressGestureRecognizer]): Factor out highlight-long-press gesture creation like long-press. Bail if the platter is enabled. (-[WKContentView setUpInteraction]): Disable the selection assistant if WKHoverPlatter wants to use long press. (-[WKContentView cleanUpInteraction]): (-[WKContentView _locationForGesture:]): (-[WKContentView _startPointForGesture:]): Add funnels for extracting the primary location or starting location from a gesture, allowing WKHoverPlatter to mutate it if it is currently engaged. (-[WKContentView _highlightLongPressRecognized:]): (-[WKContentView _doubleTapRecognizedForDoubleClick:]): (-[WKContentView _twoFingerSingleTapGestureRecognized:]): (-[WKContentView _singleTapIdentified:]): (-[WKContentView _singleTapRecognized:]): (-[WKContentView _doubleTapRecognized:]): (-[WKContentView _nonBlockingDoubleTapRecognized:]): (-[WKContentView _twoFingerDoubleTapRecognized:]): Adopt _locationForGesture/_startPointForGesture. (-[WKContentView _longPressRecognized:]): Adopt _locationForGesture/_startPointForGesture. Redirect a recognized long press to WKHoverPlatter if it wants to use long press. (-[WKContentView _shouldUseContextMenus]): Disable context menus if WKHoverPlatter wants to use long press. (-[WKContentView setUpDragAndDropInteractions]): Disable drag and drop if WKHoverPlatter wants to use long press. (-[WKContentView mouseGestureRecognizerChanged:]): Allow WKHoverPlatter to mutate the location of mouse events if it is currently engaged. (-[WKContentView numberOfLinksForHoverPlatter:inRect:completionHandler:]): * UIProcess/ios/WKHoverPlatter.h: * UIProcess/ios/WKHoverPlatter.mm: (-[WKHoverPlatter initWithView:delegate:]): (-[WKHoverPlatter didReceiveMouseEvent:]): (-[WKHoverPlatter didLongPressAtPoint:]): (-[WKHoverPlatter platterBoundingRect]): (-[WKHoverPlatter linkSearchRect]): (-[WKHoverPlatter update]): (-[WKHoverPlatter updateDebugIndicator]): (-[WKHoverPlatter dismissPlatterWithAnimation:]): (-[WKHoverPlatter didFinishDismissalAnimation:]): (-[WKHoverPlatter clearLayers]): (-[WKHoverPlatter adjustedPointForPoint:]): (-[WKHoverPlatter adjustedEventForEvent:]): (setAdditionalPlatterLayerProperties): Deleted. (addAdditionalIncomingAnimations): Deleted. (addAdditionalDismissalAnimations): Deleted. (-[WKHoverPlatter setHoverPoint:]): Deleted. (-[WKHoverPlatter requestPositionInformationForCurrentHoverPoint]): Deleted. (-[WKHoverPlatter didReceivePositionInformation:]): Deleted. (-[WKHoverPlatter didFinishAnimationForShadow:]): Deleted. * UIProcess/ios/WKHoverPlatterParameters.h: * UIProcess/ios/WKHoverPlatterParameters.mm: (-[WKHoverPlatterParameters setDefaultValues]): (-[WKHoverPlatterParameters enabled]): (+[WKHoverPlatterParameters settingsControllerModule]): (addAdditionalPlatterLayoutParameters): Deleted. (setDefaultValuesForAdditionalPlatterLayoutParameters): Deleted. Adjust WKHoverPlatter to scale up its content, and adjust the shape and animations. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/NativeWebMouseEvent.h trunk/Source/WebKit/Shared/ios/NativeWebMouseEventIOS.mm trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm trunk/Source/WebKit/UIProcess/ios/WKHoverPlatter.h trunk/Source/WebKit/UIProcess/ios/WKHoverPlatter.mm trunk/Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.h trunk/Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.mm trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in Diff Modified: trunk/Source/WebKit/ChangeLog (289462 => 289463) --
[webkit-changes] [289462] trunk
Title: [289462] trunk
Revision 289462
Author sbar...@apple.com
Date 2022-02-09 01:15:58 -0800 (Wed, 09 Feb 2022)
Log Message
Don't return an empty value from AbortController.signal.reason and make it harder to return empty values from JSValueInWrappedObject
https://bugs.webkit.org/show_bug.cgi?id=236318
Reviewed by Mark Lam.
Source/WebCore:
This patch makes it so we might not accidentally return the empty value to
_javascript_ code from JSValueInWrappedObject. Previously, JSValueInWrappedObject
had an "operator JSValue()" method. This patch removes that, adds a new
conversion method for converting between JSValueInWrappedObject and JSValue,
and makes JSValueInWrappedObject return undefined inside this method
when it used to return the empty value. This fixes a crash where we'd return
the empty value to JS JIT code, and crash dereferencing a nullptr. It's never
valid for a JS function call (or getter, etc) to return the empty value.
Test: fast/dom/AbortSignal-reason-crash-2.html
* Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::getChannelData):
* Modules/webaudio/AudioWorkletProcessor.cpp:
(WebCore::toJSArray):
(WebCore::toJSObject):
(WebCore::AudioWorkletProcessor::buildJSArguments):
* bindings/js/JSCustomEventCustom.cpp:
(WebCore::JSCustomEvent::detail const):
* bindings/js/JSDOMConvertAny.h:
(WebCore::JSConverter::convert):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data const):
* bindings/js/JSPaymentMethodChangeEventCustom.cpp:
(WebCore::JSPaymentMethodChangeEvent::methodDetails const):
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state const):
* bindings/js/JSValueInWrappedObject.h:
(WebCore::JSValueInWrappedObject::getValue const):
(WebCore::JSValueInWrappedObject::operator bool const):
(WebCore::cachedPropertyValue):
(WebCore::JSValueInWrappedObject::operator JSC::JSValue const): Deleted.
* dom/AbortSignal.cpp:
(WebCore::AbortSignal::signalFollow):
(WebCore::AbortSignal::throwIfAborted):
* dom/ErrorEvent.cpp:
(WebCore::ErrorEvent::error):
(WebCore::ErrorEvent::trySerializeError):
* dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::trySerializeState):
* page/History.cpp:
(WebCore::History::cachedState):
LayoutTests:
* fast/dom/AbortSignal-reason-crash-2-expected.txt: Added.
* fast/dom/AbortSignal-reason-crash-2.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioBuffer.cpp
trunk/Source/WebCore/Modules/webaudio/AudioWorkletProcessor.cpp
trunk/Source/WebCore/bindings/js/JSCustomEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSDOMConvertAny.h
trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSPaymentMethodChangeEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSPopStateEventCustom.cpp
trunk/Source/WebCore/bindings/js/JSValueInWrappedObject.h
trunk/Source/WebCore/dom/AbortSignal.cpp
trunk/Source/WebCore/dom/ErrorEvent.cpp
trunk/Source/WebCore/dom/PopStateEvent.cpp
trunk/Source/WebCore/page/History.cpp
Added Paths
trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-2-expected.txt
trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-2.html
Diff
Modified: trunk/LayoutTests/ChangeLog (289461 => 289462)
--- trunk/LayoutTests/ChangeLog 2022-02-09 09:14:53 UTC (rev 289461)
+++ trunk/LayoutTests/ChangeLog 2022-02-09 09:15:58 UTC (rev 289462)
@@ -1,3 +1,14 @@
+2022-02-09 Saam Barati
+
+Don't return an empty value from AbortController.signal.reason and make it harder to return empty values from JSValueInWrappedObject
+https://bugs.webkit.org/show_bug.cgi?id=236318
+
+
+Reviewed by Mark Lam.
+
+* fast/dom/AbortSignal-reason-crash-2-expected.txt: Added.
+* fast/dom/AbortSignal-reason-crash-2.html: Added.
+
2022-02-09 Diego Pino Garcia
[GTK][WPE] Update baselines after r288944
Added: trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-2-expected.txt (0 => 289462)
--- trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-2-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-2-expected.txt 2022-02-09 09:15:58 UTC (rev 289462)
@@ -0,0 +1,12 @@
+Test should not crash
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-2.html (0 => 289462)
--- trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-2.html (rev 0)
+++ trunk/LayoutTests/fast/dom/AbortSignal-reason-crash-2.html 2022-02-09 09:15:58 UTC (rev 289462)
@@ -0,0 +1,26 @@
+
+
+
+
+
+description("Test should not crash");
+window.jsTestIsAsync = true;
+(async () => {
+try {
+let abortController = new AbortController();
+abortController.abort();
+GCController.collect();
+let x = abortController.signal.r
[webkit-changes] [289461] releases/WebKitGTK/webkit-2.35.3/
Title: [289461] releases/WebKitGTK/webkit-2.35.3/ Revision 289461 Author carlo...@webkit.org Date 2022-02-09 01:14:53 -0800 (Wed, 09 Feb 2022) Log Message WebKitGTK 2.35.3 Added Paths releases/WebKitGTK/webkit-2.35.3/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289460] trunk
Title: [289460] trunk Revision 289460 Author carlo...@webkit.org Date 2022-02-09 01:13:55 -0800 (Wed, 09 Feb 2022) Log Message Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release .: * Source/cmake/OptionsGTK.cmake: Bump version numbers. Source/WebKit: * gtk/NEWS: Add release notes for 2.35.3. Modified Paths trunk/ChangeLog trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/gtk/NEWS trunk/Source/cmake/OptionsGTK.cmake Diff Modified: trunk/ChangeLog (289459 => 289460) --- trunk/ChangeLog 2022-02-09 08:47:26 UTC (rev 289459) +++ trunk/ChangeLog 2022-02-09 09:13:55 UTC (rev 289460) @@ -1,3 +1,9 @@ +2022-02-09 Carlos Garcia Campos + +Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release + +* Source/cmake/OptionsGTK.cmake: Bump version numbers. + 2022-02-08 Jonathan Bedard [git-webkit] Allow repositories to declare their bug trackers Modified: trunk/Source/WebKit/ChangeLog (289459 => 289460) --- trunk/Source/WebKit/ChangeLog 2022-02-09 08:47:26 UTC (rev 289459) +++ trunk/Source/WebKit/ChangeLog 2022-02-09 09:13:55 UTC (rev 289460) @@ -1,3 +1,9 @@ +2022-02-09 Carlos Garcia Campos + +Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release + +* gtk/NEWS: Add release notes for 2.35.3. + 2022-02-08 Jigen Zhou [Playstation] Fix build break after r289247 if ENABLE_SERVICE_WORKER is off Modified: trunk/Source/WebKit/gtk/NEWS (289459 => 289460) --- trunk/Source/WebKit/gtk/NEWS 2022-02-09 08:47:26 UTC (rev 289459) +++ trunk/Source/WebKit/gtk/NEWS 2022-02-09 09:13:55 UTC (rev 289460) @@ -1,4 +1,14 @@ +WebKitGTK 2.35.3 + + +What's new in WebKitGTK 2.35.3? + + - Fix a crash at startup when bubblewrap sandbox is enabled. + - Fix a crash when starting a drag an drop on touchscreen. + - Fix several crashes and rendering issues. + + WebKitGTK 2.35.2 Modified: trunk/Source/cmake/OptionsGTK.cmake (289459 => 289460) --- trunk/Source/cmake/OptionsGTK.cmake 2022-02-09 08:47:26 UTC (rev 289459) +++ trunk/Source/cmake/OptionsGTK.cmake 2022-02-09 09:13:55 UTC (rev 289460) @@ -3,7 +3,7 @@ WEBKIT_OPTION_BEGIN() -SET_PROJECT_VERSION(2 35 2) +SET_PROJECT_VERSION(2 35 3) set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string") @@ -227,11 +227,11 @@ endif () if (WEBKITGTK_API_VERSION VERSION_EQUAL "4.0") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 1 56) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 1 20) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 93 2 56) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 38 2 20) elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "4.1") -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 1 1) -CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 1 1) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 1 2 1) +CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 1 2 1) elseif (WEBKITGTK_API_VERSION VERSION_EQUAL "5.0") CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 0 0 0) CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 0 0 0) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [289458] trunk/Source/WebCore
Title: [289458] trunk/Source/WebCore
Revision 289458
Author mark@apple.com
Date 2022-02-09 00:34:22 -0800 (Wed, 09 Feb 2022)
Log Message
Remove some obsolete dependencies.
https://bugs.webkit.org/show_bug.cgi?id=236333
Reviewed by Chris Dumez.
These files in the dependency list don't even exist anymore.
* bindings/scripts/preprocess-idls.pl:
* bindings/scripts/test/SupplementalDependencies.dep:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl
trunk/Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep
Diff
Modified: trunk/Source/WebCore/ChangeLog (289457 => 289458)
--- trunk/Source/WebCore/ChangeLog 2022-02-09 07:35:37 UTC (rev 289457)
+++ trunk/Source/WebCore/ChangeLog 2022-02-09 08:34:22 UTC (rev 289458)
@@ -1,3 +1,15 @@
+2022-02-09 Mark Lam
+
+Remove some obsolete dependencies.
+https://bugs.webkit.org/show_bug.cgi?id=236333
+
+Reviewed by Chris Dumez.
+
+These files in the dependency list don't even exist anymore.
+
+* bindings/scripts/preprocess-idls.pl:
+* bindings/scripts/test/SupplementalDependencies.dep:
+
2022-02-08 Antti Koivisto
[CSS Container Queries] Track query containers so they can be invalidated on size change
Modified: trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl (289457 => 289458)
--- trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl 2022-02-09 07:35:37 UTC (rev 289457)
+++ trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl 2022-02-09 08:34:22 UTC (rev 289458)
@@ -1,7 +1,7 @@
#!/usr/bin/env perl
#
# Copyright (C) 2011 Google Inc. All rights reserved.
-# Copyright (C) 2020 Apple Inc. All rights reserved.
+# Copyright (C) 2020-2022 Apple Inc. All rights reserved.
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Library General Public
@@ -404,8 +404,6 @@
my @dependencies = sort(keys %{{ map{$_=>1}@dependencyList}});
$makefileDeps .= "JS${basename}.h: @{dependencies}\n";
-$makefileDeps .= "DOM${basename}.h: @{dependencies}\n";
-$makefileDeps .= "WebDOM${basename}.h: @{dependencies}\n";
foreach my $dependency (@dependencies) {
$makefileDeps .= "${dependency}:\n";
}
Modified: trunk/Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep (289457 => 289458)
--- trunk/Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep 2022-02-09 07:35:37 UTC (rev 289457)
+++ trunk/Source/WebCore/bindings/scripts/test/SupplementalDependencies.dep 2022-02-09 08:34:22 UTC (rev 289458)
@@ -1,324 +1,122 @@
# Supplemental dependencies
JSDOMWindow.h: DOMWindowConstructors.idl
-DOMDOMWindow.h: DOMWindowConstructors.idl
-WebDOMDOMWindow.h: DOMWindowConstructors.idl
DOMWindowConstructors.idl:
JSDedicatedWorkerGlobalScope.h: DedicatedWorkerGlobalScopeConstructors.idl
-DOMDedicatedWorkerGlobalScope.h: DedicatedWorkerGlobalScopeConstructors.idl
-WebDOMDedicatedWorkerGlobalScope.h: DedicatedWorkerGlobalScopeConstructors.idl
DedicatedWorkerGlobalScopeConstructors.idl:
JSExposedStar.h:
-DOMExposedStar.h:
-WebDOMExposedStar.h:
JSExposedToWorkerAndWindow.h:
-DOMExposedToWorkerAndWindow.h:
-WebDOMExposedToWorkerAndWindow.h:
JSPaintWorkletGlobalScope.h: PaintWorkletGlobalScopeConstructors.idl
-DOMPaintWorkletGlobalScope.h: PaintWorkletGlobalScopeConstructors.idl
-WebDOMPaintWorkletGlobalScope.h: PaintWorkletGlobalScopeConstructors.idl
PaintWorkletGlobalScopeConstructors.idl:
JSServiceWorkerGlobalScope.h: ServiceWorkerGlobalScopeConstructors.idl
-DOMServiceWorkerGlobalScope.h: ServiceWorkerGlobalScopeConstructors.idl
-WebDOMServiceWorkerGlobalScope.h: ServiceWorkerGlobalScopeConstructors.idl
ServiceWorkerGlobalScopeConstructors.idl:
JSShadowRealmGlobalScope.h: ShadowRealmGlobalScopeConstructors.idl
-DOMShadowRealmGlobalScope.h: ShadowRealmGlobalScopeConstructors.idl
-WebDOMShadowRealmGlobalScope.h: ShadowRealmGlobalScopeConstructors.idl
ShadowRealmGlobalScopeConstructors.idl:
JSSharedWorkerGlobalScope.h: SharedWorkerGlobalScopeConstructors.idl
-DOMSharedWorkerGlobalScope.h: SharedWorkerGlobalScopeConstructors.idl
-WebDOMSharedWorkerGlobalScope.h: SharedWorkerGlobalScopeConstructors.idl
SharedWorkerGlobalScopeConstructors.idl:
JSTestCEReactions.h:
-DOMTestCEReactions.h:
-WebDOMTestCEReactions.h:
JSTestCEReactionsStringifier.h:
-DOMTestCEReactionsStringifier.h:
-WebDOMTestCEReactionsStringifier.h:
JSTestCallTracer.h:
-DOMTestCallTracer.h:
-WebDOMTestCallTracer.h:
JSTestCallbackFunction.h:
-DOMTestCallbackFunction.h:
-WebDOMTestCallbackFunction.h:
JSTestCallbackFunctionRethrow.h:
-DOMTestCallbackFunctionRethrow.h:
-WebDOMTestCallbackFunctionRethrow.h:
JSTestCallbackFunctionWithThisObject.h:
-DOMTestCallbackFunctionWithThisObject.h:
-WebDOMTestCallbackFunctionWithThisObject.h:
JSTestCallbackFunctionWithTypedefs.h:
-DOMTestCallbackFunctionWithTypedefs.h
