[webkit-changes] [291092] trunk/LayoutTests/imported/w3c

[youenn]

Title: [291092] trunk/LayoutTests/imported/w3c








Revision 291092
Author you...@apple.com
Date 2022-03-09 23:14:02 -0800 (Wed, 09 Mar 2022)


Log Message
imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=237327

Reviewed by Eric Carlson.

The worker is first sending the Opened message, than any message coming from the data channel.
Wait for the Opened message before proceeding with the rest of the test.

* web-platform-tests/webrtc-extensions/transfer-datachannel.html:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291091 => 291092)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-10 07:04:54 UTC (rev 291091)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-10 07:14:02 UTC (rev 291092)
@@ -1,3 +1,15 @@
+2022-03-09  Youenn Fablet  
+
+imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=237327
+
+Reviewed by Eric Carlson.
+
+The worker is first sending the Opened message, than any message coming from the data channel.
+Wait for the Opened message before proceeding with the rest of the test.
+
+* web-platform-tests/webrtc-extensions/transfer-datachannel.html:
+
 2022-03-09  Antoine Quint  
 
 [web-animations] counter-increment should support discrete animation


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html (291091 => 291092)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html	2022-03-10 07:04:54 UTC (rev 291091)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc-extensions/transfer-datachannel.html	2022-03-10 07:14:02 UTC (rev 291092)
@@ -53,7 +53,7 @@
 createConnections(test, (firstConnection) => {
 localChannel = firstConnection.createDataChannel('sendDataChannel');
 worker.postMessage({channel: localChannel}, [localChannel]);
-
+data = "" Promise(resolve => worker._onmessage_ = (event) => resolve(event.data));
 }, (secondConnection) => {
 secondConnection._ondatachannel_ = (event) => {
 remoteChannel = event.channel;
@@ -62,6 +62,8 @@
 });
 });
 
+assert_equals(await data, "opened");
+
 data = "" Promise(resolve => worker._onmessage_ = (event) => resolve(event.data));
 remoteChannel.send("OK");
 assert_equals(await data, "OK");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291091] trunk/Source/WebKit

[megan_gardner]

Title: [291091] trunk/Source/WebKit








Revision 291091
Author megan_gard...@apple.com
Date 2022-03-09 23:04:54 -0800 (Wed, 09 Mar 2022)


Log Message
Combine Lookup and Define.
https://bugs.webkit.org/show_bug.cgi?id=237627
rdar://26205225

Reviewed by Tim Horton.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _defineForWebView:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (291090 => 291091)

--- trunk/Source/WebKit/ChangeLog	2022-03-10 06:12:17 UTC (rev 291090)
+++ trunk/Source/WebKit/ChangeLog	2022-03-10 07:04:54 UTC (rev 291091)
@@ -1,3 +1,14 @@
+2022-03-09  Megan Gardner  
+
+Combine Lookup and Define.
+https://bugs.webkit.org/show_bug.cgi?id=237627
+rdar://26205225
+
+Reviewed by Tim Horton.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _defineForWebView:]):
+
 2022-03-09  Per Arne Vollan  
 
 The accessibility library should be soft linked optionally


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (291090 => 291091)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2022-03-10 06:12:17 UTC (rev 291090)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2022-03-10 07:04:54 UTC (rev 291091)
@@ -4238,19 +4238,7 @@
 
 - (void)_defineForWebView:(id)sender
 {
-#if !PLATFORM(MACCATALYST)
-MCProfileConnection *connection = [PAL::getMCProfileConnectionClass() sharedConnection];
-if ([connection effectiveBoolValueForSetting:PAL::get_ManagedConfiguration_MCFeatureDefinitionLookupAllowed()] == MCRestrictedBoolExplicitNo)
-return;
-#endif
-
-RetainPtr view = self;
-_page->getSelectionOrContentsAsString([view](const String& string) {
-if (!string)
-return;
-
-[view _showDictionary:string];
-});
+[self _lookupForWebView:sender];
 }
 
 - (void)accessibilityRetrieveSpeakSelectionContent






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291090] trunk

[graouts]

Title: [291090] trunk








Revision 291090
Author grao...@webkit.org
Date 2022-03-09 22:12:17 -0800 (Wed, 09 Mar 2022)


Log Message
[web-animations] counter-increment should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237640

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

The counter-increment and counter-reset properties are represented via a single data structure
held by RenderStyle. This lays up the groundwork for animation support of counter-reset as well
but right now we only handle counter-increment to keep this patch focused.

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291089 => 291090)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-10 04:36:00 UTC (rev 291089)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-10 06:12:17 UTC (rev 291090)
@@ -1,5 +1,16 @@
 2022-03-09  Antoine Quint  
 
+[web-animations] counter-increment should support discrete animation
+https://bugs.webkit.org/show_bug.cgi?id=237640
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
+2022-03-09  Antoine Quint  
+
 [web-animations] dominant-baseline should support discrete animation
 https://bugs.webkit.org/show_bug.cgi?id=237645
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (291089 => 291090)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-10 04:36:00 UTC (rev 291089)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-10 06:12:17 UTC (rev 291090)
@@ -175,6 +175,9 @@
 PASS column-width (type: discrete) has testAccumulation function
 PASS column-width: "1px" onto "auto"
 PASS column-width: "auto" onto "1px"
+PASS counter-increment (type: discrete) has testAccumulation function
+PASS counter-increment: "ident-2 2" onto "ident-1 1"
+PASS counter-increment: "ident-1 1" onto "ident-2 2"
 PASS cursor (type: discrete) has testAccumulation function
 PASS cursor: "wait" onto "pointer"
 PASS cursor: "pointer" onto "wait"


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt (291089 => 291090)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-10 04:36:00 UTC (rev 291089)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-10 06:12:17 UTC (rev 291090)
@@ -175,6 +175,9 @@
 PASS column-width (type: discrete) has testAddition function
 PASS column-width: "1px" onto "auto"
 PASS column-width: "auto" onto "1px"
+PASS counter-increment (type: discrete) has testAddition function
+PASS counter-increment: "ident-2 2" onto "ident-1 1"
+PASS counter-increment: "ident-1 1" onto "ident-2 2"
 PASS cursor (type: discrete) has testAddition function
 PASS cursor: "wait" onto "pointer"
 PASS cursor: "pointer" onto "wait"


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt (291089 => 291090)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt	2022-03-10 04:36:00 UTC (rev 291089)
+++ 

[webkit-changes] [291089] trunk/LayoutTests

[heycam]

Title: [291089] trunk/LayoutTests








Revision 291089
Author hey...@apple.com
Date 2022-03-09 20:36:00 -0800 (Wed, 09 Mar 2022)


Log Message
Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=237688


* gpu-process/TestExpectations:
* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations
trunk/LayoutTests/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (291088 => 291089)

--- trunk/LayoutTests/ChangeLog	2022-03-10 04:31:35 UTC (rev 291088)
+++ trunk/LayoutTests/ChangeLog	2022-03-10 04:36:00 UTC (rev 291089)
@@ -1,6 +1,14 @@
 2022-03-09  Cameron McCormack  
 
 Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=237688
+
+* gpu-process/TestExpectations:
+* svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg:
+
+2022-03-09  Cameron McCormack  
+
+Unreviewed test gardening
 https://bugs.webkit.org/show_bug.cgi?id=236931
 
 * gpu-process/TestExpectations:


Modified: trunk/LayoutTests/gpu-process/TestExpectations (291088 => 291089)

--- trunk/LayoutTests/gpu-process/TestExpectations	2022-03-10 04:31:35 UTC (rev 291088)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2022-03-10 04:36:00 UTC (rev 291089)
@@ -321,20 +321,10 @@
 webkit.org/b/236927 fast/forms/input-text-autofocus.html [ Pass Failure ]
 
 # Flaky failure
-webkit.org/b/236932 css3/filters/backdrop/dynamic-with-clip-path.html [ Pass ImageOnlyFailure ]
+webkit.org/b/237684 css3/filters/backdrop/dynamic-with-clip-path.html [ Pass ImageOnlyFailure ]
 webkit.org/b/236932 css3/masking/mask-repeat-one-copy.html [ Pass ImageOnlyFailure ]
-webkit.org/b/236932 editing/pasteboard/paste-dark-mode-color-filtered.html [ Pass Failure ]
-webkit.org/b/236932 fast/speechrecognition/start-recognition-then-stop.html [ Pass Failure ]
-webkit.org/b/236932 imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-007.svg [ Pass Failure ]
-webkit.org/b/236932 imported/w3c/web-platform-tests/css/css-masking/mask-image/mask-image-url-image.html [ Pass ImageOnlyFailure ]
-webkit.org/b/236932 svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg [ Pass ImageOnlyFailure ]
-# Also happening on Mac...
-webkit.org/b/236932 imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html [ Pass Failure ]
-webkit.org/b/221487 imported/w3c/web-platform-tests/server-timing/server_timing_header-parsing.https.html [ Pass Failure ]
-webkit.org/b/236932 imported/w3c/web-platform-tests/workers/SharedWorker_dataUrl.html [ Pass Failure ]
-webkit.org/b/236932 js/dom/Promise-reject-large-string.html [ Pass Failure ]
-webkit.org/b/236932 svg/animations/smil-leak-element-instances.svg [ Pass Failure ]
-webkit.org/b/68278 http/tests/history/back-with-fragment-change.py [ Pass Failure ]
+webkit.org/b/237685 imported/w3c/web-platform-tests/css/css-masking/clip-path-svg-content/clip-path-content-use-007.svg [ Pass Failure ]
+webkit.org/b/237686 imported/w3c/web-platform-tests/css/css-masking/mask-image/mask-image-url-image.html [ Pass ImageOnlyFailure ]
 
 # Flaky crash
 webkit.org/b/236930 imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html [ Crash Pass ]


Modified: trunk/LayoutTests/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg (291088 => 291089)

--- trunk/LayoutTests/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg	2022-03-10 04:31:35 UTC (rev 291088)
+++ trunk/LayoutTests/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t.svg	2022-03-10 04:36:00 UTC (rev 291089)
@@ -2,6 +2,7 @@
viewBox="0 0 480 360" xmlns="http://www.w3.org/2000/svg"
   xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:xe="http://www.w3.org/2001/xml-events">
+  
   
   
   

[webkit-changes] [291088] trunk/LayoutTests

[heycam]

Title: [291088] trunk/LayoutTests








Revision 291088
Author hey...@apple.com
Date 2022-03-09 20:31:35 -0800 (Wed, 09 Mar 2022)


Log Message
Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=236931


* gpu-process/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (291087 => 291088)

--- trunk/LayoutTests/ChangeLog	2022-03-10 03:31:10 UTC (rev 291087)
+++ trunk/LayoutTests/ChangeLog	2022-03-10 04:31:35 UTC (rev 291088)
@@ -1,6 +1,13 @@
 2022-03-09  Cameron McCormack  
 
 Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=236931
+
+* gpu-process/TestExpectations:
+
+2022-03-09  Cameron McCormack  
+
+Unreviewed test gardening
 https://bugs.webkit.org/show_bug.cgi?id=236930
 
 * gpu-process/TestExpectations:


Modified: trunk/LayoutTests/gpu-process/TestExpectations (291087 => 291088)

--- trunk/LayoutTests/gpu-process/TestExpectations	2022-03-10 03:31:10 UTC (rev 291087)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2022-03-10 04:31:35 UTC (rev 291088)
@@ -320,9 +320,6 @@
 webkit.org/b/236927 fast/forms/autofocus-readonly-attribute.html [ Failure Pass ]
 webkit.org/b/236927 fast/forms/input-text-autofocus.html [ Pass Failure ]
 
-# Flaky timeout
-webkit.org/b/236931 editing/pasteboard/dom-paste/dom-paste-same-origin.html [ Timeout Pass ]
-
 # Flaky failure
 webkit.org/b/236932 css3/filters/backdrop/dynamic-with-clip-path.html [ Pass ImageOnlyFailure ]
 webkit.org/b/236932 css3/masking/mask-repeat-one-copy.html [ Pass ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291087] trunk/Source/JavaScriptCore

[sbarati]

Title: [291087] trunk/Source/_javascript_Core








Revision 291087
Author sbar...@apple.com
Date 2022-03-09 19:31:10 -0800 (Wed, 09 Mar 2022)


Log Message
Limit WK_XCODE_SUPPORTS_LTO in _javascript_Core based on target OS
https://bugs.webkit.org/show_bug.cgi?id=237682

Reviewed by Alexey Proskuryakov.

* Configurations/Base.xcconfig:
* Configurations/WebKitTargetConditionals.xcconfig:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/Base.xcconfig
trunk/Source/_javascript_Core/Configurations/WebKitTargetConditionals.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (291086 => 291087)

--- trunk/Source/_javascript_Core/ChangeLog	2022-03-10 03:18:08 UTC (rev 291086)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-03-10 03:31:10 UTC (rev 291087)
@@ -1,3 +1,13 @@
+2022-03-09  Saam Barati  
+
+Limit WK_XCODE_SUPPORTS_LTO in _javascript_Core based on target OS
+https://bugs.webkit.org/show_bug.cgi?id=237682
+
+Reviewed by Alexey Proskuryakov.
+
+* Configurations/Base.xcconfig:
+* Configurations/WebKitTargetConditionals.xcconfig:
+
 2022-03-09  Carlos Garcia Campos  
 
 [GTK][WPE] Stop using the env var WEBKIT_INSPECTOR_SERVER to connect to the inspector


Modified: trunk/Source/_javascript_Core/Configurations/Base.xcconfig (291086 => 291087)

--- trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2022-03-10 03:18:08 UTC (rev 291086)
+++ trunk/Source/_javascript_Core/Configurations/Base.xcconfig	2022-03-10 03:31:10 UTC (rev 291087)
@@ -194,8 +194,11 @@
 WK_LLVM_LTO_NO = NO;
 WK_LLVM_LTO_YES = $(WK_USER_LTO_MODE);
 
-WK_XCODE_SUPPORTS_LTO = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_10_2_$(XCODE_VERSION_MAJOR)));
-WK_XCODE_SUPPORTS_LTO[arch=arm*] = $(WK_NOT_$(WK_XCODE_VERSION_BEFORE_11_4_$(XCODE_VERSION_MAJOR)));
+WK_XCODE_SUPPORTS_LTO[sdk=macos*] = $(WK_NOT_$(WK_MACOS_BEFORE_1300));
+WK_XCODE_SUPPORTS_LTO[sdk=iphone*] = $(WK_NOT_$(WK_IOS_BEFORE_16));
+WK_XCODE_SUPPORTS_LTO[sdk=appletv*] = $(WK_NOT_$(WK_TVOS_BEFORE_16));
+// FIXME: This can follow the above pattern once rdar://90049836 is resolved.
+WK_XCODE_SUPPORTS_LTO[sdk=watch*] = NO;
 
 WK_XCODE_VERSION_BEFORE_10_2_0800 = YES;
 WK_XCODE_VERSION_BEFORE_10_2_0900 = YES;


Modified: trunk/Source/_javascript_Core/Configurations/WebKitTargetConditionals.xcconfig (291086 => 291087)

--- trunk/Source/_javascript_Core/Configurations/WebKitTargetConditionals.xcconfig	2022-03-10 03:18:08 UTC (rev 291086)
+++ trunk/Source/_javascript_Core/Configurations/WebKitTargetConditionals.xcconfig	2022-03-10 03:31:10 UTC (rev 291087)
@@ -217,3 +217,11 @@
 WK_IOS_16 = $(WK_IOS_16_$(WK_IOS_BEFORE_16));
 WK_IOS_16_ = _IOS_SINCE_16;
 WK_IOS_16_YES = _IOS_BEFORE_16;
+
+
+// tvOS
+WK_TVOS_BEFORE_16 = $(WK_TVOS_BEFORE_16_$(TVOS_DEPLOYMENT_TARGET:base));
+WK_TVOS_BEFORE_16_13 = YES;
+WK_TVOS_BEFORE_16_14 = YES;
+WK_TVOS_BEFORE_16_15 = YES;
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291086] trunk/LayoutTests

[heycam]

Title: [291086] trunk/LayoutTests








Revision 291086
Author hey...@apple.com
Date 2022-03-09 19:18:08 -0800 (Wed, 09 Mar 2022)


Log Message
Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=236930


* gpu-process/TestExpectations:
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/gpu-process/TestExpectations
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (291085 => 291086)

--- trunk/LayoutTests/ChangeLog	2022-03-10 03:05:30 UTC (rev 291085)
+++ trunk/LayoutTests/ChangeLog	2022-03-10 03:18:08 UTC (rev 291086)
@@ -1,3 +1,11 @@
+2022-03-09  Cameron McCormack  
+
+Unreviewed test gardening
+https://bugs.webkit.org/show_bug.cgi?id=236930
+
+* gpu-process/TestExpectations:
+* platform/ios/TestExpectations:
+
 2022-03-09  Matt Woodrow  
 
 Empty float rects should remain empty after integrally enclosing them.


Modified: trunk/LayoutTests/gpu-process/TestExpectations (291085 => 291086)

--- trunk/LayoutTests/gpu-process/TestExpectations	2022-03-10 03:05:30 UTC (rev 291085)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2022-03-10 03:18:08 UTC (rev 291086)
@@ -340,9 +340,6 @@
 webkit.org/b/68278 http/tests/history/back-with-fragment-change.py [ Pass Failure ]
 
 # Flaky crash
-webkit.org/b/236930 accessibility/ios-simulator/aria-details.html [ Crash Pass ]
-webkit.org/b/236930 ddcss3/images/cross-fade-simple.html [ Crash Pass ]
-webkit.org/b/236794 editing/spelling/editing-word-with-marker-2.html [ Crash Pass ]
 webkit.org/b/236930 imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.html [ Crash Pass ]
 webkit.org/b/236930 imported/w3c/web-platform-tests/html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener_base.html [ Crash Pass ]
 webkit.org/b/236930 imported/w3c/web-platform-tests/webstorage/storage_session_window_open.window.html [ Crash Pass ]


Modified: trunk/LayoutTests/platform/ios/TestExpectations (291085 => 291086)

--- trunk/LayoutTests/platform/ios/TestExpectations	2022-03-10 03:05:30 UTC (rev 291085)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2022-03-10 03:18:08 UTC (rev 291086)
@@ -3504,6 +3504,7 @@
 
 webkit.org/b/237295 fast/mediastream/video-rotation-gpu-process-crash.html [ Pass Crash ]
 
+webkit.org/b/236930 accessibility/ios-simulator/aria-details.html [ Crash Pass ]
 webkit.org/b/236794 editing/spelling/editing-word-with-marker-2.html [ Pass Crash ]
 
 webkit.org/b/237159 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-049.html [ Pass Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291085] trunk/Source/WebCore

[andresg_22]

Title: [291085] trunk/Source/WebCore








Revision 291085
Author andresg...@apple.com
Date 2022-03-09 19:05:30 -0800 (Wed, 09 Mar 2022)


Log Message
Remove unused AccessibilityObject member variable.
https://bugs.webkit.org/show_bug.cgi?id=237670


Reviewed by Chris Fleizach.

AccessibilityObject::m_isolatedTreeNodeInitialized is not used, thus
removing.

* accessibility/AccessibilityObject.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (291084 => 291085)

--- trunk/Source/WebCore/ChangeLog	2022-03-10 02:43:46 UTC (rev 291084)
+++ trunk/Source/WebCore/ChangeLog	2022-03-10 03:05:30 UTC (rev 291085)
@@ -1,5 +1,18 @@
 2022-03-09  Andres Gonzalez  
 
+Remove unused AccessibilityObject member variable.
+https://bugs.webkit.org/show_bug.cgi?id=237670
+
+
+Reviewed by Chris Fleizach.
+
+AccessibilityObject::m_isolatedTreeNodeInitialized is not used, thus
+removing.
+
+* accessibility/AccessibilityObject.h:
+
+2022-03-09  Andres Gonzalez  
+
 In isolated tree mode, do not call NSAccessibilityUnregisterUniqueIdForUIElement until the isolated object is detached.
 https://bugs.webkit.org/show_bug.cgi?id=237621
 


Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (291084 => 291085)

--- trunk/Source/WebCore/accessibility/AccessibilityObject.h	2022-03-10 02:43:46 UTC (rev 291084)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h	2022-03-10 03:05:30 UTC (rev 291085)
@@ -849,10 +849,6 @@
 AccessibilityIsIgnoredFromParentData m_isIgnoredFromParentData;
 bool m_childrenDirty { false };
 bool m_subtreeDirty { false };
-private:
-#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
-bool m_isolatedTreeNodeInitialized { false };
-#endif
 };
 
 #if !ENABLE(ACCESSIBILITY)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291084] trunk/Source/WebCore

[andresg_22]

Title: [291084] trunk/Source/WebCore








Revision 291084
Author andresg...@apple.com
Date 2022-03-09 18:43:46 -0800 (Wed, 09 Mar 2022)


Log Message
In isolated tree mode, do not call NSAccessibilityUnregisterUniqueIdForUIElement until the isolated object is detached.
https://bugs.webkit.org/show_bug.cgi?id=237621


Reviewed by Chris Fleizach.

When the live object is detached from its wrapper on the main thread,
the wrapper may be in the middle of serving a request on the AX thread.
Therefore calling NSAccessibilityUnregisterUniqueIdForUIElement may
interfere with the completiong of the request, or even cause undefined
behavior since many of the internal lookups for objects depend on a data
structure updated by system call. With this patch, we unregister a
wrapper when the isolated object is detached, which happens after the
live object is detached.

* accessibility/mac/WebAccessibilityObjectWrapperBase.h:
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase initWithAccessibilityObject:]):
(-[WebAccessibilityObjectWrapperBase attachIsolatedObject:]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper detach]):
(-[WebAccessibilityObjectWrapper detachIsolatedObject:]):
(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (291083 => 291084)

--- trunk/Source/WebCore/ChangeLog	2022-03-10 02:05:03 UTC (rev 291083)
+++ trunk/Source/WebCore/ChangeLog	2022-03-10 02:43:46 UTC (rev 291084)
@@ -1,3 +1,29 @@
+2022-03-09  Andres Gonzalez  
+
+In isolated tree mode, do not call NSAccessibilityUnregisterUniqueIdForUIElement until the isolated object is detached.
+https://bugs.webkit.org/show_bug.cgi?id=237621
+
+
+Reviewed by Chris Fleizach.
+
+When the live object is detached from its wrapper on the main thread,
+the wrapper may be in the middle of serving a request on the AX thread.
+Therefore calling NSAccessibilityUnregisterUniqueIdForUIElement may
+interfere with the completiong of the request, or even cause undefined
+behavior since many of the internal lookups for objects depend on a data
+structure updated by system call. With this patch, we unregister a
+wrapper when the isolated object is detached, which happens after the
+live object is detached.
+
+* accessibility/mac/WebAccessibilityObjectWrapperBase.h:
+* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
+(-[WebAccessibilityObjectWrapperBase initWithAccessibilityObject:]):
+(-[WebAccessibilityObjectWrapperBase attachIsolatedObject:]):
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper detach]):
+(-[WebAccessibilityObjectWrapper detachIsolatedObject:]):
+(-[WebAccessibilityObjectWrapper unregisterUniqueIdForUIElement]): Deleted.
+
 2022-03-09  Matt Woodrow  
 
 Empty float rects should remain empty after integrally enclosing them.


Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h (291083 => 291084)

--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h	2022-03-10 02:05:03 UTC (rev 291083)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h	2022-03-10 02:43:46 UTC (rev 291084)
@@ -63,9 +63,13 @@
 
 @interface WebAccessibilityObjectWrapperBase : NSObject {
 WebCore::AXCoreObject* m_axObject;
+
 #if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
 WebCore::AXCoreObject* m_isolatedObject;
+// To be accessed only on the main thread.
+bool m_isolatedObjectInitialized;
 #endif
+
 WebCore::AXID _identifier;
 }
 


Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm (291083 => 291084)

--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm	2022-03-10 02:05:03 UTC (rev 291083)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm	2022-03-10 02:43:46 UTC (rev 291084)
@@ -279,9 +279,10 @@
 
 - (id)initWithAccessibilityObject:(AXCoreObject*)axObject
 {
+ASSERT(isMainThread());
+
 if (!(self = [super init]))
 return nil;
-
 [self attachAXObject:axObject];
 return self;
 }
@@ -299,6 +300,9 @@
 {
 ASSERT(isolatedObject && (!_identifier.isValid() || _identifier == isolatedObject->objectID()));
 m_isolatedObject = isolatedObject;
+if (isMainThread())
+m_isolatedObjectInitialized = true;
+
 if (!_identifier.isValid())
 _identifier = m_isolatedObject->objectID();
 }


Modified: 

[webkit-changes] [291083] branches/safari-613-branch/Source/WebCore/Modules/webauthn/ AuthenticatorCoordinator.cpp

[repstein]

Title: [291083] branches/safari-613-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp








Revision 291083
Author repst...@apple.com
Date 2022-03-09 18:05:03 -0800 (Wed, 09 Mar 2022)


Log Message
Unreivewed build fix. rdar://89376484

./Modules/webauthn/AuthenticatorCoordinator.cpp:144:50: error: no member named 'findIf' in 'WTF::Vector'; did you mean 'find'?

Modified Paths

branches/safari-613-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp




Diff

Modified: branches/safari-613-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp (291082 => 291083)

--- branches/safari-613-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp	2022-03-10 02:02:18 UTC (rev 291082)
+++ branches/safari-613-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp	2022-03-10 02:05:03 UTC (rev 291083)
@@ -141,7 +141,7 @@
 options.pubKeyCredParams.append({ PublicKeyCredentialType::PublicKey, COSE::ES256 });
 options.pubKeyCredParams.append({ PublicKeyCredentialType::PublicKey, COSE::RS256 });
 } else {
-if (notFound != options.pubKeyCredParams.findIf([] (auto& pubKeyCredParam) {
+if (notFound != options.pubKeyCredParams.findMatching([] (auto& pubKeyCredParam) {
 return pubKeyCredParam.type != PublicKeyCredentialType::PublicKey;
 })) {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291082] branches/safari-613-branch/Source/WebCore/platform/sql

[repstein]

Title: [291082] branches/safari-613-branch/Source/WebCore/platform/sql








Revision 291082
Author repst...@apple.com
Date 2022-03-09 18:02:18 -0800 (Wed, 09 Mar 2022)


Log Message
Apply patch. rdar://problem/82071968

Modified Paths

branches/safari-613-branch/Source/WebCore/platform/sql/SQLiteDatabase.cpp
branches/safari-613-branch/Source/WebCore/platform/sql/SQLiteDatabase.h




Diff

Modified: branches/safari-613-branch/Source/WebCore/platform/sql/SQLiteDatabase.cpp (291081 => 291082)

--- branches/safari-613-branch/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2022-03-09 23:43:42 UTC (rev 291081)
+++ branches/safari-613-branch/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2022-03-10 02:02:18 UTC (rev 291082)
@@ -38,6 +38,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -93,7 +94,17 @@
 initializeSQLiteIfNecessary();
 
 close();
+
+auto closeDatabase = makeScopeExit([&]() {
+if (!m_db)
+return;
 
+m_openingThread = nullptr;
+m_openErrorMessage = sqlite3_errmsg(m_db);
+m_openError = sqlite3_errcode(m_db);
+close();
+});
+
 {
 Locker locker { isDatabaseOpeningForbiddenLock };
 if (isDatabaseOpeningForbidden) {
@@ -114,34 +125,27 @@
 break;
 }
 
+int result = SQLITE_OK;
 {
 SQLiteTransactionInProgressAutoCounter transactionCounter;
-m_openError = sqlite3_open_v2(FileSystem::fileSystemRepresentation(filename).data(), _db, flags, nullptr);
+result = sqlite3_open_v2(FileSystem::fileSystemRepresentation(filename).data(), _db, flags, nullptr);
 }
-if (m_openError != SQLITE_OK) {
-m_openErrorMessage = m_db ? sqlite3_errmsg(m_db) : "sqlite_open returned null";
-LOG_ERROR("SQLite database failed to load from %s\nCause - %s", filename.ascii().data(),
-m_openErrorMessage.data());
-close(ShouldSetErrorState::No);
+
+if (result != SQLITE_OK) {
+if (!m_db) {
+m_openError = result;
+m_openErrorMessage = "sqlite_open returned null";
+}
 return false;
 }
 }
 
 overrideUnauthorizedFunctions();
-
-m_openError = sqlite3_extended_result_codes(m_db, 1);
-if (m_openError != SQLITE_OK) {
-m_openErrorMessage = sqlite3_errmsg(m_db);
-LOG_ERROR("SQLite database error when enabling extended errors - %s", m_openErrorMessage.data());
-close(ShouldSetErrorState::No);
+
+m_openingThread = ::current();
+if (sqlite3_extended_result_codes(m_db, 1) != SQLITE_OK)
 return false;
-}
 
-if (isOpen())
-m_openingThread = ::current();
-else
-m_openErrorMessage = "sqlite_open returned null";
-
 {
 SQLiteTransactionInProgressAutoCounter transactionCounter;
 if (!executeCommand("PRAGMA temp_store = MEMORY;"_s))
@@ -148,18 +152,17 @@
 LOG_ERROR("SQLite database could not set temp_store to memory");
 }
 
-if (openMode != OpenMode::ReadOnly)
-useWALJournalMode();
+if (openMode != OpenMode::ReadOnly && !useWALJournalMode())
+return false;
 
 auto shmFileName = makeString(filename, "-shm"_s);
-if (FileSystem::fileExists(shmFileName)) {
-if (!FileSystem::isSafeToUseMemoryMapForPath(shmFileName)) {
-RELEASE_LOG_FAULT(SQLDatabase, "Opened an SQLite database with a Class A -shm file. This may trigger a crash when the user locks the device. (%s)", shmFileName.latin1().data());
-FileSystem::makeSafeToUseMemoryMapForPath(shmFileName);
-}
+if (FileSystem::fileExists(shmFileName) && !FileSystem::isSafeToUseMemoryMapForPath(shmFileName)) {
+RELEASE_LOG_FAULT(SQLDatabase, "Opened an SQLite database with a Class A -shm file. This may trigger a crash when the user locks the device. (%s)", shmFileName.latin1().data());
+FileSystem::makeSafeToUseMemoryMapForPath(shmFileName);
 }
 
-return isOpen();
+closeDatabase.release();
+return true;
 }
 
 static int walAutomaticTruncationHook(void* context, sqlite3* db, const char* dbName, int walPageCount)
@@ -221,26 +224,35 @@
 LOG_ERROR("SQLite database failed to checkpoint: %s", lastErrorMsg());
 }
 
-void SQLiteDatabase::useWALJournalMode()
+bool SQLiteDatabase::useWALJournalMode()
 {
 m_useWAL = true;
 {
 SQLiteTransactionInProgressAutoCounter transactionCounter;
 auto walStatement = prepareStatement("PRAGMA journal_mode=WAL;"_s);
-if (walStatement && walStatement->step() == SQLITE_ROW) {
+if (!walStatement)
+return false;
+
+int stepResult = walStatement->step();
+if (stepResult != SQLITE_ROW)
+return false;
+
 #ifndef NDEBUG
-String mode = walStatement->columnText(0);
-if (!equalLettersIgnoringASCIICase(mode, "wal"))
-

[webkit-changes] [291080] trunk

[mattwoodrow]

Title: [291080] trunk








Revision 291080
Author mattwood...@apple.com
Date 2022-03-09 15:06:19 -0800 (Wed, 09 Mar 2022)


Log Message
Empty float rects should remain empty after integrally enclosing them.
https://bugs.webkit.org/show_bug.cgi?id=237507

Reviewed by Alan Bujtas.

Source/WebCore:

Test: compositing/tile-coverage-subpixel-empty-rect.html

* platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRectPreservingEmptyRects):
* platform/graphics/FloatRect.h:
* platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::setNeedsDisplayInRect):
(WebCore::TileGrid::dropTilesInRect):
(WebCore::TileGrid::tilesWouldChangeForCoverageRect const):
(WebCore::TileGrid::prepopulateRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::ensureTilesForRect):

Add a new variant of enclosingIntRect(const Float&) that ensures that empty input rects
always return an empty output rect, even if the x/y position is fractional.
Significant portions of the layout code (including, but not limited to linesBoundingBox()) depend
on the old behavior, so the new behaviour is opt-in and only used by TileGrid.

Fixes the case where TileGrid received an empty coverage rect at a fractional position, and rounded
it out to a 1x1 rect and allocated unnecessary tiles.

LayoutTests:

* compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.
* compositing/tile-coverage-subpixel-empty-rect.html: Added.
* platform/gtk/compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.
* platform/ios/compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.

Adds a new test that uses multiple overflow:hidden clips and absolute positioning to create
an empty coverage rect with a subpixel x/y position that is within the bounds of an offscreen
layer. Confirms that we don't accidentally allocate a tile for this layer.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FloatRect.cpp
trunk/Source/WebCore/platform/graphics/FloatRect.h
trunk/Source/WebCore/platform/graphics/ca/TileGrid.cpp


Added Paths

trunk/LayoutTests/compositing/tile-coverage-subpixel-empty-rect-expected.txt
trunk/LayoutTests/compositing/tile-coverage-subpixel-empty-rect.html
trunk/LayoutTests/platform/gtk/compositing/tile-coverage-subpixel-empty-rect-expected.txt
trunk/LayoutTests/platform/ios/compositing/tile-coverage-subpixel-empty-rect-expected.txt
trunk/LayoutTests/platform/mac-wk1/compositing/tile-coverage-subpixel-empty-rect-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (291079 => 291080)

--- trunk/LayoutTests/ChangeLog	2022-03-09 22:45:42 UTC (rev 291079)
+++ trunk/LayoutTests/ChangeLog	2022-03-09 23:06:19 UTC (rev 291080)
@@ -1,3 +1,19 @@
+2022-03-09  Matt Woodrow  
+
+Empty float rects should remain empty after integrally enclosing them.
+https://bugs.webkit.org/show_bug.cgi?id=237507
+
+Reviewed by Alan Bujtas.
+
+* compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.
+* compositing/tile-coverage-subpixel-empty-rect.html: Added.
+* platform/gtk/compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.
+* platform/ios/compositing/tile-coverage-subpixel-empty-rect-expected.txt: Added.
+
+Adds a new test that uses multiple overflow:hidden clips and absolute positioning to create
+an empty coverage rect with a subpixel x/y position that is within the bounds of an offscreen
+layer. Confirms that we don't accidentally allocate a tile for this layer.
+
 2022-03-09  Matteo Flores  
 
 Unreviewed, reverting r290750.


Added: trunk/LayoutTests/compositing/tile-coverage-subpixel-empty-rect-expected.txt (0 => 291080)

--- trunk/LayoutTests/compositing/tile-coverage-subpixel-empty-rect-expected.txt	(rev 0)
+++ trunk/LayoutTests/compositing/tile-coverage-subpixel-empty-rect-expected.txt	2022-03-09 23:06:19 UTC (rev 291080)
@@ -0,0 +1,44 @@
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 3001.00 5100.00)
+  (children 1
+(GraphicsLayer
+  (bounds 3001.00 5100.00)
+  (contentsOpaque 1)
+  (tile cache coverage 0, 0 1024 x 1024)
+  (tile size 512 x 512)
+  (top left tile 0, 0 tiles grid 2 x 2)
+  (in window 1)
+  (children 1
+(GraphicsLayer
+  (position 1.00 2000.00)
+  (bounds 3000.00 3100.00)
+  (children 1
+(GraphicsLayer
+  (position -1.00 0.00)
+  (anchor 0.50 0.50)
+  (bounds 3001.00 3101.00)
+  (usingTiledLayer 1)
+  (drawsContent 1)
+  (transform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 0.00] [-1.00 0.00 0.00 1.00])
+  (tile cache coverage 0, 0 0 x 0)
+  (tile size 512 x 512)
+  (top left tile 0, 0 tiles grid 0 x 0)
+  (in window 1)
+  (children 1
+(GraphicsLayer
+  (position 0.00 

[webkit-changes] [291079] branches/safari-613-branch/Source/bmalloc

[ysuzuki]

Title: [291079] branches/safari-613-branch/Source/bmalloc








Revision 291079
Author ysuz...@apple.com
Date 2022-03-09 14:45:42 -0800 (Wed, 09 Mar 2022)


Log Message
Cherry-picking r290110

[libpas] scavenger should not call pthread_mach_thread_np after suspension
https://bugs.webkit.org/show_bug.cgi?id=236798
rdar://89020902

Reviewed by Mark Lam and Keith Miller.

pthread_mach_thread_np can take a lock internally. So we should not call it after suspending a thread.
This patch refactors libpas scavenger so that we call pthread_mach_thread_np before suspending a thread.
We also avoid calling pthread_self() after suspension to make suspending safer (while it does not take
a lock, it also depends on an internal implementation).

* libpas/src/libpas/pas_thread_local_cache.c:
(scavenger_thread_suspend_data_create):
(suspend):
(resume):
(stop_allocator):
(pas_thread_local_cache_for_all):

Modified Paths

branches/safari-613-branch/Source/bmalloc/ChangeLog
branches/safari-613-branch/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c




Diff

Modified: branches/safari-613-branch/Source/bmalloc/ChangeLog (291078 => 291079)

--- branches/safari-613-branch/Source/bmalloc/ChangeLog	2022-03-09 22:38:29 UTC (rev 291078)
+++ branches/safari-613-branch/Source/bmalloc/ChangeLog	2022-03-09 22:45:42 UTC (rev 291079)
@@ -1,3 +1,23 @@
+2022-02-17  Yusuke Suzuki  
+
+[libpas] scavenger should not call pthread_mach_thread_np after suspension
+https://bugs.webkit.org/show_bug.cgi?id=236798
+rdar://89020902
+
+Reviewed by Mark Lam and Keith Miller.
+
+pthread_mach_thread_np can take a lock internally. So we should not call it after suspending a thread.
+This patch refactors libpas scavenger so that we call pthread_mach_thread_np before suspending a thread.
+We also avoid calling pthread_self() after suspension to make suspending safer (while it does not take
+a lock, it also depends on an internal implementation).
+
+* libpas/src/libpas/pas_thread_local_cache.c:
+(scavenger_thread_suspend_data_create):
+(suspend):
+(resume):
+(stop_allocator):
+(pas_thread_local_cache_for_all):
+
 2022-03-07  Russell Epstein  
 
 Cherry-pick r290195. rdar://problem/88402366


Modified: branches/safari-613-branch/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c (291078 => 291079)

--- branches/safari-613-branch/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c	2022-03-09 22:38:29 UTC (rev 291078)
+++ branches/safari-613-branch/Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c	2022-03-09 22:45:42 UTC (rev 291079)
@@ -584,25 +584,45 @@
 pas_scavenger_notify_eligibility_if_needed();
 }
 
+typedef struct scavenger_thread_suspend_data {
+bool did_suspend;
+bool is_scavenger_itself;
 #if PAS_OS(DARWIN)
+mach_port_t mach_thread;
+#endif
+} scavenger_thread_suspend_data;
 
-static void suspend(pas_thread_local_cache* cache)
+static scavenger_thread_suspend_data scavenger_thread_suspend_data_create()
 {
+scavenger_thread_suspend_data thread_suspend_data;
+thread_suspend_data.did_suspend = false;
+thread_suspend_data.is_scavenger_itself = false;
+return thread_suspend_data;
+}
+
+#if PAS_OS(DARWIN)
+
+static void suspend(pas_thread_local_cache* cache, scavenger_thread_suspend_data* thread_suspend_data)
+{
 static const bool verbose = false;
 
 pthread_t thread;
-mach_port_t mach_thread;
 kern_return_t result;
+
+if (thread_suspend_data->did_suspend)
+return;
+thread_suspend_data->did_suspend = true;
 
 if (verbose)
 printf("Suspending TLC %p with thread %p.\n", cache, cache->thread);
 
 thread = cache->thread;
-if (thread == pthread_self())
+thread_suspend_data->is_scavenger_itself = thread == pthread_self();
+if (thread_suspend_data->is_scavenger_itself)
 return;
 
-mach_thread = pthread_mach_thread_np(thread);
-result = thread_suspend(mach_thread);
+thread_suspend_data->mach_thread = pthread_mach_thread_np(thread);
+result = thread_suspend(thread_suspend_data->mach_thread);
 
 /* Fun fact: it's impossible for us to try to suspend a thread that has exited, since
thread exit for any thread with a TLC needs to grab the heap lock and we hold the
@@ -610,20 +630,21 @@
 
 if (result != KERN_SUCCESS) {
 pas_log("[%d] Failed to suspend pthread %p (mach thread %d) associated with TLC %p: %d\n",
-getpid(), thread, mach_thread, cache, result);
+getpid(), thread, thread_suspend_data->mach_thread, cache, result);
 dump_thread_diagnostics(thread);
 PAS_ASSERT(result == KERN_SUCCESS);
 }
 }
 
-static void resume(pas_thread_local_cache* cache)
+static void resume(pas_thread_local_cache* cache, 

[webkit-changes] [291078] trunk/Source/WebCore

[achristensen]

Title: [291078] trunk/Source/WebCore








Revision 291078
Author achristen...@apple.com
Date 2022-03-09 14:38:29 -0800 (Wed, 09 Mar 2022)


Log Message
Fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=236131

* platform/VideoFrame.cpp:
(WebCore::VideoFrame::asVideoFrameCV):
* platform/VideoFrame.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/VideoFrame.cpp
trunk/Source/WebCore/platform/VideoFrame.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (291077 => 291078)

--- trunk/Source/WebCore/ChangeLog	2022-03-09 22:35:36 UTC (rev 291077)
+++ trunk/Source/WebCore/ChangeLog	2022-03-09 22:38:29 UTC (rev 291078)
@@ -5,7 +5,16 @@
 
 * platform/VideoFrame.cpp:
 (WebCore::VideoFrame::asVideoFrameCV):
+* platform/VideoFrame.h:
 
+2022-03-09  Alex Christensen  
+
+Fix AppleWin build
+https://bugs.webkit.org/show_bug.cgi?id=236131
+
+* platform/VideoFrame.cpp:
+(WebCore::VideoFrame::asVideoFrameCV):
+
 2022-03-09  Antoine Quint  
 
 [web-animations] dominant-baseline should support discrete animation


Modified: trunk/Source/WebCore/platform/VideoFrame.cpp (291077 => 291078)

--- trunk/Source/WebCore/platform/VideoFrame.cpp	2022-03-09 22:35:36 UTC (rev 291077)
+++ trunk/Source/WebCore/platform/VideoFrame.cpp	2022-03-09 22:38:29 UTC (rev 291078)
@@ -123,20 +123,16 @@
 const_cast(m_rotation) = rotation;
 }
 
-#if USE(AVFOUNDATION)
+#if PLATFORM(COCOA)
 RefPtr VideoFrame::asVideoFrameCV()
 {
-#if PLATFORM(COCOA)
 auto buffer = pixelBuffer();
 if (!buffer)
 return nullptr;
 
 return VideoFrameCV::create(presentationTime(), videoMirrored(), videoRotation(), buffer);
-#else
-return nullptr;
+}
 #endif
-}
-#endif // USE(AVFOUNDATION)
 
 }
 


Modified: trunk/Source/WebCore/platform/VideoFrame.h (291077 => 291078)

--- trunk/Source/WebCore/platform/VideoFrame.h	2022-03-09 22:35:36 UTC (rev 291077)
+++ trunk/Source/WebCore/platform/VideoFrame.h	2022-03-09 22:38:29 UTC (rev 291078)
@@ -31,11 +31,10 @@
 
 namespace WebCore {
 
-#if USE(AVFOUNDATION)
+#if USE(AVFOUNDATION) && PLATFORM(COCOA)
 class VideoFrameCV;
 #endif
 
-
 // A class representing a video frame from a decoder, capture source, or similar.
 // FIXME: Currently for implementation purposes inherts from MediaSample until capture code
 // stops referring to MediaSample
@@ -55,8 +54,10 @@
 virtual bool isLibWebRTC() const { return false; }
 #if USE(AVFOUNDATION)
 virtual bool isCV() const { return false; }
+#if PLATFORM(COCOA)
 WEBCORE_EXPORT virtual RefPtr asVideoFrameCV();
 #endif
+#endif
 
 void initializeCharacteristics(MediaTime presentationTime, bool isMirrored, VideoRotation);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291077] trunk/Tools

[jbedard]

Title: [291077] trunk/Tools








Revision 291077
Author jbed...@apple.com
Date 2022-03-09 14:35:36 -0800 (Wed, 09 Mar 2022)


Log Message
[EWS] Support concept of 'blocked' pull requests
https://bugs.webkit.org/show_bug.cgi?id=237370


Unreviewed follow-up fix.

Accidently landed change using string literals instead of variables.

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin):
(GitHubMixin._is_pr_blocked):
(ValidateChange.validate_github):
(BlockPullRequest.start):
(BlockPullRequest.getResultSummary):

Canonical link: https://commits.webkit.org/248243@main

Modified Paths

trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (291076 => 291077)

--- trunk/Tools/CISupport/ews-build/steps.py	2022-03-09 22:31:53 UTC (rev 291076)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-03-09 22:35:36 UTC (rev 291077)
@@ -139,6 +139,7 @@
 addURLs = False
 pr_open_states = ['open']
 pr_closed_states = ['closed']
+BLOCKED_LABEL = 'merging-blocked'
 
 def fetch_data_from_url_with_authentication(self, url):
 response = None
@@ -193,7 +194,7 @@
 
 def _is_pr_blocked(self, pr_json):
 for label in (pr_json or {}).get('labels', {}):
-if label.get('name', '') == 'blocked':
+if label.get('name', '') == self.BLOCKED_LABEL:
 return 1
 return 0
 
@@ -1327,7 +1328,7 @@
 
 blocked = self._is_pr_blocked(pr_json) if self.verifyReviewDenied else 0
 if blocked == 1:
-self.skip_build("PR {} has been marked as 'blocked'".format(pr_number))
+self.skip_build("PR {} has been marked as '{}'".format(pr_number, self.BLOCKED_LABEL))
 return False
 
 if -1 in (obsolete, pr_closed, blocked):
@@ -1493,7 +1494,7 @@
 
 rc = SKIPPED
 if CURRENT_HOSTNAME == EWS_BUILD_HOSTNAME:
-rc = SUCCESS if self.modify_label(pr_number, 'blocked', repository_url=self.getProperty('repository', '')) else FAILURE
+rc = SUCCESS if self.modify_label(pr_number, self.BLOCKED_LABEL, repository_url=self.getProperty('repository', '')) else FAILURE
 self.finished(rc)
 if build_finish_summary:
 self.build.buildFinished([build_finish_summary], FAILURE)
@@ -1501,10 +1502,10 @@
 
 def getResultSummary(self):
 if self.results == SUCCESS:
-return {'step': 'Added blocked label pull request'}
+return {'step': "Added '' label pull request".format(self.BLOCKED_LABEL)}
 elif self.results == SKIPPED:
 return buildstep.BuildStep.getResultSummary(self)
-return {'step': 'Failed to add blocked label to pull request'}
+return {'step': "Failed to add '{}' label to pull request".format(self.BLOCKED_LABEL)}
 
 def doStepIf(self, step):
 return self.getProperty('github.number')


Modified: trunk/Tools/ChangeLog (291076 => 291077)

--- trunk/Tools/ChangeLog	2022-03-09 22:31:53 UTC (rev 291076)
+++ trunk/Tools/ChangeLog	2022-03-09 22:35:36 UTC (rev 291077)
@@ -1,3 +1,20 @@
+2022-03-09  Jonathan Bedard  
+
+[EWS] Support concept of 'blocked' pull requests
+https://bugs.webkit.org/show_bug.cgi?id=237370
+
+
+Unreviewed follow-up fix.
+
+Accidently landed change using string literals instead of variables.
+
+* CISupport/ews-build/steps.py:
+(GitHubMixin):
+(GitHubMixin._is_pr_blocked):
+(ValidateChange.validate_github):
+(BlockPullRequest.start):
+(BlockPullRequest.getResultSummary):
+
 2022-03-09  Lauro Moura  
 
 [Tools] Add script to query results database






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291076] trunk/Source/WebCore

[achristensen]

Title: [291076] trunk/Source/WebCore








Revision 291076
Author achristen...@apple.com
Date 2022-03-09 14:31:53 -0800 (Wed, 09 Mar 2022)


Log Message
Fix AppleWin build
https://bugs.webkit.org/show_bug.cgi?id=236131

* platform/VideoFrame.cpp:
(WebCore::VideoFrame::asVideoFrameCV):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/VideoFrame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (291075 => 291076)

--- trunk/Source/WebCore/ChangeLog	2022-03-09 22:25:11 UTC (rev 291075)
+++ trunk/Source/WebCore/ChangeLog	2022-03-09 22:31:53 UTC (rev 291076)
@@ -1,3 +1,11 @@
+2022-03-09  Alex Christensen  
+
+Fix AppleWin build
+https://bugs.webkit.org/show_bug.cgi?id=236131
+
+* platform/VideoFrame.cpp:
+(WebCore::VideoFrame::asVideoFrameCV):
+
 2022-03-09  Antoine Quint  
 
 [web-animations] dominant-baseline should support discrete animation


Modified: trunk/Source/WebCore/platform/VideoFrame.cpp (291075 => 291076)

--- trunk/Source/WebCore/platform/VideoFrame.cpp	2022-03-09 22:25:11 UTC (rev 291075)
+++ trunk/Source/WebCore/platform/VideoFrame.cpp	2022-03-09 22:31:53 UTC (rev 291076)
@@ -123,16 +123,20 @@
 const_cast(m_rotation) = rotation;
 }
 
-#if PLATFORM(COCOA)
+#if USE(AVFOUNDATION)
 RefPtr VideoFrame::asVideoFrameCV()
 {
+#if PLATFORM(COCOA)
 auto buffer = pixelBuffer();
 if (!buffer)
 return nullptr;
 
 return VideoFrameCV::create(presentationTime(), videoMirrored(), videoRotation(), buffer);
+#else
+return nullptr;
+#endif
 }
-#endif
+#endif // USE(AVFOUNDATION)
 
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291075] trunk/Source/WebGPU

[rmorisset]

Title: [291075] trunk/Source/WebGPU








Revision 291075
Author rmoris...@apple.com
Date 2022-03-09 14:25:11 -0800 (Wed, 09 Mar 2022)


Log Message
[WGSL] Implement enough of the Parser for the simplest shaders
https://bugs.webkit.org/show_bug.cgi?id=237629

Reviewed by Myles Maxfield.

The specific "hello-world"-like shaders that I want this to be able to parse are included in WGSLParserTests.mm.

The general approach to the parser, such as its templating by the Lexer, is directly copied from JSC's parser.
Things are a bit simpler for us as WGSL is such a simple language to parse, being strictly LR(1).

In this patch I also deleted BlockAttribute, since this attribute was recently removed from the language.

* WGSL/AST/Attribute.h:
(WGSL::AST::Attribute::isBlock const): Deleted.
* WGSL/AST/Expressions/TypeConversion.h:
* WGSL/AST/FunctionDecl.h:
* WGSL/AST/ShaderModule.h:
* WGSL/AST/Statements/AssignmentStatement.h:
* WGSL/AST/StructureDecl.h:
* WGSL/AST/TypeDecl.h:
(WGSL::AST::ParameterizedType::stringViewToKind):
* WGSL/CompilationMessage.h:
* WGSL/Parser.cpp: Added.
(WGSL::Parser::Parser):
(WGSL::Parser::current):
(WGSL::parse):
(WGSL::parseLChar):
(WGSL::parseUChar):
(WGSL::Parser::consumeType):
(WGSL::Parser::consume):
(WGSL::Parser::parseShader):
(WGSL::Parser::parseGlobalDecl):
(WGSL::Parser::parseAttributes):
(WGSL::Parser::parseAttribute):
(WGSL::Parser::parseStructDecl):
(WGSL::Parser::parseStructMember):
(WGSL::Parser::parseTypeDecl):
(WGSL::Parser::parseTypeDeclAfterIdentifier):
(WGSL::Parser::parseGlobalVariableDecl):
(WGSL::Parser::parseVariableQualifier):
(WGSL::Parser::parseStorageClass):
(WGSL::Parser::parseAccessMode):
(WGSL::Parser::parseFunctionDecl):
(WGSL::Parser::parseParameter):
(WGSL::Parser::parseStatement):
(WGSL::Parser::parseCompoundStatement):
(WGSL::Parser::parseReturnStatement):
(WGSL::Parser::parseShortCircuitOrExpression):
(WGSL::Parser::parseRelationalExpression):
(WGSL::Parser::parseShiftExpression):
(WGSL::Parser::parseAdditiveExpression):
(WGSL::Parser::parseMultiplicativeExpression):
(WGSL::Parser::parseUnaryExpression):
(WGSL::Parser::parseSingularExpression):
(WGSL::Parser::parsePostfixExpression):
(WGSL::Parser::parsePrimaryExpression):
(WGSL::Parser::parseExpression):
(WGSL::Parser::parseLHSExpression):
(WGSL::Parser::parseCoreLHSExpression):
(WGSL::Parser::parseArgumentExpressionList):
* WGSL/Parser.h: Copied from Source/WebGPU/WGSL/CompilationMessage.h.
* WGSL/WGSL.cpp:
(WGSL::staticCheck):
(WGSL::SuccessfulCheck::SuccessfulCheck):
* WGSL/WGSL.h:
* WebGPU.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WGSL/AST/Attribute.h
trunk/Source/WebGPU/WGSL/AST/Expressions/TypeConversion.h
trunk/Source/WebGPU/WGSL/AST/FunctionDecl.h
trunk/Source/WebGPU/WGSL/AST/ShaderModule.h
trunk/Source/WebGPU/WGSL/AST/Statements/AssignmentStatement.h
trunk/Source/WebGPU/WGSL/AST/StructureDecl.h
trunk/Source/WebGPU/WGSL/AST/TypeDecl.h
trunk/Source/WebGPU/WGSL/CompilationMessage.h
trunk/Source/WebGPU/WGSL/WGSL.cpp
trunk/Source/WebGPU/WGSL/WGSL.h
trunk/Source/WebGPU/WebGPU.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebGPU/WGSL/Parser.cpp
trunk/Source/WebGPU/WGSL/Parser.h
trunk/Source/WebGPU/WGSLUnitTests/WGSLParserTests.mm




Diff

Modified: trunk/Source/WebGPU/ChangeLog (291074 => 291075)

--- trunk/Source/WebGPU/ChangeLog	2022-03-09 22:16:38 UTC (rev 291074)
+++ trunk/Source/WebGPU/ChangeLog	2022-03-09 22:25:11 UTC (rev 291075)
@@ -1,3 +1,72 @@
+2022-03-09  Robin Morisset  
+
+[WGSL] Implement enough of the Parser for the simplest shaders
+https://bugs.webkit.org/show_bug.cgi?id=237629
+
+Reviewed by Myles Maxfield.
+
+The specific "hello-world"-like shaders that I want this to be able to parse are included in WGSLParserTests.mm.
+
+The general approach to the parser, such as its templating by the Lexer, is directly copied from JSC's parser.
+Things are a bit simpler for us as WGSL is such a simple language to parse, being strictly LR(1).
+
+In this patch I also deleted BlockAttribute, since this attribute was recently removed from the language.
+
+* WGSL/AST/Attribute.h:
+(WGSL::AST::Attribute::isBlock const): Deleted.
+* WGSL/AST/Expressions/TypeConversion.h:
+* WGSL/AST/FunctionDecl.h:
+* WGSL/AST/ShaderModule.h:
+* WGSL/AST/Statements/AssignmentStatement.h:
+* WGSL/AST/StructureDecl.h:
+* WGSL/AST/TypeDecl.h:
+(WGSL::AST::ParameterizedType::stringViewToKind):
+* WGSL/CompilationMessage.h:
+* WGSL/Parser.cpp: Added.
+(WGSL::Parser::Parser):
+(WGSL::Parser::current):
+(WGSL::parse):
+(WGSL::parseLChar):
+(WGSL::parseUChar):
+(WGSL::Parser::consumeType):
+(WGSL::Parser::consume):
+(WGSL::Parser::parseShader):
+(WGSL::Parser::parseGlobalDecl):
+(WGSL::Parser::parseAttributes):
+

[webkit-changes] [291073] branches/safari-613-branch

[repstein]

Title: [291073] branches/safari-613-branch








Revision 291073
Author repst...@apple.com
Date 2022-03-09 14:16:31 -0800 (Wed, 09 Mar 2022)


Log Message
Cherry-pick r290760. rdar://problem/83745510

Rendering issues with many dynamically-added sticky elements inside overflow scroll
https://bugs.webkit.org/show_bug.cgi?id=237378


Reviewed by Cameron McCormack.

Source/WebCore:

A bug was filed describing a symptom where position:sticky elements would eventually
fail to render when many of them were dynamically added inside a non-stacking context
overflow scroll.

Debugging showed that CALayers were accumulating, causing us to hit per-process IOSurface
limits, at which point content fails to render (this is being fixed via rdar://89640915).
Further debugging showed that these layers were unparented, and being entrained by
ScrollingStateStickyNodes, which were accumulating in ScrollingStateTree's m_unparentedNodes.

This happened because with this scrolling configuration, each ScrollingStateStickyNode
is parented via a ScrollingStateOverflowScrollProxyNode which is referenced by entries
in RenderLayerBacking's m_ancestorClippingStack. On cleanup, the ScrollingStateOverflowScrollProxyNode
was unparented first, leaving the ScrollingStateStickyNode in m_unparentedNodes.

The fix is to have ScrollingStateTree::unparentChildrenAndDestroyNode() remove nodes
from m_unparentedNodes.

To test, add a m_unparentedNodes count to scrollingStateTreeAsText output, which means
having scrollingStateTreeAsText() as a member function on ScrollingStateTree.

Test: scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes.html

* page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText const):
* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::unparentChildrenAndDestroyNode):
(WebCore::ScrollingStateTree::scrollingStateTreeAsText const):
* page/scrolling/ScrollingStateTree.h:

LayoutTests:

* scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes-expected.txt: Added.
* scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
branches/safari-613-branch/Source/WebCore/page/scrolling/ScrollingStateTree.cpp
branches/safari-613-branch/Source/WebCore/page/scrolling/ScrollingStateTree.h


Added Paths

branches/safari-613-branch/LayoutTests/scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes-expected.txt
branches/safari-613-branch/LayoutTests/scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (291072 => 291073)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-09 22:16:21 UTC (rev 291072)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-09 22:16:31 UTC (rev 291073)
@@ -1,5 +1,64 @@
 2022-03-09  Russell Epstein  
 
+Cherry-pick r290760. rdar://problem/83745510
+
+Rendering issues with many dynamically-added sticky elements inside overflow scroll
+https://bugs.webkit.org/show_bug.cgi?id=237378
+
+
+Reviewed by Cameron McCormack.
+
+Source/WebCore:
+
+A bug was filed describing a symptom where position:sticky elements would eventually
+fail to render when many of them were dynamically added inside a non-stacking context
+overflow scroll.
+
+Debugging showed that CALayers were accumulating, causing us to hit per-process IOSurface
+limits, at which point content fails to render (this is being fixed via rdar://89640915).
+Further debugging showed that these layers were unparented, and being entrained by
+ScrollingStateStickyNodes, which were accumulating in ScrollingStateTree's m_unparentedNodes.
+
+This happened because with this scrolling configuration, each ScrollingStateStickyNode
+is parented via a ScrollingStateOverflowScrollProxyNode which is referenced by entries
+in RenderLayerBacking's m_ancestorClippingStack. On cleanup, the ScrollingStateOverflowScrollProxyNode
+was unparented first, leaving the ScrollingStateStickyNode in m_unparentedNodes.
+
+The fix is to have ScrollingStateTree::unparentChildrenAndDestroyNode() remove nodes
+from m_unparentedNodes.
+
+To test, add a m_unparentedNodes count to scrollingStateTreeAsText output, which means
+having scrollingStateTreeAsText() as a member function on ScrollingStateTree.
+
+Test: scrollingcoordinator/scrolling-tree/accumulated-unparented-sticky-nodes.html
+
+* 

[webkit-changes] [291072] branches/safari-613-branch

[repstein]

Title: [291072] branches/safari-613-branch








Revision 291072
Author repst...@apple.com
Date 2022-03-09 14:16:21 -0800 (Wed, 09 Mar 2022)


Log Message
Cherry-pick r290646. rdar://problem/88911184

focus({preventScroll: true}) does not prevent scrolling on iOS
https://bugs.webkit.org/show_bug.cgi?id=236584
rdar://88911184

Reviewed by Simon Fraser.

Source/WebCore:

Plumb `FocusOptions` through `Element::dispatchFocusEvent()` as well as the chrome client hooks for
`elementDidRefocus` and `elementDidFocus`, instead of just a `FocusDirection` flag.

* dom/Document.cpp:
(WebCore::Document::setFocusedElement):
* dom/Element.cpp:
(WebCore::Element::focus):
(WebCore::Element::dispatchFocusEvent):
* dom/Element.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent):
* html/HTMLSelectElement.h:
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
* html/HTMLTextFormControlElement.h:
* loader/EmptyClients.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::elementDidFocus):
(WebCore::ChromeClient::elementDidRefocus):
* page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedElement):
(WebCore::FocusController::setFocusedElement):

Source/WebKit:

Add support for `preventScroll` on iOS by avoiding UI-side zooming/scrolling to reveal the focused element if it
was focused with `preventScroll: true`. See below for more details.

Tests: fast/forms/select-focus-prevent-scroll.html
   fast/forms/text-field-focus-prevent-scroll.html

* Shared/FocusedElementInformation.cpp:
(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):
* Shared/FocusedElementInformation.h:

Add a boolean flag to `FocusedElementInformation` to indicate whether or not scrolling to reveal the focused
element should be prevented.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _zoomToRevealFocusedElement]):

Only zoom to reveal the focused element if the focused element information's `preventScroll` flag is `NO`.

(-[WKContentView _elementDidBlur]):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::elementDidFocus):
(WebKit::WebChromeClient::elementDidRefocus):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::elementDidRefocus):
(WebKit::WebPage::elementDidFocus):

Use `FocusOptions` to set the `preventScroll` flag when propagating `FocusedElementInformation`.

* WebProcess/WebPage/WebPage.h:

Source/WebKitLegacy/ios:

Adjust the method signature of elementDidFocus. See WebCore ChangeLog for more information.

* WebCoreSupport/WebChromeClientIOS.h:
* WebCoreSupport/WebChromeClientIOS.mm:
(WebChromeClientIOS::elementDidFocus):

Source/WebKitLegacy/mac:

Adjust the method signature of elementDidFocus. See WebCore ChangeLog for more information.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::elementDidFocus):

LayoutTests:

Add a couple of new layout tests to verify that passing in `{ preventScroll: true }` for focus options causes
us to avoid scrolling to reveal focused select elements and text fields.

* fast/forms/select-focus-prevent-scroll-expected.txt: Added.
* fast/forms/select-focus-prevent-scroll.html: Added.
* fast/forms/text-field-focus-prevent-scroll-expected.txt: Added.
* fast/forms/text-field-focus-prevent-scroll.html: Added.
* resources/ui-helper.js:

Also make it safe to call `waitForInputSessionToDismiss()` in a platform-agnostic test, by bailing early if
we're not on iOS, using WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/LayoutTests/resources/ui-helper.js
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/dom/Document.cpp
branches/safari-613-branch/Source/WebCore/dom/Element.cpp
branches/safari-613-branch/Source/WebCore/dom/Element.h
branches/safari-613-branch/Source/WebCore/html/HTMLSelectElement.cpp
branches/safari-613-branch/Source/WebCore/html/HTMLSelectElement.h
branches/safari-613-branch/Source/WebCore/html/HTMLTextFormControlElement.cpp
branches/safari-613-branch/Source/WebCore/html/HTMLTextFormControlElement.h
branches/safari-613-branch/Source/WebCore/loader/EmptyClients.h
branches/safari-613-branch/Source/WebCore/page/ChromeClient.h
branches/safari-613-branch/Source/WebCore/page/FocusController.cpp
branches/safari-613-branch/Source/WebKit/ChangeLog
branches/safari-613-branch/Source/WebKit/Shared/FocusedElementInformation.cpp

[webkit-changes] [291074] branches/safari-613-branch

[repstein]

Title: [291074] branches/safari-613-branch








Revision 291074
Author repst...@apple.com
Date 2022-03-09 14:16:38 -0800 (Wed, 09 Mar 2022)


Log Message
Cherry-pick r290515. rdar://problem/89376484

[WebAuthn] Use default pubKeyCredParams if empty in makeCredential
https://bugs.webkit.org/show_bug.cgi?id=237109
rdar://problem/89376484

Reviewed by Brent Fulgham.

Source/WebCore:

The Web Authentication level 2 spec was updated to clarify that
a set of default pubKeyCredParams should be used if the list
supplied by the RP is empty. This patch starts using
the default and updates associated tests.

* Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::create const):
* Modules/webauthn/PublicKeyCredentialCreationOptions.h:
* Modules/webauthn/WebAuthenticationConstants.h:

LayoutTests:

Update tests to take in account using default pubKeyCredParams.

* http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt:
* http/wpt/webauthn/public-key-credential-create-failure.https.html:
* http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt
branches/safari-613-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure.https.html
branches/safari-613-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt
branches/safari-613-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
branches/safari-613-branch/Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h
branches/safari-613-branch/Source/WebCore/Modules/webauthn/WebAuthenticationConstants.h




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (291073 => 291074)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-09 22:16:31 UTC (rev 291073)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-09 22:16:38 UTC (rev 291074)
@@ -1,5 +1,53 @@
 2022-03-09  Russell Epstein  
 
+Cherry-pick r290515. rdar://problem/89376484
+
+[WebAuthn] Use default pubKeyCredParams if empty in makeCredential
+https://bugs.webkit.org/show_bug.cgi?id=237109
+rdar://problem/89376484
+
+Reviewed by Brent Fulgham.
+
+Source/WebCore:
+
+The Web Authentication level 2 spec was updated to clarify that
+a set of default pubKeyCredParams should be used if the list
+supplied by the RP is empty. This patch starts using
+the default and updates associated tests.
+
+* Modules/webauthn/AuthenticatorCoordinator.cpp:
+(WebCore::AuthenticatorCoordinator::create const):
+* Modules/webauthn/PublicKeyCredentialCreationOptions.h:
+* Modules/webauthn/WebAuthenticationConstants.h:
+
+LayoutTests:
+
+Update tests to take in account using default pubKeyCredParams.
+
+* http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt:
+* http/wpt/webauthn/public-key-credential-create-failure.https.html:
+* http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
+* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-25  J Pascoe  
+
+[WebAuthn] Use default pubKeyCredParams if empty in makeCredential
+https://bugs.webkit.org/show_bug.cgi?id=237109
+rdar://problem/89376484
+
+Reviewed by Brent Fulgham.
+
+Update tests to take in account using default pubKeyCredParams.
+
+* http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt:
+* http/wpt/webauthn/public-key-credential-create-failure.https.html:
+* http/wpt/webauthn/public-key-credential-create-success-hid.https-expected.txt:
+* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
+
+2022-03-09  Russell Epstein  
+
 Cherry-pick r290760. rdar://problem/83745510
 
 Rendering issues with many dynamically-added sticky elements inside overflow scroll


Modified: branches/safari-613-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt (291073 => 291074)

--- branches/safari-613-branch/LayoutTests/http/wpt/webauthn/public-key-credential-create-failure.https-expected.txt	2022-03-09 22:16:31 UTC (rev 291073)
+++ 

[webkit-changes] [291071] branches/safari-613-branch/LayoutTests

[repstein]

Title: [291071] branches/safari-613-branch/LayoutTests








Revision 291071
Author repst...@apple.com
Date 2022-03-09 14:16:05 -0800 (Wed, 09 Mar 2022)


Log Message
Cherry-pick r290556. rdar://problem/89525864

Re-import inert and  WPT
https://bugs.webkit.org/show_bug.cgi?id=237243

Reviewed by Youenn Fablet.

Upstream commit: https://github.com/web-platform-tests/wpt/commit/9261ca87db106c1f31f1ab4f54b8f4a2617cbc24

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer-expected.html:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer-ref.html:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer.html:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column-expected.html:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column-ref.html:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column.html:
* web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
* web-platform-tests/inert/inert-and-contenteditable.tentative-expected.txt: Added.
* web-platform-tests/inert/inert-and-contenteditable.tentative.html: Added.
* web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt:
* web-platform-tests/inert/inert-iframe-hittest.tentative.html:
* web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt:
* web-platform-tests/inert/inert-iframe-tabbing.tentative.html:
* web-platform-tests/inert/w3c-import.log:

LayoutTests:

* TestExpectations:
* platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt:
* platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/LayoutTests/TestExpectations
branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer-expected.html
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer.html
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column-expected.html
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column.html
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative.html
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative.html
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/w3c-import.log
branches/safari-613-branch/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt
branches/safari-613-branch/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt


Added Paths

branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-replaced-renderer-ref.html
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-in-table-column-ref.html
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-contenteditable.tentative-expected.txt
branches/safari-613-branch/LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-contenteditable.tentative.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (291070 => 291071)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-09 22:15:52 UTC (rev 291070)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-09 22:16:05 UTC (rev 291071)
@@ -1,5 +1,54 @@
 2022-03-09  Russell Epstein  
 
+Cherry-pick r290556. rdar://problem/89525864
+
+Re-import inert and  WPT
+

[webkit-changes] [291069] branches/safari-613-branch

[repstein]

Title: [291069] branches/safari-613-branch








Revision 291069
Author repst...@apple.com
Date 2022-03-09 14:15:21 -0800 (Wed, 09 Mar 2022)


Log Message
Cherry-pick r289071. rdar://problem/89997434

ANGLE Metal and ANGLE OpenGL cannot be initialised one after the other
https://bugs.webkit.org/show_bug.cgi?id=236030

Patch by Kimmo Kinnunen  on 2022-02-03
Reviewed by Dean Jackson.

Source/WebCore:

Test: webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html

Remove the power-preference specific native displays.
Add a native display for opengl, and use the default
one for Metal.

After the recent ANGLE roll, ANGLE uses (native display, power preference)
as the key to look up EGLDisplays.

* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::releaseThreadResources):
* platform/graphics/angle/GraphicsContextGLANGLE.h:
* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::initializeEGLDisplay):

LayoutTests:

* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt: Added.
* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
* webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-613-branch/LayoutTests/ChangeLog
branches/safari-613-branch/Source/WebCore/ChangeLog
branches/safari-613-branch/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
branches/safari-613-branch/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h
branches/safari-613-branch/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm


Added Paths

branches/safari-613-branch/LayoutTests/webgl/pending/conformance2/misc/
branches/safari-613-branch/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt
branches/safari-613-branch/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html
branches/safari-613-branch/LayoutTests/webgl/pending/resources/webgl_test_files/conformance2/misc/
branches/safari-613-branch/LayoutTests/webgl/pending/resources/webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html




Diff

Modified: branches/safari-613-branch/LayoutTests/ChangeLog (291068 => 291069)

--- branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-09 22:10:35 UTC (rev 291068)
+++ branches/safari-613-branch/LayoutTests/ChangeLog	2022-03-09 22:15:21 UTC (rev 291069)
@@ -1,3 +1,49 @@
+2022-03-09  Russell Epstein  
+
+Cherry-pick r289071. rdar://problem/89997434
+
+ANGLE Metal and ANGLE OpenGL cannot be initialised one after the other
+https://bugs.webkit.org/show_bug.cgi?id=236030
+
+Patch by Kimmo Kinnunen  on 2022-02-03
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+Test: webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html
+
+Remove the power-preference specific native displays.
+Add a native display for opengl, and use the default
+one for Metal.
+
+After the recent ANGLE roll, ANGLE uses (native display, power preference)
+as the key to look up EGLDisplays.
+
+* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
+(WebCore::GraphicsContextGLANGLE::releaseThreadResources):
+* platform/graphics/angle/GraphicsContextGLANGLE.h:
+* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
+(WebCore::initializeEGLDisplay):
+
+LayoutTests:
+
+* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt: Added.
+* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
+* webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2022-02-03  Kimmo Kinnunen  
+
+ANGLE Metal and ANGLE OpenGL cannot be initialised one after the other
+https://bugs.webkit.org/show_bug.cgi?id=236030
+
+Reviewed by Dean Jackson.
+
+* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt: Added.
+* webgl/pending/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
+* webgl/resources/pending_webgl_test_files/conformance2/misc/webgl2-after-webgl1-bug.html: Added.
+
 2022-03-08  Russell Epstein  
 
 Cherry-pick r288701. rdar://problem/83734079


Added: branches/safari-613-branch/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt (0 => 291069)

--- branches/safari-613-branch/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt	(rev 0)
+++ branches/safari-613-branch/LayoutTests/webgl/pending/conformance2/misc/webgl2-after-webgl1-bug-expected.txt	2022-03-09 22:15:21 UTC (rev 291069)

[webkit-changes] [291068] trunk

[graouts]

Title: [291068] trunk








Revision 291068
Author grao...@webkit.org
Date 2022-03-09 14:10:35 -0800 (Wed, 09 Mar 2022)


Log Message
[web-animations] dominant-baseline should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237645

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::dominantBaseline const):
(WebCore::RenderStyle::setDominantBaseline):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291067 => 291068)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 22:10:35 UTC (rev 291068)
@@ -1,5 +1,16 @@
 2022-03-09  Antoine Quint  
 
+[web-animations] dominant-baseline should support discrete animation
+https://bugs.webkit.org/show_bug.cgi?id=237645
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
+2022-03-09  Antoine Quint  
+
 [css-lists] css/css-lists/inherit-overwrites.html and css/css-lists/li-counter-increment-computed-style.html are unique failures
 https://bugs.webkit.org/show_bug.cgi?id=237642
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (291067 => 291068)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 22:10:35 UTC (rev 291068)
@@ -178,6 +178,9 @@
 PASS cursor (type: discrete) has testAccumulation function
 PASS cursor: "wait" onto "pointer"
 PASS cursor: "pointer" onto "wait"
+PASS dominant-baseline (type: discrete) has testAccumulation function
+PASS dominant-baseline: "alphabetic" onto "ideographic"
+PASS dominant-baseline: "ideographic" onto "alphabetic"
 PASS empty-cells (type: discrete) has testAccumulation function
 PASS empty-cells: "hide" onto "show"
 PASS empty-cells: "show" onto "hide"


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt (291067 => 291068)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-09 22:07:51 UTC (rev 291067)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-09 22:10:35 UTC (rev 291068)
@@ -178,6 +178,9 @@
 PASS cursor (type: discrete) has testAddition function
 PASS cursor: "wait" onto "pointer"
 PASS cursor: "pointer" onto "wait"
+PASS dominant-baseline (type: discrete) has testAddition function
+PASS dominant-baseline: "alphabetic" onto "ideographic"
+PASS dominant-baseline: "ideographic" onto "alphabetic"
 PASS empty-cells (type: discrete) has testAddition function
 PASS empty-cells: "hide" onto "show"
 PASS empty-cells: "show" onto "hide"


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt (291067 => 291068)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt	2022-03-09 22:07:51 UTC (rev 291067)
+++ 

[webkit-changes] [291067] trunk/Tools

[lmoura]

Title: [291067] trunk/Tools








Revision 291067
Author lmo...@igalia.com
Date 2022-03-09 14:07:51 -0800 (Wed, 09 Mar 2022)


Log Message
[Tools] Add script to query results database
https://bugs.webkit.org/show_bug.cgi?id=233800

Reviewed by Jonathan Bedard.

This commit adds a script to query https://results.webkit.org for the
history of a testcase for a given bot/config. It includes a
`--only-changes` switch to show only revisions when the actual changed
from the previous one (useful to check when a test started failing).

For now it supports only layout-tests and has GTK/WPE bots predefined,
although full configurations (the query string for results.webkit.org)
can be used to access other bots.

* Scripts/webkit-test-results: Added.

Modified Paths

trunk/Tools/ChangeLog


Added Paths

trunk/Tools/Scripts/webkit-test-results




Diff

Modified: trunk/Tools/ChangeLog (291066 => 291067)

--- trunk/Tools/ChangeLog	2022-03-09 22:05:34 UTC (rev 291066)
+++ trunk/Tools/ChangeLog	2022-03-09 22:07:51 UTC (rev 291067)
@@ -1,5 +1,23 @@
 2022-03-09  Lauro Moura  
 
+[Tools] Add script to query results database
+https://bugs.webkit.org/show_bug.cgi?id=233800
+
+Reviewed by Jonathan Bedard.
+
+This commit adds a script to query https://results.webkit.org for the
+history of a testcase for a given bot/config. It includes a
+`--only-changes` switch to show only revisions when the actual changed
+from the previous one (useful to check when a test started failing).
+
+For now it supports only layout-tests and has GTK/WPE bots predefined,
+although full configurations (the query string for results.webkit.org)
+can be used to access other bots.
+
+* Scripts/webkit-test-results: Added.
+
+2022-03-09  Lauro Moura  
+
 [webkitcorepy] Prefer xdg-open to open in linux
 https://bugs.webkit.org/show_bug.cgi?id=237655
 


Added: trunk/Tools/Scripts/webkit-test-results (0 => 291067)

--- trunk/Tools/Scripts/webkit-test-results	(rev 0)
+++ trunk/Tools/Scripts/webkit-test-results	2022-03-09 22:07:51 UTC (rev 291067)
@@ -0,0 +1,390 @@
+#!/usr/bin/env python3
+#
+# Copyright (C) 2021 Igalia S.L.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this program; if not, write to the
+# Free Software Foundation, Inc., 51 Franklin St, Fifth Floor,
+# Boston, MA 02110-1301, USA.
+# pylint: disable=missing-docstring,invalid-name
+
+"""Command-line interface to the Webkit Results Database"""
+
+import argparse
+from datetime import datetime
+import json
+import logging
+import os
+import pathlib
+import sys
+import textwrap
+from urllib.parse import urljoin, urlencode, parse_qs
+from urllib.request import urlopen
+from urllib.error import HTTPError
+
+BASE_URL = "https://results.webkit.org/"
+
+
+def red(msg):
+"""Returns a shell-aware red string"""
+return "\033[91m" + msg + "\033[0m"
+
+
+def green(msg):
+"""Returns a shell-aware green string"""
+return "\033[92m" + msg + "\033[0m"
+
+
+# Roughly ordered from the most desired to the most unwanted.
+OUTCOMES = [
+"PASS",
+"TEXT",
+"IMAGE",
+"SKIP",
+"FAIL",
+"ERROR",
+"TIMEOUT",  # Put timeout as more severe than ERROR as they often are harder to debug
+"CRASH",
+]
+
+
+def is_improvement(baseline, current):
+"""Returns true if the current outcome is more favourable."""
+best_baseline = min(OUTCOMES.index(baseline_token) for baseline_token in baseline.split())
+return best_baseline > OUTCOMES.index(current)
+
+
+def is_regression(baseline, current):
+"""Returns true if the current outcome downgraded the result."""
+worst_baseline = max(OUTCOMES.index(baseline_token) for baseline_token in baseline.split())
+return worst_baseline < OUTCOMES.index(current)
+
+
+def decorate(msg, baseline, current):
+"""Colors the message if the status change represents an improvement or regression."""
+if is_improvement(baseline, current):
+msg = green(msg)
+elif is_regression(baseline, current):
+msg = red(msg)
+return msg
+
+
+class Query:
+"""Wrapper around the most common query parameters for a given request"""
+
+def __init__(self, **kwargs):
+"""Just stores the passed kwargs as parameters to be forwarded to the actual query"""
+self._params = kwargs.copy()
+
+@classmethod
+def 

[webkit-changes] [291066] trunk/LayoutTests

[matteo_flores]

Title: [291066] trunk/LayoutTests








Revision 291066
Author matteo_flo...@apple.com
Date 2022-03-09 14:05:34 -0800 (Wed, 09 Mar 2022)


Log Message
Unreviewed, reverting r290750.

Bug has been fixed, expectations are no longer needed.

Reverted changeset:

"[ iOS Debug ] editing/async-clipboard/* 20 tests are flaky
timeouts on iOS."
https://bugs.webkit.org/show_bug.cgi?id=237372
https://commits.webkit.org/r290750

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (291065 => 291066)

--- trunk/LayoutTests/ChangeLog	2022-03-09 21:46:49 UTC (rev 291065)
+++ trunk/LayoutTests/ChangeLog	2022-03-09 22:05:34 UTC (rev 291066)
@@ -1,5 +1,18 @@
 2022-03-09  Matteo Flores  
 
+Unreviewed, reverting r290750.
+
+Bug has been fixed, expectations are no longer needed.
+
+Reverted changeset:
+
+"[ iOS Debug ] editing/async-clipboard/* 20 tests are flaky
+timeouts on iOS."
+https://bugs.webkit.org/show_bug.cgi?id=237372
+https://commits.webkit.org/r290750
+
+2022-03-09  Matteo Flores  
+
 [ iOS ] 2 imported/w3c/web-platform-tests/content-security-policy/connect-src/* tests are flaky text failures
 https://bugs.webkit.org/show_bug.cgi?id=237603
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (291065 => 291066)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-03-09 21:46:49 UTC (rev 291065)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-03-09 22:05:34 UTC (rev 291066)
@@ -2195,28 +2195,6 @@
 imported/w3c/web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html [ Pass Failure ]
 
-# webkit.org/b/237372 The following 20 tests are flaky failures on iOS 15 Debug
-editing/async-clipboard/clipboard-change-data-while-getting-type.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-change-data-while-reading.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-change-data-while-writing.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-do-not-read-text-from-platform-if-text-changes.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-get-type-with-old-items.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-interfaces.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-item-get-type-basic.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-read-basic.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-read-text-from-platform.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-read-text-same-origin.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-read-text.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-read-while-pasting.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-read-write-images.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-write-basic.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-write-in-copy-event-handler-in-subframe.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-write-in-copy-event-handler.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-write-items-twice.html [ Pass Timeout ]
-editing/async-clipboard/clipboard-write-text.html [ Pass Timeout ]
-editing/async-clipboard/sanitize-when-reading-markup.html [ Pass Timeout ]
-editing/async-clipboard/sanitize-when-writing-image.html [ Pass Timeout ]
-
 # See webkit.org/b/233498 for context on this pointerevents tests
 imported/w3c/web-platform-tests/pointerevents [ Skip ]
 webkit.org/b/237348 pointerevents/mouse [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291065] trunk/Tools

[lmoura]

Title: [291065] trunk/Tools








Revision 291065
Author lmo...@igalia.com
Date 2022-03-09 13:46:49 -0800 (Wed, 09 Mar 2022)


Log Message
[webkitcorepy] Prefer xdg-open to open in linux
https://bugs.webkit.org/show_bug.cgi?id=237655

Reviewed by Jonathan Bedard.

* Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:
(Terminal.open_url):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py




Diff

Modified: trunk/Tools/ChangeLog (291064 => 291065)

--- trunk/Tools/ChangeLog	2022-03-09 21:06:23 UTC (rev 291064)
+++ trunk/Tools/ChangeLog	2022-03-09 21:46:49 UTC (rev 291065)
@@ -1,3 +1,13 @@
+2022-03-09  Lauro Moura  
+
+[webkitcorepy] Prefer xdg-open to open in linux
+https://bugs.webkit.org/show_bug.cgi?id=237655
+
+Reviewed by Jonathan Bedard.
+
+* Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:
+(Terminal.open_url):
+
 2021-12-07  Zhifei Fang  
 
 [results.webkit.org]Add selection box for results database.


Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py (291064 => 291065)

--- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py	2022-03-09 21:06:23 UTC (rev 291064)
+++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py	2022-03-09 21:46:49 UTC (rev 291065)
@@ -131,7 +131,12 @@
 if sys.platform.startswith('win'):
 process = run(['explorer', url])
 else:
-process = run(['open', url])
+# TODO: Use shutil directly when Python 2.7 is removed
+from whichcraft import which
+if sys.platform.startswith('linux') and which('xdg-open'):
+process = run(['xdg-open', url])
+else:
+process = run(['open', url])
 return True if process.returncode == 0 else False
 
 class Text(object):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291064] branches/safari-613-branch/Source/WebCore/page/csp/ ContentSecurityPolicy.cpp

[repstein]

Title: [291064] branches/safari-613-branch/Source/WebCore/page/csp/ContentSecurityPolicy.cpp








Revision 291064
Author repst...@apple.com
Date 2022-03-09 13:06:23 -0800 (Wed, 09 Mar 2022)


Log Message
Unreviewed build fix. rdar://83734079

error: no matching member function for call to 'reportViolation'

Modified Paths

branches/safari-613-branch/Source/WebCore/page/csp/ContentSecurityPolicy.cpp




Diff

Modified: branches/safari-613-branch/Source/WebCore/page/csp/ContentSecurityPolicy.cpp (291063 => 291064)

--- branches/safari-613-branch/Source/WebCore/page/csp/ContentSecurityPolicy.cpp	2022-03-09 21:05:03 UTC (rev 291063)
+++ branches/safari-613-branch/Source/WebCore/page/csp/ContentSecurityPolicy.cpp	2022-03-09 21:06:23 UTC (rev 291064)
@@ -617,7 +617,7 @@
 TextPosition sourcePosition(OrdinalNumber::beforeFirst(), OrdinalNumber());
 auto handleViolatedDirective = [&] (const ContentSecurityPolicyDirective& violatedDirective) {
 auto consoleMessage = consoleMessageForViolation(ContentSecurityPolicyDirectiveNames::workerSrc, violatedDirective, blockedURL, "Refused to load");
-reportViolation(violatedDirective, blockedURL.string(), consoleMessage, sourceURL, StringView(), sourcePosition);
+reportViolation(ContentSecurityPolicyDirectiveNames::workerSrc, violatedDirective, blockedURL.string(), consoleMessage, sourceURL, StringView(), sourcePosition);
 };
 
 return allPoliciesAllow(WTFMove(handleViolatedDirective), ::violatedDirectiveForWorker, url, redirectResponseReceived == RedirectResponseReceived::Yes);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291063] trunk/Tools

[zhifei_fang]

Title: [291063] trunk/Tools








Revision 291063
Author zhifei_f...@apple.com
Date 2022-03-09 13:05:03 -0800 (Wed, 09 Mar 2022)


Log Message
[results.webkit.org]Add selection box for results database.
https://bugs.webkit.org/show_bug.cgi?id=233958

Reviewed by Jonathan Bedard.

Allow user can drag a selection box to select multiple dots.
Allow user to use cmd + click to select multiple dots.
Allow user to use shift + click to select a row of dots.

* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(TimelineFromEndpoint):
(TimelineFromEndpoint.prototype.update):
(TimelineFromEndpoint.prototype.getTestResultStatus):
(TimelineFromEndpoint.prototype.getTestResultUrl):
(TimelineFromEndpoint.prototype.render):
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(pointRectCollisionDetect): Detact if a point and a rect have a insertion.
(rectRectCollisionDetect): Detact if two rects have a insertion.
(XScrollableCanvasProvider): Add selection box.
(xScrollStreamRenderFactory):
(Timeline.CanvasSeriesComponent): Add selection box , cmd + click and shift + click.
(prototype.ExpandableSeriesComponent):
(prototype.Timeline.CanvasContainer):

Canonical link: https://commits.webkit.org/248236@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/test_context.py
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/css/tooltip.css
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/tooltip.js
trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js


Added Paths

trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/bug_tracker_controller.py




Diff

Modified: trunk/Tools/ChangeLog (291062 => 291063)

--- trunk/Tools/ChangeLog	2022-03-09 20:59:08 UTC (rev 291062)
+++ trunk/Tools/ChangeLog	2022-03-09 21:05:03 UTC (rev 291063)
@@ -1,3 +1,30 @@
+2021-12-07  Zhifei Fang  
+
+[results.webkit.org]Add selection box for results database.
+https://bugs.webkit.org/show_bug.cgi?id=233958
+
+Reviewed by Jonathan Bedard.
+
+Allow user can drag a selection box to select multiple dots.
+Allow user to use cmd + click to select multiple dots. 
+Allow user to use shift + click to select a row of dots.
+
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+(TimelineFromEndpoint):
+(TimelineFromEndpoint.prototype.update):
+(TimelineFromEndpoint.prototype.getTestResultStatus):
+(TimelineFromEndpoint.prototype.getTestResultUrl):
+(TimelineFromEndpoint.prototype.render):
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
+* Scripts/libraries/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+(pointRectCollisionDetect): Detact if a point and a rect have a insertion.
+(rectRectCollisionDetect): Detact if two rects have a insertion.
+(XScrollableCanvasProvider): Add selection box.
+(xScrollStreamRenderFactory):
+(Timeline.CanvasSeriesComponent): Add selection box , cmd + click and shift + click.
+(prototype.ExpandableSeriesComponent):
+(prototype.Timeline.CanvasContainer):
+
 2022-03-01  Jonathan Bedard  
 
 [EWS] Support concept of 'blocked' pull requests


Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py (291062 => 291063)

--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py	2022-03-09 20:59:08 UTC (rev 291062)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/api_routes.py	2022-03-09 21:05:03 UTC (rev 291063)
@@ -20,6 +20,7 @@
 # OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+from crypt import methods
 import traceback
 
 from flask import abort, jsonify
@@ -30,12 +31,13 @@
 from resultsdbpy.controller.suite_controller import SuiteController
 from resultsdbpy.controller.test_controller import TestController
 from resultsdbpy.controller.upload_controller import UploadController
+from resultsdbpy.controller.bug_tracker_controller import BugTrackerController
 from webkitflaskpy import AuthedBlueprint
 from werkzeug.exceptions import HTTPException
 
 
 class APIRoutes(AuthedBlueprint):
-def __init__(self, model, import_name=__name__, auth_decorator=None):
+def __init__(self, model, import_name=__name__, auth_decorator=None, bug_tracker_configs=[]):
 super(APIRoutes, self).__init__('controller', import_name, url_prefix='/api', 

[webkit-changes] [291062] trunk/Source/WebKit

[pvollan]

Title: [291062] trunk/Source/WebKit








Revision 291062
Author pvol...@apple.com
Date 2022-03-09 12:59:08 -0800 (Wed, 09 Mar 2022)


Log Message
The accessibility library should be soft linked optionally
https://bugs.webkit.org/show_bug.cgi?id=236513

Reviewed by Geoffrey Garen.

The accessibility library should be soft linked optionally, since it is not always present.

* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::handleAXPreferenceChange):
(WebKit::AuxiliaryProcess::handlePreferenceChange):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (291061 => 291062)

--- trunk/Source/WebKit/ChangeLog	2022-03-09 20:44:41 UTC (rev 291061)
+++ trunk/Source/WebKit/ChangeLog	2022-03-09 20:59:08 UTC (rev 291062)
@@ -1,3 +1,16 @@
+2022-03-09  Per Arne Vollan  
+
+The accessibility library should be soft linked optionally
+https://bugs.webkit.org/show_bug.cgi?id=236513
+
+Reviewed by Geoffrey Garen.
+
+The accessibility library should be soft linked optionally, since it is not always present.
+
+* Shared/Cocoa/AuxiliaryProcessCocoa.mm:
+(WebKit::handleAXPreferenceChange):
+(WebKit::AuxiliaryProcess::handlePreferenceChange):
+
 2022-03-09  Don Olmstead  
 
 [CMake] Associate platform specific configuration with WinCairo


Modified: trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm (291061 => 291062)

--- trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm	2022-03-09 20:44:41 UTC (rev 291061)
+++ trunk/Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm	2022-03-09 20:59:08 UTC (rev 291062)
@@ -46,7 +46,7 @@
 #endif
 
 #if HAVE(UPDATE_WEB_ACCESSIBILITY_SETTINGS) && ENABLE(CFPREFS_DIRECT_MODE)
-SOFT_LINK_LIBRARY(libAccessibility)
+SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
 SOFT_LINK_OPTIONAL(libAccessibility, _AXSUpdateWebAccessibilitySettings, void, (), ());
 #endif
 
@@ -197,8 +197,13 @@
 }
 #endif
 
-void AuxiliaryProcess::handlePreferenceChange(const String& domain, const String& key, id value)
+static void handleAXPreferenceChange(const String& domain, const String& key, id value)
 {
+#if HAVE(UPDATE_WEB_ACCESSIBILITY_SETTINGS)
+if (!libAccessibilityLibrary())
+return;
+#endif
+
 if (domain == String(kAXSAccessibilityPreferenceDomain)) {
 #if HAVE(UPDATE_WEB_ACCESSIBILITY_SETTINGS)
 if (_AXSUpdateWebAccessibilitySettingsPtr())
@@ -212,7 +217,11 @@
 _AXSSetDarkenSystemColors([(NSNumber *)value boolValue]);
 #endif
 }
+}
 
+void AuxiliaryProcess::handlePreferenceChange(const String& domain, const String& key, id value)
+{
+handleAXPreferenceChange(domain, key, value);
 dispatchSimulatedNotificationsForPreferenceChange(key);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291061] trunk/Source/WebKit

[don . olmstead]

Title: [291061] trunk/Source/WebKit








Revision 291061
Author don.olmst...@sony.com
Date 2022-03-09 12:44:41 -0800 (Wed, 09 Mar 2022)


Log Message
[CMake] Associate platform specific configuration with WinCairo
https://bugs.webkit.org/show_bug.cgi?id=237668

Reviewed by Basuke Suzuki.

Move all cairo and curl platform configuration under a check for WinCairo. This arranges
platform config in a consistent manner.

* PlatformWin.cmake:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformWin.cmake




Diff

Modified: trunk/Source/WebKit/ChangeLog (291060 => 291061)

--- trunk/Source/WebKit/ChangeLog	2022-03-09 20:29:54 UTC (rev 291060)
+++ trunk/Source/WebKit/ChangeLog	2022-03-09 20:44:41 UTC (rev 291061)
@@ -1,3 +1,15 @@
+2022-03-09  Don Olmstead  
+
+[CMake] Associate platform specific configuration with WinCairo
+https://bugs.webkit.org/show_bug.cgi?id=237668
+
+Reviewed by Basuke Suzuki.
+
+Move all cairo and curl platform configuration under a check for WinCairo. This arranges
+platform config in a consistent manner.
+
+* PlatformWin.cmake:
+
 2022-03-09  Sihui Liu  
 
 File System Access: disallows names that are not permitted by underlying file system


Modified: trunk/Source/WebKit/PlatformWin.cmake (291060 => 291061)

--- trunk/Source/WebKit/PlatformWin.cmake	2022-03-09 20:29:54 UTC (rev 291060)
+++ trunk/Source/WebKit/PlatformWin.cmake	2022-03-09 20:44:41 UTC (rev 291061)
@@ -25,8 +25,6 @@
 
 NetworkProcess/WebStorage/StorageManager.cpp
 
-NetworkProcess/curl/NetworkProcessMainCurl.cpp
-
 Platform/IPC/win/AttachmentWin.cpp
 Platform/IPC/win/ConnectionWin.cpp
 Platform/IPC/win/IPCSemaphoreWin.cpp
@@ -37,8 +35,6 @@
 Platform/win/ModuleWin.cpp
 Platform/win/SharedMemoryWin.cpp
 
-Shared/API/c/curl/WKCertificateInfoCurl.cpp
-
 Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp
 
 Shared/win/AuxiliaryProcessMainWin.cpp
@@ -58,9 +54,6 @@
 
 UIProcess/API/C/WKViewportAttributes.cpp
 
-UIProcess/API/C/curl/WKProtectionSpaceCurl.cpp
-UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp
-
 UIProcess/API/C/win/WKView.cpp
 
 UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
@@ -70,8 +63,6 @@
 
 UIProcess/Launcher/win/ProcessLauncherWin.cpp
 
-UIProcess/WebsiteData/curl/WebsiteDataStoreCurl.cpp
-
 UIProcess/WebsiteData/win/WebsiteDataStoreWin.cpp
 
 UIProcess/wc/DrawingAreaProxyWC.cpp
@@ -124,8 +115,6 @@
 "${WEBKIT_DIR}/Shared/Plugins/win"
 "${WEBKIT_DIR}/Shared/wc"
 "${WEBKIT_DIR}/Shared/win"
-"${WEBKIT_DIR}/UIProcess/API/C/cairo"
-"${WEBKIT_DIR}/UIProcess/API/C/curl"
 "${WEBKIT_DIR}/UIProcess/API/C/win"
 "${WEBKIT_DIR}/UIProcess/API/cpp/win"
 "${WEBKIT_DIR}/UIProcess/API/win"
@@ -166,8 +155,6 @@
 )
 
 if (${WTF_PLATFORM_WIN_CAIRO})
-add_definitions(-DUSE_CAIRO=1 -DUSE_CURL=1)
-
 list(APPEND WebKit_SOURCES
 NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp
 
@@ -176,16 +163,24 @@
 
 NetworkProcess/curl/NetworkDataTaskCurl.cpp
 NetworkProcess/curl/NetworkProcessCurl.cpp
+NetworkProcess/curl/NetworkProcessMainCurl.cpp
 NetworkProcess/curl/NetworkSessionCurl.cpp
 
 Shared/API/c/cairo/WKImageCairo.cpp
 
+Shared/API/c/curl/WKCertificateInfoCurl.cpp
+
 Shared/cairo/ShareableBitmapCairo.cpp
 
 Shared/curl/WebCoreArgumentCodersCurl.cpp
 
+UIProcess/API/C/curl/WKProtectionSpaceCurl.cpp
+UIProcess/API/C/curl/WKWebsiteDataStoreRefCurl.cpp
+
 UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp
 
+UIProcess/WebsiteData/curl/WebsiteDataStoreCurl.cpp
+
 UIProcess/cairo/BackingStoreCairo.cpp
 
 WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.cpp
@@ -193,6 +188,8 @@
 
 list(APPEND WebKit_INCLUDE_DIRECTORIES
 "${WEBKIT_DIR}/NetworkProcess/curl"
+"${WEBKIT_DIR}/UIProcess/API/C/cairo"
+"${WEBKIT_DIR}/UIProcess/API/C/curl"
 "${WEBKIT_DIR}/WebProcess/WebCoreSupport/curl"
 )
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291060] trunk/Tools

[jbedard]

Title: [291060] trunk/Tools








Revision 291060
Author jbed...@apple.com
Date 2022-03-09 12:29:54 -0800 (Wed, 09 Mar 2022)


Log Message
[EWS] Support concept of 'blocked' pull requests
https://bugs.webkit.org/show_bug.cgi?id=237370


Reviewed by Ryan Haddad.

cq- communicates that a change is blocked, either by an engineer or by a failed EWS run.
"changes requested" is not as dramatic as "cq-", so we are adding the concept of a "blocked"
pull request, which has simlar effects to "cq-".

* Tools/CISupport/ews-build/steps.py:
(GitHubMixin._is_pr_blocked): Check if a pull request currently has the "blocked" tag.
(GitHubMixin.modify_label): Add or remove a label from a pull request.
(SetCommitQueueMinusFlagOnPatch.hideStepIf): Added.
(BlockPullRequest): Added.
(AnalyzeCompileWebKitResults.analyzeResults): Block PR if failed.
(AnalyzeLayoutTestsResults.report_failure): Ditto.

Canonical link: https://commits.webkit.org/248233@main

Modified Paths

trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/CISupport/ews-build/steps.py (291059 => 291060)

--- trunk/Tools/CISupport/ews-build/steps.py	2022-03-09 19:59:42 UTC (rev 291059)
+++ trunk/Tools/CISupport/ews-build/steps.py	2022-03-09 20:29:54 UTC (rev 291060)
@@ -191,6 +191,12 @@
 return -1
 return 0 if pr_sha == self.getProperty('github.head.sha', '?') else 1
 
+def _is_pr_blocked(self, pr_json):
+for label in (pr_json or {}).get('labels', {}):
+if label.get('name', '') == 'blocked':
+return 1
+return 0
+
 def should_send_email_for_pr(self, pr_number):
 pr_json = self.get_pr_json(pr_number)
 if not pr_json:
@@ -204,7 +210,33 @@
 return False
 return True
 
+def modify_label(self, pr_number, label, repository_url=None, action=''):
+api_url = GitHub.api_url(repository_url)
+if not api_url:
+return False
+if action not in ('add', 'delete'):
+self._addToLog('stdio', "'{}' is not a valid label modifcation action".format(action))
+return False
 
+pr_label_url = '{}/issues/{}/labels'.format(api_url, pr_number)
+try:
+username, access_token = GitHub.credentials()
+auth = HTTPBasicAuth(username, access_token) if username and access_token else None
+response = requests.request(
+'POST' if action == 'add' else 'DELETE',
+pr_label_url, timeout=60, auth=auth,
+headers=dict(Accept='application/vnd.github.v3+json'),
+json=dict(labels=[label]),
+)
+if response.status_code // 100 != 2:
+self._addToLog('stdio', "Unable to {} '{}' label on PR {}. Unexpected response code from GitHub: {}".format(action, label, pr_number, response.status_code))
+return False
+except Exception as e:
+self._addToLog('stdio', "Error in {}ing '{}' label on PR {}".format(action, label, pr_number))
+return False
+return True
+
+
 class ShellMixin(object):
 WINDOWS_SHELL_PLATFORMS = ['wincairo']
 
@@ -1293,7 +1325,12 @@
 self.skip_build('Hash {} on PR {} is outdated'.format(self.getProperty('github.head.sha', '?')[:HASH_LENGTH_TO_DISPLAY], pr_number))
 return False
 
-if obsolete == -1 or pr_closed == -1:
+blocked = self._is_pr_blocked(pr_json) if self.verifyReviewDenied else 0
+if blocked == 1:
+self.skip_build("PR {} has been marked as 'blocked'".format(pr_number))
+return False
+
+if -1 in (obsolete, pr_closed, blocked):
 self.finished(WARNINGS)
 return False
 
@@ -1435,7 +1472,48 @@
 def doStepIf(self, step):
 return self.getProperty('patch_id', False)
 
+def hideStepIf(self, results, step):
+return not self.doStepIf(step)
 
+
+class BlockPullRequest(buildstep.BuildStep, GitHubMixin):
+name = 'block-pull-request'
+
+@defer.inlineCallbacks
+def _addToLog(self, logName, message):
+try:
+log = self.getLog(logName)
+except KeyError:
+log = yield self.addLog(logName)
+log.addStdout(message)
+
+def start(self):
+pr_number = self.getProperty('github.number', '')
+build_finish_summary = self.getProperty('build_finish_summary', None)
+
+rc = SKIPPED
+if CURRENT_HOSTNAME == EWS_BUILD_HOSTNAME:
+rc = SUCCESS if self.modify_label(pr_number, 'blocked', repository_url=self.getProperty('repository', '')) else FAILURE
+self.finished(rc)
+if build_finish_summary:
+self.build.buildFinished([build_finish_summary], FAILURE)
+return None
+
+def getResultSummary(self):
+if self.results == SUCCESS:
+return {'step': 'Added blocked label pull request'}
+elif self.results == SKIPPED:
+

[webkit-changes] [291059] trunk/LayoutTests

[matteo_flores]

Title: [291059] trunk/LayoutTests








Revision 291059
Author matteo_flo...@apple.com
Date 2022-03-09 11:59:42 -0800 (Wed, 09 Mar 2022)


Log Message
[ iOS ] 2 imported/w3c/web-platform-tests/content-security-policy/connect-src/* tests are flaky text failures
https://bugs.webkit.org/show_bug.cgi?id=237603

Unreviewed test gardening.

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (291058 => 291059)

--- trunk/LayoutTests/ChangeLog	2022-03-09 19:48:55 UTC (rev 291058)
+++ trunk/LayoutTests/ChangeLog	2022-03-09 19:59:42 UTC (rev 291059)
@@ -1,5 +1,14 @@
 2022-03-09  Matteo Flores  
 
+[ iOS ] 2 imported/w3c/web-platform-tests/content-security-policy/connect-src/* tests are flaky text failures
+https://bugs.webkit.org/show_bug.cgi?id=237603
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+
+2022-03-09  Matteo Flores  
+
 [iOS] Hard link AVPictureInPictureController
 https://bugs.webkit.org/show_bug.cgi?id=237227
 


Modified: trunk/LayoutTests/platform/ios/TestExpectations (291058 => 291059)

--- trunk/LayoutTests/platform/ios/TestExpectations	2022-03-09 19:48:55 UTC (rev 291058)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2022-03-09 19:59:42 UTC (rev 291059)
@@ -3411,6 +3411,10 @@
 fast/text/design-system-ui-15.html [ Pass ]
 fast/text/design-system-ui-16.html [ Pass ]
 
+# webkit.org/b/237603 
+imported/w3c/web-platform-tests/content-security-policy/connect-src/shared-worker-connect-src-allowed.sub.html [ Pass Failure ]
+imported/w3c/web-platform-tests/content-security-policy/connect-src/shared-worker-connect-src-blocked.sub.html [ Pass Failure ]
+
 webkit.org/b/159755 fast/text/emoji-num-glyphs.html [ Pass ]
 
 # WPT css/css-pseudo import (webkit.org/b/235197)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291058] tags/Safari-614.1.5.9/

[repstein]

Title: [291058] tags/Safari-614.1.5.9/








Revision 291058
Author repst...@apple.com
Date 2022-03-09 11:48:55 -0800 (Wed, 09 Mar 2022)


Log Message
Tag Safari-614.1.5.9.

Added Paths

tags/Safari-614.1.5.9/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291057] trunk/Source/WebKit

[sihui_liu]

Title: [291057] trunk/Source/WebKit








Revision 291057
Author sihui_...@apple.com
Date 2022-03-09 11:43:46 -0800 (Wed, 09 Mar 2022)


Log Message
File System Access: disallows names that are not permitted by underlying file system
https://bugs.webkit.org/show_bug.cgi?id=237635
rdar://89291566

We use FileSystem::fileSystemRepresentation to convert input name to a name that is permitted in current file
system. This patch makes File System Access API to throw error if the input name does not match the converted
name.

Reviewed by Youenn Fablet.

* NetworkProcess/storage/FileSystemStorageHandle.cpp:
(WebKit::isValidFileName):
(WebKit::FileSystemStorageHandle::requestCreateHandle):
(WebKit::FileSystemStorageHandle::removeEntry):
(WebKit::FileSystemStorageHandle::move):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (291056 => 291057)

--- trunk/Source/WebKit/ChangeLog	2022-03-09 19:03:13 UTC (rev 291056)
+++ trunk/Source/WebKit/ChangeLog	2022-03-09 19:43:46 UTC (rev 291057)
@@ -1,3 +1,21 @@
+2022-03-09  Sihui Liu  
+
+File System Access: disallows names that are not permitted by underlying file system
+https://bugs.webkit.org/show_bug.cgi?id=237635
+rdar://89291566
+
+We use FileSystem::fileSystemRepresentation to convert input name to a name that is permitted in current file 
+system. This patch makes File System Access API to throw error if the input name does not match the converted 
+name. 
+
+Reviewed by Youenn Fablet.
+
+* NetworkProcess/storage/FileSystemStorageHandle.cpp:
+(WebKit::isValidFileName):
+(WebKit::FileSystemStorageHandle::requestCreateHandle):
+(WebKit::FileSystemStorageHandle::removeEntry):
+(WebKit::FileSystemStorageHandle::move):
+
 2022-03-09  Jon Lee  
 
 Update feature flags for WebGL


Modified: trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp (291056 => 291057)

--- trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp	2022-03-09 19:03:13 UTC (rev 291056)
+++ trunk/Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp	2022-03-09 19:43:46 UTC (rev 291057)
@@ -91,9 +91,13 @@
 return m_path == path;
 }
 
-static bool isValidFileName(const String& name)
+static bool isValidFileName(const String& directory, const String& name)
 {
-return !name.isEmpty() && name != "." && name != ".." && !name.contains(pathSeparator);
+// https://wicg.github.io/file-system-access/#valid-file-name
+if (name.isEmpty() || (name == ".") || (name == "..") || name.contains(pathSeparator))
+return false;
+
+return FileSystem::pathFileName(FileSystem::pathByAppendingComponent(directory, name)) == name;
 }
 
 Expected FileSystemStorageHandle::requestCreateHandle(IPC::Connection::UniqueID connection, Type type, String&& name, bool createIfNecessary)
@@ -104,8 +108,7 @@
 if (!m_manager)
 return makeUnexpected(FileSystemStorageError::Unknown);
 
-// https://wicg.github.io/file-system-access/#valid-file-name
-if (!isValidFileName(name))
+if (!isValidFileName(m_path, name))
 return makeUnexpected(FileSystemStorageError::InvalidName);
 
 auto path = FileSystem::pathByAppendingComponent(m_path, name);
@@ -127,7 +130,7 @@
 if (m_type != Type::Directory)
 return FileSystemStorageError::TypeMismatch;
 
-if (!isValidFileName(name))
+if (!isValidFileName(m_path, name))
 return FileSystemStorageError::InvalidName;
 
 auto path = FileSystem::pathByAppendingComponent(m_path, name);
@@ -248,7 +251,7 @@
 if (path.isEmpty())
 return FileSystemStorageError::Unknown;
 
-if (!isValidFileName(newName))
+if (!isValidFileName(path, newName))
 return FileSystemStorageError::InvalidName;
 
 auto destinationPath = FileSystem::pathByAppendingComponent(path, newName);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291056] trunk/Source/WebKit

[jonlee]

Title: [291056] trunk/Source/WebKit








Revision 291056
Author jon...@apple.com
Date 2022-03-09 11:03:13 -0800 (Wed, 09 Mar 2022)


Log Message
Update feature flags for WebGL
https://bugs.webkit.org/show_bug.cgi?id=237666
rdar://problem/90040981

Reviewed by Geoffrey Garen.

* FeatureFlags/WebKit-appletvos.plist:
* FeatureFlags/WebKit-ios.plist:
* FeatureFlags/WebKit-watchos.plist:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist
trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist
trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist




Diff

Modified: trunk/Source/WebKit/ChangeLog (291055 => 291056)

--- trunk/Source/WebKit/ChangeLog	2022-03-09 18:40:23 UTC (rev 291055)
+++ trunk/Source/WebKit/ChangeLog	2022-03-09 19:03:13 UTC (rev 291056)
@@ -1,3 +1,15 @@
+2022-03-09  Jon Lee  
+
+Update feature flags for WebGL
+https://bugs.webkit.org/show_bug.cgi?id=237666
+rdar://problem/90040981
+
+Reviewed by Geoffrey Garen.
+
+* FeatureFlags/WebKit-appletvos.plist:
+* FeatureFlags/WebKit-ios.plist:
+* FeatureFlags/WebKit-watchos.plist:
+
 2022-03-09  Simon Fraser  
 
 Move RemoteLayerBackingStore::Buffer.isVolatile into ImageBufferBackend


Modified: trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist (291055 => 291056)

--- trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist	2022-03-09 18:40:23 UTC (rev 291055)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist	2022-03-09 19:03:13 UTC (rev 291056)
@@ -35,7 +35,7 @@
 	gpu_process_webgl
 	
 		Enabled
-		
+		
 	
 	gpu_process_webrtc
 	


Modified: trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist (291055 => 291056)

--- trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist	2022-03-09 18:40:23 UTC (rev 291055)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist	2022-03-09 19:03:13 UTC (rev 291056)
@@ -35,7 +35,7 @@
 	gpu_process_webgl
 	
 		Enabled
-		
+		
 	
 	gpu_process_webrtc
 	


Modified: trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist (291055 => 291056)

--- trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist	2022-03-09 18:40:23 UTC (rev 291055)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist	2022-03-09 19:03:13 UTC (rev 291056)
@@ -35,7 +35,7 @@
 	gpu_process_webgl
 	
 		Enabled
-		
+		
 	
 	gpu_process_webrtc
 	






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291055] trunk

[matteo_flores]

Title: [291055] trunk








Revision 291055
Author matteo_flo...@apple.com
Date 2022-03-09 10:40:23 -0800 (Wed, 09 Mar 2022)


Log Message
[iOS] Hard link AVPictureInPictureController
https://bugs.webkit.org/show_bug.cgi?id=237227

Unreviewed test gardening.

* platform/ipad/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ipad/TestExpectations
trunk/metadata/contributors.json




Diff

Modified: trunk/LayoutTests/ChangeLog (291054 => 291055)

--- trunk/LayoutTests/ChangeLog	2022-03-09 18:32:14 UTC (rev 291054)
+++ trunk/LayoutTests/ChangeLog	2022-03-09 18:40:23 UTC (rev 291055)
@@ -1,3 +1,12 @@
+2022-03-09  Matteo Flores  
+
+[iOS] Hard link AVPictureInPictureController
+https://bugs.webkit.org/show_bug.cgi?id=237227
+
+Unreviewed test gardening.
+
+* platform/ipad/TestExpectations:
+
 2022-03-09  Jon Lee  
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/ipad/TestExpectations (291054 => 291055)

--- trunk/LayoutTests/platform/ipad/TestExpectations	2022-03-09 18:32:14 UTC (rev 291054)
+++ trunk/LayoutTests/platform/ipad/TestExpectations	2022-03-09 18:40:23 UTC (rev 291055)
@@ -96,6 +96,18 @@
 
 webkit.org/b/231635 [ Release ] editing/selection/ios/scroll-to-reveal-selection-when-showing-software-keyboard.html [ Timeout ]
 
+#webkit.org/b/237227 These 10 picture in picture tests are failing on iPad
+media/picture-in-picture/picture-in-picture-api-css-selector.html [ Timeout ]
+media/picture-in-picture/picture-in-picture-api-enter-pip-1.html [ Failure ]
+media/picture-in-picture/picture-in-picture-api-enter-pip-2.html [ Failure ]
+media/picture-in-picture/picture-in-picture-api-enter-pip-3.html [ Failure ]
+media/picture-in-picture/picture-in-picture-api-enter-pip-4.html [ Failure ]
+media/picture-in-picture/picture-in-picture-api-events.html [ Timeout ]
+media/picture-in-picture/picture-in-picture-api-exit-pip-1.html [ Timeout ]
+media/picture-in-picture/picture-in-picture-api-pip-window.html [ Failure ]
+media/picture-in-picture/picture-in-picture-window-aspect-ratio.html [ Failure ]
+platform/ipad/media/modern-media-controls/pip-support/pip-support-enabled.html [ Failure ]
+
 media/picture-in-picture [ Pass ]
 media/remove-video-element-in-pip-from-document.html [ Pass ]
 


Modified: trunk/metadata/contributors.json (291054 => 291055)

--- trunk/metadata/contributors.json	2022-03-09 18:32:14 UTC (rev 291054)
+++ trunk/metadata/contributors.json	2022-03-09 18:40:23 UTC (rev 291055)
@@ -4727,6 +4727,17 @@
},
{
   "emails" : [
+ "matteo_flo...@apple.com"
+  ],
+  "github" : "Smackteo",
+  "name" : "Matteo Flores",
+  "nicks" : [
+ "MatteoF"
+  ],
+  "status" : "committer"
+   },
+   {
+  "emails" : [
  "mvujo...@adobe.com",
  "maxvujo...@gmail.com"
   ],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291054] trunk

[graouts]

Title: [291054] trunk








Revision 291054
Author grao...@webkit.org
Date 2022-03-09 10:32:14 -0800 (Wed, 09 Mar 2022)


Log Message
[css-lists] css/css-lists/inherit-overwrites.html and css/css-lists/li-counter-increment-computed-style.html are unique failures
https://bugs.webkit.org/show_bug.cgi?id=237642

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-lists/inherit-overwrites-expected.txt:
* web-platform-tests/css/css-lists/li-counter-increment-computed-style-expected.txt:
* web-platform-tests/html/rendering/non-replaced-elements/lists/lists-styles-expected.txt:

Source/WebCore:

A std::nullopt means the property isn't set, not that it shoudl be 0.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::counterToCSSValue):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-lists/inherit-overwrites-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-lists/li-counter-increment-computed-style-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/lists/lists-styles-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291053 => 291054)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 18:16:03 UTC (rev 291053)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 18:32:14 UTC (rev 291054)
@@ -1,3 +1,14 @@
+2022-03-09  Antoine Quint  
+
+[css-lists] css/css-lists/inherit-overwrites.html and css/css-lists/li-counter-increment-computed-style.html are unique failures
+https://bugs.webkit.org/show_bug.cgi?id=237642
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/css/css-lists/inherit-overwrites-expected.txt:
+* web-platform-tests/css/css-lists/li-counter-increment-computed-style-expected.txt:
+* web-platform-tests/html/rendering/non-replaced-elements/lists/lists-styles-expected.txt:
+
 2022-03-09  Antti Koivisto  
 
 [CSS Container Queries] Remove size() function syntax


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-lists/inherit-overwrites-expected.txt (291053 => 291054)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-lists/inherit-overwrites-expected.txt	2022-03-09 18:16:03 UTC (rev 291053)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-lists/inherit-overwrites-expected.txt	2022-03-09 18:32:14 UTC (rev 291054)
@@ -1,4 +1,4 @@
 
-FAIL Inheritance of counter-reset replaces existing value assert_equals: expected "second 0 first 1" but got "second 0 fifth 0 first 1"
-FAIL Inheritance of counter-increment replaces existing value assert_equals: expected "second 2 first 0" but got "second 2 fourth 0 first 0"
+PASS Inheritance of counter-reset replaces existing value
+PASS Inheritance of counter-increment replaces existing value
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-lists/li-counter-increment-computed-style-expected.txt (291053 => 291054)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-lists/li-counter-increment-computed-style-expected.txt	2022-03-09 18:16:03 UTC (rev 291053)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-lists/li-counter-increment-computed-style-expected.txt	2022-03-09 18:32:14 UTC (rev 291054)
@@ -5,5 +5,5 @@
 Explicit and redundant list-item counter.
 Other counter.
 
-FAIL list-item counter-increment shouldn't be visible from computed style assert_equals: Inherited expected "none" but got ""
+PASS list-item counter-increment shouldn't be visible from computed style
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/lists/lists-styles-expected.txt (291053 => 291054)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/lists/lists-styles-expected.txt	2022-03-09 18:16:03 UTC (rev 291053)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/lists/lists-styles-expected.txt	2022-03-09 18:32:14 UTC (rev 291054)
@@ -163,9 +163,9 @@
 - counter-set
 FAIL 
 - counter-reset assert_equals: expected "list-item 0" but got "none"
-FAIL 
-- counter-increment assert_equals: expected "list-item 0" but got "none"
 PASS 
+- counter-increment
+PASS 
 - text-align
 PASS  (in ) - display
 PASS  (in ) - margin-top
@@ -205,9 +205,9 @@
 - counter-set
 FAIL 
 - counter-reset assert_equals: expected "list-item 0" but got "none"
-FAIL 
-- counter-increment assert_equals: expected "list-item 0" but got "none"
 PASS 
+- counter-increment
+PASS 
 - text-align
 PASS  (in ) - display
 PASS  (in ) - margin-top
@@ -247,9 +247,9 @@
 - counter-set
 FAIL 
 - counter-reset assert_equals: expected "list-item 0" but got "none"
-FAIL 
-- counter-increment assert_equals: expected "list-item 0" but got "none"
 

[webkit-changes] [291053] trunk/Source

[simon . fraser]

Title: [291053] trunk/Source








Revision 291053
Author simon.fra...@apple.com
Date 2022-03-09 10:16:03 -0800 (Wed, 09 Mar 2022)


Log Message
Move RemoteLayerBackingStore::Buffer.isVolatile into ImageBufferBackend
https://bugs.webkit.org/show_bug.cgi?id=237631

Reviewed by Tim Horton.
Source/WebCore:

'isVolatile' is a property of a specific image buffer, so it makes more sense to have it in
ImageBuffer[Backend] than RemoteLayerBackingStore. This also allows GPU Process code to
maintain volatility state in the web process, which reduces the amount of IPC needed when
making the front buffer non-volatile before display.

So ImageBufferBackend gets volatilityState()/setVolatilityState(), accessed via ImageBuffer.
This state is maintained by RemoteRenderingBackendProxy for remote buffers. We set the state
to volatile when we receive the IPC reply for markSurfacesVolatile(), which requires
changing the reply to list buffers for which making volatile was successful.

RemoteLayerWithRemoteRenderingBackingStoreCollection::makeFrontBufferNonVolatile() can now
early return when the buffer is already non-volatile, and we have a backend handle (recall
that we clear backend handles when trying to make a buffer volatile).

* platform/graphics/ConcreteImageBuffer.h:
* platform/graphics/ImageBuffer.h:
* platform/graphics/ImageBufferBackend.h:
(WebCore::ImageBufferBackend::volatilityState const):
(WebCore::ImageBufferBackend::setVolatilityState):
* platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp:
(WebCore::ImageBufferIOSurfaceBackend::setVolatile):
(WebCore::ImageBufferIOSurfaceBackend::setNonVolatile):
(WebCore::ImageBufferIOSurfaceBackend::volatilityState const):
(WebCore::ImageBufferIOSurfaceBackend::setVolatilityState):
* platform/graphics/cg/ImageBufferIOSurfaceBackend.h:

Source/WebKit:

'isVolatile' is a property of a specific image buffer, so it makes more sense to have it in
ImageBuffer[Backend] than RemoteLayerBackingStore. This also allows GPU Process code to
maintain volatility state in the web process, which reduces the amount of IPC needed when
making the front buffer non-volatile before display.

So ImageBufferBackend gets volatilityState()/setVolatilityState(), accessed via ImageBuffer.
This state is maintained by RemoteRenderingBackendProxy for remote buffers. We set the state
to volatile when we receive the IPC reply for markSurfacesVolatile(), which requires
changing the reply to list buffers for which making volatile was successful.

RemoteLayerWithRemoteRenderingBackingStoreCollection::makeFrontBufferNonVolatile() can now
early return when the buffer is already non-volatile, and we have a backend handle (recall
that we clear backend handles when trying to make a buffer volatile).

* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::markSurfacesVolatile):
* GPUProcess/graphics/RemoteRenderingBackend.h:
* GPUProcess/graphics/RemoteRenderingBackend.messages.in:
* Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applySwappedBuffers):
(WebKit::RemoteLayerBackingStore::setBufferVolatile):
(WebKit::RemoteLayerBackingStore::setBufferNonVolatile):
(WebKit::RemoteLayerBackingStore::didMakeFrontBufferNonVolatile):
(WebKit::RemoteLayerBackingStore::Buffer::discard):
* Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm:
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::RemoteLayerWithRemoteRenderingBackingStoreCollection):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::makeFrontBufferNonVolatile):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::collectBackingStoreBufferIdentifiersToMarkVolatile):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::sendMarkBuffersVolatile): Call the completion handler inside the callback.
* WebProcess/GPU/graphics/ImageBufferBackendHandleSharing.h:
(WebKit::ImageBufferBackendHandleSharing::hasBackendHandle const):
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::swapToValidFrontBuffer):
(WebKit::RemoteRenderingBackendProxy::markSurfaceNonVolatile):
(WebKit::RemoteRenderingBackendProxy::markSurfacesVolatile):
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
* WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp:
(WebKit::ImageBufferRemoteIOSurfaceBackend::createBackendHandle const):
(WebKit::ImageBufferRemoteIOSurfaceBackend::hasBackendHandle const):
* WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebCore/platform/graphics/ImageBufferBackend.h
trunk/Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageBufferIOSurfaceBackend.h

[webkit-changes] [291052] trunk/LayoutTests

[jonlee]

Title: [291052] trunk/LayoutTests








Revision 291052
Author jon...@apple.com
Date 2022-03-09 10:13:10 -0800 (Wed, 09 Mar 2022)


Log Message
Unreviewed gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (291051 => 291052)

--- trunk/LayoutTests/ChangeLog	2022-03-09 17:47:33 UTC (rev 291051)
+++ trunk/LayoutTests/ChangeLog	2022-03-09 18:13:10 UTC (rev 291052)
@@ -1,3 +1,9 @@
+2022-03-09  Jon Lee  
+
+Unreviewed gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2022-03-09  Youenn Fablet  
 
 WebRTC decoded frames are not correctly rotated in case GPU Process DOM rendering flag is set to true


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (291051 => 291052)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-03-09 17:47:33 UTC (rev 291051)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2022-03-09 18:13:10 UTC (rev 291052)
@@ -2227,7 +2227,7 @@
 http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html [ Pass Failure ]
 
 # Test failures from turning GPU Process on by default
-webkit.org/b/234536 webxr/high-performance.html
+webkit.org/b/234536 webxr/high-performance.html [ Failure ]
 webkit.org/b/234536 webgl/1.0.3/conformance/state/gl-object-get-calls.html [ Timeout ]
 
 # webkit.org/b/237346 REGRESSION(r290539): [ iOS ] 2X http/wpt/webauthn/public-key-credential-create-failure-local (layout-tests) are constant text failures






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291051] trunk/Source

[youenn]

Title: [291051] trunk/Source








Revision 291051
Author you...@apple.com
Date 2022-03-09 09:47:33 -0800 (Wed, 09 Mar 2022)


Log Message
Allow to pass webrtc video frame buffers through RealtimeMediaSource based pipelines
https://bugs.webkit.org/show_bug.cgi?id=236131


Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Update routines to take VideoFrameBuffer instead of VideoFrame.
Fix bugs in handling of YUV conversion libwebrtc routines.

* Configurations/libwebrtc.iOS.exp:
* Configurations/libwebrtc.iOSsim.exp:
* Configurations/libwebrtc.mac.exp:
* Source/webrtc/sdk/WebKit/WebKitUtilities.h:
* Source/webrtc/sdk/WebKit/WebKitUtilities.mm:

Source/WebCore:

Introduce VideoFrameLibWebRTC as a wrapper to libwebrtc video frame buffer.
In case we send VideoFrameLibWebRTC through RealtimeOutgoingVideoSourceCocoa, directly send the video frame buffer.
When receiving libwebrtc video frame buffers in RealtimeIncomingVideoSourceCocoa, make use of VideoFrameLibWebRTC to delay conversion of the video frame buffer in a CVPixelBufferRef.
In most cases, the conversion is unneeded as the video frame buffer will be used for rendering and will be copied to shared memory through SharedVideoFrameWriter.
Fix bugs in handling of YUV conversion libwebrtc routines.
Minor refactoring to have a default asVideoFrameCV method implementatin in VideoFrame.

Covered by existing tests.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* platform/VideoFrame.cpp:
* platform/VideoFrame.h:
* platform/cocoa/SharedVideoFrameInfo.h:
* platform/cocoa/SharedVideoFrameInfo.mm:
* platform/mediastream/libwebrtc/VideoFrameLibWebRTC.cpp: Added.
* platform/mediastream/libwebrtc/VideoFrameLibWebRTC.h: Added.
* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h:
* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
* platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:

Source/WebKit:

Add optimization support for VideoFrameLibWebRTC writing into shared memory.
This removes the need to convert the webrtc video frame into a CVPixelBuffer, just to send it to GPUProcess for rendering.

* GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:
* WebProcess/GPU/media/RemoteVideoFrameProxy.h:
* WebProcess/GPU/webrtc/SharedVideoFrame.cpp:
* WebProcess/GPU/webrtc/SharedVideoFrame.h:

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp
trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitUtilities.mm
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/VideoFrame.cpp
trunk/Source/WebCore/platform/VideoFrame.h
trunk/Source/WebCore/platform/cocoa/SharedVideoFrameInfo.h
trunk/Source/WebCore/platform/cocoa/SharedVideoFrameInfo.mm
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.h
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm
trunk/Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/media/RemoteVideoFrameProxy.h
trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SharedVideoFrame.h


Added Paths

trunk/Source/WebCore/platform/mediastream/libwebrtc/VideoFrameLibWebRTC.cpp
trunk/Source/WebCore/platform/mediastream/libwebrtc/VideoFrameLibWebRTC.h




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (291050 => 291051)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2022-03-09 15:58:14 UTC (rev 291050)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2022-03-09 17:47:33 UTC (rev 291051)
@@ -1,3 +1,20 @@
+2022-03-09  Youenn Fablet  
+
+Allow to pass webrtc video frame buffers through RealtimeMediaSource based pipelines
+https://bugs.webkit.org/show_bug.cgi?id=236131
+
+
+Reviewed by Eric Carlson.
+
+Update routines to take VideoFrameBuffer instead of VideoFrame.
+Fix bugs in handling of YUV conversion libwebrtc routines.
+
+* Configurations/libwebrtc.iOS.exp:
+* Configurations/libwebrtc.iOSsim.exp:
+* Configurations/libwebrtc.mac.exp:
+* Source/webrtc/sdk/WebKit/WebKitUtilities.h:
+* Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
+
 2022-03-07  Alex Christensen  
 
 Unreviewed, reverting r290966.


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp (291050 

[webkit-changes] [291050] trunk/Tools

[jbedard]

Title: [291050] trunk/Tools








Revision 291050
Author jbed...@apple.com
Date 2022-03-09 07:58:14 -0800 (Wed, 09 Mar 2022)


Log Message
[git-webkit] Extract revision from `git svn dcommit` (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=236849


Unreviewed follow-up fix.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
(Land.main): Only capture stdout.

Canonical link: https://commits.webkit.org/248224@main

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/libraries/webkitscmpy/setup.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py




Diff

Modified: trunk/Tools/ChangeLog (291049 => 291050)

--- trunk/Tools/ChangeLog	2022-03-09 15:25:40 UTC (rev 291049)
+++ trunk/Tools/ChangeLog	2022-03-09 15:58:14 UTC (rev 291050)
@@ -1,3 +1,16 @@
+2022-03-09  Jonathan Bedard  
+
+[git-webkit] Extract revision from `git svn dcommit` (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=236849
+
+
+Unreviewed follow-up fix.
+
+* Scripts/libraries/webkitscmpy/setup.py: Bump version.
+* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
+* Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:
+(Land.main): Only capture stdout.
+
 2022-03-09  Angelos Oikonomopoulos  
 
 [JSC] Make runner should only schedule tests on live remotes


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/setup.py (291049 => 291050)

--- trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-03-09 15:25:40 UTC (rev 291049)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/setup.py	2022-03-09 15:58:14 UTC (rev 291050)
@@ -29,7 +29,7 @@
 
 setup(
 name='webkitscmpy',
-version='4.3.12',
+version='4.3.13',
 description='Library designed to interact with git and svn repositories.',
 long_description=readme(),
 classifiers=[


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (291049 => 291050)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-03-09 15:25:40 UTC (rev 291049)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2022-03-09 15:58:14 UTC (rev 291050)
@@ -46,7 +46,7 @@
 "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `"
 )
 
-version = Version(4, 3, 12)
+version = Version(4, 3, 13)
 
 AutoInstall.register(Package('fasteners', Version(0, 15, 0)))
 AutoInstall.register(Package('jinja2', Version(2, 11, 3)))


Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py (291049 => 291050)

--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py	2022-03-09 15:25:40 UTC (rev 291049)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py	2022-03-09 15:58:14 UTC (rev 291050)
@@ -21,6 +21,7 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 import re
+import subprocess
 import sys
 import time
 
@@ -193,7 +194,12 @@
 sys.stderr.write("Failed to update subversion refs\n".format(target))
 return 1 if cls.revert_branch(repository, cls.REMOTE, target) else -1
 
-dcommit = run([repository.executable(), 'svn', 'dcommit'], cwd=repository.root_path, capture_output=True, encoding='utf-8')
+dcommit = run(
+[repository.executable(), 'svn', 'dcommit'],
+cwd=repository.root_path,
+stdout=subprocess.PIPE,
+encoding='utf-8',
+)
 if dcommit.returncode:
 sys.stderr.write(dcommit.stdout)
 sys.stderr.write(dcommit.stderr)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291049] trunk

[youenn]

Title: [291049] trunk








Revision 291049
Author you...@apple.com
Date 2022-03-09 07:25:40 -0800 (Wed, 09 Mar 2022)


Log Message
WebRTC decoded frames are not correctly rotated in case GPU Process DOM rendering flag is set to true
https://bugs.webkit.org/show_bug.cgi?id=237468


Reviewed by Eric Carlson.

Source/WebCore:

We were creating remote video frames at webrtc decoder level but at that level, we do not know yet the rotation and timestamps of the frame.
We need to set those values when the frame is exposed to RealtimeIncomingVideoSource.
Previous tests did not catch the regression as we were correctly computing the size of the video using the webrtc rotation and not the rotation from the frame.
We should probably migrate to RemoteVideoFrameProxy as a buffer wrapper so that we can easily create remote video frames from a RemoteVideoFrameProxy buffer.
In the meantime, we use const_cast in VideoFrame::initializeCharacteristics.

Covered by updated test.

* platform/VideoFrame.cpp:
* platform/VideoFrame.h:
* platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* webrtc/video-rotation.html:
Observe actual video frame rotation value.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webrtc/video-rotation.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/VideoFrame.cpp
trunk/Source/WebCore/platform/VideoFrame.h
trunk/Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (291048 => 291049)

--- trunk/LayoutTests/ChangeLog	2022-03-09 14:30:14 UTC (rev 291048)
+++ trunk/LayoutTests/ChangeLog	2022-03-09 15:25:40 UTC (rev 291049)
@@ -1,3 +1,14 @@
+2022-03-09  Youenn Fablet  
+
+WebRTC decoded frames are not correctly rotated in case GPU Process DOM rendering flag is set to true
+https://bugs.webkit.org/show_bug.cgi?id=237468
+
+
+Reviewed by Eric Carlson.
+
+* webrtc/video-rotation.html:
+Observe actual video frame rotation value.
+
 2022-03-08  Antoine Quint  
 
 [web-animations] font-family should support discrete animation


Modified: trunk/LayoutTests/webrtc/video-rotation.html (291048 => 291049)

--- trunk/LayoutTests/webrtc/video-rotation.html	2022-03-09 14:30:14 UTC (rev 291048)
+++ trunk/LayoutTests/webrtc/video-rotation.html	2022-03-09 15:25:40 UTC (rev 291049)
@@ -50,6 +50,27 @@
 });
 }
 
+async function waitForTrackRotation(track, angle, counter)
+{
+if (!window.internals)
+return;
+
+if (!counter) {
+internals.observeMediaStreamTrack(track);
+counter = 1;
+}
+
+await new Promise(resolve => setTimeout(resolve, 50));
+const value = await internals.mediaStreamTrackVideoFrameRotation()
+if (angle === value)
+return;
+
+if (++counter > 50)
+return Promise.reject("waitForTrackRotation timed out with value " + value + " while expecting " + angle);
+
+return waitForTrackRotation(track, angle, counter);
+}
+
 var track;
 promise_test((test) => {
 if (window.testRunner)
@@ -62,8 +83,6 @@
 
 createConnections((firstConnection) => {
 firstConnection.addTrack(track, localStream);
-if (window.internals)
-internals.applyRotationForOutgoingVideoSources(firstConnection);
 }, (secondConnection) => {
 secondConnection._ontrack_ = (trackEvent) => {
 resolve(trackEvent.streams[0]);
@@ -95,26 +114,30 @@
 await waitForVideoSize(localVideo, 240, 320);
 }, "Track is enabled and rotated, local video should not be black and should change size");
 
-promise_test((test) => {
+promise_test(async (test) => {
 if (window.internals)
 window.internals.setCameraMediaStreamTrackOrientation(track, 90);
 if (window.testRunner)
 testRunner.setMockCameraOrientation(90);
 
-return checkVideoBlack(false, remoteVideo, "canvas2").then(() => {
+await checkVideoBlack(false, remoteVideo, "canvas2").then(() => {
 return waitForVideoSize(remoteVideo, 240, 320);
 });
+
+await waitForTrackRotation(remoteVideo.srcObject.getVideoTracks()[0], 90);
 }, "Track is enabled and rotated, remote video should not be black and should change size");
 
-promise_test((test) => {
+promise_test(async (test) => {
 if (window.internals)
 window.internals.setCameraMediaStreamTrackOrientation(track, 180);
 if (window.testRunner)
 testRunner.setMockCameraOrientation(180);
 
-return checkVideoBlack(false, remoteVideo, "canvas3").then(() => {
+await checkVideoBlack(false, remoteVideo, "canvas3").then(() => {
 return waitForVideoSize(remoteVideo, 320, 240);
 });
+
+await 

[webkit-changes] [291048] trunk/Source

[Hironori . Fujii]

Title: [291048] trunk/Source








Revision 291048
Author hironori.fu...@sony.com
Date 2022-03-09 06:30:14 -0800 (Wed, 09 Mar 2022)


Log Message
[WinCairo] Improve WCTiledBacking and TextureMapperSparseBackingStore
https://bugs.webkit.org/show_bug.cgi?id=237355

Reviewed by Don Olmstead.

Source/WebCore:

* platform/graphics/texmap/TextureMapperSparseBackingStore.cpp:
(WebCore::TextureMapperSparseBackingStore::setSize):
(WebCore::TextureMapperSparseBackingStore::paintToTextureMapper):
(WebCore::TextureMapperSparseBackingStore::drawBorder):
(WebCore::TextureMapperSparseBackingStore::drawRepaintCounter):
(WebCore::TextureMapperSparseBackingStore::updateContents):
(WebCore::TextureMapperSparseBackingStore::removeTile):
(WebCore::TextureMapperSparseBackingStore::TextureMapperSparseBackingStore): Deleted.
(WebCore::TextureMapperSparseBackingStore::removeUncoveredTiles): Deleted.
(WebCore::TextureMapperSparseBackingStore::tileDimension const): Deleted.
* platform/graphics/texmap/TextureMapperSparseBackingStore.h:
* platform/graphics/texmap/TextureMapperTile.h:

Source/WebKit:

TextureMapperSparseBackingStore simply had a Vector to have all
tiles. If a web page had a very large layer, the vector was
extended to be able to keep all tiles, and it performed poorly.
Use a HashMap to keep tiles only in the coverage rect.

GraphicsLayerWC had only one dirty rect, and created a
ImageBuffer for all tiles to update. Change it to have one dirty
rect for one tile, and create a ImageBuffer for every dirty tile.

* GPUProcess/graphics/wc/WCScene.cpp:
(WebKit::WCScene::update):
* PlatformWin.cmake:
* WebProcess/WebPage/wc/DrawingAreaWC.cpp:
(WebKit::flushLayerImageBuffers):
* WebProcess/WebPage/wc/GraphicsLayerWC.cpp:
(WebKit::GraphicsLayerWC::setSize):
(WebKit::GraphicsLayerWC::recursiveCommitChanges):
* WebProcess/WebPage/wc/WCTileGrid.cpp: Added.
(WebKit::WCTileGrid::Tile::Tile):
(WebKit::WCTileGrid::Tile::addDirtyRect):
(WebKit::WCTileGrid::Tile::clearDirtyRect):
(WebKit::WCTileGrid::Tile::hasDirtyRect const):
(WebKit::WCTileGrid::setSize):
(WebKit::WCTileGrid::tileRectFromPixelRect):
(WebKit::WCTileGrid::tileSizeFromPixelSize):
(WebKit::WCTileGrid::tilePixelSize const):
(WebKit::WCTileGrid::addDirtyRect):
(WebKit::WCTileGrid::clearDirtyRects):
(WebKit::WCTileGrid::ensureTile):
(WebKit::WCTileGrid::setCoverageRect):
* WebProcess/WebPage/wc/WCTileGrid.h: Added.
(WebKit::WCTileGrid::Tile::willRemove const):
(WebKit::WCTileGrid::Tile::setWillRemove):
(WebKit::WCTileGrid::Tile::dirtyRect):
(WebKit::WCTileGrid::tiles):
* WebProcess/WebPage/wc/WCUpateInfo.h:
(WebKit::WCTileUpdate::encode const):
(WebKit::WCTileUpdate::decode):
(WebKit::WCLayerUpateInfo::encode const):
(WebKit::WCLayerUpateInfo::decode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperSparseBackingStore.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperSparseBackingStore.h
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperTile.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/wc/WCScene.cpp
trunk/Source/WebKit/PlatformWin.cmake
trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp
trunk/Source/WebKit/WebProcess/WebPage/wc/GraphicsLayerWC.cpp
trunk/Source/WebKit/WebProcess/WebPage/wc/WCUpateInfo.h


Added Paths

trunk/Source/WebKit/WebProcess/WebPage/wc/WCTileGrid.cpp
trunk/Source/WebKit/WebProcess/WebPage/wc/WCTileGrid.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (291047 => 291048)

--- trunk/Source/WebCore/ChangeLog	2022-03-09 13:44:20 UTC (rev 291047)
+++ trunk/Source/WebCore/ChangeLog	2022-03-09 14:30:14 UTC (rev 291048)
@@ -1,3 +1,23 @@
+2022-03-09  Fujii Hironori  
+
+[WinCairo] Improve WCTiledBacking and TextureMapperSparseBackingStore
+https://bugs.webkit.org/show_bug.cgi?id=237355
+
+Reviewed by Don Olmstead.
+
+* platform/graphics/texmap/TextureMapperSparseBackingStore.cpp:
+(WebCore::TextureMapperSparseBackingStore::setSize):
+(WebCore::TextureMapperSparseBackingStore::paintToTextureMapper):
+(WebCore::TextureMapperSparseBackingStore::drawBorder):
+(WebCore::TextureMapperSparseBackingStore::drawRepaintCounter):
+(WebCore::TextureMapperSparseBackingStore::updateContents):
+(WebCore::TextureMapperSparseBackingStore::removeTile):
+(WebCore::TextureMapperSparseBackingStore::TextureMapperSparseBackingStore): Deleted.
+(WebCore::TextureMapperSparseBackingStore::removeUncoveredTiles): Deleted.
+(WebCore::TextureMapperSparseBackingStore::tileDimension const): Deleted.
+* platform/graphics/texmap/TextureMapperSparseBackingStore.h:
+* platform/graphics/texmap/TextureMapperTile.h:
+
 2022-03-09  Antoine Quint  
 
 [web-animations] increase the max number of animatable properties


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperSparseBackingStore.cpp (291047 => 291048)

--- 

[webkit-changes] [291047] trunk/Source/WebCore

[graouts]

Title: [291047] trunk/Source/WebCore








Revision 291047
Author grao...@webkit.org
Date 2022-03-09 05:44:20 -0800 (Wed, 09 Mar 2022)


Log Message
[web-animations] increase the max number of animatable properties
https://bugs.webkit.org/show_bug.cgi?id=237651

Reviewed by Antti Koivisto.

We've run out of space in m_propertyToIdMap, the limit was 255.

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (291046 => 291047)

--- trunk/Source/WebCore/ChangeLog	2022-03-09 13:34:33 UTC (rev 291046)
+++ trunk/Source/WebCore/ChangeLog	2022-03-09 13:44:20 UTC (rev 291047)
@@ -1,3 +1,15 @@
+2022-03-09  Antoine Quint  
+
+[web-animations] increase the max number of animatable properties
+https://bugs.webkit.org/show_bug.cgi?id=237651
+
+Reviewed by Antti Koivisto.
+
+We've run out of space in m_propertyToIdMap, the limit was 255.
+
+* animation/CSSPropertyAnimation.cpp:
+(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
 2022-03-09  Antti Koivisto  
 
 [CSS Container Queries] Remove size() function syntax


Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (291046 => 291047)

--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2022-03-09 13:34:33 UTC (rev 291046)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2022-03-09 13:44:20 UTC (rev 291047)
@@ -2550,15 +2550,15 @@
 CSSPropertyAnimationWrapperMap();
 ~CSSPropertyAnimationWrapperMap() = delete;
 
-unsigned char& indexFromPropertyID(CSSPropertyID propertyID)
+unsigned short& indexFromPropertyID(CSSPropertyID propertyID)
 {
 return m_propertyToIdMap[propertyID - firstCSSProperty];
 }
 
 Vector> m_propertyWrappers;
-unsigned char m_propertyToIdMap[numCSSProperties];
+unsigned short m_propertyToIdMap[numCSSProperties];
 
-static const unsigned char cInvalidPropertyWrapperIndex = UCHAR_MAX;
+static const unsigned short cInvalidPropertyWrapperIndex = std::numeric_limits::max();
 
 friend class WTF::NeverDestroyed;
 };
@@ -2893,7 +2893,7 @@
 for (int i = 0; i < numCSSProperties; ++i)
 m_propertyToIdMap[i] = cInvalidPropertyWrapperIndex;
 
-COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < UCHAR_MAX, numberOfAnimatablePropertiesMustBeLessThanUCharMax);
+COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < std::numeric_limits::max(), numberOfAnimatablePropertiesMustBeLessThanUShrtMax);
 m_propertyWrappers.reserveInitialCapacity(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount);
 
 // First we put the non-shorthand property wrappers into the map, so the shorthand-building






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291046] trunk

[antti]

Title: [291046] trunk








Revision 291046
Author an...@apple.com
Date 2022-03-09 05:34:33 -0800 (Wed, 09 Mar 2022)


Log Message
[CSS Container Queries] Remove size() function syntax
https://bugs.webkit.org/show_bug.cgi?id=237639

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt:
* web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt:

Source/WebCore:

Per https://github.com/w3c/csswg-drafts/issues/6870

* css/ContainerQueryParser.cpp:
(WebCore::ContainerQueryParser::consumeContainerQuery):
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeSingleContainerName):

Also disallow strings as container names (they need to be identifiers).

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/ContainerQueryParser.cpp
trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291045 => 291046)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 13:31:01 UTC (rev 291045)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 13:34:33 UTC (rev 291046)
@@ -1,3 +1,13 @@
+2022-03-09  Antti Koivisto  
+
+[CSS Container Queries] Remove size() function syntax
+https://bugs.webkit.org/show_bug.cgi?id=237639
+
+Reviewed by Antoine Quint.
+
+* web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt:
+* web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt:
+
 2022-03-09  Antoine Quint  
 
 [web-animations] color-interpolation-filters should support discrete animation


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt (291045 => 291046)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt	2022-03-09 13:31:01 UTC (rev 291045)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt	2022-03-09 13:34:33 UTC (rev 291046)
@@ -24,7 +24,7 @@
 PASS (100px < width)
 PASS (100px < width < 200px)
 PASS foo(width)
-FAIL size(width) assert_equals: expected "" but got "true"
+PASS size(width)
 PASS (asdf)
 PASS (resolution > 100dpi)
 PASS (resolution: 150dpi)
@@ -50,6 +50,6 @@
 PASS Container selector: 50gil
 PASS Container selector: name(foo)
 PASS Container selector: type(inline-size)
-FAIL Container selector: "foo" assert_equals: expected 0 but got 1
-FAIL Container selector: "inherit" assert_equals: expected 0 but got 1
+PASS Container selector: "foo"
+PASS Container selector: "inherit"
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt (291045 => 291046)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt	2022-03-09 13:31:01 UTC (rev 291045)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt	2022-03-09 13:34:33 UTC (rev 291046)
@@ -12,10 +12,10 @@
 PASS e.style['container-name'] = "#fff" should not set the property value
 PASS e.style['container-name'] = "1px" should not set the property value
 PASS e.style['container-name'] = "default" should not set the property value
-FAIL e.style['container-name'] = "\"initial\"" should not set the property value assert_equals: expected "" but got "\"initial\""
-FAIL e.style['container-name'] = "\"inherit\"" should not set the property value assert_equals: expected "" but got "\"inherit\""
-FAIL e.style['container-name'] = "\"unset\"" should not set the property value assert_equals: expected "" but got "\"unset\""
-FAIL e.style['container-name'] = "\"revert\"" should not set the property value assert_equals: expected "" but got "\"revert\""
-FAIL e.style['container-name'] = "\"none\"" should not set the property value assert_equals: expected "" but got "\"none\""
-FAIL e.style['container-name'] = "\"foo\"" should not set the property value assert_equals: expected "" but got "\"foo\""
+PASS e.style['container-name'] = "\"initial\"" should not set the property value
+PASS e.style['container-name'] = "\"inherit\"" should not set the property value
+PASS e.style['container-name'] = "\"unset\"" should not set the property value
+PASS e.style['container-name'] = "\"revert\"" should not set the property value
+PASS e.style['container-name'] = "\"none\"" should not set the property value
+PASS e.style['container-name'] = 

[webkit-changes] [291045] trunk/Tools

[angelos]

Title: [291045] trunk/Tools








Revision 291045
Author ange...@igalia.com
Date 2022-03-09 05:31:01 -0800 (Wed, 09 Mar 2022)


Log Message
[JSC] Make runner should only schedule tests on live remotes
https://bugs.webkit.org/show_bug.cgi?id=237030

Reviewed by Adrian Perez de Castro.

The make runner does static scheduling of tests, i.e. it will
assign tests to all known remotes. In practice, this means that
even though the make runner participates in the retry loop, it
will always end up scheduling any tests that failed to run
(e.g. because the remote was down on startup or went away during
testing) on all remotes, including ones that are known to be down.

This patch makes it slightly more robust by introducing a liveness
check (getLiveRemoteHosts) before the static scheduling, i.e.
1. in the initial preparation of the tests to run (prepareArtifacts) and
2. in refreshExecution.

It reuses the command to get the number of processors as the
liveness check (it's a command we know currenly works in all
supported remotes), so flips numberOfProcessors inside-out.
While here, it adds getconf _NPROCESSORS_ONLN as a final attempt
to get the number of processors.

This does not mean that the make runner is now robust against
flaky remotes. At the very least, it's still missing an ssh
timeout (so it won't hang e.g. when hosts go away after the
initial connection is established) and child cleanup (e.g. when
bailing early from one remote in forEachRemote, it needs to kill
all children for other remotes, or we might end up retrying while
the old jobs are still running). But it's getting there.

Q: But isn't the GNU parallel runner much better suited for
handling flaky remotes?

A: Yes. However, the make runner is (somewhat) better at keeping
the remote CPUs busy with "fast" remotes, so we may still want to
use it when the remotes are both fast and stable enough. That
said, it still needs to be able to recover from the occasional
failed remote without producing false test failures.

* Scripts/run-jsc-stress-tests:
* Scripts/webkitruby/jsc-stress-test/executor.rb:
Make remoteHosts available to refreshExecution.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-jsc-stress-tests
trunk/Tools/Scripts/webkitruby/jsc-stress-test/executor.rb




Diff

Modified: trunk/Tools/ChangeLog (291044 => 291045)

--- trunk/Tools/ChangeLog	2022-03-09 13:29:13 UTC (rev 291044)
+++ trunk/Tools/ChangeLog	2022-03-09 13:31:01 UTC (rev 291045)
@@ -1,3 +1,49 @@
+2022-03-09  Angelos Oikonomopoulos  
+
+[JSC] Make runner should only schedule tests on live remotes
+https://bugs.webkit.org/show_bug.cgi?id=237030
+
+Reviewed by Adrian Perez de Castro.
+
+The make runner does static scheduling of tests, i.e. it will
+assign tests to all known remotes. In practice, this means that
+even though the make runner participates in the retry loop, it
+will always end up scheduling any tests that failed to run
+(e.g. because the remote was down on startup or went away during
+testing) on all remotes, including ones that are known to be down.
+
+This patch makes it slightly more robust by introducing a liveness
+check (getLiveRemoteHosts) before the static scheduling, i.e.
+1. in the initial preparation of the tests to run (prepareArtifacts) and
+2. in refreshExecution.
+
+It reuses the command to get the number of processors as the
+liveness check (it's a command we know currenly works in all
+supported remotes), so flips numberOfProcessors inside-out.
+While here, it adds getconf _NPROCESSORS_ONLN as a final attempt
+to get the number of processors.
+
+This does not mean that the make runner is now robust against
+flaky remotes. At the very least, it's still missing an ssh
+timeout (so it won't hang e.g. when hosts go away after the
+initial connection is established) and child cleanup (e.g. when
+bailing early from one remote in forEachRemote, it needs to kill
+all children for other remotes, or we might end up retrying while
+the old jobs are still running). But it's getting there.
+
+Q: But isn't the GNU parallel runner much better suited for
+handling flaky remotes?
+
+A: Yes. However, the make runner is (somewhat) better at keeping
+the remote CPUs busy with "fast" remotes, so we may still want to
+use it when the remotes are both fast and stable enough. That
+said, it still needs to be able to recover from the occasional
+failed remote without producing false test failures.
+
+* Scripts/run-jsc-stress-tests:
+* Scripts/webkitruby/jsc-stress-test/executor.rb:
+Make remoteHosts available to refreshExecution.
+
 2022-03-08  Jean-Yves Avenard  
 
 Have MediaFormatReader plugin use WebMParser directly


Modified: trunk/Tools/Scripts/run-jsc-stress-tests 

[webkit-changes] [291044] trunk/Source/WebCore

[Hironori . Fujii]

Title: [291044] trunk/Source/WebCore








Revision 291044
Author hironori.fu...@sony.com
Date 2022-03-09 05:29:13 -0800 (Wed, 09 Mar 2022)


Log Message
[WinCairo] SpatialNavigation.h(93): error C2365: 'WebCore::None': redefinition; previous definition was 'enumerator'
https://bugs.webkit.org/show_bug.cgi?id=237647

Unreviewed build fix.

Changed WebCore::RectsAlignment to an enum class.


* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::alignmentForRects):
(WebCore::distanceDataForNode):
* page/SpatialNavigation.h:
(WebCore::FocusCandidate::FocusCandidate):
(): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FocusController.cpp
trunk/Source/WebCore/page/SpatialNavigation.cpp
trunk/Source/WebCore/page/SpatialNavigation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (291043 => 291044)

--- trunk/Source/WebCore/ChangeLog	2022-03-09 13:01:55 UTC (rev 291043)
+++ trunk/Source/WebCore/ChangeLog	2022-03-09 13:29:13 UTC (rev 291044)
@@ -1,3 +1,22 @@
+2022-03-09  Fujii Hironori  
+
+[WinCairo] SpatialNavigation.h(93): error C2365: 'WebCore::None': redefinition; previous definition was 'enumerator'
+https://bugs.webkit.org/show_bug.cgi?id=237647
+
+Unreviewed build fix.
+
+Changed WebCore::RectsAlignment to an enum class.
+
+* page/FocusController.cpp:
+(WebCore::updateFocusCandidateIfNeeded):
+* page/SpatialNavigation.cpp:
+(WebCore::FocusCandidate::FocusCandidate):
+(WebCore::alignmentForRects):
+(WebCore::distanceDataForNode):
+* page/SpatialNavigation.h:
+(WebCore::FocusCandidate::FocusCandidate):
+(): Deleted.
+
 2022-03-09  Antoine Quint  
 
 [web-animations] color-interpolation-filters should support discrete animation


Modified: trunk/Source/WebCore/page/FocusController.cpp (291043 => 291044)

--- trunk/Source/WebCore/page/FocusController.cpp	2022-03-09 13:01:55 UTC (rev 291043)
+++ trunk/Source/WebCore/page/FocusController.cpp	2022-03-09 13:29:13 UTC (rev 291044)
@@ -972,7 +972,7 @@
 if (candidate.distance == maxDistance())
 return;
 
-if (candidate.isOffscreenAfterScrolling && candidate.alignment < Full)
+if (candidate.isOffscreenAfterScrolling && candidate.alignment < RectsAlignment::Full)
 return;
 
 if (closest.isNull()) {


Modified: trunk/Source/WebCore/page/SpatialNavigation.cpp (291043 => 291044)

--- trunk/Source/WebCore/page/SpatialNavigation.cpp	2022-03-09 13:01:55 UTC (rev 291043)
+++ trunk/Source/WebCore/page/SpatialNavigation.cpp	2022-03-09 13:29:13 UTC (rev 291044)
@@ -60,7 +60,7 @@
 , focusableNode(nullptr)
 , enclosingScrollableBox(nullptr)
 , distance(maxDistance())
-, alignment(None)
+, alignment(RectsAlignment::None)
 , isOffscreen(true)
 , isOffscreenAfterScrolling(true)
 {
@@ -96,15 +96,15 @@
 {
 // If we found a node in full alignment, but it is too far away, ignore it.
 if (areRectsMoreThanFullScreenApart(direction, curRect, targetRect, viewSize))
-return None;
+return RectsAlignment::None;
 
 if (areRectsFullyAligned(direction, curRect, targetRect))
-return Full;
+return RectsAlignment::Full;
 
 if (areRectsPartiallyAligned(direction, curRect, targetRect))
-return Partial;
+return RectsAlignment::Partial;
 
-return None;
+return RectsAlignment::None;
 }
 
 static inline bool isHorizontalMove(FocusDirection direction)
@@ -648,7 +648,7 @@
 if (areElementsOnSameLine(current, candidate)) {
 if ((direction == FocusDirection::Up && current.rect.y() > candidate.rect.y()) || (direction == FocusDirection::Down && candidate.rect.y() > current.rect.y())) {
 candidate.distance = 0;
-candidate.alignment = Full;
+candidate.alignment = RectsAlignment::Full;
 return;
 }
 }


Modified: trunk/Source/WebCore/page/SpatialNavigation.h (291043 => 291044)

--- trunk/Source/WebCore/page/SpatialNavigation.h	2022-03-09 13:01:55 UTC (rev 291043)
+++ trunk/Source/WebCore/page/SpatialNavigation.h	2022-03-09 13:29:13 UTC (rev 291044)
@@ -89,7 +89,7 @@
 // "Totally Aligned" elements are preferable candidates to move
 // focus to over "Partially Aligned" ones, that on its turns are
 // more preferable than "Not Aligned".
-enum RectsAlignment {
+enum class RectsAlignment {
 None = 0,
 Partial,
 Full
@@ -101,7 +101,7 @@
 , focusableNode(nullptr)
 , enclosingScrollableBox(nullptr)
 , distance(maxDistance())
-, alignment(None)
+, alignment(RectsAlignment::None)
 , isOffscreen(true)
 , isOffscreenAfterScrolling(true)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [291043] trunk

[graouts]

Title: [291043] trunk








Revision 291043
Author grao...@webkit.org
Date 2022-03-09 05:01:55 -0800 (Wed, 09 Mar 2022)


Log Message
[web-animations] color-interpolation-filters should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237637

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::colorInterpolationFilters const):
(WebCore::RenderStyle::setColorInterpolationFilters):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291042 => 291043)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 12:58:38 UTC (rev 291042)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 13:01:55 UTC (rev 291043)
@@ -1,3 +1,14 @@
+2022-03-09  Antoine Quint  
+
+[web-animations] color-interpolation-filters should support discrete animation
+https://bugs.webkit.org/show_bug.cgi?id=237637
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
 2022-03-08  Antoine Quint  
 
 [web-animations] clip-rule should support discrete animations


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (291042 => 291043)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 12:58:38 UTC (rev 291042)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 13:01:55 UTC (rev 291043)
@@ -139,6 +139,9 @@
 PASS color-interpolation (type: discrete) has testAccumulation function
 PASS color-interpolation: "auto" onto "linearrgb"
 PASS color-interpolation: "linearrgb" onto "auto"
+PASS color-interpolation-filters (type: discrete) has testAccumulation function
+PASS color-interpolation-filters: "linearrgb" onto "srgb"
+PASS color-interpolation-filters: "srgb" onto "linearrgb"
 PASS column-count (type: positiveInteger) has testAccumulation function
 PASS column-count: positive integer
 PASS column-count (type: discrete) has testAccumulation function


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt (291042 => 291043)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-09 12:58:38 UTC (rev 291042)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-09 13:01:55 UTC (rev 291043)
@@ -139,6 +139,9 @@
 PASS color-interpolation (type: discrete) has testAddition function
 PASS color-interpolation: "auto" onto "linearrgb"
 PASS color-interpolation: "linearrgb" onto "auto"
+PASS color-interpolation-filters (type: discrete) has testAddition function
+PASS color-interpolation-filters: "linearrgb" onto "srgb"
+PASS color-interpolation-filters: "srgb" onto "linearrgb"
 PASS column-count (type: positiveInteger) has testAddition function
 PASS column-count: positive integer
 PASS column-count (type: discrete) has testAddition function


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt (291042 => 291043)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt	2022-03-09 

[webkit-changes] [291042] trunk

[graouts]

Title: [291042] trunk








Revision 291042
Author grao...@webkit.org
Date 2022-03-09 04:58:38 -0800 (Wed, 09 Mar 2022)


Log Message
[web-animations] clip-rule should support discrete animations
https://bugs.webkit.org/show_bug.cgi?id=237609

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::clipRule const):
(WebCore::RenderStyle::setClipRule):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291041 => 291042)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 12:55:11 UTC (rev 291041)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 12:58:38 UTC (rev 291042)
@@ -1,5 +1,16 @@
 2022-03-08  Antoine Quint  
 
+[web-animations] clip-rule should support discrete animations
+https://bugs.webkit.org/show_bug.cgi?id=237609
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
+2022-03-08  Antoine Quint  
+
 [web-animations] background-blend-mode should support discrete animation
 https://bugs.webkit.org/show_bug.cgi?id=237607
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (291041 => 291042)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 12:55:11 UTC (rev 291041)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 12:58:38 UTC (rev 291042)
@@ -126,6 +126,9 @@
 PASS clip: "rect(10px, 10px, 10px, 10px)" onto "auto"
 PASS clip: "rect(10px, 10px, 10px, auto)" onto "rect(10px, 10px, 10px, 10px)"
 PASS clip: "rect(10px, 10px, 10px, 10px)" onto "rect(10px, 10px, 10px, auto)"
+PASS clip-rule (type: discrete) has testAccumulation function
+PASS clip-rule: "nonzero" onto "evenodd"
+PASS clip-rule: "evenodd" onto "nonzero"
 PASS color (type: color) has testAccumulation function
 FAIL color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"
 PASS color supports animating as color of #RGB


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt (291041 => 291042)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-09 12:55:11 UTC (rev 291041)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-09 12:58:38 UTC (rev 291042)
@@ -126,6 +126,9 @@
 PASS clip: "rect(10px, 10px, 10px, 10px)" onto "auto"
 PASS clip: "rect(10px, 10px, 10px, auto)" onto "rect(10px, 10px, 10px, 10px)"
 PASS clip: "rect(10px, 10px, 10px, 10px)" onto "rect(10px, 10px, 10px, auto)"
+PASS clip-rule (type: discrete) has testAddition function
+PASS clip-rule: "nonzero" onto "evenodd"
+PASS clip-rule: "evenodd" onto "nonzero"
 PASS color (type: color) has testAddition function
 FAIL color supports animating as color of rgb() with overflowed  from and to values assert_equals: The value should be rgb(255, 128, 255) at 500ms expected "rgb(255, 128, 255)" but got "rgb(192, 128, 192)"
 PASS color supports animating as color of #RGB


Modified: 

[webkit-changes] [291041] trunk

[graouts]

Title: [291041] trunk








Revision 291041
Author grao...@webkit.org
Date 2022-03-09 04:55:11 -0800 (Wed, 09 Mar 2022)


Log Message
[web-animations] background-blend-mode should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237607

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::backgroundBlendMode const):
(WebCore::RenderStyle::setBackgroundBlendMode):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291040 => 291041)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 12:52:33 UTC (rev 291040)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 12:55:11 UTC (rev 291041)
@@ -1,5 +1,16 @@
 2022-03-08  Antoine Quint  
 
+[web-animations] background-blend-mode should support discrete animation
+https://bugs.webkit.org/show_bug.cgi?id=237607
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
+2022-03-08  Antoine Quint  
+
 [web-animations] font-family should support discrete animation
 https://bugs.webkit.org/show_bug.cgi?id=237591
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (291040 => 291041)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 12:52:33 UTC (rev 291040)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 12:55:11 UTC (rev 291041)
@@ -22,6 +22,9 @@
 PASS background-color supports animating as color of #RGBa
 PASS background-color supports animating as color of rgba()
 PASS background-color supports animating as color of hsla()
+PASS background-blend-mode (type: discrete) has testAccumulation function
+PASS background-blend-mode: "screen" onto "multiply"
+PASS background-blend-mode: "multiply" onto "screen"
 PASS background-clip (type: discrete) has testAccumulation function
 PASS background-clip: "content-box" onto "padding-box"
 PASS background-clip: "padding-box" onto "content-box"


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt (291040 => 291041)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-09 12:52:33 UTC (rev 291040)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt	2022-03-09 12:55:11 UTC (rev 291041)
@@ -22,6 +22,9 @@
 PASS background-color supports animating as color of #RGBa
 PASS background-color supports animating as color of rgba()
 PASS background-color supports animating as color of hsla()
+PASS background-blend-mode (type: discrete) has testAddition function
+PASS background-blend-mode: "screen" onto "multiply"
+PASS background-blend-mode: "multiply" onto "screen"
 PASS background-clip (type: discrete) has testAddition function
 PASS background-clip: "content-box" onto "padding-box"
 PASS background-clip: "padding-box" onto "content-box"


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt (291040 => 291041)

--- 

[webkit-changes] [291039] trunk

[graouts]

Title: [291039] trunk








Revision 291039
Author grao...@webkit.org
Date 2022-03-09 04:45:26 -0800 (Wed, 09 Mar 2022)


Log Message
[web-animations] font-feature-settings should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237587

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* platform/graphics/FontTaggedSettings.cpp:
(WebCore::operator<<):
* platform/graphics/FontTaggedSettings.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontPalette):
(WebCore::RenderStyle::setFontFeatureSettings):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontFeatureSettings const):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/platform/graphics/FontTaggedSettings.cpp
trunk/Source/WebCore/platform/graphics/FontTaggedSettings.h
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291038 => 291039)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 12:43:36 UTC (rev 291038)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 12:45:26 UTC (rev 291039)
@@ -1,5 +1,17 @@
 2022-03-08  Antoine Quint  
 
+[web-animations] font-feature-settings should support discrete animation
+https://bugs.webkit.org/show_bug.cgi?id=237587
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
+2022-03-08  Antoine Quint  
+
 [web-animations] font-kerning should supporting discrete animation
 https://bugs.webkit.org/show_bug.cgi?id=237585
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt (291038 => 291039)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt	2022-03-09 12:43:36 UTC (rev 291038)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt	2022-03-09 12:45:26 UTC (rev 291039)
@@ -1,7 +1,7 @@
 
 FAIL Animation of font in ::marker assert_in_array: value "italic normal 500 expanded 15px/35px -webkit-standard" not in array ["italic small-caps 500 expanded 15px / 35px Ahem", "italic small-caps 500 expanded 15px/35px Ahem"]
 FAIL Animation of font-family in ::marker assert_equals: expected "Ahem" but got "-webkit-standard"
-FAIL Animation of font-feature-settings in ::marker assert_equals: expected "\"smcp\"" but got "normal"
+PASS Animation of font-feature-settings in ::marker
 PASS Animation of font-kerning in ::marker
 PASS Animation of font-size in ::marker
 FAIL Animation of font-size-adjust in ::marker assert_true: font-size-adjust doesn't seem to be supported in the computed style expected true got false


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (291038 => 291039)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 12:43:36 UTC (rev 291038)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt	2022-03-09 12:45:26 UTC (rev 291039)
@@ -221,6 

[webkit-changes] [291038] trunk/Source

[carlosgc]

Title: [291038] trunk/Source








Revision 291038
Author carlo...@webkit.org
Date 2022-03-09 04:43:36 -0800 (Wed, 09 Mar 2022)


Log Message
[GTK][WPE] Stop using the env var WEBKIT_INSPECTOR_SERVER to connect to the inspector
https://bugs.webkit.org/show_bug.cgi?id=237646

Reviewed by Adrian Perez de Castro.

Source/_javascript_Core:

Add RemoteInspector::s_inspectorServerAddress to keep the remote inspector server address instead of the
environment variable used to start the server.

* inspector/remote/RemoteInspector.h:
* inspector/remote/glib/RemoteInspectorGlib.cpp:
(Inspector::RemoteInspector::RemoteInspector): Only call start if s_inspectorServerAddress is not null.
(Inspector::RemoteInspector::start): Use s_inspectorServerAddress instead of querying the environment.

Source/WebKit:

Use it only in the UI process to start the server, but propagate the address to web process using creation
parameters.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const): Encode inspectorServerAddress.
(WebKit::WebProcessCreationParameters::decode): Decode inspectorServerAddress.
* Shared/WebProcessCreationParameters.h: Add inspectorServerAddress.
* UIProcess/API/glib/WebKitInitialize.cpp:
(WebKit::initializeRemoteInspectorServer): Set RemoteInspector::s_inspectorServerAddress if the server started
successfully.
* UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitializeWebProcess): Set inspectorServerAddress parameter from
RemoteInspector::s_inspectorServerAddress value.
* WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Set RemoteInspector::s_inspectorServerAddress from creation
parameter value.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h
trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit/UIProcess/API/glib/WebKitInitialize.cpp
trunk/Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
trunk/Source/WebKit/WebProcess/glib/WebProcessGLib.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (291037 => 291038)

--- trunk/Source/_javascript_Core/ChangeLog	2022-03-09 12:37:00 UTC (rev 291037)
+++ trunk/Source/_javascript_Core/ChangeLog	2022-03-09 12:43:36 UTC (rev 291038)
@@ -1,3 +1,18 @@
+2022-03-09  Carlos Garcia Campos  
+
+[GTK][WPE] Stop using the env var WEBKIT_INSPECTOR_SERVER to connect to the inspector
+https://bugs.webkit.org/show_bug.cgi?id=237646
+
+Reviewed by Adrian Perez de Castro.
+
+Add RemoteInspector::s_inspectorServerAddress to keep the remote inspector server address instead of the
+environment variable used to start the server.
+
+* inspector/remote/RemoteInspector.h:
+* inspector/remote/glib/RemoteInspectorGlib.cpp:
+(Inspector::RemoteInspector::RemoteInspector): Only call start if s_inspectorServerAddress is not null.
+(Inspector::RemoteInspector::start): Use s_inspectorServerAddress instead of querying the environment.
+
 2022-03-08  Robin Morisset  
 
 [WTF] LikelyDenseUnsignedIntegerSet::add can cause a reindexing of the entire bit vector with every call in the worst case


Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h (291037 => 291038)

--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h	2022-03-09 12:37:00 UTC (rev 291037)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h	2022-03-09 12:43:36 UTC (rev 291038)
@@ -121,6 +121,10 @@
 #if PLATFORM(COCOA)
 static void setNeedMachSandboxExtension(bool needExtension) { needMachSandboxExtension = needExtension; }
 #endif
+#if USE(GLIB)
+static void setInspectorServerAddress(CString&& address) { s_inspectorServerAddress = WTFMove(address); }
+static const CString& inspectorServerAddress() { return s_inspectorServerAddress; }
+#endif
 static void startDisabled();
 static RemoteInspector& singleton();
 friend class LazyNeverDestroyed;
@@ -247,6 +251,9 @@
 #if PLATFORM(COCOA)
 static std::atomic needMachSandboxExtension;
 #endif
+#if USE(GLIB)
+static CString s_inspectorServerAddress;
+#endif
 
 // Targets can be registered from any thread at any time.
 // Any target can send messages over the XPC connection.


Modified: trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp (291037 => 291038)

--- trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp	2022-03-09 12:37:00 UTC (rev 291037)
+++ trunk/Source/_javascript_Core/inspector/remote/glib/RemoteInspectorGlib.cpp	2022-03-09 12:43:36 UTC (rev 291038)
@@ -38,6 +38,8 @@
 
 namespace Inspector {
 
+CString RemoteInspector::s_inspectorServerAddress;
+
 RemoteInspector& RemoteInspector::singleton()
 

[webkit-changes] [291037] trunk

[graouts]

Title: [291037] trunk








Revision 291037
Author grao...@webkit.org
Date 2022-03-09 04:37:00 -0800 (Wed, 09 Mar 2022)


Log Message
[web-animations] font-kerning should supporting discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237585

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
* web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:

Source/WebCore:

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* platform/text/TextFlags.cpp: Added.
(WebCore::operator<<):
* platform/text/TextFlags.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setFontPalette):
(WebCore::RenderStyle::setFontKerning):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::fontKerning const):
* style/PropertyAllowlist.cpp:
(WebCore::Style::isValidMarkerStyleProperty):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/platform/text/TextFlags.h
trunk/Source/WebCore/rendering/style/RenderStyle.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/style/PropertyAllowlist.cpp


Added Paths

trunk/Source/WebCore/platform/text/TextFlags.cpp




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291036 => 291037)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 11:38:19 UTC (rev 291036)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-09 12:37:00 UTC (rev 291037)
@@ -1,3 +1,16 @@
+2022-03-08  Antoine Quint  
+
+[web-animations] font-kerning should supporting discrete animation
+https://bugs.webkit.org/show_bug.cgi?id=237585
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt:
+* web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
 2022-03-09  Antti Koivisto  
 
 [CSS Container Queries] Import updated WPTs


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt (291036 => 291037)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt	2022-03-09 11:38:19 UTC (rev 291036)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-expected.txt	2022-03-09 12:37:00 UTC (rev 291037)
@@ -2,7 +2,7 @@
 PASS Property font value 'italic small-caps 900 expanded 25px / 50px Ahem' in ::marker
 PASS Property font-family value 'Ahem' in ::marker
 PASS Property font-feature-settings value '"smcp"' in ::marker
-FAIL Property font-kerning value 'none' in ::marker assert_equals: expected "none" but got "auto"
+PASS Property font-kerning value 'none' in ::marker
 PASS Property font-size value '25px' in ::marker
 FAIL Property font-size-adjust value '1' in ::marker assert_true: font-size-adjust doesn't seem to be supported in the computed style expected true got false
 PASS Property font-stretch value 'expanded' in ::marker


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/marker-supported-properties-in-animation-expected.txt (291036 => 291037)

--- 

[webkit-changes] [291035] trunk/Source/WebCore

[commit-queue]

Title: [291035] trunk/Source/WebCore








Revision 291035
Author commit-qu...@webkit.org
Date 2022-03-09 00:36:52 -0800 (Wed, 09 Mar 2022)


Log Message
GraphicsContextGLCocoa manages EGL native displays manually
https://bugs.webkit.org/show_bug.cgi?id=237313

Patch by Kimmo Kinnunen  on 2022-03-09
Reviewed by Kenneth Russell.

ANGLE now keys the Metal EGL_DEFAULT_DISPLAY on the EGL_PLATFORM_ANGLE_TYPE_ANGLE.
This means that we do not need to use the default a native display for Metal and an
invented native display for OpenGL.

* platform/graphics/GraphicsTypesGL.h:
* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::platformInitialize):
(WebCore::GraphicsContextGLANGLE::releaseThreadResources):
* platform/graphics/angle/GraphicsContextGLANGLE.h:
* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
(WebCore::initializeEGLDisplay):
(WebCore::GraphicsContextGLCocoa::platformInitialize):
* platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
(WebCore::GraphicsContextGLTextureMapper::platformInitialize):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/GraphicsTypesGL.h
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.h
trunk/Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm
trunk/Source/WebCore/platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (291034 => 291035)

--- trunk/Source/WebCore/ChangeLog	2022-03-09 08:04:45 UTC (rev 291034)
+++ trunk/Source/WebCore/ChangeLog	2022-03-09 08:36:52 UTC (rev 291035)
@@ -1,3 +1,25 @@
+2022-03-09  Kimmo Kinnunen  
+
+GraphicsContextGLCocoa manages EGL native displays manually
+https://bugs.webkit.org/show_bug.cgi?id=237313
+
+Reviewed by Kenneth Russell.
+
+ANGLE now keys the Metal EGL_DEFAULT_DISPLAY on the EGL_PLATFORM_ANGLE_TYPE_ANGLE.
+This means that we do not need to use the default a native display for Metal and an
+invented native display for OpenGL.
+
+* platform/graphics/GraphicsTypesGL.h:
+* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
+(WebCore::GraphicsContextGLANGLE::platformInitialize):
+(WebCore::GraphicsContextGLANGLE::releaseThreadResources):
+* platform/graphics/angle/GraphicsContextGLANGLE.h:
+* platform/graphics/cocoa/GraphicsContextGLCocoa.mm:
+(WebCore::initializeEGLDisplay):
+(WebCore::GraphicsContextGLCocoa::platformInitialize):
+* platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:
+(WebCore::GraphicsContextGLTextureMapper::platformInitialize):
+
 2022-03-09  Youenn Fablet  
 
 Scope capture sources by page identifiers


Modified: trunk/Source/WebCore/platform/graphics/GraphicsTypesGL.h (291034 => 291035)

--- trunk/Source/WebCore/platform/graphics/GraphicsTypesGL.h	2022-03-09 08:04:45 UTC (rev 291034)
+++ trunk/Source/WebCore/platform/graphics/GraphicsTypesGL.h	2022-03-09 08:36:52 UTC (rev 291035)
@@ -67,10 +67,6 @@
 typedef unsigned GLuint;
 #endif
 
-using GCGLNativeDisplayType = int;
-
-inline constexpr GCGLNativeDisplayType gcGLDefaultDisplay = 0;
-
 inline constexpr size_t gcGLSpanDynamicExtent = std::numeric_limits::max();
 
 template


Modified: trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp (291034 => 291035)

--- trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp	2022-03-09 08:04:45 UTC (rev 291034)
+++ trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp	2022-03-09 08:36:52 UTC (rev 291035)
@@ -37,6 +37,7 @@
 #include "Logging.h"
 #include "NotImplemented.h"
 #include "PixelBuffer.h"
+#include "RuntimeApplicationChecks.h"
 #include 
 #include 
 #include 
@@ -57,6 +58,15 @@
 
 static Seconds maxFrameDuration = 5_s;
 
+// List of displays ever instantiated from EGL. When terminating all EGL resources, we need to
+// terminate all displays. However, we cannot ask EGL all the displays it has created.
+// We must know all the displays via this set.
+static HashSet& usedDisplays()
+{
+static NeverDestroyed> s_usedDisplays;
+return s_usedDisplays;
+}
+
 #if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
 static void wipeAlphaChannelFromPixels(int width, int height, unsigned char* pixels)
 {
@@ -89,6 +99,14 @@
 
 bool GraphicsContextGLANGLE::platformInitialize()
 {
+// EGL resources are only ever released if we run in process mode where EGL is used on host app threads, e.g. WK1
+// mode.
+static bool tracksUsedDisplays = !(isInWebProcess() || isInGPUProcess());
+if (tracksUsedDisplays) {
+// TODO: Move to ~GraphicsContextGLANGLE() when the function is moved to this file.
+ASSERT(m_displayObj);
+usedDisplays().add(m_displayObj);
+}
 return true;
 }
 
@@ -162,17 +180,9 @@
 ASSERT_NOT_REACHED(); // All resources