[webkit-changes] [292593] trunk/Source/WebKit
Title: [292593] trunk/Source/WebKit Revision 292593 Author j_pas...@apple.com Date 2022-04-07 22:40:06 -0700 (Thu, 07 Apr 2022) Log Message [WebAuthn] Support all CTAP transports and remove gesture requirement for virtual authenticators https://bugs.webkit.org/show_bug.cgi?id=238814 rdar://problem/91300515 Reviewed by Brent Fulgham. This patch adds support for the other CTAP virtual authenticator transports and removes the user gesture requirement when using virtual authenticators. These changes are needed to run the webauthn web-platform-tests. * UIProcess/WebAuthentication/AuthenticatorManager.cpp: (WebKit::WebCore::collectTransports): (WebKit::AuthenticatorManager::filterTransports const): * UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp: (WebKit::MockAuthenticatorManager::filterTransports const): * UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp: (WebKit::VirtualAuthenticatorManager::createAuthenticator): * UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h: * UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.mm: (WebKit::VirtualLocalConnection::verifyUser): * UIProcess/WebAuthentication/Virtual/VirtualService.mm: (WebKit::VirtualService::startDiscoveryInternal): * UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp: (WebKit::WebAuthenticatorCoordinatorProxy::handleRequest): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.mm trunk/Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualService.mm trunk/Source/WebKit/UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (292592 => 292593) --- trunk/Source/WebKit/ChangeLog 2022-04-08 04:59:16 UTC (rev 292592) +++ trunk/Source/WebKit/ChangeLog 2022-04-08 05:40:06 UTC (rev 292593) @@ -1,3 +1,30 @@ +2022-04-07 J Pascoe + +[WebAuthn] Support all CTAP transports and remove gesture requirement for virtual authenticators +https://bugs.webkit.org/show_bug.cgi?id=238814 +rdar://problem/91300515 + +Reviewed by Brent Fulgham. + +This patch adds support for the other CTAP virtual authenticator transports and removes +the user gesture requirement when using virtual authenticators. These changes are needed +to run the webauthn web-platform-tests. + +* UIProcess/WebAuthentication/AuthenticatorManager.cpp: +(WebKit::WebCore::collectTransports): +(WebKit::AuthenticatorManager::filterTransports const): +* UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp: +(WebKit::MockAuthenticatorManager::filterTransports const): +* UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.cpp: +(WebKit::VirtualAuthenticatorManager::createAuthenticator): +* UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h: +* UIProcess/WebAuthentication/Virtual/VirtualLocalConnection.mm: +(WebKit::VirtualLocalConnection::verifyUser): +* UIProcess/WebAuthentication/Virtual/VirtualService.mm: +(WebKit::VirtualService::startDiscoveryInternal): +* UIProcess/WebAuthentication/WebAuthenticatorCoordinatorProxy.cpp: +(WebKit::WebAuthenticatorCoordinatorProxy::handleRequest): + 2022-04-07 Elliott Williams [XCBuild] Enable dependency validation by default Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp (292592 => 292593) --- trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp 2022-04-08 04:59:16 UTC (rev 292592) +++ trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp 2022-04-08 05:40:06 UTC (rev 292593) @@ -63,6 +63,8 @@ ASSERT_UNUSED(addResult, addResult.isNewEntry); addResult = result.add(AuthenticatorTransport::Nfc); ASSERT_UNUSED(addResult, addResult.isNewEntry); +addResult = result.add(AuthenticatorTransport::Ble); +ASSERT_UNUSED(addResult, addResult.isNewEntry); return result; } @@ -76,6 +78,8 @@ ASSERT_UNUSED(addResult, addResult.isNewEntry); addResult = result.add(AuthenticatorTransport::Nfc); ASSERT_UNUSED(addResult, addResult.isNewEntry); +addResult = result.add(AuthenticatorTransport::Ble); +ASSERT_UNUSED(addResult, addResult.isNewEntry); return result; } @@ -98,6 +102,8 @@ ASSERT_UNUSED(addResult, addResult.isNewEntry); addResult = result.add(AuthenticatorTransport::Nfc); ASSERT_UNUSED(addResult, addResult.isNewEntry);
[webkit-changes] [292592] trunk
Title: [292592] trunk
Revision 292592
Author an...@apple.com
Date 2022-04-07 21:59:16 -0700 (Thu, 07 Apr 2022)
Log Message
[CSS Container Queries] Evaluate against shadow-including ancestors
https://bugs.webkit.org/show_bug.cgi?id=238934
Reviewed by Tim Nguyen.
LayoutTests/imported/w3c:
* web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt:
* web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.html:
Add declarative shadow DOM polyfill.
Source/WebCore:
"Style rules applying to its shadow-including descendants can then be conditioned by querying against it,
using the @container conditional group rule."
https://drafts.csswg.org/css-contain-3/#container-queries
* style/ContainerQueryEvaluator.cpp:
(WebCore::Style::ContainerQueryEvaluator::selectContainer):
Evaluate against shadow-including ancestors instead of flat tree ancestors if the cache is not available.
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::Scope::Scope):
Copy the container state when pushing scope. This also creates a stack of shadow-including ancestors.
* style/StyleTreeResolver.h:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/ContainerQueryEvaluator.cpp
trunk/Source/WebCore/style/StyleTreeResolver.cpp
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292591 => 292592)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-08 04:09:07 UTC (rev 292591)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-08 04:59:16 UTC (rev 292592)
@@ -1,3 +1,15 @@
+2022-04-07 Antti Koivisto
+
+[CSS Container Queries] Evaluate against shadow-including ancestors
+https://bugs.webkit.org/show_bug.cgi?id=238934
+
+Reviewed by Tim Nguyen.
+
+* web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt:
+* web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom.html:
+
+Add declarative shadow DOM polyfill.
+
2022-04-07 Tim Nguyen
[:has() pseudo-class] Support invalidation for :indeterminate pseudo class on
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt (292591 => 292592)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt 2022-04-08 04:09:07 UTC (rev 292591)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-for-shadow-dom-expected.txt 2022-04-08 04:59:16 UTC (rev 292592)
@@ -1,12 +1,12 @@
-FAIL Match container in outer tree null is not an object (evaluating 'document.querySelector("#inclusive-ancestor-across-root > div").shadowRoot.querySelector')
+PASS Match container in outer tree
PASS Match container in same tree, not walking flat tree ancestors
FAIL Match container in ::slotted selector's originating element tree assert_equals: expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)"
-FAIL Match container in outer tree for :host assert_equals: expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)"
-FAIL Match container in ::part selector's originating element tree null is not an object (evaluating 'document.querySelector("#inclusive-ancestor-part > div").shadowRoot.querySelector')
+PASS Match container in outer tree for :host
+FAIL Match container in ::part selector's originating element tree assert_equals: expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)"
FAIL Match container for ::before in ::slotted selector's originating element tree assert_equals: expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)"
-FAIL Match container in outer tree for :host::before assert_equals: expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)"
-FAIL Match container for ::before in ::part selector's originating element tree null is not an object (evaluating 'document.querySelector("#inclusive-ancestor-part-before > div").shadowRoot.querySelector')
-FAIL Match container for ::part selector's originating element tree for exportparts null is not an object (evaluating 'outerhost.shadowRoot.querySelector')
-FAIL Match container for slot light tree child fallback null is not an object (evaluating 'document.querySelector("#inclusive-ancestor-slot-fallback > div").shadowRoot.querySelector')
+PASS Match container in outer tree for :host::before
+FAIL Match container for ::before in ::part selector's originating element tree assert_equals: expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)"
+FAIL Match container for ::part selector's originating element tree for exportparts assert_equals: expected "rgb(0, 128, 0)" but got "rgb(0, 0, 0)"
+PASS Match container for slot light
[webkit-changes] [292591] trunk
Title: [292591] trunk Revision 292591 Author e...@apple.com Date 2022-04-07 21:09:07 -0700 (Thu, 07 Apr 2022) Log Message [XCBuild] Enable dependency validation by default https://bugs.webkit.org/show_bug.cgi?id=238901 Reviewed by Alexey Proskuryakov. .: Set VALIDATE_DEPENDENCIES=YES_ERROR everywhere, so that builds fail when task outputs are missing. The only interesting detail is that we need to set an extended attribute on the user's build directory in order for XCBuild to validate dependencies _within_ that directory. Since a users' build directory may not be created by XCBuild, have build-webkit and set-webkit-configuration set the attribute manually. * Makefile.shared: Remove the VALIDATE_DEPENDENCIES opt-in logic. Always call through to set-webkit-configuration, because that's where we verify that CreatedByBuildSystem is set on the build directory. Don't pass -EnableBuildDebugging=1; it's not actually needed to enable dependency validation. Source/bmalloc: * Configurations/DebugRelease.xcconfig: Source/_javascript_Core: * Configurations/DebugRelease.xcconfig: Source/ThirdParty/ANGLE: * Configurations/DebugRelease.xcconfig: Source/ThirdParty/libwebrtc: * Configurations/DebugRelease.xcconfig: Source/WebCore: * Configurations/DebugRelease.xcconfig: Source/WebCore/PAL: * Configurations/DebugRelease.xcconfig: Source/WebGPU: * Configurations/DebugRelease.xcconfig: Source/WebInspectorUI: * Configurations/DebugRelease.xcconfig: Source/WebKit: * Configurations/DebugRelease.xcconfig: Source/WebKitLegacy/mac: * Configurations/DebugRelease.xcconfig: Source/WTF: * Configurations/DebugRelease.xcconfig: Tools: * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: * ImageDiff/cg/Configurations/DebugRelease.xcconfig: * MiniBrowser/Configurations/DebugRelease.xcconfig: * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: * Scripts/build-webkit: * Scripts/set-webkit-configuration: When run with no arguments, checks the base product directory, prints the configuration, and exits. Recognizes -h and --help flags to show usage. * Scripts/webkitdirs.pm: (markBaseProductDirectoryAsCreatedByXcodeBuildSystem): New name of setCreatedByXcodeBuildSystem. (setCreatedByXcodeBuildSystem): Renamed. * TestWebKitAPI/Configurations/DebugRelease.xcconfig: * WebKitTestRunner/Configurations/DebugRelease.xcconfig: * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Modified Paths trunk/ChangeLog trunk/Makefile.shared trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/Configurations/DebugRelease.xcconfig trunk/Source/ThirdParty/ANGLE/ChangeLog trunk/Source/ThirdParty/ANGLE/Configurations/DebugRelease.xcconfig trunk/Source/ThirdParty/libwebrtc/ChangeLog trunk/Source/ThirdParty/libwebrtc/Configurations/DebugRelease.xcconfig trunk/Source/WTF/ChangeLog trunk/Source/WTF/Configurations/DebugRelease.xcconfig trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Configurations/DebugRelease.xcconfig trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/Configurations/DebugRelease.xcconfig trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/Configurations/DebugRelease.xcconfig trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/Configurations/DebugRelease.xcconfig trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Configurations/DebugRelease.xcconfig trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/Configurations/DebugRelease.xcconfig trunk/Source/bmalloc/ChangeLog trunk/Source/bmalloc/Configurations/DebugRelease.xcconfig trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig trunk/Tools/ImageDiff/cg/Configurations/DebugRelease.xcconfig trunk/Tools/MiniBrowser/Configurations/DebugRelease.xcconfig trunk/Tools/MobileMiniBrowser/Configurations/DebugRelease.xcconfig trunk/Tools/Scripts/build-webkit trunk/Tools/Scripts/set-webkit-configuration trunk/Tools/Scripts/webkitdirs.pm trunk/Tools/TestWebKitAPI/Configurations/DebugRelease.xcconfig trunk/Tools/WebKitTestRunner/Configurations/DebugRelease.xcconfig trunk/Tools/lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig Diff Modified: trunk/ChangeLog (292590 => 292591) --- trunk/ChangeLog 2022-04-08 04:06:57 UTC (rev 292590) +++ trunk/ChangeLog 2022-04-08 04:09:07 UTC (rev 292591) @@ -1,3 +1,26 @@ +2022-04-07 Elliott Williams + +[XCBuild] Enable dependency validation by default +https://bugs.webkit.org/show_bug.cgi?id=238901 + + +Reviewed by Alexey Proskuryakov. + +Set VALIDATE_DEPENDENCIES=YES_ERROR everywhere, so that builds fail +when task outputs are missing. + +The only interesting detail is that we need to set an extended +attribute on the user's build directory in order for XCBuild to +validate dependencies _within_ that directory. Since a users' build +directory may not be created by XCBuild, have build-webkit and +set-webkit-configuration set the
[webkit-changes] [292590] trunk/Source/WebKit
Title: [292590] trunk/Source/WebKit
Revision 292590
Author stephan.sz...@sony.com
Date 2022-04-07 21:06:57 -0700 (Thu, 07 Apr 2022)
Log Message
[WinCairo] Fix DrawingAreaWC after r292557
https://bugs.webkit.org/show_bug.cgi?id=238979
Unreviewed build fix
* WebProcess/WebPage/wc/DrawingAreaWC.cpp:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (292589 => 292590)
--- trunk/Source/WebKit/ChangeLog 2022-04-08 03:46:56 UTC (rev 292589)
+++ trunk/Source/WebKit/ChangeLog 2022-04-08 04:06:57 UTC (rev 292590)
@@ -1,3 +1,12 @@
+2022-04-07 Stephan Szabo
+
+[WinCairo] Fix DrawingAreaWC after r292557
+https://bugs.webkit.org/show_bug.cgi?id=238979
+
+Unreviewed build fix
+
+* WebProcess/WebPage/wc/DrawingAreaWC.cpp:
+
2022-04-07 Simon Fraser
Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build (again)
Modified: trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp (292589 => 292590)
--- trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp 2022-04-08 03:46:56 UTC (rev 292589)
+++ trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp 2022-04-08 04:06:57 UTC (rev 292590)
@@ -365,8 +365,8 @@
RefPtr DrawingAreaWC::createImageBuffer(FloatSize size)
{
if (WebProcess::singleton().shouldUseRemoteRenderingFor(RenderingPurpose::DOM))
-return m_webPage.ensureRemoteRenderingBackendProxy().createImageBuffer(size, RenderingPurpose::DOM, RenderingMode::Unaccelerated, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8);
-return ConcreteImageBuffer::create(size, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8, nullptr);
+return m_webPage.ensureRemoteRenderingBackendProxy().createImageBuffer(size, RenderingMode::Unaccelerated, RenderingPurpose::DOM, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8);
+return ConcreteImageBuffer::create(size, 1, DestinationColorSpace::SRGB(), PixelFormat::BGRA8, RenderingPurpose::DOM, nullptr);
}
void DrawingAreaWC::didUpdate()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292589] trunk/Source/WebKit
Title: [292589] trunk/Source/WebKit
Revision 292589
Author simon.fra...@apple.com
Date 2022-04-07 20:46:56 -0700 (Thu, 07 Apr 2022)
Log Message
Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build (again)
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::ensureFrontBuffer):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292588 => 292589)
--- trunk/Source/WebKit/ChangeLog 2022-04-08 02:30:33 UTC (rev 292588)
+++ trunk/Source/WebKit/ChangeLog 2022-04-08 03:46:56 UTC (rev 292589)
@@ -1,3 +1,10 @@
+2022-04-07 Simon Fraser
+
+Fix the CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER build (again)
+
+* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+(WebKit::RemoteLayerBackingStore::ensureFrontBuffer):
+
2022-04-07 Chris Dumez
Add PAL::TextEncoding() constructor that takes in a StringView
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (292588 => 292589)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-04-08 02:30:33 UTC (rev 292588)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-04-08 03:46:56 UTC (rev 292589)
@@ -367,7 +367,7 @@
#if ENABLE(CG_DISPLAY_LIST_BACKED_IMAGE_BUFFER)
if (m_includeDisplayList == IncludeDisplayList::Yes)
-m_frontBuffer.displayListImageBuffer = ConcreteImageBuffer::create(m_size, m_scale, DestinationColorSpace::SRGB(), pixelFormat(), { });
+m_frontBuffer.displayListImageBuffer = ConcreteImageBuffer::create(m_size, m_scale, DestinationColorSpace::SRGB(), pixelFormat(), RenderingPurpose::DOM, { });
#endif
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292588] trunk/Source
Title: [292588] trunk/Source Revision 292588 Author cdu...@apple.com Date 2022-04-07 19:30:33 -0700 (Thu, 07 Apr 2022) Log Message Add PAL::TextEncoding() constructor that takes in a StringView https://bugs.webkit.org/show_bug.cgi?id=238905 Reviewed by Darin Adler. This allows some call sites to be a bit more efficient. Source/WebCore: * Modules/fetch/FetchResponse.cpp: (WebCore::FetchResponse::create): * fileapi/FileReaderLoader.cpp: (WebCore::FileReaderLoader::setEncoding): * fileapi/FileReaderLoader.h: * html/parser/HTMLMetaCharsetParser.cpp: (WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes): * loader/FormSubmission.cpp: (WebCore::encodingFromAcceptCharset): * loader/soup/ResourceLoaderSoup.cpp: (WebCore::ResourceLoader::loadGResource): * platform/network/HTTPParsers.cpp: (WebCore::extractCharsetFromMediaType): * platform/network/HTTPParsers.h: * platform/network/curl/CurlCacheEntry.cpp: (WebCore::CurlCacheEntry::setResponseFromCachedHeaders): * platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::handleDataURL): * platform/network/curl/ResourceResponseCurl.cpp: (WebCore::ResourceResponse::ResourceResponse): * platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::ResourceResponse): * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::finalResponseCharset const): (WebCore::XMLHttpRequest::didReceiveData): Source/WebCore/PAL: * pal/text/TextEncoding.cpp: (PAL::TextEncoding::TextEncoding): * pal/text/TextEncoding.h: (PAL::TextEncoding::TextEncoding): * pal/text/TextEncodingRegistry.cpp: (PAL::atomCanonicalTextEncodingName): * pal/text/TextEncodingRegistry.h: Source/WebKit: * NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::didRequestNextPart): (WebKit::NetworkDataTaskSoup::didGetFileInfo): * UIProcess/API/glib/WebKitURISchemeRequest.cpp: (webkitURISchemeRequestReadCallback): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp trunk/Source/WebCore/PAL/ChangeLog trunk/Source/WebCore/PAL/pal/text/TextEncoding.cpp trunk/Source/WebCore/PAL/pal/text/TextEncoding.h trunk/Source/WebCore/PAL/pal/text/TextEncodingRegistry.cpp trunk/Source/WebCore/PAL/pal/text/TextEncodingRegistry.h trunk/Source/WebCore/fileapi/FileReaderLoader.cpp trunk/Source/WebCore/fileapi/FileReaderLoader.h trunk/Source/WebCore/html/parser/HTMLMetaCharsetParser.cpp trunk/Source/WebCore/loader/FormSubmission.cpp trunk/Source/WebCore/loader/soup/ResourceLoaderSoup.cpp trunk/Source/WebCore/platform/network/HTTPParsers.cpp trunk/Source/WebCore/platform/network/HTTPParsers.h trunk/Source/WebCore/platform/network/ResourceResponseBase.cpp trunk/Source/WebCore/platform/network/ResourceResponseBase.h trunk/Source/WebCore/platform/network/curl/CurlCacheEntry.cpp trunk/Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp trunk/Source/WebCore/platform/network/curl/ResourceResponseCurl.cpp trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp trunk/Source/WebCore/xml/XMLHttpRequest.cpp trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp trunk/Source/WebKit/UIProcess/API/glib/WebKitURISchemeRequest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (292587 => 292588) --- trunk/Source/WebCore/ChangeLog 2022-04-08 02:21:13 UTC (rev 292587) +++ trunk/Source/WebCore/ChangeLog 2022-04-08 02:30:33 UTC (rev 292588) @@ -1,3 +1,38 @@ +2022-04-07 Chris Dumez + +Add PAL::TextEncoding() constructor that takes in a StringView +https://bugs.webkit.org/show_bug.cgi?id=238905 + +Reviewed by Darin Adler. + +This allows some call sites to be a bit more efficient. + +* Modules/fetch/FetchResponse.cpp: +(WebCore::FetchResponse::create): +* fileapi/FileReaderLoader.cpp: +(WebCore::FileReaderLoader::setEncoding): +* fileapi/FileReaderLoader.h: +* html/parser/HTMLMetaCharsetParser.cpp: +(WebCore::HTMLMetaCharsetParser::encodingFromMetaAttributes): +* loader/FormSubmission.cpp: +(WebCore::encodingFromAcceptCharset): +* loader/soup/ResourceLoaderSoup.cpp: +(WebCore::ResourceLoader::loadGResource): +* platform/network/HTTPParsers.cpp: +(WebCore::extractCharsetFromMediaType): +* platform/network/HTTPParsers.h: +* platform/network/curl/CurlCacheEntry.cpp: +(WebCore::CurlCacheEntry::setResponseFromCachedHeaders): +* platform/network/curl/ResourceHandleCurl.cpp: +(WebCore::ResourceHandle::handleDataURL): +* platform/network/curl/ResourceResponseCurl.cpp: +(WebCore::ResourceResponse::ResourceResponse): +* platform/network/soup/ResourceResponseSoup.cpp: +(WebCore::ResourceResponse::ResourceResponse): +* xml/XMLHttpRequest.cpp: +(WebCore::XMLHttpRequest::finalResponseCharset const): +(WebCore::XMLHttpRequest::didReceiveData): + 2022-04-07 Gabriel
[webkit-changes] [292587] trunk
Title: [292587] trunk Revision 292587 Author cdu...@apple.com Date 2022-04-07 19:21:13 -0700 (Thu, 07 Apr 2022) Log Message Replace deprecated String(const char*) with String::fromLatin1() in more places https://bugs.webkit.org/show_bug.cgi?id=238925 Reviewed by Darin Adler. Source/WebKit: * NetworkProcess/DatabaseUtilities.cpp: (WebKit::DatabaseUtilities::stripIndexQueryToMatchStoredValue): * NetworkProcess/cache/NetworkCache.cpp: (WebKit::NetworkCache::Cache::dumpContentsToFile): * Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb: * Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb: * Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb: * Shared/API/Cocoa/WKRemoteObjectCoder.mm: (encodeObject): * Shared/API/Cocoa/_WKRemoteObjectRegistry.mm: (-[_WKRemoteObjectRegistry _sendInvocation:interface:]): * Shared/Cocoa/SandboxExtensionCocoa.mm: (WebKit::SandboxExtension::createHandleForTemporaryFile): * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm: (WebKit::XPCServiceInitializerDelegate::getClientBundleIdentifier): (WebKit::XPCServiceInitializerDelegate::getClientProcessName): (WebKit::XPCServiceInitializerDelegate::getExtraInitializationData): * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm: (WebKit::XPCServiceMain): * UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm: (+[_WKWebAuthenticationPanel getAllLocalAuthenticatorCredentials]): * UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::showSafeBrowsingWarning): * UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm: (WebKit::ProcessLauncher::launchProcess): * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticator::clearAllCredentials): * UIProcess/WebAuthentication/Cocoa/LocalConnection.mm: (WebKit::LocalConnection::createCredentialPrivateKey const): * UIProcess/WebPageProxy.cpp: (WebKit::pasteAccessCategoryForCommand): * UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::didReceiveInvalidMessage): * WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::pluginInfo): * WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::replaceSelectionPasteboardName): * WebProcess/WebPage/IPCTestingAPI.cpp: (WebKit::IPCTestingAPI::createJSArrayForArgumentDescriptions): (WebKit::IPCTestingAPI::JSMessageListener::jsDescriptionFromDecoder): * webpushd/WebPushDaemonMain.mm: (WebKit::WebPushDaemonMain): Source/WebKitLegacy/mac: * History/HistoryPropertyList.mm: (HistoryPropertyListWriter::HistoryPropertyListWriter): * WebView/WebHTMLView.mm: (-[WebHTMLView coreCommandByName:]): Tools: * DumpRenderTree/TestRunner.cpp: (TestRunner::setAccummulateLogsForChannel): * DumpRenderTree/mac/DumpRenderTree.mm: (handleControlCommand): (changeWindowScaleIfNeeded): (resetWebViewToConsistentState): * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: (TestWebKitAPI::TEST): * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::waitForPostDumpWatchdogTimerFired): * WebKitTestRunner/cocoa/CrashReporterInfo.mm: (WTR::testPathFromURL): * WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::cocoaPlatformInitialize): (WTR::TestController::cocoaResetStateToConsistentValues): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/NetworkProcess/DatabaseUtilities.cpp trunk/Source/WebKit/NetworkProcess/cache/NetworkCache.cpp trunk/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.cpp.erb trunk/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesInternalDebugFeatures.cpp.erb trunk/Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesStoreDefaultsMap.cpp.erb trunk/Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm trunk/Source/WebKit/Shared/API/Cocoa/_WKRemoteObjectRegistry.mm trunk/Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm trunk/Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm trunk/Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKit/UIProcess/WebProcessPool.cpp trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm trunk/Source/WebKit/WebProcess/WebPage/IPCTestingAPI.cpp trunk/Source/WebKit/webpushd/WebPushDaemonMain.mm trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/History/HistoryPropertyList.mm trunk/Source/WebKitLegacy/mac/WebView/WebHTMLView.mm trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/TestRunner.cpp trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm trunk/Tools/TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp
[webkit-changes] [292586] trunk/Source/WTF
Title: [292586] trunk/Source/WTF Revision 292586 Author gsnedd...@apple.com Date 2022-04-07 18:35:03 -0700 (Thu, 07 Apr 2022) Log Message Move long-enabled preferences away from experimental https://bugs.webkit.org/show_bug.cgi?id=238929 Reviewed by Tim Horton. This only moves things which have a simple `default: true` and have since Safari 15's release; there are likely other things which could be moved. It does, however, leave GoogleAntiFlickerOptimizationQuirkEnabled as an experimental feature, as this seems something it is more likely a developer may wish to toggle. * Scripts/Preferences/WebPreferences.yaml: * Scripts/Preferences/WebPreferencesExperimental.yaml: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Diff Modified: trunk/Source/WTF/ChangeLog (292585 => 292586) --- trunk/Source/WTF/ChangeLog 2022-04-08 01:03:40 UTC (rev 292585) +++ trunk/Source/WTF/ChangeLog 2022-04-08 01:35:03 UTC (rev 292586) @@ -1,3 +1,21 @@ +2022-04-07 Sam Sneddon + +Move long-enabled preferences away from experimental +https://bugs.webkit.org/show_bug.cgi?id=238929 + +Reviewed by Tim Horton. + +This only moves things which have a simple `default: true` and +have since Safari 15's release; there are likely other things +which could be moved. + +It does, however, leave GoogleAntiFlickerOptimizationQuirkEnabled +as an experimental feature, as this seems something it is more +likely a developer may wish to toggle. + +* Scripts/Preferences/WebPreferences.yaml: +* Scripts/Preferences/WebPreferencesExperimental.yaml: + 2022-04-07 Brent Fulgham [WebKitLegacy] Remove NPAPIPlugInsEnabledForTestingInWebKitLegacy Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (292585 => 292586) --- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-04-08 01:03:40 UTC (rev 292585) +++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-04-08 01:35:03 UTC (rev 292586) @@ -312,6 +312,30 @@ "ENABLE(APPLE_PAY_REMOTE_UI)": true default: false +AspectRatioEnabled: + type: bool + humanReadableName: "CSS Aspect Ratio" + humanReadableDescription: "Enable aspect-ratio CSS property" + defaultValue: +WebKitLegacy: + default: true +WebKit: + default: true +WebCore: + default: true + +AspectRatioOfImgFromWidthAndHeightEnabled: + type: bool + humanReadableName: "Aspect ratio of from width and height" + humanReadableDescription: "Map HTML attributes width/height to the default aspect ratio of " + defaultValue: +WebKitLegacy: + default: true +WebKit: + default: true +WebCore: + default: true + AsynchronousSpellCheckingEnabled: type: bool defaultValue: @@ -370,6 +394,42 @@ WebCore: default: false +BlankAnchorTargetImpliesNoOpenerEnabled: + type: bool + humanReadableName: "Blank anchor target implies rel=noopener" + humanReadableDescription: "target=_blank on anchor elements implies rel=noopener" + defaultValue: +WebKitLegacy: + default: true +WebKit: + default: true +WebCore: + default: true + +CSSColor4: + type: bool + humanReadableName: "CSS Color 4 Color Types" + humanReadableDescription: "Enable support for CSS Color 4 Color Types" + defaultValue: +WebKitLegacy: + default: true +WebKit: + default: true +WebCore: + default: true + +CSSIndividualTransformPropertiesEnabled: + type: bool + humanReadableName: "CSS Individual Transform Properties" + humanReadableDescription: "Support for the translate, scale and rotate CSS properties" + defaultValue: +WebKitLegacy: + default: true +WebKit: + default: true +WebCore: + default: true + CSSTransformStyleOptimized3DEnabled: type: bool condition: ENABLE(CSS_TRANSFORM_STYLE_OPTIMIZED_3D) @@ -768,6 +828,20 @@ WebCore: default: '""' +# FIXME: This seems to be accidentally enabled for WebKit1 right now due to the old code using the +# wrong preference key in some places. We should identify whether it really makes sense to keep this +# enabled. +FetchAPIKeepAliveEnabled: + type: bool + humanReadableName: "Fetch API Request KeepAlive" + humanReadableDescription: "Enable Fetch API Request KeepAlive" + webcoreBinding: RuntimeEnabledFeatures + defaultValue: +WebKitLegacy: + default: true +WebKit: + default: true + FixedFontFamily: type: String webKitLegacyPreferenceKey: WebKitFixedFont @@ -843,6 +917,33 @@ WebCore: default: false +# FIXME: This is on by default in WebKit2. Perhaps we should consider turning it on for WebKitLegacy as well. +GenericCueAPIEnabled: + type: bool + condition: ENABLE(VIDEO) + humanReadableName: "Generic Text Track Cue API" + humanReadableDescription: "Enable Generic
[webkit-changes] [292585] trunk/Source/WebCore
Title: [292585] trunk/Source/WebCore
Revision 292585
Author gnavamar...@apple.com
Date 2022-04-07 18:03:40 -0700 (Thu, 07 Apr 2022)
Log Message
When using a TrackDisplayUpdateScope queue updateActiveTextTrackCues as a task
https://bugs.webkit.org/show_bug.cgi?id=238963
Reviewed by Eric Carlson.
The HTMLMediaElement::didRemoveTextTrack call is done under ScriptDisallowedScope but this path
currently can call updateActiveTextTrackCues which could result in updating the layout downstream.
To resolve this we execute updateActiveTextTrackCues under a queueCancellableTaskKeepingObjectAlive call.
We also add a needed check in RenderVTTCue::initializeLayoutParameters exposed by queueing the task.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::cancelPendingTasks):
* html/HTMLMediaElement.h:
* rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::initializeLayoutParameters):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/rendering/RenderVTTCue.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292584 => 292585)
--- trunk/Source/WebCore/ChangeLog 2022-04-08 00:51:43 UTC (rev 292584)
+++ trunk/Source/WebCore/ChangeLog 2022-04-08 01:03:40 UTC (rev 292585)
@@ -1,3 +1,23 @@
+2022-04-07 Gabriel Nava Marino
+
+When using a TrackDisplayUpdateScope queue updateActiveTextTrackCues as a task
+https://bugs.webkit.org/show_bug.cgi?id=238963
+
+Reviewed by Eric Carlson.
+
+The HTMLMediaElement::didRemoveTextTrack call is done under ScriptDisallowedScope but this path
+currently can call updateActiveTextTrackCues which could result in updating the layout downstream.
+To resolve this we execute updateActiveTextTrackCues under a queueCancellableTaskKeepingObjectAlive call.
+
+We also add a needed check in RenderVTTCue::initializeLayoutParameters exposed by queueing the task.
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):
+(WebCore::HTMLMediaElement::cancelPendingTasks):
+* html/HTMLMediaElement.h:
+* rendering/RenderVTTCue.cpp:
+(WebCore::RenderVTTCue::initializeLayoutParameters):
+
2022-04-07 Tim Nguyen
[:has() pseudo-class] Support invalidation for :indeterminate pseudo class on
Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (292584 => 292585)
--- trunk/Source/WebCore/html/HTMLMediaElement.cpp 2022-04-08 00:51:43 UTC (rev 292584)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp 2022-04-08 01:03:40 UTC (rev 292585)
@@ -2018,8 +2018,11 @@
{
ASSERT(m_ignoreTrackDisplayUpdate);
--m_ignoreTrackDisplayUpdate;
-if (!m_ignoreTrackDisplayUpdate && m_inActiveDocument)
-updateActiveTextTrackCues(currentMediaTime());
+
+queueCancellableTaskKeepingObjectAlive(*this, TaskSource::MediaElement, m_updateTextTracksTaskCancellationGroup, [this] {
+if (!m_ignoreTrackDisplayUpdate && m_inActiveDocument)
+updateActiveTextTrackCues(currentMediaTime());
+});
}
void HTMLMediaElement::textTrackAddCues(TextTrack& track, const TextTrackCueList& cues)
@@ -5792,6 +5795,7 @@
void HTMLMediaElement::cancelPendingTasks()
{
m_configureTextTracksTaskCancellationGroup.cancel();
+m_updateTextTracksTaskCancellationGroup.cancel();
m_checkPlaybackTargetCompatibilityTaskCancellationGroup.cancel();
m_updateMediaStateTaskCancellationGroup.cancel();
m_mediaEngineUpdatedTaskCancellationGroup.cancel();
Modified: trunk/Source/WebCore/html/HTMLMediaElement.h (292584 => 292585)
--- trunk/Source/WebCore/html/HTMLMediaElement.h 2022-04-08 00:51:43 UTC (rev 292584)
+++ trunk/Source/WebCore/html/HTMLMediaElement.h 2022-04-08 01:03:40 UTC (rev 292585)
@@ -989,6 +989,7 @@
Timer m_playbackControlsManagerBehaviorRestrictionsTimer;
Timer m_seekToPlaybackPositionEndedTimer;
TaskCancellationGroup m_configureTextTracksTaskCancellationGroup;
+TaskCancellationGroup m_updateTextTracksTaskCancellationGroup;
TaskCancellationGroup m_checkPlaybackTargetCompatibilityTaskCancellationGroup;
TaskCancellationGroup m_updateMediaStateTaskCancellationGroup;
TaskCancellationGroup m_mediaEngineUpdatedTaskCancellationGroup;
Modified: trunk/Source/WebCore/rendering/RenderVTTCue.cpp (292584 => 292585)
--- trunk/Source/WebCore/rendering/RenderVTTCue.cpp 2022-04-08 00:51:43 UTC (rev 292584)
+++ trunk/Source/WebCore/rendering/RenderVTTCue.cpp 2022-04-08 01:03:40 UTC (rev 292585)
@@ -79,9 +79,9 @@
RenderBlock* parentBlock = containingBlock();
-firstLineBox = cueBox().firstLineBox();
+firstLineBox = cueBox().firstLineBox() ? cueBox().firstLineBox() : this->firstRootBox();
if (!firstLineBox)
-firstLineBox = this->firstRootBox();
+return false;
// 1.
[webkit-changes] [292584] trunk/Tools
Title: [292584] trunk/Tools
Revision 292584
Author clo...@igalia.com
Date 2022-04-07 17:51:43 -0700 (Thu, 07 Apr 2022)
Log Message
REGRESSION(r292109): [GTK][WPE] generate-bundle: Don't try to use the interpreter prefix when not bundling all.
https://bugs.webkit.org/show_bug.cgi?id=237107
For bundles of type --syslibs=generate-install-script we should
not try to prefix the executable with the interpreter.
Add a missing check to ensure that the interpreter has been copied
into the bundle before trying to use it.
Unreviewed follow-up fix.
* Scripts/webkitpy/binary_bundling/bundle.py:
(BinaryBundler.generate_wrapper_script):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py
Diff
Modified: trunk/Tools/ChangeLog (292583 => 292584)
--- trunk/Tools/ChangeLog 2022-04-08 00:49:58 UTC (rev 292583)
+++ trunk/Tools/ChangeLog 2022-04-08 00:51:43 UTC (rev 292584)
@@ -1,3 +1,18 @@
+2022-04-07 Carlos Alberto Lopez Perez
+
+REGRESSION(r292109): [GTK][WPE] generate-bundle: Don't try to use the interpreter prefix when not bundling all.
+https://bugs.webkit.org/show_bug.cgi?id=237107
+
+For bundles of type --syslibs=generate-install-script we should
+not try to prefix the executable with the interpreter.
+Add a missing check to ensure that the interpreter has been copied
+into the bundle before trying to use it.
+
+Unreviewed follow-up fix.
+
+* Scripts/webkitpy/binary_bundling/bundle.py:
+(BinaryBundler.generate_wrapper_script):
+
2022-04-07 Jonathan Bedard
[Merge-Queue] Add PushCommitToWebKitRepo
Modified: trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py (292583 => 292584)
--- trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py 2022-04-08 00:49:58 UTC (rev 292583)
+++ trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py 2022-04-08 00:51:43 UTC (rev 292584)
@@ -213,11 +213,14 @@
dlopenwrap_libname = 'dlopenwrap.so'
if os.path.isfile(os.path.join(lib_dir, dlopenwrap_libname)):
script_handle.write('export LD_PRELOAD="${%s}/lib/%s"\n' % (self.VAR_MYDIR, dlopenwrap_libname))
-# If we have patched the binaries to use a relative relpath then load the binary directly without prefixing it with the interpreter (it allows the process to use the correct progname)
-if self._has_patched_interpreter_relpath:
+
+# Prefix the program with the interpreter when we are bundling all (interpreter is copied) and the path to the interpreter isn't patched.
+# Otherwise prefer to not prefix it, because that allow the process to use a more meaningful progname.
+interpreter_basename = os.path.basename(interpreter)
+if os.path.isfile(os.path.join(lib_dir, interpreter_basename)) and not self._has_patched_interpreter_relpath:
+script_handle.write('INTERPRETER="${%s}/lib/%s"\n' % (self.VAR_MYDIR, interpreter_basename))
+script_handle.write('exec "${INTERPRETER}" "${%s}/bin/%s" "$@"\n' % (self.VAR_MYDIR, binary_to_wrap))
+else:
script_handle.write('exec "${%s}/bin/%s" "$@"\n' % (self.VAR_MYDIR, binary_to_wrap))
-else:
-script_handle.write('INTERPRETER="${%s}/lib/%s"\n' % (self.VAR_MYDIR, os.path.basename(interpreter)))
-script_handle.write('exec "${INTERPRETER}" "${%s}/bin/%s" "$@"\n' % (self.VAR_MYDIR, binary_to_wrap))
os.chmod(script_file, 0o755)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292583] trunk/Source/WebKit
Title: [292583] trunk/Source/WebKit Revision 292583 Author stephan.sz...@sony.com Date 2022-04-07 17:49:58 -0700 (Thu, 07 Apr 2022) Log Message Build-fix for not ENABLE(SERVICE_WORKER) after r292539 https://bugs.webkit.org/show_bug.cgi?id=238957 Unreviewed build fix. * UIProcess/WebPageProxy.cpp: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (292582 => 292583) --- trunk/Source/WebKit/ChangeLog 2022-04-08 00:47:15 UTC (rev 292582) +++ trunk/Source/WebKit/ChangeLog 2022-04-08 00:49:58 UTC (rev 292583) @@ -1,3 +1,12 @@ +2022-04-07 Stephan Szabo + +Build-fix for not ENABLE(SERVICE_WORKER) after r292539 +https://bugs.webkit.org/show_bug.cgi?id=238957 + +Unreviewed build fix. + +* UIProcess/WebPageProxy.cpp: + 2022-04-07 Simon Fraser Add a LayerBacking RenderingPurpose Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (292582 => 292583) --- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-04-08 00:47:15 UTC (rev 292582) +++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-04-08 00:49:58 UTC (rev 292583) @@ -4610,8 +4610,10 @@ m_mainFrame = WebFrameProxy::create(*this, frameID); +#if ENABLE(SERVICE_WORKER) if (m_serviceWorkerOpenWindowCompletionCallback) m_mainFrame->setNavigationCallback(WTFMove(m_serviceWorkerOpenWindowCompletionCallback)); +#endif // Add the frame to the process wide map. m_process->frameCreated(frameID, *m_mainFrame); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292582] trunk
Title: [292582] trunk
Revision 292582
Author n...@apple.com
Date 2022-04-07 17:47:15 -0700 (Thu, 07 Apr 2022)
Log Message
[:has() pseudo-class] Support invalidation for :indeterminate pseudo class on
https://bugs.webkit.org/show_bug.cgi?id=238923
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
* web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt:
* web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html:
Source/WebCore:
Test: imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::HTMLProgressElement):
(WebCore::HTMLProgressElement::parseAttribute):
(WebCore::HTMLProgressElement::didAttachRenderers):
(WebCore::HTMLProgressElement::updateDeterminateState):
(WebCore::HTMLProgressElement::didElementStateChange):
(WebCore::HTMLProgressElement::isDeterminate const): Deleted.
* html/HTMLProgressElement.h:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLProgressElement.cpp
trunk/Source/WebCore/html/HTMLProgressElement.h
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292581 => 292582)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-08 00:08:16 UTC (rev 292581)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-08 00:47:15 UTC (rev 292582)
@@ -1,3 +1,13 @@
+2022-04-07 Tim Nguyen
+
+[:has() pseudo-class] Support invalidation for :indeterminate pseudo class on
+https://bugs.webkit.org/show_bug.cgi?id=238923
+
+Reviewed by Antti Koivisto.
+
+* web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt:
+* web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html:
+
2022-04-07 Matteo Flores
REGRESSION(r291509): imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html is a constant text failure
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt (292581 => 292582)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt 2022-04-08 00:08:16 UTC (rev 292581)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has-expected.txt 2022-04-08 00:47:15 UTC (rev 292582)
@@ -1,6 +1,7 @@
Check me!
-PASS :checked & :indeterminate invalidation
+PASS :checked & :indeterminate invalidation on
+PASS :indeterminate invalidation on
PASS :disabled invalidation
PASS :read-only invalidation
PASS :valid invalidation
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html (292581 => 292582)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html 2022-04-08 00:08:16 UTC (rev 292581)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/input-pseudo-classes-in-has.html 2022-04-08 00:47:15 UTC (rev 292582)
@@ -15,6 +15,7 @@
.ancestor:has(#textinput:valid) { color: lightgreen }
.ancestor:has(#numberinput:out-of-range) { color: darkgreen }
.ancestor:has(#numberinput:required) { color: pink }
+ .ancestor:has(#progress:indeterminate) { color: orange }
@@ -22,6 +23,7 @@
+
[webkit-changes] [292581] releases/WebKitGTK/webkit-2.34/Source/WebCore
Title: [292581] releases/WebKitGTK/webkit-2.34/Source/WebCore
Revision 292581
Author ape...@igalia.com
Date 2022-04-07 17:08:16 -0700 (Thu, 07 Apr 2022)
Log Message
Merge r287147 - Rename forEachFrameFromMainFrame to forEachFrame
https://bugs.webkit.org/show_bug.cgi?id=234396
Reviewed by Geoffrey Garen.
Follow-up to r287110: Switch method naming to match 'forEachDocument'.
* page/Page.cpp:
(WebCore::Page::~Page):
(WebCore::Page::notifyToInjectUserScripts):
(WebCore::Page::forEachFrame):
(WebCore::Page::forEachFrameFromMainFrame): Deleted.
* page/Page.h:
Modified Paths
releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.h
Diff
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (292580 => 292581)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:08:11 UTC (rev 292580)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:08:16 UTC (rev 292581)
@@ -1,3 +1,20 @@
+2021-12-16 Brent Fulgham
+
+Rename forEachFrameFromMainFrame to forEachFrame
+https://bugs.webkit.org/show_bug.cgi?id=234396
+
+
+Reviewed by Geoffrey Garen.
+
+Follow-up to r287110: Switch method naming to match 'forEachDocument'.
+
+* page/Page.cpp:
+(WebCore::Page::~Page):
+(WebCore::Page::notifyToInjectUserScripts):
+(WebCore::Page::forEachFrame):
+(WebCore::Page::forEachFrameFromMainFrame): Deleted.
+* page/Page.h:
+
2022-03-24 Kimmo Kinnunen
REGRESSION (r287807): WEBGL_multi_draw validation rejecting valid arguments
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.cpp (292580 => 292581)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.cpp 2022-04-08 00:08:11 UTC (rev 292580)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.cpp 2022-04-08 00:08:16 UTC (rev 292581)
@@ -393,7 +393,7 @@
m_inspectorController->inspectedPageDestroyed();
-forEachFrameFromMainFrame([] (Frame& frame) {
+forEachFrame([] (Frame& frame) {
frame.willDetachPage();
frame.detachFromPage();
});
@@ -2924,7 +2924,7 @@
{
m_hasBeenNotifiedToInjectUserScripts = true;
-forEachFrameFromMainFrame([] (Frame& frame) {
+forEachFrame([] (Frame& frame) {
frame.injectUserScriptsAwaitingNotification();
});
}
@@ -3365,7 +3365,7 @@
#endif
}
-void Page::forEachFrameFromMainFrame(const Function& functor)
+void Page::forEachFrame(const Function& functor)
{
Vector> frames;
for (auto* frame = (); frame; frame = frame->tree().traverseNext())
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.h (292580 => 292581)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.h 2022-04-08 00:08:11 UTC (rev 292580)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.h 2022-04-08 00:08:16 UTC (rev 292581)
@@ -850,7 +850,7 @@
WEBCORE_EXPORT void forEachDocument(const Function&) const;
void forEachMediaElement(const Function&);
static void forEachDocumentFromMainFrame(const Frame&, const Function&);
-void forEachFrameFromMainFrame(const Function&);
+void forEachFrame(const Function&);
bool shouldDisableCorsForRequestTo(const URL&) const;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292580] releases/WebKitGTK/webkit-2.34
Title: [292580] releases/WebKitGTK/webkit-2.34
Revision 292580
Author ape...@igalia.com
Date 2022-04-07 17:08:11 -0700 (Thu, 07 Apr 2022)
Log Message
Merge r291791 - REGRESSION (r287807): WEBGL_multi_draw validation rejecting valid arguments
https://bugs.webkit.org/show_bug.cgi?id=238239
Patch by Kimmo Kinnunen on 2022-03-24
Reviewed by Darin Adler.
Source/WebCore:
Fix off-by-one error causing full buffer multidraws to be
marked as invalid.
Enable the newer WebGL conformance tests that test this.
* html/canvas/WebGLMultiDraw.cpp:
(WebCore::WebGLMultiDraw::validateOffset):
LayoutTests:
Enable the newer WebGL conformance tests that test this, marked
Slow as they take a while to run.
* TestExpectations:
Modified Paths
releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/html/canvas/WebGLMultiDraw.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog (292579 => 292580)
--- releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog 2022-04-08 00:08:05 UTC (rev 292579)
+++ releases/WebKitGTK/webkit-2.34/LayoutTests/ChangeLog 2022-04-08 00:08:11 UTC (rev 292580)
@@ -1,3 +1,15 @@
+2022-03-24 Kimmo Kinnunen
+
+REGRESSION (r287807): WEBGL_multi_draw validation rejecting valid arguments
+https://bugs.webkit.org/show_bug.cgi?id=238239
+
+Reviewed by Darin Adler.
+
+Enable the newer WebGL conformance tests that test this, marked
+Slow as they take a while to run.
+
+* TestExpectations:
+
2022-02-14 Simon Fraser
Fix crash with deeply nested async overflow scroll
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (292579 => 292580)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:08:05 UTC (rev 292579)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:08:11 UTC (rev 292580)
@@ -1,3 +1,18 @@
+2022-03-24 Kimmo Kinnunen
+
+REGRESSION (r287807): WEBGL_multi_draw validation rejecting valid arguments
+https://bugs.webkit.org/show_bug.cgi?id=238239
+
+Reviewed by Darin Adler.
+
+Fix off-by-one error causing full buffer multidraws to be
+marked as invalid.
+
+Enable the newer WebGL conformance tests that test this.
+
+* html/canvas/WebGLMultiDraw.cpp:
+(WebCore::WebGLMultiDraw::validateOffset):
+
2022-01-07 Brent Fulgham
[Hardening] Improve multi draw offset validation
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/html/canvas/WebGLMultiDraw.cpp (292579 => 292580)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/html/canvas/WebGLMultiDraw.cpp 2022-04-08 00:08:05 UTC (rev 292579)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/html/canvas/WebGLMultiDraw.cpp 2022-04-08 00:08:11 UTC (rev 292580)
@@ -135,7 +135,7 @@
return false;
}
-if (offset >= static_cast(size - drawcount)) {
+if (offset > static_cast(size - drawcount)) {
m_context->synthesizeGLError(GraphicsContextGL::INVALID_OPERATION, functionName, outOfBoundsDescription);
return false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292579] releases/WebKitGTK/webkit-2.34/Source/WebCore
Title: [292579] releases/WebKitGTK/webkit-2.34/Source/WebCore
Revision 292579
Author ape...@igalia.com
Date 2022-04-07 17:08:05 -0700 (Thu, 07 Apr 2022)
Log Message
Merge r287807 - [Hardening] Improve multi draw offset validation
https://bugs.webkit.org/show_bug.cgi?id=234966
Reviewed by Darin Adler.
Incorporate draw count into validation of the offset.
* html/canvas/WebGLMultiDraw.cpp:
(WebCore::WebGLMultiDraw::validateOffset):
Modified Paths
releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/html/canvas/WebGLMultiDraw.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (292578 => 292579)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:08:00 UTC (rev 292578)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:08:05 UTC (rev 292579)
@@ -1,3 +1,16 @@
+2022-01-07 Brent Fulgham
+
+[Hardening] Improve multi draw offset validation
+https://bugs.webkit.org/show_bug.cgi?id=234966
+
+
+Reviewed by Darin Adler.
+
+Incorporate draw count into validation of the offset.
+
+* html/canvas/WebGLMultiDraw.cpp:
+(WebCore::WebGLMultiDraw::validateOffset):
+
2022-01-31 Brent Fulgham
Fix handling of access key events
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/html/canvas/WebGLMultiDraw.cpp (292578 => 292579)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/html/canvas/WebGLMultiDraw.cpp 2022-04-08 00:08:00 UTC (rev 292578)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/html/canvas/WebGLMultiDraw.cpp 2022-04-08 00:08:05 UTC (rev 292579)
@@ -135,7 +135,7 @@
return false;
}
-if (offset >= static_cast(size)) {
+if (offset >= static_cast(size - drawcount)) {
m_context->synthesizeGLError(GraphicsContextGL::INVALID_OPERATION, functionName, outOfBoundsDescription);
return false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292578] releases/WebKitGTK/webkit-2.34/Source/WebCore
Title: [292578] releases/WebKitGTK/webkit-2.34/Source/WebCore
Revision 292578
Author ape...@igalia.com
Date 2022-04-07 17:08:00 -0700 (Thu, 07 Apr 2022)
Log Message
Merge r288867 - Fix handling of access key events
https://bugs.webkit.org/show_bug.cgi?id=234147
Reviewed by David Kilzer.
Improve focus handling for HTMLElement-based elements to ensure accessKey events
are properly dispatched.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press): Ensure correct object is used after 'accessKeyAction'
is invoked.
* dom/EventDispatcher.cpp:
(WebCore::callDefaultEventHandlersInBubblingOrder) Protect element during default
event bubbling.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::reportValidity): Ensure correct element is
used after focus event.
* page/EventHandler.cpp:
(WebCore::EventHandler::handleAccessKey): Ensure correct object is used after
'accessKeyAction' is invoked.
Modified Paths
releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/accessibility/AccessibilityObject.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/dom/EventDispatcher.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/html/HTMLFormControlElement.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/EventHandler.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (292577 => 292578)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:07:40 UTC (rev 292577)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:08:00 UTC (rev 292578)
@@ -1,3 +1,27 @@
+2022-01-31 Brent Fulgham
+
+Fix handling of access key events
+https://bugs.webkit.org/show_bug.cgi?id=234147
+
+
+Reviewed by David Kilzer.
+
+Improve focus handling for HTMLElement-based elements to ensure accessKey events
+are properly dispatched.
+
+* accessibility/AccessibilityObject.cpp:
+(WebCore::AccessibilityObject::press): Ensure correct object is used after 'accessKeyAction'
+is invoked.
+* dom/EventDispatcher.cpp:
+(WebCore::callDefaultEventHandlersInBubblingOrder) Protect element during default
+event bubbling.
+* html/HTMLFormControlElement.cpp:
+(WebCore::HTMLFormControlElement::reportValidity): Ensure correct element is
+used after focus event.
+* page/EventHandler.cpp:
+(WebCore::EventHandler::handleAccessKey): Ensure correct object is used after
+'accessKeyAction' is invoked.
+
2021-12-15 Brent Fulgham
Clean-up: Adopt Page::forEachDocument in some missed spots
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/accessibility/AccessibilityObject.cpp (292577 => 292578)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/accessibility/AccessibilityObject.cpp 2022-04-08 00:07:40 UTC (rev 292577)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/accessibility/AccessibilityObject.cpp 2022-04-08 00:08:00 UTC (rev 292578)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2008-2009, 2011, 2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2022 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -839,6 +839,7 @@
dispatchedEvent = dispatchTouchEvent();
#endif
+Ref protectedPressElement { *pressElement };
return dispatchedEvent || pressElement->accessKeyAction(true) || pressElement->dispatchSimulatedClick(nullptr, SendMouseUpDownEvents);
}
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/dom/EventDispatcher.cpp (292577 => 292578)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/dom/EventDispatcher.cpp 2022-04-08 00:07:40 UTC (rev 292577)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/dom/EventDispatcher.cpp 2022-04-08 00:08:00 UTC (rev 292578)
@@ -2,7 +2,7 @@
* Copyright (C) 1999 Lars Knoll (kn...@kde.org)
* (C) 1999 Antti Koivisto (koivi...@kde.org)
* (C) 2001 Dirk Mueller (muel...@kde.org)
- * Copyright (C) 2004-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2004-2022 Apple Inc. All rights reserved.
* Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
* Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
* Copyright (C) 2010, 2011, 2012, 2013 Google Inc. All rights reserved.
@@ -60,7 +60,8 @@
return;
// Non-bubbling events call only one default event handler, the one for the target.
-path.contextAt(0).node()->defaultEventHandler(event);
+Ref rootNode { *path.contextAt(0).node() };
+rootNode->defaultEventHandler(event);
ASSERT(!event.defaultPrevented());
if (event.defaultHandled() || !event.bubbles())
@@ -68,7 +69,8 @@
size_t size = path.size();
for (size_t i = 1; i < size; ++i) {
-
[webkit-changes] [292577] releases/WebKitGTK/webkit-2.34/Source/WebCore
Title: [292577] releases/WebKitGTK/webkit-2.34/Source/WebCore
Revision 292577
Author ape...@igalia.com
Date 2022-04-07 17:07:40 -0700 (Thu, 07 Apr 2022)
Log Message
Merge r287110 - Clean-up: Adopt Page::forEachDocument in some missed spots
https://bugs.webkit.org/show_bug.cgi?id=234324
Reviewed by Darin Adler.
Switch manual loops to our 'forEachDocument' style in a few places that were missed
in earlier refactoring.
No change in behavior.
* history/BackForwardCache.cpp:
(WebCore::setBackForwardCacheState)
* page/EventHandler.cpp:
(WebCore::removeDraggedContentDocumentMarkersFromAllFramesInPage):
* page/Frame.cpp:
(WebCore::Frame::orientationChanged):
* page/Page.cpp:
(WebCore::Page::~Page):
(WebCore::Page::forEachDocumentFromMainFrame): Added.
(WebCore::Page::forEachDocument): Use new method.
(WebCore::Page::forEachFrameFromMainFrame): Added.
(WebCore::Page::windowScreenDidChange):
(WebCore::Page::userAgentChanged):
* page/ios/FrameIOS.mm:
(WebCore::Frame::dispatchPageHideEventBeforePause):
(WebCore::Frame::dispatchPageShowEventBeforeResume):
Modified Paths
releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog
releases/WebKitGTK/webkit-2.34/Source/WebCore/history/BackForwardCache.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/EventHandler.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Frame.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.cpp
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Page.h
releases/WebKitGTK/webkit-2.34/Source/WebCore/page/ios/FrameIOS.mm
Diff
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog (292576 => 292577)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-07 22:59:01 UTC (rev 292576)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/ChangeLog 2022-04-08 00:07:40 UTC (rev 292577)
@@ -1,3 +1,33 @@
+2021-12-15 Brent Fulgham
+
+Clean-up: Adopt Page::forEachDocument in some missed spots
+https://bugs.webkit.org/show_bug.cgi?id=234324
+
+
+Reviewed by Darin Adler.
+
+Switch manual loops to our 'forEachDocument' style in a few places that were missed
+in earlier refactoring.
+
+No change in behavior.
+
+* history/BackForwardCache.cpp:
+(WebCore::setBackForwardCacheState)
+* page/EventHandler.cpp:
+(WebCore::removeDraggedContentDocumentMarkersFromAllFramesInPage):
+* page/Frame.cpp:
+(WebCore::Frame::orientationChanged):
+* page/Page.cpp:
+(WebCore::Page::~Page):
+(WebCore::Page::forEachDocumentFromMainFrame): Added.
+(WebCore::Page::forEachDocument): Use new method.
+(WebCore::Page::forEachFrameFromMainFrame): Added.
+(WebCore::Page::windowScreenDidChange):
+(WebCore::Page::userAgentChanged):
+* page/ios/FrameIOS.mm:
+(WebCore::Frame::dispatchPageHideEventBeforePause):
+(WebCore::Frame::dispatchPageShowEventBeforeResume):
+
2022-02-16 Adrian Perez de Castro
[CMake] Cannot find OpenGL when system provides opengl.pc instead of gl.pc
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/history/BackForwardCache.cpp (292576 => 292577)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/history/BackForwardCache.cpp 2022-04-07 22:59:01 UTC (rev 292576)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/history/BackForwardCache.cpp 2022-04-08 00:07:40 UTC (rev 292577)
@@ -388,10 +388,9 @@
static void setBackForwardCacheState(Page& page, Document::BackForwardCacheState BackForwardCacheState)
{
-for (Frame* frame = (); frame; frame = frame->tree().traverseNext()) {
-if (auto* document = frame->document())
-document->setBackForwardCacheState(BackForwardCacheState);
-}
+page.forEachDocument([&] (Document& document) {
+document.setBackForwardCacheState(BackForwardCacheState);
+});
}
// When entering back/forward cache, tear down the render tree before setting the in-cache flag.
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/page/EventHandler.cpp (292576 => 292577)
--- releases/WebKitGTK/webkit-2.34/Source/WebCore/page/EventHandler.cpp 2022-04-07 22:59:01 UTC (rev 292576)
+++ releases/WebKitGTK/webkit-2.34/Source/WebCore/page/EventHandler.cpp 2022-04-08 00:07:40 UTC (rev 292577)
@@ -3878,10 +3878,9 @@
static void removeDraggedContentDocumentMarkersFromAllFramesInPage(Page& page)
{
-for (RefPtr frame = (); frame; frame = frame->tree().traverseNext()) {
-if (RefPtr document = frame->document())
-document->markers().removeMarkers(DocumentMarker::DraggedContent);
-}
+page.forEachDocument([] (Document& document) {
+document.markers().removeMarkers(DocumentMarker::DraggedContent);
+});
if (auto* mainFrameRenderer = page.mainFrame().contentRenderer())
mainFrameRenderer->repaintRootContents();
Modified: releases/WebKitGTK/webkit-2.34/Source/WebCore/page/Frame.cpp (292576 => 292577)
---
[webkit-changes] [292576] trunk/Tools
Title: [292576] trunk/Tools Revision 292576 Author jbed...@apple.com Date 2022-04-07 15:59:01 -0700 (Thu, 07 Apr 2022) Log Message [Merge-Queue] Add PushCommitToWebKitRepo https://bugs.webkit.org/show_bug.cgi?id=238959 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/factories.py: (MergeQueueFactory.__init__): Add PushCommitToWebKitRepo, pre-commit validation. * Tools/CISupport/ews-build/factories_unittest.py: (TestExpectedBuildSteps): Ditto. * Tools/CISupport/ews-build/steps.py: (PushCommitToWebKitRepo.evaluateCommand): Add merge-queue steps. (PushCommitToWebKitRepo.getResultSummary): Remove identifier computation. (PushCommitToWebKitRepo.svn_revision_from_commit_text): (DetermineLandedIdentifier): Move code to determine identifier into a seperate step because merge-queue has already computed the identifier. (DetermineLandedIdentifier.__init__): (DetermineLandedIdentifier.start): Capture log output of command. (DetermineLandedIdentifier.getResultSummary): (DetermineLandedIdentifier.evaluateCommand): Attempt to pull identifier from commit message, otherwise, fall back to commits.webkit.org. (DetermineLandedIdentifier.url_for_revision_details): Moved from PushCommitToWebKitRepo. (DetermineLandedIdentifier.url_for_identifier): Ditto. (DetermineLandedIdentifier.identifier_for_revision): Ditto. (DetermineLandedIdentifier.comment_text_for_bug): Ditto. * Tools/CISupport/ews-build/steps_unittest.py: Canonical link: https://commits.webkit.org/249414@main Modified Paths trunk/Tools/CISupport/ews-build/factories.py trunk/Tools/CISupport/ews-build/factories_unittest.py trunk/Tools/CISupport/ews-build/steps.py trunk/Tools/CISupport/ews-build/steps_unittest.py trunk/Tools/ChangeLog Diff Modified: trunk/Tools/CISupport/ews-build/factories.py (292575 => 292576) --- trunk/Tools/CISupport/ews-build/factories.py 2022-04-07 22:56:25 UTC (rev 292575) +++ trunk/Tools/CISupport/ews-build/factories.py 2022-04-07 22:59:01 UTC (rev 292576) @@ -28,11 +28,11 @@ CheckOutPullRequest, CheckOutSource, CheckOutSpecificRevision, CheckChangeRelevance, CheckPatchStatusOnEWSQueues, CheckStyle, CleanGitRepo, CompileJSC, CompileWebKit, ConfigureBuild, CreateLocalGITCommit, DownloadBuiltProduct, ExtractBuiltProduct, FetchBranches, FindModifiedChangeLogs, FindModifiedLayoutTests, GitSvnFetch, - InstallGtkDependencies, InstallWpeDependencies, KillOldProcesses, PrintConfiguration, PushCommitToWebKitRepo, PushPullRequestBranch, + InstallGtkDependencies, InstallWpeDependencies, KillOldProcesses, PrintConfiguration, PushCommitToWebKitRepo, RunAPITests, RunBindingsTests, RunBuildWebKitOrgUnitTests, RunBuildbotCheckConfigForBuildWebKit, RunBuildbotCheckConfigForEWS, RunEWSUnitTests, RunResultsdbpyTests, RunJavaScriptCoreTests, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyPython2Tests, RunWebKitPyPython3Tests, RunWebKitTests, RunWebKitTestsRedTree, RunWebKitTestsInStressMode, RunWebKitTestsInStressGuardmallocMode, - SetBuildSummary, ShowIdentifier, TriggerCrashLogSubmission, UpdatePullRequest, UpdateWorkingDirectory, + SetBuildSummary, ShowIdentifier, TriggerCrashLogSubmission, UpdateWorkingDirectory, ValidateCommitMessage, ValidateChange, ValidateChangeLogAndReviewer, ValidateCommitterAndReviewer, WaitForCrashCollection, InstallBuiltProduct, VerifyGitHubIntegrity, ValidateSquashed) @@ -338,6 +338,7 @@ self.addStep(AddReviewerToChangeLog()) self.addStep(ValidateCommitMessage()) self.addStep(ValidateChangeLogAndReviewer()) +self.addStep(ValidateChange(verifyMergeQueue=True, verifyNoDraftForMergeQueue=True)) self.addStep(Canonicalize()) -self.addStep(PushPullRequestBranch()) -self.addStep(UpdatePullRequest()) +self.addStep(PushCommitToWebKitRepo()) +self.addStep(SetBuildSummary()) Modified: trunk/Tools/CISupport/ews-build/factories_unittest.py (292575 => 292576) --- trunk/Tools/CISupport/ews-build/factories_unittest.py 2022-04-07 22:56:25 UTC (rev 292575) +++ trunk/Tools/CISupport/ews-build/factories_unittest.py 2022-04-07 22:59:01 UTC (rev 292576) @@ -645,9 +645,10 @@ 'add-reviewer-to-changelog', 'validate-commit-message', 'validate-changelog-and-reviewer', +'validate-change', 'canonicalize-commit', -'push-pull-request-branch', -'update-pull-request', +'push-commit-to-webkit-repo', +'set-build-summary' ], } Modified: trunk/Tools/CISupport/ews-build/steps.py (292575 => 292576) --- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 22:56:25 UTC (rev 292575) +++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 22:59:01 UTC (rev 292576) @@ -4497,28 +4497,130 @@ def
[webkit-changes] [292575] trunk/Source/WebCore
Title: [292575] trunk/Source/WebCore Revision 292575 Author zimmerm...@webkit.org Date 2022-04-07 15:56:25 -0700 (Thu, 07 Apr 2022) Log Message Unify reference box / CTM computation in RenderLayer https://bugs.webkit.org/show_bug.cgi?id=237701 Reviewed by Rob Buis. Extract the code in RenderLayer that computes the reference box, obtains the CTM, applies pixel snapping, etc. into a shared updateTransformFromStyle() helper function. Use that helper to de-duplicate code between updateTransform() / currentTransform() (and RenderLayerBacking::updateTransform() in follow-up patches). currentTransform() needs to compute the CTM, based on a non-default RenderStyle (!= renderer().style()), namely the aninmatedStyle(), if an accelerated transform animation is running. Therefore extend RenderLayerModelObject::applyTransform() to take an additional RenderStyle parameter, that is used to access the CSS transform operations, instead of always querying renderer().style(). RenderLayer::updateTransform() continues to pass 'renderer().style()' to updateTransformFromStyle(), whereas RenderLayer::currentTransform() passes the elements animatedStyle(). Covered by existing tests, no change in behaviour. * rendering/RenderBox.cpp: (WebCore::RenderBox::applyTransform const): * rendering/RenderBox.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::applyTransform const): * rendering/RenderBoxModelObject.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransformFromStyle const): (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::currentTransform const): * rendering/RenderLayer.h: * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateTransform): * rendering/RenderLayerModelObject.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::applyTransform const): Deleted. * rendering/svg/RenderSVGModelObject.h: * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::applyTransform const): Deleted. * rendering/svg/RenderSVGRoot.h: * rendering/svg/RenderSVGShape.cpp: (WebCore::RenderSVGShape::applyTransform const): * rendering/svg/RenderSVGShape.h: * rendering/svg/RenderSVGTransformableContainer.cpp: (WebCore::RenderSVGTransformableContainer::applyTransform const): * rendering/svg/RenderSVGTransformableContainer.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBox.cpp trunk/Source/WebCore/rendering/RenderBox.h trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderBoxModelObject.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h trunk/Source/WebCore/rendering/RenderLayerBacking.cpp trunk/Source/WebCore/rendering/RenderLayerModelObject.h trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.cpp trunk/Source/WebCore/rendering/svg/RenderSVGModelObject.h trunk/Source/WebCore/rendering/svg/RenderSVGRoot.cpp trunk/Source/WebCore/rendering/svg/RenderSVGRoot.h trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp trunk/Source/WebCore/rendering/svg/RenderSVGShape.h trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.cpp trunk/Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h Diff Modified: trunk/Source/WebCore/ChangeLog (292574 => 292575) --- trunk/Source/WebCore/ChangeLog 2022-04-07 22:50:19 UTC (rev 292574) +++ trunk/Source/WebCore/ChangeLog 2022-04-07 22:56:25 UTC (rev 292575) @@ -1,3 +1,51 @@ +2022-04-07 Nikolas Zimmermann + +Unify reference box / CTM computation in RenderLayer +https://bugs.webkit.org/show_bug.cgi?id=237701 + +Reviewed by Rob Buis. + +Extract the code in RenderLayer that computes the reference box, obtains the CTM, +applies pixel snapping, etc. into a shared updateTransformFromStyle() helper function. +Use that helper to de-duplicate code between updateTransform() / currentTransform() +(and RenderLayerBacking::updateTransform() in follow-up patches). + +currentTransform() needs to compute the CTM, based on a non-default RenderStyle (!= renderer().style()), +namely the aninmatedStyle(), if an accelerated transform animation is running. Therefore extend +RenderLayerModelObject::applyTransform() to take an additional RenderStyle parameter, +that is used to access the CSS transform operations, instead of always querying renderer().style(). +RenderLayer::updateTransform() continues to pass 'renderer().style()' to updateTransformFromStyle(), +whereas RenderLayer::currentTransform() passes the elements animatedStyle(). + +Covered by existing tests, no change in behaviour. + +* rendering/RenderBox.cpp: +(WebCore::RenderBox::applyTransform const): +* rendering/RenderBox.h: +* rendering/RenderBoxModelObject.cpp: +(WebCore::RenderBoxModelObject::applyTransform const): +* rendering/RenderBoxModelObject.h: +*
[webkit-changes] [292574] trunk/Source/WebGPU
Title: [292574] trunk/Source/WebGPU
Revision 292574
Author mmaxfi...@apple.com
Date 2022-04-07 15:50:19 -0700 (Thu, 07 Apr 2022)
Log Message
[WebGPU] Add support for the "is valid to use with" operation to WebGPU objects
https://bugs.webkit.org/show_bug.cgi?id=238719
Addressing post-review comment.
Unreviewed.
* WebGPU/IsValidToUseWith.h:
(WebGPU::isValidToUseWith):
(WebGPU::isValidToUseWith const): Deleted.
Modified Paths
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/IsValidToUseWith.h
Diff
Modified: trunk/Source/WebGPU/ChangeLog (292573 => 292574)
--- trunk/Source/WebGPU/ChangeLog 2022-04-07 22:44:09 UTC (rev 292573)
+++ trunk/Source/WebGPU/ChangeLog 2022-04-07 22:50:19 UTC (rev 292574)
@@ -1,5 +1,18 @@
2022-04-07 Myles C. Maxfield
+[WebGPU] Add support for the "is valid to use with" operation to WebGPU objects
+https://bugs.webkit.org/show_bug.cgi?id=238719
+
+Addressing post-review comment.
+
+Unreviewed.
+
+* WebGPU/IsValidToUseWith.h:
+(WebGPU::isValidToUseWith):
+(WebGPU::isValidToUseWith const): Deleted.
+
+2022-04-07 Myles C. Maxfield
+
[WebGPU] Give objects a notion of invalidity
https://bugs.webkit.org/show_bug.cgi?id=238720
Modified: trunk/Source/WebGPU/WebGPU/IsValidToUseWith.h (292573 => 292574)
--- trunk/Source/WebGPU/WebGPU/IsValidToUseWith.h 2022-04-07 22:44:09 UTC (rev 292573)
+++ trunk/Source/WebGPU/WebGPU/IsValidToUseWith.h 2022-04-07 22:50:19 UTC (rev 292574)
@@ -28,7 +28,7 @@
namespace WebGPU {
template
-bool isValidToUseWith(const T& object, const U& targetObject) const
+bool isValidToUseWith(const T& object, const U& targetObject)
{
// https://gpuweb.github.io/gpuweb/#abstract-opdef-valid-to-use-with
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292573] trunk/Tools
Title: [292573] trunk/Tools
Revision 292573
Author jbed...@apple.com
Date 2022-04-07 15:44:09 -0700 (Thu, 07 Apr 2022)
Log Message
[Merge-Queue] Canonicalize parent commits
https://bugs.webkit.org/show_bug.cgi?id=238951
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(Canonicalize.run): Canonicalize first 2 parent commits if not rebasing.
(Canonicalize.getResultSummary): Pluralize summary.
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249411@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (292572 => 292573)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 22:41:56 UTC (rev 292572)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 22:44:09 UTC (rev 292573)
@@ -4912,7 +4912,7 @@
['git', 'branch', '-f', base_ref, head_ref],
['git', 'checkout', base_ref],
]
-commands.append(['python3', 'Tools/Scripts/git-webkit', 'canonicalize', '-n', '1'])
+commands.append(['python3', 'Tools/Scripts/git-webkit', 'canonicalize', '-n', '1' if self.rebase_enabled else '3'])
for command in commands:
self.commands.append(util.ShellArg(command=command, logname='stdio', haltOnFailure=True))
@@ -4920,10 +4920,11 @@
return super(Canonicalize, self).run()
def getResultSummary(self):
+commit_pluralized = "commit" if self.rebase_enabled else "commits"
if self.results == SUCCESS:
-return {'step': 'Canonicalized commit'}
+return {'step': f'Canonicalized {commit_pluralized}'}
if self.results == FAILURE:
-return {'step': 'Failed to canonicalize commit'}
+return {'step': f'Failed to canonicalize {commit_pluralized}'}
return super(Canonicalize, self).getResultSummary()
def doStepIf(self, step):
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (292572 => 292573)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-07 22:41:56 UTC (rev 292572)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-07 22:44:09 UTC (rev 292573)
@@ -6147,10 +6147,10 @@
workdir='wkdir',
timeout=300,
logEnviron=False,
-command=['python3', 'Tools/Scripts/git-webkit', 'canonicalize', '-n', '1'],
+command=['python3', 'Tools/Scripts/git-webkit', 'canonicalize', '-n', '3'],
) + 0,
)
-self.expectOutcome(result=SUCCESS, state_string='Canonicalized commit')
+self.expectOutcome(result=SUCCESS, state_string='Canonicalized commits')
return self.runStep()
def test_failure(self):
Modified: trunk/Tools/ChangeLog (292572 => 292573)
--- trunk/Tools/ChangeLog 2022-04-07 22:41:56 UTC (rev 292572)
+++ trunk/Tools/ChangeLog 2022-04-07 22:44:09 UTC (rev 292573)
@@ -1,5 +1,18 @@
2022-04-07 Jonathan Bedard
+[Merge-Queue] Canonicalize parent commits
+https://bugs.webkit.org/show_bug.cgi?id=238951
+
+
+Reviewed by Aakash Jain.
+
+* CISupport/ews-build/steps.py:
+(Canonicalize.run): Canonicalize first 2 parent commits if not rebasing.
+(Canonicalize.getResultSummary): Pluralize summary.
+* CISupport/ews-build/steps_unittest.py:
+
+2022-04-07 Jonathan Bedard
+
[Merge-Queue] Change label names
https://bugs.webkit.org/show_bug.cgi?id=238950
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292572] trunk/Source/WebCore
Title: [292572] trunk/Source/WebCore
Revision 292572
Author j...@apple.com
Date 2022-04-07 15:41:56 -0700 (Thu, 07 Apr 2022)
Log Message
Full screen video progress bar flickers after dragging it.
https://bugs.webkit.org/show_bug.cgi?id=238859
rdar://90412851
A WebAVPlayerController pretends to be an AVPlayerController by
implementing most methods of it, but not all.
When dragging the progress bar, AVKit calls the method isSeeking to
determine if we are seeking or not and if true will call seekToTime
to retrieve the last seek position and display the progress bar
accordingly.
Those two methods weren't implemented by WebAVPlayerController.
At present, we don't have information about the seeking operation having
completed or not, but we do know if we are scrubbing. So map isSeeking
to isScrubbing, this approximation is sufficient at present.
Reviewed by Jer Noble.
* platform/ios/WebAVPlayerController.h:
* platform/ios/WebAVPlayerController.mm:
(-[WebAVPlayerController seekToTime:]):
(-[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]):
(-[WebAVPlayerController isSeeking]):
(-[WebAVPlayerController seekToTime]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/WebAVPlayerController.h
trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (292571 => 292572)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 22:38:48 UTC (rev 292571)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07 22:41:56 UTC (rev 292572)
@@ -1,3 +1,29 @@
+2022-04-07 Jean-Yves Avenard
+
+Full screen video progress bar flickers after dragging it.
+https://bugs.webkit.org/show_bug.cgi?id=238859
+rdar://90412851
+
+A WebAVPlayerController pretends to be an AVPlayerController by
+implementing most methods of it, but not all.
+When dragging the progress bar, AVKit calls the method isSeeking to
+determine if we are seeking or not and if true will call seekToTime
+to retrieve the last seek position and display the progress bar
+accordingly.
+Those two methods weren't implemented by WebAVPlayerController.
+At present, we don't have information about the seeking operation having
+completed or not, but we do know if we are scrubbing. So map isSeeking
+to isScrubbing, this approximation is sufficient at present.
+
+Reviewed by Jer Noble.
+
+* platform/ios/WebAVPlayerController.h:
+* platform/ios/WebAVPlayerController.mm:
+(-[WebAVPlayerController seekToTime:]):
+(-[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]):
+(-[WebAVPlayerController isSeeking]):
+(-[WebAVPlayerController seekToTime]):
+
2022-04-07 Simon Fraser
Add a LayerBacking RenderingPurpose
Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.h (292571 => 292572)
--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.h 2022-04-07 22:38:48 UTC (rev 292571)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.h 2022-04-07 22:41:56 UTC (rev 292572)
@@ -61,6 +61,8 @@
@property (readonly) BOOL canSeekFrameBackward;
@property (readonly) BOOL canSeekFrameForward;
@property (readonly) BOOL hasContentChapters;
+@property (readonly) BOOL isSeeking;
+@property (readonly) NSTimeInterval seekToTime;
@property BOOL canPlay;
@property (getter=isPlaying) BOOL playing;
Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm (292571 => 292572)
--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm 2022-04-07 22:38:48 UTC (rev 292571)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm 2022-04-07 22:41:56 UTC (rev 292572)
@@ -65,6 +65,7 @@
BOOL _liveStreamEventModePossible;
BOOL _isScrubbing;
BOOL _allowsPictureInPicture;
+NSTimeInterval _seekToTime;
}
- (instancetype)init
@@ -271,6 +272,7 @@
- (void)seekToTime:(NSTimeInterval)time
{
+_seekToTime = time;
if (self.delegate)
self.delegate->seekToTime(time);
}
@@ -277,6 +279,7 @@
- (void)seekToTime:(NSTimeInterval)time toleranceBefore:(NSTimeInterval)before toleranceAfter:(NSTimeInterval)after
{
+_seekToTime = time;
if (self.delegate)
self.delegate->seekToTime(time, before, after);
}
@@ -395,6 +398,16 @@
return _isScrubbing;
}
+- (BOOL)isSeeking
+{
+return _isScrubbing;
+}
+
+- (NSTimeInterval)seekToTime
+{
+return _seekToTime;
+}
+
- (BOOL)canScanForward
{
return [self canPlay];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292571] trunk/LayoutTests
Title: [292571] trunk/LayoutTests Revision 292571 Author matteo_flo...@apple.com Date 2022-04-07 15:38:48 -0700 (Thu, 07 Apr 2022) Log Message [ iOS EWS ] css3/background/background-repeat-round-auto2.html is a image failure https://bugs.webkit.org/show_bug.cgi?id=238965 Unreviewed test gardening. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292570 => 292571) --- trunk/LayoutTests/ChangeLog 2022-04-07 22:34:38 UTC (rev 292570) +++ trunk/LayoutTests/ChangeLog 2022-04-07 22:38:48 UTC (rev 292571) @@ -1,5 +1,14 @@ 2022-04-07 Matteo Flores +[ iOS EWS ] css3/background/background-repeat-round-auto2.html is a image failure +https://bugs.webkit.org/show_bug.cgi?id=238965 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2022-04-07 Matteo Flores + [ iOS EWS ] fast/attachment/attachment-disabled-rendering.html is a text missing failure https://bugs.webkit.org/show_bug.cgi?id=238960 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (292570 => 292571) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 22:34:38 UTC (rev 292570) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 22:38:48 UTC (rev 292571) @@ -2177,9 +2177,12 @@ # This test is currently failing on EWS webkit.org/b/238954 imported/w3c/web-platform-tests/css/selectors/invalidation/user-action-pseudo-classes-in-has.html [ Pass Failure ] -#This test is currently failing on EWS +# This test is currently failing on EWS webkit.org/b/238960 fast/attachment/attachment-disabled-rendering.html [ Pass Failure ] +# This failure is only happening on EWS +webkit.org/b/238965 css3/background/background-repeat-round-auto2.html [ Pass ImageOnlyFailure ] + webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ] webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292570] trunk/LayoutTests/imported/w3c
Title: [292570] trunk/LayoutTests/imported/w3c
Revision 292570
Author matteo_flo...@apple.com
Date 2022-04-07 15:34:38 -0700 (Thu, 07 Apr 2022)
Log Message
REGRESSION(r291509): imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html is a constant text failure
https://bugs.webkit.org/show_bug.cgi?id=238920
Reviewed by Cameron McCormack.
Fixed typo.
* web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html:
Modified Paths
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (292569 => 292570)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-07 21:55:03 UTC (rev 292569)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-04-07 22:34:38 UTC (rev 292570)
@@ -1,3 +1,14 @@
+2022-04-07 Matteo Flores
+
+REGRESSION(r291509): imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html is a constant text failure
+https://bugs.webkit.org/show_bug.cgi?id=238920
+
+Reviewed by Cameron McCormack.
+
+Fixed typo.
+
+* web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html:
+
2022-04-07 Matt Woodrow
Grid items that establish an independent formatting context should not be subgrids.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html (292569 => 292570)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html 2022-04-07 21:55:03 UTC (rev 292569)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html 2022-04-07 22:34:38 UTC (rev 292570)
@@ -13,7 +13,7 @@
for (let scaleImage of [false, true]) {
async_test(function(t) {
let video = document.createElement("video");
-let testVidoe = t.step_func_done(function() {
+let testVideo = t.step_func_done(function() {
let canvas = document.createElement("canvas");
canvas.width = 2;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292569] trunk/Source
Title: [292569] trunk/Source
Revision 292569
Author simon.fra...@apple.com
Date 2022-04-07 14:55:03 -0700 (Thu, 07 Apr 2022)
Log Message
Add a LayerBacking RenderingPurpose
https://bugs.webkit.org/show_bug.cgi?id=238896
Reviewed by Said Abou-Hallawa.
Add RenderingPurpose::LayerBacking so the GPU Process knows which buffers are
associated with layer backing.
Source/WebCore:
* platform/graphics/RenderingMode.h:
Source/WebKit:
* Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
(WebKit::RemoteLayerBackingStoreCollection::allocateBufferForBackingStore):
* Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm:
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::allocateBufferForBackingStore):
* Shared/WebCoreArgumentCoders.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldUseRemoteRenderingFor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/RenderingMode.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm
trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h
trunk/Source/WebKit/WebProcess/WebProcess.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292568 => 292569)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 21:46:28 UTC (rev 292568)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07 21:55:03 UTC (rev 292569)
@@ -1,3 +1,15 @@
+2022-04-07 Simon Fraser
+
+Add a LayerBacking RenderingPurpose
+https://bugs.webkit.org/show_bug.cgi?id=238896
+
+Reviewed by Said Abou-Hallawa.
+
+Add RenderingPurpose::LayerBacking so the GPU Process knows which buffers are
+associated with layer backing.
+
+* platform/graphics/RenderingMode.h:
+
2022-04-07 Tyler Wilcock
AX ITM: ARIATreeItemContent, ARIATreeRows, and DisclosedRows properties need to be updated after dynamic page changes
Modified: trunk/Source/WebCore/platform/graphics/RenderingMode.h (292568 => 292569)
--- trunk/Source/WebCore/platform/graphics/RenderingMode.h 2022-04-07 21:46:28 UTC (rev 292568)
+++ trunk/Source/WebCore/platform/graphics/RenderingMode.h 2022-04-07 21:55:03 UTC (rev 292569)
@@ -31,6 +31,7 @@
Unspecified,
Canvas,
DOM,
+LayerBacking,
MediaPainting
};
Modified: trunk/Source/WebKit/ChangeLog (292568 => 292569)
--- trunk/Source/WebKit/ChangeLog 2022-04-07 21:46:28 UTC (rev 292568)
+++ trunk/Source/WebKit/ChangeLog 2022-04-07 21:55:03 UTC (rev 292569)
@@ -1,3 +1,21 @@
+2022-04-07 Simon Fraser
+
+Add a LayerBacking RenderingPurpose
+https://bugs.webkit.org/show_bug.cgi?id=238896
+
+Reviewed by Said Abou-Hallawa.
+
+Add RenderingPurpose::LayerBacking so the GPU Process knows which buffers are
+associated with layer backing.
+
+* Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:
+(WebKit::RemoteLayerBackingStoreCollection::allocateBufferForBackingStore):
+* Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm:
+(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::allocateBufferForBackingStore):
+* Shared/WebCoreArgumentCoders.h:
+* WebProcess/WebProcess.cpp:
+(WebKit::WebProcess::shouldUseRemoteRenderingFor):
+
2022-04-07 Per Arne Vollan
[iOS][WP] Block kernel routines
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm (292568 => 292569)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm 2022-04-07 21:46:28 UTC (rev 292568)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm 2022-04-07 21:55:03 UTC (rev 292569)
@@ -264,9 +264,9 @@
{
switch (backingStore.type()) {
case RemoteLayerBackingStore::Type::IOSurface:
-return WebCore::ConcreteImageBuffer::create(backingStore.size(), backingStore.scale(), WebCore::DestinationColorSpace::SRGB(), backingStore.pixelFormat(), WebCore::RenderingPurpose::DOM, { nullptr, ::IOSurfacePool::sharedPool() });
+return WebCore::ConcreteImageBuffer::create(backingStore.size(), backingStore.scale(), WebCore::DestinationColorSpace::SRGB(), backingStore.pixelFormat(), WebCore::RenderingPurpose::LayerBacking, { nullptr, ::IOSurfacePool::sharedPool() });
case RemoteLayerBackingStore::Type::Bitmap:
-return WebCore::ConcreteImageBuffer::create(backingStore.size(), backingStore.scale(), WebCore::DestinationColorSpace::SRGB(), backingStore.pixelFormat(), WebCore::RenderingPurpose::DOM, { });
+return WebCore::ConcreteImageBuffer::create(backingStore.size(), backingStore.scale(), WebCore::DestinationColorSpace::SRGB(), backingStore.pixelFormat(), WebCore::RenderingPurpose::LayerBacking, { });
}
return nullptr;
}
Modified:
[webkit-changes] [292568] trunk/LayoutTests
Title: [292568] trunk/LayoutTests Revision 292568 Author matteo_flo...@apple.com Date 2022-04-07 14:46:28 -0700 (Thu, 07 Apr 2022) Log Message [ iOS EWS ] fast/attachment/attachment-disabled-rendering.html is a text missing failure https://bugs.webkit.org/show_bug.cgi?id=238960 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292567 => 292568) --- trunk/LayoutTests/ChangeLog 2022-04-07 21:44:00 UTC (rev 292567) +++ trunk/LayoutTests/ChangeLog 2022-04-07 21:46:28 UTC (rev 292568) @@ -1,3 +1,12 @@ +2022-04-07 Matteo Flores + +[ iOS EWS ] fast/attachment/attachment-disabled-rendering.html is a text missing failure +https://bugs.webkit.org/show_bug.cgi?id=238960 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2022-04-07 Devin Rousso [GPU Process] Test failures in forms Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (292567 => 292568) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 21:44:00 UTC (rev 292567) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 21:46:28 UTC (rev 292568) @@ -2177,6 +2177,9 @@ # This test is currently failing on EWS webkit.org/b/238954 imported/w3c/web-platform-tests/css/selectors/invalidation/user-action-pseudo-classes-in-has.html [ Pass Failure ] +#This test is currently failing on EWS +webkit.org/b/238960 fast/attachment/attachment-disabled-rendering.html [ Pass Failure ] + webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ] webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292567] trunk/Source/WebGPU
Title: [292567] trunk/Source/WebGPU Revision 292567 Author mmaxfi...@apple.com Date 2022-04-07 14:44:00 -0700 (Thu, 07 Apr 2022) Log Message [WebGPU] Give objects a notion of invalidity https://bugs.webkit.org/show_bug.cgi?id=238720 Reviewed by Kimmo Kinnunen. This is the biggest blocker for running the WebGPU conformance test suite. WebGPU is designed such that creation routines don't return undefined if the object couldn't be created; instead, in "invalid" object is returned. This patch is a step on the path to making creation routines never return nullptr. Some objects have destroy() methods which makes the object invalid. Those will be implemented in a forthcoming patch. * WebGPU/Adapter.h: (WebGPU::Adapter::createInvalid): (WebGPU::Adapter::isValid const): * WebGPU/Adapter.mm: (WebGPU::Adapter::Adapter): * WebGPU/BindGroup.h: (WebGPU::BindGroup::createInvalid): (WebGPU::BindGroup::isValid const): * WebGPU/BindGroup.mm: (WebGPU::BindGroup::BindGroup): * WebGPU/BindGroupLayout.h: (WebGPU::BindGroupLayout::createInvalid): (WebGPU::BindGroupLayout::isValid const): * WebGPU/BindGroupLayout.mm: (WebGPU::BindGroupLayout::BindGroupLayout): * WebGPU/Buffer.h: (WebGPU::Buffer::createInvalid): (WebGPU::Buffer::isValid const): * WebGPU/Buffer.mm: (WebGPU::Buffer::Buffer): * WebGPU/CommandBuffer.h: (WebGPU::CommandBuffer::createInvalid): (WebGPU::CommandBuffer::isValid const): * WebGPU/CommandBuffer.mm: (WebGPU::CommandBuffer::CommandBuffer): * WebGPU/CommandEncoder.h: (WebGPU::CommandEncoder::createInvalid): (WebGPU::CommandEncoder::isValid const): * WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::CommandEncoder): * WebGPU/ComputePassEncoder.h: (WebGPU::ComputePassEncoder::createInvalid): (WebGPU::ComputePassEncoder::isValid const): * WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::ComputePassEncoder): * WebGPU/ComputePipeline.h: (WebGPU::ComputePipeline::createInvalid): (WebGPU::ComputePipeline::isValid const): * WebGPU/ComputePipeline.mm: (WebGPU::ComputePipeline::ComputePipeline): * WebGPU/Device.h: (WebGPU::Device::createInvalid): (WebGPU::Device::isValid const): * WebGPU/Device.mm: (WebGPU::Device::Device): * WebGPU/Instance.h: (WebGPU::Instance::createInvalid): (WebGPU::Instance::isValid const): * WebGPU/Instance.mm: (WebGPU::Instance::Instance): (WebGPU::m_isValid): * WebGPU/PipelineLayout.h: (WebGPU::PipelineLayout::createInvalid): (WebGPU::PipelineLayout::isValid const): * WebGPU/PipelineLayout.mm: (WebGPU::PipelineLayout::PipelineLayout): * WebGPU/QuerySet.h: (WebGPU::QuerySet::createInvalid): (WebGPU::QuerySet::isValid const): * WebGPU/QuerySet.mm: (WebGPU::QuerySet::QuerySet): * WebGPU/Queue.h: (WebGPU::Queue::createInvalid): (WebGPU::Queue::isValid const): * WebGPU/Queue.mm: (WebGPU::Queue::Queue): * WebGPU/RenderBundle.h: (WebGPU::RenderBundle::createInvalid): (WebGPU::RenderBundle::isValid const): * WebGPU/RenderBundle.mm: (WebGPU::RenderBundle::RenderBundle): * WebGPU/RenderBundleEncoder.h: (WebGPU::RenderBundleEncoder::createInvalid): (WebGPU::RenderBundleEncoder::isValid const): * WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::RenderBundleEncoder): * WebGPU/RenderPassEncoder.h: (WebGPU::RenderPassEncoder::createInvalid): (WebGPU::RenderPassEncoder::isValid const): * WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::RenderPassEncoder): * WebGPU/RenderPipeline.h: (WebGPU::RenderPipeline::createInvalid): (WebGPU::RenderPipeline::isValid const): * WebGPU/RenderPipeline.mm: (WebGPU::RenderPipeline::RenderPipeline): * WebGPU/Sampler.h: (WebGPU::Sampler::createInvalid): (WebGPU::Sampler::isValid const): * WebGPU/Sampler.mm: (WebGPU::Sampler::Sampler): * WebGPU/ShaderModule.h: (WebGPU::ShaderModule::createInvalid): (WebGPU::ShaderModule::isValid const): * WebGPU/ShaderModule.mm: (WebGPU::ShaderModule::convertCheckResult): (WebGPU::ShaderModule::ShaderModule): (WebGPU::ShaderModule::getCompilationInfo): (WebGPU::ShaderModule::ast const): * WebGPU/Texture.h: (WebGPU::Texture::createInvalid): (WebGPU::Texture::isValid const): * WebGPU/Texture.mm: (WebGPU::Texture::Texture): * WebGPU/TextureView.h: (WebGPU::TextureView::createInvalid): (WebGPU::TextureView::isValid const): * WebGPU/TextureView.mm: (WebGPU::TextureView::TextureView): Modified Paths trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/WebGPU/Adapter.h trunk/Source/WebGPU/WebGPU/Adapter.mm trunk/Source/WebGPU/WebGPU/BindGroup.h trunk/Source/WebGPU/WebGPU/BindGroup.mm trunk/Source/WebGPU/WebGPU/BindGroupLayout.h trunk/Source/WebGPU/WebGPU/BindGroupLayout.mm trunk/Source/WebGPU/WebGPU/Buffer.h trunk/Source/WebGPU/WebGPU/Buffer.mm trunk/Source/WebGPU/WebGPU/CommandBuffer.h trunk/Source/WebGPU/WebGPU/CommandBuffer.mm trunk/Source/WebGPU/WebGPU/CommandEncoder.h trunk/Source/WebGPU/WebGPU/CommandEncoder.mm trunk/Source/WebGPU/WebGPU/ComputePassEncoder.h trunk/Source/WebGPU/WebGPU/ComputePassEncoder.mm trunk/Source/WebGPU/WebGPU/ComputePipeline.h trunk/Source/WebGPU/WebGPU/ComputePipeline.mm
[webkit-changes] [292566] trunk/LayoutTests
Title: [292566] trunk/LayoutTests Revision 292566 Author drou...@apple.com Date 2022-04-07 14:15:43 -0700 (Thu, 07 Apr 2022) Log Message [GPU Process] Test failures in forms https://bugs.webkit.org/show_bug.cgi?id=236927 Unreviewed, fix test failures and adjust related expectations. * fast/forms/autofocus-readonly-attribute.html: This test appeared to be failing because it ended before the `"focus"` event had a chance to fire. Make the test async by delaying its completion until after a `requestAnimationFrame` which should be enough time for the `"focus"` event to be dispatched (and handled). * fast/forms/input-text-autofocus.html: * fast/forms/input-text-autofocus-expected.txt: Slightly rework this test to manually tell the `testRunner` to `waitUntilDone`, as for some reason the `js-test-{pre,post}` test harness seems to somehow not output the `PASS` messages while still finishing the test (i.e. not a timeout). * platform/ios-simulator-wk2/TestExpectations: * platform/ios-wk2/TestExpectations: * platform/ipad/TestExpectations: Remove non-skipped expectations for: - fast/forms/ios/choose-select-option.html - fast/forms/autofocus-readonly-attribute.html - fast/forms/input-text-autofocus.html Note that `fast/forms/ios/choose-select-option.html` is still skipped on iPad, because there is already a `platform/ipad/fast/forms/choose-select-option.html` specifically to test iPad. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html trunk/LayoutTests/fast/forms/input-text-autofocus-expected.txt trunk/LayoutTests/fast/forms/input-text-autofocus.html trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/ipad/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292565 => 292566) --- trunk/LayoutTests/ChangeLog 2022-04-07 21:05:05 UTC (rev 292565) +++ trunk/LayoutTests/ChangeLog 2022-04-07 21:15:43 UTC (rev 292566) @@ -1,3 +1,32 @@ +2022-04-07 Devin Rousso + +[GPU Process] Test failures in forms +https://bugs.webkit.org/show_bug.cgi?id=236927 + + +Unreviewed, fix test failures and adjust related expectations. + +* fast/forms/autofocus-readonly-attribute.html: +This test appeared to be failing because it ended before the `"focus"` event had a chance +to fire. Make the test async by delaying its completion until after a `requestAnimationFrame` +which should be enough time for the `"focus"` event to be dispatched (and handled). + +* fast/forms/input-text-autofocus.html: +* fast/forms/input-text-autofocus-expected.txt: +Slightly rework this test to manually tell the `testRunner` to `waitUntilDone`, as for some +reason the `js-test-{pre,post}` test harness seems to somehow not output the `PASS` messages +while still finishing the test (i.e. not a timeout). + +* platform/ios-simulator-wk2/TestExpectations: +* platform/ios-wk2/TestExpectations: +* platform/ipad/TestExpectations: +Remove non-skipped expectations for: +- fast/forms/ios/choose-select-option.html +- fast/forms/autofocus-readonly-attribute.html +- fast/forms/input-text-autofocus.html +Note that `fast/forms/ios/choose-select-option.html` is still skipped on iPad, because there +is already a `platform/ipad/fast/forms/choose-select-option.html` specifically to test iPad. + 2022-04-07 Tyler Wilcock AX ITM: ARIATreeItemContent, ARIATreeRows, and DisclosedRows properties need to be updated after dynamic page changes Modified: trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html (292565 => 292566) --- trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html 2022-04-07 21:05:05 UTC (rev 292565) +++ trunk/LayoutTests/fast/forms/autofocus-readonly-attribute.html 2022-04-07 21:15:43 UTC (rev 292566) @@ -2,13 +2,19 @@-if (window.testRunner)+if (window.testRunner) { testRunner.dumpAsText(); +testRunner.waitUntilDone(); +} function log(msg) { var console = document.getElementById("console"); console.innerText = msg; } + +requestAnimationFrame(() => { +window.testRunner?.notifyDone(); +}); Modified: trunk/LayoutTests/fast/forms/input-text-autofocus-expected.txt (292565 => 292566) --- trunk/LayoutTests/fast/forms/input-text-autofocus-expected.txt 2022-04-07 21:05:05 UTC (rev 292565) +++ trunk/LayoutTests/fast/forms/input-text-autofocus-expected.txt 2022-04-07 21:15:43 UTC (rev 292566) @@ -1,8 +1,5 @@ Test for -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - PASS inputFocusCount is 1 PASS
[webkit-changes] [292565] trunk/Source/WebKit
Title: [292565] trunk/Source/WebKit Revision 292565 Author pvol...@apple.com Date 2022-04-07 14:05:05 -0700 (Thu, 07 Apr 2022) Log Message [iOS][WP] Block kernel routines https://bugs.webkit.org/show_bug.cgi?id=238898 Reviewed by Geoffrey Garen. Block kernel routines only used during launch of the WebContent process on iOS. This is based on collected telemetry. * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Diff Modified: trunk/Source/WebKit/ChangeLog (292564 => 292565) --- trunk/Source/WebKit/ChangeLog 2022-04-07 21:03:10 UTC (rev 292564) +++ trunk/Source/WebKit/ChangeLog 2022-04-07 21:05:05 UTC (rev 292565) @@ -1,3 +1,14 @@ +2022-04-07 Per Arne Vollan + +[iOS][WP] Block kernel routines +https://bugs.webkit.org/show_bug.cgi?id=238898 + +Reviewed by Geoffrey Garen. + +Block kernel routines only used during launch of the WebContent process on iOS. This is based on collected telemetry. + +* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: + 2022-04-07 Simon Fraser Have ImageBuffer store the RenderingPurpose, and send it to the GPU process Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (292564 => 292565) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-04-07 21:03:10 UTC (rev 292564) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-04-07 21:05:05 UTC (rev 292565) @@ -1645,8 +1645,7 @@ (allow mach-message-send (kernel-mig-routine-only-in-use-during-launch))) (with-filter (state-flag "WebContentProcessLaunched") -(allow mach-message-send -(with report) +(deny mach-message-send (with telemetry) (with message "kernel mig routine used after launch") (kernel-mig-routine-only-in-use-during-launch))) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292564] trunk
Title: [292564] trunk Revision 292564 Author tyle...@apple.com Date 2022-04-07 14:03:10 -0700 (Thu, 07 Apr 2022) Log Message AX ITM: ARIATreeItemContent, ARIATreeRows, and DisclosedRows properties need to be updated after dynamic page changes https://bugs.webkit.org/show_bug.cgi?id=238844 Reviewed by Chris Fleizach. Source/WebCore: Before this patch, we never updated these properties after initializing isolated objects, so they become inaccurate when content / rows were added or removed. Test: accessibility/mac/tree-properties-update-after-dynamic-change.html * accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::ariaTreeItemContent): Make this function return a value instead of by out-parameter. * accessibility/AccessibilityObject.h: * accessibility/AccessibilityObjectInterface.h: * accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeAttributeData): * accessibility/isolatedtree/AXIsolatedObject.h: * accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::updateNodeProperty): Handle updates to AXPropertyName::ARIATreeItemContent, AXPropertyName::ARIATreeRows, and AXPropertyName::DisclosedRows. Also, updateNodeProperty now takes an `AXCoreObject&` instead of `const AXCoreObject&` since calling ariaTreeItemContent(), ariaTreeRows(), and disclosedRows() is inherently not const. (WebCore::AXIsolatedTree::updateChildren): If the object being updated is a treeitem, also update AXPropertyName::ARIATreeItemContent and AXPropertyName::DisclosedRows. And if the object has a tree role ancestor, update AXPropertyName::ARIATreeRows for that ancestor. * accessibility/isolatedtree/AXIsolatedTree.h: * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): LayoutTests: * accessibility/mac/tree-properties-update-after-dynamic-change-expected.txt: Added. * accessibility/mac/tree-properties-update-after-dynamic-change.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm Added Paths trunk/LayoutTests/accessibility/mac/tree-properties-update-after-dynamic-change-expected.txt trunk/LayoutTests/accessibility/mac/tree-properties-update-after-dynamic-change.html Diff Modified: trunk/LayoutTests/ChangeLog (292563 => 292564) --- trunk/LayoutTests/ChangeLog 2022-04-07 20:58:35 UTC (rev 292563) +++ trunk/LayoutTests/ChangeLog 2022-04-07 21:03:10 UTC (rev 292564) @@ -1,3 +1,13 @@ +2022-04-07 Tyler Wilcock + +AX ITM: ARIATreeItemContent, ARIATreeRows, and DisclosedRows properties need to be updated after dynamic page changes +https://bugs.webkit.org/show_bug.cgi?id=238844 + +Reviewed by Chris Fleizach. + +* accessibility/mac/tree-properties-update-after-dynamic-change-expected.txt: Added. +* accessibility/mac/tree-properties-update-after-dynamic-change.html: Added. + 2022-04-07 Alan Bujtas Unreviewed test gardening. Added: trunk/LayoutTests/accessibility/mac/tree-properties-update-after-dynamic-change-expected.txt (0 => 292564) --- trunk/LayoutTests/accessibility/mac/tree-properties-update-after-dynamic-change-expected.txt (rev 0) +++ trunk/LayoutTests/accessibility/mac/tree-properties-update-after-dynamic-change-expected.txt 2022-04-07 21:03:10 UTC (rev 292564) @@ -0,0 +1,28 @@ +This test ensures that tree and treeitem objects report the most up-to-date children and rows after dynamic page changes. + +#treeitem1 childrenCount: 0 +#treeitem2 childrenCount: 0 +#tree rowCount: 3 +row 0: AXRole: AXRow, #treeitem1 +row 1: AXRole: AXRow, #treeitem2 +row 2: AXRole: AXRow, #treeitem3 + +Adding content to #treeitem1 and #treeitem2. + +#treeitem1 childrenCount: 1 +child: AXRole: AXButton +#treeitem2 childrenCount: 0 +#treeitem2 had disclosed row #treeitem3 +#treeitem2 had disclosed row #treeitem4 +#tree rowCount: 4 +row 0: AXRole: AXRow, #treeitem1 +row 1: AXRole: AXRow, #treeitem2 +row 2: AXRole: AXRow, #treeitem3 +row 3: AXRole: AXRow, #treeitem4 + +PASS successfullyParsed is true + +TEST COMPLETE +Button inside treeitem1 +Button inside treeitem3 +Button inside treeitem4 Added: trunk/LayoutTests/accessibility/mac/tree-properties-update-after-dynamic-change.html (0 => 292564) --- trunk/LayoutTests/accessibility/mac/tree-properties-update-after-dynamic-change.html (rev 0) +++
[webkit-changes] [292563] trunk/Source/WebCore
Title: [292563] trunk/Source/WebCore
Revision 292563
Author you...@apple.com
Date 2022-04-07 13:58:35 -0700 (Thu, 07 Apr 2022)
Log Message
(Safari 15 - iOS15): Increased audio latency on streaming via webrtc
https://bugs.webkit.org/show_bug.cgi?id=236363
Reviewed by Eric Carlson.
On macOS 12.3, the default preferred buffer size is roughly 100 ms.
This is ok for regular audio playback but is not desirable when playing realtime audio.
To reduce the perceived latency, we now reduce the preferred buffer size to 20ms
whenever playing an audio MediaStreamTrack, similarly to when capturing audio.
Manually tested.
* platform/audio/PlatformMediaSession.cpp:
* platform/audio/PlatformMediaSession.h:
* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp
trunk/Source/WebCore/platform/audio/PlatformMediaSession.h
trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (292562 => 292563)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 20:36:29 UTC (rev 292562)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07 20:58:35 UTC (rev 292563)
@@ -1,3 +1,22 @@
+2022-04-07 Youenn Fablet
+
+(Safari 15 - iOS15): Increased audio latency on streaming via webrtc
+https://bugs.webkit.org/show_bug.cgi?id=236363
+
+
+Reviewed by Eric Carlson.
+
+On macOS 12.3, the default preferred buffer size is roughly 100 ms.
+This is ok for regular audio playback but is not desirable when playing realtime audio.
+To reduce the perceived latency, we now reduce the preferred buffer size to 20ms
+whenever playing an audio MediaStreamTrack, similarly to when capturing audio.
+
+Manually tested.
+
+* platform/audio/PlatformMediaSession.cpp:
+* platform/audio/PlatformMediaSession.h:
+* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
+
2022-04-07 Antoine Quint
[web-animations] REGRESSION (r287881): loading performance for diply.com regressed
Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp (292562 => 292563)
--- trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp 2022-04-07 20:36:29 UTC (rev 292562)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSession.cpp 2022-04-07 20:58:35 UTC (rev 292563)
@@ -365,6 +365,11 @@
return m_client.canProduceAudio();
}
+bool PlatformMediaSession::hasMediaStreamSource() const
+{
+return m_client.hasMediaStreamSource();
+}
+
void PlatformMediaSession::canProduceAudioChanged()
{
PlatformMediaSessionManager::sharedManager().sessionCanProduceAudioChanged();
Modified: trunk/Source/WebCore/platform/audio/PlatformMediaSession.h (292562 => 292563)
--- trunk/Source/WebCore/platform/audio/PlatformMediaSession.h 2022-04-07 20:36:29 UTC (rev 292562)
+++ trunk/Source/WebCore/platform/audio/PlatformMediaSession.h 2022-04-07 20:58:35 UTC (rev 292563)
@@ -179,6 +179,7 @@
bool activeAudioSessionRequired() const;
bool canProduceAudio() const;
+bool hasMediaStreamSource() const;
void canProduceAudioChanged();
virtual void resetPlaybackSessionState() { }
Modified: trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm (292562 => 292563)
--- trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm 2022-04-07 20:36:29 UTC (rev 292562)
+++ trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm 2022-04-07 20:58:35 UTC (rev 292563)
@@ -113,6 +113,7 @@
int videoAudioCount = 0;
int audioCount = 0;
int webAudioCount = 0;
+int audioMediaStreamTrackCount = 0;
int captureCount = countActiveAudioCaptureSources();
bool hasAudibleAudioOrVideoMediaType = false;
bool isPlayingAudio = false;
@@ -126,9 +127,13 @@
break;
case PlatformMediaSession::MediaType::VideoAudio:
++videoAudioCount;
+if (session.canProduceAudio() && session.hasMediaStreamSource())
+++audioMediaStreamTrackCount;
break;
case PlatformMediaSession::MediaType::Audio:
++audioCount;
+if (session.canProduceAudio() && session.hasMediaStreamSource())
+++audioMediaStreamTrackCount;
break;
case PlatformMediaSession::MediaType::WebAudio:
if (session.canProduceAudio()) {
@@ -152,6 +157,7 @@
ALWAYS_LOG(LOGIDENTIFIER, "types: "
"AudioCapture(", captureCount, "), "
+"AudioTrack(", audioMediaStreamTrackCount, "), "
"Video(", videoCount, "), "
"Audio(", audioCount, "), "
"VideoAudio(", videoAudioCount, "), "
@@ -160,8 +166,8 @@
size_t bufferSize = m_defaultBufferSize;
if (webAudioCount)
bufferSize = AudioUtilities::renderQuantumSize;
-else if (captureCount) {
-// In case of audio capture, we want to grab 20 ms
[webkit-changes] [292562] trunk/LayoutTests
Title: [292562] trunk/LayoutTests Revision 292562 Author za...@apple.com Date 2022-04-07 13:36:29 -0700 (Thu, 07 Apr 2022) Log Message Unreviewed test gardening. * imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html: .html is rendered using the legacy codepath while -expected.html is renderer using the modern codepath. In case of fractional pixel values, they sometimes produce different final baselines due to (unintentional) implicit flooring in legacy line layout. While most of these intentional/unintentional floors/ceils are matched (with FIXMEs) in the modern line layout, some would make the line layout codebase a lot more complicated. These type of bugs are mostly not visible to the user anyway ever since we have stopped swapping between modern and legacy line layout dynamically (e.g. on selection). * imported/blink/fast/multicol/vertical-lr/float-content-break.html: * platform/ios-wk2/TestExpectations: * platform/ios/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break.html trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292561 => 292562) --- trunk/LayoutTests/ChangeLog 2022-04-07 20:32:29 UTC (rev 292561) +++ trunk/LayoutTests/ChangeLog 2022-04-07 20:36:29 UTC (rev 292562) @@ -1,3 +1,17 @@ +2022-04-07 Alan Bujtas + +Unreviewed test gardening. + +* imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html: +.html is rendered using the legacy codepath while -expected.html is renderer using the modern codepath. +In case of fractional pixel values, they sometimes produce different final baselines due to (unintentional) implicit flooring in legacy line layout. +While most of these intentional/unintentional floors/ceils are matched (with FIXMEs) in the modern line layout, some would make the line layout +codebase a lot more complicated. These type of bugs are mostly not visible to the user anyway ever since we have stopped swapping between modern +and legacy line layout dynamically (e.g. on selection). +* imported/blink/fast/multicol/vertical-lr/float-content-break.html: +* platform/ios-wk2/TestExpectations: +* platform/ios/TestExpectations: + 2022-04-07 Tim Nguyen [CSS resize property] Correct minimum size computation to allow resizing below initial size Modified: trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html (292561 => 292562) --- trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html 2022-04-07 20:32:29 UTC (rev 292561) +++ trunk/LayoutTests/imported/blink/fast/multicol/vertical-lr/float-content-break-expected.html 2022-04-07 20:36:29 UTC (rev 292562) @@ -2,6 +2,7 @@
[webkit-changes] [292561] trunk/Source/WebCore
Title: [292561] trunk/Source/WebCore
Revision 292561
Author grao...@webkit.org
Date 2022-04-07 13:32:29 -0700 (Thu, 07 Apr 2022)
Log Message
[web-animations] REGRESSION (r287881): loading performance for diply.com regressed
https://bugs.webkit.org/show_bug.cgi?id=238931
rdar://91190007
Reviewed by Simon Fraser.
We only need to resolve effects in the stack if they are targeting the property we are
considering for the creation, update or removal of a CSS Transition.
* style/Styleable.cpp:
(WebCore::updateCSSTransitionsForStyleableAndProperty):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/style/Styleable.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292560 => 292561)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 20:28:42 UTC (rev 292560)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07 20:32:29 UTC (rev 292561)
@@ -1,3 +1,17 @@
+2022-04-07 Antoine Quint
+
+[web-animations] REGRESSION (r287881): loading performance for diply.com regressed
+https://bugs.webkit.org/show_bug.cgi?id=238931
+rdar://91190007
+
+Reviewed by Simon Fraser.
+
+We only need to resolve effects in the stack if they are targeting the property we are
+considering for the creation, update or removal of a CSS Transition.
+
+* style/Styleable.cpp:
+(WebCore::updateCSSTransitionsForStyleableAndProperty):
+
2022-04-07 Gabriel Nava Marino
Iterate over copy of animated properties in WebCore::WebAnimation::commitStyles
Modified: trunk/Source/WebCore/style/Styleable.cpp (292560 => 292561)
--- trunk/Source/WebCore/style/Styleable.cpp 2022-04-07 20:28:42 UTC (rev 292560)
+++ trunk/Source/WebCore/style/Styleable.cpp 2022-04-07 20:32:29 UTC (rev 292561)
@@ -442,6 +442,14 @@
}
}
+auto effectTargetsProperty = [property](KeyframeEffect& effect) {
+if (effect.animatedProperties().contains(property))
+return true;
+if (auto* transition = dynamicDowncast(effect.animation()))
+return transition->property() == property;
+return false;
+};
+
// https://drafts.csswg.org/css-transitions-1/#before-change-style
// Define the before-change style as the computed values of all properties on the element as of the previous style change event, except with
// any styles derived from declarative animations such as CSS Transitions, CSS Animations, and SMIL Animations updated to the current time.
@@ -450,6 +458,8 @@
auto style = RenderStyle::clone(*lastStyleChangeEventStyle);
if (auto* keyframeEffectStack = styleable.keyframeEffectStack()) {
for (const auto& effect : keyframeEffectStack->sortedEffects()) {
+if (!effectTargetsProperty(*effect))
+continue;
auto* effectAnimation = effect->animation();
bool shouldUseTimelineTimeAtCreation = is(effectAnimation) && (!effectAnimation->startTime() || *effectAnimation->startTime() == styleable.element.document().timeline().currentTime());
effectAnimation->resolve(style, { nullptr }, shouldUseTimelineTimeAtCreation ? downcast(*effectAnimation).timelineTimeAtCreation() : std::nullopt);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292560] trunk/Source/WebCore
Title: [292560] trunk/Source/WebCore
Revision 292560
Author gnavamar...@apple.com
Date 2022-04-07 13:28:42 -0700 (Thu, 07 Apr 2022)
Log Message
Iterate over copy of animated properties in WebCore::WebAnimation::commitStyles
https://bugs.webkit.org/show_bug.cgi?id=238940
Reviewed by Antoine Quint.
WebAnimation::resolve can end up clearing the animated properties during iteration.
The proposal here will make a copy of the properties before applying the steps
outlined in the spec.
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::commitStyles):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/WebAnimation.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292559 => 292560)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 20:26:01 UTC (rev 292559)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07 20:28:42 UTC (rev 292560)
@@ -1,3 +1,18 @@
+2022-04-07 Gabriel Nava Marino
+
+Iterate over copy of animated properties in WebCore::WebAnimation::commitStyles
+https://bugs.webkit.org/show_bug.cgi?id=238940
+
+Reviewed by Antoine Quint.
+
+WebAnimation::resolve can end up clearing the animated properties during iteration.
+
+The proposal here will make a copy of the properties before applying the steps
+outlined in the spec.
+
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::commitStyles):
+
2022-04-07 Tim Nguyen
[CSS resize property] Correct minimum size computation to allow resizing below initial size
Modified: trunk/Source/WebCore/animation/WebAnimation.cpp (292559 => 292560)
--- trunk/Source/WebCore/animation/WebAnimation.cpp 2022-04-07 20:26:01 UTC (rev 292559)
+++ trunk/Source/WebCore/animation/WebAnimation.cpp 2022-04-07 20:28:42 UTC (rev 292560)
@@ -1477,9 +1477,10 @@
inlineStyle->setCssText(styledElement.getAttribute("style"));
auto& keyframeStack = styledElement.ensureKeyframeEffectStack(PseudoId::None);
-
+// During iteration resolve() could clear the underlying properties so we use a copy
+auto properties = effect->animatedProperties();
// 2.5 For each property, property, in targeted properties:
-for (auto property : effect->animatedProperties()) {
+for (auto property : properties) {
// 1. Let partialEffectStack be a copy of the effect stack for property on target.
// 2. If animation's replace state is removed, add all animation effects associated with animation whose effect target is target and which include
// property as a target property to partialEffectStack.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292559] trunk
Title: [292559] trunk Revision 292559 Author n...@apple.com Date 2022-04-07 13:26:01 -0700 (Thu, 07 Apr 2022) Log Message [CSS resize property] Correct minimum size computation to allow resizing below initial size https://bugs.webkit.org/show_bug.cgi?id=135335 Reviewed by Simon Fraser. Source/WebCore: Tests: - LayoutTests/fast/css/resize-above-min-size-and-below-initial-size.html - LayoutTests/fast/css/resize-below-min-intrinsic-size.html - LayoutTests/fast/css/resize-below-min-intrinsic-size-large-scrollbars.html - LayoutTests/fast/css/resize-below-min-size-zoomed.html - LayoutTests/fast/css/resize-below-min-size.html - LayoutTests/fast/css/resize-orthogonal-containing-block.html Ports the relevant Chromium changeset with a few tweaks: https://chromium-review.googlesource.com/c/chromium/src/+/545395/ The previous minimum size used to be whatever size was there before the first resize, which is wrong, and does not allow resizing below the initial size. It is now based on the min-width/height properties and the scroll corner size. It is no longer stored in ElementRareData since it is no longer fixed to the initial element size, but depends on the container on the element style. * dom/Element.cpp: (WebCore::Element::minimumSizeForResizing const): Deleted. (WebCore::Element::setMinimumSizeForResizing): Deleted. * dom/Element.h: * dom/ElementRareData.cpp: * dom/ElementRareData.h: (WebCore::ElementRareData::useTypes const): (WebCore::ElementRareData::ElementRareData): (WebCore::defaultMinimumSizeForResizing): Deleted. (WebCore::ElementRareData::minimumSizeForResizing const): Deleted. (WebCore::ElementRareData::setMinimumSizeForResizing): Deleted. * dom/NodeRareData.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::minimumSizeForResizing const): (WebCore::RenderLayer::resize): * rendering/RenderLayer.h: LayoutTests: Tests ported from the Chromium changeset: https://chromium-review.googlesource.com/c/chromium/src/+/545395/ They've been tweaked to: - not rely on - use WPT harness instead of Chrome specific methods - use async functions instead of callbacks * fast/css/resize-above-min-size-and-below-initial-size-expected.txt: Added. * fast/css/resize-above-min-size-and-below-initial-size.html: Added. * fast/css/resize-below-min-intrinsic-size-large-scrollbars-expected.txt: Added. * fast/css/resize-below-min-intrinsic-size-large-scrollbars.html: Added. * fast/css/resize-below-min-intrinsic-size-expected.txt: Added. * fast/css/resize-below-min-intrinsic-size.html: Added. * fast/css/resize-below-min-size-expected.txt: Added. * fast/css/resize-below-min-size-zoomed-expected.txt: Added. * fast/css/resize-below-min-size-zoomed.html: Added. * fast/css/resize-below-min-size.html: Added. * fast/css/resize-orthogonal-containing-block-expected.txt: Added. * fast/css/resize-orthogonal-containing-block.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/Element.h trunk/Source/WebCore/dom/ElementRareData.cpp trunk/Source/WebCore/dom/ElementRareData.h trunk/Source/WebCore/dom/NodeRareData.h trunk/Source/WebCore/rendering/RenderLayer.cpp trunk/Source/WebCore/rendering/RenderLayer.h Added Paths trunk/LayoutTests/fast/css/resize-above-min-size-and-below-initial-size-expected.txt trunk/LayoutTests/fast/css/resize-above-min-size-and-below-initial-size.html trunk/LayoutTests/fast/css/resize-below-min-intrinsic-size-expected.txt trunk/LayoutTests/fast/css/resize-below-min-intrinsic-size-large-scrollbars-expected.txt trunk/LayoutTests/fast/css/resize-below-min-intrinsic-size-large-scrollbars.html trunk/LayoutTests/fast/css/resize-below-min-intrinsic-size.html trunk/LayoutTests/fast/css/resize-below-min-size-expected.txt trunk/LayoutTests/fast/css/resize-below-min-size-zoomed-expected.txt trunk/LayoutTests/fast/css/resize-below-min-size-zoomed.html trunk/LayoutTests/fast/css/resize-below-min-size.html trunk/LayoutTests/fast/css/resize-orthogonal-containing-block-expected.txt trunk/LayoutTests/fast/css/resize-orthogonal-containing-block.html Diff Modified: trunk/LayoutTests/ChangeLog (292558 => 292559) --- trunk/LayoutTests/ChangeLog 2022-04-07 20:22:58 UTC (rev 292558) +++ trunk/LayoutTests/ChangeLog 2022-04-07 20:26:01 UTC (rev 292559) @@ -1,3 +1,29 @@ +2022-04-07 Tim Nguyen + +[CSS resize property] Correct minimum size computation to allow resizing below initial size +https://bugs.webkit.org/show_bug.cgi?id=135335 + +Reviewed by Simon Fraser. + +Tests ported from the Chromium changeset: https://chromium-review.googlesource.com/c/chromium/src/+/545395/ +They've been tweaked to: +- not rely on +- use WPT harness instead of Chrome specific methods +- use async functions instead of callbacks + +* fast/css/resize-above-min-size-and-below-initial-size-expected.txt: Added. +*
[webkit-changes] [292558] trunk/Source/WebGPU
Title: [292558] trunk/Source/WebGPU Revision 292558 Author mmaxfi...@apple.com Date 2022-04-07 13:22:58 -0700 (Thu, 07 Apr 2022) Log Message [WebGPU] Add support for the "is valid to use with" operation to WebGPU objects https://bugs.webkit.org/show_bug.cgi?id=238719 Reviewed by Kimmo Kinnunen. The spec also has the representation of this base class, named GPUObjectBase, which supports the setting of labels. However, in our WebGPU implementation, all objects implement labels differently, so that handling isn't present. * WebGPU.xcodeproj/project.pbxproj: * WebGPU/Adapter.h: * WebGPU/BindGroup.h: (WebGPU::BindGroup::create): * WebGPU/BindGroup.mm: (WebGPU::Device::createBindGroup): (WebGPU::BindGroup::BindGroup): * WebGPU/BindGroupLayout.h: (WebGPU::BindGroupLayout::create): * WebGPU/BindGroupLayout.mm: (WebGPU::Device::createBindGroupLayout): (WebGPU::BindGroupLayout::BindGroupLayout): * WebGPU/Buffer.h: * WebGPU/Buffer.mm: (WebGPU::Buffer::Buffer): * WebGPU/CommandBuffer.h: (WebGPU::CommandBuffer::create): * WebGPU/CommandBuffer.mm: (WebGPU::CommandBuffer::CommandBuffer): * WebGPU/CommandEncoder.h: * WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::CommandEncoder): (WebGPU::CommandEncoder::beginComputePass): (WebGPU::CommandEncoder::beginRenderPass): (WebGPU::CommandEncoder::finish): * WebGPU/CommandsMixin.h: * WebGPU/ComputePassEncoder.h: (WebGPU::ComputePassEncoder::create): * WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::ComputePassEncoder): * WebGPU/ComputePipeline.h: (WebGPU::ComputePipeline::create): * WebGPU/ComputePipeline.mm: (WebGPU::Device::createComputePipeline): (WebGPU::ComputePipeline::ComputePipeline): * WebGPU/Device.h: * WebGPU/Instance.h: * WebGPU/IsValidToUseWith.h: Copied from Source/WebGPU/WebGPU/CommandsMixin.h. (WebGPU::ObjectBase::ObjectBase): * WebGPU/PipelineLayout.h: (WebGPU::PipelineLayout::create): * WebGPU/PipelineLayout.mm: (WebGPU::Device::createPipelineLayout): (WebGPU::PipelineLayout::PipelineLayout): * WebGPU/QuerySet.h: (WebGPU::QuerySet::create): * WebGPU/QuerySet.mm: (WebGPU::Device::createQuerySet): (WebGPU::QuerySet::QuerySet): * WebGPU/Queue.h: * WebGPU/RenderBundle.h: (WebGPU::RenderBundle::create): * WebGPU/RenderBundle.mm: (WebGPU::RenderBundle::RenderBundle): * WebGPU/RenderBundleEncoder.h: (WebGPU::RenderBundleEncoder::create): * WebGPU/RenderBundleEncoder.mm: (WebGPU::Device::createRenderBundleEncoder): (WebGPU::RenderBundleEncoder::RenderBundleEncoder): (WebGPU::RenderBundleEncoder::finish): * WebGPU/RenderPassEncoder.h: (WebGPU::RenderPassEncoder::create): * WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::RenderPassEncoder): * WebGPU/RenderPipeline.h: (WebGPU::RenderPipeline::create): * WebGPU/RenderPipeline.mm: (WebGPU::Device::createRenderPipeline): (WebGPU::RenderPipeline::RenderPipeline): * WebGPU/Sampler.h: * WebGPU/Sampler.mm: (WebGPU::Sampler::Sampler): * WebGPU/ShaderModule.h: (WebGPU::ShaderModule::create): * WebGPU/ShaderModule.mm: (WebGPU::earlyCompileShaderModule): (WebGPU::Device::createShaderModule): (WebGPU::ShaderModule::ShaderModule): * WebGPU/Texture.h: * WebGPU/Texture.mm: (WebGPU::Texture::Texture): (WebGPU::Texture::createView): * WebGPU/TextureView.h: (WebGPU::TextureView::create): * WebGPU/TextureView.mm: (WebGPU::TextureView::TextureView): Modified Paths trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/WebGPU/Adapter.h trunk/Source/WebGPU/WebGPU/BindGroup.h trunk/Source/WebGPU/WebGPU/BindGroup.mm trunk/Source/WebGPU/WebGPU/BindGroupLayout.h trunk/Source/WebGPU/WebGPU/BindGroupLayout.mm trunk/Source/WebGPU/WebGPU/Buffer.h trunk/Source/WebGPU/WebGPU/CommandBuffer.h trunk/Source/WebGPU/WebGPU/CommandBuffer.mm trunk/Source/WebGPU/WebGPU/CommandEncoder.h trunk/Source/WebGPU/WebGPU/CommandEncoder.mm trunk/Source/WebGPU/WebGPU/CommandsMixin.h trunk/Source/WebGPU/WebGPU/ComputePassEncoder.h trunk/Source/WebGPU/WebGPU/ComputePassEncoder.mm trunk/Source/WebGPU/WebGPU/ComputePipeline.h trunk/Source/WebGPU/WebGPU/ComputePipeline.mm trunk/Source/WebGPU/WebGPU/Device.h trunk/Source/WebGPU/WebGPU/Instance.h trunk/Source/WebGPU/WebGPU/PipelineLayout.h trunk/Source/WebGPU/WebGPU/PipelineLayout.mm trunk/Source/WebGPU/WebGPU/QuerySet.h trunk/Source/WebGPU/WebGPU/QuerySet.mm trunk/Source/WebGPU/WebGPU/Queue.h trunk/Source/WebGPU/WebGPU/RenderBundle.h trunk/Source/WebGPU/WebGPU/RenderBundle.mm trunk/Source/WebGPU/WebGPU/RenderBundleEncoder.h trunk/Source/WebGPU/WebGPU/RenderBundleEncoder.mm trunk/Source/WebGPU/WebGPU/RenderPassEncoder.h trunk/Source/WebGPU/WebGPU/RenderPassEncoder.mm trunk/Source/WebGPU/WebGPU/RenderPipeline.h trunk/Source/WebGPU/WebGPU/RenderPipeline.mm trunk/Source/WebGPU/WebGPU/Sampler.h trunk/Source/WebGPU/WebGPU/ShaderModule.h trunk/Source/WebGPU/WebGPU/ShaderModule.mm trunk/Source/WebGPU/WebGPU/Texture.h trunk/Source/WebGPU/WebGPU/Texture.mm trunk/Source/WebGPU/WebGPU/TextureView.h trunk/Source/WebGPU/WebGPU/TextureView.mm trunk/Source/WebGPU/WebGPU.xcodeproj/project.pbxproj Added Paths
[webkit-changes] [292557] trunk/Source
Title: [292557] trunk/Source Revision 292557 Author simon.fra...@apple.com Date 2022-04-07 13:13:53 -0700 (Thu, 07 Apr 2022) Log Message Have ImageBuffer store the RenderingPurpose, and send it to the GPU process https://bugs.webkit.org/show_bug.cgi?id=238887 Reviewed by Said Abou-Hallawa. Source/WebCore: Add RenderingPurpose to ImageBufferBackend::Parameters so it's stored on ImageBufferBackend/ImageBuffer, and propagate that to the GPU process. * platform/graphics/ConcreteImageBuffer.h: (WebCore::ConcreteImageBuffer::create): * platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::create): * platform/graphics/ImageBuffer.h: * platform/graphics/ImageBufferBackend.h: (WebCore::ImageBufferBackend::renderingPurpose const): * platform/graphics/PlatformImageBuffer.h: * platform/graphics/coreimage/FilterImageCoreImage.mm: (WebCore::FilterImage::imageBufferFromCIImage): * platform/graphics/displaylists/DisplayListImageBuffer.h: Source/WebKit: Add RenderingPurpose to ImageBufferBackend::Parameters so it's stored on ImageBufferBackend/ImageBuffer, and propagate that to the GPU process. * GPUProcess/graphics/RemoteImageBuffer.h: (WebKit::RemoteImageBuffer::create): * GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::createImageBuffer): (WebKit::RemoteRenderingBackend::createImageBufferWithQualifiedIdentifier): * GPUProcess/graphics/RemoteRenderingBackend.h: * GPUProcess/graphics/RemoteRenderingBackend.messages.in: * Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): (headers_for_type): * Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm: (WebKit::RemoteLayerBackingStoreCollection::allocateBufferForBackingStore): * Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm: (WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::allocateBufferForBackingStore): * Shared/WebCoreArgumentCoders.h: * WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp: (WebKit::RemoteDisplayListRecorderProxy::createImageBuffer const): * WebProcess/GPU/graphics/RemoteImageBufferProxy.h: (WebKit::RemoteImageBufferProxy::create): * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer): (WebKit::RemoteRenderingBackendProxy::createImageBuffer): * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h: * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createImageBuffer const): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ConcreteImageBuffer.h trunk/Source/WebCore/platform/graphics/ImageBuffer.cpp trunk/Source/WebCore/platform/graphics/ImageBuffer.h trunk/Source/WebCore/platform/graphics/ImageBufferBackend.h trunk/Source/WebCore/platform/graphics/PlatformImageBuffer.h trunk/Source/WebCore/platform/graphics/coreimage/FilterImageCoreImage.mm trunk/Source/WebCore/platform/graphics/displaylists/DisplayListImageBuffer.h trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/graphics/RemoteImageBuffer.h trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in trunk/Source/WebKit/Scripts/webkit/messages.py trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp trunk/Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (292556 => 292557) --- trunk/Source/WebCore/ChangeLog 2022-04-07 19:59:13 UTC (rev 292556) +++ trunk/Source/WebCore/ChangeLog 2022-04-07 20:13:53 UTC (rev 292557) @@ -1,3 +1,25 @@ +2022-04-07 Simon Fraser + +Have ImageBuffer store the RenderingPurpose, and send it to the GPU process +https://bugs.webkit.org/show_bug.cgi?id=238887 + +Reviewed by Said Abou-Hallawa. + +Add RenderingPurpose to ImageBufferBackend::Parameters so it's stored on ImageBufferBackend/ImageBuffer, +and propagate that to the GPU process. + +* platform/graphics/ConcreteImageBuffer.h: +(WebCore::ConcreteImageBuffer::create): +* platform/graphics/ImageBuffer.cpp: +(WebCore::ImageBuffer::create): +* platform/graphics/ImageBuffer.h: +* platform/graphics/ImageBufferBackend.h: +(WebCore::ImageBufferBackend::renderingPurpose const): +* platform/graphics/PlatformImageBuffer.h: +*
[webkit-changes] [292556] trunk/Tools
Title: [292556] trunk/Tools
Revision 292556
Author jbed...@apple.com
Date 2022-04-07 12:59:13 -0700 (Thu, 07 Apr 2022)
Log Message
[Merge-Queue] Change label names
https://bugs.webkit.org/show_bug.cgi?id=238950
Reviewed by Ryan Haddad.
* CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits): Use "unsafe-merge-queue" instead of "fast-merge-queue".
* CISupport/ews-build/steps.py:
(GitHubMixin): Ditto.
(GitHubMixin._is_pr_in_merge_queue): Ditto.
(BlockPullRequest.start): Ditto.
(RemoveLabelsFromPullRequest): Ditto.
Canonical link: https://commits.webkit.org/249394@main
Modified Paths
trunk/Tools/CISupport/ews-build/events.py
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/events.py (292555 => 292556)
--- trunk/Tools/CISupport/ews-build/events.py 2022-04-07 19:55:32 UTC (rev 292555)
+++ trunk/Tools/CISupport/ews-build/events.py 2022-04-07 19:59:13 UTC (rev 292556)
@@ -312,7 +312,7 @@
class GitHubEventHandlerNoEdits(GitHubEventHandler):
OPEN_STATES = ('open',)
-MERGE_QUEUE_LABELS = ('merge-queue', 'fast-merge-queue')
+MERGE_QUEUE_LABELS = ('merge-queue', 'unsafe-merge-queue')
@classmethod
def file_with_status_sign(cls, info):
Modified: trunk/Tools/CISupport/ews-build/steps.py (292555 => 292556)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 19:55:32 UTC (rev 292555)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 19:59:13 UTC (rev 292556)
@@ -142,7 +142,7 @@
pr_closed_states = ['closed']
BLOCKED_LABEL = 'merging-blocked'
MERGE_QUEUE_LABEL = 'merge-queue'
-FAST_MERGE_QUEUE_LABEL = 'fast-merge-queue'
+UNSAFE_MERGE_QUEUE_LABEL = 'unsafe-merge-queue'
def fetch_data_from_url_with_authentication(self, url):
response = None
@@ -229,7 +229,7 @@
def _is_pr_in_merge_queue(self, pr_json):
for label in (pr_json or {}).get('labels', {}):
-if label.get('name', '') in (self.MERGE_QUEUE_LABEL, self.FAST_MERGE_QUEUE_LABEL):
+if label.get('name', '') in (self.MERGE_QUEUE_LABEL, self.UNSAFE_MERGE_QUEUE_LABEL):
return 1
return 0
@@ -1667,7 +1667,7 @@
repository_url = self.getProperty('repository', '')
rc = SUCCESS
if any((
-not self.remove_labels(pr_number, [self.MERGE_QUEUE_LABEL, self.FAST_MERGE_QUEUE_LABEL], repository_url=repository_url),
+not self.remove_labels(pr_number, [self.MERGE_QUEUE_LABEL, self.UNSAFE_MERGE_QUEUE_LABEL], repository_url=repository_url),
not self.add_label(pr_number, self.BLOCKED_LABEL, repository_url=repository_url),
)):
rc = FAILURE
@@ -1727,7 +1727,7 @@
haltOnFailure = False
LABELS_TO_REMOVE = [
GitHubMixin.MERGE_QUEUE_LABEL,
-GitHubMixin.FAST_MERGE_QUEUE_LABEL,
+GitHubMixin.UNSAFE_MERGE_QUEUE_LABEL,
GitHubMixin.BLOCKED_LABEL,
]
Modified: trunk/Tools/ChangeLog (292555 => 292556)
--- trunk/Tools/ChangeLog 2022-04-07 19:55:32 UTC (rev 292555)
+++ trunk/Tools/ChangeLog 2022-04-07 19:59:13 UTC (rev 292556)
@@ -1,5 +1,21 @@
2022-04-07 Jonathan Bedard
+[Merge-Queue] Change label names
+https://bugs.webkit.org/show_bug.cgi?id=238950
+
+
+Reviewed by Ryan Haddad.
+
+* CISupport/ews-build/events.py:
+(GitHubEventHandlerNoEdits): Use "unsafe-merge-queue" instead of "fast-merge-queue".
+* CISupport/ews-build/steps.py:
+(GitHubMixin): Ditto.
+(GitHubMixin._is_pr_in_merge_queue): Ditto.
+(BlockPullRequest.start): Ditto.
+(RemoveLabelsFromPullRequest): Ditto.
+
+2022-04-07 Jonathan Bedard
+
[Merge-Queue] Add step to close pull request
https://bugs.webkit.org/show_bug.cgi?id=238949
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292555] trunk/Tools
Title: [292555] trunk/Tools
Revision 292555
Author jbed...@apple.com
Date 2022-04-07 12:55:32 -0700 (Thu, 07 Apr 2022)
Log Message
[Merge-Queue] Add step to close pull request
https://bugs.webkit.org/show_bug.cgi?id=238949
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.close_pr): Make POST request to close PR.
(ClosePullRequest):
(ClosePullRequest.start): Ensure PR we're operating on is closed.
(ClosePullRequest.getResultSummary):
(ClosePullRequest.doStepIf): Only do step if operating on a PR.
(ClosePullRequest.hideStepIf): Hide step if skipping.
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249393@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (292554 => 292555)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 19:42:41 UTC (rev 292554)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 19:55:32 UTC (rev 292555)
@@ -362,7 +362,29 @@
return False
return True
+def close_pr(self, pr_number, repository_url=None):
+api_url = GitHub.api_url(repository_url)
+if not api_url:
+return False
+update_url = f'{api_url}/pulls/{pr_number}'
+try:
+username, access_token = GitHub.credentials()
+auth = HTTPBasicAuth(username, access_token) if username and access_token else None
+response = requests.request(
+'POST', update_url, timeout=60, auth=auth,
+headers=dict(Accept='application/vnd.github.v3+json'),
+json=dict(state='closed'),
+)
+if response.status_code // 100 != 2:
+self._addToLog('stdio', f"Failed to close PR {pr_number}. Unexpected response code from GitHub: {response.status_code}\n")
+return False
+except Exception as e:
+self._addToLog('stdio', f"Error in closing PR {pr_number}\n")
+return False
+return True
+
+
class ShellMixin(object):
WINDOWS_SHELL_PLATFORMS = ['wincairo']
@@ -1759,6 +1781,33 @@
return not self.doStepIf(step)
+class ClosePullRequest(buildstep.BuildStep, GitHubMixin, AddToLogMixin):
+name = 'close-pull-request'
+flunkOnFailure = False
+haltOnFailure = False
+
+def start(self):
+self.pr_number = self.getProperty('github.number', '')
+if self.close_pr(self.pr_number, self.getProperty('repository')):
+self.finished(SUCCESS)
+else:
+self.finished(FAILURE)
+return None
+
+def getResultSummary(self):
+if self.results == FAILURE:
+return {'step': f'Failed to close PR {self.pr_number}'}
+if self.results == SUCCESS:
+return {'step': f'Closed PR {self.pr_number}'}
+return buildstep.BuildStep.getResultSummary(self)
+
+def doStepIf(self, step):
+return self.getProperty('github.number')
+
+def hideStepIf(self, results, step):
+return not self.doStepIf(step)
+
+
class LeaveComment(buildstep.BuildStep, BugzillaMixin, GitHubMixin):
name = 'leave-comment'
flunkOnFailure = False
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (292554 => 292555)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-07 19:42:41 UTC (rev 292554)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-07 19:55:32 UTC (rev 292555)
@@ -45,7 +45,7 @@
from steps import (AddAuthorToCommitMessage, AddReviewerToCommitMessage, AddReviewerToChangeLog, AnalyzeAPITestsResults, AnalyzeCompileWebKitResults,
AnalyzeJSCTestsResults, AnalyzeLayoutTestsResults, ApplyPatch, ApplyWatchList, ArchiveBuiltProduct, ArchiveTestResults, BugzillaMixin,
Canonicalize, CheckOutPullRequest, CheckOutSource, CheckOutSpecificRevision, CheckChangeRelevance, CheckPatchStatusOnEWSQueues, CheckStyle,
- CleanBuild, CleanUpGitIndexLock, CleanGitRepo, CleanWorkingDirectory, CompileJSC, CompileJSCWithoutChange,
+ CleanBuild, CleanUpGitIndexLock, CleanGitRepo, CleanWorkingDirectory, ClosePullRequest, CompileJSC, CompileJSCWithoutChange,
CompileWebKit, CompileWebKitWithoutChange, ConfigureBuild, ConfigureBuild, Contributors, CreateLocalGITCommit,
DownloadBuiltProduct, DownloadBuiltProductFromMaster, EWS_BUILD_HOSTNAME, ExtractBuiltProduct, ExtractTestResults,
FetchBranches, FindModifiedChangeLogs, FindModifiedLayoutTests, GitHub, GitResetHard, GitSvnFetch,
@@ -6392,5 +6392,33 @@
return self.runStep()
+class TestClosePullRequest(BuildStepMixinAdditions, unittest.TestCase):
+def setUp(self):
+self.longMessage = True
+return self.setUpBuildStep()
+
+def tearDown(self):
+return
[webkit-changes] [292554] trunk/Source/WebGPU
Title: [292554] trunk/Source/WebGPU Revision 292554 Author mmaxfi...@apple.com Date 2022-04-07 12:42:41 -0700 (Thu, 07 Apr 2022) Log Message [WebGPU] Delete redundant spec quotes https://bugs.webkit.org/show_bug.cgi?id=238711 Reviewed by Kimmo Kinnunen. I actually prefer to have lots and lots of spec quotes throughout the implementation, but enough people have commented about it that it's become clear that we probably shouldn't have them. This deletes almost all of them (and leaves just the ones that are particularly insightful). * WebGPU/Buffer.h: * WebGPU/Buffer.mm: (WebGPU::validateDescriptor): (WebGPU::validateCreateBuffer): (WebGPU::Device::createBuffer): (WebGPU::Buffer::destroy): (WebGPU::Buffer::validateGetMappedRange const): (WebGPU::Buffer::getMappedRange): (WebGPU::Buffer::validateMapAsync const): (WebGPU::Buffer::mapAsync): (WebGPU::Buffer::validateUnmap const): (WebGPU::Buffer::unmap): * WebGPU/CommandEncoder.mm: (WebGPU::validateCopyBufferToBuffer): (WebGPU::CommandEncoder::copyBufferToBuffer): (WebGPU::validateImageCopyBuffer): (WebGPU::validateCopyBufferToTexture): (WebGPU::CommandEncoder::copyBufferToTexture): (WebGPU::validateCopyTextureToBuffer): (WebGPU::CommandEncoder::copyTextureToBuffer): (WebGPU::areCopyCompatible): (WebGPU::validateCopyTextureToTexture): (WebGPU::CommandEncoder::copyTextureToTexture): (WebGPU::validateClearBuffer): (WebGPU::CommandEncoder::clearBuffer): (WebGPU::CommandEncoder::validateFinish const): (WebGPU::CommandEncoder::finish): (WebGPU::CommandEncoder::insertDebugMarker): (WebGPU::CommandEncoder::validatePopDebugGroup const): (WebGPU::CommandEncoder::popDebugGroup): (WebGPU::CommandEncoder::pushDebugGroup): * WebGPU/ComputePassEncoder.mm: (WebGPU::ComputePassEncoder::insertDebugMarker): (WebGPU::ComputePassEncoder::validatePopDebugGroup const): (WebGPU::ComputePassEncoder::popDebugGroup): (WebGPU::ComputePassEncoder::pushDebugGroup): * WebGPU/Device.h: * WebGPU/Device.mm: (WebGPU::Device::currentErrorScope): (WebGPU::Device::generateAValidationError): (WebGPU::Device::validatePopErrorScope const): (WebGPU::Device::popErrorScope): (WebGPU::Device::pushErrorScope): * WebGPU/Queue.mm: (WebGPU::Queue::submit): (WebGPU::validateWriteBufferInitial): (WebGPU::Queue::validateWriteBuffer const): (WebGPU::Queue::writeBuffer): (WebGPU::validateWriteTexture): (WebGPU::Queue::writeTexture): * WebGPU/RenderBundleEncoder.mm: (WebGPU::RenderBundleEncoder::insertDebugMarker): (WebGPU::RenderBundleEncoder::validatePopDebugGroup const): (WebGPU::RenderBundleEncoder::popDebugGroup): (WebGPU::RenderBundleEncoder::pushDebugGroup): * WebGPU/RenderPassEncoder.mm: (WebGPU::RenderPassEncoder::insertDebugMarker): (WebGPU::RenderPassEncoder::validatePopDebugGroup const): (WebGPU::RenderPassEncoder::popDebugGroup): (WebGPU::RenderPassEncoder::pushDebugGroup): * WebGPU/Sampler.h: (WebGPU::Sampler::descriptor const): (WebGPU::Sampler::isComparison const): * WebGPU/Sampler.mm: (WebGPU::validateCreateSampler): (WebGPU::Device::createSampler): * WebGPU/Texture.h: * WebGPU/Texture.mm: (WebGPU::isCompressedFormat): (WebGPU::Texture::isDepthOrStencilFormat): (WebGPU::Texture::texelBlockWidth): (WebGPU::Texture::texelBlockHeight): (WebGPU::isRenderableFormat): (WebGPU::supportsMultisampling): (WebGPU::maximumMiplevelCount): (WebGPU::Device::validateCreateTexture): (WebGPU::Device::createTexture): (WebGPU::Texture::resolveTextureViewDescriptorDefaults const): (WebGPU::Texture::arrayLayerCount const): (WebGPU::Texture::validateCreateView const): (WebGPU::computeRenderExtent): (WebGPU::Texture::createView): (WebGPU::Texture::logicalMiplevelSpecificTextureExtent): (WebGPU::Texture::physicalMiplevelSpecificTextureExtent): (WebGPU::imageCopyTextureSubresourceSize): (WebGPU::Texture::validateImageCopyTexture): (WebGPU::Texture::validateTextureCopyRange): (WebGPU::Texture::validateLinearTextureData): Modified Paths trunk/Source/WebGPU/ChangeLog trunk/Source/WebGPU/WebGPU/Buffer.h trunk/Source/WebGPU/WebGPU/Buffer.mm trunk/Source/WebGPU/WebGPU/CommandEncoder.mm trunk/Source/WebGPU/WebGPU/ComputePassEncoder.mm trunk/Source/WebGPU/WebGPU/Device.h trunk/Source/WebGPU/WebGPU/Device.mm trunk/Source/WebGPU/WebGPU/Queue.mm trunk/Source/WebGPU/WebGPU/RenderBundleEncoder.mm trunk/Source/WebGPU/WebGPU/RenderPassEncoder.mm trunk/Source/WebGPU/WebGPU/Sampler.h trunk/Source/WebGPU/WebGPU/Sampler.mm trunk/Source/WebGPU/WebGPU/Texture.h trunk/Source/WebGPU/WebGPU/Texture.mm Diff Modified: trunk/Source/WebGPU/ChangeLog (292553 => 292554) --- trunk/Source/WebGPU/ChangeLog 2022-04-07 19:40:12 UTC (rev 292553) +++ trunk/Source/WebGPU/ChangeLog 2022-04-07 19:42:41 UTC (rev 292554) @@ -1,5 +1,106 @@ 2022-04-07 Myles C. Maxfield +[WebGPU] Delete redundant spec quotes +https://bugs.webkit.org/show_bug.cgi?id=238711 + +Reviewed by Kimmo Kinnunen. + +I actually prefer to have lots and lots of spec quotes throughout the implementation, +but enough people have
[webkit-changes] [292553] trunk/LayoutTests
Title: [292553] trunk/LayoutTests Revision 292553 Author matteo_flo...@apple.com Date 2022-04-07 12:40:12 -0700 (Thu, 07 Apr 2022) Log Message REGRESSION(r292419): [ iOS EWS ] imported/w3c/web-platform-tests/css/selectors/invalidation/user-action-pseudo-classes-in-has.html is a flaky text failure https://bugs.webkit.org/show_bug.cgi?id=238954 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292552 => 292553) --- trunk/LayoutTests/ChangeLog 2022-04-07 19:19:54 UTC (rev 292552) +++ trunk/LayoutTests/ChangeLog 2022-04-07 19:40:12 UTC (rev 292553) @@ -1,5 +1,14 @@ 2022-04-07 Matteo Flores +REGRESSION(r292419): [ iOS EWS ] imported/w3c/web-platform-tests/css/selectors/invalidation/user-action-pseudo-classes-in-has.html is a flaky text failure +https://bugs.webkit.org/show_bug.cgi?id=238954 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + +2022-04-07 Matteo Flores + REGRESSION(r290770): [ Mac wk2 ] imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html is a flaky text failure https://bugs.webkit.org/show_bug.cgi?id=238033 Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (292552 => 292553) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 19:19:54 UTC (rev 292552) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2022-04-07 19:40:12 UTC (rev 292553) @@ -2174,6 +2174,9 @@ webkit.org/b/232310 [ Release ] fast/flexbox/aspect-ratio-intrinsic-adjust.html [ Pass ImageOnlyFailure ] +# This test is currently failing on EWS +webkit.org/b/238954 imported/w3c/web-platform-tests/css/selectors/invalidation/user-action-pseudo-classes-in-has.html [ Pass Failure ] + webkit.org/b/231780 [ Debug ] imported/w3c/web-platform-tests/webrtc/simulcast/basic.https.html [ Pass Failure ] webkit.org/b/232099 imported/w3c/web-platform-tests/websockets/Close-1000.any.html [ Pass Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292552] trunk/Source/WebGPU
Title: [292552] trunk/Source/WebGPU
Revision 292552
Author mmaxfi...@apple.com
Date 2022-04-07 12:19:54 -0700 (Thu, 07 Apr 2022)
Log Message
[WebGPU] Implement Texture view format compatibility
https://bugs.webkit.org/show_bug.cgi?id=238710
Reviewed by Kimmo Kinnunen.
Right now, the definition of texture view format compatibility is narrow enough that we'll
never need to add MTLTextureUsagePixelFormatView to the usage of any textures. So, all we
have to do is validate.
Test: http/tests/webgpu/webgpu/api/validation/createTexture.html
* WebGPU/CommandEncoder.mm:
(WebGPU::areCopyCompatible):
(WebGPU::isSRGBCompatible): Deleted.
* WebGPU/Device.h:
* WebGPU/Texture.h:
(WebGPU::Texture::create):
* WebGPU/Texture.mm:
(WebGPU::Texture::removeSRGBSuffix):
(WebGPU::textureViewFormatCompatible):
(WebGPU::Device::validateCreateTexture):
(WebGPU::usage):
(WebGPU::Device::createTexture):
(WebGPU::Texture::Texture):
(WebGPU::Texture::validateCreateView const):
Modified Paths
trunk/Source/WebGPU/ChangeLog
trunk/Source/WebGPU/WebGPU/CommandEncoder.mm
trunk/Source/WebGPU/WebGPU/Device.h
trunk/Source/WebGPU/WebGPU/Texture.h
trunk/Source/WebGPU/WebGPU/Texture.mm
Diff
Modified: trunk/Source/WebGPU/ChangeLog (292551 => 292552)
--- trunk/Source/WebGPU/ChangeLog 2022-04-07 19:18:13 UTC (rev 292551)
+++ trunk/Source/WebGPU/ChangeLog 2022-04-07 19:19:54 UTC (rev 292552)
@@ -1,3 +1,31 @@
+2022-04-07 Myles C. Maxfield
+
+[WebGPU] Implement Texture view format compatibility
+https://bugs.webkit.org/show_bug.cgi?id=238710
+
+Reviewed by Kimmo Kinnunen.
+
+Right now, the definition of texture view format compatibility is narrow enough that we'll
+never need to add MTLTextureUsagePixelFormatView to the usage of any textures. So, all we
+have to do is validate.
+
+Test: http/tests/webgpu/webgpu/api/validation/createTexture.html
+
+* WebGPU/CommandEncoder.mm:
+(WebGPU::areCopyCompatible):
+(WebGPU::isSRGBCompatible): Deleted.
+* WebGPU/Device.h:
+* WebGPU/Texture.h:
+(WebGPU::Texture::create):
+* WebGPU/Texture.mm:
+(WebGPU::Texture::removeSRGBSuffix):
+(WebGPU::textureViewFormatCompatible):
+(WebGPU::Device::validateCreateTexture):
+(WebGPU::usage):
+(WebGPU::Device::createTexture):
+(WebGPU::Texture::Texture):
+(WebGPU::Texture::validateCreateView const):
+
2022-04-06 Chris Dumez
Start replacing String(const char*) constructor with a String::fromLatin1(const char*) function
Modified: trunk/Source/WebGPU/WebGPU/CommandEncoder.mm (292551 => 292552)
--- trunk/Source/WebGPU/WebGPU/CommandEncoder.mm 2022-04-07 19:18:13 UTC (rev 292551)
+++ trunk/Source/WebGPU/WebGPU/CommandEncoder.mm 2022-04-07 19:19:54 UTC (rev 292552)
@@ -33,6 +33,7 @@
#import "Device.h"
#import "QuerySet.h"
#import "RenderPassEncoder.h"
+#import "Texture.h"
namespace WebGPU {
@@ -556,139 +557,6 @@
}
}
-static std::optional isSRGBCompatible(WGPUTextureFormat format)
-{
-switch (format) {
-case WGPUTextureFormat_R8Unorm:
-case WGPUTextureFormat_R8Snorm:
-case WGPUTextureFormat_R8Uint:
-case WGPUTextureFormat_R8Sint:
-case WGPUTextureFormat_R16Uint:
-case WGPUTextureFormat_R16Sint:
-case WGPUTextureFormat_R16Float:
-case WGPUTextureFormat_RG8Unorm:
-case WGPUTextureFormat_RG8Snorm:
-case WGPUTextureFormat_RG8Uint:
-case WGPUTextureFormat_RG8Sint:
-case WGPUTextureFormat_R32Float:
-case WGPUTextureFormat_R32Uint:
-case WGPUTextureFormat_R32Sint:
-case WGPUTextureFormat_RG16Uint:
-case WGPUTextureFormat_RG16Sint:
-case WGPUTextureFormat_RG16Float:
-return std::nullopt;
-case WGPUTextureFormat_RGBA8Unorm:
-case WGPUTextureFormat_RGBA8UnormSrgb:
-return WGPUTextureFormat_RGBA8Unorm;
-case WGPUTextureFormat_RGBA8Snorm:
-case WGPUTextureFormat_RGBA8Uint:
-case WGPUTextureFormat_RGBA8Sint:
-return std::nullopt;
-case WGPUTextureFormat_BGRA8Unorm:
-case WGPUTextureFormat_BGRA8UnormSrgb:
-return WGPUTextureFormat_BGRA8Unorm;
-case WGPUTextureFormat_RGB10A2Unorm:
-case WGPUTextureFormat_RG11B10Ufloat:
-case WGPUTextureFormat_RGB9E5Ufloat:
-case WGPUTextureFormat_RG32Float:
-case WGPUTextureFormat_RG32Uint:
-case WGPUTextureFormat_RG32Sint:
-case WGPUTextureFormat_RGBA16Uint:
-case WGPUTextureFormat_RGBA16Sint:
-case WGPUTextureFormat_RGBA16Float:
-case WGPUTextureFormat_RGBA32Float:
-case WGPUTextureFormat_RGBA32Uint:
-case WGPUTextureFormat_RGBA32Sint:
-case WGPUTextureFormat_Stencil8:
-case WGPUTextureFormat_Depth16Unorm:
-case WGPUTextureFormat_Depth24Plus:
-case WGPUTextureFormat_Depth24PlusStencil8:
-case WGPUTextureFormat_Depth24UnormStencil8:
-case WGPUTextureFormat_Depth32Float:
-case WGPUTextureFormat_Depth32FloatStencil8:
-return
[webkit-changes] [292551] trunk/LayoutTests
Title: [292551] trunk/LayoutTests Revision 292551 Author matteo_flo...@apple.com Date 2022-04-07 12:18:13 -0700 (Thu, 07 Apr 2022) Log Message REGRESSION(r290770): [ Mac wk2 ] imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html is a flaky text failure https://bugs.webkit.org/show_bug.cgi?id=238033 Unreviewed test gardening * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292550 => 292551) --- trunk/LayoutTests/ChangeLog 2022-04-07 18:59:19 UTC (rev 292550) +++ trunk/LayoutTests/ChangeLog 2022-04-07 19:18:13 UTC (rev 292551) @@ -1,5 +1,14 @@ 2022-04-07 Matteo Flores +REGRESSION(r290770): [ Mac wk2 ] imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html is a flaky text failure +https://bugs.webkit.org/show_bug.cgi?id=238033 + +Unreviewed test gardening + +* platform/mac-wk2/TestExpectations: + +2022-04-07 Matteo Flores + REBASLINE: [ Monterey ] fast/text/khmer-lao-font.html is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=238917 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (292550 => 292551) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-07 18:59:19 UTC (rev 292550) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-04-07 19:18:13 UTC (rev 292551) @@ -1380,6 +1380,8 @@ webkit.org/b/224257 [ Debug ] webgl/2.0.0/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Slow ] +webkit.org/b/238033 imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html [ Pass Failure ] + webkit.org/b/224963 [ BigSur arm64 ] webrtc/captureCanvas-webrtc.html [ Pass Timeout ] webkit.org/b/225430 [ BigSur arm64 ] http/tests/inspector/network/resource-sizes-network.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292550] trunk/LayoutTests
Title: [292550] trunk/LayoutTests Revision 292550 Author matteo_flo...@apple.com Date 2022-04-07 11:59:19 -0700 (Thu, 07 Apr 2022) Log Message REBASLINE: [ Monterey ] fast/text/khmer-lao-font.html is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=238917 Unreviewed test gardening * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292549 => 292550) --- trunk/LayoutTests/ChangeLog 2022-04-07 18:24:11 UTC (rev 292549) +++ trunk/LayoutTests/ChangeLog 2022-04-07 18:59:19 UTC (rev 292550) @@ -1,3 +1,12 @@ +2022-04-07 Matteo Flores + +REBASLINE: [ Monterey ] fast/text/khmer-lao-font.html is a constant text failure +https://bugs.webkit.org/show_bug.cgi?id=238917 + +Unreviewed test gardening + +* platform/mac/TestExpectations: + 2022-04-07 Kate Cheney [ BigSur wk1 ] printing/css2.1/page-break-after-000.html is a flaky failure (231102) Modified: trunk/LayoutTests/platform/mac/TestExpectations (292549 => 292550) --- trunk/LayoutTests/platform/mac/TestExpectations 2022-04-07 18:24:11 UTC (rev 292549) +++ trunk/LayoutTests/platform/mac/TestExpectations 2022-04-07 18:59:19 UTC (rev 292550) @@ -2242,6 +2242,8 @@ webkit.org/b/231757 [ BigSur ] inspector/canvas/updateShader-webgl.html [ Pass Failure ] +webkit.org/b/238917 [ Monterey ] fast/text/khmer-lao-font.html [ Failure ] + webkit.org/b/231924 inspector/css/modify-css-property.html [ Pass Failure ] webkit.org/b/237172 imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-twice.html [ Pass Failure Crash ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292549] trunk/Tools
Title: [292549] trunk/Tools
Revision 292549
Author jbed...@apple.com
Date 2022-04-07 11:24:11 -0700 (Thu, 07 Apr 2022)
Log Message
[Merge-Queue] Update head and base references in PR
https://bugs.webkit.org/show_bug.cgi?id=238942
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(GitHubMixin.update_pr): Pass head and base to POST request.
(UpdatePullRequest.evaluateCommand): Set head and base refs.
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249387@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (292548 => 292549)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 18:19:04 UTC (rev 292548)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 18:24:11 UTC (rev 292549)
@@ -331,11 +331,20 @@
return False
return True
-def update_pr(self, pr_number, title, description, repository_url=None):
+def update_pr(self, pr_number, title, description, base=None, head=None, repository_url=None):
api_url = GitHub.api_url(repository_url)
if not api_url:
return False
+pr_info = dict(
+title=title,
+body=description,
+)
+if base:
+pr_info['base'] = base
+if head:
+pr_info['head'] = head
+
update_url = f'{api_url}/pulls/{pr_number}'
try:
username, access_token = GitHub.credentials()
@@ -343,10 +352,7 @@
response = requests.request(
'POST', update_url, timeout=60, auth=auth,
headers=dict(Accept='application/vnd.github.v3+json'),
-json=dict(
-title=title,
-body=description,
-),
+json=pr_info,
)
if response.status_code // 100 != 2:
self._addToLog('stdio', f"Failed to update PR {pr_number}. Unexpected response code from GitHub: {response.status_code}\n")
@@ -4975,10 +4981,15 @@
if bug_id:
self.setProperty('bug_id', bug_id)
+user = self.getProperty('github.head.user.login', '')
+head = self.getProperty('github.head.ref', '')
+
if not self.update_pr(
self.getProperty('github.number'),
title=title,
description=description,
+base=self.getProperty('github.base.ref', ''),
+head=f"{user}:{head}" if user and head else None,
repository_url=self.getProperty('repository', ''),
):
return FAILURE
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (292548 => 292549)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-07 18:19:04 UTC (rev 292548)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-07 18:24:11 UTC (rev 292549)
@@ -6254,9 +6254,11 @@
return self.runStep()
def test_success(self):
-def update_pr(x, pr_number, title, description, repository_url=None):
+def update_pr(x, pr_number, title, description, base=None, head=None, repository_url=None):
self.assertEqual(pr_number, '1234')
self.assertEqual(title, '[Merge-Queue] Add http credential helper')
+self.assertEqual(base, 'main')
+self.assertEqual(head, 'HEAD:eng/pull-request-branch')
self.assertEqual(
description,
@@ -6283,6 +6285,9 @@
UpdatePullRequest.update_pr = update_pr
self.setupStep(UpdatePullRequest())
self.setProperty('github.number', '1234')
+self.setProperty('github.head.user.login', 'JonWBedard')
+self.setProperty('github.head.ref', 'eng/pull-request-branch')
+self.setProperty('github.base.ref', 'main')
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logEnviron=False,
@@ -6312,12 +6317,15 @@
return self.runStep()
def test_success(self):
-def update_pr(x, pr_number, title, description, repository_url=None):
+def update_pr(x, pr_number, title, description, base=None, head=None, repository_url=None):
return False
UpdatePullRequest.update_pr = update_pr
self.setupStep(UpdatePullRequest())
self.setProperty('github.number', '1234')
+self.setProperty('github.head.user.login', 'JonWBedard')
+self.setProperty('github.head.ref', 'eng/pull-request-branch')
+self.setProperty('github.base.ref', 'main')
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logEnviron=False,
Modified: trunk/Tools/ChangeLog (292548 => 292549)
--- trunk/Tools/ChangeLog 2022-04-07 18:19:04 UTC (rev 292548)
+++ trunk/Tools/ChangeLog 2022-04-07 18:24:11 UTC (rev 292549)
@@ -1,3 +1,16 @@
[webkit-changes] [292548] trunk/LayoutTests
Title: [292548] trunk/LayoutTests Revision 292548 Author katherine_che...@apple.com Date 2022-04-07 11:19:04 -0700 (Thu, 07 Apr 2022) Log Message [ BigSur wk1 ] printing/css2.1/page-break-after-000.html is a flaky failure (231102) https://bugs.webkit.org/show_bug.cgi?id=231102 Unreviewed. Fixing expectations for a no-longer-flaky test. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292547 => 292548) --- trunk/LayoutTests/ChangeLog 2022-04-07 18:08:45 UTC (rev 292547) +++ trunk/LayoutTests/ChangeLog 2022-04-07 18:19:04 UTC (rev 292548) @@ -1,3 +1,13 @@ +2022-04-07 Kate Cheney + +[ BigSur wk1 ] printing/css2.1/page-break-after-000.html is a flaky failure (231102) +https://bugs.webkit.org/show_bug.cgi?id=231102 + + +Unreviewed. Fixing expectations for a no-longer-flaky test. + +* platform/mac-wk1/TestExpectations: + 2022-04-07 Wenson Hsieh Adjust and refactor some UA styles and logic for injecting Live Text Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (292547 => 292548) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-07 18:08:45 UTC (rev 292547) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-07 18:19:04 UTC (rev 292548) @@ -1633,8 +1633,6 @@ webkit.org/b/230425 printing/allowed-breaks.html [ Pass Failure ] -webkit.org/b/231102 [ BigSur ] printing/css2.1/page-break-after-000.html [ Pass Failure ] - # webkit.org/b/214448 Web Share API is not implemented for mac-wk1 http/tests/webshare/ [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292547] trunk
Title: [292547] trunk
Revision 292547
Author bfulg...@apple.com
Date 2022-04-07 11:08:45 -0700 (Thu, 07 Apr 2022)
Log Message
[WebKitLegacy] Remove NPAPIPlugInsEnabledForTestingInWebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=238882
Reviewed by Tim Horton.
We have completely removed the NPAPI code and no longer run the tests. We no longer need this setting
and should remove it to reduce complexity and build time.
The specific skipped tests will be removed in a follow-up patch.
Source/WTF:
* Scripts/Preferences/WebPreferencesInternal.yaml:
Tools:
* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestOptions.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (292546 => 292547)
--- trunk/Source/WTF/ChangeLog 2022-04-07 17:37:17 UTC (rev 292546)
+++ trunk/Source/WTF/ChangeLog 2022-04-07 18:08:45 UTC (rev 292547)
@@ -1,3 +1,17 @@
+2022-04-07 Brent Fulgham
+
+[WebKitLegacy] Remove NPAPIPlugInsEnabledForTestingInWebKitLegacy
+https://bugs.webkit.org/show_bug.cgi?id=238882
+
+Reviewed by Tim Horton.
+
+We have completely removed the NPAPI code and no longer run the tests. We no longer need this setting
+and should remove it to reduce complexity and build time.
+
+The specific skipped tests will be removed in a follow-up patch.
+
+* Scripts/Preferences/WebPreferencesInternal.yaml:
+
2022-04-07 Geza Lore
[JSC][ARMv7] Support proper near calls and JUMP_ISLANDS
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (292546 => 292547)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-04-07 17:37:17 UTC (rev 292546)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2022-04-07 18:08:45 UTC (rev 292547)
@@ -665,16 +665,6 @@
WebCore:
default: false
-NPAPIPlugInsEnabledForTestingInWebKitLegacy:
- type: bool
- humanReadableName: "NPAPI Plug-Ins Enabled In WebKitLegacy"
- humanReadableDescription: "Enable NPAPI Plug-Ins for testing"
- webcoreBinding: none
- exposed: [ WebKitLegacy ]
- defaultValue:
-WebKitLegacy:
- default: false
-
NotificationEventEnabled:
type: bool
humanReadableName: "NotificationEvent support"
Modified: trunk/Tools/ChangeLog (292546 => 292547)
--- trunk/Tools/ChangeLog 2022-04-07 17:37:17 UTC (rev 292546)
+++ trunk/Tools/ChangeLog 2022-04-07 18:08:45 UTC (rev 292547)
@@ -1,3 +1,18 @@
+2022-04-07 Brent Fulgham
+
+[WebKitLegacy] Remove NPAPIPlugInsEnabledForTestingInWebKitLegacy
+https://bugs.webkit.org/show_bug.cgi?id=238882
+
+Reviewed by Tim Horton.
+
+We have completely removed the NPAPI code and no longer run the tests. We no longer need this setting
+and should remove it to reduce complexity and build time.
+
+The specific skipped tests will be removed in a follow-up patch.
+
+* DumpRenderTree/TestOptions.cpp:
+(WTR::TestOptions::defaults):
+
2022-04-06 Jonathan Bedard
[Merge-Queue] Remove labels from pull request
Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (292546 => 292547)
--- trunk/Tools/DumpRenderTree/TestOptions.cpp 2022-04-07 17:37:17 UTC (rev 292546)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp 2022-04-07 18:08:45 UTC (rev 292547)
@@ -89,7 +89,6 @@
{ "MediaDevicesEnabled", true },
{ "MediaPreloadingEnabled", true },
{ "MockScrollbarsEnabled", true },
-{ "NPAPIPlugInsEnabledForTestingInWebKitLegacy", true },
{ "NeedsStorageAccessFromFileURLsQuirk", false },
{ "OfflineWebApplicationCacheEnabled", true },
{ "RequiresUserGestureForAudioPlayback", false },
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292546] trunk/Tools
Title: [292546] trunk/Tools
Revision 292546
Author jbed...@apple.com
Date 2022-04-07 10:37:17 -0700 (Thu, 07 Apr 2022)
Log Message
[Merge-Queue] Remove labels from pull request
https://bugs.webkit.org/show_bug.cgi?id=238909
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(RemoveLabelsFromPullRequest):
(RemoveLabelsFromPullRequest._addToLog):
(RemoveLabelsFromPullRequest.start): Remove active labels.
(RemoveLabelsFromPullRequest.getResultSummary):
(RemoveLabelsFromPullRequest.doStepIf): Only do step if pull request
number is defined.
(RemoveLabelsFromPullRequest.hideStepIf): Hide stip if step not executed.
Canonical link: https://commits.webkit.org/249384@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (292545 => 292546)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 17:28:43 UTC (rev 292545)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 17:37:17 UTC (rev 292546)
@@ -1693,6 +1693,40 @@
return not self.doStepIf(step)
+class RemoveLabelsFromPullRequest(buildstep.BuildStep, GitHubMixin, AddToLogMixin):
+name = 'remove-labels-from-pull-request'
+flunkOnFailure = False
+haltOnFailure = False
+LABELS_TO_REMOVE = [
+GitHubMixin.MERGE_QUEUE_LABEL,
+GitHubMixin.FAST_MERGE_QUEUE_LABEL,
+GitHubMixin.BLOCKED_LABEL,
+]
+
+def start(self):
+pr_number = self.getProperty('github.number', '')
+
+repository_url = self.getProperty('repository', '')
+rc = SUCCESS
+if not self.remove_labels(pr_number, self.LABELS_TO_REMOVE, repository_url=repository_url):
+rc = FAILURE
+self.finished(rc)
+return None
+
+def getResultSummary(self):
+if self.results == SUCCESS:
+return {'step': f"Removed labels from pull request"}
+elif self.results == FAILURE:
+return {'step': f"Failed to remove labels from pull request"}
+return buildstep.BuildStep.getResultSummary(self)
+
+def doStepIf(self, step):
+return self.getProperty('github.number') and CURRENT_HOSTNAME == EWS_BUILD_HOSTNAME
+
+def hideStepIf(self, results, step):
+return not self.doStepIf(step)
+
+
class CloseBug(buildstep.BuildStep, BugzillaMixin):
name = 'close-bugzilla-bug'
flunkOnFailure = False
Modified: trunk/Tools/ChangeLog (292545 => 292546)
--- trunk/Tools/ChangeLog 2022-04-07 17:28:43 UTC (rev 292545)
+++ trunk/Tools/ChangeLog 2022-04-07 17:37:17 UTC (rev 292546)
@@ -1,3 +1,20 @@
+2022-04-06 Jonathan Bedard
+
+[Merge-Queue] Remove labels from pull request
+https://bugs.webkit.org/show_bug.cgi?id=238909
+
+
+Reviewed by Aakash Jain.
+
+* CISupport/ews-build/steps.py:
+(RemoveLabelsFromPullRequest):
+(RemoveLabelsFromPullRequest._addToLog):
+(RemoveLabelsFromPullRequest.start): Remove active labels.
+(RemoveLabelsFromPullRequest.getResultSummary):
+(RemoveLabelsFromPullRequest.doStepIf): Only do step if pull request
+number is defined.
+(RemoveLabelsFromPullRequest.hideStepIf): Hide stip if step not executed.
+
2022-04-07 Jonathan Bedard
[Merge-Queue] Extract bug_id when updating pull-request (Follow-up fix)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292545] trunk/Tools
Title: [292545] trunk/Tools
Revision 292545
Author jbed...@apple.com
Date 2022-04-07 10:28:43 -0700 (Thu, 07 Apr 2022)
Log Message
[Merge-Queue] Extract bug_id when updating pull-request (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=238772
Unreviewed follow-up fix.
* Tools/CISupport/ews-build/steps.py:
(LeaveComment.start): Pass repository to GitHubMixin.comment_on_pr.
Canonical link: https://commits.webkit.org/249383@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (292544 => 292545)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 17:22:33 UTC (rev 292544)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 17:28:43 UTC (rev 292545)
@@ -1736,7 +1736,7 @@
return None
rc = SUCCESS
-if self.pr_number and not self.comment_on_pr(self.pr_number, self.comment_text):
+if self.pr_number and not self.comment_on_pr(self.pr_number, self.comment_text, self.getProperty('repository')):
rc = FAILURE
if self.bug_id and self.comment_on_bug(self.bug_id, self.comment_text) != SUCCESS:
rc = FAILURE
Modified: trunk/Tools/ChangeLog (292544 => 292545)
--- trunk/Tools/ChangeLog 2022-04-07 17:22:33 UTC (rev 292544)
+++ trunk/Tools/ChangeLog 2022-04-07 17:28:43 UTC (rev 292545)
@@ -1,5 +1,16 @@
2022-04-07 Jonathan Bedard
+[Merge-Queue] Extract bug_id when updating pull-request (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=238772
+
+
+Unreviewed follow-up fix.
+
+* CISupport/ews-build/steps.py:
+(LeaveComment.start): Pass repository to GitHubMixin.comment_on_pr.
+
+2022-04-07 Jonathan Bedard
+
[Merge-Queue] Update pull-request with landed content (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=238554
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292543] trunk
Title: [292543] trunk
Revision 292543
Author wenson_hs...@apple.com
Date 2022-04-07 10:22:10 -0700 (Thu, 07 Apr 2022)
Log Message
Adjust and refactor some UA styles and logic for injecting Live Text
https://bugs.webkit.org/show_bug.cgi?id=238912
rdar://91383570
Reviewed by Aditya Keerthi.
Source/WebCore:
Adjust various Live-Text-related UA styles for "text recognition blocks", along with other miscellaneous
adjustments:
- Compute and set the border radius, based on the font size and overall height of the block.
- Add horizontal/vertical padding to text recognition, computed relative to the border radius.
- Allow hyphenation in blocks.
- Only center-align text in blocks if there are fewer than 3 text runs in the block.
- Adjust box shadows, backdrop filter blur radius and line height.
- Specify a `line-height`, such that `line-height` from the host element doesn't erroneously apply to blocks.
- Handle text recognition blocks with newline characters (\n) by injecting line break elements between text.
Test: fast/images/text-recognition/image-overlay-block-with-newlines.html
* dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateSubtree):
(WebCore::ImageOverlay::fitElementToQuad):
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* html/shadow/imageOverlay.css:
(:host(:not(img)) div#image-overlay:-webkit-full-screen-document):
(div.image-overlay-block):
(div.image-overlay-line, .image-overlay-text, div.image-overlay-block):
(div.image-overlay-line, .image-overlay-text):
(.image-overlay-block):
LayoutTests:
Add a layout test to exercise "block"-style Live Text injection, in the case where the injected text contains
newlines. The resulting selected text should preserve the newline.
* fast/images/text-recognition/image-overlay-block-with-newlines-expected.txt: Added.
* fast/images/text-recognition/image-overlay-block-with-newlines.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ImageOverlay.cpp
trunk/Source/WebCore/html/shadow/imageOverlay.css
Added Paths
trunk/LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines-expected.txt
trunk/LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines.html
Diff
Modified: trunk/LayoutTests/ChangeLog (292542 => 292543)
--- trunk/LayoutTests/ChangeLog 2022-04-07 17:13:34 UTC (rev 292542)
+++ trunk/LayoutTests/ChangeLog 2022-04-07 17:22:10 UTC (rev 292543)
@@ -1,3 +1,17 @@
+2022-04-07 Wenson Hsieh
+
+Adjust and refactor some UA styles and logic for injecting Live Text
+https://bugs.webkit.org/show_bug.cgi?id=238912
+rdar://91383570
+
+Reviewed by Aditya Keerthi.
+
+Add a layout test to exercise "block"-style Live Text injection, in the case where the injected text contains
+newlines. The resulting selected text should preserve the newline.
+
+* fast/images/text-recognition/image-overlay-block-with-newlines-expected.txt: Added.
+* fast/images/text-recognition/image-overlay-block-with-newlines.html: Added.
+
2022-04-07 Alan Bujtas
Fix the expected failure type.
Added: trunk/LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines-expected.txt (0 => 292543)
--- trunk/LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines-expected.txt 2022-04-07 17:22:10 UTC (rev 292543)
@@ -0,0 +1,5 @@
+PASS getSelection().toString() is "Hello\nworld"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines.html (0 => 292543)
--- trunk/LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines.html (rev 0)
+++ trunk/LayoutTests/fast/images/text-recognition/image-overlay-block-with-newlines.html 2022-04-07 17:22:10 UTC (rev 292543)
@@ -0,0 +1,31 @@
+
+
+
+
+body, html {
+margin: 0;
+}
+
+
+
+![]()
+addEventListener("load", () => {
+let image = document.querySelector("img");
+internals.installImageOverlay(image, [], [
+{
+topLeft : new DOMPointReadOnly(0.1, 0.1),
+topRight : new DOMPointReadOnly(0.4, 0.1),
+bottomRight : new DOMPointReadOnly(0.4, 0.4),
+bottomLeft : new DOMPointReadOnly(0.1, 0.4),
+text : "Hello\nworld",
+}
+]);
+const overlay = internals.shadowRoot(image).getElementById("image-overlay");
+getSelection().selectAllChildren(overlay);
+shouldBeEqualToString("getSelection().toString()", "Hello\nworld");
+});
+
+
+
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (292542 => 292543)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 17:13:34 UTC (rev 292542)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07
[webkit-changes] [292544] trunk/Tools
Title: [292544] trunk/Tools
Revision 292544
Author jbed...@apple.com
Date 2022-04-07 10:22:33 -0700 (Thu, 07 Apr 2022)
Log Message
[Merge-Queue] Update pull-request with landed content (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=238554
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(PushPullRequestBranch.start): Push canonicalized HEAD to remote branch.
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/249381@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (292543 => 292544)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 17:22:10 UTC (rev 292543)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 17:22:33 UTC (rev 292544)
@@ -4854,7 +4854,7 @@
def start(self, BufferLogObserverClass=logobserver.BufferLogObserver):
remote = self.getProperty('github.head.repo.full_name').split('/')[0]
head_ref = self.getProperty('github.head.ref')
-self.command = ['git', 'push', remote, head_ref, '-f']
+self.command = ['git', 'push', '-f', remote, f'HEAD:{head_ref}']
username, access_token = GitHub.credentials()
self.workerEnvironment['GIT_USER'] = username
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (292543 => 292544)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-07 17:22:10 UTC (rev 292543)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2022-04-07 17:22:33 UTC (rev 292544)
@@ -6211,7 +6211,7 @@
logEnviron=False,
timeout=300,
env=dict(GIT_USER='webkit-commit-queue', GIT_PASSWORD='password'),
-command=['git', 'push', 'Contributor', 'eng/pull-request-branch', '-f'])
+command=['git', 'push', '-f', 'Contributor', 'HEAD:eng/pull-request-branch'])
+ 0
+ ExpectShell.log('stdio', stdout='To https://github.com/Contributor/WebKit.git\n37b7da95723b...9e2cb83b07b6 eng/pull-request-branch -> eng/pull-request-branch (forced update)\n'),
)
@@ -6230,7 +6230,7 @@
logEnviron=False,
timeout=300,
env=dict(GIT_USER='webkit-commit-queue', GIT_PASSWORD='password'),
-command=['git', 'push', 'Contributor', 'eng/pull-request-branch', '-f'])
+command=['git', 'push', '-f', 'Contributor', 'HEAD:eng/pull-request-branch'])
+ 1
+ ExpectShell.log('stdio', stdout="fatal: could not read Username for 'https://github.com': Device not configured\n"),
)
Modified: trunk/Tools/ChangeLog (292543 => 292544)
--- trunk/Tools/ChangeLog 2022-04-07 17:22:10 UTC (rev 292543)
+++ trunk/Tools/ChangeLog 2022-04-07 17:22:33 UTC (rev 292544)
@@ -1,3 +1,15 @@
+2022-04-07 Jonathan Bedard
+
+[Merge-Queue] Update pull-request with landed content (Follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=238554
+
+
+Reviewed by Aakash Jain.
+
+* CISupport/ews-build/steps.py:
+(PushPullRequestBranch.start): Push canonicalized HEAD to remote branch.
+* CISupport/ews-build/steps_unittest.py:
+
2022-04-07 Youenn Fablet
Use the same callback mechanism for ServiceWorker openWindow and navigate in UIProcess
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292542] trunk/Source/WebCore
Title: [292542] trunk/Source/WebCore
Revision 292542
Author lmo...@igalia.com
Date 2022-04-07 10:13:34 -0700 (Thu, 07 Apr 2022)
Log Message
Unreviewed, non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=238933
* css/CSSToStyleMap.h: Forward declare Quad
* platform/graphics/filters/FilterEffectVector.h: Replace forward with
actual include for Ref.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSToStyleMap.h
trunk/Source/WebCore/platform/graphics/filters/FilterEffectVector.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (292541 => 292542)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 17:06:19 UTC (rev 292541)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07 17:13:34 UTC (rev 292542)
@@ -1,3 +1,12 @@
+2022-04-07 Lauro Moura
+
+Unreviewed, non-unified build fixes
+https://bugs.webkit.org/show_bug.cgi?id=238933
+
+* css/CSSToStyleMap.h: Forward declare Quad
+* platform/graphics/filters/FilterEffectVector.h: Replace forward with
+actual include for Ref.
+
2022-04-07 Tim Nguyen
Remove redundant invalidateStyleForSubtree() calls
Modified: trunk/Source/WebCore/css/CSSToStyleMap.h (292541 => 292542)
--- trunk/Source/WebCore/css/CSSToStyleMap.h 2022-04-07 17:06:19 UTC (rev 292541)
+++ trunk/Source/WebCore/css/CSSToStyleMap.h 2022-04-07 17:13:34 UTC (rev 292542)
@@ -32,6 +32,7 @@
class FillLayer;
class LengthBox;
class NinePieceImage;
+class Quad;
class RenderStyle;
class StyleImage;
Modified: trunk/Source/WebCore/platform/graphics/filters/FilterEffectVector.h (292541 => 292542)
--- trunk/Source/WebCore/platform/graphics/filters/FilterEffectVector.h 2022-04-07 17:06:19 UTC (rev 292541)
+++ trunk/Source/WebCore/platform/graphics/filters/FilterEffectVector.h 2022-04-07 17:13:34 UTC (rev 292542)
@@ -25,12 +25,11 @@
#pragma once
+#include "FilterEffect.h"
#include
namespace WebCore {
-class FilterEffect;
-
using FilterEffectVector = Vector>;
} // namespace WebCore
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292541] trunk/Source/WebCore
Title: [292541] trunk/Source/WebCore Revision 292541 Author n...@apple.com Date 2022-04-07 10:06:19 -0700 (Thu, 07 Apr 2022) Log Message Remove redundant invalidateStyleForSubtree() calls https://bugs.webkit.org/show_bug.cgi?id=238922 Reviewed by Antti Koivisto. These calls were for :invalid/:valid validation, which now are invalidated using Style::PseudoClassChangeInvalidation. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::maxLengthAttributeChanged): (WebCore::HTMLInputElement::minLengthAttributeChanged): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLInputElement.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (292540 => 292541) --- trunk/Source/WebCore/ChangeLog 2022-04-07 17:03:19 UTC (rev 292540) +++ trunk/Source/WebCore/ChangeLog 2022-04-07 17:06:19 UTC (rev 292541) @@ -1,3 +1,16 @@ +2022-04-07 Tim Nguyen + +Remove redundant invalidateStyleForSubtree() calls +https://bugs.webkit.org/show_bug.cgi?id=238922 + +Reviewed by Antti Koivisto. + +These calls were for :invalid/:valid validation, which now are invalidated using Style::PseudoClassChangeInvalidation. + +* html/HTMLInputElement.cpp: +(WebCore::HTMLInputElement::maxLengthAttributeChanged): +(WebCore::HTMLInputElement::minLengthAttributeChanged): + 2022-04-07 Chris Dumez Drop unused EditorClient::getAutoCorrectSuggestionForMisspelledWord() Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (292540 => 292541) --- trunk/Source/WebCore/html/HTMLInputElement.cpp 2022-04-07 17:03:19 UTC (rev 292540) +++ trunk/Source/WebCore/html/HTMLInputElement.cpp 2022-04-07 17:06:19 UTC (rev 292541) @@ -1911,8 +1911,6 @@ if (oldEffectiveMaxLength != effectiveMaxLength()) updateValueIfNeeded(); -// FIXME: Do we really need to do this if the effective maxLength has not changed? -invalidateStyleForSubtree(); updateValidity(); } @@ -1923,8 +1921,6 @@ if (oldMinLength != minLength()) updateValueIfNeeded(); -// FIXME: Do we really need to do this if the effective minLength has not changed? -invalidateStyleForSubtree(); updateValidity(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292540] trunk
Title: [292540] trunk Revision 292540 Author commit-qu...@webkit.org Date 2022-04-07 10:03:19 -0700 (Thu, 07 Apr 2022) Log Message [JSC][ARMv7] Support proper near calls and JUMP_ISLANDS https://bugs.webkit.org/show_bug.cgi?id=238143 Patch by Geza Lore on 2022-04-07 Reviewed by Yusuke Suzuki. JSTests: * microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js: Source/_javascript_Core: Implement nearCall and nearTailCall as single instruction direct branches on ARMv7/Thumb-2. (Will need to support these for Wasm JITs, to implement threadSafePatchableNearcall.) To make this possible while also having an executable pool size larger than the branch range, I also ported JUMP_ISLANDS. To port JUMP_ISLANDS, a reformulation of the region allocations was necessary, which is now done in terms of the range of the nearCall/nearTailCall macroassembler macros. For ARM64, the behaviour should be identical. The jump islad reservation on ARMv7 is set to 5% of executable memory size, which is approximately the same as the baseline JIT code size saving provided by using short branches for near calls, so the change should be neutral overall with respect to executable memory consumption. Also made it possible for the --jitMemoryReservationSize option to request JIT memory that is larger than the default hardcoded size while using JUMP_ISLANDS (we need this for testing on ARMv7, which has a smaller default executable pool size). To do this the region allocators are no longer statically allocated but are held in a FixedVector. Also removed the unused repatchCompact methods from assemblers. * assembler/ARM64Assembler.h: * assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::isEven): (JSC::ARMv7Assembler::makeEven): (JSC::ARMv7Assembler::bl): (JSC::ARMv7Assembler::link): (JSC::ARMv7Assembler::linkTailCall): (JSC::ARMv7Assembler::linkCall): (JSC::ARMv7Assembler::relinkCall): (JSC::ARMv7Assembler::relinkTailCall): (JSC::ARMv7Assembler::prepareForAtomicRelinkJumpConcurrently): (JSC::ARMv7Assembler::prepareForAtomicRelinkCallConcurrently): (JSC::ARMv7Assembler::replaceWithJump): (JSC::ARMv7Assembler::canEmitJump): (JSC::ARMv7Assembler::isBL): (JSC::ARMv7Assembler::linkJumpT4): (JSC::ARMv7Assembler::linkConditionalJumpT4): (JSC::ARMv7Assembler::linkJumpAbsolute): (JSC::ARMv7Assembler::linkBranch): * assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::repatchNearCall): * assembler/AssemblerCommon.h: (JSC::isInt): * assembler/MIPSAssembler.h: * assembler/MacroAssemblerARM64.h: * assembler/MacroAssemblerARMv7.h: (JSC::MacroAssemblerARMv7::nearCall): (JSC::MacroAssemblerARMv7::nearTailCall): (JSC::MacroAssemblerARMv7::linkCall): * assembler/MacroAssemblerMIPS.h: * assembler/MacroAssemblerRISCV64.h: * assembler/MacroAssemblerX86Common.h: * assembler/X86Assembler.h: * bytecode/Repatch.cpp: (JSC::linkPolymorphicCall): * jit/ExecutableAllocator.cpp: (JSC::initializeJITPageReservation): Source/WTF: Support constructor arguments for FixedVector element initialization. * wtf/EmbeddedFixedVector.h: * wtf/FixedVector.h: (WTF::FixedVector::FixedVector): * wtf/PlatformEnable.h: * wtf/TrailingArray.h: (WTF::TrailingArray::TrailingArray): * wtf/Vector.h: (WTF::VectorTypeOperations::initializeWithArgs): Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/assembler/ARM64Assembler.h trunk/Source/_javascript_Core/assembler/ARMv7Assembler.h trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h trunk/Source/_javascript_Core/assembler/AssemblerCommon.h trunk/Source/_javascript_Core/assembler/MIPSAssembler.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h trunk/Source/_javascript_Core/assembler/MacroAssemblerARMv7.h trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h trunk/Source/_javascript_Core/assembler/MacroAssemblerRISCV64.h trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h trunk/Source/_javascript_Core/assembler/RISCV64Assembler.h trunk/Source/_javascript_Core/assembler/X86Assembler.h trunk/Source/_javascript_Core/bytecode/Repatch.cpp trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/EmbeddedFixedVector.h trunk/Source/WTF/wtf/FixedVector.h trunk/Source/WTF/wtf/PlatformEnable.h trunk/Source/WTF/wtf/TrailingArray.h trunk/Source/WTF/wtf/Vector.h Diff Modified: trunk/JSTests/ChangeLog (292539 => 292540) --- trunk/JSTests/ChangeLog 2022-04-07 16:10:36 UTC (rev 292539) +++ trunk/JSTests/ChangeLog 2022-04-07 17:03:19 UTC (rev 292540) @@ -1,3 +1,12 @@ +2022-04-07 Geza Lore + +[JSC][ARMv7] Support proper near calls and JUMP_ISLANDS +https://bugs.webkit.org/show_bug.cgi?id=238143 + +Reviewed by Yusuke Suzuki. + +* microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js: + 2022-04-06 Yusuke Suzuki
[webkit-changes] [292539] trunk
Title: [292539] trunk
Revision 292539
Author you...@apple.com
Date 2022-04-07 09:10:36 -0700 (Thu, 07 Apr 2022)
Log Message
Use the same callback mechanism for ServiceWorker openWindow and navigate in UIProcess
https://bugs.webkit.org/show_bug.cgi?id=238924
Reviewed by Chris Dumez.
Source/WebKit:
Reuse WebFrameProxy navigation delegate for openWindow once the main frame is created.
This ensures we get the same behavior for both code paths and makes sure openWindow does not hang if a delegate cancels the load.
Covered by API test.
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::transferNavigationCallbackToFrame):
(WebKit::WebFrameProxy::setNavigationCallback):
* UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::transferNavigationCallbackToFrame): Deleted.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCreateMainFrame):
(WebKit::WebPageProxy::callLoadCompletionHandlersIfNecessary):
* UIProcess/WebPageProxy.h:
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::openWindowFromServiceWorker):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
(-[ServiceWorkerPSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[ServiceWorkerPSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[ServiceWorkerOpenWindowWebsiteDataStoreDelegate initWithConfiguration:]):
(-[ServiceWorkerOpenWindowWebsiteDataStoreDelegate websiteDataStore:openWindow:fromServiceWorkerOrigin:completionHandler:]):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebFrameProxy.cpp
trunk/Source/WebKit/UIProcess/WebFrameProxy.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (292538 => 292539)
--- trunk/Source/WebKit/ChangeLog 2022-04-07 16:09:50 UTC (rev 292538)
+++ trunk/Source/WebKit/ChangeLog 2022-04-07 16:10:36 UTC (rev 292539)
@@ -1,3 +1,27 @@
+2022-04-07 Youenn Fablet
+
+Use the same callback mechanism for ServiceWorker openWindow and navigate in UIProcess
+https://bugs.webkit.org/show_bug.cgi?id=238924
+
+Reviewed by Chris Dumez.
+
+Reuse WebFrameProxy navigation delegate for openWindow once the main frame is created.
+This ensures we get the same behavior for both code paths and makes sure openWindow does not hang if a delegate cancels the load.
+
+Covered by API test.
+
+* UIProcess/WebFrameProxy.cpp:
+(WebKit::WebFrameProxy::transferNavigationCallbackToFrame):
+(WebKit::WebFrameProxy::setNavigationCallback):
+* UIProcess/WebFrameProxy.h:
+(WebKit::WebFrameProxy::transferNavigationCallbackToFrame): Deleted.
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::didCreateMainFrame):
+(WebKit::WebPageProxy::callLoadCompletionHandlersIfNecessary):
+* UIProcess/WebPageProxy.h:
+* UIProcess/WebsiteData/WebsiteDataStore.cpp:
+(WebKit::WebsiteDataStore::openWindowFromServiceWorker):
+
2022-04-07 Chris Dumez
Drop unused EditorClient::getAutoCorrectSuggestionForMisspelledWord()
Modified: trunk/Source/WebKit/UIProcess/WebFrameProxy.cpp (292538 => 292539)
--- trunk/Source/WebKit/UIProcess/WebFrameProxy.cpp 2022-04-07 16:09:50 UTC (rev 292538)
+++ trunk/Source/WebKit/UIProcess/WebFrameProxy.cpp 2022-04-07 16:10:36 UTC (rev 292539)
@@ -282,6 +282,17 @@
m_frameLoadState.setUnreachableURL(unreachableURL);
}
+void WebFrameProxy::transferNavigationCallbackToFrame(WebFrameProxy& frame)
+{
+frame.setNavigationCallback(WTFMove(m_navigateCallback));
+}
+
+void WebFrameProxy::setNavigationCallback(CompletionHandler)>&& navigateCallback)
+{
+ASSERT(!m_navigateCallback);
+m_navigateCallback = WTFMove(navigateCallback);
+}
+
#if ENABLE(CONTENT_FILTERING)
bool WebFrameProxy::didHandleContentFilterUnblockNavigation(const ResourceRequest& request)
{
Modified: trunk/Source/WebKit/UIProcess/WebFrameProxy.h (292538 => 292539)
--- trunk/Source/WebKit/UIProcess/WebFrameProxy.h 2022-04-07 16:09:50 UTC (rev 292538)
+++ trunk/Source/WebKit/UIProcess/WebFrameProxy.h 2022-04-07 16:10:36 UTC (rev 292539)
@@ -130,7 +130,8 @@
void collapseSelection();
#endif
-void transferNavigationCallbackToFrame(WebFrameProxy& frame) { frame.m_navigateCallback = WTFMove(m_navigateCallback); }
+void transferNavigationCallbackToFrame(WebFrameProxy&);
+void setNavigationCallback(CompletionHandler)>&&);
private:
WebFrameProxy(WebPageProxy&, WebCore::FrameIdentifier);
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (292538 => 292539)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-04-07 16:09:50 UTC (rev 292538)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-04-07
[webkit-changes] [292538] trunk/Tools
Title: [292538] trunk/Tools Revision 292538 Author jbed...@apple.com Date 2022-04-07 09:09:50 -0700 (Thu, 07 Apr 2022) Log Message [git-webkit] Clear merging-blocked label on PR update https://bugs.webkit.org/show_bug.cgi?id=238907 Reviewed by Aakash Jain. * Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py: (Tracker.set): Empty list should trigger request. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py: (Issue.set_labels): Pass self to tracker.set. * Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py: (GitHub.__init__): Set self.labels from passed argument. (GitHub._issue): Handle empty list. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: (PullRequest): Add BLOCKED_LABEL constant. (PullRequest.main): Remove 'merging-blocked' label from existing pull-request before updating pull-request. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: Canonical link: https://commits.webkit.org/249376@main Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitbugspy/setup.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py trunk/Tools/Scripts/libraries/webkitscmpy/setup.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py Diff Modified: trunk/Tools/ChangeLog (292537 => 292538) --- trunk/Tools/ChangeLog 2022-04-07 15:29:42 UTC (rev 292537) +++ trunk/Tools/ChangeLog 2022-04-07 16:09:50 UTC (rev 292538) @@ -1,3 +1,28 @@ +2022-04-07 Jonathan Bedard + +[git-webkit] Clear merging-blocked label on PR update +https://bugs.webkit.org/show_bug.cgi?id=238907 + + +Reviewed by Aakash Jain. + +* Scripts/libraries/webkitbugspy/setup.py: Bump version. +* Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto. +* Scripts/libraries/webkitbugspy/webkitbugspy/github.py: +(Tracker.set): Empty list should trigger request. +* Scripts/libraries/webkitbugspy/webkitbugspy/issue.py: +(Issue.set_labels): Pass self to tracker.set. +* Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py: +(GitHub.__init__): Set self.labels from passed argument. +(GitHub._issue): Handle empty list. +* Scripts/libraries/webkitscmpy/setup.py: Bump version. +* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. +* Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: +(PullRequest): Add BLOCKED_LABEL constant. +(PullRequest.main): Remove 'merging-blocked' label from existing pull-request +before updating pull-request. +* Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: + 2022-04-06 Jonathan Bedard [Merge-Queue] Share code for _addToLog Modified: trunk/Tools/Scripts/libraries/webkitbugspy/setup.py (292537 => 292538) --- trunk/Tools/Scripts/libraries/webkitbugspy/setup.py 2022-04-07 15:29:42 UTC (rev 292537) +++ trunk/Tools/Scripts/libraries/webkitbugspy/setup.py 2022-04-07 16:09:50 UTC (rev 292538) @@ -30,7 +30,7 @@ setup( name='webkitbugspy', -version='0.5.1', +version='0.5.2', description='Library containing a shared API for various bug trackers.', long_description=readme(), classifiers=[ Modified: trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py (292537 => 292538) --- trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py 2022-04-07 15:29:42 UTC (rev 292537) +++ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py 2022-04-07 16:09:50 UTC (rev 292538) @@ -46,7 +46,7 @@ "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url `" ) -version = Version(0, 5, 1) +version = Version(0, 5, 2) from .user import User from .issue import Issue Modified: trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py (292537 => 292538) --- trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py 2022-04-07 15:29:42 UTC (rev 292537) +++ trunk/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py 2022-04-07 16:09:50 UTC (rev 292538) @@ -356,7 +356,7 @@ if version: labels.append(version) -if labels: +if labels is not None: for label in labels:
[webkit-changes] [292537] trunk/LayoutTests
Title: [292537] trunk/LayoutTests Revision 292537 Author za...@apple.com Date 2022-04-07 08:29:42 -0700 (Thu, 07 Apr 2022) Log Message Fix the expected failure type. Unreviewed. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (292536 => 292537) --- trunk/LayoutTests/ChangeLog 2022-04-07 15:26:58 UTC (rev 292536) +++ trunk/LayoutTests/ChangeLog 2022-04-07 15:29:42 UTC (rev 292537) @@ -1,5 +1,13 @@ 2022-04-07 Alan Bujtas +Fix the expected failure type. + +Unreviewed. + +* platform/mac-wk1/TestExpectations: + +2022-04-07 Alan Bujtas + A float avoider should never take a vertical position where a float is present even when its used width is zero https://bugs.webkit.org/show_bug.cgi?id=238895 Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (292536 => 292537) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-07 15:26:58 UTC (rev 292536) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-04-07 15:29:42 UTC (rev 292537) @@ -1870,4 +1870,4 @@ http/tests/webgpu/webgpu/shader/validation/shader_io/locations.html [ Skip ] http/tests/webgpu/webgpu/shader/validation/wgsl/basic.html [ Skip ] -webkit.org/b/238642 imported/w3c/web-platform-tests/css/css-contain/contain-body-overflow-002.html [ Failure ] +webkit.org/b/238642 imported/w3c/web-platform-tests/css/css-contain/contain-body-overflow-002.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292536] trunk/Tools
Title: [292536] trunk/Tools
Revision 292536
Author jbed...@apple.com
Date 2022-04-07 08:26:58 -0700 (Thu, 07 Apr 2022)
Log Message
[Merge-Queue] Share code for _addToLog
https://bugs.webkit.org/show_bug.cgi?id=238913
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/steps.py:
(AddToLogMixin): Base class for all classes using _addToLog
(ConfigureBuild): Use from AddToLogMixin.
(AnalyzeChange): Ditto.
(BugzillaMixin): Ditto.
(ValidateCommitterAndReviewer): Ditto.
(BlockPullRequest): Ditto.
(RunBindingsTests): Ditto.
(WebKitPyTest): Ditto.
(CompileWebKit): Ditto.
(RunJavaScriptCoreTests): Ditto.
(AnalyzeJSCTestsResults): Ditto.
(RunWebKitTests): Ditto.
(AnalyzeAPITestsResults): Ditto.
(UpdatePullRequest): Ditto.
(ConfigureBuild._addToLog): Deleted.
(AnalyzeChange._addToLog): Deleted.
(BugzillaMixin._addToLog): Deleted.
(ValidateCommitterAndReviewer._addToLog): Deleted.
(BlockPullRequest._addToLog): Deleted.
(RunBindingsTests._addToLog): Deleted.
(WebKitPyTest._addToLog): Deleted.
(CompileWebKit._addToLog): Deleted.
(RunJavaScriptCoreTests._addToLog): Deleted.
(AnalyzeJSCTestsResults._addToLog): Deleted.
(RunWebKitTests._addToLog): Deleted.
(AnalyzeAPITestsResults._addToLog): Deleted.
(CheckPatchStatusOnEWSQueues._addToLog): Deleted.
(UpdatePullRequest._addToLog): Deleted.
Canonical link: https://commits.webkit.org/249374@main
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (292535 => 292536)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 14:43:36 UTC (rev 292535)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-04-07 15:26:58 UTC (rev 292536)
@@ -374,6 +374,16 @@
return 'true'
+class AddToLogMixin(object):
+@defer.inlineCallbacks
+def _addToLog(self, logName, message):
+try:
+log = self.getLog(logName)
+except KeyError:
+log = yield self.addLog(logName)
+log.addStdout(message)
+
+
class Contributors(object):
url = ''
contributors = {}
@@ -432,7 +442,7 @@
return contributors, errors
-class ConfigureBuild(buildstep.BuildStep):
+class ConfigureBuild(buildstep.BuildStep, AddToLogMixin):
name = 'configure-build'
description = ['configuring build']
descriptionDone = ['Configured build']
@@ -451,14 +461,6 @@
self.remotes = remotes
self.additionalArguments = additionalArguments
-@defer.inlineCallbacks
-def _addToLog(self, logName, message):
-try:
-log = self.getLog(logName)
-except KeyError:
-log = yield self.addLog(logName)
-log.addStdout(message)
-
def start(self):
if self.platform and self.platform != '*':
self.setProperty('platform', self.platform, 'config.json')
@@ -848,7 +850,7 @@
return super(CheckOutPullRequest, self).getResultSummary()
-class AnalyzeChange(buildstep.BuildStep):
+class AnalyzeChange(buildstep.BuildStep, AddToLogMixin):
flunkOnFailure = True
haltOnFailure = True
@@ -860,14 +862,6 @@
return sourcestamp.patch[1]
return None
-@defer.inlineCallbacks
-def _addToLog(self, logName, message):
-try:
-log = self.getLog(logName)
-except KeyError:
-log = yield self.addLog(logName)
-log.addStdout(message)
-
@property
def change_type(self):
if self.getProperty('github.number', False):
@@ -1051,18 +1045,11 @@
return '{}attachment.cgi?id={}="" patch_id)
-class BugzillaMixin(object):
+class BugzillaMixin(AddToLogMixin):
addURLs = False
bug_open_statuses = ['UNCONFIRMED', 'NEW', 'ASSIGNED', 'REOPENED']
bug_closed_statuses = ['RESOLVED', 'VERIFIED', 'CLOSED']
fast_cq_preambles = ('revert of r', 'fast-cq', '[fast-cq]')
-@defer.inlineCallbacks
-def _addToLog(self, logName, message):
-try:
-log = self.getLog(logName)
-except KeyError:
-log = yield self.addLog(logName)
-log.addStdout(message)
def fetch_data_from_url_with_authentication(self, url):
response = None
@@ -1487,7 +1474,7 @@
return True
-class ValidateCommitterAndReviewer(buildstep.BuildStep, GitHubMixin):
+class ValidateCommitterAndReviewer(buildstep.BuildStep, GitHubMixin, AddToLogMixin):
name = 'validate-commiter-and-reviewer'
descriptionDone = ['Validated commiter and reviewer']
@@ -1495,14 +1482,6 @@
super(ValidateCommitterAndReviewer, self).__init__(*args, **kwargs)
self.contributors = {}
-@defer.inlineCallbacks
-def _addToLog(self, logName, message):
-try:
-log = self.getLog(logName)
-except KeyError:
-log = yield self.addLog(logName)
-log.addStdout(message)
-
def getResultSummary(self):
if self.results == FAILURE:
return {'step': self.descriptionDone}
@@ -1648,17 +1627,9
[webkit-changes] [292535] trunk/Source/JavaScriptCore
Title: [292535] trunk/Source/_javascript_Core
Revision 292535
Author commit-qu...@webkit.org
Date 2022-04-07 07:43:36 -0700 (Thu, 07 Apr 2022)
Log Message
[JSC][32bit] Use constexpr tags instead of enums
https://bugs.webkit.org/show_bug.cgi?id=238926
Patch by Geza Lore on 2022-04-07
Reviewed by Yusuke Suzuki.
The *Tag values are just 32-bit constants, so define them as
constexpr. This reduces compiler nuisance warnings about enum
comparisons.
* dfg/DFGSpeculativeJIT.cpp:
* runtime/JSCJSValue.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/runtime/JSCJSValue.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292534 => 292535)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-07 14:40:11 UTC (rev 292534)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-07 14:43:36 UTC (rev 292535)
@@ -1,3 +1,17 @@
+2022-04-07 Geza Lore
+
+[JSC][32bit] Use constexpr tags instead of enums
+https://bugs.webkit.org/show_bug.cgi?id=238926
+
+Reviewed by Yusuke Suzuki.
+
+The *Tag values are just 32-bit constants, so define them as
+constexpr. This reduces compiler nuisance warnings about enum
+comparisons.
+
+* dfg/DFGSpeculativeJIT.cpp:
+* runtime/JSCJSValue.h:
+
2022-04-07 Carlos Garcia Campos
[GTK][WPE] RemoteInspector add support for IPv6
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (292534 => 292535)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2022-04-07 14:40:11 UTC (rev 292534)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2022-04-07 14:43:36 UTC (rev 292535)
@@ -11674,9 +11674,7 @@
JSValueRegs(gpr), edge, SpecBytecodeNumber,
m_jit.branchIfNotNumber(gpr));
#else
-IGNORE_WARNINGS_BEGIN("enum-compare")
static_assert(JSValue::Int32Tag >= JSValue::LowestTag, "Int32Tag is included in >= JSValue::LowestTag range.");
-IGNORE_WARNINGS_END
GPRReg tagGPR = value.tagGPR();
DFG_TYPE_CHECK(
value.jsValueRegs(), edge, ~SpecInt32Only,
@@ -12321,9 +12319,7 @@
regs, edge, SpecMisc,
m_jit.branch64(MacroAssembler::Above, regs.gpr(), MacroAssembler::TrustedImm64(JSValue::MiscTag)));
#else
-IGNORE_WARNINGS_BEGIN("enum-compare")
static_assert(JSValue::Int32Tag >= JSValue::UndefinedTag, "Int32Tag is included in >= JSValue::UndefinedTag range.");
-IGNORE_WARNINGS_END
DFG_TYPE_CHECK(
regs, edge, ~SpecInt32Only,
m_jit.branchIfInt32(regs.tagGPR()));
Modified: trunk/Source/_javascript_Core/runtime/JSCJSValue.h (292534 => 292535)
--- trunk/Source/_javascript_Core/runtime/JSCJSValue.h 2022-04-07 14:40:11 UTC (rev 292534)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValue.h 2022-04-07 14:43:36 UTC (rev 292535)
@@ -157,16 +157,15 @@
public:
#if USE(JSVALUE32_64)
-enum { Int32Tag =0x };
-enum { BooleanTag = 0xfffe };
-enum { NullTag = 0xfffd };
-enum { UndefinedTag =0xfffc };
-enum { CellTag = 0xfffb };
-enum { EmptyValueTag = 0xfffa };
-enum { DeletedValueTag = 0xfff9 };
+static constexpr uint32_t Int32Tag =0x;
+static constexpr uint32_t BooleanTag = 0xfffe;
+static constexpr uint32_t NullTag = 0xfffd;
+static constexpr uint32_t UndefinedTag =0xfffc;
+static constexpr uint32_t CellTag = 0xfffb;
+static constexpr uint32_t EmptyValueTag = 0xfffa;
+static constexpr uint32_t DeletedValueTag = 0xfff9;
-enum { LowestTag = DeletedValueTag };
-
+static constexpr uint32_t LowestTag = DeletedValueTag;
#endif
static EncodedJSValue encode(JSValue);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292534] trunk/Source
Title: [292534] trunk/Source
Revision 292534
Author cdu...@apple.com
Date 2022-04-07 07:40:11 -0700 (Thu, 07 Apr 2022)
Log Message
Drop unused EditorClient::getAutoCorrectSuggestionForMisspelledWord()
https://bugs.webkit.org/show_bug.cgi?id=238897
Reviewed by Wenson Hsieh.
Source/WebCore:
* editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
* editing/TextCheckingHelper.cpp:
(WebCore::findMisspellings):
* loader/EmptyClients.cpp:
* platform/text/TextCheckerClient.h:
Source/WebKit:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::getAutoCorrectSuggestionForMisspelledWord): Deleted.
* WebProcess/WebCoreSupport/WebEditorClient.h:
Source/WebKitLegacy/mac:
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::getAutoCorrectSuggestionForMisspelledWord): Deleted.
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::getAutoCorrectSuggestionForMisspelledWord): Deleted.
Source/WebKitLegacy/win:
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::getAutoCorrectSuggestionForMisspelledWord): Deleted.
* WebCoreSupport/WebEditorClient.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/TextCheckingHelper.cpp
trunk/Source/WebCore/loader/EmptyClients.cpp
trunk/Source/WebCore/platform/text/TextCheckerClient.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.cpp
trunk/Source/WebKitLegacy/win/WebCoreSupport/WebEditorClient.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (292533 => 292534)
--- trunk/Source/WebCore/ChangeLog 2022-04-07 13:34:59 UTC (rev 292533)
+++ trunk/Source/WebCore/ChangeLog 2022-04-07 14:40:11 UTC (rev 292534)
@@ -1,3 +1,17 @@
+2022-04-07 Chris Dumez
+
+Drop unused EditorClient::getAutoCorrectSuggestionForMisspelledWord()
+https://bugs.webkit.org/show_bug.cgi?id=238897
+
+Reviewed by Wenson Hsieh.
+
+* editing/Editor.cpp:
+(WebCore::Editor::markMisspellingsAfterTypingToWord):
+* editing/TextCheckingHelper.cpp:
+(WebCore::findMisspellings):
+* loader/EmptyClients.cpp:
+* platform/text/TextCheckerClient.h:
+
2022-04-07 Alan Bujtas
A float avoider should never take a vertical position where a float is present even when its used width is zero
Modified: trunk/Source/WebCore/editing/Editor.cpp (292533 => 292534)
--- trunk/Source/WebCore/editing/Editor.cpp 2022-04-07 13:34:59 UTC (rev 292533)
+++ trunk/Source/WebCore/editing/Editor.cpp 2022-04-07 14:40:11 UTC (rev 292534)
@@ -2642,28 +2642,7 @@
// Autocorrect the misspelled word.
if (!misspellingRange)
return;
-
-// Get the misspelled word.
-String autocorrectedString = textChecker()->getAutoCorrectSuggestionForMisspelledWord(plainText(*misspellingRange));
-// If autocorrected word is non empty, replace the misspelled word by this word.
-if (!autocorrectedString.isEmpty()) {
-VisibleSelection newSelection(*misspellingRange);
-if (newSelection != m_document.selection().selection()) {
-if (!m_document.selection().shouldChangeSelection(newSelection))
-return;
-m_document.selection().setSelection(newSelection);
-}
-
-if (!m_document.editor().shouldInsertText(autocorrectedString, misspellingRange, EditorInsertAction::Typed))
-return;
-m_document.editor().replaceSelectionWithText(autocorrectedString, SelectReplacement::No, SmartReplace::No, EditAction::Insert);
-
-// Reset the charet one character further.
-m_document.selection().moveTo(m_document.selection().selection().end());
-m_document.selection().modify(FrameSelection::AlterationMove, SelectionDirection::Forward, TextGranularity::CharacterGranularity);
-}
-
if (!isGrammarCheckingEnabled())
return;
Modified: trunk/Source/WebCore/editing/TextCheckingHelper.cpp (292533 => 292534)
--- trunk/Source/WebCore/editing/TextCheckingHelper.cpp 2022-04-07 13:34:59 UTC (rev 292533)
+++ trunk/Source/WebCore/editing/TextCheckingHelper.cpp 2022-04-07 14:40:11 UTC (rev 292534)
@@ -94,7 +94,6 @@
TextCheckingResult misspelling;
misspelling.type = TextCheckingType::Spelling;
misspelling.range = CharacterRange(wordStart + misspellingLocation, misspellingLength);
-misspelling.replacement = client.getAutoCorrectSuggestionForMisspelledWord(text.substring(misspelling.range.location, misspelling.range.length).toStringWithoutCopying());
results.append(misspelling);
}
Modified:
[webkit-changes] [292533] trunk/Source/WebKit
Title: [292533] trunk/Source/WebKit Revision 292533 Author commit-qu...@webkit.org Date 2022-04-07 06:34:59 -0700 (Thu, 07 Apr 2022) Log Message IPC::Connection should support diverting all messages to a message queue in other thread https://bugs.webkit.org/show_bug.cgi?id=238608 Patch by Kimmo Kinnunen on 2022-04-07 Reviewed by Simon Fraser. Previously, it was possible to divert all messages to certain ReceiverName to a message queue. This is used in IPC streams functionality. Add a possibility to divert all messages to a message queue. Instead of passing ReceiverName, id pair to Connection, pass new struct ReceiverMatcher. Use ReceiverMatcher instead of pair optional, optional, since nullopt, id is not a valid case. This will be used in future patch for the case where IPC::Connection is created for the sole purpose of using it together with IPC stream connection. This also clarifies the overloaded use of destinationID 0 as a wildcard as well as a valid message destination. Also implement the possibility to divert all messages to particular ReceiverName, id 0. Previously this was signifying the destination ID wildcard. No new tests, refactor. * Platform/IPC/Connection.cpp: (IPC::Connection::SyncMessageState::enqueueMatchingMessages): (IPC::Connection::enqueueMatchingMessagesToMessageReceiveQueue): (IPC::Connection::addMessageReceiveQueue): (IPC::Connection::removeMessageReceiveQueue): (IPC::Connection::addWorkQueueMessageReceiver): (IPC::Connection::removeWorkQueueMessageReceiver): (IPC::Connection::addThreadMessageReceiver): (IPC::Connection::removeThreadMessageReceiver): * Platform/IPC/Connection.h: * Platform/IPC/Decoder.h: (IPC::Decoder::matches const): * Platform/IPC/MessageReceiveQueueMap.cpp: (IPC::MessageReceiveQueueMap::addImpl): (IPC::MessageReceiveQueueMap::remove): (IPC::MessageReceiveQueueMap::get const): * Platform/IPC/MessageReceiveQueueMap.h: (IPC::MessageReceiveQueueMap::add): * Platform/IPC/ReceiverMatcher.h: Copied from Source/WebKit/Platform/IPC/MessageReceiveQueueMap.h. (IPC::ReceiverMatcher::ReceiverMatcher): (IPC::ReceiverMatcher::createForLegacyAPI): (IPC::ReceiverMatcher::matches const): * Platform/IPC/StreamServerConnection.cpp: (IPC::StreamServerConnectionBase::startReceivingMessagesImpl): (IPC::StreamServerConnectionBase::stopReceivingMessagesImpl): * WebKit.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Platform/IPC/Connection.cpp trunk/Source/WebKit/Platform/IPC/Connection.h trunk/Source/WebKit/Platform/IPC/Decoder.h trunk/Source/WebKit/Platform/IPC/MessageReceiveQueueMap.cpp trunk/Source/WebKit/Platform/IPC/MessageReceiveQueueMap.h trunk/Source/WebKit/Platform/IPC/StreamServerConnection.cpp trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj Added Paths trunk/Source/WebKit/Platform/IPC/ReceiverMatcher.h Diff Modified: trunk/Source/WebKit/ChangeLog (292532 => 292533) --- trunk/Source/WebKit/ChangeLog 2022-04-07 13:28:51 UTC (rev 292532) +++ trunk/Source/WebKit/ChangeLog 2022-04-07 13:34:59 UTC (rev 292533) @@ -1,3 +1,54 @@ +2022-04-07 Kimmo Kinnunen + +IPC::Connection should support diverting all messages to a message queue in other thread +https://bugs.webkit.org/show_bug.cgi?id=238608 + +Reviewed by Simon Fraser. + +Previously, it was possible to divert all messages to certain ReceiverName to +a message queue. This is used in IPC streams functionality. + +Add a possibility to divert all messages to a message queue. Instead of +passing ReceiverName, id pair to Connection, pass new struct ReceiverMatcher. +Use ReceiverMatcher instead of pair optional, optional, since +nullopt, id is not a valid case. +This will be used in future patch for the case where IPC::Connection is created for +the sole purpose of using it together with IPC stream connection. +This also clarifies the overloaded use of destinationID 0 as a wildcard as well as +a valid message destination. + +Also implement the possibility to divert all messages to particular ReceiverName, +id 0. Previously this was signifying the destination ID wildcard. + +No new tests, refactor. + +* Platform/IPC/Connection.cpp: +(IPC::Connection::SyncMessageState::enqueueMatchingMessages): +(IPC::Connection::enqueueMatchingMessagesToMessageReceiveQueue): +(IPC::Connection::addMessageReceiveQueue): +(IPC::Connection::removeMessageReceiveQueue): +(IPC::Connection::addWorkQueueMessageReceiver): +(IPC::Connection::removeWorkQueueMessageReceiver): +(IPC::Connection::addThreadMessageReceiver): +(IPC::Connection::removeThreadMessageReceiver): +* Platform/IPC/Connection.h: +* Platform/IPC/Decoder.h: +(IPC::Decoder::matches const): +* Platform/IPC/MessageReceiveQueueMap.cpp: +(IPC::MessageReceiveQueueMap::addImpl): +
[webkit-changes] [292532] trunk
Title: [292532] trunk
Revision 292532
Author za...@apple.com
Date 2022-04-07 06:28:51 -0700 (Thu, 07 Apr 2022)
Log Message
A float avoider should never take a vertical position where a float is present even when its used width is zero
https://bugs.webkit.org/show_bug.cgi?id=238895
Reviewed by Antti Koivisto.
Source/WebCore:
A zero width available space is never a valid vertical position for a float avoider even when its width is zero too.
Test: fast/block/float/float-avoider-with-zero-width.html
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::getClearDelta): skip and check the next candidate poisition when no space is available.
LayoutTests:
* TestExpectations: inline-size-bfc-floats.html: never produced correct rendering, the red box just happened to be hidden (which made this test pass).
* fast/block/float/float-avoider-with-zero-width-expected.html: Added.
* fast/block/float/float-avoider-with-zero-width.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
Added Paths
trunk/LayoutTests/fast/block/float/float-avoider-with-shrinking-content-expected.html
trunk/LayoutTests/fast/block/float/float-avoider-with-shrinking-content.html
trunk/LayoutTests/fast/block/float/float-avoider-with-zero-width-expected.txt
trunk/LayoutTests/fast/block/float/float-avoider-with-zero-width.html
Diff
Modified: trunk/LayoutTests/ChangeLog (292531 => 292532)
--- trunk/LayoutTests/ChangeLog 2022-04-07 12:57:58 UTC (rev 292531)
+++ trunk/LayoutTests/ChangeLog 2022-04-07 13:28:51 UTC (rev 292532)
@@ -1,3 +1,14 @@
+2022-04-07 Alan Bujtas
+
+A float avoider should never take a vertical position where a float is present even when its used width is zero
+https://bugs.webkit.org/show_bug.cgi?id=238895
+
+Reviewed by Antti Koivisto.
+
+* TestExpectations: inline-size-bfc-floats.html: never produced correct rendering, the red box just happened to be hidden (which made this test pass).
+* fast/block/float/float-avoider-with-zero-width-expected.html: Added.
+* fast/block/float/float-avoider-with-zero-width.html: Added.
+
2022-04-07 Tim Nguyen
[:has() pseudo-class] Support invalidation for :autofill pseudo class
Modified: trunk/LayoutTests/TestExpectations (292531 => 292532)
--- trunk/LayoutTests/TestExpectations 2022-04-07 12:57:58 UTC (rev 292531)
+++ trunk/LayoutTests/TestExpectations 2022-04-07 13:28:51 UTC (rev 292532)
@@ -4639,7 +4639,6 @@
webanimations/translate-property-and-translate-animation-with-delay-on-forced-layer.html [ Skip ]
# CSS containment tests that fail
-imported/w3c/web-platform-tests/css/css-contain/contain-inline-size-bfc-floats-001.html [ ImageOnlyFailure ]
# webkit-ruby-text
imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/css/css-contain/contain-paint-021.html [ ImageOnlyFailure ]
@@ -4696,6 +4695,7 @@
webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-layout-container-001.https.html [ ImageOnlyFailure ]
webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-002.html [ ImageOnlyFailure ]
webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-foreignobject-no-size-container.html [ Skip ]
+webkit.org/b/229659 imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-size-bfc-floats.html [ ImageOnlyFailure ]
# Flaky css-contain test
imported/w3c/web-platform-tests/css/css-contain/content-visibility/animation-display-lock.html [ Failure Pass ]
Added: trunk/LayoutTests/fast/block/float/float-avoider-with-shrinking-content-expected.html (0 => 292532)
--- trunk/LayoutTests/fast/block/float/float-avoider-with-shrinking-content-expected.html (rev 0)
+++ trunk/LayoutTests/fast/block/float/float-avoider-with-shrinking-content-expected.html 2022-04-07 13:28:51 UTC (rev 292532)
@@ -0,0 +1,28 @@
+
+.outer {
+ width: 150px;
+}
+
+.float {
+ float: left;
+ background-color: green;
+ width: 100px;
+ height: 100px
+}
+
+.right {
+ float: right;
+ background-color: blue;
+}
+
+.float_avoider {
+ width: 50px;
+ height: 200px;
+ background: yellow;
+}
+
+
+
+
+
+
Added: trunk/LayoutTests/fast/block/float/float-avoider-with-shrinking-content.html (0 => 292532)
--- trunk/LayoutTests/fast/block/float/float-avoider-with-shrinking-content.html (rev 0)
+++ trunk/LayoutTests/fast/block/float/float-avoider-with-shrinking-content.html 2022-04-07 13:28:51 UTC (rev 292532)
@@ -0,0 +1,33 @@
+
+.outer {
+ width: 150px;
+}
+
+.float {
+ float: left;
+ background-color: green;
+ width: 100px;
+ height: 100px
+}
+
+.right {
+ float: right;
+ background-color: blue;
+}
+
+.float_avoider {
+ overflow: hidden;
+}
+
+.content
[webkit-changes] [292531] trunk
Title: [292531] trunk Revision 292531 Author n...@apple.com Date 2022-04-07 05:57:58 -0700 (Thu, 07 Apr 2022) Log Message [:has() pseudo-class] Support invalidation for :autofill pseudo class https://bugs.webkit.org/show_bug.cgi?id=238899 Reviewed by Antti Koivisto. Source/WebCore: Tests: LayoutTests/fast/forms/input-autofilled-*.html I've only added tests for the :autofill case, since the other pseudo-classes are supposed to be internal-only. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setAutoFilled): (WebCore::HTMLInputElement::setAutoFilledAndViewable): (WebCore::HTMLInputElement::setAutoFilledAndObscured): LayoutTests: * fast/forms/input-autofilled-expected.txt: * fast/forms/input-autofilled.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/forms/input-autofilled-expected.txt trunk/LayoutTests/fast/forms/input-autofilled.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLInputElement.cpp Diff Modified: trunk/LayoutTests/ChangeLog (292530 => 292531) --- trunk/LayoutTests/ChangeLog 2022-04-07 11:41:33 UTC (rev 292530) +++ trunk/LayoutTests/ChangeLog 2022-04-07 12:57:58 UTC (rev 292531) @@ -1,3 +1,13 @@ +2022-04-07 Tim Nguyen + +[:has() pseudo-class] Support invalidation for :autofill pseudo class +https://bugs.webkit.org/show_bug.cgi?id=238899 + +Reviewed by Antti Koivisto. + +* fast/forms/input-autofilled-expected.txt: +* fast/forms/input-autofilled.html: + 2022-04-06 Myles C. Maxfield NBSP characters drawn in fonts that don't support the space character turn into boxes Modified: trunk/LayoutTests/fast/forms/input-autofilled-expected.txt (292530 => 292531) --- trunk/LayoutTests/fast/forms/input-autofilled-expected.txt 2022-04-07 11:41:33 UTC (rev 292530) +++ trunk/LayoutTests/fast/forms/input-autofilled-expected.txt 2022-04-07 12:57:58 UTC (rev 292531) @@ -1,4 +1,6 @@ -This tests that foreground and background colors properly change for autofilled inputs. It can only be run using DumpRenderTree. +This tests that foreground and background colors properly change for autofilled inputs. -PASS +PASS Testing input style changing with UA stylesheet +PASS Testing form style changing with :has() selector + Modified: trunk/LayoutTests/fast/forms/input-autofilled.html (292530 => 292531) --- trunk/LayoutTests/fast/forms/input-autofilled.html 2022-04-07 11:41:33 UTC (rev 292530) +++ trunk/LayoutTests/fast/forms/input-autofilled.html 2022-04-07 12:57:58 UTC (rev 292531) @@ -1,65 +1,53 @@ + -+ + + +This tests that foreground and background colors properly change for autofilled inputs.
+ +