[webkit-changes] [294931] trunk/Source
Title: [294931] trunk/Source
Revision 294931
Author cdu...@apple.com
Date 2022-05-26 22:47:49 -0700 (Thu, 26 May 2022)
Log Message
Avoid ElementIdentifier-related work under Element::removedFromAncestor()
https://bugs.webkit.org/show_bug.cgi?id=240932
Reviewed by Darin Adler.
Avoid ElementIdentifier-related work under Element::removedFromAncestor() since it is a
hot function and we want to do as little work as possible in there.
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::dispatchSystemPreviewActionEvent):
(WebCore::Document::identifierForElement): Deleted.
(WebCore::Document::searchForElementByIdentifier): Deleted.
(WebCore::Document::identifiedElementWasRemovedFromDocument): Deleted.
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
(WebCore::elementIdentifiersMap):
(WebCore::Element::identifier const):
(WebCore::Element::fromIdentifier):
(WebCore::Element::createElementIdentifier): Deleted.
* Source/WebCore/dom/Element.h:
* Source/WebCore/dom/Node.h:
* Source/WebCore/html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
* Source/WebCore/page/InteractionRegion.cpp:
(WebCore::regionForElement):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::elementIdentifier const):
(WebCore::Internals::isElementAlive const):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::elementForContext const):
(WebKit::WebPage::contextForElement const):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::textInputContextsInRect):
Canonical link: https://commits.webkit.org/251042@main
Modified Paths
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/Node.h
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
trunk/Source/WebCore/page/InteractionRegion.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Diff
Modified: trunk/Source/WebCore/dom/Document.cpp (294930 => 294931)
--- trunk/Source/WebCore/dom/Document.cpp 2022-05-27 05:45:58 UTC (rev 294930)
+++ trunk/Source/WebCore/dom/Document.cpp 2022-05-27 05:47:49 UTC (rev 294931)
@@ -8906,30 +8906,6 @@
return resultLayer;
}
-ElementIdentifier Document::identifierForElement(Element& element)
-{
-ASSERT(() == this);
-auto result = m_identifiedElementsMap.ensure(, [&] {
-return element.createElementIdentifier();
-});
-return result.iterator->value;
-}
-
-Element* Document::searchForElementByIdentifier(const ElementIdentifier& identifier)
-{
-for (auto it = m_identifiedElementsMap.begin(); it != m_identifiedElementsMap.end(); ++it) {
-if (it->value == identifier)
-return it->key;
-}
-
-return nullptr;
-}
-
-void Document::identifiedElementWasRemovedFromDocument(Element& element)
-{
-m_identifiedElementsMap.remove();
-}
-
#if ENABLE(DEVICE_ORIENTATION)
DeviceOrientationAndMotionAccessController& Document::deviceOrientationAndMotionAccessController()
@@ -9024,11 +9000,11 @@
#if USE(SYSTEM_PREVIEW)
void Document::dispatchSystemPreviewActionEvent(const SystemPreviewInfo& systemPreviewInfo, const String& message)
{
-RefPtr element = searchForElementByIdentifier(systemPreviewInfo.element.elementIdentifier);
-if (!element)
+RefPtr element = Element::fromIdentifier(systemPreviewInfo.element.elementIdentifier);
+if (!is(element))
return;
-if (!is(element))
+if (!element->isConnected() || >document() != this)
return;
auto event = MessageEvent::create(message, securityOrigin().toString());
Modified: trunk/Source/WebCore/dom/Document.h (294930 => 294931)
--- trunk/Source/WebCore/dom/Document.h 2022-05-27 05:45:58 UTC (rev 294930)
+++ trunk/Source/WebCore/dom/Document.h 2022-05-27 05:47:49 UTC (rev 294931)
@@ -35,7 +35,6 @@
#include "CrossOriginOpenerPolicy.h"
#include "DisabledAdaptations.h"
#include "DocumentEventTiming.h"
-#include "ElementIdentifier.h"
#include "FocusOptions.h"
#include "FontSelectorClient.h"
#include "FrameDestructionObserver.h"
@@ -392,10 +391,6 @@
WEBCORE_EXPORT static DocumentsMap::ValuesIteratorRange allDocuments();
WEBCORE_EXPORT static DocumentsMap& allDocumentsMap();
-WEBCORE_EXPORT ElementIdentifier identifierForElement(Element&);
-WEBCORE_EXPORT Element* searchForElementByIdentifier(const ElementIdentifier&);
-void identifiedElementWasRemovedFromDocument(Element&);
-
MediaQueryMatcher& mediaQueryMatcher();
using ContainerNode::ref;
@@ -2263,8 +2258,6 @@
std::unique_ptr m_textManipulationController;
-HashMap m_identifiedElementsMap;
-
UniqueRef m_editor;
UniqueRef m_selection;
Modified:
[webkit-changes] [294930] trunk/Source/WebCore
Title: [294930] trunk/Source/WebCore
Revision 294930
Author cdu...@apple.com
Date 2022-05-26 22:45:58 -0700 (Thu, 26 May 2022)
Log Message
Move some of the work from Element::insertedIntoAncestor() / removedFromAncestor() to subclasses
https://bugs.webkit.org/show_bug.cgi?id=240914
Reviewed by Ryosuke Niwa and Darin Adler.
Move some of the work from Element::insertedIntoAncestor() / removedFromAncestor() to subclasses.
These functions are hot and should be kept as efficient as possible. There is no reason for every
Element to pay run-time cost for checks that only apply to article or label elements.
* Source/WebCore/Headers.cmake:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::insertedIntoAncestor):
(WebCore::Element::removedFromAncestor):
* Source/WebCore/dom/Element.h:
* Source/WebCore/html/HTMLArticleElement.cpp: Added.
(WebCore::HTMLArticleElement::create):
(WebCore::HTMLArticleElement::HTMLArticleElement):
(WebCore::HTMLArticleElement::insertedIntoAncestor):
(WebCore::HTMLArticleElement::removedFromAncestor):
* Source/WebCore/html/HTMLArticleElement.h: Added.
* Source/WebCore/html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::insertedIntoAncestor):
(WebCore::HTMLLabelElement::removedFromAncestor):
* Source/WebCore/html/HTMLLabelElement.h:
* Source/WebCore/html/HTMLTagNames.in:
Canonical link: https://commits.webkit.org/251041@main
Modified Paths
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/html/HTMLLabelElement.cpp
trunk/Source/WebCore/html/HTMLLabelElement.h
trunk/Source/WebCore/html/HTMLTagNames.in
Added Paths
trunk/Source/WebCore/html/HTMLArticleElement.cpp
trunk/Source/WebCore/html/HTMLArticleElement.h
Diff
Modified: trunk/Source/WebCore/Headers.cmake (294929 => 294930)
--- trunk/Source/WebCore/Headers.cmake 2022-05-27 05:20:50 UTC (rev 294929)
+++ trunk/Source/WebCore/Headers.cmake 2022-05-27 05:45:58 UTC (rev 294930)
@@ -838,6 +838,7 @@
html/HTMLAnchorElement.h
html/HTMLAnchorElementInlines.h
html/HTMLAreaElement.h
+html/HTMLArticleElement.h
html/HTMLAttachmentElement.h
html/HTMLAudioElement.h
html/HTMLBRElement.h
Modified: trunk/Source/WebCore/Sources.txt (294929 => 294930)
--- trunk/Source/WebCore/Sources.txt 2022-05-27 05:20:50 UTC (rev 294929)
+++ trunk/Source/WebCore/Sources.txt 2022-05-27 05:45:58 UTC (rev 294930)
@@ -1211,6 +1211,7 @@
html/HTMLAllCollection.cpp
html/HTMLAnchorElement.cpp
html/HTMLAreaElement.cpp
+html/HTMLArticleElement.cpp
html/HTMLAttachmentElement.cpp
html/HTMLAudioElement.cpp
html/HTMLBDIElement.cpp
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (294929 => 294930)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2022-05-27 05:20:50 UTC (rev 294929)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2022-05-27 05:45:58 UTC (rev 294930)
@@ -769,8 +769,8 @@
2AEF6FDB26E7ECC700326D02 /* CSSNumericArray.h in Headers */ = {isa = PBXBuildFile; fileRef = 2AEF6FBF26E716EE00326D02 /* CSSNumericArray.h */; };
2AEF6FDC26E7ECCC00326D02 /* CSSNumericBaseType.h in Headers */ = {isa = PBXBuildFile; fileRef = 2AEF6FCF26E71F2E00326D02 /* CSSNumericBaseType.h */; };
2AEF6FDD26E7ECCF00326D02 /* CSSNumericType.h in Headers */ = {isa = PBXBuildFile; fileRef = 2AEF6FCE26E71F2D00326D02 /* CSSNumericType.h */; };
+ 2B365C743425119AAB91D27B /* RenderSVGEllipse.h in Headers */ = {isa = PBXBuildFile; fileRef = 2B4235A015250EF555DB5CD8 /* RenderSVGEllipse.h */; };
2B365C841525119E0091D27B /* LegacyRenderSVGEllipse.h in Headers */ = {isa = PBXBuildFile; fileRef = 2B4235A015250F6000DBBCD8 /* LegacyRenderSVGEllipse.h */; };
- 2B365C743425119AAB91D27B /* RenderSVGEllipse.h in Headers */ = {isa = PBXBuildFile; fileRef = 2B4235A015250EF555DB5CD8 /* RenderSVGEllipse.h */; };
2BE8E2C712A589EC00FAD550 /* HTMLMetaCharsetParser.h in Headers */ = {isa = PBXBuildFile; fileRef = 2BE8E2C612A589EC00FAD550 /* HTMLMetaCharsetParser.h */; };
2D0621441DA639B600A7FB26 /* WebKitMediaKeyMessageEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2D0621421DA6398800A7FB26 /* WebKitMediaKeyMessageEvent.cpp */; };
2D0621451DA639BA00A7FB26 /* WebKitMediaKeyMessageEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 2D0621431DA6398800A7FB26 /* WebKitMediaKeyMessageEvent.h */; };
@@ -1384,6 +1384,7 @@
46BCBBC22085008F00710638 /* JSRemoteDOMWindowBase.h in Headers */ = {isa = PBXBuildFile; fileRef = 46BCBBC02085007F00710638 /* JSRemoteDOMWindowBase.h */; settings = {ATTRIBUTES = (Private, ); }; };
46BD05C525BB6E5900225F30 /* AddEventListenerOptions.h in Headers */ = {isa = PBXBuildFile; fileRef = 46BD05C225BB6E4E00225F30 /* AddEventListenerOptions.h */; settings = {ATTRIBUTES = (Private, ); }; };
46BD05C625BB6E6C00225F30 /*
[webkit-changes] [294929] trunk
Title: [294929] trunk
Revision 294929
Author ross.kirsl...@sony.com
Date 2022-05-26 22:20:50 -0700 (Thu, 26 May 2022)
Log Message
ArrayBuffer species should be ignored when cloning a Typed Array
https://bugs.webkit.org/show_bug.cgi?id=240996
Reviewed by Yusuke Suzuki.
This patch implements the spec change of tc39/ecma262#2719:
Constructing one Typed Array from another used to require that we check @@species on the source buffer and create
a new ArrayBuffer using the species constructor's *prototype*...without actually calling the species constructor itself.
Happily, this ridiculous behavior turned out to be web-compatible to remove.
* JSTests/test262/expectations.yaml:
* Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewWithArguments):
(JSC::constructCustomArrayBufferIfNeeded): Deleted.
Canonical link: https://commits.webkit.org/251040@main
Modified Paths
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h
Diff
Modified: trunk/JSTests/test262/expectations.yaml (294928 => 294929)
--- trunk/JSTests/test262/expectations.yaml 2022-05-27 03:55:15 UTC (rev 294928)
+++ trunk/JSTests/test262/expectations.yaml 2022-05-27 05:20:50 UTC (rev 294929)
@@ -1098,9 +1098,6 @@
test/built-ins/TypedArray/prototype/sort/sort-tonumber.js:
default: 'TypeError: Underlying ArrayBuffer has been detached from the view (Testing with Float64Array.)'
strict mode: 'TypeError: Underlying ArrayBuffer has been detached from the view (Testing with Float64Array.)'
-test/built-ins/TypedArrayConstructors/ctors/no-species.js:
- default: 'Test262Error: unreachable'
- strict mode: 'Test262Error: unreachable'
test/harness/temporalHelpers-one-shift-time-zone.js:
default: "TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainDateTime(2021, 3, 28, 1)')"
strict mode: "TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainDateTime(2021, 3, 28, 1)')"
Modified: trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h (294928 => 294929)
--- trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h 2022-05-27 03:55:15 UTC (rev 294928)
+++ trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h 2022-05-27 05:20:50 UTC (rev 294929)
@@ -105,43 +105,6 @@
return result;
}
-inline JSArrayBuffer* constructCustomArrayBufferIfNeeded(JSGlobalObject* globalObject, JSArrayBufferView* view)
-{
-VM& vm = globalObject->vm();
-auto scope = DECLARE_THROW_SCOPE(vm);
-
-JSArrayBuffer* source = view->possiblySharedJSBuffer(globalObject);
-RETURN_IF_EXCEPTION(scope, nullptr);
-if (source->isShared())
-return nullptr;
-
-std::optional species = arrayBufferSpeciesConstructor(globalObject, source, ArrayBufferSharingMode::Default);
-RETURN_IF_EXCEPTION(scope, nullptr);
-if (!species)
-return nullptr;
-
-if (!species->isConstructor()) {
-throwTypeError(globalObject, scope, "species is not a constructor"_s);
-return nullptr;
-}
-
-JSValue prototype = species->get(globalObject, vm.propertyNames->prototype);
-RETURN_IF_EXCEPTION(scope, nullptr);
-
-auto buffer = ArrayBuffer::tryCreate(source->impl()->byteLength(), 1);
-if (!buffer) {
-throwOutOfMemoryError(globalObject, scope);
-return nullptr;
-}
-
-JSGlobalObject* functionGlobalObject = getFunctionRealm(globalObject, asObject(species.value()));
-RETURN_IF_EXCEPTION(scope, nullptr);
-auto result = JSArrayBuffer::create(vm, functionGlobalObject->arrayBufferStructure(ArrayBufferSharingMode::Default), WTFMove(buffer));
-if (prototype.isObject())
-result->setPrototypeDirect(vm, prototype);
-return result;
-}
-
template
inline JSObject* constructGenericTypedArrayViewWithArguments(JSGlobalObject* globalObject, Structure* structure, EncodedJSValue firstArgument, size_t offset, std::optional lengthOpt)
{
@@ -183,13 +146,10 @@
if (JSObject* object = jsDynamicCast(firstValue)) {
size_t length;
-JSArrayBuffer* customBuffer = nullptr;
if (isTypedView(object->classInfo()->typedArrayStorageType)) {
auto* view = jsCast(object);
-customBuffer = constructCustomArrayBufferIfNeeded(globalObject, view);
-RETURN_IF_EXCEPTION(scope, nullptr);
if (view->isDetached()) {
throwTypeError(globalObject, scope, "Underlying ArrayBuffer has been detached from the view"_s);
return nullptr;
@@ -236,9 +196,7 @@
}
}
-ViewClass* result = customBuffer
-? ViewClass::create(globalObject, structure, customBuffer->impl(), 0, length)
-: ViewClass::createUninitialized(globalObject, structure, length);
+ViewClass* result = ViewClass::createUninitialized(globalObject,
[webkit-changes] [294928] trunk
Title: [294928] trunk
Revision 294928
Author s...@apple.com
Date 2022-05-26 20:55:15 -0700 (Thu, 26 May 2022)
Log Message
REGRESSION(r289580): Canvas: putImageData sometimes draws nothing
https://bugs.webkit.org/show_bug.cgi?id=240802
rdar://93801722
Reviewed by Simon Fraser.
RemoteImageBufferProxy::putPixelBuffer() needs to setNeedsFlush(true) once the
request to change the backend is sent to GPUProcess. If WebProcess has access to
the ImageBufferBackend, flushDrawingContext() will be called from copyNativeImage().
This call has to wait all DisplayList items and PutPixelBuffer messages to be
flushed to the backend before copyNativeImage() copies the pixels of the backend
to a NativeImage.
* Source/WebCore/platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::setNeedsFlush):
* Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:
(WebKit::RemoteDisplayListRecorderProxy::send):
(WebKit::RemoteDisplayListRecorderProxy::resetNeedsFlush): Deleted.
(WebKit::RemoteDisplayListRecorderProxy::needsFlush const): Deleted.
(): Deleted.
* Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h:
(WebKit::RemoteImageBufferProxy::~RemoteImageBufferProxy):
Canonical link: https://commits.webkit.org/251039@main
Modified Paths
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp
trunk/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferProxy.h
Added Paths
trunk/LayoutTests/fast/canvas/canvas-put-image-data-no-draw-expected.html
trunk/LayoutTests/fast/canvas/canvas-put-image-data-no-draw.html
Diff
Added: trunk/LayoutTests/fast/canvas/canvas-put-image-data-no-draw-expected.html (0 => 294928)
--- trunk/LayoutTests/fast/canvas/canvas-put-image-data-no-draw-expected.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-put-image-data-no-draw-expected.html 2022-05-27 03:55:15 UTC (rev 294928)
@@ -0,0 +1,13 @@
+
+
+
+const targetCanvas = document.getElementById('target');
+const target = targetCanvas.getContext('2d');
+
+const canvasWidth = targetCanvas.width;
+const canvasHeight = targetCanvas.height
+
+target.fillStyle = 'green';
+target.fillRect(0, 0, canvasWidth, canvasHeight);
+
+
Added: trunk/LayoutTests/fast/canvas/canvas-put-image-data-no-draw.html (0 => 294928)
--- trunk/LayoutTests/fast/canvas/canvas-put-image-data-no-draw.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-put-image-data-no-draw.html 2022-05-27 03:55:15 UTC (rev 294928)
@@ -0,0 +1,50 @@
+
+
+
+const targetCanvas = document.getElementById('target');
+const target = targetCanvas.getContext('2d');
+
+const canvasWidth = targetCanvas.width;
+const canvasHeight = targetCanvas.height
+
+var sourceCanvas = document.createElement('canvas');
+sourceCanvas.width = canvasWidth;
+sourceCanvas.height = canvasHeight;
+
+const source = sourceCanvas.getContext('2d');
+
+let progressX = 0;
+let progressY = 0;
+const paintSize = 100;
+
+source.fillStyle = 'green';
+source.fillRect(0, 0, canvasWidth, canvasHeight);
+const imagedata = source.getImageData(0, 0, canvasWidth, canvasHeight);
+
+function drawLoop() {
+target.putImageData(imagedata, 0, 0, progressX, progressY, paintSize, paintSize);
+
+progressX += paintSize;
+
+if (progressX + paintSize <= canvasWidth) {
+requestAnimationFrame(drawLoop);
+return;
+}
+
+if (progressY + paintSize > canvasHeight) {
+if (window.testRunner)
+testRunner.notifyDone();
+return;
+}
+
+progressX = 0;
+progressY += paintSize;
+requestAnimationFrame(drawLoop);
+}
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+requestAnimationFrame(drawLoop);
+
+
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (294927 => 294928)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-05-27 03:51:05 UTC (rev 294927)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2022-05-27 03:55:15 UTC (rev 294928)
@@ -1712,27 +1712,6 @@
webkit.org/b/240670 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html [ Pass Crash ]
-webkit.org/b/240735 [ Release ] webgl/2.0.0/conformance/textures/image_bitmap_from_image_bitmap/tex-2d-rgb-rgb-unsigned_short_5_6_5.html [ Pass Failure ]
[webkit-changes] [294927] trunk
Title: [294927] trunk
Revision 294927
Author achristen...@apple.com
Date 2022-05-26 20:51:05 -0700 (Thu, 26 May 2022)
Log Message
Use _adoptEffectiveConfiguration instead of a separate NSURLSession without credentials
https://bugs.webkit.org/show_bug.cgi?id=240362
Reviewed by Chris Dumez.
This is a PLT performance improvement because we spend less time initiating TCP connections.
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::initializeNSURLSessionsInSet):
(WebKit::SessionSet::initializeEphemeralStatelessSessionIfNeeded):
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
(WebKit::NetworkSessionCocoa::appBoundSession):
(WebKit::SessionSet::isolatedSession):
(WebKit::NetworkSessionCocoa::invalidateAndCancelSessionSet):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/cocoa/HTTPServer.mm:
(TestWebKitAPI::HTTPServer::respondWithChallengeThenOK):
Canonical link: https://commits.webkit.org/251038@main
Modified Paths
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.h
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/HSTS.mm
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm
trunk/Tools/TestWebKitAPI/cocoa/HTTPServer.mm
Diff
Modified: trunk/Source/WTF/wtf/PlatformHave.h (294926 => 294927)
--- trunk/Source/WTF/wtf/PlatformHave.h 2022-05-27 02:29:00 UTC (rev 294926)
+++ trunk/Source/WTF/wtf/PlatformHave.h 2022-05-27 03:51:05 UTC (rev 294927)
@@ -456,6 +456,7 @@
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12
#define HAVE_SAFARI_FOR_WEBKIT_DEVELOPMENT_REQUIRING_EXTRA_SYMBOLS 1
+#define HAVE_NSURLSESSION_EFFECTIVE_CONFIGURATION_OBJECT 1
#endif
#if PLATFORM(MAC)
Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (294926 => 294927)
--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2022-05-27 02:29:00 UTC (rev 294926)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h 2022-05-27 03:51:05 UTC (rev 294927)
@@ -60,6 +60,12 @@
#else // !USE(APPLE_INTERNAL_SDK)
+#if HAVE(NSURLSESSION_EFFECTIVE_CONFIGURATION_OBJECT) && defined(__OBJC__)
+@interface NSURLSessionEffectiveConfiguration : NSObject
+- (instancetype)_initWithConfiguration:(NSURLSessionConfiguration *)config;
+@end
+#endif // HAVE(NSURLSESSION_EFFECTIVE_CONFIGURATION_OBJECT) && defined(__OBJC__)
+
#if HAVE(PRECONNECT_PING) && defined(__OBJC__)
@interface _NSHTTPConnectionInfo : NSObject
@@ -280,6 +286,11 @@
@end
@interface NSURLSessionTask ()
+#if HAVE(NSURLSESSION_EFFECTIVE_CONFIGURATION_OBJECT)
+- (void)_adoptEffectiveConfiguration:(NSURLSessionEffectiveConfiguration *) newConfiguration;
+#else
+- (void)_adoptEffectiveConfiguration:(NSURLSessionConfiguration *) newConfiguration;
+#endif
- (NSDictionary *)_timingData;
@property (readwrite, copy) NSString *_pathToDownloadTaskFile;
@property (copy) NSString *_storagePartitionIdentifier;
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (294926 => 294927)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-05-27 02:29:00 UTC (rev 294926)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm 2022-05-27 03:51:05 UTC (rev 294927)
@@ -363,6 +363,27 @@
m_task = [m_sessionWrapper->session dataTaskWithRequest:nsRequest.get()];
+switch (parameters.storedCredentialsPolicy) {
+case WebCore::StoredCredentialsPolicy::Use:
+ASSERT(m_sessionWrapper->session.get().configuration.URLCredentialStorage);
+break;
+case WebCore::StoredCredentialsPolicy::EphemeralStateless:
+ASSERT(!m_sessionWrapper->session.get().configuration.URLCredentialStorage);
+break;
+case WebCore::StoredCredentialsPolicy::DoNotUse:
+#if HAVE(NSURLSESSION_EFFECTIVE_CONFIGURATION_OBJECT)
+NSURLSessionConfiguration *copiedConfiguration = m_sessionWrapper->session.get().configuration;
+copiedConfiguration.URLCredentialStorage = nil;
+auto effectiveConfiguration = adoptNS([[NSURLSessionEffectiveConfiguration alloc] _initWithConfiguration:copiedConfiguration]);
+[m_task _adoptEffectiveConfiguration:effectiveConfiguration.get()];
+#else
+NSURLSessionConfiguration *effectiveConfiguration = m_sessionWrapper->session.get().configuration;
+effectiveConfiguration.URLCredentialStorage = nil;
+[m_task _adoptEffectiveConfiguration:effectiveConfiguration];
+#endif
+break;
[webkit-changes] [294926] trunk/JSTests/test262
Title: [294926] trunk/JSTests/test262 Revision 294926 Author ross.kirsl...@sony.com Date 2022-05-26 19:29:00 -0700 (Thu, 26 May 2022) Log Message Unreviewed test262 gardening, use useArrayGroupByMethod for feature tests https://bugs.webkit.org/show_bug.cgi?id=240997 * JSTests/test262/config.yaml: * JSTests/test262/expectations.yaml: Canonical link: https://commits.webkit.org/251037@main Modified Paths trunk/JSTests/test262/config.yaml trunk/JSTests/test262/expectations.yaml Diff Modified: trunk/JSTests/test262/config.yaml (294925 => 294926) --- trunk/JSTests/test262/config.yaml 2022-05-27 01:54:22 UTC (rev 294925) +++ trunk/JSTests/test262/config.yaml 2022-05-27 02:29:00 UTC (rev 294926) @@ -8,6 +8,7 @@ String.prototype.at: useAtMethod Temporal: useTemporal array-find-from-last: useArrayFindLastMethod + array-grouping: useArrayGroupByMethod Object.hasOwn: useHasOwn ShadowRealm: useShadowRealm skip: Modified: trunk/JSTests/test262/expectations.yaml (294925 => 294926) --- trunk/JSTests/test262/expectations.yaml 2022-05-27 01:54:22 UTC (rev 294925) +++ trunk/JSTests/test262/expectations.yaml 2022-05-27 02:29:00 UTC (rev 294926) @@ -603,9 +603,6 @@ default: 'Test262Error: An initialized binding is not created prior to evaluation Expected a ReferenceError to be thrown but no exception was thrown at all' test/annexB/language/global-code/switch-dflt-global-skip-early-err.js: default: "SyntaxError: Cannot declare a function that shadows a let/const/class/function variable 'f' in strict mode." -test/built-ins/Array/prototype/Symbol.unscopables/array-grouping.js: - default: 'Test262Error: `groupBy` property value Expected SameValue(«undefined», «true») to be true' - strict mode: 'Test262Error: `groupBy` property value Expected SameValue(«undefined», «true») to be true' test/built-ins/Date/UTC/fp-evaluation-order.js: default: 'Test262Error: order of operations / precision in MakeTime Expected SameValue(«NaN», «29312») to be true' strict mode: 'Test262Error: order of operations / precision in MakeTime Expected SameValue(«NaN», «29312») to be true' ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294925] tags/WebKit-7614.1.14.3.4/
Title: [294925] tags/WebKit-7614.1.14.3.4/ Revision 294925 Author alanc...@apple.com Date 2022-05-26 18:54:22 -0700 (Thu, 26 May 2022) Log Message Tag WebKit-7614.1.14.3.4. Added Paths tags/WebKit-7614.1.14.3.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294924] branches/safari-7614.1.14.3-branch/Source
Title: [294924] branches/safari-7614.1.14.3-branch/Source Revision 294924 Author alanc...@apple.com Date 2022-05-26 18:51:03 -0700 (Thu, 26 May 2022) Log Message Versioning. WebKit-7614.1.14.3.4 Modified Paths branches/safari-7614.1.14.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.3-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.3-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.3-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.3-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.3-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294923 => 294924) --- branches/safari-7614.1.14.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-27 01:49:35 UTC (rev 294923) +++ branches/safari-7614.1.14.3-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-27 01:51:03 UTC (rev 294924) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294923 => 294924) --- branches/safari-7614.1.14.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-27 01:49:35 UTC (rev 294923) +++ branches/safari-7614.1.14.3-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-27 01:51:03 UTC (rev 294924) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294923 => 294924) --- branches/safari-7614.1.14.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-27 01:49:35 UTC (rev 294923) +++ branches/safari-7614.1.14.3-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-27 01:51:03 UTC (rev 294924) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.3-branch/Source/WebCore/Configurations/Version.xcconfig (294923 => 294924) --- branches/safari-7614.1.14.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-27 01:49:35 UTC (rev 294923) +++ branches/safari-7614.1.14.3-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-27 01:51:03 UTC (rev 294924) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294923 => 294924) --- branches/safari-7614.1.14.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-27 01:49:35 UTC (rev 294923) +++ branches/safari-7614.1.14.3-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-27 01:51:03 UTC (rev 294924) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 3; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.3-branch/Source/WebGPU/Configurations/Version.xcconfig (294923 => 294924) --- branches/safari-7614.1.14.3-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-27 01:49:35 UTC (rev 294923) +++ branches/safari-7614.1.14.3-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-27 01:51:03 UTC (rev 294924) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 3;
[webkit-changes] [294923] tags/WebKit-7614.1.14.2.5/
Title: [294923] tags/WebKit-7614.1.14.2.5/ Revision 294923 Author alanc...@apple.com Date 2022-05-26 18:49:35 -0700 (Thu, 26 May 2022) Log Message Tag WebKit-7614.1.14.2.5. Added Paths tags/WebKit-7614.1.14.2.5/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294922] branches/safari-7614.1.14.2-branch/Source
Title: [294922] branches/safari-7614.1.14.2-branch/Source Revision 294922 Author alanc...@apple.com Date 2022-05-26 18:48:48 -0700 (Thu, 26 May 2022) Log Message Versioning. WebKit-7614.1.14.2.5 Modified Paths branches/safari-7614.1.14.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.2-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.2-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.2-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.2-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.2-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294921 => 294922) --- branches/safari-7614.1.14.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-27 01:47:10 UTC (rev 294921) +++ branches/safari-7614.1.14.2-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-27 01:48:48 UTC (rev 294922) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294921 => 294922) --- branches/safari-7614.1.14.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-27 01:47:10 UTC (rev 294921) +++ branches/safari-7614.1.14.2-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-27 01:48:48 UTC (rev 294922) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294921 => 294922) --- branches/safari-7614.1.14.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-27 01:47:10 UTC (rev 294921) +++ branches/safari-7614.1.14.2-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-27 01:48:48 UTC (rev 294922) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.2-branch/Source/WebCore/Configurations/Version.xcconfig (294921 => 294922) --- branches/safari-7614.1.14.2-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-27 01:47:10 UTC (rev 294921) +++ branches/safari-7614.1.14.2-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-27 01:48:48 UTC (rev 294922) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294921 => 294922) --- branches/safari-7614.1.14.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-27 01:47:10 UTC (rev 294921) +++ branches/safari-7614.1.14.2-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-27 01:48:48 UTC (rev 294922) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 2; -NANO_VERSION = 4; +NANO_VERSION = 5; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.2-branch/Source/WebGPU/Configurations/Version.xcconfig (294921 => 294922) --- branches/safari-7614.1.14.2-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-27 01:47:10 UTC (rev 294921) +++ branches/safari-7614.1.14.2-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-27 01:48:48 UTC (rev 294922) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 2;
[webkit-changes] [294921] branches/safari-7614.1.14.2-branch
Title: [294921] branches/safari-7614.1.14.2-branch Revision 294921 Author alanc...@apple.com Date 2022-05-26 18:47:10 -0700 (Thu, 26 May 2022) Log Message Revert r294186. rdar://problem/93213436 This reverts r294697. Modified Paths branches/safari-7614.1.14.2-branch/LayoutTests/ChangeLog branches/safari-7614.1.14.2-branch/LayoutTests/platform/glib/TestExpectations branches/safari-7614.1.14.2-branch/LayoutTests/platform/ios/TestExpectations branches/safari-7614.1.14.2-branch/LayoutTests/platform/win/TestExpectations branches/safari-7614.1.14.2-branch/Source/WebCore/ChangeLog branches/safari-7614.1.14.2-branch/Source/WebCore/accessibility/AXObjectCache.cpp branches/safari-7614.1.14.2-branch/Source/WebCore/accessibility/AXObjectCache.h branches/safari-7614.1.14.2-branch/Source/WebCore/accessibility/AccessibilityObject.cpp Removed Paths branches/safari-7614.1.14.2-branch/LayoutTests/accessibility/aria-modal-with-text-crash-expected.txt branches/safari-7614.1.14.2-branch/LayoutTests/accessibility/aria-modal-with-text-crash.html Diff Modified: branches/safari-7614.1.14.2-branch/LayoutTests/ChangeLog (294920 => 294921) --- branches/safari-7614.1.14.2-branch/LayoutTests/ChangeLog 2022-05-27 01:40:53 UTC (rev 294920) +++ branches/safari-7614.1.14.2-branch/LayoutTests/ChangeLog 2022-05-27 01:47:10 UTC (rev 294921) @@ -1,67 +1,3 @@ -2022-05-23 Alan Coon - -Cherry-pick r294186. rdar://problem/93213436 - -Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence -https://bugs.webkit.org/show_bug.cgi?id=240365 - -Reviewed by Chris Fleizach. - -Source/WebCore: - -We can get infinite recursion when accessibilityIsIgnored is called as -part of computing AccessibilityObject::ignoredFromModalPresence. One -example of such a cycle: - -AXObjectCache::currentModalNode() -> -AccessibilityRenderObject::computeAccessibilityIsIgnored() -> -AccessibilityRenderObject::parentObjectUnignored() -> -AccessibilityObject::accessibilityIsIgnored() -> -AccessibilityObject::ignoredFromModalPresence() -> -AXObjectCache::currentModalNode() -> -...repeat... - -This patch fixes this by tracking when we start computing the current -modal node in the AXObjectCache. Then, in AccessibilityObject::accessibilityIsIgnored(), -we don't call AccessibilityObject::ignoredFromModalPresence() if this new state is true, -since in this context we only need to know if the object is inherently -ignored (i.e. ignored disregarding modal presence). - -Test: accessibility/aria-modal-with-text-crash.html - -* accessibility/AXObjectCache.cpp: -(WebCore::AXObjectCache::currentModalNode): -* accessibility/AXObjectCache.h: -Add m_isRetrievingCurrentModalNode. -(WebCore::AXObjectCache::isRetrievingCurrentModalNode): Added. -* accessibility/AccessibilityObject.cpp: -(WebCore::AccessibilityObject::accessibilityIsIgnored const): -Don't call ignoredFromModalPresence if we're in the midst of computing the current modal. - -LayoutTests: - -* accessibility/aria-modal-with-text-crash-expected.txt: Added. -* accessibility/aria-modal-with-text-crash.html: Added. -* platform/glib/TestExpectations: Skip new test. -* platform/ios/TestExpectations: Enable new test. -* platform/win/TestExpectations: Skip new test. - - -git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294186 268f45cc-cd09-0410-ab3c-d52691b4dbfc - -2022-05-13 Tyler Wilcock - -Infinite recursion caused by call to accessibilityIsIgnored in the midst of AccessibilityObject::ignoredFromModalPresence -https://bugs.webkit.org/show_bug.cgi?id=240365 - -Reviewed by Chris Fleizach. - -* accessibility/aria-modal-with-text-crash-expected.txt: Added. -* accessibility/aria-modal-with-text-crash.html: Added. -* platform/glib/TestExpectations: Skip new test. -* platform/ios/TestExpectations: Enable new test. -* platform/win/TestExpectations: Skip new test. - 2022-05-12 Russell Epstein Cherry-pick r293951. rdar://problem/92635604 Deleted: branches/safari-7614.1.14.2-branch/LayoutTests/accessibility/aria-modal-with-text-crash-expected.txt (294920 => 294921) --- branches/safari-7614.1.14.2-branch/LayoutTests/accessibility/aria-modal-with-text-crash-expected.txt 2022-05-27 01:40:53 UTC (rev 294920) +++ branches/safari-7614.1.14.2-branch/LayoutTests/accessibility/aria-modal-with-text-crash-expected.txt 2022-05-27 01:47:10 UTC (rev 294921) @@ -1,10 +0,0 @@ -This test ensures we don't crash when using search to traverse an aria-modal with text. - - -AXRole: AXStaticText -AXValue: Foo - -PASS successfullyParsed is true - -TEST COMPLETE -Foo Deleted:
[webkit-changes] [294920] trunk
Title: [294920] trunk
Revision 294920
Author lmo...@igalia.com
Date 2022-05-26 18:40:53 -0700 (Thu, 26 May 2022)
Log Message
[GTK] Deprecate WebKitSettings:enable-java
https://bugs.webkit.org/show_bug.cgi?id=239538
Reviewed by Adrian Perez de Castro and Michael Catanzaro.
250264@main removed the WKPreference entry regarding Java support, which in turn
was dropped long time ago.
* Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsSetProperty): Do not call deprecated function.
(webKitSettingsGetProperty): Ditto.
(webkit_settings_class_init): Ditto.
(webkit_settings_get_enable_java): Add deprecation warnings.
(webkit_settings_set_enable_java): Add deprecation warnings.
* Source/WebKit/UIProcess/API/gtk/WebKitSettings.h: Mark functions as
deprecated.
* Source/WebKit/UIProcess/API/wpe/WebKitSettings.h: Ditto.
* Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings): Update for new behavior and remove fatal warning
flag for enable-java block as the warnings are expected.
Canonical link: https://commits.webkit.org/251036@main
Modified Paths
trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h
trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp
Diff
Modified: trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp (294919 => 294920)
--- trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2022-05-27 00:58:34 UTC (rev 294919)
+++ trunk/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp 2022-05-27 01:40:53 UTC (rev 294920)
@@ -236,7 +236,6 @@
case PROP_ENABLE_PLUGINS:
break;
case PROP_ENABLE_JAVA:
-webkit_settings_set_enable_java(settings, g_value_get_boolean(value));
break;
case PROP_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY:
webkit_settings_set_javascript_can_open_windows_automatically(settings, g_value_get_boolean(value));
@@ -439,7 +438,7 @@
g_value_set_boolean(value, FALSE);
break;
case PROP_ENABLE_JAVA:
-g_value_set_boolean(value, webkit_settings_get_enable_java(settings));
+g_value_set_boolean(value, FALSE);
break;
case PROP_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY:
g_value_set_boolean(value, webkit_settings_get_javascript_can_open_windows_automatically(settings));
@@ -752,6 +751,8 @@
* WebKitSettings:enable-java:
*
* Determines whether or not Java is enabled on the page.
+ *
+ * Deprecated: 2.38
*/
sObjProperties[PROP_ENABLE_JAVA] =
g_param_spec_boolean(
@@ -758,7 +759,7 @@
"enable-java",
_("Enable Java"),
_("Whether Java support should be enabled."),
-TRUE,
+FALSE,
readWriteConstructParamFlags);
/**
@@ -1917,11 +1918,15 @@
* Get the #WebKitSettings:enable-java property.
*
* Returns: %FALSE always.
+ *
+ * Deprecated: 2.38. This function always returns %FALSE.
*/
gboolean webkit_settings_get_enable_java(WebKitSettings* settings)
{
g_return_val_if_fail(WEBKIT_IS_SETTINGS(settings), FALSE);
+g_warning("webkit_settings_get_enable_java is deprecated and always returns FALSE. Java is no longer supported.");
+
return FALSE;
}
@@ -1931,10 +1936,15 @@
* @enabled: Value to be set
*
* Set the #WebKitSettings:enable-java property. Deprecated function that does nothing.
+ *
+ * Deprecated: 2.38. This function does nothing.
*/
-void webkit_settings_set_enable_java(WebKitSettings* settings, gboolean)
+void webkit_settings_set_enable_java(WebKitSettings* settings, gboolean enabled)
{
g_return_if_fail(WEBKIT_IS_SETTINGS(settings));
+
+if (enabled)
+g_warning("webkit_settings_set_enable_java is deprecated and does nothing. Java is no longer supported.");
}
/**
Modified: trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h (294919 => 294920)
--- trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h 2022-05-27 00:58:34 UTC (rev 294919)
+++ trunk/Source/WebKit/UIProcess/API/gtk/WebKitSettings.h 2022-05-27 01:40:53 UTC (rev 294920)
@@ -156,10 +156,10 @@
webkit_settings_set_enable_plugins (WebKitSettings *settings,
gbooleanenabled);
-WEBKIT_API gboolean
+WEBKIT_DEPRECATED gboolean
webkit_settings_get_enable_java(WebKitSettings *settings);
-WEBKIT_API void
+WEBKIT_DEPRECATED void
webkit_settings_set_enable_java(WebKitSettings *settings,
gbooleanenabled);
Modified: trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h (294919 => 294920)
--- trunk/Source/WebKit/UIProcess/API/wpe/WebKitSettings.h 2022-05-27 00:58:34 UTC (rev 294919)
+++
[webkit-changes] [294919] tags/WebKit-7614.1.14.0.12/
Title: [294919] tags/WebKit-7614.1.14.0.12/ Revision 294919 Author alanc...@apple.com Date 2022-05-26 17:58:34 -0700 (Thu, 26 May 2022) Log Message Tag WebKit-7614.1.14.0.12. Added Paths tags/WebKit-7614.1.14.0.12/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294918] tags/WebKit-7614.1.14.1.13/
Title: [294918] tags/WebKit-7614.1.14.1.13/ Revision 294918 Author alanc...@apple.com Date 2022-05-26 17:57:42 -0700 (Thu, 26 May 2022) Log Message Tag WebKit-7614.1.14.1.13. Added Paths tags/WebKit-7614.1.14.1.13/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294917] trunk/Source/JavaScriptCore
Title: [294917] trunk/Source/_javascript_Core
Revision 294917
Author sbar...@apple.com
Date 2022-05-26 17:56:40 -0700 (Thu, 26 May 2022)
Log Message
Rename putDirect to putDirectOffset
https://bugs.webkit.org/show_bug.cgi?id=240992
Reviewed by Mark Lam.
* Source/_javascript_Core/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/_javascript_Core/ftl/FTLOperations.cpp:
(JSC::FTL::JSC_DEFINE_JIT_OPERATION):
* Source/_javascript_Core/runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::createEmpty):
* Source/_javascript_Core/runtime/CommonSlowPaths.cpp:
(JSC::JSC_DEFINE_COMMON_SLOW_PATH):
* Source/_javascript_Core/runtime/IteratorOperations.cpp:
(JSC::createIteratorResultObject):
* Source/_javascript_Core/runtime/JSONObject.cpp:
(JSC::Walker::walk):
* Source/_javascript_Core/runtime/JSObject.cpp:
(JSC::JSObject::setPrototypeDirect):
(JSC::JSObject::putDirectCustomGetterSetterWithoutTransition):
(JSC::JSObject::putDirectNonIndexAccessorWithoutTransition):
* Source/_javascript_Core/runtime/JSObject.h:
(JSC::JSObject::putDirectOffset):
(JSC::JSObject::putDirectWithoutBarrier):
(JSC::JSObject::putDirectUndefined): Deleted.
* Source/_javascript_Core/runtime/JSObjectInlines.h:
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectInternal):
* Source/_javascript_Core/runtime/ObjectConstructor.h:
(JSC::constructObjectFromPropertyDescriptor):
* Source/_javascript_Core/runtime/RegExpMatchesArray.h:
(JSC::createRegExpMatchesArray):
* Source/_javascript_Core/runtime/Structure.cpp:
(JSC::Structure::flattenDictionaryStructure):
Canonical link: https://commits.webkit.org/251035@main
Modified Paths
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/ftl/FTLOperations.cpp
trunk/Source/_javascript_Core/runtime/ClonedArguments.cpp
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp
trunk/Source/_javascript_Core/runtime/IteratorOperations.cpp
trunk/Source/_javascript_Core/runtime/JSONObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.cpp
trunk/Source/_javascript_Core/runtime/JSObject.h
trunk/Source/_javascript_Core/runtime/JSObjectInlines.h
trunk/Source/_javascript_Core/runtime/ObjectConstructor.h
trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h
trunk/Source/_javascript_Core/runtime/Structure.cpp
Diff
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (294916 => 294917)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2022-05-27 00:50:02 UTC (rev 294916)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2022-05-27 00:56:40 UTC (rev 294917)
@@ -417,7 +417,7 @@
if (structure->hasPolyProto()) {
JSObject* prototype = allocationProfile->prototype();
ASSERT(prototype == jsCast(constructor)->prototypeForConstruction(vm, globalObject));
-result->putDirect(vm, knownPolyProtoOffset, prototype);
+result->putDirectOffset(vm, knownPolyProtoOffset, prototype);
prototype->didBecomePrototype();
ASSERT_WITH_MESSAGE(!hasIndexedProperties(result->indexingType()), "We rely on JSFinalObject not starting out with an indexing type otherwise we would potentially need to convert to slow put storage");
}
Modified: trunk/Source/_javascript_Core/ftl/FTLOperations.cpp (294916 => 294917)
--- trunk/Source/_javascript_Core/ftl/FTLOperations.cpp 2022-05-27 00:50:02 UTC (rev 294916)
+++ trunk/Source/_javascript_Core/ftl/FTLOperations.cpp 2022-05-27 00:56:40 UTC (rev 294917)
@@ -88,7 +88,7 @@
if (codeBlock->identifier(property.location().info()).impl() != entry.key())
continue;
-object->putDirect(vm, entry.offset(), JSValue::decode(values[i]));
+object->putDirectOffset(vm, entry.offset(), JSValue::decode(values[i]));
}
}
break;
@@ -225,7 +225,7 @@
// We use a random-ish number instead of a sensible value like
// undefined to make possible bugs easier to track.
for (const PropertyTableEntry& entry : structure->getPropertiesConcurrently())
-result->putDirect(vm, entry.offset(), jsNumber(19723));
+result->putDirectOffset(vm, entry.offset(), jsNumber(19723));
return result;
}
Modified: trunk/Source/_javascript_Core/runtime/ClonedArguments.cpp (294916 => 294917)
--- trunk/Source/_javascript_Core/runtime/ClonedArguments.cpp 2022-05-27 00:50:02 UTC (rev 294916)
+++ trunk/Source/_javascript_Core/runtime/ClonedArguments.cpp 2022-05-27 00:56:40 UTC (rev 294917)
@@ -69,7 +69,7 @@
result->finishCreation(vm);
result->m_callee.set(vm, result, callee);
-result->putDirect(vm, clonedArgumentsLengthPropertyOffset, jsNumber(length));
+result->putDirectOffset(vm, clonedArgumentsLengthPropertyOffset, jsNumber(length));
return result;
}
Modified: trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp (294916 => 294917)
---
[webkit-changes] [294916] trunk
Title: [294916] trunk
Revision 294916
Author cdu...@apple.com
Date 2022-05-26 17:50:02 -0700 (Thu, 26 May 2022)
Log Message
Make StringView(const char*) private
https://bugs.webkit.org/show_bug.cgi?id=240942
Reviewed by Darin Adler.
Make StringView(const char*) private and update existing call sites
to use either StringView(ASCIILiteral) or StringView::fromLatin1(const char*).
* Source/WTF/wtf/text/StringView.h:
* Source/WebCore/platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::isColumnDeclaredAsBlob):
* Source/WebGPU/WGSL/Parser.cpp:
(WGSL::Parser::parseTypeDecl):
* Tools/TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::stringViewFromLiteral):
* Tools/TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
(TestWebKitAPI::TEST):
* Tools/TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
(TestWebKitAPI::TEST):
Canonical link: https://commits.webkit.org/251034@main
Modified Paths
trunk/Source/WTF/wtf/Threading.cpp
trunk/Source/WTF/wtf/linux/MemoryFootprintLinux.cpp
trunk/Source/WTF/wtf/text/StringView.h
trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp
trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp
trunk/Source/WebGPU/WGSL/Parser.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/StringParsingBuffer.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/StringView.cpp
trunk/Tools/TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp
trunk/Tools/TestWebKitAPI/Tests/WebCore/ISOBox.cpp
Diff
Modified: trunk/Source/WTF/wtf/Threading.cpp (294915 => 294916)
--- trunk/Source/WTF/wtf/Threading.cpp 2022-05-27 00:23:14 UTC (rev 294915)
+++ trunk/Source/WTF/wtf/Threading.cpp 2022-05-27 00:50:02 UTC (rev 294916)
@@ -166,7 +166,7 @@
// This name can be com.apple.WebKit.ProcessLauncher or com.apple.CoreIPC.ReceiveQueue.
// We are using those names for the thread name, but both are longer than the limit of
// the platform thread name length, 32 for Windows and 16 for Linux.
-StringView result(threadName);
+auto result = StringView::fromLatin1(threadName);
size_t size = result.reverseFind('.');
if (size != notFound)
result = result.substring(size + 1);
Modified: trunk/Source/WTF/wtf/linux/MemoryFootprintLinux.cpp (294915 => 294916)
--- trunk/Source/WTF/wtf/linux/MemoryFootprintLinux.cpp 2022-05-27 00:23:14 UTC (rev 294915)
+++ trunk/Source/WTF/wtf/linux/MemoryFootprintLinux.cpp 2022-05-27 00:50:02 UTC (rev 294916)
@@ -69,7 +69,7 @@
return;
}
if (scannedCount == 7) {
-StringView pathString(path);
+auto pathString = StringView::fromLatin1(path);
isAnonymous = pathString == "[heap]"_s || pathString.startsWith("[stack"_s);
return;
}
Modified: trunk/Source/WTF/wtf/text/StringView.h (294915 => 294916)
--- trunk/Source/WTF/wtf/text/StringView.h 2022-05-27 00:23:14 UTC (rev 294915)
+++ trunk/Source/WTF/wtf/text/StringView.h 2022-05-27 00:50:02 UTC (rev 294916)
@@ -69,9 +69,6 @@
StringView(const char*, unsigned length);
StringView(ASCIILiteral);
-// FIXME: Make private once all call sites have been ported to fromLatin1.
-explicit StringView(const char*);
-
ALWAYS_INLINE static StringView fromLatin1(const char* characters) { return StringView { characters }; }
static StringView empty();
@@ -191,6 +188,9 @@
struct UnderlyingString;
private:
+// Clients should use StringView(ASCIILiteral) or StringView::fromLatin1() instead.
+explicit StringView(const char*);
+
friend bool equal(StringView, StringView);
friend WTF_EXPORT_PRIVATE bool equalRespectingNullity(StringView, StringView);
Modified: trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp (294915 => 294916)
--- trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp 2022-05-27 00:23:14 UTC (rev 294915)
+++ trunk/Source/WebCore/platform/graphics/PlatformDisplay.cpp 2022-05-27 00:50:02 UTC (rev 294916)
@@ -271,7 +271,7 @@
{
const char* extensionsString = eglQueryString(m_eglDisplay, EGL_EXTENSIONS);
-auto displayExtensions = StringView { extensionsString }.split(' ');
+auto displayExtensions = StringView::fromLatin1(extensionsString).split(' ');
auto findExtension =
[&](auto extensionName) {
return std::any_of(displayExtensions.begin(), displayExtensions.end(),
Modified: trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp (294915 => 294916)
--- trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp 2022-05-27 00:23:14 UTC (rev 294915)
+++ trunk/Source/WebCore/platform/sql/SQLiteStatement.cpp 2022-05-27 00:50:02 UTC (rev 294916)
@@ -183,7 +183,7 @@
bool SQLiteStatement::isColumnDeclaredAsBlob(int col)
{
ASSERT(col >= 0);
-return equalLettersIgnoringASCIICase(StringView(sqlite3_column_decltype(m_statement, col)), "blob"_s);
+return
[webkit-changes] [294915] branches/safari-7614.1.14.11-branch/Source/WebKit/NetworkProcess/ mac/com.apple.WebKit.NetworkProcess.sb.in
Title: [294915] branches/safari-7614.1.14.11-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Revision 294915 Author alanc...@apple.com Date 2022-05-26 17:23:14 -0700 (Thu, 26 May 2022) Log Message Cherry-pick r294282. rdar://problem/93249176 [macOS] Fix mach syscall sandbox violation in the Network process https://bugs.webkit.org/show_bug.cgi?id=240466 Reviewed by Chris Dumez. Fix mach syscall sandbox violation in the Network process on macOS. * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: Canonical link: https://commits.webkit.org/250626@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294282 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.14.11-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in Diff Modified: branches/safari-7614.1.14.11-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in (294914 => 294915) --- branches/safari-7614.1.14.11-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2022-05-27 00:10:43 UTC (rev 294914) +++ branches/safari-7614.1.14.11-branch/Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in 2022-05-27 00:23:14 UTC (rev 294915) @@ -670,7 +670,11 @@ MSC_syscall_thread_switch MSC_task_dyld_process_info_notify_get MSC_task_self_trap -MSC_thread_get_special_reply_port)) +MSC_thread_get_special_reply_port +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 12 +MSC_thread_self_trap +#endif +)) (when (defined? 'MSC_mach_msg2_trap) (allow syscall-mach ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294914] branches/safari-7614.1.14.11-branch/Source
Title: [294914] branches/safari-7614.1.14.11-branch/Source Revision 294914 Author alanc...@apple.com Date 2022-05-26 17:10:43 -0700 (Thu, 26 May 2022) Log Message Versioning. WebKit-7614.1.14.11.4 Modified Paths branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.11-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.11-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.11-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294913 => 294914) --- branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-27 00:05:37 UTC (rev 294913) +++ branches/safari-7614.1.14.11-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-27 00:10:43 UTC (rev 294914) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 11; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294913 => 294914) --- branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-27 00:05:37 UTC (rev 294913) +++ branches/safari-7614.1.14.11-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-27 00:10:43 UTC (rev 294914) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 11; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294913 => 294914) --- branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-27 00:05:37 UTC (rev 294913) +++ branches/safari-7614.1.14.11-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-27 00:10:43 UTC (rev 294914) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 11; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig (294913 => 294914) --- branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-27 00:05:37 UTC (rev 294913) +++ branches/safari-7614.1.14.11-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-27 00:10:43 UTC (rev 294914) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 11; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294913 => 294914) --- branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-27 00:05:37 UTC (rev 294913) +++ branches/safari-7614.1.14.11-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-27 00:10:43 UTC (rev 294914) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 11; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig (294913 => 294914) --- branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-27 00:05:37 UTC (rev 294913) +++ branches/safari-7614.1.14.11-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-27 00:10:43 UTC (rev 294914) @@ -25,7 +25,7 @@ MINOR_VERSION = 1;
[webkit-changes] [294913] branches/safari-7614.1.15-branch
Title: [294913] branches/safari-7614.1.15-branch Revision 294913 Author alanc...@apple.com Date 2022-05-26 17:05:37 -0700 (Thu, 26 May 2022) Log Message Cherry-pick r294897. rdar://problem/93984643 Define WK_NOT_NO in SDKVariant.xcconfig https://bugs.webkit.org/show_bug.cgi?id=240963 rdar://problem/93984643 Reviewed by Alexey Proskuryakov. Provide a definition of `WK_NOT_NO = YES`, so that the `$(WK_NOT_$(SOME_BUILD_SETTING))` construction can be relied upon to produce a result of YES if the original build setting has a value of NO, which shouldn't be handled substantially different from an empty string. * PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig: * Source/_javascript_Core/Configurations/SDKVariant.xcconfig: * Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig: * Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig: * Source/WTF/Configurations/SDKVariant.xcconfig: * Source/WebCore/Configurations/SDKVariant.xcconfig: * Source/WebCore/PAL/Configurations/SDKVariant.xcconfig: * Source/WebGPU/Configurations/SDKVariant.xcconfig: * Source/WebInspectorUI/Configurations/SDKVariant.xcconfig: * Source/WebKit/Configurations/SDKVariant.xcconfig: * Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig: * Source/bmalloc/Configurations/SDKVariant.xcconfig: * Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig: * Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: * Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig: * Tools/MiniBrowser/Configurations/SDKVariant.xcconfig: * Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig: * Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig: * Tools/WebEditingTester/Configurations/SDKVariant.xcconfig: * Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig: * Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Canonical link: https://commits.webkit.org/251020@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294897 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-7614.1.15-branch/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/_javascript_Core/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/WTF/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/WebCore/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/WebCore/PAL/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/WebGPU/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/WebInspectorUI/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/WebKit/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Source/bmalloc/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/MiniBrowser/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/WebEditingTester/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig branches/safari-7614.1.15-branch/Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig Diff Modified: branches/safari-7614.1.15-branch/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig (294912 => 294913) --- branches/safari-7614.1.15-branch/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig 2022-05-27 00:01:47 UTC (rev 294912) +++ branches/safari-7614.1.15-branch/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig 2022-05-27 00:05:37 UTC (rev 294913) @@ -23,6 +23,7 @@ WK_EMPTY_ = YES; WK_NOT_ = YES; +WK_NOT_NO = YES; WK_NOT_YES = NO; WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM_NAME))); Modified: branches/safari-7614.1.15-branch/Source/_javascript_Core/Configurations/SDKVariant.xcconfig (294912 => 294913) ---
[webkit-changes] [294912] trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js
Title: [294912] trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js
Revision 294912
Author drou...@apple.com
Date 2022-05-26 17:01:47 -0700 (Thu, 26 May 2022)
Log Message
REGRESSION (250994@main): inspector/css/css-property.html is consistently failing
https://bugs.webkit.org/show_bug.cgi?id=240986
Reviewed by Patrick Angle.
* Source/WebInspectorUI/UserInterface/Models/CSSProperty.js:
(WI.CSSProperty.prototype._updateName.changeCount):
Don't adjust `WI.CSSProperty._cachedNameCounts` when updating `WI.objectStores.cssPropertyNameCounts`
as the latter will not work in LayoutTests (to avoid having to reset state between tests).
Canonical link: https://commits.webkit.org/251033@main
Modified Paths
trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js
Diff
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js (294911 => 294912)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js 2022-05-26 23:59:16 UTC (rev 294911)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js 2022-05-27 00:01:47 UTC (rev 294912)
@@ -557,22 +557,19 @@
if (!propertyName || this._implicit || this._anonymous || !this._enabled)
return;
-let oldCount = WI.CSSProperty._cachedNameCounts[propertyName];
+let cachedCount = WI.CSSProperty._cachedNameCounts[propertyName];
// Allow property counts to be updated if the property name has already been counted before.
// This can happen when inspecting a device that has different CSS properties enabled.
-if (isNaN(oldCount) && !WI.cssManager.propertyNameCompletions.isValidPropertyName(propertyName))
+if (isNaN(cachedCount) && !WI.cssManager.propertyNameCompletions.isValidPropertyName(propertyName))
return;
-console.assert(delta > 0 || oldCount >= delta, oldCount, delta);
-let newCount = Math.max(0, (oldCount || 0) + delta);
-WI.CSSProperty._cachedNameCounts[propertyName] = newCount;
+console.assert(delta > 0 || cachedCount >= delta, cachedCount, delta);
+WI.CSSProperty._cachedNameCounts[propertyName] = Math.max(0, (cachedCount || 0) + delta);
WI.objectStores.cssPropertyNameCounts.get(propertyName).then((storedCount) => {
console.assert(delta > 0 || storedCount >= delta, storedCount, delta);
-storedCount = Math.max(0, (storedCount || 0) + delta);
-WI.CSSProperty._cachedNameCounts[propertyName] = storedCount;
-WI.objectStores.cssPropertyNameCounts.put(storedCount, propertyName);
+WI.objectStores.cssPropertyNameCounts.put(Math.max(0, (storedCount || 0) + delta), propertyName);
});
if (propertyName !== this.canonicalName)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294910] tags/WebKit-7614.1.14.10.8/
Title: [294910] tags/WebKit-7614.1.14.10.8/ Revision 294910 Author alanc...@apple.com Date 2022-05-26 16:48:27 -0700 (Thu, 26 May 2022) Log Message Tag WebKit-7614.1.14.10.8. Added Paths tags/WebKit-7614.1.14.10.8/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294909] branches/safari-7614.1.14.10-branch/Source
Title: [294909] branches/safari-7614.1.14.10-branch/Source Revision 294909 Author alanc...@apple.com Date 2022-05-26 16:47:50 -0700 (Thu, 26 May 2022) Log Message Versioning. WebKit-7614.1.14.10.8 Modified Paths branches/safari-7614.1.14.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.10-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294908 => 294909) --- branches/safari-7614.1.14.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-26 23:41:44 UTC (rev 294908) +++ branches/safari-7614.1.14.10-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-26 23:47:50 UTC (rev 294909) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294908 => 294909) --- branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-26 23:41:44 UTC (rev 294908) +++ branches/safari-7614.1.14.10-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-26 23:47:50 UTC (rev 294909) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294908 => 294909) --- branches/safari-7614.1.14.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-26 23:41:44 UTC (rev 294908) +++ branches/safari-7614.1.14.10-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-26 23:47:50 UTC (rev 294909) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/WebCore/Configurations/Version.xcconfig (294908 => 294909) --- branches/safari-7614.1.14.10-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-26 23:41:44 UTC (rev 294908) +++ branches/safari-7614.1.14.10-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-26 23:47:50 UTC (rev 294909) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294908 => 294909) --- branches/safari-7614.1.14.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-26 23:41:44 UTC (rev 294908) +++ branches/safari-7614.1.14.10-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-26 23:47:50 UTC (rev 294909) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 10; -NANO_VERSION = 7; +NANO_VERSION = 8; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.10-branch/Source/WebGPU/Configurations/Version.xcconfig (294908 => 294909) --- branches/safari-7614.1.14.10-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-26 23:41:44 UTC (rev 294908) +++ branches/safari-7614.1.14.10-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-26 23:47:50 UTC (rev 294909) @@ -25,7 +25,7 @@ MINOR_VERSION = 1;
[webkit-changes] [294908] trunk/LayoutTests/platform
Title: [294908] trunk/LayoutTests/platform Revision 294908 Author nmouchta...@apple.com Date 2022-05-26 16:41:44 -0700 (Thu, 26 May 2022) Log Message Disable heic tests temporarily https://bugs.webkit.org/show_bug.cgi?id=240990 Unreviewed test expectation chnage. * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/251030@main Modified Paths trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/platform/ios/TestExpectations (294907 => 294908) --- trunk/LayoutTests/platform/ios/TestExpectations 2022-05-26 23:41:11 UTC (rev 294907) +++ trunk/LayoutTests/platform/ios/TestExpectations 2022-05-26 23:41:44 UTC (rev 294908) @@ -72,9 +72,9 @@ perf/accessibility-title-ui-element.html # webkit.org/b/240843 -fast/images/heic-as-background-image.html [ Pass ] -fast/images/animated-heics-verify.html [ Pass ] -fast/images/animated-heics-draw.html [ Pass ] +fast/images/heic-as-background-image.html [ Skip ] +fast/images/animated-heics-verify.html [ Skip ] +fast/images/animated-heics-draw.html [ Skip ] # No fullscreen API on iOS fullscreen Modified: trunk/LayoutTests/platform/mac/TestExpectations (294907 => 294908) --- trunk/LayoutTests/platform/mac/TestExpectations 2022-05-26 23:41:11 UTC (rev 294907) +++ trunk/LayoutTests/platform/mac/TestExpectations 2022-05-26 23:41:44 UTC (rev 294908) @@ -90,9 +90,9 @@ #// # webkit.org/b/240843 -fast/images/animated-heics-draw.html [ Pass ] -fast/images/animated-heics-verify.html [ Pass ] -fast/images/heic-as-background-image.html [ Pass ] +fast/images/animated-heics-draw.html [ Skip ] +fast/images/animated-heics-verify.html [ Skip ] +fast/images/heic-as-background-image.html [ Skip ] # fast/events/mouseout-on-window.html needs mac DRT to issue mouse out events fast/events/mouseout-on-window.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294907] trunk/LayoutTests/inspector/debugger/breakpoints
Title: [294907] trunk/LayoutTests/inspector/debugger/breakpoints
Revision 294907
Author pan...@apple.com
Date 2022-05-26 16:41:11 -0700 (Thu, 26 May 2022)
Log Message
Web Inspector: `inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html` is a flakey failure
https://bugs.webkit.org/show_bug.cgi?id=239134
rdar://91639437
Reviewed by Devin Rousso.
This test was flaky because the only piece of code in the test keeping the SourceProvider alive for `dump-multiline.js`
was the `function test()`, which is replaced by the `function test()` in the test page itself. This meant that the
function from dump-multiline.js would be garbage collected at some point, and since it was the last possible way to
reach source code in `dump-multiline.js`, the SourceProvider was also disposed of at the same time.
Normally this would not be an issue for users because the source code itself is still viewable in Web Inspector, and
breakpoints can still be set (and will be triggered after a reload). The issue here is that when we attach Web Inspector
the source code is longer reachable, so the backend doesn't send information for it to the frontend for it (until a page
reload), but this test is assuming the script will have been sent from the backend to associate with the resource.
* LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt:
* LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js:
Canonical link: https://commits.webkit.org/251030@main
Modified Paths
trunk/LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt
trunk/LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js
Diff
Modified: trunk/LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt (294906 => 294907)
--- trunk/LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt 2022-05-26 23:13:12 UTC (rev 294906)
+++ trunk/LayoutTests/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt 2022-05-26 23:41:11 UTC (rev 294907)
@@ -2818,7 +2818,7 @@
INSERTING AT: 0:0
PAUSES AT: 1:4
- -> 0#function test() {
+ -> 0#function multilineTest() {
=> 1|var x;
2}
3
@@ -2826,7 +2826,7 @@
INSERTING AT: 1:5
PAUSES AT: 2:0
- 0function test() {
+ 0function multilineTest() {
-> 1v#ar x;
=> 2|}
3
@@ -2835,13 +2835,13 @@
INSERTING AT: 2:1
PAUSES AT: 5:0
- 0function test() {
+ 0function multilineTest() {
1var x;
-> 2}#
3
4// Strings
=> 5|let multiline1 = "test\
- 6string", multiline2 = test();
+ 6string", multiline2 = multilineTest();
7
8// Template Strings
@@ -2851,7 +2851,7 @@
3
4// Strings
-> 5l#et multiline1 = "test\
- => 6string", |multiline2 = test();
+ => 6string", |multiline2 = multilineTest();
7
8// Template Strings
9let multiline3 = `test
@@ -2861,21 +2861,21 @@
3
4// Strings
5let multiline1 = "test\
- -> 6string", m#ultiline2 = test();
+ -> 6string", m#ultiline2 = multilineTest();
7
8// Template Strings
=> 9|let multiline3 = `test
- 10string`, multiline4 = test();
+ 10string`, multiline4 = multilineTest();
11
12// Comments
INSERTING AT: 9:1
PAUSES AT: 10:9
- 6string", multiline2 = test();
+ 6string", multiline2 = multilineTest();
7
8// Template Strings
-> 9l#et multiline3 = `test
- => 10string`, |multiline4 = test();
+ => 10string`, |multiline4 = multilineTest();
11
12// Comments
13/* test
@@ -2885,11 +2885,11 @@
7
8// Template Strings
9let multiline3 = `test
- -> 10string`, m#ultiline4 = test();
+ -> 10string`, m#ultiline4 = multilineTest();
11
12// Comments
13/* test
- => 14comment */ |let multiline5 = test();
+ => 14comment */ |let multiline5 = multilineTest();
15
Modified: trunk/LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js (294906 => 294907)
--- trunk/LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js 2022-05-26 23:13:12 UTC (rev 294906)
+++ trunk/LayoutTests/inspector/debugger/breakpoints/resources/dump-multiline.js 2022-05-26 23:41:11 UTC (rev 294907)
@@ -1,15 +1,15 @@
-function test() {
+function multilineTest() {
var x;
}
// Strings
let multiline1 = "test\
-string", multiline2 = test();
+string", multiline2 = multilineTest();
// Template Strings
let multiline3 = `test
-string`, multiline4 = test();
+string`, multiline4 = multilineTest();
// Comments
/* test
-comment */ let multiline5 = test();
+comment */ let multiline5 = multilineTest();
[webkit-changes] [294906] trunk/Source/cmake/OptionsPlayStation.cmake
Title: [294906] trunk/Source/cmake/OptionsPlayStation.cmake
Revision 294906
Author don.olmst...@sony.com
Date 2022-05-26 16:13:12 -0700 (Thu, 26 May 2022)
Log Message
[CMake][PlayStation] Base find_package checks on whether WebCore is being built
https://bugs.webkit.org/show_bug.cgi?id=240974
Reviewed by Ross Kirsling.
Move any `find_package` for WebCore libraries under a check for
`ENABLE_WEBCORE`. Shift the `find_package` checks to the top of the
file. This will allow us to base `ENABLE` flags on whether or not a
package is found. Fix a couple style issues while there.
* Source/cmake/OptionsPlayStation.cmake:
Canonical link: https://commits.webkit.org/251029@main
Modified Paths
trunk/Source/cmake/OptionsPlayStation.cmake
Diff
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (294905 => 294906)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2022-05-26 22:51:13 UTC (rev 294905)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2022-05-26 23:13:12 UTC (rev 294906)
@@ -19,6 +19,67 @@
set(ENABLE_WEBKIT_LEGACY OFF)
set(ENABLE_WEBINSPECTORUI OFF)
+# Specify third party library directory
+if (NOT WEBKIT_LIBRARIES_DIR)
+if (DEFINED ENV{WEBKIT_LIBRARIES})
+set(WEBKIT_LIBRARIES_DIR "$ENV{WEBKIT_LIBRARIES}" CACHE PATH "Path to PlayStationRequirements")
+else ()
+set(WEBKIT_LIBRARIES_DIR "${CMAKE_SOURCE_DIR}/WebKitLibraries/playstation" CACHE PATH "Path to PlayStationRequirements")
+endif ()
+endif ()
+
+if (DEFINED ENV{WEBKIT_IGNORE_PATH})
+set(CMAKE_IGNORE_PATH $ENV{WEBKIT_IGNORE_PATH})
+endif ()
+
+list(APPEND CMAKE_PREFIX_PATH ${WEBKIT_LIBRARIES_DIR})
+
+# Find libraries
+find_library(C_STD_LIBRARY c)
+find_library(KERNEL_LIBRARY kernel)
+find_package(ICU 61.2 REQUIRED COMPONENTS data i18n uc)
+
+set(USE_WPE_BACKEND_PLAYSTATION OFF)
+
+if (ENABLE_WEBCORE)
+set(WebKitRequirements_COMPONENTS
+JPEG
+LibPSL
+LibXml2
+ProcessLauncher
+SQLite3
+ZLIB
+)
+
+find_package(WPEBackendPlayStation)
+if (WPEBackendPlayStation_FOUND)
+# WPE::libwpe is compiled into the PlayStation backend
+set(WPE_NAMES SceWPE)
+find_package(WPE REQUIRED)
+
+SET_AND_EXPOSE_TO_BUILD(USE_WPE_BACKEND_PLAYSTATION ON)
+else ()
+list(APPEND WebKitRequirements_COMPONENTS libwpe)
+endif ()
+
+find_package(WebKitRequirements REQUIRED COMPONENTS ${WebKitRequirements_COMPONENTS})
+
+# The OpenGL ES implementation is in the same library as the EGL implementation
+set(OpenGLES2_NAMES ${EGL_NAMES})
+
+find_package(CURL 7.77.0 REQUIRED)
+find_package(Cairo REQUIRED)
+find_package(EGL REQUIRED)
+find_package(Fontconfig REQUIRED)
+find_package(Freetype REQUIRED)
+find_package(HarfBuzz REQUIRED COMPONENTS ICU)
+find_package(OpenGLES2 REQUIRED)
+find_package(OpenSSL REQUIRED)
+find_package(PNG REQUIRED)
+find_package(Threads REQUIRED)
+find_package(WebP REQUIRED COMPONENTS demux)
+endif ()
+
WEBKIT_OPTION_BEGIN()
# Developer mode options
@@ -93,10 +154,6 @@
WEBKIT_OPTION_END()
-if (DEFINED ENV{WEBKIT_IGNORE_PATH})
-set(CMAKE_IGNORE_PATH $ENV{WEBKIT_IGNORE_PATH})
-endif ()
-
# Do not use a separate directory based on configuration when building
# with the Visual Studio generator
set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY_DEBUG "${CMAKE_ARCHIVE_OUTPUT_DIRECTORY}")
@@ -110,66 +167,16 @@
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(CMAKE_VISIBILITY_INLINES_HIDDEN ON)
-# Specify third party library directory
-if (NOT WEBKIT_LIBRARIES_DIR)
-if (DEFINED ENV{WEBKIT_LIBRARIES})
-set(WEBKIT_LIBRARIES_DIR "$ENV{WEBKIT_LIBRARIES}" CACHE PATH "Path to PlayStationRequirements")
-else ()
-set(WEBKIT_LIBRARIES_DIR "${CMAKE_SOURCE_DIR}/WebKitLibraries/playstation" CACHE PATH "Path to PlayStationRequirements")
-endif ()
-endif ()
-
-list(APPEND CMAKE_PREFIX_PATH ${WEBKIT_LIBRARIES_DIR})
-
-set(WebKitRequirements_COMPONENTS
-JPEG
-LibPSL
-LibXml2
-ProcessLauncher
-SQLite3
-ZLIB
-)
-
-find_package(WPEBackendPlayStation)
-if (WPEBackendPlayStation_FOUND)
-# WPE::libwpe is compiled into the PlayStation backend
-set(WPE_NAMES SceWPE)
-find_package(WPE REQUIRED)
-
-SET_AND_EXPOSE_TO_BUILD(USE_WPE_BACKEND_PLAYSTATION ON)
-else ()
-list(APPEND WebKitRequirements_COMPONENTS libwpe)
-endif ()
-
-find_library(C_STD_LIBRARY c)
-find_library(KERNEL_LIBRARY kernel)
-find_package(WebKitRequirements REQUIRED COMPONENTS ${WebKitRequirements_COMPONENTS})
-
-# The OpenGL ES implementation is in the same library as the EGL implementation
-set(OpenGLES2_NAMES ${EGL_NAMES})
-
-find_package(Cairo REQUIRED)
-find_package(CURL 7.77.0 REQUIRED)
-find_package(EGL REQUIRED)
-find_package(Fontconfig REQUIRED)
-find_package(Freetype REQUIRED)
-find_package(HarfBuzz REQUIRED COMPONENTS ICU)
-find_package(ICU 61.2 REQUIRED COMPONENTS data i18n uc)
-find_package(OpenGLES2 REQUIRED)
-find_package(OpenSSL
[webkit-changes] [294905] trunk/Source/JavaScriptCore/runtime/JSCellInlines.h
Title: [294905] trunk/Source/_javascript_Core/runtime/JSCellInlines.h
Revision 294905
Author mark@apple.com
Date 2022-05-26 15:51:13 -0700 (Thu, 26 May 2022)
Log Message
Re-factoring clean up in allocateCell and tryAllocateCell.
https://bugs.webkit.org/show_bug.cgi?id=240973
Reviewed by Saam Barati.
The AllocationFailureMode should be a template parameter to tryAllocateCellHelper because it's
constant. Also, tryAllocateCellHelper should take a VM& instead of taking a Heap& and then
converting it back to a VM&.
* Source/_javascript_Core/runtime/JSCellInlines.h:
(JSC::tryAllocateCellHelper):
(JSC::allocateCell):
(JSC::tryAllocateCell):
Canonical link: https://commits.webkit.org/251028@main
Modified Paths
trunk/Source/_javascript_Core/runtime/JSCellInlines.h
Diff
Modified: trunk/Source/_javascript_Core/runtime/JSCellInlines.h (294904 => 294905)
--- trunk/Source/_javascript_Core/runtime/JSCellInlines.h 2022-05-26 22:39:00 UTC (rev 294904)
+++ trunk/Source/_javascript_Core/runtime/JSCellInlines.h 2022-05-26 22:51:13 UTC (rev 294905)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012-2021 Apple Inc. All rights reserved.
+ * Copyright (C) 2012-2022 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -167,15 +167,16 @@
return { };
}
-template
-ALWAYS_INLINE void* tryAllocateCellHelper(Heap& heap, size_t size, GCDeferralContext* deferralContext, AllocationFailureMode failureMode)
+template
+ALWAYS_INLINE void* tryAllocateCellHelper(VM& vm, size_t size, GCDeferralContext* deferralContext)
{
-VM& vm = heap.vm();
-ASSERT(deferralContext || heap.isDeferred() || !DisallowGC::isInEffectOnCurrentThread());
+ASSERT(deferralContext || vm.heap.isDeferred() || !DisallowGC::isInEffectOnCurrentThread());
ASSERT(size >= sizeof(T));
JSCell* result = static_cast(subspaceFor(vm)->allocate(vm, size, deferralContext, failureMode));
-if (failureMode == AllocationFailureMode::ReturnNull && !result)
-return nullptr;
+if constexpr (failureMode == AllocationFailureMode::ReturnNull) {
+if (!result)
+return nullptr;
+}
#if ENABLE(GC_VALIDATION)
ASSERT(!vm.isInitializingObject());
vm.setInitializingObjectClass(T::info());
@@ -187,25 +188,25 @@
template
void* allocateCell(VM& vm, size_t size)
{
-return tryAllocateCellHelper(vm.heap, size, nullptr, AllocationFailureMode::Assert);
+return tryAllocateCellHelper(vm, size, nullptr);
}
template
void* tryAllocateCell(VM& vm, size_t size)
{
-return tryAllocateCellHelper(vm.heap, size, nullptr, AllocationFailureMode::ReturnNull);
+return tryAllocateCellHelper(vm, size, nullptr);
}
template
void* allocateCell(VM& vm, GCDeferralContext* deferralContext, size_t size)
{
-return tryAllocateCellHelper(vm.heap, size, deferralContext, AllocationFailureMode::Assert);
+return tryAllocateCellHelper(vm, size, deferralContext);
}
template
void* tryAllocateCell(VM& vm, GCDeferralContext* deferralContext, size_t size)
{
-return tryAllocateCellHelper(vm.heap, size, deferralContext, AllocationFailureMode::ReturnNull);
+return tryAllocateCellHelper(vm, size, deferralContext);
}
inline bool JSCell::isObject() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294903] trunk/Source/WebKit/Resources/SandboxProfiles/ios/ com.apple.WebKit.WebContent.sb.in
Title: [294903] trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Revision 294903 Author pvol...@apple.com Date 2022-05-26 15:34:25 -0700 (Thu, 26 May 2022) Log Message [iOS][WP] Block access to file-ioctl commands https://bugs.webkit.org/show_bug.cgi?id=240977 Reviewed by Chris Dumez. This is based on collected telemetry. This patch also adds telemetry to file read/write of /dev/aes_0 to determine if that can be removed as well. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Canonical link: https://commits.webkit.org/251026@main Modified Paths trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Diff Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in (294902 => 294903) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-05-26 22:22:08 UTC (rev 294902) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in 2022-05-26 22:34:25 UTC (rev 294903) @@ -315,7 +315,7 @@ (literal "/dev/random") (literal "/dev/urandom")) -(allow file-read* file-write-data +(allow file-read* file-write-data (with telemetry) (literal "/dev/aes_0"))) (define required-etc-files @@ -1239,14 +1239,8 @@ (deny file-ioctl (with telemetry)) -;; restrict to the two ioctl's /dev/aes_0 needs -(allow file-ioctl (with telemetry) -(require-all -(literal "/dev/aes_0") -(require-any -(ioctl-command (_IO "T" 101)) ;; IOAES_GET_INFO -(ioctl-command (_IO "T" 102)) ;; IOAES_ENCRYPT_DECRYPT -))) +(deny file-ioctl (with telemetry) +(literal "/dev/aes_0")) (deny socket-ioctl (with telemetry)) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294902] trunk/Source/WebCore/rendering
Title: [294902] trunk/Source/WebCore/rendering
Revision 294902
Author za...@apple.com
Date 2022-05-26 15:22:08 -0700 (Thu, 26 May 2022)
Log Message
Do not issue repaint when the ancestor layer has already been scheduled for one
https://bugs.webkit.org/show_bug.cgi?id=240728
Reviewed by Simon Fraser.
When a renderer needs repaint, we walk the layer tree to search for the repaint container (root for all the paints).
If we find a layer between the renderer and the repaint container that has already been scheduled for a full repaint
we know that this repaint is redundant and will be covered by the ancestor layer.
Since layers paint their overflow content, this works even when the renderer "sticks out" of the ancestor layer's renderer's border box (i.e. produces ink/scrollable overflow).
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint const):
(WebCore::RenderLayer::clipCrossesPaintingBoundary const):
(WebCore::RenderLayer::calculateClipRects const):
* Source/WebCore/rendering/RenderLayer.h:
(WebCore::RenderLayer::needsFullRepaint const):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::containerForRepaint const):
(WebCore::fullRepaintIsScheduled): This covers the cases when the content is embedded inside an iframe and the iframe's view is not composited.
(WebCore::RenderObject::repaint const):
(WebCore::RenderObject::repaintRectangle const):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
Canonical link: https://commits.webkit.org/251025@main
Modified Paths
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderView.cpp
Diff
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (294901 => 294902)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2022-05-26 22:15:24 UTC (rev 294901)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2022-05-26 22:22:08 UTC (rev 294902)
@@ -2024,7 +2024,7 @@
return nullptr;
}
-RenderLayer* RenderLayer::enclosingCompositingLayerForRepaint(IncludeSelfOrNot includeSelf) const
+RenderLayer::EnclosingCompositingLayerStatus RenderLayer::enclosingCompositingLayerForRepaint(IncludeSelfOrNot includeSelf) const
{
auto repaintTargetForLayer = [](const RenderLayer& layer) -> RenderLayer* {
if (compositedWithOwnBackingStore(layer))
@@ -2035,17 +2035,22 @@
return nullptr;
};
+auto isEligibleForFullRepaintCheck = [&](const auto& layer) {
+return layer.isSelfPaintingLayer() && !layer.renderer().hasPotentiallyScrollableOverflow() && !is(layer.renderer());
+};
+auto fullRepaintAlreadyScheduled = isEligibleForFullRepaintCheck(*this) && needsFullRepaint();
RenderLayer* repaintTarget = nullptr;
if (includeSelf == IncludeSelf && (repaintTarget = repaintTargetForLayer(*this)))
-return repaintTarget;
+return { fullRepaintAlreadyScheduled, repaintTarget };
for (const RenderLayer* curr = paintOrderParent(); curr; curr = curr->paintOrderParent()) {
+fullRepaintAlreadyScheduled = fullRepaintAlreadyScheduled || (isEligibleForFullRepaintCheck(*curr) && curr->needsFullRepaint());
if ((repaintTarget = repaintTargetForLayer(*curr)))
-return repaintTarget;
+return { fullRepaintAlreadyScheduled, repaintTarget };
}
-return nullptr;
+return { };
}
RenderLayer* RenderLayer::enclosingFilterLayer(IncludeSelfOrNot includeSelf) const
@@ -4612,7 +4617,7 @@
bool RenderLayer::clipCrossesPaintingBoundary() const
{
return parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers)
-|| parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();
+|| parent()->enclosingCompositingLayerForRepaint().layer != enclosingCompositingLayerForRepaint().layer;
}
void RenderLayer::calculateClipRects(const ClipRectsContext& clipRectsContext, ClipRects& clipRects) const
@@ -5811,7 +5816,7 @@
bool RenderLayer::invalidateEventRegion(EventRegionInvalidationReason reason)
{
#if ENABLE(ASYNC_SCROLLING)
-auto* compositingLayer = enclosingCompositingLayerForRepaint();
+auto* compositingLayer = enclosingCompositingLayerForRepaint().layer;
auto shouldInvalidate = [&] {
if (!compositingLayer)
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (294901 => 294902)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2022-05-26 22:15:24 UTC (rev 294901)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2022-05-26 22:22:08 UTC (rev 294902)
@@ -590,7 +590,11 @@
// Enclosing compositing layer; if
[webkit-changes] [294901] trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
Title: [294901] trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp Revision 294901 Author commit-qu...@webkit.org Date 2022-05-26 15:15:24 -0700 (Thu, 26 May 2022) Log Message AX: -Wswitch warnings in AXObjectCacheAtspi.cpp https://bugs.webkit.org/show_bug.cgi?id=240956 Patch by Michael Catanzaro on 2022-05-26 Reviewed by Adrian Perez de Castro. * Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp: (WebCore::AXObjectCache::postPlatformNotification): Canonical link: https://commits.webkit.org/251024@main Modified Paths trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp Diff Modified: trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp (294900 => 294901) --- trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp 2022-05-26 21:56:01 UTC (rev 294900) +++ trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp 2022-05-26 22:15:24 UTC (rev 294901) @@ -195,6 +195,10 @@ break; case AXDraggingExitedDropZone: break; +case AXGrabbedStateChanged: +break; +case AXPositionInSetChanged: +break; } } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294899] trunk/Source/WebKit/Resources/SandboxProfiles/ios/ com.apple.WebKit.GPU.sb.in
Title: [294899] trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Revision 294899 Author pvol...@apple.com Date 2022-05-26 14:31:26 -0700 (Thu, 26 May 2022) Log Message [iOS][GPUP] Block unused system calls https://bugs.webkit.org/show_bug.cgi?id=240960 Reviewed by Chris Dumez. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/251022@main Modified Paths trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Diff Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in (294898 => 294899) --- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in 2022-05-26 21:29:42 UTC (rev 294898) +++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in 2022-05-26 21:31:26 UTC (rev 294899) @@ -714,12 +714,14 @@ ) (when (defined? 'syscall-unix) -(allow syscall-unix (with telemetry)) +(deny syscall-unix (with telemetry)) (allow syscall-unix (syscall-number SYS___disable_threadsignal SYS___mac_syscall SYS___pthread_sigmask +SYS___pthread_kill SYS___semwait_signal +SYS_abort_with_payload SYS_access SYS_bsdthread_create SYS_bsdthread_ctl @@ -804,6 +806,7 @@ SYS_shared_region_check_np SYS_shm_open SYS_sigaction +SYS_sigprocmask SYS_socket SYS_stat64 SYS_statfs64 @@ -822,7 +825,7 @@ (allow syscall-unix (syscall-number SYS_map_with_linking_np))) (when (defined? 'syscall-mach) -(allow syscall-mach (with telemetry)) +(deny syscall-mach (with telemetry)) (allow syscall-mach (machtrap-number MSC__kernelrpc_mach_port_allocate_trap ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294898] trunk/Source/WebKit/GPUProcess/mac/ com.apple.WebKit.GPUProcess.sb.in
Title: [294898] trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in Revision 294898 Author pvol...@apple.com Date 2022-05-26 14:29:42 -0700 (Thu, 26 May 2022) Log Message [macOS][GPUP] Block unused system calls https://bugs.webkit.org/show_bug.cgi?id=240966 Reviewed by Chris Dumez. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: Canonical link: https://commits.webkit.org/251021@main Modified Paths trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in Diff Modified: trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in (294897 => 294898) --- trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2022-05-26 21:12:24 UTC (rev 294897) +++ trunk/Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in 2022-05-26 21:29:42 UTC (rev 294898) @@ -904,7 +904,7 @@ (allow mach-message-send (with telemetry) (when (and (equal? (param "ENABLE_SANDBOX_MESSAGE_FILTER") "YES") (defined? 'syscall-mach)) -(allow syscall-mach (with telemetry)) +(deny syscall-mach (with telemetry)) (allow syscall-mach (machtrap-number MSC__kernelrpc_mach_port_allocate_trap MSC__kernelrpc_mach_port_construct_trap @@ -911,6 +911,7 @@ MSC__kernelrpc_mach_port_deallocate_trap MSC__kernelrpc_mach_port_destruct_trap MSC__kernelrpc_mach_port_extract_member_trap +MSC__kernelrpc_mach_port_get_attributes_trap MSC__kernelrpc_mach_port_guard_trap MSC__kernelrpc_mach_port_insert_member_trap MSC__kernelrpc_mach_port_insert_right_trap @@ -917,29 +918,42 @@ MSC__kernelrpc_mach_port_mod_refs_trap MSC__kernelrpc_mach_port_request_notification_trap MSC__kernelrpc_mach_port_type_trap +MSC__kernelrpc_mach_port_unguard_trap MSC__kernelrpc_mach_vm_allocate_trap MSC__kernelrpc_mach_vm_deallocate_trap MSC__kernelrpc_mach_vm_map_trap MSC__kernelrpc_mach_vm_protect_trap +MSC__kernelrpc_mach_vm_purgable_control_trap MSC_host_create_mach_voucher_trap MSC_host_self_trap +MSC_iokit_user_client_trap +MSC_mach_generate_activity_id MSC_mach_msg_trap +MSC_mach_msg2_trap MSC_mach_reply_port MSC_mach_voucher_extract_attr_recipe_trap +MSC_mk_timer_arm +MSC_mk_timer_cancel +MSC_mk_timer_create +MSC_mk_timer_destroy MSC_pid_for_task MSC_semaphore_signal_trap +MSC_semaphore_timedwait_trap MSC_semaphore_wait_trap MSC_swtch_pri MSC_syscall_thread_switch +MSC_task_name_for_pid +MSC_task_self_trap MSC_thread_get_special_reply_port))) #endif // HAVE(SANDBOX_MESSAGE_FILTERING) (when (defined? 'syscall-unix) -(allow syscall-unix (with telemetry)) +(deny syscall-unix (with telemetry)) (allow syscall-unix (syscall-number SYS___channel_open SYS___disable_threadsignal SYS___mac_syscall +SYS___pthread_canceled SYS___pthread_kill SYS___pthread_sigmask SYS___semwait_signal @@ -981,6 +995,7 @@ SYS_gettimeofday SYS_getuid SYS_getxattr +SYS_guarded_open_np SYS_issetugid SYS_kdebug_trace SYS_kdebug_trace64 @@ -1024,6 +1039,8 @@ SYS_readlink SYS_rename SYS_sendto +SYS_setrlimit +SYS_setsockopt SYS_sigaltstack SYS_sigprocmask SYS_socket ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294897] trunk
Title: [294897] trunk Revision 294897 Author david_ques...@apple.com Date 2022-05-26 14:12:24 -0700 (Thu, 26 May 2022) Log Message Define WK_NOT_NO in SDKVariant.xcconfig https://bugs.webkit.org/show_bug.cgi?id=240963 rdar://problem/93984643 Reviewed by Alexey Proskuryakov. Provide a definition of `WK_NOT_NO = YES`, so that the `$(WK_NOT_$(SOME_BUILD_SETTING))` construction can be relied upon to produce a result of YES if the original build setting has a value of NO, which shouldn't be handled substantially different from an empty string. * PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig: * Source/_javascript_Core/Configurations/SDKVariant.xcconfig: * Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig: * Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig: * Source/WTF/Configurations/SDKVariant.xcconfig: * Source/WebCore/Configurations/SDKVariant.xcconfig: * Source/WebCore/PAL/Configurations/SDKVariant.xcconfig: * Source/WebGPU/Configurations/SDKVariant.xcconfig: * Source/WebInspectorUI/Configurations/SDKVariant.xcconfig: * Source/WebKit/Configurations/SDKVariant.xcconfig: * Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig: * Source/bmalloc/Configurations/SDKVariant.xcconfig: * Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig: * Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: * Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig: * Tools/MiniBrowser/Configurations/SDKVariant.xcconfig: * Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig: * Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig: * Tools/WebEditingTester/Configurations/SDKVariant.xcconfig: * Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig: * Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Canonical link: https://commits.webkit.org/251020@main Modified Paths trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig trunk/Source/_javascript_Core/Configurations/SDKVariant.xcconfig trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig trunk/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig trunk/Source/ThirdParty/libwebrtc/Configurations/SDKVariant.xcconfig trunk/Source/WTF/Configurations/SDKVariant.xcconfig trunk/Source/WebCore/Configurations/SDKVariant.xcconfig trunk/Source/WebCore/PAL/Configurations/SDKVariant.xcconfig trunk/Source/WebGPU/Configurations/SDKVariant.xcconfig trunk/Source/WebInspectorUI/Configurations/SDKVariant.xcconfig trunk/Source/WebKit/Configurations/SDKVariant.xcconfig trunk/Source/WebKitLegacy/mac/Configurations/SDKVariant.xcconfig trunk/Source/bmalloc/Configurations/SDKVariant.xcconfig trunk/Tools/ContentExtensionTester/Configurations/SDKVariant.xcconfig trunk/Tools/DumpRenderTree/mac/Configurations/SDKVariant.xcconfig trunk/Tools/ImageDiff/cg/Configurations/SDKVariant.xcconfig trunk/Tools/MiniBrowser/Configurations/SDKVariant.xcconfig trunk/Tools/MobileMiniBrowser/Configurations/SDKVariant.xcconfig trunk/Tools/TestWebKitAPI/Configurations/SDKVariant.xcconfig trunk/Tools/WebEditingTester/Configurations/SDKVariant.xcconfig trunk/Tools/WebKitTestRunner/Configurations/SDKVariant.xcconfig trunk/Tools/lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig Diff Modified: trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig (294896 => 294897) --- trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig 2022-05-26 21:07:42 UTC (rev 294896) +++ trunk/PerformanceTests/MediaTime/Configurations/SDKVariant.xcconfig 2022-05-26 21:12:24 UTC (rev 294897) @@ -23,6 +23,7 @@ WK_EMPTY_ = YES; WK_NOT_ = YES; +WK_NOT_NO = YES; WK_NOT_YES = NO; WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM_NAME))); Modified: trunk/Source/_javascript_Core/Configurations/SDKVariant.xcconfig (294896 => 294897) --- trunk/Source/_javascript_Core/Configurations/SDKVariant.xcconfig 2022-05-26 21:07:42 UTC (rev 294896) +++ trunk/Source/_javascript_Core/Configurations/SDKVariant.xcconfig 2022-05-26 21:12:24 UTC (rev 294897) @@ -23,6 +23,7 @@ WK_EMPTY_ = YES; WK_NOT_ = YES; +WK_NOT_NO = YES; WK_NOT_YES = NO; WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM_NAME))); Modified: trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig (294896 => 294897) --- trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig 2022-05-26 21:07:42 UTC (rev 294896) +++ trunk/Source/ThirdParty/ANGLE/Configurations/SDKVariant.xcconfig 2022-05-26 21:12:24 UTC (rev 294897) @@ -23,6 +23,7 @@ WK_EMPTY_ = YES; WK_NOT_ = YES; +WK_NOT_NO = YES; WK_NOT_YES = NO; WK_DEFAULT_PLATFORM_NAME = $(WK_DEFAULT_PLATFORM_NAME_$(WK_EMPTY_$(FALLBACK_PLATFORM_NAME))); Modified: trunk/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig (294896 => 294897) --- trunk/Source/ThirdParty/gtest/xcode/Config/SDKVariant.xcconfig 2022-05-26 21:07:42 UTC
[webkit-changes] [294896] trunk/Source/WebCore/accessibility/AXObjectCache.h
Title: [294896] trunk/Source/WebCore/accessibility/AXObjectCache.h
Revision 294896
Author don.olmst...@sony.com
Date 2022-05-26 14:07:42 -0700 (Thu, 26 May 2022)
Log Message
Fix !ENABLE(ACCESSIBILITY) after r294878
https://bugs.webkit.org/show_bug.cgi?id=240976
Reviewed by Chris Fleizach.
Some methods with AXObjectCache were missing an !ENABLE(ACCESSIBILITY) build.
* Source/WebCore/accessibility/AXObjectCache.h:
Canonical link: https://commits.webkit.org/251019@main
Modified Paths
trunk/Source/WebCore/accessibility/AXObjectCache.h
Diff
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (294895 => 294896)
--- trunk/Source/WebCore/accessibility/AXObjectCache.h 2022-05-26 20:45:57 UTC (rev 294895)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2022-05-26 21:07:42 UTC (rev 294896)
@@ -638,6 +638,7 @@
inline void AXObjectCache::handleScrolledToAnchor(const Node*) { }
inline void AXObjectCache::liveRegionChangedNotificationPostTimerFired() { }
inline void AXObjectCache::notificationPostTimerFired() { }
+inline Vector> AXObjectCache::objectsForIDs(const Vector&) const { return { }; }
inline void AXObjectCache::passwordNotificationPostTimerFired() { }
inline void AXObjectCache::performDeferredCacheUpdate() { }
inline void AXObjectCache::postLiveRegionChangeNotification(AccessibilityObject*) { }
@@ -655,6 +656,7 @@
inline void AXObjectCache::updateCacheAfterNodeIsAttached(Node*) { }
inline void AXObjectCache::updateLoadingProgress(double) { }
inline SimpleRange AXObjectCache::rangeForNodeContents(Node& node) { return makeRangeSelectingNodeContents(node); }
+inline std::optional> AXObjectCache::relatedObjectsFor(const AXCoreObject&, AXRelationType) { return std::nullopt; }
inline void AXObjectCache::remove(AXID) { }
inline void AXObjectCache::remove(RenderObject*) { }
inline void AXObjectCache::remove(Node&) { }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294895] trunk/Source
Title: [294895] trunk/Source
Revision 294895
Author commit-qu...@webkit.org
Date 2022-05-26 13:45:57 -0700 (Thu, 26 May 2022)
Log Message
Build with -Wno-stringop-overflow when using GCC
https://bugs.webkit.org/show_bug.cgi?id=240596
Patch by Michael Catanzaro on 2022-05-26
Reviewed by Adrian Perez de Castro.
Also, rearrange and simplify the warning flag code.
And remove suppression of -Wno-attributes, since GCC 8 is everywhere nowadays.
* Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
* Source/_javascript_Core/ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
* Source/WebCore/loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::end):
* Source/cmake/WebKitCompilerFlags.cmake:
Canonical link: https://commits.webkit.org/251018@main
Modified Paths
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/ftl/FTLOSRExit.cpp
trunk/Source/WebCore/loader/DocumentWriter.cpp
trunk/Source/cmake/WebKitCompilerFlags.cmake
Diff
Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp (294894 => 294895)
--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2022-05-26 20:19:17 UTC (rev 294894)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp 2022-05-26 20:45:57 UTC (rev 294895)
@@ -20751,9 +20751,7 @@
ExitValue exitValue = exitValueForAvailability(arguments, map, availability);
if (exitValue.hasIndexInStackmapLocations())
exitValue.adjustStackmapLocationsIndexByOffset(offsetOfExitArgumentsInStackmapLocations);
-IGNORE_GCC_WARNINGS_BEGIN("stringop-overflow")
exitDescriptor->m_values[i] = exitValue;
-IGNORE_GCC_WARNINGS_END
}
for (auto heapPair : availabilityMap.m_heap) {
Modified: trunk/Source/_javascript_Core/ftl/FTLOSRExit.cpp (294894 => 294895)
--- trunk/Source/_javascript_Core/ftl/FTLOSRExit.cpp 2022-05-26 20:19:17 UTC (rev 294894)
+++ trunk/Source/_javascript_Core/ftl/FTLOSRExit.cpp 2022-05-26 20:45:57 UTC (rev 294895)
@@ -83,10 +83,8 @@
const StackmapGenerationParams& params, uint32_t dfgNodeIndex, unsigned offset)
{
FixedVector valueReps(params.size() - offset);
-IGNORE_GCC_WARNINGS_BEGIN("stringop-overflow")
for (unsigned i = offset, indexInValueReps = 0; i < params.size(); ++i, ++indexInValueReps)
valueReps[indexInValueReps] = params[i];
-IGNORE_GCC_WARNINGS_END
unsigned index = state.jitCode->m_osrExit.size();
state.jitCode->m_osrExit.append(OSRExit(this, exitKind, nodeOrigin.forExit, nodeOrigin.semantic, nodeOrigin.wasHoisted, dfgNodeIndex, WTFMove(valueReps)));
return adoptRef(*new OSRExitHandle(index, state.jitCode.get()));
Modified: trunk/Source/WebCore/loader/DocumentWriter.cpp (294894 => 294895)
--- trunk/Source/WebCore/loader/DocumentWriter.cpp 2022-05-26 20:19:17 UTC (rev 294894)
+++ trunk/Source/WebCore/loader/DocumentWriter.cpp 2022-05-26 20:45:57 UTC (rev 294895)
@@ -296,9 +296,7 @@
// http://bugs.webkit.org/show_bug.cgi?id=10854
// The frame's last ref may be removed and it can be deleted by checkCompleted(),
// so we'll add a protective refcount
-IGNORE_GCC_WARNINGS_BEGIN("stringop-overflow")
Ref protect(*m_frame);
-IGNORE_GCC_WARNINGS_END
if (!m_parser)
return;
Modified: trunk/Source/cmake/WebKitCompilerFlags.cmake (294894 => 294895)
--- trunk/Source/cmake/WebKitCompilerFlags.cmake 2022-05-26 20:19:17 UTC (rev 294894)
+++ trunk/Source/cmake/WebKitCompilerFlags.cmake 2022-05-26 20:45:57 UTC (rev 294895)
@@ -131,37 +131,29 @@
WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-noexcept-type)
-# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80947
-if (${CMAKE_CXX_COMPILER_VERSION} VERSION_LESS "8.0" AND NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-attributes)
-endif ()
+# These GCC warnings produce too many false positives to be useful. We'll
+# rely on developers who build with Clang to notice these warnings.
+if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+# https://bugs.webkit.org/show_bug.cgi?id=167643#c13
+WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS(-Wno-expansion-to-defined)
-# Since GCC 11, these warnings produce too many false positives to be useful. We'll rely on
-# developers who build with Clang to notice these warnings.
-if (CMAKE_CXX_COMPILER_ID MATCHES "GNU" AND ${CMAKE_CXX_COMPILER_VERSION} VERSION_GREATER_EQUAL "11.0")
+# https://bugs.webkit.org/show_bug.cgi?id=228601
WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-array-bounds)
WEBKIT_PREPEND_GLOBAL_CXX_FLAGS(-Wno-nonnull)
-endif ()
-# This triggers warnings in wtf/Packed.h, a header that is included in many places. It does not
-# respect ignore warning pragmas and we cannot easily suppress it for all affected files.
-# https://bugs.webkit.org/show_bug.cgi?id=226557
-if (CMAKE_CXX_COMPILER_ID MATCHES "GNU"
[webkit-changes] [294894] trunk/Source/WebCore/accessibility/isolatedtree
Title: [294894] trunk/Source/WebCore/accessibility/isolatedtree
Revision 294894
Author tyle...@apple.com
Date 2022-05-26 13:19:17 -0700 (Thu, 26 May 2022)
Log Message
AX: Don't create isolated objects from ignored live objects
https://bugs.webkit.org/show_bug.cgi?id=240507
Reviewed by Chris Fleizach.
Sometimes, we can get into a state where a live object has dynamically
become ignored but not removed as a child from its parent (since
unignored objects are the only thing that should be in any
AccessibilityObject::m_children). This can cause us to create an
isolated object for this ignored live object.
With this change, we now return a std::nullopt NodeChange for an
ignored live object.
I split this change off from a different patch improving our handling of
modals. It is required to make accessibility/aria-modal-multiple-dialogs.html
pass in isolated tree mode.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::nodeChangeForObject):
(WebCore::AXIsolatedTree::queueRemovalsAndUnresolvedChanges):
(WebCore::AXIsolatedTree::updateNode):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h:
Canonical link: https://commits.webkit.org/251016@main
Modified Paths
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h
Diff
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp (294893 => 294894)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp 2022-05-26 20:18:36 UTC (rev 294893)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp 2022-05-26 20:19:17 UTC (rev 294894)
@@ -181,19 +181,23 @@
queueRemovalsAndUnresolvedChanges({ });
}
-AXIsolatedTree::NodeChange AXIsolatedTree::nodeChangeForObject(AXCoreObject& axObject, AttachWrapper attachWrapper)
+std::optional AXIsolatedTree::nodeChangeForObject(AXCoreObject& axObject, AttachWrapper attachWrapper)
{
ASSERT(isMainThread());
-auto object = AXIsolatedObject::create(axObject, this);
-NodeChange nodeChange { object, nullptr };
+// We should never create an isolated object from an ignored object.
+if (axObject.accessibilityIsIgnored())
+return std::nullopt;
-if (!object->objectID().isValid()) {
+if (!axObject.objectID().isValid()) {
// Either the axObject has an invalid ID or something else went terribly wrong. Don't bother doing anything else.
ASSERT_NOT_REACHED();
-return nodeChange;
+return std::nullopt;
}
+auto object = AXIsolatedObject::create(axObject, this);
+NodeChange nodeChange { object, nullptr };
+
ASSERT(axObject.wrapper());
if (attachWrapper == AttachWrapper::OnMainThread)
object->attachPlatformWrapper(axObject.wrapper());
@@ -260,7 +264,8 @@
resolvedAppends.reserveInitialCapacity(m_unresolvedPendingAppends.size());
for (const auto& unresolvedAppend : m_unresolvedPendingAppends) {
if (auto* axObject = cache->objectFromAXID(unresolvedAppend.key))
-resolvedAppends.uncheckedAppend(nodeChangeForObject(*axObject, unresolvedAppend.value));
+if (auto nodeChange = nodeChangeForObject(*axObject, unresolvedAppend.value))
+resolvedAppends.uncheckedAppend(WTFMove(*nodeChange));
}
m_unresolvedPendingAppends.clear();
}
@@ -306,9 +311,10 @@
// Otherwise, resolve the change immediately and queue it up.
// In both cases, we can't attach the wrapper immediately on the main thread, since the wrapper could be in use
// on the AX thread (because this function updates an existing node).
-auto change = nodeChangeForObject(axObject, AttachWrapper::OnAXThread);
-Locker locker { m_changeLogLock };
-queueChange(change);
+if (auto change = nodeChangeForObject(axObject, AttachWrapper::OnAXThread)) {
+Locker locker { m_changeLogLock };
+queueChange(WTFMove(*change));
+}
}
void AXIsolatedTree::updateNodeProperty(AXCoreObject& axObject, AXPropertyName property)
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h (294893 => 294894)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h 2022-05-26 20:18:36 UTC (rev 294893)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h 2022-05-26 20:19:17 UTC (rev 294894)
@@ -386,7 +386,7 @@
static HashMap>& treePageCache() WTF_REQUIRES_LOCK(s_cacheLock);
enum class AttachWrapper : bool { OnMainThread, OnAXThread };
-NodeChange nodeChangeForObject(AXCoreObject&, AttachWrapper = AttachWrapper::OnMainThread);
+std::optional nodeChangeForObject(AXCoreObject&, AttachWrapper = AttachWrapper::OnMainThread);
void collectNodeChangesForSubtree(AXCoreObject&);
void queueChange(const NodeChange&) WTF_REQUIRES_LOCK(m_changeLogLock);
void queueRemovals(const
[webkit-changes] [294893] trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy
Title: [294893] trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy
Revision 294893
Author jbed...@apple.com
Date 2022-05-26 13:18:36 -0700 (Thu, 26 May 2022)
Log Message
[git-webkit] Support radar when auto-filing bug
https://bugs.webkit.org/show_bug.cgi?id=240969
Reviewed by Dewei Zhu.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py:
(Branch.main): Handle case where tracker does not have defined credentials.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py:
(TestBranch.test_create_bug): Added.
Canonical link: https://commits.webkit.org/251016@main
Modified Paths
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py
trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py
Diff
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py (294892 => 294893)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py 2022-05-26 20:06:56 UTC (rev 294892)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/branch.py 2022-05-26 20:18:36 UTC (rev 294893)
@@ -118,7 +118,7 @@
if not issue and Tracker.instance():
if ' ' in args.issue:
-if getattr(Tracker.instance(), 'credentials'):
+if getattr(Tracker.instance(), 'credentials', None):
Tracker.instance().credentials(required=True, validate=True)
issue = Tracker.instance().create(
title=args.issue,
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py (294892 => 294893)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py 2022-05-26 20:06:56 UTC (rev 294892)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/branch_unittest.py 2022-05-26 20:18:36 UTC (rev 294893)
@@ -125,8 +125,7 @@
self.assertEqual(captured.stderr.getvalue(), "'eng/reject_underscores' is an invalid branch name, cannot create it\n")
def test_create_bug(self):
-self.maxDiff = None
-with MockTerminal.input('2'), OutputCapture(level=logging.INFO) as captured, mocks.local.Git(self.path), bmocks.Bugzilla(
+with OutputCapture(level=logging.INFO) as captured, mocks.local.Git(self.path), bmocks.Bugzilla(
self.BUGZILLA.split('://')[-1],
issues=bmocks.ISSUES,
projects=bmocks.PROJECTS,
@@ -177,6 +176,49 @@
)
self.assertEqual(captured.stderr.getvalue(), '')
+def test_create_radar(self):
+with OutputCapture(level=logging.INFO) as captured, mocks.local.Git(self.path), Environment(RADAR_USERNAME='tcontributor'), bmocks.Radar(
+issues=bmocks.ISSUES,
+projects=bmocks.PROJECTS,
+), patch('webkitbugspy.Tracker._trackers', [radar.Tracker(project='WebKit')]), mocks.local.Svn(), MockTime, wkmocks.Terminal.input(
+'[Area] New Issue', 'Issue created via command line prompts.',
+'1', '2',
+):
+self.assertEqual(0, program.main(
+args=('branch',),
+path=self.path,
+))
+self.assertEqual(local.Git(self.path).branch, 'eng/Area-New-Issue')
+
+issue = radar.Tracker(project='WebKit').issue(4)
+self.assertEqual(issue.title, '[Area] New Issue')
+self.assertEqual(issue.description, 'Issue created via command line prompts.')
+self.assertEqual(issue.project, 'WebKit')
+self.assertEqual(issue.component, 'SVG')
+self.assertEqual(issue.version, 'Safari 15')
+
+self.assertEqual(
+captured.stdout.getvalue(),
+'''Enter issue URL or title of new issue:
+Issue description:
+What component in 'WebKit' should the bug be associated with?:
+1) SVG
+2) Scrolling
+3) Tables
+4) Text
+:
+What version of 'WebKit SVG' should the bug be associated with?:
+1) Other
+2) Safari 15
+3) Safari Technology Preview
+4) WebKit Local Build
+:
+Created ' [Area] New Issue'
+Created the local development branch 'eng/Area-New-Issue'
+''',
+)
+self.assertEqual(captured.stderr.getvalue(), '')
+
def test_to_branch_name(self):
self.assertEqual(program.Branch.to_branch_name('something with spaces'), 'something-with-spaces')
self.assertEqual(program.Branch.to_branch_name('[EWS] bug description'), 'EWS-bug-description')
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294892] branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/src/ libANGLE/renderer/metal/ContextMtl.mm
Title: [294892] branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm
Revision 294892
Author alanc...@apple.com
Date 2022-05-26 13:06:56 -0700 (Thu, 26 May 2022)
Log Message
Cherry-pick r294877. rdar://problem/93834054
Uniform buffer reuse causes flush, creates invalid state
https://bugs.webkit.org/show_bug.cgi?id=240896
Patch by Kimmo Kinnunen on 2022-05-26
Patch by Kyle Piddington.
Reviewed by Kimmo Kinnunen.
A flush during draw setup would leave the render command encoder
not started and render pipeline unset. This would assert in debug
and leak memory with corrupted draws in release.
This would happen for example when uniform buffer pool would run
out of uniform memory. If the pool is maxed out, we flush the
existing rendering to obtain free buffers. After the flush,
we need to re-run the setup.
Test is tracked in bug 240948.
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:
(rx::ContextMtl::setupDraw):
(rx::ContextMtl::setupDrawImpl):
Canonical link: https://commits.webkit.org/251007@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm
Diff
Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm (294891 => 294892)
--- branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm 2022-05-26 20:06:52 UTC (rev 294891)
+++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm 2022-05-26 20:06:56 UTC (rev 294892)
@@ -,6 +,32 @@
const void *indices,
bool xfbPass)
{
+ANGLE_TRY(setupDrawImpl(context, mode, firstVertex, vertexOrIndexCount, instances,
+indexTypeOrNone, indices, xfbPass));
+if (!mRenderEncoder.valid())
+{
+// Flush occurred during setup, due to running out of memory while setting up the render
+// pass state. This would happen for example when there is no more space in the uniform
+// buffers in the uniform buffer pool. The rendering would be flushed to free the uniform
+// buffer memory for new usage. In this case, re-run the setup.
+ANGLE_TRY(setupDrawImpl(context, mode, firstVertex, vertexOrIndexCount, instances,
+indexTypeOrNone, indices, xfbPass));
+// Setup with flushed state should either produce a working encoder or fail with an error
+// result.
+ASSERT(mRenderEncoder.valid());
+}
+return angle::Result::Continue;
+}
+
+angle::Result ContextMtl::setupDrawImpl(const gl::Context *context,
+gl::PrimitiveMode mode,
+GLint firstVertex,
+GLsizei vertexOrIndexCount,
+GLsizei instances,
+gl::DrawElementsType indexTypeOrNone,
+const void *indices,
+bool xfbPass)
+{
ASSERT(mProgram);
// instances=0 means no instanced draw.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294891] branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess
Title: [294891] branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess
Revision 294891
Author alanc...@apple.com
Date 2022-05-26 13:06:52 -0700 (Thu, 26 May 2022)
Log Message
Cherry-pick r294831. rdar://problem/93656000
Prevent NSAttributedString crashes when AppSSO URLs are provided
https://bugs.webkit.org/show_bug.cgi?id=240739
Reviewed by Chris Dumez.
When NSAttributedString is used in a sandboxed app, it is prevented from checking in with the
AppSSO plugin manager, causing a Sandbox Violation and crash. We don't want NSAttributedString
to ever hand-off to AppSSO, so we should configure it's internal WKWebView to do the right thing.
Reviewed by Chris Dumez.
* Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm:
(+[_WKAttributedStringWebViewCache configuration]): Turn off AppSSO for string uses.
* Source/WebKit/UIProcess/Cocoa/NavigationState.mm:
(WebKit::trySOAuthorization): Use new lazy loading approach.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::trySOAuthorization): Ditto.
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::soAuthorizationCoordinator): Lazily initialize, and RELEASE_ASSERT
if we somehow reach this code without enabling AppSSO.
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::soAuthorizationCoordinator): Deleted.
Canonical link: https://commits.webkit.org/250981@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/Cocoa/NavigationState.mm
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp
branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h
Diff
Modified: branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm (294890 => 294891)
--- branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm 2022-05-26 20:03:07 UTC (rev 294890)
+++ branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/API/Cocoa/NSAttributedString.mm 2022-05-26 20:06:52 UTC (rev 294891)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2019-2022 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -144,6 +144,7 @@
[configuration _setAllowsJavaScriptMarkup:NO];
[configuration _setAllowsMetaRefresh:NO];
[configuration _setAttachmentElementEnabled:YES];
+[configuration preferences]._extensibleSSOEnabled = NO;
[configuration _setInvisibleAutoplayNotPermitted:YES];
[configuration _setMediaDataLoadsAutomatically:NO];
[configuration _setNeedsStorageAccessFromFileURLsQuirk:NO];
Modified: branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/Cocoa/NavigationState.mm (294890 => 294891)
--- branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/Cocoa/NavigationState.mm 2022-05-26 20:03:07 UTC (rev 294890)
+++ branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/Cocoa/NavigationState.mm 2022-05-26 20:06:52 UTC (rev 294891)
@@ -424,7 +424,7 @@
completionHandler(false);
return;
}
-page.websiteDataStore().soAuthorizationCoordinator().tryAuthorize(WTFMove(navigationAction), page, WTFMove(completionHandler));
+page.websiteDataStore().soAuthorizationCoordinator(page).tryAuthorize(WTFMove(navigationAction), page, WTFMove(completionHandler));
#else
completionHandler(false);
#endif
Modified: branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (294890 => 294891)
--- branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-05-26 20:03:07 UTC (rev 294890)
+++ branches/safari-7614.1.14.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp 2022-05-26 20:06:52 UTC (rev 294891)
@@ -5996,7 +5996,7 @@
static void trySOAuthorization(Ref&& navigationAction, WebPageProxy& page, NewPageCallback&& newPageCallback, UIClientCallback&& uiClientCallback)
{
#if HAVE(APP_SSO)
-page.websiteDataStore().soAuthorizationCoordinator().tryAuthorize(WTFMove(navigationAction), page, WTFMove(newPageCallback), WTFMove(uiClientCallback));
+page.websiteDataStore().soAuthorizationCoordinator(page).tryAuthorize(WTFMove(navigationAction), page, WTFMove(newPageCallback), WTFMove(uiClientCallback));
#else
uiClientCallback(WTFMove(navigationAction), WTFMove(newPageCallback));
#endif
Modified:
[webkit-changes] [294890] branches/safari-7614.1.14.1-branch/Source
Title: [294890] branches/safari-7614.1.14.1-branch/Source Revision 294890 Author alanc...@apple.com Date 2022-05-26 13:03:07 -0700 (Thu, 26 May 2022) Log Message Versioning. WebKit-7614.1.14.1.13 Modified Paths branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294889 => 294890) --- branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) +++ branches/safari-7614.1.14.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-26 20:03:07 UTC (rev 294890) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 12; +NANO_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294889 => 294890) --- branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) +++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-26 20:03:07 UTC (rev 294890) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 12; +NANO_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294889 => 294890) --- branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) +++ branches/safari-7614.1.14.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-26 20:03:07 UTC (rev 294890) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 12; +NANO_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig (294889 => 294890) --- branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) +++ branches/safari-7614.1.14.1-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-26 20:03:07 UTC (rev 294890) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 12; +NANO_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294889 => 294890) --- branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) +++ branches/safari-7614.1.14.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-26 20:03:07 UTC (rev 294890) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 1; -NANO_VERSION = 12; +NANO_VERSION = 13; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig (294889 => 294890) --- branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) +++ branches/safari-7614.1.14.1-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-26 20:03:07 UTC (rev 294890) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION
[webkit-changes] [294889] branches/safari-7614.1.14.0-branch/Source
Title: [294889] branches/safari-7614.1.14.0-branch/Source Revision 294889 Author alanc...@apple.com Date 2022-05-26 13:02:46 -0700 (Thu, 26 May 2022) Log Message Versioning. WebKit-7614.1.14.0.12 Modified Paths branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.14.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294888 => 294889) --- branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-26 19:50:46 UTC (rev 294888) +++ branches/safari-7614.1.14.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 11; +NANO_VERSION = 12; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294888 => 294889) --- branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-26 19:50:46 UTC (rev 294888) +++ branches/safari-7614.1.14.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 11; +NANO_VERSION = 12; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294888 => 294889) --- branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-26 19:50:46 UTC (rev 294888) +++ branches/safari-7614.1.14.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 11; +NANO_VERSION = 12; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig (294888 => 294889) --- branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-26 19:50:46 UTC (rev 294888) +++ branches/safari-7614.1.14.0-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 11; +NANO_VERSION = 12; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294888 => 294889) --- branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-26 19:50:46 UTC (rev 294888) +++ branches/safari-7614.1.14.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION = 0; -NANO_VERSION = 11; +NANO_VERSION = 12; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig (294888 => 294889) --- branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-26 19:50:46 UTC (rev 294888) +++ branches/safari-7614.1.14.0-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-26 20:02:46 UTC (rev 294889) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 14; MICRO_VERSION
[webkit-changes] [294888] trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Title: [294888] trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Revision 294888
Author drou...@apple.com
Date 2022-05-26 12:50:46 -0700 (Thu, 26 May 2022)
Log Message
spurious `RELEASE_LOG` when creating a `WKWebView` with an empty `frame`
https://bugs.webkit.org/show_bug.cgi?id=240959
Reviewed by Tim Horton.
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]):
Don't `RELEASE_LOG` (or `throw`) unless a `minimumViewportInset`/`maximumViewportInset` has been specified.
Canonical link: https://commits.webkit.org/251015@main
Modified Paths
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Diff
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (294887 => 294888)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-05-26 19:30:38 UTC (rev 294887)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2022-05-26 19:50:46 UTC (rev 294888)
@@ -1602,25 +1602,33 @@
{
auto frame = WebCore::FloatSize(self.frame.size);
-auto minimumUnobscuredSize = frame - WebCore::FloatSize(maximumViewportInset.left + maximumViewportInset.right, maximumViewportInset.top + maximumViewportInset.bottom);
+auto maximumViewportInsetSize = WebCore::FloatSize(maximumViewportInset.left + maximumViewportInset.right, maximumViewportInset.top + maximumViewportInset.bottom);
+auto minimumUnobscuredSize = frame - maximumViewportInsetSize;
if (minimumUnobscuredSize.isEmpty()) {
-if (throwOnInvalidInput) {
-[NSException raise:NSInvalidArgumentException format:@"maximumViewportInset cannot be larger than frame"];
-return;
+if (!maximumViewportInsetSize.isEmpty()) {
+if (throwOnInvalidInput) {
+[NSException raise:NSInvalidArgumentException format:@"maximumViewportInset cannot be larger than frame"];
+return;
+}
+
+RELEASE_LOG_ERROR(ViewportSizing, "maximumViewportInset cannot be larger than frame");
}
-RELEASE_LOG_ERROR(ViewportSizing, "maximumViewportInset cannot be larger than frame");
minimumUnobscuredSize = frame;
}
-auto maximumUnobscuredSize = frame - WebCore::FloatSize(minimumViewportInset.left + minimumViewportInset.right, minimumViewportInset.top + minimumViewportInset.bottom);
+auto minimumViewportInsetSize = WebCore::FloatSize(minimumViewportInset.left + minimumViewportInset.right, minimumViewportInset.top + minimumViewportInset.bottom);
+auto maximumUnobscuredSize = frame - minimumViewportInsetSize;
if (maximumUnobscuredSize.isEmpty()) {
-if (throwOnInvalidInput) {
-[NSException raise:NSInvalidArgumentException format:@"minimumViewportInset cannot be larger than frame"];
-return;
+if (!minimumViewportInsetSize.isEmpty()) {
+if (throwOnInvalidInput) {
+[NSException raise:NSInvalidArgumentException format:@"minimumViewportInset cannot be larger than frame"];
+return;
+}
+
+RELEASE_LOG_ERROR(ViewportSizing, "minimumViewportInset cannot be larger than frame");
}
-RELEASE_LOG_ERROR(ViewportSizing, "minimumViewportInset cannot be larger than frame");
maximumUnobscuredSize = frame;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294887] releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/ texmap/TextureMapperPlatformLayerProxyGL.cpp
Title: [294887] releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp
Revision 294887
Author ape...@igalia.com
Date 2022-05-26 12:30:38 -0700 (Thu, 26 May 2022)
Log Message
Crash in WebCore::TextureMapperLayer::paintSelf https://bugs.webkit.org/show_bug.cgi?id=240283
Unreviewed merge.
There are 4 cases that can happen after there has been a layerFlush and
we're adopting the new state in the composition stage:
1. The layer is removed from the tree and the proxy is not assigned to
any other layer: the deletion of the layer causes an invalidation of
the proxy and both are destroyed afterwards. This works fine.
2. The layer is removed from the tree and the proxy is reassigned to a
new layer: the deletion of the first layer causes the invalidation of
the proxy, which is then activated on the second layer. As the first
layer is destroyed, we don't have to worry about dangling references
from it to the proxy's currentBuffer. This works fine.
3. The layer is kept in the tree and the proxy gets disassociated from
it and not used by any other layer: we detect that the proxy is not
used anymore and call invalidate on it, but the layer keeps a
reference to the proxy's currentBuffer, which has been deleted during
invalidate, which leads to a crash when trying to render the layer.
4. The layer is kept in the tree and the proxy gets associated to a new
layer: as we detect that the proxy is still being used it's not
invalidated, but it gets activated on the second layer. The first
layer keeps a reference to the proxy's currentBuffer, which will be
destroyed a bit later when swapBuffers is called on the proxy. This
leads to a crash when trying to render the first layer.
This patch addresses cases 3. and 4. described above.
* Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp:
(WebCore::TextureMapperPlatformLayerProxyGL::activateOnCompositingThread):
Ensure that the layer no longer keeps a reference to the current buffer if the
proxy is already active on a different layer.
(WebCore::TextureMapperPlatformLayerProxyGL::invalidate): Ensure that
the invalidated layer does not keep a reference to the current buffer.
Modified Paths
releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp
Diff
Modified: releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp (294886 => 294887)
--- releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp 2022-05-26 18:41:37 UTC (rev 294886)
+++ releases/WebKitGTK/webkit-2.36/Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxyGL.cpp 2022-05-26 19:30:38 UTC (rev 294887)
@@ -65,6 +65,9 @@
{
Locker locker { m_lock };
m_compositor = compositor;
+// If the proxy is already active on another layer, remove the layer's reference to the current buffer.
+if (m_targetLayer)
+m_targetLayer->setContentsLayer(nullptr);
m_targetLayer = targetLayer;
if (m_targetLayer && m_currentBuffer)
m_targetLayer->setContentsLayer(m_currentBuffer.get());
@@ -91,7 +94,10 @@
{
Locker locker { m_lock };
m_compositor = nullptr;
-m_targetLayer = nullptr;
+if (m_targetLayer) {
+m_targetLayer->setContentsLayer(nullptr);
+m_targetLayer = nullptr;
+}
m_currentBuffer = nullptr;
m_pendingBuffer = nullptr;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294886] trunk
Title: [294886] trunk Revision 294886 Author gsnedd...@apple.com Date 2022-05-26 11:41:37 -0700 (Thu, 26 May 2022) Log Message Remove resolution media feature dpi/dpcm unit warning https://bugs.webkit.org/show_bug.cgi?id=240907 Reviewed by Simon Fraser. * LayoutTests/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: * LayoutTests/fast/media/mq-resolution-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: * LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: * LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt: * Source/WebCore/css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::setMediaQueries): * Source/WebCore/css/MediaList.cpp: (WebCore::addResolutionWarningMessageToConsole): Deleted. (WebCore::reportMediaQueryWarningIfNeeded): Deleted. * Source/WebCore/css/MediaList.h: * Source/WebCore/css/MediaQueryMatcher.cpp: (WebCore::MediaQueryMatcher::matchMedia): * Source/WebCore/css/StyleSheetContents.cpp: (WebCore::StyleSheetContents::parserAppendRule): Canonical link: https://commits.webkit.org/251014@main Modified Paths trunk/LayoutTests/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt trunk/LayoutTests/fast/media/mq-resolution-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt trunk/Source/WebCore/css/CSSStyleSheet.cpp trunk/Source/WebCore/css/MediaList.cpp trunk/Source/WebCore/css/MediaList.h trunk/Source/WebCore/css/MediaQueryMatcher.cpp trunk/Source/WebCore/css/StyleSheetContents.cpp Diff Modified: trunk/LayoutTests/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt (294885 => 294886) --- trunk/LayoutTests/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt 2022-05-26 18:30:46 UTC (rev 294885) +++ trunk/LayoutTests/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt 2022-05-26 18:41:37 UTC (rev 294886) @@ -1,16 +1 @@ -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to the actual 'dpi' of a screen. In media query _expression_: screen and (min-resolution: 96dpi) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpcm', as in CSS 'dpcm' means dots-per-CSS-centimeter, not dots-per-physical-centimeter, so does not correspond to the actual 'dpcm' of a screen. In media query _expression_: (min-resolution: 160dpcm) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to the actual 'dpi' of a screen. In media query _expression_: (resolution: 96dpi) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to the actual 'dpi' of a screen. In media query _expression_: (min-resolution: 2dpi) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpcm', as in CSS 'dpcm' means dots-per-CSS-centimeter, not dots-per-physical-centimeter, so does not correspond to the actual 'dpcm' of a screen. In media query _expression_: (min-resolution: 2dpcm) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to the actual 'dpi' of a screen. In media query _expression_: screen and (min-resolution: 5dpi) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpcm', as in CSS 'dpcm' means dots-per-CSS-centimeter, not dots-per-physical-centimeter, so does not correspond to the actual 'dpcm' of a screen. In media query _expression_: screen and (min-resolution: 5dpcm) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to the actual 'dpi' of a screen. In media query _expression_: (min-resolution: 10dpi) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpcm', as in CSS 'dpcm' means dots-per-CSS-centimeter, not dots-per-physical-centimeter, so does not correspond to the actual 'dpcm' of a screen. In media query _expression_: (min-resolution: 10dpcm) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpi', as in CSS 'dpi' means dots-per-CSS-inch, not dots-per-physical-inch, so does not correspond to the actual 'dpi' of a screen. In media query _expression_: screen and (max-resolution: 300dpi) -CONSOLE MESSAGE: Consider using 'dppx' units instead of 'dpcm', as in CSS 'dpcm' means dots-per-CSS-centimeter, not dots-per-physical-centimeter, so does not correspond to the actual 'dpcm' of a screen. In media query _expression_:
[webkit-changes] [294885] trunk/Source
Title: [294885] trunk/Source
Revision 294885
Author cdu...@apple.com
Date 2022-05-26 11:30:46 -0700 (Thu, 26 May 2022)
Log Message
Drop unnecessary overloads now that StringView(const char*) is explicit
https://bugs.webkit.org/show_bug.cgi?id=240941
Reviewed by Darin Adler.
* Source/WTF/wtf/text/AtomString.h:
* Source/WTF/wtf/text/StringImpl.h:
(WTF::StringImpl::find):
(WTF::StringImpl::reverseFind):
* Source/WTF/wtf/text/StringView.h:
* Source/WTF/wtf/text/WTFString.h:
* Source/WebCore/platform/network/HTTPHeaderMap.h:
* Source/WebCore/platform/network/ResourceRequestBase.h:
* Source/WebCore/platform/network/ResourceResponseBase.h:
Canonical link: https://commits.webkit.org/251013@main
Modified Paths
trunk/Source/WTF/wtf/text/AtomString.h
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/StringView.h
trunk/Source/WTF/wtf/text/WTFString.h
trunk/Source/WebCore/platform/network/HTTPHeaderMap.h
trunk/Source/WebCore/platform/network/ResourceRequestBase.h
trunk/Source/WebCore/platform/network/ResourceResponseBase.h
Diff
Modified: trunk/Source/WTF/wtf/text/AtomString.h (294884 => 294885)
--- trunk/Source/WTF/wtf/text/AtomString.h 2022-05-26 18:21:26 UTC (rev 294884)
+++ trunk/Source/WTF/wtf/text/AtomString.h 2022-05-26 18:30:46 UTC (rev 294885)
@@ -98,16 +98,13 @@
bool contains(UChar character) const { return m_string.contains(character); }
bool contains(ASCIILiteral literal) const { return m_string.contains(literal); }
-bool contains(const char*) const = delete;
bool contains(StringView) const;
bool containsIgnoringASCIICase(StringView) const;
size_t find(UChar character, unsigned start = 0) const { return m_string.find(character, start); }
size_t find(ASCIILiteral literal, unsigned start = 0) const { return m_string.find(literal, start); }
-size_t find(const char*, unsigned start = 0) const = delete;
size_t find(StringView, unsigned start = 0) const;
size_t findIgnoringASCIICase(StringView) const;
-size_t findIgnoringASCIICase(const char*) const = delete;
size_t findIgnoringASCIICase(StringView, unsigned start) const;
size_t find(CodeUnitMatchFunction matchFunction, unsigned start = 0) const { return m_string.find(matchFunction, start); }
@@ -190,7 +187,6 @@
bool equalIgnoringASCIICase(const AtomString&, const String&);
bool equalIgnoringASCIICase(const String&, const AtomString&);
bool equalIgnoringASCIICase(const AtomString&, ASCIILiteral);
-bool equalIgnoringASCIICase(const AtomString&, const char*) = delete;
bool equalLettersIgnoringASCIICase(const AtomString&, ASCIILiteral);
bool startsWithLettersIgnoringASCIICase(const AtomString&, ASCIILiteral);
Modified: trunk/Source/WTF/wtf/text/StringImpl.h (294884 => 294885)
--- trunk/Source/WTF/wtf/text/StringImpl.h 2022-05-26 18:21:26 UTC (rev 294884)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2022-05-26 18:30:46 UTC (rev 294885)
@@ -433,7 +433,6 @@
template>* = nullptr>
size_t find(CodeUnitMatchFunction, unsigned start = 0);
ALWAYS_INLINE size_t find(ASCIILiteral literal, unsigned start = 0) { return find(literal.characters8(), literal.length(), start); }
-size_t find(const char*, unsigned start = 0) = delete;
WTF_EXPORT_PRIVATE size_t find(StringView);
WTF_EXPORT_PRIVATE size_t find(StringView, unsigned start);
WTF_EXPORT_PRIVATE size_t findIgnoringASCIICase(StringView) const;
@@ -442,7 +441,6 @@
WTF_EXPORT_PRIVATE size_t reverseFind(UChar, unsigned start = MaxLength);
WTF_EXPORT_PRIVATE size_t reverseFind(StringView, unsigned start = MaxLength);
ALWAYS_INLINE size_t reverseFind(ASCIILiteral literal, unsigned start = MaxLength) { return reverseFind(literal.characters8(), literal.length(), start); }
-size_t reverseFind(const char*, unsigned start = MaxLength) = delete;
WTF_EXPORT_PRIVATE bool startsWith(StringView) const;
WTF_EXPORT_PRIVATE bool startsWithIgnoringASCIICase(StringView) const;
@@ -589,8 +587,6 @@
WTF_EXPORT_PRIVATE bool equalIgnoringASCIICase(const StringImpl*, const StringImpl*);
bool equalIgnoringASCIICase(const StringImpl&, ASCIILiteral);
bool equalIgnoringASCIICase(const StringImpl*, ASCIILiteral);
-bool equalIgnoringASCIICase(const StringImpl&, const char*) = delete;
-bool equalIgnoringASCIICase(const StringImpl*, const char*) = delete;
WTF_EXPORT_PRIVATE bool equalIgnoringASCIICaseNonNull(const StringImpl*, const StringImpl*);
Modified: trunk/Source/WTF/wtf/text/StringView.h (294884 => 294885)
--- trunk/Source/WTF/wtf/text/StringView.h 2022-05-26 18:21:26 UTC (rev 294884)
+++ trunk/Source/WTF/wtf/text/StringView.h 2022-05-26 18:30:46 UTC (rev 294885)
@@ -151,12 +151,10 @@
template>* = nullptr>
size_t find(CodeUnitMatchFunction&&, unsigned start = 0) const;
ALWAYS_INLINE size_t find(ASCIILiteral literal, unsigned start = 0) const { return find(literal.characters8(), literal.length(), start); }
-size_t find(const char*, unsigned start =
[webkit-changes] [294884] branches/safari-7614.1.15-branch/Source
Title: [294884] branches/safari-7614.1.15-branch/Source Revision 294884 Author repst...@apple.com Date 2022-05-26 11:21:26 -0700 (Thu, 26 May 2022) Log Message Versioning. WebKit-7614.1.15 Modified Paths branches/safari-7614.1.15-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-7614.1.15-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-7614.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-7614.1.15-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-7614.1.15-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-7614.1.15-branch/Source/WebGPU/Configurations/Version.xcconfig branches/safari-7614.1.15-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-7614.1.15-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-7614.1.15-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-7614.1.15-branch/Source/_javascript_Core/Configurations/Version.xcconfig (294883 => 294884) --- branches/safari-7614.1.15-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-26 18:00:14 UTC (rev 294883) +++ branches/safari-7614.1.15-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2022-05-26 18:21:26 UTC (rev 294884) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 13; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-7614.1.15-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (294883 => 294884) --- branches/safari-7614.1.15-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-26 18:00:14 UTC (rev 294883) +++ branches/safari-7614.1.15-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2022-05-26 18:21:26 UTC (rev 294884) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 13; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-7614.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (294883 => 294884) --- branches/safari-7614.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-26 18:00:14 UTC (rev 294883) +++ branches/safari-7614.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2022-05-26 18:21:26 UTC (rev 294884) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 13; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-7614.1.15-branch/Source/WebCore/Configurations/Version.xcconfig (294883 => 294884) --- branches/safari-7614.1.15-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-26 18:00:14 UTC (rev 294883) +++ branches/safari-7614.1.15-branch/Source/WebCore/Configurations/Version.xcconfig 2022-05-26 18:21:26 UTC (rev 294884) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 13; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-7614.1.15-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (294883 => 294884) --- branches/safari-7614.1.15-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-26 18:00:14 UTC (rev 294883) +++ branches/safari-7614.1.15-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2022-05-26 18:21:26 UTC (rev 294884) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 13; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-7614.1.15-branch/Source/WebGPU/Configurations/Version.xcconfig (294883 => 294884) --- branches/safari-7614.1.15-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-26 18:00:14 UTC (rev 294883) +++ branches/safari-7614.1.15-branch/Source/WebGPU/Configurations/Version.xcconfig 2022-05-26 18:21:26 UTC (rev 294884) @@ -23,7 +23,7 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 13; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-7614.1.15-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (294883 => 294884) --- branches/safari-7614.1.15-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-05-26 18:00:14 UTC (rev 294883) +++ branches/safari-7614.1.15-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2022-05-26 18:21:26 UTC (rev 294884) @@ -1,6 +1,6 @@ MAJOR_VERSION = 614; MINOR_VERSION = 1; -TINY_VERSION = 13; +TINY_VERSION = 15; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION =
[webkit-changes] [294883] branches/safari-7614.1.15-branch/
Title: [294883] branches/safari-7614.1.15-branch/ Revision 294883 Author repst...@apple.com Date 2022-05-26 11:00:14 -0700 (Thu, 26 May 2022) Log Message New branch. Added Paths branches/safari-7614.1.15-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294882] trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
Title: [294882] trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
Revision 294882
Author akeer...@apple.com
Date 2022-05-26 10:46:28 -0700 (Thu, 26 May 2022)
Log Message
[iOS] Update the presentation style of the photo picker
https://bugs.webkit.org/show_bug.cgi?id=240926
rdar://89670039
Reviewed by Wenson Hsieh.
The photo picker should no longer be displayed as a popover. Instead, let UIKit
decide the modal presentation style.
* Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel dealloc]):
(-[WKFileUploadPanel dismiss]):
(-[WKFileUploadPanel _dismissDisplayAnimated:]):
(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
Set the presentationController's delegate so that we are informed when the picker
is dismissed by swiping down.
(-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]): Deleted.
This method was already unused.
(-[WKFileUploadPanel _presentPopoverWithContentViewController:animated:]): Deleted.
(-[WKFileUploadPanel popoverControllerDidDismissPopover:]): Deleted.
Canonical link: https://commits.webkit.org/251012@main
Modified Paths
trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
Diff
Modified: trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm (294881 => 294882)
--- trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2022-05-26 17:25:38 UTC (rev 294881)
+++ trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm 2022-05-26 17:46:28 UTC (rev 294882)
@@ -332,7 +332,7 @@
#pragma mark - WKFileUploadPanel
-@interface WKFileUploadPanel () +@interface WKFileUploadPanel () #if USE(UICONTEXTMENU)
, UIContextMenuInteractionDelegate
#endif
@@ -351,9 +351,8 @@
RetainPtr _mediaTranscoder;
#endif
RetainPtr _imagePicker;
-RetainPtr _presentationViewController; // iPhone always. iPad for Fullscreen Camera.
+RetainPtr _presentationViewController;
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
-RetainPtr _presentationPopover; // iPad for action sheet and Photo Library.
BOOL _isPresentingSubMenu;
ALLOW_DEPRECATED_DECLARATIONS_END
#if USE(UICONTEXTMENU)
@@ -374,7 +373,6 @@
- (void)dealloc
{
[_imagePicker setDelegate:nil];
-[_presentationPopover setDelegate:nil];
[_documentPickerController setDelegate:nil];
#if USE(UICONTEXTMENU)
[self removeContextMenuInteraction];
@@ -503,9 +501,7 @@
if (auto view = _view.get())
[[UIViewController _viewControllerForFullScreenPresentationFromView:view.get()] dismissViewControllerAnimated:NO completion:nil];
-
-[_presentationPopover setDelegate:nil];
-_presentationPopover = nil;
+
_presentationViewController = nil;
[self _cancel];
@@ -513,12 +509,6 @@
- (void)_dismissDisplayAnimated:(BOOL)animated
{
-if (_presentationPopover) {
-[_presentationPopover dismissPopoverAnimated:animated];
-[_presentationPopover setDelegate:nil];
-_presentationPopover = nil;
-}
-
if (_presentationViewController) {
UIViewController *currentPresentedViewController = [_presentationViewController presentedViewController];
if (currentPresentedViewController == self || currentPresentedViewController == _imagePicker.get()) {
@@ -781,8 +771,8 @@
[_imagePicker setSourceType:sourceType];
[_imagePicker setMediaTypes:[self _mediaTypesForPickerSourceType:sourceType]];
[_imagePicker setDelegate:self];
+[_imagePicker presentationController].delegate = self;
[_imagePicker setAllowsEditing:NO];
-[_imagePicker setModalPresentationStyle:UIModalPresentationFullScreen];
[_imagePicker _setAllowsMultipleSelection:_allowMultipleFiles];
[_imagePicker _setRequiresPickingConfirmation:YES];
[_imagePicker _setShowsFileSizePicker:YES];
@@ -790,36 +780,11 @@
if (_mediaCaptureType != WebCore::MediaCaptureTypeNone)
[_imagePicker setCameraDevice:cameraDeviceForMediaCaptureType(_mediaCaptureType)];
-// Use a popover on the iPad if the source type is not the camera.
-// The camera will use a fullscreen, modal view controller.
-BOOL usePopover = !currentUserInterfaceIdiomIsSmallScreen() && sourceType != UIImagePickerControllerSourceTypeCamera;
-if (usePopover)
-[self _presentPopoverWithContentViewController:_imagePicker.get() animated:YES];
-else
-[self _presentFullscreenViewController:_imagePicker.get() animated:YES];
+[self _presentFullscreenViewController:_imagePicker.get() animated:YES];
}
#pragma mark - Presenting View Controllers
-- (void)_presentMenuOptionForCurrentInterfaceIdiom:(UIViewController *)viewController
-{
-if (currentUserInterfaceIdiomIsSmallScreen())
-[self _presentFullscreenViewController:viewController animated:YES];
-else
-[self _presentPopoverWithContentViewController:viewController animated:YES];
-}
-
-- (void)_presentPopoverWithContentViewController:(UIViewController *)contentViewController animated:(BOOL)animated
-{
-
[webkit-changes] [294881] trunk/Source
Title: [294881] trunk/Source Revision 294881 Author hironori.fu...@sony.com Date 2022-05-26 10:25:38 -0700 (Thu, 26 May 2022) Log Message Cannot link WebKitTestRunner in non-unified builds https://bugs.webkit.org/show_bug.cgi?id=240755 Reviewed by Adrian Perez de Castro. In GTK non-unified build, WebKit shared library didn't export all WEBCORE_EXPORT marked WebCore symbols because WebCore was a static library. WebCore should be an SHARED or OBJECT library to work WEBCORE_EXPORT macro as expected. * Source/WebCore/PlatformGTK.cmake: * Source/WebCore/page/gtk/DragControllerGtk.cpp: * Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/251011@main Modified Paths trunk/Source/WebCore/PlatformGTK.cmake trunk/Source/WebCore/page/gtk/DragControllerGtk.cpp trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp trunk/Source/cmake/OptionsGTK.cmake trunk/Source/cmake/OptionsWPE.cmake Diff Modified: trunk/Source/WebCore/PlatformGTK.cmake (294880 => 294881) --- trunk/Source/WebCore/PlatformGTK.cmake 2022-05-26 16:56:14 UTC (rev 294880) +++ trunk/Source/WebCore/PlatformGTK.cmake 2022-05-26 17:25:38 UTC (rev 294881) @@ -6,8 +6,6 @@ include(platform/Soup.cmake) include(platform/TextureMapper.cmake) -set(WebCore_OUTPUT_NAME WebCoreGTK) - list(APPEND WebCore_UNIFIED_SOURCE_LIST_FILES "SourcesGTK.txt" Modified: trunk/Source/WebCore/page/gtk/DragControllerGtk.cpp (294880 => 294881) --- trunk/Source/WebCore/page/gtk/DragControllerGtk.cpp 2022-05-26 16:56:14 UTC (rev 294880) +++ trunk/Source/WebCore/page/gtk/DragControllerGtk.cpp 2022-05-26 17:25:38 UTC (rev 294881) @@ -32,6 +32,7 @@ #include "Editor.h" #include "Element.h" #include "Frame.h" +#include "FrameDestructionObserverInlines.h" #include "Pasteboard.h" #include "markup.h" Modified: trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp (294880 => 294881) --- trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp 2022-05-26 16:56:14 UTC (rev 294880) +++ trunk/Source/WebKit/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp 2022-05-26 17:25:38 UTC (rev 294881) @@ -33,6 +33,7 @@ #include "WebProcess.h" #include #include +#include #include #include #include Modified: trunk/Source/cmake/OptionsGTK.cmake (294880 => 294881) --- trunk/Source/cmake/OptionsGTK.cmake 2022-05-26 16:56:14 UTC (rev 294880) +++ trunk/Source/cmake/OptionsGTK.cmake 2022-05-26 17:25:38 UTC (rev 294881) @@ -247,6 +247,7 @@ set(CMAKE_CXX_VISIBILITY_PRESET hidden) set(bmalloc_LIBRARY_TYPE OBJECT) set(WTF_LIBRARY_TYPE OBJECT) +set(WebCore_LIBRARY_TYPE OBJECT) # These are shared variables, but we special case their definition so that we can use the # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro. Modified: trunk/Source/cmake/OptionsWPE.cmake (294880 => 294881) --- trunk/Source/cmake/OptionsWPE.cmake 2022-05-26 16:56:14 UTC (rev 294880) +++ trunk/Source/cmake/OptionsWPE.cmake 2022-05-26 17:25:38 UTC (rev 294881) @@ -178,6 +178,7 @@ set(bmalloc_LIBRARY_TYPE OBJECT) set(WTF_LIBRARY_TYPE OBJECT) set(_javascript_Core_LIBRARY_TYPE OBJECT) +set(WebCore_LIBRARY_TYPE OBJECT) # These are shared variables, but we special case their definition so that we can use the # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294880] trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Title: [294880] trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Revision 294880
Author simon.fra...@apple.com
Date 2022-05-26 09:56:14 -0700 (Thu, 26 May 2022)
Log Message
Incorrect layout on iframe with object-fit
https://bugs.webkit.org/show_bug.cgi?id=240940
Reviewed by Alan Bujtas.
Don't use replacedContentRect() when positioning iframe content layers, because iframes
don't (yet) respond to object-fit.
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentsBox const):
Canonical link: https://commits.webkit.org/251010@main
Modified Paths
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp
Diff
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (294879 => 294880)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2022-05-26 16:16:12 UTC (rev 294879)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2022-05-26 16:56:14 UTC (rev 294880)
@@ -2995,7 +2995,8 @@
contentsRect = downcast(renderBox).videoBox();
else
#endif
-if (is(renderBox)) {
+
+if (is(renderBox) && !is(renderBox)) {
RenderReplaced& renderReplaced = downcast(renderBox);
contentsRect = renderReplaced.replacedContentRect();
} else
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294879] trunk
Title: [294879] trunk
Revision 294879
Author commit-qu...@webkit.org
Date 2022-05-26 09:16:12 -0700 (Thu, 26 May 2022)
Log Message
[GStreamer][WebRTC] Local/remote ICE candidates stats gathering support
https://bugs.webkit.org/show_bug.cgi?id=240949
Patch by Philippe Normand on 2022-05-26
Reviewed by Xabier Rodriguez-Calvar.
The corresponding feature was implemented in GStreamer as part of:
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1998
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp:
(WebCore::iceCandidateType):
(WebCore::fillRTCCandidateStats):
(WebCore::fillRTCCandidatePairStats):
(WebCore::fillReportCallback):
Canonical link: https://commits.webkit.org/251009@main
Modified Paths
trunk/LayoutTests/platform/glib/TestExpectations
trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp
Diff
Modified: trunk/LayoutTests/platform/glib/TestExpectations (294878 => 294879)
--- trunk/LayoutTests/platform/glib/TestExpectations 2022-05-26 16:01:38 UTC (rev 294878)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2022-05-26 16:16:12 UTC (rev 294879)
@@ -956,6 +956,9 @@
# Hits an ASSERT because we don't have a WebRTC provider handling WebRTC-related media-capabilities.
webkit.org/b/235885 [ Debug ] media/mediacapabilities/mock-encodingInfo.html [ Crash ]
+# Expected to pass with GStreamer 1.22.
+webkit.org/b/235885 webrtc/no-port-zero-in-upd-candidates.html [ Failure ]
+
#
# End of GStreamer-related bugs
#
Modified: trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp (294878 => 294879)
--- trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp 2022-05-26 16:01:38 UTC (rev 294878)
+++ trunk/Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp 2022-05-26 16:16:12 UTC (rev 294879)
@@ -22,7 +22,7 @@
#if ENABLE(WEB_RTC) && USE(GSTREAMER_WEBRTC)
-#include "GUniquePtrGStreamer.h"
+#include "GStreamerCommon.h"
#include "JSDOMMapLike.h"
#include "JSRTCStatsReport.h"
@@ -201,6 +201,75 @@
// stats.srtpCipher =
}
+static inline std::optional iceCandidateType(const String& type)
+{
+if (type == "host")
+return RTCIceCandidateType::Host;
+if (type == "srflx")
+return RTCIceCandidateType::Srflx;
+if (type == "prflx")
+return RTCIceCandidateType::Prflx;
+if (type == "relay")
+return RTCIceCandidateType::Relay;
+
+return { };
+}
+
+static inline void fillRTCCandidateStats(RTCStatsReport::IceCandidateStats& stats, GstWebRTCStatsType statsType, const GstStructure* structure)
+{
+stats.type = statsType == GST_WEBRTC_STATS_REMOTE_CANDIDATE ? RTCStatsReport::Type::RemoteCandidate : RTCStatsReport::Type::LocalCandidate;
+
+fillRTCStats(stats, structure);
+
+stats.transportId = String::fromLatin1(gst_structure_get_string(structure, "transport-id"));
+stats.address = String::fromLatin1(gst_structure_get_string(structure, "address"));
+stats.protocol = String::fromLatin1(gst_structure_get_string(structure, "protocol"));
+stats.url = "" "url"));
+
+unsigned port;
+if (gst_structure_get_uint(structure, "port", ))
+stats.port = port;
+
+auto candidateType = String::fromLatin1(gst_structure_get_string(structure, "candidate-type"));
+stats.candidateType = iceCandidateType(candidateType);
+
+uint64_t priority;
+if (gst_structure_get_uint64(structure, "priority", ))
+stats.priority = priority;
+}
+
+static inline void fillRTCCandidatePairStats(RTCStatsReport::IceCandidatePairStats& stats, const GstStructure* structure)
+{
+fillRTCStats(stats, structure);
+
+stats.localCandidateId = String::fromLatin1(gst_structure_get_string(structure, "local-candidate-id"));
+stats.remoteCandidateId = String::fromLatin1(gst_structure_get_string(structure, "remote-candidate-id"));
+
+// FIXME
+// stats.transportId =
+// stats.state =
+// stats.priority =
+// stats.nominated =
+// stats.writable =
+// stats.readable =
+// stats.bytesSent =
+// stats.bytesReceived =
+// stats.totalRoundTripTime =
+// stats.currentRoundTripTime =
+// stats.availableOutgoingBitrate =
+// stats.availableIncomingBitrate =
+// stats.requestsReceived =
+// stats.requestsSent =
+// stats.responsesReceived =
+// stats.responsesSent =
+// stats.retransmissionsReceived =
+// stats.retransmissionsSent =
+// stats.consentRequestsReceived =
+// stats.consentRequestsSent =
+// stats.consentResponsesReceived =
+// stats.consentResponsesSent =
+}
+
static gboolean fillReportCallback(GQuark, const GValue* value, gpointer userData)
{
if
[webkit-changes] [294878] trunk
Title: [294878] trunk Revision 294878 Author andresg...@apple.com Date 2022-05-26 09:01:38 -0700 (Thu, 26 May 2022) Log Message AX: Refactor implementation of AX object relationships. https://bugs.webkit.org/show_bug.cgi?id=240842 Reviewed by Chris Fleizach and Tyler Wilcock. Test: accessibility/grid-with-aria-owned-cells.html Relationships between AX objects were being computed by the methods AccessibilityObject::ariaElementsFromAttribute and ariaElementsReferencedByAttribute, both of which performed walks of the DOM tree to match ids between origin and target of a specific relationship, having a significant performance impact when called repeatedly. With this patch, these two methods are replaced with a single method, AccessibilityObject::relatedObjects, that in turn calls AXObjectCache::relatedObjectsFor. This AXObjectCache method computes and caches all relationships in one walk of the DoM tree. The cache is updated when relevant event notifications are received. This makes support of relationships between objects more efficient, and the code clearer. The test added exercises this implementation of relationships via the aria-owns attribute to relate table rows to their cells. The execution time of this test before this change was estimated in one system at about 1.91s, and after the change was reduced to 1.87s. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::objectsForIDs const): (WebCore::AXObjectCache::handleActiveDescendantChanged): (WebCore::AXObjectCache::handleAttributeChange): (WebCore::AXObjectCache::relationAttributes): (WebCore::AXObjectCache::symmetricRelation): (WebCore::AXObjectCache::attributeToRelationType): (WebCore::AXObjectCache::addRelation): (WebCore::AXObjectCache::updateRelationsIfNeeded): (WebCore::AXObjectCache::relatedObjectsFor): * Source/WebCore/accessibility/AXObjectCache.h: (WebCore::AXObjectCache::relationsNeedUpdate): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::relatedObjects const): (WebCore::AccessibilityObject::activeDescendantOfObjects const): (WebCore::AccessibilityObject::controlledObjects const): (WebCore::AccessibilityObject::controllers const): (WebCore::AccessibilityObject::describedByObjects const): (WebCore::AccessibilityObject::descriptionForObjects const): (WebCore::AccessibilityObject::detailedByObjects const): (WebCore::AccessibilityObject::detailsForObjects const): (WebCore::AccessibilityObject::errorMessageObjects const): (WebCore::AccessibilityObject::errorMessageForObjects const): (WebCore::AccessibilityObject::flowToObjects const): (WebCore::AccessibilityObject::flowFromObjects const): (WebCore::AccessibilityObject::labelledByObjects const): (WebCore::AccessibilityObject::labelForObjects const): (WebCore::AccessibilityObject::ownedObjects const): (WebCore::AccessibilityObject::owners const): (WebCore::AccessibilityObject::ariaElementsFromAttribute const): Deleted. (WebCore::AccessibilityObject::ariaElementsReferencedByAttribute const): Deleted. * Source/WebCore/accessibility/AccessibilityObject.h: * Source/WebCore/accessibility/AccessibilityObjectInterface.h: (WebCore::Accessibility::findRelatedObjectInAncestry): * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::activeDescendant const): * Source/WebCore/accessibility/AccessibilityTableCell.cpp: (WebCore::AccessibilityTableCell::columnHeaders): * Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp: (WebCore::AccessibilityObjectAtspi::relationMap const): * Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): (-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]): * LayoutTests/accessibility/grid-with-aria-owned-cells-expected.txt: Added. * LayoutTests/accessibility/grid-with-aria-owned-cells.html: Added. Canonical link: https://commits.webkit.org/251008@main Modified Paths trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/accessibility/AXObjectCache.cpp trunk/Source/WebCore/accessibility/AXObjectCache.h trunk/Source/WebCore/accessibility/AccessibilityObject.cpp trunk/Source/WebCore/accessibility/AccessibilityObject.h trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp trunk/Source/WebCore/accessibility/AccessibilityTableCell.cpp trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm Added Paths trunk/LayoutTests/accessibility/grid-with-aria-owned-cells-expected.txt trunk/LayoutTests/accessibility/grid-with-aria-owned-cells.html Diff Added: trunk/LayoutTests/accessibility/grid-with-aria-owned-cells-expected.txt (0 => 294878) --- trunk/LayoutTests/accessibility/grid-with-aria-owned-cells-expected.txt (rev 0) +++
[webkit-changes] [294877] trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ ContextMtl.mm
Title: [294877] trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm
Revision 294877
Author commit-qu...@webkit.org
Date 2022-05-26 07:00:35 -0700 (Thu, 26 May 2022)
Log Message
Uniform buffer reuse causes flush, creates invalid state
https://bugs.webkit.org/show_bug.cgi?id=240896
Patch by Kimmo Kinnunen on 2022-05-26
Patch by Kyle Piddington.
Reviewed by Kimmo Kinnunen.
A flush during draw setup would leave the render command encoder
not started and render pipeline unset. This would assert in debug
and leak memory with corrupted draws in release.
This would happen for example when uniform buffer pool would run
out of uniform memory. If the pool is maxed out, we flush the
existing rendering to obtain free buffers. After the flush,
we need to re-run the setup.
Test is tracked in bug 240948.
* Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:
(rx::ContextMtl::setupDraw):
(rx::ContextMtl::setupDrawImpl):
Canonical link: https://commits.webkit.org/251007@main
Modified Paths
trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm
Diff
Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm (294876 => 294877)
--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm 2022-05-26 12:13:28 UTC (rev 294876)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm 2022-05-26 14:00:35 UTC (rev 294877)
@@ -2216,6 +2216,32 @@
const void *indices,
bool xfbPass)
{
+ANGLE_TRY(setupDrawImpl(context, mode, firstVertex, vertexOrIndexCount, instances,
+indexTypeOrNone, indices, xfbPass));
+if (!mRenderEncoder.valid())
+{
+// Flush occurred during setup, due to running out of memory while setting up the render
+// pass state. This would happen for example when there is no more space in the uniform
+// buffers in the uniform buffer pool. The rendering would be flushed to free the uniform
+// buffer memory for new usage. In this case, re-run the setup.
+ANGLE_TRY(setupDrawImpl(context, mode, firstVertex, vertexOrIndexCount, instances,
+indexTypeOrNone, indices, xfbPass));
+// Setup with flushed state should either produce a working encoder or fail with an error
+// result.
+ASSERT(mRenderEncoder.valid());
+}
+return angle::Result::Continue;
+}
+
+angle::Result ContextMtl::setupDrawImpl(const gl::Context *context,
+gl::PrimitiveMode mode,
+GLint firstVertex,
+GLsizei vertexOrIndexCount,
+GLsizei instances,
+gl::DrawElementsType indexTypeOrNone,
+const void *indices,
+bool xfbPass)
+{
ASSERT(mProgram);
// instances=0 means no instanced draw.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294876] trunk/LayoutTests/platform/win/fast/css3-text/ css3-text-decoration/getComputedStyle/
Title: [294876] trunk/LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/ Revision 294876 Author n...@apple.com Date 2022-05-26 05:13:28 -0700 (Thu, 26 May 2022) Log Message [Windows] Remove obsolete css3-text-decoration test results https://bugs.webkit.org/show_bug.cgi?id=240951 Unreviewed test gardening. * LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt: Removed. * LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-style-expected.txt: Removed. Canonical link: https://commits.webkit.org/251006@main Removed Paths trunk/LayoutTests/platform/win/fast/css3-text/css3-text-decoration/getComputedStyle/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294875] trunk
Title: [294875] trunk
Revision 294875
Author tyle...@apple.com
Date 2022-05-26 04:40:09 -0700 (Thu, 26 May 2022)
Log Message
AccessibilityTable::m_isExposable is never recomputed after AccessibilityTable::init
https://bugs.webkit.org/show_bug.cgi?id=240750
Reviewed by Andres Gonzalez.
AccessibilityTable::m_isExposable is never recomputed after
AccessibilityTable::init. This is bad because the semantics of table,
and the semantics of the table cells in the table, are dependent on
whether the table is exposed.
With this commit, we recompute m_isExposable when a table's row count
changes. This commit also updates the isolated tree for row count
changes, meaning we handle dynamic aria-rowcount value modifications.
Test: accessibility/table-exposure-updates-dynamically.html.
Also added another testcase to accessibility/aria-table-attributes.html.
* LayoutTests/accessibility/aria-table-attributes-expected.txt:
* LayoutTests/accessibility/aria-table-attributes.html: Add testcase.
* LayoutTests/accessibility/table-exposure-updates-dynamically-expected.txt: Added.
* LayoutTests/accessibility/table-exposure-updates-dynamically.html: Added.
* LayoutTests/platform/glib/accessibility/table-exposure-updates-dynamically-expected.txt: Added.
* LayoutTests/platform/ios/TestExpectations: Enable new test.
* LayoutTests/platform/ios/accessibility/table-exposure-updates-dynamically-expected.txt: Added.
* LayoutTests/platform/win/TestExpectations: Disable new test.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::handleRowCountChanged): Added.
(WebCore::AXObjectCache::handleAriaExpandedChange):
(WebCore::AXObjectCache::handleAttributeChange):
(WebCore::filterWeakHashSetForRemoval):
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::updateIsolatedTree):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::recomputeIsExposable): Added.
(WebCore::AccessibilityTable::updateChildrenRoles): Added.
(WebCore::AccessibilityTable::addChildren):
* Source/WebCore/accessibility/AccessibilityTable.h:
* Source/WebCore/html/HTMLTablePartElement.h:
Moved findParentTable from protected to public so it can be called from
accessibility code.
Canonical link: https://commits.webkit.org/251005@main
Modified Paths
trunk/LayoutTests/accessibility/aria-table-attributes-expected.txt
trunk/LayoutTests/accessibility/aria-table-attributes.html
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h
trunk/Source/WebCore/accessibility/AccessibilityTable.cpp
trunk/Source/WebCore/accessibility/AccessibilityTable.h
trunk/Source/WebCore/html/HTMLTablePartElement.h
Added Paths
trunk/LayoutTests/accessibility/table-exposure-updates-dynamically-expected.txt
trunk/LayoutTests/accessibility/table-exposure-updates-dynamically.html
trunk/LayoutTests/platform/glib/accessibility/table-exposure-updates-dynamically-expected.txt
trunk/LayoutTests/platform/ios/accessibility/table-exposure-updates-dynamically-expected.txt
Diff
Modified: trunk/LayoutTests/accessibility/aria-table-attributes-expected.txt (294874 => 294875)
--- trunk/LayoutTests/accessibility/aria-table-attributes-expected.txt 2022-05-26 11:05:03 UTC (rev 294874)
+++ trunk/LayoutTests/accessibility/aria-table-attributes-expected.txt 2022-05-26 11:40:09 UTC (rev 294875)
@@ -1,22 +1,21 @@
This tests that attributes related to aria table/grid are working correctly.
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+PASS: grid.numberAttributeValue('AXARIAColumnCount') === 16
+PASS: grid.numberAttributeValue('AXARIARowCount') === 30
+PASS: grid.rowCount === 4
+PASS: grid.columnCount === 4
+PASS: cell1.numberAttributeValue('AXARIAColumnIndex') === 2
+PASS: cell1.numberAttributeValue('AXARIARowIndex') === 7
+PASS: cell2.numberAttributeValue('AXARIAColumnIndex') === 4
+PASS: cell2.numberAttributeValue('AXARIARowIndex') === 8
+PASS: cell4.numberAttributeValue('AXARIAColumnIndex') === 3
+PASS: cell2.rowIndexRange() === '{1, 2}'
+PASS: cell5.columnIndexRange() === '{2, 3}'
+PASS: cell3.rowIndexRange() === '{1, 2}'
+PASS: cell6.rowIndexRange() === '{0, 2}'
+PASS: cell7.rowIndexRange() === '{0, 2}'
+PASS: #grid AXARIARowCount dynamically changed to 60.
-
-PASS grid.numberAttributeValue('AXARIAColumnCount') is 16
-PASS grid.numberAttributeValue('AXARIARowCount') is 30
-PASS grid.rowCount is 4
-PASS grid.columnCount is 4
-PASS cell1.numberAttributeValue('AXARIAColumnIndex') is 2
-PASS cell1.numberAttributeValue('AXARIARowIndex') is 7
-PASS cell2.numberAttributeValue('AXARIAColumnIndex') is 4
-PASS cell2.numberAttributeValue('AXARIARowIndex') is 8
-PASS
[webkit-changes] [294874] trunk/Source/WebCore/platform/graphics/gstreamer/ DMABufVideoSinkGStreamer.cpp
Title: [294874] trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp
Revision 294874
Author commit-qu...@webkit.org
Date 2022-05-26 04:05:03 -0700 (Thu, 26 May 2022)
Log Message
[GStreamear] DMABufVideoSink can already handle Y41B
https://bugs.webkit.org/show_bug.cgi?id=240946
Patch by Žan Doberšek on 2022-05-26
Reviewed by Philippe Normand.
In GStreamer-specific DMABufVideoSink, Y41B multi-planar format was listed as
problematic and not included in the list of formats that are supported by
default. In reality, it's handled properly already and works, so it's moved over
to the list of supported formats.
* Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp:
Canonical link: https://commits.webkit.org/251004@main
Modified Paths
trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp
Diff
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp (294873 => 294874)
--- trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp 2022-05-26 08:13:02 UTC (rev 294873)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp 2022-05-26 11:05:03 UTC (rev 294874)
@@ -43,11 +43,11 @@
GST_DEBUG_CATEGORY_STATIC(webkit_dmabuf_video_sink_debug);
#define GST_CAT_DEFAULT webkit_dmabuf_video_sink_debug
-#define GST_WEBKIT_DMABUF_SINK_CAPS_FORMAT_LIST "{ RGBA, RGBx, BGRA, BGRx, I420, YV12, A420, NV12, NV12, Y444, Y42B, VUYA }"
+#define GST_WEBKIT_DMABUF_SINK_CAPS_FORMAT_LIST "{ RGBA, RGBx, BGRA, BGRx, I420, YV12, A420, NV12, NV12, Y444, Y41B, Y42B, VUYA }"
static GstStaticPadTemplate sinkTemplate = GST_STATIC_PAD_TEMPLATE("sink", GST_PAD_SINK, GST_PAD_ALWAYS, GST_STATIC_CAPS_ANY);
// TODO: this is a list of remaining YUV formats we want to support, but don't currently work (due to improper handling in TextureMapper):
-// YUY2, YVYU, UYVY, VYUY, AYUV, Y41B
+// YUY2, YVYU, UYVY, VYUY, AYUV
#define webkit_dmabuf_video_sink_parent_class parent_class
WEBKIT_DEFINE_TYPE_WITH_CODE(WebKitDMABufVideoSink, webkit_dmabuf_video_sink, GST_TYPE_BIN,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294872] trunk/Tools/Scripts/update-angle
Title: [294872] trunk/Tools/Scripts/update-angle
Revision 294872
Author commit-qu...@webkit.org
Date 2022-05-25 23:58:23 -0700 (Wed, 25 May 2022)
Log Message
Generate better ChangeLogs in update-angle script
https://bugs.webkit.org/show_bug.cgi?id=238649
Patch by Kenneth Russell on 2022-05-25
Auto-generate the preferred commit message format during ANGLE rolls
into a commit-message.txt file.
Reviewed by Kimmo Kinnunen.
* Tools/Scripts/update-angle:
Canonical link: https://commits.webkit.org/251002@main
Modified Paths
trunk/Tools/Scripts/update-angle
Diff
Modified: trunk/Tools/Scripts/update-angle (294871 => 294872)
--- trunk/Tools/Scripts/update-angle 2022-05-26 06:08:03 UTC (rev 294871)
+++ trunk/Tools/Scripts/update-angle 2022-05-26 06:58:23 UTC (rev 294872)
@@ -121,6 +121,13 @@
echo "Press Enter to continue after fixing build:"
read -r
regenerate_changes_diff "origin/main"
+echo "Generating contents of commit message into commit-message.txt."
+echo "Be sure to copy out this file's contents and delete it before committing."
+echo "Update ANGLE to $(git log -1 ${COMMIT_HASH} --format=%cs) (${COMMIT_HASH}))" > commit-message.txt
+echo "" >> commit-message.txt
+echo "Contains upstream commits:" >> commit-message.txt
+echo git log --oneline "$PREVIOUS_ANGLE_COMMIT_HASH".."$COMMIT_HASH" --pretty="%h %s" >> commit-message.txt
+git log --oneline "$PREVIOUS_ANGLE_COMMIT_HASH".."$COMMIT_HASH" --pretty="%h %s" >> commit-message.txt
echo "Removing temporary git repository from Source/ThirdParty/ANGLE"
rm -rf .git
git add -A .
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [294871] trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
Title: [294871] trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
Revision 294871
Author commit-qu...@webkit.org
Date 2022-05-25 23:08:03 -0700 (Wed, 25 May 2022)
Log Message
[Soup] USE(SOUP2) build fix after 250730@main
https://bugs.webkit.org/show_bug.cgi?id=240943
Patch by Žan Doberšek on 2022-05-25
Unreviewed build fix for USE(SOUP2), switching to string literals in a couple of
places where URL::protocolIs() is expecting them.
* Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::authenticateCallback):
(WebKit::NetworkDataTaskSoup::didStartRequest):
Canonical link: https://commits.webkit.org/251001@main
Modified Paths
trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
Diff
Modified: trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp (294870 => 294871)
--- trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2022-05-26 05:36:21 UTC (rev 294870)
+++ trunk/Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp 2022-05-26 06:08:03 UTC (rev 294871)
@@ -657,7 +657,7 @@
// it's proxy authentication and the request URL is HTTPS, because in that case libsoup uses a
// tunnel internally and the SoupMessage used for the authentication is the tunneling one.
// See https://bugs.webkit.org/show_bug.cgi?id=175378.
-if (soupMessage != task->m_soupMessage.get() && (soupMessage->status_code != SOUP_STATUS_PROXY_AUTHENTICATION_REQUIRED || !task->m_currentRequest.url().protocolIs("https")))
+if (soupMessage != task->m_soupMessage.get() && (soupMessage->status_code != SOUP_STATUS_PROXY_AUTHENTICATION_REQUIRED || !task->m_currentRequest.url().protocolIs("https"_s)))
return;
if (task->state() == State::Canceling || task->state() == State::Completed || !task->m_client) {
@@ -1636,7 +1636,7 @@
{
#if USE(SOUP2)
m_networkLoadMetrics.requestStart = MonotonicTime::now();
-if (!m_networkLoadMetrics.secureConnectionStart && m_currentRequest.url().protocolIs("https"))
+if (!m_networkLoadMetrics.secureConnectionStart && m_currentRequest.url().protocolIs("https"_s))
m_networkLoadMetrics.secureConnectionStart = WebCore::reusedTLSConnectionSentinel;
#else
auto* metrics = soup_message_get_metrics(m_soupMessage.get());
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
