[webkit-changes] [WebKit/WebKit] 19c5bd: pral.com.pk - Double bounce animation compared to ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 19c5bd914bfa1fb024e81ef201480315edd4bb7d https://github.com/WebKit/WebKit/commit/19c5bd914bfa1fb024e81ef201480315edd4bb7d Author: Antoine Quint Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/shadow-root-insertion-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/shadow-root-insertion.html M Source/WebCore/dom/Element.cpp M Source/WebCore/rendering/updating/RenderTreeUpdater.cpp M Source/WebCore/rendering/updating/RenderTreeUpdater.h Log Message: --- pral.com.pk - Double bounce animation compared to other browsers https://bugs.webkit.org/show_bug.cgi?id=273364 rdar://127188948 Reviewed by Antti Koivisto. The site pral.com.pk has a list of images under their "ISO CERTIFICATIONS" section that are badges with text rendered within the raster image. Those images run a transition when hovered. After a short while, the transition is restarted, and this only happens in Safari, and only the first time a given image is hovered. WebKit in Safari supports text recognition within images, performed asynchronously, and when text is detected a user-agent shadow root is inserted within the element to show additional UI. The addition of a shadow root triggers a full renderer rebuild and this has the side effect of canceling all running style-originated animations on that element. This explains why the transition appears to restart, because the initial transition is canceled once text recognition succeeds, and since the cursor is still over the image, a new transition immediately starts. Since the user-agent shadow root remains attached, hovering over the image a second time does not exhibit the behavior. We fixed a similar issue in the past with 240582@main to deal with a slot change while a transition is running on an element and introduced a dedicated `TeardownType` value that distinguishes a full rebuild from a rebuild resulting from a slot change. We follow the same approach for the case where a shadow root is inserted, adding a new `tearDownRenderersForShadowRootInsertion()` method which will call the same logic as `tearDownRenderersAfterSlotChange()`, with an inverse assertion as to whether the provided element has a shadow root attached. This prompted some refactoring of `tearDownRenderers()` as well since there is a lot of shared code with the aforementioned methods. We test this with a new WPT test that would fail prior to this change but already works in Chrome and Firefox. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/shadow-root-insertion-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/shadow-root-insertion.html: Added. * Source/WebCore/dom/Element.cpp: (WebCore::Element::addShadowRoot): * Source/WebCore/rendering/updating/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::tearDownRenderers): (WebCore::RenderTreeUpdater::tearDownRenderersForShadowRootInsertion): (WebCore::RenderTreeUpdater::tearDownRenderersAfterSlotChange): * Source/WebCore/rendering/updating/RenderTreeUpdater.h: Canonical link: https://commits.webkit.org/278156@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85a241: inputNormalizeEdgesTransparent blur isn't availabl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85a241ca1e5f23b30574ccfa51d54f17b6e3932a https://github.com/WebKit/WebKit/commit/85a241ca1e5f23b30574ccfa51d54f17b6e3932a Author: Matt Woodrow Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h M Source/WebCore/platform/graphics/ca/PlatformCAFilters.h M Source/WebCore/platform/graphics/ca/PlatformCALayer.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm M Source/WebKit/Shared/RemoteLayerTree/LayerProperties.h M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in M Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm Log Message: --- inputNormalizeEdgesTransparent blur isn't available on all platforms. https://bugs.webkit.org/show_bug.cgi?id=273280 Reviewed by Darin Adler. We currently try to set this everywhere, but the key isn't always available. We should use inputHardEdges instead, but since this looks worse, we should try to use inputNormalizeEdges when we know the blurred area is opaque. This detects when the layer that establishes a backdrop root also has an opaque background color, and passes that down to descendants in order to pick the right blur mode. * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateBackdropFilters): (WebCore::GraphicsLayerCA::updateBackdropRoot): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * Source/WebCore/platform/graphics/ca/PlatformCAFilters.h: * Source/WebCore/platform/graphics/ca/PlatformCALayer.h: * Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm: (WebCore::PlatformCAFilters::setFiltersOnLayer): * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.h: * Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: (WebCore::PlatformCALayerCocoa::setBackdropRootIsOpaque): (WebCore::PlatformCALayerCocoa::setFilters): * Source/WebKit/Shared/RemoteLayerTree/LayerProperties.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.h: * Source/WebKit/UIProcess/RemoteLayerTree/RemoteAcceleratedEffectStack.mm: (WebKit::RemoteAcceleratedEffectStack::applyEffectsFromMainThread const): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.h: (WebKit::RemoteLayerTreeNode::backdropRootIsOpaque const): (WebKit::RemoteLayerTreeNode::setBackdropRootIsOpaque): * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeNode.mm: (WebKit::RemoteLayerTreeNode::setAcceleratedEffectsAndBaseValues): * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm: (WebKit::RemoteScrollingCoordinatorProxyIOS::updateAnimations): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.mm: (WebKit::PlatformCALayerRemote::setBackdropRootIsOpaque): Canonical link: https://commits.webkit.org/278155@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b134d3: [@starting-style] Fix double whitespace in seriali...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b134d32eb7db41231e46c100adef1169ef0fd3fa https://github.com/WebKit/WebKit/commit/b134d32eb7db41231e46c100adef1169ef0fd3fa Author: Tim Nguyen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/starting-style-parsing-expected.txt M Source/WebCore/css/CSSStartingStyleRule.cpp Log Message: --- [@starting-style] Fix double whitespace in serialization https://bugs.webkit.org/show_bug.cgi?id=273438 rdar://127257305 Reviewed by Cameron McCormack. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/starting-style-parsing-expected.txt: * Source/WebCore/css/CSSStartingStyleRule.cpp: (WebCore::CSSStartingStyleRule::cssText const): Canonical link: https://commits.webkit.org/278154@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 511e5f: Reduce use of `const char*` in
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 511e5fff44f9949be51d903a8d1f9c851d2864e0 https://github.com/WebKit/WebKit/commit/511e5fff44f9949be51d903a8d1f9c851d2864e0 Author: Chris Dumez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/JavaScriptCore/runtime/JSDateMath.cpp M Source/WTF/wtf/DateMath.cpp M Source/WTF/wtf/DateMath.h M Source/WebCore/platform/network/HTTPParsers.cpp M Source/WebCore/platform/network/curl/CookieUtil.cpp Log Message: --- Reduce use of `const char*` in https://bugs.webkit.org/show_bug.cgi?id=273409 Reviewed by Darin Adler. Reduce use of `const char*` in by leveraging std::span. * Source/JavaScriptCore/runtime/JSDateMath.cpp: (JSC::DateCache::parseDate): * Source/WTF/wtf/DateMath.cpp: (WTF::skipSpacesAndComments): (WTF::findMonth): (WTF::parseInt): (WTF::parseLong): (WTF::parseDate): (WTF::parseDateFromNullTerminatedCharacters): Deleted. * Source/WTF/wtf/DateMath.h: * Source/WebCore/platform/network/HTTPParsers.cpp: (WebCore::parseHTTPDate): * Source/WebCore/platform/network/curl/CookieUtil.cpp: (WebCore::CookieUtil::parseExpiresMS): (WebCore::CookieUtil::parseCookieAttributes): Canonical link: https://commits.webkit.org/278153@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 51e313: Unreviewed follow-up after 278147@main to address ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 51e313829329fd5ec144c1ff0f83f7b907e7e573 https://github.com/WebKit/WebKit/commit/51e313829329fd5ec144c1ff0f83f7b907e7e573 Author: Chris Dumez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebKit/Shared/API/c/cf/WKStringCF.mm Log Message: --- Unreviewed follow-up after 278147@main to address Sihui Liu's comment. * Source/WebKit/Shared/API/c/cf/WKStringCF.mm: (WKStringCopyCFString): Canonical link: https://commits.webkit.org/278152@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 01fe68: [Site Isolation] Text input does not work
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 01fe68213aaa7c7a430e853ba16b59969aca04c6 https://github.com/WebKit/WebKit/commit/01fe68213aaa7c7a430e853ba16b59969aca04c6 Author: Charlie Wolfe Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebCore/editing/Editor.cpp Log Message: --- [Site Isolation] Text input does not work https://bugs.webkit.org/show_bug.cgi?id=273432 rdar://127252787 Reviewed by Pascoe. `shouldSuppressTextInputFromEditing` suppresses text input while the main frame is in a provisional load state. With site isolation, iframe processes do not know the load state of the main frame. This feature will need to be rethought to make it work with site isolation. For now, disable it in isolated iframes to get text input to work. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebCore/editing/Editor.cpp: (WebCore::Editor::shouldInsertText const): Canonical link: https://commits.webkit.org/278151@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 58ebd2: Opener relationship should be preserved when switc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 58ebd2f088d76f1a8b5d7b502a1d303a7f955256 https://github.com/WebKit/WebKit/commit/58ebd2f088d76f1a8b5d7b502a1d303a7f955256 Author: Alex Christensen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/history/CachedFrame.cpp M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/LocalFrameLoaderClient.h M Source/WebCore/loader/PolicyChecker.cpp M Source/WebCore/page/Frame.cpp M Source/WebCore/page/Frame.h M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h M Source/WebCore/page/RemoteFrame.cpp M Source/WebCore/page/RemoteFrame.h M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Opener relationship should be preserved when switching between local and remote frames for site isolation https://bugs.webkit.org/show_bug.cgi?id=273433 rdar://127253523 Reviewed by Charlie Wolfe. This moves the owner pointer and the set of opened pages from FrameLoader and RemoteFrame to Frame so that the management of those two related structures can be shared between LocalFrame and RemoteFrame. I then update the pointer and set when switching from a LocalFrame to a RemoteFrame and when switching from a RemoteFrame to a LocalFrame. Covered by an API test, which not only tests that the opener is unchanged after these transitions, but it also tests other types of provisional navigation failures with site isolation: navigating to the same domain, and navigating to a new domain that has never been seen before. * Source/WebCore/dom/Document.cpp: (WebCore::Document::fallbackBaseURL const): (WebCore::Document::canNavigateInternal): (WebCore::Document::initSecurityContext): (WebCore::Document::initContentSecurityPolicy): * Source/WebCore/history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): * Source/WebCore/inspector/InspectorFrontendClientLocal.cpp: (WebCore::InspectorFrontendClientLocal::openURLExternally): * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::doCrossOriginOpenerHandlingOfResponse): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::~FrameLoader): (WebCore::shouldClearWindowName): (WebCore::FrameLoader::hasOpenedFrames const): (WebCore::FrameLoader::setOriginalURLForDownloadRequest): (WebCore::FrameLoader::updateRequestAndAddExtraFields): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::effectiveReferrerPolicy const): (WebCore::FrameLoader::switchBrowsingContextsGroup): (WebCore::FrameLoader::detachFromAllOpenedFrames): Deleted. (WebCore::FrameLoader::opener): Deleted. (WebCore::FrameLoader::opener const): Deleted. (WebCore::FrameLoader::setOpener): Deleted. * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/LocalFrameLoaderClient.h: * Source/WebCore/loader/PolicyChecker.cpp: (WebCore::FrameLoader::PolicyChecker::checkNavigationPolicy): * Source/WebCore/page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::setOpener): (WebCore::Frame::detachFromAllOpenedFrames): (WebCore::Frame::openedFrames): (WebCore::Frame::hasOpenedFrames const): * Source/WebCore/page/Frame.h: (WebCore::Frame::opener const): (WebCore::Frame::opener): * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::focus): (WebCore::LocalDOMWindow::disownOpener): * Source/WebCore/page/LocalFrame.cpp: (WebCore::LocalFrame::LocalFrame): (WebCore::LocalFrame::reinitializeDocumentSecurityContext): (WebCore::LocalFrame::disconnectView): (WebCore::LocalFrame::setOpener): Deleted. (WebCore::LocalFrame::opener const): Deleted. (WebCore::LocalFrame::opener): Deleted. * Source/WebCore/page/LocalFrame.h: * Source/WebCore/page/RemoteFrame.cpp: (WebCore::RemoteFrame::createSubframe): (WebCore::RemoteFrame::createSubframeWithContentsInAnotherProcess): (WebCore::RemoteFrame::RemoteFrame): * Source/WebCore/page/RemoteFrame.h: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameClearOpener): * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): * Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
[webkit-changes] [WebKit/WebKit] 40a587: [WebXR] Fixes due to Update ANGLE to 2024-04-26
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40a587be57369f415bf7ed68ecc2f0354bdd90de https://github.com/WebKit/WebKit/commit/40a587be57369f415bf7ed68ecc2f0354bdd90de Author: Dan Glastonbury Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm Log Message: --- [WebXR] Fixes due to Update ANGLE to 2024-04-26 https://bugs.webkit.org/show_bug.cgi?id=273391 rdar://127219301 Reviewed by Cameron McCormack. Upstream ANGLE change for overriding internal image format for externally attached images will fail if EGL_TEXTURE_INTERNAL_FORMAT_ANGLE is EGL_NONE. Change createExternalImage to skip passing EGL_TEXTURE_INTERNAL_FORMAT_ANGLE if EGL_NONE is passed for internalFormat. * Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm: (WebCore::GraphicsContextGLCocoa::createExternalImage): Canonical link: https://commits.webkit.org/278149@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 159f9e: [JSC] JIT stub should hold Watchpoint and Watchpoi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 159f9e46d6bb256c1de1ed39f66935ccaf987734 https://github.com/WebKit/WebKit/commit/159f9e46d6bb256c1de1ed39f66935ccaf987734 Author: Yusuke Suzuki Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h M Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.cpp M Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.h M Source/JavaScriptCore/bytecode/Watchpoint.h M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h Log Message: --- [JSC] JIT stub should hold Watchpoint and WatchpointSet https://bugs.webkit.org/show_bug.cgi?id=273454 rdar://127262594 Reviewed by Keith Miller. Previously, our approach is 1. Collecting WatchpointSet throughout IC 2. Watch them and holding watchpoints in StructureStubInfo (or its owining data structures) 3. When WatchpointSet fires, clearing StructureStubInfo. Instead, the new approach is 1. Collecting WatchpointSet throughout IC 2. Watch them and holding watchpoints in IC JIT Stub 3. IC JIT Stub also holds WatchpointSet 4. StructureStubInfo watches (3)'s WatchpointSet instead. 5. When WatchpointSet fires, invalidating (3)'s IC JIT Stub's WatchpointSet. 6. Because of (5), WatchpointSet fires, and clearing StructureStubInfo. In this way, we can have one WatchpointSet managed by IC JIT Stub. And each *potentially multiple* StructureStubInfo can monitor this condition by inserting Watchpoint into this set. In this way, we can share one IC JIT Stub with multiple StructureStubInfo even if the IC has watchpoints. This is the work towards Handler IC. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheHandler::InlineCacheHandler): (JSC::m_watchpoint): (JSC::InlineCacheCompiler::generateImpl): (JSC::InlineCacheCompiler::regenerate): (JSC::m_watchpoints): Deleted. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.h: * Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.cpp: (JSC::StructureStubInfoClearingWatchpoint::fireInternal): (JSC::StructureTransitionStructureStubClearingWatchpoint::fireInternal): (JSC::WatchpointsOnStructureStubInfo::ensureReferenceAndInstallWatchpoint): (JSC::WatchpointsOnStructureStubInfo::ensureReferenceAndAddWatchpoint): (JSC::AdaptiveValueStructureStubClearingWatchpoint::handleFire): (JSC::WatchpointsOnStructureStubInfo::isValid const): Deleted. * Source/JavaScriptCore/bytecode/StructureStubClearingWatchpoint.h: * Source/JavaScriptCore/bytecode/Watchpoint.h: * Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp: (JSC::PolymorphicAccessJITStubRoutine::PolymorphicAccessJITStubRoutine): (JSC::PolymorphicAccessJITStubRoutine::setWatchpoints): (JSC::PolymorphicAccessJITStubRoutine::invalidate): * Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h: (JSC::PolymorphicAccessJITStubRoutine::watchpoints const): (JSC::PolymorphicAccessJITStubRoutine::watchpointSet): Canonical link: https://commits.webkit.org/278148@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d9f520: Regression(278082@main) Crash under WKStringCopyCF...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9f5208cd39357e9836ef9e5920f6ec1614b6c32 https://github.com/WebKit/WebKit/commit/d9f5208cd39357e9836ef9e5920f6ec1614b6c32 Author: Chris Dumez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebKit/Shared/API/c/cf/WKStringCF.mm Log Message: --- Regression(278082@main) Crash under WKStringCopyCFString() https://bugs.webkit.org/show_bug.cgi?id=273460 rdar://127262671 Reviewed by Darin Adler. API::String::string() returns a new value, using isolatedCopy(), which I wasn't expected. As a result, we need to store the result of API::String::string() in a local variable so that our span keeps pointing to valid memory. * Source/WebKit/Shared/API/c/cf/WKStringCF.mm: (WKStringCopyCFString): Canonical link: https://commits.webkit.org/278147@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c065ba: [ANGLE] Update ANGLE to 2024-04-26 (8332e5b10e4f37...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c065bad621ef6315cd418a41b67bf1427445d9c3 https://github.com/WebKit/WebKit/commit/c065bad621ef6315cd418a41b67bf1427445d9c3 Author: Dan Glastonbury Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/ThirdParty/ANGLE/ANGLE.plist M Source/ThirdParty/ANGLE/DEPS M Source/ThirdParty/ANGLE/WebKit/ANGLEShaderProgramVersion.h M Source/ThirdParty/ANGLE/WebKit/angle_commit.h M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/extensions/EGL_ANGLE_metal_texture_client_buffer.txt M Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h M Source/ThirdParty/ANGLE/include/platform/vk_features.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/GL_EGL_entry_points.json M Source/ThirdParty/ANGLE/scripts/generate_entry_points.py M Source/ThirdParty/ANGLE/scripts/roll_aosp.sh M Source/ThirdParty/ANGLE/src/libANGLE/State.cpp M Source/ThirdParty/ANGLE/src/libANGLE/State.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ImageMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLCommandQueueVk.cpp M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLCommandQueueVk.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLContextVk.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/CLMemoryVk.h M Source/ThirdParty/ANGLE/src/libANGLE/renderer/vulkan/vk_renderer.cpp M Source/ThirdParty/ANGLE/src/libANGLE/validationEGL.cpp M Source/ThirdParty/ANGLE/src/libGLESv2/entry_points_egl_autogen.cpp M Source/ThirdParty/ANGLE/src/tests/gl_tests/ImageTestMetal.mm M Source/ThirdParty/ANGLE/util/autogen/angle_features_autogen.cpp M Source/ThirdParty/ANGLE/util/autogen/angle_features_autogen.h Log Message: --- [ANGLE] Update ANGLE to 2024-04-26 (8332e5b10e4f37bf20f63b0c0e8f8ddcae184b17) https://bugs.webkit.org/show_bug.cgi?id=273381 rdar://127211299 Reviewed by Kimmo Kinnunen Contains upstream commits: git log --oneline 6cfb593174d2f9d432386f4ea1fb587c9c395593..8332e5b10e4f37bf20f63b0c0e8f8ddcae184b17 --pretty=%h %s 8332e5b10e Use python3 instead of python for bootstrap b74de55781 Vulkan: Add a feature related to shader subsets d9a008755c Metal: Override internal format of images 89caa0e1d9 Cleanup: replace DirtyObjectType check with constexpr generator 5e37ae35f6 Roll vulkan-deps from a4bf9c4e9ffd to 736920240f0b (2 revisions) 884dc38077 EGL: Make eglGetCurrent(Context|Surface|Display) lockless. bea8d9dd8f Roll Chromium from ad99ecc02953 to 0129806a25c3 (372 revisions) c62c0c2500 CL/VK: Implement initial enqueueRead/WriteBuffer Canonical link: https://commits.webkit.org/278146@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 31988f: AX: Fix for accessibility/mac/area-with-aria-label...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 31988f49031dede5d9a7c245edb6d249c5ce34be https://github.com/WebKit/WebKit/commit/31988f49031dede5d9a7c245edb6d249c5ce34be Author: Andres Gonzalez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/accessibility-isolated-tree/TestExpectations M LayoutTests/accessibility/mac/area-with-aria-label-expected.txt M LayoutTests/accessibility/mac/area-with-aria-label.html Log Message: --- AX: Fix for accessibility/mac/area-with-aria-label.html in isolated tree mode. https://bugs.webkit.org/show_bug.cgi?id=273403 Reviewed by Tyler Wilcock. This test was failing in ITM due to asynchronicity of focus changes. Fixed and updated test to AX standards. * LayoutTests/accessibility-isolated-tree/TestExpectations: * LayoutTests/accessibility/mac/area-with-aria-label-expected.txt: * LayoutTests/accessibility/mac/area-with-aria-label.html: Canonical link: https://commits.webkit.org/278145@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 432988: REGRESSION (277958@main): [ macOS ASan GuardMalloc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4329889dd57ff859ecff6cf57f82c821ece9ff92 https://github.com/WebKit/WebKit/commit/4329889dd57ff859ecff6cf57f82c821ece9ff92 Author: Tim Nguyen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/dom/ViewTransition.cpp Log Message: --- REGRESSION (277958@main): [ macOS ASan GuardMalloc wk2 ] Multiple css-view-transitions tests are flaky crash https://bugs.webkit.org/show_bug.cgi?id=273451 rdar://127258163 Reviewed by Chris Dumez. Set `ViewTransition::m_phase` before `document->setActiveViewTransition(nullptr);` is called in `ViewTransition::clearViewTransition()` to prevent UAF. * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::stop): Canonical link: https://commits.webkit.org/278144@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2ac48: Re-import css/css-transitions WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2ac4828cf48421940986b2a73c003eb8f00643e https://github.com/WebKit/WebKit/commit/e2ac4828cf48421940986b2a73c003eb8f00643e Author: Tim Nguyen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-effect.tentative.html A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/starting-style-parsing-expected.txt A LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/starting-style-parsing.html M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/w3c-import.log M LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/w3c-import.log Log Message: --- Re-import css/css-transitions WPT https://bugs.webkit.org/show_bug.cgi?id=273439 rdar://127264296 Reviewed by Matt Woodrow. Upstream commit: https://github.com/web-platform-tests/wpt/commit/8c6b479fae23badbb86e9c993f5b5fbb66e16905 * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-effect.tentative.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/starting-style-parsing-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/starting-style-parsing.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/parsing/w3c-import.log: * LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/w3c-import.log: Canonical link: https://commits.webkit.org/278143@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 50602e: [MultiRep HEIC][iOS] Copy/paste results in quality...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 50602e4790301374e1134bbc4f564a4e5e90c097 https://github.com/WebKit/WebKit/commit/50602e4790301374e1134bbc4f564a4e5e90c097 Author: Aditya Keerthi Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/editing/cocoa/HTMLConverter.mm Log Message: --- [MultiRep HEIC][iOS] Copy/paste results in quality loss https://bugs.webkit.org/show_bug.cgi?id=273420 rdar://126719532 Reviewed by Wenson Hsieh. On iOS 17.4+, copying web content no longer writes RTF to the pasteboard. Instead, web archive data is written, and is only converted to RTF when pasting. In this scenario, there is no loaded image, only attachment data. Consequently, existing logic to create `WebMultiRepresentationHEICAttachment` is elided. Fix by updating `HTMLConverter::_addAttachmentForElement` to be aware of `WebMultiRepresentationHEICAttachment`. * Source/WebCore/editing/cocoa/HTMLConverter.mm: (HTMLConverter::_addAttachmentForElement): Canonical link: https://commits.webkit.org/278142@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b4139e: [Unified Text Replacement] Attributed string conve...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b4139ed0097c70e6ac9f4bce19b4830d90a0be97 https://github.com/WebKit/WebKit/commit/b4139ed0097c70e6ac9f4bce19b4830d90a0be97 Author: Aditya Keerthi Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/editing/WebContentReader.h M Source/WebCore/editing/cocoa/EditorCocoa.mm M Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm Log Message: --- [Unified Text Replacement] Attributed string conversion introduces unexpected newlines https://bugs.webkit.org/show_bug.cgi?id=273421 rdar://126644154 Reviewed by Ryosuke Niwa. Set "InterchangeNewlines" to `NO` for unified text replacement. Introduce `FragmentCreationOptions` to control behavior. * Source/WebCore/editing/WebContentReader.h: (WebCore::createFragment): * Source/WebCore/editing/cocoa/EditorCocoa.mm: (WebCore::Editor::replaceSelectionWithAttributedString): * Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm: (WebCore::createFragmentInternal): (WebCore::attributesForAttributedStringConversion): (WebCore::createFragment): (WebCore::WebContentReader::readRTFD): (WebCore::WebContentMarkupReader::readRTFD): (WebCore::WebContentReader::readRTF): (WebCore::WebContentMarkupReader::readRTF): * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange): Canonical link: https://commits.webkit.org/278141@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 768505: Writing suggestions sometimes show up in the middl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7685053aabfc692b2b35b2b6885eaa2af68da6ef https://github.com/WebKit/WebKit/commit/7685053aabfc692b2b35b2b6885eaa2af68da6ef Author: Richard Robinson Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: A LayoutTests/editing/input/mac/writing-suggestions-textarea-multiple-lines-expected.txt A LayoutTests/editing/input/mac/writing-suggestions-textarea-multiple-lines.html M LayoutTests/platform/mac-wk2/TestExpectations M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp Log Message: --- Writing suggestions sometimes show up in the middle of previous paragraphs in `textarea`s https://bugs.webkit.org/show_bug.cgi?id=273365 rdar://127129683 Reviewed by Wenson Hsieh. The logic that inserts the writing suggestions renderer was incorrectly assuming that the renderer which corresponds to the node before the writing suggestion would always just be the first text child node of the current renderer. While this is true for trivial `contenteditable` `div`s, which have several `RenderBlock`s, and one `RenderText` per block, this is not true for `textarea`s, which can and do have multiple `RenderText`s per block, nor is this true in the general case of arbitrary HTML. Since the node before the writing suggestions renderer is known already, its renderer is the correct one to use, and doesn't make any assumptions about the number of children of a renderer. * LayoutTests/editing/input/mac/writing-suggestions-textarea-multiple-lines-expected.txt: Added. * LayoutTests/editing/input/mac/writing-suggestions-textarea-multiple-lines.html: Added. * Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp: (WebCore::RenderTreeUpdater::GeneratedContent::updateWritingSuggestionsRenderer): Canonical link: https://commits.webkit.org/278140@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a66201: Fix PlayStation build with GPU Process
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a662016b2cd789c14f6c9fba394a84f058f1 https://github.com/WebKit/WebKit/commit/a662016b2cd789c14f6c9fba394a84f058f1 Author: Don Olmstead Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp M Source/WebKit/GPUProcess/playstation/GPUProcessMainPlayStation.cpp Log Message: --- Fix PlayStation build with GPU Process https://bugs.webkit.org/show_bug.cgi?id=273448 Reviewed by Fujii Hironori. Update based on changes since the last time it was turned on. * Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp: * Source/WebKit/GPUProcess/playstation/GPUProcessMainPlayStation.cpp: Canonical link: https://commits.webkit.org/278139@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 33843b: Drop WTF::debugString() as it encourages unsafe us...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 33843b7ab0c4763b811fe9cda6997abb71eb3c50 https://github.com/WebKit/WebKit/commit/33843b7ab0c4763b811fe9cda6997abb71eb3c50 Author: Chris Dumez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WTF/wtf/DebugUtilities.h M Source/WebCore/history/HistoryItem.cpp M Source/WebCore/history/HistoryItem.h M Source/WebKit/Shared/WebBackForwardListItem.cpp M Source/WebKit/Shared/WebBackForwardListItem.h M Source/WebKit/UIProcess/API/APINavigation.cpp M Source/WebKit/UIProcess/API/APINavigation.h M Source/WebKit/UIProcess/SuspendedPageProxy.cpp M Source/WebKit/UIProcess/SuspendedPageProxy.h M Source/WebKit/UIProcess/WebBackForwardList.cpp M Source/WebKit/UIProcess/WebBackForwardList.h M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- Drop WTF::debugString() as it encourages unsafe usage of `const char*` https://bugs.webkit.org/show_bug.cgi?id=273427 Reviewed by Ryosuke Niwa. * Source/WTF/wtf/DebugUtilities.h: (WTF::debugString): Deleted. * Source/WebCore/history/HistoryItem.cpp: (WebCore::HistoryItem::logString const): * Source/WebCore/history/HistoryItem.h: * Source/WebKit/Shared/WebBackForwardListItem.cpp: (WebKit::WebBackForwardListItem::loggingString): * Source/WebKit/Shared/WebBackForwardListItem.h: * Source/WebKit/UIProcess/API/APINavigation.cpp: (API::Navigation::loggingString const): * Source/WebKit/UIProcess/API/APINavigation.h: * Source/WebKit/UIProcess/SuspendedPageProxy.cpp: (WebKit::SuspendedPageProxy::didProcessRequestToSuspend): (WebKit::SuspendedPageProxy::loggingString const): * Source/WebKit/UIProcess/SuspendedPageProxy.h: * Source/WebKit/UIProcess/WebBackForwardList.cpp: (WebKit::WebBackForwardList::loggingString): * Source/WebKit/UIProcess/WebBackForwardList.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::suspendCurrentPageIfPossible): (WebKit::WebPageProxy::receivedNavigationActionPolicyDecision): (WebKit::WebPageProxy::continueNavigationInNewProcess): (WebKit::WebPageProxy::didCommitLoadForFrame): Canonical link: https://commits.webkit.org/278138@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e769ed: [Unified Text Replacement] Remove unused `WebTextR...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e769ed8cf322a2ae21245b424526c13bd62ecd21 https://github.com/WebKit/WebKit/commit/e769ed8cf322a2ae21245b424526c13bd62ecd21 Author: Richard Robinson Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebKit/Shared/UnifiedTextReplacement.serialization.in M Source/WebKit/Shared/WebTextReplacementData.h M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm Log Message: --- [Unified Text Replacement] Remove unused `WebTextReplacementData::State::Committed` enum case https://bugs.webkit.org/show_bug.cgi?id=273446 rdar://127235440 Reviewed by Abrar Rahman Protyasha. * Source/WebKit/Shared/UnifiedTextReplacement.serialization.in: * Source/WebKit/Shared/WebTextReplacementData.h: * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::textReplacementSessionDidUpdateStateForReplacement): Canonical link: https://commits.webkit.org/278137@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f8e2f4: ToPropertyKeyOrNumber incorrectly says it doesn't ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f8e2f45c2312e66f34db314a2ca054d0adaac66e https://github.com/WebKit/WebKit/commit/f8e2f45c2312e66f34db314a2ca054d0adaac66e Author: Keith Miller Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: A JSTests/stress/ToPropertyKeyOrNumber-AI-should-include-number.js M Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp Log Message: --- ToPropertyKeyOrNumber incorrectly says it doesn't return a number in AI https://bugs.webkit.org/show_bug.cgi?id=273429 rdar://127225001 Reviewed by Yusuke Suzuki. Right now ToPropertyKeyOrNumber falls through to ToPropertyKey, which says it always returns `SpecString | SpecSymbol`. This is obviously wrong. * JSTests/stress/ToPropertyKeyOrNumber-AI-should-include-number.js: Added. (opt.f): (opt): * Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter::executeEffects): * Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp: Canonical link: https://commits.webkit.org/278136@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4fd8e: Update isReachableFromOpaqueRoots to use ASCIILiteral
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4fd8e95f979f622b541e389f009180567836b1a https://github.com/WebKit/WebKit/commit/e4fd8e95f979f622b541e389f009180567836b1a Author: Chris Dumez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/JavaScriptCore/API/JSAPIWrapperObject.mm M Source/JavaScriptCore/API/JSManagedValue.mm M Source/JavaScriptCore/API/glib/JSAPIWrapperObjectGLib.cpp M Source/JavaScriptCore/heap/HeapAnalyzer.h M Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp M Source/JavaScriptCore/heap/HeapSnapshotBuilder.h M Source/JavaScriptCore/heap/WeakBlock.cpp M Source/JavaScriptCore/heap/WeakHandleOwner.cpp M Source/JavaScriptCore/heap/WeakHandleOwner.h M Source/JavaScriptCore/inspector/JSInjectedScriptHost.cpp M Source/JavaScriptCore/runtime/SimpleTypedArrayController.cpp M Source/JavaScriptCore/runtime/SimpleTypedArrayController.h M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/WebCore/bindings/js/JSAbortSignalCustom.cpp M Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp M Source/WebCore/bindings/js/JSCallbackData.cpp M Source/WebCore/bindings/js/JSCallbackData.h M Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp M Source/WebCore/bindings/js/JSDeprecatedCSSOMValueCustom.cpp M Source/WebCore/bindings/js/JSIntersectionObserverCustom.cpp M Source/WebCore/bindings/js/JSMutationObserverCustom.cpp M Source/WebCore/bindings/js/JSNodeCustom.cpp M Source/WebCore/bindings/js/JSNodeListCustom.cpp M Source/WebCore/bindings/js/JSOffscreenCanvasRenderingContext2DCustom.cpp M Source/WebCore/bindings/js/JSPaintRenderingContext2DCustom.cpp M Source/WebCore/bindings/js/JSPerformanceObserverCustom.cpp M Source/WebCore/bindings/js/JSResizeObserverCustom.cpp M Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp M Source/WebCore/bindings/js/JSUndoItemCustom.cpp M Source/WebCore/bindings/js/WebCoreTypedArrayController.cpp M Source/WebCore/bindings/js/WebCoreTypedArrayController.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp M Source/WebCore/bindings/scripts/test/JS/JSExposedToWorkerAndWindow.h M Source/WebCore/bindings/scripts/test/JS/JSShadowRealmGlobalScope.cpp M Source/WebCore/bindings/scripts/test/JS/JSShadowRealmGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncIterable.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncIterable.h M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncKeyValueIterable.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestAsyncKeyValueIterable.h M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactions.h M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestCEReactionsStringifier.h M Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestCallTracer.h M Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h M Source/WebCore/bindings/scripts/test/JS/JSTestConditionalIncludes.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestConditionalIncludes.h M Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestConditionallyReadWrite.h M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSON.h M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.h M Source/WebCore/bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDelegateToSharedSyntheticAttribute.h M Source/WebCore/bindings/scripts/test/JS/JSTestDomainSecurity.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestDomainSecurity.h M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySetting.h M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledForContext.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestEnabledForContext.h M Source/WebCore/bindings/scripts/test/JS/JSTestException.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestException.h M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.cpp M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateAddOpaqueRoot.h M Source/WebCore/bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp M
[webkit-changes] [WebKit/WebKit] eedb53: Unreviewed, speculative build fix
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eedb530e3d40833c95462b32c8f0372d4c7d2994 https://github.com/WebKit/WebKit/commit/eedb530e3d40833c95462b32c8f0372d4c7d2994 Author: Yusuke Suzuki Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/JavaScriptCore/runtime/ArrayPrototype.cpp Log Message: --- Unreviewed, speculative build fix https://bugs.webkit.org/show_bug.cgi?id=273450 rdar://127259897 * Source/JavaScriptCore/runtime/ArrayPrototype.cpp: Canonical link: https://commits.webkit.org/278134@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 63eb54: Add some root frame utility functions
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 63eb54f1aee4398784db80b00a80669cd679ef70 https://github.com/WebKit/WebKit/commit/63eb54f1aee4398784db80b00a80669cd679ef70 Author: Alex Christensen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/page/Frame.cpp M Source/WebCore/page/Frame.h M Source/WebCore/page/LocalFrame.cpp M Source/WebCore/page/LocalFrame.h Log Message: --- Add some root frame utility functions https://bugs.webkit.org/show_bug.cgi?id=273348 rdar://127142451 Reviewed by Simon Fraser. Frame has the ability to query if it is the main frame and the ability to quickly get the main frame without traversing the frame tree to find it. It does this by storing a WeakRef of the main frame and comparing or dereferencing it. This has been useful for many years. LocalFrame already had the ability to quickly query if it is a root frame. With site isolation off and all the frames in the same process, this is the same as being the main frame. With site isolation on, though, frames can be in different processes so a root frame is the root of a subtree of LocalFrames with either no parent (if it is also the main frame) or a RemoteFrame parent if its parent's contents are in another process. With https://github.com/WebKit/WebKit/pull/27300 we introduce the need to quickly get the root frame of a particular LocalFrame. We implement that in this PR the same way we have long ago with the main frame: by storing a WeakRef. In that same PR, we will benefit by having the ability to assert that a particular FrameIdentifier is from a root frame to prevent future developers from forgetting a call to rootFrame and messing up the scroll tree. For that purpose we introduce Frame::isRootFrameIdentifier which requires some extra bookkeeping that isn't necessary in release builds with ASSERT_ENABLED set to false. * Source/WebCore/page/Frame.cpp: (WebCore::allFrames): (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::isRootFrameIdentifier): * Source/WebCore/page/Frame.h: * Source/WebCore/page/LocalFrame.cpp: (WebCore::rootFrame): (WebCore::LocalFrame::LocalFrame): (WebCore::isRootFrame): Deleted. (WebCore::LocalFrame::isRootFrame const): Deleted. * Source/WebCore/page/LocalFrame.h: Canonical link: https://commits.webkit.org/278133@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40ce17: Use naming conventions for Font IPC
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40ce17e8ec3287c304383c2641ca0e2e4a7bebf9 https://github.com/WebKit/WebKit/commit/40ce17e8ec3287c304383c2641ca0e2e4a7bebf9 Author: Don Olmstead Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/FontPlatformData.h M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp M Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in Log Message: --- Use naming conventions for Font IPC https://bugs.webkit.org/show_bug.cgi?id=273422 Reviewed by Chris Dumez. Use `toIPCData` and `fromIPCData` when serializing `FontPlatformData`. This conforms with the updated naming conventions. Organize the code so other platforms can start generating serialization. * Source/WebCore/platform/graphics/FontPlatformData.h: * Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp: (WebCore::FontPlatformData::fromIPCData): (WebCore::FontPlatformData::toIPCData const): (WebCore::FontPlatformData::tryMakeFontPlatformData): Deleted. (WebCore::FontPlatformData::platformSerializationData const): Deleted. * Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/278132@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da29b1: Remove ProcessSwapOnCrossSiteWindowOpenEnabled pre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da29b1848a9aad67c70c48f9e1d289162b49d7fc https://github.com/WebKit/WebKit/commit/da29b1848a9aad67c70c48f9e1d289162b49d7fc Author: Alex Christensen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/FrameProcess.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebProcessPool.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- Remove ProcessSwapOnCrossSiteWindowOpenEnabled preference https://bugs.webkit.org/show_bug.cgi?id=273434 rdar://127254303 Reviewed by Pascoe. It was originally intended to turn on and off site isolation but only for window.open. It has become more and more closely tied to site isolation, and it is now only used to keep a few tests working. Those tests should just enable site isolation instead. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::ensureProcessForDomain): (WebKit::BrowsingContextGroup::ensureProcessForConnection): * Source/WebKit/UIProcess/FrameProcess.cpp: (WebKit::FrameProcess::FrameProcess): * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::initializeWebPage): (WebKit::ProvisionalPageProxy::didCreateMainFrame): (WebKit::ProvisionalPageProxy::didCommitLoadForFrame): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::suspendCurrentPageIfPossible): (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::commitProvisionalPage): (WebKit::WebPageProxy::shouldClosePreviousPage): (WebKit::WebPageProxy::continueNavigationInNewProcess): (WebKit::WebPageProxy::didCreateMainFrame): (WebKit::WebPageProxy::didCommitLoadForFrame): (WebKit::WebPageProxy::createRemoteSubframesInOtherProcesses): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigationInternal): * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::hasRootFrames): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: ((ProcessSwap, CrossSiteWindowOpenWithOpener)): ((ProcessSwap, SameSiteWindowWithOpenerNavigateToFile)): Canonical link: https://commits.webkit.org/278131@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f923c3: Decoupling from-font resolution from FontCascadeFo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f923c324da2f95fbd856ac79fc43aeb662f172cc https://github.com/WebKit/WebKit/commit/f923c324da2f95fbd856ac79fc43aeb662f172cc Author: Vitor Roriz Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/platform/graphics/FontCascade.h M Source/WebCore/platform/graphics/FontCascadeDescription.cpp M Source/WebCore/platform/graphics/FontCascadeDescription.h M Source/WebCore/platform/graphics/FontCascadeFonts.h M Source/WebCore/platform/graphics/FontSizeAdjust.h Log Message: --- Decoupling from-font resolution from FontCascadeFonts::primaryFont https://bugs.webkit.org/show_bug.cgi?id=273339 rdar://127132471 Reviewed by Brent Fulgham. font-size-adjust from-font resolution was fixed by [1]. It now works correctly and it uses the primary font for resolution. However, this patch changed FontCascadeFonts::primaryFont to receive a mutable (non-const) FontCascadeDescription object, such that it could resolve the from-font reference after the primary font is resolved. This means that now FontCascadeFonts::primaryFont does two different things: a) resolving and caching a font as the primary font b) resolving from-font according to the primary font if necessary The (a) part of primaryFont doesn't require a mutable FontCascadeDescription. We can update FontCascadeDescription to have a method for resolving font-size-adjust from-font at the point where we own a mutable FontCascadeDescription instead. This allows us to compute the primaryFont itself from places where we only have access to a const FontCascadeDescription. This is for example, required for solving https://bugs.webkit.org/show_bug.cgi?id=273233, where we need to access to primaryFont from FontCascadeFonts::glyphDataForVariant This patch should have no side effects, as it is a preparation for solving 273233. [1] https://commits.webkit.org/269041@main * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::fontSizeAdjustFromStyle): * Source/WebCore/platform/graphics/FontCascade.h: (WebCore::FontCascade::primaryFont const): * Source/WebCore/platform/graphics/FontCascadeDescription.cpp: (WebCore::FontCascadeDescription::resolveFontSizeAdjustFromFontIfNeeded): * Source/WebCore/platform/graphics/FontCascadeDescription.h: * Source/WebCore/platform/graphics/FontCascadeFonts.h: (WebCore::FontCascadeFonts::primaryFont): * Source/WebCore/platform/graphics/FontSizeAdjust.h: (WebCore::FontSizeAdjust::resolveFromFontIfNeeded): (WebCore::FontSizeAdjust::shouldResolveFromFont const): Canonical link: https://commits.webkit.org/278130@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8faca0: Update wpt css/css-color
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8faca0da76fde8d8d03a959cd9044aceb4cc1dac https://github.com/WebKit/WebKit/commit/8faca0da76fde8d8d03a959cd9044aceb4cc1dac Author: Sam Weinig Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/TestExpectations R LayoutTests/imported/w3c/web-platform-tests/css/css-color/009900-image-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/009900-tagged-image-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/WEB_FEATURES.yml R LayoutTests/imported/w3c/web-platform-tests/css/css-color/a98rgb-003-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/a98rgb-004-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/opacity-animation-ending-correctly-001-ref.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/animation/w3c-import.log R LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-hsl-001-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-hsl-002-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-hsl-003-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-hsl-004-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-rgb-001-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-rgb-002-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/background-color-rgb-003-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/blacksquare-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/blacktext-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/border-color-currentcolor-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/border-color-ref.xht A LayoutTests/imported/w3c/web-platform-tests/css/css-color/clip-opacity-out-of-flow-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/clip-opacity-out-of-flow.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-basic-001-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-001-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-002-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-003-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-nested-for-color-property-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-currentcolor-visited-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-non-srgb-001-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/color-mix-percents-01-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/composited-filters-under-opacity-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-003-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-004-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/currentcolor-visited-fallback-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-ButtonBorder-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-ButtonFace-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-Canvas-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-CanvasText-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/deprecated-sameas-GrayText-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/display-p3-004-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/greensquare-090-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/greensquare-display-p3-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/greensquare-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/greentext-ref.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/hex-003-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/hsl-clamp-negative-saturation-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/hsl-clamp-negative-saturation.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/hsla-clamp-negative-saturation-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-color/hsla-clamp-negative-saturation.html R LayoutTests/imported/w3c/web-platform-tests/css/css-color/hwb-003-ref.html R
[webkit-changes] [WebKit/WebKit] eb01ec: [GTK] Correct scaling for DPI.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: eb01eca78d82335d2372d2add5ce5e4304b71930 https://github.com/WebKit/WebKit/commit/eb01eca78d82335d2372d2add5ce5e4304b71930 Author: Glen Whitney Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/platform/gtk/PlatformScreenGtk.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h Log Message: --- [GTK] Correct scaling for DPI. https://bugs.webkit.org/show_bug.cgi?id=247980 Reviewed by Michael Catanzaro. Move the scaling factor formerly in WebKitWebView.cpp (responsive to the xft-dpi setting) into WebKitWebViewBase.cpp, and split it into two scaling factors. The first, a page scaling factor, uses screenDPI to ensure that a length specified by a CSS unit of 1in will appear on the screen as one physical inch. The second, a text scaling factor, ensures that text specified as 96px in size will have a height on-screen as specified by fontDPI (which is primarily driven by the xft-dpi setting), in terms of the number of screen pixels taken up. The two scaling factors are refreshed when any one of the inputs for computing them changes: the GDK_SCALE factor, the xft-dpi setting, or the screenDPI of the device it is displayed on (say by being dragged to a different monitor). Throughout, at the default zoom level, a CSS 1in dimension is kept at one physical inch. The scale factors are kept internal to WebKitWebViewBase (which helps keep GTK dependencies grouped and reduces the total code in WebKitWebView enclosed in `#ifdef PLATFORM(GTK)`) but made available to WebKitWebView so that its external interfaces can maintain zoom level 1 as the default zoom level, and zoom in and out from there. So indeed, if a user of WebKitWebView asks for a zoom level of 1.5, a length specified in CSS as 1in will then occupy one and a half physical inches on screen. * Source/WebCore/platform/gtk/PlatformScreenGtk.cpp: (WebCore::fontDPI): * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewConstructed): (webkitWebViewDispose): (webkit_web_view_set_zoom_level): (webkit_web_view_get_zoom_level): * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): (refreshInternalScaling): (webkitWebViewBaseUpdateDisplayID): (webkitWebViewBaseDispose): (webkitWebViewBaseGetScaleFactors): (deviceScaleFactorChanged): (webkitWebViewBaseCreateWebPage): * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Canonical link: https://commits.webkit.org/278128@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 296e0c: [webkitpy] Ignore SSL compatibility issues when au...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 296e0c1a0e23c88ab3d5bed9e146a5ca46ac96d0 https://github.com/WebKit/WebKit/commit/296e0c1a0e23c88ab3d5bed9e146a5ca46ac96d0 Author: Maria Corona Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Tools/Scripts/webkitpy/__init__.py Log Message: --- [webkitpy] Ignore SSL compatibility issues when auto-installer is disabled (272919) https://bugs.webkit.org/show_bug.cgi?id=273350 rdar://126708984 Reviewed by Jonathan Bedard. * Tools/Scripts/webkitpy/__init__.py: This script should let you continue even if urllib3 modules are not found. The import is intended to be optional. Canonical link: https://commits.webkit.org/278127@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb9958: [results.webkit.org] Handle empty dashboard query
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb99585b31371166f708c62167a08fbbe0c762bd https://github.com/WebKit/WebKit/commit/fb99585b31371166f708c62167a08fbbe0c762bd Author: Jonathan Bedard Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes.py Log Message: --- [results.webkit.org] Handle empty dashboard query https://bugs.webkit.org/show_bug.cgi?id=273436 rdar://127255746 Unreviewed infrastructure fix. Fix a regression from 276963@main. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/view_routes.py: (ViewRoutes): Define dashboard_queries as [] if undefined. Canonical link: https://commits.webkit.org/278126@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f19f70: Missing iframe subresource in http/tests/scroll-to...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f19f7024c1c41c613941803b4fc2fd458ad8585a https://github.com/WebKit/WebKit/commit/f19f7024c1c41c613941803b4fc2fd458ad8585a Author: Fujii Hironori Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/http/tests/scroll-to-text-fragment/no-iframe-match-expected.html M LayoutTests/http/tests/scroll-to-text-fragment/no-iframe-match.html Log Message: --- Missing iframe subresource in http/tests/scroll-to-text-fragment/no-iframe-match.html https://bugs.webkit.org/show_bug.cgi?id=273297 Reviewed by Darin Adler. * LayoutTests/http/tests/scroll-to-text-fragment/no-iframe-match-expected.html: * LayoutTests/http/tests/scroll-to-text-fragment/no-iframe-match.html: Removed the leading "../" from the URL. Canonical link: https://commits.webkit.org/278125@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bdf863: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bdf863f4e49861889c99b860e1d3fe9b2bb60ad2 https://github.com/WebKit/WebKit/commit/bdf863f4e49861889c99b860e1d3fe9b2bb60ad2 Author: Fujii Hironori Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/278124@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3ba31e: [view-transitions] Pseudo elements can't be captured.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3ba31ee3b3d5e5a87e409978bc11eb8aa0c7f1c5 https://github.com/WebKit/WebKit/commit/3ba31ee3b3d5e5a87e409978bc11eb8aa0c7f1c5 Author: Matt Woodrow Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/dom/Element.cpp M Source/WebCore/dom/Element.h M Source/WebCore/dom/Node.h M Source/WebCore/dom/ViewTransition.cpp M Source/WebCore/dom/ViewTransition.h M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderLayer.cpp M Source/WebCore/rendering/RenderLayerBacking.cpp M Source/WebCore/rendering/RenderLayerCompositor.cpp M Source/WebCore/rendering/RenderObject.h M Source/WebCore/style/StyleAdjuster.cpp M Source/WebCore/style/StyleAdjuster.h M Source/WebCore/style/StyleResolver.cpp M Source/WebCore/style/StyleResolver.h M Source/WebCore/style/Styleable.cpp M Source/WebCore/style/Styleable.h Log Message: --- [view-transitions] Pseudo elements can't be captured. https://bugs.webkit.org/show_bug.cgi?id=273166 Reviewed by Tim Nguyen. Pseudo elements (like ::backdrop) don't have an associated Element, so can't be found by ViewTransition's forEachElementInPaintOrder. Rather than holding an Element in CapturedElement, hold a Styleable instead which can represent these pseudo elements as well. Since the normal Styleable class uses an Element reference, introduces a WeakStyleable object which uses a WeakPtr to an Element and can (maybe) be converted back into a Styleable when needed. Changes most of the ViewTransition code to operator on the RenderElement from the Styleable, instead of the Element. Adds capturedInViewTransition to Styleable, so that we can look this up in cases where the renderer hasn't yet been created. * LayoutTests/TestExpectations: * Source/WebCore/dom/Element.cpp: (WebCore::operator<<): * Source/WebCore/dom/Element.h: (WebCore::Element::capturedInViewTransition const): Deleted. (WebCore::Element::setCapturedInViewTransition): Deleted. * Source/WebCore/dom/Node.h: * Source/WebCore/dom/ViewTransition.cpp: (WebCore::effectiveViewTransitionName): (WebCore::captureOverflowRect): (WebCore::snapshotElementVisualOverflowClippedToViewport): (WebCore::forEachRendererInPaintOrder): (WebCore::ViewTransition::captureOldState): (WebCore::ViewTransition::captureNewState): (WebCore::ViewTransition::activateViewTransition): (WebCore::ViewTransition::clearViewTransition): (WebCore::ViewTransition::copyElementBaseProperties): (WebCore::ViewTransition::updatePseudoElementStyles): (WebCore::ViewTransition::viewTransitionNewPseudoForCapturedElement): (WebCore::forEachElementInPaintOrder): Deleted. * Source/WebCore/dom/ViewTransition.h: * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::initializeStyle): (WebCore::RenderElement::capturedInViewTransition const): Deleted. * Source/WebCore/rendering/RenderElement.h: * Source/WebCore/rendering/RenderLayer.cpp: (WebCore::RenderLayer::rebuildZOrderLists): (WebCore::RenderLayer::paintList): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateTransform): (WebCore::RenderLayerBacking::updateGeometry): * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::collectViewTransitionNewContentLayers): * Source/WebCore/rendering/RenderObject.h: (WebCore::RenderObject::capturedInViewTransition const): (WebCore::RenderObject::setCapturedInViewTransition): * Source/WebCore/style/Styleable.cpp: (WebCore::Styleable::capturedInViewTransition const): * Source/WebCore/style/Styleable.h: (WebCore::WeakStyleable::operator bool const): (WebCore::WeakStyleable::operator=): (WebCore::WeakStyleable::styleable const): Canonical link: https://commits.webkit.org/278123@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cbc731: Unskip http/tests/media for site-isolation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cbc731672fc689aceac00e1250a5229ea4a8f41c https://github.com/WebKit/WebKit/commit/cbc731672fc689aceac00e1250a5229ea4a8f41c Author: Pascoe Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations Log Message: --- Unskip http/tests/media for site-isolation https://bugs.webkit.org/show_bug.cgi?id=273430 rdar://127251459 Unreviewed, test development. These tests don't time out and don't need to be skipped. * LayoutTests/platform/mac-site-isolation/TestExpectations: Canonical link: https://commits.webkit.org/278122@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5712bc: REGRESSION (268354@main): [ macOS wk1 ] fast/hidpi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5712bc351f464c88865e202418fece3ea9f4d6b2 https://github.com/WebKit/WebKit/commit/5712bc351f464c88865e202418fece3ea9f4d6b2 Author: Said Abou-Hallawa Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/fast/hidpi/filters-drop-shadow.html M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- REGRESSION (268354@main): [ macOS wk1 ] fast/hidpi/filters-drop-shadow.html is a consistent failure with image diff https://bugs.webkit.org/show_bug.cgi?id=270380 rdar://123922421 [Filters] Unreviewed test gardening Make the pixel tolerance of the test to be a range. * LayoutTests/fast/hidpi/filters-drop-shadow.html: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/278121@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 500fd5: [view-transitions] css/css-view-transitions/conten...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 500fd5004df14f04bfeb13a58634e5506073d910 https://github.com/WebKit/WebKit/commit/500fd5004df14f04bfeb13a58634e5506073d910 Author: Matt Woodrow Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp Log Message: --- [view-transitions] css/css-view-transitions/content-with-clip.html fails due to duplicate pseudo renderers. https://bugs.webkit.org/show_bug.cgi?id=273388 Reviewed by Tim Nguyen. The root element is included in the old state, but not the new, and is the first name in the namedElements map. Each frame during updatePseudoElementTree, `buildPseudoElementGroup` is called for the root, and nothing is created (as expected).. currentGroup then gets moved to the previous sibling, which is nullptr, and then is in a broken state for further iterations. All other iterated names then create new renderers, without removing the existing ones. * LayoutTests/TestExpectations: * Source/WebCore/rendering/updating/RenderTreeUpdaterViewTransition.cpp: (WebCore::RenderTreeUpdater::ViewTransition::updatePseudoElementTree): Canonical link: https://commits.webkit.org/278120@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40c054: [Site Isolation] Top content inset is incorrect af...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40c054663111dac1e8af0d07618a5789d376d638 https://github.com/WebKit/WebKit/commit/40c054663111dac1e8af0d07618a5789d376d638 Author: Charlie Wolfe Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- [Site Isolation] Top content inset is incorrect after a cross-site navigation https://bugs.webkit.org/show_bug.cgi?id=273379 rdar://127205664 Reviewed by Alex Christensen. This was added a while ago in 259937@main, and I’m not sure why. It’s causing page content to be offset after a cross-site navigation because the top content inset sent to the destination process is always zero. This issue became more frequent after 275592@main, because we started using these creation parameters for main frame process swaps. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): (WebKit::WebPageProxy::creationParametersForRemotePage): * Source/WebKit/UIProcess/WebPageProxy.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST(SiteIsolation, TopContentInsetAfterCrossSiteNavigation)): Canonical link: https://commits.webkit.org/278119@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3c6b07: [ Gardening ][ iOS MacOS ] imported/w3c/web-platfo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3c6b07200a080df0251825651729cff2ace396db https://github.com/WebKit/WebKit/commit/3c6b07200a080df0251825651729cff2ace396db Author: Dawn Morningstar Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/TestExpectations Log Message: --- [ Gardening ][ iOS MacOS ] imported/w3c/web-platform-tests/html/rendering/widgets/the-select-element/option-add-label-quirks.html(layout-tests) is a constant IMAGE failure https://bugs.webkit.org/show_bug.cgi?id=273416 rdar://127157528 Unreviewed test gardening. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/278118@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4d5b97: [Buildstream SDK] Rollback GTK 4.15 update
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4d5b97db9832ad1614e994ee23c21eba97eb6564 https://github.com/WebKit/WebKit/commit/4d5b97db9832ad1614e994ee23c21eba97eb6564 Author: Philippe Normand Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Tools/buildstream/elements/sdk/gtk.bst R Tools/buildstream/patches/gtk/0001-wayland-Consistently-handle-enum-type.patch Log Message: --- [Buildstream SDK] Rollback GTK 4.15 update https://bugs.webkit.org/show_bug.cgi?id=273423 Unreviewed, GTK 4.15 is not usable, going back to latest stable release. * Tools/buildstream/elements/sdk/gtk.bst: * Tools/buildstream/patches/gtk/0001-wayland-Consistently-handle-enum-type.patch: Removed. Canonical link: https://commits.webkit.org/278117@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a88419: [ Gardening ][ Ventura ] css3/filters/effect-drop-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a8841966293092e2c134b816951fc6cd023356d7 https://github.com/WebKit/WebKit/commit/a8841966293092e2c134b816951fc6cd023356d7 Author: Dawn Morningstar Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [ Gardening ][ Ventura ] css3/filters/effect-drop-shadow-clip-abspos.html(layout-tests) is a constant IMAGE failure https://bugs.webkit.org/show_bug.cgi?id=273419 rdar://127155318 Unreviewed test gardening. * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/278116@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c1d302: [JSC] Disable StopIfNecessaryTimer on WebKit main ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c1d30237589d2fa3fea2e0a76029783d73c2fac4 https://github.com/WebKit/WebKit/commit/c1d30237589d2fa3fea2e0a76029783d73c2fac4 Author: Yusuke Suzuki Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/JavaScriptCore/heap/Heap.cpp M Source/JavaScriptCore/heap/Heap.h M Source/JavaScriptCore/heap/StopIfNecessaryTimer.cpp M Source/JavaScriptCore/heap/StopIfNecessaryTimer.h M Source/WebCore/bindings/js/CommonVM.cpp Log Message: --- [JSC] Disable StopIfNecessaryTimer on WebKit main thread https://bugs.webkit.org/show_bug.cgi?id=273354 rdar://127152132 Reviewed by Keith Miller. Because we have opportunistic task scheduler and GC timer, we do not need to have StopIfNecessaryTimer in the main thread VM of WebKit. * Source/JavaScriptCore/heap/Heap.cpp: (JSC::Heap::disableStopIfNecessaryTimer): * Source/JavaScriptCore/heap/Heap.h: * Source/JavaScriptCore/heap/StopIfNecessaryTimer.cpp: (JSC::StopIfNecessaryTimer::scheduleSoon): (JSC::StopIfNecessaryTimer::disable): * Source/JavaScriptCore/heap/StopIfNecessaryTimer.h: * Source/WebCore/bindings/js/CommonVM.cpp: (WebCore::commonVMSlow): Canonical link: https://commits.webkit.org/278115@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b1f35b: Use ASCIILiteral in JSC assembler macros
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b1f35bb4f49588153a2b874b84079c6ebe2d22e5 https://github.com/WebKit/WebKit/commit/b1f35bb4f49588153a2b874b84079c6ebe2d22e5 Author: Chris Dumez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/JavaScriptCore/assembler/ARM64Assembler.h M Source/JavaScriptCore/assembler/ARM64Registers.h M Source/JavaScriptCore/assembler/ARMv7Assembler.h M Source/JavaScriptCore/assembler/ARMv7Registers.h M Source/JavaScriptCore/assembler/AbstractMacroAssembler.h M Source/JavaScriptCore/assembler/MacroAssemblerPrinter.cpp M Source/JavaScriptCore/assembler/ProbeContext.h M Source/JavaScriptCore/assembler/RISCV64Assembler.h M Source/JavaScriptCore/assembler/RISCV64Registers.h M Source/JavaScriptCore/assembler/X86Assembler.h M Source/JavaScriptCore/assembler/X86Registers.h M Source/JavaScriptCore/assembler/X86_64Registers.h M Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp M Source/JavaScriptCore/dfg/DFGVariableEvent.cpp M Source/JavaScriptCore/jit/FPRInfo.h M Source/JavaScriptCore/jit/GPRInfo.h M Source/JavaScriptCore/jit/Reg.cpp M Source/JavaScriptCore/jit/Reg.h Log Message: --- Use ASCIILiteral in JSC assembler macros https://bugs.webkit.org/show_bug.cgi?id=273383 Reviewed by Darin Adler. * Source/JavaScriptCore/assembler/ARM64Assembler.h: (JSC::ARM64Assembler::gprName): (JSC::ARM64Assembler::sprName): (JSC::ARM64Assembler::fprName): * Source/JavaScriptCore/assembler/ARM64Registers.h: * Source/JavaScriptCore/assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::gprName): (JSC::ARMv7Assembler::sprName): (JSC::ARMv7Assembler::fprName): * Source/JavaScriptCore/assembler/ARMv7Registers.h: * Source/JavaScriptCore/assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::gprName): (JSC::AbstractMacroAssembler::sprName): (JSC::AbstractMacroAssembler::fprName): * Source/JavaScriptCore/assembler/RISCV64Assembler.h: (JSC::RISCV64Assembler::gprName): (JSC::RISCV64Assembler::sprName): (JSC::RISCV64Assembler::fprName): * Source/JavaScriptCore/assembler/RISCV64Registers.h: * Source/JavaScriptCore/assembler/X86Assembler.h: (JSC::X86Assembler::gprName): (JSC::X86Assembler::sprName): (JSC::X86Assembler::fprName): * Source/JavaScriptCore/assembler/X86Registers.h: * Source/JavaScriptCore/assembler/X86_64Registers.h: Canonical link: https://commits.webkit.org/278114@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d5408d: [JSC] Extract WatchpointSet collection from Access...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5408df0618d2f1bfbba7b5bd3ab8f3f1d52d44c https://github.com/WebKit/WebKit/commit/d5408df0618d2f1bfbba7b5bd3ab8f3f1d52d44c Author: Yusuke Suzuki Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/JavaScriptCore/bytecode/AccessCase.cpp M Source/JavaScriptCore/bytecode/AccessCase.h M Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.h M Source/JavaScriptCore/bytecode/InstanceOfAccessCase.cpp M Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.cpp M Source/JavaScriptCore/bytecode/ModuleNamespaceAccessCase.cpp M Source/JavaScriptCore/bytecode/ProxyObjectAccessCase.cpp M Source/JavaScriptCore/bytecode/ProxyableAccessCase.cpp Log Message: --- [JSC] Extract WatchpointSet collection from AccessCase https://bugs.webkit.org/show_bug.cgi?id=273392 rdar://127220534 Reviewed by Keith Miller. This patch changes how watchpoint set are registered in IC. 1. We will always clone AccessCase holding CallLinkInfo for simplicity. This is rare and this wipes AccessCase::State completely. 2. We stop registering watchpoint set at addCases. It only materializes watchpoint set for the future invalidation. We collect them when actually generating code. And we stop generating code for AccessCase which already holds invalid watchpoint set. By doing this approach, now we can list up all the watchpoint set we would like to see in InlineCacheCompiler's regenerate function. And AccessCase becomes much more just an immutable feedback data. This is important step towards Handler IC. Now we gather all watchpoint set registrations into InlineCacheCompiler::regenerate. Next step is redesign of these watchpoint set to put them into IC code instead of StructureStubInfo. And then, Handler IC will share the same set of watchpoint set when sharing code. * Source/JavaScriptCore/bytecode/AccessCase.cpp: (JSC::AccessCase::commit): Deleted. * Source/JavaScriptCore/bytecode/AccessCase.h: (JSC::AccessCase::polyProtoAccessChain const): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::generateWithGuard): (JSC::InlineCacheCompiler::generateImpl): (JSC::collectAdditionalWatchpoints): (JSC::InlineCacheCompiler::regenerate): (JSC::PolymorphicAccess::addCases): (JSC::InlineCacheCompiler::installWatchpoint): Deleted. (JSC::commit): Deleted. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.h: Canonical link: https://commits.webkit.org/278113@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d979e: Re-sync color conversion constants with latest in ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d979e658a4948cb03f593c9091b70b275eff5c3 https://github.com/WebKit/WebKit/commit/1d979e658a4948cb03f593c9091b70b275eff5c3 Author: Sam Weinig Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-color/nested-color-mix-with-currentcolor-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-mix-out-of-gamut-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt M LayoutTests/platform/glib/fast/css/hsl-color-expected.txt M LayoutTests/platform/ios/fast/css/hsl-color-expected.txt M LayoutTests/platform/mac/fast/css/hsl-color-expected.txt M LayoutTests/platform/wincairo/fast/css/hsl-color-expected.txt M Source/WebCore/platform/graphics/ColorConversion.cpp M Source/WebCore/platform/graphics/ColorConversion.h M Source/WebCore/platform/graphics/ColorMatrix.h M Source/WebCore/platform/graphics/ColorTypes.h M Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp Log Message: --- Re-sync color conversion constants with latest in spec https://bugs.webkit.org/show_bug.cgi?id=272952 Reviewed by Darin Adler. Update the following constants: - xyzToLinear/linearToXYZ 3x3 matrices for the RGB color types. - chromatic adaptation 3x3 matrices - D50 and D65 white point vector - OKLab XYZ <-> LMS matrices Also updated polar/rectilinear conversions to correctly handle the achromatic cases, ensuring conversion to lch/oklch have "powerless" hue when chroma is close to 0, and when that "powerless" hue is transformed back to lab/oklab, that it the opponent A/B values are set to 0. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color.html: Update one result to account to more closely match colorjs.io reference results. * LayoutTests/imported/w3c/web-platform-tests/css/css-color/nested-color-mix-with-currentcolor-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-color-mix-function-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-computed-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-valid-relative-color-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/color-mix-out-of-gamut-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-color/parsing/relative-color-out-of-gamut-expected.txt: - Updated results that are now passing. * Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp: (TestWebKitAPI::TEST(Color, P3ConversionToSRGB)): - Updated result to account for change in OKLab conversion. (OKLab is used for the gamut mapping, which is why this only effected this one test). * Source/WebCore/platform/graphics/ColorConversion.cpp: (WebCore::convertToPolarForm): - Updated to account for sufficiently small a/b values that the result would be achromatic. (WebCore::convertToRectangularForm): - Handle missing (NaN) hue, to correctly set a/b to 0. (WebCore::OKLab>::convert): - Update XYZ <-> LMS constants to latest in spec. * Source/WebCore/platform/graphics/ColorConversion.h: - Move and update white point constants to the header to be closer to the chromatic adaptation code. - Update chromatic adaptation constants and add a comment explaining what they are all about. * Source/WebCore/platform/graphics/ColorMatrix.h: (WebCore::ColorMatrix::ColorMatrix): - Allow conversions on construction to allow matrices to be defined with either double or float. (WebCore::brightnessColorMatrix): (WebCore::contrastColorMatrix): (WebCore::invertColorMatrix): (WebCore::opacityColorMatrix): - Fix a typo that was copied in a few places. compontent -> component * Source/WebCore/platform/graphics/ColorTypes.h: - Update LinearRGB <-> XYZ constants. Canonical link: https://commits.webkit.org/278112@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e6ecf3: Remove the "disable writing suggestions by default...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e6ecf3e5ec3a6607930a161733c0fccafe2f088b https://github.com/WebKit/WebKit/commit/e6ecf3e5ec3a6607930a161733c0fccafe2f088b Author: Richard Robinson Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/dom/Element.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Remove the "disable writing suggestions by default" quirk https://bugs.webkit.org/show_bug.cgi?id=273366 rdar://127185268 Reviewed by Abrar Rahman Protyasha. Now that the writing suggestions logic is more robust, this quirk is no longer needed. * Source/WebCore/dom/Element.cpp: (WebCore::Element::isWritingSuggestionsEnabled const): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableWritingSuggestionsByDefaultQuirk const): Deleted. * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/278111@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ad81d5: Removed EnumTraits
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ad81d5649c426c8497b62f411b81edbc64462b06 https://github.com/WebKit/WebKit/commit/ad81d5649c426c8497b62f411b81edbc64462b06 Author: Mikhail R. Gadelha Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/Modules/webauthn/AuthenticatorTransport.h M Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm Log Message: --- Removed EnumTraits as it was already ported to the new serialization format https://bugs.webkit.org/show_bug.cgi?id=268158 Reviewed by Alex Christensen. Ported in https://commits.webkit.org/256789@main * Source/WebCore/Modules/webauthn/AuthenticatorTransport.h: Canonical link: https://commits.webkit.org/278110@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 443d8b: Drop startsWithLettersIgnoringASCIICase() in DateM...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 443d8b768f0d2c6aebd973f64ba289e740f24883 https://github.com/WebKit/WebKit/commit/443d8b768f0d2c6aebd973f64ba289e740f24883 Author: Chris Dumez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WTF/wtf/DateMath.cpp Log Message: --- Drop startsWithLettersIgnoringASCIICase() in DateMath.cpp https://bugs.webkit.org/show_bug.cgi?id=273404 Reviewed by Darin Adler. It is unused. * Source/WTF/wtf/DateMath.cpp: (WTF::startsWithLettersIgnoringASCIICase): Deleted. Canonical link: https://commits.webkit.org/278109@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 67a879: Drop StringImpl::characters8() / characters16()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 67a879c31de358001ebd9ab1006d534c14bd8de5 https://github.com/WebKit/WebKit/commit/67a879c31de358001ebd9ab1006d534c14bd8de5 Author: Chris Dumez Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/JavaScriptCore/runtime/CachedTypes.cpp M Source/JavaScriptCore/runtime/JSONObject.cpp M Source/JavaScriptCore/runtime/JSString.cpp M Source/JavaScriptCore/runtime/StringPrototype.cpp M Source/WTF/wtf/StdLibExtras.h M Source/WTF/wtf/URLParser.cpp M Source/WTF/wtf/text/AtomString.cpp M Source/WTF/wtf/text/AtomStringImpl.cpp M Source/WTF/wtf/text/StringBuilder.cpp M Source/WTF/wtf/text/StringBuilder.h M Source/WTF/wtf/text/StringBuilderInternals.h M Source/WTF/wtf/text/StringImpl.cpp M Source/WTF/wtf/text/StringImpl.h M Source/WTF/wtf/text/WTFString.h M Source/WTF/wtf/text/cf/StringImplCF.cpp M Source/WebCore/css/parser/CSSTokenizerInputStream.cpp M Source/WebCore/css/parser/CSSTokenizerInputStream.h M Source/WebCore/dom/DatasetDOMStringMap.cpp M Source/WebCore/platform/text/SegmentedString.h M Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp M Tools/TestWebKitAPI/cocoa/HTTPServer.mm Log Message: --- Drop StringImpl::characters8() / characters16() https://bugs.webkit.org/show_bug.cgi?id=273376 Reviewed by Darin Adler. Drop StringImpl::characters8() / characters16() in favor of span equivalents. * Source/JavaScriptCore/runtime/CachedTypes.cpp: (JSC::CachedUniquedStringImplBase::encode): * Source/JavaScriptCore/runtime/JSONObject.cpp: (JSC::FastStringifier::append): * Source/JavaScriptCore/runtime/JSString.cpp: (JSC::JSString::dumpToStream): * Source/JavaScriptCore/runtime/StringPrototype.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/WTF/wtf/StdLibExtras.h: (WTF::spanConstCast): * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::domainToASCII): * Source/WTF/wtf/text/AtomString.cpp: (WTF::AtomString::convertASCIICase const): * Source/WTF/wtf/text/AtomStringImpl.cpp: (WTF::HashAndUTF8CharactersTranslator::equal): * Source/WTF/wtf/text/StringBuilder.cpp: (WTF::StringBuilder::shrink): (WTF::StringBuilder::extendBufferForAppendingWithUpconvert): * Source/WTF/wtf/text/StringBuilder.h: (WTF::StringBuilder::append): (WTF::StringBuilder::characters const): * Source/WTF/wtf/text/StringBuilderInternals.h: (WTF::StringBuilder::extendBufferForAppending): (WTF::StringBuilder::extendBufferForAppendingSlowCase): * Source/WTF/wtf/text/StringImpl.cpp: (WTF::StringImpl::simplifyMatchedCharactersToSpace): (WTF::StringImpl::find): (WTF::equalInner): (WTF::equalInternal): (WTF::equal): (WTF::equalIgnoringNullity): * Source/WTF/wtf/text/StringImpl.h: (WTF::StringImpl::span8 const): (WTF::StringImpl::span16 const): (WTF::StringImpl::span const): (WTF::StringImpl::span const): (WTF::StringImpl::containsOnlyLatin1 const): (WTF::StringImpl::removeCharactersImpl): (WTF::StringImpl::removeCharacters): (WTF::StringImpl::characters8 const): Deleted. (WTF::StringImpl::characters16 const): Deleted. (WTF::StringImpl::span const): Deleted. (WTF::StringImpl::characters const): Deleted. (WTF::StringImpl::characters const): Deleted. * Source/WTF/wtf/text/WTFString.h: (WTF::String::characterAt const): * Source/WTF/wtf/text/cf/StringImplCF.cpp: (WTF::StringImpl::createCFString): * Source/WTF/wtf/unicode/UTF8Conversion.cpp: (WTF::Unicode::equalUTF16WithUTF8): (WTF::Unicode::equalLatin1WithUTF8): * Source/WTF/wtf/unicode/UTF8Conversion.h: * Source/WebCore/css/parser/CSSTokenizerInputStream.cpp: (WebCore::CSSTokenizerInputStream::advanceUntilNonWhitespace): * Source/WebCore/css/parser/CSSTokenizerInputStream.h: (WebCore::CSSTokenizerInputStream::characterPredicate): * Source/WebCore/dom/DatasetDOMStringMap.cpp: (WebCore::convertPropertyNameToAttributeName): * Source/WebCore/platform/text/SegmentedString.h: (WebCore::SegmentedString::Substring::Substring): Canonical link: https://commits.webkit.org/278108@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 61f60c: Versioning.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 61f60cf9fd5ebdb3f7d1eec670eabfcbc5b43351 https://github.com/WebKit/WebKit/commit/61f60cf9fd5ebdb3f7d1eec670eabfcbc5b43351 Author: Mohsin Qureshi Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Configurations/Version.xcconfig Log Message: --- Versioning. WebKit-7619.1.12 Canonical link: https://commits.webkit.org/278107@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e39325: Begin implementing provisional load failure handli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3932586024691e3b18defa319de5d4d0e252335 https://github.com/WebKit/WebKit/commit/e3932586024691e3b18defa319de5d4d0e252335 Author: Alex Christensen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebKit/UIProcess/BrowsingContextGroup.cpp M Source/WebKit/UIProcess/BrowsingContextGroup.h M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp M Source/WebKit/UIProcess/ProvisionalPageProxy.h M Source/WebKit/UIProcess/WebFrameProxy.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.cpp M Source/WebKit/WebProcess/WebPage/WebFrame.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm Log Message: --- Begin implementing provisional load failure handling with site isolation https://bugs.webkit.org/show_bug.cgi?id=273362 rdar://127177756 Reviewed by Charlie Wolfe. When a provisional load fails, some additional bookkeeping is needed to have all the processes have local and remote frames in the right state. I renamed didCommitLoadInAnotherProcess to transitionFrameToRemote to be symmetric with transitionFrameToLocal and because it is used in more cases than just during a load commit now. Now it's used in a provisional load failure, too. * Source/WebKit/UIProcess/BrowsingContextGroup.cpp: (WebKit::BrowsingContextGroup::transitionProvisionalPageToRemotePage): * Source/WebKit/UIProcess/BrowsingContextGroup.h: * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::~ProvisionalPageProxy): (WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame): (WebKit::ProvisionalPageProxy::didCommitLoadForFrame): * Source/WebKit/UIProcess/ProvisionalPageProxy.h: (WebKit::ProvisionalPageProxy::messageReceiverRegistration): * Source/WebKit/UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::commitProvisionalFrame): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::transitionToRemote): (WebKit::WebFrame::didCommitLoadInAnotherProcess): Deleted. * Source/WebKit/WebProcess/WebPage/WebFrame.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::transitionFrameToLocal): (WebKit::WebPage::transitionFrameToRemote): (WebKit::WebPage::didCommitLoadInAnotherProcess): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST(SiteIsolation, NavigateOpenerToProvisionalNavigationFailure)): Canonical link: https://commits.webkit.org/278106@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 375cdc: Expand use of WKBundlePagePostMessageWithAsyncRepl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 375cdc397ac2d646c8f43ed094ce1d2a18790005 https://github.com/WebKit/WebKit/commit/375cdc397ac2d646c8f43ed094ce1d2a18790005 Author: Alex Christensen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Tools/WebKitTestRunner/DictionaryFunctions.h M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h M Tools/WebKitTestRunner/TestController.cpp M Tools/WebKitTestRunner/TestController.h M Tools/WebKitTestRunner/TestInvocation.cpp M Tools/WebKitTestRunner/TestInvocation.h M Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm Log Message: --- Expand use of WKBundlePagePostMessageWithAsyncReply in WebKitTestRunner https://bugs.webkit.org/show_bug.cgi?id=273359 rdar://127169842 Reviewed by Charlie Wolfe. Not only does it reduce boilerplate code, but it also works better with site isolation by sending the reply to the originating process instead of the main frame process. * Tools/WebKitTestRunner/DictionaryFunctions.h: (WTR::arrayValue): * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::InjectedBundle::postRemoveChromeInputField): Deleted. (WTR::InjectedBundle::postSetBackingScaleFactor): Deleted. * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::removeChromeInputField): (WTR::TestRunner::setBackingScaleFactor): (WTR::TestRunner::removeAllSessionCredentials): (WTR::TestRunner::setAppBoundDomains): (WTR::TestRunner::setManagedDomains): (WTR::TestRunner::callRemoveChromeInputFieldCallback): Deleted. (WTR::TestRunner::callSetBackingScaleFactorCallback): Deleted. (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback): Deleted. (WTR::TestRunner::didSetAppBoundDomainsCallback): Deleted. (WTR::TestRunner::didSetManagedDomainsCallback): Deleted. * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::didReceiveAsyncMessageFromInjectedBundle): (WTR::TestController::removeAllSessionCredentials): (WTR::TestController::setAppBoundDomains): (WTR::TestController::setManagedDomains): (WTR::AppBoundDomainsCallbackContext::AppBoundDomainsCallbackContext): Deleted. (WTR::didSetAppBoundDomainsCallback): Deleted. (WTR::ManagedDomainsCallbackContext::ManagedDomainsCallbackContext): Deleted. (WTR::didSetManagedDomainsCallback): Deleted. * Tools/WebKitTestRunner/TestController.h: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): (WTR::TestInvocation::didRemoveAllSessionCredentials): Deleted. (WTR::TestInvocation::didSetAppBoundDomains): Deleted. (WTR::TestInvocation::didSetManagedDomains): Deleted. * Tools/WebKitTestRunner/TestInvocation.h: * Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::removeAllSessionCredentials): Canonical link: https://commits.webkit.org/278105@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 292d42: [IFC][Integration] Layout boxes should have a rend...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 292d42429ba215465a1e89f01981f3a92e742446 https://github.com/WebKit/WebKit/commit/292d42429ba215465a1e89f01981f3a92e742446 Author: Antti Koivisto Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp M Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp A Source/WebCore/layout/layouttree/FormattingContextBoxIterator.h M Source/WebCore/layout/layouttree/LayoutBox.cpp M Source/WebCore/layout/layouttree/LayoutBox.h M Source/WebCore/layout/layouttree/LayoutIterator.h M Source/WebCore/rendering/RenderObject.cpp Log Message: --- [IFC][Integration] Layout boxes should have a renderer backpointer https://bugs.webkit.org/show_bug.cgi?id=273395 rdar://127226407 Reviewed by Alan Baradlay. Currently we are using an awkward layout box -> renderer map in BoxTree. We can simplify things, save memory and improve performance by getting rid of it. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp: (WebCore::LayoutIntegration::BoxTree::~BoxTree): (WebCore::LayoutIntegration::BoxTree::buildTreeForInlineContent): (WebCore::LayoutIntegration::BoxTree::buildTreeForFlexContent): (WebCore::LayoutIntegration::BoxTree::insertChild): (WebCore::LayoutIntegration::BoxTree::insert): (WebCore::LayoutIntegration::BoxTree::remove): (WebCore::LayoutIntegration::BoxTree::contains const): (WebCore::LayoutIntegration::BoxTree::rendererForLayoutBox): (WebCore::LayoutIntegration::BoxTree::rendererForLayoutBox const): (WebCore::LayoutIntegration::BoxTree::hasRendererForLayoutBox const): * Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h: (WebCore::LayoutIntegration::BoxTree::boxCount const): Deleted. (WebCore::LayoutIntegration::BoxTree::renderers const): Deleted. * Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp: (WebCore::LayoutIntegration::FlexLayout::layout): (WebCore::LayoutIntegration::FlexLayout::updateRenderers): * Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp: (WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions): Since we don't have a renderer list anymore, traverse the boxes in the formatting context instead. (WebCore::LayoutIntegration::LineLayout::shiftLinesBy): * Source/WebCore/layout/layouttree/FormattingContextBoxIterator.h: Added. (WebCore::Layout::FormattingContextBoxIterator::FormattingContextBoxIterator): (WebCore::Layout::FormattingContextBoxIterator::operator++): (WebCore::Layout::FormattingContextBoxIteratorAdapter::FormattingContextBoxIteratorAdapter): (WebCore::Layout::FormattingContextBoxIteratorAdapter::begin): (WebCore::Layout::FormattingContextBoxIteratorAdapter::end): (WebCore::Layout::formattingContextBoxes): Add a iterator for traversing all boxes in a formatting context. * Source/WebCore/layout/layouttree/LayoutBox.cpp: (WebCore::Layout::Box::~Box): * Source/WebCore/layout/layouttree/LayoutBox.h: (WebCore::Layout::Box::rendererForIntegration const): (WebCore::Layout::Box::setRendererForIntegration): * Source/WebCore/layout/layouttree/LayoutIterator.h: (WebCore::Layout::LayoutBoxTraversal::nextSkippingChildren): (WebCore::Layout::Traversal::nextSkippingChildren): (WebCore::Layout::LayoutIterator::traverseNextSkippingChildren): (WebCore::Layout::LayoutIterator::operator const): (WebCore::Layout:: const): (WebCore::Layout::LayoutIterator::get const): * Source/WebCore/rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): (WebCore::RenderObject::setLayoutBox): (WebCore::RenderObject::clearLayoutBox): Canonical link: https://commits.webkit.org/278104@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bbca2d: Update webrtc build and code to prepare for tvOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bbca2d7c1fe0a5db650202e53d2f4bbef81cc28a https://github.com/WebKit/WebKit/commit/bbca2d7c1fe0a5db650202e53d2f4bbef81cc28a Author: Youenn Fablet Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/platform/mac-monterey-wk2/TestExpectations M Source/ThirdParty/libwebrtc/Configurations/libaom.xcconfig M Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig M Source/WebCore/platform/VideoDecoder.cpp M Source/WebCore/platform/VideoEncoder.cpp M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.h M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp M Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.h M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.cpp M Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.h M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp M Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h Log Message: --- Update webrtc build and code to prepare for tvOS rdar://126747824 https://bugs.webkit.org/show_bug.cgi?id=272974 Reviewed by Andy Estes and Elliott Williams. Compile out some libwebrtc code in case AV1 is not supported, as is the case in tvOS, where dav1d is not needed. Ditto for some WEB_CODECS code specific code. Update xcconfig files for tvOS. * LayoutTests/platform/mac-monterey-wk2/TestExpectations: Skipping AV1 tests as ENABLE(AV1) is not 1 in Monterey. * Source/ThirdParty/libwebrtc/Configurations/libaom.xcconfig: * Source/ThirdParty/libwebrtc/Configurations/libvpx.xcconfig: * Source/WebCore/platform/VideoDecoder.cpp: (WebCore::VideoDecoder::createLocalDecoder): * Source/WebCore/platform/VideoEncoder.cpp: (WebCore::VideoEncoder::createLocalEncoder): * Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.cpp: (WebCore::createInternalDecoder): * Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoDecoder.h: * Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.cpp: (WebCore::createInternalEncoder): (WebCore::LibWebRTCVPXInternalVideoEncoder::initialize): * Source/WebCore/platform/libwebrtc/LibWebRTCVPXVideoEncoder.h: * Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.cpp: * Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCDav1dDecoder.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp: (WebKit::LibWebRTCCodecs::setEncodingConfiguration): * Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.h: Canonical link: https://commits.webkit.org/278103@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6999be: [LBSE] Add support for LBSE masks in SVGResourceImage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6999be889df2d2b5b9ba7b5c92cd35f7b0ee848a https://github.com/WebKit/WebKit/commit/6999be889df2d2b5b9ba7b5c92cd35f7b0ee848a Author: Rob Buis Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M LayoutTests/TestExpectations M Source/WebCore/rendering/ReferencedSVGResources.cpp M Source/WebCore/rendering/ReferencedSVGResources.h M Source/WebCore/rendering/style/StyleCachedImage.cpp M Source/WebCore/rendering/style/StyleCachedImage.h M Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp M Source/WebCore/rendering/svg/RenderSVGResourceMasker.h M Source/WebCore/svg/graphics/SVGResourceImage.cpp M Source/WebCore/svg/graphics/SVGResourceImage.h Log Message: --- [LBSE] Add support for LBSE masks in SVGResourceImage https://bugs.webkit.org/show_bug.cgi?id=272823 Reviewed by Nikolas Zimmermann. Add support for LBSE masks in SVGResourceImage and that way support HTML referencing SVG masks, both in same document and in external SVG documents. * LayoutTests/TestExpectations: * Source/WebCore/rendering/ReferencedSVGResources.cpp: (WebCore::ReferencedSVGResources::referencedMaskElement): * Source/WebCore/rendering/ReferencedSVGResources.h: * Source/WebCore/rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::legacyRenderSVGResource const): (WebCore::StyleCachedImage::renderSVGResource const): (WebCore::StyleCachedImage::isRenderSVGResource const): (WebCore::StyleCachedImage::image const): * Source/WebCore/rendering/style/StyleCachedImage.h: * Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::applyMask): (WebCore::RenderSVGResourceMasker::drawContentIntoContext): * Source/WebCore/rendering/svg/RenderSVGResourceMasker.h: * Source/WebCore/svg/graphics/SVGResourceImage.cpp: (WebCore::SVGResourceImage::create): (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::draw): * Source/WebCore/svg/graphics/SVGResourceImage.h: Canonical link: https://commits.webkit.org/278102@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e9acc9: [Skia] Handle font smoothing when drawing glyphs
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e9acc98eb155a5d5a45ea8fb4e763ff4cede6eb0 https://github.com/WebKit/WebKit/commit/e9acc98eb155a5d5a45ea8fb4e763ff4cede6eb0 Author: Carlos Garcia Campos Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp Log Message: --- [Skia] Handle font smoothing when drawing glyphs https://bugs.webkit.org/show_bug.cgi?id=273367 Reviewed by Alejandro G. Castro. * Source/WebCore/platform/graphics/skia/FontCascadeSkia.cpp: (WebCore::FontCascade::drawGlyphs): Canonical link: https://commits.webkit.org/278101@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89a191: Removing tests using getTypeMapping() in trusted t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89a19166cb0fe45d0fb83a591c1851ad41f8de45 https://github.com/WebKit/WebKit/commit/89a19166cb0fe45d0fb83a591c1851ad41f8de45 Author: Ziran Sun Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: R LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt R LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative.html R LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt R LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.html A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.tentative-expected.txt A LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.tentative.html Log Message: --- Removing tests using getTypeMapping() in trusted types. https://bugs.webkit.org/show_bug.cgi?id=273312 Reviewed by Tim Nguyen. This is to be in line with the spec discussions at https://github.com/w3c/trusted-types/issues/432. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-getPropertyType.html. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.tentative-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata-expected.txt. * LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.tentative.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/trusted-types/TrustedTypePolicyFactory-metadata.html. Canonical link: https://commits.webkit.org/278100@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1bc81c: [WebRTC][GStreamer] Missing media in SDP if setCon...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1bc81c31ff6c5f2b535b70b44de1ebc5e0389725 https://github.com/WebKit/WebKit/commit/1bc81c31ff6c5f2b535b70b44de1ebc5e0389725 Author: Carlos Bentzen Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: A LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver-expected.txt A LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver.html M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp Log Message: --- [WebRTC][GStreamer] Missing media in SDP if setConfiguration() is called after createDataChannel() or addTransceiver() https://bugs.webkit.org/show_bug.cgi?id=273318 Reviewed by Xabier Rodriguez-Calvar. GStreamerMediaEndpoint::setConfiguration() was tearing down the pipeline if one already existed and creating a new one, which is an issue if any data channels or transceivers are created before RTCPeerConnection.setConfiguration(). The issue is fixed by creating the pipeline earlier in GStreamerMediaEndpoint's contructor, so that data channels or transceivers aren't discarded if created/added before setConfiguration(). Credit to Philippe Normand for finding the issue and fixing it. I wrote the layout test, which fails without his fix. * LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver-expected.txt: Added. * LayoutTests/webrtc/setConfiguration-after-createDataChannel-or-addTransceiver.html: Added. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::GStreamerMediaEndpoint): (WebCore::GStreamerMediaEndpoint::setConfiguration): Canonical link: https://commits.webkit.org/278099@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a20f2f: Deallocate stored VPIO unit after being stopped fo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a20f2f1daa95270f7dd904539502e380674fcdee https://github.com/WebKit/WebKit/commit/a20f2f1daa95270f7dd904539502e380674fcdee Author: Youenn Fablet Date: 2024-04-29 (Mon, 29 Apr 2024) Changed paths: M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp M Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h Log Message: --- Deallocate stored VPIO unit after being stopped for some time rdar://126738470 https://bugs.webkit.org/show_bug.cgi?id=272964 Reviewed by Eric Carlson. Keeping a VPIO unit allocated is triggering CPU activity. It is best for efficiency to deallocate it. We do this after the VPIO unit gets unused for one minute, to retain the VPIO unit with a web page decides to switch of microphone. Manually tested. * Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.cpp: (WebCore::CoreAudioSharedUnit::CoreAudioSharedUnit): (WebCore::CoreAudioSharedUnit::setStoredVPIOUnit): (WebCore::CoreAudioSharedUnit::takeStoredVPIOUnit): (WebCore::CoreAudioSharedUnit::deallocateStoredVPIOUnit): * Source/WebCore/platform/mediastream/mac/CoreAudioSharedUnit.h: Canonical link: https://commits.webkit.org/278098@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
