[webkit-changes] [WebKit/WebKit] cdf0e8: Weak ref smart pointer check should be smarter
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cdf0e8ad7972a47c7ef9a620b28dcbc12eeb88f9 https://github.com/WebKit/WebKit/commit/cdf0e8ad7972a47c7ef9a620b28dcbc12eeb88f9 Author: Geoffrey Garen Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WTF/wtf/TypeTraits.h M Source/WTF/wtf/WeakPtr.h M Source/WTF/wtf/WeakRef.h Log Message: --- Weak ref smart pointer check should be smarter https://bugs.webkit.org/show_bug.cgi?id=273594 rdar://127395924 Reviewed by Chris Dumez. Improved the SFINAE usage to account for const/non-const overload. Moved the static_assert to dereference operations so that WeakPtr can be more like T* in its support for forward declaration. Now you don't need the full type definition available in order to destroy a WeakPtr; only to dereference one. * Source/WTF/wtf/TypeTraits.h: * Source/WTF/wtf/WeakPtr.h: (WTF::WeakPtr::releaseImpl): (WTF::WeakPtr::get const): (WTF::WeakPtr::operator-> const): (WTF::WeakPtr::operator* const): (WTF::WeakPtr::~WeakPtr): Deleted. * Source/WTF/wtf/WeakRef.h: (WTF::WeakRef::ptrAllowingHashTableEmptyValue const): (WTF::WeakRef::ptr const): (WTF::WeakRef::get const): (WTF::WeakRef::~WeakRef): Deleted. Canonical link: https://commits.webkit.org/278249@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 75ca80: REGRESSION (273393@main): Elevated CPU use in UIPr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 75ca8019625a49f6806846f69f7c6e028dfef6e4 https://github.com/WebKit/WebKit/commit/75ca8019625a49f6806846f69f7c6e028dfef6e4 Author: Timothy Hatcher Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h M Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in M Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp M Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp Log Message: --- REGRESSION (273393@main): Elevated CPU use in UIProcess and NetworkProcess due to always sending resource load messages to UIProcess. https://webkit.org/b/273582 rdar://127380142 Reviewed by Brian Weinstein. Only send the resource messages if the page has loaded extensions, not just an extension controller. The NetworkResourceLoadParameters are sent over for each scheduled load, so it is always accurate. Renamed the struct field from pageHasExtensionController to pageHasLoadedWebExtensions. * Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters): * Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.h: * Source/WebKit/NetworkProcess/NetworkResourceLoadParameters.serialization.in: * Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::shouldSendResourceLoadMessages const): * Source/WebKit/WebProcess/Extensions/WebExtensionControllerProxy.h: * Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp: (WebKit::addParametersShared): Canonical link: https://commits.webkit.org/278248@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a4bc6: Moving Masonry to preview
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a4bc6fdbf407f3b9a36b98fd915fad6aa4eb10c https://github.com/WebKit/WebKit/commit/7a4bc6fdbf407f3b9a36b98fd915fad6aa4eb10c Author: Brandon Stewart Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Moving Masonry to preview https://bugs.webkit.org/show_bug.cgi?id=273564 rdar://problem/127378191 Reviewed by Brent Fulgham. Moving Masonry state back to preview now that initial testing is complete. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/278247@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 514a7d: [GTK] Unreviewed, build fix for Clang after 278224...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 514a7d938a6c633e45585e33594a90e1f410c89d https://github.com/WebKit/WebKit/commit/514a7d938a6c633e45585e33594a90e1f410c89d Author: Diego Pino Garcia Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h Log Message: --- [GTK] Unreviewed, build fix for Clang after 278224@main https://bugs.webkit.org/show_bug.cgi?id=273569 Rename 'nullptr_t' to 'std::nullptr_t'. * Source/WebKit/UIProcess/Authentication/AuthenticationChallengeProxy.h: Canonical link: https://commits.webkit.org/278246@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f069b9: Log attachment editing operations
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f069b9d3124d91b6e537be45ea349b79388895f5 https://github.com/WebKit/WebKit/commit/f069b9d3124d91b6e537be45ea349b79388895f5 Author: Gerald Squelart Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WTF/wtf/StackTrace.h M Source/WebCore/html/HTMLAttachmentElement.cpp Log Message: --- Log attachment editing operations https://bugs.webkit.org/show_bug.cgi?id=270152 rdar://121088022 Reviewed by Wenson Hsieh and Aditya Keerthi. This is for Mail to know when and why an attachment was quickly inserted, removed, then another attachment was inserted, all soon after the document creation; this seems to correlate with unexpected behavior where an attachment cannot be inserted in an email reply. When this quick sequence happens, compact stacks are logged for each event, in the "Editing" category. Example: ``` HTMLAttachmentElement - quick insert(A)-remove(A)-insert(B) within 0.074342s of the first document[0x116122400] load, stacks below: HTMLAttachmentElement[0x117006530 uuid=47a8d676-657f-4510-a8f3-5cb9723b0947] - 1st insertion 108.248833ms ago: [stack] HTMLAttachmentElement[0x117006530 uuid=47a8d676-657f-4510-a8f3-5cb9723b0947] - removal 4.043792ms ago: [stack] HTMLAttachmentElement[0x11700ba30 uuid=47a8d676-657f-4510-a8f3-5cb9723b0947] - 2nd insertion: [stack] ``` * Source/WTF/wtf/StackTrace.h: (WTF::StackTrace::forEachFrame const): * Source/WebCore/html/HTMLAttachmentElement.cpp: (WebCore::compactStackTrace): (WebCore::AttachmentEvent::attachment const): (WebCore::AttachmentEvent::document const): (WebCore::AttachmentEvent::uniqueIdentifier const): (WebCore::AttachmentEvent::time const): (WebCore::AttachmentEvent::stackTrace const): (WebCore::AttachmentEvent::capture): (WebCore::AttachmentEvent::reset): (WebCore::AttachmentEvent::operator bool const): (WebCore::lastInsertionInDocument): (WebCore::lastRemovalFromDocument): (WebCore::shouldMonitorDocumentTraffic): (WebCore::HTMLAttachmentElement::insertedIntoAncestor): (WebCore::HTMLAttachmentElement::removedFromAncestor): Canonical link: https://commits.webkit.org/278245@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8cf954: [UnifiedPDF] Snapshots don't get the correct scrol...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8cf954d346bc1cc6b549e8a60cb95bda9c7d15f1 https://github.com/WebKit/WebKit/commit/8cf954d346bc1cc6b549e8a60cb95bda9c7d15f1 Author: Sammy Gill Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm Log Message: --- [UnifiedPDF] Snapshots don't get the correct scroll offset https://bugs.webkit.org/show_bug.cgi?id=273565 rdar://126945237 Reviewed by Simon Fraser and Abrar Rahman Protyasha. In order to make the snapshots appear correct in the tab preview we need to make a few related changes. The first change we need to make is to take into consideration the page scale. This is the main factor that is driving the incorrect scroll offset in the snapshots. However, we must also recenter the document by adding in the padding that is used to center it. Finally, we must also make sure that we paint the grey background that is shown on the page itself. One other related change we need to make is to factor out the page scale in the clip rect we pass to paintPDFContent. This is because we will pass in the rect to pageCoverageForRect, which seems to expect that the passed in rect is in document space, in order to determine which pages need to get painted. With the page scale factored into the rect we can get into a state where we scroll to a new page in the document but not have that page appear in the snapshot. * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::paint): Canonical link: https://commits.webkit.org/278244@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6995fc: strip-tbd: Always remove allowable client list
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6995fcc5396788acfd152c3bebbe5c384fda83dd https://github.com/WebKit/WebKit/commit/6995fcc5396788acfd152c3bebbe5c384fda83dd Author: Elliott Williams Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Tools/Scripts/strip-tbd Log Message: --- strip-tbd: Always remove allowable client list https://bugs.webkit.org/show_bug.cgi?id=273518 rdar://127315657 Reviewed by Alexey Proskuryakov. We need to start importing TBD stubs from private SDK frameworks which have allowable-client lists. Including the entire list adds unnecessary noise and makes mention of system frameworks that are otherwise unrelated to WebKit. Since the TBD stubs only contain minimal information to link successfully, strip the allowable-client section entirely. * Tools/Scripts/strip-tbd: Canonical link: https://commits.webkit.org/278243@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6de0a6: Crash in CheckedPtr::decrementPtrCount via SplitTe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6de0a6e596b6b251fe46c8b12b05a62aea4afb64 https://github.com/WebKit/WebKit/commit/6de0a6e596b6b251fe46c8b12b05a62aea4afb64 Author: Ryosuke Niwa Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: A LayoutTests/editing/style/apply-style-split-text-element-at-end-crash-expected.txt A LayoutTests/editing/style/apply-style-split-text-element-at-end-crash.html M Source/WebCore/editing/CompositeEditCommand.cpp M Source/WebCore/editing/SplitTextNodeContainingElementCommand.cpp Log Message: --- Crash in CheckedPtr::decrementPtrCount via SplitTextNodeContainingElementCommand::doApply https://bugs.webkit.org/show_bug.cgi?id=273581 Reviewed by Wenson Hsieh. The crash was caused by SplitTextNodeContainingElementCommand::doApply holding onto a CheckedPtr of RenderObject until across a call to splitElement, which could trigger a layout and delete the render object. Fixed the crash by reducing the scope of CheckedPtr. Also remove the debug assertion in CompositeEditCommand::appendNode which gets hit with the newly added test case. * LayoutTests/editing/style/apply-style-split-text-element-at-end-crash-expected.txt: Added. * LayoutTests/editing/style/apply-style-split-text-element-at-end-crash.html: Added. * Source/WebCore/editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::appendNode): * Source/WebCore/editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::doApply): Canonical link: https://commits.webkit.org/278242@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42db1b: Remove current macOS (mac-sonoma) from baseline se...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42db1bee0ebaa7a64103cbe43082bcbd7c1b0552 https://github.com/WebKit/WebKit/commit/42db1bee0ebaa7a64103cbe43082bcbd7c1b0552 Author: Sam Sneddon Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Tools/Scripts/webkitpy/port/mac.py M Tools/Scripts/webkitpy/port/mac_unittest.py Log Message: --- Remove current macOS (mac-sonoma) from baseline search path https://bugs.webkit.org/show_bug.cgi?id=273509 Reviewed by Jonathan Bedard. Per policy, we put all current macOS baselines in `mac` rather than `mac-sonoma`. Rather than relying on policy to enforce this, we should just remove `mac-sonoma` from the baseline search path, therefore meaning its baseline search path ends with `mac`. We're not currently changing the baseline search path when apple_additions exists, so if that defines a version name for current macOS it will remain in the search path. * Tools/Scripts/webkitpy/port/mac.py: (MacPort.default_baseline_search_path): * Tools/Scripts/webkitpy/port/mac_unittest.py: (MacTest.test_sonoma_baseline_search_path): Canonical link: https://commits.webkit.org/278241@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 68ea65: [Gardening]: [macOS iOS] Multiple tests in importe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 68ea65490ab1c606ac4a279bb817cc2ae1d9640b https://github.com/WebKit/WebKit/commit/68ea65490ab1c606ac4a279bb817cc2ae1d9640b Author: Marta Darbinyan Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: [macOS iOS] Multiple tests in imported/w3c/web-platform-tests/css* are constant failing https://bugs.webkit.org/show_bug.cgi?id=273595 rdar://127396069 Unreviewed test gardening. Adding test expectation * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/278240@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 484a4f: Safari crashes at WebKit::WebExtensionContext::ope...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 484a4fe7b14f08bae1bdccd3e68309bc1ec1ef38 https://github.com/WebKit/WebKit/commit/484a4fe7b14f08bae1bdccd3e68309bc1ec1ef38 Author: Timothy Hatcher Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICookiesCocoa.mm M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm M Source/WebKit/UIProcess/Extensions/WebExtensionContext.h Log Message: --- Safari crashes at WebKit::WebExtensionContext::openInspectors. https://webkit.org/b/273560 rdar://127189700 Reviewed by Brian Weinstein. Add a null check for _WKInspector befor tryign to get API::Inspector from it. Also moved extensionHasAccess() check to openWindows() and openTabs(), so the caller does not need to do it. A extensionHasAccess() check was missing in the openInspectors() loop of openTabs(). Also skip extra work with early returns for !hasInspectorBackgroundPage(). Finally, adopt WTF::compactMap and WTF::map() more. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext openWindows]): Pass IgnoreExtensionAccess::Yes since API should see all. (-[_WKWebExtensionContext openTabs]): Ditto. * Source/WebKit/UIProcess/Extensions/Cocoa/API/WebExtensionContextAPICookiesCocoa.mm: (WebKit::WebExtensionContext::cookiesGetAllCookieStores): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::openWindows const): (WebKit::WebExtensionContext::openTabs const): (WebKit::WebExtensionContext::openInspectors const): (WebKit::WebExtensionContext::loadedInspectors const): (WebKit::WebExtensionContext::inspectorExtension const): (WebKit::WebExtensionContext::inspector const): (WebKit::WebExtensionContext::processes const): (WebKit::WebExtensionContext::isInspectorBackgroundPage const): (WebKit::WebExtensionContext::isDevToolsMessageAllowed): Removed #ifdef since this method is already guarded by it. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: Canonical link: https://commits.webkit.org/278239@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d0941d: Remove no longer needed testing infrastructure fro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d0941d28f74c55fcfbcd60f512740b321d5611c7 https://github.com/WebKit/WebKit/commit/d0941d28f74c55fcfbcd60f512740b321d5611c7 Author: Robert Jenner Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Tools/CISupport/build-webkit-org/config.json M Tools/CISupport/build-webkit-org/factories_unittest.py M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js M Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/WebKitBuildbot.js M Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css M Tools/CISupport/build-webkit-org/steps_unittest.py Log Message: --- Remove no longer needed testing infrastructure from post-commit OpenSource rdar://127372525 https://bugs.webkit.org/show_bug.cgi?id=273562 Reviewed by Ryan Haddad. This fix removes no longer needed testing infrastructure from the configuration. It also adds Ventura JSC testers. * Tools/CISupport/build-webkit-org/config.json: * Tools/CISupport/build-webkit-org/factories_unittest.py: (TestExpectedBuildSteps): * Tools/CISupport/build-webkit-org/public_html/dashboard/Scripts/Dashboard.js: * Tools/CISupport/build-webkit-org/public_html/dashboard/Styles/Main.css: (table.queue-grid tr.platform.macos-monterey img.logo): Deleted. * Tools/CISupport/build-webkit-org/steps_unittest.py: Canonical link: https://commits.webkit.org/278238@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a3973: Harden JSLexicalEnvironment::getOwnPropertySlot by...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a39739f7cfb8a65349669480ccf4a6a9f023285 https://github.com/WebKit/WebKit/commit/1a39739f7cfb8a65349669480ccf4a6a9f023285 Author: Marcus Plutowski Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp M Source/JavaScriptCore/runtime/PropertySlot.h Log Message: --- Harden JSLexicalEnvironment::getOwnPropertySlot by asserting the attribute's accessor status https://bugs.webkit.org/show_bug.cgi?id=273492 rdar://12017 Reviewed by Keith Miller. This ensures that we don't call setValue on anything with an accessor attribute. * Source/JavaScriptCore/runtime/JSLexicalEnvironment.cpp: (JSC::JSLexicalEnvironment::getOwnPropertySlot): Canonical link: https://commits.webkit.org/278237@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 711b43: [ Ventura ] css3/filters/effect-drop-shadow-clip-a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 711b431d67041d8f1b27bb8c9793b5c6ca49506c https://github.com/WebKit/WebKit/commit/711b431d67041d8f1b27bb8c9793b5c6ca49506c Author: Said Abou-Hallawa Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M LayoutTests/css3/filters/effect-drop-shadow-clip-abspos.html M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [ Ventura ] css3/filters/effect-drop-shadow-clip-abspos.html(layout-tests) is a constant IMAGE failure https://bugs.webkit.org/show_bug.cgi?id=273419 rdar://127155318 [Filters] Unreviewed test gardening * LayoutTests/css3/filters/effect-drop-shadow-clip-abspos.html: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/278236@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 362c47: Forward availability notification from WebInspecto...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 362c47aa678d4a720ce0a5b0dd9b01b3b86529bb https://github.com/WebKit/WebKit/commit/362c47aa678d4a720ce0a5b0dd9b01b3b86529bb Author: Per Arne Vollan Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- Forward availability notification from WebInspector daemon https://bugs.webkit.org/show_bug.cgi?id=273586 rdar://126946795 Reviewed by Ben Nham. Forward availability notification from WebInspector daemon from the UI process to the WebContent processes. The notification handler in the WebContent process will not be called unless we forward the notification. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::registerNotificationObservers): * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/278235@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 681629: remoteViewToRootView is sync and can return result...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 681629886f58ad0eacf97bce0ced109574d5403b https://github.com/WebKit/WebKit/commit/681629886f58ad0eacf97bce0ced109574d5403b Author: Sihui Liu Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h Log Message: --- remoteViewToRootView is sync and can return result directly https://bugs.webkit.org/show_bug.cgi?id=273559 rdar://127376595 Reviewed by Charlie Wolfe. remoteViewToRootView does not need to take CompletionHandler as parameter. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::remoteViewToRootView): (WebKit::WebPage::remoteViewRectToRootView): (WebKit::WebPage::remoteViewPointToRootView): (WebKit::WebPage::remoteDictionaryPopupInfoToRootView): * Source/WebKit/WebProcess/WebPage/WebPage.h: Canonical link: https://commits.webkit.org/278234@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 03f4b6: Fix the MODEL_PROCESS build after 278224@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 03f4b61006b78fc7053a78fa282b14efe01829f9 https://github.com/WebKit/WebKit/commit/03f4b61006b78fc7053a78fa282b14efe01829f9 Author: Geoffrey Garen Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h Log Message: --- Fix the MODEL_PROCESS build after 278224@main https://bugs.webkit.org/show_bug.cgi?id=273579 rdar://127387527 Unreviewed, build fix. Added some more exceptions. * Source/WebKit/ModelProcess/ModelProcessModelPlayerManagerProxy.h: Canonical link: https://commits.webkit.org/278233@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b632e2: [visionOS] Add SPI module for LinearMediaKit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b632e2a90f9fc8d6894b80700dd023965cdd5ad6 https://github.com/WebKit/WebKit/commit/b632e2a90f9fc8d6894b80700dd023965cdd5ad6 Author: Elliott Williams Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/Configurations/WebKitSwift.xcconfig A Source/WebKit/Platform/spi/visionos/LinearMediaKit.swiftinterface M Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h M Source/WebKit/WebKitSwift/WebKitSwift.h Log Message: --- [visionOS] Add SPI module for LinearMediaKit rdar://127327242 https://bugs.webkit.org/show_bug.cgi?id=273527 Reviewed by Andy Estes. In order to build visionOS using the public SDK, WebKitSwift needs to `import LinearMediaKit`, which a private framework. For C-family framework we'd handle this by adding an SPI header, to go with auto-extracted TBDs in WebKitLibraries/. But because this is a Swift framework, we need an alternative. Add a handwritten LinearMediaKit.swiftinterface file to the relevant spi directory. This contains the subset of the framework that WebKit links against. In public SDK builds, SWIFT_INCLUDE_PATHS is modified to include this directory, making the module importable in public while falling back to the private framework's module internally. * Source/WebKit/Configurations/WebKitSwift.xcconfig: * Source/WebKit/Platform/spi/visionos/LinearMediaKit.swiftinterface: Added. * Source/WebKit/WebKitSwift/LinearMediaKit/WKSLinearMediaPlayer.h: In public builds, WebKitSwift does not implicitly have libxpc imported, so add an import of XPCSPI.h. * Source/WebKit/WebKitSwift/WebKitSwift.h: LinearMediaKitSPI.h doesn't need to be in private headers, as it's only used by WebKit itself. Fixes a TAPI error. Canonical link: https://commits.webkit.org/278232@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0de4d5: JSC cli should have a short option for useConcurre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0de4d5991ad42c9ab64d474d391978429e842e51 https://github.com/WebKit/WebKit/commit/0de4d5991ad42c9ab64d474d391978429e842e51 Author: Keith Miller Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/JavaScriptCore/jsc.cpp M Tools/Scripts/run-jsc-stress-tests Log Message: --- JSC cli should have a short option for useConcurrentJIT=0 https://bugs.webkit.org/show_bug.cgi?id=273528 rdar://127327863 Reviewed by Yusuke Suzuki. This is a commonly used option so it should have a short option. This patch makes the option `-s` for "synchronous compilation". Currently, this is used for signal handling but that's only used by the test harness so we can move that to a long option, `--signal-expected`. * Source/JavaScriptCore/jsc.cpp: (printUsageStatement): (CommandLine::parseArguments): * Tools/Scripts/run-jsc-stress-tests: Canonical link: https://commits.webkit.org/278231@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 84e133: [view-transitions] https://spotify-astro-transitio...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 84e133272f1e3d267014c0b78953c25750b3ed9b https://github.com/WebKit/WebKit/commit/84e133272f1e3d267014c0b78953c25750b3ed9b Author: Matt Woodrow Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped.html M Source/WebCore/rendering/RenderLayerBacking.cpp Log Message: --- [view-transitions] https://spotify-astro-transitions.vercel.app glitches due to incorrect layer position with overflow:hidden ancestor. https://bugs.webkit.org/show_bug.cgi?id=273537 Reviewed by Tim Nguyen. Rather than just moving the existing parent graphics layer rect (which isn't relevant, since this layer will be reparented), use the rect that the pseudo (to which this layer will be reparented) represents directly. It still needs to be moved into the coordinate space of the current compositing ancestor, since that's what the following code expects. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped-expected.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped-ref.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/new-content-ancestor-clipped.html: Added. * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGeometry): Canonical link: https://commits.webkit.org/278230@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de6652: Use an inline capacity 2 for the vector for LayerA...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de66522046aea3efe88c8e84ea2dbbec57fca03d https://github.com/WebKit/WebKit/commit/de66522046aea3efe88c8e84ea2dbbec57fca03d Author: Yusuke Suzuki Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/rendering/LayerOverlapMap.cpp M Source/WebCore/rendering/LayerOverlapMap.h M Source/WebCore/rendering/RenderLayerCompositor.cpp Log Message: --- Use an inline capacity 2 for the vector for LayerAndBounds https://bugs.webkit.org/show_bug.cgi?id=273539 rdar://127345908 Reviewed by Simon Fraser. We are repeatedly allocating this Vector, but elements are typically 1 or 2. We should have inline capacity for this as 2. * Source/WebCore/rendering/LayerOverlapMap.cpp: (WebCore::OverlapMapContainer::add): (WebCore::OverlapMapContainer::overlapsLayers const): (WebCore::OverlapMapContainer::ensureClippingScopeForLayers): (WebCore::OverlapMapContainer::findClippingScopeForLayers const): (WebCore::LayerOverlapMap::add): (WebCore::LayerOverlapMap::overlapsLayers const): * Source/WebCore/rendering/LayerOverlapMap.h: * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeClippingScopes const): Canonical link: https://commits.webkit.org/278229@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 139fe6: [ Ventura WK1 ] http/tests/media/hls/track-webvtt-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 139fe6341785549039de1d359da5ac10cc7ab8fd https://github.com/WebKit/WebKit/commit/139fe6341785549039de1d359da5ac10cc7ab8fd Author: Jay Stfleur Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [ Ventura WK1 ] http/tests/media/hls/track-webvtt-multitracks.html is a mostly timeout/crash https://bugs.webkit.org/show_bug.cgi?id=273577 rdar://127384137 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/278228@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7216e5: Update wpt html/canvas//fill-an...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7216e55773aff1733416f4311ab4a3a7210021a4 https://github.com/WebKit/WebKit/commit/7216e55773aff1733416f4311ab4a3a7210021a4 Author: Sam Weinig Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.currentcolor-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.currentcolor.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.colormix.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-1.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-2.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-3.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-4.png A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-negative-saturation-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-negative-saturation.html A LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsl-clamp-negative-saturation.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-1.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-2.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-3.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-4.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5-expected.txt R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5.html R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-5.png R LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.fillStyle.parse.hsla-clamp-6-expected.txt R
[webkit-changes] [WebKit/WebKit] a5997b: REGRESSION (278112@main): [ MacOS iOS ] TestWebKit...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a5997b3faeb5b7b4e4fcbb9309e509dd6c92 https://github.com/WebKit/WebKit/commit/a5997b3faeb5b7b4e4fcbb9309e509dd6c92 Author: Sam Weinig Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp Log Message: --- REGRESSION (278112@main): [ MacOS iOS ] TestWebKitAPI.Color.P3ConversionToSRGB is a consistent failure https://bugs.webkit.org/show_bug.cgi?id=273497 Reviewed by Tim Nguyen. Update results to account for change in gamut mapping from CSS gamut mapping to clipping. * Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp: (TestWebKitAPI::TEST(Color, P3ConversionToSRGB)): Canonical link: https://commits.webkit.org/278226@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 653366: Much more aggressively remove duplicate layout tes...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6533667eb99289893ebc466b6f0dfc97607604e0 https://github.com/WebKit/WebKit/commit/6533667eb99289893ebc466b6f0dfc97607604e0 Author: Sam Sneddon Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: A LayoutTests/compositing/layer-creation/fixed-position-scroll-expected.txt A LayoutTests/compositing/repaint/newly-composited-on-scroll-expected.txt A LayoutTests/compositing/webgl/webgl-no-alpha-expected.txt A LayoutTests/css3/filters/backdrop/blur-input-bounds-expected.txt A LayoutTests/css3/masking/clip-path-circle-border-box-expected.txt A LayoutTests/css3/masking/clip-path-circle-content-box-expected.txt A LayoutTests/css3/masking/clip-path-circle-padding-box-expected.txt A LayoutTests/fast/borders/mixed-border-style2-expected.txt A LayoutTests/fast/canvas/webgl/css-webkit-canvas-expected.txt A LayoutTests/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt A LayoutTests/fast/hidpi/device-scale-factor-paint-expected.txt A LayoutTests/fast/hidpi/focus-rings-expected.txt A LayoutTests/fast/writing-mode/broken-ideographic-font-expected.txt A LayoutTests/platform/glib/compositing/animation/state-at-end-event-transform-layer-expected.txt A LayoutTests/platform/glib/compositing/color-matching/image-color-matching-expected.txt A LayoutTests/platform/glib/compositing/color-matching/pdf-image-match-expected.txt A LayoutTests/platform/glib/compositing/compositing-visible-descendant-expected.txt A LayoutTests/platform/glib/compositing/direct-image-compositing-expected.txt A LayoutTests/platform/glib/compositing/generated-content-expected.txt A LayoutTests/platform/glib/compositing/geometry/abs-position-inside-opacity-expected.txt A LayoutTests/platform/glib/compositing/geometry/clipping-foreground-expected.txt A LayoutTests/platform/glib/compositing/geometry/composited-html-size-expected.txt A LayoutTests/platform/glib/compositing/geometry/fixed-in-composited-expected.txt A LayoutTests/platform/glib/compositing/geometry/fixed-position-expected.txt A LayoutTests/platform/glib/compositing/geometry/horizontal-scroll-composited-expected.txt A LayoutTests/platform/glib/compositing/geometry/layer-due-to-layer-children-deep-expected.txt A LayoutTests/platform/glib/compositing/geometry/layer-due-to-layer-children-expected.txt A LayoutTests/platform/glib/compositing/geometry/outline-change-expected.txt A LayoutTests/platform/glib/compositing/geometry/partial-layout-update-expected.txt A LayoutTests/platform/glib/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt A LayoutTests/platform/glib/compositing/geometry/vertical-scroll-composited-expected.txt A LayoutTests/platform/glib/compositing/geometry/video-fixed-scrolling-expected.txt A LayoutTests/platform/glib/compositing/geometry/video-opacity-overlay-expected.txt A LayoutTests/platform/glib/compositing/iframes/composited-iframe-alignment-expected.txt A LayoutTests/platform/glib/compositing/iframes/iframe-copy-on-scroll-expected.txt A LayoutTests/platform/glib/compositing/iframes/iframe-in-composited-layer-expected.txt A LayoutTests/platform/glib/compositing/iframes/invisible-nested-iframe-show-expected.txt A LayoutTests/platform/glib/compositing/iframes/resizer-expected.txt A LayoutTests/platform/glib/compositing/images/direct-image-background-color-expected.txt A LayoutTests/platform/glib/compositing/layers-inside-overflow-scroll-expected.txt A LayoutTests/platform/glib/compositing/masks/direct-image-mask-expected.txt A LayoutTests/platform/glib/compositing/masks/masked-ancestor-expected.txt A LayoutTests/platform/glib/compositing/masks/multiple-masks-expected.txt A LayoutTests/platform/glib/compositing/masks/simple-composited-mask-expected.txt A LayoutTests/platform/glib/compositing/overflow/ancestor-overflow-expected.txt A LayoutTests/platform/glib/compositing/overflow/fixed-position-ancestor-clip-expected.txt A LayoutTests/platform/glib/compositing/overflow/nested-scrolling-expected.txt A LayoutTests/platform/glib/compositing/overflow/overflow-compositing-descendant-expected.txt A LayoutTests/platform/glib/compositing/overflow/overflow-positioning-expected.txt A LayoutTests/platform/glib/compositing/overflow/overflow-scroll-expected.txt A LayoutTests/platform/glib/compositing/overflow/parent-overflow-expected.txt A LayoutTests/platform/glib/compositing/overflow/remove-overflow-crash2-expected.txt A LayoutTests/platform/glib/compositing/overflow/scroll-ancestor-update-expected.txt A LayoutTests/platform/glib/compositing/overflow/scrollbar-painting-expected.txt A LayoutTests/platform/glib/compositing/overflow/theme-affects-visual-overflow-expected.txt A
[webkit-changes] [WebKit/WebKit] c13321: Added a compile time assertion that forbids classe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c13321a96e1de0debe0e734a4b092001b22854aa https://github.com/WebKit/WebKit/commit/c13321a96e1de0debe0e734a4b092001b22854aa Author: Geoffrey Garen Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/JavaScriptCore/inspector/InspectorTarget.h M Source/JavaScriptCore/runtime/ConsoleClient.h M Source/JavaScriptCore/runtime/JSGlobalObject.cpp M Source/JavaScriptCore/runtime/JSGlobalObject.h M Source/WTF/wtf/CancellableTask.h M Source/WTF/wtf/ListHashSet.h M Source/WTF/wtf/NativePromise.h M Source/WTF/wtf/Observer.h M Source/WTF/wtf/TypeTraits.h M Source/WTF/wtf/WeakPtr.h M Source/WTF/wtf/WeakRef.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUBufferBinding.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCanvasConfiguration.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUImageCopyTexture.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUPipelineDescriptorBase.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUProgrammableStage.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassColorAttachment.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPURenderPassDepthStencilAttachment.h M Source/WebCore/Modules/applepay/PaymentCoordinator.h M Source/WebCore/Modules/audiosession/DOMAudioSession.h M Source/WebCore/Modules/encryptedmedia/CDMClient.h M Source/WebCore/Modules/encryptedmedia/MediaKeySystemClient.h M Source/WebCore/Modules/fetch/FormDataConsumer.h M Source/WebCore/Modules/gamepad/NavigatorGamepad.h M Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h M Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseManager.h M Source/WebCore/Modules/mediarecorder/MediaRecorder.h M Source/WebCore/Modules/mediasession/MediaSession.cpp M Source/WebCore/Modules/mediasession/MediaSession.h M Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h M Source/WebCore/Modules/mediasession/MediaSessionCoordinatorPrivate.h M Source/WebCore/Modules/mediastream/MediaStream.h M Source/WebCore/Modules/mediastream/MediaStreamTrack.h M Source/WebCore/Modules/mediastream/MediaStreamTrackProcessor.h M Source/WebCore/Modules/mediastream/PeerConnectionBackend.h M Source/WebCore/Modules/mediastream/RTCController.h M Source/WebCore/Modules/mediastream/RTCDataChannelRemoteHandler.h M Source/WebCore/Modules/mediastream/RTCDtlsTransport.h M Source/WebCore/Modules/mediastream/RTCDtlsTransportBackend.h M Source/WebCore/Modules/mediastream/RTCIceTransport.h M Source/WebCore/Modules/mediastream/RTCIceTransportBackend.h M Source/WebCore/Modules/mediastream/RTCRtpTransceiver.cpp M Source/WebCore/Modules/mediastream/RTCRtpTransceiver.h M Source/WebCore/Modules/mediastream/RTCSctpTransport.h M Source/WebCore/Modules/mediastream/RTCSctpTransportBackend.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerDtlsTransportBackend.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerDtlsTransportBackend.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceTransportBackend.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerIceTransportBackend.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpSenderBackend.h M Source/WebCore/Modules/mediastream/gstreamer/GStreamerSctpTransportBackend.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerSctpTransportBackend.h M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDtlsTransportBackend.h M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCIceTransportBackend.h M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.cpp M Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCSctpTransportBackend.h M Source/WebCore/Modules/model-element/ModelPlayerClient.h M Source/WebCore/Modules/model-element/scenekit/SceneKitModelLoaderClient.h M Source/WebCore/Modules/permissions/PermissionObserver.h M Source/WebCore/Modules/speech/SpeechRecognitionCaptureSourceImpl.h M Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h M Source/WebCore/Modules/speech/SpeechRecognitionRequest.h M Source/WebCore/Modules/speech/SpeechRecognizer.h M Source/WebCore/Modules/storage/StorageManager.cpp M Source/WebCore/Modules/storage/StorageManager.h M
[webkit-changes] [WebKit/WebKit] 1d96c3: REGRESSION(278148@main): random crashes under JSC:...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d96c3185c84598869508e1ac51538952efb7912 https://github.com/WebKit/WebKit/commit/1d96c3185c84598869508e1ac51538952efb7912 Author: Yusuke Suzuki Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp M Source/JavaScriptCore/jit/GCAwareJITStubRoutine.h Log Message: --- REGRESSION(278148@main): random crashes under JSC::WatchpointSet::fireAllWatchpoints https://bugs.webkit.org/show_bug.cgi?id=273467 rdar://127346958 Reviewed by Justin Michaud, Keith Miller and Mark Lam. PolymorphicAccessJITStubRoutine::invalidate clears StructureStubInfo, and this may deref PolymorphicAccessJITStubRoutine itself held by InlineCacheHandler. But at the same time, PolymorphicAccessJITStubRoutine is half-GC-managed, so this `invalidate` function can be called when PolymorphicAccessJITStubRoutine's refCount is zero, and will be destroyed by GC. So, in this patch, 1. We just clear WatchpointSet when PolymorphicAccessJITStubRoutine's refCount becomes zero. 2. Inside PolymorphicAccessJITStubRoutine::invalidate, we just capture WatchpointSet and fire them all instead of keeping PolymorphicAccessJITStubRoutine alive. * Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp: (JSC::PolymorphicAccessJITStubRoutine::invalidate): Canonical link: https://commits.webkit.org/278223@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d85dda: [Site Isolation] Document::isTopDocument should re...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d85ddaf99d035414fda2f2974bee09751b6ad50e https://github.com/WebKit/WebKit/commit/d85ddaf99d035414fda2f2974bee09751b6ad50e Author: Sihui Liu Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h Log Message: --- [Site Isolation] Document::isTopDocument should return false for document of subframe https://bugs.webkit.org/show_bug.cgi?id=273510 rdar://127308766 Reviewed by Alex Christensen. Currently `Document::isTopDocument` can return true when `Document` is in a subframe, as `Document::topDocument` returns `this` when main frame is remote. When main frame is remote, the document cannot be top-level document, as the top-level document should be in the same process as the main frame. To fix this, this patch makes `Document::isTopDocument` return true only when main frame is local and main frame's document is the same as `this` (there could be multiple documents pointing to the same frame, but only the one in use by frame can be the top). This change will make sure `Document::isSameSiteForCookies` return the correct value and cookie test passes when site isolation flag is enabled. To avoid breakage, the patch adds `Document::isTopDocumentLegacy`, which implements the old behavior of `Document::isTopDocument`. `Document::isTopDocumentLegacy` is used when site isolation is not enabled, and at places where new `Document::isTopDocument` implementation would cause breakage. We will migrate those call sites to use `Document::isTopDocument` later. Test: http/tests/cookies/same-site/popup-cross-site-from-cross-origin-iframe.html. * Source/WebCore/dom/Document.cpp: (WebCore::Document::isTopDocument const): * Source/WebCore/dom/Document.h: (WebCore::Document::setUserDidInteractWithPage): (WebCore::Document::userDidInteractWithPage const): (WebCore::Document::isTopDocumentLegacy const): (WebCore::Document::isTopDocument const): Deleted. Canonical link: https://commits.webkit.org/278222@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] df0f17: Select primary font for missing glyph for PUA char...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: df0f17533ab4c17991214087049e647a68754ce5 https://github.com/WebKit/WebKit/commit/df0f17533ab4c17991214087049e647a68754ce5 Author: Vitor Roriz Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/mac/fast/text/softbank-emoji-expected.txt M LayoutTests/platform/wpe/fast/text/softbank-emoji-expected.txt M Source/WebCore/platform/graphics/FontCascadeFonts.cpp Log Message: --- Select primary font for missing glyph for PUA characters https://bugs.webkit.org/show_bug.cgi?id=273233 rdar://124036223 Reviewed by Antti Koivisto. We used to render the missing glyph for PUA characters (see [1]) with the lastResortFontFallback, instead of the primary font. This is done by FontCascadeFonts::glyphDataForVariant(...) producing a GlyphData object with such font for the missing glyph (glyph 0). The ComplexTextController, which handles complex text, would always use the primary font for getting metrics for the missing glyph. When rendering PUA characters we would use the simple path (WidthIterator is used instead of ComplexTextController), selecting the last resort font both for layout and painting. However, when computing the caret position, we still use the ComplexTextController because WidthIterator can't handle partial runs with ligatures (for example). This would result in WidthIterator being used for layout/painting and selecting the lastResortFont, and ComplexTextController being used for calculating the caret position, selecting the primary font. We are fixing it by updating the special case for PUA character and selecting the primary font for such case, instead of the lastResortFont. This also has the benefit of enforcing interoperability with other browser, as Blink and Gecko seem to also use the primary font selected by the author. [1] https://commits.webkit.org/269524@main * LayoutTests/platform/mac/fast/text/softbank-emoji-expected.txt: * LayoutTests/platform/wpe/fast/text/softbank-emoji-expected.txt: - Rebasing this test since they contain PUA characters and font will change. * LayoutTests/TestExpectations: - We should pass this test now. * Source/WebCore/platform/graphics/FontCascadeFonts.cpp: (WebCore::FontCascadeFonts::glyphDataForVariant): - Using primary font instead of last resort font for glyph 0 when PUA characters can't be mapped by selected fonts. Canonical link: https://commits.webkit.org/278221@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd68ed: [PlayStation] Hook in rendering to GPU Process
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd68edac9b94617cdb1a1c59ed67b2955b7fef8a https://github.com/WebKit/WebKit/commit/cd68edac9b94617cdb1a1c59ed67b2955b7fef8a Author: Don Olmstead Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/PlatformPlayStation.cmake M Source/WebKit/GPUProcess/EntryPoint/playstation/GPUProcessMain.cpp M Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp M Source/WebKit/UIProcess/playstation/PageClientImpl.cpp M Source/WebKit/UIProcess/playstation/PageClientImpl.h M Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp Log Message: --- [PlayStation] Hook in rendering to GPU Process https://bugs.webkit.org/show_bug.cgi?id=261055 Reviewed by Fujii Hironori. Add in the plumbing to render the scene in the GPU Process. * Source/WebCore/PlatformPlayStation.cmake: * Source/WebKit/GPUProcess/EntryPoint/playstation/GPUProcessMain.cpp: (main): * Source/WebKit/GPUProcess/playstation/GPUProcessPlayStation.cpp: (WebKit::GPUProcess::platformInitializeGPUProcess): * Source/WebKit/UIProcess/playstation/PageClientImpl.cpp: (WebKit::PageClientImpl::viewWidget): * Source/WebKit/UIProcess/playstation/PageClientImpl.h: * Source/WebKit/UIProcess/playstation/WebPageProxyPlayStation.cpp: (WebKit::WebPageProxy::viewWidget): Canonical link: https://commits.webkit.org/278220@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 44d346: Decoupling from-font resolution from FontCascadeFo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 44d3464ef15e7080e9de1350c0daaa66ac4e315a https://github.com/WebKit/WebKit/commit/44d3464ef15e7080e9de1350c0daaa66ac4e315a Author: Vitor Roriz Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/css/ComputedStyleExtractor.cpp M Source/WebCore/platform/graphics/FontCascade.h M Source/WebCore/platform/graphics/FontCascadeDescription.cpp M Source/WebCore/platform/graphics/FontCascadeDescription.h M Source/WebCore/platform/graphics/FontCascadeFonts.h M Source/WebCore/platform/graphics/FontSizeAdjust.h Log Message: --- Decoupling from-font resolution from FontCascadeFonts::primaryFont https://bugs.webkit.org/show_bug.cgi?id=273339 rdar://127132471 Reviewed by Brent Fulgham. font-size-adjust from-font resolution was fixed by [1]. It now works correctly and it uses the primary font for resolution. However, this patch changed FontCascadeFonts::primaryFont to receive a mutable (non-const) FontCascadeDescription object, such that it could resolve the from-font reference after the primary font is resolved. This means that now FontCascadeFonts::primaryFont does two different things: a) resolving and caching a font as the primary font b) resolving from-font according to the primary font if necessary The (a) part of primaryFont doesn't require a mutable FontCascadeDescription. We can update FontCascadeDescription to have a method for resolving font-size-adjust from-font at the point where we own a mutable FontCascadeDescription instead. This allows us to compute the primaryFont itself from places where we only have access to a const FontCascadeDescription. This is for example, required for solving https://bugs.webkit.org/show_bug.cgi?id=273233, where we need to access to primaryFont from FontCascadeFonts::glyphDataForVariant This patch should have no side effects, as it is a preparation for solving 273233. [1] https://commits.webkit.org/269041@main * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::fontSizeAdjustFromStyle): * Source/WebCore/platform/graphics/FontCascade.h: (WebCore::FontCascade::primaryFont const): * Source/WebCore/platform/graphics/FontCascadeDescription.cpp: (WebCore::FontCascadeDescription::resolveFontSizeAdjustFromFontIfNeeded): * Source/WebCore/platform/graphics/FontCascadeDescription.h: * Source/WebCore/platform/graphics/FontCascadeFonts.h: (WebCore::FontCascadeFonts::primaryFont): * Source/WebCore/platform/graphics/FontSizeAdjust.h: (WebCore::FontSizeAdjust::shouldResolveFromFont const): Canonical link: https://commits.webkit.org/278219@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c98cf: Remove configure-xcode-for-embedded-development
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c98cfba342987c1b9d811e2aff980a9bdefc996 https://github.com/WebKit/WebKit/commit/9c98cfba342987c1b9d811e2aff980a9bdefc996 Author: Elliott Williams Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M ReadMe.md M Tools/Scripts/configure-xcode-for-embedded-development M Websites/webkit.org/languages.md Log Message: --- Remove configure-xcode-for-embedded-development https://bugs.webkit.org/show_bug.cgi?id=272053 rdar://125864015 Reviewed by Alexey Proskuryakov and Jonathan Bedard. Since WebKit's move to additions SDKs last summer and changes to how XCBuild loads specifications in 2022, we no longer need to modify Xcode to build embedded platforms. * ReadMe.md: Remove reference to the script and merge the Mac / embedded build sections, since there is less of a difference between them now. * Tools/Scripts/configure-xcode-for-embedded-development: Replaced with an error message that the script is no longer needed. * Websites/webkit.org/languages.md: Remove reference to the script. Canonical link: https://commits.webkit.org/278218@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 86923d: Move HistoryController from FrameLoader to Frame
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 86923db91ca26a33b62c677e9494e0b3448acf60 https://github.com/WebKit/WebKit/commit/86923db91ca26a33b62c677e9494e0b3448acf60 Author: Charlie Wolfe Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/history/BackForwardCache.cpp M Source/WebCore/loader/DocumentLoader.cpp M Source/WebCore/loader/DocumentWriter.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/FrameLoader.h M Source/WebCore/loader/HistoryController.cpp M Source/WebCore/loader/HistoryController.h M Source/WebCore/page/Frame.cpp M Source/WebCore/page/Frame.h M Source/WebCore/page/History.cpp M Source/WebCore/page/NavigationHistoryEntry.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/testing/Internals.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebView.mm Log Message: --- Move HistoryController from FrameLoader to Frame rdar://127331154 https://bugs.webkit.org/show_bug.cgi?id=273529 Reviewed by Alex Christensen. Move HistoryController to Frame so that it can be accessed on remote frames. This is work towards making the back forward list work with site isolation. * Source/WebCore/history/BackForwardCache.cpp: (WebCore::canCacheFrame): * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::willSendRequest): * Source/WebCore/loader/DocumentWriter.cpp: (WebCore::DocumentWriter::begin): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadInSameDocument): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::dispatchDidFailProvisionalLoad): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::restoreScrollPositionAndViewStateNowIfNeeded): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::scrollToFragmentWithParentBoundary): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent const): (WebCore::FrameLoader::loadSameDocumentItem): (WebCore::FrameLoader::loadDifferentDocumentItem): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad): (WebCore::FrameLoader::updateNavigationAPIEntries): (WebCore::FrameLoader::checkedHistory const): Deleted. * Source/WebCore/loader/FrameLoader.h: * Source/WebCore/loader/HistoryController.cpp: (WebCore::HistoryController::HistoryController): (WebCore::HistoryController::saveScrollPositionAndViewStateToItem): (WebCore::HistoryController::protectedFrame const): (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::saveDocumentState): (WebCore::HistoryController::saveDocumentAndScrollState): (WebCore::HistoryController::restoreDocumentState): (WebCore::HistoryController::invalidateCurrentItemCachedPage): (WebCore::HistoryController::goToItem): (WebCore::HistoryController::updateForBackForwardNavigation): (WebCore::HistoryController::updateForReload): (WebCore::HistoryController::updateForStandardLoad): (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList): (WebCore::HistoryController::updateForClientRedirect): (WebCore::HistoryController::updateForCommit): (WebCore::HistoryController::recursiveUpdateForCommit): (WebCore::HistoryController::updateForSameDocumentNavigation): (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation): (WebCore::HistoryController::clearPreviousItem): (WebCore::HistoryController::initializeItem): (WebCore::HistoryController::createItemTree): (WebCore::HistoryController::recursiveSetProvisionalItem): (WebCore::HistoryController::recursiveGoToItem): (WebCore::HistoryController::updateBackForwardListClippedAtTarget): (WebCore::HistoryController::updateCurrentItem): (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState): * Source/WebCore/loader/HistoryController.h: * Source/WebCore/page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::checkedHistory const): * Source/WebCore/page/Frame.h: (WebCore::Frame::history const): * Source/WebCore/page/History.cpp: (WebCore::History::scrollRestoration const): (WebCore::History::setScrollRestoration):
[webkit-changes] [WebKit/WebKit] a56e42: Deploy more smart pointers in Source/WebKit/GPUPro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a56e420ab7cab7428f255ba397a557e51c87a118 https://github.com/WebKit/WebKit/commit/a56e420ab7cab7428f255ba397a557e51c87a118 Author: Ryosuke Niwa Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/GPUProcess/GPUProcess.cpp M Source/WebKit/Shared/AuxiliaryProcess.h Log Message: --- Deploy more smart pointers in Source/WebKit/GPUProcess/GPUProcess.cpp https://bugs.webkit.org/show_bug.cgi?id=273531 Reviewed by Tim Nguyen. Deployed more smart pointers in Source/WebKit/GPUProcess/GPUProcess.cpp as warned by the clang static analyzer. * Source/WebKit/GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::tryExitIfUnused): (WebKit::GPUProcess::updateCaptureAccess): (WebKit::GPUProcess::updateCaptureOrigin): * Source/WebKit/Shared/AuxiliaryProcess.h: (WebKit::AuxiliaryProcess::protectedParentProcessConnection const): Canonical link: https://commits.webkit.org/278216@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 926918: [iOS] Unable to autofill username-only pages in WK...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 926918ec35d91e1c20a16e5e43ce483fc06e3bad https://github.com/WebKit/WebKit/commit/926918ec35d91e1c20a16e5e43ce483fc06e3bad Author: Aditya Keerthi Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/editing/cocoa/AutofillElements.cpp M Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm Log Message: --- [iOS] Unable to autofill username-only pages in WKWebView https://bugs.webkit.org/show_bug.cgi?id=273538 rdar://126970887 Reviewed by Wenson Hsieh and Abrar Rahman Protyasha. As a result of UIKit / AutoFillUI changes in iOS 17.4, username autofill is now displayed as a suggestion in the keyboard candidates bar on pages that separate out their username and password fields, like yahoo.com. Previously, this autofill flow was only available to pages that contained both a username and password field together. However, the introduction of standalone username support was a consequence of other feature work, and never explicitly tested in WKWebView. Due to the way autofill text suggestions are set up in WebKit, attempting to autofill a standalone username field, simply drops the content. Specifically, `AutofillElements::computeAutofillElements` returns `std::nullopt` if no password field is present. This means that when a username is autofilled using `-[WKContentView insertTextSuggestion:]` and `WebPageProxy::autofillLoginCredentials`, the data is simply dropped by an early return in `WebPage::autofillLoginCredentials`. Fix by updating `AutofillElements::computeAutofillElements` to handle the username-only case. * Source/WebCore/editing/cocoa/AutofillElements.cpp: (WebCore::AutofillElements::computeAutofillElements): Support for autofilling specific fields is already present in `AutofillElements::autofill`, which null checks each individual autofill element, including the username field. However, this method currently returns no elements in the case where only a username field is present. Update to return the username field in the case where the `autocomplete` value is "username". This restriction corresponds to the specification of `UITextContentTypeUsername` on the UI process side. * Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm: (TestWebKitAPI::TEST(WKWebViewAutoFillTests, StandaloneUsernameField)): Canonical link: https://commits.webkit.org/278215@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40274a: [cocoa] Block response from localhost for mixed co...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40274a8fb39df8ee3974a16846a5bb00780253c8 https://github.com/WebKit/WebKit/commit/40274a8fb39df8ee3974a16846a5bb00780253c8 Author: Matthew Finkel Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/platform/network/DNS.cpp M Source/WebCore/platform/network/DNS.h M Source/WebKit/NetworkProcess/NetworkDataTask.cpp M Source/WebKit/NetworkProcess/NetworkDataTask.h M Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp M Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.cpp M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp Log Message: --- [cocoa] Block response from localhost for mixed content if not loopback https://bugs.webkit.org/show_bug.cgi?id=272955 rdar://126729658 Reviewed by Brent Fulgham. In general, localhost could resolve to any IP address, but the expectation is that it resolves to either 127.0.0.1 as an IPv4 and [::1] as IPv6. This change looks at the resolved IP address and blocks the response if we are loading a subresource from localhost over plaintext HTTP and the main document was loaded with HTTPS (and it wasn't from localhost). * Source/WebCore/platform/network/DNS.cpp: (WebCore::IPAddress::isLoopback const): * Source/WebCore/platform/network/DNS.h: * Source/WebKit/NetworkProcess/NetworkDataTask.cpp: (WebKit::NetworkDataTask::didReceiveResponse): * Source/WebKit/NetworkProcess/NetworkDataTask.h: * Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse): * Source/WebKit/NetworkProcess/NetworkDataTaskDataURL.cpp: (WebKit::NetworkDataTaskDataURL::didDecodeDataURL): * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::didReceiveResponse): * Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp: (WebKit::NetworkDataTaskCurl::invokeDidReceiveResponse): * Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp: (WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse): Canonical link: https://commits.webkit.org/278214@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14cbb5: [JSC] Threading Concurrency::MainThread in isWatch...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14cbb53aba694170b8552181b637f263df97df4f https://github.com/WebKit/WebKit/commit/14cbb53aba694170b8552181b637f263df97df4f Author: Yusuke Suzuki Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/JavaScriptCore/bytecode/AccessCase.cpp M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp M Source/JavaScriptCore/bytecode/ObjectPropertyCondition.cpp M Source/JavaScriptCore/bytecode/ObjectPropertyCondition.h M Source/JavaScriptCore/bytecode/PropertyCondition.cpp M Source/JavaScriptCore/bytecode/PropertyCondition.h Log Message: --- [JSC] Threading Concurrency::MainThread in isWatchableAssumingImpurePropertyWatchpoint https://bugs.webkit.org/show_bug.cgi?id=273540 rdar://127348006 Reviewed by Justin Michaud. We should thread Concurrency::MainThread when calling isWatchableAssumingImpurePropertyWatchpoint from main thread code. * Source/JavaScriptCore/bytecode/AccessCase.cpp: (JSC::AccessCase::couldStillSucceed const): * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: (JSC::InlineCacheCompiler::generateImpl): * Source/JavaScriptCore/bytecode/ObjectPropertyCondition.cpp: (JSC::ObjectPropertyCondition::isWatchableAssumingImpurePropertyWatchpoint const): * Source/JavaScriptCore/bytecode/ObjectPropertyCondition.h: * Source/JavaScriptCore/bytecode/PropertyCondition.cpp: (JSC::PropertyCondition::isWatchableAssumingImpurePropertyWatchpoint const): * Source/JavaScriptCore/bytecode/PropertyCondition.h: Canonical link: https://commits.webkit.org/278213@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53e67f: REGRESSION(277450@main): OOB array read with SVG a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53e67f679530f17b29fa09c1ca2af78cb1b0e0e4 https://github.com/WebKit/WebKit/commit/53e67f679530f17b29fa09c1ca2af78cb1b0e0e4 Author: Scott Marcy Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: A LayoutTests/svg/animations/animate-zero-keyPoints-should-not-crash-expected.txt A LayoutTests/svg/animations/animate-zero-keyPoints-should-not-crash.html M Source/WebCore/svg/SVGAnimationElement.cpp Log Message: --- REGRESSION(277450@main): OOB array read with SVG animation where keyPoints = 0. https://bugs.webkit.org/show_bug.cgi?id=272929 rdar://126636733 Reviewed by Said Abou-Hallawa. This change makes a couple additional, similar changes to the original changes to better track the SVG spec. (See the original bug for more information.) * LayoutTests/svg/animations/animate-zero-keyPoints-should-not-crash-expected.txt: Added. * LayoutTests/svg/animations/animate-zero-keyPoints-should-not-crash.html: Added. * Source/WebCore/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::keyTimes const): (WebCore::SVGAnimationElement::startedActiveInterval): Canonical link: https://commits.webkit.org/278212@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ead27: Fix test indicator position for site-isolated perf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ead2727f1b4d0230891b6359fbd7629e7cf905e https://github.com/WebKit/WebKit/commit/0ead2727f1b4d0230891b6359fbd7629e7cf905e Author: Pascoe Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in Log Message: --- Fix test indicator position for site-isolated performImmediateActionHitTestAtLocation https://bugs.webkit.org/show_bug.cgi?id=273410 rdar://127120734 Reviewed by Sihui Liu. Currently the actions resulting from performImmediateActionHitTestAtLocation have an offset position, because they are placed relative to the iframe. To fix this, we consult the parent processes to calculate the position relative to the main frame. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didPerformImmediateActionHitTest): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::remoteDictionaryPopupInfoToRootView): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/278210@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 70e44f: [Site Isolation] Notify all web processes when a f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 70e44fdaed0301c38ae30ecb50711dbc1a09268d https://github.com/WebKit/WebKit/commit/70e44fdaed0301c38ae30ecb50711dbc1a09268d Author: Charlie Wolfe Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M LayoutTests/platform/mac-site-isolation/TestExpectations M Source/WebCore/loader/LocalFrameLoaderClient.h M Source/WebCore/page/LocalDOMWindow.cpp M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebPageProxy.messages.in M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in Log Message: --- [Site Isolation] Notify all web processes when a frame name has changed rdar://127323660 https://bugs.webkit.org/show_bug.cgi?id=273524 Reviewed by Pascoe. If an iframe name is set inline we send it when creating a remote frame in other processes. If a frame name was changed by JavaScript, we need to notify other processes that it has changed. * LayoutTests/platform/mac-site-isolation/TestExpectations: * Source/WebCore/loader/LocalFrameLoaderClient.h: * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::setName): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::frameNameChanged): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxy.messages.in: * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::frameNameChanged): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::frameNameWasChangedInAnotherProcess): * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/278211@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c1c858: Duolingo continue/next bar trails off of viewport
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c1c858cf081e67326c44328c12ab5ddb53a8799b https://github.com/WebKit/WebKit/commit/c1c858cf081e67326c44328c12ab5ddb53a8799b Author: Alan Baradlay Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: A LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid-expected.html A LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid.html M Source/WebCore/rendering/RenderBox.cpp Log Message: --- Duolingo continue/next bar trails off of viewport https://bugs.webkit.org/show_bug.cgi?id=273526 Reviewed by Antti Koivisto. When a box changes containing block through style mutation (e.g. by going from out-of-flow to inflow), its (grid/flex driven) override value becomes stale. (note that these override values are apparently sticky and we have to keep them around in-between layouts for example to be able to resolve percent padding values for getComputedStyle) * LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid-expected.html: Added. * LayoutTests/fast/dynamic/out-of-flow-going-in-flow-inside-grid.html: Added. * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutPositionedObject): Canonical link: https://commits.webkit.org/278209@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2a15af: Web Inspector: Top or bottom of Web Inspector is c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2a15afd431a01ae3aeb4a971e919a0669ace0399 https://github.com/WebKit/WebKit/commit/2a15afd431a01ae3aeb4a971e919a0669ace0399 Author: Razvan Caliman Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js M Source/WebInspectorUI/UserInterface/Views/QuickConsole.js M Source/WebInspectorUI/UserInterface/Views/Variables.css Log Message: --- Web Inspector: Top or bottom of Web Inspector is cut off on short viewports https://bugs.webkit.org/show_bug.cgi?id=273506 rdar://117272735 Reviewed by Devin Rousso. The Console Drawer was allowed to be resized to an arbitrarily capped maximum height of `` that did not take into account the minimum height defined by the Tab Browser or the space taken up by the Quick Console. Their common container is an absolutely-positioned flex container that has its overflow hidden by `overflow: hidden` on the Web Inspector ``. So when the Console Drawer was oversized, it pushed either the Quick Console or the top of the Tab bar beyond the visible viewport, depending on the successive layout operations (CSS and programmatic) that occur during Web Inspector launch. The patch sets a maximum height for the Console Drawer that is calculated explicitly. * Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js: (WI.ConsoleDrawer.prototype._updateDrawerHeight): * Source/WebInspectorUI/UserInterface/Views/QuickConsole.js: * Source/WebInspectorUI/UserInterface/Views/Variables.css: (:root): Canonical link: https://commits.webkit.org/278208@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 989aca: Regression(278060@main): Unreviewed, build error w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 989aca0e762edaeac7073a43dc8cd4c0a6c09eb5 https://github.com/WebKit/WebKit/commit/989aca0e762edaeac7073a43dc8cd4c0a6c09eb5 Author: Przemyslaw Gorszkowski Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/Modules/mediasource/MediaSource.cpp Log Message: --- Regression(278060@main): Unreviewed, build error with ENABLE_RELEASE_LOG=OFF and ENABLE_JOURNALD_LOG=OFF https://bugs.webkit.org/show_bug.cgi?id=273493 It fixes a compiler error: unused parameter ‘time’ when it is compiled with ENABLE_RELEASE_LOG=OFF and ENABLE_JOURNALD_LOG=OFF and USE_OS_LOG=OFF * Source/WebCore/Modules/mediasource/MediaSource.cpp: (WebCore::MediaSource::seeked): Canonical link: https://commits.webkit.org/278207@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 088a3e: Adopt more smart pointers in LocalFrame
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 088a3e573b59664dc988291e52900bba6b106b2c https://github.com/WebKit/WebKit/commit/088a3e573b59664dc988291e52900bba6b106b2c Author: Rob Buis Date: 2024-05-01 (Wed, 01 May 2024) Changed paths: M Source/WebCore/page/LocalFrame.cpp Log Message: --- Adopt more smart pointers in LocalFrame https://bugs.webkit.org/show_bug.cgi?id=273397 Reviewed by Sihui Liu. Adopt more smart pointers in LocalFrame based on the [alpha.webkit.UncountedLocalVarsChecker] warning. * Source/WebCore/page/LocalFrame.cpp: (WebCore::parentPageZoomFactor): (WebCore::parentTextZoomFactor): (WebCore::rootFrame): (WebCore::LocalFrame::LocalFrame): (WebCore::LocalFrame::~LocalFrame): (WebCore::LocalFrame::shouldUsePrintingLayout const): (WebCore::LocalFrame::frameForWidget): (WebCore::LocalFrame::rangeForPoint): (WebCore::LocalFrame::debugDescription const): (WebCore::LocalFrame::contentFrameFromWindowOrFrameElement): Canonical link: https://commits.webkit.org/278206@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d3fc36: REGRESSION (272891@main): [ Sonoma wk1 ] 3 tests i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3fc36c7d5eb0ad8630af11137d9b522a65c6399 https://github.com/WebKit/WebKit/commit/d3fc36c7d5eb0ad8630af11137d9b522a65c6399 Author: Said Abou-Hallawa Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-grayscale.html M LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-sepia.html M LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/filters-grayscale-001-test.html M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- REGRESSION (272891@main): [ Sonoma wk1 ] 3 tests in imported/w3c/web-platform-tests/css/filter-effects are constant failures https://bugs.webkit.org/show_bug.cgi?id=270199 rdar://123723468 [Filters] Unreviewed test gardening Add enough pixel tolerance to three of the WPT tests. * LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-grayscale.html: * LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-sepia.html: * LayoutTests/imported/w3c/web-platform-tests/css/filter-effects/filters-grayscale-001-test.html: * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/278205@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
