[webkit-changes] [WebKit/WebKit] ae3780: [Cococa] Ensure temporary PDF file paths are writt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae3780f0dcc35faca0a21110e00f5955a0cd00c7 https://github.com/WebKit/WebKit/commit/ae3780f0dcc35faca0a21110e00f5955a0cd00c7 Author: Brent Fulgham Date: 2024-05-27 (Mon, 27 May 2024) Changed paths: M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm Log Message: --- [Cococa] Ensure temporary PDF file paths are written matching the meaning of their relevant file URLs https://bugs.webkit.org/show_bug.cgi?id=274695 Reviewed by Abrar Rahman Protyasha. Correct pathToPDFOnDisk so that it creates un-encoded files from file URLs, since NSWorkspace always decodes it's URL path arguments before passing to relevant helper applications to open. This ensures that an attempt to open a temporary file for a PDF like "some%20test.pdf" will create a temporary "some\ test.pdf" on disk, which will then be found by NSWorkspace when it is given the encoded file URL. * Source/WebKit/UIProcess/mac/WebPageProxyMac.mm: (WebKit::pathToPDFOnDisk): Canonical link: https://commits.webkit.org/279359@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15eafe: [Cocoa] Silence some spurious telemetry about read...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15eafe817db29471f3f4ce2a16181401aed40770 https://github.com/WebKit/WebKit/commit/15eafe817db29471f3f4ce2a16181401aed40770 Author: Brent Fulgham Date: 2024-05-21 (Tue, 21 May 2024) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- [Cocoa] Silence some spurious telemetry about reading the "kern.willshutdown" sysctl https://bugs.webkit.org/show_bug.cgi?id=274422 Reviewed by Per Arne Vollan. Telemetry confirms we benefit form allowing systcl-read for "kern.willshutdown" under more conditions, and should allow it. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/279072@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c741b1: REGRESSION(266644@main):[ macOS WK1 ] report-origi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c741b1a50100c46daa4c10c0c06ed3bb1a65c35d https://github.com/WebKit/WebKit/commit/c741b1a50100c46daa4c10c0c06ed3bb1a65c35d Author: Brent Fulgham Date: 2024-05-08 (Wed, 08 May 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/reporting/report-original-url-on-mixed-content-frame.https.sub-expected.txt Log Message: --- REGRESSION(266644@main):[ macOS WK1 ] report-original-url-on-mixed-content-frame.https.sub.html is a constant text failure https://bugs.webkit.org/show_bug.cgi?id=266047 Reviewed by Tim Nguyen. The original result for LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-original-url-on-mixed-content-frame.https.sub-expected.txt was failure on all platforms. Ryan's work in 266644@main progressed this test case in modern WebKit, and he checked that expectation in. Unfortunately, WebKitLegacy relies on a PingHandle implementation that cannot authenticate against https (which is a missing feature in the entire deprecated WebKitLegacy platform for the old PingHandle implementation). We do to intend to invest time working on implementing such a feature in WebKitLegacy, so we expect this test to fail. This patch lands a new WebKitLegacy test expectation to document the expected behavior. Note that the console output on WebKitLegacy shows that the load was blocked properly in WebKitLegacy. It is only the Reporting API message that fails in this test, simply because WebKitLegacy cannot handle the mixture of an insecure main page sending reports to an secure reporting target. * LayoutTests/platform/mac-wk1/TestExpectations: * LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/content-security-policy/reporting/report-original-url-on-mixed-content-frame.https.sub-expected.txt: Added. Canonical link: https://commits.webkit.org/278543@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc88c3: [GPUP][macOS] Add read access to sysctl properties...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc88c33a969459327c2441aaefb8ec38d9c3b6c3 https://github.com/WebKit/WebKit/commit/dc88c33a969459327c2441aaefb8ec38d9c3b6c3 Author: Brent Fulgham Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in Log Message: --- [GPUP][macOS] Add read access to sysctl properties to match iOS https://bugs.webkit.org/show_bug.cgi?id=273704 Reviewed by Per Arne Vollan. In Bug 236018 we added `kern.bootargs` to the iOS sandbox to reduce telemetry, and because it was needed to support control of certain system behaviors at boot time. We should have added this to the macOS sandbox at the time, but did not. This patch brings the two sandboxes into alignment, and avoids sandbox telemetry that hides more useful findings. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: Canonical link: https://commits.webkit.org/278364@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 371cab: Avoid copying FontPalette and FontVariantAlternates
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 371cab863ee8cb0010261fddb8e0435391fc4dbd https://github.com/WebKit/WebKit/commit/371cab863ee8cb0010261fddb8e0435391fc4dbd Author: Brent Fulgham Date: 2024-05-03 (Fri, 03 May 2024) Changed paths: M Source/WebCore/animation/CSSPropertyAnimation.cpp M Source/WebCore/platform/graphics/FontDescription.h M Source/WebCore/platform/text/TextFlags.cpp M Source/WebCore/platform/text/TextFlags.h M Source/WebCore/rendering/style/RenderStyle.cpp M Source/WebCore/rendering/style/RenderStyle.h M Source/WebCore/rendering/style/RenderStyleInlines.h M Source/WebCore/style/StyleBuilderCustom.h Log Message: --- Avoid copying FontPalette and FontVariantAlternates https://bugs.webkit.org/show_bug.cgi?id=273568 Reviewed by Chris Dumez. Reduce unnecessary copies in our font handling code: (1) FontPalette is a struct containing an enum and an AtomString, and should be returned by const reference to avoid copying that string. (2) FontVariantAlternates is lightweight, containing only a `Markable`, but the `Markable` is holding a very heavy-weight object that contains Vectors of Strings, and Strings. * Source/WebCore/css/CSSFontFace.h: * Source/WebCore/css/CSSFontFaceSet.cpp: (WebCore::CSSFontFaceSet::fontFace): * Source/WebCore/css/CSSFontFaceSet.h: * Source/WebCore/platform/graphics/FontDescription.h: (WebCore::FontDescription::variantAlternates const): (WebCore::FontDescription::fontPalette const): (WebCore::FontDescription::setVariantAlternates): (WebCore::FontDescription::setFontPalette): * Source/WebCore/platform/text/TextFlags.cpp: (WebCore::operator<<): * Source/WebCore/platform/text/TextFlags.h: * Source/WebCore/rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::setFontPalette): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::fontPalette const): * Source/WebCore/style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyValueFontVariantAlternates): Canonical link: https://commits.webkit.org/278351@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0a2730: Add quirk for TripAdvisor to support mixed content...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0a2730dd7efa7b0fceccec9ae9b3f5d14acebd7f https://github.com/WebKit/WebKit/commit/0a2730dd7efa7b0fceccec9ae9b3f5d14acebd7f Author: Brent Fulgham Date: 2024-04-30 (Tue, 30 Apr 2024) Changed paths: M Source/WebCore/loader/MixedContentChecker.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Add quirk for TripAdvisor to support mixed content in their Panorama feature https://bugs.webkit.org/show_bug.cgi?id=273425 Reviewed by Matthew Finkel. Add a quirk to allow TripAdvisor.com's Panorama feature to work despite their use of mixed content in conjunction with crossorigin="" style. This brings Safari behavior in line with Chrome, which performs the insecure content upgrade (even though the specification indicates this should not happen). * Source/WebCore/loader/MixedContentChecker.cpp: (WebCore::destinationIsImageAudioOrVideo): (WebCore::MixedContentChecker::shouldUpgradeInsecureContent): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::needsRelaxedCorsMixedContentCheckQuirk const): * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/278170@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c333c: Adopt smart pointers in ApplicationStateTracker
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c333c99a9a77e7f985b532002f6f2f8f7e05a07 https://github.com/WebKit/WebKit/commit/6c333c99a9a77e7f985b532002f6f2f8f7e05a07 Author: Brent Fulgham Date: 2024-04-25 (Thu, 25 Apr 2024) Changed paths: M Source/WebKit/UIProcess/ApplicationStateTracker.h M Source/WebKit/UIProcess/ApplicationStateTracker.mm Log Message: --- Adopt smart pointers in ApplicationStateTracker https://bugs.webkit.org/show_bug.cgi?id=273218 Reviewed by David Kilzer. The ApplicationStateTracker uses `id` values to remember observers that it Registers and unregisters at various points in the display of a view. It's possible that some framework could decide to unregistered an observer outside of this flow, causing us to request an observer to be removed a second time, which triggers a release assert. * Source/WebKit/UIProcess/ApplicationStateTracker.h: * Source/WebKit/UIProcess/ApplicationStateTracker.mm: (WebKit::m_isInBackground): (WebKit::ApplicationStateTracker::removeAllObservers): (WebKit::m_willEnterForegroundObserver): Deleted. Canonical link: https://commits.webkit.org/278022@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d25dff: Check MDM for administrator-specified bundle IDs t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d25dff5c21517511af1894f7002c26a2db4702fc https://github.com/WebKit/WebKit/commit/d25dff5c21517511af1894f7002c26a2db4702fc Author: Brent Fulgham Date: 2024-04-04 (Thu, 04 Apr 2024) Changed paths: M Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm Log Message: --- Check MDM for administrator-specified bundle IDs to grant access to managed domains https://bugs.webkit.org/show_bug.cgi?id=265390 Reviewed by John Wilander. This patch checks MDM to see if the current application is one of a small set of apps specified by the organization administrator. If so, the app will be treated the same way as Safari with respect to managed domains (see Bug 246290). * Source/WebCore/PAL/pal/spi/ios/ManagedConfigurationSPI.h: Add missing forward declaration. * Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::initializeManagedDomains): Ask MCProfileConnection for the list of allowed bundleIDs to include in the relaxed handling. Canonical link: https://commits.webkit.org/277090@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b64091: Revise sandbox to allow necessary sysctl calls
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b64091ecce1bc486b4621fcbcdfe4c047d9093d8 https://github.com/WebKit/WebKit/commit/b64091ecce1bc486b4621fcbcdfe4c047d9093d8 Author: Brent Fulgham Date: 2024-04-02 (Tue, 02 Apr 2024) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.mac.sb.in M Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.relocatable.mac.sb.in Log Message: --- Revise sandbox to allow necessary sysctl calls rdar://107428604 https://bugs.webkit.org/show_bug.cgi?id=271899 Reviewed by Per Arne Vollan. Telemetry has revealed a sysctl-read call that is needed in normal use: kern.willshutdown We can also silence a few sysctl-read calls that are only needed for use cases where WebKit does not run: sysctl.proc_translated vm.page_wire_count We should add them to the sandbox to avoid spurious logging. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: * Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.mac.sb.in: * Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.relocatable.mac.sb.in: Canonical link: https://commits.webkit.org/276953@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e57d2: [Cocoa] Provide hints to CFNetwork for network tra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e57d2b564fd1e0829b164467c080fc54448e1d5 https://github.com/WebKit/WebKit/commit/1e57d2b564fd1e0829b164467c080fc54448e1d5 Author: Brent Fulgham Date: 2024-04-01 (Mon, 01 Apr 2024) Changed paths: M Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm Log Message: --- [Cocoa] Provide hints to CFNetwork for network traffic class https://bugs.webkit.org/show_bug.cgi?id=271920 Reviewed by Jer Noble and Eric Carlson. In Bug 254072 we started setting the traffic class for network activity in WebRTC operations. We should take the same action when we know we are making high (or low) priority requests to the network system so it can do a better job of routing packets and organizing connections. * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::adjustNetworkServiceTypeIfNecessary): Added helper. (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Canonical link: https://commits.webkit.org/276901@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 779251: Complete transition to std::span in CryptoDigest-r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 779251105768188876c269d293475f2a65f2152c https://github.com/WebKit/WebKit/commit/779251105768188876c269d293475f2a65f2152c Author: Brent Fulgham Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M Source/JavaScriptCore/API/JSScript.mm M Source/JavaScriptCore/bytecode/CodeBlockHash.cpp M Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp M Source/JavaScriptCore/runtime/CachedBytecode.h M Source/WTF/wtf/SHA1.h M Source/WTF/wtf/persistence/PersistentEncoder.cpp M Source/WTF/wtf/persistence/PersistentEncoder.h M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp M Source/WebCore/PAL/pal/crypto/CryptoDigest.h M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm M Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp M Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp M Source/WebCore/PAL/pal/crypto/win/CryptoDigestWin.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp M Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp M Source/WebCore/css/FontFace.cpp M Source/WebCore/dom/Node.cpp M Source/WebCore/inspector/DOMPatchSupport.cpp M Source/WebCore/loader/ResourceCryptographicDigest.cpp M Source/WebCore/loader/ResourceCryptographicDigest.h M Source/WebCore/loader/cache/TrustedFonts.cpp M Source/WebCore/loader/cache/TrustedFonts.h M Source/WebCore/page/csp/ContentSecurityPolicy.cpp M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp M Source/WebCore/platform/network/soup/SoupNetworkSession.cpp M Source/WebCore/storage/StorageUtilities.cpp M Source/WebCore/workers/service/server/SWScriptStorage.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheKey.cpp M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm M Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm M Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorUtils.mm M Tools/DumpRenderTree/cg/PixelDumpSupportCG.cpp M Tools/TestWebKitAPI/Tests/WTF/BloomFilter.cpp M Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp M Tools/TestWebKitAPI/cocoa/HTTPServer.mm M Tools/WebKitTestRunner/cairo/TestInvocationCairo.cpp M Tools/WebKitTestRunner/cg/TestInvocationCG.cpp M Tools/WebKitTestRunner/skia/TestInvocationSkia.cpp Log Message: --- Complete transition to std::span in CryptoDigest-related code https://bugs.webkit.org/show_bug.cgi?id=271488 Reviewed by Chris Dumez and Sihui Liu. Following the changes in Bug 249414 and Bug 271383, complete the work of moving to std::span in CryptoDigest-related code. * Source/JavaScriptCore/API/JSScript.mm: (-[JSScript readCache]): (-[JSScript writeCache:]): * Source/JavaScriptCore/bytecode/CodeBlockHash.cpp: (JSC::CodeBlockHash::CodeBlockHash): * Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp: (Inspector::backendCommandsHash): * Source/JavaScriptCore/runtime/CachedBytecode.h: (JSC::CachedBytecode::span const): * Source/WTF/wtf/SHA1.h: * Source/WTF/wtf/persistence/PersistentEncoder.cpp: (WTF::Persistence::Encoder::updateChecksumForData): * Source/WTF/wtf/persistence/PersistentEncoder.h: (WTF::Persistence::Encoder::updateChecksumForNumber): * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: (WebCore::buildClientDataJsonHash): * Source/WebCore/Modules/websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::getExpectedWebSocketAccept): * Source/WebCore/PAL/pal/crypto/CryptoDigest.h: (PAL::CryptoDigest::addBytes): Deleted. * Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm: (PAL::CryptoDigest::addBytes): * Source/WebCore/PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp: (PAL::CryptoDigest::addBytes): * Source/WebCore/PAL/pal/crypto/openssl/CryptoDigestOpenSSL.cpp: (PAL::CryptoDigest::addBytes): * Source/WebCore/PAL/pal/crypto/win/CryptoDigestWin.cpp: (PAL::CryptoDigest::addBytes): * Source/WebCore/css/FontFace.cpp: (WebCore::FontFace::create): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp: (WebCore::gcryptSign): (WebCore::gcryptVerify): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp: (WebCore::gcryptSign): (WebCore::gcryptVerify): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp: (WebCore::gcryptSign): (WebCore::gcryptVerify): * Source/WebCore/dom/Node.cpp: (WebCore::hashPointer): * Source/WebCore/inspector/DOMPatchSupport.cpp: (WebCore::DOMPatchSupport::createDigest
[webkit-changes] [WebKit/WebKit] 7638eb: Update PAL::CryptoDigest to accept std::span argum...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7638ebd719852209c343015eb41ff30279fc4cfa https://github.com/WebKit/WebKit/commit/7638ebd719852209c343015eb41ff30279fc4cfa Author: Brent Fulgham Date: 2024-03-21 (Thu, 21 Mar 2024) Changed paths: M Source/WTF/wtf/persistence/PersistentEncoder.cpp M Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp M Source/WebCore/Modules/webauthn/fido/Pin.cpp M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp M Source/WebCore/PAL/pal/crypto/CryptoDigest.h M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm M Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp M Source/WebCore/crypto/cocoa/CryptoAlgorithmRSA_PSSMac.cpp M Source/WebCore/inspector/DOMPatchSupport.cpp M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp M Source/WebCore/loader/ResourceCryptographicDigest.cpp M Source/WebCore/loader/cache/TrustedFonts.cpp M Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp M Source/WebCore/platform/sql/SQLiteFileSystem.cpp M Source/WebCore/storage/StorageUtilities.cpp M Source/WebCore/workers/service/server/SWScriptStorage.cpp M Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp M Source/WebKit/NetworkProcess/cache/NetworkCacheKey.cpp M Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp M Tools/TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp Log Message: --- Update PAL::CryptoDigest to accept std::span arguments https://bugs.webkit.org/show_bug.cgi?id=249414 Reviewed by Chris Dumez. Update the implementation of PAL::CryptoDigest to accept std:span arguments. * Source/WTF/wtf/persistence/PersistentEncoder.cpp: (WTF::Persistence::Encoder::updateChecksumForData): * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: (WebCore::produceRpIdHash): * Source/WebCore/Modules/webauthn/fido/Pin.cpp: (fido::pin::TokenRequest::tryCreate): (fido::pin::SetPinRequest::tryCreate): * Source/WebCore/Modules/websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::getExpectedWebSocketAccept): * Source/WebCore/PAL/pal/crypto/CryptoDigest.h: * Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.mm: (PAL::CryptoDigest::addBytes): (PAL::CryptoDigest::computeHash): * Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.cpp: (WebCore::CryptoAlgorithmSHA224::digest): * Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp: (WebCore::signECDSA): (WebCore::verifyECDSA): * Source/WebCore/crypto/cocoa/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: (WebCore::signRSASSA_PKCS1_v1_5): (WebCore::verifyRSASSA_PKCS1_v1_5): * Source/WebCore/crypto/cocoa/CryptoAlgorithmRSA_PSSMac.cpp: (WebCore::signRSA_PSS): (WebCore::verifyRSA_PSS): * Source/WebCore/inspector/DOMPatchSupport.cpp: (WebCore::addStringToSHA1): * Source/WebCore/inspector/agents/InspectorDOMAgent.cpp: (WebCore::computeContentSecurityPolicySHA256Hash): * Source/WebCore/loader/ResourceCryptographicDigest.cpp: (WebCore::cryptographicDigestForSharedBuffer): * Source/WebCore/loader/cache/TrustedFonts.cpp: (WebCore::hashForFontData): * Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp: (WebCore::addStringToSHA1): * Source/WebCore/platform/sql/SQLiteFileSystem.cpp: (WebCore::SQLiteFileSystem::computeHashForFileName): * Source/WebCore/storage/StorageUtilities.cpp: (WebCore::StorageUtilities::encodeSecurityOriginForFileName): * Source/WebCore/workers/service/server/SWScriptStorage.cpp: (WebCore::SWScriptStorage::sha2Hash const): * Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementManager.cpp: (WebKit::PrivateClickMeasurementManager::fireConversionRequest): * Source/WebKit/NetworkProcess/cache/NetworkCacheData.cpp: (WebKit::NetworkCache::computeSHA1): * Source/WebKit/NetworkProcess/cache/NetworkCacheKey.cpp: (WebKit::NetworkCache::hashString): * Source/WebKit/NetworkProcess/storage/CacheStorageDiskStore.cpp: (WebKit::computeSHA1): * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp: (WebKit::encode): * Tools/TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/276507@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f69700: [Cocoa] Update sandbox for refactored media servic...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f69700615f80a2004045273778ac68f58f4a717a https://github.com/WebKit/WebKit/commit/f69700615f80a2004045273778ac68f58f4a717a Author: Brent Fulgham Date: 2024-02-26 (Mon, 26 Feb 2024) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- [Cocoa] Update sandbox for refactored media services (disable unused endpoint) https://bugs.webkit.org/show_bug.cgi?id=269809 Reviewed by Per Arne Vollan. This change builds on Bug 262400 by closing down the deprecated media services endpoint now that we have completed adoption of the finer-grained endpoints. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/275328@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9a926: [css-grid] Turn masonry feature off-by-default on ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9a9269b077fd8712363b519b8bca7c73478b5b5 https://github.com/WebKit/WebKit/commit/c9a9269b077fd8712363b519b8bca7c73478b5b5 Author: Brent Fulgham Date: 2024-02-23 (Fri, 23 Feb 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- [css-grid] Turn masonry feature off-by-default on non-Cocoa builds https://bugs.webkit.org/show_bug.cgi?id=269939 Reviewed by Tim Nguyen. In Bug 247074 we moved the Masonry feature flag from preview to stable. While the Cocoa build of WebKit needs the feature to be on by default at the moment, we do not need to toggle the feature for other ports. This patch leaves the Cocoa port enabled, but switches the default for non-Cocoa ports back off. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/275249@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4ac0fb: Update test expectations after 273643@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ac0fb5bb613c425d0126beb5a289cf119e5018d https://github.com/WebKit/WebKit/commit/4ac0fb5bb613c425d0126beb5a289cf119e5018d Author: Brent Fulgham Date: 2024-02-16 (Fri, 16 Feb 2024) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webrtc-stats/supported-stats.https-expected.txt M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- Update test expectations after 273643@main https://bugs.webkit.org/show_bug.cgi?id=269314 Reviewed by Per Arne Vollan. The improvements to add missing stats in WebRTC progressed a WPT WebRTC test case. * LayoutTests/imported/w3c/web-platform-tests/webrtc-stats/supported-stats.https-expected.txt: * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/274891@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c710e9: Add Spotify to the desktop class quirks list
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c710e9dd3240943ddeca3f902c0b7aefbbf15caa https://github.com/WebKit/WebKit/commit/c710e9dd3240943ddeca3f902c0b7aefbbf15caa Author: Brent Fulgham Date: 2024-02-07 (Wed, 07 Feb 2024) Changed paths: M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm Log Message: --- Add Spotify to the desktop class quirks list https://bugs.webkit.org/show_bug.cgi?id=268928 Reviewed by Wenson Hsieh and Chris Dumez. It is nearly impossible to use the volume control or playback scrubber in Spotify in Safari. They don't expect a desktop with touch support. Spotify removed the scrubber features on iOS back in 2016 (https://community.spotify.com/t5/iOS-iPhone-iPad/Audio-scrubber-is-gone-in-latest-update-Why/td-p/1311946 This patch presents Safari to Spotify as a mobile User Agent so that we get the best "touch" version of the website. * Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm: (WebKit::desktopClassBrowsingRecommendedForRequest): Canonical link: https://commits.webkit.org/274268@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a68ad5: Protect WebProcess::unblockServicesRequiredByAcces...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a68ad5db5c8327163866f7f1ece33604d2ac5c7d https://github.com/WebKit/WebKit/commit/a68ad5db5c8327163866f7f1ece33604d2ac5c7d Author: Brent Fulgham Date: 2024-01-29 (Mon, 29 Jan 2024) Changed paths: M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- Protect WebProcess::unblockServicesRequiredByAccessibility from attempting to consume nullptr sandbox extensions https://bugs.webkit.org/show_bug.cgi?id=268314 Reviewed by Per Arne Vollan. The code in WebProcess::unblockServicesRequiredByAccessibility assumes that it will always work with non-nullptr Sandbox Extensions. However, it's possible for the SandboxExtension::create() method to return nullptr, so we should harden this code to avoid crashing under such conditions. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::unblockServicesRequiredByAccessibility): Canonical link: https://commits.webkit.org/273719@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 67a191: Fix adattributiond sandbox violation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 67a191ac740b0193fdbba0a43941e6c6bf12454f https://github.com/WebKit/WebKit/commit/67a191ac740b0193fdbba0a43941e6c6bf12454f Author: Brent Fulgham Date: 2024-01-24 (Wed, 24 Jan 2024) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in Log Message: --- Fix adattributiond sandbox violation https://bugs.webkit.org/show_bug.cgi?id=268039 Reviewed by Per Arne Vollan. In Bug 263274 we added user-specific DarwinDirectoryDataStore to the adattributiond sandbox, but neglected the system fallback location. This triggers sandbox telemetry and prevents the expected fallback behavior. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in: Canonical link: https://commits.webkit.org/273471@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1c6723: [macOS] Quirk oracle.com to disable the Navigator....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1c67239be368f5b2a3b12fdceb378d2d8e03acee https://github.com/WebKit/WebKit/commit/1c67239be368f5b2a3b12fdceb378d2d8e03acee Author: Brent Fulgham Date: 2024-01-19 (Fri, 19 Jan 2024) Changed paths: M Source/WebCore/page/Navigator.idl M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- [macOS] Quirk oracle.com to disable the Navigator.standalone feature https://bugs.webkit.org/show_bug.cgi?id=267784 Reviewed by Chris Dumez. Oracle.com uses the presence of `Navigator.standalone` to identify iPad devices. If it sees a macOS browser with 'Navigator.standalone' defined it believes it is an iPad, and deactivates Tooltip features. We enabled standalone to better support web apps on macOS, causing this issue on the Oracle site. This patch Quirks Oracle so that tooltips work on macOS. * Source/WebCore/page/Navigator.idl: * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableNavigatorStandaloneQuirk const): * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/273257@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55aa24: [iOS] Add missing pthread sys call to Network process
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55aa24214a74b998374efe060b7b24de8375 https://github.com/WebKit/WebKit/commit/55aa24214a74b998374efe060b7b24de8375 Author: Brent Fulgham Date: 2024-01-09 (Tue, 09 Jan 2024) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in Log Message: --- [iOS] Add missing pthread sys call to Network process https://bugs.webkit.org/show_bug.cgi?id=267250 Reviewed by Per Arne Vollan. We added `SYS_psynch_rw_wrlock` to our macOS Network process sandbox in Bug 230961, but did not do so for our iOS sandbox. While we do not frequently need this thread synchronization primitive, telemetry shows that we do hit this during some Network operations that attempt to generate logs. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Canonical link: https://commits.webkit.org/272825@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bcde08: CMSampleBufferGetSampleAttachmentsArray return val...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcde08d1581e66f651880e5903c782332fa5bc67 https://github.com/WebKit/WebKit/commit/bcde08d1581e66f651880e5903c782332fa5bc67 Author: Brent Fulgham Date: 2023-12-04 (Mon, 04 Dec 2023) Changed paths: M Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm Log Message: --- CMSampleBufferGetSampleAttachmentsArray return value is not checked for nullptr https://bugs.webkit.org/show_bug.cgi?id=262650 Reviewed by Jer Noble. CMSampleBufferGetSampleAttachmentsArray declares that its return value as CM_NULLABLE, to warn users that a nullptr value might be returned. This patch adds the missing nullptr check. * Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm: (WebCore::MediaSampleAVFObjC::createNonDisplayingCopy const): Canonical link: https://commits.webkit.org/271496@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c9647a: [Cocoa] Remove permissions for SYS_setsockopt from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c9647ae53c5d528fc86cb2a37905683ccb7b0422 https://github.com/WebKit/WebKit/commit/c9647ae53c5d528fc86cb2a37905683ccb7b0422 Author: Brent Fulgham Date: 2023-11-28 (Tue, 28 Nov 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- [Cocoa] Remove permissions for SYS_setsockopt from the WebContent process https://bugs.webkit.org/show_bug.cgi?id=265413 Reviewed by Per Arne Vollan. We needed to keep access to `setsockopt` in the WebContent process until Content Filtering had completely moved to the Network process. That happened in macOS 13, so we should be able to remove this ability for Ventura and newer operating systems. All iOS ports have made this transition already, so no version checks are needed there. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/271239@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b627d2: [Cocoa] Allow two syscalls found by sandbox telemetry
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b627d2e0516ab8e62054fbdb5087f579841fe90b https://github.com/WebKit/WebKit/commit/b627d2e0516ab8e62054fbdb5087f579841fe90b Author: Brent Fulgham Date: 2023-11-13 (Mon, 13 Nov 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in Log Message: --- [Cocoa] Allow two syscalls found by sandbox telemetry https://bugs.webkit.org/show_bug.cgi?id=264632 Reviewed by Per Arne Vollan. Telemetry on iOS and macOS shows that we need to allow access to SYS_fsctl in the Network process, and silence the SYS_crossarch_trap syscall in all sandboxes. This was discussed with the larger security team, and the need confirmed with the components that require these syscalls. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: Canonical link: https://commits.webkit.org/270661@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 271bf5: Add another test case for managed origins
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 271bf5cc9d335fc900b09e58fd338b8a8ff804ed https://github.com/WebKit/WebKit/commit/271bf5cc9d335fc900b09e58fd338b8a8ff804ed Author: Brent Fulgham Date: 2023-10-09 (Mon, 09 Oct 2023) Changed paths: A LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/third-party-cookie-blocking-expected.txt A LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/third-party-cookie-blocking.html Log Message: --- Add another test case for managed origins https://bugs.webkit.org/show_bug.cgi?id=262749 Reviewed by Sihui Liu. This PR adds a test case that should have been included in Bug 262749. It just confirms that adjustment to the CFNetwork API does not impact the normal third party cookie blocking behavior. * LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/third-party-cookie-blocking-expected.txt: Added. * LayoutTests/http/tests/resourceLoadStatistics/exemptDomains/third-party-cookie-blocking.html: Added. Canonical link: https://commits.webkit.org/269083@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d0a1a: Switch cookie accept policy when using managed dom...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d0a1a99ffad4617e22c1ee48442d755a11488ae https://github.com/WebKit/WebKit/commit/8d0a1a99ffad4617e22c1ee48442d755a11488ae Author: Brent Fulgham Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M Source/WebKit/NetworkProcess/NetworkProcess.cpp Log Message: --- Switch cookie accept policy when using managed domains https://bugs.webkit.org/show_bug.cgi?id=262415 Reviewed by Pascoe. The ITP features block third party cookie access, and purge local state regularly. When an MDM application is running with managed domains, we should adjust cookie acceptance policy to support those managed origins. * Source/WebKit/NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::setManagedDomainsForResourceLoadStatistics): Canonical link: https://commits.webkit.org/268871@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3bf860: Update sandbox for refactored media services
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3bf860bb447c6724570b7f86702b3bad1b5a49f3 https://github.com/WebKit/WebKit/commit/3bf860bb447c6724570b7f86702b3bad1b5a49f3 Author: Brent Fulgham Date: 2023-09-29 (Fri, 29 Sep 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- Update sandbox for refactored media services https://bugs.webkit.org/show_bug.cgi?id=262400 Reviewed by Per Arne Vollan. Adopt finer-grained media services on relevant platforms. This doesn't expose new functionality, it's just adopting these more specific endpoints. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/268672@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 73e0d4: Create a combined GTK/WPE PlatformEnablement file
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 73e0d4c74d1baaeb169b9bbc3f1adcfe71579bcc https://github.com/WebKit/WebKit/commit/73e0d4c74d1baaeb169b9bbc3f1adcfe71579bcc Author: Brent Fulgham Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M Source/WTF/WTF.xcodeproj/project.pbxproj M Source/WTF/wtf/CMakeLists.txt M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformEnableCocoa.h A Source/WTF/wtf/PlatformEnableGlib.h M Source/WTF/wtf/PlatformEnablePlayStation.h M Source/WTF/wtf/PlatformEnableWinCairo.h M Source/WebCore/platform/PlatformWheelEvent.h Log Message: --- Create a combined GTK/WPE PlatformEnablement file https://bugs.webkit.org/show_bug.cgi?id=261960 Reviewed by Chris Dumez. PlatformEnable.h is meant to hold the default state of compile-time feature enablement flag. Specific platform-related files are meant to override these values. No PlatformEnableGTK or PlatformEnableWPE file was ever created, leading to conditional macros being added to the default file. This patch moves the GTK and WPE-specific rules to their own file, to match other platforms. It also corrects the alphabetical ordering of the files. * Source/WTF/wtf/CMakeFiles.txt: Add new header file. * Source/WTF/WTF.xcodeproj/project.pbxproj: * Source/WTF/wtf/PlatformEnable.h: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WTF/wtf/PlatformEnableGlib.h: Added. * Source/WTF/wtf/PlatformEnablePlayStation.h: * Source/WTF/wtf/PlatformEnableWinCairo.h: * Source/WebCore/platform/PlatformWheelEvent.h: Correct the enum definition for the case where KINETIC_SCROLLING has been enabled, but ASYNC_SCROLLING is not. Canonical link: https://commits.webkit.org/268543@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8844e5: Enablement flag clean-ups
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8844e5028d10063aaf5ff4d20c3e96906ca7a18c https://github.com/WebKit/WebKit/commit/8844e5028d10063aaf5ff4d20c3e96906ca7a18c Author: Brent Fulgham Date: 2023-09-21 (Thu, 21 Sep 2023) Changed paths: M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WTF/wtf/PlatformHave.h M Source/WebCore/platform/ios/UserAgentIOS.mm Log Message: --- Enablement flag clean-ups https://bugs.webkit.org/show_bug.cgi?id=261843 Reviewed by Tim Horton and Elliott Williams. This patch moves a few more enablement flags into Open Source, and corrects some mistakes where some HAVE_ macros were placed in ENABLE_ header files. * Source/WTF/wtf/PlatformEnable.h: - Add WEBXR enablement flags for visionOS. - Move a Cocoa-specific feature flag to PlatformEnableCocoa.h * Source/WTF/wtf/PlatformEnableCocoa.h: - Move some visionOS HAVE_ macros to PlatformHave.h. - Move some visionOS ENABLE_ macros to this Open Source file. - Add ENABLE_IMAGE_ANALYSIS_ENHANCEMENTS flag from PlatformEnable.h * Source/WTF/wtf/PlatformHave.h: - Add HAVE_UI_FOCUS_EFFECT to Open Source. - Add visionOS HAVE_ macros previously in PlatformEnableCocoa.h * Source/WebCore/platform/ios/UserAgentIOS.mm: - Switch definition to ENABLE_STATIC_IPAD_USER_AGENT_VALUE, and move to Open Source. Canonical link: https://commits.webkit.org/268299@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0d5ad8: Correct Open Source WebKit build when using Sonoma...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0d5ad833f880ae9a8c1fc88359a452da42b5b145 https://github.com/WebKit/WebKit/commit/0d5ad833f880ae9a8c1fc88359a452da42b5b145 Author: Brent Fulgham Date: 2023-09-20 (Wed, 20 Sep 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h Log Message: --- Correct Open Source WebKit build when using Sonoma SDK https://bugs.webkit.org/show_bug.cgi?id=261832 Unreviewed build fix. The changes in 258467@main defined a needed property for NSMutableURLRequest, but did not provide the related declaration for NSURLRequest. This causes a build failure when someone attempts to build trunk WebKit with the Open Source Sonoma SDK. * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: Canonical link: https://commits.webkit.org/268214@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b93d3a: Move internal feature enablement flags to Open Source
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b93d3a485f777e9d81ca56dfb011aeeff66ec8e9 https://github.com/WebKit/WebKit/commit/b93d3a485f777e9d81ca56dfb011aeeff66ec8e9 Author: Brent Fulgham Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M Source/WTF/wtf/PlatformEnable.h M Source/WTF/wtf/PlatformEnableCocoa.h M Source/WTF/wtf/PlatformHave.h M Source/WTF/wtf/PlatformUse.h M Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm M Source/WebKit/Platform/spi/ios/UIKitSPI.h M Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h M Source/WebKit/UIProcess/ios/forms/WKSelectMenuListViewController.mm M Tools/TestWebKitAPI/ios/UIKitSPI.h M WebKitLibraries/SDKs/watchos9.0-additions.sdk/System/Library/PrivateFrameworks/PepperUICore.framework/PepperUICore.tbd M WebKitLibraries/SDKs/watchsimulator9.0-additions.sdk/System/Library/PrivateFrameworks/PepperUICore.framework/PepperUICore.tbd Log Message: --- Move internal feature enablement flags to Open Source https://bugs.webkit.org/show_bug.cgi?id=261477 Reviewed by Tim Horton. Now that the public betas of our iOS 17 and macOS 14 releases have been shipping for a few months, we should move all relevant flags into Open Source to reduce maintenance burden. * Source/WTF/wtf/PlatformEnable.h: * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/PlatformUse.h: * Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (WebKit::activateSessionCleanup): Correct PLATFORM macro uses * Source/WebKit/Platform/spi/ios/UIKitSPI.h: UIDatePickerStyle is now API on all build targets, so this declaration is unneeded. * Source/WebKit/Platform/spi/watchos/PepperUICoreSPI.h: Add missing forward declarations. * Source/WebKit/UIProcess/ios/forms/WKSelectMenuListViewController.mm: Correct include for watchOS builds. * WebKitLibraries/SDKs/watchos9.0-additions.sdk/System/Library/PrivateFrameworks/PepperUICore.framework/PepperUICore.tbd: Add missing class declaration. * WebKitLibraries/SDKs/watchsimulator9.0-additions.sdk/System/Library/PrivateFrameworks/PepperUICore.framework/PepperUICore.tbd: Ditto. Canonical link: https://commits.webkit.org/268103@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 793f13: Enable Fetch Priority by default
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 793f132ba08ba69462713ded8e74294bd400023e https://github.com/WebKit/WebKit/commit/793f132ba08ba69462713ded8e74294bd400023e Author: Brent Fulgham Date: 2023-08-23 (Wed, 23 Aug 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Enable Fetch Priority by default https://bugs.webkit.org/show_bug.cgi?id=255008 Reviewed by Youenn Fablet. Enable this feature now that Igalia has completed it. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/267196@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f0bb87: Merge ResourceLoadStatisticsStore and ResourceLoad...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f0bb8782e85bede4de98d6243dd3a15f56d4807d https://github.com/WebKit/WebKit/commit/f0bb8782e85bede4de98d6243dd3a15f56d4807d Author: Brent Fulgham Date: 2023-08-09 (Wed, 09 Aug 2023) Changed paths: R Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp M Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.h M Source/WebKit/Sources.txt M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- Merge ResourceLoadStatisticsStore and ResourceLoadStatisticsDatabaseStore https://bugs.webkit.org/show_bug.cgi?id=259715 Reviewed by Chris Dumez. Now that we only have a SQLite-based ITP database, we should remove the needless layering created by a separate ResourceLoadStatisticsStore and ResourceLoadStatisticsDatabaseStore child class. This will allow us to reduce complexity by removing a needless child class, but will also remove numerous virtual method calls, type checks, and downcast operations needed to dispatch methods to the child class. * Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: Removed. * Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp: Many methods moved here from ResourceLoadStatisticsDatabaseStore.cpp. (WebKit::ResourceLoadStatisticsStore::computeImportance): Deleted. * Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.h: (WebKit::ResourceLoadStatisticsStore::isDebugModeEnabled const): Deleted. (WebKit::ResourceLoadStatisticsStore::setThirdPartyCookieBlockingMode): Deleted. (WebKit::ResourceLoadStatisticsStore::thirdPartyCookieBlockingMode const): Deleted. (WebKit::ResourceLoadStatisticsStore::setSameSiteStrictEnforcementEnabled): Deleted. (WebKit::ResourceLoadStatisticsStore::isSameSiteStrictEnforcementEnabled const): Deleted. (WebKit::ResourceLoadStatisticsStore::setFirstPartyWebsiteDataRemovalMode): Deleted. (WebKit::ResourceLoadStatisticsStore::setStandaloneApplicationDomain): Deleted. (WebKit::ResourceLoadStatisticsStore::store const): Deleted. (WebKit::ResourceLoadStatisticsStore::isMemoryStore const): Deleted. (WebKit::ResourceLoadStatisticsStore::isDatabaseStore const): Deleted. (WebKit::ResourceLoadStatisticsStore::dataRecordsBeingRemoved const): Deleted. (WebKit::ResourceLoadStatisticsStore::store): Deleted. (WebKit::ResourceLoadStatisticsStore::workQueue): Deleted. (WebKit::ResourceLoadStatisticsStore::classifier): Deleted. (WebKit::ResourceLoadStatisticsStore::parameters const): Deleted. (WebKit::ResourceLoadStatisticsStore::endOfGrandfatheringTimestamp): Deleted. (WebKit::ResourceLoadStatisticsStore::endOfGrandfatheringTimestamp const): Deleted. (WebKit::ResourceLoadStatisticsStore::clearEndOfGrandfatheringTimeStamp): Deleted. (WebKit::ResourceLoadStatisticsStore::debugManualPrevalentResource const): Deleted. (WebKit::ResourceLoadStatisticsStore::debugStaticPrevalentResource const): Deleted. (WebKit::ResourceLoadStatisticsStore::debugLoggingEnabled const): Deleted. (WebKit::ResourceLoadStatisticsStore::debugModeEnabled const): Deleted. (WebKit::ResourceLoadStatisticsStore::firstPartyWebsiteDataRemovalMode const): Deleted. (WebKit::ResourceLoadStatisticsStore::setDebugLogggingEnabled): Deleted. * Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp: (WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore): Update to call method directly, rather than using is<> and downcast<>. (WebKit::WebResourceLoadStatisticsStore::populateMemoryStoreFromDisk): Ditto. (WebKit::WebResourceLoadStatisticsStore::statisticsDatabaseHasAllTables): Ditto. (WebKit::WebResourceLoadStatisticsStore::performDailyTasks): Ditto. (WebKit::WebResourceLoadStatisticsStore::isRelationshipOnlyInDatabaseOnce): Ditto. (WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent): Ditto. (WebKit::WebResourceLoadStatisticsStore::domainIDExistsInDatabase): Ditto. (WebKit::WebResourceLoadStatisticsStore::suspend): Ditto. * Source/WebKit/Sources.txt: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/266741@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2e93e1: [watchOS] Allow two IOKit property read messages
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2e93e1be4d5073275b68ef0f655e9b3f011996a2 https://github.com/WebKit/WebKit/commit/2e93e1be4d5073275b68ef0f655e9b3f011996a2 Author: Brent Fulgham Date: 2023-07-11 (Tue, 11 Jul 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in Log Message: --- [watchOS] Allow two IOKit property read messages https://bugs.webkit.org/show_bug.cgi?id=259083 Reviewed by Per Arne Vollan. Now that we have investigated their use, we found that we need to allow the watchOS WebContent Process to send the 'io_server_version' and 'io_registry_entry_get_property' MIG messages. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: Canonical link: https://commits.webkit.org/265959@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4ad2a4: [Cocoa] WebContent process needs to grant bootstra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ad2a4a1ba005c866ba22bf0ed2670001edc3852 https://github.com/WebKit/WebKit/commit/4ad2a4a1ba005c866ba22bf0ed2670001edc3852 Author: Brent Fulgham Date: 2023-07-07 (Fri, 07 Jul 2023) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- [Cocoa] WebContent process needs to grant bootstrap extension for font server access https://bugs.webkit.org/show_bug.cgi?id=258953 Reviewed by Per Arne Vollan. The Sandbox extensions needed for dynamic fonts needs to enable the webkit mach bootstrap extension, otherwise message filtering will block calls needed for the feature to work properly. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Canonical link: https://commits.webkit.org/265850@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9632de: Check CachedResourceLoader's document WeakPtr in m...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9632def06c0f39742c6b9b5af8ca7259b44583e8 https://github.com/WebKit/WebKit/commit/9632def06c0f39742c6b9b5af8ca7259b44583e8 Author: Brent Fulgham Date: 2023-06-16 (Fri, 16 Jun 2023) Changed paths: M Source/WebCore/loader/cache/CachedResourceLoader.cpp Log Message: --- Check CachedResourceLoader's document WeakPtr in more places https://bugs.webkit.org/show_bug.cgi?id=258167 Reviewed by Chris Dumez. The CachedResourceLoader class holds a WeakPtr to a Document, which may be a nullptr at different moments in loading. We inconsistently check for nullptr, which telemetry shows is triggering some crashes. This patch provides more rigorous checks for nullptr to avoid these crashes. * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::cachedResource const): (WebCore::CachedResourceLoader::checkInsecureContent const): (WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::canRequestAfterRedirection const): (WebCore::CachedResourceLoader::canRequestInContentDispositionAttachmentSandbox const): Canonical link: https://commits.webkit.org/265259@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e1b1a8: [watchOS] Unreviewed Build Fix: Some SDK Combinati...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e1b1a8e15911df44fc7f07d3fa38fcbfa64e76d9 https://github.com/WebKit/WebKit/commit/e1b1a8e15911df44fc7f07d3fa38fcbfa64e76d9 Author: Brent Fulgham Date: 2023-06-09 (Fri, 09 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- [watchOS] Unreviewed Build Fix: Some SDK Combinations lack LockdownMode header https://bugs.webkit.org/show_bug.cgi?id=257891 Unreviewed build fix. * Source/WTF/wtf/PlatformHave.h: Add a __has_include check to avoid failures. Canonical link: https://commits.webkit.org/265025@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1a8f5e: [Cocoa] Move new LockdownMode Framework to Open So...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1a8f5e8fc6c56c0f12e97f7ef0fb44a212e8df20 https://github.com/WebKit/WebKit/commit/1a8f5e8fc6c56c0f12e97f7ef0fb44a212e8df20 Author: Brent Fulgham Date: 2023-06-08 (Thu, 08 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.h A Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.mm M Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm Log Message: --- [Cocoa] Move new LockdownMode Framework to Open Source https://bugs.webkit.org/show_bug.cgi?id=257761 Reviewed by Tim Horton. Migrate internal use of the new LockdownMode framework to Open Source now that it has been released with the WWDC 2023 Seed. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.h: Added. * Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.mm: Added. (PAL::isLockdownModeEnabled): * Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm: (+[_WKSystemPreferences isCaptivePortalModeEnabled]): Canonical link: https://commits.webkit.org/265001@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4883c5: [Cocoa] Move new LockdownMode Framework to Open So...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4883c52ce3250f4665685e993adedf1eafe19833 https://github.com/WebKit/WebKit/commit/4883c52ce3250f4665685e993adedf1eafe19833 Author: Brent Fulgham Date: 2023-06-07 (Wed, 07 Jun 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj A Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.h A Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.mm M Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm Log Message: --- [Cocoa] Move new LockdownMode Framework to Open Source https://bugs.webkit.org/show_bug.cgi?id=257761 Reviewed by Tim Horton. Migrate internal use of the new LockdownMode framework to Open Source now that it has been released with the WWDC 2023 Seed * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.h: Added. * Source/WebCore/PAL/pal/cocoa/LockdownModeSoftLink.mm: Added. (PAL::isLockdownModeEnabled): * Source/WebKit/UIProcess/API/Cocoa/_WKSystemPreferences.mm: (+[_WKSystemPreferences isCaptivePortalModeEnabled]): Canonical link: https://commits.webkit.org/264961@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe4af8: [Cocoa] Call [AVCaptureDevice ensureServerConnecti...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe4af8b17fb6e12697825b46a8c0a542a7a7525a https://github.com/WebKit/WebKit/commit/fe4af8b17fb6e12697825b46a8c0a542a7a7525a Author: Brent Fulgham Date: 2023-05-23 (Tue, 23 May 2023) Changed paths: M Source/WebKit/GPUProcess/GPUProcess.cpp M Source/WebKit/GPUProcess/cocoa/GPUProcessCocoa.mm Log Message: --- [Cocoa] Call [AVCaptureDevice ensureServerConnection] when new extensions are made to the GPU Process https://bugs.webkit.org/show_bug.cgi?id=257241 Reviewed by Eric Carlson. Our current code only calls [AVCaptureDevice ensureServerConnection] the first time we extend the sandbox. This can lead to problems if the user visits a site that only needs Microphone access (for example), and then visits a site that needs Camera access. Because the camera-related extensions are only recognized by the video capture system when [AVCaptureDevice ensureServiceConnection] is called, the fact that we called it before the new sandbox extensions were in place mean we never activate the relevant features. To fix this, we should simply call [AVCaptureDevice ensureServerConnection] any time we extend the sandbox. I have confirmed with the relevant teams that this call is low-cost (performance wise), and is not harmful to call repeatedly for things that have already been activated. This patch also adds new logging to help debug similar problems in the future. * Source/WebKit/GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::updateSandboxAccess): Add logging. (WebKit::GPUProcess::updateCaptureAccess): Ditto. * Source/WebKit/GPUProcess/cocoa/GPUProcessCocoa.mm: (WebKit::GPUProcess::ensureAVCaptureServerConnection): Add new logging, no longer make this a 'std::call_once'. Canonical link: https://commits.webkit.org/264460@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 21a4b1: [iOS] REGRESSION (264028@main): Memory regression
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 21a4b1c5559f6ddda3f3c4166e5ab33cab2c475d https://github.com/WebKit/WebKit/commit/21a4b1c5559f6ddda3f3c4166e5ab33cab2c475d Author: Brent Fulgham Date: 2023-05-22 (Mon, 22 May 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- [iOS] REGRESSION (264028@main): Memory regression https://bugs.webkit.org/show_bug.cgi?id=257126 Reviewed by Per Arne Vollan. Relaxing the iOS GPU Process Sandbox in Bug 256728 had the unintended effect of increasing memory use. Since blocking this call didn't create any functional issues, but regressed memory, we will instead silence the logging to avoid flooding telemetry with irrelevant logging. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/264386@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 89cc82: [Cocoa] Allow additional Socket Option powers in N...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 89cc82d5b08e9a51e582e13390667fd022b8c317 https://github.com/WebKit/WebKit/commit/89cc82d5b08e9a51e582e13390667fd022b8c317 Author: Brent Fulgham Date: 2023-05-19 (Fri, 19 May 2023) Changed paths: M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in Log Message: --- [Cocoa] Allow additional Socket Option powers in Network Process https://bugs.webkit.org/show_bug.cgi?id=256992 Reviewed by Per Arne Vollan. Update the Network sandboxes to permit socket options that have been hit during telemetry collection: allow socket-option-set level:SOL_SOCKET name:SO_MARK_KNOWN_TRACKER allow socket-option-get level:SOL_SOCKET name:SO_SNDBUF allow socket-option-set level:SOL_SOCKET name:SO_SNDLOWAT We should add these permissions to avoid generating telemetry and reports for things that are needed during normal WebKit operations. * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Canonical link: https://commits.webkit.org/264275@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 66efa4: [Cocoa] Allow F_GETPROTECTIONCLASS in the GPU Proc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 66efa46ff030d3c4c5a6149adaafb85c8e617355 https://github.com/WebKit/WebKit/commit/66efa46ff030d3c4c5a6149adaafb85c8e617355 Author: Brent Fulgham Date: 2023-05-18 (Thu, 18 May 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- [Cocoa] Allow F_GETPROTECTIONCLASS in the GPU Process Sandbox https://bugs.webkit.org/show_bug.cgi?id=256983 Reviewed by Per Arne Vollan. Telemetry shows a lot of logging for `F_GETPROTECTIONCLASS` Sandbox denials in the GPU Process. We allow this in the WebContent and Network process sandboxes, and should do so in the GPU Process, too. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/264219@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 933ac0: [Cocoa] Reduce telemetry reports for virtual memor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 933ac09efb9574f9e08407389affd065693d1ac4 https://github.com/WebKit/WebKit/commit/933ac09efb9574f9e08407389affd065693d1ac4 Author: Brent Fulgham Date: 2023-05-17 (Wed, 17 May 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.webpushd.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.mac.sb.in Log Message: --- [Cocoa] Reduce telemetry reports for virtual memory routines https://bugs.webkit.org/show_bug.cgi?id=256736 Reviewed by Per Arne Vollan. Add additional rules for VM handling features to reduce sandbox telemetry. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.webpushd.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: * Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.mac.sb.in: Canonical link: https://commits.webkit.org/264179@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d3c7b8: [Cocoa] Reduce telemetry reports for virtual memor...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d3c7b8f39ab3b9c551adbaec0bc039834573b9c6 https://github.com/WebKit/WebKit/commit/d3c7b8f39ab3b9c551adbaec0bc039834573b9c6 Author: Brent Fulgham Date: 2023-05-16 (Tue, 16 May 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.webpushd.sb.in M Source/WebKit/WebProcess/com.apple.WebProcess.sb.in M Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.mac.sb.in Log Message: --- [Cocoa] Reduce telemetry reports for virtual memory routines https://bugs.webkit.org/show_bug.cgi?id=256736 Reviewed by Per Arne Vollan. Add additional rules for VM handling features to reduce sandbox telemetry. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.webpushd.sb.in: * Source/WebKit/WebProcess/com.apple.WebProcess.sb.in: * Source/WebKit/webpushd/mac/com.apple.WebKit.webpushd.mac.sb.in: Canonical link: https://commits.webkit.org/264130@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 125fe1: [Cocoa] Silence some spurious reports from sandbox...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 125fe148640d29ff4cc4000bc952589bdb5adf37 https://github.com/WebKit/WebKit/commit/125fe148640d29ff4cc4000bc952589bdb5adf37 Author: Brent Fulgham Date: 2023-05-15 (Mon, 15 May 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- [Cocoa] Silence some spurious reports from sandbox telemetry https://bugs.webkit.org/show_bug.cgi?id=256730 Reviewed by Per Arne Vollan. Disable a set of expected sandbox telemetry and reports to reduce CPU cycles spent generating irrelevant reports and backtraces. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/264074@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 20d3e8: [Cocoa] Extend access to the 'com.apple.gputools.s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20d3e87d72695d65ea71a557c33ba0f5148a2267 https://github.com/WebKit/WebKit/commit/20d3e87d72695d65ea71a557c33ba0f5148a2267 Author: Brent Fulgham Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M Source/WebKit/GPUProcess/GPUProcess.cpp M Source/WebKit/GPUProcess/GPUProcess.h M Source/WebKit/GPUProcess/GPUProcess.messages.in M Source/WebKit/GPUProcess/GPUProcessCreationParameters.cpp M Source/WebKit/GPUProcess/GPUProcessCreationParameters.h M Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp M Source/WebKit/UIProcess/GPU/GPUProcessProxy.h Log Message: --- [Cocoa] Extend access to the 'com.apple.gputools.service' mach service if Web Inspector is enabled https://bugs.webkit.org/show_bug.cgi?id=256673 Reviewed by Per Arne Vollan. Access to the `com.apple.gputools.service` mach service is denied to the GPU Process. Unfortunately, some developer diagnostic tools for graphics investigation need this access to work. We should have the UI Process extend permission for the GPU Process to talk to relevant services when the Web Inspector has been enabled. * Source/WebKit/GPUProcess/GPUProcess.cpp: (WebKit::GPUProcess::initializeGPUProcess): Consume the GPU tools extensions if present. (WebKit::GPUProcess::updateSandboxAccess): Move outside the MEDIA_SESSION enablement macro so we can use it for WebInspector purposes. * Source/WebKit/GPUProcess/GPUProcess.h: * Source/WebKit/GPUProcess/GPUProcess.messages.in: Ditto. * Source/WebKit/GPUProcess/GPUProcessCreationParameters.cpp: (WebKit::GPUProcessCreationParameters::encode const): Update for additional sandbox extensions. (WebKit::GPUProcessCreationParameters::decode): Ditto. * Source/WebKit/GPUProcess/GPUProcessCreationParameters.h: * Source/WebKit/UIProcess/Cocoa/GPUProcessProxyCocoa.mm: (WebKit::GPUProcessProxy::platformInitializeGPUProcessParameters): Add GPU tools extensions to process launch parameters if needed. (WebKit::GPUProcessProxy::createGPUToolsSandboxExtensionHandlesIfNeeded): Added. * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess): Extend GPU tools extensions to the GPU process if they haven't been sent before, but the WebInspector is now enabled. * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::GPUProcessProxy::GPUProcessProxy): * Source/WebKit/UIProcess/GPU/GPUProcessProxy.h: Canonical link: https://commits.webkit.org/264029@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f18e6f: [iOS] Allow syscall-unix SYS_faccessat in the GPU ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f18e6f12b40e8626d25fb3afeb453a531f984601 https://github.com/WebKit/WebKit/commit/f18e6f12b40e8626d25fb3afeb453a531f984601 Author: Brent Fulgham Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- [iOS] Allow syscall-unix SYS_faccessat in the GPU Process sandbox https://bugs.webkit.org/show_bug.cgi?id=256728 Reviewed by Per Arne Vollan. Telemetry shows that we use the SYS_faccessat syscall in iOS, just like we do in macOS. We already allow this in our macOS sandbox, and given these telemetry findings we should allow it in our iOS sandbox to avoid impacting web content. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/264028@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 032c1c: [iOS] Silence telemetry about 'com.apple.coremedia...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 032c1c43834945ffb6cb4cad4e374f5d93513ab0 https://github.com/WebKit/WebKit/commit/032c1c43834945ffb6cb4cad4e374f5d93513ab0 Author: Brent Fulgham Date: 2023-05-12 (Fri, 12 May 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in Log Message: --- [iOS] Silence telemetry about 'com.apple.coremedia.mediaparserd.utilities' in the GPU Process https://bugs.webkit.org/show_bug.cgi?id=256729 Reviewed by Per Arne Vollan. Some CoreMedia code running in the GPU Process attempts to connect to `com.apple.coremedia.mediaparserd.utilities`, which is not needed by features supported in that process. We expect all media parsing to happen in the WebContent process. We have confirmed blocking is the correct behavior here, and does not impact features needed by WebKit. Therefore, we will silence this logging to reduce telemetry burden and improve performance. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb.in: Canonical link: https://commits.webkit.org/264027@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a09166: Revert 257885@main: Broke too many sites in Lockdo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a09166e3759c5c04abaf274d3af5365569d74a49 https://github.com/WebKit/WebKit/commit/a09166e3759c5c04abaf274d3af5365569d74a49 Author: Brent Fulgham Date: 2023-05-11 (Thu, 11 May 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- Revert 257885@main: Broke too many sites in Lockdown Mode https://bugs.webkit.org/show_bug.cgi?id=256665 Unreviewed revert of 257886@main. We have determined that disabling Service Workers in Lockdown Mode is not viable with acceptable levels of Website Compatibility. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/263986@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 419d74: Dynamically extend GPU Process to Apple Camera Cli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 419d742e96e5d321c25a5b814b63be6d3507d980 https://github.com/WebKit/WebKit/commit/419d742e96e5d321c25a5b814b63be6d3507d980 Author: Brent Fulgham Date: 2023-05-10 (Wed, 10 May 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp M Source/WebKit/UIProcess/UserMediaProcessManager.cpp Log Message: --- Dynamically extend GPU Process to Apple Camera Client IOKit Classes when appropriate https://bugs.webkit.org/show_bug.cgi?id=256562 Reviewed by Youenn Fablet, Eric Carlson and Per Arne Vollan. Continue the work from Bug 256013 by dynamically extending the IOKit classes used when the camera is enabled during WebRTC. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::addCameraSandboxExtensions): * Source/WebKit/UIProcess/UserMediaProcessManager.cpp: (WebKit::UserMediaProcessManager::willCreateMediaStream): Canonical link: https://commits.webkit.org/263903@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7a7a1d: Provide more precise description for Lockdown Mode...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7a7a1dfaa36dd3ab2e38e3982f3766ff6055ee8a https://github.com/WebKit/WebKit/commit/7a7a1dfaa36dd3ab2e38e3982f3766ff6055ee8a Author: Brent Fulgham Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M Source/WebCore/en.lproj/Localizable.strings M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm Log Message: --- Provide more precise description for Lockdown Mode Alert in MacCatalyst https://bugs.webkit.org/show_bug.cgi?id=256005 Reviewed by Aditya Keerthi. MacCatalyst apps present the same Lockdown Mode Alert as the one they use in iOS, which is misleading. This change revises the text we use in MacCatalyst to be more precise about the features available for controlling Lockdown Mode. * Source/WebCore/en.lproj/Localizable.strings: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _presentLockdownMode]): Canonical link: https://commits.webkit.org/263470@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a78204: Dynamically extend GPU Process to Apple Camera Cli...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a782040e52f01520625c8fc1c36565e3e777eeab https://github.com/WebKit/WebKit/commit/a782040e52f01520625c8fc1c36565e3e777eeab Author: Brent Fulgham Date: 2023-04-27 (Thu, 27 Apr 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in M Source/WebKit/Scripts/process-entitlements.sh M Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp M Source/WebKit/UIProcess/UserMediaProcessManager.cpp Log Message: --- Dynamically extend GPU Process to Apple Camera Client when appropriate https://bugs.webkit.org/show_bug.cgi?id=256013 Reviewed by Eric Carlson. Extend a mach connection to an Apple Camera User Client service when appropriate. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: * Source/WebKit/Scripts/process-entitlements.sh: * Source/WebKit/UIProcess/GPU/GPUProcessProxy.cpp: (WebKit::addCameraSandboxExtensions): * Source/WebKit/UIProcess/UserMediaProcessManager.cpp: (WebKit::UserMediaProcessManager::willCreateMediaStream): (WebKit::UserMediaProcessManager::revokeSandboxExtensionsIfNeeded): Canonical link: https://commits.webkit.org/263469@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d142de: ASSERTION FAILED: !image->size().isEmpty(): [ iOS, ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d142dec43f3a5bf2ca6832f1eab1df116e38e080 https://github.com/WebKit/WebKit/commit/d142dec43f3a5bf2ca6832f1eab1df116e38e080 Author: Brent Fulgham Date: 2023-04-26 (Wed, 26 Apr 2023) Changed paths: M Source/WebCore/svg/graphics/SVGImageCache.cpp Log Message: --- ASSERTION FAILED: !image->size().isEmpty(): [ iOS, macOS ] imported/w3c/web-platform-tests/css/css-backgrounds/background-size/background-size-near-zero-svg.html is a constant crash. https://bugs.webkit.org/show_bug.cgi?id=255662 Reviewed by Said Abou-Hallawa. SVGImageCache::setContainerContextForClient caches an unscaled SVGImage, plus a scale factor. It computes the size based on a LayoutSize, which is converted to a FloatSize, unscaled by the image scaling factor, then stored for later use. When the cached value is retrieved, it is scaled by the zoom factor, then rounded to the nearest integer value. This scaling and rounding process can yield an empty image, which triggers an assertion when the image is retrieved. Rather that store this nonsensical image, we should recognize that the image is effectively null, and not cache it. * Source/WebCore/svg/graphics/SVGImageCache.cpp: (WebCore::SVGImageCache::setContainerContextForClient): Canonical link: https://commits.webkit.org/263430@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d5c1f2: Unreviewed test gardening for css-backgrounds/back...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5c1f2c2fba1f96ab7962ed595fa270e0bb244d9 https://github.com/WebKit/WebKit/commit/d5c1f2c2fba1f96ab7962ed595fa270e0bb244d9 Author: Brent Fulgham Date: 2023-04-24 (Mon, 24 Apr 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- Unreviewed test gardening for css-backgrounds/background-size/vector https://bugs.webkit.org/show_bug.cgi?id=255809 Unreviewed test gardening. * LayoutTests/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/263325@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e07c0d: The status for the PushAPIEnabled flag should be '...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e07c0d836e7a36a5eed02469e76966513e3f263a https://github.com/WebKit/WebKit/commit/e07c0d836e7a36a5eed02469e76966513e3f263a Author: Brent Fulgham Date: 2023-04-21 (Fri, 21 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Tools/DumpRenderTree/TestOptions.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm M Tools/WebKitTestRunner/TestOptions.cpp Log Message: --- The status for the PushAPIEnabled flag should be 'embedder' rather than 'testable' https://bugs.webkit.org/show_bug.cgi?id=255794 Reviewed by Ben Nham. While reviewing feature flag state, we noticed that 'PushAPIEnabled' is testable (and off-by-default). It should instead be an `embedder` flag. We should continue to activate it during tests to maintain proper coverage. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Tools/DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: * Tools/WebKitTestRunner/TestOptions.cpp: (WTR::TestOptions::defaults): Canonical link: https://commits.webkit.org/263267@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 496718: Remove the abandoned 'LoadSiteIconsIgnoringImageLo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4967181732a932f88eb3b348aa0b6fa5354560f2 https://github.com/WebKit/WebKit/commit/4967181732a932f88eb3b348aa0b6fa5354560f2 Author: Brent Fulgham Date: 2023-04-20 (Thu, 20 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/API/C/WKPreferences.cpp M Source/WebKit/UIProcess/API/C/WKPreferencesRef.h M Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h M Source/WebKitLegacy/mac/WebView/WebPreferences.mm M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp Log Message: --- Remove the abandoned 'LoadSiteIconsIgnoringImageLoadingPreference' setting https://bugs.webkit.org/show_bug.cgi?id=255688 Reviewed by Brady Eidson. The LoadSiteIconsIgnoringImageLoadingPreference is not used any longer, and we should remove it. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetLoadsSiteIconsIgnoringImageLoadingPreference): (WKPreferencesGetLoadsSiteIconsIgnoringImageLoadingPreference): * Source/WebKit/UIProcess/API/C/WKPreferencesRef.h: * Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: (webkit_settings_get_load_icons_ignoring_image_load_setting): (webkit_settings_set_load_icons_ignoring_image_load_setting): * Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::getLoadDecisionForIcons): * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: (testWebKitSettings): (testWebKitSettingsNewWithSettings): Canonical link: https://commits.webkit.org/263202@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ee46c7: [iOS] Make eager soft-linking of Data Detection fr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ee46c752943bd6be0e433b8e7931efd5de456e77 https://github.com/WebKit/WebKit/commit/ee46c752943bd6be0e433b8e7931efd5de456e77 Author: Brent Fulgham Date: 2023-04-19 (Wed, 19 Apr 2023) Changed paths: M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj M Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISPI.h A Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISoftLink.h A Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISoftLink.mm M Source/WebCore/editing/cocoa/DataDetection.mm M Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: --- [iOS] Make eager soft-linking of Data Detection frameworks non-fatal https://bugs.webkit.org/show_bug.cgi?id=255369 Reviewed by David Kilzer. Eager soft-linking of the Data Detection framework was added in Bug 241267. Crash telemetry indicates that the soft-linking fails in some cases, possibly when multiple code paths are trying to initialize the DataDetectors framework, and one of those paths fails Instead, we should consolidate the SoftLink code into a single implementation file, and use that single code path in all cases. * Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj: * Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISPI.h: Moved some declarations to DataDetectorsUISoftLink. * Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISoftLink.h: Added. * Source/WebCore/PAL/pal/spi/ios/DataDetectorsUISoftLink.mm: Added. * Source/WebCore/editing/cocoa/DataDetection.mm: Reference new SoftLink calls. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: Ditto. * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::softlinkDataDetectorsFrameworks): Ditto. Canonical link: https://commits.webkit.org/263154@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b33825: Correct state of "Local File Content Sniffing" flag
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b33825c88890fa30be886284fc575e15b0759e9f https://github.com/WebKit/WebKit/commit/b33825c88890fa30be886284fc575e15b0759e9f Author: Brent Fulgham Date: 2023-04-19 (Wed, 19 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Correct state of "Local File Content Sniffing" flag https://bugs.webkit.org/show_bug.cgi?id=255673 Reviewed by Patrick Angle. The "Local File Content Sniffing" flag is an internal debugging flag, and not a feature flag users or developers need to interact with. Stable is not the right status for this flag; it should be `internal` instead. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/263150@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 860778: [Cocoa] WebKit is copying a source file into the b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 860778a3010e0c21c4175e740ebf0d90c588dffa https://github.com/WebKit/WebKit/commit/860778a3010e0c21c4175e740ebf0d90c588dffa Author: Brent Fulgham Date: 2023-04-18 (Tue, 18 Apr 2023) Changed paths: M Source/WebKit/WebKit.xcodeproj/project.pbxproj Log Message: --- [Cocoa] WebKit is copying a source file into the build product directory https://bugs.webkit.org/show_bug.cgi?id=255628 Reviewed by Elliott Williams. We noticed that the 'BackgroundFetchState.serialization.in' file is improperly being copied into the WebContent.Development.xpc service as a resource. This is just a waste of space on the finished product. This patch fixes this minor mistake. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/263107@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4442e1: Many 'Testable' settings are enabled by default, w...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4442e18594130dce280e3690827d2602a38c4fcd https://github.com/WebKit/WebKit/commit/4442e18594130dce280e3690827d2602a38c4fcd Author: Brent Fulgham Date: 2023-04-18 (Tue, 18 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Many 'Testable' settings are enabled by default, which suggests they should be 'Stable' instead https://bugs.webkit.org/show_bug.cgi?id=20 Reviewed by Patrick Angle. Testable features are intended to be things that are off in shipping releases, but are activated when running tests. The following “Testable” features are on-by-default and should be promoted to “Stable” to match this default state: - File System Access API - Gamepad.vibrationActuator support - Live Ranges in Selection - OffscreenCanvas - OffscreenCanvas in Workers - Push API - WebGL via Metal - AudioSession API - Media Capabilities Extensions - WebRTC Encoded Transform API - Link rel=preconnect via HTTP early hints * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/263095@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ffdc4: Correct the NotificationsEnabled state from 'devel...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ffdc4ca0afd82524736b99d31cfbc1d71207c89 https://github.com/WebKit/WebKit/commit/9ffdc4ca0afd82524736b99d31cfbc1d71207c89 Author: Brent Fulgham Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Correct the NotificationsEnabled state from 'developer' to 'stable' https://bugs.webkit.org/show_bug.cgi?id=255545 Reviewed by Patrick Angle. The 'NotificationsEnabled' feature flag is not a development flag; it is just a toggle for A/B testing. It should therefore be in the 'stable' category. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/263038@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 88d12a: Correct the state of on-by-default features to 'st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 88d12a2d001c34dbc81c348eb60df926c59cd44f https://github.com/WebKit/WebKit/commit/88d12a2d001c34dbc81c348eb60df926c59cd44f Author: Brent Fulgham Date: 2023-04-17 (Mon, 17 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Correct the state of on-by-default features to 'stable' instead of 'preview' https://bugs.webkit.org/show_bug.cgi?id=255535 Reviewed by Patrick Angle. We have a number of features that were in Preview state, that are now on-by-default. Since Preview is only meant to indicate features that are off-by-default for stable software, we should reflect the fact that these feature are complete by moving them to 'stable'. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/263033@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4718ec: Clean up build entitlements on watchOS
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4718ec21fbae6c97ca81df0ea931c39764d87b18 https://github.com/WebKit/WebKit/commit/4718ec21fbae6c97ca81df0ea931c39764d87b18 Author: Brent Fulgham Date: 2023-04-13 (Thu, 13 Apr 2023) Changed paths: M Source/WebKit/Scripts/process-entitlements.sh Log Message: --- Clean up build entitlements on watchOS https://bugs.webkit.org/show_bug.cgi?id=255356 Reviewed by Mark Lam. We do not allow JIT on watchOS, so it's confusing to include the JIT entitlements required on iOS on a platform that doesn't support them. This patch removes them. * Source/WebKit/Scripts/process-entitlements.sh: Canonical link: https://commits.webkit.org/262916@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 893e62: Pull back some upstream css-backgrounds changes ba...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 893e62e7ce3b46b03b3be8f47236f481fe817e6a https://github.com/WebKit/WebKit/commit/893e62e7ce3b46b03b3be8f47236f481fe817e6a Author: Brent Fulgham Date: 2023-04-12 (Wed, 12 Apr 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/border-image-repeat-space-8.html M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/border-image-space-001.html Log Message: --- Pull back some upstream css-backgrounds changes based on WPT team review https://bugs.webkit.org/show_bug.cgi?id=255301 Reviewed by Tim Nguyen. Revert the very wide fuzzy factor added in https://commits.webkit.org/262031@main, and correct a new fuzzy factor based on feedback from the WPT project reviewers. * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/border-image-repeat-space-8.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/border-image-space-001.html: Canonical link: https://commits.webkit.org/262881@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 72e8df: Correct status of 'LiveRangeSelectionEnabled' from...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72e8df69eb90d6bbee9851fe682fffa4c42801a5 https://github.com/WebKit/WebKit/commit/72e8df69eb90d6bbee9851fe682fffa4c42801a5 Author: Brent Fulgham Date: 2023-04-11 (Tue, 11 Apr 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Correct status of 'LiveRangeSelectionEnabled' from 'testable' to 'stable' https://bugs.webkit.org/show_bug.cgi?id=255306 Reviewed by Ryosuke Niwa. The LiveRangeSelectionEnabled feature is on by default on all targets, but is marked with a status of 'testable'. We should display this as 'stable' as it is complete and expected to be on in all deployments. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/262851@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1cc30e: Correct PDF Plugin descriptions returned by naviga...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1cc30ed20c2570c0d4b67c6c71a9b92d2a21c85c https://github.com/WebKit/WebKit/commit/1cc30ed20c2570c0d4b67c6c71a9b92d2a21c85c Author: Brent Fulgham Date: 2023-04-10 (Mon, 10 Apr 2023) Changed paths: A LayoutTests/dom/html/navigator-plugins-expected.txt A LayoutTests/dom/html/navigator-plugins.html M Source/WebCore/page/Navigator.cpp Log Message: --- Correct PDF Plugin descriptions returned by navigator.plugins[x].description https://bugs.webkit.org/show_bug.cgi?id=255155 Reviewed by Geoffrey Garen. In Bug 254189 we corrected a bug where the name of the WebKit Built-in PDF plugin was localized for the user's settings, which confused some anti-fraud software because the specification requires the name to be in plain English text. While that issue was fixed, the specification also requires a consistent English label, "Portable Document Format" be returned by the 'description' property of the plugin. This is currently localized in Safari, leading to some anti-fraud software failing. This patch modifies only the return value from Navigator.plugins[].description, so that other elements of the Browser UI can correctly localize the description. * Source/WebCore/page/Navigator.cpp: (WebCore::Navigator::initializePluginAndMimeTypeArrays): Canonical link: https://commits.webkit.org/262779@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] abf1b3: Review and unskip correct css/css-backgrounds test...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: abf1b37fe2d2029b57287a256f212ee3b3819acf https://github.com/WebKit/WebKit/commit/abf1b37fe2d2029b57287a256f212ee3b3819acf Author: Brent Fulgham Date: 2023-04-10 (Mon, 10 Apr 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-clip/clip-text-multi-line.html M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-image-none-gradient-repaint.html M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-repeat-space-4.html M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-repeat-space-5.html M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-size-001-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/diagonal-percentage-vector-background.html R LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/border-image-6-expected.txt M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/css-border-radius-001.html M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/linear-gradient-currentcolor-first-line.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations M LayoutTests/platform/mac/TestExpectationsRosetta M LayoutTests/platform/wpe/TestExpectations Log Message: --- Review and unskip correct css/css-backgrounds test cases https://bugs.webkit.org/show_bug.cgi?id=255154 Reviewed by Tim Nguyen. I recently resynced the css/css-backgrounds WPT test suite. Many of these tests were skipped years ago, and appear to work (at least according to wpt.fyi). We should unskip relevant tests, add missing 'fuzzy' rules where appropriate, and allow ourselves to focus on the remaining failures. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-image-none-gradient-repaint.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-size-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/background-size/vector/diagonal-percentage-vector-background.html: * LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/border-image-6-expected.txt: Removed. * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/mac/TestExpectationsRosetta: Canonical link: https://commits.webkit.org/262777@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8ab35: Resync css/css-backgrounds from WPT
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8ab35ad7f37b2df2065189ee693374bbdc8e20f https://github.com/WebKit/WebKit/commit/c8ab35ad7f37b2df2065189ee693374bbdc8e20f Author: Brent Fulgham Date: 2023-04-06 (Thu, 06 Apr 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/resources/resource-files.json M LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/META.yml A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-backdrop-infinite-duration-crash.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-element-not-visible-at-current-viewport-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-element-not-visible-at-current-viewport-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-element-not-visible-at-current-viewport.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-additive-keyframe-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-additive-keyframe-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-additive-keyframe.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-0-percent-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-0-percent-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-0-percent.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-100-percent-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-100-percent-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-missing-100-percent.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-replace-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-replace-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fallback-replace.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-field-crash.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fragmented-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fragmented-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-fragmented.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-half-opaque-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-half-opaque-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-half-opaque.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-in-body-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-in-body-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-in-body.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-non-empty-no-draw-crash.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-non-zero-size-element-change-to-zero-expected.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-non-zero-size-element-change-to-zero-ref.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-non-zero-size-element-change-to-zero.html A LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/animations/background-color-animation-pseudo-element-expected.html A LayoutTests/imported/w3c/web
[webkit-changes] [WebKit/WebKit] 95cb10: [Lockdown Mode] Disable Web Codecs API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 95cb10c87569d6491b027a7f0123548dbf891555 https://github.com/WebKit/WebKit/commit/95cb10c87569d6491b027a7f0123548dbf891555 Author: Brent Fulgham Date: 2023-04-05 (Wed, 05 Apr 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [Lockdown Mode] Disable Web Codecs API https://bugs.webkit.org/show_bug.cgi?id=255054 Reviewed by Youenn Fablet. Disable access to WebCodec APIs when in lockdown mode. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): Turn off WebCodecs. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Add tests. Canonical link: https://commits.webkit.org/262653@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 589cb4: iPad test results have not kept up with the new te...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 589cb41a4fd737789773468b7b99d01b0f64b9f4 https://github.com/WebKit/WebKit/commit/589cb41a4fd737789773468b7b99d01b0f64b9f4 Author: Brent Fulgham Date: 2023-03-24 (Fri, 24 Mar 2023) Changed paths: M LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt Log Message: --- iPad test results have not kept up with the new testable features in the build https://bugs.webkit.org/show_bug.cgi?id=254438 Reviewed by Tim Nguyen. A few CSS features that are now 'testable' are not properly reflected in the iPad test results. * LayoutTests/platform/ipad/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt: Canonical link: https://commits.webkit.org/262095@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 47796d: Cherry-pick d5f4c908e83c. rdar://problem/106292744
Branch: refs/heads/safari-7616.1.6-branch Home: https://github.com/WebKit/WebKit Commit: 47796de60266d5a1864be6402e7f10ca1aa79014 https://github.com/WebKit/WebKit/commit/47796de60266d5a1864be6402e7f10ca1aa79014 Author: Brent Fulgham Date: 2023-03-11 (Sat, 11 Mar 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- Cherry-pick d5f4c908e83c. rdar://problem/106292744 REGRESSION(261233@main): Fix Simulator (and MacCatalyst) builds https://bugs.webkit.org/show_bug.cgi?id=253459 Reviewed by Ryosuke Niwa and Chris Dumez. The simulator and MacCatalyst do not yet support the Lockdown Mode Additions, leading to build failures. This patch adjusts the HAVE macro to avoid attempting to build with invalid settings. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/261296@main Canonical link: https://commits.webkit.org/261247.30@safari-7616.1.6-branch ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d5f4c9: REGRESSION(261233@main): Fix Simulator (and MacCat...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d5f4c908e83c7f7f6643f0bf0739a2cbe743710b https://github.com/WebKit/WebKit/commit/d5f4c908e83c7f7f6643f0bf0739a2cbe743710b Author: Brent Fulgham Date: 2023-03-06 (Mon, 06 Mar 2023) Changed paths: M Source/WTF/wtf/PlatformHave.h Log Message: --- REGRESSION(261233@main): Fix Simulator (and MacCatalyst) builds https://bugs.webkit.org/show_bug.cgi?id=253459 Reviewed by Ryosuke Niwa and Chris Dumez. The simulator and MacCatalyst do not yet support the Lockdown Mode Additions, leading to build failures. This patch adjusts the HAVE macro to avoid attempting to build with invalid settings. * Source/WTF/wtf/PlatformHave.h: Canonical link: https://commits.webkit.org/261296@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 93ddd0: REGRESSION (261182@main): TestWebKitAPI.ProcessSwa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 93ddd026548d5811d7583d917ea96b583af362ba https://github.com/WebKit/WebKit/commit/93ddd026548d5811d7583d917ea96b583af362ba Author: Brent Fulgham Date: 2023-03-04 (Sat, 04 Mar 2023) Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- REGRESSION (261182@main): TestWebKitAPI.ProcessSwap.LockdownModeEnabledByDefaultThenOptOut and TestWebKitAPI.ProcessSwap.NavigatingToLockdownMode are failing https://bugs.webkit.org/show_bug.cgi?id=253388 Unreviewed test fix. We need to remove the checks for 'CSSCounterStyleRule' and 'contain-intrinsic-size', since these features are now stable and not part of the Experimental cohort we wish to deactivate in Lockdown Mode. * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/261231@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3fdb8c: Use shifts to speedup floor() and round()
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3fdb8cf70b8a1a20f2bf782f1690b6cd3eb9ee08 https://github.com/WebKit/WebKit/commit/3fdb8cf70b8a1a20f2bf782f1690b6cd3eb9ee08 Author: Brent Fulgham Date: 2023-02-16 (Thu, 16 Feb 2023) Changed paths: M Source/WebCore/platform/LayoutUnit.h Log Message: --- Use shifts to speedup floor() and round() https://bugs.webkit.org/show_bug.cgi?id=250523 Reviewed by Chris Dumez. Suggested by Ahmad Saleem, based on the 2014 Blink patch in https://chromium.googlesource.com/chromium/blink/+/143faa0607149758526318a98757a3055197cb0f * Source/WebCore/platform/LayoutUnit.h: (WebCore::LayoutUnit::round const): (WebCore::LayoutUnit::floor const): Canonical link: https://commits.webkit.org/260422@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 176591: Expose a 'category' for Web Preferences
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 176591df93a53b8c551157e6c735e8e24d3fd1c1 https://github.com/WebKit/WebKit/commit/176591df93a53b8c551157e6c735e8e24d3fd1c1 Author: Brent Fulgham Date: 2023-02-16 (Thu, 16 Feb 2023) Changed paths: M Source/WTF/Scripts/GeneratePreferences.rb M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Scripts/GenerateSettings.rb M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesFeatures.cpp.erb M Source/WebKit/UIProcess/API/APIFeature.cpp M Source/WebKit/UIProcess/API/APIFeature.h M Source/WebKit/UIProcess/API/APIFeatureStatus.h M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.h M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb M Source/WebKitLegacy/mac/WebView/WebFeature.h M Source/WebKitLegacy/mac/WebView/WebFeature.m M Source/WebKitLegacy/mac/WebView/WebFeatureInternal.h Log Message: --- Expose a 'category' for Web Preferences https://bugs.webkit.org/show_bug.cgi?id=252093 Reviewed by Patrick Angle. Add a new 'category' field to our preference definitions that can be used to provide context to the User Interface for applications like Safari so that we can easily present the features in the clearest way. * Source/WTF/Scripts/GeneratePreferences.rb: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Scripts/GenerateSettings.rb: * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesFeatures.cpp.erb: * Source/WebKit/UIProcess/API/APIFeature.cpp (API::Feature::create): Add new argument. (API::Feature::Feature): Ditto. * Source/WebKit/UIProcess/API/APIFeature.h: * Source/WebKit/UIProcess/API/APIFeatureStatus.h: * Source/WebKit/UIProcess/API/Cocoa/_WKFeature.h: * Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm: (-[_WKFeature category]): * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesExperimentalFeatures.mm.erb: * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesInternalFeatures.mm.erb: * Source/WebKitLegacy/mac/WebView/WebFeature.h: * Source/WebKitLegacy/mac/WebView/WebFeature.m: (-[WebFeature initWithKey:preferenceKey:name:status:category:details:defaultValue:hidden:]): Added. (-[WebFeature initWithKey:preferenceKey:name:status:details:defaultValue:hidden:]): Deleted. * Source/WebKitLegacy/mac/WebView/WebFeatureInternal.h: Canonical link: https://commits.webkit.org/260420@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 252ee7: Remove Windows WebKitLegacy code
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 252ee7ef89ec4685d4c20b12b5f6dba0795988db https://github.com/WebKit/WebKit/commit/252ee7ef89ec4685d4c20b12b5f6dba0795988db Author: Brent Fulgham Date: 2023-02-16 (Thu, 16 Feb 2023) Changed paths: M Source/WebKitLegacy/CMakeLists.txt R Source/WebKitLegacy/PlatformWin.cmake R Source/WebKitLegacy/WebKitLegacy.vcxproj/WebKitLegacy.proj M Source/WebKitLegacy/cf/WebCoreSupport/WebInspectorClientCF.cpp R Source/WebKitLegacy/win/AccessibleBase.cpp R Source/WebKitLegacy/win/AccessibleBase.h R Source/WebKitLegacy/win/AccessibleDocument.cpp R Source/WebKitLegacy/win/AccessibleDocument.h R Source/WebKitLegacy/win/AccessibleImage.cpp R Source/WebKitLegacy/win/AccessibleImage.h R Source/WebKitLegacy/win/AccessibleTextImpl.cpp R Source/WebKitLegacy/win/AccessibleTextImpl.h R Source/WebKitLegacy/win/BackForwardList.cpp R Source/WebKitLegacy/win/BackForwardList.h R Source/WebKitLegacy/win/CFDictionaryPropertyBag.cpp R Source/WebKitLegacy/win/CFDictionaryPropertyBag.h R Source/WebKitLegacy/win/COMEnumVariant.h R Source/WebKitLegacy/win/COMPropertyBag.h R Source/WebKitLegacy/win/COMVariantSetter.h R Source/WebKitLegacy/win/CodeAnalysisConfig.h R Source/WebKitLegacy/win/DOMCSSClasses.cpp R Source/WebKitLegacy/win/DOMCSSClasses.h R Source/WebKitLegacy/win/DOMCoreClasses.cpp R Source/WebKitLegacy/win/DOMCoreClasses.h R Source/WebKitLegacy/win/DOMEventsClasses.cpp R Source/WebKitLegacy/win/DOMEventsClasses.h R Source/WebKitLegacy/win/DOMHTMLClasses.cpp R Source/WebKitLegacy/win/DOMHTMLClasses.h R Source/WebKitLegacy/win/DefaultDownloadDelegate.cpp R Source/WebKitLegacy/win/DefaultDownloadDelegate.h R Source/WebKitLegacy/win/DefaultPolicyDelegate.cpp R Source/WebKitLegacy/win/DefaultPolicyDelegate.h R Source/WebKitLegacy/win/ForEachCoClass.cpp R Source/WebKitLegacy/win/ForEachCoClass.h R Source/WebKitLegacy/win/FullscreenVideoController.cpp R Source/WebKitLegacy/win/FullscreenVideoController.h R Source/WebKitLegacy/win/Interfaces/AccessibilityDelegate.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/Accessible2.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/Accessible2_2.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/AccessibleApplication.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/AccessibleEditableText.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/AccessibleRelation.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/AccessibleStates.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/AccessibleText.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/AccessibleText2.idl R Source/WebKitLegacy/win/Interfaces/Accessible2/IA2CommonTypes.idl R Source/WebKitLegacy/win/Interfaces/AccessibleComparable.idl R Source/WebKitLegacy/win/Interfaces/DOMCSS.idl R Source/WebKitLegacy/win/Interfaces/DOMCore.idl R Source/WebKitLegacy/win/Interfaces/DOMEvents.idl R Source/WebKitLegacy/win/Interfaces/DOMExtensions.idl R Source/WebKitLegacy/win/Interfaces/DOMHTML.idl R Source/WebKitLegacy/win/Interfaces/DOMPrivate.idl R Source/WebKitLegacy/win/Interfaces/DOMRange.idl R Source/WebKitLegacy/win/Interfaces/DOMWindow.idl R Source/WebKitLegacy/win/Interfaces/IGEN_DOMObject.idl R Source/WebKitLegacy/win/Interfaces/IWebApplicationCache.idl R Source/WebKitLegacy/win/Interfaces/IWebArchive.idl R Source/WebKitLegacy/win/Interfaces/IWebBackForwardList.idl R Source/WebKitLegacy/win/Interfaces/IWebBackForwardListPrivate.idl R Source/WebKitLegacy/win/Interfaces/IWebCache.idl R Source/WebKitLegacy/win/Interfaces/IWebCoreStatistics.idl R Source/WebKitLegacy/win/Interfaces/IWebDataSource.idl R Source/WebKitLegacy/win/Interfaces/IWebDatabaseManager.idl R Source/WebKitLegacy/win/Interfaces/IWebDesktopNotificationsDelegate.idl R Source/WebKitLegacy/win/Interfaces/IWebDocument.idl R Source/WebKitLegacy/win/Interfaces/IWebDownload.idl R Source/WebKitLegacy/win/Interfaces/IWebEditingDelegate.idl R Source/WebKitLegacy/win/Interfaces/IWebEmbeddedView.idl R Source/WebKitLegacy/win/Interfaces/IWebError.idl R Source/WebKitLegacy/win/Interfaces/IWebErrorPrivate.idl R Source/WebKitLegacy/win/Interfaces/IWebFormDelegate.idl R Source/WebKitLegacy/win/Interfaces/IWebFrame.idl R Source/WebKitLegacy/win/Interfaces/IWebFrameLoadDelegate.idl R Source/WebKitLegacy/win/Interfaces/IWebFrameLoadDelegatePrivate.idl R Source/WebKitLegacy/win/Interfaces/IWebFrameLoadDelegatePrivate2.idl R Source/WebKitLegacy/win/Interfaces/IWebFramePrivate.idl R Source/WebKitLegacy/win/Interfaces/IWebFrameView.idl R Source/WebKitLegacy/win/Interfaces/IWebGeolocationPolicyListener.idl R Source/WebKitLegacy/win/Interfaces/IWebGeolocationPosition.idl R Source
[webkit-changes] [WebKit/WebKit] ccfd01: Update .github/CODEOWNERS for Site Quirks and Sand...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ccfd01b632764a159c85d87820010fe7a0f9fc12 https://github.com/WebKit/WebKit/commit/ccfd01b632764a159c85d87820010fe7a0f9fc12 Author: Brent Fulgham Date: 2023-02-15 (Wed, 15 Feb 2023) Changed paths: M .github/CODEOWNERS Log Message: --- Update .github/CODEOWNERS for Site Quirks and Sandboxes https://bugs.webkit.org/show_bug.cgi?id=252271 Reviewed by Per Arne Vollan. We lost some of the automated notifications we used to have before we switched to GitHub. This patch adds owners to a few files where we'd like to be notified of changes. * .github/CODEOWNERS: Canonical link: https://commits.webkit.org/260315@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a24ac1: Remove code in common files only compiled for Appl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a24ac189df77eb8e7d2d17f1b4bc8dc2386facc5 https://github.com/WebKit/WebKit/commit/a24ac189df77eb8e7d2d17f1b4bc8dc2386facc5 Author: Brent Fulgham Date: 2023-02-10 (Fri, 10 Feb 2023) Changed paths: M Source/WebCore/PlatformMac.cmake M Source/WebCore/SourcesCocoa.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/WebCorePrefix.h M Source/WebCore/loader/EmptyClients.cpp M Source/WebCore/loader/EmptyFrameLoaderClient.h M Source/WebCore/loader/FrameLoaderClient.h M Source/WebCore/loader/ResourceLoader.h R Source/WebCore/loader/cf/ResourceLoaderCFNet.cpp M Source/WebCore/platform/MIMETypeRegistry.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/PlatformCALayer.h M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp M Source/WebCore/platform/graphics/cg/ImageBufferCGBackend.cpp M Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp M Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp R Source/WebCore/platform/graphics/cg/ImageSourceCG.h M Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp M Source/WebCore/platform/graphics/cg/PathCG.cpp M Source/WebCore/platform/graphics/cg/UTIRegistry.cpp M Source/WebCore/platform/graphics/cg/UTIRegistry.h M Source/WebCore/platform/graphics/cocoa/MediaPlaybackTargetContext.h M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp M Source/WebCore/platform/graphics/coretext/GlyphPageCoreText.cpp M Source/WebCore/platform/mediastream/cocoa/AudioMediaStreamTrackRendererInternalUnit.cpp M Source/WebCore/platform/network/NetworkStorageSession.h M Source/WebCore/platform/network/ProtectionSpace.h M Source/WebCore/platform/network/ProtectionSpaceBase.cpp M Source/WebCore/platform/network/ResourceHandle.h M Source/WebCore/platform/network/ResourceHandleClient.h M Source/WebCore/platform/network/ResourceHandleInternal.h M Source/WebCore/platform/network/ResourceRequestBase.cpp R Source/WebCore/platform/network/cf/AuthenticationCF.cpp R Source/WebCore/platform/network/cf/AuthenticationCF.h M Source/WebCore/platform/network/cf/AuthenticationChallenge.h M Source/WebCore/platform/network/cf/CertificateInfoCFNet.cpp R Source/WebCore/platform/network/cf/CookieStorageCFNet.cpp R Source/WebCore/platform/network/cf/CredentialStorageCFNet.cpp R Source/WebCore/platform/network/cf/LoaderRunLoopCF.cpp R Source/WebCore/platform/network/cf/LoaderRunLoopCF.h M Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp R Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.cpp R Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h M Source/WebCore/platform/network/cf/ResourceError.h R Source/WebCore/platform/network/cf/ResourceErrorCF.cpp R Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp R Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp R Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegate.h R Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp R Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h M Source/WebCore/platform/network/cf/ResourceRequest.h M Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp M Source/WebCore/platform/network/cf/ResourceRequestCFNet.h M Source/WebCore/platform/network/cf/ResourceResponse.h R Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp M Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp R Source/WebCore/platform/network/cf/SynchronousLoaderClientCFNet.cpp M Source/WebCore/platform/network/cocoa/CredentialCocoa.h M Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h M Source/WebCore/platform/network/mac/ResourceErrorMac.mm M Source/WebCore/platform/network/mac/ResourceHandleMac.mm M Source/WebCore/platform/win/TemporaryLinkStubs.cpp M Source/WebKitLegacy/WebCoreSupport/NetworkStorageSessionMap.cpp Log Message: --- Remove code in common files only compiled for Apple's Windows port https://bugs.webkit.org/show_bug.cgi?id=252018 Reviewed by Alex Christensen. This patch removes code that is no longer compiled on any platform, focused on the CoreGraphics, CoreAnimation, and CFNetwork parts of the system. It also moves some code from ImageSourceCG into UTIRegistry (since those methods were only UTI-related). * Source/WebCore/PlatformMac.cmake: * Source/WebCore/SourcesCocoa.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/WebCorePrefix.h: * Source/WebCore/loader/EmptyClients.cpp: (WebCore::EmptyFrameLoaderClient
[webkit-changes] [WebKit/WebKit] 244276: Numerous "Stable" feature flags appear miscategori...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 24427685c584bb10d0b3dc04064cfd5dd4f792b6 https://github.com/WebKit/WebKit/commit/24427685c584bb10d0b3dc04064cfd5dd4f792b6 Author: Brent Fulgham Date: 2023-02-10 (Fri, 10 Feb 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Numerous "Stable" feature flags appear miscategorized, should be "Mature" https://bugs.webkit.org/show_bug.cgi?id=252071 Reviewed by Patrick Angle. Numerous "Stable" feature flags appear miscategorized, and should instead be "Mature". * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/260129@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f993c3: Remove Apple-specific Windows files that are no lo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f993c30c9817273dad456b376933817b8dc8 https://github.com/WebKit/WebKit/commit/f993c30c9817273dad456b376933817b8dc8 Author: Brent Fulgham Date: 2023-02-09 (Thu, 09 Feb 2023) Changed paths: R Source/WebCore/PAL/pal/spi/cf/CFNetworkSPIWin.cpp R Source/WebCore/PAL/pal/spi/win/CFNetworkSPIWin.h R Source/WebCore/PAL/pal/spi/win/CoreTextSPIWin.h R Source/WebCore/page/win/FrameCGWin.cpp R Source/WebCore/platform/cf/win/CertificateCFWin.cpp R Source/WebCore/platform/cf/win/CertificateCFWin.h R Source/WebCore/platform/graphics/ca/win/AbstractCACFLayerTreeHost.h R Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp R Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.h R Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHostClient.h R Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.cpp R Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.h R Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp R Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.h R Source/WebCore/platform/graphics/ca/win/PlatformCAFiltersWin.cpp R Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp R Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h R Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp R Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.h R Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp R Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.h R Source/WebCore/platform/graphics/ca/win/WebTiledBackingLayerWin.cpp R Source/WebCore/platform/graphics/ca/win/WebTiledBackingLayerWin.h R Source/WebCore/platform/graphics/cg/ImageSourceCGWin.cpp R Source/WebCore/platform/graphics/win/FontCGWin.cpp R Source/WebCore/platform/graphics/win/FontPlatformDataCGWin.cpp R Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp R Source/WebCore/platform/graphics/win/ImageCGWin.cpp R Source/WebCore/platform/graphics/win/SimpleFontDataCGWin.cpp R Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp R Source/WebCore/platform/win/DragImageCGWin.cpp Log Message: --- Remove Apple-specific Windows files that are no longer compiled https://bugs.webkit.org/show_bug.cgi?id=252005 Reviewed by Don Olmstead. Remove files that are no longer used in any build. * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPIWin.cpp: Removed. * Source/WebCore/PAL/pal/spi/win/CFNetworkSPIWin.h: Removed. * Source/WebCore/PAL/pal/spi/win/CoreTextSPIWin.h: Removed. * Source/WebCore/page/win/FrameCGWin.cpp: Removed. * Source/WebCore/platform/cf/win/CertificateCFWin.cpp: Removed. * Source/WebCore/platform/cf/win/CertificateCFWin.h: Removed. * Source/WebCore/platform/graphics/ca/win/AbstractCACFLayerTreeHost.h: Removed. * Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp: Removed. * Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.h: Removed. * Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHostClient.h: Removed. * Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.cpp: Removed. * Source/WebCore/platform/graphics/ca/win/LayerChangesFlusher.h: Removed. * Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp: Removed. * Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.h: Removed. * Source/WebCore/platform/graphics/ca/win/PlatformCAFiltersWin.cpp: Removed. * Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.cpp: Removed. * Source/WebCore/platform/graphics/ca/win/PlatformCALayerWin.h: Removed. * Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp: Removed. * Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.h: Removed. * Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Removed. * Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.h: Removed. * Source/WebCore/platform/graphics/ca/win/WebTiledBackingLayerWin.cpp: Removed. * Source/WebCore/platform/graphics/ca/win/WebTiledBackingLayerWin.h: Removed. * Source/WebCore/platform/graphics/cg/ImageSourceCGWin.cpp: Removed. * Source/WebCore/platform/graphics/win/FontCGWin.cpp: Removed. * Source/WebCore/platform/graphics/win/FontPlatformDataCGWin.cpp: Removed. * Source/WebCore/platform/graphics/win/GraphicsContextCGWin.cpp: Removed. * Source/WebCore/platform/graphics/win/ImageCGWin.cpp: Removed. * Source/WebCore/platform/graphics/win/SimpleFontDataCGWin.cpp: Removed. * Source/WebCore/platform/network/cf/NetworkStorageSessionCFNetWin.cpp: Removed. * Source/WebCore/platform/win/DragImageCGWin.cpp: Removed. Canonical link: https://commits.webkit.org/260089@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman
[webkit-changes] [WebKit/WebKit] 1154eb: Remove unneeded #ifdefs and includes from WebCore ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1154eb41e9f87626f6e5faff9191165460806351 https://github.com/WebKit/WebKit/commit/1154eb41e9f87626f6e5faff9191165460806351 Author: Brent Fulgham Date: 2023-02-09 (Thu, 09 Feb 2023) Changed paths: M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp M Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm M Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h M Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h M Source/WebCore/PAL/pal/spi/cg/ImageIOSPI.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp M Source/WebCore/page/ChromeClient.h M Source/WebCore/platform/graphics/DrawGlyphsRecorder.h M Source/WebCore/platform/graphics/FontCascade.h M Source/WebCore/platform/graphics/FontPlatformData.h M Source/WebCore/platform/graphics/MediaPlayer.cpp M Source/WebCore/platform/graphics/MediaPlayer.h M Source/WebCore/platform/graphics/PlatformLayer.h M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp M Source/WebCore/platform/graphics/ca/PlatformCALayer.h M Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp M Source/WebCore/platform/graphics/cg/GraphicsContextCG.h M Source/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivateCG.h M Source/WebCore/platform/graphics/cg/ImageBufferUtilitiesCG.cpp M Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp M Source/WebCore/platform/graphics/cg/PathCG.cpp M Source/WebCore/platform/graphics/cg/UTIRegistry.cpp M Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp M Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp M Source/WebCore/platform/graphics/coretext/FontCoreText.cpp M Source/WebCore/platform/graphics/coretext/FontPlatformDataCoreText.cpp M Source/WebCore/platform/graphics/opentype/OpenTypeCG.cpp M Source/WebCore/platform/graphics/opentype/OpenTypeCG.h M Source/WebCore/platform/network/ResourceHandleClient.h M Source/WebCore/platform/network/cf/CertificateInfo.h M Source/WebCore/platform/network/cf/DNSResolveQueueCFNet.cpp M Source/WebCore/platform/network/cf/FormDataStreamCFNet.cpp M Source/WebCore/platform/network/cf/ResourceError.h M Source/WebCore/platform/network/cf/ResourceRequest.h M Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp M Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp M Source/WebCore/platform/network/cocoa/CertificateInfoCocoa.mm Log Message: --- Remove unneeded #ifdefs and includes from WebCore (251949) https://bugs.webkit.org/show_bug.cgi?id=251949 Reviewed by Don Olmstead. Remove various unused #ifdef and #includes related to the old Cocoa-on-Windows libraries. * Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.cpp: * Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h: * Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm: * Source/WebCore/PAL/pal/spi/cf/CoreMediaSPI.h: * Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h: * Source/WebCore/PAL/pal/spi/cg/ImageIOSPI.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter const): Deleted. * Source/WebCore/html/HTMLMediaElement.h: * Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h: * Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp: (WebCore::userCaptionPreferencesChangedNotificationCallback): (WebCore::CaptionUserPreferencesMediaAF::CaptionUserPreferencesMediaAF): (WebCore::CaptionUserPreferencesMediaAF::~CaptionUserPreferencesMediaAF): (WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges): * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::graphicsDeviceAdapter const): Deleted. * Source/WebCore/platform/graphics/DrawGlyphsRecorder.h: * Source/WebCore/platform/graphics/FontCascade.h: * Source/WebCore/platform/graphics/FontPlatformData.h: (WebCore::FontPlatformData::ctFont const): Deleted. * Source/WebCore/platform/graphics/MediaPlayer.cpp: (WebCore::WTF_REQUIRES_LOCK): (WebCore::MediaPlayer::graphicsDeviceAdapter const): Deleted. * Source/WebCore/platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerGraphicsDeviceAdapter const): Deleted. * Source/WebCore/platform/graphics/PlatformLayer.h: * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::filtersCanBeComposited): (WebCore::GraphicsLayerCA::createPlatformCALayer): (WebCore::GraphicsLayerCA::createPlatformCAAnimation): * Source/WebCore/platform/graphics/ca/PlatformCALayer.cpp: * Source
[webkit-changes] [WebKit/WebKit] fc1e58: Disable CSS Nesting by default
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fc1e58ebbeaccd4c81e813b3fe2c6d0de63472a7 https://github.com/WebKit/WebKit/commit/fc1e58ebbeaccd4c81e813b3fe2c6d0de63472a7 Author: Brent Fulgham Date: 2023-02-02 (Thu, 02 Feb 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Disable CSS Nesting by default https://bugs.webkit.org/show_bug.cgi?id=251636 Reviewed by Tim Nguyen. Turn Nesting off for customer builds, but retain for prerelease builds. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/259787@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c4c0ad: Use 'mature' instead of 'shipping' to represent st...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4c0ad0db413cf856ad127a189abec360db15694 https://github.com/WebKit/WebKit/commit/c4c0ad0db413cf856ad127a189abec360db15694 Author: Brent Fulgham Date: 2023-02-02 (Thu, 02 Feb 2023) Changed paths: M Source/WTF/Scripts/GeneratePreferences.rb M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Scripts/GenerateSettings.rb M Source/WebKit/UIProcess/API/APIFeatureStatus.h M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm M Source/WebKitLegacy/mac/WebView/WebFeature.h Log Message: --- Use 'mature' instead of 'shipping' to represent stable features https://bugs.webkit.org/show_bug.cgi?id=251545 Reviewed by Chris Dumez and Elliott Williams. Replace 'shipping' with 'mature' in various feature-flag places. * Source/WTF/Scripts/GeneratePreferences.rb: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Scripts/GenerateSettings.rb: * Source/WebKit/UIProcess/API/APIFeatureStatus.h: * Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm: (-[_WKFeature status]): * Source/WebKitLegacy/mac/WebView/WebFeature.h: Canonical link: https://commits.webkit.org/259755@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c4d95c: Revert `FullScreenEnabled` feature flag from `inte...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4d95cca9a1f615db218cb85e4ff56af97469cf5 https://github.com/WebKit/WebKit/commit/c4d95cca9a1f615db218cb85e4ff56af97469cf5 Author: Brent Fulgham Date: 2023-01-30 (Mon, 30 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Revert `FullScreenEnabled` feature flag from `internal` back to `embedder` https://bugs.webkit.org/show_bug.cgi?id=251390 Reviewed by Tim Nguyen. The `FullScreenEnabled` preference is not meant to be an internal debugging toggle, so should be labeled as `embedder`. This patch is a partial revert of 259054@main. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/259586@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 671c87: Move a few 'internal' flags back to 'embedder' to ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 671c87c0858bd471c4e7a32f584534bdf4e3971b https://github.com/WebKit/WebKit/commit/671c87c0858bd471c4e7a32f584534bdf4e3971b Author: Brent Fulgham Date: 2023-01-26 (Thu, 26 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Move a few 'internal' flags back to 'embedder' to match shipping behavior https://bugs.webkit.org/show_bug.cgi?id=251232 Reviewed by Elliott Williams. The following feature flags were improperly set as 'internal', rather than 'embedder': 1. AVFoundationEnabled 2. PaginateDuringLayoutEnabled 3. ScrollAnimatorEnabled 4. ScrollToTextFragmentIndicatorEnabled This patch returns them to their correct state. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/259461@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f58ae: Restrict the set of defaults-overridable flags to ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f58ae8a9cfeded106727881a403f817a692d8f4 https://github.com/WebKit/WebKit/commit/0f58ae8a9cfeded106727881a403f817a692d8f4 Author: Brent Fulgham Date: 2023-01-26 (Thu, 26 Jan 2023) Changed paths: M Source/WTF/Scripts/GeneratePreferences.rb M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb M Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm Log Message: --- Restrict the set of defaults-overridable flags to better match shipping Safari https://bugs.webkit.org/show_bug.cgi?id=251183 Reviewed by Elliott Williams. The new feature generator logic attempts to persist all `internal` feature flags such that a developer can use a 'WebKitDebug'-prefix for a setting to override it. This is only desired for a small set of feature flags (those that lived in the Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml file previously). This patch does the following: 1. Corrects a handful of feature flags that were moved from `internal` to `embedder`, improperly. 2. Adds a new key, `defaultsOverridable`, to UnifiedWebPreferences.yaml. Flags that have this key with a `true` value will get additional logic to support 'WebKitDebug'-prefix overrides. 3. Changes the predicate from 'defaultOverridable?' to `defaultsOverridable?' for consistency. 4. Partial revert of 258448@main to restore the ability to honor debug overrides for UInt32 types. * Source/WTF/Scripts/GeneratePreferences.rb: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: * Source/WebKit/UIProcess/Cocoa/WebPreferencesCocoa.mm: (WebKit::setDebugUInt32ValueIfInUserDefaults): Partial revert of 258448@main. We actually do need this method. Canonical link: https://commits.webkit.org/259458@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb16e1: Autogenerated settings turn off too many things in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb16e152e4f6b4e8d4d20035e34034431d046e57 https://github.com/WebKit/WebKit/commit/fb16e152e4f6b4e8d4d20035e34034431d046e57 Author: Brent Fulgham Date: 2023-01-24 (Tue, 24 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Autogenerated settings turn off too many things in Lockdown Mode https://bugs.webkit.org/show_bug.cgi?id=251103 Reviewed by Elliott Williams. We decided that 'developer' state should refer to features that are typically off, but might be enabled by developers debugging a problem. A number of features that are expected to be enabled at all times were improperly labeled with this state, causing our Lockdown Mode logic to turn them off. Instead, we should use 'stable' for features that developers may wish to turn off for A/B testing reasons, but are not intended to be off for most use cases. This patch corrects these problems, and exposes two WebRTC flags as developer options that can be enabled for experimentation, but should not be used by default. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/259331@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 27ac54: Use consistent settings between WebKit/WebKitLegac...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 27ac548bef6ea93a00857b33ca9bbefa811391ef https://github.com/WebKit/WebKit/commit/27ac548bef6ea93a00857b33ca9bbefa811391ef Author: Brent Fulgham Date: 2023-01-20 (Fri, 20 Jan 2023) Changed paths: M LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html M LayoutTests/media/ios/autoplay-only-in-main-document.html M LayoutTests/media/loadedmetadata-fires-without-user-gesture-when-setRequiresUserGestureToLoadVideo-false.html M LayoutTests/media/no-autoplay-with-user-gesture-requirement.html M LayoutTests/media/playlist-inherits-user-gesture-expected.txt M LayoutTests/media/playlist-inherits-user-gesture.html M LayoutTests/media/video-add-autoplay-user-gesture-expected.txt M LayoutTests/media/video-add-autoplay-user-gesture.html M LayoutTests/media/video-create-with-user-gesture-expected.txt M LayoutTests/media/video-create-with-user-gesture.html M LayoutTests/media/video-load-require-user-gesture.html M LayoutTests/media/video-source-before-src-expected.txt M LayoutTests/media/video-source-before-src.html M LayoutTests/media/video-user-gesture-tracking-expected.txt M LayoutTests/media/video-user-gesture-tracking.html M LayoutTests/platform/ios/media/video-source-before-src-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Modules/speech/SpeechSynthesis.cpp M Source/WebCore/Modules/webaudio/AudioContext.cpp M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/page/Settings.yaml M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKitLegacy/mac/WebView/WebView.mm M Source/WebKitLegacy/win/WebView.cpp Log Message: --- Use consistent settings between WebKit/WebKitLegacy/WebCore for audio and video gesture requirements https://bugs.webkit.org/show_bug.cgi?id=250858 Reviewed by Jer Noble. We currently have different names used for WebCore-related media gesture requirements, and the preferences in WebKitLegacy and WebKit with custom code to toggle the WebCore bits in response to the WebKit/WebKitLegacy settings. Instead, we should let the generator code create the WebCore settings code, which will automatically sync it when WebKit/WebKitLegacy preferences are adjusted. Since the internal keys used to control the settings are unchanged, this should not modify behavior. * LayoutTests/http/tests/cache/disk-cache/disk-cache-media-small.html: Update generated 'internals' method call to match Settings. * LayoutTests/media/ios/autoplay-only-in-main-document.html: Ditto. * LayoutTests/media/loadedmetadata-fires-without-user-gesture-when-setRequiresUserGestureToLoadVideo-false.html: Ditto. * LayoutTests/media/no-autoplay-with-user-gesture-requirement.html: Ditto. * LayoutTests/media/playlist-inherits-user-gesture-expected.txt: Ditto. * LayoutTests/media/playlist-inherits-user-gesture.html: Ditto. * LayoutTests/media/video-add-autoplay-user-gesture-expected.txt: Ditto. * LayoutTests/media/video-add-autoplay-user-gesture.html: Ditto. * LayoutTests/media/video-create-with-user-gesture-expected.txt: Ditto. * LayoutTests/media/video-create-with-user-gesture.html: Ditto. * LayoutTests/media/video-load-require-user-gesture.html: Ditto. * LayoutTests/media/video-source-before-src-expected.txt: Ditto. * LayoutTests/media/video-source-before-src.html: Ditto. * LayoutTests/media/video-user-gesture-tracking-expected.txt: Ditto. * LayoutTests/media/video-user-gesture-tracking.html: Ditto. * LayoutTests/platform/ios/media/video-source-before-src-expected.txt: Ditto. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Modules/speech/SpeechSynthesis.cpp: (WebCore::SpeechSynthesis::SpeechSynthesis): * Source/WebCore/Modules/webaudio/AudioContext.cpp: (WebCore::AudioContext::constructCommon): * Source/WebCore/dom/Document.cpp: (WebCore::Document::requiresUserGestureForAudioPlayback const): (WebCore::Document::requiresUserGestureForVideoPlayback const): (WebCore::Document::audioPlaybackRequiresUserGesture const): Deleted. (WebCore::Document::videoPlaybackRequiresUserGesture const): Deleted. * Source/WebCore/dom/Document.h: * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::initializeMediaSession): (WebCore::HTMLMediaElement::updateRateChangeRestrictions): * Source/WebCore/page/Settings.yaml: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences): Update for generated Settings labels. * Source/WebKitLegacy/mac/WebView/WebView.mm: (-[WebView _preferencesChanged:]): Ditto. * Source/WebKitLegacy/win/WebView.cpp: (WebView::notifyPreferencesChanged): Ditto. Canonical link: https://commits.webkit.org/259163@main ___ webkit
[webkit-changes] [WebKit/WebKit] 6eb6b7: De-duplicate feature flags from Settings.yaml that...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6eb6b7e29314edc08edee2733bb39e89b27d31c4 https://github.com/WebKit/WebKit/commit/6eb6b7e29314edc08edee2733bb39e89b27d31c4 Author: Brent Fulgham Date: 2023-01-19 (Thu, 19 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/editing/cocoa/DataDetectorType.h M Source/WebCore/page/Settings.yaml M Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb Log Message: --- De-duplicate feature flags from Settings.yaml that are provided by UnifiedWebPreferences.yaml https://bugs.webkit.org/show_bug.cgi?id=250778 Reviewed by Elliott Williams. A number of preferences defined in UnifiedWebPreferences.yaml are duplicated in Settings.yaml. The generator handles this case properly, but it's confusing to developers. This patch also removed the unused MediaDeviceIdentifierStorageDirectory item. It also restores the 'Settings.yaml' file to the Xcode project so that search will locate items within it. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Clean up duplicates. * Source/WebCore/WebCore.xcodeproj/project.pbxproj: Add missing Settings.yaml file. * Source/WebCore/editing/cocoa/DataDetectorType.h: Add a 'None' case. * Source/WebCore/page/Settings.yaml: Remove duplicates. * Source/WebKitLegacy/mac/Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: Downcast enums to integral types. Canonical link: https://commits.webkit.org/259101@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b21281: [macOS] Extend GPU process sandbox to permit conne...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b212810b234edeb5ae524beab1f0e591e7de33fe https://github.com/WebKit/WebKit/commit/b212810b234edeb5ae524beab1f0e591e7de33fe Author: Brent Fulgham Date: 2023-01-18 (Wed, 18 Jan 2023) Changed paths: M Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in Log Message: --- [macOS] Extend GPU process sandbox to permit connection to com.apple.coremedia.shaphelper.xpc https://bugs.webkit.org/show_bug.cgi?id=250102 Reviewed by Per Arne Vollan. Some echo mitigation features don't work in macOS Ventura because we block access to a new CoreMedia mach service. This patch permits this access. * Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in: Canonical link: https://commits.webkit.org/259057@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0afbc6: Move long-shipping features to the new 'shipping' ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0afbc6ef439ed2fceb65388d2cbb1d2f93705e74 https://github.com/WebKit/WebKit/commit/0afbc6ef439ed2fceb65388d2cbb1d2f93705e74 Author: Brent Fulgham Date: 2023-01-11 (Wed, 11 Jan 2023) Changed paths: M Source/WTF/Scripts/GeneratePreferences.rb M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/Scripts/GenerateSettings.rb M Source/WebKit/UIProcess/API/APIFeatureStatus.h M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm M Source/WebKitLegacy/mac/WebView/WebFeature.h Log Message: --- Move long-shipping features to the new 'shipping' status https://bugs.webkit.org/show_bug.cgi?id=250395 Reviewed by Patrick Angle and Elliott Williams. Following Bug 247926, we expose 'stable' features to the Safari 'Develop' menu to support A/B testing by developers so they can isolate the cause of page regression to specific features. This has created an overly-cumbersome UI, and surfaced features that cannot be disabled on the modern web (and which have been shipping for many years). This patch updates our Feature flag definitions to use 'shipping' for long-shipping features. These will no longer be displayed in the UI, and the feature toggles will likely be removed in a future update as they are no longer conditional, but are foundational to the modern web. This also corrects MediaSourceEnabled and SafeBrowsing to be 'embedder'. * Source/WTF/Scripts/GeneratePreferences.rb: Add 'shipping' as a recognized status. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Scripts/GenerateSettings.rb: Add 'shipping' as a recognized status. * Source/WebKit/UIProcess/API/APIFeatureStatus.h * Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm * Source/WebKitLegacy/mac/WebView/WebFeature.h Canonical link: https://commits.webkit.org/258810@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dd88e1: Move long-shipping features to the new 'shipping' ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd88e1d7de7148ea7a4ec21bab32bdc265c0cb5a https://github.com/WebKit/WebKit/commit/dd88e1d7de7148ea7a4ec21bab32bdc265c0cb5a Author: Brent Fulgham Date: 2023-01-10 (Tue, 10 Jan 2023) Changed paths: M Source/WTF/Scripts/GeneratePreferences.rb M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebKit/UIProcess/API/APIFeatureStatus.h M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm M Source/WebKitLegacy/mac/WebView/WebFeature.h Log Message: --- Move long-shipping features to the new 'shipping' status https://bugs.webkit.org/show_bug.cgi?id=250395 Reviewed by Patrick Angle and Elliott Williams. Following Bug 247926, we expose 'stable' features to the Safari 'Develop' menu to support A/B testing by developers so they can isolate the cause of page regression to specific features. This has created an overly-cumbersome UI, and surfaced features that cannot be disabled on the modern web (and which have been shipping for many years). This patch updates our Feature flag definitions to use 'shipping' for long-shipping features. These will no longer be displayed in the UI, and the feature toggles will likely be removed in a future update as they are no longer conditional, but are foundational to the modern web. This also corrects MediaSourceEnabled and SafeBrowsing to be 'embedder'. * Source/WTF/Scripts/GeneratePreferences.rb: Add 'shipping' as a recognized status. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebKit/UIProcess/API/APIFeatureStatus.h * Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm * Source/WebKitLegacy/mac/WebView/WebFeature.h Canonical link: https://commits.webkit.org/258753@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 14816e: SampleBufferContentKeySessionSupportEnabled is not...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 14816ea69ff90349214ca5f7371d4a21f9244bfc https://github.com/WebKit/WebKit/commit/14816ea69ff90349214ca5f7371d4a21f9244bfc Author: Brent Fulgham Date: 2023-01-10 (Tue, 10 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/page/DeprecatedGlobalSettings.cpp M Source/WebCore/page/DeprecatedGlobalSettings.h M Source/WebCore/page/SettingsBase.cpp M Source/WebCore/page/SettingsBase.h Log Message: --- SampleBufferContentKeySessionSupportEnabled is not attached to DeprecatedGlobalSettings https://bugs.webkit.org/show_bug.cgi?id=250337 Reviewed by Eric Carlson. Correct a missing 'webcorebindings' field in the new generator file. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Include missing webcoreOnChange binding. * Source/WebCore/page/DeprecatedGlobalSettings.cpp: Remove unused method * Source/WebCore/page/DeprecatedGlobalSettings.h: Remove unused method and member variable. * Source/WebCore/page/SettingsBase.cpp: Add handler for KeySessionSupport. * Source/WebCore/page/SettingsBase.h Canonical link: https://commits.webkit.org/258734@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2800c1: [iOS] Allow access to MobileAsset data for network...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2800c1e530768c4ecce425ed2ff67e378730beb3 https://github.com/WebKit/WebKit/commit/2800c1e530768c4ecce425ed2ff67e378730beb3 Author: Brent Fulgham Date: 2023-01-06 (Fri, 06 Jan 2023) Changed paths: M Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in Log Message: --- [iOS] Allow access to MobileAsset data for network extensions https://bugs.webkit.org/show_bug.cgi?id=250144 Reviewed by Per Arne Vollan. Add the path to the location where MobileAssets deposits content related to Network filtering. * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in: Canonical link: https://commits.webkit.org/258580@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 664b37: Restore missing PrivateClickMeasurementFraudPreven...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 664b37c69f5864b5696fe1fa12df0cf9850cdd57 https://github.com/WebKit/WebKit/commit/664b37c69f5864b5696fe1fa12df0cf9850cdd57 Author: Brent Fulgham Date: 2023-01-06 (Fri, 06 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Restore missing PrivateClickMeasurementFraudPreventionEnabled flag https://bugs.webkit.org/show_bug.cgi?id=250170 Reviewed by Chris Dumez. Restore an experimental feature flag that was accidentally removed while unifying the files. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/258548@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55cc92: Correct a few settings after Bug 247926
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 55cc9293a2c7f999dda8ef24e9a00c5e2b93ae31 https://github.com/WebKit/WebKit/commit/55cc9293a2c7f999dda8ef24e9a00c5e2b93ae31 Author: Brent Fulgham Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- Correct a few settings after Bug 247926 https://bugs.webkit.org/show_bug.cgi?id=250164 Reviewed by Elliott Williams. We made a few mistakes when transfering settings data from the multiple YAML files to the single unified file. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/258517@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 80f4f4: Lower per-process websocket connection limits to m...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 80f4f4ee7deb62df8465a1678d21346fab7c3cb8 https://github.com/WebKit/WebKit/commit/80f4f4ee7deb62df8465a1678d21346fab7c3cb8 Author: Brent Fulgham Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: A LayoutTests/http/tests/websocket/tests/hybi/multiple-connections-limit-expected.txt A LayoutTests/http/tests/websocket/tests/hybi/multiple-connections-limit.html M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk1/TestExpectations M LayoutTests/platform/win/TestExpectations M Source/WebKit/WebProcess/Network/WebSocketChannel.cpp M Source/WebKit/WebProcess/Network/WebSocketChannelManager.h Log Message: --- Lower per-process websocket connection limits to match other browser behavior https://bugs.webkit.org/show_bug.cgi?id=247100 Reviewed by Chris Dumez. Chrome and Firefox place an upper bound on the number of connections that a single web page may have open at the same time. We should follow this behavior to avoid a poorly written web page impacting system performance. We will use Chrome's larger limit to reduce the likelihood of web compatibility issues. Tested by a new test: http/tests/websocket/tests/hybi/multiple-connections-limit.html * LayoutTests/http/tests/websocket/tests/hybi/multiple-connections-limit-expected.txt: Added. * LayoutTests/http/tests/websocket/tests/hybi/multiple-connections-limit.html: Added. * Source/WebKit/WebProcess/Network/WebSocketChannel.cpp: (WebKit::WebSocketChannel::connect): Check open connections and fail the connection attempt if we exceed them. * Source/WebKit/WebProcess/Network/WebSocketChannelManager.h: (WebKit::WebSocketChannelManager::hasReachedSocketLimit const): Added. Canonical link: https://commits.webkit.org/258488@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f744bd: [Lockdown Mode] Disable WebSpeech API (Speech Synt...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f744bdf45ea903d8232bb05daedd0721a6e62509 https://github.com/WebKit/WebKit/commit/f744bdf45ea903d8232bb05daedd0721a6e62509 Author: Brent Fulgham Date: 2022-12-15 (Thu, 15 Dec 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [Lockdown Mode] Disable WebSpeech API (Speech Synthesis) https://bugs.webkit.org/show_bug.cgi?id=249346 Reviewed by Chris Dumez. Disable the speech synthesis portions of the Web Speech API in Lockdown Mode. (We already disable the Speech Recognition portions). * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/257933@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] da81ee: [Lockdown Mode] Disable the WebLocks API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: da81ee12ac03c37ab39ccab197d2e3df544a2b14 https://github.com/WebKit/WebKit/commit/da81ee12ac03c37ab39ccab197d2e3df544a2b14 Author: Brent Fulgham Date: 2022-12-14 (Wed, 14 Dec 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- [Lockdown Mode] Disable the WebLocks API https://bugs.webkit.org/show_bug.cgi?id=249264 Reviewed by Chris Dumez. Disable WebLocks in Lockdown Mode. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/257886@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 219be2: Disable IndexedDB in Lockdown Mode
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 219be2142507258fc8a409a8676c3b52e45662ec https://github.com/WebKit/WebKit/commit/219be2142507258fc8a409a8676c3b52e45662ec Author: Brent Fulgham Date: 2022-12-13 (Tue, 13 Dec 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm Log Message: --- Disable IndexedDB in Lockdown Mode https://bugs.webkit.org/show_bug.cgi?id=249176 Reviewed by Chris Dumez. Add 'IndexedDB' to the set of Web API's disabled in Lockdown Mode. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::adjustSettingsForLockdownMode): * Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Canonical link: https://commits.webkit.org/257804@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
