[webkit-changes] [WebKit/WebKit] b25829: Dont build default.metallib when building ANGLE
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b258292b150603e1104099b6c41a3a30ab7fb5fc https://github.com/WebKit/WebKit/commit/b258292b150603e1104099b6c41a3a30ab7fb5fc Author: Kyle Piddington Date: 2023-07-25 (Tue, 25 Jul 2023) Changed paths: M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj Log Message: --- Dont build default.metallib when building ANGLE https://bugs.webkit.org/show_bug.cgi?id=259509 Reviewed by Alex Christensen. The autogenerated metal file was accidently included as a build target in ANGLE's default shared library. It's previously been compiled in a seperate project that builds to "ANGLEMetalLib.metallib". After the last ANGLE roll, it was building to both "default.metallib" and 'ANGLEMetalLib.metallib' This change restores the previous behavior for this library. * Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/266307@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 46f465: Update ANGLE to 2023-06-28 (77c4b6779152795f188c1f...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 46f465b0e6c5fac133ab88f042dedb33938b1010 https://github.com/WebKit/WebKit/commit/46f465b0e6c5fac133ab88f042dedb33938b1010 Author: Kyle Piddington Date: 2023-07-06 (Thu, 06 Jul 2023) Changed paths: M Source/ThirdParty/ANGLE/.gitattributes M Source/ThirdParty/ANGLE/.gitignore M Source/ThirdParty/ANGLE/.vpython3 M Source/ThirdParty/ANGLE/ANGLE.plist M Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj M Source/ThirdParty/ANGLE/AUTHORS M Source/ThirdParty/ANGLE/BUILD.gn M Source/ThirdParty/ANGLE/CONTRIBUTORS M Source/ThirdParty/ANGLE/Compiler.cmake M Source/ThirdParty/ANGLE/D3D.cmake M Source/ThirdParty/ANGLE/DEPS M Source/ThirdParty/ANGLE/GLESv2.cmake M Source/ThirdParty/ANGLE/PRESUBMIT.py M Source/ThirdParty/ANGLE/WebKit/SourcesCGL-mm.mm M Source/ThirdParty/ANGLE/WebKit/SourcesCGL.cpp M Source/ThirdParty/ANGLE/WebKit/SourcesEAGL.cpp M Source/ThirdParty/ANGLE/WebKit/SourcesEAGL1-mm.mm M Source/ThirdParty/ANGLE/WebKit/SourcesEAGL2-mm.mm M Source/ThirdParty/ANGLE/WebKit/SourcesGL.cpp M Source/ThirdParty/ANGLE/WebKit/SourcesPlatform-mm.mm M Source/ThirdParty/ANGLE/WebKit/SourcesPlatform.cpp M Source/ThirdParty/ANGLE/android/angle_apk.gni M Source/ThirdParty/ANGLE/changes.diff M Source/ThirdParty/ANGLE/doc/ExtensionSupport.md A Source/ThirdParty/ANGLE/extensions/ANGLE_polygon_mode.txt M Source/ThirdParty/ANGLE/extensions/ANGLE_shader_pixel_local_storage.txt M Source/ThirdParty/ANGLE/gni-to-cmake.py M Source/ThirdParty/ANGLE/gni/angle.gni M Source/ThirdParty/ANGLE/include/GLES2/gl2ext_angle.h M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderLang.h M Source/ThirdParty/ANGLE/include/GLSLANG/ShaderVars.h M Source/ThirdParty/ANGLE/include/platform/Feature.h R Source/ThirdParty/ANGLE/include/platform/FeaturesD3D_autogen.h R Source/ThirdParty/ANGLE/include/platform/FeaturesGL_autogen.h R Source/ThirdParty/ANGLE/include/platform/FeaturesMtl_autogen.h R Source/ThirdParty/ANGLE/include/platform/FeaturesVk_autogen.h R Source/ThirdParty/ANGLE/include/platform/FrontendFeatures_autogen.h A Source/ThirdParty/ANGLE/include/platform/autogen/.clang-format A Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesD3D_autogen.h A Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesGL_autogen.h A Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesMtl_autogen.h A Source/ThirdParty/ANGLE/include/platform/autogen/FeaturesVk_autogen.h A Source/ThirdParty/ANGLE/include/platform/autogen/FrontendFeatures_autogen.h M Source/ThirdParty/ANGLE/include/platform/gen_features.py M Source/ThirdParty/ANGLE/include/platform/gl_features.json M Source/ThirdParty/ANGLE/include/platform/mtl_features.json M Source/ThirdParty/ANGLE/include/platform/vk_features.json M Source/ThirdParty/ANGLE/infra/config/generated/cr-buildbucket.cfg M Source/ThirdParty/ANGLE/infra/config/generated/luci-milo.cfg M Source/ThirdParty/ANGLE/infra/config/generated/luci-scheduler.cfg M Source/ThirdParty/ANGLE/infra/config/generated/project.cfg M Source/ThirdParty/ANGLE/infra/config/main.star M Source/ThirdParty/ANGLE/infra/specs/angle.json M Source/ThirdParty/ANGLE/infra/specs/angle_mb_config.pyl M Source/ThirdParty/ANGLE/infra/specs/generate_test_spec_json.py M Source/ThirdParty/ANGLE/infra/specs/gn_isolate_map.pyl M Source/ThirdParty/ANGLE/infra/specs/mixins.pyl M Source/ThirdParty/ANGLE/infra/specs/test_suite_exceptions.pyl M Source/ThirdParty/ANGLE/infra/specs/test_suites.pyl M Source/ThirdParty/ANGLE/infra/specs/waterfalls.pyl M Source/ThirdParty/ANGLE/samples/capture_replay/CaptureReplay.cpp M Source/ThirdParty/ANGLE/samples/shader_translator/shader_translator.cpp A Source/ThirdParty/ANGLE/scripts/angle_trace_bundle.py R Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_features.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_format.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_load_functions_table.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_shader_preprocessor.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/ANGLE_shader_translator.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/D3D11_blit_shader_selection.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/D3D11_format.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/DXGI_format.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/DXGI_format_support.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Emulated_HLSL_functions.json M Source/ThirdParty/ANGLE/scripts/code_generation_hashes/Extension_files.json M
[webkit-changes] [WebKit/WebKit] bb1da0: [ANGLE] Render pipeline descriptor missing casses ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bb1da00b9ba878d228a5e9834a0767dbca2fee43 https://github.com/WebKit/WebKit/commit/bb1da00b9ba878d228a5e9834a0767dbca2fee43 Author: Kyle Piddington Date: 2022-10-26 (Wed, 26 Oct 2022) Changed paths: M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm M Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.h Log Message: --- [ANGLE] Render pipeline descriptor missing casses GPU-Process crash https://bugs.webkit.org/show_bug.cgi?id=246777 rdar://97847673 Reviewed by Dean Jackson. Following on from https://bugs.webkit.org/show_bug.cgi?id=240896, we are still experiencing some cases where the Metal backend does not correctly configure the render pipeline state. In rarer cases, we end up in a state where the render encoder is valid, but the pipeline state is not set. Attempt to correct this error with three additional checks 1) When setting up a program, if the render encoder in question does not have a render pipeline state set, attempt to set it, even if the render pass descriptor has not changes. 2) When validating if an encoder is valid, also check if it has a valid render pipeline state during setupDraw. After setupDrawImpl, it should either be invalid (Due to a flush and invalidate all) or not have a render pipeline state (Due to a misconfiguration on the program, or within the state bits.) If we end up in the case of 2, attempt to set up the program one more time. (Usually due to a flush and invalidate all). If we've failed to create a render encoder again, attempt to recover the graphics context by dropping flushing the command buffer, invalidating the entire GL state, and dropping the draw call. This may lead to a rendering error, but will not cause a browser crash. * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm: (rx::ContextMtl::setupDraw): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ProgramMtl.mm: (rx::ProgramMtl::setupDraw): * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_command_buffer.h: Canonical link: https://commits.webkit.org/256013@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295429] trunk
Title: [295429] trunk Revision 295429 Author kpidding...@apple.com Date 2022-06-09 12:25:08 -0700 (Thu, 09 Jun 2022) Log Message TextureMtl.mm:108 (GetLayerMipIndex): \t! Unreachable reached https://bugs.webkit.org/show_bug.cgi?id=240790 Reviewed by Darin Adler Check texture valid before use. * Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.mm: (rx::mtl::Texture::MakeTexture): Canonical link: https://commits.webkit.org/251435@main Modified Paths trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.mm Added Paths trunk/LayoutTests/fast/canvas/webgl/large-texture-creation-expected.txt trunk/LayoutTests/fast/canvas/webgl/large-texture-creation.html Diff Added: trunk/LayoutTests/fast/canvas/webgl/large-texture-creation-expected.txt (0 => 295429) --- trunk/LayoutTests/fast/canvas/webgl/large-texture-creation-expected.txt (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/large-texture-creation-expected.txt 2022-06-09 19:25:08 UTC (rev 295429) @@ -0,0 +1,14 @@ +Test creating a max-size texture. + +On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". + + +Canvas.getContext +PASS context exists + +PASS getError was one of: NO_ERROR or OUT_OF_MEMORY : unexpected result when creating MAX_TEXTURE_SIZE texture + +PASS successfullyParsed is true + +TEST COMPLETE + Added: trunk/LayoutTests/fast/canvas/webgl/large-texture-creation.html (0 => 295429) --- trunk/LayoutTests/fast/canvas/webgl/large-texture-creation.html (rev 0) +++ trunk/LayoutTests/fast/canvas/webgl/large-texture-creation.html 2022-06-09 19:25:08 UTC (rev 295429) @@ -0,0 +1,52 @@ + + + + +WebGL Framebuffer Test + + + + + +