[webkit-changes] [221416] trunk/Tools

[carlosgc]

Title: [221416] trunk/Tools








Revision 221416
Author carlo...@webkit.org
Date 2017-08-31 01:15:54 -0700 (Thu, 31 Aug 2017)


Log Message
Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session.

It fails when comparing the browser version if micro version is 0 (or if both micro and minor are 0 too).

* TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Use a helper method to convert major, minor, micro
numbers into a version string, using the same approach as WebKitAutomationSession.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp




Diff

Modified: trunk/Tools/ChangeLog (221415 => 221416)

--- trunk/Tools/ChangeLog	2017-08-31 04:07:34 UTC (rev 221415)
+++ trunk/Tools/ChangeLog	2017-08-31 08:15:54 UTC (rev 221416)
@@ -1,3 +1,12 @@
+2017-08-31  Carlos Garcia Campos  
+
+Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session.
+
+It fails when comparing the browser version if micro version is 0 (or if both micro and minor are 0 too).
+
+* TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Use a helper method to convert major, minor, micro
+numbers into a version string, using the same approach as WebKitAutomationSession.
+
 2017-08-30  Dan Bernstein  
 
 [iOS] REGRESSION (r218144) -[WKContentView targetForAction:withSender:] returns the content view for actions implemented only by the WKWebView, causing a crash


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp (221415 => 221416)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp	2017-08-31 04:07:34 UTC (rev 221415)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp	2017-08-31 08:15:54 UTC (rev 221416)
@@ -193,6 +193,17 @@
 test->automationStarted(session);
 }
 
+static GUniquePtr toVersionString(unsigned major, unsigned minor, unsigned micro)
+{
+if (!micro && !minor)
+return GUniquePtr(g_strdup_printf("%u", major));
+
+if (!micro)
+return GUniquePtr(g_strdup_printf("%u.%u", major, minor));
+
+return GUniquePtr(g_strdup_printf("%u.%u.%u", major, minor, micro));
+}
+
 WebKitAutomationSession* requestSession(const char* sessionID)
 {
 auto signalID = g_signal_connect(m_webContext.get(), "automation-started", G_CALLBACK(automationStartedCallback), this);
@@ -209,7 +220,7 @@
 const char* browserVersion;
 g_variant_get(capabilities.get(), "()", , );
 g_assert_cmpstr(browserName, ==, "AutomationTestBrowser");
-GUniquePtr versionString(g_strdup_printf("%u.%u.%u", WEBKIT_MAJOR_VERSION, WEBKIT_MINOR_VERSION, WEBKIT_MICRO_VERSION));
+GUniquePtr versionString = toVersionString(WEBKIT_MAJOR_VERSION, WEBKIT_MINOR_VERSION, WEBKIT_MICRO_VERSION);
 g_assert_cmpstr(browserVersion, ==, versionString.get());
 }, this
 );






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221418] trunk/LayoutTests

[commit-queue]

Title: [221418] trunk/LayoutTests








Revision 221418
Author commit-qu...@webkit.org
Date 2017-08-31 05:57:51 -0700 (Thu, 31 Aug 2017)


Log Message
[GTK] Mark some tests as passing.
https://bugs.webkit.org/show_bug.cgi?id=176156

Unreviewed test gardening.

Patch by Ms2ger  on 2017-08-31

* platform/gtk/TestExpectations:
  - fast/hidpi/percent-height-image-nested.html: passing since test change in r217943.
  - fast/ruby/bopomofo.html: passing since r216874.
  - fast/ruby/bopomofo-letter-spacing.html: passing since r216874.
  - fast/ruby/bopomofo-rl.html: passing since r216874.
  - fast/sub-pixel/sub-pixel-composited-layers.html: passing since r215179.
  - fast/text/font-weight-download-2.html: passing since r216944.
  - fast/text/justify-ideograph-vertical.html: passing since r216874.
  - fast/text/multiglyph-characters.html: passing since r216817.
  - http/tests/misc/will-send-request-returns-null-on-redirect.html: passing since r214245.
  - http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html: passing since r211627.
  - imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-005.html: has been passing all along on GTK.
  - imported/w3c/web-platform-tests/fetch/api/basic/error-after-response.html: passing since r218269-r218276.
  - imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html: matching expectations since rebaseline in r215164.
  - imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html: matching expectations since rebaseline in r215164.
  - imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplaythrough.html: passing since r218248.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (221417 => 221418)

--- trunk/LayoutTests/ChangeLog	2017-08-31 10:04:49 UTC (rev 221417)
+++ trunk/LayoutTests/ChangeLog	2017-08-31 12:57:51 UTC (rev 221418)
@@ -1,3 +1,27 @@
+2017-08-31  Ms2ger  
+
+[GTK] Mark some tests as passing.
+https://bugs.webkit.org/show_bug.cgi?id=176156
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+  - fast/hidpi/percent-height-image-nested.html: passing since test change in r217943.
+  - fast/ruby/bopomofo.html: passing since r216874.
+  - fast/ruby/bopomofo-letter-spacing.html: passing since r216874.
+  - fast/ruby/bopomofo-rl.html: passing since r216874.
+  - fast/sub-pixel/sub-pixel-composited-layers.html: passing since r215179.
+  - fast/text/font-weight-download-2.html: passing since r216944.
+  - fast/text/justify-ideograph-vertical.html: passing since r216874.
+  - fast/text/multiglyph-characters.html: passing since r216817.
+  - http/tests/misc/will-send-request-returns-null-on-redirect.html: passing since r214245.
+  - http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html: passing since r211627.
+  - imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-005.html: has been passing all along on GTK.
+  - imported/w3c/web-platform-tests/fetch/api/basic/error-after-response.html: passing since r218269-r218276.
+  - imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html: matching expectations since rebaseline in r215164.
+  - imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html: matching expectations since rebaseline in r215164.
+  - imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/readyState_during_canplaythrough.html: passing since r218248.
+
 2017-08-31  Yusuke Suzuki  
 
 [JSC] Use reifying system for "name" property of builtin JSFunction


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (221417 => 221418)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2017-08-31 10:04:49 UTC (rev 221417)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2017-08-31 12:57:51 UTC (rev 221418)
@@ -862,7 +862,6 @@
 webkit.org/b/131347 fast/hidpi/image-set-background-dynamic.html [ Failure Pass Missing ]
 webkit.org/b/131347 fast/hidpi/image-set-border-image-dynamic.html [ Failure Pass Missing ]
 webkit.org/b/131347 fast/hidpi/image-srcset-png-canvas.html [ ImageOnlyFailure Pass ]
-webkit.org/b/131347 fast/hidpi/percent-height-image-nested.html [ ImageOnlyFailure ]
 webkit.org/b/131347 fast/hidpi/video-controls-in-hidpi.html [ Failure ]
 webkit.org/b/131347 fast/inline-block/hidpi-margin-top-with-subpixel-value-and-overflow-hidden.html [ ImageOnlyFailure ]
 webkit.org/b/131347 fast/inline/hidpi-inline-selection-leaves-gap.html [ ImageOnlyFailure ]
@@ -1170,9 +1169,6 @@
 # WebKit2 plug-ins: No support for getting the form value.
 plugins/form-value.html [ 

[webkit-changes] [221451] tags/Safari-604.2.7/

[jmarcell]

Title: [221451] tags/Safari-604.2.7/








Revision 221451
Author jmarc...@apple.com
Date 2017-08-31 16:18:40 -0700 (Thu, 31 Aug 2017)


Log Message
Tag Safari-604.2.7.

Added Paths

tags/Safari-604.2.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221457] trunk/Source/WebKit

[megan_gardner]

Title: [221457] trunk/Source/WebKit








Revision 221457
Author megan_gard...@apple.com
Date 2017-08-31 16:31:55 -0700 (Thu, 31 Aug 2017)


Log Message
Fix error in protocol revving
https://bugs.webkit.org/show_bug.cgi?id=176191

Protocol definition was mastered out of later iOS submissions, causing them to not build.

Reviewed by Tim Horton.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (221456 => 221457)

--- trunk/Source/WebKit/ChangeLog	2017-08-31 23:27:02 UTC (rev 221456)
+++ trunk/Source/WebKit/ChangeLog	2017-08-31 23:31:55 UTC (rev 221457)
@@ -1,3 +1,15 @@
+2017-08-31  Megan Gardner  
+
+Fix error in protocol revving
+https://bugs.webkit.org/show_bug.cgi?id=176191
+
+Protocol definition was mastered out of later iOS submissions, causing them to not build.
+
+Reviewed by Tim Horton.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
+
 2017-08-31  Youenn Fablet  
 
 Update CacheStorage caches only if it is updated


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (221456 => 221457)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2017-08-31 23:27:02 UTC (rev 221456)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2017-08-31 23:31:55 UTC (rev 221457)
@@ -2552,12 +2552,10 @@
 return _textSelectionAssistant != nil;
 }
 
-#if __IPHONE_OS_VERSION_MAX_ALLOWED < 12
 - (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state
 {
 [self changeSelectionWithGestureAt:point withGesture:gestureType withState:state withFlags:UIWKNone];
 }
-#endif
 
 - (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state withFlags:(UIWKSelectionFlags)flags
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221456] trunk

[antti]

Title: [221456] trunk








Revision 221456
Author an...@apple.com
Date 2017-08-31 16:27:02 -0700 (Thu, 31 Aug 2017)


Log Message
Remove newBlockInsideInlineModel and anonymous inline block
https://bugs.webkit.org/show_bug.cgi?id=176181

Reviewed by Zalan Bujtas.

Source/WebCore:

Anonymous inline block exists to support newBlockInsideInlineModel which was planned as the replacement for continuations.
It has never been enabled and it is time to remove it.

* page/Settings.in:
* rendering/InlineElementBox.cpp:
(WebCore::InlineElementBox::paint):
(WebCore::InlineElementBox::nodeAtPoint):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paint):
(WebCore::InlineFlowBox::anonymousInlineBlock const): Deleted.
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasAnonymousInlineBlock const): Deleted.
(WebCore::InlineFlowBox::setHasAnonymousInlineBlock): Deleted.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight const):
(WebCore::RenderBlock::baselinePosition const):
(WebCore::RenderBlock::renderName const):
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::childrenPreventSelfCollapsing const):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):
* rendering/RenderBlockFlow.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::updateLogicalInlinePositions):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::matchedEndLine):
(WebCore::RenderBlockFlow::marginCollapseLinesFromStart): Deleted.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent const):
(WebCore::RenderBox::createsNewFormattingContext const):
(WebCore::RenderBox::avoidsFloats const):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChildIgnoringContinuation):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::isAnonymousInlineBlock const): Deleted.
* rendering/RenderObject.h:
(WebCore::RenderObject::isAnonymousBlock const):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::ascentAndDescentForBox const):
* rendering/line/BreakingContext.h:
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::handleReplaced):
* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::nextLineBreak):
* rendering/line/LineBreaker.h:
* rendering/line/LineLayoutState.h:
(WebCore::LineLayoutState::marginInfo):
(WebCore::LineLayoutState::prevFloatBottomFromAnonymousInlineBlock): Deleted.
(WebCore::LineLayoutState::maxFloatBottomFromAnonymousInlineBlock): Deleted.

LayoutTests:

* TestExpectations:
* fast/block/inside-inlines/crash-on-first-line-change.html:

Don't set newBlockInsideInlineModel.

* fast/block/inside-inlines/new-model: Removed.
* fast/block/inside-inlines/new-model/basic-float-intrusion-expected.html: Removed.
* fast/block/inside-inlines/new-model/basic-float-intrusion.html: Removed.
* fast/block/inside-inlines/new-model/block-width-check-expected.html: Removed.
* fast/block/inside-inlines/new-model/block-width-check.html: Removed.
* fast/block/inside-inlines/new-model/breaking-behavior-expected.html: Removed.
* fast/block/inside-inlines/new-model/breaking-behavior.html: Removed.
* fast/block/inside-inlines/new-model/empty-block-expected.html: Removed.
* fast/block/inside-inlines/new-model/empty-block.html: Removed.
* fast/block/inside-inlines/new-model/margin-collapse: Removed.
* fast/block/inside-inlines/new-model/margin-collapse/001-expected.html: Removed.
* fast/block/inside-inlines/new-model/margin-collapse/001.html: Removed.
* fast/block/inside-inlines/new-model/margin-collapse/002-expected.html: Removed.
* fast/block/inside-inlines/new-model/margin-collapse/002.html: Removed.
* fast/block/inside-inlines/new-model/margin-collapse/003-expected.html: Removed.
* fast/block/inside-inlines/new-model/margin-collapse/003.html: Removed.
* fast/block/inside-inlines/new-model/margin-collapse/004-expected.html: Removed.
* fast/block/inside-inlines/new-model/margin-collapse/004.html: Removed.
* fast/block/inside-inlines/new-model/margins-pushing-below-float-expected.html: Removed.
* fast/block/inside-inlines/new-model/margins-pushing-below-float.html: Removed.
* fast/block/inside-inlines/new-model/paint-order-expected.html: Removed.
* fast/block/inside-inlines/new-model/paint-order.html: Removed.
* fast/block/inside-inlines/new-model/self-collapsing-test-expected.html: Removed.
* fast/block/inside-inlines/new-model/self-collapsing-test.html: Removed.

[webkit-changes] [221459] trunk/Source/WebCore

[dbates]

Title: [221459] trunk/Source/WebCore








Revision 221459
Author dba...@webkit.org
Date 2017-08-31 16:55:12 -0700 (Thu, 31 Aug 2017)


Log Message
Make RenderStyle's non-inherited flags more human friendly
https://bugs.webkit.org/show_bug.cgi?id=176171

Reviewed by Antti Koivisto.

Revert r166465 as we never followed through and made the CSS JIT update
RenderStyle's non-inherited flags directly.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
(WebCore::RenderStyle::hashForTextAutosizing const):
(WebCore::RenderStyle::equalForTextAutosizing const):
(WebCore::RenderStyle::changeRequiresLayout const):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::styleType const):
(WebCore::RenderStyle::setStyleType):
(WebCore::RenderStyle::setHasViewportUnits):
(WebCore::RenderStyle::hasViewportUnits const):
(WebCore::RenderStyle::affectedByHover const):
(WebCore::RenderStyle::affectedByActive const):
(WebCore::RenderStyle::affectedByDrag const):
(WebCore::RenderStyle::setAffectedByHover):
(WebCore::RenderStyle::setAffectedByActive):
(WebCore::RenderStyle::setAffectedByDrag):
(WebCore::RenderStyle::isFloating const):
(WebCore::RenderStyle::display const):
(WebCore::RenderStyle::position const):
(WebCore::RenderStyle::floating const):
(WebCore::RenderStyle::overflowX const):
(WebCore::RenderStyle::overflowY const):
(WebCore::RenderStyle::verticalAlign const):
(WebCore::RenderStyle::unicodeBidi const):
(WebCore::RenderStyle::clear const):
(WebCore::RenderStyle::tableLayout const):
(WebCore::RenderStyle::hasExplicitlySetDirection const):
(WebCore::RenderStyle::isLink const):
(WebCore::RenderStyle::setDisplay):
(WebCore::RenderStyle::setOriginalDisplay):
(WebCore::RenderStyle::setPosition):
(WebCore::RenderStyle::setFloating):
(WebCore::RenderStyle::setOverflowX):
(WebCore::RenderStyle::setOverflowY):
(WebCore::RenderStyle::setVerticalAlign):
(WebCore::RenderStyle::setUnicodeBidi):
(WebCore::RenderStyle::setClear):
(WebCore::RenderStyle::setTableLayout):
(WebCore::RenderStyle::setHasExplicitlySetDirection):
(WebCore::RenderStyle::setIsLink):
(WebCore::RenderStyle::hasExplicitlySetWritingMode const):
(WebCore::RenderStyle::setHasExplicitlySetWritingMode):
(WebCore::RenderStyle::hasExplicitlySetTextAlign const):
(WebCore::RenderStyle::setHasExplicitlySetTextAlign):
(WebCore::RenderStyle::unique const):
(WebCore::RenderStyle::setUnique):
(WebCore::RenderStyle::emptyState const):
(WebCore::RenderStyle::setEmptyState):
(WebCore::RenderStyle::firstChildState const):
(WebCore::RenderStyle::setFirstChildState):
(WebCore::RenderStyle::lastChildState const):
(WebCore::RenderStyle::setLastChildState):
(WebCore::RenderStyle::setHasExplicitlyInheritedProperties):
(WebCore::RenderStyle::hasExplicitlyInheritedProperties const):
(WebCore::RenderStyle::inheritUnicodeBidiFrom):
(WebCore::RenderStyle::NonInheritedFlags::operator!= const):
(WebCore::RenderStyle::NonInheritedFlags::hasAnyPublicPseudoStyles const):
(WebCore::RenderStyle::originalDisplay const):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
(WebCore::RenderStyle::NonInheritedFlags::hasPseudoStyle const):
(WebCore::RenderStyle::NonInheritedFlags::setHasPseudoStyle):
(WebCore::RenderStyle::NonInheritedFlags::overflowX const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOverflowX): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::overflowY const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOverflowY): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::clear const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setClear): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::effectiveDisplay const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setEffectiveDisplay): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::position const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setPosition): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::originalDisplay const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setOriginalDisplay): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::unicodeBidi const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setUnicodeBidi): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasViewportUnits const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasViewportUnits): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::verticalAlign const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setVerticalAlign): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::hasExplicitlyInheritedProperties const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setHasExplicitlyInheritedProperties): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::isFloating const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::floating const): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::setFloating): Deleted.
(WebCore::RenderStyle::NonInheritedFlags::tableLayout const): Deleted.

[webkit-changes] [221460] trunk/Tools

[fpizlo]

Title: [221460] trunk/Tools








Revision 221460
Author fpi...@apple.com
Date 2017-08-31 17:09:14 -0700 (Thu, 31 Aug 2017)


Log Message
WSL should support makeptr (\)
https://bugs.webkit.org/show_bug.cgi?id=176197

Reviewed by Saam Barati.

This required introducing some sanity about how pointers are carried around in the evaluator.
It turns out that we need to be careful about when a pointer to an rvalue is dereferenced. It
should be dereferenced basically immediately. If it cannot be, then we need to snapshot the
value. To do that, we need to know the types of things in a few more places. That's what this
change accomplishes.

* WebGPUShadingLanguageRI/All.js:
* WebGPUShadingLanguageRI/CallFunction.js:
(callFunction):
* WebGPUShadingLanguageRI/Checker.js:
(Checker.prototype.visitProtocolDecl.set throw):
* WebGPUShadingLanguageRI/DereferenceExpression.js:
(DereferenceExpression.prototype.get isLValue):
* WebGPUShadingLanguageRI/Evaluator.js:
(Evaluator.prototype._snapshot):
(Evaluator.prototype.runBody):
(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype.visitDereferenceExpression):
(Evaluator.prototype.visitMakePtrExpression):
(Evaluator.prototype.visitCommaExpression):
(Evaluator.prototype.visitCallExpression):
(Evaluator):
(Evaluator.prototype._dereference): Deleted.
* WebGPUShadingLanguageRI/FuncInstantiator.js:
(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitFuncDef):
(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):
* WebGPUShadingLanguageRI/FunctionLikeBlock.js:
(FunctionLikeBlock):
(FunctionLikeBlock.prototype.get returnType):
(FunctionLikeBlock.prototype.toString):
* WebGPUShadingLanguageRI/Inliner.js:
(Inliner.prototype.visitCallExpression):
(Inliner):
* WebGPUShadingLanguageRI/MakePtrExpression.js: Added.
(MakePtrExpression):
(MakePtrExpression.prototype.get lValue):
(MakePtrExpression.prototype.toString):
* WebGPUShadingLanguageRI/NativeFuncInstance.js: Added.
(NativeFuncInstance):
(NativeFuncInstance.prototype.get func):
(NativeFuncInstance.prototype.toString):
* WebGPUShadingLanguageRI/Rewriter.js:
(Rewriter.prototype.visitMakePtrExpression):
(Rewriter.prototype.visitCallExpression):
* WebGPUShadingLanguageRI/Test.js:
(TEST_dereferenceStore):
(TEST_simpleMakePtr):
* WebGPUShadingLanguageRI/Value.js:
(Value.prototype.get isLValue):
(Value):
* WebGPUShadingLanguageRI/VariableRef.js:
(VariableRef.prototype.get isLValue):
(VariableRef.prototype.get addressSpace):
* WebGPUShadingLanguageRI/Visitor.js:
(Visitor.prototype.visitMakePtrExpression):
(Visitor.prototype.visitCallExpression):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebGPUShadingLanguageRI/All.js
trunk/Tools/WebGPUShadingLanguageRI/CallFunction.js
trunk/Tools/WebGPUShadingLanguageRI/Checker.js
trunk/Tools/WebGPUShadingLanguageRI/DereferenceExpression.js
trunk/Tools/WebGPUShadingLanguageRI/Evaluator.js
trunk/Tools/WebGPUShadingLanguageRI/FuncInstantiator.js
trunk/Tools/WebGPUShadingLanguageRI/FunctionLikeBlock.js
trunk/Tools/WebGPUShadingLanguageRI/Inliner.js
trunk/Tools/WebGPUShadingLanguageRI/Rewriter.js
trunk/Tools/WebGPUShadingLanguageRI/Test.js
trunk/Tools/WebGPUShadingLanguageRI/Value.js
trunk/Tools/WebGPUShadingLanguageRI/VariableRef.js
trunk/Tools/WebGPUShadingLanguageRI/Visitor.js


Added Paths

trunk/Tools/WebGPUShadingLanguageRI/MakePtrExpression.js
trunk/Tools/WebGPUShadingLanguageRI/NativeFuncInstance.js




Diff

Modified: trunk/Tools/ChangeLog (221459 => 221460)

--- trunk/Tools/ChangeLog	2017-08-31 23:55:12 UTC (rev 221459)
+++ trunk/Tools/ChangeLog	2017-09-01 00:09:14 UTC (rev 221460)
@@ -1,3 +1,70 @@
+2017-08-31  Filip Pizlo  
+
+WSL should support makeptr (\)
+https://bugs.webkit.org/show_bug.cgi?id=176197
+
+Reviewed by Saam Barati.
+
+This required introducing some sanity about how pointers are carried around in the evaluator.
+It turns out that we need to be careful about when a pointer to an rvalue is dereferenced. It
+should be dereferenced basically immediately. If it cannot be, then we need to snapshot the
+value. To do that, we need to know the types of things in a few more places. That's what this
+change accomplishes.
+
+* WebGPUShadingLanguageRI/All.js:
+* WebGPUShadingLanguageRI/CallFunction.js:
+(callFunction):
+* WebGPUShadingLanguageRI/Checker.js:
+(Checker.prototype.visitProtocolDecl.set throw):
+* WebGPUShadingLanguageRI/DereferenceExpression.js:
+(DereferenceExpression.prototype.get isLValue):
+* WebGPUShadingLanguageRI/Evaluator.js:
+(Evaluator.prototype._snapshot):
+(Evaluator.prototype.runBody):
+(Evaluator.prototype.visitFunctionLikeBlock):
+(Evaluator.prototype.visitDereferenceExpression):
+

[webkit-changes] [221466] trunk

[achristensen]

Title: [221466] trunk








Revision 221466
Author achristen...@apple.com
Date 2017-08-31 18:47:33 -0700 (Thu, 31 Aug 2017)


Log Message
Add WKUIDelegatePrivate equivalent of WKPageUIClient's isPlayingAudioDidChange
https://bugs.webkit.org/show_bug.cgi?id=176203


Reviewed by Tim Horton.

Source/WebKit:

* UIProcess/API/APIUIClient.h:
(API::UIClient::isPlayingMediaDidChange):
(API::UIClient::isPlayingAudioDidChange): Deleted.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::isPlayingMediaDidChange):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isPlayingMediaDidChange):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(-[MediaDelegate _webView:isPlayingMediaDidChange:]):
(-[MediaDelegate webView:didFinishNavigation:]):
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIUIClient.h
trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h
trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.h
trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (221465 => 221466)

--- trunk/Source/WebKit/ChangeLog	2017-09-01 01:46:26 UTC (rev 221465)
+++ trunk/Source/WebKit/ChangeLog	2017-09-01 01:47:33 UTC (rev 221466)
@@ -1,5 +1,26 @@
 2017-08-31  Alex Christensen  
 
+Add WKUIDelegatePrivate equivalent of WKPageUIClient's isPlayingAudioDidChange
+https://bugs.webkit.org/show_bug.cgi?id=176203
+
+
+Reviewed by Tim Horton.
+
+* UIProcess/API/APIUIClient.h:
+(API::UIClient::isPlayingMediaDidChange):
+(API::UIClient::isPlayingAudioDidChange): Deleted.
+* UIProcess/API/C/WKPage.cpp:
+(WKPageSetPageUIClient):
+* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
+* UIProcess/Cocoa/UIDelegate.h:
+* UIProcess/Cocoa/UIDelegate.mm:
+(WebKit::UIDelegate::setDelegate):
+(WebKit::UIDelegate::UIClient::isPlayingMediaDidChange):
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::isPlayingMediaDidChange):
+
+2017-08-31  Alex Christensen  
+
 Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
 https://bugs.webkit.org/show_bug.cgi?id=175779
 


Modified: trunk/Source/WebKit/UIProcess/API/APIUIClient.h (221465 => 221466)

--- trunk/Source/WebKit/UIProcess/API/APIUIClient.h	2017-09-01 01:46:26 UTC (rev 221465)
+++ trunk/Source/WebKit/UIProcess/API/APIUIClient.h	2017-09-01 01:47:33 UTC (rev 221466)
@@ -146,7 +146,7 @@
 
 virtual void pinnedStateDidChange(WebKit::WebPageProxy&) { }
 
-virtual void isPlayingAudioDidChange(WebKit::WebPageProxy&) { }
+virtual void isPlayingMediaDidChange(WebKit::WebPageProxy&, bool) { }
 virtual void mediaCaptureStateDidChange(WebCore::MediaProducer::MediaStateFlags) { }
 virtual void handleAutoplayEvent(WebKit::WebPageProxy&, WebCore::AutoplayEvent, OptionSet) { }
 


Modified: trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp (221465 => 221466)

--- trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp	2017-09-01 01:46:26 UTC (rev 221465)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPage.cpp	2017-09-01 01:47:33 UTC (rev 221466)
@@ -2059,7 +2059,7 @@
 m_client.pinnedStateDidChange(toAPI(), m_client.base.clientInfo);
 }
 
-void isPlayingAudioDidChange(WebPageProxy& page) final
+void isPlayingMediaDidChange(WebPageProxy& page, bool) final
 {
 if (!m_client.isPlayingAudioDidChange)
 return;


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h (221465 => 221466)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2017-09-01 01:46:26 UTC (rev 221465)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h	2017-09-01 01:47:33 UTC (rev 221466)
@@ -149,6 +149,7 @@
 - (void)_webView:(WKWebView *)webView takeFocus:(_WKFocusDirection)direction WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView didNotHandleWheelEvent:(NSEvent *)event WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView handleAutoplayEvent:(_WKAutoplayEvent)event withFlags:(_WKAutoplayEventFlags)flags WK_API_AVAILABLE(macosx(WK_MAC_TBA));
+- (void)_webView:(WKWebView *)webView isPlayingMediaDidChange:(BOOL)playingMedia WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView didClickAutoFillButtonWithUserInfo:(id )userInfo WK_API_AVAILABLE(macosx(WK_MAC_TBA));
 - (void)_webView:(WKWebView *)webView saveDataToFile:(NSData 

[webkit-changes] [221420] trunk

[carlosgc]

Title: [221420] trunk








Revision 221420
Author carlo...@webkit.org
Date 2017-08-31 07:10:21 -0700 (Thu, 31 Aug 2017)


Log Message
[GTK] Several InputMethodFilter tests are failing and crashing
https://bugs.webkit.org/show_bug.cgi?id=176158

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

* UIProcess/gtk/InputMethodFilter.cpp:
(WebKit::InputMethodFilter::confirmCurrentComposition): Return early in testing mode because the page is not available.
(WebKit::InputMethodFilter::logHandleKeyboardEventWithCompositionResultsForTesting): Use hexadecimal numbers for
logging key codes.

Tools:

This started to happen after the GTK+ upgrade from 3.16 to 3.22 in the internal jhbuild. Now, GtkIMContext
doesn't emit the preedit signals when using the compose key (GDK_KEY_Multi_key). The composition results are
committed directly when they are ready. The test InputMethodFilterComposeKey was failing because it expected
preedit events that no longer happen. Tests InputMethodFilterContextFocusOutDuringOngoingComposition and
InputMethodFilterContextMouseClickDuringOngoingComposition were crashing because InputMethodFilter::confirmCurrentComposition()
accessed the WebPageProxy unconditionally, that is not available in testing mode. I wonder how this ever
worked. Other tests results have also been updated because logHandleKeyboardEventWithCompositionResultsForTesting()
now uses hexadecimal numbers for the key codes, for consistency with all other event logs.

* TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
(TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
(TestWebKitAPI::TEST):
(TestWebKitAPI::verifyCanceledComposition): Deleted.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (221419 => 221420)

--- trunk/Source/WebKit/ChangeLog	2017-08-31 14:07:11 UTC (rev 221419)
+++ trunk/Source/WebKit/ChangeLog	2017-08-31 14:10:21 UTC (rev 221420)
@@ -1,5 +1,17 @@
 2017-08-31  Carlos Garcia Campos  
 
+[GTK] Several InputMethodFilter tests are failing and crashing
+https://bugs.webkit.org/show_bug.cgi?id=176158
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* UIProcess/gtk/InputMethodFilter.cpp:
+(WebKit::InputMethodFilter::confirmCurrentComposition): Return early in testing mode because the page is not available.
+(WebKit::InputMethodFilter::logHandleKeyboardEventWithCompositionResultsForTesting): Use hexadecimal numbers for
+logging key codes.
+
+2017-08-31  Carlos Garcia Campos  
+
 [GTK][Wayland] Crash when gdk_keymap_get_entries_for_keyval returns TRUE but n_keys=0
 https://bugs.webkit.org/show_bug.cgi?id=176154
 


Modified: trunk/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp (221419 => 221420)

--- trunk/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp	2017-08-31 14:07:11 UTC (rev 221419)
+++ trunk/Source/WebKit/UIProcess/gtk/InputMethodFilter.cpp	2017-08-31 14:10:21 UTC (rev 221420)
@@ -312,6 +312,14 @@
 {
 if (!m_composingTextCurrently)
 return;
+
+#if ENABLE(API_TESTS)
+if (m_testingMode) {
+m_composingTextCurrently = false;
+return;
+}
+#endif
+
 m_page->confirmComposition(String(), -1, 0);
 m_composingTextCurrently = false;
 }
@@ -431,7 +439,7 @@
 {
 const char* eventType = event->type == GDK_KEY_RELEASE ? "release" : "press";
 const char* fakedString = faked == EventFaked ? " (faked)" : "";
-m_events.append(String::format("sendKeyEventWithCompositionResults type=%s keycode=%u%s", eventType, event->keyval, fakedString));
+m_events.append(String::format("sendKeyEventWithCompositionResults type=%s keycode=%x%s", eventType, event->keyval, fakedString));
 
 if (resultsToSend & Composition && !m_confirmedComposition.isNull())
 logConfirmCompositionForTesting();


Modified: trunk/Tools/ChangeLog (221419 => 221420)

--- trunk/Tools/ChangeLog	2017-08-31 14:07:11 UTC (rev 221419)
+++ trunk/Tools/ChangeLog	2017-08-31 14:10:21 UTC (rev 221420)
@@ -1,5 +1,26 @@
 2017-08-31  Carlos Garcia Campos  
 
+[GTK] Several InputMethodFilter tests are failing and crashing
+https://bugs.webkit.org/show_bug.cgi?id=176158
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+This started to happen after the GTK+ upgrade from 3.16 to 3.22 in the internal jhbuild. Now, GtkIMContext
+doesn't emit the preedit signals when using the compose key (GDK_KEY_Multi_key). The composition results are
+committed directly when they are ready. The test InputMethodFilterComposeKey was failing because it expected
+preedit events that no longer happen. Tests InputMethodFilterContextFocusOutDuringOngoingComposition and
+InputMethodFilterContextMouseClickDuringOngoingComposition were 

[webkit-changes] [221419] trunk

[carlosgc]

Title: [221419] trunk








Revision 221419
Author carlo...@webkit.org
Date 2017-08-31 07:07:11 -0700 (Thu, 31 Aug 2017)


Log Message
[GTK][Wayland] Crash when gdk_keymap_get_entries_for_keyval returns TRUE but n_keys=0
https://bugs.webkit.org/show_bug.cgi?id=176154

Reviewed by Carlos Alberto Lopez Perez.

Source/WebKit:

In Wayland gdk_keymap_get_entries_for_keyval() can return TRUE with n_keys=0. We have several places in WebKit
where we just check the return value of gdk_keymap_get_entries_for_keyval() and then use the returned array to
get the first position assuming it has at least one item. This has always worked in X11 because the GDK X11
backend does the right thing, but it's crashing in Wayland now. It should be fixed in GTK+ but in the meantime
it's easy to workaround by also checking n_keys > 0.

* UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
(WebKit::doKeyStrokeEvent):

Tools:

Also check the n_keys > 0 when using gdk_keymap_get_entries_for_keyval().

* TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
* TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp: Remove duplicated code and use WebViewTest::keyStroke instead.
* TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
(WebViewTest::keyStroke):
* TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
(TestWebKitAPI::doKeyStroke):
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::keyDown):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp
trunk/Tools/TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp
trunk/Tools/TestWebKitAPI/gtk/PlatformWebViewGtk.cpp
trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (221418 => 221419)

--- trunk/Source/WebKit/ChangeLog	2017-08-31 12:57:51 UTC (rev 221418)
+++ trunk/Source/WebKit/ChangeLog	2017-08-31 14:07:11 UTC (rev 221419)
@@ -1,3 +1,19 @@
+2017-08-31  Carlos Garcia Campos  
+
+[GTK][Wayland] Crash when gdk_keymap_get_entries_for_keyval returns TRUE but n_keys=0
+https://bugs.webkit.org/show_bug.cgi?id=176154
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+In Wayland gdk_keymap_get_entries_for_keyval() can return TRUE with n_keys=0. We have several places in WebKit
+where we just check the return value of gdk_keymap_get_entries_for_keyval() and then use the returned array to
+get the first position assuming it has at least one item. This has always worked in X11 because the GDK X11
+backend does the right thing, but it's crashing in Wayland now. It should be fixed in GTK+ but in the meantime
+it's easy to workaround by also checking n_keys > 0.
+
+* UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
+(WebKit::doKeyStrokeEvent):
+
 2017-08-30  Dan Bernstein  
 
 [iOS] REGRESSION (r218144) -[WKContentView targetForAction:withSender:] returns the content view for actions implemented only by the WKWebView, causing a crash


Modified: trunk/Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp (221418 => 221419)

--- trunk/Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp	2017-08-31 12:57:51 UTC (rev 221418)
+++ trunk/Source/WebKit/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp	2017-08-31 14:07:11 UTC (rev 221419)
@@ -145,7 +145,7 @@
 // When synthesizing an event, an invalid hardware_keycode value can cause it to be badly processed by GTK+.
 GUniqueOutPtr keys;
 int keysCount;
-if (gdk_keymap_get_entries_for_keyval(gdk_keymap_get_default(), keyVal, (), ))
+if (gdk_keymap_get_entries_for_keyval(gdk_keymap_get_default(), keyVal, (), ) && keysCount)
 event->key.hardware_keycode = keys.get()[0].keycode;
 
 gtk_main_do_event(event.get());


Modified: trunk/Tools/ChangeLog (221418 => 221419)

--- trunk/Tools/ChangeLog	2017-08-31 12:57:51 UTC (rev 221418)
+++ trunk/Tools/ChangeLog	2017-08-31 14:07:11 UTC (rev 221419)
@@ -1,5 +1,24 @@
 2017-08-31  Carlos Garcia Campos  
 
+[GTK][Wayland] Crash when gdk_keymap_get_entries_for_keyval returns TRUE but n_keys=0
+https://bugs.webkit.org/show_bug.cgi?id=176154
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Also check the n_keys > 0 when using gdk_keymap_get_entries_for_keyval().
+
+* TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
+(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
+* TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp: Remove duplicated code and use WebViewTest::keyStroke instead.
+* TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
+(WebViewTest::keyStroke):
+* 

[webkit-changes] [221421] branches/safari-604-branch/Tools

[jmarcell]

Title: [221421] branches/safari-604-branch/Tools








Revision 221421
Author jmarc...@apple.com
Date 2017-08-31 08:23:14 -0700 (Thu, 31 Aug 2017)


Log Message
Cherry-pick r220296. rdar://problem/34177414

Modified Paths

branches/safari-604-branch/Tools/ChangeLog
branches/safari-604-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm




Diff

Modified: branches/safari-604-branch/Tools/ChangeLog (221420 => 221421)

--- branches/safari-604-branch/Tools/ChangeLog	2017-08-31 14:10:21 UTC (rev 221420)
+++ branches/safari-604-branch/Tools/ChangeLog	2017-08-31 15:23:14 UTC (rev 221421)
@@ -1,3 +1,22 @@
+2017-08-30  Jason Marcell  
+
+Cherry-pick r220296. rdar://problem/34177414
+
+2017-08-04  Tim Horton  
+
+Add an API test for r220286
+https://bugs.webkit.org/show_bug.cgi?id=175206
+
+Reviewed by Simon Fraser.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
+(-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
+(createAnimatedResizeWebView):
+(TEST):
+Add a test to ensure that we don't call
+_webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
+animated resize.
+
 2017-08-28  Jason Marcell  
 
 Cherry-pick r221153. rdar://problem/34113728


Modified: branches/safari-604-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm (221420 => 221421)

--- branches/safari-604-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm	2017-08-31 14:10:21 UTC (rev 221420)
+++ branches/safari-604-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm	2017-08-31 15:23:14 UTC (rev 221421)
@@ -39,8 +39,9 @@
 
 static bool didLayout;
 static bool didEndAnimatedResize;
+static bool didChangeSafeAreaShouldAffectObscuredInsets;
 
-@interface AnimatedResizeWebView : WKWebView
+@interface AnimatedResizeWebView : WKWebView 
 
 @end
 
@@ -53,9 +54,14 @@
 didEndAnimatedResize = true;
 }
 
+- (void)_webView:(WKWebView *)webView didChangeSafeAreaShouldAffectObscuredInsets:(BOOL)safeAreaShouldAffectObscuredInsets
+{
+didChangeSafeAreaShouldAffectObscuredInsets = true;
+}
+
 @end
 
-static RetainPtr createAnimatedResizeWebView()
+static RetainPtr createAnimatedResizeWebView()
 {
 RetainPtr<_WKProcessPoolConfiguration> processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
 [processPoolConfiguration setIgnoreSynchronousMessagingTimeoutsForTesting:YES];
@@ -64,11 +70,8 @@
 RetainPtr webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
 [webViewConfiguration setProcessPool:processPool.get()];
 
-RetainPtr webView = adoptNS([[AnimatedResizeWebView alloc] initWithFrame:CGRectMake(0, 0, 800, 600) configuration:webViewConfiguration.get()]);
+RetainPtr webView = adoptNS([[AnimatedResizeWebView alloc] initWithFrame:CGRectMake(0, 0, 800, 600) configuration:webViewConfiguration.get()]);
 
-NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"blinking-div" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
-[webView loadRequest:request];
-
 return webView;
 }
 
@@ -85,6 +88,8 @@
 TEST(WebKit2, DISABLED_ResizeWithHiddenContentDoesNotHang)
 {
 auto webView = createAnimatedResizeWebView();
+[webView loadRequest:[NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"blinking-div" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]]];
+
 auto navigationDelegate = createFirstVisuallyNonEmptyWatchingNavigationDelegate();
 [webView setNavigationDelegate:navigationDelegate.get()];
 RetainPtr window = adoptNS([[UIWindow alloc] initWithFrame:CGRectMake(0, 0, 800, 600)]);
@@ -107,6 +112,8 @@
 TEST(WebKit2, AnimatedResizeDoesNotHang)
 {
 auto webView = createAnimatedResizeWebView();
+[webView loadRequest:[NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"blinking-div" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]]];
+
 auto navigationDelegate = createFirstVisuallyNonEmptyWatchingNavigationDelegate();
 [webView setNavigationDelegate:navigationDelegate.get()];
 RetainPtr window = adoptNS([[UIWindow alloc] initWithFrame:CGRectMake(0, 0, 800, 600)]);
@@ -164,4 +171,51 @@
 TestWebKitAPI::Util::run();
 }
 
+TEST(WebKit2, AnimatedResizeBlocksViewportFitChanges)
+{
+auto webView = createAnimatedResizeWebView();
+[webView setUIDelegate:webView.get()];
+
+// We need to have something loaded before beginning the animated
+// resize, or it will bail.
+[webView loadHTMLString:@"" baseURL:nil];
+[webView _test_waitForDidFinishNavigation];
+
+RetainPtr window = adoptNS([[UIWindow alloc] initWithFrame:CGRectMake(0, 0, 800, 600)]);
+[window addSubview:webView.get()];
+[window setHidden:NO];
+
+[webView 

[webkit-changes] [221423] trunk

[darin]

Title: [221423] trunk








Revision 221423
Author da...@apple.com
Date 2017-08-31 09:55:50 -0700 (Thu, 31 Aug 2017)


Log Message
REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame() || !needsStyleRecalcOrLayout()  in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()
https://bugs.webkit.org/show_bug.cgi?id=175270

Reviewed by Simon Fraser and Antti Koivisto.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::Document): Initialize m_styleRecalcTimer with a lamdba so it can work
with a function that returns a bool and ignore the return value.
(WebCore::Document::updateStyleIfNeeded): Added a boolean return value indicating if the
function did any work or not.
* dom/Document.h: Updated for above change.

* page/FrameView.cpp:
(WebCore::appendRenderedChildren): Added helper that will later replace the
FrameView::renderedChildFrameViews function and is used below.
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Instead of always doing two
passes of style and layout update do up to 25 passes, but stop as soon as a pass does
no work. This is slightly more efficient in cases where no layout and style update is
needed, and works correctly when a additional passes are needed, which is what happens
in the test that was failing. We can eventually improve this further, but this resolves
the immediate problem we are seeing in the test.

LayoutTests:

* platform/mac-wk2/TestExpectations: Re-enable the disabled test.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Source/WebCore/page/FrameView.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (221422 => 221423)

--- trunk/LayoutTests/ChangeLog	2017-08-31 16:38:16 UTC (rev 221422)
+++ trunk/LayoutTests/ChangeLog	2017-08-31 16:55:50 UTC (rev 221423)
@@ -1,3 +1,12 @@
+2017-08-22  Darin Adler  
+
+REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame() || !needsStyleRecalcOrLayout()  in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()
+https://bugs.webkit.org/show_bug.cgi?id=175270
+
+Reviewed by Simon Fraser and Antti Koivisto.
+
+* platform/mac-wk2/TestExpectations: Re-enable the disabled test.
+
 2017-08-31  Ms2ger  
 
 [GTK] Mark some tests as passing.


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (221422 => 221423)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-08-31 16:38:16 UTC (rev 221422)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-08-31 16:55:50 UTC (rev 221423)
@@ -754,8 +754,6 @@
 
 webkit.org/b/173946 [ Debug ] media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Pass Failure ]
 
-webkit.org/b/175270 [ Debug ] plugins/crash-restoring-plugin-page-from-page-cache.html [ Skip ]
-
 # CSS Regions are being phased out.
 tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html [ Skip ]
 


Modified: trunk/Source/WebCore/ChangeLog (221422 => 221423)

--- trunk/Source/WebCore/ChangeLog	2017-08-31 16:38:16 UTC (rev 221422)
+++ trunk/Source/WebCore/ChangeLog	2017-08-31 16:55:50 UTC (rev 221423)
@@ -1,3 +1,27 @@
+2017-08-22  Darin Adler  
+
+REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame() || !needsStyleRecalcOrLayout()  in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()
+https://bugs.webkit.org/show_bug.cgi?id=175270
+
+Reviewed by Simon Fraser and Antti Koivisto.
+
+* dom/Document.cpp:
+(WebCore::Document::Document): Initialize m_styleRecalcTimer with a lamdba so it can work
+with a function that returns a bool and ignore the return value.
+(WebCore::Document::updateStyleIfNeeded): Added a boolean return value indicating if the
+function did any work or not.
+* dom/Document.h: Updated for above change.
+
+* page/FrameView.cpp:
+(WebCore::appendRenderedChildren): Added helper that will later replace the
+FrameView::renderedChildFrameViews function and is used below.
+(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Instead of always doing two
+passes of style and layout update do up to 25 passes, but stop as soon as a pass does
+no work. This is slightly more efficient in cases where no layout and style update is
+needed, and works correctly when a additional passes are needed, which is what happens
+in the test that was failing. We can eventually improve this further, but this resolves
+the immediate problem we are seeing in the test.
+
 2017-08-22  Filip Pizlo  
 
 Strings need to be in some kind of gigacage


Modified: trunk/Source/WebCore/dom/Document.cpp (221422 => 221423)

--- trunk/Source/WebCore/dom/Document.cpp	2017-08-31 16:38:16 UTC (rev 221422)
+++ 

[webkit-changes] [221436] trunk/Tools

[fpizlo]

Title: [221436] trunk/Tools








Revision 221436
Author fpi...@apple.com
Date 2017-08-31 12:51:08 -0700 (Thu, 31 Aug 2017)


Log Message
WSL parser should pass the token as the origin to the AST
https://bugs.webkit.org/show_bug.cgi?id=176177

Reviewed by Keith Miller.

Parse.js was sometimes passing token.origin as the origin, but that's just the filename
component of the origin. This fixes the problem and adds a test. The test previously failed
because instead of reporting the origin of the type error as ":1", it reported undefined.

* WebGPUShadingLanguageRI/Parse.js:
(parseProtocolRef):
(consumeEndOfTypeArgs):
(parseTypeParameters):
(parseTerm):
(parseTypeArguments):
(parseType):
(parseTypeDef):
(parseNative):
(parseLeftOperatorCall):
(parsePossibleSuffix):
(parsePossiblePrefix):
(parsePossibleRelationalEquality):
(parseLeftLogicalExpression):
(parsePossibleTernaryConditional):
(parsePossibleAssignment):
(genericParseCommaExpression):
(parseReturn):
(parseVariableDecls):
(parseBlock):
* WebGPUShadingLanguageRI/Test.js:
(checkFail):
(TEST_nameResolutionFailure):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/WebGPUShadingLanguageRI/Parse.js
trunk/Tools/WebGPUShadingLanguageRI/Test.js




Diff

Modified: trunk/Tools/ChangeLog (221435 => 221436)

--- trunk/Tools/ChangeLog	2017-08-31 19:42:00 UTC (rev 221435)
+++ trunk/Tools/ChangeLog	2017-08-31 19:51:08 UTC (rev 221436)
@@ -1,3 +1,38 @@
+2017-08-31  Filip Pizlo  
+
+WSL parser should pass the token as the origin to the AST
+https://bugs.webkit.org/show_bug.cgi?id=176177
+
+Reviewed by Keith Miller.
+
+Parse.js was sometimes passing token.origin as the origin, but that's just the filename
+component of the origin. This fixes the problem and adds a test. The test previously failed
+because instead of reporting the origin of the type error as ":1", it reported undefined.
+
+* WebGPUShadingLanguageRI/Parse.js:
+(parseProtocolRef):
+(consumeEndOfTypeArgs):
+(parseTypeParameters):
+(parseTerm):
+(parseTypeArguments):
+(parseType):
+(parseTypeDef):
+(parseNative):
+(parseLeftOperatorCall):
+(parsePossibleSuffix):
+(parsePossiblePrefix):
+(parsePossibleRelationalEquality):
+(parseLeftLogicalExpression):
+(parsePossibleTernaryConditional):
+(parsePossibleAssignment):
+(genericParseCommaExpression):
+(parseReturn):
+(parseVariableDecls):
+(parseBlock):
+* WebGPUShadingLanguageRI/Test.js:
+(checkFail):
+(TEST_nameResolutionFailure):
+
 2017-08-31  Keith Miller  
 
 Add a filter argument to WSL test suite.


Modified: trunk/Tools/WebGPUShadingLanguageRI/Parse.js (221435 => 221436)

--- trunk/Tools/WebGPUShadingLanguageRI/Parse.js	2017-08-31 19:42:00 UTC (rev 221435)
+++ trunk/Tools/WebGPUShadingLanguageRI/Parse.js	2017-08-31 19:51:08 UTC (rev 221436)
@@ -124,7 +124,7 @@
 function parseProtocolRef()
 {
 let protocolToken = consumeKind("identifier");
-return new ProtocolRef(protocolToken.origin, protocolToken.text);
+return new ProtocolRef(protocolToken, protocolToken.text);
 }
 
 function consumeEndOfTypeArgs()
@@ -131,7 +131,7 @@
 {
 let rightShift = tryConsume(">>");
 if (rightShift)
-lexer.push(new LexerToken(lexer, rightShift.origin, rightShift.index, rightShift.kind, ">"));
+lexer.push(new LexerToken(lexer, rightShift, rightShift.index, rightShift.kind, ">"));
 else
 consume(">");
 }
@@ -155,7 +155,7 @@
 else {
 let name = consumeKind("identifier");
 let protocol = tryConsume(":") ? parseProtocolRef() : null;
-result.push(new TypeVariable(name.origin, name.text, protocol));
+result.push(new TypeVariable(name, name.text, protocol));
 }
 if (!tryConsume(","))
 break;
@@ -168,18 +168,18 @@
 {
 let token;
 if (token = tryConsume("null"))
-return new Null(token.origin);
+return new Null(token);
 if (token = tryConsumeKind("identifier"))
-return new VariableRef(token.origin, token.text);
+return new VariableRef(token, token.text);
 if (token = tryConsumeKind("intLiteral")) {
 let intVersion = token.text | 0;
 if (intVersion != token.text)
 lexer.fail("Integer literal is not 32-bit integer");
-return new IntLiteral(token.origin, intVersion);
+return new IntLiteral(token, intVersion);
 }
 if (token = tryConsumeKind("doubleLiteral")) {
 token = consumeKind("doubleLiteral");
-return new DoubleLiteral(token.origin, +token.text);
+return new 

[webkit-changes] [221437] trunk

[commit-queue]

Title: [221437] trunk








Revision 221437
Author commit-qu...@webkit.org
Date 2017-08-31 13:03:42 -0700 (Thu, 31 Aug 2017)


Log Message
Add support for Request body stream cloning
https://bugs.webkit.org/show_bug.cgi?id=176148

Patch by Youenn Fablet  on 2017-08-31
Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/wpt/fetch/request-clone.html
   http/wpt/fetch/request-consume-stream.html
   http/wpt/fetch/request-stream-disturbed-1.html
   http/wpt/fetch/request-stream-disturbed-2.html
   http/wpt/fetch/request-stream-disturbed-3.html

Adding support for ReadableStream teeing for cloning fetch bodies.
Adding support for pushing request body data to its ReadableStream.
Renamed FetchResponseSource to FetchBodySource for that purpose.

Tests extracting body from a ReadableStream through JS API pass.
Tests extracting data stored in a ReadableStream to resolve fetch body promises are failing.
There is no support yet, this will be added as a follow-up.

* CMakeLists.txt:
* Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeAsStream):
(WebCore::FetchBody::clone):
* Modules/fetch/FetchBody.h:
* Modules/fetch/FetchBodyConsumer.h:
* Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::cloneBody):
(WebCore::FetchBodyOwner::loadBlob):
(WebCore::FetchBodyOwner::readableStream):
(WebCore::FetchBodyOwner::consumeBodyAsStream):
* Modules/fetch/FetchBodyOwner.h:
(WebCore::FetchBodyOwner::feedStream):
(WebCore::FetchBodyOwner::cancel):
* Modules/fetch/FetchBodySource.cpp: Renamed from Source/WebCore/Modules/fetch/FetchResponseSource.cpp.
* Modules/fetch/FetchBodySource.h: Renamed from Source/WebCore/Modules/fetch/FetchResponseSource.h.
* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::consumeBodyAsStream):
(WebCore::FetchResponse::createReadableStream):
* Modules/fetch/FetchResponse.h:
* Modules/fetch/FetchResponse.idl:
* Modules/fetch/FetchResponse.js:
(getter.body):
(clone):
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ReadableStream.cpp:
(WebCore::ReadableStream::tee):
* bindings/js/ReadableStream.h:
* bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

* http/wpt/fetch/request-clone-expected.txt: Added.
* http/wpt/fetch/request-clone.html: Added.
* http/wpt/fetch/request-consume-stream-expected.txt: Added.
* http/wpt/fetch/request-consume-stream.html: Added.
* http/wpt/fetch/request-stream-disturbed-1-expected.txt: Added.
* http/wpt/fetch/request-stream-disturbed-1.html: Added.
* http/wpt/fetch/request-stream-disturbed-2-expected.txt: Added.
* http/wpt/fetch/request-stream-disturbed-2.html: Added.
* http/wpt/fetch/request-stream-disturbed-3-expected.txt: Added.
* http/wpt/fetch/request-stream-disturbed-3.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/fetch/FetchBody.cpp
trunk/Source/WebCore/Modules/fetch/FetchBody.h
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.cpp
trunk/Source/WebCore/Modules/fetch/FetchBodyOwner.h
trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponse.h
trunk/Source/WebCore/Modules/fetch/FetchResponse.idl
trunk/Source/WebCore/Modules/fetch/FetchResponse.js
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/ReadableStream.cpp
trunk/Source/WebCore/bindings/js/ReadableStream.h
trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h


Added Paths

trunk/LayoutTests/http/wpt/fetch/request-clone-expected.txt
trunk/LayoutTests/http/wpt/fetch/request-clone.html
trunk/LayoutTests/http/wpt/fetch/request-consume-stream-expected.txt
trunk/LayoutTests/http/wpt/fetch/request-consume-stream.html
trunk/LayoutTests/http/wpt/fetch/request-stream-disturbed-1-expected.txt
trunk/LayoutTests/http/wpt/fetch/request-stream-disturbed-1.html
trunk/LayoutTests/http/wpt/fetch/request-stream-disturbed-2-expected.txt
trunk/LayoutTests/http/wpt/fetch/request-stream-disturbed-2.html
trunk/LayoutTests/http/wpt/fetch/request-stream-disturbed-3-expected.txt
trunk/LayoutTests/http/wpt/fetch/request-stream-disturbed-3.html
trunk/Source/WebCore/Modules/fetch/FetchBodySource.cpp
trunk/Source/WebCore/Modules/fetch/FetchBodySource.h


Removed Paths

trunk/Source/WebCore/Modules/fetch/FetchResponseSource.cpp
trunk/Source/WebCore/Modules/fetch/FetchResponseSource.h




Diff

Modified: trunk/LayoutTests/ChangeLog (221436 => 221437)

--- trunk/LayoutTests/ChangeLog	2017-08-31 19:51:08 UTC (rev 221436)
+++ trunk/LayoutTests/ChangeLog	2017-08-31 20:03:42 UTC (rev 221437)
@@ -1,3 +1,21 @@
+2017-08-31  Youenn Fablet  
+
+Add support for Request body stream cloning
+https://bugs.webkit.org/show_bug.cgi?id=176148
+
+Reviewed by Alex Christensen.
+
+* http/wpt/fetch/request-clone-expected.txt: Added.
+* http/wpt/fetch/request-clone.html: Added.
+* 

[webkit-changes] [221438] trunk/Source/WebCore

[mcatanzaro]

Title: [221438] trunk/Source/WebCore








Revision 221438
Author mcatanz...@igalia.com
Date 2017-08-31 13:09:53 -0700 (Thu, 31 Aug 2017)


Log Message
REGRESSION(r221226): [SOUP] libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed
https://bugs.webkit.org/show_bug.cgi?id=176140

Reviewed by Carlos Garcia Campos.

This should fix unexpected stderr output in several tests.

* platform/network/soup/CookieJarSoup.cpp:
(WebCore::cookiesForSession):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (221437 => 221438)

--- trunk/Source/WebCore/ChangeLog	2017-08-31 20:03:42 UTC (rev 221437)
+++ trunk/Source/WebCore/ChangeLog	2017-08-31 20:09:53 UTC (rev 221438)
@@ -1,3 +1,15 @@
+2017-08-31  Michael Catanzaro  
+
+REGRESSION(r221226): [SOUP] libsoup-CRITICAL **: soup_cookies_to_cookie_header: assertion 'cookies != NULL' failed
+https://bugs.webkit.org/show_bug.cgi?id=176140
+
+Reviewed by Carlos Garcia Campos.
+
+This should fix unexpected stderr output in several tests.
+
+* platform/network/soup/CookieJarSoup.cpp:
+(WebCore::cookiesForSession):
+
 2017-08-31  Youenn Fablet  
 
 Add support for Request body stream cloning


Modified: trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp (221437 => 221438)

--- trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp	2017-08-31 20:03:42 UTC (rev 221437)
+++ trunk/Source/WebCore/platform/network/soup/CookieJarSoup.cpp	2017-08-31 20:09:53 UTC (rev 221438)
@@ -107,6 +107,9 @@
 }
 }
 
+if (!cookies)
+return { { }, false };
+
 GUniquePtr cookieHeader(soup_cookies_to_cookie_header(cookies));
 soup_cookies_free(cookies);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221429] trunk/LayoutTests

[jbedard]

Title: [221429] trunk/LayoutTests








Revision 221429
Author jbed...@apple.com
Date 2017-08-31 11:37:38 -0700 (Thu, 31 Aug 2017)


Log Message
iOS should include both iPad and iPhone when running layout tests
https://bugs.webkit.org/show_bug.cgi?id=176172


Reviewed by Tim Horton.

* resources/ui-helper.js:
(window.UIHelper.isIOS):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/resources/ui-helper.js




Diff

Modified: trunk/LayoutTests/ChangeLog (221428 => 221429)

--- trunk/LayoutTests/ChangeLog	2017-08-31 18:31:22 UTC (rev 221428)
+++ trunk/LayoutTests/ChangeLog	2017-08-31 18:37:38 UTC (rev 221429)
@@ -1,3 +1,14 @@
+2017-08-31  Jonathan Bedard  
+
+iOS should include both iPad and iPhone when running layout tests
+https://bugs.webkit.org/show_bug.cgi?id=176172
+
+
+Reviewed by Tim Horton.
+
+* resources/ui-helper.js:
+(window.UIHelper.isIOS): 
+
 2017-08-31  Youenn Fablet  
 
 Take into account removed caches in Caches::remove assertion


Modified: trunk/LayoutTests/resources/ui-helper.js (221428 => 221429)

--- trunk/LayoutTests/resources/ui-helper.js	2017-08-31 18:31:22 UTC (rev 221428)
+++ trunk/LayoutTests/resources/ui-helper.js	2017-08-31 18:37:38 UTC (rev 221429)
@@ -2,7 +2,7 @@
 window.UIHelper = class UIHelper {
 static isIOS()
 {
-return navigator.userAgent.includes('iPhone');
+return navigator.userAgent.includes('iPhone') || navigator.userAgent.includes('iPad');
 }
 
 static isWebKit2()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [221428] trunk

[commit-queue]

Title: [221428] trunk








Revision 221428
Author commit-qu...@webkit.org
Date 2017-08-31 11:31:22 -0700 (Thu, 31 Aug 2017)


Log Message
Take into account removed caches in Caches::remove assertion
https://bugs.webkit.org/show_bug.cgi?id=176164

Patch by Youenn Fablet  on 2017-08-31
Reviewed by Alex Christensen.

Source/WebKit:

* NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::remove):

LayoutTests:

* http/wpt/cache-storage/cache-remove-twice-expected.txt: Added.
* http/wpt/cache-storage/cache-remove-twice.html: Added.
* http/wpt/cache-storage/resources/cache-remove-twice-iframe.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp


Added Paths

trunk/LayoutTests/http/wpt/cache-storage/cache-remove-twice-expected.txt
trunk/LayoutTests/http/wpt/cache-storage/cache-remove-twice.html
trunk/LayoutTests/http/wpt/cache-storage/resources/
trunk/LayoutTests/http/wpt/cache-storage/resources/cache-remove-twice-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (221427 => 221428)

--- trunk/LayoutTests/ChangeLog	2017-08-31 18:21:27 UTC (rev 221427)
+++ trunk/LayoutTests/ChangeLog	2017-08-31 18:31:22 UTC (rev 221428)
@@ -1,3 +1,14 @@
+2017-08-31  Youenn Fablet  
+
+Take into account removed caches in Caches::remove assertion
+https://bugs.webkit.org/show_bug.cgi?id=176164
+
+Reviewed by Alex Christensen.
+
+* http/wpt/cache-storage/cache-remove-twice-expected.txt: Added.
+* http/wpt/cache-storage/cache-remove-twice.html: Added.
+* http/wpt/cache-storage/resources/cache-remove-twice-iframe.html: Added.
+
 2017-08-31  Michael Catanzaro  
 
 Unreviewed, remove crash expectation for hopefully-fixed test


Added: trunk/LayoutTests/http/wpt/cache-storage/cache-remove-twice-expected.txt (0 => 221428)

--- trunk/LayoutTests/http/wpt/cache-storage/cache-remove-twice-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/wpt/cache-storage/cache-remove-twice-expected.txt	2017-08-31 18:31:22 UTC (rev 221428)
@@ -0,0 +1,6 @@
+
+
+PASS Cleaning existing caches 
+PASS Removing the same cache from two different documents 
+PASS Cleaning added caches 
+


Added: trunk/LayoutTests/http/wpt/cache-storage/cache-remove-twice.html (0 => 221428)

--- trunk/LayoutTests/http/wpt/cache-storage/cache-remove-twice.html	(rev 0)
+++ trunk/LayoutTests/http/wpt/cache-storage/cache-remove-twice.html	2017-08-31 18:31:22 UTC (rev 221428)
@@ -0,0 +1,45 @@
+
+
+
+Cache Storage: testing persistency
+
+
+

+
+