date:20200211

[webkit-changes] [256294] trunk/Source

2020-02-11 Thread cfleizach

Title: [256294] trunk/Source








Revision 256294
Author cfleiz...@apple.com
Date 2020-02-11 00:10:59 -0800 (Tue, 11 Feb 2020)


Log Message
AX: Unable to build webkit open source - build errors related to AXClientType
https://bugs.webkit.org/show_bug.cgi?id=207524


Reviewed by Mark Lam.

Source/WebCore/PAL:

* pal/spi/mac/HIServicesSPI.h:

Source/WebKit:

* Platform/spi/mac/ApplicationServicesSPI.h:

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (256293 => 256294)

--- trunk/Source/WebCore/PAL/ChangeLog	2020-02-11 06:26:49 UTC (rev 256293)
+++ trunk/Source/WebCore/PAL/ChangeLog	2020-02-11 08:10:59 UTC (rev 256294)
@@ -1,3 +1,13 @@
+2020-02-11  chris fleizach  
+
+AX: Unable to build webkit open source - build errors related to AXClientType
+https://bugs.webkit.org/show_bug.cgi?id=207524
+
+
+Reviewed by Mark Lam.
+
+* pal/spi/mac/HIServicesSPI.h:
+
 2020-02-10  Truitt Savell  
 
 Unreviewed, rolling out r256091.


Modified: trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h (256293 => 256294)

--- trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h	2020-02-11 06:26:49 UTC (rev 256293)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h	2020-02-11 08:10:59 UTC (rev 256294)
@@ -126,4 +126,26 @@
 bool _AXUIElementRequestServicedBySecondaryAXThread(void);
 OSStatus SetApplicationIsDaemon(Boolean);
 
+#if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+AXError _AXUIElementUseSecondaryAXThread(bool enabled);
+#endif
+
+#if HAVE(AX_CLIENT_TYPE)
+typedef CF_ENUM(int32_t, AXClientType)
+{
+kAXClientTypeNoActiveRequestFound  = 0,
+kAXClientTypeUnknown,
+kAXClientTypeRaft,
+kAXClientTypeXCUITest,
+kAXClientTypeXCTest,
+kAXClientTypeScripter2,
+kAXClientTypeSystemEvents,
+kAXClientTypeVoiceOver,
+kAXClientTypeAssistiveControl,
+kAXClientTypeFullKeyboardAccess,
+kAXClientTypeDictation,
+};
+AXClientType _AXGetClientForCurrentRequestUntrusted(void);
+#endif // HAVE(AX_CLIENT_TYPE)
+
 WTF_EXTERN_C_END


Modified: trunk/Source/WebKit/ChangeLog (256293 => 256294)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 06:26:49 UTC (rev 256293)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 08:10:59 UTC (rev 256294)
@@ -1,3 +1,13 @@
+2020-02-11  chris fleizach  
+
+AX: Unable to build webkit open source - build errors related to AXClientType
+https://bugs.webkit.org/show_bug.cgi?id=207524
+
+
+Reviewed by Mark Lam.
+
+* Platform/spi/mac/ApplicationServicesSPI.h:
+
 2020-02-10  Jiewen Tan  
 
 [WebAuthn] Move the async code from WebAuthenticationPanelClient to AuthenticatorManager


Modified: trunk/Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h (256293 => 256294)

--- trunk/Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h	2020-02-11 06:26:49 UTC (rev 256293)
+++ trunk/Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h	2020-02-11 08:10:59 UTC (rev 256294)
@@ -33,25 +33,6 @@
 
 #else
 
-#if HAVE(AX_CLIENT_TYPE)
-
-typedef CF_ENUM(int32_t, AXClientType)
-{
-kAXClientTypeNoActiveRequestFound  = 0,
-kAXClientTypeUnknown,
-kAXClientTypeRaft,
-kAXClientTypeXCUITest,
-kAXClientTypeXCTest,
-kAXClientTypeScripter2,
-kAXClientTypeSystemEvents,
-kAXClientTypeVoiceOver,
-kAXClientTypeAssistiveControl,
-kAXClientTypeFullKeyboardAccess,
-kAXClientTypeDictation,
-};
-
-#endif // HAVE(AX_CLIENT_TYPE)
-
 typedef enum {
 AXSuspendStatusRunning = 0,
 AXSuspendStatusSuspended,
@@ -59,8 +40,4 @@
 
 #endif
 
-#if HAVE(AX_CLIENT_TYPE)
-extern AXClientType _AXGetClientForCurrentRequestUntrusted(void);
-#endif // HAVE(AX_CLIENT_TYPE)
-
 #endif // PLATFORM(MAC)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256295] releases/WebKitGTK/webkit-2.28

2020-02-11 Thread aperez

Title: [256295] releases/WebKitGTK/webkit-2.28








Revision 256295
Author ape...@igalia.com
Date 2020-02-11 00:21:06 -0800 (Tue, 11 Feb 2020)


Log Message
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.90 release

.:

* Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

* wpe/NEWS: Add release notes for 2.27.90.

Modified Paths

releases/WebKitGTK/webkit-2.28/ChangeLog
releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog
releases/WebKitGTK/webkit-2.28/Source/WebKit/wpe/NEWS
releases/WebKitGTK/webkit-2.28/Source/cmake/OptionsWPE.cmake




Diff

Modified: releases/WebKitGTK/webkit-2.28/ChangeLog (256294 => 256295)

--- releases/WebKitGTK/webkit-2.28/ChangeLog	2020-02-11 08:10:59 UTC (rev 256294)
+++ releases/WebKitGTK/webkit-2.28/ChangeLog	2020-02-11 08:21:06 UTC (rev 256295)
@@ -1,3 +1,9 @@
+2020-02-10  Adrian Perez de Castro  
+
+Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.90 release
+
+* Source/cmake/OptionsWPE.cmake: Bump version numbers.
+
 2020-02-10  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.27.90 release


Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog (256294 => 256295)

--- releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog	2020-02-11 08:10:59 UTC (rev 256294)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/ChangeLog	2020-02-11 08:21:06 UTC (rev 256295)
@@ -1,3 +1,9 @@
+2020-02-10  Adrian Perez de Castro  
+
+Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.27.90 release
+
+* wpe/NEWS: Add release notes for 2.27.90.
+
 2020-02-10  Carlos Garcia Campos  
 
 Unreviewed. Update OptionsGTK.cmake and NEWS for 2.27.90 release


Modified: releases/WebKitGTK/webkit-2.28/Source/WebKit/wpe/NEWS (256294 => 256295)

--- releases/WebKitGTK/webkit-2.28/Source/WebKit/wpe/NEWS	2020-02-11 08:10:59 UTC (rev 256294)
+++ releases/WebKitGTK/webkit-2.28/Source/WebKit/wpe/NEWS	2020-02-11 08:21:06 UTC (rev 256295)
@@ -1,3 +1,16 @@
+==
+WPE WebKit 2.27.90
+==
+
+What's new in WPE WebKit 2.27.90?
+
+  - Add support for same-site cookies.
+  - Add Flatpak sandbox support.
+  - Enable WebAudio and WebGL by default in WebKitSettings.
+  - Add a setting to disallow top level navigation to a data URI.
+  - Add support for the -webkit-font-smoothing CSS property.
+  - Fix several crashes and rendering issues.
+
 =
 WPE WebKit 2.27.4
 =


Modified: releases/WebKitGTK/webkit-2.28/Source/cmake/OptionsWPE.cmake (256294 => 256295)

--- releases/WebKitGTK/webkit-2.28/Source/cmake/OptionsWPE.cmake	2020-02-11 08:10:59 UTC (rev 256294)
+++ releases/WebKitGTK/webkit-2.28/Source/cmake/OptionsWPE.cmake	2020-02-11 08:21:06 UTC (rev 256295)
@@ -1,10 +1,10 @@
 include(GNUInstallDirs)
 include(VersioningUtils)
 
-SET_PROJECT_VERSION(2 27 4)
+SET_PROJECT_VERSION(2 27 90)
 set(WPE_API_VERSION 1.0)
 
-CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 12 0 9)
+CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 13 0 10)
 
 # These are shared variables, but we special case their definition so that we can use the
 # CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256296] releases/WPE WebKit/webkit-2.27.90/

2020-02-11 Thread aperez

Title: [256296] releases/WPE WebKit/webkit-2.27.90/








Revision 256296
Author ape...@igalia.com
Date 2020-02-11 00:21:31 -0800 (Tue, 11 Feb 2020)


Log Message
WPE WebKit 2.27.90

Added Paths

releases/WPE WebKit/webkit-2.27.90/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256297] trunk/Tools

2020-02-11 Thread wenson_hsieh

Title: [256297] trunk/Tools








Revision 256297
Author wenson_hs...@apple.com
Date 2020-02-11 00:24:47 -0800 (Tue, 11 Feb 2020)


Log Message
[iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=207525


Reviewed by Tim Horton.

After the fix for , some scroll view content offset changes will attempt to call into
CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
causing us to crash upon trying to create the dictionary.

While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
beginning of each API test.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/cocoa/TestWKWebView.mm:
(overrideBundleIdentifier):

Move this to the top of the file, so it can be shared.

(+[WKWebView initialize]):

At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
internal class method that calls into the internal helper function, with no other side effects.

* TestWebKitAPI/ios/UIKitSPI.h:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm
trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h




Diff

Modified: trunk/Tools/ChangeLog (256296 => 256297)

--- trunk/Tools/ChangeLog	2020-02-11 08:21:31 UTC (rev 256296)
+++ trunk/Tools/ChangeLog	2020-02-11 08:24:47 UTC (rev 256297)
@@ -1,3 +1,38 @@
+2020-02-11  Wenson Hsieh  
+
+[iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
+https://bugs.webkit.org/show_bug.cgi?id=207525
+
+
+Reviewed by Tim Horton.
+
+After the fix for , some scroll view content offset changes will attempt to call into
+CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
+creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
+unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
+UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
+causing us to crash upon trying to create the dictionary.
+
+While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
+some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
+identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
+throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
+identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
+beginning of each API test.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/cocoa/TestWKWebView.mm:
+(overrideBundleIdentifier):
+
+Move this to the top of the file, so it can be shared.
+
+(+[WKWebView initialize]):
+
+At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
+internal class method that calls into the internal helper function, with no other side effects.
+
+* TestWebKitAPI/ios/UIKitSPI.h:
+
 2020-02-10  Jonathan Bedard  
 
 TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst


Modified: trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm (256296 => 256297)

--- trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm	2020-02-11 08:21:31 UTC (rev 256296)
+++ trunk/Tools/TestWebKitAPI/cocoa/TestWKWebView.mm	2020-02-11 08:24:47 UTC (rev 256297)
@@ -51,6 +51,11 @@
 SOFT_LINK_FRAMEWORK(UIKit)
 SOFT_LINK_CLASS(UIKit, UIWindow)
 
+static NSString *overrideBundleIdentifier(id, SEL)
+{
+return @"com.apple.TestWebKitAPI";
+}
+
 @implementation WKWebView (WKWebViewTestingQuirks)
 
 // TestWebKitAPI is currently not a UIApplication so we are unable to track if it is in
@@ -66,6 +71,22 @@
 
 @implementation WKWebView (TestWebKitAPI)
 
+#if PLATFORM(IOS_FAMILY

[webkit-changes] [256298] trunk/Source/WebCore

2020-02-11 Thread carlosgc

Title: [256298] trunk/Source/WebCore








Revision 256298
Author carlo...@webkit.org
Date 2020-02-11 01:35:23 -0800 (Tue, 11 Feb 2020)


Log Message
[WPE] Add initial support for rendering scrollbars
https://bugs.webkit.org/show_bug.cgi?id=206999

Reviewed by Michael Catanzaro.

Show overlay scrollbars with a style similar to Adwaita.

* SourcesWPE.txt: Add ScrollAnimatorGeneric.cpp to the build.
* platform/ScrollAnimator.cpp: Switch to use ScrollAnimatorGeneric, required to show/hide the overlay scrollbars.
* platform/wpe/ScrollbarThemeWPE.cpp:
(WebCore::ScrollbarThemeWPE::scrollbarThickness):
(WebCore::ScrollbarThemeWPE::minimumThumbLength):
(WebCore::ScrollbarThemeWPE::hasButtons):
(WebCore::ScrollbarThemeWPE::hasThumb):
(WebCore::ScrollbarThemeWPE::backButtonRect):
(WebCore::ScrollbarThemeWPE::forwardButtonRect):
(WebCore::ScrollbarThemeWPE::trackRect):
(WebCore::ScrollbarThemeWPE::paint):
* platform/wpe/ScrollbarThemeWPE.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/SourcesWPE.txt
trunk/Source/WebCore/platform/ScrollAnimator.cpp
trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.cpp
trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256297 => 256298)

--- trunk/Source/WebCore/ChangeLog	2020-02-11 08:24:47 UTC (rev 256297)
+++ trunk/Source/WebCore/ChangeLog	2020-02-11 09:35:23 UTC (rev 256298)
@@ -1,3 +1,25 @@
+2020-01-30  Carlos Garcia Campos  
+
+[WPE] Add initial support for rendering scrollbars
+https://bugs.webkit.org/show_bug.cgi?id=206999
+
+Reviewed by Michael Catanzaro.
+
+Show overlay scrollbars with a style similar to Adwaita.
+
+* SourcesWPE.txt: Add ScrollAnimatorGeneric.cpp to the build.
+* platform/ScrollAnimator.cpp: Switch to use ScrollAnimatorGeneric, required to show/hide the overlay scrollbars.
+* platform/wpe/ScrollbarThemeWPE.cpp:
+(WebCore::ScrollbarThemeWPE::scrollbarThickness):
+(WebCore::ScrollbarThemeWPE::minimumThumbLength):
+(WebCore::ScrollbarThemeWPE::hasButtons):
+(WebCore::ScrollbarThemeWPE::hasThumb):
+(WebCore::ScrollbarThemeWPE::backButtonRect):
+(WebCore::ScrollbarThemeWPE::forwardButtonRect):
+(WebCore::ScrollbarThemeWPE::trackRect):
+(WebCore::ScrollbarThemeWPE::paint):
+* platform/wpe/ScrollbarThemeWPE.h:
+
 2020-02-10  Keith Rollin  
 
 Adjust the minor version number for the desktop user agent string.


Modified: trunk/Source/WebCore/SourcesWPE.txt (256297 => 256298)

--- trunk/Source/WebCore/SourcesWPE.txt	2020-02-11 08:24:47 UTC (rev 256297)
+++ trunk/Source/WebCore/SourcesWPE.txt	2020-02-11 09:35:23 UTC (rev 256298)
@@ -59,8 +59,11 @@
 
 page/scrolling/generic/ScrollingThreadGeneric.cpp
 
+platform/ScrollAnimationKinetic.cpp
 platform/UserAgentQuirks.cpp
 
+platform/generic/ScrollAnimatorGeneric.cpp
+
 platform/graphics/GLContext.cpp
 platform/graphics/PlatformDisplay.cpp
 


Modified: trunk/Source/WebCore/platform/ScrollAnimator.cpp (256297 => 256298)

--- trunk/Source/WebCore/platform/ScrollAnimator.cpp	2020-02-11 08:24:47 UTC (rev 256297)
+++ trunk/Source/WebCore/platform/ScrollAnimator.cpp	2020-02-11 09:35:23 UTC (rev 256298)
@@ -41,7 +41,7 @@
 
 namespace WebCore {
 
-#if !ENABLE(SMOOTH_SCROLLING) && !PLATFORM(IOS_FAMILY) && !PLATFORM(MAC)
+#if !ENABLE(SMOOTH_SCROLLING) && !PLATFORM(IOS_FAMILY) && !PLATFORM(MAC) && !PLATFORM(WPE)
 std::unique_ptr ScrollAnimator::create(ScrollableArea& scrollableArea)
 {
 return makeUnique(scrollableArea);


Modified: trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.cpp (256297 => 256298)

--- trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.cpp	2020-02-11 08:24:47 UTC (rev 256297)
+++ trunk/Source/WebCore/platform/wpe/ScrollbarThemeWPE.cpp	2020-02-11 09:35:23 UTC (rev 256298)
@@ -26,40 +26,184 @@
 #include "config.h"
 #include "ScrollbarThemeWPE.h"
 
-#include "NotImplemented.h"
+#include "Color.h"
+#include "FloatRoundedRect.h"
+#include "GraphicsContext.h"
+#include "PlatformMouseEvent.h"
+#include "Scrollbar.h"
 
 namespace WebCore {
 
+static const unsigned scrollbarSize = 13;
+static const unsigned hoveredScrollbarBorderSize = 1;
+static const unsigned thumbBorderSize = 1;
+static const unsigned overlayThumbSize = 5;
+static const unsigned thumbSize = 6;
+static const double scrollbarOpacity = 0.8;
+static const Color scrollbarBackgroundColor = makeRGB(252, 252, 252);
+static const Color scrollbarBorderColor = makeRGB(220, 223, 227);
+static const Color overlayThumbBorderColor = makeRGBA(255, 255, 255, 100);
+static const Color overlayThumbColor = makeRGBA(46, 52, 54, 100);
+static const Color thumbHoveredColor = makeRGB(86, 91, 92);
+static const Color thumbPressedColor = makeRGB(27, 106, 203);
+static const Color thumbColor = makeRGB(126, 129, 130);
+
+int ScrollbarThemeWPE::scrollbarThickness(ScrollbarControlSize, ScrollbarExpansionState)
+{
+return scrollbarSize;
+}
+
+int Scrollb

[webkit-changes] [256299] trunk/LayoutTests

2020-02-11 Thread commit-queue

Title: [256299] trunk/LayoutTests








Revision 256299
Author commit-qu...@webkit.org
Date 2020-02-11 02:47:26 -0800 (Tue, 11 Feb 2020)


Log Message
[GTK][WPE] imported/w3c/web-platform-tests/css/css-lists/counter-* tests consistently pass
https://bugs.webkit.org/show_bug.cgi?id=207533

Unreviewed test gardening.

Patch by Chris Lord  on 2020-02-11

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/wpe/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256298 => 256299)

--- trunk/LayoutTests/ChangeLog	2020-02-11 09:35:23 UTC (rev 256298)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 10:47:26 UTC (rev 256299)
@@ -1,3 +1,13 @@
+2020-02-11  Chris Lord  
+
+[GTK][WPE] imported/w3c/web-platform-tests/css/css-lists/counter-* tests consistently pass
+https://bugs.webkit.org/show_bug.cgi?id=207533
+
+Unreviewed test gardening.
+
+* platform/gtk/TestExpectations:
+* platform/wpe/TestExpectations:
+
 2020-02-10  Sihui Liu  
 
 REGRESSION: (253807) [ macOS iOS ] storage/indexeddb/intversion-long-queue-private.html is flaky failing


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (256298 => 256299)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2020-02-11 09:35:23 UTC (rev 256298)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2020-02-11 10:47:26 UTC (rev 256299)
@@ -4246,6 +4246,8 @@
 
 imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-greek.html [ Pass ]
 imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-latin.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-lists/counter-increment-inside-display-contents.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-lists/counter-reset-inside-display-contents.html [ Pass ]
 
 fast/text/emoji-gender-2-3.html [ Pass ]
 fast/text/emoji-gender-2-4.html [ Pass ]


Modified: trunk/LayoutTests/platform/wpe/TestExpectations (256298 => 256299)

--- trunk/LayoutTests/platform/wpe/TestExpectations	2020-02-11 09:35:23 UTC (rev 256298)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2020-02-11 10:47:26 UTC (rev 256299)
@@ -867,6 +867,8 @@
 imported/w3c/web-platform-tests/css/css-display/run-in/quotes-applies-to-011.xht [ Pass ]
 imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-greek.html [ Pass ]
 imported/w3c/web-platform-tests/css/css-lists/content-property/marker-text-matches-lower-latin.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-lists/counter-increment-inside-display-contents.html [ Pass ]
+imported/w3c/web-platform-tests/css/css-lists/counter-reset-inside-display-contents.html [ Pass ]
 imported/w3c/web-platform-tests/css/css-scoping/stylesheet-title-001.html [ Pass ]
 imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-004.html [ Pass ]
 imported/w3c/web-platform-tests/css/css-text/boundary-shaping/boundary-shaping-005.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256300] trunk/LayoutTests

2020-02-11 Thread commit-queue

Title: [256300] trunk/LayoutTests








Revision 256300
Author commit-qu...@webkit.org
Date 2020-02-11 03:31:58 -0800 (Tue, 11 Feb 2020)


Log Message
REGRESSION: [ Mac ] legacy-animation-engine/fast/animation/request-animation-frame-iframe2.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206624

Patch by Said Abou-Hallawa  on 2020-02-11
Reviewed by Antoine Quint.

Rewrite test to have a reliable asynchronous execution order.

* fast/animation/script-tests/request-animation-frame-subframe.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (256299 => 256300)

--- trunk/LayoutTests/ChangeLog	2020-02-11 10:47:26 UTC (rev 256299)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 11:31:58 UTC (rev 256300)
@@ -1,3 +1,14 @@
+2020-02-11  Said Abou-Hallawa  
+
+REGRESSION: [ Mac ] legacy-animation-engine/fast/animation/request-animation-frame-iframe2.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=206624
+
+Reviewed by Antoine Quint.
+
+Rewrite test to have a reliable asynchronous execution order.
+
+* fast/animation/script-tests/request-animation-frame-subframe.html:
+
 2020-02-11  Chris Lord  
 
 [GTK][WPE] imported/w3c/web-platform-tests/css/css-lists/counter-* tests consistently pass


Modified: trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html (256299 => 256300)

--- trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html	2020-02-11 10:47:26 UTC (rev 256299)
+++ trunk/LayoutTests/fast/animation/script-tests/request-animation-frame-subframe.html	2020-02-11 11:31:58 UTC (rev 256300)
@@ -7,17 +7,24 @@
 
 window.requestAnimationFrame(function() {
 parent.callbackInvoked = true;
+doWork();
 });
 
-parent.doDisplay();
-
-setTimeout(function() {
+function timeoutPromise(interval) {
+return new Promise((resolve, reject) => {
+setTimeout(function(){
+resolve("done");
+}, interval);
+});
+}
+
+async function doWork() {
+parent.doDisplay();
+await timeoutPromise(100);
 parent.doCheckResult();
-}, 100);
-
-setTimeout(function() {
+await timeoutPromise(100);
 parent.doTestDone();
-}, 200);
+}   
 
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256301] trunk/Source/WebCore

2020-02-11 Thread carlosgc

Title: [256301] trunk/Source/WebCore








Revision 256301
Author carlo...@webkit.org
Date 2020-02-11 05:03:46 -0800 (Tue, 11 Feb 2020)


Log Message
Unreviewed. Fix WPE build after r256298

It started to fail in r256298 because of unified builds, but the issue was introduced in r256013.

* platform/network/soup/ResourceRequestSoup.cpp: Add missing header include.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (256300 => 256301)

--- trunk/Source/WebCore/ChangeLog	2020-02-11 11:31:58 UTC (rev 256300)
+++ trunk/Source/WebCore/ChangeLog	2020-02-11 13:03:46 UTC (rev 256301)
@@ -1,3 +1,11 @@
+2020-02-11  Carlos Garcia Campos  
+
+Unreviewed. Fix WPE build after r256298
+
+It started to fail in r256298 because of unified builds, but the issue was introduced in r256013.
+
+* platform/network/soup/ResourceRequestSoup.cpp: Add missing header include.
+
 2020-01-30  Carlos Garcia Campos  
 
 [WPE] Add initial support for rendering scrollbars


Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp (256300 => 256301)

--- trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp	2020-02-11 11:31:58 UTC (rev 256300)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp	2020-02-11 13:03:46 UTC (rev 256301)
@@ -27,6 +27,7 @@
 #include "GUniquePtrSoup.h"
 #include "HTTPParsers.h"
 #include "MIMETypeRegistry.h"
+#include "RegistrableDomain.h"
 #include "SharedBuffer.h"
 #include "URLSoup.h"
 #include 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256302] trunk/Tools

2020-02-11 Thread commit-queue

Title: [256302] trunk/Tools








Revision 256302
Author commit-qu...@webkit.org
Date 2020-02-11 05:09:59 -0800 (Tue, 11 Feb 2020)


Log Message
[WPE][WebDriver] MiniBrowser should react to close session commands
https://bugs.webkit.org/show_bug.cgi?id=207529

Patch by Lauro Moura  on 2020-02-11
Reviewed by Carlos Garcia Campos.

WebDriver delete session command asks to close the WebView associated to the
current automation session. We must react to it to avoid lots of
timeouts and errors.

* MiniBrowser/wpe/main.cpp:
(main): Listen to "close" signal on the main WebView.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/wpe/main.cpp




Diff

Modified: trunk/Tools/ChangeLog (256301 => 256302)

--- trunk/Tools/ChangeLog	2020-02-11 13:03:46 UTC (rev 256301)
+++ trunk/Tools/ChangeLog	2020-02-11 13:09:59 UTC (rev 256302)
@@ -1,3 +1,17 @@
+2020-02-11  Lauro Moura  
+
+[WPE][WebDriver] MiniBrowser should react to close session commands
+https://bugs.webkit.org/show_bug.cgi?id=207529
+
+Reviewed by Carlos Garcia Campos.
+
+WebDriver delete session command asks to close the WebView associated to the
+current automation session. We must react to it to avoid lots of
+timeouts and errors.
+
+* MiniBrowser/wpe/main.cpp:
+(main): Listen to "close" signal on the main WebView.
+
 2020-02-11  Wenson Hsieh  
 
 [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions


Modified: trunk/Tools/MiniBrowser/wpe/main.cpp (256301 => 256302)

--- trunk/Tools/MiniBrowser/wpe/main.cpp	2020-02-11 13:03:46 UTC (rev 256301)
+++ trunk/Tools/MiniBrowser/wpe/main.cpp	2020-02-11 13:09:59 UTC (rev 256302)
@@ -300,6 +300,7 @@
 g_signal_connect(webContext, "automation-started", G_CALLBACK(automationStartedCallback), webView);
 g_signal_connect(webView, "permission-request", G_CALLBACK(decidePermissionRequest), nullptr);
 g_signal_connect(webView, "create", G_CALLBACK(createWebView), nullptr);
+g_signal_connect(webView, "close", G_CALLBACK(webViewClose), nullptr);
 
 if (ignoreTLSErrors)
 webkit_web_context_set_tls_errors_policy(webContext, WEBKIT_TLS_ERRORS_POLICY_IGNORE);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256303] trunk/Source/WebKit

2020-02-11 Thread youenn

Title: [256303] trunk/Source/WebKit








Revision 256303
Author you...@apple.com
Date 2020-02-11 06:08:30 -0800 (Tue, 11 Feb 2020)


Log Message
Use ObjectIdentifier for WebSocketStream/WebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=207507

Reviewed by Alex Christensen.

Replace uint64_t by ObjectIdentifier.
This adds type safety and ensures we get valid identifiers from IPC.
We still need to check for destinationID being not null in a few places.
No observable change of behavior.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::createSocketStream):
(WebKit::NetworkConnectionToWebProcess::createSocketChannel):
(WebKit::NetworkConnectionToWebProcess::removeSocketChannel):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkSocketChannel.cpp:
(WebKit::NetworkSocketChannel::create):
(WebKit::NetworkSocketChannel::NetworkSocketChannel):
* NetworkProcess/NetworkSocketChannel.h:
* NetworkProcess/NetworkSocketStream.cpp:
(WebKit::NetworkSocketStream::create):
(WebKit::NetworkSocketStream::NetworkSocketStream):
(WebKit::NetworkSocketStream::messageSenderDestinationID const):
* NetworkProcess/NetworkSocketStream.h:
* Scripts/webkit/messages.py:
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage):
* WebProcess/Network/WebSocketChannel.cpp:
(WebKit::WebSocketChannel::WebSocketChannel):
(WebKit::WebSocketChannel::messageSenderDestinationID const):
(WebKit::WebSocketChannel::connect):
* WebProcess/Network/WebSocketChannel.h:
(WebKit::WebSocketChannel::identifier const):
* WebProcess/Network/WebSocketChannelManager.cpp:
(WebKit::WebSocketChannelManager::didReceiveMessage):
* WebProcess/Network/WebSocketChannelManager.h:
* WebProcess/Network/WebSocketIdentifier.h: Added.
* WebProcess/Network/WebSocketStream.cpp:
(WebKit::WebSocketStream::streamWithIdentifier):
(WebKit::WebSocketStream::WebSocketStream):
(WebKit::WebSocketStream::~WebSocketStream):
(WebKit::WebSocketStream::messageSenderDestinationID const):
* WebProcess/Network/WebSocketStream.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
trunk/Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSocketChannel.h
trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.cpp
trunk/Source/WebKit/NetworkProcess/NetworkSocketStream.h
trunk/Source/WebKit/Scripts/webkit/messages.py
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
trunk/Source/WebKit/WebProcess/Network/WebSocketChannel.cpp
trunk/Source/WebKit/WebProcess/Network/WebSocketChannel.h
trunk/Source/WebKit/WebProcess/Network/WebSocketChannelManager.cpp
trunk/Source/WebKit/WebProcess/Network/WebSocketChannelManager.h
trunk/Source/WebKit/WebProcess/Network/WebSocketStream.cpp
trunk/Source/WebKit/WebProcess/Network/WebSocketStream.h


Added Paths

trunk/Source/WebKit/WebProcess/Network/WebSocketIdentifier.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (256302 => 256303)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 13:09:59 UTC (rev 256302)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 14:08:30 UTC (rev 256303)
@@ -1,3 +1,52 @@
+2020-02-11  Youenn Fablet  
+
+Use ObjectIdentifier for WebSocketStream/WebSocketChannel
+https://bugs.webkit.org/show_bug.cgi?id=207507
+
+Reviewed by Alex Christensen.
+
+Replace uint64_t by ObjectIdentifier.
+This adds type safety and ensures we get valid identifiers from IPC.
+We still need to check for destinationID being not null in a few places.
+No observable change of behavior.
+
+* NetworkProcess/NetworkConnectionToWebProcess.cpp:
+(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
+(WebKit::NetworkConnectionToWebProcess::createSocketStream):
+(WebKit::NetworkConnectionToWebProcess::createSocketChannel):
+(WebKit::NetworkConnectionToWebProcess::removeSocketChannel):
+* NetworkProcess/NetworkConnectionToWebProcess.h:
+* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
+* NetworkProcess/NetworkSocketChannel.cpp:
+(WebKit::NetworkSocketChannel::create):
+(WebKit::NetworkSocketChannel::NetworkSocketChannel):
+* NetworkProcess/NetworkSocketChannel.h:
+* NetworkProcess/NetworkSocketStream.cpp:
+(WebKit::NetworkSocketStream::create):
+(WebKit::NetworkSocketStream::NetworkSocketStream):
+(WebKit::NetworkSocketStream::messageSenderDestinationID const):
+* NetworkProcess/NetworkSocketStream

[webkit-changes] [256304] trunk/Source/WebCore

2020-02-11 Thread zalan

Title: [256304] trunk/Source/WebCore








Revision 256304
Author za...@apple.com
Date 2020-02-11 07:13:15 -0800 (Tue, 11 Feb 2020)


Log Message
[LFC] Introduce Layout::InlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=207530


Reviewed by Antti Koivisto.

Any text that is directly contained inside a block container element (not inside an inline element) must be treated as an anonymous inline element.

* Sources.txt:
* layout/Verification.cpp:
(WebCore::Layout::checkForMatchingTextRuns):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):
* layout/inlineformatting/InlineLineBreaker.cpp:
(WebCore::Layout::LineBreaker::tryBreakingTextRun const):
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::m_textContext):
* layout/inlineformatting/InlineSoftLineBreakItem.h:
(WebCore::Layout::InlineSoftLineBreakItem::createSoftLineBreakItem):
(WebCore::Layout::InlineSoftLineBreakItem::InlineSoftLineBreakItem):
* layout/inlineformatting/InlineTextItem.cpp:
(WebCore::Layout::InlineTextItem::createAndAppendTextItems):
(WebCore::Layout::InlineTextItem::isEmptyContent const):
* layout/inlineformatting/InlineTextItem.h:
(WebCore::Layout::InlineTextItem::inlineTextBox const):
(WebCore::Layout::InlineTextItem::createWhitespaceItem):
(WebCore::Layout::InlineTextItem::createNonWhitespaceItem):
(WebCore::Layout::InlineTextItem::createEmptyItem):
(WebCore::Layout::InlineTextItem::InlineTextItem):
(WebCore::Layout::InlineTextItem::left const):
(WebCore::Layout::InlineTextItem::right const):
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::endsWithSoftWrapOpportunity):
* layout/inlineformatting/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::width):
(WebCore::Layout::TextUtil::split):
* layout/inlineformatting/text/TextUtil.h:
* layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTree):
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::Box):
(): Deleted.
* layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isInlineTextBox const):
(WebCore::Layout::Box::hasTextContent const): Deleted.
(WebCore::Layout::Box::textContext const): Deleted.
* layout/layouttree/LayoutContainer.cpp:
(WebCore::Layout::Container::Container):
(): Deleted.
* layout/layouttree/LayoutInlineTextBox.cpp: Copied from Source/WebCore/layout/layouttree/TextContext.h.
(WebCore::Layout::InlineTextBox::InlineTextBox):
(WebCore::Layout::m_canUseSimplifiedContentMeasuring):
* layout/layouttree/LayoutInlineTextBox.h: Renamed from Source/WebCore/layout/layouttree/TextContext.h.
(WebCore::Layout::InlineTextBox::content const):
(WebCore::Layout::InlineTextBox::canUseSimplifiedContentMeasuring const):
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createTextBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::outputLayoutBox):
* layout/layouttree/LayoutTreeBuilder.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/layout/Verification.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBreaker.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineSoftLineBreakItem.h
trunk/Source/WebCore/layout/inlineformatting/InlineTextItem.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineTextItem.h
trunk/Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp
trunk/Source/WebCore/layout/inlineformatting/text/TextUtil.cpp
trunk/Source/WebCore/layout/inlineformatting/text/TextUtil.h
trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp
trunk/Source/WebCore/layout/layouttree/LayoutBox.h
trunk/Source/WebCore/layout/layouttree/LayoutContainer.cpp
trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.h


Added Paths

trunk/Source/WebCore/layout/layouttree/LayoutInlineTextBox.cpp
trunk/Source/WebCore/layout/layouttree/LayoutInlineTextBox.h


Removed Paths

trunk/Source/WebCore/layout/layouttree/TextContext.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256303 => 256304)

--- trunk/Source/WebCore/ChangeLog	2020-02-11 14:08:30 UTC (rev 256303)
+++ trunk/Source/WebCore/ChangeLog	2020-02-11 15:13:15 UTC (rev 256304)
@@ -1,3 +1,66 @@
+2020-02-11  Zalan Bujtas  
+
+[LFC] Introduce Layout::InlineTextBox
+https://bugs.webkit.org/show_bug.cgi?id=207530
+
+
+Reviewed by Antti Koivisto.
+
+Any text that is directly contained inside a block container element (not inside an inline element) must be treated as an anonymous inline element.
+
+* Sources.txt:
+* layout/Verification.cpp:
+(WebCore::Layout::checkFo

[webkit-changes] [256305] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256305] trunk/LayoutTests








Revision 256305
Author jacob_uph...@apple.com
Date 2020-02-11 07:58:20 -0800 (Tue, 11 Feb 2020)


Log Message
REGRESSION (r253312): imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html is super flaky
https://bugs.webkit.org/show_bug.cgi?id=205216

Updated test expectations to include ios.

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256304 => 256305)

--- trunk/LayoutTests/ChangeLog	2020-02-11 15:13:15 UTC (rev 256304)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 15:58:20 UTC (rev 256305)
@@ -1,3 +1,14 @@
+2020-02-11  Jacob Uphoff  
+
+REGRESSION (r253312): imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html is super flaky
+https://bugs.webkit.org/show_bug.cgi?id=205216
+
+Updated test expectations to include ios.
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+
 2020-02-11  Said Abou-Hallawa  
 
 REGRESSION: [ Mac ] legacy-animation-engine/fast/animation/request-animation-frame-iframe2.html is a flaky failure


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256304 => 256305)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 15:13:15 UTC (rev 256304)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 15:58:20 UTC (rev 256305)
@@ -1384,4 +1384,6 @@
 
 webkit.org/b/207465 [ Debug ] storage/indexeddb/intversion-long-queue.html [ Pass Failure ]
 
-webkit.org/b/207466 [ Debug ] http/wpt/service-workers/service-worker-networkprocess-crash.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207466 [ Debug ] http/wpt/service-workers/service-worker-networkprocess-crash.html [ Pass Failure ]
+
+webkit.org/b/205216 imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html [ PAss Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256306] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256306] trunk/LayoutTests








Revision 256306
Author jacob_uph...@apple.com
Date 2020-02-11 08:15:08 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS ] http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207551

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256305 => 256306)

--- trunk/LayoutTests/ChangeLog	2020-02-11 15:58:20 UTC (rev 256305)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 16:15:08 UTC (rev 256306)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ iOS ] http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html is flaky timing out
+https://bugs.webkit.org/show_bug.cgi?id=207551
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 REGRESSION (r253312): imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html is super flaky
 https://bugs.webkit.org/show_bug.cgi?id=205216
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256305 => 256306)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 15:58:20 UTC (rev 256305)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 16:15:08 UTC (rev 256306)
@@ -1386,4 +1386,6 @@
 
 webkit.org/b/207466 [ Debug ] http/wpt/service-workers/service-worker-networkprocess-crash.html [ Pass Failure ]
 
-webkit.org/b/205216 imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html [ PAss Failure ]
\ No newline at end of file
+webkit.org/b/205216 imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html [ PAss Failure ]
+
+webkit.org/b/207551 http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256307] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256307] trunk/LayoutTests








Revision 256307
Author jacob_uph...@apple.com
Date 2020-02-11 08:36:57 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS ] http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207552

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256306 => 256307)

--- trunk/LayoutTests/ChangeLog	2020-02-11 16:15:08 UTC (rev 256306)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 16:36:57 UTC (rev 256307)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ iOS ] http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html is flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=207552
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 [ iOS ] http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html is flaky timing out
 https://bugs.webkit.org/show_bug.cgi?id=207551
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256306 => 256307)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 16:15:08 UTC (rev 256306)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 16:36:57 UTC (rev 256307)
@@ -1388,4 +1388,6 @@
 
 webkit.org/b/205216 imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html [ PAss Failure ]
 
-webkit.org/b/207551 http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/207551 http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html [ Pass Timeout ]
+
+webkit.org/b/207552 http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256308] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256308] trunk/LayoutTests








Revision 256308
Author jacob_uph...@apple.com
Date 2020-02-11 08:42:43 -0800 (Tue, 11 Feb 2020)


Log Message
Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=190852

Updating expectations to include ios

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256307 => 256308)

--- trunk/LayoutTests/ChangeLog	2020-02-11 16:36:57 UTC (rev 256307)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 16:42:43 UTC (rev 256308)
@@ -1,5 +1,16 @@
 2020-02-11  Jacob Uphoff  
 
+Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=190852
+
+Updating expectations to include ios 
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 [ iOS ] http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html is flaky timeout
 https://bugs.webkit.org/show_bug.cgi?id=207552
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256307 => 256308)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 16:36:57 UTC (rev 256307)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 16:42:43 UTC (rev 256308)
@@ -1390,4 +1390,6 @@
 
 webkit.org/b/207551 http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html [ Pass Timeout ]
 
-webkit.org/b/207552 http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/207552 http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html [ Pass Timeout ]
+
+webkit.org/b/190852 imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256309] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256309] trunk/LayoutTests








Revision 256309
Author jacob_uph...@apple.com
Date 2020-02-11 08:50:46 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS ] imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207553

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256308 => 256309)

--- trunk/LayoutTests/ChangeLog	2020-02-11 16:42:43 UTC (rev 256308)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 16:50:46 UTC (rev 256309)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ iOS ] imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=207553
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=190852
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256308 => 256309)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 16:42:43 UTC (rev 256308)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 16:50:46 UTC (rev 256309)
@@ -1392,4 +1392,6 @@
 
 webkit.org/b/207552 http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html [ Pass Timeout ]
 
-webkit.org/b/190852 imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/190852 imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Pass Failure ]
+
+webkit.org/b/207553 imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256310] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256310] trunk/LayoutTests








Revision 256310
Author jacob_uph...@apple.com
Date 2020-02-11 09:11:02 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS ] imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207555

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256309 => 256310)

--- trunk/LayoutTests/ChangeLog	2020-02-11 16:50:46 UTC (rev 256309)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 17:11:02 UTC (rev 256310)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ iOS ] imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=207555
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 [ iOS ] imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html is a flaky timeout
 https://bugs.webkit.org/show_bug.cgi?id=207553
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256309 => 256310)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 16:50:46 UTC (rev 256309)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 17:11:02 UTC (rev 256310)
@@ -1394,4 +1394,6 @@
 
 webkit.org/b/190852 imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Pass Failure ]
 
-webkit.org/b/207553 imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/207553 imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html [ Pass Timeout ]
+
+webkit.org/b/207555 imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html [ Pass Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256311] trunk/Source/WebCore

2020-02-11 Thread zalan

Title: [256311] trunk/Source/WebCore








Revision 256311
Author za...@apple.com
Date 2020-02-11 09:12:44 -0800 (Tue, 11 Feb 2020)


Log Message
[LFC] Introduce Layout::LineBreakBox
https://bugs.webkit.org/show_bug.cgi?id=207550


Reviewed by Antti Koivisto.

This is in preparation for making Layout::Box an abstract box (so that it stops being a leaf type of box).

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):
* layout/integration/LayoutIntegrationBoxTree.cpp:
(WebCore::LayoutIntegration::BoxTree::buildTree):
* layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isImage const):
(WebCore::Layout::Box::isLineBreakBox const):
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLineBreakBox):
(WebCore::Layout::TreeBuilder::createLayoutBox):
* layout/layouttree/LayoutTreeBuilder.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp
trunk/Source/WebCore/layout/layouttree/LayoutBox.h
trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
trunk/Source/WebCore/layout/layouttree/LayoutTreeBuilder.h


Added Paths

trunk/Source/WebCore/layout/layouttree/LayoutLineBreakBox.cpp
trunk/Source/WebCore/layout/layouttree/LayoutLineBreakBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256310 => 256311)

--- trunk/Source/WebCore/ChangeLog	2020-02-11 17:11:02 UTC (rev 256310)
+++ trunk/Source/WebCore/ChangeLog	2020-02-11 17:12:44 UTC (rev 256311)
@@ -1,5 +1,29 @@
 2020-02-11  Zalan Bujtas  
 
+[LFC] Introduce Layout::LineBreakBox
+https://bugs.webkit.org/show_bug.cgi?id=207550
+
+
+Reviewed by Antti Koivisto.
+
+This is in preparation for making Layout::Box an abstract box (so that it stops being a leaf type of box).
+
+* Sources.txt:
+* WebCore.xcodeproj/project.pbxproj:
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::collectInlineContentIfNeeded):
+* layout/integration/LayoutIntegrationBoxTree.cpp:
+(WebCore::LayoutIntegration::BoxTree::buildTree):
+* layout/layouttree/LayoutBox.h:
+(WebCore::Layout::Box::isImage const):
+(WebCore::Layout::Box::isLineBreakBox const):
+* layout/layouttree/LayoutTreeBuilder.cpp:
+(WebCore::Layout::TreeBuilder::createLineBreakBox):
+(WebCore::Layout::TreeBuilder::createLayoutBox):
+* layout/layouttree/LayoutTreeBuilder.h:
+
+2020-02-11  Zalan Bujtas  
+
 [LFC] Introduce Layout::InlineTextBox
 https://bugs.webkit.org/show_bug.cgi?id=207530
 


Modified: trunk/Source/WebCore/Sources.txt (256310 => 256311)

--- trunk/Source/WebCore/Sources.txt	2020-02-11 17:11:02 UTC (rev 256310)
+++ trunk/Source/WebCore/Sources.txt	2020-02-11 17:12:44 UTC (rev 256311)
@@ -1452,6 +1452,7 @@
 layout/layouttree/LayoutBox.cpp
 layout/layouttree/LayoutContainer.cpp
 layout/layouttree/LayoutInlineTextBox.cpp
+layout/layouttree/LayoutLineBreakBox.cpp
 layout/layouttree/LayoutReplaced.cpp
 layout/layouttree/LayoutTreeBuilder.cpp
 layout/tableformatting/TableFormattingContext.cpp


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (256310 => 256311)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2020-02-11 17:11:02 UTC (rev 256310)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2020-02-11 17:12:44 UTC (rev 256311)
@@ -2080,6 +2080,7 @@
 		6FD9CD54227E21C800E53957 /* DisplayRect.h in Headers */ = {isa = PBXBuildFile; fileRef = 6FD9CD52227E21C800E53957 /* DisplayRect.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		6FE198172178397C00446F08 /* InlineLineBreaker.h in Headers */ = {isa = PBXBuildFile; fileRef = 6FE198152178397C00446F08 /* InlineLineBreaker.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		6FE7CFA22177EEF2005B1573 /* InlineItem.h in Headers */ = {isa = PBXBuildFile; fileRef = 6FE7CFA02177EEF1005B1573 /* InlineItem.h */; };
+		6FFA4C0123F2FED9007E4EBC /* LayoutLineBreakBox.h in Headers */ = {isa = PBXBuildFile; fileRef = 6FFA4C0023F2FED9007E4EBC /* LayoutLineBreakBox.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		6FFDC442212EFF1700A9CA91 /* FloatAvoider.h in Headers */ = {isa = PBXBuildFile; fileRef = 6FFDC440212EFF1600A9CA91 /* FloatAvoider.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		709A01FE1E3D0BDD006B0D4C /* ModuleFetchFailureKind.h in Headers */ = {isa = PBXBuildFile; fileRef = 709A01FD1E3D0BCC006B0D4C /* ModuleFetchFailureKind.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		71025ECD1F99F0CE004A250C /* AnimationTimeline.h in Headers */ = {isa = PBXBuildFile; fileRef = 71025EC71F99F096004A250C /* AnimationTimeline.h */; setti

[webkit-changes] [256312] trunk/Source/WebKit

2020-02-11 Thread achristensen

Title: [256312] trunk/Source/WebKit








Revision 256312
Author achristen...@apple.com
Date 2020-02-11 09:48:15 -0800 (Tue, 11 Feb 2020)


Log Message
Add WKContentWorld.h to WebKit.h
https://bugs.webkit.org/show_bug.cgi?id=207351

Suggested by Alex Christensen.

Patch by Brady Eidson  on 2020-02-11

* Shared/API/Cocoa/WebKit.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/API/Cocoa/WebKit.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (256311 => 256312)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 17:12:44 UTC (rev 256311)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 17:48:15 UTC (rev 256312)
@@ -1,3 +1,12 @@
+2020-02-11  Brady Eidson  
+
+Add WKContentWorld.h to WebKit.h
+https://bugs.webkit.org/show_bug.cgi?id=207351
+
+Suggested by Alex Christensen.
+
+* Shared/API/Cocoa/WebKit.h:
+
 2020-02-11  Youenn Fablet  
 
 Use ObjectIdentifier for WebSocketStream/WebSocketChannel


Modified: trunk/Source/WebKit/Shared/API/Cocoa/WebKit.h (256311 => 256312)

--- trunk/Source/WebKit/Shared/API/Cocoa/WebKit.h	2020-02-11 17:12:44 UTC (rev 256311)
+++ trunk/Source/WebKit/Shared/API/Cocoa/WebKit.h	2020-02-11 17:48:15 UTC (rev 256312)
@@ -28,6 +28,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256313] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256313] trunk/LayoutTests








Revision 256313
Author jacob_uph...@apple.com
Date 2020-02-11 09:51:00 -0800 (Tue, 11 Feb 2020)


Log Message
[ macOS iOS ] fast/parser/parser-yield-timing.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207559

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:
* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256312 => 256313)

--- trunk/LayoutTests/ChangeLog	2020-02-11 17:48:15 UTC (rev 256312)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 17:51:00 UTC (rev 256313)
@@ -1,5 +1,15 @@
 2020-02-11  Jacob Uphoff  
 
+[ macOS iOS ] fast/parser/parser-yield-timing.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=207559
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+* platform/mac-wk1/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 [ iOS ] imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html is a flaky timeout
 https://bugs.webkit.org/show_bug.cgi?id=207555
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256312 => 256313)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 17:48:15 UTC (rev 256312)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 17:51:00 UTC (rev 256313)
@@ -1396,4 +1396,6 @@
 
 webkit.org/b/207553 imported/w3c/IndexedDB-private-browsing/abort-in-initial-upgradeneeded.html [ Pass Timeout ]
 
-webkit.org/b/207555 imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html [ Pass Timeout ]
\ No newline at end of file
+webkit.org/b/207555 imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html [ Pass Timeout ]
+
+webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256312 => 256313)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 17:48:15 UTC (rev 256312)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 17:51:00 UTC (rev 256313)
@@ -908,4 +908,6 @@
 
 webkit.org/b/207469 [ Debug ] imported/w3c/web-platform-tests/svg/animations/slider-switch.html [ Pass Failure ]
 
-webkit.org/b/207470 [ Debug ] imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207470 [ Debug ] imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm [ Pass Failure ]
+
+webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256314] trunk

2020-02-11 Thread youenn

Title: [256314] trunk








Revision 256314
Author you...@apple.com
Date 2020-02-11 09:57:16 -0800 (Tue, 11 Feb 2020)


Log Message
WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
https://bugs.webkit.org/show_bug.cgi?id=207537

Reviewed by Chris Dumez.

Source/WebKit:

Covered by added API test.

* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256313 => 256314)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 17:51:00 UTC (rev 256313)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 17:57:16 UTC (rev 256314)
@@ -1,3 +1,16 @@
+2020-02-11  Youenn Fablet  
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+Covered by added API test.
+
+* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+(WebKit::WebSWServerConnection::registerServiceWorkerClient):
+Fix use after move so that we can get the context connection and send the IPC message to UIProcess as expected.
+
 2020-02-11  Brady Eidson  
 
 Add WKContentWorld.h to WebKit.h


Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256313 => 256314)

--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp	2020-02-11 17:51:00 UTC (rev 256313)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp	2020-02-11 17:57:16 UTC (rev 256314)
@@ -313,6 +313,7 @@
 bool isNewOrigin = WTF::allOf(m_clientOrigins.values(), [&contextOrigin](auto& origin) {
 return contextOrigin != origin.clientOrigin;
 });
+auto* contextConnection = isNewOrigin ? server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin }) : nullptr;
 
 auto clientOrigin = ClientOrigin { WTFMove(topOrigin), WTFMove(contextOrigin) };
 m_clientOrigins.add(data.identifier, clientOrigin);
@@ -321,11 +322,9 @@
 if (!m_isThrottleable)
 updateThrottleState();
 
-if (isNewOrigin) {
-if (auto* contextConnection = server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin })) {
-auto& connection = static_cast(*contextConnection);
-m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
-}
+if (contextConnection) {
+auto& connection = static_cast(*contextConnection);
+m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
 }
 }
 


Modified: trunk/Tools/ChangeLog (256313 => 256314)

--- trunk/Tools/ChangeLog	2020-02-11 17:51:00 UTC (rev 256313)
+++ trunk/Tools/ChangeLog	2020-02-11 17:57:16 UTC (rev 256314)
@@ -1,3 +1,12 @@
+2020-02-11  Youenn Fablet  
+
+WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
+https://bugs.webkit.org/show_bug.cgi?id=207537
+
+Reviewed by Chris Dumez.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
 2020-02-11  Lauro Moura  
 
 [WPE][WebDriver] MiniBrowser should react to close session commands


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm (256313 => 256314)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm	2020-02-11 17:51:00 UTC (rev 256313)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm	2020-02-11 17:57:16 UTC (rev 256314)
@@ -1676,6 +1676,22 @@
 [webView _setAssertionStateForTesting: 0];
 waitUntilServiceWorkerProcessBackgroundActivityState(webView.get(), false);
 waitUntilServiceWorkerProcessForegroundActivityState(webView.get(), false);
+
+[webView _setAssertionStateForTesting: 1];
+waitUntilServiceWorkerProcessForegroundActivityState(webView.get(), false);
+waitUntilServiceWorkerProcessBackgroundActivityState(webView.get(), true);
+
+auto webView2 = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
+
+[webView2 loadRequest:server.request()];
+[webView2 _setAssertionStateForTesting: 3];
+
+[webView _close];
+webView = nullptr;
+
+// The first webView is closed so the service worker process sho

[webkit-changes] [256315] trunk

2020-02-11 Thread commit-queue

Title: [256315] trunk








Revision 256315
Author commit-qu...@webkit.org
Date 2020-02-11 10:14:10 -0800 (Tue, 11 Feb 2020)


Log Message
Add WKHTTPCookieStore._getCookiesForURL SPI
https://bugs.webkit.org/show_bug.cgi?id=207527

Patch by Alex Christensen  on 2020-02-11
Reviewed by Brady Eidson.

Source/WebKit:

This is needed to implement rdar://problem/57193106 without re-implementing the cookie/URL matching logic that exists in CFNetwork.
Covered by an API test with a great pun in it.

* UIProcess/API/APIHTTPCookieStore.cpp:
(API::HTTPCookieStore::cookiesForURL):
* UIProcess/API/APIHTTPCookieStore.h:
* UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
(-[WKHTTPCookieStore _getCookiesForURL:completionHandler:]):
* UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h: Added.
* WebKit.xcodeproj/project.pbxproj:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(TEST):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp
trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm


Added Paths

trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (256314 => 256315)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 17:57:16 UTC (rev 256314)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 18:14:10 UTC (rev 256315)
@@ -1,3 +1,21 @@
+2020-02-11  Alex Christensen  
+
+Add WKHTTPCookieStore._getCookiesForURL SPI
+https://bugs.webkit.org/show_bug.cgi?id=207527
+
+Reviewed by Brady Eidson.
+
+This is needed to implement rdar://problem/57193106 without re-implementing the cookie/URL matching logic that exists in CFNetwork.
+Covered by an API test with a great pun in it.
+
+* UIProcess/API/APIHTTPCookieStore.cpp:
+(API::HTTPCookieStore::cookiesForURL):
+* UIProcess/API/APIHTTPCookieStore.h:
+* UIProcess/API/Cocoa/WKHTTPCookieStore.mm:
+(-[WKHTTPCookieStore _getCookiesForURL:completionHandler:]):
+* UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h: Added.
+* WebKit.xcodeproj/project.pbxproj:
+
 2020-02-11  Youenn Fablet  
 
 WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should


Modified: trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp (256314 => 256315)

--- trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp	2020-02-11 17:57:16 UTC (rev 256314)
+++ trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp	2020-02-11 18:14:10 UTC (rev 256315)
@@ -75,6 +75,18 @@
 });
 }
 
+void HTTPCookieStore::cookiesForURL(WTF::URL&& url, CompletionHandler&&)>&& completionHandler)
+{
+auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();
+if (!pool)
+return completionHandler({ });
+
+auto* cookieManager = pool->supplement();
+cookieManager->getCookies(m_owningDataStore->sessionID(), url, [completionHandler = WTFMove(completionHandler)] (Vector&& cookies) mutable {
+completionHandler(WTFMove(cookies));
+});
+}
+
 void HTTPCookieStore::setCookies(const Vector& cookies, CompletionHandler&& completionHandler)
 {
 auto* pool = m_owningDataStore->processPoolForCookieStorageOperations();


Modified: trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h (256314 => 256315)

--- trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h	2020-02-11 17:57:16 UTC (rev 256314)
+++ trunk/Source/WebKit/UIProcess/API/APIHTTPCookieStore.h	2020-02-11 18:14:10 UTC (rev 256315)
@@ -58,6 +58,7 @@
 virtual ~HTTPCookieStore();
 
 void cookies(CompletionHandler&)>&&);
+void cookiesForURL(WTF::URL&&, CompletionHandler&&)>&&);
 void setCookies(const Vector&, CompletionHandler&&);
 void deleteCookie(const WebCore::Cookie&, CompletionHandler&&);
 


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm (256314 => 256315)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm	2020-02-11 17:57:16 UTC (rev 256314)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStore.mm	2020-02-11 18:14:10 UTC (rev 256315)
@@ -29,6 +29,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -129,3 +130,14 @@
 }
 
 @end
+
+@implementation WKHTTPCookieStore (WKPrivate)
+
+- (void)_getCookiesForURL:(NSURL *)url completionHandler:(void (^)(NSArray *))completionHandler
+{
+_cookieStore->cookiesForURL(url, [handler = makeBlockPtr(completionHandler)] (const Vector& cookies) {
+handler.get()(coreCookiesToNSCookies(cookies));
+});
+}
+
+@end


Added: trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h (0 => 256315)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKHTTPCookieStorePrivate.h	(rev 0)
+++ trunk/Source/WebKit/UIProcess/AP

[webkit-changes] [256316] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256316] trunk/LayoutTests








Revision 256316
Author jacob_uph...@apple.com
Date 2020-02-11 10:18:37 -0800 (Tue, 11 Feb 2020)


Log Message
[ macOS wk1 ] media/airplay-target-availability.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207560

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256315 => 256316)

--- trunk/LayoutTests/ChangeLog	2020-02-11 18:14:10 UTC (rev 256315)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 18:18:37 UTC (rev 256316)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ macOS wk1 ] media/airplay-target-availability.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=207560
+
+Unreviewed test gardening
+
+* platform/mac-wk1/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 [ macOS iOS ] fast/parser/parser-yield-timing.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=207559
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256315 => 256316)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 18:14:10 UTC (rev 256315)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 18:18:37 UTC (rev 256316)
@@ -910,4 +910,6 @@
 
 webkit.org/b/207470 [ Debug ] imported/w3c/web-platform-tests/workers/WorkerGlobalScope_ErrorEvent_colno.htm [ Pass Failure ]
 
-webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
+
+webkit.org/207560 media/airplay-target-availability.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256317] trunk

2020-02-11 Thread youenn

Title: [256317] trunk








Revision 256317
Author you...@apple.com
Date 2020-02-11 10:26:51 -0800 (Tue, 11 Feb 2020)


Log Message
REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration
https://bugs.webkit.org/show_bug.cgi?id=207521


Reviewed by Eric Carlson.

Source/WebKit:

Covered by debug assertion not hit in layout tests.

* WebProcess/Network/webrtc/WebMDNSRegister.cpp:
(WebKit::WebMDNSRegister::finishedRegisteringMDNSName):
Call completion handler even if the document entry has been cleared, which can happen in suspend/destruction case.
If the entry is not there, all MDNS names for the document have been unregistered. We then report a registration error.

LayoutTests:

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (256316 => 256317)

--- trunk/LayoutTests/ChangeLog	2020-02-11 18:18:37 UTC (rev 256316)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 18:26:51 UTC (rev 256317)
@@ -1,3 +1,13 @@
+2020-02-11  Youenn Fablet  
+
+REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration
+https://bugs.webkit.org/show_bug.cgi?id=207521
+
+
+Reviewed by Eric Carlson.
+
+* platform/mac-wk2/TestExpectations:
+
 2020-02-11  Jacob Uphoff  
 
 [ macOS wk1 ] media/airplay-target-availability.html is flaky failing


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256316 => 256317)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 18:18:37 UTC (rev 256316)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 18:26:51 UTC (rev 256317)
@@ -1014,5 +1014,3 @@
 webkit.org/b/207515 http/wpt/service-workers/service-worker-spinning-fetch.https.html [ Pass Failure ]
 
 webkit.org/b/207518 tiled-drawing/simple-document-with-margin-tiles.html [ Pass Failure ]
-
-webkit.org/b/207521 [ Mojave Debug ] webrtc/peerconnection-page-cache-long.html [ Pass Crash ]
\ No newline at end of file


Modified: trunk/Source/WebKit/ChangeLog (256316 => 256317)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 18:18:37 UTC (rev 256316)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 18:26:51 UTC (rev 256317)
@@ -1,3 +1,18 @@
+2020-02-11  Youenn Fablet  
+
+REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration
+https://bugs.webkit.org/show_bug.cgi?id=207521
+
+
+Reviewed by Eric Carlson.
+
+Covered by debug assertion not hit in layout tests.
+
+* WebProcess/Network/webrtc/WebMDNSRegister.cpp:
+(WebKit::WebMDNSRegister::finishedRegisteringMDNSName):
+Call completion handler even if the document entry has been cleared, which can happen in suspend/destruction case.
+If the entry is not there, all MDNS names for the document have been unregistered. We then report a registration error.
+
 2020-02-11  Alex Christensen  
 
 Add WKHTTPCookieStore._getCookiesForURL SPI


Modified: trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp (256316 => 256317)

--- trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp	2020-02-11 18:18:37 UTC (rev 256316)
+++ trunk/Source/WebKit/WebProcess/Network/webrtc/WebMDNSRegister.cpp	2020-02-11 18:26:51 UTC (rev 256317)
@@ -44,8 +44,10 @@
 
 if (result.has_value()) {
 auto iterator = m_registeringDocuments.find(pendingRegistration.documentIdentifier);
-if (iterator == m_registeringDocuments.end())
+if (iterator == m_registeringDocuments.end()) {
+pendingRegistration.callback(makeUnexpected(WebCore::MDNSRegisterError::DNSSD));
 return;
+}
 iterator->value.add(pendingRegistration.ipAddress, result.value());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256318] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256318] trunk/LayoutTests








Revision 256318
Author jacob_uph...@apple.com
Date 2020-02-11 10:38:20 -0800 (Tue, 11 Feb 2020)


Log Message
BOTWATCH: editing/selection/5354455-1.html causes nasty crash
rdar://problem/13448458

Unreviewed test gardening

* platform/mac-wk2/TestExpectations: unskip test because it no longer crashes locally

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256317 => 256318)

--- trunk/LayoutTests/ChangeLog	2020-02-11 18:26:51 UTC (rev 256317)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 18:38:20 UTC (rev 256318)
@@ -1,3 +1,12 @@
+2020-02-11  Jacob Uphoff  
+
+BOTWATCH: editing/selection/5354455-1.html causes nasty crash
+rdar://problem/13448458
+
+Unreviewed test gardening
+
+* platform/mac-wk2/TestExpectations: unskip test because it no longer crashes locally
+
 2020-02-11  Youenn Fablet  
 
 REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256317 => 256318)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 18:26:51 UTC (rev 256317)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 18:38:20 UTC (rev 256318)
@@ -119,7 +119,6 @@
 editing/pasteboard/subframe-dragndrop-1.html
 editing/selection/4895428-1.html
 editing/selection/4895428-4.html
-editing/selection/5354455-1.html
 editing/selection/5354455-2.html
 editing/selection/caret-after-keypress.html
 editing/selection/contains-boundaries.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256319] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256319] trunk/LayoutTests








Revision 256319
Author jacob_uph...@apple.com
Date 2020-02-11 10:49:14 -0800 (Tue, 11 Feb 2020)


Log Message
[ macOS iOS ] animations/animation-callback-timestamp.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207153

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256318 => 256319)

--- trunk/LayoutTests/ChangeLog	2020-02-11 18:38:20 UTC (rev 256318)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 18:49:14 UTC (rev 256319)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ macOS iOS ] animations/animation-callback-timestamp.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=207153
+
+Unreviewed test gardening
+
+* platform/mac-wk1/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 BOTWATCH: editing/selection/5354455-1.html causes nasty crash
 rdar://problem/13448458
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256318 => 256319)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 18:38:20 UTC (rev 256318)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 18:49:14 UTC (rev 256319)
@@ -912,4 +912,6 @@
 
 webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
 
-webkit.org/207560 media/airplay-target-availability.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/207560 media/airplay-target-availability.html [ Pass Failure ]
+
+webkit.org/207153 [ Debug ] animations/animation-callback-timestamp.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256320] trunk/Source/WebCore/PAL

2020-02-11 Thread cfleizach

Title: [256320] trunk/Source/WebCore/PAL








Revision 256320
Author cfleiz...@apple.com
Date 2020-02-11 10:58:19 -0800 (Tue, 11 Feb 2020)


Log Message
AX: Wrong includes for internal SDK
https://bugs.webkit.org/show_bug.cgi?id=207554

Reviewed by Chris Dumez.

* pal/spi/mac/HIServicesSPI.h:

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (256319 => 256320)

--- trunk/Source/WebCore/PAL/ChangeLog	2020-02-11 18:49:14 UTC (rev 256319)
+++ trunk/Source/WebCore/PAL/ChangeLog	2020-02-11 18:58:19 UTC (rev 256320)
@@ -1,3 +1,12 @@
+2020-02-11  Chris Fleizach  
+
+AX: Wrong includes for internal SDK
+https://bugs.webkit.org/show_bug.cgi?id=207554
+
+Reviewed by Chris Dumez.
+
+* pal/spi/mac/HIServicesSPI.h:
+
 2020-02-11  chris fleizach  
 
 AX: Unable to build webkit open source - build errors related to AXClientType


Modified: trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h (256319 => 256320)

--- trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h	2020-02-11 18:49:14 UTC (rev 256319)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h	2020-02-11 18:58:19 UTC (rev 256320)
@@ -102,8 +102,6 @@
 kMSHDoNotCreateSendRightOption = 0x4,
 };
 
-#endif
-
 typedef UInt32 MSHCreateOptions;
 typedef const struct __AXTextMarker* AXTextMarkerRef;
 typedef const struct __AXTextMarkerRange* AXTextMarkerRangeRef;
@@ -149,3 +147,5 @@
 #endif // HAVE(AX_CLIENT_TYPE)
 
 WTF_EXTERN_C_END
+
+#endif // USE(APPLE_INTERNAL_SDK)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256321] trunk/LayoutTests

2020-02-11 Thread tsavell

Title: [256321] trunk/LayoutTests








Revision 256321
Author tsav...@apple.com
Date 2020-02-11 11:04:05 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS ] imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207563

Unreviewed test gardening

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256320 => 256321)

--- trunk/LayoutTests/ChangeLog	2020-02-11 18:58:19 UTC (rev 256320)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 19:04:05 UTC (rev 256321)
@@ -1,3 +1,12 @@
+2020-02-11  Truitt Savell  
+
+[ iOS ] imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=207563
+
+Unreviewed test gardening
+
+* platform/ios/TestExpectations:
+
 2020-02-11  Jacob Uphoff  
 
 [ macOS iOS ] animations/animation-callback-timestamp.html is flaky failing.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (256320 => 256321)

--- trunk/LayoutTests/platform/ios/TestExpectations	2020-02-11 18:58:19 UTC (rev 256320)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-02-11 19:04:05 UTC (rev 256321)
@@ -3485,3 +3485,5 @@
 # Locale-specific shaping is only enabled on certain OSes.
 webkit.org/b/77568 fast/text/locale-shaping.html [ ImageOnlyFailure ]
 webkit.org/b/77568 fast/text/locale-shaping-complex.html [ ImageOnlyFailure ]
+
+webkit.org/b/207563 imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256322] branches/Safari-609.1.17.0/

2020-02-11 Thread repstein

Title: [256322] branches/Safari-609.1.17.0/








Revision 256322
Author repst...@apple.com
Date 2020-02-11 11:05:30 -0800 (Tue, 11 Feb 2020)


Log Message
New branch, safari-609.1.17.0-branch

Added Paths

branches/Safari-609.1.17.0/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256323] branches/Safari-609.1.17.1/

2020-02-11 Thread repstein

Title: [256323] branches/Safari-609.1.17.1/








Revision 256323
Author repst...@apple.com
Date 2020-02-11 11:05:51 -0800 (Tue, 11 Feb 2020)


Log Message
New branch, safari-609.1.17.1-branch

Added Paths

branches/Safari-609.1.17.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256324] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256324] trunk/LayoutTests








Revision 256324
Author jacob_uph...@apple.com
Date 2020-02-11 11:06:46 -0800 (Tue, 11 Feb 2020)


Log Message
[ macOS wk1 ] imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207566

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256323 => 256324)

--- trunk/LayoutTests/ChangeLog	2020-02-11 19:05:51 UTC (rev 256323)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 19:06:46 UTC (rev 256324)
@@ -1,3 +1,12 @@
+2020-02-11  Jacob Uphoff  
+
+[ macOS wk1 ] imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=207566
+
+Unreviewed test gardening
+
+* platform/mac-wk1/TestExpectations:
+
 2020-02-11  Truitt Savell  
 
 [ iOS ] imported/w3c/web-platform-tests/content-security-policy/frame-ancestors/frame-ancestors-from-serviceworker.https.html is a flaky failure


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256323 => 256324)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 19:05:51 UTC (rev 256323)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 19:06:46 UTC (rev 256324)
@@ -914,4 +914,6 @@
 
 webkit.org/207560 media/airplay-target-availability.html [ Pass Failure ]
 
-webkit.org/207153 [ Debug ] animations/animation-callback-timestamp.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/207153 [ Debug ] animations/animation-callback-timestamp.html [ Pass Failure ]
+
+webkit.org/b/207566 imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256325] branches/Safari-609.1.17.0/

2020-02-11 Thread repstein

Title: [256325] branches/Safari-609.1.17.0/








Revision 256325
Author repst...@apple.com
Date 2020-02-11 11:11:38 -0800 (Tue, 11 Feb 2020)


Log Message
Delete branch.

Removed Paths

branches/Safari-609.1.17.0/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256326] branches/safari-609.1.17.0-branch/

2020-02-11 Thread repstein

Title: [256326] branches/safari-609.1.17.0-branch/








Revision 256326
Author repst...@apple.com
Date 2020-02-11 11:12:47 -0800 (Tue, 11 Feb 2020)


Log Message
New branch, safari-609.1.17.0-branch

Added Paths

branches/safari-609.1.17.0-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256328] branches/safari-609.1.17.1-branch/

2020-02-11 Thread repstein

Title: [256328] branches/safari-609.1.17.1-branch/








Revision 256328
Author repst...@apple.com
Date 2020-02-11 11:16:26 -0800 (Tue, 11 Feb 2020)


Log Message
New branch, safari-609.1.17.1-branch

Added Paths

branches/safari-609.1.17.1-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256327] branches/Safari-609.1.17.1/

2020-02-11 Thread repstein

Title: [256327] branches/Safari-609.1.17.1/








Revision 256327
Author repst...@apple.com
Date 2020-02-11 11:15:47 -0800 (Tue, 11 Feb 2020)


Log Message
Delete branch.

Removed Paths

branches/Safari-609.1.17.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256329] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256329] trunk/LayoutTests








Revision 256329
Author jacob_uph...@apple.com
Date 2020-02-11 11:16:51 -0800 (Tue, 11 Feb 2020)


Log Message
[ macOS wk1 ] inspector/page/overrideUserAgent.html  is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207568

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256328 => 256329)

--- trunk/LayoutTests/ChangeLog	2020-02-11 19:16:26 UTC (rev 256328)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 19:16:51 UTC (rev 256329)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ macOS wk1 ] inspector/page/overrideUserAgent.html  is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=207568
+
+Unreviewed test gardening
+
+* platform/mac-wk1/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 [ macOS wk1 ] imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html is flaky failing
 https://bugs.webkit.org/show_bug.cgi?id=207566
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256328 => 256329)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 19:16:26 UTC (rev 256328)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 19:16:51 UTC (rev 256329)
@@ -912,8 +912,10 @@
 
 webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
 
-webkit.org/207560 media/airplay-target-availability.html [ Pass Failure ]
+webkit.org/b/207560 media/airplay-target-availability.html [ Pass Failure ]
 
-webkit.org/207153 [ Debug ] animations/animation-callback-timestamp.html [ Pass Failure ]
+webkit.org/b/207153 [ Debug ] animations/animation-callback-timestamp.html [ Pass Failure ]
 
-webkit.org/b/207566 imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207566 imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html [ Pass Failure ]
+
+webkit.org/b/207568 inspector/page/overrideUserAgent.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256330] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256330] trunk/LayoutTests








Revision 256330
Author jacob_uph...@apple.com
Date 2020-02-11 11:25:47 -0800 (Tue, 11 Feb 2020)


Log Message
[ macOS wk1 ] legacy-animation-engine/animations/3d/transform-origin-vs-functions.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207569

Unreviewed test gardening

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256329 => 256330)

--- trunk/LayoutTests/ChangeLog	2020-02-11 19:16:51 UTC (rev 256329)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 19:25:47 UTC (rev 256330)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ macOS wk1 ] legacy-animation-engine/animations/3d/transform-origin-vs-functions.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=207569
+
+Unreviewed test gardening
+
+* platform/mac-wk1/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 [ macOS wk1 ] inspector/page/overrideUserAgent.html  is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=207568
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (256329 => 256330)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 19:16:51 UTC (rev 256329)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-02-11 19:25:47 UTC (rev 256330)
@@ -918,4 +918,6 @@
 
 webkit.org/b/207566 imported/w3c/web-platform-tests/web-animations/timing-model/animations/pausing-an-animation.html [ Pass Failure ]
 
-webkit.org/b/207568 inspector/page/overrideUserAgent.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207568 inspector/page/overrideUserAgent.html [ Pass Failure ]
+
+webkit.org/b/207569 legacy-animation-engine/animations/3d/transform-origin-vs-functions.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256331] branches/safari-609.1.17.0-branch/Source

2020-02-11 Thread repstein

Title: [256331] branches/safari-609.1.17.0-branch/Source








Revision 256331
Author repst...@apple.com
Date 2020-02-11 11:34:33 -0800 (Tue, 11 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609.1.17.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609.1.17.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609.1.17.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256330 => 256331)

--- branches/safari-609.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-11 19:25:47 UTC (rev 256330)
+++ branches/safari-609.1.17.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-11 19:34:33 UTC (rev 256331)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256330 => 256331)

--- branches/safari-609.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-11 19:25:47 UTC (rev 256330)
+++ branches/safari-609.1.17.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-11 19:34:33 UTC (rev 256331)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256330 => 256331)

--- branches/safari-609.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-11 19:25:47 UTC (rev 256330)
+++ branches/safari-609.1.17.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-11 19:34:33 UTC (rev 256331)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig (256330 => 256331)

--- branches/safari-609.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-11 19:25:47 UTC (rev 256330)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-11 19:34:33 UTC (rev 256331)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256330 => 256331)

--- branches/safari-609.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-11 19:25:47 UTC (rev 256330)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-11 19:34:33 UTC (rev 256331)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION =

[webkit-changes] [256332] trunk/Source/WebKit

2020-02-11 Thread achristensen

Title: [256332] trunk/Source/WebKit








Revision 256332
Author achristen...@apple.com
Date 2020-02-11 11:40:03 -0800 (Tue, 11 Feb 2020)


Log Message
Deprecate _WKUserContentWorld replaced by WKContentWorld
https://bugs.webkit.org/show_bug.cgi?id=207514

Reviewed by Brady Eidson.

I also add SPI to convert between the two to aid a smooth transition.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
* UIProcess/API/APIContentWorld.cpp:
(API::ContentWorld::fromUserContentWorld):
(API::ContentWorld::ContentWorld):
* UIProcess/API/APIContentWorld.h:
(API::ContentWorldBase::ContentWorldBase):
* UIProcess/API/APIUserContentWorld.cpp:
(API::UserContentWorld::fromContentWorld):
(API::UserContentWorld::UserContentWorld):
* UIProcess/API/APIUserContentWorld.h:
* UIProcess/API/Cocoa/WKContentWorld.mm:
(-[WKContentWorld _userContentWorld]):
* UIProcess/API/Cocoa/WKContentWorldInternal.h:
* UIProcess/API/Cocoa/WKContentWorldPrivate.h: Added.
* UIProcess/API/Cocoa/WKUserContentController.mm:
* UIProcess/API/Cocoa/WKUserScript.mm:
* UIProcess/API/Cocoa/_WKUserContentWorld.h:
* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
* UIProcess/API/Cocoa/_WKUserContentWorldInternal.h:
* UIProcess/API/Cocoa/_WKUserStyleSheet.h:
* UIProcess/API/Cocoa/_WKUserStyleSheet.mm:
* WebKit.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/Cocoa/APIObject.mm
trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp
trunk/Source/WebKit/UIProcess/API/APIContentWorld.h
trunk/Source/WebKit/UIProcess/API/APIUserContentWorld.cpp
trunk/Source/WebKit/UIProcess/API/APIUserContentWorld.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentWorld.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentWorldInternal.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUserContentController.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKUserScript.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorldInternal.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserStyleSheet.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserStyleSheet.mm
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebKit/UIProcess/API/Cocoa/WKContentWorldPrivate.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (256331 => 256332)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 19:34:33 UTC (rev 256331)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 19:40:03 UTC (rev 256332)
@@ -1,3 +1,36 @@
+2020-02-11  Alex Christensen  
+
+Deprecate _WKUserContentWorld replaced by WKContentWorld
+https://bugs.webkit.org/show_bug.cgi?id=207514
+
+Reviewed by Brady Eidson.
+
+I also add SPI to convert between the two to aid a smooth transition.
+
+* Shared/Cocoa/APIObject.mm:
+(API::Object::newObject):
+* UIProcess/API/APIContentWorld.cpp:
+(API::ContentWorld::fromUserContentWorld):
+(API::ContentWorld::ContentWorld):
+* UIProcess/API/APIContentWorld.h:
+(API::ContentWorldBase::ContentWorldBase):
+* UIProcess/API/APIUserContentWorld.cpp:
+(API::UserContentWorld::fromContentWorld):
+(API::UserContentWorld::UserContentWorld):
+* UIProcess/API/APIUserContentWorld.h:
+* UIProcess/API/Cocoa/WKContentWorld.mm:
+(-[WKContentWorld _userContentWorld]):
+* UIProcess/API/Cocoa/WKContentWorldInternal.h:
+* UIProcess/API/Cocoa/WKContentWorldPrivate.h: Added.
+* UIProcess/API/Cocoa/WKUserContentController.mm:
+* UIProcess/API/Cocoa/WKUserScript.mm:
+* UIProcess/API/Cocoa/_WKUserContentWorld.h:
+* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
+* UIProcess/API/Cocoa/_WKUserContentWorldInternal.h:
+* UIProcess/API/Cocoa/_WKUserStyleSheet.h:
+* UIProcess/API/Cocoa/_WKUserStyleSheet.mm:
+* WebKit.xcodeproj/project.pbxproj:
+
 2020-02-11  Youenn Fablet  
 
 REGRESSION (r256009): [ Mojave wk2 Debug ] ASSERTION FAILED: Completion handler should always be called under WebKit::WebMDNSRegister::PendingRegistration


Modified: trunk/Source/WebKit/Shared/Cocoa/APIObject.mm (256331 => 256332)

--- trunk/Source/WebKit/Shared/Cocoa/APIObject.mm	2020-02-11 19:34:33 UTC (rev 256331)
+++ trunk/Source/WebKit/Shared/Cocoa/APIObject.mm	2020-02-11 19:40:03 UTC (rev 256332)
@@ -352,7 +352,9 @@
 break;
 
 case Type::UserContentWorld:
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 wrapper = [_WKUserContentWorld alloc];
+ALLOW_DEPRECATED_DECLARATIONS_END
 break;
 
 case Type::UserInitiatedAction:


Modified: trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp (256331 => 256332)

--- trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp	2020-02-11 19:34:33 UTC (rev 256331)
+++ trunk/Source/WebKit/UIProcess/API/APIContentWorld.cpp	2020-02-11 19:40:03 UTC (rev 256332)
@@ -76,6 +76,11 @@
 return

[webkit-changes] [256333] trunk/LayoutTests

2020-02-11 Thread jacob_uphoff

Title: [256333] trunk/LayoutTests








Revision 256333
Author jacob_uph...@apple.com
Date 2020-02-11 11:41:55 -0800 (Tue, 11 Feb 2020)


Log Message
[ macOS wk2 ] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207571

Unreviewed test gardening

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256332 => 256333)

--- trunk/LayoutTests/ChangeLog	2020-02-11 19:40:03 UTC (rev 256332)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 19:41:55 UTC (rev 256333)
@@ -1,5 +1,14 @@
 2020-02-11  Jacob Uphoff  
 
+[ macOS wk2 ] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky failing
+https://bugs.webkit.org/show_bug.cgi?id=207571
+
+Unreviewed test gardening
+
+* platform/mac-wk2/TestExpectations:
+
+2020-02-11  Jacob Uphoff  
+
 [ macOS wk1 ] legacy-animation-engine/animations/3d/transform-origin-vs-functions.html is flaky failing
 https://bugs.webkit.org/show_bug.cgi?id=207569
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256332 => 256333)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 19:40:03 UTC (rev 256332)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 19:41:55 UTC (rev 256333)
@@ -1013,3 +1013,5 @@
 webkit.org/b/207515 http/wpt/service-workers/service-worker-spinning-fetch.https.html [ Pass Failure ]
 
 webkit.org/b/207518 tiled-drawing/simple-document-with-margin-tiles.html [ Pass Failure ]
+
+webkit.rog/b/207571 http/tests/IndexedDB/collect-IDB-objects.https.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256334] branches/safari-609-branch/Source/WebKit

2020-02-11 Thread bfulgham

Title: [256334] branches/safari-609-branch/Source/WebKit








Revision 256334
Author bfulg...@apple.com
Date 2020-02-11 11:54:21 -0800 (Tue, 11 Feb 2020)


Log Message
Apply patch. rdar://problem/59354409

Modified Paths

branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb




Diff

Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (256333 => 256334)

--- branches/safari-609-branch/Source/WebKit/ChangeLog	2020-02-11 19:41:55 UTC (rev 256333)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog	2020-02-11 19:54:21 UTC (rev 256334)
@@ -1,3 +1,17 @@
+2020-02-11  Brent Fulgham  
+
+Cherry-pick r254989. rdar://problem/59354409
+
+[iOS] Camera is lost during WebRTC demo
+https://bugs.webkit.org/show_bug.cgi?id=206613
+
+
+Reviewed by Brent Fulgham.
+
+Fix observed sandbox violations in the Networking process.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
+
 2020-02-10  Kocsen Chung  
 
 Cherry-pick r256105. rdar://problem/59302221


Modified: branches/safari-609-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb (256333 => 256334)

--- branches/safari-609-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2020-02-11 19:41:55 UTC (rev 256333)
+++ branches/safari-609-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb	2020-02-11 19:54:21 UTC (rev 256334)
@@ -587,8 +587,9 @@
 ;; enough access to make it possible.
 
 ;; IOKit user clients
-(allow iokit-open (with report) (with telemetry)
-   (iokit-user-client-class "RootDomainUserClient"))
+(allow iokit-open
+   (iokit-user-client-class "RootDomainUserClient") ;; Needed by PowerObserver
+)
 
 ;; Various services required by CFNetwork and other frameworks
 (allow mach-lookup
@@ -647,3 +648,21 @@
 ;; Various shared memory accesses required by system frameworks
 (allow ipc-posix-shm-read-data
 (ipc-posix-name "/com.apple.AppSSO.version"))
+
+;; Access to ContainerManager
+(allow mach-lookup
+(global-name "com.apple.containermanagerd"))
+(allow ipc-posix-sem-open
+(ipc-posix-name "containermanagerd.fb_check"))
+
+(allow file-read*
+(literal "/dev/random")
+(literal "/dev/urandom"))
+
+;; Access to MobileGestalt
+(allow mach-lookup
+(global-name "com.apple.mobilegestalt.xpc"))
+(allow file-read*
+(well-known-system-group-container-literal "/systemgroup.com.apple.mobilegestaltcache/Library/Caches/com.apple.MobileGestalt.plist"))
+(allow iokit-get-properties
+(iokit-property "IORegistryEntryPropertyKeys"))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256337] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256337] branches/safari-609.1.17.0-branch








Revision 256337
Author repst...@apple.com
Date 2020-02-11 12:48:45 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255593. rdar://problem/59349198

[Web Animations] Accelerated animations don't run until their natural completion
https://bugs.webkit.org/show_bug.cgi?id=207130


Reviewed by Dean Jackson.

Source/WebCore:

Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html
   webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html

Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
The accelerated animations will be queued for removal in the next animation frame.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
* animation/KeyframeEffect.h:
* animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):

LayoutTests:

Add two new tests that ensures that an accelerated animation still yields compositing on an element when
its finished promise is resolved, but that it's no longer the case on the next frame.

This required an existing test to be updated to wait until the next frame before checking the composited
status of an element on which an animation had just completed.

* compositing/geometry/limit-layer-bounds-opacity-transition.html:
* webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
* webanimations/transform-accelerated-animation-finishes-before-removal.html: Added.
* webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt: Added.
* webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffectStack.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256336 => 256337)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:40 UTC (rev 256336)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:45 UTC (rev 256337)
@@ -1,5 +1,65 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r255593. rdar://problem/59349198
+
+[Web Animations] Accelerated animations don't run until their natural completion
+https://bugs.webkit.org/show_bug.cgi?id=207130
+
+
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html
+   webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html
+
+Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
+The accelerated animations will be queued for removal in the next animation frame.
+
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
+* animation/KeyframeEffect.h:
+* animation/KeyframeEffectStack.cpp:
+(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):
+
+LayoutTests:
+
+Add two new tests that ensures that an accelerated animation still yields compositing on an element when
+its finished promise is resolved, but that it's no longer the case on the next frame.
+
+This required an existing test to be updated to wait until the next frame before checking the composited
+status of an element on which an animation had just completed.
+
+* compositing/geometry/limit-layer-bounds-opacity-transition.html:
+* webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
+* webanimations/transform-accelerated-animation-f

[webkit-changes] [256335] branches/safari-609.1.17.0-branch/LayoutTests

2020-02-11 Thread repstein

Title: [256335] branches/safari-609.1.17.0-branch/LayoutTests








Revision 256335
Author repst...@apple.com
Date 2020-02-11 12:48:36 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255525. rdar://problem/59349213

[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=207071

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-31

* platform/ipad/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256334 => 256335)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 19:54:21 UTC (rev 256334)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:36 UTC (rev 256335)
@@ -1,3 +1,27 @@
+2020-02-11  Russell Epstein  
+
+Cherry-pick r255525. rdar://problem/59349213
+
+[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+Unreviewed test gardening.
+
+Patch by Jason Lawrence  on 2020-01-31
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-31  Jason Lawrence  
+
+[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+Unreviewed test gardening.
+
+* platform/ipad/TestExpectations:
+
 2020-02-05  Russell Epstein  
 
 Cherry-pick r255396. rdar://problem/59097789


Modified: branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations (256334 => 256335)

--- branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 19:54:21 UTC (rev 256334)
+++ branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 20:48:36 UTC (rev 256335)
@@ -68,4 +68,6 @@
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-002.html [ Pass ]
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-004.html [ Pass ]
 
-media/picture-in-picture [ Pass ]
\ No newline at end of file
+media/picture-in-picture [ Pass ]
+
+webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256336] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256336] branches/safari-609.1.17.0-branch








Revision 256336
Author repst...@apple.com
Date 2020-02-11 12:48:40 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r22. rdar://problem/59349213

ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
https://bugs.webkit.org/show_bug.cgi?id=207071


Patch by Antoine Quint  on 2020-02-02
Reviewed by Dean Jackson.

Source/WebCore:

We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
because we wouldn't know how to animate that CSS property.

* animation/AnimationTimeline.cpp:
(WebCore::compileTransitionPropertiesInStyle):

LayoutTests:

The crash is fixed, we can start running the test as expected again.

* platform/ipad/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.cpp




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256335 => 256336)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:36 UTC (rev 256335)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:40 UTC (rev 256336)
@@ -1,5 +1,44 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r22. rdar://problem/59349213
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Patch by Antoine Quint  on 2020-02-02
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
+because we wouldn't know how to animate that CSS property.
+
+* animation/AnimationTimeline.cpp:
+(WebCore::compileTransitionPropertiesInStyle):
+
+LayoutTests:
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-02  Antoine Quint  
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Reviewed by Dean Jackson.
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+2020-02-11  Russell Epstein  
+
 Cherry-pick r255525. rdar://problem/59349213
 
 [ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.


Modified: branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations (256335 => 256336)

--- branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 20:48:36 UTC (rev 256335)
+++ branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 20:48:40 UTC (rev 256336)
@@ -69,5 +69,3 @@
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-004.html [ Pass ]
 
 media/picture-in-picture [ Pass ]
-
-webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]
\ No newline at end of file


Modified: branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog (256335 => 256336)

--- branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog	2020-02-11 20:48:36 UTC (rev 256335)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog	2020-02-11 20:48:40 UTC (rev 256336)
@@ -1,3 +1,44 @@
+2020-02-11  Russell Epstein  
+
+Cherry-pick r22. rdar://problem/59349213
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Patch by Antoine Quint  on 2020-02-02
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
+because we wouldn't know how to animate that CSS property.
+
+* animation/AnimationTimeline.cpp:
+(WebCore::compileTransitionPropertiesInStyle):
+
+LayoutTests:
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-02  Antoine Quint  
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(

[webkit-changes] [256338] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256338] branches/safari-609.1.17.0-branch








Revision 256338
Author repst...@apple.com
Date 2020-02-11 12:48:49 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255663. rdar://problem/59349185

Accelerated animations freeze on render tree rebuild
https://bugs.webkit.org/show_bug.cgi?id=201048


Reviewed by Antoine Quint.

Source/WebCore:

If there is an accelerated animation in progress for a renderer and the render tree is rebuild the animation
does not continue with the new renderer.

To fix, make sure that the animation leaves the accelerated state when the renderer is removed. The new renderer
will then become accelerated automatically.

Original test case by Tim Guan-tin Chien.

Test: webanimations/accelerated-animation-renderer-change.html

* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::willChangeRendererForElement):
* animation/AnimationTimeline.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::willChangeRenderer):
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::willChangeRenderer):
* animation/WebAnimation.h:
* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):

LayoutTests:

* webanimations/accelerated-animation-renderer-change-expected.html: Added.
* webanimations/accelerated-animation-renderer-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/WebAnimation.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/WebAnimation.h
branches/safari-609.1.17.0-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-renderer-change-expected.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-renderer-change.html




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256337 => 256338)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:45 UTC (rev 256337)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:49 UTC (rev 256338)
@@ -1,5 +1,58 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r255663. rdar://problem/59349185
+
+Accelerated animations freeze on render tree rebuild
+https://bugs.webkit.org/show_bug.cgi?id=201048
+
+
+Reviewed by Antoine Quint.
+
+Source/WebCore:
+
+If there is an accelerated animation in progress for a renderer and the render tree is rebuild the animation
+does not continue with the new renderer.
+
+To fix, make sure that the animation leaves the accelerated state when the renderer is removed. The new renderer
+will then become accelerated automatically.
+
+Original test case by Tim Guan-tin Chien.
+
+Test: webanimations/accelerated-animation-renderer-change.html
+
+* animation/AnimationTimeline.cpp:
+(WebCore::AnimationTimeline::willChangeRendererForElement):
+* animation/AnimationTimeline.h:
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::willChangeRenderer):
+* animation/KeyframeEffect.h:
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::willChangeRenderer):
+* animation/WebAnimation.h:
+* rendering/updating/RenderTreeUpdater.cpp:
+(WebCore::RenderTreeUpdater::tearDownRenderers):
+
+LayoutTests:
+
+* webanimations/accelerated-animation-renderer-change-expected.html: Added.
+* webanimations/accelerated-animation-renderer-change.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-03  Antti Koivisto  
+
+Accelerated animations freeze on render tree rebuild
+https://bugs.webkit.org/show_bug.cgi?id=201048
+
+
+Reviewed by Antoine Quint.
+
+* webanimations/accelerated-animation-renderer-change-expected.html: Added.
+* webanimations/accelerated-animation-renderer-change.html: Added.
+
+2020-02-11  Russell Epstein  
+
 Cherry-pick r255593. rdar://problem/59349198
 
 [Web Animations] Accelerated animations don't run until their natural completion


Added: branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-renderer-cha

[webkit-changes] [256341] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256341] branches/safari-609.1.17.0-branch








Revision 256341
Author repst...@apple.com
Date 2020-02-11 12:49:00 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256181. rdar://problem/59349184

There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=207361


Reviewed by Simon Fraser.

Source/WebCore:

Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
an active transform animation.

To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.

Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.

* animation/AnimationEffect.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::updateAcceleratedActions):
(WebCore::KeyframeEffect::animationDidTick):
(WebCore::KeyframeEffect::animationDidPlay):
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::play):
(WebCore::WebAnimation::tick):

LayoutTests:

Lower the number of frames to wait after an animation completes by one to check that the accelerated animation has been removed
to show that we enqueue accelerated actions as part of the "update animations and send events" procedure.

* webanimations/accelerated-animation-removal-upon-transition-completion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-removal-upon-transition-completion.html
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/WebAnimation.cpp




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256340 => 256341)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:56 UTC (rev 256340)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:49:00 UTC (rev 256341)
@@ -1,5 +1,61 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r256181. rdar://problem/59349184
+
+There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
+https://bugs.webkit.org/show_bug.cgi?id=207361
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
+animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
+an active transform animation.
+
+To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
+KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
+WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.
+
+Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.
+
+* animation/AnimationEffect.h:
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::apply):
+(WebCore::KeyframeEffect::updateAcceleratedActions):
+(WebCore::KeyframeEffect::animationDidTick):
+(WebCore::KeyframeEffect::animationDidPlay):
+* animation/KeyframeEffect.h:
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::play):
+(WebCore::WebAnimation::tick):
+
+LayoutTests:
+
+Lower the number of frames to wait after an animation completes by one to check that the accelerated animation has been removed
+to show that we enqueue accelerated actions as part of the "update animations and send events" procedure.
+
+* webanimations/accelerated-animation-removal-upon-transition-completion.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-10  Antoine Quint  
+
+There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
+

[webkit-changes] [256339] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256339] branches/safari-609.1.17.0-branch








Revision 256339
Author repst...@apple.com
Date 2020-02-11 12:48:52 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255810. rdar://problem/59349189

[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
https://bugs.webkit.org/show_bug.cgi?id=207253


Reviewed by Antti Koivisto.

Source/WebCore:

Test: webanimations/accelerated-animation-canceled-before-commit.html

Merely checking whether an accelerated animation is running prior to enqueuing an action to cancel it is not sufficient
since there could be an uncommitted change to start it upon the next animation frame. The same logic would need to apply
in other situations where the playback state changes for a potentially in-flight animation.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::animationDidSeek):
(WebCore::KeyframeEffect::animationWasCanceled):
(WebCore::KeyframeEffect::willChangeRenderer):
(WebCore::KeyframeEffect::animationSuspensionStateDidChange):

LayoutTests:

Add a new test that checks that an accelerated animation that has been enqueued to start but has
not yet been committed is correctly canceled when the cancel() method is called. This test fails
prior to this source change.

* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
* webanimations/accelerated-animation-canceled-before-commit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit-expected.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit.html




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256338 => 256339)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:49 UTC (rev 256338)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:48:52 UTC (rev 256339)
@@ -1,5 +1,55 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r255810. rdar://problem/59349189
+
+[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
+https://bugs.webkit.org/show_bug.cgi?id=207253
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+Test: webanimations/accelerated-animation-canceled-before-commit.html
+
+Merely checking whether an accelerated animation is running prior to enqueuing an action to cancel it is not sufficient
+since there could be an uncommitted change to start it upon the next animation frame. The same logic would need to apply
+in other situations where the playback state changes for a potentially in-flight animation.
+
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::animationDidSeek):
+(WebCore::KeyframeEffect::animationWasCanceled):
+(WebCore::KeyframeEffect::willChangeRenderer):
+(WebCore::KeyframeEffect::animationSuspensionStateDidChange):
+
+LayoutTests:
+
+Add a new test that checks that an accelerated animation that has been enqueued to start but has
+not yet been committed is correctly canceled when the cancel() method is called. This test fails
+prior to this source change.
+
+* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
+* webanimations/accelerated-animation-canceled-before-commit.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-05  Antoine Quint  
+
+[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
+https://bugs.webkit.org/show_bug.cgi?id=207253
+
+
+Reviewed by Antti Koivisto.
+
+Add a new test that checks that an accelerated animation that has been enqueued to start but has
+not yet been committed is correctly canceled when the cancel() method is called. This test fails
+prior to this source change.
+
+* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
+* webanimations/accelerated-animation-canceled-before-commit.html: Added.
+
+2020-02-11  Russell Epstein  
+
 Cherry-pick r255663. rdar://problem/59349185
 
 Accelerated animations freeze on render tree rebuild


Added: branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit-expected.html (0 => 256339)

[webkit-changes] [256340] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256340] branches/safari-609.1.17.0-branch








Revision 256340
Author repst...@apple.com
Date 2020-02-11 12:48:56 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256095. rdar://problem/59349202

Extent of a composited animation should not include the untransformed position
https://bugs.webkit.org/show_bug.cgi?id=207434

Reviewed by Sam Weinig.
Source/WebCore:

To determine whether to create ("attach") backing store for layers with transform animations,
we compute the union of all the states of the animation as an "extent", and ask whether it intersects
the coverage rect in GraphicsLayerCA.

The non-Web Animations transition code did this correctly, just unioning the bounds transformed by
the start and end state.

The non-Web Animations keyframe code, and the Web Animations KeyframeEffect code (used for both CSS transitions
and animations) also unioned with the unanimated bounds, which could create overly large extents in some
cases, contributing to jetsams on iOS (rdar://problem/59020443).

Fix KeyframeAnimation and KeyframeEffect to not union with the untransformed bounds.

Tests: compositing/backing/backing-store-attachment-animating-outside-viewport.html
   legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::computeExtentOfTransformAnimation const):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::computeExtentOfTransformAnimation const):

LayoutTests:

New test that checks backing store attachment and overlap for an element which is positioned in-view,
but is move offscreen by the animation.

New baselines for overlap tests, since overlap no longer considers the unanimated position.

* compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* compositing/backing/backing-store-attachment-animating-outside-viewport.html: Added.
* compositing/layer-creation/translate-animation-overlap-expected.txt:
* compositing/layer-creation/translate-scale-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html: Added.
* legacy-animation-engine/compositing/layer-creation/translate-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap-expected.txt:
* platform/ios-wk2/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* platform/ios-wk2/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/compositing/layer-creation/translate-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/layer-creation/translate-scale-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/page/animation/KeyframeAnimation.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/backing-store-attachment-animating-outside-viewport.html
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/legacy-animation-engine/compositing/
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/legacy-animation-engine/compositing/backing/
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (25633

[webkit-changes] [256342] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256342] branches/safari-609.1.17.0-branch








Revision 256342
Author repst...@apple.com
Date 2020-02-11 12:49:03 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256214. rdar://problem/59349205

WebContent jetsams on Sony lens webpage due to spike of IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=207493
rdar://problem/59020443

Reviewed by Zalan Bujtas.
Source/WebCore:

There were three issues that contributed to massive backing store allocation on
.

The first, fixed in r256095, was that the Web Animations code unioned the untransitioning
bounds with the transitioning bounds, causing the computation of large extent rects.

The second, fixed in r256181, was that GraphicsLayerCA would keep hold of a transform
animation for an extra frame, causing a rendering update where
RenderLayerBacking::updateGeometry() would have cleared the extent, but GraphicsLayerCA
still thought transform was animating, causing GraphicsLayerCA::updateCoverage() to keep
backing store attached.

This patch is the final fix; when animations start and end, we need to ensure that
RenderLayerBacking::updateGeometry() is called so that we compute the animation extent in
the same frame that adds the animation.

Test: compositing/backing/transition-extent.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::animationFinished):

LayoutTests:

Test with an out-of-view transitioning element which should not get backing store.

* compositing/backing/transition-extent-expected.txt: Added.
* compositing/backing/transition-extent.html: Added.
* platform/ios-wk2/compositing/backing/transition-extent-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/rendering/RenderLayerBacking.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/transition-extent-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/transition-extent.html
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/compositing/backing/transition-extent-expected.txt




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256341 => 256342)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:49:00 UTC (rev 256341)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 20:49:03 UTC (rev 256342)
@@ -1,59 +1,102 @@
 2020-02-11  Russell Epstein  
 
-Cherry-pick r256181. rdar://problem/59349184
+Cherry-pick r256214. rdar://problem/59349205
 
-There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
-https://bugs.webkit.org/show_bug.cgi?id=207361
-
+WebContent jetsams on Sony lens webpage due to spike of IOSurfaces
+https://bugs.webkit.org/show_bug.cgi?id=207493
+rdar://problem/59020443
 
-Reviewed by Simon Fraser.
-
+Reviewed by Zalan Bujtas.
 Source/WebCore:
 
-Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
-animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
-an active transform animation.
+There were three issues that contributed to massive backing store allocation on
+.
 
-To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
-KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
-WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.
+The first, fixed in r256095, was that the Web Animations code unioned the untransitioning
+bounds with the transitioning bounds, causing the computation of large extent rects.
 
-Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.
+The second, fixed in r256181, was that GraphicsLayerCA would keep hold of a transform
+animation for an extra frame, causing a rendering update where
+RenderLayerBacking::updateGeometry() would have cleared the extent, but GraphicsLayerCA
+still thought transform was animating, causing GraphicsLayerCA::updateCoverage() to keep
+backing store attached.
 
-* animation/AnimationEffect.h:
-* animation/KeyframeEffect.cpp:
-(WebCore::KeyframeEffect::apply):
-(WebCore::KeyframeEffect::updateAcceleratedActions):
-(WebCore::KeyframeEffect::animationDidTick):
-(WebCore::KeyframeEffect::animationDidPlay):
-* animation/KeyframeEffect.h:
-

[webkit-changes] [256343] trunk/Tools

2020-02-11 Thread wenson_hsieh

Title: [256343] trunk/Tools








Revision 256343
Author wenson_hs...@apple.com
Date 2020-02-11 12:59:13 -0800 (Tue, 11 Feb 2020)


Log Message
KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
https://bugs.webkit.org/show_bug.cgi?id=207557

Reviewed by Jonathan Bedard.

The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
around this by focusing an empty select element instead (for which we won't attempt to create and select any
table view cells).

* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm




Diff

Modified: trunk/Tools/ChangeLog (256342 => 256343)

--- trunk/Tools/ChangeLog	2020-02-11 20:49:03 UTC (rev 256342)
+++ trunk/Tools/ChangeLog	2020-02-11 20:59:13 UTC (rev 256343)
@@ -1,3 +1,18 @@
+2020-02-11  Wenson Hsieh  
+
+KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
+https://bugs.webkit.org/show_bug.cgi?id=207557
+
+Reviewed by Jonathan Bedard.
+
+The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
+a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
+to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
+around this by focusing an empty select element instead (for which we won't attempt to create and select any
+table view cells).
+
+* TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
+
 2020-02-11  Alex Christensen  
 
 Add WKHTTPCookieStore._getCookiesForURL SPI


Modified: trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm (256342 => 256343)

--- trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm	2020-02-11 20:49:03 UTC (rev 256342)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm	2020-02-11 20:59:13 UTC (rev 256343)
@@ -607,15 +607,15 @@
 
 auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 568)]);
 auto contentView = (id )[webView textInputContentView];
-[webView synchronouslyLoadHTMLString:@""];
+[webView synchronouslyLoadHTMLString:@""];
 [webView _setInputDelegate:inputDelegate.get()];
 
 [webView stringByEvaluatingJavaScript:@"input.focus()"];
 EXPECT_TRUE(contentView.supportsImagePaste);
 
-[webView stringByEvaluatingJavaScript:@"document.activeElement.blur(); input.type = 'date'"];
+[webView stringByEvaluatingJavaScript:@"document.activeElement.blur()"];
 [webView waitForNextPresentationUpdate];
-[webView stringByEvaluatingJavaScript:@"input.focus()"];
+[webView stringByEvaluatingJavaScript:@"select.focus()"];
 EXPECT_FALSE(contentView.supportsImagePaste);
 
 [webView stringByEvaluatingJavaScript:@"editor.focus()"];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256344] trunk/LayoutTests

2020-02-11 Thread lawrence . j

Title: [256344] trunk/LayoutTests








Revision 256344
Author lawrenc...@apple.com
Date 2020-02-11 13:08:09 -0800 (Tue, 11 Feb 2020)


Log Message
[ Mac wk2 ] http/tests/ssl/applepay/ApplePayBillingAddress.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207577

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256343 => 256344)

--- trunk/LayoutTests/ChangeLog	2020-02-11 20:59:13 UTC (rev 256343)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 21:08:09 UTC (rev 256344)
@@ -1,3 +1,12 @@
+2020-02-11  Jason Lawrence  
+
+[ Mac wk2 ] http/tests/ssl/applepay/ApplePayBillingAddress.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=207577
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2020-02-11  Jacob Uphoff  
 
 [ macOS wk2 ] http/tests/IndexedDB/collect-IDB-objects.https.html is flaky failing


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256343 => 256344)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 20:59:13 UTC (rev 256343)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 21:08:09 UTC (rev 256344)
@@ -1014,4 +1014,6 @@
 
 webkit.org/b/207518 tiled-drawing/simple-document-with-margin-tiles.html [ Pass Failure ]
 
-webkit.rog/b/207571 http/tests/IndexedDB/collect-IDB-objects.https.html [ Pass Failure ]
\ No newline at end of file
+webkit.rog/b/207571 http/tests/IndexedDB/collect-IDB-objects.https.html [ Pass Failure ]
+
+webkit.org/b/207577 http/tests/ssl/applepay/ApplePayBillingAddress.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256345] trunk/Source/WebKit

2020-02-11 Thread achristensen

Title: [256345] trunk/Source/WebKit








Revision 256345
Author achristen...@apple.com
Date 2020-02-11 13:09:21 -0800 (Tue, 11 Feb 2020)


Log Message
Deprecate _WKUserContentWorld replaced by WKContentWorld
https://bugs.webkit.org/show_bug.cgi?id=207514

Add the rest of the SPI to convert between the two.

* UIProcess/API/Cocoa/_WKUserContentWorld.h:
* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
(-[_WKUserContentWorld contentWorld]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256344 => 256345)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 21:08:09 UTC (rev 256344)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 21:09:21 UTC (rev 256345)
@@ -3,6 +3,17 @@
 Deprecate _WKUserContentWorld replaced by WKContentWorld
 https://bugs.webkit.org/show_bug.cgi?id=207514
 
+Add the rest of the SPI to convert between the two.
+
+* UIProcess/API/Cocoa/_WKUserContentWorld.h:
+* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
+(-[_WKUserContentWorld contentWorld]):
+
+2020-02-11  Alex Christensen  
+
+Deprecate _WKUserContentWorld replaced by WKContentWorld
+https://bugs.webkit.org/show_bug.cgi?id=207514
+
 Reviewed by Brady Eidson.
 
 I also add SPI to convert between the two to aid a smooth transition.


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h (256344 => 256345)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h	2020-02-11 21:08:09 UTC (rev 256344)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h	2020-02-11 21:09:21 UTC (rev 256345)
@@ -27,6 +27,8 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
+@class WKContentWorld;
+
 WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKContentWorld", macos(10.12, WK_MAC_TBA), ios(10.0, WK_IOS_TBA))
 @interface _WKUserContentWorld : NSObject
 
@@ -33,6 +35,8 @@
 + (_WKUserContentWorld *)worldWithName:(NSString *)name;
 + (_WKUserContentWorld *)normalWorld;
 
+@property (nonatomic, copy, readonly) WKContentWorld *contentWorld WK_API_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
+
 @property (nullable, nonatomic, readonly, copy) NSString *name;
 
 @end


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm (256344 => 256345)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm	2020-02-11 21:08:09 UTC (rev 256344)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm	2020-02-11 21:09:21 UTC (rev 256345)
@@ -26,6 +26,8 @@
 #import "config.h"
 #import "_WKUserContentWorldInternal.h"
 
+#import "WKContentWorldInternal.h"
+
 ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
 @implementation _WKUserContentWorld
 
@@ -53,6 +55,11 @@
 return _userContentWorld->name();
 }
 
+- (WKContentWorld *)contentWorld
+{
+return wrapper(API::ContentWorld::fromUserContentWorld(*_userContentWorld));
+}
+
 #pragma mark WKObject protocol implementation
 
 - (API::Object&)_apiObject






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256346] trunk

2020-02-11 Thread eric . carlson

Title: [256346] trunk








Revision 256346
Author eric.carl...@apple.com
Date 2020-02-11 13:14:44 -0800 (Tue, 11 Feb 2020)


Log Message
video.currentTime is not being updated in iOS 13.4 Beta
https://bugs.webkit.org/show_bug.cgi?id=207489


Reviewed by Youenn Fablet.

Source/WebKit:

Allow the Web process and the GPU process to communicate with
'com.apple.coremedia.audiodeviceclock.xpc' because it is necessary to use a
CMTimeBase, which is used by MediaPlayerPrivateMediaStreamAVFObjC for currentTime.

Test: fast/mediastream/media-element-current-time.html

* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

* fast/mediastream/media-element-current-time.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb


Added Paths

trunk/LayoutTests/fast/mediastream/media-element-current-time-expected.txt
trunk/LayoutTests/fast/mediastream/media-element-current-time.html




Diff

Modified: trunk/LayoutTests/ChangeLog (256345 => 256346)

--- trunk/LayoutTests/ChangeLog	2020-02-11 21:09:21 UTC (rev 256345)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 21:14:44 UTC (rev 256346)
@@ -1,3 +1,13 @@
+2020-02-11  Eric Carlson  
+
+video.currentTime is not being updated in iOS 13.4 Beta
+https://bugs.webkit.org/show_bug.cgi?id=207489
+
+
+Reviewed by Youenn Fablet.
+
+* fast/mediastream/media-element-current-time.html: Added.
+
 2020-02-11  Jason Lawrence  
 
 [ Mac wk2 ] http/tests/ssl/applepay/ApplePayBillingAddress.html is flaky failing.


Added: trunk/LayoutTests/fast/mediastream/media-element-current-time-expected.txt (0 => 256346)

--- trunk/LayoutTests/fast/mediastream/media-element-current-time-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/mediastream/media-element-current-time-expected.txt	2020-02-11 21:14:44 UTC (rev 256346)
@@ -0,0 +1,4 @@
+
+
+PASS Check video.currentTime behavior 
+


Added: trunk/LayoutTests/fast/mediastream/media-element-current-time.html (0 => 256346)

--- trunk/LayoutTests/fast/mediastream/media-element-current-time.html	(rev 0)
+++ trunk/LayoutTests/fast/mediastream/media-element-current-time.html	2020-02-11 21:14:44 UTC (rev 256346)
@@ -0,0 +1,31 @@
+
+
+
+
+promise_test(async() => {
+
+let stream = await navigator.mediaDevices.getUserMedia({video : true});
+
+video.srcObject = stream;
+assert_equals(video.currentTime, 0);
+
+await video.play();
+let currentTime = video.currentTime;
+assert_not_equals(currentTime, 0, "Playback has started, currentTime must not be zero");
+
+await new Promise(resolve => setTimeout(resolve, 10));
+assert_greater_than(video.currentTime, currentTime, "video is playing, time should advance");
+
+video.pause();
+currentTime = video.currentTime;
+await new Promise(resolve => setTimeout(resolve, 10));
+assert_equals(video.currentTime, currentTime, "video is paused, currentTime must not advance");
+
+await video.play();
+assert_greater_than(video.currentTime, currentTime, "Playback has started, currentTime should advance");
+
+}, "Check video.currentTime behavior");
+
+


Modified: trunk/Source/WebKit/ChangeLog (256345 => 256346)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 21:09:21 UTC (rev 256345)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 21:14:44 UTC (rev 256346)
@@ -1,3 +1,20 @@
+2020-02-11  Eric Carlson  
+
+video.currentTime is not being updated in iOS 13.4 Beta
+https://bugs.webkit.org/show_bug.cgi?id=207489
+
+
+Reviewed by Youenn Fablet.
+
+Allow the Web process and the GPU process to communicate with
+'com.apple.coremedia.audiodeviceclock.xpc' because it is necessary to use a 
+CMTimeBase, which is used by MediaPlayerPrivateMediaStreamAVFObjC for currentTime.
+
+Test: fast/mediastream/media-element-current-time.html
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-02-11  Alex Christensen  
 
 Deprecate _WKUserContentWorld replaced by WKContentWorld


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (256345 => 256346)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2020-02-11 21:09:21 UTC (rev 256345)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb	2020-02-11 21:14:44 UTC (rev 256346)
@@ -140,6 +140,7 @@
(global-name "com.apple.coremedia.admin")
(global-name "com.apple.coremedia.asset.xpc")
(global-name "com.apple.coremedia.assetimagegenerator.xpc")
+   (global-name "com.apple.coremedia.audiodeviceclock.xpc") ; Needed for CMTime

[webkit-changes] [256347] trunk/Source/WebCore

2020-02-11 Thread andresg_22

Title: [256347] trunk/Source/WebCore








Revision 256347
Author andresg...@apple.com
Date 2020-02-11 13:33:41 -0800 (Tue, 11 Feb 2020)


Log Message
Fix for crashes in WebAccessibilityObjectWrapper after notification updates in IsolatedTree mode.
https://bugs.webkit.org/show_bug.cgi?id=207558

Reviewed by Chris Fleizach.

- Accessibility methods invoked in the secondary thread that Return id
values retrieved from the main thread, need to retain/autorelease the
returned ids.
- When serving a request on the AX thread that requires retrieving a
value from the main thread, the backing obbject on the main thread may
have gone away, so need to check for nullity of the backing object also
on the main thread.

* accessibility/AccessibilityObjectInterface.h:
(WebCore::Accessibility::retrieveAutoreleasedValueFromMainThread):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper attachmentView]):
(-[WebAccessibilityObjectWrapper textMarkerRangeFromRange:]):
(-[WebAccessibilityObjectWrapper renderWidgetChildren]):
(-[WebAccessibilityObjectWrapper associatedPluginParent]):
(-[WebAccessibilityObjectWrapper scrollViewParent]):
(-[WebAccessibilityObjectWrapper windowElement:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (256346 => 256347)

--- trunk/Source/WebCore/ChangeLog	2020-02-11 21:14:44 UTC (rev 256346)
+++ trunk/Source/WebCore/ChangeLog	2020-02-11 21:33:41 UTC (rev 256347)
@@ -1,3 +1,29 @@
+2020-02-11  Andres Gonzalez  
+
+Fix for crashes in WebAccessibilityObjectWrapper after notification updates in IsolatedTree mode.
+https://bugs.webkit.org/show_bug.cgi?id=207558
+
+Reviewed by Chris Fleizach.
+
+- Accessibility methods invoked in the secondary thread that Return id
+values retrieved from the main thread, need to retain/autorelease the
+returned ids.
+- When serving a request on the AX thread that requires retrieving a
+value from the main thread, the backing obbject on the main thread may
+have gone away, so need to check for nullity of the backing object also
+on the main thread.
+
+* accessibility/AccessibilityObjectInterface.h:
+(WebCore::Accessibility::retrieveAutoreleasedValueFromMainThread):
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper attachmentView]):
+(-[WebAccessibilityObjectWrapper textMarkerRangeFromRange:]):
+(-[WebAccessibilityObjectWrapper renderWidgetChildren]):
+(-[WebAccessibilityObjectWrapper associatedPluginParent]):
+(-[WebAccessibilityObjectWrapper scrollViewParent]):
+(-[WebAccessibilityObjectWrapper windowElement:]):
+(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
+
 2020-02-11  Zalan Bujtas  
 
 [LFC] Introduce Layout::LineBreakBox


Modified: trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h (256346 => 256347)

--- trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h	2020-02-11 21:14:44 UTC (rev 256346)
+++ trunk/Source/WebCore/accessibility/AccessibilityObjectInterface.h	2020-02-11 21:33:41 UTC (rev 256347)
@@ -1207,6 +1207,20 @@
 return value;
 }
 
+#if PLATFORM(COCOA)
+template inline T retrieveAutoreleasedValueFromMainThread(U&& lambda)
+{
+if (isMainThread())
+return lambda().autorelease();
+
+RetainPtr value;
+callOnMainThreadAndWait([&value, &lambda] {
+value = lambda();
+});
+return value.autorelease();
+}
+#endif
+
 } // namespace Accessibility
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (256346 => 256347)

--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2020-02-11 21:14:44 UTC (rev 256346)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2020-02-11 21:33:41 UTC (rev 256347)
@@ -557,7 +557,7 @@
 {
 ASSERT(self.axBackingObject->isAttachment());
 
-return Accessibility::retrieveValueFromMainThread([protectedSelf = RetainPtr(self)] () -> id {
+return Accessibility::retrieveAutoreleasedValueFromMainThread([protectedSelf = RetainPtr(self)] () -> RetainPtr {
 auto* widget = protectedSelf.get().axBackingObject->widgetForAttachmentView();
 if (!widget)
 return nil;
@@ -799,7 +799,9 @@
 
 - (id)textMarkerRangeFromRange:(const RefPtr)range
 {
-return textMarkerRangeFromRange(self.axBackingObject->axObjectCache(), range);
+if (auto* backingObject = self.axBackingObject)
+return textMarkerRangeFromRange(backingObject->axObjectCache(), range);
+return nil;
 }
 
 static id textMarkerRa

[webkit-changes] [256348] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256348] branches/safari-609.1.17.0-branch








Revision 256348
Author repst...@apple.com
Date 2020-02-11 13:37:42 -0800 (Tue, 11 Feb 2020)


Log Message
Revert "Cherry-pick r256214. rdar://problem/59349205"

This reverts commit 136c83914552143e2f30738b1892c80bdce440bf.

Revert "Cherry-pick r256181. rdar://problem/59349184"

This reverts commit c243d1210b16f08fe15d2655e5404fc58e3a8f2f.

Revert "Cherry-pick r256095. rdar://problem/59349202"

This reverts commit da093df9a0316d7248cd43eead2fda895dbdc415.

Revert "Cherry-pick r255810. rdar://problem/59349189"

This reverts commit 410a91668843774b2cea733ea441221c8ad6bc40.

Revert "Cherry-pick r255663. rdar://problem/59349185"

This reverts commit ee4f679f99959f7eee3d509950a6b44c611f7dc6.

Revert "Cherry-pick r255593. rdar://problem/59349198"

This reverts commit 1ae924558dd4ff09bf20d97fa3a3648cd9766bcf.

Revert "Cherry-pick r22. rdar://problem/59349213"

This reverts commit f8feeed1205b837e4912f66bdf76c935612be0f3.

Revert "Cherry-pick r255525. rdar://problem/59349213"

This reverts commit 444142aa67ab570929cada2fcd63156d65e4d55c.

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html
branches/safari-609.1.17.0-branch/LayoutTests/compositing/layer-creation/translate-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/layer-creation/translate-scale-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-removal-upon-transition-completion.html
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffectStack.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/WebAnimation.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/WebAnimation.h
branches/safari-609.1.17.0-branch/Source/WebCore/page/animation/KeyframeAnimation.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/rendering/RenderLayerBacking.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp


Removed Paths

branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/backing-store-attachment-animating-outside-viewport.html
branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/transition-extent-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/transition-extent.html
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/compositing/backing/transition-extent-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit-expected.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-renderer-change-expected.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-renderer-change.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt
branches/safari-609.

[webkit-changes] [256358] branches/safari-609.1.17.0-branch/Source/WebCore

2020-02-11 Thread repstein

Title: [256358] branches/safari-609.1.17.0-branch/Source/WebCore








Revision 256358
Author repst...@apple.com
Date 2020-02-11 13:38:14 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256230. rdar://problem/59335800

Adjust the minor version number for the desktop user agent string.
https://bugs.webkit.org/show_bug.cgi?id=207498


Patch by Keith Rollin  on 2020-02-10
Reviewed by Wenson Hsieh.

This helps with Netflix compatibility on the iPad.

No new tests -- no new or changed functionality.

* platform/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/platform/ios/UserAgentIOS.mm




Diff

Modified: branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog (256357 => 256358)

--- branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog	2020-02-11 21:38:12 UTC (rev 256357)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog	2020-02-11 21:38:14 UTC (rev 256358)
@@ -1,5 +1,40 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r256230. rdar://problem/59335800
+
+Adjust the minor version number for the desktop user agent string.
+https://bugs.webkit.org/show_bug.cgi?id=207498
+
+
+Patch by Keith Rollin  on 2020-02-10
+Reviewed by Wenson Hsieh.
+
+This helps with Netflix compatibility on the iPad.
+
+No new tests -- no new or changed functionality.
+
+* platform/ios/UserAgentIOS.mm:
+(WebCore::standardUserAgentWithApplicationName):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-10  Keith Rollin  
+
+Adjust the minor version number for the desktop user agent string.
+https://bugs.webkit.org/show_bug.cgi?id=207498
+
+
+Reviewed by Wenson Hsieh.
+
+This helps with Netflix compatibility on the iPad.
+
+No new tests -- no new or changed functionality.
+
+* platform/ios/UserAgentIOS.mm:
+(WebCore::standardUserAgentWithApplicationName):
+
+2020-02-11  Russell Epstein  
+
 Cherry-pick r256214. rdar://problem/59349590
 
 WebContent jetsams on Sony lens webpage due to spike of IOSurfaces


Modified: branches/safari-609.1.17.0-branch/Source/WebCore/platform/ios/UserAgentIOS.mm (256357 => 256358)

--- branches/safari-609.1.17.0-branch/Source/WebCore/platform/ios/UserAgentIOS.mm	2020-02-11 21:38:12 UTC (rev 256357)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/platform/ios/UserAgentIOS.mm	2020-02-11 21:38:14 UTC (rev 256358)
@@ -83,7 +83,7 @@
 {
 if (type == UserAgentType::Desktop) {
 String appNameSuffix = applicationName.isEmpty() ? "" : makeString(" ", applicationName);
-return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);
+return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);
 }
 
 // FIXME: Is this needed any more? Mac doesn't have this check,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256354] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256354] branches/safari-609.1.17.0-branch








Revision 256354
Author repst...@apple.com
Date 2020-02-11 13:38:00 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255810. rdar://problem/59335797

[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
https://bugs.webkit.org/show_bug.cgi?id=207253


Reviewed by Antti Koivisto.

Source/WebCore:

Test: webanimations/accelerated-animation-canceled-before-commit.html

Merely checking whether an accelerated animation is running prior to enqueuing an action to cancel it is not sufficient
since there could be an uncommitted change to start it upon the next animation frame. The same logic would need to apply
in other situations where the playback state changes for a potentially in-flight animation.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::animationDidSeek):
(WebCore::KeyframeEffect::animationWasCanceled):
(WebCore::KeyframeEffect::willChangeRenderer):
(WebCore::KeyframeEffect::animationSuspensionStateDidChange):

LayoutTests:

Add a new test that checks that an accelerated animation that has been enqueued to start but has
not yet been committed is correctly canceled when the cancel() method is called. This test fails
prior to this source change.

* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
* webanimations/accelerated-animation-canceled-before-commit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit-expected.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit.html




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256353 => 256354)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:58 UTC (rev 256353)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:38:00 UTC (rev 256354)
@@ -1,5 +1,55 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r255810. rdar://problem/59335797
+
+[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
+https://bugs.webkit.org/show_bug.cgi?id=207253
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+Test: webanimations/accelerated-animation-canceled-before-commit.html
+
+Merely checking whether an accelerated animation is running prior to enqueuing an action to cancel it is not sufficient
+since there could be an uncommitted change to start it upon the next animation frame. The same logic would need to apply
+in other situations where the playback state changes for a potentially in-flight animation.
+
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::animationDidSeek):
+(WebCore::KeyframeEffect::animationWasCanceled):
+(WebCore::KeyframeEffect::willChangeRenderer):
+(WebCore::KeyframeEffect::animationSuspensionStateDidChange):
+
+LayoutTests:
+
+Add a new test that checks that an accelerated animation that has been enqueued to start but has
+not yet been committed is correctly canceled when the cancel() method is called. This test fails
+prior to this source change.
+
+* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
+* webanimations/accelerated-animation-canceled-before-commit.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-05  Antoine Quint  
+
+[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
+https://bugs.webkit.org/show_bug.cgi?id=207253
+
+
+Reviewed by Antti Koivisto.
+
+Add a new test that checks that an accelerated animation that has been enqueued to start but has
+not yet been committed is correctly canceled when the cancel() method is called. This test fails
+prior to this source change.
+
+* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
+* webanimations/accelerated-animation-canceled-before-commit.html: Added.
+
+2020-02-11  Russell Epstein  
+
 Cherry-pick r255663. rdar://problem/59335773
 
 Accelerated animations freeze on render tree rebuild


Added: branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit-expected.html (0 => 256354)

[webkit-changes] [256351] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256351] branches/safari-609.1.17.0-branch








Revision 256351
Author repst...@apple.com
Date 2020-02-11 13:37:53 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255593. rdar://problem/59335802

[Web Animations] Accelerated animations don't run until their natural completion
https://bugs.webkit.org/show_bug.cgi?id=207130


Reviewed by Dean Jackson.

Source/WebCore:

Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html
   webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html

Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
The accelerated animations will be queued for removal in the next animation frame.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
* animation/KeyframeEffect.h:
* animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):

LayoutTests:

Add two new tests that ensures that an accelerated animation still yields compositing on an element when
its finished promise is resolved, but that it's no longer the case on the next frame.

This required an existing test to be updated to wait until the next frame before checking the composited
status of an element on which an animation had just completed.

* compositing/geometry/limit-layer-bounds-opacity-transition.html:
* webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
* webanimations/transform-accelerated-animation-finishes-before-removal.html: Added.
* webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt: Added.
* webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffectStack.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256350 => 256351)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:49 UTC (rev 256350)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:53 UTC (rev 256351)
@@ -1,5 +1,65 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r255593. rdar://problem/59335802
+
+[Web Animations] Accelerated animations don't run until their natural completion
+https://bugs.webkit.org/show_bug.cgi?id=207130
+
+
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html
+   webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html
+
+Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
+The accelerated animations will be queued for removal in the next animation frame.
+
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
+* animation/KeyframeEffect.h:
+* animation/KeyframeEffectStack.cpp:
+(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):
+
+LayoutTests:
+
+Add two new tests that ensures that an accelerated animation still yields compositing on an element when
+its finished promise is resolved, but that it's no longer the case on the next frame.
+
+This required an existing test to be updated to wait until the next frame before checking the composited
+status of an element on which an animation had just completed.
+
+* compositing/geometry/limit-layer-bounds-opacity-transition.html:
+* webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
+* webanimations/transform-accelerated-animation-f

[webkit-changes] [256356] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256356] branches/safari-609.1.17.0-branch








Revision 256356
Author repst...@apple.com
Date 2020-02-11 13:38:08 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256181. rdar://problem/59335793

There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=207361


Reviewed by Simon Fraser.

Source/WebCore:

Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
an active transform animation.

To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.

Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.

* animation/AnimationEffect.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::updateAcceleratedActions):
(WebCore::KeyframeEffect::animationDidTick):
(WebCore::KeyframeEffect::animationDidPlay):
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::play):
(WebCore::WebAnimation::tick):

LayoutTests:

Lower the number of frames to wait after an animation completes by one to check that the accelerated animation has been removed
to show that we enqueue accelerated actions as part of the "update animations and send events" procedure.

* webanimations/accelerated-animation-removal-upon-transition-completion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-removal-upon-transition-completion.html
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/WebAnimation.cpp




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256355 => 256356)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:38:05 UTC (rev 256355)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:38:08 UTC (rev 256356)
@@ -1,5 +1,61 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r256181. rdar://problem/59335793
+
+There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
+https://bugs.webkit.org/show_bug.cgi?id=207361
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
+animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
+an active transform animation.
+
+To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
+KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
+WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.
+
+Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.
+
+* animation/AnimationEffect.h:
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::apply):
+(WebCore::KeyframeEffect::updateAcceleratedActions):
+(WebCore::KeyframeEffect::animationDidTick):
+(WebCore::KeyframeEffect::animationDidPlay):
+* animation/KeyframeEffect.h:
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::play):
+(WebCore::WebAnimation::tick):
+
+LayoutTests:
+
+Lower the number of frames to wait after an animation completes by one to check that the accelerated animation has been removed
+to show that we enqueue accelerated actions as part of the "update animations and send events" procedure.
+
+* webanimations/accelerated-animation-removal-upon-transition-completion.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-10  Antoine Quint  
+
+There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
+

[webkit-changes] [256350] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256350] branches/safari-609.1.17.0-branch








Revision 256350
Author repst...@apple.com
Date 2020-02-11 13:37:49 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r22. rdar://problem/59335812

ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
https://bugs.webkit.org/show_bug.cgi?id=207071


Patch by Antoine Quint  on 2020-02-02
Reviewed by Dean Jackson.

Source/WebCore:

We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
because we wouldn't know how to animate that CSS property.

* animation/AnimationTimeline.cpp:
(WebCore::compileTransitionPropertiesInStyle):

LayoutTests:

The crash is fixed, we can start running the test as expected again.

* platform/ipad/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.cpp




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256349 => 256350)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:46 UTC (rev 256349)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:49 UTC (rev 256350)
@@ -1,5 +1,44 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r22. rdar://problem/59335812
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Patch by Antoine Quint  on 2020-02-02
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
+because we wouldn't know how to animate that CSS property.
+
+* animation/AnimationTimeline.cpp:
+(WebCore::compileTransitionPropertiesInStyle):
+
+LayoutTests:
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-02  Antoine Quint  
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Reviewed by Dean Jackson.
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+2020-02-11  Russell Epstein  
+
 Cherry-pick r255525. rdar://problem/59335812
 
 [ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.


Modified: branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations (256349 => 256350)

--- branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 21:37:46 UTC (rev 256349)
+++ branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 21:37:49 UTC (rev 256350)
@@ -69,5 +69,3 @@
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-004.html [ Pass ]
 
 media/picture-in-picture [ Pass ]
-
-webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]
\ No newline at end of file


Modified: branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog (256349 => 256350)

--- branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog	2020-02-11 21:37:46 UTC (rev 256349)
+++ branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog	2020-02-11 21:37:49 UTC (rev 256350)
@@ -1,3 +1,44 @@
+2020-02-11  Russell Epstein  
+
+Cherry-pick r22. rdar://problem/59335812
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Patch by Antoine Quint  on 2020-02-02
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
+because we wouldn't know how to animate that CSS property.
+
+* animation/AnimationTimeline.cpp:
+(WebCore::compileTransitionPropertiesInStyle):
+
+LayoutTests:
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-02  Antoine Quint  
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(

[webkit-changes] [256349] branches/safari-609.1.17.0-branch/LayoutTests

2020-02-11 Thread repstein

Title: [256349] branches/safari-609.1.17.0-branch/LayoutTests








Revision 256349
Author repst...@apple.com
Date 2020-02-11 13:37:46 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255525. rdar://problem/59335812

[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=207071

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-31

* platform/ipad/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256348 => 256349)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:42 UTC (rev 256348)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:46 UTC (rev 256349)
@@ -1,3 +1,27 @@
+2020-02-11  Russell Epstein  
+
+Cherry-pick r255525. rdar://problem/59335812
+
+[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+Unreviewed test gardening.
+
+Patch by Jason Lawrence  on 2020-01-31
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-31  Jason Lawrence  
+
+[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+Unreviewed test gardening.
+
+* platform/ipad/TestExpectations:
+
 2020-02-05  Russell Epstein  
 
 Cherry-pick r255396. rdar://problem/59097789


Modified: branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations (256348 => 256349)

--- branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 21:37:42 UTC (rev 256348)
+++ branches/safari-609.1.17.0-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 21:37:46 UTC (rev 256349)
@@ -68,4 +68,6 @@
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-002.html [ Pass ]
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-004.html [ Pass ]
 
-media/picture-in-picture [ Pass ]
\ No newline at end of file
+media/picture-in-picture [ Pass ]
+
+webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256355] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256355] branches/safari-609.1.17.0-branch








Revision 256355
Author repst...@apple.com
Date 2020-02-11 13:38:05 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256095. rdar://problem/59335804

Extent of a composited animation should not include the untransformed position
https://bugs.webkit.org/show_bug.cgi?id=207434

Reviewed by Sam Weinig.
Source/WebCore:

To determine whether to create ("attach") backing store for layers with transform animations,
we compute the union of all the states of the animation as an "extent", and ask whether it intersects
the coverage rect in GraphicsLayerCA.

The non-Web Animations transition code did this correctly, just unioning the bounds transformed by
the start and end state.

The non-Web Animations keyframe code, and the Web Animations KeyframeEffect code (used for both CSS transitions
and animations) also unioned with the unanimated bounds, which could create overly large extents in some
cases, contributing to jetsams on iOS (rdar://problem/59020443).

Fix KeyframeAnimation and KeyframeEffect to not union with the untransformed bounds.

Tests: compositing/backing/backing-store-attachment-animating-outside-viewport.html
   legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::computeExtentOfTransformAnimation const):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::computeExtentOfTransformAnimation const):

LayoutTests:

New test that checks backing store attachment and overlap for an element which is positioned in-view,
but is move offscreen by the animation.

New baselines for overlap tests, since overlap no longer considers the unanimated position.

* compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* compositing/backing/backing-store-attachment-animating-outside-viewport.html: Added.
* compositing/layer-creation/translate-animation-overlap-expected.txt:
* compositing/layer-creation/translate-scale-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html: Added.
* legacy-animation-engine/compositing/layer-creation/translate-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap-expected.txt:
* platform/ios-wk2/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* platform/ios-wk2/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/LayoutTests/compositing/layer-creation/translate-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/layer-creation/translate-scale-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap-expected.txt
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/page/animation/KeyframeAnimation.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/backing-store-attachment-animating-outside-viewport.html
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256354 => 256355)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:38:00 UTC (rev 256354)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:38:05 UTC (rev 256355)

[webkit-changes] [256352] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256352] branches/safari-609.1.17.0-branch








Revision 256352
Author repst...@apple.com
Date 2020-02-11 13:37:57 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255663. rdar://problem/59335773

Accelerated animations freeze on render tree rebuild
https://bugs.webkit.org/show_bug.cgi?id=201048


Reviewed by Antoine Quint.

Source/WebCore:

If there is an accelerated animation in progress for a renderer and the render tree is rebuild the animation
does not continue with the new renderer.

To fix, make sure that the animation leaves the accelerated state when the renderer is removed. The new renderer
will then become accelerated automatically.

Original test case by Tim Guan-tin Chien.

Test: webanimations/accelerated-animation-renderer-change.html

* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::willChangeRendererForElement):
* animation/AnimationTimeline.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::willChangeRenderer):
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::willChangeRenderer):
* animation/WebAnimation.h:
* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):

LayoutTests:

* webanimations/accelerated-animation-renderer-change-expected.html: Added.
* webanimations/accelerated-animation-renderer-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/AnimationTimeline.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.0-branch/Source/WebCore/animation/WebAnimation.cpp
branches/safari-609.1.17.0-branch/Source/WebCore/animation/WebAnimation.h
branches/safari-609.1.17.0-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-renderer-change-expected.html
branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-renderer-change.html




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256351 => 256352)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:53 UTC (rev 256351)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:37:57 UTC (rev 256352)
@@ -1,5 +1,58 @@
 2020-02-11  Russell Epstein  
 
+Cherry-pick r255663. rdar://problem/59335773
+
+Accelerated animations freeze on render tree rebuild
+https://bugs.webkit.org/show_bug.cgi?id=201048
+
+
+Reviewed by Antoine Quint.
+
+Source/WebCore:
+
+If there is an accelerated animation in progress for a renderer and the render tree is rebuild the animation
+does not continue with the new renderer.
+
+To fix, make sure that the animation leaves the accelerated state when the renderer is removed. The new renderer
+will then become accelerated automatically.
+
+Original test case by Tim Guan-tin Chien.
+
+Test: webanimations/accelerated-animation-renderer-change.html
+
+* animation/AnimationTimeline.cpp:
+(WebCore::AnimationTimeline::willChangeRendererForElement):
+* animation/AnimationTimeline.h:
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::willChangeRenderer):
+* animation/KeyframeEffect.h:
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::willChangeRenderer):
+* animation/WebAnimation.h:
+* rendering/updating/RenderTreeUpdater.cpp:
+(WebCore::RenderTreeUpdater::tearDownRenderers):
+
+LayoutTests:
+
+* webanimations/accelerated-animation-renderer-change-expected.html: Added.
+* webanimations/accelerated-animation-renderer-change.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-03  Antti Koivisto  
+
+Accelerated animations freeze on render tree rebuild
+https://bugs.webkit.org/show_bug.cgi?id=201048
+
+
+Reviewed by Antoine Quint.
+
+* webanimations/accelerated-animation-renderer-change-expected.html: Added.
+* webanimations/accelerated-animation-renderer-change.html: Added.
+
+2020-02-11  Russell Epstein  
+
 Cherry-pick r255593. rdar://problem/59335802
 
 [Web Animations] Accelerated animations don't run until their natural completion


Added: branches/safari-609.1.17.0-branch/LayoutTests/webanimations/accelerated-animation-renderer-cha

[webkit-changes] [256357] branches/safari-609.1.17.0-branch

2020-02-11 Thread repstein

Title: [256357] branches/safari-609.1.17.0-branch








Revision 256357
Author repst...@apple.com
Date 2020-02-11 13:38:12 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256214. rdar://problem/59349590

WebContent jetsams on Sony lens webpage due to spike of IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=207493
rdar://problem/59020443

Reviewed by Zalan Bujtas.
Source/WebCore:

There were three issues that contributed to massive backing store allocation on
.

The first, fixed in r256095, was that the Web Animations code unioned the untransitioning
bounds with the transitioning bounds, causing the computation of large extent rects.

The second, fixed in r256181, was that GraphicsLayerCA would keep hold of a transform
animation for an extra frame, causing a rendering update where
RenderLayerBacking::updateGeometry() would have cleared the extent, but GraphicsLayerCA
still thought transform was animating, causing GraphicsLayerCA::updateCoverage() to keep
backing store attached.

This patch is the final fix; when animations start and end, we need to ensure that
RenderLayerBacking::updateGeometry() is called so that we compute the animation extent in
the same frame that adds the animation.

Test: compositing/backing/transition-extent.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::animationFinished):

LayoutTests:

Test with an out-of-view transitioning element which should not get backing store.

* compositing/backing/transition-extent-expected.txt: Added.
* compositing/backing/transition-extent.html: Added.
* platform/ios-wk2/compositing/backing/transition-extent-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.0-branch/Source/WebCore/rendering/RenderLayerBacking.cpp


Added Paths

branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/transition-extent-expected.txt
branches/safari-609.1.17.0-branch/LayoutTests/compositing/backing/transition-extent.html
branches/safari-609.1.17.0-branch/LayoutTests/platform/ios-wk2/compositing/backing/transition-extent-expected.txt




Diff

Modified: branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog (256356 => 256357)

--- branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:38:08 UTC (rev 256356)
+++ branches/safari-609.1.17.0-branch/LayoutTests/ChangeLog	2020-02-11 21:38:12 UTC (rev 256357)
@@ -1,59 +1,102 @@
 2020-02-11  Russell Epstein  
 
-Cherry-pick r256181. rdar://problem/59335793
+Cherry-pick r256214. rdar://problem/59349590
 
-There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
-https://bugs.webkit.org/show_bug.cgi?id=207361
-
+WebContent jetsams on Sony lens webpage due to spike of IOSurfaces
+https://bugs.webkit.org/show_bug.cgi?id=207493
+rdar://problem/59020443
 
-Reviewed by Simon Fraser.
-
+Reviewed by Zalan Bujtas.
 Source/WebCore:
 
-Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
-animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
-an active transform animation.
+There were three issues that contributed to massive backing store allocation on
+.
 
-To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
-KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
-WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.
+The first, fixed in r256095, was that the Web Animations code unioned the untransitioning
+bounds with the transitioning bounds, causing the computation of large extent rects.
 
-Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.
+The second, fixed in r256181, was that GraphicsLayerCA would keep hold of a transform
+animation for an extra frame, causing a rendering update where
+RenderLayerBacking::updateGeometry() would have cleared the extent, but GraphicsLayerCA
+still thought transform was animating, causing GraphicsLayerCA::updateCoverage() to keep
+backing store attached.
 
-* animation/AnimationEffect.h:
-* animation/KeyframeEffect.cpp:
-(WebCore::KeyframeEffect::apply):
-(WebCore::KeyframeEffect::updateAcceleratedActions):
-(WebCore::KeyframeEffect::animationDidTick):
-(WebCore::KeyframeEffect::animationDidPlay):
-* animation/KeyframeEffect.h:
-

[webkit-changes] [256359] tags/Safari-610.1.1.4.3/

2020-02-11 Thread alancoon

Title: [256359] tags/Safari-610.1.1.4.3/








Revision 256359
Author alanc...@apple.com
Date 2020-02-11 13:39:35 -0800 (Tue, 11 Feb 2020)


Log Message
Tag Safari-610.1.1.4.3.

Added Paths

tags/Safari-610.1.1.4.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256360] trunk

2020-02-11 Thread megan_gardner

Title: [256360] trunk








Revision 256360
Author megan_gard...@apple.com
Date 2020-02-11 13:53:01 -0800 (Tue, 11 Feb 2020)


Log Message
Draw underlines when specified in highlights
https://bugs.webkit.org/show_bug.cgi?id=207319

Reviewed by Simon Fraser.

Source/WebCore:

Test: http/wpt/css/css-highlight-api/highlight-text-decorations.html

When determining if we have any text decorations, currently we were only looking at the lineStyle,
but since highlights can have text decorations, they need to be considered in these calculations.

* dom/Document.cpp:
(WebCore::Document::updateHighlightPositions):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::collectMarkedTextsForHighlights const):
(WebCore::InlineTextBox::paintMarkedTextDecoration):
* rendering/TextDecorationPainter.cpp:
(WebCore::TextDecorationPainter::textDecorationsInEffectForStyle):
* rendering/TextDecorationPainter.h:

LayoutTests:

* http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html: Copied from LayoutTests/http/wpt/css/css-highlight-api/highlight-text-expected.html.
* http/wpt/css/css-highlight-api/highlight-text-decorations.html: Added.
* http/wpt/css/css-highlight-api/highlight-text-expected.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineTextBox.cpp
trunk/Source/WebCore/rendering/TextDecorationPainter.cpp
trunk/Source/WebCore/rendering/TextDecorationPainter.h


Added Paths

trunk/LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html
trunk/LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations.html




Diff

Modified: trunk/LayoutTests/ChangeLog (256359 => 256360)

--- trunk/LayoutTests/ChangeLog	2020-02-11 21:39:35 UTC (rev 256359)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 21:53:01 UTC (rev 256360)
@@ -1,3 +1,14 @@
+2020-02-11  Megan Gardner  
+
+Draw underlines when specified in highlights
+https://bugs.webkit.org/show_bug.cgi?id=207319
+
+Reviewed by Simon Fraser.
+
+* http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html: Copied from LayoutTests/http/wpt/css/css-highlight-api/highlight-text-expected.html.
+* http/wpt/css/css-highlight-api/highlight-text-decorations.html: Added.
+* http/wpt/css/css-highlight-api/highlight-text-expected.html:
+
 2020-02-11  Eric Carlson  
 
 Support in-band VTT captions when loading media in the GPU Process


Added: trunk/LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html (0 => 256360)

--- trunk/LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html	(rev 0)
+++ trunk/LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html	2020-02-11 21:53:01 UTC (rev 256360)
@@ -0,0 +1,35 @@
+
+
+
+
+html { 
+font-size: 24pt;
+}
+.style1 {
+text-decoration: underline;
+}
+/* FIXME: There is a discrepency for how the underlines are displayed at the end of the line, leading to a pixel different in this text. Find a real fix, but in the meantime, obscure the offending pixel  https://bugs.webkit.org/show_bug.cgi?id=207512*/
+.obscurer1 {
+  position: absolute;
+  top: 35px;
+  left: 100px;
+  width: 10px;
+  height: 10px;
+  background: grey;
+}
+.obscurer2 {
+  position: absolute;
+  top: 35px;
+  left: 180px;
+  width: 10px;
+  height: 10px;
+  background: grey;
+}
+
+
+
+One two three
+
+
+
+


Added: trunk/LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations.html (0 => 256360)

--- trunk/LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations.html	(rev 0)
+++ trunk/LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations.html	2020-02-11 21:53:01 UTC (rev 256360)
@@ -0,0 +1,48 @@
+
+
+
+
+Text decorations in custom highlight pseudo elements.
+
+
+html {
+font-size: 24pt;
+}
+::highlight(example-highlight1) {
+text-decoration: underline;
+}
+/* FIXME: There is a discrepency for how the underlines are displayed at the end of the line, leading to a pixel different in this text. Find a real fix, but in the meantime, obscure the offending pixel https://bugs.webkit.org/show_bug.cgi?id=207512  */
+.obscurer1 {
+  position: absolute;
+  top: 35px;
+  left: 100px;
+  width: 10px;
+  height: 10px;
+  background: grey;
+}
+.obscurer2 {
+  position: absolute;
+  top: 35px;
+  left: 180px;
+  width: 10px;
+

[webkit-changes] [256361] branches/safari-609.1.17.1-branch/Source

2020-02-11 Thread alancoon

Title: [256361] branches/safari-609.1.17.1-branch/Source








Revision 256361
Author alanc...@apple.com
Date 2020-02-11 13:55:17 -0800 (Tue, 11 Feb 2020)


Log Message
Versioning.

Modified Paths

branches/safari-609.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-609.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-609.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-609.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-609.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-609.1.17.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-609.1.17.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-609.1.17.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-609.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (256360 => 256361)

--- branches/safari-609.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-11 21:53:01 UTC (rev 256360)
+++ branches/safari-609.1.17.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-02-11 21:55:17 UTC (rev 256361)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (256360 => 256361)

--- branches/safari-609.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-11 21:53:01 UTC (rev 256360)
+++ branches/safari-609.1.17.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-02-11 21:55:17 UTC (rev 256361)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (256360 => 256361)

--- branches/safari-609.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-11 21:53:01 UTC (rev 256360)
+++ branches/safari-609.1.17.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-02-11 21:55:17 UTC (rev 256361)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig (256360 => 256361)

--- branches/safari-609.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-11 21:53:01 UTC (rev 256360)
+++ branches/safari-609.1.17.1-branch/Source/WebCore/Configurations/Version.xcconfig	2020-02-11 21:55:17 UTC (rev 256361)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-609.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (256360 => 256361)

--- branches/safari-609.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-11 21:53:01 UTC (rev 256360)
+++ branches/safari-609.1.17.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-02-11 21:55:17 UTC (rev 256361)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 609;
 MINOR_VERSION = 1;
 TINY_VERSION = 17;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(

[webkit-changes] [256367] branches/safari-609.1.17.1-branch

2020-02-11 Thread alancoon

Title: [256367] branches/safari-609.1.17.1-branch








Revision 256367
Author alanc...@apple.com
Date 2020-02-11 14:03:25 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256095. rdar://problem/59349202

Extent of a composited animation should not include the untransformed position
https://bugs.webkit.org/show_bug.cgi?id=207434

Reviewed by Sam Weinig.
Source/WebCore:

To determine whether to create ("attach") backing store for layers with transform animations,
we compute the union of all the states of the animation as an "extent", and ask whether it intersects
the coverage rect in GraphicsLayerCA.

The non-Web Animations transition code did this correctly, just unioning the bounds transformed by
the start and end state.

The non-Web Animations keyframe code, and the Web Animations KeyframeEffect code (used for both CSS transitions
and animations) also unioned with the unanimated bounds, which could create overly large extents in some
cases, contributing to jetsams on iOS (rdar://problem/59020443).

Fix KeyframeAnimation and KeyframeEffect to not union with the untransformed bounds.

Tests: compositing/backing/backing-store-attachment-animating-outside-viewport.html
   legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::computeExtentOfTransformAnimation const):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::computeExtentOfTransformAnimation const):

LayoutTests:

New test that checks backing store attachment and overlap for an element which is positioned in-view,
but is move offscreen by the animation.

New baselines for overlap tests, since overlap no longer considers the unanimated position.

* compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* compositing/backing/backing-store-attachment-animating-outside-viewport.html: Added.
* compositing/layer-creation/translate-animation-overlap-expected.txt:
* compositing/layer-creation/translate-scale-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html: Added.
* legacy-animation-engine/compositing/layer-creation/translate-animation-overlap-expected.txt:
* legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap-expected.txt:
* platform/ios-wk2/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.
* platform/ios-wk2/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.1-branch/LayoutTests/compositing/layer-creation/translate-animation-overlap-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/compositing/layer-creation/translate-scale-animation-overlap-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-animation-overlap-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/legacy-animation-engine/compositing/layer-creation/translate-scale-animation-overlap-expected.txt
branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.1-branch/Source/WebCore/page/animation/KeyframeAnimation.cpp


Added Paths

branches/safari-609.1.17.1-branch/LayoutTests/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/compositing/backing/backing-store-attachment-animating-outside-viewport.html
branches/safari-609.1.17.1-branch/LayoutTests/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport.html
branches/safari-609.1.17.1-branch/LayoutTests/platform/ios-wk2/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/platform/ios-wk2/legacy-animation-engine/compositing/
branches/safari-609.1.17.1-branch/LayoutTests/platform/ios-wk2/legacy-animation-engine/compositing/backing/
branches/safari-609.1.17.1-branch/LayoutTests/platform/ios-wk2/legacy-animation-engine/compositing/backing/backing-store-attachment-animating-outside-viewport-expected.txt




Diff

Modified: branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog (25636

[webkit-changes] [256366] branches/safari-609.1.17.1-branch

2020-02-11 Thread alancoon

Title: [256366] branches/safari-609.1.17.1-branch








Revision 256366
Author alanc...@apple.com
Date 2020-02-11 14:03:18 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255810. rdar://problem/59349189

[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
https://bugs.webkit.org/show_bug.cgi?id=207253


Reviewed by Antti Koivisto.

Source/WebCore:

Test: webanimations/accelerated-animation-canceled-before-commit.html

Merely checking whether an accelerated animation is running prior to enqueuing an action to cancel it is not sufficient
since there could be an uncommitted change to start it upon the next animation frame. The same logic would need to apply
in other situations where the playback state changes for a potentially in-flight animation.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::animationDidSeek):
(WebCore::KeyframeEffect::animationWasCanceled):
(WebCore::KeyframeEffect::willChangeRenderer):
(WebCore::KeyframeEffect::animationSuspensionStateDidChange):

LayoutTests:

Add a new test that checks that an accelerated animation that has been enqueued to start but has
not yet been committed is correctly canceled when the cancel() method is called. This test fails
prior to this source change.

* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
* webanimations/accelerated-animation-canceled-before-commit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffect.cpp


Added Paths

branches/safari-609.1.17.1-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit-expected.html
branches/safari-609.1.17.1-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit.html




Diff

Modified: branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog (256365 => 256366)

--- branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:12 UTC (rev 256365)
+++ branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:18 UTC (rev 256366)
@@ -1,5 +1,55 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255810. rdar://problem/59349189
+
+[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
+https://bugs.webkit.org/show_bug.cgi?id=207253
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+Test: webanimations/accelerated-animation-canceled-before-commit.html
+
+Merely checking whether an accelerated animation is running prior to enqueuing an action to cancel it is not sufficient
+since there could be an uncommitted change to start it upon the next animation frame. The same logic would need to apply
+in other situations where the playback state changes for a potentially in-flight animation.
+
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::animationDidSeek):
+(WebCore::KeyframeEffect::animationWasCanceled):
+(WebCore::KeyframeEffect::willChangeRenderer):
+(WebCore::KeyframeEffect::animationSuspensionStateDidChange):
+
+LayoutTests:
+
+Add a new test that checks that an accelerated animation that has been enqueued to start but has
+not yet been committed is correctly canceled when the cancel() method is called. This test fails
+prior to this source change.
+
+* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
+* webanimations/accelerated-animation-canceled-before-commit.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-05  Antoine Quint  
+
+[Web Animations] Canceling an accelerated animation before it was committed does not prevent it from playing
+https://bugs.webkit.org/show_bug.cgi?id=207253
+
+
+Reviewed by Antti Koivisto.
+
+Add a new test that checks that an accelerated animation that has been enqueued to start but has
+not yet been committed is correctly canceled when the cancel() method is called. This test fails
+prior to this source change.
+
+* webanimations/accelerated-animation-canceled-before-commit-expected.html: Added.
+* webanimations/accelerated-animation-canceled-before-commit.html: Added.
+
+2020-02-11  Alan Coon  
+
 Cherry-pick r255663. rdar://problem/59349185
 
 Accelerated animations freeze on render tree rebuild


Added: branches/safari-609.1.17.1-branch/LayoutTests/webanimations/accelerated-animation-canceled-before-commit-expected.html (0 => 256366)

--- branches

[webkit-changes] [256364] branches/safari-609.1.17.1-branch

2020-02-11 Thread alancoon

Title: [256364] branches/safari-609.1.17.1-branch








Revision 256364
Author alanc...@apple.com
Date 2020-02-11 14:03:08 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255593. rdar://problem/59349198

[Web Animations] Accelerated animations don't run until their natural completion
https://bugs.webkit.org/show_bug.cgi?id=207130


Reviewed by Dean Jackson.

Source/WebCore:

Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html
   webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html

Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
The accelerated animations will be queued for removal in the next animation frame.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
* animation/KeyframeEffect.h:
* animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):

LayoutTests:

Add two new tests that ensures that an accelerated animation still yields compositing on an element when
its finished promise is resolved, but that it's no longer the case on the next frame.

This required an existing test to be updated to wait until the next frame before checking the composited
status of an element on which an animation had just completed.

* compositing/geometry/limit-layer-bounds-opacity-transition.html:
* webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
* webanimations/transform-accelerated-animation-finishes-before-removal.html: Added.
* webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt: Added.
* webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.1-branch/LayoutTests/compositing/geometry/limit-layer-bounds-opacity-transition.html
branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffectStack.cpp


Added Paths

branches/safari-609.1.17.1-branch/LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/webanimations/transform-accelerated-animation-finishes-before-removal.html
branches/safari-609.1.17.1-branch/LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html




Diff

Modified: branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog (256363 => 256364)

--- branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:03 UTC (rev 256363)
+++ branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:08 UTC (rev 256364)
@@ -1,5 +1,65 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255593. rdar://problem/59349198
+
+[Web Animations] Accelerated animations don't run until their natural completion
+https://bugs.webkit.org/show_bug.cgi?id=207130
+
+
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html
+   webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html
+
+Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
+The accelerated animations will be queued for removal in the next animation frame.
+
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
+* animation/KeyframeEffect.h:
+* animation/KeyframeEffectStack.cpp:
+(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):
+
+LayoutTests:
+
+Add two new tests that ensures that an accelerated animation still yields compositing on an element when
+its finished promise is resolved, but that it's no longer the case on the next frame.
+
+This required an existing test to be updated to wait until the next frame before checking the composited
+status of an element on which an animation had just completed.
+
+* compositing/geometry/limit-layer-bounds-opacity-transition.html:
+* webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
+* webanimations/transform-accelerated-animation-finishe

[webkit-changes] [256363] branches/safari-609.1.17.1-branch

2020-02-11 Thread alancoon

Title: [256363] branches/safari-609.1.17.1-branch








Revision 256363
Author alanc...@apple.com
Date 2020-02-11 14:03:03 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r22. rdar://problem/59349213

ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
https://bugs.webkit.org/show_bug.cgi?id=207071


Patch by Antoine Quint  on 2020-02-02
Reviewed by Dean Jackson.

Source/WebCore:

We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
because we wouldn't know how to animate that CSS property.

* animation/AnimationTimeline.cpp:
(WebCore::compileTransitionPropertiesInStyle):

LayoutTests:

The crash is fixed, we can start running the test as expected again.

* platform/ipad/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.1-branch/LayoutTests/platform/ipad/TestExpectations
branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/animation/AnimationTimeline.cpp




Diff

Modified: branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog (256362 => 256363)

--- branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:02:57 UTC (rev 256362)
+++ branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:03 UTC (rev 256363)
@@ -1,5 +1,44 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r22. rdar://problem/59349213
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Patch by Antoine Quint  on 2020-02-02
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
+because we wouldn't know how to animate that CSS property.
+
+* animation/AnimationTimeline.cpp:
+(WebCore::compileTransitionPropertiesInStyle):
+
+LayoutTests:
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-02  Antoine Quint  
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Reviewed by Dean Jackson.
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+2020-02-11  Alan Coon  
+
 Cherry-pick r255525. rdar://problem/59349213
 
 [ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.


Modified: branches/safari-609.1.17.1-branch/LayoutTests/platform/ipad/TestExpectations (256362 => 256363)

--- branches/safari-609.1.17.1-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 22:02:57 UTC (rev 256362)
+++ branches/safari-609.1.17.1-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 22:03:03 UTC (rev 256363)
@@ -69,5 +69,3 @@
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-004.html [ Pass ]
 
 media/picture-in-picture [ Pass ]
-
-webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]
\ No newline at end of file


Modified: branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog (256362 => 256363)

--- branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog	2020-02-11 22:02:57 UTC (rev 256362)
+++ branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog	2020-02-11 22:03:03 UTC (rev 256363)
@@ -1,3 +1,44 @@
+2020-02-11  Alan Coon  
+
+Cherry-pick r22. rdar://problem/59349213
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animations/keyframe-autoclose-brace.html
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+
+Patch by Antoine Quint  on 2020-02-02
+Reviewed by Dean Jackson.
+
+Source/WebCore:
+
+We cannot add CSSPropertyInvalid to a HashSet, because it triggers an ASSERT, and also we shouldn't
+because we wouldn't know how to animate that CSS property.
+
+* animation/AnimationTimeline.cpp:
+(WebCore::compileTransitionPropertiesInStyle):
+
+LayoutTests:
+
+The crash is fixed, we can start running the test as expected again.
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-02  Antoine Quint  
+
+ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) on animati

[webkit-changes] [256362] branches/safari-609.1.17.1-branch/LayoutTests

2020-02-11 Thread alancoon

Title: [256362] branches/safari-609.1.17.1-branch/LayoutTests








Revision 256362
Author alanc...@apple.com
Date 2020-02-11 14:02:57 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255525. rdar://problem/59349213

[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
https://bugs.webkit.org/show_bug.cgi?id=207071

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-31

* platform/ipad/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.1-branch/LayoutTests/platform/ipad/TestExpectations




Diff

Modified: branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog (256361 => 256362)

--- branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 21:55:17 UTC (rev 256361)
+++ branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:02:57 UTC (rev 256362)
@@ -1,3 +1,27 @@
+2020-02-11  Alan Coon  
+
+Cherry-pick r255525. rdar://problem/59349213
+
+[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+Unreviewed test gardening.
+
+Patch by Jason Lawrence  on 2020-01-31
+
+* platform/ipad/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-31  Jason Lawrence  
+
+[ iOS Debug wk2 ] animations/keyframe-autoclose-brace.html is flaky crashing.
+https://bugs.webkit.org/show_bug.cgi?id=207071
+
+Unreviewed test gardening.
+
+* platform/ipad/TestExpectations:
+
 2020-02-05  Russell Epstein  
 
 Cherry-pick r255396. rdar://problem/59097789


Modified: branches/safari-609.1.17.1-branch/LayoutTests/platform/ipad/TestExpectations (256361 => 256362)

--- branches/safari-609.1.17.1-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 21:55:17 UTC (rev 256361)
+++ branches/safari-609.1.17.1-branch/LayoutTests/platform/ipad/TestExpectations	2020-02-11 22:02:57 UTC (rev 256362)
@@ -68,4 +68,6 @@
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-002.html [ Pass ]
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-004.html [ Pass ]
 
-media/picture-in-picture [ Pass ]
\ No newline at end of file
+media/picture-in-picture [ Pass ]
+
+webkit.org/b/207071 [ Debug ] animations/keyframe-autoclose-brace.html [ Pass Crash ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256365] branches/safari-609.1.17.1-branch

2020-02-11 Thread alancoon

Title: [256365] branches/safari-609.1.17.1-branch








Revision 256365
Author alanc...@apple.com
Date 2020-02-11 14:03:12 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255663. rdar://problem/59349185

Accelerated animations freeze on render tree rebuild
https://bugs.webkit.org/show_bug.cgi?id=201048


Reviewed by Antoine Quint.

Source/WebCore:

If there is an accelerated animation in progress for a renderer and the render tree is rebuild the animation
does not continue with the new renderer.

To fix, make sure that the animation leaves the accelerated state when the renderer is removed. The new renderer
will then become accelerated automatically.

Original test case by Tim Guan-tin Chien.

Test: webanimations/accelerated-animation-renderer-change.html

* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::willChangeRendererForElement):
* animation/AnimationTimeline.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::willChangeRenderer):
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::willChangeRenderer):
* animation/WebAnimation.h:
* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):

LayoutTests:

* webanimations/accelerated-animation-renderer-change-expected.html: Added.
* webanimations/accelerated-animation-renderer-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/animation/AnimationTimeline.cpp
branches/safari-609.1.17.1-branch/Source/WebCore/animation/AnimationTimeline.h
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.1-branch/Source/WebCore/animation/WebAnimation.cpp
branches/safari-609.1.17.1-branch/Source/WebCore/animation/WebAnimation.h
branches/safari-609.1.17.1-branch/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp


Added Paths

branches/safari-609.1.17.1-branch/LayoutTests/webanimations/accelerated-animation-renderer-change-expected.html
branches/safari-609.1.17.1-branch/LayoutTests/webanimations/accelerated-animation-renderer-change.html




Diff

Modified: branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog (256364 => 256365)

--- branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:08 UTC (rev 256364)
+++ branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:12 UTC (rev 256365)
@@ -1,5 +1,58 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255663. rdar://problem/59349185
+
+Accelerated animations freeze on render tree rebuild
+https://bugs.webkit.org/show_bug.cgi?id=201048
+
+
+Reviewed by Antoine Quint.
+
+Source/WebCore:
+
+If there is an accelerated animation in progress for a renderer and the render tree is rebuild the animation
+does not continue with the new renderer.
+
+To fix, make sure that the animation leaves the accelerated state when the renderer is removed. The new renderer
+will then become accelerated automatically.
+
+Original test case by Tim Guan-tin Chien.
+
+Test: webanimations/accelerated-animation-renderer-change.html
+
+* animation/AnimationTimeline.cpp:
+(WebCore::AnimationTimeline::willChangeRendererForElement):
+* animation/AnimationTimeline.h:
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::willChangeRenderer):
+* animation/KeyframeEffect.h:
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::willChangeRenderer):
+* animation/WebAnimation.h:
+* rendering/updating/RenderTreeUpdater.cpp:
+(WebCore::RenderTreeUpdater::tearDownRenderers):
+
+LayoutTests:
+
+* webanimations/accelerated-animation-renderer-change-expected.html: Added.
+* webanimations/accelerated-animation-renderer-change.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-03  Antti Koivisto  
+
+Accelerated animations freeze on render tree rebuild
+https://bugs.webkit.org/show_bug.cgi?id=201048
+
+
+Reviewed by Antoine Quint.
+
+* webanimations/accelerated-animation-renderer-change-expected.html: Added.
+* webanimations/accelerated-animation-renderer-change.html: Added.
+
+2020-02-11  Alan Coon  
+
 Cherry-pick r255593. rdar://problem/59349198
 
 [Web Animations] Accelerated animations don't run until their natural completion


Added: branches/safari-609.1.17.1-branch/LayoutTests/webanimations/accelerated-animation-renderer-change-expected

[webkit-changes] [256368] branches/safari-609.1.17.1-branch

2020-02-11 Thread alancoon

Title: [256368] branches/safari-609.1.17.1-branch








Revision 256368
Author alanc...@apple.com
Date 2020-02-11 14:03:29 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256181. rdar://problem/59349184

There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=207361


Reviewed by Simon Fraser.

Source/WebCore:

Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
an active transform animation.

To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.

Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.

* animation/AnimationEffect.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::updateAcceleratedActions):
(WebCore::KeyframeEffect::animationDidTick):
(WebCore::KeyframeEffect::animationDidPlay):
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::play):
(WebCore::WebAnimation::tick):

LayoutTests:

Lower the number of frames to wait after an animation completes by one to check that the accelerated animation has been removed
to show that we enqueue accelerated actions as part of the "update animations and send events" procedure.

* webanimations/accelerated-animation-removal-upon-transition-completion.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.1-branch/LayoutTests/webanimations/accelerated-animation-removal-upon-transition-completion.html
branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/animation/AnimationEffect.h
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffect.cpp
branches/safari-609.1.17.1-branch/Source/WebCore/animation/KeyframeEffect.h
branches/safari-609.1.17.1-branch/Source/WebCore/animation/WebAnimation.cpp




Diff

Modified: branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog (256367 => 256368)

--- branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:25 UTC (rev 256367)
+++ branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:29 UTC (rev 256368)
@@ -1,5 +1,61 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r256181. rdar://problem/59349184
+
+There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
+https://bugs.webkit.org/show_bug.cgi?id=207361
+
+
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
+animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
+an active transform animation.
+
+To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
+KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
+WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.
+
+Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.
+
+* animation/AnimationEffect.h:
+* animation/KeyframeEffect.cpp:
+(WebCore::KeyframeEffect::apply):
+(WebCore::KeyframeEffect::updateAcceleratedActions):
+(WebCore::KeyframeEffect::animationDidTick):
+(WebCore::KeyframeEffect::animationDidPlay):
+* animation/KeyframeEffect.h:
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::play):
+(WebCore::WebAnimation::tick):
+
+LayoutTests:
+
+Lower the number of frames to wait after an animation completes by one to check that the accelerated animation has been removed
+to show that we enqueue accelerated actions as part of the "update animations and send events" procedure.
+
+* webanimations/accelerated-animation-removal-upon-transition-completion.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-10  Antoine Quint  
+
+There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
+http

[webkit-changes] [256369] branches/safari-609.1.17.1-branch

2020-02-11 Thread alancoon

Title: [256369] branches/safari-609.1.17.1-branch








Revision 256369
Author alanc...@apple.com
Date 2020-02-11 14:03:33 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r256214. rdar://problem/59349205

WebContent jetsams on Sony lens webpage due to spike of IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=207493
rdar://problem/59020443

Reviewed by Zalan Bujtas.
Source/WebCore:

There were three issues that contributed to massive backing store allocation on
.

The first, fixed in r256095, was that the Web Animations code unioned the untransitioning
bounds with the transitioning bounds, causing the computation of large extent rects.

The second, fixed in r256181, was that GraphicsLayerCA would keep hold of a transform
animation for an extra frame, causing a rendering update where
RenderLayerBacking::updateGeometry() would have cleared the extent, but GraphicsLayerCA
still thought transform was animating, causing GraphicsLayerCA::updateCoverage() to keep
backing store attached.

This patch is the final fix; when animations start and end, we need to ensure that
RenderLayerBacking::updateGeometry() is called so that we compute the animation extent in
the same frame that adds the animation.

Test: compositing/backing/transition-extent.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::animationFinished):

LayoutTests:

Test with an out-of-view transitioning element which should not get backing store.

* compositing/backing/transition-extent-expected.txt: Added.
* compositing/backing/transition-extent.html: Added.
* platform/ios-wk2/compositing/backing/transition-extent-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/ChangeLog
branches/safari-609.1.17.1-branch/Source/WebCore/rendering/RenderLayerBacking.cpp


Added Paths

branches/safari-609.1.17.1-branch/LayoutTests/compositing/backing/transition-extent-expected.txt
branches/safari-609.1.17.1-branch/LayoutTests/compositing/backing/transition-extent.html
branches/safari-609.1.17.1-branch/LayoutTests/platform/ios-wk2/compositing/backing/transition-extent-expected.txt




Diff

Modified: branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog (256368 => 256369)

--- branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:29 UTC (rev 256368)
+++ branches/safari-609.1.17.1-branch/LayoutTests/ChangeLog	2020-02-11 22:03:33 UTC (rev 256369)
@@ -1,59 +1,102 @@
 2020-02-11  Alan Coon  
 
-Cherry-pick r256181. rdar://problem/59349184
+Cherry-pick r256214. rdar://problem/59349205
 
-There's an event loop cycle between an animation finishing, and it being removed from GraphicsLayerCA
-https://bugs.webkit.org/show_bug.cgi?id=207361
-
+WebContent jetsams on Sony lens webpage due to spike of IOSurfaces
+https://bugs.webkit.org/show_bug.cgi?id=207493
+rdar://problem/59020443
 
-Reviewed by Simon Fraser.
-
+Reviewed by Zalan Bujtas.
 Source/WebCore:
 
-Animations should be removed from GraphicsLayersCAs in the same rendering update that changes the playState of the
-animation to "finished", to avoid layer flush where a GraphicsLayersCAs has no extent set, but thinks there is
-an active transform animation.
+There were three issues that contributed to massive backing store allocation on
+.
 
-To do this, instead of enqueuing accelerated actions when resolving animations during style resolution, in
-KeyframeAnimation::apply(), we enqueue them as soon as an animation's current time may have changed: in
-WebAnimation::tick() and WebAnimation::play() with supporting functions newly exposed on AnimationEffect.
+The first, fixed in r256095, was that the Web Animations code unioned the untransitioning
+bounds with the transitioning bounds, causing the computation of large extent rects.
 
-Now, accelerated animations are enqueued and applied during the "update animations and send events" procedure.
+The second, fixed in r256181, was that GraphicsLayerCA would keep hold of a transform
+animation for an extra frame, causing a rendering update where
+RenderLayerBacking::updateGeometry() would have cleared the extent, but GraphicsLayerCA
+still thought transform was animating, causing GraphicsLayerCA::updateCoverage() to keep
+backing store attached.
 
-* animation/AnimationEffect.h:
-* animation/KeyframeEffect.cpp:
-(WebCore::KeyframeEffect::apply):
-(WebCore::KeyframeEffect::updateAcceleratedActions):
-(WebCore::KeyframeEffect::animationDidTick):
-(WebCore::KeyframeEffect::animationDidPlay):
-* animation/KeyframeEffect.h:
-* a

[webkit-changes] [256370] trunk/LayoutTests

2020-02-11 Thread lawrence . j

Title: [256370] trunk/LayoutTests








Revision 256370
Author lawrenc...@apple.com
Date 2020-02-11 14:13:15 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS wk2 ] http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207583

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256369 => 256370)

--- trunk/LayoutTests/ChangeLog	2020-02-11 22:03:33 UTC (rev 256369)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 22:13:15 UTC (rev 256370)
@@ -1,3 +1,12 @@
+2020-02-11  Jason Lawrence  
+
+[ iOS wk2 ] http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=207583
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2020-02-11  Megan Gardner  
 
 Draw underlines when specified in highlights


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256369 => 256370)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 22:03:33 UTC (rev 256369)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 22:13:15 UTC (rev 256370)
@@ -1398,4 +1398,6 @@
 
 webkit.org/b/207555 imported/w3c/IndexedDB-private-browsing/idbcursor_update_objectstore8.html [ Pass Timeout ]
 
-webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
+
+webkit.org/b/207583 http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256371] trunk

2020-02-11 Thread pvollan

Title: [256371] trunk








Revision 256371
Author pvol...@apple.com
Date 2020-02-11 14:22:23 -0800 (Tue, 11 Feb 2020)


Log Message
[iOS] Deny mach lookup access to the tccd service in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=207488

Reviewed by Darin Adler.

Source/WebKit:

As part of sandbox hardening, deny mach lookup access to the tccd service.

Test: fast/sandbox/ios/sandbox-mach-lookup.html

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
* fast/sandbox/ios/sandbox-mach-lookup.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt
trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb




Diff

Modified: trunk/LayoutTests/ChangeLog (256370 => 256371)

--- trunk/LayoutTests/ChangeLog	2020-02-11 22:13:15 UTC (rev 256370)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 22:22:23 UTC (rev 256371)
@@ -1,3 +1,13 @@
+2020-02-11  Per Arne Vollan  
+
+[iOS] Deny mach lookup access to the tccd service in the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=207488
+
+Reviewed by Darin Adler.
+
+* fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
+* fast/sandbox/ios/sandbox-mach-lookup.html:
+
 2020-02-11  Jason Lawrence  
 
 [ iOS wk2 ] http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html is flaky failing.


Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt (256370 => 256371)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-02-11 22:13:15 UTC (rev 256370)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup-expected.txt	2020-02-11 22:22:23 UTC (rev 256371)
@@ -17,4 +17,4 @@
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.powerlog.plxpclogger.xpc") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.system.logger") is false
 PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.aggregated") is false
-
+PASS internals.hasSandboxMachLookupAccessToGlobalName("com.apple.WebKit.WebContent", "com.apple.tccd") is false


Modified: trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html (256370 => 256371)

--- trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-02-11 22:13:15 UTC (rev 256370)
+++ trunk/LayoutTests/fast/sandbox/ios/sandbox-mach-lookup.html	2020-02-11 22:22:23 UTC (rev 256371)
@@ -20,6 +20,7 @@
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.powerlog.plxpclogger.xpc\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.system.logger\")");
 shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.aggregated\")");
+shouldBeFalse("internals.hasSandboxMachLookupAccessToGlobalName(\"com.apple.WebKit.WebContent\", \"com.apple.tccd\")");
 }
 
 


Modified: trunk/Source/WebKit/ChangeLog (256370 => 256371)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 22:13:15 UTC (rev 256370)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 22:22:23 UTC (rev 256371)
@@ -1,3 +1,16 @@
+2020-02-11  Per Arne Vollan  
+
+[iOS] Deny mach lookup access to the tccd service in the WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=207488
+
+Reviewed by Darin Adler.
+
+As part of sandbox hardening, deny mach lookup access to the tccd service.
+
+Test: fast/sandbox/ios/sandbox-mach-lookup.html
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
 2020-02-11  Eric Carlson  
 
 Support in-band VTT captions when loading media in the GPU Process


Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (256370 => 256371)

--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-02-11 22:13:15 UTC (rev 256370)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-02-11 22:22:23 UTC (rev 256371)
@@ -605,8 +605,7 @@
 (global-name "com.apple.cfprefsd.daemon"))
 
 (allow mach-lookup (with report) (with telemetry)
-(global-name "com.apple.distributed_notifications@1v3")
-(global-name "com.apple.tccd"))
+(global-name "com.apple.distributed_notifications@1v3"))
 
 (allow ipc-posix-shm-read*
(ipc-posix-name-prefix "apple.cfprefs."))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256373] trunk/Source/WebKit

2020-02-11 Thread ryanhaddad

Title: [256373] trunk/Source/WebKit








Revision 256373
Author ryanhad...@apple.com
Date 2020-02-11 14:36:56 -0800 (Tue, 11 Feb 2020)


Log Message
Unreviewed, rolling out r256345.

Broke iOS builds.

Reverted changeset:

"Deprecate _WKUserContentWorld replaced by WKContentWorld"
https://bugs.webkit.org/show_bug.cgi?id=207514
https://trac.webkit.org/changeset/256345

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256372 => 256373)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 22:36:48 UTC (rev 256372)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 22:36:56 UTC (rev 256373)
@@ -1,3 +1,15 @@
+2020-02-11  Ryan Haddad  
+
+Unreviewed, rolling out r256345.
+
+Broke iOS builds.
+
+Reverted changeset:
+
+"Deprecate _WKUserContentWorld replaced by WKContentWorld"
+https://bugs.webkit.org/show_bug.cgi?id=207514
+https://trac.webkit.org/changeset/256345
+
 2020-02-11  Per Arne Vollan  
 
 [iOS] Deny mach lookup access to the tccd service in the WebContent process


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h (256372 => 256373)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h	2020-02-11 22:36:48 UTC (rev 256372)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h	2020-02-11 22:36:56 UTC (rev 256373)
@@ -27,8 +27,6 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-@class WKContentWorld;
-
 WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKContentWorld", macos(10.12, WK_MAC_TBA), ios(10.0, WK_IOS_TBA))
 @interface _WKUserContentWorld : NSObject
 
@@ -35,8 +33,6 @@
 + (_WKUserContentWorld *)worldWithName:(NSString *)name;
 + (_WKUserContentWorld *)normalWorld;
 
-@property (nonatomic, copy, readonly) WKContentWorld *contentWorld WK_API_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA);
-
 @property (nullable, nonatomic, readonly, copy) NSString *name;
 
 @end


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm (256372 => 256373)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm	2020-02-11 22:36:48 UTC (rev 256372)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm	2020-02-11 22:36:56 UTC (rev 256373)
@@ -26,8 +26,6 @@
 #import "config.h"
 #import "_WKUserContentWorldInternal.h"
 
-#import "WKContentWorldInternal.h"
-
 ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
 @implementation _WKUserContentWorld
 
@@ -55,11 +53,6 @@
 return _userContentWorld->name();
 }
 
-- (WKContentWorld *)contentWorld
-{
-return wrapper(API::ContentWorld::fromUserContentWorld(*_userContentWorld));
-}
-
 #pragma mark WKObject protocol implementation
 
 - (API::Object&)_apiObject






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256372] trunk/Source/WebCore

2020-02-11 Thread peng . liu6

Title: [256372] trunk/Source/WebCore








Revision 256372
Author peng.l...@apple.com
Date 2020-02-11 14:36:48 -0800 (Tue, 11 Feb 2020)


Log Message
Cleanup WebCore.xcodeproj/project.pbxproj
https://bugs.webkit.org/show_bug.cgi?id=207573

Reviewed by Darin Adler.

No new tests -- no new or changed functionality.

* WebCore.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (256371 => 256372)

--- trunk/Source/WebCore/ChangeLog	2020-02-11 22:22:23 UTC (rev 256371)
+++ trunk/Source/WebCore/ChangeLog	2020-02-11 22:36:48 UTC (rev 256372)
@@ -1,3 +1,14 @@
+2020-02-11  Peng Liu  
+
+Cleanup WebCore.xcodeproj/project.pbxproj
+https://bugs.webkit.org/show_bug.cgi?id=207573
+
+Reviewed by Darin Adler.
+
+No new tests -- no new or changed functionality.
+
+* WebCore.xcodeproj/project.pbxproj:
+
 2020-02-11  Megan Gardner  
 
 Draw underlines when specified in highlights


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (256371 => 256372)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2020-02-11 22:22:23 UTC (rev 256371)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2020-02-11 22:36:48 UTC (rev 256372)
@@ -833,17 +833,6 @@
 		2DACB9E923755DB4C185 /* GraphicsContextImpl.h in Headers */ = {isa = PBXBuildFile; fileRef = 0F00123F1FAD87D600531D76 /* GraphicsContextImpl.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		2DAF343D1EA7E0F100382CD3 /* ConstantPropertyMap.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DAF343B1EA7E0F100382CD3 /* ConstantPropertyMap.h */; };
 		2DD5A7271EBEE47D009BA597 /* CompositionUnderline.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DD5A7261EBEE47D009BA597 /* CompositionUnderline.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		2DDE1CE31F574AE500D1A365 /* JSVRFieldOfView.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CE01F574AD100D1A365 /* JSVRFieldOfView.h */; };
-		2DDE1CE41F574AE900D1A365 /* JSVRDisplay.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CDE1F574AAB00D1A365 /* JSVRDisplay.h */; };
-		2DDE1CF81F574C3900D1A365 /* JSVRDisplayCapabilities.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CE61F574BFF00D1A365 /* JSVRDisplayCapabilities.h */; };
-		2DDE1CFA1F574C3E00D1A365 /* JSVRDisplayEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CE81F574BFF00D1A365 /* JSVRDisplayEvent.h */; };
-		2DDE1CFC1F574CEE00D1A365 /* JSVRDisplayEventReason.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CEA1F574BFF00D1A365 /* JSVRDisplayEventReason.h */; };
-		2DDE1CFE1F574CF300D1A365 /* JSVREye.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CEC1F574BFF00D1A365 /* JSVREye.h */; };
-		2DDE1D001F574CF700D1A365 /* JSVREyeParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CEE1F574BFF00D1A365 /* JSVREyeParameters.h */; };
-		2DDE1D021F574DD1A365 /* JSVRFrameData.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF01F574BFF00D1A365 /* JSVRFrameData.h */; };
-		2DDE1D041F574D0500D1A365 /* JSVRLayerInit.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF21F574BFF00D1A365 /* JSVRLayerInit.h */; };
-		2DDE1D061F574D0A00D1A365 /* JSVRPose.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF41F574BFF00D1A365 /* JSVRPose.h */; };
-		2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; };
 		2DE70023192FE82A00B0975C /* DisplayRefreshMonitorMac.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DE70022192FE82A00B0975C /* DisplayRefreshMonitorMac.h */; };
 		2DF512CE1D873E47001D6780 /* ReplaceRangeWithTextCommand.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DF512CC1D873E47001D6780 /* ReplaceRangeWithTextCommand.h */; };
 		2DFA488F1DB541D000362B99 /* BufferSource.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DFA488E1DB541C200362B99 /* BufferSource.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -2143,8 +2132,6 @@
 		71E2C42621C935280024F8C8 /* AnimationEffectPhase.h in Headers */ = {isa = PBXBuildFile; fileRef = 71E2C42421C9351D0024F8C8 /* AnimationEffectPhase.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		71EADCD822087E720065A45F /* PointerID.h in Headers */ = {isa = PBXBuildFile; fileRef = 71EADCD622087E6D0065A45F /* PointerID.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		71EFCEDC202B38A900D7C411 /* AnimationEffect.h in Headers */ = {isa = PBXBuildFile; fileRef = 71EFCED7202B388D00D7C411 /* AnimationEffect.h */; settings = {ATTRIBUTES = (Private, ); }; };
-		72144331223EC85400F12FF7 /* (null) in Headers */ = {isa = PBXBuildFile; settings = {ATTRIBUTES = (Private, ); }; };
-		72144332223EC85F00F12FF7 /* (null) in Headers */ = {isa = PBXBuildFile; settings = {ATTRIBUTES = (Private, ); }; };
 		72144333223EC8B000F12FF7 /* SVGProperty.h in Headers */ = {isa = PBXBuildFile; fileRef = 55EE53632

[webkit-changes] [256374] trunk/Source/WebInspectorUI

2020-02-11 Thread nvasilyev

Title: [256374] trunk/Source/WebInspectorUI








Revision 256374
Author nvasil...@apple.com
Date 2020-02-11 14:38:23 -0800 (Tue, 11 Feb 2020)


Log Message
Web Inspector RTL: Elements closing tag is reversed
https://bugs.webkit.org/show_bug.cgi?id=207214

Reviewed by Timothy Hatcher.

Wrap text nodes in `unicode-bidi: isolate-override`. From MDN:

isolate-override:
This keyword applies the isolation behavior of the isolate
keyword to the surrounding content and the override behavior
of the bidi-override keyword to the inner content.

* UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom li > span > .html-text-node):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (256373 => 256374)

--- trunk/Source/WebInspectorUI/ChangeLog	2020-02-11 22:36:56 UTC (rev 256373)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-02-11 22:38:23 UTC (rev 256374)
@@ -1,3 +1,20 @@
+2020-02-11  Nikita Vasilyev  
+
+Web Inspector RTL: Elements closing tag is reversed
+https://bugs.webkit.org/show_bug.cgi?id=207214
+
+Reviewed by Timothy Hatcher.
+
+Wrap text nodes in `unicode-bidi: isolate-override`. From MDN:
+
+isolate-override:
+This keyword applies the isolation behavior of the isolate
+keyword to the surrounding content and the override behavior
+of the bidi-override keyword to the inner content.
+
+* UserInterface/Views/DOMTreeOutline.css:
+(.tree-outline.dom li > span > .html-text-node):
+
 2020-02-09  Keith Rollin  
 
 Re-enable LTO for ARM builds


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css (256373 => 256374)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css	2020-02-11 22:36:56 UTC (rev 256373)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css	2020-02-11 22:38:23 UTC (rev 256374)
@@ -131,6 +131,10 @@
 margin-right: var(--item-padding-end);
 }
 
+.tree-outline.dom li > span > .html-text-node {
+unicode-bidi: isolate-override;
+}
+
 .tree-outline.dom li .pseudo-class-indicator {
 display: inline-block;
 position: absolute;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256375] trunk/LayoutTests

2020-02-11 Thread lawrence . j

Title: [256375] trunk/LayoutTests








Revision 256375
Author lawrenc...@apple.com
Date 2020-02-11 14:43:11 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=206934

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256374 => 256375)

--- trunk/LayoutTests/ChangeLog	2020-02-11 22:38:23 UTC (rev 256374)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 22:43:11 UTC (rev 256375)
@@ -1,3 +1,12 @@
+2020-02-11  Jason Lawrence  
+
+[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206934
+
+Unreviewed test gardening.
+
+* platform/ios-simulator-wk2/TestExpectations:
+
 2020-02-11  Per Arne Vollan  
 
 [iOS] Deny mach lookup access to the tccd service in the WebContent process


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (256374 => 256375)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2020-02-11 22:38:23 UTC (rev 256374)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2020-02-11 22:43:11 UTC (rev 256375)
@@ -92,4 +92,6 @@
 
 webkit.org/b/206952 imported/w3c/IndexedDB-private-browsing/idbindex_getKey6.html [ Pass Timeout ]
 
-webkit.org/b/207055 media/track/texttrackcue/texttrackcue-displaycue.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207055 media/track/texttrackcue/texttrackcue-displaycue.html [ Pass Failure ]
+
+webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256376] trunk/Source/WebKit

2020-02-11 Thread achristensen

Title: [256376] trunk/Source/WebKit








Revision 256376
Author achristen...@apple.com
Date 2020-02-11 14:50:47 -0800 (Tue, 11 Feb 2020)


Log Message
Deprecate _WKUserContentWorld replaced by WKContentWorld
https://bugs.webkit.org/show_bug.cgi?id=207514
 
Add the rest of the SPI to convert between the two.

* UIProcess/API/Cocoa/_WKUserContentWorld.h:
* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
(-[_WKUserContentWorld contentWorld]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256375 => 256376)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 22:43:11 UTC (rev 256375)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 22:50:47 UTC (rev 256376)
@@ -1,3 +1,14 @@
+2020-02-11  Alex Christensen  
+
+Deprecate _WKUserContentWorld replaced by WKContentWorld
+https://bugs.webkit.org/show_bug.cgi?id=207514
+ 
+Add the rest of the SPI to convert between the two.
+
+* UIProcess/API/Cocoa/_WKUserContentWorld.h:
+* UIProcess/API/Cocoa/_WKUserContentWorld.mm:
+(-[_WKUserContentWorld contentWorld]):
+
 2020-02-11  Ryan Haddad  
 
 Unreviewed, rolling out r256345.


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h (256375 => 256376)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h	2020-02-11 22:43:11 UTC (rev 256375)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.h	2020-02-11 22:50:47 UTC (rev 256376)
@@ -25,6 +25,8 @@
 
 #import 
 
+@class WKContentWorld;
+
 NS_ASSUME_NONNULL_BEGIN
 
 WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKContentWorld", macos(10.12, WK_MAC_TBA), ios(10.0, WK_IOS_TBA))
@@ -35,6 +37,8 @@
 
 @property (nullable, nonatomic, readonly, copy) NSString *name;
 
+@property (nonatomic, copy, readonly) WKContentWorld *contentWorld WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
+
 @end
 
 NS_ASSUME_NONNULL_END


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm (256375 => 256376)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm	2020-02-11 22:43:11 UTC (rev 256375)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKUserContentWorld.mm	2020-02-11 22:50:47 UTC (rev 256376)
@@ -26,6 +26,8 @@
 #import "config.h"
 #import "_WKUserContentWorldInternal.h"
 
+#import "WKContentWorldInternal.h"
+
 ALLOW_DEPRECATED_IMPLEMENTATIONS_BEGIN
 @implementation _WKUserContentWorld
 
@@ -53,6 +55,11 @@
 return _userContentWorld->name();
 }
 
+- (WKContentWorld *)contentWorld
+{
+return wrapper(API::ContentWorld::fromUserContentWorld(*_userContentWorld));
+}
+
 #pragma mark WKObject protocol implementation
 
 - (API::Object&)_apiObject






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256377] trunk

2020-02-11 Thread youenn

Title: [256377] trunk








Revision 256377
Author you...@apple.com
Date 2020-02-11 14:53:08 -0800 (Tue, 11 Feb 2020)


Log Message
Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
https://bugs.webkit.org/show_bug.cgi?id=207325


Reviewed by Eric Carlson.

Source/WebCore:

Manually tested and covered by API test.

* platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProvider::webRTCAvailable):
Return true unconditionally on iOS since libwebrtc.dylib is always available.

Tools:

* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
(TestWebKitAPI::TEST):
Add a test validating that RTCRtpSender.getCapabilities does not return null.
* TestWebKitAPI/Tests/WebKit/getUserMedia.html:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html




Diff

Modified: trunk/Source/WebCore/ChangeLog (256376 => 256377)

--- trunk/Source/WebCore/ChangeLog	2020-02-11 22:50:47 UTC (rev 256376)
+++ trunk/Source/WebCore/ChangeLog	2020-02-11 22:53:08 UTC (rev 256377)
@@ -1,3 +1,17 @@
+2020-02-11  Youenn Fablet  
+
+Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
+https://bugs.webkit.org/show_bug.cgi?id=207325
+
+
+Reviewed by Eric Carlson.
+
+Manually tested and covered by API test.
+
+* platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
+(WebCore::LibWebRTCProvider::webRTCAvailable):
+Return true unconditionally on iOS since libwebrtc.dylib is always available.
+
 2020-02-11  Peng Liu  
 
 Cleanup WebCore.xcodeproj/project.pbxproj


Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp (256376 => 256377)

--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp	2020-02-11 22:50:47 UTC (rev 256376)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp	2020-02-11 22:53:08 UTC (rev 256377)
@@ -73,7 +73,11 @@
 
 bool LibWebRTCProvider::webRTCAvailable()
 {
+#if PLATFORM(IOS)
+return true;
+#else
 return !isNullFunctionPointer(rtc::LogMessage::LogToDebug);
+#endif
 }
 
 } // namespace WebCore


Modified: trunk/Tools/ChangeLog (256376 => 256377)

--- trunk/Tools/ChangeLog	2020-02-11 22:50:47 UTC (rev 256376)
+++ trunk/Tools/ChangeLog	2020-02-11 22:53:08 UTC (rev 256377)
@@ -1,3 +1,16 @@
+2020-02-11  Youenn Fablet  
+
+Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
+https://bugs.webkit.org/show_bug.cgi?id=207325
+
+
+Reviewed by Eric Carlson.
+
+* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
+(TestWebKitAPI::TEST):
+Add a test validating that RTCRtpSender.getCapabilities does not return null.
+* TestWebKitAPI/Tests/WebKit/getUserMedia.html:
+
 2020-02-11  Wenson Hsieh  
 
 KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm (256376 => 256377)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm	2020-02-11 22:50:47 UTC (rev 256376)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm	2020-02-11 22:53:08 UTC (rev 256377)
@@ -201,6 +201,35 @@
 wasPrompted = false;
 }
 
+TEST(WebKit2, GetCapabilities)
+{
+auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
+auto processPoolConfig = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
+auto preferences = [configuration preferences];
+preferences._mediaCaptureRequiresSecureConnection = NO;
+preferences._mediaDevicesEnabled = YES;
+preferences._mockCaptureDevicesEnabled = YES;
+
+auto messageHandler = adoptNS([[GUMMessageHandler alloc] init]);
+[[configuration.get() userContentController] addScriptMessageHandler:messageHandler.get() name:@"gum"];
+
+auto webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500) configuration:configuration.get() processPoolConfiguration:processPoolConfig.get()];
+auto delegate = adoptNS([[GetUserMediaCaptureUIDelegate alloc] init]);
+webView.UIDelegate = delegate.get();
+
+wasPrompted = false;
+
+[webView loadTestPageNamed:@"getUserMedia"];
+EXPECT_TRUE(waitUntilCaptureState(webView, _WKMediaCaptureStateActiveCamera));
+
+TestWebKitAPI::Util::run(&wasPrompted);
+
+done = false;
+[webView stringByEvaluatingJavaScript:@"checkGetCapabilities()"];
+
+TestWebKitAPI::Util::run(&done);
+}
+
 #if WK_HAVE_C_SPI
 TEST(WebKit, WebAudioAndGetUserMedia)
 {


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html (256376 => 256377)

--- trunk/Tools/TestWebKitAPI/Tests/WebKit/getUserMedia.html	2020-02-11 22:50:47 UTC (rev 256376)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/getUserM

[webkit-changes] [256378] trunk/Source/WebKit

2020-02-11 Thread dbates

Title: [256378] trunk/Source/WebKit








Revision 256378
Author dba...@webkit.org
Date 2020-02-11 14:57:39 -0800 (Tue, 11 Feb 2020)


Log Message
Should not allow zooming to reveal focused element when suppressing selection assistant
https://bugs.webkit.org/show_bug.cgi?id=207575

Reviewed by Wenson Hsieh.

Do not tell the UIScrollView to scroll and zoom to reveal the focused element when the
selection assistant is being suppressed as it does not make sense to do so: the primary
motivation for zooming to reveal the focused (aka the editable) element is make it easier
to edit it.

This fixes a bug where previewing a partially offscreen link inside an editable element
would cause the page content to scroll and zoom to reveal the editable element. Previewing
a link is not considered an editing operation and selection assistance is prevented, but
"zoom to reveal" was inadvertently allowed. Now it is not.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _zoomToRevealFocusedElement]): Bail out if selection is being suppressed
for any reason. Note that pre-r245882 there was reason SuppressSelectionAssistantReason::DropAnimationIsRunning
that was used to suppress selection assistance AND allow "zoom to reveal". But this
reason was removed and there are no suppression reasons as of the time of writing where
it makes sense to have behavior like SuppressSelectionAssistantReason::DropAnimationIsRunning.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256377 => 256378)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 22:53:08 UTC (rev 256377)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 22:57:39 UTC (rev 256378)
@@ -1,3 +1,28 @@
+2020-02-11  Daniel Bates  
+
+Should not allow zooming to reveal focused element when suppressing selection assistant
+https://bugs.webkit.org/show_bug.cgi?id=207575
+
+Reviewed by Wenson Hsieh.
+
+Do not tell the UIScrollView to scroll and zoom to reveal the focused element when the
+selection assistant is being suppressed as it does not make sense to do so: the primary
+motivation for zooming to reveal the focused (aka the editable) element is make it easier
+to edit it.
+
+This fixes a bug where previewing a partially offscreen link inside an editable element
+would cause the page content to scroll and zoom to reveal the editable element. Previewing
+a link is not considered an editing operation and selection assistance is prevented, but
+"zoom to reveal" was inadvertently allowed. Now it is not.
+
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _zoomToRevealFocusedElement]): Bail out if selection is being suppressed
+for any reason. Note that pre-r245882 there was reason SuppressSelectionAssistantReason::DropAnimationIsRunning
+that was used to suppress selection assistance AND allow "zoom to reveal". But this
+reason was removed and there are no suppression reasons as of the time of writing where
+it makes sense to have behavior like SuppressSelectionAssistantReason::DropAnimationIsRunning.
+
 2020-02-11  Alex Christensen  
 
 Deprecate _WKUserContentWorld replaced by WKContentWorld


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (256377 => 256378)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-02-11 22:53:08 UTC (rev 256377)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-02-11 22:57:39 UTC (rev 256378)
@@ -1936,7 +1936,7 @@
 
 - (void)_zoomToRevealFocusedElement
 {
-if (_suppressSelectionAssistantReasons.contains(WebKit::EditableRootIsTransparentOrFullyClipped) || _suppressSelectionAssistantReasons.contains(WebKit::FocusedElementIsTooSmall))
+if (_suppressSelectionAssistantReasons)
 return;
 
 // In case user scaling is force enabled, do not use that scaling when zooming in with an input field.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256379] trunk/LayoutTests

2020-02-11 Thread lawrence . j

Title: [256379] trunk/LayoutTests








Revision 256379
Author lawrenc...@apple.com
Date 2020-02-11 14:59:38 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS wk2 ] http/wpt/service-workers/service-worker-spinning-fetch.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207515

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256378 => 256379)

--- trunk/LayoutTests/ChangeLog	2020-02-11 22:57:39 UTC (rev 256378)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 22:59:38 UTC (rev 256379)
@@ -1,5 +1,15 @@
 2020-02-11  Jason Lawrence  
 
+[ iOS wk2 ] http/wpt/service-workers/service-worker-spinning-fetch.https.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=207515
+
+Unreviewed test gardening.
+
+* platform/ios-simulator-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
+2020-02-11  Jason Lawrence  
+
 [ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
 https://bugs.webkit.org/show_bug.cgi?id=206934
 


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (256378 => 256379)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2020-02-11 22:57:39 UTC (rev 256378)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2020-02-11 22:59:38 UTC (rev 256379)
@@ -94,4 +94,6 @@
 
 webkit.org/b/207055 media/track/texttrackcue/texttrackcue-displaycue.html [ Pass Failure ]
 
-webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]
+
+webkit.org/b/207515 http/wpt/service-workers/service-worker-spinning-fetch.https.html [ Pass Failure ]
\ No newline at end of file


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (256378 => 256379)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 22:57:39 UTC (rev 256378)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 22:59:38 UTC (rev 256379)
@@ -1010,8 +1010,6 @@
 
 webkit.org/b/207509 [ Debug ] imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html [ Pass Crash ]
 
-webkit.org/b/207515 http/wpt/service-workers/service-worker-spinning-fetch.https.html [ Pass Failure ]
-
 webkit.org/b/207518 tiled-drawing/simple-document-with-margin-tiles.html [ Pass Failure ]
 
 webkit.rog/b/207571 http/tests/IndexedDB/collect-IDB-objects.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256380] trunk/Source/WebCore

2020-02-11 Thread zalan

Title: [256380] trunk/Source/WebCore








Revision 256380
Author za...@apple.com
Date 2020-02-11 15:13:00 -0800 (Tue, 11 Feb 2020)


Log Message
[LFC] Introduce Layout::ReplacedBox
https://bugs.webkit.org/show_bug.cgi?id=207561


Reviewed by Antti Koivisto.

This is in preparation for making Layout::Box an "abstract" box (so that it stops being a leaf type of box).

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):
* layout/FormattingContext.h:
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases const):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin const):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin const):
* layout/blockformatting/BlockFormattingContext.h:
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::intrinsicWidthConstraints):
* layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::precomputedMarginBefore):
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin):
* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin const):
* layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::append):
(WebCore::Layout::LineBuilder::appendReplacedInlineBox):
(WebCore::Layout::LineBuilder::runContentHeight const):
(WebCore::Layout::LineBuilder::isVisuallyNonEmpty const):
* layout/inlineformatting/LineLayoutContext.cpp:
(WebCore::Layout::LineLayoutContext::inlineItemWidth const):
* layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::Box):
(WebCore::Layout::Box::isInlineBox const):
(WebCore::Layout::Box::replaced const): Deleted.
(WebCore::Layout::Box::replaced): Deleted.
* layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isTableCell const):
(WebCore::Layout::Box::isReplacedBox const):
(WebCore::Layout::Box::isReplaced const): Deleted.
* layout/layouttree/LayoutReplacedBox.cpp: Renamed from Source/WebCore/layout/layouttree/LayoutReplaced.cpp.
(WebCore::Layout::ReplacedBox::ReplacedBox):
(WebCore::Layout::ReplacedBox::hasIntrinsicWidth const):
(WebCore::Layout::ReplacedBox::hasIntrinsicHeight const):
(WebCore::Layout::ReplacedBox::hasIntrinsicRatio const):
(WebCore::Layout::ReplacedBox::intrinsicWidth const):
(WebCore::Layout::ReplacedBox::intrinsicHeight const):
(WebCore::Layout::ReplacedBox::intrinsicRatio const):
(WebCore::Layout::ReplacedBox::hasAspectRatio const):
* layout/layouttree/LayoutReplacedBox.h: Renamed from Source/WebCore/layout/layouttree/LayoutReplaced.h.
(WebCore::Layout::ReplacedBox::setCachedImage):
(WebCore::Layout::ReplacedBox::cachedImage const):
(WebCore::Layout::ReplacedBox::setIntrinsicSize):
(WebCore::Layout::ReplacedBox::setIntrinsicRatio):
* layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::outputLayoutBox):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Headers.cmake
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingCont

[webkit-changes] [256381] trunk

2020-02-11 Thread youenn

Title: [256381] trunk








Revision 256381
Author you...@apple.com
Date 2020-02-11 15:32:10 -0800 (Tue, 11 Feb 2020)


Log Message
Parent service worker controller should be used for child iframe as per https://w3c.github.io/ServiceWorker/#control-and-use-window-client
https://bugs.webkit.org/show_bug.cgi?id=207506

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/local-url-inherit-controller.https-expected.txt:

Source/WebCore:

Instead of checking document URL protocol, implement the rules as per spec, in particular:
- If http/https, do not reuse controller
- If iframe has a unique origin, do not reuse controller
- If iframe does not have same origin as parent, do not reuse controller.

Covered by rebased test.

* loader/DocumentLoader.cpp:
(WebCore::isInheritingControllerFromParent):
(WebCore::DocumentLoader::commitData):
(WebCore::isLocalURL): Deleted.

LayoutTests:

* http/tests/workers/service/serviceworkerclients-claim.https-expected.txt:
Rebased test since now the frame is doing a fetch that is no longer intercepted by the service worker,
and is thus failing due to CORS.
* http/tests/workers/service/serviceworkerclients-claim.https.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt
trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/local-url-inherit-controller.https-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (256380 => 256381)

--- trunk/LayoutTests/ChangeLog	2020-02-11 23:13:00 UTC (rev 256380)
+++ trunk/LayoutTests/ChangeLog	2020-02-11 23:32:10 UTC (rev 256381)
@@ -1,3 +1,15 @@
+2020-02-11  Youenn Fablet  
+
+Parent service worker controller should be used for child iframe as per https://w3c.github.io/ServiceWorker/#control-and-use-window-client
+https://bugs.webkit.org/show_bug.cgi?id=207506
+
+Reviewed by Darin Adler.
+
+* http/tests/workers/service/serviceworkerclients-claim.https-expected.txt:
+Rebased test since now the frame is doing a fetch that is no longer intercepted by the service worker,
+and is thus failing due to CORS.
+* http/tests/workers/service/serviceworkerclients-claim.https.html:
+
 2020-02-11  Jason Lawrence  
 
 [ iOS wk2 ] http/wpt/service-workers/service-worker-spinning-fetch.https.html is flaky failing.


Modified: trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt (256380 => 256381)

--- trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt	2020-02-11 23:13:00 UTC (rev 256380)
+++ trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https-expected.txt	2020-02-11 23:32:10 UTC (rev 256381)
@@ -1,3 +1,6 @@
+CONSOLE MESSAGE: Origin null is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: Fetch API cannot load https://127.0.0.1:8443/pinkelephant due to access control checks.
+CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: TypeError: Origin null is not allowed by Access-Control-Allow-Origin.
 
 
 PASS Setup worker 


Modified: trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html (256380 => 256381)

--- trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html	2020-02-11 23:13:00 UTC (rev 256380)
+++ trunk/LayoutTests/http/tests/workers/service/serviceworkerclients-claim.https.html	2020-02-11 23:32:10 UTC (rev 256381)
@@ -60,13 +60,12 @@
 promise_test(async (test) => {
 var promise = new Promise((resolve, reject) => {
 window.addEventListener("message", (event) => {
-resolve(event.data);
+reject("Received a message from iframe:" + event.data);
 }, false);
-setTimeout(() => {  reject("Did not receive any message from iframe"); }, 5000);
+setTimeout(resolve, 100);
 });
 var frame = await withFrame("data:text/html," + htmlString);
-var result = await promise;
-assert_equals(result, "PASS");
+return promise;
 }, "Test data URL frame");
 
 promise_test(async (test) => {


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (256380 => 256381)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2020-02-11 23:13:00 UTC (rev 256380)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2020-02-11 23:32:10 UTC (rev 256381)
@@ -1,3 +1,12 @@
+2020-02-11  Youenn Fablet  
+
+Parent service worker controller should be used for child iframe as per https://w3c.github.io/ServiceWorker/#control-and-use-window-client
+https://bugs.webkit.org/show_bug.cgi?id=207506
+
+Reviewed by Darin Adler.
+
+* web-platform-tests/service-workers/service-worker/local-url-inherit-controller.https

[webkit-changes] [256382] trunk/Tools

2020-02-11 Thread jbedard

Title: [256382] trunk/Tools








Revision 256382
Author jbed...@apple.com
Date 2020-02-11 15:42:44 -0800 (Tue, 11 Feb 2020)


Log Message
results.webkit.org: Configuration documentation should include architecture
https://bugs.webkit.org/show_bug.cgi?id=207584

Reviewed by Aakash Jain.

* resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/templates/documentation.html




Diff

Modified: trunk/Tools/ChangeLog (256381 => 256382)

--- trunk/Tools/ChangeLog	2020-02-11 23:32:10 UTC (rev 256381)
+++ trunk/Tools/ChangeLog	2020-02-11 23:42:44 UTC (rev 256382)
@@ -1,3 +1,12 @@
+2020-02-11  Jonathan Bedard  
+
+results.webkit.org: Configuration documentation should include architecture
+https://bugs.webkit.org/show_bug.cgi?id=207584
+
+Reviewed by Aakash Jain.
+
+* resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
+
 2020-02-11  Youenn Fablet  
 
 Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)


Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/templates/documentation.html (256381 => 256382)

--- trunk/Tools/resultsdbpy/resultsdbpy/view/templates/documentation.html	2020-02-11 23:32:10 UTC (rev 256381)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/templates/documentation.html	2020-02-11 23:42:44 UTC (rev 256382)
@@ -469,6 +469,7 @@
 'Configuration': [
 `Configurations are the key which defines a specific row within the results database. Uploads which share a configuration, but not a UUID, will appear in the same row on a timeline. Configurations are represented within the results database as an object:`,
 codeBlock('{\n' +
+'"architecture": ,\n' +
 '"platform": ,\n' +
 '"is_simulator": ,\n' +
 '"version": ,\n' +






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256383] trunk

2020-02-11 Thread commit-queue

Title: [256383] trunk








Revision 256383
Author commit-qu...@webkit.org
Date 2020-02-11 15:49:43 -0800 (Tue, 11 Feb 2020)


Log Message
Unreviewed, rolling out r256314.
https://bugs.webkit.org/show_bug.cgi?id=207594

It is breaking an API test (Requested by youenn on #webkit).

Reverted changeset:

"WebSWServerConnection::registerServiceWorkerClient is not
sending IPC message to UIProcess when it should"
https://bugs.webkit.org/show_bug.cgi?id=207537
https://trac.webkit.org/changeset/256314

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (256382 => 256383)

--- trunk/Source/WebKit/ChangeLog	2020-02-11 23:42:44 UTC (rev 256382)
+++ trunk/Source/WebKit/ChangeLog	2020-02-11 23:49:43 UTC (rev 256383)
@@ -1,3 +1,17 @@
+2020-02-11  Commit Queue  
+
+Unreviewed, rolling out r256314.
+https://bugs.webkit.org/show_bug.cgi?id=207594
+
+It is breaking an API test (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"WebSWServerConnection::registerServiceWorkerClient is not
+sending IPC message to UIProcess when it should"
+https://bugs.webkit.org/show_bug.cgi?id=207537
+https://trac.webkit.org/changeset/256314
+
 2020-02-11  Daniel Bates  
 
 Should not allow zooming to reveal focused element when suppressing selection assistant


Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (256382 => 256383)

--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp	2020-02-11 23:42:44 UTC (rev 256382)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp	2020-02-11 23:49:43 UTC (rev 256383)
@@ -313,7 +313,6 @@
 bool isNewOrigin = WTF::allOf(m_clientOrigins.values(), [&contextOrigin](auto& origin) {
 return contextOrigin != origin.clientOrigin;
 });
-auto* contextConnection = isNewOrigin ? server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin }) : nullptr;
 
 auto clientOrigin = ClientOrigin { WTFMove(topOrigin), WTFMove(contextOrigin) };
 m_clientOrigins.add(data.identifier, clientOrigin);
@@ -322,9 +321,11 @@
 if (!m_isThrottleable)
 updateThrottleState();
 
-if (contextConnection) {
-auto& connection = static_cast(*contextConnection);
-m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
+if (isNewOrigin) {
+if (auto* contextConnection = server().contextConnectionForRegistrableDomain(RegistrableDomain { contextOrigin })) {
+auto& connection = static_cast(*contextConnection);
+m_networkProcess->parentProcessConnection()->send(Messages::NetworkProcessProxy::RegisterServiceWorkerClientProcess { identifier(), connection.webProcessIdentifier() }, 0);
+}
 }
 }
 


Modified: trunk/Tools/ChangeLog (256382 => 256383)

--- trunk/Tools/ChangeLog	2020-02-11 23:42:44 UTC (rev 256382)
+++ trunk/Tools/ChangeLog	2020-02-11 23:49:43 UTC (rev 256383)
@@ -1,3 +1,17 @@
+2020-02-11  Commit Queue  
+
+Unreviewed, rolling out r256314.
+https://bugs.webkit.org/show_bug.cgi?id=207594
+
+It is breaking an API test (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"WebSWServerConnection::registerServiceWorkerClient is not
+sending IPC message to UIProcess when it should"
+https://bugs.webkit.org/show_bug.cgi?id=207537
+https://trac.webkit.org/changeset/256314
+
 2020-02-11  Jonathan Bedard  
 
 results.webkit.org: Configuration documentation should include architecture


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm (256382 => 256383)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm	2020-02-11 23:42:44 UTC (rev 256382)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm	2020-02-11 23:49:43 UTC (rev 256383)
@@ -1676,22 +1676,6 @@
 [webView _setAssertionStateForTesting: 0];
 waitUntilServiceWorkerProcessBackgroundActivityState(webView.get(), false);
 waitUntilServiceWorkerProcessForegroundActivityState(webView.get(), false);
-
-[webView _setAssertionStateForTesting: 1];
-waitUntilServiceWorkerProcessForegroundActivityState(webView.get(), false);
-waitUntilServiceWorkerProcessBackgroundActivityState(webView.get(), true);
-
-auto webView2 = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
-
-[webView2 loadRequest:server.request()];
-[webView2 _setAssertionStateForTesting: 3];
-
-[webView _close];
-webView = nullptr;
-
-// The first webView is closed so the service worker process shou

[webkit-changes] [256384] trunk/Source/WebCore

2020-02-11 Thread zalan

Title: [256384] trunk/Source/WebCore








Revision 256384
Author za...@apple.com
Date 2020-02-11 15:51:36 -0800 (Tue, 11 Feb 2020)


Log Message
[LFC] Do not create generic Layout::Box leaf boxes
https://bugs.webkit.org/show_bug.cgi?id=207570


Reviewed by Antti Koivisto.

A Layout::Box is either a container box or a very specific leaf type (text, replaced etc).

* layout/layouttree/LayoutBox.cpp:
* layout/layouttree/LayoutBox.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp
trunk/Source/WebCore/layout/layouttree/LayoutBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (256383 => 256384)

--- trunk/Source/WebCore/ChangeLog	2020-02-11 23:49:43 UTC (rev 256383)
+++ trunk/Source/WebCore/ChangeLog	2020-02-11 23:51:36 UTC (rev 256384)
@@ -1,3 +1,16 @@
+2020-02-11  Zalan Bujtas  
+
+[LFC] Do not create generic Layout::Box leaf boxes
+https://bugs.webkit.org/show_bug.cgi?id=207570
+
+
+Reviewed by Antti Koivisto.
+
+A Layout::Box is either a container box or a very specific leaf type (text, replaced etc).
+
+* layout/layouttree/LayoutBox.cpp:
+* layout/layouttree/LayoutBox.h:
+
 2020-02-11  Youenn Fablet  
 
 Parent service worker controller should be used for child iframe as per https://w3c.github.io/ServiceWorker/#control-and-use-window-client


Modified: trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp (256383 => 256384)

--- trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp	2020-02-11 23:49:43 UTC (rev 256383)
+++ trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp	2020-02-11 23:51:36 UTC (rev 256384)
@@ -49,11 +49,6 @@
 {
 }
 
-Box::Box(Optional attributes, RenderStyle&& style)
-: Box(attributes, WTFMove(style), BaseTypeFlag::BoxFlag)
-{
-}
-
 Box::~Box()
 {
 if (UNLIKELY(m_hasRareData))


Modified: trunk/Source/WebCore/layout/layouttree/LayoutBox.h (256383 => 256384)

--- trunk/Source/WebCore/layout/layouttree/LayoutBox.h	2020-02-11 23:49:43 UTC (rev 256383)
+++ trunk/Source/WebCore/layout/layouttree/LayoutBox.h	2020-02-11 23:51:36 UTC (rev 256384)
@@ -69,7 +69,6 @@
 };
 typedef unsigned BaseTypeFlags;
 
-Box(Optional, RenderStyle&&);
 virtual ~Box();
 
 bool establishesFormattingContext() const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256391] branches/safari-609-branch/LayoutTests

2020-02-11 Thread alancoon

Title: [256391] branches/safari-609-branch/LayoutTests








Revision 256391
Author alanc...@apple.com
Date 2020-02-11 15:55:24 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255672. rdar://problem/59299127

Regression: (252234?) [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207194

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-02-04

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256390 => 256391)

--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:22 UTC (rev 256390)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:24 UTC (rev 256391)
@@ -1,5 +1,29 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255672. rdar://problem/59299127
+
+Regression: (252234?) [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=207194
+
+Unreviewed test gardening.
+
+Patch by Jason Lawrence  on 2020-02-04
+
+* platform/ios-wk2/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-04  Jason Lawrence  
+
+Regression: (252234?) [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=207194
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2020-02-11  Alan Coon  
+
 Cherry-pick r255518. rdar://problem/59298166
 
 [ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.


Modified: branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations (256390 => 256391)

--- branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 23:55:22 UTC (rev 256390)
+++ branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 23:55:24 UTC (rev 256391)
@@ -1351,3 +1351,4 @@
 
 webkit.org/b/205308 accessibility/smart-invert-reference.html [ ImageOnlyFailure ]
 
+webkit.org/b/207194 fast/scrolling/ios/scroll-events-back-forward.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256388] branches/safari-609-branch

2020-02-11 Thread alancoon

Title: [256388] branches/safari-609-branch








Revision 256388
Author alanc...@apple.com
Date 2020-02-11 15:55:17 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255518. rdar://problem/59298166

[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=206934


Source/WebKit:

Reviewed by Brady Eidson.

Flakiness would happen when the service worker would take too long to launch and the responsiveness timer would fire and
report the process as unresponsive while still launching or very shortly after. When a service worker is reported as
unresponsive, we would kill it.

To address the issue, several changes were made:
- Responsiveness checks are now disabled for slow builds (Debug, ASAN, GuardMalloc)
- We only start the ResponsivenessTimer after the process has finished launching since the responsiveness
  check relies on IPC to the process and we cannot send the IPC until after the process has launched.

* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:
(WebKit::DrawingAreaProxyCoordinatedGraphics::sendUpdateBackingStoreState):
* UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::goToBackForwardItem):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::launchProcessForReload):
(WebKit::WebPageProxy::launchProcessWithItem):
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadDataWithNavigationShared):
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPageProxy::stopLoading):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::processNextQueuedMouseEvent):
(WebKit::WebPageProxy::handleKeyboardEvent):
(WebKit::WebPageProxy::handleGestureEvent):
(WebKit::WebPageProxy::handlePreventableTouchEvent):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::runJavaScriptAlert):
(WebKit::WebPageProxy::runJavaScriptConfirm):
(WebKit::WebPageProxy::runJavaScriptPrompt):
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel):
(WebKit::WebPageProxy::runOpenPanel):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::mayBecomeUnresponsive):
(WebKit::WebProcessProxy::didFinishLaunching):
(WebKit::WebProcessProxy::startResponsivenessTimer):
(WebKit::WebProcessProxy::isResponsive):
* UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::responsivenessTimer):

LayoutTests:

Unskip test which should no longer be flaky.

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations
branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp
branches/safari-609-branch/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessProxy.cpp
branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessProxy.h




Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256387 => 256388)

--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:13 UTC (rev 256387)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:17 UTC (rev 256388)
@@ -1,5 +1,79 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255518. rdar://problem/59298166
+
+[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206934
+
+
+Source/WebKit:
+
+Reviewed by Brady Eidson.
+
+Flakiness would happen when the service worker would take too long to launch and the responsiveness timer would fire and
+report the process as unresponsive while still launching or very shortly after. When a service worker is reported as
+unresponsive, we would kill it.
+
+To address the issue, several changes were made:
+- Responsiveness checks are now disabled for slow builds (Debug, ASAN, GuardMalloc)
+- We only start the ResponsivenessTimer after the process has finished launching since the responsiveness
+  check relies on IPC to the process and we cannot send the IPC until after the process has launched.
+
+* UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGr

[webkit-changes] [256386] branches/safari-609-branch/LayoutTests

2020-02-11 Thread alancoon

Title: [256386] branches/safari-609-branch/LayoutTests








Revision 256386
Author alanc...@apple.com
Date 2020-02-11 15:55:11 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255360. rdar://problem/59298166

[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=206934

Unreviewed test gardening.

Patch by Jason Lawrence  on 2020-01-29

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256385 => 256386)

--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:08 UTC (rev 256385)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:11 UTC (rev 256386)
@@ -1,5 +1,29 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255360. rdar://problem/59298166
+
+[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206934
+
+Unreviewed test gardening.
+
+Patch by Jason Lawrence  on 2020-01-29
+
+* platform/ios-wk2/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-29  Jason Lawrence  
+
+[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206934
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2020-02-11  Alan Coon  
+
 Cherry-pick r255158. rdar://problem/59298137
 
 Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler


Modified: branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations (256385 => 256386)

--- branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 23:55:08 UTC (rev 256385)
+++ branches/safari-609-branch/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 23:55:11 UTC (rev 256386)
@@ -1350,3 +1350,5 @@
 webkit.org/b/203637 fast/css-custom-paint/simple-hidpi.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/205308 accessibility/smart-invert-reference.html [ ImageOnlyFailure ]
+
+webkit.org/b/206934 imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256393] branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/ StorageAreaImpl.cpp

2020-02-11 Thread alancoon

Title: [256393] branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp








Revision 256393
Author alanc...@apple.com
Date 2020-02-11 15:55:30 -0800 (Tue, 11 Feb 2020)


Log Message
Unreviewed build fix. rdar://problem/59298172

Modified Paths

branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp




Diff

Modified: branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp (256392 => 256393)

--- branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp	2020-02-11 23:55:28 UTC (rev 256392)
+++ branches/safari-609-branch/Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.cpp	2020-02-11 23:55:30 UTC (rev 256393)
@@ -46,7 +46,7 @@
 : m_identifier(Identifier::generate())
 , m_storageAreaMap(makeWeakPtr(storageAreaMap.get()))
 {
-storageAreaMap.incrementUseCount();
+storageAreaMap->incrementUseCount();
 }
 
 StorageAreaImpl::~StorageAreaImpl()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256389] branches/safari-609-branch/Source/WebKit

2020-02-11 Thread alancoon

Title: [256389] branches/safari-609-branch/Source/WebKit








Revision 256389
Author alanc...@apple.com
Date 2020-02-11 15:55:19 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255519. rdar://problem/59298166

Unreviewed macOS build fix after r255518

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleGestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (256388 => 256389)

--- branches/safari-609-branch/Source/WebKit/ChangeLog	2020-02-11 23:55:17 UTC (rev 256388)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog	2020-02-11 23:55:19 UTC (rev 256389)
@@ -1,5 +1,23 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255519. rdar://problem/59298166
+
+Unreviewed macOS build fix after r255518
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::handleGestureEvent):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-31  Chris Dumez  
+
+Unreviewed macOS build fix after r255518
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::handleGestureEvent):
+
+2020-02-11  Alan Coon  
+
 Cherry-pick r255518. rdar://problem/59298166
 
 [ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.


Modified: branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (256388 => 256389)

--- branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-11 23:55:17 UTC (rev 256388)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-11 23:55:19 UTC (rev 256389)
@@ -2819,7 +2819,7 @@
 m_gestureEventQueue.append(event);
 // FIXME: Consider doing some coalescing here.
 
-m_process->startResponsivenessTimer((event.type() == WebEvent::GestureStart || event.type() == WebEvent::GestureChange) ? WebProcessProxy::UseLazyStop::Yes ? WebProcessProxy::UseLazyStop::No);
+m_process->startResponsivenessTimer((event.type() == WebEvent::GestureStart || event.type() == WebEvent::GestureChange) ? WebProcessProxy::UseLazyStop::Yes : WebProcessProxy::UseLazyStop::No);
 
 send(Messages::EventDispatcher::GestureEvent(m_webPageID, event), 0);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256387] branches/safari-609-branch/LayoutTests

2020-02-11 Thread alancoon

Title: [256387] branches/safari-609-branch/LayoutTests








Revision 256387
Author alanc...@apple.com
Date 2020-02-11 15:55:13 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255379. rdar://problem/59298188

2020-01-29  Jacob Uphoff  

[ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky failure & flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=206958

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256386 => 256387)

--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:11 UTC (rev 256386)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:13 UTC (rev 256387)
@@ -1,27 +1,51 @@
 2020-02-11  Alan Coon  
 
-Cherry-pick r255360. rdar://problem/59298166
+Cherry-pick r255379. rdar://problem/59298188
 
-[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
-https://bugs.webkit.org/show_bug.cgi?id=206934
+2020-01-29  Jacob Uphoff  
 
+[ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky failure & flaky timing out
+https://bugs.webkit.org/show_bug.cgi?id=206958
+
 Unreviewed test gardening.
 
-Patch by Jason Lawrence  on 2020-01-29
+* platform/mac-wk2/TestExpectations:
 
-* platform/ios-wk2/TestExpectations:
-
-git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
 
-2020-01-29  Jason Lawrence  
+020-01-29  Jacob Uphoff  
 
-[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
-https://bugs.webkit.org/show_bug.cgi?id=206934
+[ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky failure & flaky timing out
+https://bugs.webkit.org/show_bug.cgi?id=206958
 
 Unreviewed test gardening.
 
-* platform/ios-wk2/TestExpectations:
+* platform/mac-wk2/TestExpectations:
 
+2020-02-11  Alan Coon  
+
+Cherry-pick r255360. rdar://problem/59298166
+
+[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206934
+
+Unreviewed test gardening.
+
+Patch by Jason Lawrence  on 2020-01-29
+
+* platform/ios-wk2/TestExpectations:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-01-29  Jason Lawrence  
+
+[ iOS ] imported/w3c/web-platform-tests/IndexedDB/key-generators/reading-autoincrement-indexes-cursors.any.serviceworker.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=206934
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2020-02-11  Alan Coon  
 
 Cherry-pick r255158. rdar://problem/59298137


Modified: branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations (256386 => 256387)

--- branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 23:55:11 UTC (rev 256386)
+++ branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations	2020-02-11 23:55:13 UTC (rev 256387)
@@ -928,3 +928,4 @@
 
 webkit.org/b/205886 http/wpt/service-workers/persistent-importScripts.html [ Pass Failure ]
 
+webkit.org/b/206958 http/tests/media/media-stream/get-display-media-prompt.html [ Pass Failure Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256392] branches/safari-609-branch

2020-02-11 Thread alancoon

Title: [256392] branches/safari-609-branch








Revision 256392
Author alanc...@apple.com
Date 2020-02-11 15:55:28 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255162. rdar://problem/59299120

Support 'allow="fullscreen"' feature policy
https://bugs.webkit.org/show_bug.cgi?id=206806


Patch by Jer Noble  on 2020-01-27
Reviewed by Youenn Fablet.

Source/WebCore:

Test: http/tests/fullscreen/fullscreen-feature-policy.html

The unprefixed version of the Fullscreen API has deprecated the 'allowfullscreen' iframe
attribute in favor of the 'allow="fullscreen"' style attribute used by Feature Policy.
Add support for such, including the specified handling for the legacy 'allowfullscreen'
attribute.

Note: this patch will (intentionally) change the default behavior of s. Previously
any  without the "allowfullscreen" attribute would not be allowed to enter fullscreen
mode. After this patch,  without the legacy attribute or an explicit fullscreen
Feature Policy will be allowed to enter fullscreen so long as their origin is the same as
the top document (and that all parent iframes are also allowed to enter fullscreen).

* dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::requestFullscreenForElement):
(WebCore::FullscreenManager::isFullscreenEnabled const):
(WebCore::isAttributeOnAllOwners): Deleted.
(WebCore::FullscreenManager::fullscreenIsAllowedForElement const): Deleted.
* dom/FullscreenManager.h:
* html/FeaturePolicy.cpp:
(WebCore::isFeaturePolicyAllowedByDocumentAndAllOwners):
(WebCore::FeaturePolicy::parse):
(WebCore::FeaturePolicy::allows const):
* html/FeaturePolicy.h:
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
(WebCore::HTMLIFrameElement::featurePolicy const):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
(WebCore::isSyncXHRAllowedByFeaturePolicy): Deleted.

LayoutTests:

* fullscreen/full-screen-enabled-prefixed.html:
* fullscreen/full-screen-enabled.html:
* fullscreen/full-screen-frameset-expected.txt: Removed.
* fullscreen/full-screen-frameset.html: Removed.
* fullscreen/full-screen-iframe-not-allowed.html:
* fullscreen/full-screen-restrictions.html:
* http/tests/fullscreen/fullscreen-feature-policy-expected.txt: Added.
* http/tests/fullscreen/fullscreen-feature-policy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/fullscreen/full-screen-enabled-prefixed.html
branches/safari-609-branch/LayoutTests/fullscreen/full-screen-enabled.html
branches/safari-609-branch/LayoutTests/fullscreen/full-screen-iframe-not-allowed.html
branches/safari-609-branch/LayoutTests/fullscreen/full-screen-restrictions.html
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/dom/FullscreenManager.cpp
branches/safari-609-branch/Source/WebCore/dom/FullscreenManager.h
branches/safari-609-branch/Source/WebCore/html/FeaturePolicy.cpp
branches/safari-609-branch/Source/WebCore/html/FeaturePolicy.h
branches/safari-609-branch/Source/WebCore/html/HTMLIFrameElement.cpp
branches/safari-609-branch/Source/WebCore/xml/XMLHttpRequest.cpp


Added Paths

branches/safari-609-branch/LayoutTests/http/tests/fullscreen/fullscreen-feature-policy-expected.txt
branches/safari-609-branch/LayoutTests/http/tests/fullscreen/fullscreen-feature-policy.html


Removed Paths

branches/safari-609-branch/LayoutTests/fullscreen/full-screen-frameset-expected.txt
branches/safari-609-branch/LayoutTests/fullscreen/full-screen-frameset.html




Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (256391 => 256392)

--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:24 UTC (rev 256391)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-02-11 23:55:28 UTC (rev 256392)
@@ -1,5 +1,79 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255162. rdar://problem/59299120
+
+Support 'allow="fullscreen"' feature policy
+https://bugs.webkit.org/show_bug.cgi?id=206806
+
+
+Patch by Jer Noble  on 2020-01-27
+Reviewed by Youenn Fablet.
+
+Source/WebCore:
+
+Test: http/tests/fullscreen/fullscreen-feature-policy.html
+
+The unprefixed version of the Fullscreen API has deprecated the 'allowfullscreen' iframe
+attribute in favor of the 'allow="fullscreen"' style attribute used by Feature Policy.
+Add support for such, including the specified handling for the legacy 'allowfullscreen'
+attribute.
+
+Note: this patch will (intentionally) change the default behavior of s. Previously
+any  without the "allowfullscreen" attribute would not be allowed to enter fullscreen
+mode. After this patch,  without the legacy attribute or an explici

[webkit-changes] [256390] branches/safari-609-branch

2020-02-11 Thread alancoon

Title: [256390] branches/safari-609-branch








Revision 256390
Author alanc...@apple.com
Date 2020-02-11 15:55:22 -0800 (Tue, 11 Feb 2020)


Log Message
Cherry-pick r255595. rdar://problem/59298183

Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=207121


Reviewed by Alex Christensen.

Source/WebKit:

WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView, in case we time out
while waiting for an answer from the WebProcess but the WebProcess eventually responds.

Change is covered by new API test.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::tryClose):

Tools:

Add API test coverage.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
* TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
(-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-609-branch/Source/WebKit/ChangeLog
branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-609-branch/Tools/ChangeLog
branches/safari-609-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
branches/safari-609-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm


Added Paths

branches/safari-609-branch/Tools/TestWebKitAPI/Tests/WebKit/beforeunload-slow.html




Diff

Modified: branches/safari-609-branch/Source/WebKit/ChangeLog (256389 => 256390)

--- branches/safari-609-branch/Source/WebKit/ChangeLog	2020-02-11 23:55:19 UTC (rev 256389)
+++ branches/safari-609-branch/Source/WebKit/ChangeLog	2020-02-11 23:55:22 UTC (rev 256390)
@@ -1,5 +1,54 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255595. rdar://problem/59298183
+
+Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=207121
+
+
+Reviewed by Alex Christensen.
+
+Source/WebKit:
+
+WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView, in case we time out
+while waiting for an answer from the WebProcess but the WebProcess eventually responds.
+
+Change is covered by new API test.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::tryClose):
+
+Tools:
+
+Add API test coverage.
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
+* TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
+(-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
+(-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
+(TEST):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-02-03  Chris Dumez  
+
+Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=207121
+
+
+Reviewed by Alex Christensen.
+
+WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView, in case we time out
+while waiting for an answer from the WebProcess but the WebProcess eventually responds.
+
+Change is covered by new API test.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::tryClose):
+
+2020-02-11  Alan Coon  
+
 Cherry-pick r255519. rdar://problem/59298166
 
 Unreviewed macOS build fix after r255518


Modified: branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (256389 => 256390)

--- branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-11 23:55:19 UTC (rev 256389)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-02-11 23:55:22 UTC (rev 256390)
@@ -1114,6 +1114,10 @@
 if (!weakThis)
 return;
 
+// If we timed out, don't ask the client to close again.
+if (!m_tryCloseTimeoutTimer.isActive())
+return;
+
 m_tryCloseTimeoutTimer.stop();
 if (shouldClose)
 closePage();


Modified: branches/safari-609-branch/Tools/ChangeLog (256389 => 256390)

--- branches/safari-609-branch/Tools/ChangeLog	2020-02-11 23:55:19 UTC (rev 256389)
+++ branches/safari-609-branch/Tools/ChangeLog	2020-02-11 23:55:22 UTC (rev 256390)
@@ -1,5 +1,55 @@
 2020-02-11  Alan Coon  
 
+Cherry-pick r255595. rdar://problem/59298183
+
+Regression(r25

[webkit-changes] [256394] trunk/LayoutTests

2020-02-11 Thread lawrence . j

Title: [256394] trunk/LayoutTests








Revision 256394
Author lawrenc...@apple.com
Date 2020-02-11 16:05:09 -0800 (Tue, 11 Feb 2020)


Log Message
[ iOS wk2 ] fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207596

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (256393 => 256394)

--- trunk/LayoutTests/ChangeLog	2020-02-11 23:55:30 UTC (rev 256393)
+++ trunk/LayoutTests/ChangeLog	2020-02-12 00:05:09 UTC (rev 256394)
@@ -1,3 +1,12 @@
+2020-02-11  Jason Lawrence  
+
+[ iOS wk2 ] fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=207596
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2020-02-11  Youenn Fablet  
 
 Parent service worker controller should be used for child iframe as per https://w3c.github.io/ServiceWorker/#control-and-use-window-client


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (256393 => 256394)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-11 23:55:30 UTC (rev 256393)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-02-12 00:05:09 UTC (rev 256394)
@@ -1400,4 +1400,6 @@
 
 webkit.org/b/207559 fast/parser/parser-yield-timing.html [ Pass Failure ]
 
-webkit.org/b/207583 http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/207583 http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html [ Pass Failure ]
+
+webkit.org/b/207596 fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [256395] trunk

2020-02-11 Thread ddkilzer

Title: [256395] trunk








Revision 256395
Author ddkil...@apple.com
Date 2020-02-11 16:13:55 -0800 (Tue, 11 Feb 2020)


Log Message
Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type



Patch by Rob Buis  and David Kilzer  on 2020-02-11
Reviewed by Rob Buis.

Source/WebCore:

Return StringView directly rather than wrapping
it in Optional, since StringView's can be null tested.

Tests: TestWebKitAPI.ParsedContentType

* platform/network/ParsedContentType.cpp:
(WebCore::parseToken):
(WebCore::parseQuotedString):
(WebCore::ParsedContentType::parseContentType): Don't set type
parameter if parameterName is null string.  Remove unneeded
`parameterName` variable; use keyRange.toString() instead.

Tools:

* TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
(TestWebKitAPI::TEST): Add more tests.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/ParsedContentType.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (256394 => 256395)

--- trunk/Source/WebCore/ChangeLog	2020-02-12 00:05:09 UTC (rev 256394)
+++ trunk/Source/WebCore/ChangeLog	2020-02-12 00:13:55 UTC (rev 256395)
@@ -1,3 +1,23 @@
+2020-02-11  Rob Buis  
+
+Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
+
+
+
+Reviewed by Rob Buis.
+
+Return StringView directly rather than wrapping
+it in Optional, since StringView's can be null tested.
+
+Tests: TestWebKitAPI.ParsedContentType
+
+* platform/network/ParsedContentType.cpp:
+(WebCore::parseToken):
+(WebCore::parseQuotedString):
+(WebCore::ParsedContentType::parseContentType): Don't set type
+parameter if parameterName is null string.  Remove unneeded
+`parameterName` variable; use keyRange.toString() instead.
+
 2020-02-11  Zalan Bujtas  
 
 [LFC] Do not create generic Layout::Box leaf boxes


Modified: trunk/Source/WebCore/platform/network/ParsedContentType.cpp (256394 => 256395)

--- trunk/Source/WebCore/platform/network/ParsedContentType.cpp	2020-02-12 00:05:09 UTC (rev 256394)
+++ trunk/Source/WebCore/platform/network/ParsedContentType.cpp	2020-02-12 00:13:55 UTC (rev 256395)
@@ -56,7 +56,7 @@
 
 using CharacterMeetsCondition = bool (*)(UChar);
 
-static Optional parseToken(StringView input, unsigned& startIndex, CharacterMeetsCondition characterMeetsCondition, Mode mode, bool skipTrailingWhitespace = false)
+static StringView parseToken(StringView input, unsigned& startIndex, CharacterMeetsCondition characterMeetsCondition, Mode mode, bool skipTrailingWhitespace = false)
 {
 unsigned inputLength = input.length();
 unsigned tokenStart = startIndex;
@@ -63,7 +63,7 @@
 unsigned& tokenEnd = startIndex;
 
 if (tokenEnd >= inputLength)
-return WTF::nullopt;
+return StringView();
 
 while (tokenEnd < inputLength && characterMeetsCondition(input[tokenEnd])) {
 if (mode == Mode::Rfc2045 && !isTokenCharacter(input[tokenEnd]))
@@ -72,7 +72,7 @@
 }
 
 if (tokenEnd == tokenStart)
-return WTF::nullopt;
+return StringView();
 if (skipTrailingWhitespace) {
 while (input[tokenEnd - 1] == ' ')
 --tokenEnd;
@@ -125,7 +125,7 @@
 return false;
 }
 
-static Optional parseQuotedString(StringView input, unsigned& startIndex)
+static StringView parseQuotedString(StringView input, unsigned& startIndex)
 {
 unsigned inputLength = input.length();
 unsigned quotedStringStart = startIndex + 1;
@@ -132,16 +132,16 @@
 unsigned& quotedStringEnd = startIndex;
 
 if (quotedStringEnd >= inputLength)
-return WTF::nullopt;
+return StringView();
 
 if (input[quotedStringEnd++] != '"' || quotedStringEnd >= inputLength)
-return WTF::nullopt;
+return StringView();
 
 bool lastCharacterWasBackslash = false;
 char currentCharacter;
 while ((currentCharacter = input[quotedStringEnd++]) != '"' || lastCharacterWasBackslash) {
 if (quotedStringEnd >= inputLength)
-return WTF::nullopt;
+return StringView();
 if (currentCharacter == '\\' && !lastCharacterWasBackslash) {
 lastCharacterWasBackslash = true;
 continue;
@@ -234,7 +234,7 @@
 
 unsigned contentTypeStart = index;
 auto typeRange = parseToken(m_contentType, index, isNotForwardSlash, mode);
-if (!typeRange || containsNonTokenCharacters(*typeRange, mode)) {
+if (typeRange.isNull() || containsNonTokenCharacters(typeRange, mode)) {
 LOG_ERROR("Invalid Content-Type, invalid type value.");
 return false;
 }
@@ -245,7 +245,7 @@
 }
 
 auto subTypeRange = parseToken(m_contentType, index, isNotSemicolon, mode, mode == Mode::MimeSniff);
-if (!subTypeRange || containsNonTokenCharacters(*subTypeRange, mode)) {

1 2 >

1 - 100 of 130 matches

Mail list logo