[webkit-changes] [WebKit/WebKit] 8efe42: [GTK][Skia] Add support for shared memory buffer i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8efe423f38b6d002cf19bbb2a0548ebe1a62f568 https://github.com/WebKit/WebKit/commit/8efe423f38b6d002cf19bbb2a0548ebe1a62f568 Author: Carlos Garcia Campos Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h Log Message: --- [GTK][Skia] Add support for shared memory buffer in accelerated compositing mode https://bugs.webkit.org/show_bug.cgi?id=270789 Reviewed by Adrian Perez de Castro. Create a cairo surface for the ShareableBitmap data. * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp: (WebKit::AcceleratedBackingStoreDMABuf::BufferSHM::didUpdateContents): * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.h: Canonical link: https://commits.webkit.org/276017@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 015bce: [GTK][Skia] Add support for non-accelerated rendering
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 015bce0872dcce7de3173685094b0a73dbfb93b6 https://github.com/WebKit/WebKit/commit/015bce0872dcce7de3173685094b0a73dbfb93b6 Author: Carlos Garcia Campos Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp M Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp Log Message: --- [GTK][Skia] Add support for non-accelerated rendering https://bugs.webkit.org/show_bug.cgi?id=270788 Reviewed by Adrian Perez de Castro. GTK uses cairo for non-accelerated rendering, so we need to render the ShareableBitmap with skia, but into a cairo surface. * Source/WebCore/platform/graphics/skia/ShareableBitmapSkia.cpp: (WebCore::ShareableBitmap::paint): * Source/WebKit/UIProcess/cairo/BackingStoreCairo.cpp: (WebKit::BackingStore::incorporateUpdate): (WebKit::BackingStore::scroll): Canonical link: https://commits.webkit.org/276018@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 071a8e: [Skia] Improve the way we decide when to use CPU o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 071a8e4ca7a56a134f7c3573e76e00b392515861 https://github.com/WebKit/WebKit/commit/071a8e4ca7a56a134f7c3573e76e00b392515861 Author: Carlos Garcia Campos Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/html/CanvasBase.cpp M Source/WebCore/html/HTMLCanvasElement.cpp M Source/WebCore/html/ImageBitmap.cpp M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp M Source/WebCore/page/Settings.yaml M Source/WebCore/platform/graphics/ImageBuffer.cpp M Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp M Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp M Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.h M Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp M Source/WebKit/SourcesWPE.txt M Source/WebKit/UIProcess/WebPreferences.cpp M Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp A Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp Log Message: --- [Skia] Improve the way we decide when to use CPU or GPU https://bugs.webkit.org/show_bug.cgi?id=270083 Reviewed by Adrian Perez de Castro. We normally assume we always want hardware acceleration for rendering with Skia, but there are several situations in which we need to use the CPU: - If we fail to create the GL context. - If we fail to create the SkSurface (for example because the size is bigger than the maximum render target size allowed). - When accelerated compositing is disabled. - When accelerated 2D canvas is disabled. - When CPU rendering is disabled. - When the canvas is too small (we use 128 * 129 to match chromium). * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::shouldAccelerate const): * Source/WebCore/html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createContext2d): (WebCore::HTMLCanvasElement::createContextBitmapRenderer): (WebCore::HTMLCanvasElement::paintsIntoCanvasBuffer const): (WebCore::HTMLCanvasElement::createImageBuffer const): * Source/WebCore/html/ImageBitmap.cpp: (WebCore::bufferRenderingMode): (WebCore::ImageBitmap::create): (WebCore::ImageBitmap::createImageBuffer): (WebCore::ImageBitmap::createBlankImageBuffer): (WebCore::ImageBitmap::createCompletionHandler): (WebCore::ImageBitmap::createFromBuffer): * Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::isAccelerated const): * Source/WebCore/page/Settings.yaml: * Source/WebCore/platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::create): * Source/WebCore/platform/graphics/skia/ImageBufferSkiaAcceleratedBackend.cpp: (WebCore::ImageBufferSkiaAcceleratedBackend::create): * Source/WebCore/platform/graphics/skia/PlatformDisplaySkia.cpp: (WebCore::PlatformDisplay::skiaGLContext): * Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.cpp: (WebCore::SkiaAcceleratedBufferPool::acquireBuffer): (WebCore::SkiaAcceleratedBufferPool::createAcceleratedBuffer): * Source/WebCore/platform/graphics/skia/SkiaAcceleratedBufferPool.h: * Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayerSkia.cpp: (WebCore::CoordinatedGraphicsLayer::paintTile): * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/WebPreferences.cpp: * Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp: (WebKit::WebPreferences::platformInitializeStore): * Source/WebKit/UIProcess/wpe/WebPreferencesWPE.cpp: Copied from Source/WebKit/UIProcess/gtk/WebPreferencesGtk.cpp. (WebKit::WebPreferences::platformInitializeStore): * Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: (WebKit::CompositingCoordinator::CompositingCoordinator): (WebKit::skiaForceUseCpuRendering): Deleted. Canonical link: https://commits.webkit.org/276016@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a1c08: REGRESSION(276012@main): CMake fails with GObject-...
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3a1c08120188470f531a1a3a4837b496cc900bd7
https://github.com/WebKit/WebKit/commit/3a1c08120188470f531a1a3a4837b496cc900bd7
Author: Adrian Perez de Castro
Date: 2024-03-13 (Wed, 13 Mar 2024)
Changed paths:
M Source/WebKit/PlatformGTK.cmake
Log Message:
---
REGRESSION(276012@main): CMake fails with GObject-Introspection disabled
https://bugs.webkit.org/show_bug.cgi?id=269377
Reviewed by Michael Catanzaro and Philippe Normand.
* Source/WebKit/PlatformGTK.cmake: Quote the expansion of ${GI_VERSION}
to ensure VERSION_GREATER_EQUAL has at least an empty string as value
to compare against; otherwise when the variable is undefined there was
no left-hand side of the comparison, which resulted in CMake erroring
due to wrong syntax.
Canonical link: https://commits.webkit.org/276019@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 069343: [WPE][GTK] Unreviewed, fix build for Ubuntu LTS af...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 069343ef2025b751397cc74952875c12f6940c9d https://github.com/WebKit/WebKit/commit/069343ef2025b751397cc74952875c12f6940c9d Author: Vitaly Dyachkov Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/PlatformGTK.cmake M Source/WebKit/PlatformWPE.cmake Log Message: --- [WPE][GTK] Unreviewed, fix build for Ubuntu LTS after 276012@main * Source/WebKit/PlatformGTK.cmake: * Source/WebKit/PlatformWPE.cmake: Canonical link: https://commits.webkit.org/276020@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 333abc: Remove FIXME about `resetClip` in CanvasDrawPath.idl
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 333abc3ffa529b870b611f130f3745834f3821eb https://github.com/WebKit/WebKit/commit/333abc3ffa529b870b611f130f3745834f3821eb Author: Ahmad Saleem Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/html/canvas/CanvasDrawPath.idl Log Message: --- Remove FIXME about `resetClip` in CanvasDrawPath.idl https://bugs.webkit.org/show_bug.cgi?id=270890 Reviewed by Simon Fraser. There is no web specification about `resetClip`, so no reason to keep this FIXME. > https://html.spec.whatwg.org/multipage/canvas.html#canvasdrawpath It was trialed in past for implementation in bug 82801, which was concluded with similar conclusion as below W3C thread: > https://lists.w3.org/Archives/Public/public-whatwg-archive/2013Oct/0057.html "The reason resetClip() is a bad API is that it breaks the ability..." * Source/WebCore/html/canvas/CanvasDrawPath.idl: Canonical link: https://commits.webkit.org/276022@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85ca8b: Clean up serialized type info for IPC test API
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85ca8bbdbc74fb2a06470bfc623af965a5db6ee1 https://github.com/WebKit/WebKit/commit/85ca8bbdbc74fb2a06470bfc623af965a5db6ee1 Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in M Source/WebKit/Scripts/generate-serializers.py M Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp M Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp M Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/Shared/WebGPU/WebGPUColor.serialization.in M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: --- Clean up serialized type info for IPC test API https://bugs.webkit.org/show_bug.cgi?id=270884 rdar://124491555 Reviewed by Mike Wyrzykowski. This fixes a number of issues: Incorrect spaces in serialization.in files Missing C preprocessor guards around type info for types with conditions Missing wrapper information for webkit_secure_coding_types and cf_types I also improved the test to know about more container types and fundamental types. * Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.messages.in: * Source/WebKit/Scripts/generate-serializers.py: (generate_one_serialized_type_info): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp: * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::allSerializedTypes): * Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/Shared/WebGPU/WebGPUColor.serialization.in: * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/276023@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 722de1: Using ruby tag within a hanging-punctuation specif...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 722de1a0a5f59ea87d662ccbc9c304b7bbf0e76c https://github.com/WebKit/WebKit/commit/722de1a0a5f59ea87d662ccbc9c304b7bbf0e76c Author: Alan Baradlay Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: A LayoutTests/fast/text/hanging-punctuation-with-bidi-expected.html A LayoutTests/fast/text/hanging-punctuation-with-bidi.html M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp M Source/WebCore/layout/formattingContexts/inline/InlineLine.h M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp M Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp Log Message: --- Using ruby tag within a hanging-punctuation specifies element, hanging appears not to apply. https://bugs.webkit.org/show_bug.cgi?id=270780 Reviewed by Antti Koivisto. Let's take punctuation offset into account when processing (left-to-right) bidi based inline content. 1. Pass leading punctuation width over to display content build as part of the line layout result 2. Offset "visual left start position" with the punctuation width (negative offset) - non-bidi content works fine as we already take this negative offset into account while building the line -which we lose when dealing with bidi reordering - right-to-left is also fine as punctuation width being visually trailing does not contribute to visual left * LayoutTests/fast/text/hanging-punctuation-with-bidi-expected.html: Added. * LayoutTests/fast/text/hanging-punctuation-with-bidi.html: Added. * Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp: (WebCore::Layout::Line::close): * Source/WebCore/layout/formattingContexts/inline/InlineLine.h: (WebCore::Layout::Line::HangingContent::leadingPunctuationWidth const): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::LineBuilder::layoutInlineContent): * Source/WebCore/layout/formattingContexts/inline/LineLayoutResult.h: * Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp: (WebCore::Layout::InlineDisplayContentBuilder::processBidiContent): Canonical link: https://commits.webkit.org/276026@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 99e7a2: Remove WebVTTRubyElement and WebVTTRubyTextElement
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 99e7a283e2ed8bda5d0455d2cabb581ee66cf3d9 https://github.com/WebKit/WebKit/commit/99e7a283e2ed8bda5d0455d2cabb581ee66cf3d9 Author: Antti Koivisto Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/media/track/webvtt-ruby-expected.txt M LayoutTests/media/track/webvtt-ruby.html M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css M Source/WebCore/css/SelectorCheckerTestFunctions.h M Source/WebCore/css/html.css M Source/WebCore/css/mediaControls.css M Source/WebCore/dom/Node.h M Source/WebCore/html/track/VTTCue.cpp M Source/WebCore/html/track/WebVTTElement.cpp M Source/WebCore/html/track/WebVTTElement.h M Source/WebCore/html/track/WebVTTParser.cpp M Source/WebCore/style/ElementRuleCollector.cpp M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- Remove WebVTTRubyElement and WebVTTRubyTextElement https://bugs.webkit.org/show_bug.cgi?id=270852 rdar://problem/124449628 Reviewed by Alan Baradlay. WebVTT tree is implemented using an Element subclass, except for ruby elements. For those there were special subclasses inheriting from RubyElement and RubyTextElement. These are no longer needed since ruby is now CSS based. We can style WebVTT ruby elements similarly to other WebVTT elements. * LayoutTests/media/track/webvtt-ruby-expected.txt: * LayoutTests/media/track/webvtt-ruby.html: Turns our offsetFoo functions are only available on HTMLElement. Since all WebVTT elements now inherit from plain Element we can no longer use it to inspect the internal state. Use more universal getBoundingClientRect() instead. * Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css: ([useragentpart="-webkit-media-text-track-display"] ruby): ([useragentpart="-webkit-media-text-track-display"] ruby > rt): ([useragentpart="-webkit-media-text-track-display"] ruby > :not(ruby)): Add a relevant subset of ruby rules to the text-track stylesheet, similar to other WebVTT elements. The rules on html.css don't match since these elements are not in HTML namespace. * Source/WebCore/css/SelectorCheckerTestFunctions.h: (WebCore::matchesLangPseudoClass): (WebCore::matchesFutureCuePseudoClass): (WebCore::matchesPastCuePseudoClass): * Source/WebCore/css/mediaControls.css: ([useragentpart="-webkit-media-text-track-display"] ruby): ([useragentpart="-webkit-media-text-track-display"] ruby > rt): ([useragentpart="-webkit-media-text-track-display"] ruby > :not(ruby)): * Source/WebCore/dom/Node.h: (WebCore::Node::isWebVTTElement const): (WebCore::Node::isWebVTTRubyElement const): Deleted. (WebCore::Node::isWebVTTRubyTextElement const): Deleted. * Source/WebCore/html/track/VTTCue.cpp: (WebCore::VTTCue::markFutureAndPastNodes): * Source/WebCore/html/track/WebVTTElement.cpp: (WebCore::WebVTTElement::WebVTTElement): (WebCore::m_language): (WebCore::WebVTTElement::create): (WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren): (WebCore::WebVTTElement::createEquivalentHTMLElement): (WebCore::WebVTTElementImpl::create): Deleted. Remove the now-unnedeed WebVTTElement/WebVTTElementImpl split. (WebCore::WebVTTElementImpl::cloneElementWithoutAttributesAndChildren): Deleted. (WebCore::WebVTTElementImpl::createEquivalentHTMLElement): Deleted. * Source/WebCore/html/track/WebVTTElement.h: (WebCore::WebVTTElementImpl::setWebVTTNodeType): Deleted. (WebCore::WebVTTElementImpl::webVTTNodeType const): Deleted. (WebCore::WebVTTElementImpl::isPastNode const): Deleted. (WebCore::WebVTTElementImpl::setIsPastNode): Deleted. (WebCore::WebVTTElementImpl::language const): Deleted. (WebCore::WebVTTElementImpl::setLanguage): Deleted. (WebCore::WebVTTElementImpl::voiceAttributeName): Deleted. (WebCore::WebVTTElementImpl::langAttributeName): Deleted. (WebCore::WebVTTElementImpl::WebVTTElementImpl): Deleted. * Source/WebCore/html/track/WebVTTParser.cpp: (WebCore::WebVTTTreeBuilder::constructTreeFromToken): * Source/WebCore/style/ElementRuleCollector.cpp: (WebCore::Style::ElementRuleCollector::collectMatchingUserAgentPartRules): * Source/WebCore/style/StyleAdjuster.cpp: (WebCore::Style::hasUnsupportedRubyDisplay): Relax the check to allow any elements called "ruby" or "rt" to have ruby display type, not just the HTML ones Canonical link: https://commits.webkit.org/276025@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4ac62b: [LBSE] Rebaseline svg tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4ac62bf9551810c9b37e8e6c3dd5e9f1c38142f5 https://github.com/WebKit/WebKit/commit/4ac62bf9551810c9b37e8e6c3dd5e9f1c38142f5 Author: Rob Buis Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/animate-interact-pevents-03-t-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/animate-interact-pevents-04-t-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/conform-viewers-03-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/filters-displace-01-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/interact-cursor-01-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/interact-pevents-08-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/interact-pevents-09-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/linking-a-09-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/paths-dom-01-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/styling-css-05-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/styling-pres-02-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-02-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-03-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-04-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-06-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-07-t-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-align-08-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-altglyph-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-altglyph-02-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-altglyph-03-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-deco-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-dom-01-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-fonts-05-f-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-path-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-tref-03-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-tselect-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-tspan-01-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/import/text-tspan-02-b-manual-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-dynamic-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/lang-attribute-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/multiple-textpaths-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/no-background-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/no-margin-border-padding-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-005-expected.txt M LayoutTests/platform/mac-sonoma-wk2-lbse-text/imported/w3c/web-platform-tests/svg/text/reftests/text-inline-size-006-expected.txt
[webkit-changes] [WebKit/WebKit] e87abc: Add bounds check when writing multidimensional tex...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e87abc019b58b6bec3af3db905ff83ba39a9302e https://github.com/WebKit/WebKit/commit/e87abc019b58b6bec3af3db905ff83ba39a9302e Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/webgpu/multidimensional-texture-bounds-expected.txt A LayoutTests/fast/webgpu/multidimensional-texture-bounds.html M Source/WebGPU/WebGPU/Queue.mm Log Message: --- Add bounds check when writing multidimensional texture https://bugs.webkit.org/show_bug.cgi?id=270896 rdar://124475299 Reviewed by Mike Wyrzykowski. * LayoutTests/TestExpectations: * LayoutTests/fast/webgpu/multidimensional-texture-bounds-expected.txt: Added. * LayoutTests/fast/webgpu/multidimensional-texture-bounds.html: Added. * Source/WebGPU/WebGPU/Queue.mm: (WebGPU::Queue::writeTexture): Canonical link: https://commits.webkit.org/276024@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 937428: Remove Quirk when booking.com sends simple JPEG in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9374282dca203b624bed17ffc1fd178216c19e0a https://github.com/WebKit/WebKit/commit/9374282dca203b624bed17ffc1fd178216c19e0a Author: Karl Dubost Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/loader/cache/CachedResourceLoader.cpp M Source/WebCore/loader/cache/CachedResourceRequest.cpp M Source/WebCore/loader/cache/CachedResourceRequest.h M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Remove Quirk when booking.com sends simple JPEG instead of JPEG2000 to WebKit on iOS https://bugs.webkit.org/show_bug.cgi?id=269876 rdar://123409087 Reviewed by Chris Dumez. Booking.com doesn't JPEG2 anymore to Safari since March 8, 2024. The Quirk can be removed. * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::updateRequestAndAddExtraFields): * Source/WebCore/loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::prepareFetch): * Source/WebCore/loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::acceptHeaderValueFromType): (WebCore::CachedResourceRequest::setAcceptHeaderIfNone): * Source/WebCore/loader/cache/CachedResourceRequest.h: * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldSendLongerAcceptHeaderQuirk): Deleted. * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/276027@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 50f118: [WebCore] Optimize WidthCache further
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 50f118c27cfa82d3409c1ea3addf2aa07d2904d7 https://github.com/WebKit/WebKit/commit/50f118c27cfa82d3409c1ea3addf2aa07d2904d7 Author: Yusuke Suzuki Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WTF/wtf/HashTraits.h M Source/WebCore/platform/graphics/WidthCache.h Log Message: --- [WebCore] Optimize WidthCache further https://bugs.webkit.org/show_bug.cgi?id=270901 rdar://124512596 Reviewed by Ryosuke Niwa. This patch further optimizes WidthCache. 1. Ensure that SmallStringKey constructor is always inlined. 2. Add copySmallCharacters. We know that this string is <= 16, very small. Just doing for-loop is faster for this level of size. 3. Add FloatWithZeroEmptyKeyHashTraits. float / double uses infinity for empty value. But this means that we cannot use zeroed empty value for HashMap even though T's empty value is zero. We add FloatWithZeroEmptyKeyHashTraits which uses 0 for empty value, so that we can ensure that KeyValuePair's empty value is zero. Also, using character + 1 for key in SingleCharMap so that it can make empty value zero too. * Source/WTF/wtf/HashTraits.h: (WTF::FloatWithZeroEmptyKeyHashTraits::emptyValue): (WTF::FloatWithZeroEmptyKeyHashTraits::constructDeletedValue): (WTF::FloatWithZeroEmptyKeyHashTraits::isDeletedValue): * Source/WebCore/platform/graphics/WidthCache.h: (WebCore::WidthCache::SmallStringKey::SmallStringKey): (WebCore::WidthCache::SmallStringKey::copySmallCharacters): (WebCore::WidthCache::addSlowCase): Canonical link: https://commits.webkit.org/276034@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 515f00: Remove RubyElement and RubyTextElement
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 515f002ff6fda37c0f6f4826bd85f919dba805ad https://github.com/WebKit/WebKit/commit/515f002ff6fda37c0f6f4826bd85f919dba805ad Author: Antti Koivisto Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/html/HTMLTagNames.in R Source/WebCore/html/RubyElement.cpp R Source/WebCore/html/RubyElement.h R Source/WebCore/html/RubyTextElement.cpp R Source/WebCore/html/RubyTextElement.h M Source/WebCore/html/track/WebVTTElement.cpp M Source/WebCore/html/track/WebVTTElement.h M Source/WebCore/style/StyleAdjuster.cpp Log Message: --- Remove RubyElement and RubyTextElement https://bugs.webkit.org/show_bug.cgi?id=270749 rdar://124331645 Reviewed by Tim Nguyen. Ruby does not expose any unique interface so these HTMLElement subclasses are not needed. * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/html/HTMLTagNames.in: * Source/WebCore/html/RubyElement.cpp: Removed. * Source/WebCore/html/RubyElement.h: Removed. * Source/WebCore/html/RubyTextElement.cpp: Removed. * Source/WebCore/html/RubyTextElement.h: Removed. (WebCore::VTTCue::markFutureAndPastNodes): * Source/WebCore/html/track/WebVTTElement.cpp: (WebCore::WebVTTElementImpl::createEquivalentHTMLElement): Canonical link: https://commits.webkit.org/276037@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ceb3a8: [iOS] Switch InlineMediaPlaybackRequiresPlaysInlin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ceb3a87f20ef4c344c0e0e533091b1235c36ef37 https://github.com/WebKit/WebKit/commit/ceb3a87f20ef4c344c0e0e533091b1235c36ef37 Author: Youenn Fablet Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- [iOS] Switch InlineMediaPlaybackRequiresPlaysInlineAttribute to false by default https://bugs.webkit.org/show_bug.cgi?id=270691 rdar://124264770 Reviewed by Eric Carlson. We started to add quirks to remove playsinline requirement for some websites. We can try now to do the reverse as a way to deprecate playsinline. Set the playsinline requirement to false by default on iOS. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/276029@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 305fc1: [hooks/pre-push] Make our pre-push hook case insen...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 305fc1b1cf5931248c265a39dfc2aa272b8cd1d6 https://github.com/WebKit/WebKit/commit/305fc1b1cf5931248c265a39dfc2aa272b8cd1d6 Author: Jonathan Bedard Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Tools/Scripts/hooks/pre-push M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py Log Message: --- [hooks/pre-push] Make our pre-push hook case insensitive https://bugs.webkit.org/show_bug.cgi?id=254303 rdar://107109166 Reviewed by Aakash Jain. Make all our remote logic in our pre-push hook case insensitive. * Tools/Scripts/hooks/pre-push: * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py: (InstallHooks._security_levels): (InstallHooks.main): Canonical link: https://commits.webkit.org/276030@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 349c5a: Use the rule type as a prefix for the DNR database...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 349c5a3059a9047c7d9939deab1e2bbd4dc08e10 https://github.com/WebKit/WebKit/commit/349c5a3059a9047c7d9939deab1e2bbd4dc08e10 Author: Brian Weinstein Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestSQLiteStore.mm Log Message: --- Use the rule type as a prefix for the DNR database table https://bugs.webkit.org/show_bug.cgi?id=270911 rdar://121455049 Reviewed by Timothy Hatcher. This matches the current database format in Safari, and having these formats match will help us migrate existing extension data over to WebKit's new file structure. While we're here, we are changing the name of the database file on disk. Without this, we would need to bump the schema version, which would lead to issues when performing the previously described migration. * Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestSQLiteStore.mm: (-[_WKWebExtensionDeclarativeNetRequestSQLiteStore initWithUniqueIdentifier:storageType:directory:usesInMemoryDatabase:]): Canonical link: https://commits.webkit.org/276033@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 81b1ab: Provide canSuspend info to didExceedMemoryFootprin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 81b1ab5cf1c83eaace71f65207569561ad8d0ba6 https://github.com/WebKit/WebKit/commit/81b1ab5cf1c83eaace71f65207569561ad8d0ba6 Author: Ben Nham Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WTF/wtf/MemoryPressureHandler.cpp M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm M Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Source/WebKit/UIProcess/WebProcessProxy.cpp M Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/MemoryFootprintThreshold.mm Log Message: --- Provide canSuspend info to didExceedMemoryFootprintThreshold event https://bugs.webkit.org/show_bug.cgi?id=270646 rdar://124165615 Reviewed by Chris Dumez. We fire the didExceedMemoryFootprintThreshold analytics event to detect sites and/or processes with excessive memory usage. We also want to log whether or not those sites are ever allowed to suspend in the event. I also changed the event to log the threshold being violated rather than the actual footprint value of the process. This works better with the way we want to analyze the data. * Source/WTF/wtf/MemoryPressureHandler.cpp: (WTF::MemoryPressureHandler::measurementTimerFired): * Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm: * Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h: * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::hasAllowedToRunInTheBackgroundActivity const): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::didExceedMemoryFootprintThreshold): * Source/WebKit/UIProcess/WebsiteData/WebsiteDataStoreClient.h: (WebKit::WebsiteDataStoreClient::didExceedMemoryFootprintThreshold): * Tools/TestWebKitAPI/Tests/WebKitCocoa/MemoryFootprintThreshold.mm: (-[MemoryFootprintDelegate websiteDataStore:domain:didExceedMemoryFootprintThreshold:withPageCount:processLifetime:inForeground:wasPrivateRelayed:canSuspend:]): (-[MemoryFootprintDelegate websiteDataStore:domain:didExceedMemoryFootprintThreshold:withPageCount:processLifetime:inForeground:wasPrivateRelayed:]): Deleted. Canonical link: https://commits.webkit.org/276032@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d83537: REGRESSION (iOS 17.4, macOS 14.4, 270890@main): An...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d83537abc7e7901653c42553b3f7d71505f5dbc8 https://github.com/WebKit/WebKit/commit/d83537abc7e7901653c42553b3f7d71505f5dbc8 Author: Antti Koivisto Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: A LayoutTests/fast/animation/animation-with-DOM-mutation-and-display-none-expected.html A LayoutTests/fast/animation/animation-with-DOM-mutation-and-display-none.html M Source/WebCore/style/StyleTreeResolver.cpp Log Message: --- REGRESSION (iOS 17.4, macOS 14.4, 270890@main): Animating element with display: none still remain visible https://bugs.webkit.org/show_bug.cgi?id=270697 rdar://124289418 Reviewed by Antoine Quint and Darin Adler. The page sets the root of the overlay containing tree to display:none and immediately (before style recall) reinserts it into another position in the document, causing render tree teardown. When we recompute the style (applying display:none) we don't consider it a style change since there was no existing style due to the earlier teardown. In this case we fail to clear lastStyleChangeEventStyle which has been set by an animation on the element. Another animation triggered style recalc comes along, takes the optimized AnimationOnly code path and picks up the lastStyleChangeEventStyle (which doesn't have display:none) bringing the element back alive. * LayoutTests/fast/animation/animation-with-DOM-mutation-and-display-none-expected.html: Added. * LayoutTests/fast/animation/animation-with-DOM-mutation-and-display-none.html: Added. * Source/WebCore/style/StyleTreeResolver.cpp: (WebCore::Style::TreeResolver::resolveElement): Fix by clearing lastStyleChangeEventStyle also when we have a style change to display:none without existing renderer. Canonical link: https://commits.webkit.org/276035@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 40a84b: Do not promote MediaStream HTMLMediaElement to be ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 40a84b10af90bfa6acfd1a8506517a304c699381 https://github.com/WebKit/WebKit/commit/40a84b10af90bfa6acfd1a8506517a304c699381 Author: Youenn Fablet Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: A LayoutTests/fast/mediastream/now-playing-and-mediastream-expected.txt A LayoutTests/fast/mediastream/now-playing-and-mediastream.html M LayoutTests/platform/glib/TestExpectations M Source/WebCore/html/MediaElementSession.cpp Log Message: --- Do not promote MediaStream HTMLMediaElement to be NowPlaying without the web page using the MediaSession API https://bugs.webkit.org/show_bug.cgi?id=270522 rdar://121562032 Reviewed by Eric Carlson. When a web page is becoming NowPlaying, it has to react to Play/Pause commands from the user or from user actions like removing AirPods. Pausing/Resuming media from regular video streaming is a good default, but pausing/resuming live video streaming (no buffering) is not a great default, like can be seen in video conferencing or game streaming web sites. We further restrict MediaStream HTMLMediaElement to becoming NowPlaying to the case where the website is using MediaSession API. Either it should set metadata or provide action handlers. * LayoutTests/fast/mediastream/now-playing-and-mediastream-expected.txt: Added. * LayoutTests/fast/mediastream/now-playing-and-mediastream.html: Added. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/html/MediaElementSession.cpp: (WebCore::MediaElementSession::hasNowPlayingInfo const): (WebCore::MediaElementSession::playbackStateChanged): (WebCore::MediaElementSession::actionHandlersChanged): Canonical link: https://commits.webkit.org/276028@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 67969c: [JSC] RegExp /u flag doesn't respect atomicity of ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 67969c218ddf357855d3c26ca4769b194fb1f4db https://github.com/WebKit/WebKit/commit/67969c218ddf357855d3c26ca4769b194fb1f4db Author: Michael Saboff Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: A JSTests/stress/regexp-unicode-dangling-surrogates.js M JSTests/test262/expectations.yaml M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h M Source/JavaScriptCore/yarr/YarrInterpreter.cpp M Source/JavaScriptCore/yarr/YarrJIT.cpp M Source/JavaScriptCore/yarr/YarrJITRegisters.h Log Message: --- [JSC] RegExp /u flag doesn't respect atomicity of surrogate pairs https://bugs.webkit.org/show_bug.cgi?id=267011 rdar://124217243 Reviewed by Yusuke Suzuki. Fixed bug where a dangling surrogate in a pattern matches half a valid surrogate pair in a subject string. Updated the reading of surrogates that when we read starting in the middle of a valid surrogate pair, we return an error code point which we never match. Updated backtracking for non-greedy character class matching to use the start index as the appropriate index to reset when we fail to match, instead of doing math with the current match count. The fix above originally landed Jan 13, but it regressed some Unicode performance tests and was subsequently rolled out. This change builds on the prior fix by adding three optimizations to mitigate the performance loss in the earlier fix.. 1. We don't need to check for the errorCodePoint (-1) if we read a dangling surrogate when we are matching a normal, non-inverted atoms. The errorCodePoint won't match in that case. For inverted atoms, we still need to check for the errorCodePoint and fail matching that atom. 2. Changed the code emitted for a character class that has only one range. Before this change, we'd emit all range checks with each range check's failure target address the instruction right after the two conditional branches. This works fine if there is another range check. When all range checks have been performed, we add a branch to the failure (backtracking) code. If the character class has only one range and doesn't have any list of single characters, we can eliminate the branch to failure code by changing the two conditional branches that make up a range check go directly to the failure code. This change appears to help JetStream2/babylon-wtp by at least 1.5+%. 3. (ARM64 only) When we read a non-BMB code point, consisting of two surrogate code units, and we fail to match any atom in the body of a RegExp, we were incrementing the subject string index by 1 and going back to the top of the loop to start matching the pattern again. Now we dedicate a register to hold either 0 or 1 depending on the width of the first character read for that loop iteration. When advancing the index for the next iteration, we add the value of that register to the updated index. This eliminates one iteration through the matching loop for each non-BMP code point that doesn't match. This change appears to help JetStream2/UniPoker by 3+%. Added a new test and updated the Test262 exceptions file. * JSTests/stress/regexp-unicode-dangling-surrogates.js: Added. (arrayToString): (objectToString): (dumpValue): (compareArray): (compareGroups): (testRegExp): (testRegExpSyntaxError): * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/assembler/MacroAssemblerARM64.h: (JSC::MacroAssemblerARM64::moveConditionallyTest32): Added to conditionally zero a register. (JSC::MacroAssemblerARM64::addOneConditionally32): Added to conditionally increment a register. * Source/JavaScriptCore/yarr/YarrInterpreter.cpp: (JSC::Yarr::Interpreter::InputStream::readChecked): * Source/JavaScriptCore/yarr/YarrJIT.cpp: * Source/JavaScriptCore/yarr/YarrJITRegisters.h: Canonical link: https://commits.webkit.org/276031@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60aeff: Use smart pointers to store references to ObjectHeap
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60aeffa2f9b8aaa7da3ae2fe2815090ca79f2e9d https://github.com/WebKit/WebKit/commit/60aeffa2f9b8aaa7da3ae2fe2815090ca79f2e9d Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.cpp M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCompositorIntegrationImpl.h M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPUCompositorIntegration.h M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp M Source/WebKit/GPUProcess/ShapeDetection/RemoteBarcodeDetector.cpp M Source/WebKit/GPUProcess/ShapeDetection/RemoteBarcodeDetector.h M Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.cpp M Source/WebKit/GPUProcess/ShapeDetection/RemoteFaceDetector.h M Source/WebKit/GPUProcess/ShapeDetection/RemoteTextDetector.cpp M Source/WebKit/GPUProcess/ShapeDetection/RemoteTextDetector.h M Source/WebKit/GPUProcess/ShapeDetection/ShapeDetectionObjectHeap.h M Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteAdapter.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroup.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBindGroupLayout.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteBuffer.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandBuffer.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteCompositorIntegration.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteComputePipeline.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteDevice.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteExternalTexture.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePipelineLayout.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemotePresentationContext.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQuerySet.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundle.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderBundleEncoder.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPipeline.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteSampler.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteShaderModule.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTexture.h M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.cpp M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteTextureView.h M Source/WebKit/GPUProcess/graphics/WebGPU/WebGPUObjectHeap.h M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.cpp M Source/WebKit/GPUProcess/mac/LocalAudioSessionRoutingArbitrator.h M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.cpp M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxy.h M Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp M
[webkit-changes] [WebKit/WebKit] 3412f1: [Gardening]: REGRESSION (275949@main): 18 imported...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3412f17868274cc523f247c8dbc336a73d273abe https://github.com/WebKit/WebKit/commit/3412f17868274cc523f247c8dbc336a73d273abe Author: Ben Schwartz Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/ios-wk2/TestExpectations M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: REGRESSION (275949@main): 18 imported WPT /i18n/.../css-text-line-break* tests are consistent/flaky failures. https://bugs.webkit.org/show_bug.cgi?id=270860 rdar://124463423 Unreviewed test gardening. Adding more tests that are failing as a result of the same issue. * LayoutTests/platform/ios-wk2/TestExpectations: * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/276046@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 70fb31: Remove LegacyEllipsisBox
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 70fb31eed2b668ecf8ac2bf9492d4918856ab2eb https://github.com/WebKit/WebKit/commit/70fb31eed2b668ecf8ac2bf9492d4918856ab2eb Author: Antti Koivisto Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/Headers.cmake M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h M Source/WebCore/rendering/EllipsisBoxPainter.cpp R Source/WebCore/rendering/LegacyEllipsisBox.cpp R Source/WebCore/rendering/LegacyEllipsisBox.h M Source/WebCore/rendering/LegacyInlineBox.cpp M Source/WebCore/rendering/LegacyInlineBox.h M Source/WebCore/rendering/LegacyInlineFlowBox.cpp M Source/WebCore/rendering/LegacyInlineFlowBox.h M Source/WebCore/rendering/LegacyInlineTextBox.cpp M Source/WebCore/rendering/LegacyInlineTextBox.h M Source/WebCore/rendering/LegacyLineLayout.cpp M Source/WebCore/rendering/LegacyLineLayout.h M Source/WebCore/rendering/LegacyRootInlineBox.cpp M Source/WebCore/rendering/LegacyRootInlineBox.h M Source/WebCore/rendering/RenderBlock.h M Source/WebCore/rendering/RenderBlockFlow.h M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp M Source/WebCore/rendering/RenderElement.cpp M Source/WebCore/rendering/RenderElement.h M Source/WebCore/rendering/RenderText.cpp M Source/WebCore/rendering/RenderTextLineBoxes.cpp M Source/WebCore/rendering/svg/SVGInlineTextBox.cpp Log Message: --- Remove LegacyEllipsisBox https://bugs.webkit.org/show_bug.cgi?id=270914 rdar://124538996 Reviewed by Alan Baradlay. We now only use LegacyInlineBoxes for SVG which doesn't support ellipsis (or have a concept of text overflow in general). * Source/WebCore/Headers.cmake: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/layout/integration/inline/InlineIteratorLineBoxLegacyPath.h: (WebCore::InlineIterator::LineBoxIteratorLegacyPath::hasEllipsis const): (WebCore::InlineIterator::LineBoxIteratorLegacyPath::ellipsisVisualRectIgnoringBlockDirection const): (WebCore::InlineIterator::LineBoxIteratorLegacyPath::ellipsisText const): * Source/WebCore/rendering/EllipsisBoxPainter.cpp: * Source/WebCore/rendering/LegacyEllipsisBox.cpp: Removed. * Source/WebCore/rendering/LegacyEllipsisBox.h: Removed. * Source/WebCore/rendering/LegacyInlineBox.cpp: (WebCore::LegacyInlineBox::selectionState const): (WebCore::LegacyInlineBox::canAccommodateEllipsis const): Deleted. (WebCore::LegacyInlineBox::placeEllipsisBox): Deleted. * Source/WebCore/rendering/LegacyInlineBox.h: (WebCore::LegacyInlineBox::isInlineTextBox const): (WebCore::LegacyInlineBox::setEndsWithBreak): (WebCore::LegacyInlineBox::isEllipsisBox const): Deleted. (WebCore::LegacyInlineBox::clearTruncation): Deleted. (WebCore::LegacyInlineBox::hasEllipsisBox const): Deleted. (WebCore::LegacyInlineBox::setHasEllipsisBox): Deleted. * Source/WebCore/rendering/LegacyInlineFlowBox.cpp: (WebCore::LegacyInlineFlowBox::nodeAtPoint): (WebCore::LegacyInlineFlowBox::canAccommodateEllipsis const): Deleted. (WebCore::LegacyInlineFlowBox::placeEllipsisBox): Deleted. (WebCore::LegacyInlineFlowBox::clearTruncation): Deleted. * Source/WebCore/rendering/LegacyInlineFlowBox.h: * Source/WebCore/rendering/LegacyInlineTextBox.cpp: (WebCore::LegacyInlineTextBox::nodeAtPoint): (WebCore::LegacyInlineTextBox::paint): (WebCore::LegacyInlineTextBox::selectableRange const): (WebCore::LegacyInlineTextBox::placeEllipsisBox): Deleted. * Source/WebCore/rendering/LegacyInlineTextBox.h: (WebCore::LegacyInlineTextBox::truncation const): Deleted. * Source/WebCore/rendering/LegacyLineLayout.cpp: (WebCore::LegacyLineLayout::layoutLineBoxes): (WebCore::LegacyLineLayout::deleteEllipsisLineBoxes): Deleted. (WebCore::LegacyLineLayout::checkLinesForTextOverflow): Deleted. * Source/WebCore/rendering/LegacyLineLayout.h: * Source/WebCore/rendering/LegacyRootInlineBox.cpp: (WebCore::LegacyRootInlineBox::~LegacyRootInlineBox): (WebCore::LegacyRootInlineBox::adjustPosition): (WebCore::LegacyRootInlineBox::detachEllipsisBox): Deleted. (WebCore::LegacyRootInlineBox::clearTruncation): Deleted. (WebCore::LegacyRootInlineBox::lineCanAccommodateEllipsis): Deleted. (WebCore::LegacyRootInlineBox::placeEllipsis): Deleted. (WebCore::LegacyRootInlineBox::placeEllipsisBox): Deleted. (WebCore::LegacyRootInlineBox::paintEllipsisBox const): Deleted. (WebCore::LegacyRootInlineBox::paint): Deleted. (WebCore::LegacyRootInlineBox::nodeAtPoint): Deleted. (WebCore::LegacyRootInlineBox::ellipsisBox const): Deleted. * Source/WebCore/rendering/LegacyRootInlineBox.h: * Source/WebCore/rendering/RenderBlock.h: * Source/WebCore/rendering/RenderBlockFlow.h: (WebCore::RenderBlockFlow::setHasMarkupTruncation): Deleted. (WebCore::RenderBlockFlow::hasMarkupTruncation const): Deleted. *
[webkit-changes] [WebKit/WebKit] 65f69c: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 65f69c4429b507186e061e56f05a924e905da625 https://github.com/WebKit/WebKit/commit/65f69c4429b507186e061e56f05a924e905da625 Author: Fujii Hironori Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/276057@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8e3980: CommandEncoder::clearTexture should only allocate ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8e39803a4c17f35737254dbc26993ab097ef187f https://github.com/WebKit/WebKit/commit/8e39803a4c17f35737254dbc26993ab097ef187f Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: A LayoutTests/fast/webgpu/copy-texture-more-than-4gb-expected.txt A LayoutTests/fast/webgpu/copy-texture-more-than-4gb.html M Source/WebGPU/WebGPU/CommandEncoder.mm Log Message: --- CommandEncoder::clearTexture should only allocate once to make temporaryBuffer https://bugs.webkit.org/show_bug.cgi?id=270938 rdar://124475200 Reviewed by Mike Wyrzykowski. Instead of allocating a Vector then allocating a buffer from it with newBufferWithBytes, just use newBufferWithLength. This also fixes crashes where the buffer length is more than 4GB, which Vector can't allocate. * LayoutTests/fast/webgpu/copy-texture-more-than-4gb-expected.txt: Added. * LayoutTests/fast/webgpu/copy-texture-more-than-4gb.html: Added. * Source/WebGPU/WebGPU/CommandEncoder.mm: (WebGPU::CommandEncoder::clearTexture): Canonical link: https://commits.webkit.org/276058@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7f87b7: REGRESSION (274816@main): [visionOS] Fullscreen wi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7f87b7bf71aefae08144aa6948d677afe9a366cd https://github.com/WebKit/WebKit/commit/7f87b7bf71aefae08144aa6948d677afe9a366cd Author: Aditya Keerthi Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/Shared/FullScreenMediaDetails.h M Source/WebKit/Shared/FullScreenMediaDetails.serialization.in M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp Log Message: --- REGRESSION (274816@main): [visionOS] Fullscreen window size does not always match the video's aspect ratio https://bugs.webkit.org/show_bug.cgi?id=270897 rdar://124506779 Reviewed by Abrar Rahman Protyasha. Fullscreen video on visionOS is intended to be presented at the aspect ratio of the video element. In cases where the video element is not actually the fullscreen element, the "main" video element is used, as determined by the heuristic in `WebFullScreenManager::updateMainVideoElement`. If a "main" video element exists, it's size is sent to the UI process for appropriate window sizing. To add a distinct path for image fullscreen on visionOS, 274816@main refactored fullscreen presentation logic to specify media type (image/video) and video size in a single struct. However, in this refactoring, the logic for size determination was additionally gated on whether or not the fullscreen element was a video element, and not simply the existence of a "main" video element. Fix by splitting up the "video element is fullscreen" and "the fullscreen element contains a prominent video" cases by introducing a new `FullScreenMediaDetails::Type`, ensuring the size is sent over in both cases. The distinction between the two cases is necessary, as `FullScreenMediaDetails::Type::Video` is used further down the line, to determine whether native, UI-process side controls should be shown. * Source/WebKit/Shared/FullScreenMediaDetails.h: * Source/WebKit/Shared/FullScreenMediaDetails.serialization.in: * Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp: (WebKit::WebFullScreenManager::enterFullScreenForElement): Do not check `is(element)` prior to populating the details, as the size should always be specified if there is a "main" video element. Canonical link: https://commits.webkit.org/276059@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c43042: [UnifiedPDF] WebCore::DataDetectorHighlight should...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4304291691ca9767872d81459d4a6553fb45869 https://github.com/WebKit/WebKit/commit/c4304291691ca9767872d81459d4a6553fb45869 Author: Abrar Rahman Protyasha Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/page/ImageOverlayController.h M Source/WebCore/page/PageOverlay.h M Source/WebCore/page/mac/ImageOverlayControllerMac.mm M Source/WebCore/page/mac/ServicesOverlayController.h M Source/WebCore/page/mac/ServicesOverlayController.mm M Source/WebCore/platform/mac/DataDetectorHighlight.h M Source/WebCore/platform/mac/DataDetectorHighlight.mm M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.h Log Message: --- [UnifiedPDF] WebCore::DataDetectorHighlight should be decoupled from the page https://bugs.webkit.org/show_bug.cgi?id=270883 rdar://124490748 Reviewed by Aditya Keerthi. Currently, DataDetectorHighlight instances require a WebCore::Page object at construction time. This object is used for some IPC needs such as for scheduling rendering updates and for creating graphics layers, among other things. While having a Page object around is convenient, it does not fit well when trying to integrate the DataDetectorHighlight data type in the UnifiedPDF Data Detection code path. This patch rips out the dependency of DataDetectorHighlight on the page object, instead delegating its duties to the abstract interface DataDetectorHighlightClient, which can be satisifed by downstream overlay controllers, or even PDF plugins. We make this change in anticipation of a forthcoming patch where we construct and display DataDetectorHighlight instances in a UnifiedPDFPlugin-specific document overlay controller. Furthermore, we also adopt the changes made to the DataDetectorHighlightClient interface in two notable overlay controllers - ImageOverlayController and ServicesOverlayController. Furthermore, we make a few miscellaneous unified sources build fixes and annotate a couple of `enum class` declarations with the tightest possible data type representation. * Source/WebCore/page/ImageOverlayController.h: * Source/WebCore/page/PageOverlay.h: * Source/WebCore/page/mac/ImageOverlayControllerMac.mm: (WebCore::ImageOverlayController::updateDataDetectorHighlights): (WebCore::ImageOverlayController::scheduleRenderingUpdate): (WebCore::ImageOverlayController::deviceScaleFactor const): (WebCore::ImageOverlayController::createGraphicsLayer): * Source/WebCore/page/mac/ServicesOverlayController.h: (WebCore::ServicesOverlayController::protectedPage const): * Source/WebCore/page/mac/ServicesOverlayController.mm: (WebCore::ServicesOverlayController::buildPhoneNumberHighlights): (WebCore::ServicesOverlayController::buildSelectionHighlight): (WebCore::ServicesOverlayController::scheduleRenderingUpdate): (WebCore::ServicesOverlayController::deviceScaleFactor const): (WebCore::ServicesOverlayController::createGraphicsLayer): * Source/WebCore/platform/mac/DataDetectorHighlight.h: (WebCore::DataDetectorHighlight::range const): Deleted. * Source/WebCore/platform/mac/DataDetectorHighlight.mm: (WebCore::DataDetectorHighlight::createForSelection): (WebCore::DataDetectorHighlight::createForTelephoneNumber): (WebCore::DataDetectorHighlight::createForImageOverlay): (WebCore::DataDetectorHighlight::DataDetectorHighlight): (WebCore::DataDetectorHighlight::invalidate): (WebCore::DataDetectorHighlight::notifyFlushRequired): (WebCore::DataDetectorHighlight::deviceScaleFactor const): (WebCore::DataDetectorHighlight::isRangeSupportingType const): (WebCore::DataDetectorHighlight::range const): (WebCore::areEquivalent): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm: (WebKit::UnifiedTextReplacementController::textReplacementSessionDidReceiveTextWithReplacementRange): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.h: Canonical link: https://commits.webkit.org/276060@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c0307b: Clean up inline jit permissions macros
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c0307b8afe4d721b543b9c3246e20afac2da6866 https://github.com/WebKit/WebKit/commit/c0307b8afe4d721b543b9c3246e20afac2da6866 Author: Justin Michaud Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WTF/wtf/PlatformUse.h Log Message: --- Clean up inline jit permissions macros https://bugs.webkit.org/show_bug.cgi?id=270937 rdar://124558039 Reviewed by Wenson Hsieh. Clean up inline jit permissions macros. * Source/WTF/wtf/PlatformUse.h: Canonical link: https://commits.webkit.org/276061@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a47745: [iOS 17.4] ~11 layout tests debug assert in `-hand...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a477452eb93ff56f535304cccb7b0acb9cad0698 https://github.com/WebKit/WebKit/commit/a477452eb93ff56f535304cccb7b0acb9cad0698 Author: Wenson Hsieh Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm Log Message: --- [iOS 17.4] ~11 layout tests debug assert in `-handleKeyEntry:withCompletionHandler:` https://bugs.webkit.org/show_bug.cgi?id=270928 rdar://123028621 Reviewed by Abrar Rahman Protyasha. The new debug assertion in `-handleKeyEntry:withCompletionHandler:` (which sanity checks that the key event completion handler for an incoming event `e` is invoked with `e`) is sometimes hit when running layout tests that send synthetic key events. This reveals an existing bug, wherein `WKContentView`'s `_keyWebEventHandler` is replaced with another incoming ObjC block in the case when async key events are invoked back-to-back, before the preceding key event's completion handler has been called. This causes the latter key event handler to be called with the previous key event, and also means that the previous key event handler won't ever be called. In practice, this is not an issue because UIKit's `UIKeyboardTaskQueue` doesn't attempt to send the next key event until the previous one has finished processing (i.e., WebKit has called the completion block associated with the event); this is likely an artifact of how HID key events are synthesized and dispatched in WebKitTestRunner. However, the `BETextInput` protocol doesn't inherently require or enforce this invariant, so it probably makes more sense for `WKContentView` to be robust for this scenario and call all incoming key event handler completion blocks with their corresponding appropriate events. To ensure this, we replace the current `_keyWebEventHandler` instance variable with a vector of events and completion blocks. This allows us to store multiple completion blocks if needed (for each key event that's currently in-flight), and invoke the correct event handler in response. * Source/WebKit/UIProcess/ios/WKContentViewInteraction.h: * Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm: Replace `_keyWebEventHandler` with `_keyWebEventHandlers`, a `Vector` of `WebEvent`s and completion handler blocks. See above for more details. (-[WKContentView cleanUpInteraction]): (-[WKContentView _cancelPendingKeyEventHandlers:]): (-[WKContentView resignFirstResponderForWebView]): (-[WKContentView _internalHandleKeyWebEvent:withCompletionHandler:]): (-[WKContentView _didHandleKeyEvent:eventWasHandled:]): (-[WKContentView _cancelPendingKeyEventHandler]): Deleted. Canonical link: https://commits.webkit.org/276062@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5745ae: RegisteredContentScripts.db should only be created...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5745aee1167a4b0f77891efe606302d5160fdbde https://github.com/WebKit/WebKit/commit/5745aee1167a4b0f77891efe606302d5160fdbde Author: Timothy Hatcher Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/Shared/Extensions/_WKWebExtensionRegisteredScriptsSQLiteStore.mm M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteDatabase.mm M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.h M Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm M Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestSQLiteStore.mm M Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.mm Log Message: --- RegisteredContentScripts.db should only be created if needed. https://webkit.org/b/270931 rdar://problem/124554561 Reviewed by Sihui Liu and Jeff Miller. Change the APIs that use SQL store to use the new _openDatabaseIfNecessaryReturningErrorMessage:createIfNecessary: method and pass NO when the access is deleting or getting data. This makes sure we don't create an empty database just to read or delete no data. * Source/WebKit/Shared/Extensions/_WKWebExtensionRegisteredScriptsSQLiteStore.mm: (-[_WKWebExtensionRegisteredScriptsSQLiteStore deleteScriptsWithIDs:completionHandler:]): Pass createIfNecessary:NO. (-[_WKWebExtensionRegisteredScriptsSQLiteStore _getScriptsWithOutErrorMessage:]): Ditto. * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteDatabase.mm: (-[_WKWebExtensionSQLiteDatabase _openWithFlags:vfs:error:]): Return no error if thsi is a can't open error and we were not asekd to create the file. * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.h: * Source/WebKit/Shared/Extensions/_WKWebExtensionSQLiteStore.mm: (-[_WKWebExtensionSQLiteStore _openDatabaseIfNecessaryReturningErrorMessage:]): Call the new method with YES. (-[_WKWebExtensionSQLiteStore _openDatabaseIfNecessaryReturningErrorMessage:createIfNecessary:]): Added. (-[_WKWebExtensionSQLiteStore _openDatabase:withAccessType:deleteDatabaseFileOnError:]): Added accessType param. (-[_WKWebExtensionSQLiteStore _deleteDatabaseFileAtURL:reopenDatabase:]): Pass SQLiteDatabaseAccessTypeReadWriteCreate. (-[_WKWebExtensionSQLiteStore _openDatabase:deleteDatabaseFileOnError:]): Deleted. * Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestSQLiteStore.mm: (-[_WKWebExtensionDeclarativeNetRequestSQLiteStore deleteRules:completionHandler:]): Pass createIfNecessary:NO. (-[_WKWebExtensionDeclarativeNetRequestSQLiteStore _getRulesWithOutErrorMessage:]): Ditto. * Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionStorageSQLiteStore.mm: (-[_WKWebExtensionStorageSQLiteStore getStorageSizeForKeys:completionHandler:]): (-[_WKWebExtensionStorageSQLiteStore deleteValuesForKeys:completionHandler:]): (-[_WKWebExtensionStorageSQLiteStore _getValuesForAllKeysReturningErrorMessage:]): (-[_WKWebExtensionStorageSQLiteStore _getAllKeysReturningErrorMessage:]): (-[_WKWebExtensionStorageSQLiteStore _getValuesForKeys:outErrorMessage:]): Canonical link: https://commits.webkit.org/276063@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e8cde: REGRESSION (275888@main): [ Ventura ] tables/mozil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e8cde26d18c7892958fbeb2b3199e2418847b4c https://github.com/WebKit/WebKit/commit/1e8cde26d18c7892958fbeb2b3199e2418847b4c Author: Alan Baradlay Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/mac-ventura/tables/mozilla/bugs/bug12384-expected.txt Log Message: --- REGRESSION (275888@main): [ Ventura ] tables/mozilla/bugs/bug12384.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=270939 Unreviewed rebaseline. * LayoutTests/platform/mac-ventura/tables/mozilla/bugs/bug12384-expected.txt: Canonical link: https://commits.webkit.org/276064@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 027a60: RefinedForGithub extension cannot be enabled: Inva...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 027a604092f7e3765e9f22f44e71cbd8c506bf90 https://github.com/WebKit/WebKit/commit/027a604092f7e3765e9f22f44e71cbd8c506bf90 Author: Elijah Sawyers Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICommandsCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIAction.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICommands.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPIMenus.mm Log Message: --- RefinedForGithub extension cannot be enabled: Invalid call to permissions.request() https://bugs.webkit.org/show_bug.cgi?id=270918 rdar://123775789 Reviewed by Timothy Hatcher. When requesting permissions (permissions.request()), there is a check to make sure that the method was called when processing a user gesture. As it stands, the check doesn't handle events for actions, context menus, and commands. This patch makes it such that WebCore::UserGestureIndicator::processingUserGesture() returns true when handling those events. * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIActionCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchActionClickedEvent): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPICommandsCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchCommandsCommandEvent): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIMenusCocoa.mm: (WebKit::WebExtensionContextProxy::dispatchMenusClickedEvent): Canonical link: https://commits.webkit.org/276065@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8864b0: REGRESSION (275869@main): [ Ventura ] tables/mozil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8864b093959e3bdc2d5d5953906597c6f6b4220d https://github.com/WebKit/WebKit/commit/8864b093959e3bdc2d5d5953906597c6f6b4220d Author: Alan Baradlay Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/mac-ventura/tables/mozilla/bugs/bug1188-expected.txt Log Message: --- REGRESSION (275869@main): [ Ventura ] tables/mozilla/bugs/bug1188.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=270941 Unreviewed rebaseline. * LayoutTests/platform/mac-ventura/tables/mozilla/bugs/bug1188-expected.txt: Canonical link: https://commits.webkit.org/276066@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b8cacf: [iOS 17.4] 21+ layout tests assert under WebPage::...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b8cacf190ad60d1d602a3b40509bb52d9ec4b5fb https://github.com/WebKit/WebKit/commit/b8cacf190ad60d1d602a3b40509bb52d9ec4b5fb Author: Wenson Hsieh Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/editing/VisibleUnits.cpp M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Tools/TestRunnerShared/spi/UIKitSPIForTesting.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm Log Message: --- [iOS 17.4] 21+ layout tests assert under WebPage::requestDocumentEditingContext https://bugs.webkit.org/show_bug.cgi?id=270899 rdar://123028247 Reviewed by Abrar Rahman Protyasha. As a part of BrowserEngineKit adoption in iOS 17.4, UIKit began issuing document editing context requests to grab 2 sentences worth of context before and after the selection while the keyboard is shown. This triggers a frequent debug assertion when running tests on iOS 17.4, due to the fact that the current implementation of `nextSentenceBoundaryInDirection` frequently returns a position that ends up being upstream of the initial `vp` when the `direction` is downstream, or downstream of the `vp` when the given `direction` is upstream. For instance, this can happen when we're trying to find the next downstream sentence boundary when the `vp` is anchored to a cell in a table; we end up first moving to the end of the table with `nextSentencePosition`, but then `startOfSentence` takes us back up to before the table, leaving us at a position before the initial `vp` (despite the fact that we wanted to go downstream). To fix this, we make `nextSentenceBoundaryInDirection` more robust with some minor adjustments: 1. When moving downstream, if the start of the next sentence is before `vp`, then move to the end of the next sentence instead (and vice versa when moving upstream). 2. Repeat the process of moving to the next `startOfSentence` or `endOfSentence` until the `result` is in the requested `direction` relative to the initial `vp`. This ensures that we'll find the closest visible position that satisfies the following constraints: 1. It is the result of either `startOfSentence` or `endOfSentence`. 2. It is downstream of the initial `vp` when the `direction` is downstream, and vice versa when the `direction` is upstream. * Source/WebCore/editing/VisibleUnits.cpp: (WebCore::nextSentenceBoundaryInDirection): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::moveByGranularityRespectingWordBoundary): Also, remove an unnecessary assertion here. This assertion can fire in the case where the given `position` already denotes the end of the last (if moving downstream) or the start of the first (if moving upstream) sentence in the document or editable root, in which case `positionOfNextBoundaryOfGranularity` will just return the null position. This scenario is already handled gracefully. * Tools/TestRunnerShared/spi/UIKitSPIForTesting.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: (makeRequest): Remove staging for `UITextDocumentRequest` / `UITextDocumentContext`, since the rename from `UIWKDocument*` to `UITextDocument*` never ended up happening (and we alternatively went with introducing these objects in BrowserEngineKit, as `BETextDocument*`). (-[TestWKWebView synchronouslyRequestDocumentContext:]): (TEST): (-[UITextDocumentContext markedTextRects]): Deleted. (-[UITextDocumentContext contextBeforeLength]): Deleted. (-[UITextDocumentContext markedTextLength]): Deleted. (-[UITextDocumentContext markedTextRange]): Deleted. (-[UITextDocumentContext textRects]): Deleted. (-[UITextDocumentContext boundingRectForCharacterRange:]): Deleted. Also fix these failing API tests on iOS 17.4 (which currently expect `UIWKDocumentContext` instead of a `BETextDocumentContext`, and therefore throw ObjC exceptions at runtime when attempting to access `contextBefore` and other methods). Canonical link: https://commits.webkit.org/276067@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 942b7e: Make sqlite error message in SQLiteStorageArea log...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 942b7ee0ec7b95249c1ce08bce51913423135b90 https://github.com/WebKit/WebKit/commit/942b7ee0ec7b95249c1ce08bce51913423135b90 Author: Sihui Liu Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp Log Message: --- Make sqlite error message in SQLiteStorageArea logs public https://bugs.webkit.org/show_bug.cgi?id=270932 rdar://124555223 Reviewed by Chris Dumez. This will help us understand sqlite error better when debugging issues like rdar://123797002. * Source/WebKit/NetworkProcess/storage/SQLiteStorageArea.cpp: (WebKit::SQLiteStorageArea::createTableIfNecessary): (WebKit::SQLiteStorageArea::getItemFromDatabase): (WebKit::SQLiteStorageArea::allItems): (WebKit::SQLiteStorageArea::setItem): Canonical link: https://commits.webkit.org/276068@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 20cf87: [Navigation] Implement "update the navigation API ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 20cf87bc4485eefd39154530327a27670e484950 https://github.com/WebKit/WebKit/commit/20cf87bc4485eefd39154530327a27670e484950 Author: Rob Buis Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/anchor-click-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/location-api-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-same-doc-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/properties-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-across-origins-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-after-blank-navigation-from-cross-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-in-new-srcdoc-iframe-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/key-id-location-reload-intercept-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/key-id-location-replace-cross-origin-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/sameDocument-after-navigate-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-intercept-history-state-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/navigate-relative-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/reload-base-url-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/sandboxing-navigate-parent-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/sandboxing-navigate-sibling-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/scroll-behavior/manual-basic-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/scroll-behavior/manual-immediate-scroll-expected.txt M LayoutTests/imported/w3c/web-platform-tests/navigation-api/updateCurrentEntry-method/location-reload-expected.txt M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/Navigation.cpp M Source/WebCore/page/Navigation.h Log Message: --- [Navigation] Implement "update the navigation API entries for a same-document navigation" algorithm https://bugs.webkit.org/show_bug.cgi?id=270696 Reviewed by Alex Christensen. This PR implements the "update the navigation API entries for a same-document navigation" algorithm [1]. Some parts of it we can't do now until some other parts are in place so two FIXMEs are left. Since this means meany WPT tests start to work now this also marks many tests in TestExpectations as passing. [1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#update-the-navigation-api-entries-for-a-same-document-navigation * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/commit-behavior/after-transition-uncancelable-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/anchor-click-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-replace-same-doc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/navigation-navigate-same-doc-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/currententrychange-event/properties-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-across-origins-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-after-blank-navigation-from-cross-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/entries-in-new-srcdoc-iframe-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/key-id-location-reload-intercept-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/key-id-location-replace-cross-origin-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-history-entry/sameDocument-after-navigate-expected.txt: *
[webkit-changes] [WebKit/WebKit] e7a46d: REGRESSION (Sonoma?): RTL scrollbar incorrect spacing
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e7a46d11ffb4d88a4075971be726d8999d8e4230 https://github.com/WebKit/WebKit/commit/e7a46d11ffb4d88a4075971be726d8999d8e4230 Author: Nikolaos Mouchtaris Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: A LayoutTests/fast/scrolling/mac/scrollbars/rtl-scrollbar-state-expected.txt A LayoutTests/fast/scrolling/mac/scrollbars/rtl-scrollbar-state.html M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingCoordinator.h M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStateNode.h M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.h M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp M Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h M Source/WebCore/page/scrolling/mac/ScrollerMac.h M Source/WebCore/page/scrolling/mac/ScrollerMac.mm M Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm M Source/WebCore/platform/ScrollbarsController.h M Source/WebCore/platform/mac/ScrollbarsControllerMac.mm M Source/WebCore/rendering/RenderBox.cpp M Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm Log Message: --- REGRESSION (Sonoma?): RTL scrollbar incorrect spacing https://bugs.webkit.org/show_bug.cgi?id=263512 rdar://117355120 Reviewed by Simon Fraser. We need to pass changes to shouldPlaceVerticalScrollbarOnLeft to the UI-process so that we can properly set userInterfaceLayoutDirection on the scroller imp. Since on first style change the scrollable area in styleDidChange() doesn't yet have a render layer backing, also pass accross UserInterfaceLayoutDirection when we first set the scrollbar layer as well. * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::setShouldPlaceVerticalScrollbarOnLeft): * Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h: * Source/WebCore/page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::setShouldPlaceVerticalScrollbarOnLeft): * Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.cpp: (WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode): * Source/WebCore/page/scrolling/ScrollingStateFrameScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStateNode.h: * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.cpp: (WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode): * Source/WebCore/page/scrolling/ScrollingStateOverflowScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.cpp: (WebCore::ScrollingStatePluginScrollingNode::ScrollingStatePluginScrollingNode): * Source/WebCore/page/scrolling/ScrollingStatePluginScrollingNode.h: * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::setShouldPlaceVerticalScrollbarOnLeft): * Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h: (WebCore::ScrollingStateScrollingNode::shouldPlaceVerticalScrollbarOnLeft const): * Source/WebCore/page/scrolling/mac/ScrollerMac.h: * Source/WebCore/page/scrolling/mac/ScrollerMac.mm: (WebCore::ScrollerMac::setShouldPlaceVerticalScrollbarOnLeft): * Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm: (WebCore::ScrollingTreeScrollingNodeDelegateMac::updateFromStateNode): * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollbarsController.mm: (WebKit::RemoteScrollbarsController::RemoteScrollbarsController): (WebKit::RemoteScrollbarsController::mouseMovedInContentArea): Canonical link: https://commits.webkit.org/276040@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 911ec2: Disable element fullscreen on as.com on iPhone
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 911ec2b8f9cddb0dd8c6a2577a1ce513d316a08e https://github.com/WebKit/WebKit/commit/911ec2b8f9cddb0dd8c6a2577a1ce513d316a08e Author: Dana Estra Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/page/Quirks.cpp Log Message: --- Disable element fullscreen on as.com on iPhone https://bugs.webkit.org/show_bug.cgi?id=270880 rdar://124305168 Reviewed by Jer Noble. Adding quirk to as.com to disable element fullscreen on iPhone, until the website fixes its custom media controls which are currently cut off on the bottom when the phone is rotated into landscape mode. * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::shouldDisableElementFullscreenQuirk const): Canonical link: https://commits.webkit.org/276044@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5011b2: Remove unused ios-device folders from LayoutTests/...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5011b2f6a335a86e922867a7c78dd2ba4af373b9 https://github.com/WebKit/WebKit/commit/5011b2f6a335a86e922867a7c78dd2ba4af373b9 Author: Ben Schwartz Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: R LayoutTests/platform/ios-device-wk2/TestExpectations R LayoutTests/platform/ios-device/TestExpectations Log Message: --- Remove unused ios-device folders from LayoutTests/platforms. rdar://124541515 https://bugs.webkit.org/show_bug.cgi?id=270917 Reviewed by Jonathan Bedard. There are currently 7 iOS/iPad-related layout test platform folders. In order to disambiguate, we would like to remove the unused iOS device platform folders from our LayoutTests/platform directory. * LayoutTests/platform/ios-device-wk2/TestExpectations: Removed. * LayoutTests/platform/ios-device/TestExpectations: Removed. Canonical link: https://commits.webkit.org/276042@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5b6703: Conditionally exclude crossorigin attribute when s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5b67039b6533405bf352d6071aff8fbb8aca5519 https://github.com/WebKit/WebKit/commit/5b67039b6533405bf352d6071aff8fbb8aca5519 Author: Sihui Liu Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebCore/editing/MarkupAccumulator.cpp M Source/WebCore/editing/MarkupAccumulator.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm Log Message: --- Conditionally exclude crossorigin attribute when saving web page resources https://bugs.webkit.org/show_bug.cgi?id=270874 rdar://124074708 Reviewed by Ryosuke Niwa. When saving complete web page, we may replace URLs of elements with relative paths that point to saved subresource files. In this case, we should drop crossorigin attribute on these elements, otherwise the saved page may not have subresources loaded correctly as browsers can perform CORS checks on the element (e.g. requiring response to contain Access-Control-Allow-Origin header). Test: WebArchive.SaveResourcesExcludeCrossOriginAttribute * Source/WebCore/editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::resolveURLIfNeeded const): (WebCore::isURLAttributeForElement): (WebCore::MarkupAccumulator::appendStartTag): (WebCore::MarkupAccumulator::appendURLAttributeForReplacementIfNecessary): (WebCore::MarkupAccumulator::appendAttribute): (WebCore::MarkupAccumulator::appendURLAttributeIfNecessary): Deleted. * Source/WebCore/editing/MarkupAccumulator.h: * Tools/TestWebKitAPI/Tests/WebKitCocoa/CreateWebArchive.mm: Canonical link: https://commits.webkit.org/276043@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 028654: [Gardening]: [ Ventura WK1 ] 2x imported/w3c/web-p...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0286542226743cf29725de3d2ec20fc7a03f347c https://github.com/WebKit/WebKit/commit/0286542226743cf29725de3d2ec20fc7a03f347c Author: Jay Stfleur Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/mac-ventura-wk1/TestExpectations Log Message: --- [Gardening]: [ Ventura WK1 ] 2x imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-mode are constant crashes https://bugs.webkit.org/show_bug.cgi?id=124540415 rdar://124540415 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac-ventura-wk1/TestExpectations: Canonical link: https://commits.webkit.org/276038@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f49ce0: [GStreamer] Disable ORC SIMD optimizations in test...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f49ce0893345af68f7e1aa12185734cd520d85cd https://github.com/WebKit/WebKit/commit/f49ce0893345af68f7e1aa12185734cd520d85cd Author: Philippe Normand Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Tools/Scripts/webkitpy/port/glib.py Log Message: --- [GStreamer] Disable ORC SIMD optimizations in test harness https://bugs.webkit.org/show_bug.cgi?id=270908 Reviewed by Xabier Rodriguez-Calvar. Disable SIMD optimization in GStreamer's ORC. Some bots (WPE release) crash in ORC's optimizations. Suggested by Víctor Jaquez. * Tools/Scripts/webkitpy/port/glib.py: (GLibPort.setup_environ_for_server): Canonical link: https://commits.webkit.org/276041@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f657af: [webkitcorepy] Exit AutoInstall.install when disabled
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f657af17ad3a8ee4bc206d37597804354a921beb https://github.com/WebKit/WebKit/commit/f657af17ad3a8ee4bc206d37597804354a921beb Author: Jonathan Bedard Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py Log Message: --- [webkitcorepy] Exit AutoInstall.install when disabled https://bugs.webkit.org/show_bug.cgi?id=270920 rdar://124542328 Reviewed by Elliott Williams. AutoInstall.install will fail if the autoinstaller is disabled. Programs shouldn't call AutoInstall.install if the autoinstaller is disabled, but the program may still complete, so we should just print an error message. * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py: (AutoInstall.install): Exit and print error if AutoInstall is disabled. Canonical link: https://commits.webkit.org/276051@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b3029: [Gardening]: REGRESSION(266260@main): [ Ventura wk...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b302963d86676b9ef60e092283409cab964977f https://github.com/WebKit/WebKit/commit/3b302963d86676b9ef60e092283409cab964977f Author: Jay Stfleur Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/mac-wk1/TestExpectations Log Message: --- [Gardening]: REGRESSION(266260@main): [ Ventura wk1 ] http/tests/media/hls/track-in-band-multiple-cues.html is a constant crash https://bugs.webkit.org/show_bug.cgi?id=124478685 rdar://124478685 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac-wk1/TestExpectations: Canonical link: https://commits.webkit.org/276052@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bd17eb: [Gardening]: REGRESSION (275888@main): [ Ventura ]...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bd17eb048e3dcb8789d33e207f4fffed445b36a8 https://github.com/WebKit/WebKit/commit/bd17eb048e3dcb8789d33e207f4fffed445b36a8 Author: Jay Stfleur Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/platform/mac/TestExpectations Log Message: --- [Gardening]: REGRESSION (275888@main): [ Ventura ] tables/mozilla/bugs/bug12384.html is a constant failure https://bugs.webkit.org/show_bug.cgi?id=124558965 rdar://124558965 Unreviewed test gardening. Adding test expectation. * LayoutTests/platform/mac/TestExpectations: Canonical link: https://commits.webkit.org/276053@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7a0e5: [results.safari.apple.com] Handle configurations d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7a0e5174f2bfd123c484d8f94689e2dd951204b https://github.com/WebKit/WebKit/commit/a7a0e5174f2bfd123c484d8f94689e2dd951204b Author: Jonathan Bedard Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js Log Message: --- [results.safari.apple.com] Handle configurations differentiated by version number https://bugs.webkit.org/show_bug.cgi?id=270942 rdar://124561156 Reviewed by Elliott Williams. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/configuration.js: (Configuration.prototype.toKey): Include version in key if SDK is defined. Canonical link: https://commits.webkit.org/276054@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a1d782: Fix Mac Build after addition of reconfigureLayerCo...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a1d782a450ecbc564c3e19faa13fa8dbe24f3b25 https://github.com/WebKit/WebKit/commit/a1d782a450ecbc564c3e19faa13fa8dbe24f3b25 Author: Megan Gardner Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm Log Message: --- Fix Mac Build after addition of reconfigureLayerContentHint. https://bugs.webkit.org/show_bug.cgi?id=270945 rdar://124563181 Unreviewed build fix. * Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm: (WebKit::updateLayersForInteractionRegions): Canonical link: https://commits.webkit.org/276055@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3dca86: [UnifiedPDF] Enable UnifiedPDF by default on certa...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3dca86dae15c026891add4e978d43d14a3054c30 https://github.com/WebKit/WebKit/commit/3dca86dae15c026891add4e978d43d14a3054c30 Author: Abrar Rahman Protyasha Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml Log Message: --- [UnifiedPDF] Enable UnifiedPDF by default on certain platforms https://bugs.webkit.org/show_bug.cgi?id=270927 rdar://123062091 Reviewed by Simon Fraser. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: Canonical link: https://commits.webkit.org/276056@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] de0840: Fix bugprone-use-after-move warnings in `WebExtens...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: de084069b1214e2ed8e0616a55613e9fb1250a10 https://github.com/WebKit/WebKit/commit/de084069b1214e2ed8e0616a55613e9fb1250a10 Author: Charlie Wolfe Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm Log Message: --- Fix bugprone-use-after-move warnings in `WebExtensionContext::loadDeclarativeNetRequestRules` https://bugs.webkit.org/show_bug.cgi?id=270930 rdar://124554555 Reviewed by Timothy Hatcher. `completionHandler` was unnecessarily being moved into several lambda captures. * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::loadDeclarativeNetRequestRules): Canonical link: https://commits.webkit.org/276048@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f84f5a: [generate-xcfilelists] Disable autoinstaller
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f84f5a221f1e4c54febcd789945720867499aa5c https://github.com/WebKit/WebKit/commit/f84f5a221f1e4c54febcd789945720867499aa5c Author: Jonathan Bedard Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Tools/Scripts/generate-xcfilelists Log Message: --- [generate-xcfilelists] Disable autoinstaller https://bugs.webkit.org/show_bug.cgi?id=270921 rdar://102516630 Reviewed by Elliott Williams. generate-xcfilelists doesn't require the autoinstaller, encode that assumption so no dependency is added in the future. * Tools/Scripts/generate-xcfilelists: Canonical link: https://commits.webkit.org/276049@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7debec: Null check video element in imageBytesForSource
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7debec9d62d0792976658aede004da32cefc88b0 https://github.com/WebKit/WebKit/commit/7debec9d62d0792976658aede004da32cefc88b0 Author: Alex Christensen Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M LayoutTests/TestExpectations A LayoutTests/fast/webgpu/null-video-texture-expected.txt A LayoutTests/fast/webgpu/null-video-texture.html M Source/WebCore/Modules/WebGPU/GPUQueue.cpp Log Message: --- Null check video element in imageBytesForSource https://bugs.webkit.org/show_bug.cgi?id=270922 rdar://124475221 Reviewed by Mike Wyrzykowski. Also add a release assertion to verify that the callback is called synchronously so that the captured references are still in scope. * LayoutTests/fast/webgpu/null-video-texture-expected.txt: Added. * LayoutTests/fast/webgpu/null-video-texture.html: Added. * Source/WebCore/Modules/WebGPU/GPUQueue.cpp: (WebCore::imageBytesForSource): (WebCore::GPUQueue::copyExternalImageToTexture): Canonical link: https://commits.webkit.org/276047@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6099df: Update Vitor Roriz's contributor status to reviewer
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6099df83a0ad16a86bc7bca5fe013d0de732b5e2 https://github.com/WebKit/WebKit/commit/6099df83a0ad16a86bc7bca5fe013d0de732b5e2 Author: Vitor Roriz Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M metadata/contributors.json Log Message: --- Update Vitor Roriz's contributor status to reviewer https://bugs.webkit.org/show_bug.cgi?id=270935 rdar://problem/124556805 Reviewed by Brent Fulgham. * metadata/contributors.json: Canonical link: https://commits.webkit.org/276050@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ed9f21: [JSC] Validate that HasStaticPropertyTable is pres...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed9f215ec22744e680c5a1f6f382f2b7afca56ad https://github.com/WebKit/WebKit/commit/ed9f215ec22744e680c5a1f6f382f2b7afca56ad Author: Alexey Shvayka Date: 2024-03-13 (Wed, 13 Mar 2024) Changed paths: M Source/JavaScriptCore/runtime/ArrayIteratorPrototype.h M Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototype.h M Source/JavaScriptCore/runtime/IntlLocaleConstructor.h M Source/JavaScriptCore/runtime/JSModuleLoader.h M Source/JavaScriptCore/runtime/MapConstructor.cpp M Source/JavaScriptCore/runtime/MapPrototype.h M Source/JavaScriptCore/runtime/RegExpStringIteratorPrototype.h M Source/JavaScriptCore/runtime/SetPrototype.h M Source/JavaScriptCore/runtime/StringIteratorPrototype.h M Source/JavaScriptCore/runtime/Structure.cpp M Source/JavaScriptCore/tools/JSDollarVM.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyArrayConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyArrayConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyArrayPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyArrayPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyCompileErrorPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyExceptionConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyExceptionConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyGlobalConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyGlobalConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyInstanceConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyInstanceConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyInstancePrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyLinkErrorPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyModulePrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyModulePrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyRuntimeErrorPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyStructConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyStructConstructor.h M Source/JavaScriptCore/wasm/js/WebAssemblyStructPrototype.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyStructPrototype.h M Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp M Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.h M Source/WebCore/bindings/scripts/CodeGeneratorJS.pm M Source/WebCore/bindings/scripts/test/JS/JSDedicatedWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSLocalDOMWindow.h M Source/WebCore/bindings/scripts/test/JS/JSPaintWorkletGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSServiceWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSSharedWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSWorkerGlobalScope.h M Source/WebCore/bindings/scripts/test/JS/JSWorkletGlobalScope.h Log Message: --- [JSC] Validate that HasStaticPropertyTable is present only if there is a static property table https://bugs.webkit.org/show_bug.cgi?id=270889 Reviewed by Yusuke Suzuki. This change: 1) Removes empty static property tables. 2) Removes HasStaticPropertyTable structure flag from classes without static property tables. 3) Fixes bindings generator condition for setting HasStaticPropertyTable to match the condition for setting `staticPropHashTable`, which isn't observable because we eagerly reify all static properties. 4) Adds an assertion to validate that HasStaticPropertyTable is present only if there is an own or inherited static property table. 1) and 2) are performance micro-optimizations that avoid calling into getOwnStaticPropertySlot() for property lookup if there is no static property table, own nor inherited, while 4) ensures consistency across the JSC codebase. * Source/JavaScriptCore/runtime/ArrayIteratorPrototype.h: * Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototype.h: * Source/JavaScriptCore/runtime/IntlLocaleConstructor.h: *
