[webkit-changes] [WebKit/WebKit] 662e37: prepare-commit-msg hook doesn't generate a changed...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 662e3790e0b6902fe02cd8594c47052a8bb935c9 https://github.com/WebKit/WebKit/commit/662e3790e0b6902fe02cd8594c47052a8bb935c9 Author: Fujii Hironori Date: 2023-09-05 (Tue, 05 Sep 2023) Changed paths: M Tools/Scripts/hooks/prepare-commit-msg M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py Log Message: --- prepare-commit-msg hook doesn't generate a changed file list with Windows Git https://bugs.webkit.org/show_bug.cgi?id=261097 Reviewed by Jonathan Bedard. prepare-ChangeLog reproted "Can't locate VCSUtils.pm in @INC" error if it was executed from prepare-commit-msg hook of Windows Git. It failed to set a library path to 'Tools/Scripts' directory. Windows Git includes msys perl. prepare-commit-msg hook unexpectedly executed it. It should execute Windows Perl. Use shutil.which to get perl's absolute path. But, it's available for Python 3.3 or newer. Windows port developers have been switched to Python 3. Use the original relative command name 'perl' for older Python. * Tools/Scripts/hooks/prepare-commit-msg: * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py: * (InstallHooks.main): Added a new template variable 'perl' to set perl's absolute path. Canonical link: https://commits.webkit.org/267649@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fc2d94: REGRESSION(267608@main): [Win] build-webkit is fai...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fc2d94a97e1ff3d2a1cc580fc4d828f0cb9252fd https://github.com/WebKit/WebKit/commit/fc2d94a97e1ff3d2a1cc580fc4d828f0cb9252fd Author: Fujii Hironori Date: 2023-09-05 (Tue, 05 Sep 2023) Changed paths: M Tools/Scripts/build-webkit Log Message: --- REGRESSION(267608@main): [Win] build-webkit is failing with "'python3' is not recognized as an internal or external command" https://bugs.webkit.org/show_bug.cgi?id=261183 Reviewed by Ross Kirsling. Windows Python 3 is python.exe, not python3.exe. * Tools/Scripts/build-webkit: Use python to execute update-webkit-wincairo-libs.py instead of python3. Canonical link: https://commits.webkit.org/267662@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 39a03b: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 39a03baf3308f67cb6704106f87a3da844637ad1 https://github.com/WebKit/WebKit/commit/39a03baf3308f67cb6704106f87a3da844637ad1 Author: Fujii Hironori Date: 2023-09-06 (Wed, 06 Sep 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/267710@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 02f620: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02f6205f5e0b3fd9d3f80ca14a083cbcc31302aa https://github.com/WebKit/WebKit/commit/02f6205f5e0b3fd9d3f80ca14a083cbcc31302aa Author: Fujii Hironori Date: 2023-09-11 (Mon, 11 Sep 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/fast/html/details-writing-mode-expected.txt M LayoutTests/platform/wincairo/fast/html/details-writing-mode-mixed-expected.txt M LayoutTests/platform/wincairo/fast/text/emphasis-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/fast/html/details-writing-mode-expected.txt: * LayoutTests/platform/wincairo/fast/html/details-writing-mode-mixed-expected.txt: * LayoutTests/platform/wincairo/fast/text/emphasis-expected.txt: Canonical link: https://commits.webkit.org/267877@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b332b3: [CMake] rewrite-compile-commands reports a lot of ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b332b310db505e67e0cc8561fcdb47bd3117b79a https://github.com/WebKit/WebKit/commit/b332b310db505e67e0cc8561fcdb47bd3117b79a Author: Fujii Hironori Date: 2023-08-31 (Thu, 31 Aug 2023) Changed paths: M Tools/Scripts/rewrite-compile-commands Log Message: --- [CMake] rewrite-compile-commands reports a lot of warning messages "Failed to find ..." https://bugs.webkit.org/show_bug.cgi?id=260841 Reviewed by Don Olmstead. rewrite-compile-commands scripts reported a lot of warning messages of missing derived sources for the build-webkit first invocation. We don't have a nice solution yet. And, derived sources don't have to be included in compile_commands.json because we don't directly edit them. Let's just ignore the missing derived sources at the moment. * Tools/Scripts/rewrite-compile-commands: Canonical link: https://commits.webkit.org/267542@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 602003: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6020033aee1fc4bbf31d80231a618a7e6318e10f https://github.com/WebKit/WebKit/commit/6020033aee1fc4bbf31d80231a618a7e6318e10f Author: Fujii Hironori Date: 2023-09-12 (Tue, 12 Sep 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/267933@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f546b: REGRESSION(267176@main): [Win][Clang] Unreviewed b...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f546b2749a1cabc883701d6c222ed52b90be287 https://github.com/WebKit/WebKit/commit/2f546b2749a1cabc883701d6c222ed52b90be287 Author: Fujii Hironori Date: 2023-08-30 (Wed, 30 Aug 2023) Changed paths: M Source/WTF/wtf/Compiler.h Log Message: --- REGRESSION(267176@main): [Win][Clang] Unreviewed build fix for ALWAYS_INLINE_LAMBDA https://bugs.webkit.org/show_bug.cgi?id=260689 After 267176@main added ALWAYS_INLINE_LAMBDA macro, clang-cl reported the following warning for Windows port release builds: > dfg/DFGOperations.cpp(1471,29): warning: unknown attribute 'forceinline' > ignored [-Wunknown-attributes] * Source/WTF/wtf/Compiler.h: Clang-cl should take the same ALWAYS_INLINE_LAMBDA macro definition with GCC. Canonical link: https://commits.webkit.org/267471@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4132ce: RemoteInspectorSocket.cpp: error: implicit capture...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4132ced62b83c0096bc81b1c07292a76f44248a4 https://github.com/WebKit/WebKit/commit/4132ced62b83c0096bc81b1c07292a76f44248a4 Author: Fujii Hironori Date: 2023-09-11 (Mon, 11 Sep 2023) Changed paths: M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp Log Message: --- RemoteInspectorSocket.cpp: error: implicit capture of 'this' with a capture default of '=' is deprecated [-Werror,-Wdeprecated-this-capture] https://bugs.webkit.org/show_bug.cgi?id=261448 Reviewed by Ross Kirsling. Clang 17 reported the following compiler warnings for Windows port: > inspector/remote/socket/RemoteInspectorSocket.cpp(73,25): error: implicit > capture of 'this' with a capture default of '=' is deprecated > [-Werror,-Wdeprecated-this-capture] > inspector/remote/socket/RemoteInspectorSocket.cpp(185,25): error: implicit > capture of 'this' with a capture default of '=' is deprecated > [-Werror,-Wdeprecated-this-capture] * Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp: (Inspector::RemoteInspector::didClose): (Inspector::RemoteInspector::pushListingsSoon): Capture `this` explicitly. Canonical link: https://commits.webkit.org/267892@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] efdde1: Re-sync the top directory files of web-platform-te...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: efdde118860a9787675616975b099a4d87b53487 https://github.com/WebKit/WebKit/commit/efdde118860a9787675616975b099a4d87b53487 Author: Fujii Hironori Date: 2023-10-16 (Mon, 16 Oct 2023) Changed paths: A LayoutTests/imported/w3c/web-platform-tests/.gitattributes M LayoutTests/imported/w3c/web-platform-tests/.gitignore M LayoutTests/imported/w3c/web-platform-tests/CODEOWNERS A LayoutTests/imported/w3c/web-platform-tests/CODE_OF_CONDUCT.md M LayoutTests/imported/w3c/web-platform-tests/CONTRIBUTING.md R LayoutTests/imported/w3c/web-platform-tests/LICENSE M LayoutTests/imported/w3c/web-platform-tests/LICENSE.md R LayoutTests/imported/w3c/web-platform-tests/__init__.py R LayoutTests/imported/w3c/web-platform-tests/check_stability.ini R LayoutTests/imported/w3c/web-platform-tests/config.default.json R LayoutTests/imported/w3c/web-platform-tests/diff-manifest.py A LayoutTests/imported/w3c/web-platform-tests/lint.ignore R LayoutTests/imported/w3c/web-platform-tests/lint.whitelist R LayoutTests/imported/w3c/web-platform-tests/serve.py R LayoutTests/imported/w3c/web-platform-tests/server-side.md R LayoutTests/imported/w3c/web-platform-tests/test_keys_wdspec.html R LayoutTests/imported/w3c/web-platform-tests/update-built-tests.sh Log Message: --- Re-sync the top directory files of web-platform-tests to d20c3cdbf6e91f14dda9 https://bugs.webkit.org/show_bug.cgi?id=263173 Reviewed by Tim Nguyen. WPT hash for this import: d20c3cdbf6e91f14dda92737e453621617b8de74 This revision is the last tools directory sync by 259138@main. * LayoutTests/imported/w3c/web-platform-tests/.gitattributes: Added. * LayoutTests/imported/w3c/web-platform-tests/.gitignore: * LayoutTests/imported/w3c/web-platform-tests/CODEOWNERS: * LayoutTests/imported/w3c/web-platform-tests/CODE_OF_CONDUCT.md: Added. * LayoutTests/imported/w3c/web-platform-tests/CONTRIBUTING.md: * LayoutTests/imported/w3c/web-platform-tests/LICENSE: Removed. * LayoutTests/imported/w3c/web-platform-tests/LICENSE.md: * LayoutTests/imported/w3c/web-platform-tests/__init__.py: Removed. * LayoutTests/imported/w3c/web-platform-tests/check_stability.ini: Removed. * LayoutTests/imported/w3c/web-platform-tests/config.default.json: Removed. * LayoutTests/imported/w3c/web-platform-tests/diff-manifest.py: Removed. * LayoutTests/imported/w3c/web-platform-tests/lint.ignore: Added. * LayoutTests/imported/w3c/web-platform-tests/lint.whitelist: Removed. * LayoutTests/imported/w3c/web-platform-tests/serve.py: Removed. * LayoutTests/imported/w3c/web-platform-tests/server-side.md: Removed. * LayoutTests/imported/w3c/web-platform-tests/test_keys_wdspec.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/update-built-tests.sh: Removed. Canonical link: https://commits.webkit.org/269364@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d68b95: [Win] editing/selection/caret-rtl-right.html is ra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d68b9530bdc4e3d8a998476a8152fd7a8097039c https://github.com/WebKit/WebKit/commit/d68b9530bdc4e3d8a998476a8152fd7a8097039c Author: Fujii Hironori Date: 2023-10-11 (Wed, 11 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/editing/deleting/smart-delete-004-expected.txt M Tools/WebKitTestRunner/win/TestControllerWin.cpp Log Message: --- [Win] editing/selection/caret-rtl-right.html is randomly failing https://bugs.webkit.org/show_bug.cgi?id=262460 Reviewed by Don Olmstead. The following tests were randomly failing becuase a click sometimes dispatched a double-click event. editing/deleting/smart-delete-001.html editing/deleting/smart-delete-003.html editing/deleting/smart-delete-004.html editing/selection/5057506.html editing/selection/caret-ltr-right.html editing/selection/caret-rtl-right.html Reset the mouse position after the previous test not to dispatch a fake double-click event for a click in the next page. * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/editing/deleting/smart-delete-004-expected.txt: * Tools/WebKitTestRunner/win/TestControllerWin.cpp: Canonical link: https://commits.webkit.org/269217@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3e5207: [Win] "git-webkit pr" reports "FileNotFoundError: ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3e52075ba71d423f80d114f5fadb759e7c692db2 https://github.com/WebKit/WebKit/commit/3e52075ba71d423f80d114f5fadb759e7c692db2 Author: Fujii Hironori Date: 2023-10-16 (Mon, 16 Oct 2023) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py Log Message: --- [Win] "git-webkit pr" reports "FileNotFoundError: [WinError 2] The system cannot find the file specified" https://bugs.webkit.org/show_bug.cgi?id=258704 Reviewed by Jonathan Bedard. 'git-webkit pr' runs pre-pr checkers specifed in webkitscmpy.pre-pr config. 'python3' is hard-coded in 'metadata/git_config_extension' file, but Windows Python doesn't contain 'python3.exe'. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pull_request.py: If the commnad name of webkitscmpy.pre-pr config is 'python3', replace it with sys.executable. Canonical link: https://commits.webkit.org/269375@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a716d: STDIN and STDOUT of Perl CGI scripts should be bin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a716d72adac16a24a5fa865b2ed6a7a454d6d64 https://github.com/WebKit/WebKit/commit/5a716d72adac16a24a5fa865b2ed6a7a454d6d64 Author: Fujii Hironori Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M LayoutTests/http/tests/cache/resources/current-time.cgi M LayoutTests/http/tests/cache/resources/echo-cacheable.cgi M LayoutTests/http/tests/cache/resources/echo-no-store.cgi M LayoutTests/http/tests/cache/resources/random-cached-iframe.cgi M LayoutTests/http/tests/cache/resources/random-cached.cgi M LayoutTests/http/tests/cache/resources/random-max-age.cgi M LayoutTests/http/tests/cache/resources/random.cgi M LayoutTests/http/tests/cache/resources/subresource-failover-to-network.cgi M LayoutTests/http/tests/cookies/resources/clearCookies.cgi M LayoutTests/http/tests/cookies/resources/getCookies.cgi M LayoutTests/http/tests/cookies/resources/setCookies.cgi M LayoutTests/http/tests/history/redirect-200-refresh-0-seconds.pl M LayoutTests/http/tests/history/redirect-200-refresh-2-seconds.pl M LayoutTests/http/tests/history/resources/redirect-helper.pl M LayoutTests/http/tests/incremental/pause-in-script-element.pl M LayoutTests/http/tests/incremental/resources/slow-utf8-css.pl M LayoutTests/http/tests/incremental/slow-utf8-html.pl M LayoutTests/http/tests/incremental/slow-utf8-text.pl M LayoutTests/http/tests/incremental/split-hex-entities.pl M LayoutTests/http/tests/inspector/network/resources/cors-data.pl M LayoutTests/http/tests/links/resources/redirect-helper.pl M LayoutTests/http/tests/loading/onload-vs-immediate-refresh.pl M LayoutTests/http/tests/loading/resources/404-with-empty-body-no-content-type.cgi M LayoutTests/http/tests/loading/resources/404-with-empty-body.cgi M LayoutTests/http/tests/local/slow-css-pass.cgi M LayoutTests/http/tests/mime/resources/style-with-empty-content-type.cgi M LayoutTests/http/tests/misc/BOM-override.pl M LayoutTests/http/tests/misc/error404.pl M LayoutTests/http/tests/misc/nph-non-utf8-header-name.pl M LayoutTests/http/tests/misc/resources/BOM-override-2.pl M LayoutTests/http/tests/misc/resources/BOM-override-3.pl M LayoutTests/http/tests/misc/resources/image-slow.pl M LayoutTests/http/tests/misc/resources/intrinsic-ratio-slow.pl M LayoutTests/http/tests/misc/resources/percent-sign-in-form-data-field-name.cgi M LayoutTests/http/tests/misc/resources/post-echo-and-notify-done.cgi M LayoutTests/http/tests/misc/resources/post-echo.cgi M LayoutTests/http/tests/misc/resources/script-slow1.pl M LayoutTests/http/tests/misc/resources/script-slow2.pl M LayoutTests/http/tests/misc/resources/slow-async-script.cgi M LayoutTests/http/tests/misc/resources/slow-defer-script.cgi M LayoutTests/http/tests/misc/resources/slow-stylesheet.cgi M LayoutTests/http/tests/misc/resources/svg-slow.pl M LayoutTests/http/tests/misc/resources/text-refresh.pl M LayoutTests/http/tests/misc/resources/uncacheable-script.cgi M LayoutTests/http/tests/misc/xmltokenizer-do-not-crash.pl M LayoutTests/http/tests/navigation/resources/error404.pl M LayoutTests/http/tests/navigation/resources/redirect-cycle-1.pl M LayoutTests/http/tests/navigation/resources/redirect-cycle-2.pl M LayoutTests/http/tests/navigation/resources/redirect-to-referrer-check.pl M LayoutTests/http/tests/navigation/resources/redirect302-metaredirect.pl M LayoutTests/http/tests/navigation/resources/redirect302.pl M LayoutTests/http/tests/navigation/resources/reload-subframe-content.pl M LayoutTests/http/tests/navigation/resources/reload-subframe.pl M LayoutTests/http/tests/navigation/resources/response204.pl M LayoutTests/http/tests/navigation/resources/slow-resource-1-sec.pl M LayoutTests/http/tests/plugins/resources/mock-plugin-cacheable.pl M LayoutTests/http/tests/plugins/resources/mock-plugin-unknown-type.pl M LayoutTests/http/tests/plugins/resources/mock-plugin.pl M LayoutTests/http/tests/plugins/resources/plugin-document-has-focus.pl M LayoutTests/http/tests/plugins/resources/slow-resource.pl M LayoutTests/http/tests/preload/resources/nph-invalid_resources_from_header.pl M LayoutTests/http/tests/resources/post-and-verify-hybrid.cgi M LayoutTests/http/tests/resources/post-and-verify.cgi M LayoutTests/http/tests/security/XFrameOptions/resources/nph-cached-xfo.pl M LayoutTests/http/tests/security/XFrameOptions/resources/x-frame-options-allowall.cgi M LayoutTests/http/tests/security/XFrameOptions/resources/x-frame-options-deny.cgi M LayoutTests/http/tests/security/XFrameOptions/resources/x-frame-options-frame-ancestors-same-origin-allow.cgi M LayoutTests/http/tests/security/XFrameOptions/resources/x-frame-options-frame-ancestors-same-origin-deny.cgi M LayoutTests/http/tests
[webkit-changes] [WebKit/WebKit] d34d9d: [Win] REGRESSION(269866@main): StringCommon.h(87) ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d34d9d14d3c41869a17402520129375c74f5cab7 https://github.com/WebKit/WebKit/commit/d34d9d14d3c41869a17402520129375c74f5cab7 Author: Fujii Hironori Date: 2023-10-27 (Fri, 27 Oct 2023) Changed paths: M Source/WTF/wtf/text/StringCommon.h Log Message: --- [Win] REGRESSION(269866@main): StringCommon.h(87) : equal : SHOULD NEVER BE REACHED for Windows port https://bugs.webkit.org/show_bug.cgi?id=263816 Unreviewed crash fix for Windows port. * Source/WTF/wtf/text/StringCommon.h: Replaced "fastLog2(length - 1)" with "fastLog2(length)". Canonical link: https://commits.webkit.org/269880@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a394a8: [Gardening][soup] http/tests/multipart/win-boundar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a394a8f37a5762c473895024e9f00555736efa10 https://github.com/WebKit/WebKit/commit/a394a8f37a5762c473895024e9f00555736efa10 Author: Fujii Hironori Date: 2023-10-27 (Fri, 27 Oct 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [Gardening][soup] http/tests/multipart/win-boundary-crash.html is crashing: soup_multipart_input_stream_read_headers: assertion 'got_lf' failed https://bugs.webkit.org/show_bug.cgi?id=263629 Unreviewed test gardening. * LayoutTests/platform/glib/TestExpectations: Skip crashing http/tests/multipart/win-boundary-crash.html. Canonical link: https://commits.webkit.org/269883@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a699a: SubresourceLoader should keep a ResourceResponse o...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a699a9eda3a9a5744da1dd4ea8ef862ad56b1e2 https://github.com/WebKit/WebKit/commit/3a699a9eda3a9a5744da1dd4ea8ef862ad56b1e2 Author: Fujii Hironori Date: 2023-10-31 (Tue, 31 Oct 2023) Changed paths: A LayoutTests/http/tests/multipart/images-expected.html A LayoutTests/http/tests/multipart/images.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/http/tests/multipart/invalid-image-data-expected.txt M Source/WebCore/loader/SubresourceLoader.cpp M Source/WebCore/loader/SubresourceLoader.h Log Message: --- SubresourceLoader should keep a ResourceResponse of the previous part of multipart/x-mixed-replace https://bugs.webkit.org/show_bug.cgi?id=263423 Reviewed by Chris Dumez. multipart/x-mixed-replace resources don't load progressively because it keeps showing the previous part content while loading the next part. Thus, SubresourceLoader finishes loading the current part content when the next resource responce comes in. SubresourceLoader::didReceiveResponse does the trick. It synthetically calls CachedResource::finishLoading for the previous part content. However, when CachedResource::finishLoading is called with the previous part content, CachedResource::responseReceived is already called with the next part resource responce. So, for example, if a multipart/x-mixed-replace resource contains two parts, CachedResource methods were called in the following sequence: CachedResource::responseReceived with multipart/x-mixed-replace CachedResource::responseReceived with the first part response CachedResource::responseReceived with the second part response CachedResource::finishLoading with the first part content CachedResource::finishLoading with the second part content As the result, the last part doesn't show as expected. <https://webkit.org/b/36536> SubresourceLoader has to keep the previous ResourceResponse and synthetically call CachedResource::responseReceived with it just before synthetically calling CachedResource::finishLoading. Also, this fixes another problem that debug build of Windows port was failing an assertion for http/tests/multipart/invalid-image-data.html test. The Image object wasn't recreated for the second part. CachedImage::responseReceived clears the previous Image object. But, it wasn't called for the second part just before finishLoading of the second part. * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/http/tests/multipart/invalid-image-data-expected.txt: * Source/WebCore/loader/SubresourceLoader.cpp: * Source/WebCore/loader/SubresourceLoader.h: * LayoutTests/http/tests/multipart/images-expected.html: Added. * LayoutTests/http/tests/multipart/images.html: Added. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/270023@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e3d10f: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e3d10f17ba8ef2e28373b7548232a513bf30e843 https://github.com/WebKit/WebKit/commit/e3d10f17ba8ef2e28373b7548232a513bf30e843 Author: Fujii Hironori Date: 2023-10-31 (Tue, 31 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/270044@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 85c759: Use more smart pointers in SubresourceLoader
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 85c7594d6be4e0c79e0981f2f6638baddd6dac5e https://github.com/WebKit/WebKit/commit/85c7594d6be4e0c79e0981f2f6638baddd6dac5e Author: Fujii Hironori Date: 2023-11-01 (Wed, 01 Nov 2023) Changed paths: M Source/WebCore/loader/ResourceLoader.cpp M Source/WebCore/loader/ResourceLoader.h M Source/WebCore/loader/SubresourceLoader.cpp Log Message: --- Use more smart pointers in SubresourceLoader https://bugs.webkit.org/show_bug.cgi?id=263999 Reviewed by Chris Dumez. * Source/WebCore/loader/ResourceLoader.cpp: (WebCore::ResourceLoader::protectedDocumentLoader const): * Source/WebCore/loader/ResourceLoader.h: (WebCore::ResourceLoader::protectedCachedResource const): * Source/WebCore/loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::init): (WebCore::SubresourceLoader::willSendRequestInternal): (WebCore::SubresourceLoader::didSendData): (WebCore::SubresourceLoader::didReceivePreviewResponse): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveBuffer): (WebCore::SubresourceLoader::responseHasHTTPStatusCodeError const): (WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::willCancel): (WebCore::SubresourceLoader::didCancel): (WebCore::SubresourceLoader::notifyDone): (WebCore::SubresourceLoader::releaseResources): (WebCore::SubresourceLoader::reportResourceTiming): Canonical link: https://commits.webkit.org/270049@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8eff97: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8eff9712c9e83d5d626e43d48636503265068855 https://github.com/WebKit/WebKit/commit/8eff9712c9e83d5d626e43d48636503265068855 Author: Fujii Hironori Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/269993@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 02a362: [Gardening] animations/transition-and-animation-2....
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02a36270bab5130e77b522e17b83f38b98f57ac2 https://github.com/WebKit/WebKit/commit/02a36270bab5130e77b522e17b83f38b98f57ac2 Author: Fujii Hironori Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening] animations/transition-and-animation-2.html is flaky https://bugs.webkit.org/show_bug.cgi?id=263923 Unreviewed test gardening. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/269994@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a7592: Update the GB18030 table for ICU 74.1
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a759283ec61057c92782099301d61db2da105ef https://github.com/WebKit/WebKit/commit/5a759283ec61057c92782099301d61db2da105ef Author: Fujii Hironori Date: 2023-10-31 (Tue, 31 Oct 2023) Changed paths: M Source/WebCore/PAL/pal/text/EncodingTables.cpp Log Message: --- Update the GB18030 table for ICU 74.1 https://bugs.webkit.org/show_bug.cgi?id=263953 Reviewed by Don Olmstead. An assertion was failing with ICU 74.1. > ASSERTION FAILED: (*array)[6555] == 0xe5e5 > WebCore\PAL\pal\text\EncodingTables.cpp(8630) : operator() ICU 74.1 fixed the problem. [ICU-22420] Align GB18030 decoders with the WHATWG decoding specification <https://unicode-org.atlassian.net/browse/ICU-22420> * Source/WebCore/PAL/pal/text/EncodingTables.cpp: Conditioned out the code if ICU >= 74. Canonical link: https://commits.webkit.org/270019@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fdc4da: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fdc4daa334e1ad2f0b6880c358ff06c9f972b244 https://github.com/WebKit/WebKit/commit/fdc4daa334e1ad2f0b6880c358ff06c9f972b244 Author: Fujii Hironori Date: 2023-11-03 (Fri, 03 Nov 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/270162@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b184ee: [Gardening] Flaky Test: animations/dynamic-stylesh...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b184eee59922f793e2ab04ab60f7ef8a918c7a08 https://github.com/WebKit/WebKit/commit/b184eee59922f793e2ab04ab60f7ef8a918c7a08 Author: Fujii Hironori Date: 2023-11-06 (Mon, 06 Nov 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening] Flaky Test: animations/dynamic-stylesheet-loading.html https://bugs.webkit.org/show_bug.cgi?id=52669 Unreviewed test gardening. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/270301@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b75c13: REGRESSION(269895@main): ASSERTION FAILED: !m_dele...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b75c1351a087aef447b4edf9c76005271fd18a06 https://github.com/WebKit/WebKit/commit/b75c1351a087aef447b4edf9c76005271fd18a06 Author: Fujii Hironori Date: 2023-10-29 (Sun, 29 Oct 2023) Changed paths: M Source/WebKit/UIProcess/WebProcessProxy.cpp Log Message: --- REGRESSION(269895@main): ASSERTION FAILED: !m_deletionHasBegun for WebProcessPool https://bugs.webkit.org/show_bug.cgi?id=263845 Reviewed by Chris Dumez. One more partial revert of 269895@main to address the assertion. * Source/WebKit/UIProcess/WebProcessProxy.cpp: Canonical link: https://commits.webkit.org/269914@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e33e71: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e33e718c1d7984a9b2a3a94d66bba0e4be6a8ba4 https://github.com/WebKit/WebKit/commit/e33e718c1d7984a9b2a3a94d66bba0e4be6a8ba4 Author: Fujii Hironori Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/269932@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c4f3c6: [Gardening] http/tests/security/xss-DENIED-script-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c4f3c627500f8dc0945746a8a8cf1862cfa54b6c https://github.com/WebKit/WebKit/commit/c4f3c627500f8dc0945746a8a8cf1862cfa54b6c Author: Fujii Hironori Date: 2023-10-30 (Mon, 30 Oct 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening] http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html is flaky recently https://bugs.webkit.org/show_bug.cgi?id=263879 Unreviewed test gardening. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/269933@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ae5f0d: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae5f0dd3d903723bb2dff38b9c9419401f78915d https://github.com/WebKit/WebKit/commit/ae5f0dd3d903723bb2dff38b9c9419401f78915d Author: Fujii Hironori Date: 2023-11-05 (Sun, 05 Nov 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/270253@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 824e7a: Rewrite Python CGI under http/tests/xmlhttprequest...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 824e7a817082c9aa5ce165ce62bf7db87cbb3478 https://github.com/WebKit/WebKit/commit/824e7a817082c9aa5ce165ce62bf7db87cbb3478 Author: Fujii Hironori Date: 2023-11-06 (Mon, 06 Nov 2023) Changed paths: M LayoutTests/http/tests/xmlhttprequest/resources/access-control-allow-lists.py M LayoutTests/http/tests/xmlhttprequest/resources/access-control-allow-with-body.py M LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir1/basic-auth.py M LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir2/basic-auth.py M LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir2/catch.py M LayoutTests/http/tests/xmlhttprequest/resources/chunked-transfer.py M LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-authorization.py M LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-check-cookies.py M LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-no-authorization.py M LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-preflight-get.py M LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-set-cookies.py M LayoutTests/http/tests/xmlhttprequest/resources/logout/resource.py M LayoutTests/http/tests/xmlhttprequest/resources/re-login/resource.py M LayoutTests/platform/wincairo/TestExpectations Log Message: --- Rewrite Python CGI under http/tests/xmlhttprequest to use binary mode for stdout for Windows Python https://bugs.webkit.org/show_bug.cgi?id=264238 Reviewed by Ross Kirsling. Windows Python automatically converts '\n' to '\r\n' in text mode. Use sys.stdout.buffer.write instead of sys.stdout.write. * LayoutTests/http/tests/xmlhttprequest/resources/access-control-allow-lists.py: * LayoutTests/http/tests/xmlhttprequest/resources/access-control-allow-with-body.py: * LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir1/basic-auth.py: * LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir2/basic-auth.py: * LayoutTests/http/tests/xmlhttprequest/resources/basic-auth-default/dir2/catch.py: * LayoutTests/http/tests/xmlhttprequest/resources/chunked-transfer.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-authorization.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-check-cookies.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-no-authorization.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-preflight-get.py: * LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-set-cookies.py: * LayoutTests/http/tests/xmlhttprequest/resources/logout/resource.py: * LayoutTests/http/tests/xmlhttprequest/resources/re-login/resource.py: * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/270258@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b7a358: [Gardening] http/tests/misc/object-embedding-svg-d...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b7a3586b052b986d3093cc7b6f04acd11ac8a211 https://github.com/WebKit/WebKit/commit/b7a3586b052b986d3093cc7b6f04acd11ac8a211 Author: Fujii Hironori Date: 2023-10-18 (Wed, 18 Oct 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=208396 Unreviewed test gardening. It isn't a platform specific failure. Promoted the flaky marker to the top common TestExpectations. * LayoutTests/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269505@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0ff06e: [Gardening] REGRESSION (r203142): Layout test js/r...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0ff06e582825160cf42469f7abe9ee332dd9d284 https://github.com/WebKit/WebKit/commit/0ff06e582825160cf42469f7abe9ee332dd9d284 Author: Fujii Hironori Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/mac-wk2/TestExpectations Log Message: --- [Gardening] REGRESSION (r203142): Layout test js/regress-139548.html is 10x slower. https://bugs.webkit.org/show_bug.cgi?id=160017 Unreviewed test gardeing. No ports are failing these days. Unmarked it. * LayoutTests/TestExpectations: * LayoutTests/platform/mac-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269507@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a6e0f8: REGRESSION(268259@main): ASSERTION FAILED: prologu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a6e0f8ae8578c6ccd1579437cfd44d47833ff5e6 https://github.com/WebKit/WebKit/commit/a6e0f8ae8578c6ccd1579437cfd44d47833ff5e6 Author: Fujii Hironori Date: 2023-09-22 (Fri, 22 Sep 2023) Changed paths: M Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp Log Message: --- REGRESSION(268259@main): ASSERTION FAILED: prologueSizeInBytesDataIC == (jit.debugOffset() - startOffset) https://bugs.webkit.org/show_bug.cgi?id=261928 Reviewed by Keith Miller. * Source/JavaScriptCore/bytecode/InlineCacheCompiler.cpp: Changed prologueSizeInBytesDataIC to 5 for Windows x64. Canonical link: https://commits.webkit.org/268333@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 30eedd: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 30eedddaa14fdffd58cd9917dd2a26cab2421d52 https://github.com/WebKit/WebKit/commit/30eedddaa14fdffd58cd9917dd2a26cab2421d52 Author: Fujii Hironori Date: 2023-09-24 (Sun, 24 Sep 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/268383@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e9f67f: REGRESSION(268343@main): Crash under WebCore::Posi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e9f67fe4c9c1a5881942e18067772c28897f6399 https://github.com/WebKit/WebKit/commit/e9f67fe4c9c1a5881942e18067772c28897f6399 Author: Fujii Hironori Date: 2023-09-24 (Sun, 24 Sep 2023) Changed paths: M Source/WebCore/rendering/RenderBlock.cpp Log Message: --- REGRESSION(268343@main): Crash under WebCore::PositionedDescendantsMap::removeContainingBlock https://bugs.webkit.org/show_bug.cgi?id=261998 Reviewed by Chris Dumez. Some layout tests were crashing under PositionedDescendantsMap::removeContainingBlock for WinCairo after 268343@main changed PositionedDescendantsMap::ContainerMap to WeakHashMap. 'renderer' in removeContainingBlock wasn't a live RenderBox object in the cases. Previously it has no problem because it just used a raw pointer as a key. Changed the key of ContainerMap to const RenderBox*. * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::PositionedDescendantsMap::addDescendant): (WebCore::PositionedDescendantsMap::removeDescendant): (WebCore::PositionedDescendantsMap::removeContainingBlock): Canonical link: https://commits.webkit.org/268373@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 26540a: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 26540a38cc297ca24c8f4be1212ea8111c6e8cd0 https://github.com/WebKit/WebKit/commit/26540a38cc297ca24c8f4be1212ea8111c6e8cd0 Author: Fujii Hironori Date: 2023-10-01 (Sun, 01 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/fast/line-grid/line-align-left-edges-expected.txt M LayoutTests/platform/wincairo/fast/line-grid/line-align-right-edges-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/fast/line-grid/line-align-left-edges-expected.txt: * LayoutTests/platform/wincairo/fast/line-grid/line-align-right-edges-expected.txt: Canonical link: https://commits.webkit.org/268708@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fed6dd: [Win] Fix -Wundef and -Wnonportable-include-path c...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fed6dd1cc3869b517a33f1f8a22df6c30a0e0a2d https://github.com/WebKit/WebKit/commit/fed6dd1cc3869b517a33f1f8a22df6c30a0e0a2d Author: Fujii Hironori Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: M Source/WTF/wtf/Brigand.h M Source/WebCore/crypto/openssl/OpenSSLUtilities.h M Source/WebCore/platform/network/curl/CookieJarDB.cpp M Source/WebCore/platform/win/HWndDC.h M Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp M Source/cmake/WebKitCompilerFlags.cmake M Tools/Scripts/webkitdirs.pm M Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp Log Message: --- [Win] Fix -Wundef and -Wnonportable-include-path compiler warnings https://bugs.webkit.org/show_bug.cgi?id=262473 Reviewed by Ross Kirsling. Fixed more clang-cl warnings. > wtf/Brigand.h(41,7): warning: '__GNUC__' is not defined, evaluates to 0 > [-Wundef] > Source\WebCore\platform\network\curl\CookieJarDB.cpp(27,10): warning: > non-portable path to file '"CookieJar.h"'; > specified path differs in case from file name on disk > [-Wnonportable-include-path] * Source/WTF/wtf/Brigand.h: * Source/WebCore/crypto/openssl/OpenSSLUtilities.h: * Source/WebCore/platform/network/curl/CookieJarDB.cpp: * Source/WebCore/platform/win/HWndDC.h: * Source/WebKit/UIProcess/Launcher/win/ProcessLauncherWin.cpp: * Source/cmake/WebKitCompilerFlags.cmake: * Tools/Scripts/webkitdirs.pm: (shouldRemoveCMakeCache): Remove CMakeCache.txt if WebKitCompilerFlags.cmake is modified. * Tools/TestWebKitAPI/Tests/WebCore/CryptoDigest.cpp: Canonical link: https://commits.webkit.org/268748@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7b833e: [Win] Generate VS project files with '-T ClangCL' ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7b833e8e18ce1474a00504b49ff46757b96e1a83 https://github.com/WebKit/WebKit/commit/7b833e8e18ce1474a00504b49ff46757b96e1a83 Author: Fujii Hironori Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: M Tools/Scripts/webkitdirs.pm Log Message: --- [Win] Generate VS project files with '-T ClangCL' if $CC is 'clang-cl' https://bugs.webkit.org/show_bug.cgi?id=262506 Reviewed by Don Olmstead. Pass '-T ClangCL' switches to CMake Visual Studio generator to enable clang-cl toolset. * Tools/Scripts/webkitdirs.pm: (getCMakeWindowsToolsetArgument): Canonical link: https://commits.webkit.org/268758@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6aa75e: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6aa75e132551667add198a0086dcb4a56efe68f1 https://github.com/WebKit/WebKit/commit/6aa75e132551667add198a0086dcb4a56efe68f1 Author: Fujii Hironori Date: 2023-10-02 (Mon, 02 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/editing/selection/5057506-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/editing/selection/5057506-expected.txt: Canonical link: https://commits.webkit.org/268765@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0c72c1: [Win] Ninja clang-cl and MSBuild clang-cl should u...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0c72c18c1345de2fd7f98b39e2e6d85808a13592 https://github.com/WebKit/WebKit/commit/0c72c18c1345de2fd7f98b39e2e6d85808a13592 Author: Fujii Hironori Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M Source/cmake/OptionsMSVC.cmake M Source/cmake/WebKitCompilerFlags.cmake Log Message: --- [Win] Ninja clang-cl and MSBuild clang-cl should use the same compiler warning flags https://bugs.webkit.org/show_bug.cgi?id=262166 Reviewed by Ross Kirsling. CMake Visual Studio generator ignores MSVC-style compiler warning flags for clang-cl, for example /wd4100, while CMake Ninja generator doesn't. They should be aligned. Don't use MSVC-style compiler warning flags for clang-cl. Instead, use GCC-style for it. * Source/cmake/OptionsMSVC.cmake: * Source/cmake/WebKitCompilerFlags.cmake: Canonical link: https://commits.webkit.org/268497@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6cc3f8: [Win] Fix unused parameter warnings reported by cl...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6cc3f85ca0cf2ead6c93a48cf5b0511876180a0d https://github.com/WebKit/WebKit/commit/6cc3f85ca0cf2ead6c93a48cf5b0511876180a0d Author: Fujii Hironori Date: 2023-09-25 (Mon, 25 Sep 2023) Changed paths: M Source/WTF/wtf/win/FileSystemWin.cpp M Source/WTF/wtf/win/MemoryPressureHandlerWin.cpp M Source/WTF/wtf/win/OSAllocatorWin.cpp M Source/WebCore/accessibility/win/AccessibilityObjectWin.cpp M Source/WebCore/platform/StaticPasteboard.cpp M Source/WebCore/platform/graphics/Image.h M Source/WebCore/platform/graphics/win/FontCacheWin.cpp M Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp M Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp M Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp M Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h M Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp M Source/WebCore/platform/network/win/NetworkStateNotifierWin.cpp M Source/WebCore/platform/win/PasteboardWin.cpp M Source/WebCore/platform/win/PlatformMouseEventWin.cpp M Source/WebCore/platform/win/WidgetWin.cpp M Source/WebDriver/win/WebDriverServiceWin.cpp M Tools/MiniBrowser/win/DialogHelper.h M Tools/MiniBrowser/win/InjectedBundle.cpp M Tools/MiniBrowser/win/WebKitBrowserWindow.cpp M Tools/MiniBrowser/win/WinMain.cpp Log Message: --- [Win] Fix unused parameter warnings reported by clang-cl https://bugs.webkit.org/show_bug.cgi?id=262098 Reviewed by Ross Kirsling. clang-cl reported a lot of unused parameter warnings like the following. > Source\WebCore\platform/StaticPasteboard.cpp(143,58): error: unused parameter > 'content' [-Werror,-Wunused-parameter] * Source/WTF/wtf/win/FileSystemWin.cpp: (WTF::FileSystemImpl::fileID): (WTF::FileSystemImpl::fileIDsAreEqual): (WTF::FileSystemImpl::flushFile): * Source/WTF/wtf/win/MemoryPressureHandlerWin.cpp: (WTF::MemoryPressureHandler::holdOff): * Source/WTF/wtf/win/OSAllocatorWin.cpp: (WTF::OSAllocator::tryReserveUncommittedAligned): * Source/WebCore/accessibility/win/AccessibilityObjectWin.cpp: (WebCore::AccessibilityObject::detachPlatformWrapper): * Source/WebCore/platform/graphics/Image.h: (WebCore::Image::drawFrameMatchingSourceSize): * Source/WebCore/platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): (WebCore::linkedFontEnumProc): (WebCore::matchImprovingEnumProc): (WebCore::traitsInFamilyEnumProc): * Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::FontPlatformData::platformDataInit): * Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp: (WebCore::createCairoContextWithHDC): (WebCore::GraphicsContextCairo::GraphicsContextCairo): * Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp: (WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::OnClockStart): (WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::OnClockStop): (WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::OnClockPause): (WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::OnClockRestart): (WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::OnClockSetRate): (WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::ProcessMessage): (WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::getService): (WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::presentSample): * Source/WebCore/platform/graphics/win/MediaPlayerPrivateMediaFoundation.h: * Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::Font::platformCreateScaledFont const): * Source/WebCore/platform/network/win/NetworkStateNotifierWin.cpp: (WebCore::NetworkStateNotifier::addressChangeCallback): * Source/WebCore/platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writePlainTextToDataObject): * Source/WebCore/platform/win/PlatformMouseEventWin.cpp: (WebCore::positionForEvent): * Source/WebCore/platform/win/WidgetWin.cpp: (WebCore::Widget::setFocus): * Source/WebDriver/win/WebDriverServiceWin.cpp: (WebDriver::WebDriverService::platformCompareBrowserVersions): (WebDriver::WebDriverService::platformValidateCapability const): * Tools/MiniBrowser/win/DialogHelper.h: (Dialog::command): * Tools/MiniBrowser/win/InjectedBundle.cpp: (didReceiveMessageToPage): * Tools/MiniBrowser/win/WebKitBrowserWindow.cpp: (WebKitBrowserWindow::navigateToHistory): (WebKitBrowserWindow::updateStatistics): (WebKitBrowserWindow::decidePolicyForNavigationResponse): (WebKitBrowserWindow::didFailProvisionalNavigation): (WebKitBrowserWindow::didReceiveAuthenticationChallenge): (WebKitBrowserWindow::createNewPage): (WebKitBrowserWindow::runJavaScriptAlert): (WebKitBrowserWindow::runJavaScriptConfirm): (WebKitBrowserWindow::runJavaScriptPrompt): * Tools/MiniBrowser/win/WinMain.cpp: (wWinMain): Canonica
[webkit-changes] [WebKit/WebKit] ca3f26: [Win] failing to install rapidfuzz-2.11.1
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca3f26ebbb57485c9aefd3cee2b1b12e0d7c6f29 https://github.com/WebKit/WebKit/commit/ca3f26ebbb57485c9aefd3cee2b1b12e0d7c6f29 Author: Fujii Hironori Date: 2023-09-26 (Tue, 26 Sep 2023) Changed paths: M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py Log Message: --- [Win] failing to install rapidfuzz-2.11.1 https://bugs.webkit.org/show_bug.cgi?id=262154 Reviewed by Jonathan Bedard. git-webkit was failing to install rapidfuzz-2.11.1 due to missing pyparsing in a fresh checkout working copy on Windows. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Added implicit_deps of pyparsing to rapidfuzz. Canonical link: https://commits.webkit.org/268494@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe54e5: Unreviewed build fix for Windows port
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe54e50383ada7a7d90719370efbc755173448d8 https://github.com/WebKit/WebKit/commit/fe54e50383ada7a7d90719370efbc755173448d8 Author: Fujii Hironori Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: M Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp Log Message: --- Unreviewed build fix for Windows port clang-cl release builds couldn't compile. > JavaScriptCore\inspector\remote\socket\win\RemoteInspectorSocketWin.cpp(100,104): > warning: unused parameter 'debug' [-Wunused-parameter] * Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp: (Inspector::Socket::setOpt): Use UNUSED_PARAM for it. Canonical link: https://commits.webkit.org/268534@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] acb83c: REGRESSION(268551@main): Restore rendering/svg/leg...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: acb83c08ddc28ae3f0e279b68f6a33801480 https://github.com/WebKit/WebKit/commit/acb83c08ddc28ae3f0e279b68f6a33801480 Author: Fujii Hironori Date: 2023-09-27 (Wed, 27 Sep 2023) Changed paths: A Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h Log Message: --- REGRESSION(268551@main): Restore rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h https://bugs.webkit.org/show_bug.cgi?id=262227 Unreviewed build fix. * Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceClipperInlines.h: Added. Canonical link: https://commits.webkit.org/268554@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e244db: animations/animation-delay-changed.html is randoml...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e244db9b198977e223e12ea4acbb236e55d891e9 https://github.com/WebKit/WebKit/commit/e244db9b198977e223e12ea4acbb236e55d891e9 Author: Fujii Hironori Date: 2023-10-03 (Tue, 03 Oct 2023) Changed paths: M LayoutTests/animations/animation-delay-changed-expected.txt M LayoutTests/animations/animation-delay-changed.html M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/ios/TestExpectations M LayoutTests/platform/mac/TestExpectations M LayoutTests/platform/wincairo/TestExpectations Log Message: --- animations/animation-delay-changed.html is randomly failing https://bugs.webkit.org/show_bug.cgi?id=111612 Reviewed by Don Olmstead. In this test case, both box1 and box2 move from 0 to 200, and go back to 0 when the animations finish. The test case checks if box1 position is around 200. However, it's the end of the animation. Thus, the position randomly results in around 200 or 0. On the other hand, the test case also checks if box2 position is around 100. It's the middle of the animation. Do the same for box1. Check the position of box1 at the middle of the animation. * LayoutTests/animations/animation-delay-changed-expected.txt: * LayoutTests/animations/animation-delay-changed.html: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/ios/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/268812@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7c14f4: [Win] WebGL conformance tests need more stack space
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7c14f48e920ca37ecc95417fd1a5aa59e8365ada https://github.com/WebKit/WebKit/commit/7c14f48e920ca37ecc95417fd1a5aa59e8365ada Author: Fujii Hironori Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M Source/WTF/wtf/Threading.cpp Log Message: --- [Win] WebGL conformance tests need more stack space https://bugs.webkit.org/show_bug.cgi?id=261297 Reviewed by Ross Kirsling. The following WebGL tests were crashing due to stack overflow for Windows Debug builds and clang-cl Release builds. webgl/2.0.y/conformance/glsl/bugs/complex-glsl-does-not-crash.html [ Crash ] webgl/2.0.y/conformance/glsl/misc/shader-uniform-packing-restrictions.html [ Crash ] The WebGL team suggests to allocate more stack space for the tests. * LayoutTests/platform/wincairo/TestExpectations: * Source/WTF/wtf/Threading.cpp: (WTF::stackSize): Increased the stack size for graphics threads. Canonical link: https://commits.webkit.org/268108@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 759a8e: REGRESSION(268090@main): WCBackingStore.h(61, 31): ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 759a8e3ae11502727b3d6dc6e89110ac7ed2bd7e https://github.com/WebKit/WebKit/commit/759a8e3ae11502727b3d6dc6e89110ac7ed2bd7e Author: Fujii Hironori Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.h Log Message: --- REGRESSION(268090@main): WCBackingStore.h(61,31): warning: use 'template' keyword to treat 'decode' as a dependent template name https://bugs.webkit.org/show_bug.cgi?id=261721 Unreviewed build fix for clang-cl Windows build. * Source/WebKit/WebProcess/WebPage/wc/WCBackingStore.h: (WebKit::WCBackingStore::decode): Use `template` keyword. Canonical link: https://commits.webkit.org/268109@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5a4bac: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5a4bacbf612ef4b96a124a6ceb9a909c779e2d6f https://github.com/WebKit/WebKit/commit/5a4bacbf612ef4b96a124a6ceb9a909c779e2d6f Author: Fujii Hironori Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/268096@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c12cd6: Revert [268180@main] [Curl] Support multipart resp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c12cd61edd95d63e88424b7a148315864a426da7 https://github.com/WebKit/WebKit/commit/c12cd61edd95d63e88424b7a148315864a426da7 Author: Fujii Hironori Date: 2023-09-20 (Wed, 20 Sep 2023) Changed paths: M Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp M Source/WebCore/platform/network/curl/CurlMultipartHandle.h M Source/WebCore/platform/network/curl/CurlMultipartHandleClient.h M Source/WebCore/platform/network/curl/CurlRequest.cpp M Source/WebCore/platform/network/curl/CurlRequest.h M Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp M Tools/TestWebKitAPI/PlatformWin.cmake R Tools/TestWebKitAPI/Tests/WebCore/curl/CurlMultipartHandleTests.cpp Log Message: --- Revert [268180@main] [Curl] Support multipart response https://bugs.webkit.org/show_bug.cgi?id=261104 WinCairo is crashing. Unreviewed revert. * Source/WebCore/platform/network/curl/CurlMultipartHandle.cpp: (WebCore::CurlMultipartHandle::createIfNeeded): (WebCore::CurlMultipartHandle::extractBoundary): (WebCore::CurlMultipartHandle::extractBoundaryFromContentType): (WebCore::CurlMultipartHandle::CurlMultipartHandle): (WebCore::CurlMultipartHandle::didReceiveData): (WebCore::CurlMultipartHandle::didComplete): (WebCore::CurlMultipartHandle::processContent): (WebCore::CurlMultipartHandle::checkForBoundary): (WebCore::CurlMultipartHandle::matchedLength): (WebCore::CurlMultipartHandle::parseHeadersIfPossible): (WebCore::extractBoundary): Deleted. (WebCore::CurlMultipartHandle::didReceiveMessage): Deleted. (WebCore::CurlMultipartHandle::completeHeaderProcessing): Deleted. (WebCore::CurlMultipartHandle::didCompleteMessage): Deleted. (WebCore::CurlMultipartHandle::findBoundary): Deleted. * Source/WebCore/platform/network/curl/CurlMultipartHandle.h: (WebCore::CurlMultipartHandle::completed): Deleted. (WebCore::CurlMultipartHandle::hasError const): Deleted. * Source/WebCore/platform/network/curl/CurlMultipartHandleClient.h: * Source/WebCore/platform/network/curl/CurlRequest.cpp: (WebCore::CurlRequest::CurlRequest): (WebCore::CurlRequest::didReceiveHeader): (WebCore::CurlRequest::didReceiveData): (WebCore::CurlRequest::didReceiveHeaderFromMultipart): (WebCore::CurlRequest::didReceiveDataFromMultipart): (WebCore::CurlRequest::didCompleteTransfer): (WebCore::CurlRequest::didCompleteFromMultipart): Deleted. * Source/WebCore/platform/network/curl/CurlRequest.h: (WebCore::CurlRequest::create): * Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp: (WebKit::NetworkDataTaskCurl::createCurlRequest): * Tools/TestWebKitAPI/PlatformWin.cmake: * Tools/TestWebKitAPI/Tests/WebCore/curl/CurlMultipartHandleTests.cpp: Removed. Canonical link: https://commits.webkit.org/268213@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aa8ce9: REGRESSION(268368@main): causes an assertion failu...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aa8ce99efeeaa07ae4e59e26710a841edffe5927 https://github.com/WebKit/WebKit/commit/aa8ce99efeeaa07ae4e59e26710a841edffe5927 Author: Fujii Hironori Date: 2023-09-24 (Sun, 24 Sep 2023) Changed paths: M Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp Log Message: --- REGRESSION(268368@main): causes an assertion failure for http tests https://bugs.webkit.org/show_bug.cgi?id=262016 Unreviewed revert 268368@main partially. * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::InjectedBundle::beginTesting): Canonical link: https://commits.webkit.org/268377@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] caff91: REGRESSION(268453@main): error: incomplete type 'W...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: caff9124ec4b8ae65cef9f907f2cb29e0f184264 https://github.com/WebKit/WebKit/commit/caff9124ec4b8ae65cef9f907f2cb29e0f184264 Author: Fujii Hironori Date: 2023-09-26 (Tue, 26 Sep 2023) Changed paths: M Source/WebKit/WebProcess/Network/WebSocketProvider.cpp Log Message: --- REGRESSION(268453@main): error: incomplete type 'WebCore::Document' used in type trait expression https://bugs.webkit.org/show_bug.cgi?id=261007 Debug builds of some ports couldn't compile. Unreviewed build fix. > include\type_traits(1317,71): error: incomplete type 'WebCore::Document' used > in type trait expression * Source/WebKit/WebProcess/Network/WebSocketProvider.cpp: Include . Canonical link: https://commits.webkit.org/268473@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 799e82: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 799e821af6a647559fb4fe51fbd1cbc920ad22e4 https://github.com/WebKit/WebKit/commit/799e821af6a647559fb4fe51fbd1cbc920ad22e4 Author: Fujii Hironori Date: 2023-10-05 (Thu, 05 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/fast/line-grid/line-grid-contains-value-expected.txt M LayoutTests/platform/wincairo/fast/line-grid/line-grid-floating-expected.txt M LayoutTests/platform/wincairo/fast/line-grid/line-grid-into-columns-expected.txt M LayoutTests/platform/wincairo/fast/line-grid/line-grid-positioned-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/fast/line-grid/line-grid-contains-value-expected.txt: * LayoutTests/platform/wincairo/fast/line-grid/line-grid-floating-expected.txt: * LayoutTests/platform/wincairo/fast/line-grid/line-grid-into-columns-expected.txt: * LayoutTests/platform/wincairo/fast/line-grid/line-grid-positioned-expected.txt: Canonical link: https://commits.webkit.org/268903@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 273a25: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 273a25921fdc2fcb0539b5567238fa01a9305d95 https://github.com/WebKit/WebKit/commit/273a25921fdc2fcb0539b5567238fa01a9305d95 Author: Fujii Hironori Date: 2023-10-11 (Wed, 11 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/editing/selection/5057506-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/editing/selection/5057506-expected.txt: Canonical link: https://commits.webkit.org/269232@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0f0669: [WinCairo] Use Cairo DirectWrite font backend
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0f066948ca64aeef6b9afbe74f078d7e46406b36 https://github.com/WebKit/WebKit/commit/0f066948ca64aeef6b9afbe74f078d7e46406b36 Author: Fujii Hironori Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M Source/WebCore/PlatformWin.cmake M Source/WebCore/platform/graphics/cairo/FontCairo.cpp M Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp M Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp M Source/cmake/OptionsWin.cmake Log Message: --- [WinCairo] Use Cairo DirectWrite font backend https://bugs.webkit.org/show_bug.cgi?id=215259 Reviewed by Don Olmstead. cairo 1.18.0 added the dwrite font backend. Use it instead of the legacy cairo win32 font backend. Windows port supports color font now. However, Windows port is still using the lagacy Uniscribe API for shaping. It should be replaced by DirectWrite in the future. * Source/WebCore/PlatformWin.cmake: * Source/WebCore/platform/graphics/FontPlatformData.h: * Source/WebCore/platform/graphics/cairo/FontCairo.cpp: (WebCore::FontCascade::drawGlyphs): * Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): * Source/WebCore/platform/graphics/win/FontCustomPlatformDataWin.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): * Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::getDWriteGdiInterop): (WebCore::createCairoDWriteFontFace): (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::familyName const): * Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): * Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::Font::platformInit): * LayoutTests/platform/wincairo/TestExpectations: * Source/cmake/OptionsWin.cmake: Canonical link: https://commits.webkit.org/269270@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ee827: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ee827e4b2a2d7adb85af4b66a3138849d9e95c5 https://github.com/WebKit/WebKit/commit/8ee827e4b2a2d7adb85af4b66a3138849d9e95c5 Author: Fujii Hironori Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/compositing/repaint/invalidations-on-composited-layers-with-subpixel-positions-expected.txt M LayoutTests/platform/wincairo/css1/basic/containment-expected.txt M LayoutTests/platform/wincairo/css1/basic/contextual_selectors-expected.txt M LayoutTests/platform/wincairo/css1/basic/grouping-expected.txt M LayoutTests/platform/wincairo/css1/basic/id_as_selector-expected.txt M LayoutTests/platform/wincairo/css1/basic/inheritance-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/acid_test-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_bottom-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_bottom_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_bottom_width-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_bottom_width_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_color-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_color_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_left-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_left_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_left_width-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_left_width_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_right-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_right_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_right_width-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_right_width_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_style-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_style_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_top-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_top_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_top_width-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_top_width_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_width-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/border_width_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/clear-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/clear_float-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/float-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/float_elements_in_series-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/float_margin-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/float_on_text_elements-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/height-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_bottom-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_bottom_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_left-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_left_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_right-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_right_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_top-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/margin_top_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/padding-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/padding_bottom-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/padding_bottom_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/padding_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/padding_left-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/padding_left_inline-expected.txt M LayoutTests/platform/wincairo/css1/box_properties/padding_right-expected.txt M
[webkit-changes] [WebKit/WebKit] 6d7089: REGRESSION(269270@main): [Win] FontCairo.cpp: erro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6d7089f0d592a784e26c3460213f85a715794757 https://github.com/WebKit/WebKit/commit/6d7089f0d592a784e26c3460213f85a715794757 Author: Fujii Hironori Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M Source/WebCore/platform/graphics/cairo/FontCairo.cpp Log Message: --- REGRESSION(269270@main): [Win] FontCairo.cpp: error: no member named 'uncheckedAppend' in 'WTF::Vector' https://bugs.webkit.org/show_bug.cgi?id=215259 Unreviewed build fix. * Source/WebCore/platform/graphics/cairo/FontCairo.cpp: Use append instead of uncheckedAppend. Canonical link: https://commits.webkit.org/269275@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cd8422: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cd8422cd85e8c6533d81966487dca0268e29ccf8 https://github.com/WebKit/WebKit/commit/cd8422cd85e8c6533d81966487dca0268e29ccf8 Author: Fujii Hironori Date: 2023-10-07 (Sat, 07 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/editing/selection/drag-in-iframe-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/editing/selection/drag-in-iframe-expected.txt: Canonical link: https://commits.webkit.org/269035@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5051fe: [Win] Reduce cairo win32 font API usage
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5051fe83ad0c60f63ecc59b3cc91c4b3a7bca8ec https://github.com/WebKit/WebKit/commit/5051fe83ad0c60f63ecc59b3cc91c4b3a7bca8ec Author: Fujii Hironori Date: 2023-10-06 (Fri, 06 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/fast/text/whitespace/nowrap-clear-float-expected.txt M Source/WebCore/platform/graphics/FontPlatformData.h M Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp M Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp M Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp Log Message: --- [Win] Reduce cairo win32 font API usage https://bugs.webkit.org/show_bug.cgi?id=262768 Reviewed by Don Olmstead. As a preparation of migration to cairo dwrite font backend (bug#215259), use Windows GDI API to get font information instead of cairo win32 font API. Windows port is still using the legacy Uniscribe API for shaping. The legacy Windows GDI API should be replaced by DirectWrite in the futute. * Source/WebCore/platform/graphics/FontPlatformData.h: * Source/WebCore/platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::familyName const): * Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): * Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::Font::platformInit): * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/269016@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 29536d: [Gardening] http/tests/security/service-worker-net...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 29536df45fc5aa5eb623a2d17480d8dfd32cb3f1 https://github.com/WebKit/WebKit/commit/29536df45fc5aa5eb623a2d17480d8dfd32cb3f1 Author: Fujii Hironori Date: 2023-10-05 (Thu, 05 Oct 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening] http/tests/security/service-worker-network-load.html is randomly timing out since the beginning https://bugs.webkit.org/show_bug.cgi?id=262734 Unreviewed test gardening. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/268952@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1d5348: [Gardening] storage/indexeddb/modern/transactions-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1d5348a4faaf8305e521dccb8b889ec84e5b118d https://github.com/WebKit/WebKit/commit/1d5348a4faaf8305e521dccb8b889ec84e5b118d Author: Fujii Hironori Date: 2023-10-17 (Tue, 17 Oct 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/platform/ios-wk2/TestExpectations Log Message: --- [Gardening] storage/indexeddb/modern/transactions-stop-on-navigation.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=208656 Unreviewed test gardening. It is flaky not only for iOS. Promote the flaky marker to the top common TestExpectations. * LayoutTests/TestExpectations: * LayoutTests/platform/ios-wk2/TestExpectations: Canonical link: https://commits.webkit.org/269446@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b5146d: animations/animation-delay-changed.html is randoml...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b5146d846e8364528ca6f347aaf7f203ae6d5592 https://github.com/WebKit/WebKit/commit/b5146d846e8364528ca6f347aaf7f203ae6d5592 Author: Fujii Hironori Date: 2023-10-17 (Tue, 17 Oct 2023) Changed paths: M LayoutTests/animations/animation-delay-changed-expected.txt M LayoutTests/animations/animation-delay-changed.html Log Message: --- animations/animation-delay-changed.html is randomly failing https://bugs.webkit.org/show_bug.cgi?id=111612 Reviewed by Don Olmstead. In this test case, animations move by 200px during 1s. 200px/s is too quick for some tester buildbots to test realiably. Change the animation duration to 4s. * LayoutTests/animations/animation-delay-changed.html: * LayoutTests/animations/animation-delay-changed-expected.txt: Canonical link: https://commits.webkit.org/269450@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f2921e: REGRESSION(269405@main)[Win] /OPT:NOICF linker swi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f2921eabafd54691bddf7342542e6e1257a6d7f0 https://github.com/WebKit/WebKit/commit/f2921eabafd54691bddf7342542e6e1257a6d7f0 Author: Fujii Hironori Date: 2023-10-17 (Tue, 17 Oct 2023) Changed paths: M Source/cmake/OptionsMSVC.cmake Log Message: --- REGRESSION(269405@main)[Win] /OPT:NOICF linker switch is duplicated for debug build https://bugs.webkit.org/show_bug.cgi?id=263285 Reviewed by Don Olmstead. 269405@main added /OPT:NOICF switch, but 16@main also added it for debug build. * Source/cmake/OptionsMSVC.cmake: Removed /OPT:NOICF switch of debug build. Use string(APPEND). Canonical link: https://commits.webkit.org/269439@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a89b68: [Win][Clang] Remove -fmsc-version=1911 compiler sw...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a89b68fd1a995a56b08f6c1c1a7f302e51137502 https://github.com/WebKit/WebKit/commit/a89b68fd1a995a56b08f6c1c1a7f302e51137502 Author: Fujii Hironori Date: 2023-10-17 (Tue, 17 Oct 2023) Changed paths: M Source/cmake/OptionsMSVC.cmake Log Message: --- [Win][Clang] Remove -fmsc-version=1911 compiler switch https://bugs.webkit.org/show_bug.cgi?id=263283 Reviewed by Don Olmstead. 190776@main (bug#173889) added -fmsc-version=1911 compiler switch for clang-cl. However, it seems that it is no longer needed. * Source/cmake/OptionsMSVC.cmake: Canonical link: https://commits.webkit.org/269438@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 903c53: Rewrite Python CGI under http/tests/multipart for ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 903c53aa4abcd48c2108c02ab063043c746cd91c https://github.com/WebKit/WebKit/commit/903c53aa4abcd48c2108c02ab063043c746cd91c Author: Fujii Hironori Date: 2023-10-20 (Fri, 20 Oct 2023) Changed paths: M LayoutTests/http/tests/multipart/load-last-non-html-frame.py M LayoutTests/http/tests/multipart/multipart-html.py M LayoutTests/http/tests/multipart/multipart-replace-non-html-content.py M LayoutTests/http/tests/multipart/policy-ignore-crash.py M LayoutTests/http/tests/multipart/resources/multipart-nodashes.py M LayoutTests/http/tests/multipart/resources/multipart-wait-before-boundary.py M LayoutTests/http/tests/multipart/resources/multipart.py M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/http/tests/multipart/invalid-image-data-standalone-expected.txt Log Message: --- Rewrite Python CGI under http/tests/multipart for Windows Python https://bugs.webkit.org/show_bug.cgi?id=263425 Reviewed by Ross Kirsling. Windows Python replaces '\n' to '\r\n' for sys.stdout. Use sys.stdout.buffer.write instead of sys.stdout.write. * LayoutTests/http/tests/multipart/load-last-non-html-frame.py: * LayoutTests/http/tests/multipart/multipart-html.py: * LayoutTests/http/tests/multipart/multipart-replace-non-html-content.py: * LayoutTests/http/tests/multipart/policy-ignore-crash.py: * LayoutTests/http/tests/multipart/resources/multipart-nodashes.py: * LayoutTests/http/tests/multipart/resources/multipart-wait-before-boundary.py: * LayoutTests/http/tests/multipart/resources/multipart.py: * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/http/tests/multipart/invalid-image-data-standalone-expected.txt: Canonical link: https://commits.webkit.org/269589@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f40446: [Win] http/tests/cookies/document-cookie-during-if...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f40446c2645c3cf9a055b3fb0cc3af486b297891 https://github.com/WebKit/WebKit/commit/f40446c2645c3cf9a055b3fb0cc3af486b297891 Author: Fujii Hironori Date: 2023-10-20 (Fri, 20 Oct 2023) Changed paths: M LayoutTests/http/tests/cookies/resources/set-cookie-and-serve.py M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [Win] http/tests/cookies/document-cookie-during-iframe-parsing.html is timing out https://bugs.webkit.org/show_bug.cgi?id=263364 Reviewed by Ross Kirsling. Windows Python replaces '\n' to '\r\n' for sys.stdout. Use sys.stdout.buffer.write instead of sys.stdout.write. * LayoutTests/http/tests/cookies/resources/set-cookie-and-serve.py: * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/269590@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a505a: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a505adc4a76419ff3b04725e52eb62131da1259 https://github.com/WebKit/WebKit/commit/6a505adc4a76419ff3b04725e52eb62131da1259 Author: Fujii Hironori Date: 2023-10-22 (Sun, 22 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/fast/text/softbank-emoji-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening Rebaselined fast/text/softbank-emoji-expected.txt after 269524@main. Unskipped passing tests under imported/w3c/web-platform-tests/css. * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/fast/text/softbank-emoji-expected.txt: Canonical link: https://commits.webkit.org/269637@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d18826: [Win] Some layout tests are failing due to the CR ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d1882602c9b1bf88acf98357c435cfea6efc2a70 https://github.com/WebKit/WebKit/commit/d1882602c9b1bf88acf98357c435cfea6efc2a70 Author: Fujii Hironori Date: 2023-10-15 (Sun, 15 Oct 2023) Changed paths: M LayoutTests/.gitattributes Log Message: --- [Win] Some layout tests are failing due to the CR LF line end style if they are checked out by Windows Git https://bugs.webkit.org/show_bug.cgi?id=263174 Reviewed by Ross Kirsling. The defalut settings of Windows Git is core.autocrlf=true. Add '-crlf' attributes for the tests for it. See also bug#34645. * LayoutTests/.gitattributes: Canonical link: https://commits.webkit.org/269350@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 15855e: REGRESSION(269016@main) [Win] fast/forms/listbox-z...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 15855ea0a70708ea758ab7917dafe852e1fbd711 https://github.com/WebKit/WebKit/commit/15855ea0a70708ea758ab7917dafe852e1fbd711 Author: Fujii Hironori Date: 2023-10-15 (Sun, 15 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp Log Message: --- REGRESSION(269016@main) [Win] fast/forms/listbox-zero-item-height.html is randomly failing https://bugs.webkit.org/show_bug.cgi?id=263101 Reviewed by Ross Kirsling. The following tests were randomly failing after 269016@main.. fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-svg.html fast/css3-text/css3-text-decoration/text-decoration-thickness.html fast/forms/listbox-zero-item-height.html Uninitialized OUTLINETEXTMETRIC was used if GetOutlineTextMetrics failed. Check the return value of GetOutlineTextMetrics. * LayoutTests/platform/wincairo/TestExpectations: * Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp: Canonical link: https://commits.webkit.org/269354@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] abb444: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: abb444cf09b6e934ceac492efad87bf5e328479d https://github.com/WebKit/WebKit/commit/abb444cf09b6e934ceac492efad87bf5e328479d Author: Fujii Hironori Date: 2023-10-16 (Mon, 16 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/269355@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9b0a91: REGRESSION(269701@main): Unreviewed build fix for ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9b0a913d44af9f5a7b26a94ad024fe77498291bf https://github.com/WebKit/WebKit/commit/9b0a913d44af9f5a7b26a94ad024fe77498291bf Author: Fujii Hironori Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp Log Message: --- REGRESSION(269701@main): Unreviewed build fix for Windows port https://bugs.webkit.org/show_bug.cgi?id=263566 > WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp(158,30): error: use of > undeclared identifier 'convertedDescriptor' * Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteDeviceProxy.cpp: Canonical link: https://commits.webkit.org/269702@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9342e7: [Gardening] http/tests/security/block-top-level-na...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9342e7b566e578486a8446d3496d7d48d53567e4 https://github.com/WebKit/WebKit/commit/9342e7b566e578486a8446d3496d7d48d53567e4 Author: Fujii Hironori Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening] http/tests/security/block-top-level-navigation-via-redirect-by-third-party-iframes.html is randomly failing https://bugs.webkit.org/show_bug.cgi?id=263233 Unreviewed test gardening. * LayoutTests/TestExpectations: Marked it flaky. Canonical link: https://commits.webkit.org/269703@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 237bd7: [Gardening] http/tests/multipart/win-boundary-cras...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 237bd74e5ced0ccc32412bae22d0a29a84700680 https://github.com/WebKit/WebKit/commit/237bd74e5ced0ccc32412bae22d0a29a84700680 Author: Fujii Hironori Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening] http/tests/multipart/win-boundary-crash.html flakey https://bugs.webkit.org/show_bug.cgi?id=63268 Unreviewed test gardening. No ports is flaky these days. * LayoutTests/TestExpectations: Unskipped http/tests/multipart/win-boundary-crash.html. Canonical link: https://commits.webkit.org/269704@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4cb2dd: [Gardening] http/tests/multipart/policy-ignore-cra...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4cb2ddc6fe2274899f2c66ae926c1c26264f2c3a https://github.com/WebKit/WebKit/commit/4cb2ddc6fe2274899f2c66ae926c1c26264f2c3a Author: Fujii Hironori Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M LayoutTests/TestExpectations R LayoutTests/platform/ios/http/tests/multipart/policy-ignore-crash-expected.txt Log Message: --- [Gardening] http/tests/multipart/policy-ignore-crash.py passes https://bugs.webkit.org/show_bug.cgi?id=263581 Unreviewed test gardening. No ports are failing these days. * LayoutTests/TestExpectations: Unskipped it. * LayoutTests/platform/ios/http/tests/multipart/policy-ignore-crash-expected.txt: Removed. Canonical link: https://commits.webkit.org/269707@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bc27e1: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bc27e1c45f91699dfcf05f7e3f9ee30fb6f07904 https://github.com/WebKit/WebKit/commit/bc27e1c45f91699dfcf05f7e3f9ee30fb6f07904 Author: Fujii Hironori Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/269671@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b02d12: [Gardening] Add DumpJSConsoleLogInStdErr for Bug 1...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b02d1232307aba744cea12e5ef508faaa0c53fa9 https://github.com/WebKit/WebKit/commit/b02d1232307aba744cea12e5ef508faaa0c53fa9 Author: Fujii Hironori Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/TestExpectations M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wpe/TestExpectations Log Message: --- [Gardening] Add DumpJSConsoleLogInStdErr for Bug 185254 https://bugs.webkit.org/show_bug.cgi?id=185254 Unreviewed test gardening. These tests are failing due to the following extra console message on non-Cocoa ports. > CONSOLE MESSAGE: line 22: Load cannot follow more than 20 redirections Added DumpJSConsoleLogInStdErr for the tests. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/269709@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a2c0f8: [Gardening] animations/animation-delay-changed.htm...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a2c0f8feaecff9c399b16b9cc22175719be996e0 https://github.com/WebKit/WebKit/commit/a2c0f8feaecff9c399b16b9cc22175719be996e0 Author: Fujii Hironori Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M LayoutTests/TestExpectations Log Message: --- [Gardening] animations/animation-delay-changed.html is randomly failing https://bugs.webkit.org/show_bug.cgi?id=111612 Unreviewed test gardening. * LayoutTests/TestExpectations: Canonical link: https://commits.webkit.org/269710@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 91261f: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 91261f325bfaf3442dfcf3e2cbca5b8d6b27b2ff https://github.com/WebKit/WebKit/commit/91261f325bfaf3442dfcf3e2cbca5b8d6b27b2ff Author: Fujii Hironori Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/editing/selection/drag-in-iframe-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/editing/selection/drag-in-iframe-expected.txt: Canonical link: https://commits.webkit.org/269292@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dc38df: WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc38df83a8f6b257aaba0bf89ae1c1ebd4936eb7 https://github.com/WebKit/WebKit/commit/dc38df83a8f6b257aaba0bf89ae1c1ebd4936eb7 Author: Fujii Hironori Date: 2023-08-17 (Thu, 17 Aug 2023) Changed paths: M Source/WebKit/Platform/IPC/win/ConnectionWin.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp Log Message: --- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: warning: lambda capture 'thisPointerForLog' is not used https://bugs.webkit.org/show_bug.cgi?id=260329 Reviewed by Ross Kirsling. clang-cl reported the following warnings for Windows port. > WebKit\Platform\IPC\win\ConnectionWin.cpp(332,10): warning: variable 'result' > set but not used [-Wunused-but-set-variable] > WebKit\WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp(170,325): warning: > lambda capture 'thisPointerForLog' is not used [-Wunused-lambda-capture] * Source/WebKit/Platform/IPC/win/ConnectionWin.cpp: (IPC::Connection::EventListener::open): * Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Canonical link: https://commits.webkit.org/266993@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c660b: jsc.cpp(3614, 1): warning: function declared 'noret...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c660bb7b4f5b27281db488bcb8890cee00a1f0b https://github.com/WebKit/WebKit/commit/6c660bb7b4f5b27281db488bcb8890cee00a1f0b Author: Fujii Hironori Date: 2023-08-17 (Thu, 17 Aug 2023) Changed paths: M Source/WTF/wtf/Assertions.cpp M Source/WTF/wtf/Compiler.h Log Message: --- jsc.cpp(3614,1): warning: function declared 'noreturn' should not return https://bugs.webkit.org/show_bug.cgi?id=260330 Reviewed by Ross Kirsling. clang-cl reported the following warnings for Windows port. > WTF\wtf\Assertions.cpp(335,1): warning: function declared 'noreturn' should > not return [-Winvalid-noreturn] > JavaScriptCore\jsc.cpp(2602,1): warning: non-void function does not return a > value [-Wreturn-type] > JavaScriptCore\jsc.cpp(3614,1): warning: function declared 'noreturn' should > not return [-Winvalid-noreturn] Clang-cl should take a code path of GCC for UNUSED_FUNCTION, NO_RETURN and NO_RETURN_WITH_VALUE macros to suppress compiler warnings. * Source/WTF/wtf/Assertions.cpp: * Source/WTF/wtf/Compiler.h: Canonical link: https://commits.webkit.org/266995@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0cd6da: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0cd6da4dde62415063bb9834945a4d011c382292 https://github.com/WebKit/WebKit/commit/0cd6da4dde62415063bb9834945a4d011c382292 Author: Fujii Hironori Date: 2023-08-27 (Sun, 27 Aug 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/editing/deleting/delete-to-select-table-expected.txt M LayoutTests/platform/wincairo/editing/inserting/paragraph-separator-in-table-2-expected.txt M LayoutTests/platform/wincairo/editing/style/table-selection-expected.txt Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: * LayoutTests/platform/wincairo/editing/deleting/delete-to-select-table-expected.txt: * LayoutTests/platform/wincairo/editing/inserting/paragraph-separator-in-table-2-expected.txt: * LayoutTests/platform/wincairo/editing/style/table-selection-expected.txt: Canonical link: https://commits.webkit.org/267337@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c482bc: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c482bc633a8fdbe1a455c65143b675ddea21c70d https://github.com/WebKit/WebKit/commit/c482bc633a8fdbe1a455c65143b675ddea21c70d Author: Fujii Hironori Date: 2023-08-13 (Sun, 13 Aug 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/266859@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9487cc: [Win] SignalsWin.cpp: error: case value evaluates ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9487cc29d6e221e23a0e632fefb8e157e103e8ce https://github.com/WebKit/WebKit/commit/9487cc29d6e221e23a0e632fefb8e157e103e8ce Author: Fujii Hironori Date: 2023-08-15 (Tue, 15 Aug 2023) Changed paths: M Source/WTF/wtf/win/SignalsWin.cpp Log Message: --- [Win] SignalsWin.cpp: error: case value evaluates to 3221225613, which cannot be narrowed to type 'int' https://bugs.webkit.org/show_bug.cgi?id=260222 Reviewed by Ross Kirsling. After 266716@main, clang-cl reports the following error for Windows port. > WTF\wtf\win\SignalsWin.cpp(82,10): error: case value evaluates to 3221225613, > which cannot be narrowed to type 'int' [-Wc++11-narrowing] > case EXCEPTION_FLT_DENORMAL_OPERAND: We shouldn't convert a DWORD signal type to int. * Source/WTF/wtf/win/SignalsWin.cpp: (WTF::fromSystemException): Take the argument as a DWORD. Canonical link: https://commits.webkit.org/266936@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5bd7a2: Move createStructure inline functions to *Inlines.h
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5bd7a22a5bc306e773ba8908e851fdbfa94142f4 https://github.com/WebKit/WebKit/commit/5bd7a22a5bc306e773ba8908e851fdbfa94142f4 Author: Fujii Hironori Date: 2023-08-15 (Tue, 15 Aug 2023) Changed paths: M Source/JavaScriptCore/API/JSAPIGlobalObject.cpp M Source/JavaScriptCore/API/JSAPIValueWrapper.cpp M Source/JavaScriptCore/API/JSAPIValueWrapper.h M Source/JavaScriptCore/API/tests/JSObjectGetProxyTargetTest.cpp M Source/JavaScriptCore/CMakeLists.txt M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj M Source/JavaScriptCore/bytecode/CallVariant.h A Source/JavaScriptCore/bytecode/CallVariantInlines.h M Source/JavaScriptCore/bytecode/EvalCodeBlock.h A Source/JavaScriptCore/bytecode/EvalCodeBlockInlines.h M Source/JavaScriptCore/bytecode/FunctionCodeBlock.cpp M Source/JavaScriptCore/bytecode/FunctionCodeBlock.h A Source/JavaScriptCore/bytecode/FunctionCodeBlockInlines.h M Source/JavaScriptCore/bytecode/ModuleProgramCodeBlock.cpp M Source/JavaScriptCore/bytecode/ModuleProgramCodeBlock.h A Source/JavaScriptCore/bytecode/ModuleProgramCodeBlockInlines.h M Source/JavaScriptCore/bytecode/ProgramCodeBlock.h A Source/JavaScriptCore/bytecode/ProgramCodeBlockInlines.h M Source/JavaScriptCore/bytecode/UnlinkedEvalCodeBlock.cpp M Source/JavaScriptCore/bytecode/UnlinkedEvalCodeBlock.h A Source/JavaScriptCore/bytecode/UnlinkedEvalCodeBlockInlines.h M Source/JavaScriptCore/bytecode/UnlinkedFunctionCodeBlock.h A Source/JavaScriptCore/bytecode/UnlinkedFunctionCodeBlockInlines.h M Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h A Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutableInlines.h M Source/JavaScriptCore/bytecode/UnlinkedModuleProgramCodeBlock.h A Source/JavaScriptCore/bytecode/UnlinkedModuleProgramCodeBlockInlines.h M Source/JavaScriptCore/bytecode/UnlinkedProgramCodeBlock.h A Source/JavaScriptCore/bytecode/UnlinkedProgramCodeBlockInlines.h M Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp M Source/JavaScriptCore/generator/DSL.rb M Source/JavaScriptCore/interpreter/CallFrameInlines.h M Source/JavaScriptCore/jit/AssemblyHelpers.h M Source/JavaScriptCore/runtime/AggregateErrorConstructor.h A Source/JavaScriptCore/runtime/AggregateErrorConstructorInlines.h M Source/JavaScriptCore/runtime/AggregateErrorPrototype.h A Source/JavaScriptCore/runtime/AggregateErrorPrototypeInlines.h M Source/JavaScriptCore/runtime/ArrayConstructor.h A Source/JavaScriptCore/runtime/ArrayConstructorInlines.h M Source/JavaScriptCore/runtime/ArrayIteratorPrototype.h A Source/JavaScriptCore/runtime/ArrayIteratorPrototypeInlines.h M Source/JavaScriptCore/runtime/ArrayPrototype.h M Source/JavaScriptCore/runtime/ArrayPrototypeInlines.h M Source/JavaScriptCore/runtime/AsyncFromSyncIteratorPrototype.h A Source/JavaScriptCore/runtime/AsyncFromSyncIteratorPrototypeInlines.h M Source/JavaScriptCore/runtime/AsyncFunctionConstructor.h A Source/JavaScriptCore/runtime/AsyncFunctionConstructorInlines.h M Source/JavaScriptCore/runtime/AsyncFunctionPrototype.h A Source/JavaScriptCore/runtime/AsyncFunctionPrototypeInlines.h M Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototype.h A Source/JavaScriptCore/runtime/AsyncGeneratorFunctionPrototypeInlines.h M Source/JavaScriptCore/runtime/AsyncGeneratorPrototype.h A Source/JavaScriptCore/runtime/AsyncGeneratorPrototypeInlines.h M Source/JavaScriptCore/runtime/AsyncIteratorPrototype.h A Source/JavaScriptCore/runtime/AsyncIteratorPrototypeInlines.h M Source/JavaScriptCore/runtime/BigIntConstructor.h A Source/JavaScriptCore/runtime/BigIntConstructorInlines.h M Source/JavaScriptCore/runtime/BigIntObject.h A Source/JavaScriptCore/runtime/BigIntObjectInlines.h M Source/JavaScriptCore/runtime/BigIntPrototype.h A Source/JavaScriptCore/runtime/BigIntPrototypeInlines.h M Source/JavaScriptCore/runtime/BooleanConstructor.h A Source/JavaScriptCore/runtime/BooleanConstructorInlines.h M Source/JavaScriptCore/runtime/BooleanObject.h A Source/JavaScriptCore/runtime/BooleanObjectInlines.h M Source/JavaScriptCore/runtime/BooleanPrototype.h A Source/JavaScriptCore/runtime/BooleanPrototypeInlines.h M Source/JavaScriptCore/runtime/ConsoleObject.h A Source/JavaScriptCore/runtime/ConsoleObjectInlines.h M Source/JavaScriptCore/runtime/CustomGetterSetter.h A Source/JavaScriptCore/runtime/CustomGetterSetterInlines.h M Source/JavaScriptCore/runtime/DOMAttributeGetterSetter.h A Source/JavaScriptCore/runtime/DOMAttributeGetterSetterInlines.h M Source/JavaScriptCore/runtime/DateConstructor.h A Source/JavaScriptCore/runtime/DateConstructorInlines.h M Source/JavaScriptCore/runtime/DateInstance.h A Source/JavaScriptCore
[webkit-changes] [WebKit/WebKit] 0deb2f: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0deb2fdef8763a4e46774547b72cb9e1d76b8278 https://github.com/WebKit/WebKit/commit/0deb2fdef8763a4e46774547b72cb9e1d76b8278 Author: Fujii Hironori Date: 2023-11-08 (Wed, 08 Nov 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/270405@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a7d292: [Win] ~CompletionHandler's assertion "Completion h...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a7d29235f1b0da54edf64f2cd4a0f4e23f151100 https://github.com/WebKit/WebKit/commit/a7d29235f1b0da54edf64f2cd4a0f4e23f151100 Author: Fujii Hironori Date: 2023-11-10 (Fri, 10 Nov 2023) Changed paths: M Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp Log Message: --- [Win] ~CompletionHandler's assertion "Completion handler should always be called" fails under RemoteWCLayerTreeHost::update https://bugs.webkit.org/show_bug.cgi?id=264438 Reviewed by Don Olmstead. CompletionHandler should be always called. * Source/WebKit/GPUProcess/graphics/wc/RemoteWCLayerTreeHost.cpp: Canonical link: https://commits.webkit.org/270571@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ae0534: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ae0534174d2a600aef4a95bdf5609f41b109aa24 https://github.com/WebKit/WebKit/commit/ae0534174d2a600aef4a95bdf5609f41b109aa24 Author: Fujii Hironori Date: 2023-11-09 (Thu, 09 Nov 2023) Changed paths: M LayoutTests/platform/wincairo/TestExpectations Log Message: --- [WinCairo] Unreviewed test gardening * LayoutTests/platform/wincairo/TestExpectations: Canonical link: https://commits.webkit.org/270473@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9fd8cc: TextureMapperGL: edge distance anti-aliasing shoul...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9fd8ccc1aa9a931022ec6a5a28297733473b6e7a https://github.com/WebKit/WebKit/commit/9fd8ccc1aa9a931022ec6a5a28297733473b6e7a Author: Fujii Hironori Date: 2022-09-26 (Mon, 26 Sep 2022) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp Log Message: --- TextureMapperGL: edge distance anti-aliasing should be calculated in homogeneous coordinates https://bugs.webkit.org/show_bug.cgi?id=245265 Reviewed by Don Olmstead. The edge distance anti-aliasing inflates rect edges by 1px in the viewport coordinates and calculates an alpha value (v_antialias) for each vertex to blur the edges. However, the viewport coordinates are homogeneous coordinates. The projected vertex can be at infinity. v_antialias also should be calculated in the homogeneous coordinates. The denominator of v_antialias is same with one of the projected vertex. On the other hand, v_texCoord varying variable should be calculated based on the 3D space distance. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp: Canonical link: https://commits.webkit.org/254885@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6009cd: TextureMapperGL: REGRESSION(215058@main): edge dis...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6009cd99a53dd0843138de2206586f23621e5045 https://github.com/WebKit/WebKit/commit/6009cd99a53dd0843138de2206586f23621e5045 Author: Fujii Hironori Date: 2022-09-26 (Mon, 26 Sep 2022) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp Log Message: --- TextureMapperGL: REGRESSION(215058@main): edge distance anti-aliasing renders thinner edges than expected https://bugs.webkit.org/show_bug.cgi?id=245514 Reviewed by Don Olmstead. bug#124653 added fragmentTransformTexCoord to extend edges of a texture to the inflation area. However, it hadn't worked after bug#132869 renamed ENABLE_Texture macro to ENABLE_TextureRGB becuase the transformTexCoord definition still used the old macro. * Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp: Removed the condition with old ENABLE_Texture macro for transformTexCoord. Canonical link: https://commits.webkit.org/254876@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 922f8f: TextureMapper: Calculate zFar and zNear for the pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 922f8f09f0ca28f6ace19c16c2b7a9a7989d5d2f https://github.com/WebKit/WebKit/commit/922f8f09f0ca28f6ace19c16c2b7a9a7989d5d2f Author: Fujii Hironori Date: 2022-09-26 (Mon, 26 Sep 2022) Changed paths: M Source/WebCore/platform/graphics/texmap/TextureMapper.h M Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperGL.h M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp M Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h Log Message: --- TextureMapper: Calculate zFar and zNear for the projection matrix https://bugs.webkit.org/show_bug.cgi?id=244564 Reviewed by Darin Adler. TextureMapper was using fixed zFar and zNear values, (-9, 999). These were too big for 16 bits depth buffer on Linux. <https://bugs.webkit.org/show_bug.cgi?id=244526#c2> Changed TextureMapperLayer::computeTransformsRecursive to calculate zFar and zNear. * LayoutTests/platform/glib/TestExpectations: Unmarked imported/w3c/web-platform-tests/css/css-transforms/perspective-split-by-zero-w.html * Source/WebCore/platform/graphics/texmap/TextureMapper.h: (WebCore::TextureMapper::setDepthRange): * Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: (WebCore::createProjectionMatrix): (WebCore::TextureMapperGL::bindDefaultSurface): (WebCore::TextureMapperGL::bindSurface): (WebCore::TextureMapperGL::setDepthRange): * Source/WebCore/platform/graphics/texmap/TextureMapperGL.h: * Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp: (WebCore::TextureMapperComputeTransformData::updateDepthRange): (WebCore::TextureMapperLayer::computeTransformsRecursive): (WebCore::TextureMapperLayer::paint): * Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h: Canonical link: https://commits.webkit.org/254897@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c746f3: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c746f37b4f60239496fd58d651428f78f6cf9c2c https://github.com/WebKit/WebKit/commit/c746f37b4f60239496fd58d651428f78f6cf9c2c Author: Fujii Hironori Date: 2022-10-16 (Sun, 16 Oct 2022) Changed paths: M LayoutTests/platform/wincairo/editing/caret/insert-paragraph-does-not-paint-stale-carets-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-3608445-fix-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-3608462-fix-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-012-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-017-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-018-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-021-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-022-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-contiguous-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-003-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-line-end-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-line-end-ws-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-selection-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-to-select-table-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-trailing-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-trailing-ws-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-004-expected.txt M LayoutTests/platform/wincairo/editing/deleting/forward-delete-expected.txt M LayoutTests/platform/wincairo/editing/deleting/non-smart-delete-expected.txt M LayoutTests/platform/wincairo/editing/deleting/table-cells-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/5482023-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/find-after-replace-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/paste-1-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/print-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/selectAll-expected.txt M LayoutTests/platform/wincairo/editing/inserting/12882-expected.txt M LayoutTests/platform/wincairo/editing/inserting/editable-html-element-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-br-007-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-br-008-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-007-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-019-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-020-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-022-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-023-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-024-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-027-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-space-in-empty-doc-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-text-with-newlines-expected.txt M LayoutTests/platform/wincairo/editing/inserting/paragraph-separator-in-table-2-expected.txt M LayoutTests/platform/wincairo/editing/inserting/typing-003-expected.txt M LayoutTests/platform/wincairo/editing/inserting/typing-around-image-001-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-2-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-3-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4944770-2-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5028447-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5134759-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5387578-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5478250-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/cut-text-001-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/merge-end-borders-expected.txt
[webkit-changes] [WebKit/WebKit] d03dce: [WPE] checkbox and radio button aren't painted bec...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d03dce63e768d08101b3902ab6f5259d5857035d https://github.com/WebKit/WebKit/commit/d03dce63e768d08101b3902ab6f5259d5857035d Author: Fujii Hironori Date: 2022-10-18 (Tue, 18 Oct 2022) Changed paths: M Source/WebCore/platform/adwaita/ThemeAdwaita.cpp M Source/WebCore/platform/adwaita/ThemeAdwaita.h Log Message: --- [WPE] checkbox and radio button aren't painted because ThemeAdwaita::m_accentColor is the invalid color https://bugs.webkit.org/show_bug.cgi?id=246667 Reviewed by Carlos Garcia Campos. ThemeAdwaita is painting checkbox and radio button with the accent color. GTK port supports accent color, but WPE doesn't. ThemeAdwaita::m_accentColor was initialized as the invalid color that was transparent. * Source/WebCore/platform/adwaita/ThemeAdwaita.cpp: (WebCore::ThemeAdwaita::accentColor): * Source/WebCore/platform/adwaita/ThemeAdwaita.h: Canonical link: https://commits.webkit.org/255668@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 24ad5f: Merge 255668@main - [WPE] checkbox and radio butto...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 24ad5fc9a0f2308a4b719cc438ff13d0e132796c https://github.com/WebKit/WebKit/commit/24ad5fc9a0f2308a4b719cc438ff13d0e132796c Author: Fujii Hironori Date: 2022-10-18 (Tue, 18 Oct 2022) Changed paths: M Source/WebCore/platform/adwaita/ThemeAdwaita.cpp M Source/WebCore/platform/adwaita/ThemeAdwaita.h Log Message: --- Merge 255668@main - [WPE] checkbox and radio button aren't painted because ThemeAdwaita::m_accentColor is the invalid color https://bugs.webkit.org/show_bug.cgi?id=246667 Reviewed by Carlos Garcia Campos. ThemeAdwaita is painting checkbox and radio button with the accent color. GTK port supports accent color, but WPE doesn't. ThemeAdwaita::m_accentColor was initialized as the invalid color that was transparent. * Source/WebCore/platform/adwaita/ThemeAdwaita.cpp: (WebCore::ThemeAdwaita::accentColor): * Source/WebCore/platform/adwaita/ThemeAdwaita.h: Canonical link: https://commits.webkit.org/255668@main (cherry picked from commit d03dce63e768d08101b3902ab6f5259d5857035d) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c5338: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c53388b776a8aad44d0884e11752d236ded18cb https://github.com/WebKit/WebKit/commit/6c53388b776a8aad44d0884e11752d236ded18cb Author: Fujii Hironori Date: 2022-10-19 (Wed, 19 Oct 2022) Changed paths: M LayoutTests/platform/wincairo/TestExpectations M LayoutTests/platform/wincairo/css1/box_properties/acid_test-expected.txt M LayoutTests/platform/wincairo/css2.1/20110323/replaced-elements-001-expected.txt M LayoutTests/platform/wincairo/css2.1/t09-c5526c-display-00-e-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-blur-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-blur-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-brightness-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-brightness-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-combined-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-combined-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-contrast-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-contrast-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-drop-shadow-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-drop-shadow-hw-expected.png R LayoutTests/platform/wincairo/css3/filters/effect-drop-shadow-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-grayscale-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-grayscale-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-hue-rotate-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-hue-rotate-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-invert-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-invert-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-opacity-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-opacity-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-saturate-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-saturate-hw-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-sepia-expected.txt R LayoutTests/platform/wincairo/css3/filters/effect-sepia-hw-expected.txt M LayoutTests/platform/wincairo/editing/caret/insert-paragraph-does-not-paint-stale-carets-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-3608445-fix-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-3608462-fix-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-012-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-017-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-018-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-021-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-022-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-contiguous-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-003-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-line-end-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-line-end-ws-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-selection-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-to-select-table-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-trailing-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-trailing-ws-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-004-expected.txt M LayoutTests/platform/wincairo/editing/deleting/forward-delete-expected.txt M LayoutTests/platform/wincairo/editing/deleting/non-smart-delete-expected.txt M LayoutTests/platform/wincairo/editing/deleting/table-cells-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/5482023-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/find-after-replace-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/paste-1-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/print-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/selectAll-expected.txt M
[webkit-changes] [WebKit/WebKit] fbcbce: ThemeAdwaita: checkbox, radio and inner spin butto...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fbcbce2f5153def0a1b56ac28009828b4802320e https://github.com/WebKit/WebKit/commit/fbcbce2f5153def0a1b56ac28009828b4802320e Author: Fujii Hironori Date: 2022-10-21 (Fri, 21 Oct 2022) Changed paths: M LayoutTests/platform/gtk/transforms/2d/zoom-menulist-expected.png M LayoutTests/platform/gtk/transforms/2d/zoom-menulist-expected.txt M Source/WebCore/platform/adwaita/ThemeAdwaita.cpp M Source/WebCore/platform/adwaita/ThemeAdwaita.h M Source/WebCore/rendering/RenderThemeAdwaita.cpp Log Message: --- ThemeAdwaita: checkbox, radio and inner spin button don't scale along by page zoom https://bugs.webkit.org/show_bug.cgi?id=246679 Reviewed by Carlos Garcia Campos. ThemeAdwaita should scale controls based on a given zoom factor. Scale buttons for input elements with type=number, type=checkbox, type=radio and datalist, and select elements. ThemeAdwaita::paintArrow painted a 16x16 arrow at (0, 0) position. Change it to take a rect and paint an arrow at the center of the rect, fitting to the smaller edge. * Source/WebCore/platform/adwaita/ThemeAdwaita.cpp: (WebCore::ThemeAdwaita::paintArrow): (WebCore::ThemeAdwaita::controlSize const): (WebCore::ThemeAdwaita::paintSpinButton): * Source/WebCore/platform/adwaita/ThemeAdwaita.h: * Source/WebCore/rendering/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::paintTextField): (WebCore::RenderThemeAdwaita::popupInternalPaddingBox const): (WebCore::RenderThemeAdwaita::paintMenuList): * LayoutTests/platform/gtk/transforms/2d/zoom-menulist-expected.png: * LayoutTests/platform/gtk/transforms/2d/zoom-menulist-expected.txt: Canonical link: https://commits.webkit.org/255820@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 38c7cc: [WinCairo] Unreviewed test gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 38c7cca6f8fa13b21af2a3b57590dfc042e94012 https://github.com/WebKit/WebKit/commit/38c7cca6f8fa13b21af2a3b57590dfc042e94012 Author: Fujii Hironori Date: 2022-10-24 (Mon, 24 Oct 2022) Changed paths: M LayoutTests/platform/wincairo/editing/caret/insert-paragraph-does-not-paint-stale-carets-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-3608445-fix-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-3608462-fix-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-012-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-017-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-018-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-021-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-block-merge-contents-022-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-contiguous-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-image-003-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-line-end-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-line-end-ws-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-selection-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-to-select-table-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-trailing-ws-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-trailing-ws-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-001-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-002-expected.txt M LayoutTests/platform/wincairo/editing/deleting/delete-ws-fixup-004-expected.txt M LayoutTests/platform/wincairo/editing/deleting/forward-delete-expected.txt M LayoutTests/platform/wincairo/editing/deleting/non-smart-delete-expected.txt M LayoutTests/platform/wincairo/editing/deleting/table-cells-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/5482023-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/find-after-replace-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/paste-1-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/print-expected.txt M LayoutTests/platform/wincairo/editing/execCommand/selectAll-expected.txt M LayoutTests/platform/wincairo/editing/inserting/12882-expected.txt M LayoutTests/platform/wincairo/editing/inserting/editable-html-element-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-br-007-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-br-008-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-007-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-019-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-020-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-022-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-023-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-024-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-div-027-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-space-in-empty-doc-expected.txt M LayoutTests/platform/wincairo/editing/inserting/insert-text-with-newlines-expected.txt M LayoutTests/platform/wincairo/editing/inserting/paragraph-separator-in-table-2-expected.txt M LayoutTests/platform/wincairo/editing/inserting/typing-003-expected.txt M LayoutTests/platform/wincairo/editing/inserting/typing-around-image-001-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-2-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-3-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/4076267-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5028447-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5134759-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5387578-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/5478250-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/cut-text-001-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/merge-end-borders-expected.txt M LayoutTests/platform/wincairo/editing/pasteboard/paste-2-expected.txt
[webkit-changes] [WebKit/WebKit] 214a96: [MSVC] Suppress warning C4723: The second operand ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 214a966eafadc21448fa6f1d948ea8e6b99af2ee https://github.com/WebKit/WebKit/commit/214a966eafadc21448fa6f1d948ea8e6b99af2ee Author: Fujii Hironori Date: 2022-10-25 (Tue, 25 Oct 2022) Changed paths: M Source/cmake/OptionsMSVC.cmake Log Message: --- [MSVC] Suppress warning C4723: The second operand in a divide operation evaluated to zero at compile time https://bugs.webkit.org/show_bug.cgi?id=247033 Reviewed by Don Olmstead. * Source/cmake/OptionsMSVC.cmake: Align MSVC's compiler warnings to Clang as much as possible. Canonical link: https://commits.webkit.org/255997@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fbeb80: [MSVC] Suppress warning C4805: 'operation' : unsaf...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fbeb80ee96c998f31e1299df99576d58a1b9d842 https://github.com/WebKit/WebKit/commit/fbeb80ee96c998f31e1299df99576d58a1b9d842 Author: Fujii Hironori Date: 2022-10-25 (Tue, 25 Oct 2022) Changed paths: M Source/cmake/OptionsMSVC.cmake Log Message: --- [MSVC] Suppress warning C4805: 'operation' : unsafe mix of type 'type' and type 'type' in operation https://bugs.webkit.org/show_bug.cgi?id=247024 Reviewed by Don Olmstead. WinCairo EWS was failing to compile due to the following warning. > WebCore\platform\graphics\angle\ANGLEUtilities.cpp(155): error C2220: the > following warning is treated as an error > WebCore\platform\graphics\angle\ANGLEUtilities.cpp(155): warning C4805: '==': > unsafe mix of type 'GLboolean' and type 'bool' in operation Other ports don't complain that. Suppress the warning C4805. * Source/cmake/OptionsMSVC.cmake: Canonical link: https://commits.webkit.org/255981@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b0d809: [WinCairo] Unreviewed build fix after 255889@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b0d809850b743ede12a68aadd870de6603484daa https://github.com/WebKit/WebKit/commit/b0d809850b743ede12a68aadd870de6603484daa Author: Fujii Hironori Date: 2022-10-23 (Sun, 23 Oct 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp Log Message: --- [WinCairo] Unreviewed build fix after 255889@main https://bugs.webkit.org/show_bug.cgi?id=246897 * Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.cpp: (WebKit::DrawingAreaWC::sendUpdateNonAC): Renamed didUpdate to displayDidRefresh. Canonical link: https://commits.webkit.org/255898@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 284e48: [WinCairo] Use RenderThemeAdwaita instead of Rende...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 284e48c374b08051f649898eecc3d83c1a9d578e https://github.com/WebKit/WebKit/commit/284e48c374b08051f649898eecc3d83c1a9d578e Author: Fujii Hironori Date: 2022-10-18 (Tue, 18 Oct 2022) Changed paths: M Source/WTF/wtf/PlatformUse.h M Source/WebCore/CMakeLists.txt M Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp M Source/WebCore/PlatformPlayStation.cmake M Source/WebCore/PlatformWin.cmake M Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp M Source/WebCore/rendering/RenderThemeAdwaita.cpp M Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp M Source/WebKitLegacy/win/WebKitDLL.cpp M Source/cmake/OptionsWin.cmake Log Message: --- [WinCairo] Use RenderThemeAdwaita instead of RenderThemeWin https://bugs.webkit.org/show_bug.cgi?id=246604 Reviewed by Darin Adler. RenderThemeWin doesn't work with UseGPUProcessForDOMRenderingEnabled because it uses Windows API to paint themes to HDC. Use RenderThemeAdwaita that is painting themes to GraphicsContext. Turned USE_NEW_THEME macro on because RenderThemeAdwaita depends on it. Turned ENABLE_MODERN_MEDIA_CONTROLS macro on. mediaControls.css is a stylesheet for the legacy media controls. ENABLE_MODERN_MEDIA_CONTROLS causes a compilation error for the generated C++ source file to embed mediaControls.css due to a zero size array. So, process the file only for AppleWin and PlayStation ports that are using the legacy media controls. * Source/WTF/wtf/PlatformUse.h: * Source/WebCore/CMakeLists.txt: * Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp: (WebCore::MediaControlsHost::layoutTraitsClassName const): * Source/WebCore/PlatformPlayStation.cmake: * Source/WebCore/PlatformWin.cmake: * Source/WebCore/platform/adwaita/ScrollbarThemeAdwaita.cpp: (WebCore::ScrollbarThemeAdwaita::handleMousePressEvent): * Source/WebCore/rendering/RenderThemeAdwaita.cpp: (WebCore::RenderThemeAdwaita::mediaControlsBase64StringForIconNameAndType): * Source/WebKit/UIProcess/win/WebPopupMenuProxyWin.cpp: * Source/WebKitLegacy/win/WebKitDLL.cpp: (DllMain): * Source/cmake/OptionsWin.cmake: Canonical link: https://commits.webkit.org/255715@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c2c849: Add platform-specific expectations of http/tests/s...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c2c84973bcac41b074f403d01bfe1991d2112d0e https://github.com/WebKit/WebKit/commit/c2c84973bcac41b074f403d01bfe1991d2112d0e Author: Fujii Hironori Date: 2022-09-20 (Tue, 20 Sep 2022) Changed paths: M LayoutTests/http/tests/scroll-to-text-fragment/start-text-emoji.html M LayoutTests/http/tests/scroll-to-text-fragment/start-text-quote.html M LayoutTests/http/tests/scroll-to-text-fragment/start-text-sentence.html M LayoutTests/http/tests/scroll-to-text-fragment/start-text-word.html A LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html A LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-quote-expected.html A LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html A LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-word-expected.html R LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html R LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html R LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-word-expected.html A LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html A LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-quote-expected.html A LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html A LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-word-expected.html Log Message: --- Add platform-specific expectations of http/tests/scroll-to-text-fragment ref-tests for WinCairo, GTK and WPE ports https://bugs.webkit.org/show_bug.cgi?id=245055 Reviewed by Darin Adler. http/tests/scroll-to-text-fragment ref-tests were failing for GTK port because GTK port's expectations had the incorrect annotation highlight color. The actual annotation highlight color is calculated by transforming the color returned by RenderTheme::platformAnnotationHighlightColor. The actual color is yellow with 80% alpha. Fixed GTK port's expectations. Added glib ports' expectations by moving them for WPE port. Added WinCairo expectations by copying them. * LayoutTests/http/tests/scroll-to-text-fragment/start-text-emoji.html: * LayoutTests/http/tests/scroll-to-text-fragment/start-text-quote.html: * LayoutTests/http/tests/scroll-to-text-fragment/start-text-sentence.html: * LayoutTests/http/tests/scroll-to-text-fragment/start-text-word.html: * LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html. * LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-quote-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html. * LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html. * LayoutTests/platform/glib/http/tests/scroll-to-text-fragment/start-text-word-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-word-expected.html. * LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html: Renamed from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-emoji-expected.html. * LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-quote-expected.html: Copied from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html. * LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html: Renamed from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-sentence-expected.html. * LayoutTests/platform/wincairo/http/tests/scroll-to-text-fragment/start-text-word-expected.html: Renamed from LayoutTests/platform/gtk/http/tests/scroll-to-text-fragment/start-text-word-expected.html. Canonical link: https://commits.webkit.org/254664@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c00cdc: [WinCairo] PageUp and PageDown keys don't start th...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c00cdc0f009be6bdef4525791a07858abfed30eb https://github.com/WebKit/WebKit/commit/c00cdc0f009be6bdef4525791a07858abfed30eb Author: Fujii Hironori Date: 2022-10-05 (Wed, 05 Oct 2022) Changed paths: M Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp Log Message: --- [WinCairo] PageUp and PageDown keys don't start the smooth keyboard scrolling https://bugs.webkit.org/show_bug.cgi?id=245982 Reviewed by Ross Kirsling. 252663@main removed the code to start the smooth keyboard scrolling for PageUp and PageDown keys in EventHandler. Mac port is executing ScrollPageBackward and ScrollPageForward EditCommands for them. Do the same for WinCairo. For Home and End keys, Mac port is executing ScrollToBeginningOfDocument and ScrollToEndOfDocument EditCommands. This change does so for WinCairo too. However, the smooth keyboard scrolling still doesn't work for WinCairo because 252663@main added the smooth keyboard scrolling code only for ScrollPageBackward and ScrollPageForward EditCommands but for ScrollToBeginningOfDocument and ScrollToEndOfDocument EditCommands. A follow-up will fix the problem. * Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Execute EditCommands for Home, End, PageUp, PageDown keys. Canonical link: https://commits.webkit.org/255162@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9fa349: [curl] Add new WK C API to get the server certific...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9fa349553d3f473392a89ab3b37a3e63b8c993c8 https://github.com/WebKit/WebKit/commit/9fa349553d3f473392a89ab3b37a3e63b8c993c8 Author: Fujii Hironori Date: 2022-10-13 (Thu, 13 Oct 2022) Changed paths: M Source/WebKit/Shared/API/c/curl/WKCertificateInfoCurl.cpp M Source/WebKit/UIProcess/API/C/curl/WKProtectionSpaceCurl.cpp M Source/WebKit/UIProcess/API/C/curl/WKProtectionSpaceCurl.h M Tools/MiniBrowser/win/WebKitBrowserWindow.cpp Log Message: --- [curl] Add new WK C API to get the server certificate chain https://bugs.webkit.org/show_bug.cgi?id=246379 Reviewed by Alex Christensen. 255206@main deprecated WKProtectionSpaceCopyCertificateInfo and WKCertificateInfoRef. But, WinCairo and PlayStation ports are using it. Added alternative new WK C API. WKArrayRef WKProtectionSpaceCopyCertificateChain(WKProtectionSpaceRef protectionSpace) int WKProtectionSpaceGetCertificateVerificationError(WKProtectionSpaceRef protectionSpace) WKStringRef WKProtectionSpaceCopyCertificateVerificationErrorDescription(WKProtectionSpaceRef protectionSpace) * Source/WebKit/Shared/API/c/curl/WKCertificateInfoCurl.cpp: * Source/WebKit/UIProcess/API/C/curl/WKProtectionSpaceCurl.cpp: (WKProtectionSpaceCopyCertificateChain): (WKProtectionSpaceGetCertificateVerificationError): (WKProtectionSpaceCopyCertificateVerificationErrorDescription): * Source/WebKit/UIProcess/API/C/curl/WKProtectionSpaceCurl.h: * Tools/MiniBrowser/win/WebKitBrowserWindow.cpp: (createPEMString): (WebKitBrowserWindow::canTrustServerCertificate): Canonical link: https://commits.webkit.org/255505@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7934e5: Revert 253880@main: WinCairo buildbot is failing t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7934e56e257a14374ea907b0ef5a995f2e1976ee https://github.com/WebKit/WebKit/commit/7934e56e257a14374ea907b0ef5a995f2e1976ee Author: Fujii Hironori Date: 2022-10-06 (Thu, 06 Oct 2022) Changed paths: M Tools/CISupport/build-webkit-org/steps.py M Tools/CISupport/build-webkit-org/steps_unittest.py M Tools/CISupport/ews-build/steps.py M Tools/CISupport/ews-build/steps_unittest.py M Tools/Scripts/webkitpy/common/checkout/scm/git.py M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py Log Message: --- Revert 253880@main: WinCairo buildbot is failing to run test-webkitpy https://bugs.webkit.org/show_bug.cgi?id=244292 Reviewed by Jonathan Bedard. After 253880@main added '--all' switch for test-webkitpy on Buildbot, WinCairo buildbot was failing to run test-webkitpy due to 'lupa' installation failure. And, adding '--all' switch run unnecessary platform specific tests. * Tools/CISupport/build-webkit-org/steps.py: (RunWebKitPyTests): * Tools/CISupport/build-webkit-org/steps_unittest.py: * Tools/CISupport/ews-build/steps.py: (RunWebKitPyPython2Tests): (RunWebKitPyPython3Tests): * Tools/CISupport/ews-build/steps_unittest.py: (test_success): (test_unexpected_failure): * Tools/Scripts/webkitpy/common/checkout/scm/git.py: (Git.create_patch): * Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py: (GitTest.test_remote_branch_ref): (GitTest.test_create_patch): (GitTest.test_native_branch): (GitSVNTest): Canonical link: https://commits.webkit.org/255219@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
