Re: [webkit-dev] bugid in ChangeLog
On Sat, Mar 26, 2011 at 3:24 AM, Patrick Gansterer wrote: > Hi, > > Sometimes folks commit changes without bug numbers. If those changes breaks > things it's hard to find the correct context for the change. > Can we make the bug number a requirement for a commit when it has a > corresponding bug? > IMHO it would be great if the style bot and the reviewer complain about > missing bug numbers. > For the style bot, the style checker is here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checker.py One would need to add a checker for the change log. You can see a similar change done here where Adam Roben added one to catch errors in xml files after he had a problem with someone messing this up: http://trac.webkit.org/changeset/74149 I'm willing to review such a change (or give tips as needed). dave > > - Patrick > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] bugid in ChangeLog
Am 26.03.2011 um 19:30 schrieb Brent Fulgham: > I don't want to have a bug report for everything either, but I do agree that > my failure to include it in the changelog for the FontPlatformData change was > a stupid oversight. > > I'll make sure to avoid that mistake in the future! I didn't want to blame you directly! :-) Am 26.03.2011 um 21:32 schrieb Ryosuke Niwa: > On Sat, Mar 26, 2011 at 10:41 AM, Darin Adler wrote: > On Mar 26, 2011, at 3:24 AM, Patrick Gansterer wrote: > > > Sometimes folks commit changes without bug numbers. If those changes breaks > > things it's hard to find the correct context for the change. > > Can we make the bug number a requirement for a commit when it has a > > corresponding bug? > > IMHO it would be great if the style bot and the reviewer complain about > > missing bug numbers. > > I don’t think we should require a bug report for every commit. > > I think Patrick is saying that we should require to have the corresponding > bug number if there is one, not that every commit should have a bug number. Correct! I don't think we need a bug id for every commit (e.g. a simple build fix). But if we already upload a patch to bugzilla we should make the bug number a requirement in the ChangeLog. IMHO there's no extra cost to do this. - Patrick ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] bugid in ChangeLog
On Sat, Mar 26, 2011 at 10:41 AM, Darin Adler wrote: > On Mar 26, 2011, at 3:24 AM, Patrick Gansterer wrote: > > > Sometimes folks commit changes without bug numbers. If those changes > breaks things it's hard to find the correct context for the change. > > Can we make the bug number a requirement for a commit when it has a > corresponding bug? > > IMHO it would be great if the style bot and the reviewer complain about > missing bug numbers. > > I don’t think we should require a bug report for every commit. > I think Patrick is saying that we should require to have the corresponding bug number if there is one, not that every commit should have a bug number. One thing that bothers me most though is that when I somehow dropped the bug number in the initial commit and add a bug number back in a separate commit, the bug number doesn't show up on the original trac record and becomes sort of useless when trying to follow code changes on trac. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] bugid in ChangeLog
> If you use webkit-patch everything just magically works (yay!!) > > --Oliver > I agree! And if people would use it on uploading patches to a bug report, we wouldn't need a style-bot. Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] bugid in ChangeLog
If you use webkit-patch everything just magically works (yay!!) --Oliver On Mar 26, 2011, at 11:30 AM, Brent Fulgham wrote: > > On Mar 26, 2011, at 10:41 AM, Darin Adler wrote: > >> On Mar 26, 2011, at 3:24 AM, Patrick Gansterer wrote: >> >>> Sometimes folks commit changes without bug numbers. If those changes breaks >>> things it's hard to find the correct context for the change. >>> Can we make the bug number a requirement for a commit when it has a >>> corresponding bug? >>> IMHO it would be great if the style bot and the reviewer complain about >>> missing bug numbers. >> >> I don’t think we should require a bug report for every commit. > > I don't want to have a bug report for everything either, but I do agree that > my failure to include it in the changelog for the FontPlatformData change was > a stupid oversight. > > I'll make sure to avoid that mistake in the future! > > -Brent > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] bugid in ChangeLog
On Mar 26, 2011, at 10:41 AM, Darin Adler wrote: > On Mar 26, 2011, at 3:24 AM, Patrick Gansterer wrote: > >> Sometimes folks commit changes without bug numbers. If those changes breaks >> things it's hard to find the correct context for the change. >> Can we make the bug number a requirement for a commit when it has a >> corresponding bug? >> IMHO it would be great if the style bot and the reviewer complain about >> missing bug numbers. > > I don’t think we should require a bug report for every commit. I don't want to have a bug report for everything either, but I do agree that my failure to include it in the changelog for the FontPlatformData change was a stupid oversight. I'll make sure to avoid that mistake in the future! -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] bugid in ChangeLog
On Mar 26, 2011, at 3:24 AM, Patrick Gansterer wrote: > Sometimes folks commit changes without bug numbers. If those changes breaks > things it's hard to find the correct context for the change. > Can we make the bug number a requirement for a commit when it has a > corresponding bug? > IMHO it would be great if the style bot and the reviewer complain about > missing bug numbers. I don’t think we should require a bug report for every commit. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] bugid in ChangeLog
Hi, Sometimes folks commit changes without bug numbers. If those changes breaks things it's hard to find the correct context for the change. Can we make the bug number a requirement for a commit when it has a corresponding bug? IMHO it would be great if the style bot and the reviewer complain about missing bug numbers. - Patrick ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] XMLReader Interface Patch & XML Prague 2011
I've just uploaded a patch for WebKit that provides event-oriented parser for XML called XMLReader that is a variant of the behavior of XMLHttpRequest but, instead of building a whole document DOM, it delivers "XML Events" to an EventListener. The implementation has very low memory consumption characteristics and provides a great deal of flexibility for designing receiving applications that accomplish their XML tasks during the processing of the XML (e.g. data binding). I am presenting this interface at XML Prague tomorrow (Sunday, March 27th) and I've put the paper up at: http://www.milowski.com/research/xmlreader/ The page is #57145: https://bugs.webkit.org/show_bug.cgi?id=57145 I'm curious about any feedback you all might have. I should have sent this out earlier but I haven't had the time. Even "gut feel" or "immediate reactions" would be interesting. Don't hold back... :) -- --Alex Milowski "The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered." Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
