Am 26.03.2011 um 19:30 schrieb Brent Fulgham: > I don't want to have a bug report for everything either, but I do agree that > my failure to include it in the changelog for the FontPlatformData change was > a stupid oversight. > > I'll make sure to avoid that mistake in the future!
I didn't want to blame you directly! :-) Am 26.03.2011 um 21:32 schrieb Ryosuke Niwa: > On Sat, Mar 26, 2011 at 10:41 AM, Darin Adler <da...@apple.com> wrote: > On Mar 26, 2011, at 3:24 AM, Patrick Gansterer wrote: > > > Sometimes folks commit changes without bug numbers. If those changes breaks > > things it's hard to find the correct context for the change. > > Can we make the bug number a requirement for a commit when it has a > > corresponding bug? > > IMHO it would be great if the style bot and the reviewer complain about > > missing bug numbers. > > I don’t think we should require a bug report for every commit. > > I think Patrick is saying that we should require to have the corresponding > bug number if there is one, not that every commit should have a bug number. Correct! I don't think we need a bug id for every commit (e.g. a simple build fix). But if we already upload a patch to bugzilla we should make the bug number a requirement in the ChangeLog. IMHO there's no extra cost to do this. - Patrick
_______________________________________________ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
