Re: [webkit-dev] Spelling document markers: Design question
On Thu, Mar 7, 2013 at 2:58 PM, Rouslan Solomakhin < rouslan+web...@chromium.org> wrote: > The contextual spellcheck in Chromium needs to identify the spellcheck > request that added spelling markers to the document. > What is contextual spellcheck? > This information will be used to provide a feedback loop to the contextial > spellcheck. I was thinking about adding an ID field to > DocumentMarkerDescription detail. Is this a correct approach? > I'm with morrita on this one but it's hard to answer this kind of a design question without understanding what you're trying to achieve. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Spelling document markers: Design question
There are DocumentMarker, or DocumentMakerDetails. Which do you have in your mind? For me, it seems DocumentMarker is the right place to put such an ID since DocumentMarkerDetails is an immutable, shared object and giving such ID breaks the assumption for instance sharing. Or you can possibly introduce another DocumentMakerDetails for the "contextual marker". This approach might be cleaner. By introducing the new subclass, it won't interfere existing marker implementations. One caveat of this approach is that this needs extra heap allocations since DocumentMarkerDetails with unique IDs cannot be shared and will be allocated per marker. Sorry for my slow response. Hope this helps. On Fri, Mar 8, 2013 at 7:58 AM, Rouslan Solomakhin < rouslan+web...@chromium.org> wrote: > Howdy folks, > > The contextual spellcheck in Chromium needs to identify the spellcheck > request that added spelling markers to the document. This information will > be used to provide a feedback loop to the contextial spellcheck. I was > thinking about adding an ID field to DocumentMarkerDescription detail. Is > this a correct approach? > > Thank you all for thoughts and suggestions! > > Cheers, > Rouslan > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] SVGStopElement.idl recompiling every time if you build twice in a row?
Thanks for the information, both of you. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] SVGStopElement.idl recompiling every time if you build twice in a row?
Hi Darin, There is a bug report about this https://bugs.webkit.org/show_bug.cgi?id=107731 and a fix from Simon "Nuking WebKitBuild/Debug/DerivedSources/WebCore/*SVGStopElement.dep fixed this for me." Greetings, Dirk On Mar 10, 2013, at 6:15 PM, Darin Adler wrote: > On Mac, SVGStopElement.idl keeps getting recompiled every time I build > WebCore, and then in turn everything that uses the headers generated. Anyone > know why this happens? Is this specific to Mac, or happening with other build > systems too? > > -- Darin > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] SVGStopElement.idl recompiling every time if you build twice in a row?
On Mar 10, 2013, at 6:15 PM, Darin Adler wrote: > On Mac, SVGStopElement.idl keeps getting recompiled every time I build > WebCore, and then in turn everything that uses the headers generated. Anyone > know why this happens? Is this specific to Mac, or happening with other build > systems too? I noticed this too and I knew which change had caused it, then someone told me that if I deleted my build directory (or maybe it was just my derived sources directory) it would stop, and it did. I don’t know what is broken in the Mac (or all) build systems that made this necessary. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] SVGStopElement.idl recompiling every time if you build twice in a row?
On Mac, SVGStopElement.idl keeps getting recompiled every time I build WebCore, and then in turn everything that uses the headers generated. Anyone know why this happens? Is this specific to Mac, or happening with other build systems too? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] question about accessibility
hello everyone. I just wonder if webkit will include some runtime libraryes for accessibility like text to speech, ocr and speech recognition. this may sound silly, but there are many application examples of how this could be useful for accessibility. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
