Re: [webkit-dev] Proposal: Use ICU in WebKit code
05.10.2013, в 04:09, Konstantin Tokarev написал(а): > There is an issue with ICU: it uses UTF16 as its internal representation, > while most of the Web nowadays is UTF8. Therefore, page text goes through > unnecessary encoding conversion, and takes more memory than in UTF8 (for most > of languages). So it might be not a good development direction to tie up > WebKit to ICU. UTF-8 decoding is performed by a custom codec in WTF, we don't use ICU for that. So the question of which internal representation to use for strings that were UTF-8 on the wire is orthogonal to whether we use ICU directly or through an abstraction layer. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] GCC version consistency on EFL bots?
Hello Karen, Thank you for good information. However, as Andreas said, it is important to have the same compiler version both on EWS and bots. So, I feel I need that the problem bot has the same gcc version as soon as possible. Because I don't want to do something against WebKit(or common) development trend and policy. Thanks, Gyuyoung. On Mon, Oct 7, 2013 at 11:35 AM, Karen Shaeffer wrote: > Hi Gyuyoung, > > Be aware: > Ubuntu 12.10 (gnu 4.7.2) expires April 2014. > Ubuntu 13.04 (gnu 4.7.3) expires Jan 2014. > Ubunut 13.10 (gnu 4.8.1) scheduled release date Oct 17 2013. End of life > Jul 2014. > Ubuntu 14.04 (gnu 4.8.x) scheduled release date Apr 17 2014. LTS release > > I would avoid 13.04, because you'll need to upgrade twice more within > months to > get to 14.04 LTS. Either 12.10 or 13.10 allow you only 1 more upgrade to > get to > 14.04 LTS. I guess the decision should be which compiler version you > prefer. > > enjoy, > Karen > -- > Karen Shaeffer Be aware: If you see an obstacle in your > path, > Neuralscape Services that obstacle is your path.Zen > proverb > > On Mon, Oct 07, 2013 at 10:26:22AM +0900, Gyuyoung Kim wrote: > > Hi Andreas, > > > > Ah, I only talked on EFL ews bots. Yes, we're running an ubuntu 32bit > > machine only for a 32bit buildbot. And, it is based on Ubuntu 12.04 and > has > > gcc 4.6.3 version. I think the 32bit buildbot needs to be upgraded. I > will > > do it. > > > > Thanks, > > Gyuyoung. > > > > > > On Mon, Oct 7, 2013 at 10:07 AM, Andreas Kling wrote: > > > > > Hi Gyuyoung, > > > > > > Then why is final/override working on EWS but not on the main build > bots? > > > Are they using different compiler flags? > > > > > > According to wtf/Compiler.h, GCC should support override control since > at > > > least 4.7.0. > > > > > > Errors here: > > > > > > > http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/22628/steps/compile-webkit/logs/stdio > > > > > > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:60: > > > error: expected ';' at end of member declaration > > > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:62: > > > error: 'override' does not name a type > > > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:87: > > > error: expected ';' at end of member declaration > > > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:89: > > > error: 'override' does not name a type > > > > > > -Andreas > > > > > > On Oct 7, 2013, at 2:01 AM, Gyuyoung Kim > wrote: > > > > > > > Hi Andreas, > > > > > > > > > Are the main/EWS bots running different versions of GCC? > > > > > > > > No, EFL ews bots have same gcc version. EFL ews and buildbots are > being > > > ran on two machines. As far as I know, those are based on Ubuntu 13.04 > and > > > have same gcc 4.7.3. > > > > > > > > Thanks, > > > > Gyuyoung. > > > > > > > > > > > > On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling > wrote: > > > > Hi folks, > > > > > > > > I recently landed a patch that makes use of lowercased “override” > > > > and “final” in WebKit, and now the EFL build is failing. > > > > > > > > The EFL EWS bots didn’t have any problem with the patch however, > > > > which brings me to my question: > > > > > > > > Are the main/EWS bots running different versions of GCC? > > > > And if so, how soon can we make them use the same one? > > > > > > > > -Kling > > > > ___ > > > > webkit-dev mailing list > > > > webkit-dev@lists.webkit.org > > > > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > > > > > > > > > > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > https://lists.webkit.org/mailman/listinfo/webkit-dev > > --- end quoted text --- > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] GCC version consistency on EFL bots?
Hi Gyuyoung, Be aware: Ubuntu 12.10 (gnu 4.7.2) expires April 2014. Ubuntu 13.04 (gnu 4.7.3) expires Jan 2014. Ubunut 13.10 (gnu 4.8.1) scheduled release date Oct 17 2013. End of life Jul 2014. Ubuntu 14.04 (gnu 4.8.x) scheduled release date Apr 17 2014. LTS release I would avoid 13.04, because you'll need to upgrade twice more within months to get to 14.04 LTS. Either 12.10 or 13.10 allow you only 1 more upgrade to get to 14.04 LTS. I guess the decision should be which compiler version you prefer. enjoy, Karen -- Karen Shaeffer Be aware: If you see an obstacle in your path, Neuralscape Services that obstacle is your path.Zen proverb On Mon, Oct 07, 2013 at 10:26:22AM +0900, Gyuyoung Kim wrote: > Hi Andreas, > > Ah, I only talked on EFL ews bots. Yes, we're running an ubuntu 32bit > machine only for a 32bit buildbot. And, it is based on Ubuntu 12.04 and has > gcc 4.6.3 version. I think the 32bit buildbot needs to be upgraded. I will > do it. > > Thanks, > Gyuyoung. > > > On Mon, Oct 7, 2013 at 10:07 AM, Andreas Kling wrote: > > > Hi Gyuyoung, > > > > Then why is final/override working on EWS but not on the main build bots? > > Are they using different compiler flags? > > > > According to wtf/Compiler.h, GCC should support override control since at > > least 4.7.0. > > > > Errors here: > > > > http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/22628/steps/compile-webkit/logs/stdio > > > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:60: > > error: expected ';' at end of member declaration > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:62: > > error: 'override' does not name a type > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:87: > > error: expected ';' at end of member declaration > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:89: > > error: 'override' does not name a type > > > > -Andreas > > > > On Oct 7, 2013, at 2:01 AM, Gyuyoung Kim wrote: > > > > > Hi Andreas, > > > > > > > Are the main/EWS bots running different versions of GCC? > > > > > > No, EFL ews bots have same gcc version. EFL ews and buildbots are being > > ran on two machines. As far as I know, those are based on Ubuntu 13.04 and > > have same gcc 4.7.3. > > > > > > Thanks, > > > Gyuyoung. > > > > > > > > > On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling wrote: > > > Hi folks, > > > > > > I recently landed a patch that makes use of lowercased “override” > > > and “final” in WebKit, and now the EFL build is failing. > > > > > > The EFL EWS bots didn’t have any problem with the patch however, > > > which brings me to my question: > > > > > > Are the main/EWS bots running different versions of GCC? > > > And if so, how soon can we make them use the same one? > > > > > > -Kling > > > ___ > > > webkit-dev mailing list > > > webkit-dev@lists.webkit.org > > > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > > > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev --- end quoted text --- ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] GCC version consistency on EFL bots?
We can keep using FINAL and OVERRIDE macros for a while longer. That should keep the GCC 4.6 build trucking along. It’s still important that we use the same compiler on EWS and real bots, since the whole point is to avoid situations like this :) On Oct 7, 2013, at 3:19 AM, ryuan Choi wrote: > Hi gyuyoung and Andreas, > > If then, does it mean that webkit will drop support of gcc 4.6? > > Just for curiousity. > > Thanks. > > 2013. 10. 7. 오전 10:26에 "Gyuyoung Kim" 님이 작성: > Hi Andreas, > > Ah, I only talked on EFL ews bots. Yes, we're running an ubuntu 32bit machine > only for a 32bit buildbot. And, it is based on Ubuntu 12.04 and has gcc 4.6.3 > version. I think the 32bit buildbot needs to be upgraded. I will do it. > > Thanks, > Gyuyoung. > > > On Mon, Oct 7, 2013 at 10:07 AM, Andreas Kling wrote: > Hi Gyuyoung, > > Then why is final/override working on EWS but not on the main build bots? > Are they using different compiler flags? > > According to wtf/Compiler.h, GCC should support override control since at > least 4.7.0. > > Errors here: > http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/22628/steps/compile-webkit/logs/stdio > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:60: > error: expected ';' at end of member declaration > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:62: > error: 'override' does not name a type > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:87: > error: expected ';' at end of member declaration > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:89: > error: 'override' does not name a type > > -Andreas > > On Oct 7, 2013, at 2:01 AM, Gyuyoung Kim wrote: > > > Hi Andreas, > > > > > Are the main/EWS bots running different versions of GCC? > > > > No, EFL ews bots have same gcc version. EFL ews and buildbots are being ran > > on two machines. As far as I know, those are based on Ubuntu 13.04 and have > > same gcc 4.7.3. > > > > Thanks, > > Gyuyoung. > > > > > > On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling wrote: > > Hi folks, > > > > I recently landed a patch that makes use of lowercased “override” > > and “final” in WebKit, and now the EFL build is failing. > > > > The EFL EWS bots didn’t have any problem with the patch however, > > which brings me to my question: > > > > Are the main/EWS bots running different versions of GCC? > > And if so, how soon can we make them use the same one? > > > > -Kling > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] GCC version consistency on EFL bots?
Hi gyuyoung and Andreas, If then, does it mean that webkit will drop support of gcc 4.6? Just for curiousity. Thanks. 2013. 10. 7. 오전 10:26에 "Gyuyoung Kim" 님이 작성: > Hi Andreas, > > Ah, I only talked on EFL ews bots. Yes, we're running an ubuntu 32bit > machine only for a 32bit buildbot. And, it is based on Ubuntu 12.04 and has > gcc 4.6.3 version. I think the 32bit buildbot needs to be upgraded. I will > do it. > > Thanks, > Gyuyoung. > > > On Mon, Oct 7, 2013 at 10:07 AM, Andreas Kling wrote: > >> Hi Gyuyoung, >> >> Then why is final/override working on EWS but not on the main build bots? >> Are they using different compiler flags? >> >> According to wtf/Compiler.h, GCC should support override control since at >> least 4.7.0. >> >> Errors here: >> >> http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/22628/steps/compile-webkit/logs/stdio >> >> /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:60: >> error: expected ';' at end of member declaration >> /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:62: >> error: 'override' does not name a type >> /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:87: >> error: expected ';' at end of member declaration >> /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:89: >> error: 'override' does not name a type >> >> -Andreas >> >> On Oct 7, 2013, at 2:01 AM, Gyuyoung Kim wrote: >> >> > Hi Andreas, >> > >> > > Are the main/EWS bots running different versions of GCC? >> > >> > No, EFL ews bots have same gcc version. EFL ews and buildbots are being >> ran on two machines. As far as I know, those are based on Ubuntu 13.04 and >> have same gcc 4.7.3. >> > >> > Thanks, >> > Gyuyoung. >> > >> > >> > On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling wrote: >> > Hi folks, >> > >> > I recently landed a patch that makes use of lowercased “override” >> > and “final” in WebKit, and now the EFL build is failing. >> > >> > The EFL EWS bots didn’t have any problem with the patch however, >> > which brings me to my question: >> > >> > Are the main/EWS bots running different versions of GCC? >> > And if so, how soon can we make them use the same one? >> > >> > -Kling >> > ___ >> > webkit-dev mailing list >> > webkit-dev@lists.webkit.org >> > https://lists.webkit.org/mailman/listinfo/webkit-dev >> > >> >> > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] GCC version consistency on EFL bots?
Hi Andreas, Ah, I only talked on EFL ews bots. Yes, we're running an ubuntu 32bit machine only for a 32bit buildbot. And, it is based on Ubuntu 12.04 and has gcc 4.6.3 version. I think the 32bit buildbot needs to be upgraded. I will do it. Thanks, Gyuyoung. On Mon, Oct 7, 2013 at 10:07 AM, Andreas Kling wrote: > Hi Gyuyoung, > > Then why is final/override working on EWS but not on the main build bots? > Are they using different compiler flags? > > According to wtf/Compiler.h, GCC should support override control since at > least 4.7.0. > > Errors here: > > http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/22628/steps/compile-webkit/logs/stdio > > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:60: > error: expected ';' at end of member declaration > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:62: > error: 'override' does not name a type > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:87: > error: expected ';' at end of member declaration > /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:89: > error: 'override' does not name a type > > -Andreas > > On Oct 7, 2013, at 2:01 AM, Gyuyoung Kim wrote: > > > Hi Andreas, > > > > > Are the main/EWS bots running different versions of GCC? > > > > No, EFL ews bots have same gcc version. EFL ews and buildbots are being > ran on two machines. As far as I know, those are based on Ubuntu 13.04 and > have same gcc 4.7.3. > > > > Thanks, > > Gyuyoung. > > > > > > On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling wrote: > > Hi folks, > > > > I recently landed a patch that makes use of lowercased “override” > > and “final” in WebKit, and now the EFL build is failing. > > > > The EFL EWS bots didn’t have any problem with the patch however, > > which brings me to my question: > > > > Are the main/EWS bots running different versions of GCC? > > And if so, how soon can we make them use the same one? > > > > -Kling > > ___ > > webkit-dev mailing list > > webkit-dev@lists.webkit.org > > https://lists.webkit.org/mailman/listinfo/webkit-dev > > > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] GCC version consistency on EFL bots?
Hi Gyuyoung, Then why is final/override working on EWS but not on the main build bots? Are they using different compiler flags? According to wtf/Compiler.h, GCC should support override control since at least 4.7.0. Errors here: http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/22628/steps/compile-webkit/logs/stdio /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:60: error: expected ';' at end of member declaration /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:142:62: error: 'override' does not name a type /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:87: error: expected ';' at end of member declaration /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebCore/editing/markup.cpp:143:89: error: 'override' does not name a type -Andreas On Oct 7, 2013, at 2:01 AM, Gyuyoung Kim wrote: > Hi Andreas, > > > Are the main/EWS bots running different versions of GCC? > > No, EFL ews bots have same gcc version. EFL ews and buildbots are being ran > on two machines. As far as I know, those are based on Ubuntu 13.04 and have > same gcc 4.7.3. > > Thanks, > Gyuyoung. > > > On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling wrote: > Hi folks, > > I recently landed a patch that makes use of lowercased “override” > and “final” in WebKit, and now the EFL build is failing. > > The EFL EWS bots didn’t have any problem with the patch however, > which brings me to my question: > > Are the main/EWS bots running different versions of GCC? > And if so, how soon can we make them use the same one? > > -Kling > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] GCC version consistency on EFL bots?
Hi Andreas, > Are the main/EWS bots running different versions of GCC? No, EFL ews bots have same gcc version. EFL ews and buildbots are being ran on two machines. As far as I know, those are based on Ubuntu 13.04 and have same gcc 4.7.3. Thanks, Gyuyoung. On Mon, Oct 7, 2013 at 4:56 AM, Andreas Kling wrote: > Hi folks, > > I recently landed a patch that makes use of lowercased “override” > and “final” in WebKit, and now the EFL build is failing. > > The EFL EWS bots didn’t have any problem with the patch however, > which brings me to my question: > > Are the main/EWS bots running different versions of GCC? > And if so, how soon can we make them use the same one? > > -Kling > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please install shellwords on the bots
On Oct 6, 2013, at 2:00 PM, Benjamin Poulain wrote: > On 10/6/13, 1:54 PM, Filip Pizlo wrote: >> This bug: https://bugs.webkit.org/show_bug.cgi?id=120696 >> >> Is for making run-javascriptcore-tests run all of the tests in >> parallel and in a way that is aware of our multiple tiers. It vastly >> improves JSC test coverage. >> >> Right now, the script will refuse to do anything if your machine >> doesn't have the Ruby shellwords package installed. Eventually I'll >> change that to make it just fail. >> >> Please install shellwords on the bots so that this script can work. >> >> (And no, I don't see an easy alternative to using shellwords for this >> testing infrastructure. It would take a lot more code if we didn't >> want to use shellwords. So, you should install shellwords to run >> javascriptcore tests. It's already installed by default on a lot of >> OS's.) >> >> I'll be landing this patch soon. We need the test coverage. > > Could run-javascriptcore-tests just install shellwords when it is missing? Probably. > > There is a precedent of this, webkit-patch downloads every missing > packages, making it easy to use without installing the dependencies. In the case of shellwords, the majority of WebKit developers will already have it. It’s part of the Ruby standard library as of version 2. > > Benjamin > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Please install shellwords on the bots
On 10/6/13, 1:54 PM, Filip Pizlo wrote: > This bug: https://bugs.webkit.org/show_bug.cgi?id=120696 > > Is for making run-javascriptcore-tests run all of the tests in > parallel and in a way that is aware of our multiple tiers. It vastly > improves JSC test coverage. > > Right now, the script will refuse to do anything if your machine > doesn't have the Ruby shellwords package installed. Eventually I'll > change that to make it just fail. > > Please install shellwords on the bots so that this script can work. > > (And no, I don't see an easy alternative to using shellwords for this > testing infrastructure. It would take a lot more code if we didn't > want to use shellwords. So, you should install shellwords to run > javascriptcore tests. It's already installed by default on a lot of > OS's.) > > I'll be landing this patch soon. We need the test coverage. Could run-javascriptcore-tests just install shellwords when it is missing? There is a precedent of this, webkit-patch downloads every missing packages, making it easy to use without installing the dependencies. Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Please install shellwords on the bots
This bug: https://bugs.webkit.org/show_bug.cgi?id=120696 Is for making run-javascriptcore-tests run all of the tests in parallel and in a way that is aware of our multiple tiers. It vastly improves JSC test coverage. Right now, the script will refuse to do anything if your machine doesn't have the Ruby shellwords package installed. Eventually I'll change that to make it just fail. Please install shellwords on the bots so that this script can work. (And no, I don't see an easy alternative to using shellwords for this testing infrastructure. It would take a lot more code if we didn't want to use shellwords. So, you should install shellwords to run javascriptcore tests. It's already installed by default on a lot of OS's.) I'll be landing this patch soon. We need the test coverage. -Filip ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Use ICU in WebKit code
> "Since ICU uses Unicode (UTF-16) internally, all converters convert > between UTF-16 (with the endianness according to the current platform) > and another encoding.” The claim I would like to verify is that this design is slower and "takes more memory” due to "unnecessary encoding conversion”. Engineers working on WebKit performance should provide — and require of others — verifiable empirical data to back up performance claims. Geoff ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] GCC version consistency on EFL bots?
Hi folks, I recently landed a patch that makes use of lowercased “override” and “final” in WebKit, and now the EFL build is failing. The EFL EWS bots didn’t have any problem with the patch however, which brings me to my question: Are the main/EWS bots running different versions of GCC? And if so, how soon can we make them use the same one? -Kling ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Use ICU in WebKit code
I think the question was about the performance impact of using UTF-16 as an internal representation of characters. The original claim was in effect that the encoding conversion to UTF-16 is so costly that it offsets any gain of doing codepoint operations on UTF-16 instead of UTF-8. It is a very strong claim because experiments so far have proven the opposite. I think the statement against ICU/UTF16 needs to be backed by experimental data. Benjamin On 10/6/13, 12:31 PM, Alp Toker wrote: > Geoffrey, http://userguide.icu-project.org/conversion/converters says: > > "Since ICU uses Unicode (UTF-16) internally, all converters convert > between UTF-16 (with the endianness according to the current platform) > and another encoding." > > That said, I don't think it's a major concern because ICU works on byte > streams. It's not like these strings will persist internally somewhere > eating lots of memory. > > From experience, the old WTF in-place converters found in WebKit > "mobile" ports of past were way-buggy and probably only ever tested with > ASCII. I'd say use ICU and don't look back :-) > > Alp. > > > On 06/10/2013 20:08, Geoffrey Garen wrote: >>> There is an issue with ICU: it uses UTF16 as its internal representation, >>> while most of the Web nowadays is UTF8. Therefore, page text goes through >>> unnecessary encoding conversion, and takes more memory than in UTF8 (for >>> most of languages). So it might be not a good development direction to tie >>> up WebKit to ICU. >> Is there a benchmark or website that can verify these claims? >> >> Thanks, >> Geoff >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Use ICU in WebKit code
Geoffrey, http://userguide.icu-project.org/conversion/converters says: "Since ICU uses Unicode (UTF-16) internally, all converters convert between UTF-16 (with the endianness according to the current platform) and another encoding." That said, I don't think it's a major concern because ICU works on byte streams. It's not like these strings will persist internally somewhere eating lots of memory. >From experience, the old WTF in-place converters found in WebKit "mobile" ports of past were way-buggy and probably only ever tested with ASCII. I'd say use ICU and don't look back :-) Alp. On 06/10/2013 20:08, Geoffrey Garen wrote: >> There is an issue with ICU: it uses UTF16 as its internal representation, >> while most of the Web nowadays is UTF8. Therefore, page text goes through >> unnecessary encoding conversion, and takes more memory than in UTF8 (for >> most of languages). So it might be not a good development direction to tie >> up WebKit to ICU. > Is there a benchmark or website that can verify these claims? > > Thanks, > Geoff > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev -- http://www.nuanti.com the browser experts ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Use ICU in WebKit code
> There is an issue with ICU: it uses UTF16 as its internal representation, > while most of the Web nowadays is UTF8. Therefore, page text goes through > unnecessary encoding conversion, and takes more memory than in UTF8 (for most > of languages). So it might be not a good development direction to tie up > WebKit to ICU. Is there a benchmark or website that can verify these claims? Thanks, Geoff ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
