Re: [webkit-dev] EWS: feeder and style queues are offline

[Ryosuke Niwa]

Or now.
- R. Niwa


On Tue, May 3, 2016 at 12:53 PM, Lucas Forschler  wrote:
> This should be all fixed up now.
> Lucas
>
>> On May 3, 2016, at 7:38 AM, Osztrogonác Csaba  wrote:
>>
>> Hi,
>>
>> it seems feeder and style queues are offline
>> now, which means EWS and CQ bots aren't fed.
>>
>> Could somebody possibly restart these bots?
>>
>> br,
>> Ossy
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EWS: feeder and style queues are offline

[Lucas Forschler]

This should be all fixed up now.
Lucas

> On May 3, 2016, at 7:38 AM, Osztrogonác Csaba  wrote:
> 
> Hi,
> 
> it seems feeder and style queues are offline
> now, which means EWS and CQ bots aren't fed.
> 
> Could somebody possibly restart these bots?
> 
> br,
> Ossy
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Windows Bot Updates

[Brent Fulgham]

Hi Everyone,

I have just reviewed the full set of Windows EWS and build bots, and updated 
them as follows:

1. Perl 5.18 or newer, which matches the Perl shipped with Mac OS.
2. Visual Studio 2015, Update 2. This fixes a number of C++ compatibility 
issues.

At this point, it should not be necessary to have Windows-specific C++ hacks in 
the code.

Most of the places where I knew we had worked around VC++ compiler bugs were 
commented. We have now removed all such commented hacks.

Please let me know if you are aware of any other cases where we were forced to 
use less efficient or more complicated code to work around an issue with Visual 
C++. We should be able to remove those hacks now.

Thanks,

-Brent
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] On/Off selection gap painting during the text selection

[Manuel Rego Casasnovas]

On 03/05/16 17:12, Gyuyoung Kim wrote:
> In second issue case, although it looks there is no critical issue with
> new layout methods yet
> I think I need to check it further. But the issues won't appear on port
> which uses gaps painting.

Maybe I didn't explain myself properly, but the issue with new layout
methods is happening when you paint the selection gaps, if you don't
paint them the issue disappears.

A very simple example with Flexbox:

  first
  second
  third
  fourth


Try to select from "first" to "third", with selection gaps painting the
final result is really bad. Without gaps painting it should be better.
You can check it live here: http://jsbin.com/getafojevu/1/edit

Bye,
  Rego
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] On/Off selection gap painting during the text selection

[Gyuyoung Kim]

Hi Rego,

Thank you for pointing issues out when removing gaps painting. The issues
probably heads up
when gaps painting is disabled. In newline issue case, I'm able to refer to
the chrome's fix. Let me check it.
In second issue case, although it looks there is no critical issue with new
layout methods yet
I think I need to check it further. But the issues won't appear on port
which uses gaps painting.

gyuyoung.

On Tue, May 3, 2016 at 10:58 PM, Manuel Rego Casasnovas 
wrote:

> Hi,
>
> On 03/05/16 15:24, Gyuyoung Kim wrote:
> > I upload a patch to add a preference API in order to enable/disable the
> > selection gap painting feature.
>
> BTW, this has been removed from Chrome too past year:
>
> https://groups.google.com/a/chromium.org/d/msg/blink-dev/6Iu5oIbAGbI/PsJlNvJPhfMJ
>
> Note that in the discussion they pointed to an issue that happens when
> you remove gaps paining, you don't know if you've selected a newlines or
> not: https://bugs.chromium.org/p/chromium/issues/detail?id=474759
>
> > Add WKPreference for SelectionPaintingWithoutSelectionGaps
> > https://bugs.webkit.org/show_bug.cgi?id=156900
>
> As pointed out by Darin on the bug, an issue with selection gaps is what
> happens with the new layout methods like Flexbox and specially Grid
> Layout, where the visual order and the DOM order can be completely
> different.
>
> My 2 cents,
>   Rego
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] EWS: feeder and style queues are offline

[Osztrogonác Csaba]

Hi,

it seems feeder and style queues are offline
now, which means EWS and CQ bots aren't fed.

Could somebody possibly restart these bots?

br,
Ossy
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] On/Off selection gap painting during the text selection

[Manuel Rego Casasnovas]

Hi,

On 03/05/16 15:24, Gyuyoung Kim wrote:
> I upload a patch to add a preference API in order to enable/disable the
> selection gap painting feature.

BTW, this has been removed from Chrome too past year:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/6Iu5oIbAGbI/PsJlNvJPhfMJ

Note that in the discussion they pointed to an issue that happens when
you remove gaps paining, you don't know if you've selected a newlines or
not: https://bugs.chromium.org/p/chromium/issues/detail?id=474759

> Add WKPreference for SelectionPaintingWithoutSelectionGaps
> https://bugs.webkit.org/show_bug.cgi?id=156900

As pointed out by Darin on the bug, an issue with selection gaps is what
happens with the new layout methods like Flexbox and specially Grid
Layout, where the visual order and the DOM order can be completely
different.

My 2 cents,
  Rego
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] About unprefixing CSS Grid Layout (implementation status summary included)

[Manuel Rego Casasnovas]

On 30/04/16 00:17, Dean Jackson wrote:
> Please leave the build flag around. We probably need a bigger discussion
> on this, but for now we should have both a runtime flag and a build flag
> just in case a browser ships and doesn't want the feature compiled at all
> (reducing binary size).

Ok, no problem from our side, we'll have both the build flag and the
runtime flag together. Eventually once we ship Grid Layout, we'll get
rid of both.

BTW, the runtime flag has already landed (r200215) and the unprefixing
patch is ready for review: http://webkit.org/b/157137

Thanks,
  Rego
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev