Re: [webkit-dev] Inconsistency in logging approach
W dniu 23.06.2011 22:16, Darin Adler pisze: Correcting the #if to use LOG_DISABLED would be going back to the original design. I created bugzilla patch for it https://bugs.webkit.org/show_bug.cgi?id=63346 Regards Lukasz Slachciak ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Inconsistency in logging approach
Hello All, I would like to know what do you think about Logging in Release build. Should WebKit allow it? Currently it is not possible because some features (like IconDatabase) use #ifndef NDEBUG for marking LOG macro related code. From the other hand in WebKit2 all logging is based on the #if !LOG_DISABLED macro. Ports approach to logging in Release builds is not consistent too: - GTK and EFL allows to use LOG in Release - Qt it is not possible Personally, I like approach of putting logging related code into #if !LOG_DISABLED macro instead of #ifndef NDEBUG. I prepared small patch to allow building WebKit in Release build and use logging. I'll open ticket in bugzilla, but first I would like to know your opinion about this idea. Regards Lukasz Slachciak ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] API documentation in cpp files
W dniu 22.06.2011 18:27, Darin Adler pisze: For WebKit API header files, files intended to be used by the clients of WebKit outside the project, I think your proposal makes sense. For an example of a header file in WebKit that is done in this way, you could look at JavaScriptCore/API/JSObjectRef.h. I also think that for API files going to development packages should have some documentation. Maybe for WebKit2 we could use consistent approach and for external API write documentation in header files? Regards Lukasz Slachciak ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Inconsistency in logging approach
On 23.06.2011 22:16, Darin Adler wrote: But I’m surprised that GTK and EFL chose to leave logging on in releases. -- Darin They warn user with messaage sth like: WEBKIT_DEBUG is not empty, but this is a release build. Notice that many log messages will only appear in a debug build. Of course to have logging working in GTK you need to turn off LOG_DISABLED macro in Assertions.h. Regards Lukasz Slachciak ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
