Re: [webkit-dev] Importing W3C tests for HTML template elements
I created a bug to track this (serve imported w3c tests using wptserve: https://bugs.webkit.org/show_bug.cgi?id=127094). I also plan to work on merging Blink patches to allow checking testharness-based tests without the use of any -expected file: https://bugs.webkit.org/show_bug.cgi?id=127095. 2014/1/6 Dirk Pranke dpra...@chromium.org Ryosuke and I discussed this a bit over IRC. Ryosuke's main concern was that supporting multiple document roots adds a fair amount of complexity to NRWT. Conceptually, it's probably easier to add support to run the W3C's new server (known as wptserve) and then maybe use it for *all* imported tests from the W3C. If it turns out that wptserve is too slow, and you would prefer to run only some of the directories over http (i.e., the 10k+ CSS tests don't need http), you'll probably need to modify how wptserve is run (and NRWT) as well, anyway, so the patch would be different. Ryosuke, please let me know if I've misstated your thinking at all. -- Dirk On Mon, Jan 6, 2014 at 11:23 AM, Ryosuke Niwa rn...@webkit.org wrote: I don't think we should do this given that the python server has been added to W3C testing harness, and they're gonna convert all existing tests to use that instead: http://lists.w3.org/Archives/Public/public-test-infra/2014JanMar/.html We should simply wait for that effort to take place and add a support for the python server instead. - R. Niwa On Fri, Dec 6, 2013 at 12:25 AM, youenn fablet youe...@gmail.com wrote: As long as the newly imported tests use relative URLs, alias may be used as a workaround. I will give it a try. Bug entry is at https://bugs.webkit.org/show_bug.cgi?id=125339 Any further help appreciated, Youenn 2013/12/6 Darin Adler da...@apple.com If that's really ends up being super hard we can always put yet another third-party or imported directory inside the http directory as previously suggested. it's annoying to have three different places for imported tests and code, but not something I want to hold us up for a long time. -- Darin Sent from my iPhone On Dec 5, 2013, at 5:51 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote: On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. One trickiness to it is that we don't currently run any HTTP test in parallel and the document root of the HTTP server is set to LayoutTests/http/tests so we might need to modify that or restart the HTTP server whenever we're running HTTP tests outside of LayoutTests/http. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
I don't think we should do this given that the python server has been added to W3C testing harness, and they're gonna convert all existing tests to use that instead: http://lists.w3.org/Archives/Public/public-test-infra/2014JanMar/.html We should simply wait for that effort to take place and add a support for the python server instead. - R. Niwa On Fri, Dec 6, 2013 at 12:25 AM, youenn fablet youe...@gmail.com wrote: As long as the newly imported tests use relative URLs, alias may be used as a workaround. I will give it a try. Bug entry is at https://bugs.webkit.org/show_bug.cgi?id=125339 Any further help appreciated, Youenn 2013/12/6 Darin Adler da...@apple.com If that's really ends up being super hard we can always put yet another third-party or imported directory inside the http directory as previously suggested. it's annoying to have three different places for imported tests and code, but not something I want to hold us up for a long time. -- Darin Sent from my iPhone On Dec 5, 2013, at 5:51 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote: On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. One trickiness to it is that we don't currently run any HTTP test in parallel and the document root of the HTTP server is set to LayoutTests/http/tests so we might need to modify that or restart the HTTP server whenever we're running HTTP tests outside of LayoutTests/http. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
On 06/01/2014 20:23 , Ryosuke Niwa wrote: I don't think we should do this given that the python server has been added to W3C testing harness, and they're gonna convert all existing tests to use that instead: http://lists.w3.org/Archives/Public/public-test-infra/2014JanMar/.html We should simply wait for that effort to take place and add a support for the python server instead. I'm happy to report that the conversion to a python server as well as of all the server-side dynamic content that it needs to run is now complete and has been merged to master as of today. No need to wait! -- Robin Berjon - http://berjon.com/ - @robinberjon ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
Ryosuke and I discussed this a bit over IRC. Ryosuke's main concern was that supporting multiple document roots adds a fair amount of complexity to NRWT. Conceptually, it's probably easier to add support to run the W3C's new server (known as wptserve) and then maybe use it for *all* imported tests from the W3C. If it turns out that wptserve is too slow, and you would prefer to run only some of the directories over http (i.e., the 10k+ CSS tests don't need http), you'll probably need to modify how wptserve is run (and NRWT) as well, anyway, so the patch would be different. Ryosuke, please let me know if I've misstated your thinking at all. -- Dirk On Mon, Jan 6, 2014 at 11:23 AM, Ryosuke Niwa rn...@webkit.org wrote: I don't think we should do this given that the python server has been added to W3C testing harness, and they're gonna convert all existing tests to use that instead: http://lists.w3.org/Archives/Public/public-test-infra/2014JanMar/.html We should simply wait for that effort to take place and add a support for the python server instead. - R. Niwa On Fri, Dec 6, 2013 at 12:25 AM, youenn fablet youe...@gmail.com wrote: As long as the newly imported tests use relative URLs, alias may be used as a workaround. I will give it a try. Bug entry is at https://bugs.webkit.org/show_bug.cgi?id=125339 Any further help appreciated, Youenn 2013/12/6 Darin Adler da...@apple.com If that's really ends up being super hard we can always put yet another third-party or imported directory inside the http directory as previously suggested. it's annoying to have three different places for imported tests and code, but not something I want to hold us up for a long time. -- Darin Sent from my iPhone On Dec 5, 2013, at 5:51 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote: On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. One trickiness to it is that we don't currently run any HTTP test in parallel and the document root of the HTTP server is set to LayoutTests/http/tests so we might need to modify that or restart the HTTP server whenever we're running HTTP tests outside of LayoutTests/http. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
As long as the newly imported tests use relative URLs, alias may be used as a workaround. I will give it a try. Bug entry is at https://bugs.webkit.org/show_bug.cgi?id=125339 Any further help appreciated, Youenn 2013/12/6 Darin Adler da...@apple.com If that's really ends up being super hard we can always put yet another third-party or imported directory inside the http directory as previously suggested. it's annoying to have three different places for imported tests and code, but not something I want to hold us up for a long time. -- Darin Sent from my iPhone On Dec 5, 2013, at 5:51 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote: On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. One trickiness to it is that we don't currently run any HTTP test in parallel and the document root of the HTTP server is set to LayoutTests/http/tests so we might need to modify that or restart the HTTP server whenever we're running HTTP tests outside of LayoutTests/http. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
The way I got around this when I was first working on it was to simply map imported/w3c onto a subdirectory of the document root in apache; it's a two line change. For some time I've toyed with the idea of changing the DocumentRoot to just be LayoutTests/, so that any test could be run over http directly. A lot of tests and test results would need to be updated for this, but I think it could simplify the test organization a fair amount and open up some interesting possibilities. -- Dirk On Thu, Dec 5, 2013 at 6:25 PM, Darin Adler da...@apple.com wrote: If that's really ends up being super hard we can always put yet another third-party or imported directory inside the http directory as previously suggested. it's annoying to have three different places for imported tests and code, but not something I want to hold us up for a long time. -- Darin Sent from my iPhone On Dec 5, 2013, at 5:51 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote: On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. One trickiness to it is that we don't currently run any HTTP test in parallel and the document root of the HTTP server is set to LayoutTests/http/tests so we might need to modify that or restart the HTTP server whenever we're running HTTP tests outside of LayoutTests/http. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote: On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. Might be nice to think about a more elegant way to trigger the HTTP server when needed. Even requiring some kind of trigger file in each directory would be better than the hard-coded path rule we use now. I'd prefer/recommend LayoutTests/imported/w3c as well (and just modify the test scripts to deal w/ the additional http servers). As you start to pull in more of the w3c's tests, there will probably need to be some overall cleanup and refactoring of how stuff like this works and is shared (e.g., duplication of files under resources/ , paths mapped in the http server, etc.). Blink has the same issues. I'd be happy to help out with this where possible to try and keep things relatively consistent. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote: On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. One trickiness to it is that we don't currently run any HTTP test in parallel and the document root of the HTTP server is set to LayoutTests/http/tests so we might need to modify that or restart the HTTP server whenever we're running HTTP tests outside of LayoutTests/http. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
If that's really ends up being super hard we can always put yet another third-party or imported directory inside the http directory as previously suggested. it's annoying to have three different places for imported tests and code, but not something I want to hold us up for a long time. -- Darin Sent from my iPhone On Dec 5, 2013, at 5:51 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Dec 4, 2013 at 11:19 AM, Darin Adler da...@apple.com wrote: On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. One trickiness to it is that we don't currently run any HTTP test in parallel and the document root of the HTTP server is set to LayoutTests/http/tests so we might need to modify that or restart the HTTP server whenever we're running HTTP tests outside of LayoutTests/http. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? Youenn 2013/11/22 Ryosuke Niwa rn...@webkit.org On Fri, Nov 22, 2013 at 12:15 AM, Sergio Villar Senin svil...@igalia.comwrote: On 21/11/13 09:16, - R. Niwa wrote: Maciej says he'd rather see w3c directory under imported directory so I'm doing that. That was not done for other set of imported tests. Are you planning to move them also to that same place? The idea is that. I don't intend on doing that work myself. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
On Dec 4, 2013, at 6:48 AM, youenn fablet youe...@gmail.com wrote: I am planning to add some XHR tests from https://github.com/w3c/web-platform-tests. My initial plan was to add them in a subdirectory of LayoutTests/http/tests/w3c. If adding them into LayoutTests/imported/w3c, that would probably require updating the test scripts to start/stop the HTTP test server for that particular sub-folder. Any preference? I’d prefer LayoutTests/imported/w3c. Although I’m not so happy about the different terminology we are using for “imported” vs. “ThirdParty”, which seems like the same concept at the top level of the directory structure. Might be nice to think about a more elegant way to trigger the HTTP server when needed. Even requiring some kind of trigger file in each directory would be better than the hard-coded path rule we use now. — Darin___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Importing W3C tests for HTML template elements
Hi, There has been a lot of discussions about importing W3C tests. Since I'm already trying to enable HTML template elements, I've decided to take lead on this and add LayoutTests/w3c directory as we've previously come to consensus. I've posted a patch to import some of HTML template elements tests into LayoutTests/w3c/html-templates at https://bugs.webkit.org/show_bug.cgi?id=124699 Since W3C is planning to move all tests into web-platform-tests repository: https://github.com/w3c/web-platform-tests, I didn't feel the need to put it inside LayoutTests/w3c/web-platform-tests/html-templates but I can do that if someone feels strongly about it. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
Maciej says he'd rather see w3c directory under imported directory so I'm doing that. - R. Niwa On Thu, Nov 21, 2013 at 5:01 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, There has been a lot of discussions about importing W3C tests. Since I'm already trying to enable HTML template elements, I've decided to take lead on this and add LayoutTests/w3c directory as we've previously come to consensus. I've posted a patch to import some of HTML template elements tests into LayoutTests/w3c/html-templates at https://bugs.webkit.org/show_bug.cgi?id=124699 Since W3C is planning to move all tests into web-platform-tests repository: https://github.com/w3c/web-platform-tests, I didn't feel the need to put it inside LayoutTests/w3c/web-platform-tests/html-templates but I can do that if someone feels strongly about it. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
On 21/11/13 09:16, Ryosuke Niwa wrote: Maciej says he'd rather see w3c directory under imported directory so I'm doing that. That was not done for other set of imported tests. Are you planning to move them also to that same place? BR ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
On Nov 21, 2013, at 00:01 , Ryosuke Niwa rn...@webkit.orgmailto:rn...@webkit.org wrote: Hi, There has been a lot of discussions about importing W3C tests. Since I'm already trying to enable HTML template elements, I've decided to take lead on this and add LayoutTests/w3c directory as we've previously come to consensus. I've posted a patch to import some of HTML template elements tests into LayoutTests/w3c/html-templates at https://bugs.webkit.org/show_bug.cgi?id=124699 Since W3C is planning to move all tests into web-platform-tests repository: https://github.com/w3c/web-platform-tests, I didn't feel the need to put it inside LayoutTests/w3c/web-platform-tests/html-templates but I can do that if someone feels strongly about it. I'm all for this. Are you aware of the script in Tools/Scripts/import-w3c-tests ? By default, it imports into LayoutTests/w3c. - Bem ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Importing W3C tests for HTML template elements
On Fri, Nov 22, 2013 at 12:15 AM, Sergio Villar Senin svil...@igalia.comwrote: On 21/11/13 09:16, - R. Niwa wrote: Maciej says he'd rather see w3c directory under imported directory so I'm doing that. That was not done for other set of imported tests. Are you planning to move them also to that same place? The idea is that. I don't intend on doing that work myself. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
