[webstack-discuss] php cum its extensions version upgrade and minor bu

[Seema]

Hi Sriram,

Some minor comments

1. usr/src/cmd/php5/METADATA :
SRC field should be updated to point to the latest source.

2. usr/src/cmd/php5/Makefile.sfw
Does 5.2.8 include php_cgi_main.c.patch changes ?

3. usr/src/cmd/php5/patches/idn_config.patch :
Should SEARCH_FOR value include the / at the beginning of the path ?

4. usr/src/cmd/php5/patches/php_configure.patch :
Has one extra blank line at the end of the file which can be removed.


Regards,
Seema.
-- 
This message posted from opensolaris.org

[webstack-discuss] php cum its extensions version upgrade and minor

[Sriram Natarajan]

HI
 Please find the updated webrev at this below location
http://cr.opensolaris.org/~sn123202/webrev.2/

 Hi Sriram,
 
 Some minor comments
 
 1. usr/src/cmd/php5/METADATA :
 SRC field should be updated to point to the
 latest source.

done

 
 2. usr/src/cmd/php5/Makefile.sfw
 Does 5.2.8 include php_cgi_main.c.patch changes
  ?
 
yes, it does

 3. usr/src/cmd/php5/patches/idn_config.patch :
 Should SEARCH_FOR value include the / at the
 beginning of the path ?
 

the config.m4 script does that. it works with the current patch :-)

 4. usr/src/cmd/php5/patches/php_configure.patch :
 Has one extra blank line at the end of the file
  which can be removed.
 
 
ok
 rds,
 Seema.
-- 
This message posted from opensolaris.org

[webstack-discuss] php cum its extensions version upgrade and minor bug fixes

[Sriram Natarajan]

Hi
 I would like to upgrade  php version to 5.2.8 and php extensions like xdebug 
and idn to the latest version as well.  these version upgrade are bug fixes 
only and are there are no documented backward compatible issues .  This webrev 
also includes misc minor bug fixes that has been in pending for quite some time

http://cr.opensolaris.org/~sn123202/php528/webrev/php-gate.patch

your comments are much appreciated. 
thanks
sriram