subject:"\[Wicket\-user\] TextField and trimming blanks at end \(and maybe at beginning\)"

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-10 Thread Johan Compagner

By the way.That method is already overridden by many other formcomponents like RadioChoice, DropDownChoice or CheckBoxAlso when a textfield has a type specified it will also not fall into that method. because the type conversion through the convertor 
will happen instead.So it only happens for textfieds without a type specified.johanOn 3/10/06, Johan Compagner <
[EMAIL PROTECTED]> wrote:just committed it:
FormComponentprotected Object convertValue(String value) throws ConversionException    {        return value != null?value.trim():null;
    }so if you don't want trimming, override that method and return directly the value.
I think it is a better default.We could make a global property to switch it again, but personally i don't see many uses for that.johan
On 3/10/06, 
Ari Suutari <[EMAIL PROTECTED]> wrote:

To sum up discussion, I understood that trimming is goingto be default behaviour on text fields (soon) ? Correct ?Ari S.- Original Message -From: "Ari Suutari" <

[EMAIL PROTECTED]>To: <wicket-user@lists.sourceforge.net>Sent: Monday, March 06, 2006 3:25 PM
Subject: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)
> Hi,>> What might be the simplest way to change behaviour of whole wicket application> so that TextField have their input trimmed of blanks at end ?>> I tried to do this via converters (I have my own converter factory),
> but it didn't work because Converter.convert doesn't do anything> if String is being assigned to String field in model (it uses isAssignableFrom> for this check).>>Ari S.>

>>>> ---> This SF.Net email is sponsored by xPML, a groundbreaking scripting language> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!> 
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> ___> Wicket-user mailing list> 
Wicket-user@lists.sourceforge.net> 
https://lists.sourceforge.net/lists/listinfo/wicket-user>---This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___Wicket-user mailing listWicket-user@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-10 Thread Johan Compagner

just committed it:FormComponentprotected Object convertValue(String value) throws ConversionException    {        return value != null?value.trim():null;    }so if you don't want trimming, override that method and return directly the value.
I think it is a better default.We could make a global property to switch it again, but personally i don't see many uses for that.johanOn 3/10/06, 
Ari Suutari <[EMAIL PROTECTED]> wrote:
To sum up discussion, I understood that trimming is goingto be default behaviour on text fields (soon) ? Correct ?Ari S.- Original Message -From: "Ari Suutari" <
[EMAIL PROTECTED]>To: <wicket-user@lists.sourceforge.net>Sent: Monday, March 06, 2006 3:25 PMSubject: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)
> Hi,>> What might be the simplest way to change behaviour of whole wicket application> so that TextField have their input trimmed of blanks at end ?>> I tried to do this via converters (I have my own converter factory),
> but it didn't work because Converter.convert doesn't do anything> if String is being assigned to String field in model (it uses isAssignableFrom> for this check).>>Ari S.>
>>>> ---> This SF.Net email is sponsored by xPML, a groundbreaking scripting language> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> ___> Wicket-user mailing list> Wicket-user@lists.sourceforge.net> 
https://lists.sourceforge.net/lists/listinfo/wicket-user>---This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___Wicket-user mailing listWicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-10 Thread Ari Suutari

To sum up discussion, I understood that trimming is going
to be default behaviour on text fields (soon) ? Correct ?

   Ari S.

- Original Message - 
From: "Ari Suutari" <[EMAIL PROTECTED]>

To: 
Sent: Monday, March 06, 2006 3:25 PM
Subject: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)

Hi,

What might be the simplest way to change behaviour of whole wicket application
so that TextField have their input trimmed of blanks at end ?

I tried to do this via converters (I have my own converter factory),
but it didn't work because Converter.convert doesn't do anything
if String is being assigned to String field in model (it uses isAssignableFrom
for this check).

   Ari S.

---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Igor Vaynberg

the only reason it didnt work for Ari was because he already created his application and only now is thinking about trimming.we say we trim all textfields by default, if you want to break out of it either override wherever needed or use a subclass.
i dont see why we need some global option for something as simple as this. maybe for backwards compat with older apps, in that case we can add an option, deprecate it, and remove it post 1.2 release.-Igor
On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
That works for single cases, just as it would have worked for singlecases for Ari. But whether you want to have trimming applied or not isalso a cross cutting concern.EelcoOn 3/9/06, Igor Vaynberg <
[EMAIL PROTECTED]> wrote:> then create a subclass and use that instead :)>> -Igor On 3/9/06, Eelco Hillenius <
[EMAIL PROTECTED] > wrote:> >> Of course. If you don't want all your textfields to trim your input by> default, but instead have the input applied to your models exactly as> it was provided, it is nice to be able to turn it off application
> wide.>> Eelco>> > Because does it make sense to globally set it off?> > why would you do that?>  ---
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language> that extends applications into web and mobile media. Attend the live webcast> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642> ___
> Wicket-user mailing list> Wicket-user@lists.sourceforge.net>  https://lists.sourceforge.net/lists/listinfo/wicket-user
>>---This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642
___Wicket-user mailing listWicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Eelco Hillenius

That works for single cases, just as it would have worked for single
cases for Ari. But whether you want to have trimming applied or not is
also a cross cutting concern.

Eelco

On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> then create a subclass and use that instead :)
>
> -Igor
>
>
>
> On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED] > wrote:
> >
> Of course. If you don't want all your textfields to trim your input by
> default, but instead have the input applied to your models exactly as
> it was provided, it is nice to be able to turn it off application
> wide.
>
> Eelco
>
> > Because does it make sense to globally set it off?
> > why would you do that?
> >
>
>
> ---
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642
> ___
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
>  https://lists.sourceforge.net/lists/listinfo/wicket-user
>
>


---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Johan Compagner

when do you want that?I think 99% of all the text fields don't want trailing or leading spaces.So you can make it an options but then suddenly you have to do it the other way aroundif you do want trimming.
But we can make it an option, i don't mind, i just think it is not really needed as an option.johanOn 3/9/06, Eelco Hillenius <
[EMAIL PROTECTED]> wrote:Of course. If you don't want all your textfields to trim your input by
default, but instead have the input applied to your models exactly asit was provided, it is nice to be able to turn it off applicationwide.Eelco> Because does it make sense to globally set it off?
> why would you do that?>---This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642
___Wicket-user mailing listWicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Igor Vaynberg

then create a subclass and use that instead :)-IgorOn 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]
> wrote:Of course. If you don't want all your textfields to trim your input by
default, but instead have the input applied to your models exactly asit was provided, it is nice to be able to turn it off applicationwide.Eelco> Because does it make sense to globally set it off?
> why would you do that?>---This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642
___Wicket-user mailing listWicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Eelco Hillenius

Of course. If you don't want all your textfields to trim your input by
default, but instead have the input applied to your models exactly as
it was provided, it is nice to be able to turn it off application
wide.

Eelco

> Because does it make sense to globally set it off?
> why would you do that?
>


---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Ryan Sonnek

what about trimming leading spaces as well (by default)?

On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> But it has to be something that can be turned off (and on), not only
> at a component level, but also with an application property.
>
> Eelco
>
> On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > that is what i want also. i think a better default is to always trim.
> >
> > -Igor
> >
> >
> >
> > On 3/9/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> > >
> > > we could trim the input by default when we convert the text
> > > So the right method now would be:
> > >
> > > protected Object convertValue(String value) throws ConversionException
> > > {
> > > return value;
> > > }
> > >
> > > i can make it this:
> > >
> > > protected Object convertValue(String value) throws ConversionException
> > > {
> > > return value.trim();
> > > }
> > >
> > > then all string values are trimmed by default. in the convert phase.
> > >
> > > If people don't want that then they can override converValue again.
> > >
> > > So would it be a better default?
> > > When would we have a case that trailing or leading spaces are required?
> > >
> > >
> > >
> > > johan
> > >
> > >
> > >
> > > On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > > > Nah, we don't need a delegate. Making it non-final would work well
> > > > enough wouldn't it.
> > > >
> > > > Furthermore, I now agree with Igor and Jonathan (and Johan?) that
> > > > trimming is something we should build in text components by default.
> > > >
> > > > Eelco
> > > >
> > > >
> > > > On 3/9/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> > > > > We could make it non final or make a delegate.
> > > > >
> > > > > class MyConverter implements IConverter
> > > > > {
> > > > >IConverter delegate = new Converter();
> > > > >
> > > > >convert(Object value, Class clss)
> > > > >{
> > > > >if(value instanceof String and clss == String.class)
> > > > >{
> > > > >     return value.trim();
> > > > >    }
> > > > >else
> > > > >{
> > > > >return delegate.convert(value,clss);
> > > > >
> > > > >}
> > > > >}
> > > > > }
> > > > >
> > > > > On 3/9/06, Ari Suutari < [EMAIL PROTECTED]> wrote:
> > > > > > Could you make Converter not final, so I could subclass it and
> > override
> > > > > convert ?
> > > > > >
> > > > > > Ari S.
> > > > > >
> > > > > > - Original Message -
> > > > > > From: "Eelco Hillenius" <[EMAIL PROTECTED] >
> > > > > > To: < wicket-user@lists.sourceforge.net >
> > > > > > Sent: Thursday, March 09, 2006 10:58 AM
> > > > > > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
> > maybe
> > > > > at beginning)
> > > > > >
> > > > > >
> > > > > > > Another thing you can do is copy 'n paste Converter, make your
> > > > > > > adjustement, and use that as the application wide converter. I
> > think
> > > > > > > everyone is happy then, and I don't think it is a class that'll
> > change
> > > > > > > often if ever.
> > > > > > >
> > > > > > > Eelco
> > > > > > >
> > > > > > >
> > > > > > > On 3/9/06, Ari Suutari < [EMAIL PROTECTED]> wrote:
> > > > > > >> Whats the risk here ? The default StringConverter in wicket does
> > > > > nothing
> > > > > > >> when invoked for String-String conversion.
> > > > > > >>
> > > > > > >> Ari S.
> > > > > > >>
> > > > > > >> - Original Message -
> > > > > > >> From: "Igor Vaynberg" < [EMAIL PROTECTED]>

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Eelco Hillenius

But it has to be something that can be turned off (and on), not only
at a component level, but also with an application property.

Eelco

On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> that is what i want also. i think a better default is to always trim.
>
> -Igor
>
>
>
> On 3/9/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> >
> > we could trim the input by default when we convert the text
> > So the right method now would be:
> >
> > protected Object convertValue(String value) throws ConversionException
> > {
> > return value;
> > }
> >
> > i can make it this:
> >
> > protected Object convertValue(String value) throws ConversionException
> > {
> > return value.trim();
> > }
> >
> > then all string values are trimmed by default. in the convert phase.
> >
> > If people don't want that then they can override converValue again.
> >
> > So would it be a better default?
> > When would we have a case that trailing or leading spaces are required?
> >
> >
> >
> > johan
> >
> >
> >
> > On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > > Nah, we don't need a delegate. Making it non-final would work well
> > > enough wouldn't it.
> > >
> > > Furthermore, I now agree with Igor and Jonathan (and Johan?) that
> > > trimming is something we should build in text components by default.
> > >
> > > Eelco
> > >
> > >
> > > On 3/9/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> > > > We could make it non final or make a delegate.
> > > >
> > > > class MyConverter implements IConverter
> > > > {
> > > >IConverter delegate = new Converter();
> > > >
> > > >convert(Object value, Class clss)
> > > >{
> > > >if(value instanceof String and clss == String.class)
> > > >{
> > > > return value.trim();
> > > >}
> > > >else
> > > >{
> > > >return delegate.convert(value,clss);
> > > >
> > > >    }
> > > >}
> > > > }
> > > >
> > > > On 3/9/06, Ari Suutari < [EMAIL PROTECTED]> wrote:
> > > > > Could you make Converter not final, so I could subclass it and
> override
> > > > convert ?
> > > > >
> > > > > Ari S.
> > > > >
> > > > > - Original Message -
> > > > > From: "Eelco Hillenius" <[EMAIL PROTECTED] >
> > > > > To: < wicket-user@lists.sourceforge.net >
> > > > > Sent: Thursday, March 09, 2006 10:58 AM
> > > > > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
> maybe
> > > > at beginning)
> > > > >
> > > > >
> > > > > > Another thing you can do is copy 'n paste Converter, make your
> > > > > > adjustement, and use that as the application wide converter. I
> think
> > > > > > everyone is happy then, and I don't think it is a class that'll
> change
> > > > > > often if ever.
> > > > > >
> > > > > > Eelco
> > > > > >
> > > > > >
> > > > > > On 3/9/06, Ari Suutari < [EMAIL PROTECTED]> wrote:
> > > > > >> Whats the risk here ? The default StringConverter in wicket does
> > > > nothing
> > > > > >> when invoked for String-String conversion.
> > > > > >>
> > > > > >> Ari S.
> > > > > >>
> > > > > >> - Original Message -
> > > > > >> From: "Igor Vaynberg" < [EMAIL PROTECTED]>
> > > > > >> To: < wicket-user@lists.sourceforge.net>
> > > > > >> Sent: Thursday, March 09, 2006 10:42 AM
> > > > > >> Subject: Re: [Wicket-user] TextField and trimming blanks at end
> (and
> > > > maybe at beginning)
> > > > > >>
> > > > > >>
> > > > > >> this is not a kind of a problem i would want to be tracing for,
> > > > especially
> > > > > >> as a user. you add your own string converter and that suddenly
> breaks
> > > > some
> > >

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Eelco Hillenius

Nah, we don't need a delegate. Making it non-final would work well
enough wouldn't it.

Furthermore, I now agree with Igor and Jonathan (and Johan?) that
trimming is something we should build in text components by default.

Eelco


On 3/9/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> We could make it non final or make a delegate.
>
> class MyConverter implements IConverter
> {
>IConverter delegate = new Converter();
>
>convert(Object value, Class clss)
>{
>if(value instanceof String and clss == String.class)
>{
> return value.trim();
>}
>else
>{
>return delegate.convert(value,clss);
>
>}
>}
> }
>
> On 3/9/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > Could you make Converter not final, so I could subclass it and override
> convert ?
> >
> > Ari S.
> >
> > - Original Message -
> > From: "Eelco Hillenius" <[EMAIL PROTECTED] >
> > To: 
> > Sent: Thursday, March 09, 2006 10:58 AM
> > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
> at beginning)
> >
> >
> > > Another thing you can do is copy 'n paste Converter, make your
> > > adjustement, and use that as the application wide converter. I think
> > > everyone is happy then, and I don't think it is a class that'll change
> > > often if ever.
> > >
> > > Eelco
> > >
> > >
> > > On 3/9/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > >> Whats the risk here ? The default StringConverter in wicket does
> nothing
> > >> when invoked for String-String conversion.
> > >>
> > >> Ari S.
> > >>
> > >> - Original Message -
> > >> From: "Igor Vaynberg" < [EMAIL PROTECTED]>
> > >> To: 
> > >> Sent: Thursday, March 09, 2006 10:42 AM
> > >> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
> maybe at beginning)
> > >>
> > >>
> > >> this is not a kind of a problem i would want to be tracing for,
> especially
> > >> as a user. you add your own string converter and that suddenly breaks
> some
> > >> internal feature that you dont even know about, or maybe it even breaks
> some
> > >> 3rd party components.
> > >>
> > >> i know i feel strongly about this one. how strong do you feel? should
> we
> > >> have a vote?
> > >>
> > >> -Igor
> > >>
> > >>
> > >> On 3/9/06, Eelco Hillenius < [EMAIL PROTECTED]> wrote:
> > >> >
> > >> > It's potentially dangerous, second that. But the argument of whether
> > >> > it is a good use of converters or not aside, when I put on my user
> hat
> > >> > and look at that API, *I* would expect conversion to happen from
> input
> > >> > parameters to my model properties regardless whether it has the
> target
> > >> > type or not.
> > >> >
> > >> > Eelco
> > >> >
> > >> >
> > >> > On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > >> > > this might have nasty side effects that we do not see right now.
> for
> > >> > example
> > >> > > converters are going to start running on things they werent running
> on
> > >> > > before. how is this going to affect existing applications?
> > >> > >
> > >> > > furthermore afaict the intention behind converters was to have a
> generic
> > >> > > /type/ conversion framework for use inside wicket core. you can see
> they
> > >> > are
> > >> > > intended to be /type/ converters by looking at the javadoc of
> > >> > > IConverter.convert(Object, Class). how is a trimming string
> converter
> > >> > that
> > >> > > is running on values that are already strings and trimming them
> going to
> > >> > > affect places in wicket's core outside form processing?
> > >> > >
> > >> > > i still dont think this is the right approach. we should think of
> > >> > something
> > >> > > else.
> > >> > >
> > >> > >
> > >> > > > getInput would be fine if we were just starting development. But
> we
> > >> > have a
> >

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Ari Suutari


This is a great idea ! Thanks !

   Ari S.

- Original Message - 
From: "Johan Compagner" <[EMAIL PROTECTED]>

To: 
Sent: Thursday, March 09, 2006 12:29 PM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)


We could make it non final or make a delegate.

class MyConverter implements IConverter
{
  IConverter delegate = new Converter();

  convert(Object value, Class clss)
  {
  if(value instanceof String and clss == String.class)
  {
   return value.trim();
  }
  else
  {
  return delegate.convert(value,clss);
  }
  }
}

On 3/9/06, Ari Suutari <[EMAIL PROTECTED]> wrote:


Could you make Converter not final, so I could subclass it and override
convert ?

Ari S.

- Original Message -
From: "Eelco Hillenius" <[EMAIL PROTECTED]>
To: 
Sent: Thursday, March 09, 2006 10:58 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
at beginning)


> Another thing you can do is copy 'n paste Converter, make your
> adjustement, and use that as the application wide converter. I think
> everyone is happy then, and I don't think it is a class that'll change
> often if ever.
>
> Eelco
>
>
> On 3/9/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
>> Whats the risk here ? The default StringConverter in wicket does
nothing
>> when invoked for String-String conversion.
>>
>> Ari S.
>>
>> - Original Message -----
>> From: "Igor Vaynberg" <[EMAIL PROTECTED]>
>> To: 
>> Sent: Thursday, March 09, 2006 10:42 AM
>> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
maybe at beginning)
>>
>>
>> this is not a kind of a problem i would want to be tracing for,
especially
>> as a user. you add your own string converter and that suddenly breaks
some
>> internal feature that you dont even know about, or maybe it even breaks
some
>> 3rd party components.
>>
>> i know i feel strongly about this one. how strong do you feel? should
we
>> have a vote?
>>
>> -Igor
>>
>>
>> On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
>> >
>> > It's potentially dangerous, second that. But the argument of whether
>> > it is a good use of converters or not aside, when I put on my user
hat
>> > and look at that API, *I* would expect conversion to happen from
input
>> > parameters to my model properties regardless whether it has the
target
>> > type or not.
>> >
>> > Eelco
>> >
>> >
>> > On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
>> > > this might have nasty side effects that we do not see right now.
for
>> > example
>> > > converters are going to start running on things they werent running
on
>> > > before. how is this going to affect existing applications?
>> > >
>> > > furthermore afaict the intention behind converters was to have a
generic
>> > > /type/ conversion framework for use inside wicket core. you can see
they
>> > are
>> > > intended to be /type/ converters by looking at the javadoc of
>> > > IConverter.convert(Object, Class). how is a trimming string
converter
>> > that
>> > > is running on values that are already strings and trimming them
going to
>> > > affect places in wicket's core outside form processing?
>> > >
>> > > i still dont think this is the right approach. we should think of
>> > something
>> > > else.
>> > >
>> > >
>> > > > getInput would be fine if we were just starting development. But
we
>> > have a
>> > > big
>> > > > application going to production soon and I'm seeking some kind of
>> > another
>> > > alternative
>> > > > than telling all developers to change their TextFields to
>> > > MyTrimmerTextFields.
>> > > so why are you just now thinking about this? sounds to me like you
are
>> > > dealing with this issue too late. (not that we are not willing to
help
>> > you)
>> > >
>> > > -Igor
>> > >
>> > >
>> > >
>> > > On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
>> > > >
>> > >  I agree with Ari and I am not against removing that check.
>> > >
>> > > Eelco
>> > >
>> > >
>> > > On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
>> > > > Hi,
>> > > >
>> > &

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Ari Suutari


Could you make Converter not final, so I could subclass it and override convert 
?

   Ari S.

- Original Message - 
From: "Eelco Hillenius" <[EMAIL PROTECTED]>

To: 
Sent: Thursday, March 09, 2006 10:58 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)



Another thing you can do is copy 'n paste Converter, make your
adjustement, and use that as the application wide converter. I think
everyone is happy then, and I don't think it is a class that'll change
often if ever.

Eelco


On 3/9/06, Ari Suutari <[EMAIL PROTECTED]> wrote:

Whats the risk here ? The default StringConverter in wicket does nothing
when invoked for String-String conversion.

Ari S.

- Original Message -
From: "Igor Vaynberg" <[EMAIL PROTECTED]>
To: 
Sent: Thursday, March 09, 2006 10:42 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)


this is not a kind of a problem i would want to be tracing for, especially
as a user. you add your own string converter and that suddenly breaks some
internal feature that you dont even know about, or maybe it even breaks some
3rd party components.

i know i feel strongly about this one. how strong do you feel? should we
have a vote?

-Igor


On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
>
> It's potentially dangerous, second that. But the argument of whether
> it is a good use of converters or not aside, when I put on my user hat
> and look at that API, *I* would expect conversion to happen from input
> parameters to my model properties regardless whether it has the target
> type or not.
>
> Eelco
>
>
> On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > this might have nasty side effects that we do not see right now. for
> example
> > converters are going to start running on things they werent running on
> > before. how is this going to affect existing applications?
> >
> > furthermore afaict the intention behind converters was to have a generic
> > /type/ conversion framework for use inside wicket core. you can see they
> are
> > intended to be /type/ converters by looking at the javadoc of
> > IConverter.convert(Object, Class). how is a trimming string converter
> that
> > is running on values that are already strings and trimming them going to
> > affect places in wicket's core outside form processing?
> >
> > i still dont think this is the right approach. we should think of
> something
> > else.
> >
> >
> > > getInput would be fine if we were just starting development. But we
> have a
> > big
> > > application going to production soon and I'm seeking some kind of
> another
> > alternative
> > > than telling all developers to change their TextFields to
> > MyTrimmerTextFields.
> > so why are you just now thinking about this? sounds to me like you are
> > dealing with this issue too late. (not that we are not willing to help
> you)
> >
> > -Igor
> >
> >
> >
> > On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > >
> >  I agree with Ari and I am not against removing that check.
> >
> > Eelco
> >
> >
> > On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > > Hi,
> > >
> >  > getInput would be fine if we were just starting development. But we
> have
> > a big
> > > application going to production soon and I'm seeking some kind of
> another
> > alternative
> > > than telling all developers to change their TextFields to
> > MyTrimmerTextFields.
> > > Converter interface has been very handy for me before, but it just
> failed
> > on this one.
> > >
> > > Why should you think Converter only as datatype converter ? I'm sure
> that
> > > there are plenty of use cases where manipulating also the value would
> be
> > handy.
> > > Also, I don't think that removing the short-circuit done by
> > isAssignableFrom
> > > woundn't be a performace problem ?
> > >
> > > What I have liked about wicket a lot is that there are a lot of
> different
> > interfaces
> > > that one can use to get between things and alter the behaviour for
> local
> > needs
> > > without creating a derived component of each standard component. This
> is
> > also
> > > the reason I'm insisting about similar solution here.
> > >
> > > Ari S.
> > >
> > > - Original Message -
> > > From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> > > To:

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Ari Suutari


This was also one idea that I considered. However, as it is more than just a
one or two lines of code I decided to start this discussion in order to find
a more elegant way.

If you think about real-world applications, I would say that on-one
wants to sit anwering support calls about odd incidents that occur
because user's fields has some invisible spaces after value. I have been
involved with form-based applications in several companies, for many
years and always the policy has been to trim trailing blanks from fields.
Otherwise the users will just get confused.

   Ari S.

- Original Message - 
From: "Eelco Hillenius" <[EMAIL PROTECTED]>

To: 
Sent: Thursday, March 09, 2006 10:58 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)



Another thing you can do is copy 'n paste Converter, make your
adjustement, and use that as the application wide converter. I think
everyone is happy then, and I don't think it is a class that'll change
often if ever.

Eelco


On 3/9/06, Ari Suutari <[EMAIL PROTECTED]> wrote:

Whats the risk here ? The default StringConverter in wicket does nothing
when invoked for String-String conversion.

Ari S.

- Original Message -
From: "Igor Vaynberg" <[EMAIL PROTECTED]>
To: 
Sent: Thursday, March 09, 2006 10:42 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)


this is not a kind of a problem i would want to be tracing for, especially
as a user. you add your own string converter and that suddenly breaks some
internal feature that you dont even know about, or maybe it even breaks some
3rd party components.

i know i feel strongly about this one. how strong do you feel? should we
have a vote?

-Igor


On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
>
> It's potentially dangerous, second that. But the argument of whether
> it is a good use of converters or not aside, when I put on my user hat
> and look at that API, *I* would expect conversion to happen from input
> parameters to my model properties regardless whether it has the target
> type or not.
>
> Eelco
>
>
> On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > this might have nasty side effects that we do not see right now. for
> example
> > converters are going to start running on things they werent running on
> > before. how is this going to affect existing applications?
> >
> > furthermore afaict the intention behind converters was to have a generic
> > /type/ conversion framework for use inside wicket core. you can see they
> are
> > intended to be /type/ converters by looking at the javadoc of
> > IConverter.convert(Object, Class). how is a trimming string converter
> that
> > is running on values that are already strings and trimming them going to
> > affect places in wicket's core outside form processing?
> >
> > i still dont think this is the right approach. we should think of
> something
> > else.
> >
> >
> > > getInput would be fine if we were just starting development. But we
> have a
> > big
> > > application going to production soon and I'm seeking some kind of
> another
> > alternative
> > > than telling all developers to change their TextFields to
> > MyTrimmerTextFields.
> > so why are you just now thinking about this? sounds to me like you are
> > dealing with this issue too late. (not that we are not willing to help
> you)
> >
> > -Igor
> >
> >
> >
> > On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > >
> >  I agree with Ari and I am not against removing that check.
> >
> > Eelco
> >
> >
> > On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > > Hi,
> > >
> >  > getInput would be fine if we were just starting development. But we
> have
> > a big
> > > application going to production soon and I'm seeking some kind of
> another
> > alternative
> > > than telling all developers to change their TextFields to
> > MyTrimmerTextFields.
> > > Converter interface has been very handy for me before, but it just
> failed
> > on this one.
> > >
> > > Why should you think Converter only as datatype converter ? I'm sure
> that
> > > there are plenty of use cases where manipulating also the value would
> be
> > handy.
> > > Also, I don't think that removing the short-circuit done by
> > isAssignableFrom
> > > woundn't be a performace problem ?
> > >
> > > What I have liked about wicket a lot is that there are a lot of
> different
> > int

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Eelco Hillenius

Another thing you can do is copy 'n paste Converter, make your
adjustement, and use that as the application wide converter. I think
everyone is happy then, and I don't think it is a class that'll change
often if ever.

Eelco


On 3/9/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> Whats the risk here ? The default StringConverter in wicket does nothing
> when invoked for String-String conversion.
>
> Ari S.
>
> - Original Message -
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> To: 
> Sent: Thursday, March 09, 2006 10:42 AM
> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
> beginning)
>
>
> this is not a kind of a problem i would want to be tracing for, especially
> as a user. you add your own string converter and that suddenly breaks some
> internal feature that you dont even know about, or maybe it even breaks some
> 3rd party components.
>
> i know i feel strongly about this one. how strong do you feel? should we
> have a vote?
>
> -Igor
>
>
> On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> >
> > It's potentially dangerous, second that. But the argument of whether
> > it is a good use of converters or not aside, when I put on my user hat
> > and look at that API, *I* would expect conversion to happen from input
> > parameters to my model properties regardless whether it has the target
> > type or not.
> >
> > Eelco
> >
> >
> > On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > > this might have nasty side effects that we do not see right now. for
> > example
> > > converters are going to start running on things they werent running on
> > > before. how is this going to affect existing applications?
> > >
> > > furthermore afaict the intention behind converters was to have a generic
> > > /type/ conversion framework for use inside wicket core. you can see they
> > are
> > > intended to be /type/ converters by looking at the javadoc of
> > > IConverter.convert(Object, Class). how is a trimming string converter
> > that
> > > is running on values that are already strings and trimming them going to
> > > affect places in wicket's core outside form processing?
> > >
> > > i still dont think this is the right approach. we should think of
> > something
> > > else.
> > >
> > >
> > > > getInput would be fine if we were just starting development. But we
> > have a
> > > big
> > > > application going to production soon and I'm seeking some kind of
> > another
> > > alternative
> > > > than telling all developers to change their TextFields to
> > > MyTrimmerTextFields.
> > > so why are you just now thinking about this? sounds to me like you are
> > > dealing with this issue too late. (not that we are not willing to help
> > you)
> > >
> > > -Igor
> > >
> > >
> > >
> > > On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > > >
> > >  I agree with Ari and I am not against removing that check.
> > >
> > > Eelco
> > >
> > >
> > > On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > > > Hi,
> > > >
> > >  > getInput would be fine if we were just starting development. But we
> > have
> > > a big
> > > > application going to production soon and I'm seeking some kind of
> > another
> > > alternative
> > > > than telling all developers to change their TextFields to
> > > MyTrimmerTextFields.
> > > > Converter interface has been very handy for me before, but it just
> > failed
> > > on this one.
> > > >
> > > > Why should you think Converter only as datatype converter ? I'm sure
> > that
> > > > there are plenty of use cases where manipulating also the value would
> > be
> > > handy.
> > > > Also, I don't think that removing the short-circuit done by
> > > isAssignableFrom
> > > > woundn't be a performace problem ?
> > > >
> > > > What I have liked about wicket a lot is that there are a lot of
> > different
> > > interfaces
> > > > that one can use to get between things and alter the behaviour for
> > local
> > > needs
> > > > without creating a derived component of each standard component. This
> > is
> > > also
> > > > the reason I'm insisti

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Ari Suutari


Whats the risk here ? The default StringConverter in wicket does nothing
when invoked for String-String conversion.

   Ari S.

- Original Message - 
From: "Igor Vaynberg" <[EMAIL PROTECTED]>

To: 
Sent: Thursday, March 09, 2006 10:42 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)


this is not a kind of a problem i would want to be tracing for, especially
as a user. you add your own string converter and that suddenly breaks some
internal feature that you dont even know about, or maybe it even breaks some
3rd party components.

i know i feel strongly about this one. how strong do you feel? should we
have a vote?

-Igor


On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:


It's potentially dangerous, second that. But the argument of whether
it is a good use of converters or not aside, when I put on my user hat
and look at that API, *I* would expect conversion to happen from input
parameters to my model properties regardless whether it has the target
type or not.

Eelco


On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> this might have nasty side effects that we do not see right now. for
example
> converters are going to start running on things they werent running on
> before. how is this going to affect existing applications?
>
> furthermore afaict the intention behind converters was to have a generic
> /type/ conversion framework for use inside wicket core. you can see they
are
> intended to be /type/ converters by looking at the javadoc of
> IConverter.convert(Object, Class). how is a trimming string converter
that
> is running on values that are already strings and trimming them going to
> affect places in wicket's core outside form processing?
>
> i still dont think this is the right approach. we should think of
something
> else.
>
>
> > getInput would be fine if we were just starting development. But we
have a
> big
> > application going to production soon and I'm seeking some kind of
another
> alternative
> > than telling all developers to change their TextFields to
> MyTrimmerTextFields.
> so why are you just now thinking about this? sounds to me like you are
> dealing with this issue too late. (not that we are not willing to help
you)
>
> -Igor
>
>
>
> On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> >
>  I agree with Ari and I am not against removing that check.
>
> Eelco
>
>
> On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
>  > getInput would be fine if we were just starting development. But we
have
> a big
> > application going to production soon and I'm seeking some kind of
another
> alternative
> > than telling all developers to change their TextFields to
> MyTrimmerTextFields.
> > Converter interface has been very handy for me before, but it just
failed
> on this one.
> >
> > Why should you think Converter only as datatype converter ? I'm sure
that
> > there are plenty of use cases where manipulating also the value would
be
> handy.
> > Also, I don't think that removing the short-circuit done by
> isAssignableFrom
> > woundn't be a performace problem ?
> >
> > What I have liked about wicket a lot is that there are a lot of
different
> interfaces
> > that one can use to get between things and alter the behaviour for
local
> needs
> > without creating a derived component of each standard component. This
is
> also
> > the reason I'm insisting about similar solution here.
> >
> > Ari S.
> >
> > - Original Message -
> > From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> > To: < wicket-user@lists.sourceforge.net>
> > Sent: Wednesday, March 08, 2006 9:23 AM
> > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
maybe
> at beginning)
> >
> >
> > but is it really then a conversion? why run a Integer->Integer
conversion
> or
> > a String->String conversion? then you are really warping the converter
> into
> > an input postprocessor. why not create a simple subclass of textfield
and
> > override getInput() ?
> >
> > -Igor
> >
> >
> > On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > >
> > > Could someone also take a look at Converter so it could be used ?
> > > I mean this line in Converter.java:
> > >
> > > // Catch all cases where value is already the right type
> > > if (c.isAssignableFrom(value.getClass()))
> > > {
> > >     return value;
> > > }
> > >
> > > This is some kind of a optimization, right ? But as a side effe

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Ari Suutari


AOP would be one solution, but haven't needed it so far with wicket, because
there have always been elegant interfaces that I have been able to use to
make things work like we want. That wouldn't be wicket's way of doing things,
would it ?

   Ari S.

- Original Message - 
From: "Eelco Hillenius" <[EMAIL PROTECTED]>

To: 
Sent: Thursday, March 09, 2006 10:27 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)



Ari, what about using AOP?

Eelco

On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:

It's potentially dangerous, second that. But the argument of whether
it is a good use of converters or not aside, when I put on my user hat
and look at that API, *I* would expect conversion to happen from input
parameters to my model properties regardless whether it has the target
type or not.

Eelco


On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> this might have nasty side effects that we do not see right now. for example
> converters are going to start running on things they werent running on
> before. how is this going to affect existing applications?
>
> furthermore afaict the intention behind converters was to have a generic
> /type/ conversion framework for use inside wicket core. you can see they are
> intended to be /type/ converters by looking at the javadoc of
> IConverter.convert(Object, Class). how is a trimming string converter that
> is running on values that are already strings and trimming them going to
> affect places in wicket's core outside form processing?
>
> i still dont think this is the right approach. we should think of something
> else.
>
>
> > getInput would be fine if we were just starting development. But we have a
> big
> > application going to production soon and I'm seeking some kind of another
> alternative
> > than telling all developers to change their TextFields to
> MyTrimmerTextFields.
> so why are you just now thinking about this? sounds to me like you are
> dealing with this issue too late. (not that we are not willing to help you)
>
> -Igor
>
>
>
> On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> >
>  I agree with Ari and I am not against removing that check.
>
> Eelco
>
>
> On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
>  > getInput would be fine if we were just starting development. But we have
> a big
> > application going to production soon and I'm seeking some kind of another
> alternative
> > than telling all developers to change their TextFields to
> MyTrimmerTextFields.
> > Converter interface has been very handy for me before, but it just failed
> on this one.
> >
> > Why should you think Converter only as datatype converter ? I'm sure that
> > there are plenty of use cases where manipulating also the value would be
> handy.
> > Also, I don't think that removing the short-circuit done by
> isAssignableFrom
> > woundn't be a performace problem ?
> >
> > What I have liked about wicket a lot is that there are a lot of different
> interfaces
> > that one can use to get between things and alter the behaviour for local
> needs
> > without creating a derived component of each standard component. This is
> also
> > the reason I'm insisting about similar solution here.
> >
> > Ari S.
> >
> > - Original Message -
> > From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> > To: < wicket-user@lists.sourceforge.net>
> > Sent: Wednesday, March 08, 2006 9:23 AM
> > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
> at beginning)
> >
> >
> > but is it really then a conversion? why run a Integer->Integer conversion
> or
> > a String->String conversion? then you are really warping the converter
> into
> > an input postprocessor. why not create a simple subclass of textfield and
> > override getInput() ?
> >
> > -Igor
> >
> >
> > On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > >
> > > Could someone also take a look at Converter so it could be used ?
> > > I mean this line in Converter.java:
> > >
> > > // Catch all cases where value is already the right type
> > > if (c.isAssignableFrom(value.getClass()))
> > > {
> > > return value;
> > > }
> > >
> > > This is some kind of a optimization, right ? But as a side effect
> > > it makes it impossible to do any conversion on textfield input
> > > if it is stored to String field in model (quite usual case, I thin

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Eelco Hillenius

I don't feel as strongly, so need to to vote here. It's been in there
a long time and it isn't really wrong either. So what other options
does Ari have - besides AOP.

On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> this is not a kind of a problem i would want to be tracing for, especially
> as a user. you add your own string converter and that suddenly breaks some
> internal feature that you dont even know about, or maybe it even breaks some
> 3rd party components.
>
> i know i feel strongly about this one. how strong do you feel? should we
> have a vote?
>
> -Igor
>
>
>
> On 3/9/06, Eelco Hillenius < [EMAIL PROTECTED]> wrote:
> >
> It's potentially dangerous, second that. But the argument of whether
> it is a good use of converters or not aside, when I put on my user hat
> and look at that API, *I* would expect conversion to happen from input
> parameters to my model properties regardless whether it has the target
> type or not.
>
> Eelco
>
>
> On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > this might have nasty side effects that we do not see right now. for
> example
> > converters are going to start running on things they werent running on
> > before. how is this going to affect existing applications?
> >
> > furthermore afaict the intention behind converters was to have a generic
> > /type/ conversion framework for use inside wicket core. you can see they
> are
> > intended to be /type/ converters by looking at the javadoc of
> > IConverter.convert(Object, Class). how is a trimming string converter that
> > is running on values that are already strings and trimming them going to
> > affect places in wicket's core outside form processing?
> >
> > i still dont think this is the right approach. we should think of
> something
> > else.
> >
> >
> > > getInput would be fine if we were just starting development. But we have
> a
> > big
> > > application going to production soon and I'm seeking some kind of
> another
>  > alternative
> > > than telling all developers to change their TextFields to
> > MyTrimmerTextFields.
> > so why are you just now thinking about this? sounds to me like you are
> > dealing with this issue too late. (not that we are not willing to help
> you)
> >
> > -Igor
> >
> >
> >
> > On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > >
> >  I agree with Ari and I am not against removing that check.
> >
> > Eelco
> >
> >
> > On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > > Hi,
> > >
> >  > getInput would be fine if we were just starting development. But we
> have
> > a big
> > > application going to production soon and I'm seeking some kind of
> another
> > alternative
> > > than telling all developers to change their TextFields to
> > MyTrimmerTextFields.
> > > Converter interface has been very handy for me before, but it just
> failed
> > on this one.
> > >
> > > Why should you think Converter only as datatype converter ? I'm sure
> that
> > > there are plenty of use cases where manipulating also the value would be
> > handy.
> > > Also, I don't think that removing the short-circuit done by
> > isAssignableFrom
> > > woundn't be a performace problem ?
> > >
> > > What I have liked about wicket a lot is that there are a lot of
> different
> > interfaces
> > > that one can use to get between things and alter the behaviour for local
> > needs
> > > without creating a derived component of each standard component. This is
> > also
>  > > the reason I'm insisting about similar solution here.
> > >
> > > Ari S.
> > >
> > > - Original Message -
> > > From: "Igor Vaynberg" < [EMAIL PROTECTED]>
> > > To: < wicket-user@lists.sourceforge.net>
> > > Sent: Wednesday, March 08, 2006 9:23 AM
> > > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
> maybe
> > at beginning)
> > >
> > >
> > > but is it really then a conversion? why run a Integer->Integer
> conversion
> > or
> > > a String->String conversion? then you are really warping the converter
> > into
> > > an input postprocessor. why not create a simple subclass of textfield
> and
> > > override getInput() ?
> > >
> > > -Igor
> > >
> > >
> > > On 3/7/06,

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Igor Vaynberg

this is not a kind of a problem i would want to be tracing for, especially as a user. you add your own string converter and that suddenly breaks some internal feature that you dont even know about, or maybe it even breaks some 3rd party components.
i know i feel strongly about this one. how strong do you feel? should we have a vote?-IgorOn 3/9/06, Eelco Hillenius <
[EMAIL PROTECTED]> wrote:It's potentially dangerous, second that. But the argument of whether
it is a good use of converters or not aside, when I put on my user hatand look at that API, *I* would expect conversion to happen from inputparameters to my model properties regardless whether it has the target
type or not.EelcoOn 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:> this might have nasty side effects that we do not see right now. for example
> converters are going to start running on things they werent running on> before. how is this going to affect existing applications?>> furthermore afaict the intention behind converters was to have a generic
> /type/ conversion framework for use inside wicket core. you can see they are> intended to be /type/ converters by looking at the javadoc of> IConverter.convert(Object, Class). how is a trimming string converter that
> is running on values that are already strings and trimming them going to> affect places in wicket's core outside form processing?>> i still dont think this is the right approach. we should think of something
> else.>>> > getInput would be fine if we were just starting development. But we have a> big> > application going to production soon and I'm seeking some kind of another
> alternative> > than telling all developers to change their TextFields to> MyTrimmerTextFields.> so why are you just now thinking about this? sounds to me like you are> dealing with this issue too late. (not that we are not willing to help you)
>> -Igor>>>> On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:> >>  I agree with Ari and I am not against removing that check.
>> Eelco>>> On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:> > Hi,> >>  > getInput would be fine if we were just starting development. But we have
> a big> > application going to production soon and I'm seeking some kind of another> alternative> > than telling all developers to change their TextFields to> MyTrimmerTextFields.
> > Converter interface has been very handy for me before, but it just failed> on this one.> >> > Why should you think Converter only as datatype converter ? I'm sure that> > there are plenty of use cases where manipulating also the value would be
> handy.> > Also, I don't think that removing the short-circuit done by> isAssignableFrom> > woundn't be a performace problem ?> >> > What I have liked about wicket a lot is that there are a lot of different
> interfaces> > that one can use to get between things and alter the behaviour for local> needs> > without creating a derived component of each standard component. This is> also
> > the reason I'm insisting about similar solution here.> >> > Ari S.> >> > - Original Message -> > From: "Igor Vaynberg" <
[EMAIL PROTECTED]>> > To: < wicket-user@lists.sourceforge.net>> > Sent: Wednesday, March 08, 2006 9:23 AM> > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
> at beginning)> >> >> > but is it really then a conversion? why run a Integer->Integer conversion> or> > a String->String conversion? then you are really warping the converter
> into> > an input postprocessor. why not create a simple subclass of textfield and> > override getInput() ?> >> > -Igor> >> >> > On 3/7/06, Ari Suutari <
[EMAIL PROTECTED]> wrote:> > >> > > Could someone also take a look at Converter so it could be used ?> > > I mean this line in 
Converter.java:> > >> > > // Catch all cases where value is already the right type> > > if (c.isAssignableFrom(value.getClass()))> > > {> > > return value;
> > > }> > >> > > This is some kind of a optimization, right ? But as a side effect> > > it makes it impossible to do any conversion on textfield input> > > if it is stored to String field in model (quite usual case, I think).
> > >> > > Maybe just drop those lines ?> > >> > > Ari S.> > >> > > - Original Message -> > > From: "Eelco Hillenius" < 
[EMAIL PROTECTED]>> > > To: <wicket-us

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Ari Suutari


Hi,

Yes. After all, the name is "Converter", not "TypeConverter".

   Ari S.

- Original Message - 
From: "Eelco Hillenius" <[EMAIL PROTECTED]>

To: 
Sent: Thursday, March 09, 2006 10:25 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)



It's potentially dangerous, second that. But the argument of whether
it is a good use of converters or not aside, when I put on my user hat
and look at that API, *I* would expect conversion to happen from input
parameters to my model properties regardless whether it has the target
type or not.

Eelco


On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:

this might have nasty side effects that we do not see right now. for example
converters are going to start running on things they werent running on
before. how is this going to affect existing applications?

furthermore afaict the intention behind converters was to have a generic
/type/ conversion framework for use inside wicket core. you can see they are
intended to be /type/ converters by looking at the javadoc of
IConverter.convert(Object, Class). how is a trimming string converter that
is running on values that are already strings and trimming them going to
affect places in wicket's core outside form processing?

i still dont think this is the right approach. we should think of something
else.


> getInput would be fine if we were just starting development. But we have a
big
> application going to production soon and I'm seeking some kind of another
alternative
> than telling all developers to change their TextFields to
MyTrimmerTextFields.
so why are you just now thinking about this? sounds to me like you are
dealing with this issue too late. (not that we are not willing to help you)

-Igor



On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
>
 I agree with Ari and I am not against removing that check.

Eelco


On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> Hi,
>
 > getInput would be fine if we were just starting development. But we have
a big
> application going to production soon and I'm seeking some kind of another
alternative
> than telling all developers to change their TextFields to
MyTrimmerTextFields.
> Converter interface has been very handy for me before, but it just failed
on this one.
>
> Why should you think Converter only as datatype converter ? I'm sure that
> there are plenty of use cases where manipulating also the value would be
handy.
> Also, I don't think that removing the short-circuit done by
isAssignableFrom
> woundn't be a performace problem ?
>
> What I have liked about wicket a lot is that there are a lot of different
interfaces
> that one can use to get between things and alter the behaviour for local
needs
> without creating a derived component of each standard component. This is
also
> the reason I'm insisting about similar solution here.
>
> Ari S.
>
> - Original Message -
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> To: < wicket-user@lists.sourceforge.net>
> Sent: Wednesday, March 08, 2006 9:23 AM
> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
at beginning)
>
>
> but is it really then a conversion? why run a Integer->Integer conversion
or
> a String->String conversion? then you are really warping the converter
into
> an input postprocessor. why not create a simple subclass of textfield and
> override getInput() ?
>
> -Igor
>
>
> On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> >
> > Could someone also take a look at Converter so it could be used ?
> > I mean this line in Converter.java:
> >
> > // Catch all cases where value is already the right type
> > if (c.isAssignableFrom(value.getClass()))
> > {
> > return value;
> > }
> >
> > This is some kind of a optimization, right ? But as a side effect
> > it makes it impossible to do any conversion on textfield input
> > if it is stored to String field in model (quite usual case, I think).
> >
> > Maybe just drop those lines ?
> >
> > Ari S.
> >
> > - Original Message -
> > From: "Eelco Hillenius" < [EMAIL PROTECTED]>
> > To: 
> > Sent: Tuesday, March 07, 2006 7:22 PM
> > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
maybe
> > at beginning)
> >
> >
> > >I don't think we need it in core. Maybe as an example somewhere. We
> > > have to get our users get used to working with custom components more,
> > > as that's one of the key points of Wicket imo :)
> > >
> > > Eelco
> > >
> > >
> > > On 3/7/06, Igor

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Eelco Hillenius

Ari, what about using AOP?

Eelco

On 3/9/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> It's potentially dangerous, second that. But the argument of whether
> it is a good use of converters or not aside, when I put on my user hat
> and look at that API, *I* would expect conversion to happen from input
> parameters to my model properties regardless whether it has the target
> type or not.
>
> Eelco
>
>
> On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > this might have nasty side effects that we do not see right now. for example
> > converters are going to start running on things they werent running on
> > before. how is this going to affect existing applications?
> >
> > furthermore afaict the intention behind converters was to have a generic
> > /type/ conversion framework for use inside wicket core. you can see they are
> > intended to be /type/ converters by looking at the javadoc of
> > IConverter.convert(Object, Class). how is a trimming string converter that
> > is running on values that are already strings and trimming them going to
> > affect places in wicket's core outside form processing?
> >
> > i still dont think this is the right approach. we should think of something
> > else.
> >
> >
> > > getInput would be fine if we were just starting development. But we have a
> > big
> > > application going to production soon and I'm seeking some kind of another
> > alternative
> > > than telling all developers to change their TextFields to
> > MyTrimmerTextFields.
> > so why are you just now thinking about this? sounds to me like you are
> > dealing with this issue too late. (not that we are not willing to help you)
> >
> > -Igor
> >
> >
> >
> > On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > >
> >  I agree with Ari and I am not against removing that check.
> >
> > Eelco
> >
> >
> > On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > > Hi,
> > >
> >  > getInput would be fine if we were just starting development. But we have
> > a big
> > > application going to production soon and I'm seeking some kind of another
> > alternative
> > > than telling all developers to change their TextFields to
> > MyTrimmerTextFields.
> > > Converter interface has been very handy for me before, but it just failed
> > on this one.
> > >
> > > Why should you think Converter only as datatype converter ? I'm sure that
> > > there are plenty of use cases where manipulating also the value would be
> > handy.
> > > Also, I don't think that removing the short-circuit done by
> > isAssignableFrom
> > > woundn't be a performace problem ?
> > >
> > > What I have liked about wicket a lot is that there are a lot of different
> > interfaces
> > > that one can use to get between things and alter the behaviour for local
> > needs
> > > without creating a derived component of each standard component. This is
> > also
> > > the reason I'm insisting about similar solution here.
> > >
> > > Ari S.
> > >
> > > - Original Message -
> > > From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> > > To: < wicket-user@lists.sourceforge.net>
> > > Sent: Wednesday, March 08, 2006 9:23 AM
> > > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
> > at beginning)
> > >
> > >
> > > but is it really then a conversion? why run a Integer->Integer conversion
> > or
> > > a String->String conversion? then you are really warping the converter
> > into
> > > an input postprocessor. why not create a simple subclass of textfield and
> > > override getInput() ?
> > >
> > > -Igor
> > >
> > >
> > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > > >
> > > > Could someone also take a look at Converter so it could be used ?
> > > > I mean this line in Converter.java:
> > > >
> > > > // Catch all cases where value is already the right type
> > > > if (c.isAssignableFrom(value.getClass()))
> > > > {
> > > > return value;
> > > > }
> > > >
> > > > This is some kind of a optimization, right ? But as a side effect
> > > > it makes it impossible to do any conversion on textfield input
> > > > if it is stored to String field in model (qu

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Eelco Hillenius

It's potentially dangerous, second that. But the argument of whether
it is a good use of converters or not aside, when I put on my user hat
and look at that API, *I* would expect conversion to happen from input
parameters to my model properties regardless whether it has the target
type or not.

Eelco


On 3/9/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> this might have nasty side effects that we do not see right now. for example
> converters are going to start running on things they werent running on
> before. how is this going to affect existing applications?
>
> furthermore afaict the intention behind converters was to have a generic
> /type/ conversion framework for use inside wicket core. you can see they are
> intended to be /type/ converters by looking at the javadoc of
> IConverter.convert(Object, Class). how is a trimming string converter that
> is running on values that are already strings and trimming them going to
> affect places in wicket's core outside form processing?
>
> i still dont think this is the right approach. we should think of something
> else.
>
>
> > getInput would be fine if we were just starting development. But we have a
> big
> > application going to production soon and I'm seeking some kind of another
> alternative
> > than telling all developers to change their TextFields to
> MyTrimmerTextFields.
> so why are you just now thinking about this? sounds to me like you are
> dealing with this issue too late. (not that we are not willing to help you)
>
> -Igor
>
>
>
> On 3/8/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> >
>  I agree with Ari and I am not against removing that check.
>
> Eelco
>
>
> On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > Hi,
> >
>  > getInput would be fine if we were just starting development. But we have
> a big
> > application going to production soon and I'm seeking some kind of another
> alternative
> > than telling all developers to change their TextFields to
> MyTrimmerTextFields.
> > Converter interface has been very handy for me before, but it just failed
> on this one.
> >
> > Why should you think Converter only as datatype converter ? I'm sure that
> > there are plenty of use cases where manipulating also the value would be
> handy.
> > Also, I don't think that removing the short-circuit done by
> isAssignableFrom
> > woundn't be a performace problem ?
> >
> > What I have liked about wicket a lot is that there are a lot of different
> interfaces
> > that one can use to get between things and alter the behaviour for local
> needs
> > without creating a derived component of each standard component. This is
> also
> > the reason I'm insisting about similar solution here.
> >
> > Ari S.
> >
> > - Original Message -
> > From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> > To: < wicket-user@lists.sourceforge.net>
> > Sent: Wednesday, March 08, 2006 9:23 AM
> > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
> at beginning)
> >
> >
> > but is it really then a conversion? why run a Integer->Integer conversion
> or
> > a String->String conversion? then you are really warping the converter
> into
> > an input postprocessor. why not create a simple subclass of textfield and
> > override getInput() ?
> >
> > -Igor
> >
> >
> > On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> > >
> > > Could someone also take a look at Converter so it could be used ?
> > > I mean this line in Converter.java:
> > >
> > > // Catch all cases where value is already the right type
> > > if (c.isAssignableFrom(value.getClass()))
> > > {
> > >     return value;
> > > }
> > >
> > > This is some kind of a optimization, right ? But as a side effect
> > > it makes it impossible to do any conversion on textfield input
> > > if it is stored to String field in model (quite usual case, I think).
> > >
> > > Maybe just drop those lines ?
> > >
> > > Ari S.
> > >
> > > - Original Message -
> > > From: "Eelco Hillenius" < [EMAIL PROTECTED]>
> > > To: 
> > > Sent: Tuesday, March 07, 2006 7:22 PM
> > > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
> maybe
> > > at beginning)
> > >
> > >
> > > >I don't think we need it in core. Maybe as an example somewhere. We
> > > > have to get our

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-09 Thread Igor Vaynberg

this might have nasty side effects that we do not see right now. for example converters are going to start running on things they werent running on before. how is this going to affect existing applications?furthermore afaict the intention behind converters was to have a generic /type/ conversion framework for use inside wicket core. you can see they are intended to be /type/ converters by looking at the javadoc of 
IConverter.convert(Object, Class). how is a trimming string converter that is running on values that are already strings and trimming them going to affect places in wicket's core outside form processing?i still dont think this is the right approach. we should think of something else.
> getInput would be fine if we were just starting development. But we have a big> application going to production soon and I'm seeking some kind of another alternative> than telling all developers to change their TextFields to MyTrimmerTextFields.
so why are you just now thinking about this? sounds to me like you are dealing with this issue too late. (not that we are not willing to help you)-IgorOn 3/8/06, 
Eelco Hillenius <[EMAIL PROTECTED]> wrote:
I agree with Ari and I am not against removing that check.EelcoOn 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:> Hi,>
> getInput would be fine if we were just starting development. But we have a big> application going to production soon and I'm seeking some kind of another alternative> than telling all developers to change their TextFields to MyTrimmerTextFields.
> Converter interface has been very handy for me before, but it just failed on this one.>> Why should you think Converter only as datatype converter ? I'm sure that> there are plenty of use cases where manipulating also the value would be handy.
> Also, I don't think that removing the short-circuit done by isAssignableFrom> woundn't be a performace problem ?>> What I have liked about wicket a lot is that there are a lot of different interfaces
> that one can use to get between things and alter the behaviour for local needs> without creating a derived component of each standard component. This is also> the reason I'm insisting about similar solution here.
>> Ari S.>> - Original Message -> From: "Igor Vaynberg" <[EMAIL PROTECTED]>> To: <
wicket-user@lists.sourceforge.net>> Sent: Wednesday, March 08, 2006 9:23 AM> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)>>> but is it really then a conversion? why run a Integer->Integer conversion or
> a String->String conversion? then you are really warping the converter into> an input postprocessor. why not create a simple subclass of textfield and> override getInput() ?>> -Igor
>>> On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:> >> > Could someone also take a look at Converter so it could be used ?
> > I mean this line in Converter.java:> >> > // Catch all cases where value is already the right type> > if (c.isAssignableFrom(value.getClass()))> > {> > return value;
> > }> >> > This is some kind of a optimization, right ? But as a side effect> > it makes it impossible to do any conversion on textfield input> > if it is stored to String field in model (quite usual case, I think).
> >> > Maybe just drop those lines ?> >> > Ari S.> >> > - Original Message -> > From: "Eelco Hillenius" <
[EMAIL PROTECTED]>> > To: <wicket-user@lists.sourceforge.net>> > Sent: Tuesday, March 07, 2006 7:22 PM> > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
> > at beginning)> >> >> > >I don't think we need it in core. Maybe as an example somewhere. We> > > have to get our users get used to working with custom components more,
> > > as that's one of the key points of Wicket imo :)> > >> > > Eelco> > >> > >> > > On 3/7/06, Igor Vaynberg <
[EMAIL PROTECTED]> wrote:> > >> but do we need this in core? its a trivial subclass, why not create it> > in> > >> your own codebase?> > >>> > >> if you guys want it in core you can have it, just asking.
> > >>> > >> -Igor> > >>> > >>> > >>> > >> On 3/7/06, Ryan Sonnek <[EMAIL PROTECTED]
> wrote:> > >> > +1 for this solution.  this seems to be the cleanest implementation> > to> > >> > me and puts the responsibility on the developer to *use* the correct
> > >>

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-08 Thread Eelco Hillenius

I agree with Ari and I am not against removing that check.

Eelco


On 3/8/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> Hi,
>
> getInput would be fine if we were just starting development. But we have a big
> application going to production soon and I'm seeking some kind of another 
> alternative
> than telling all developers to change their TextFields to MyTrimmerTextFields.
> Converter interface has been very handy for me before, but it just failed on 
> this one.
>
> Why should you think Converter only as datatype converter ? I'm sure that
> there are plenty of use cases where manipulating also the value would be 
> handy.
> Also, I don't think that removing the short-circuit done by isAssignableFrom
> woundn't be a performace problem ?
>
> What I have liked about wicket a lot is that there are a lot of different 
> interfaces
> that one can use to get between things and alter the behaviour for local needs
> without creating a derived component of each standard component. This is also
> the reason I'm insisting about similar solution here.
>
> Ari S.
>
> - Original Message -
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> To: 
> Sent: Wednesday, March 08, 2006 9:23 AM
> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
> beginning)
>
>
> but is it really then a conversion? why run a Integer->Integer conversion or
> a String->String conversion? then you are really warping the converter into
> an input postprocessor. why not create a simple subclass of textfield and
> override getInput() ?
>
> -Igor
>
>
> On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> >
> > Could someone also take a look at Converter so it could be used ?
> > I mean this line in Converter.java:
> >
> > // Catch all cases where value is already the right type
> > if (c.isAssignableFrom(value.getClass()))
> > {
> > return value;
> > }
> >
> > This is some kind of a optimization, right ? But as a side effect
> > it makes it impossible to do any conversion on textfield input
> > if it is stored to String field in model (quite usual case, I think).
> >
> > Maybe just drop those lines ?
> >
> > Ari S.
> >
> > - Original Message -
> > From: "Eelco Hillenius" <[EMAIL PROTECTED]>
> > To: 
> > Sent: Tuesday, March 07, 2006 7:22 PM
> > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
> > at beginning)
> >
> >
> > >I don't think we need it in core. Maybe as an example somewhere. We
> > > have to get our users get used to working with custom components more,
> > > as that's one of the key points of Wicket imo :)
> > >
> > > Eelco
> > >
> > >
> > > On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > >> but do we need this in core? its a trivial subclass, why not create it
> > in
> > >> your own codebase?
> > >>
> > >> if you guys want it in core you can have it, just asking.
> > >>
> > >> -Igor
> > >>
> > >>
> > >>
> > >> On 3/7/06, Ryan Sonnek <[EMAIL PROTECTED]> wrote:
> > >> > +1 for this solution.  this seems to be the cleanest implementation
> > to
> > >> > me and puts the responsibility on the developer to *use* the correct
> > >> > component.
> > >> >
> > >> > On 3/7/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote:
> > >> > > i guess thats true. you can create a subclass TrimmingTextField
> > that
> > >> > > overrides getInput() and trims it.
> > >> > >
> > >> > >
> > >> > > -Igor
> > >> > >
> > >> > >
> > >> > > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> > >> > > >
> > >> > > > So before the input goes into the required/type conversion and
> > >> validators
> > >> > > we first trim it
> > >> > > > when that flag is set?.
> > >> > > >
> > >> > > > he also could just overwrite getInput() and trim the text when
> > called.
> > >> > > >
> > >> > > >
> > >> > > > johan
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > >
> >

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-08 Thread Ari Suutari

Hi,

getInput would be fine if we were just starting development. But we have a big
application going to production soon and I'm seeking some kind of another 
alternative
than telling all developers to change their TextFields to MyTrimmerTextFields.
Converter interface has been very handy for me before, but it just failed on 
this one.

Why should you think Converter only as datatype converter ? I'm sure that
there are plenty of use cases where manipulating also the value would be handy.
Also, I don't think that removing the short-circuit done by isAssignableFrom
woundn't be a performace problem ?

What I have liked about wicket a lot is that there are a lot of different 
interfaces
that one can use to get between things and alter the behaviour for local needs
without creating a derived component of each standard component. This is also
the reason I'm insisting about similar solution here.

   Ari S.

- Original Message - 
From: "Igor Vaynberg" <[EMAIL PROTECTED]>

To: 
Sent: Wednesday, March 08, 2006 9:23 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)

but is it really then a conversion? why run a Integer->Integer conversion or
a String->String conversion? then you are really warping the converter into
an input postprocessor. why not create a simple subclass of textfield and
override getInput() ?

-Igor

On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:

Could someone also take a look at Converter so it could be used ?
I mean this line in Converter.java:

// Catch all cases where value is already the right type
if (c.isAssignableFrom(value.getClass()))
{
return value;
}

This is some kind of a optimization, right ? But as a side effect
it makes it impossible to do any conversion on textfield input
if it is stored to String field in model (quite usual case, I think).

Maybe just drop those lines ?

Ari S.

- Original Message -
From: "Eelco Hillenius" <[EMAIL PROTECTED]>
To: 
Sent: Tuesday, March 07, 2006 7:22 PM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
at beginning)

>I don't think we need it in core. Maybe as an example somewhere. We
> have to get our users get used to working with custom components more,
> as that's one of the key points of Wicket imo :)
>
> Eelco
>
>
> On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
>> but do we need this in core? its a trivial subclass, why not create it
in
>> your own codebase?
>>
>> if you guys want it in core you can have it, just asking.
>>
>> -Igor
>>
>>
>>
>> On 3/7/06, Ryan Sonnek <[EMAIL PROTECTED]> wrote:
>> > +1 for this solution.  this seems to be the cleanest implementation
to
>> > me and puts the responsibility on the developer to *use* the correct
>> > component.
>> >
>> > On 3/7/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote:
>> > > i guess thats true. you can create a subclass TrimmingTextField
that
>> > > overrides getInput() and trims it.
>> > >
>> > >
>> > > -Igor
>> > >
>> > >
>> > > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
>> > > >
>> > > > So before the input goes into the required/type conversion and
>> validators
>> > > we first trim it
>> > > > when that flag is set?.
>> > > >
>> > > > he also could just overwrite getInput() and trim the text when
called.
>> > > >
>> > > >
>> > > > johan
>> > > >
>> > > >
>> > > >
>> > > >
>> > > >
>> > > >
>> > > >
>> > > > On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote:
>> > > > >
>> > > > > i was also thinking a trim flag on the textfield and textarea
only.
>> are
>> > > you opposed to that also Johan?
>> > > > >
>> > > > >
>> > > > > -Igor
>> > > > >
>> > > > >
>> > > > >
>> > > > >
>> > > > > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
>> > > > > >
>> > > > > > You also could use a Converter for this i guess.
>> > > > > >
>> > > > > >
>> > > > > > johan
>> > > > > >
>> > > > > >
>> > > > > >
>> > > > > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED] > wrote:
>> > > > > > &

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Igor Vaynberg

but is it really then a conversion? why run a Integer->Integer conversion or a String->String conversion? then you are really warping the converter into an input postprocessor. why not create a simple subclass of textfield and override getInput() ?
-IgorOn 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
Could someone also take a look at Converter so it could be used ?I mean this line in Converter.java:// Catch all cases where value is already the right typeif (c.isAssignableFrom(value.getClass())){
return value;}This is some kind of a optimization, right ? But as a side effectit makes it impossible to do any conversion on textfield inputif it is stored to String field in model (quite usual case, I think).
Maybe just drop those lines ?Ari S.- Original Message -From: "Eelco Hillenius" <[EMAIL PROTECTED]>To: <
wicket-user@lists.sourceforge.net>Sent: Tuesday, March 07, 2006 7:22 PMSubject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)
>I don't think we need it in core. Maybe as an example somewhere. We> have to get our users get used to working with custom components more,> as that's one of the key points of Wicket imo :)
>> Eelco>>> On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:>> but do we need this in core? its a trivial subclass, why not create it in
>> your own codebase?>>>> if you guys want it in core you can have it, just asking.>>>> -Igor>>>>>>>> On 3/7/06, Ryan Sonnek <
[EMAIL PROTECTED]> wrote:>> > +1 for this solution.  this seems to be the cleanest implementation to>> > me and puts the responsibility on the developer to *use* the correct>> > component.
>> >>> > On 3/7/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote:>> > > i guess thats true. you can create a subclass TrimmingTextField that
>> > > overrides getInput() and trims it.>> > >>> > >>> > > -Igor>> > >>> > >>> > > On 3/7/06, Johan Compagner < 
[EMAIL PROTECTED]> wrote:>> > > >>> > > > So before the input goes into the required/type conversion and>> validators>> > > we first trim it
>> > > > when that flag is set?.>> > > >>> > > > he also could just overwrite getInput() and trim the text when called.>> > > >>> > > >
>> > > > johan>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >>> > > >
>> > > > On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote:>> > > > >>> > > > > i was also thinking a trim flag on the textfield and textarea only.
>> are>> > > you opposed to that also Johan?>> > > > >>> > > > >>> > > > > -Igor>> > > > >>> > > > >
>> > > > >>> > > > >>> > > > > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:>> > > > > >
>> > > > > > You also could use a Converter for this i guess.>> > > > > >>> > > > > >>> > > > > > johan>> > > > > >
>> > > > > >>> > > > > >>> > > > > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED] > wrote:
>> > > > > > > Hi,>> > > > > > >>> > > > > > > But simple validation is already on wicket level. Of course we>> could>> > > > > > > argue on this, but I really think that right place for simple
>> > > > > > > input "cleanup" is the user interface layer:>> > > > > > >>> > > > > > > - Let's say I have a model, which has field called "code".
>> > > > > > > - If user types new value for this in a field, I (and even user,>> I>> > > think)>> > > > > > >   excepts that invisible blanks at end of "code" are removed. It
>> is>> > > > > > >   very easy to accidentally put them there with copy & paste,>> for>> > > example.>> > > > > > > - However, if I code something like this: 
m.setCode("ZAP   "); I>> > > sure>> > > > > > >   except that it is stored excactly as I wrote.>> > > > > > >>> > > > > > >

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Ari Suutari


Could someone also take a look at Converter so it could be used ?
I mean this line in Converter.java:

// Catch all cases where value is already the right type
if (c.isAssignableFrom(value.getClass()))
{
   return value;
}

This is some kind of a optimization, right ? But as a side effect
it makes it impossible to do any conversion on textfield input
if it is stored to String field in model (quite usual case, I think).

Maybe just drop those lines ?

   Ari S.

- Original Message - 
From: "Eelco Hillenius" <[EMAIL PROTECTED]>

To: 
Sent: Tuesday, March 07, 2006 7:22 PM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)



I don't think we need it in core. Maybe as an example somewhere. We
have to get our users get used to working with custom components more,
as that's one of the key points of Wicket imo :)

Eelco


On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:

but do we need this in core? its a trivial subclass, why not create it in
your own codebase?

if you guys want it in core you can have it, just asking.

-Igor



On 3/7/06, Ryan Sonnek <[EMAIL PROTECTED]> wrote:
> +1 for this solution.  this seems to be the cleanest implementation to
> me and puts the responsibility on the developer to *use* the correct
> component.
>
> On 3/7/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote:
> > i guess thats true. you can create a subclass TrimmingTextField that
> > overrides getInput() and trims it.
> >
> >
> > -Igor
> >
> >
> > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> > >
> > > So before the input goes into the required/type conversion and
validators
> > we first trim it
> > > when that flag is set?.
> > >
> > > he also could just overwrite getInput() and trim the text when called.
> > >
> > >
> > > johan
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote:
> > > >
> > > > i was also thinking a trim flag on the textfield and textarea only.
are
> > you opposed to that also Johan?
> > > >
> > > >
> > > > -Igor
> > > >
> > > >
> > > >
> > > >
> > > > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> > > > >
> > > > > You also could use a Converter for this i guess.
> > > > >
> > > > >
> > > > > johan
> > > > >
> > > > >
> > > > >
> > > > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED] > wrote:
> > > > > > Hi,
> > > > > >
> > > > > > But simple validation is already on wicket level. Of course we
could
> > > > > > argue on this, but I really think that right place for simple
> > > > > > input "cleanup" is the user interface layer:
> > > > > >
> > > > > > - Let's say I have a model, which has field called "code".
> > > > > > - If user types new value for this in a field, I (and even user,
I
> > think)
> > > > > >   excepts that invisible blanks at end of "code" are removed. It
is
> > > > > >   very easy to accidentally put them there with copy & paste,
for
> > example.
> > > > > > - However, if I code something like this: m.setCode("ZAP   "); I
> > sure
> > > > > >   except that it is stored excactly as I wrote.
> > > > > >
> > > > > > Besides, who it would harm if TextField & TextArea had a flag
> > > > > > like this ? Nobody forces one to use it.
> > > > > >
> > > > > > Ari S.
> > > > > >
> > > > > > - Original Message -
> > > > > > From: "Johan Compagner" <[EMAIL PROTECTED]>
> > > > > > To: < wicket-user@lists.sourceforge.net>
> > > > > > Sent: Tuesday, March 07, 2006 11:35 AM
> > > > > > Subject: Re: [Wicket-user] TextField and trimming blanks at end
(and
> > maybe at beginning)
> > > > > >
> > > > > >
> > > > > > a trim flag on what?
> > > > > > Form component?
> > > > > > I don't like that what does it do for non text fields?
> > > > > >
> > > > > > trimming should belong in a mo

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Ari Suutari


I forgot to mention that:

Converter would have been my preferred solution, because
with it I could have easily modified trimming behavour of all
my user interface components. So if this can be made to work
it would be great.

   Ari S.

- Original Message - 
From: "Johan Compagner" <[EMAIL PROTECTED]>

To: 
Sent: Tuesday, March 07, 2006 3:44 PM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)


You also could use a Converter for this i guess.

johan


On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:


Hi,

But simple validation is already on wicket level. Of course we could
argue on this, but I really think that right place for simple
input "cleanup" is the user interface layer:

- Let's say I have a model, which has field called "code".
- If user types new value for this in a field, I (and even user, I think)
  excepts that invisible blanks at end of "code" are removed. It is
  very easy to accidentally put them there with copy & paste, for example.
- However, if I code something like this: m.setCode("ZAP   "); I sure
  except that it is stored excactly as I wrote.

Besides, who it would harm if TextField & TextArea had a flag
like this ? Nobody forces one to use it.

Ari S.

- Original Message -
From: "Johan Compagner" <[EMAIL PROTECTED]>
To: 
Sent: Tuesday, March 07, 2006 11:35 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
at beginning)


a trim flag on what?
Form component?
I don't like that what does it do for non text fields?

trimming should belong in a model. For example a ModelWrapper where you
put
youre real models in.

johan


On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
>
> Hi,
>
> setTrimValue flag would be great (maybe there should be settings
> for left/right trim ?).
>
> Model might be also a working solution, but somehow I feel that
> this kind of task belongs to upper layer.
>
> Ari S.
>
> ----- Original Message -
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> To: 
> Sent: Monday, March 06, 2006 7:11 PM
> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
maybe
> at beginning)
>
>
> this should be a flag on the textfield so you can call
> setTrimValue(boolean)
> what do others think?
>
> if not you can write a model that trims for you on setObject()
>
> -Igor
>
>
> On 3/6/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> >
> > Hi,
> >
> > What might be the simplest way to change behaviour of whole wicket
> > application
> > so that TextField have their input trimmed of blanks at end ?
> >
> > I tried to do this via converters (I have my own converter factory),
> > but it didn't work because Converter.convert doesn't do anything
> > if String is being assigned to String field in model (it uses
> > isAssignableFrom
> > for this check).
> >
> > Ari S.
> >
> >
> >
> >
> > ---
> > This SF.Net email is sponsored by xPML, a groundbreaking scripting
> > language
> > that extends applications into web and mobile media. Attend the live
> > webcast
> > and join the prime developer group breaking into this new coding
> > territory!
> >
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> > ___
> > Wicket-user mailing list
> > Wicket-user@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/wicket-user
> >
>
>
>
> ---
> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language
> that extends applications into web and mobile media. Attend the live
> webcast
> and join the prime developer group breaking into this new coding
> territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> ___
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>



---
This SF.Net email is sponsored by xPML, a groundbreaking scripting
language
that extends applications into web and mobile media. Attend the live
webcast
and join the prime developer group breaking into this new coding
territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listi

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Ari Suutari


I tried to use Converter at first, of course. But it doesn't work,
since string-string -conversion bypasses things.
(read the end of this e-mail)

   Ari S.

- Original Message - 
From: "Johan Compagner" <[EMAIL PROTECTED]>

To: 
Sent: Tuesday, March 07, 2006 3:44 PM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)


You also could use a Converter for this i guess.

johan


On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:


Hi,

But simple validation is already on wicket level. Of course we could
argue on this, but I really think that right place for simple
input "cleanup" is the user interface layer:

- Let's say I have a model, which has field called "code".
- If user types new value for this in a field, I (and even user, I think)
  excepts that invisible blanks at end of "code" are removed. It is
  very easy to accidentally put them there with copy & paste, for example.
- However, if I code something like this: m.setCode("ZAP   "); I sure
  except that it is stored excactly as I wrote.

Besides, who it would harm if TextField & TextArea had a flag
like this ? Nobody forces one to use it.

Ari S.

- Original Message -
From: "Johan Compagner" <[EMAIL PROTECTED]>
To: 
Sent: Tuesday, March 07, 2006 11:35 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
at beginning)


a trim flag on what?
Form component?
I don't like that what does it do for non text fields?

trimming should belong in a model. For example a ModelWrapper where you
put
youre real models in.

johan


On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
>
> Hi,
>
> setTrimValue flag would be great (maybe there should be settings
> for left/right trim ?).
>
> Model might be also a working solution, but somehow I feel that
> this kind of task belongs to upper layer.
>
> Ari S.
>
> ----- Original Message -
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> To: 
> Sent: Monday, March 06, 2006 7:11 PM
> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
maybe
> at beginning)
>
>
> this should be a flag on the textfield so you can call
> setTrimValue(boolean)
> what do others think?
>
> if not you can write a model that trims for you on setObject()
>
> -Igor
>
>
> On 3/6/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
> >
> > Hi,
> >
> > What might be the simplest way to change behaviour of whole wicket
> > application
> > so that TextField have their input trimmed of blanks at end ?
> >
> > I tried to do this via converters (I have my own converter factory),
> > but it didn't work because Converter.convert doesn't do anything
> > if String is being assigned to String field in model (it uses
> > isAssignableFrom
> > for this check).
> >
> > Ari S.
> >
> >
> >
> >
> > ---
> > This SF.Net email is sponsored by xPML, a groundbreaking scripting
> > language
> > that extends applications into web and mobile media. Attend the live
> > webcast
> > and join the prime developer group breaking into this new coding
> > territory!
> >
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> > ___
> > Wicket-user mailing list
> > Wicket-user@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/wicket-user
> >
>
>
>
> ---
> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language
> that extends applications into web and mobile media. Attend the live
> webcast
> and join the prime developer group breaking into this new coding
> territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> ___
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>



---
This SF.Net email is sponsored by xPML, a groundbreaking scripting
language
that extends applications into web and mobile media. Attend the live
webcast
and join the prime developer group breaking into this new coding
territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user





---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Eelco Hillenius

I don't think we need it in core. Maybe as an example somewhere. We
have to get our users get used to working with custom components more,
as that's one of the key points of Wicket imo :)

Eelco


On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> but do we need this in core? its a trivial subclass, why not create it in
> your own codebase?
>
> if you guys want it in core you can have it, just asking.
>
> -Igor
>
>
>
> On 3/7/06, Ryan Sonnek <[EMAIL PROTECTED]> wrote:
> > +1 for this solution.  this seems to be the cleanest implementation to
> > me and puts the responsibility on the developer to *use* the correct
> > component.
> >
> > On 3/7/06, Igor Vaynberg < [EMAIL PROTECTED]> wrote:
> > > i guess thats true. you can create a subclass TrimmingTextField that
> > > overrides getInput() and trims it.
> > >
> > >
> > > -Igor
> > >
> > >
> > > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> > > >
> > > > So before the input goes into the required/type conversion and
> validators
> > > we first trim it
> > > > when that flag is set?.
> > > >
> > > > he also could just overwrite getInput() and trim the text when called.
> > > >
> > > >
> > > > johan
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote:
> > > > >
> > > > > i was also thinking a trim flag on the textfield and textarea only.
> are
> > > you opposed to that also Johan?
> > > > >
> > > > >
> > > > > -Igor
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> > > > > >
> > > > > > You also could use a Converter for this i guess.
> > > > > >
> > > > > >
> > > > > > johan
> > > > > >
> > > > > >
> > > > > >
> > > > > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED] > wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > But simple validation is already on wicket level. Of course we
> could
> > > > > > > argue on this, but I really think that right place for simple
> > > > > > > input "cleanup" is the user interface layer:
> > > > > > >
> > > > > > > - Let's say I have a model, which has field called "code".
> > > > > > > - If user types new value for this in a field, I (and even user,
> I
> > > think)
> > > > > > >   excepts that invisible blanks at end of "code" are removed. It
> is
> > > > > > >   very easy to accidentally put them there with copy & paste,
> for
> > > example.
> > > > > > > - However, if I code something like this: m.setCode("ZAP   "); I
> > > sure
> > > > > > >   except that it is stored excactly as I wrote.
> > > > > > >
> > > > > > > Besides, who it would harm if TextField & TextArea had a flag
> > > > > > > like this ? Nobody forces one to use it.
> > > > > > >
> > > > > > > Ari S.
> > > > > > >
> > > > > > > - Original Message -
> > > > > > > From: "Johan Compagner" <[EMAIL PROTECTED]>
> > > > > > > To: < wicket-user@lists.sourceforge.net>
> > > > > > > Sent: Tuesday, March 07, 2006 11:35 AM
> > > > > > > Subject: Re: [Wicket-user] TextField and trimming blanks at end
> (and
> > > maybe at beginning)
> > > > > > >
> > > > > > >
> > > > > > > a trim flag on what?
> > > > > > > Form component?
> > > > > > > I don't like that what does it do for non text fields?
> > > > > > >
> > > > > > > trimming should belong in a model. For example a ModelWrapper
> where
> > > you put
> > > > > > > youre real models in.
> > > > > > >
> > > > > > > johan
> > > > > > >

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Igor Vaynberg

but do we need this in core? its a trivial subclass, why not create it in your own codebase?if you guys want it in core you can have it, just asking.-IgorOn 3/7/06, 
Ryan Sonnek <[EMAIL PROTECTED]> wrote:
+1 for this solution.  this seems to be the cleanest implementation tome and puts the responsibility on the developer to *use* the correctcomponent.On 3/7/06, Igor Vaynberg <
[EMAIL PROTECTED]> wrote:> i guess thats true. you can create a subclass TrimmingTextField that> overrides getInput() and trims it.>>> -Igor>>> On 3/7/06, Johan Compagner < 
[EMAIL PROTECTED]> wrote:> >> > So before the input goes into the required/type conversion and validators> we first trim it> > when that flag is set?.
> >> > he also could just overwrite getInput() and trim the text when called.> >> >> > johan> >> >> >> >> >> >
> >> > On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote:> > >> > > i was also thinking a trim flag on the textfield and textarea only. are
> you opposed to that also Johan?> > >> > >> > > -Igor> > >> > >> > >> > >> > > On 3/7/06, Johan Compagner < 
[EMAIL PROTECTED]> wrote:> > > >> > > > You also could use a Converter for this i guess.> > > >> > > >> > > > johan
> > > >> > > >> > > >> > > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED] > wrote:> > > > > Hi,
> > > > >> > > > > But simple validation is already on wicket level. Of course we could> > > > > argue on this, but I really think that right place for simple> > > > > input "cleanup" is the user interface layer:
> > > > >> > > > > - Let's say I have a model, which has field called "code".> > > > > - If user types new value for this in a field, I (and even user, I
> think)> > > > >   excepts that invisible blanks at end of "code" are removed. It is> > > > >   very easy to accidentally put them there with copy & paste, for> example.
> > > > > - However, if I code something like this: m.setCode("ZAP   "); I> sure> > > > >   except that it is stored excactly as I wrote.> > > > >
> > > > > Besides, who it would harm if TextField & TextArea had a flag> > > > > like this ? Nobody forces one to use it.> > > > >> > > > > Ari S.
> > > > >> > > > > - Original Message -> > > > > From: "Johan Compagner" <[EMAIL PROTECTED]>
> > > > > To: < wicket-user@lists.sourceforge.net>> > > > > Sent: Tuesday, March 07, 2006 11:35 AM> > > > > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
> maybe at beginning)> > > > >> > > > >> > > > > a trim flag on what?> > > > > Form component?> > > > > I don't like that what does it do for non text fields?
> > > > >> > > > > trimming should belong in a model. For example a ModelWrapper where> you put> > > > > youre real models in.> > > > >
> > > > > johan> > > > >> > > > >> > > > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED] > wrote:
> > > > > >> > > > > > Hi,> > > > > >> > > > > > setTrimValue flag would be great (maybe there should be settings> > > > > > for left/right trim ?).
> > > > > >> > > > > > Model might be also a working solution, but somehow I feel that> > > > > > this kind of task belongs to upper layer.> > > > > >
> > > > > > Ari S.> > > > > >> > > > > > - Original Message -> > > > > > From: "Igor Vaynberg" <
[EMAIL PROTECTED]>> > > > > > To: < wicket-user@lists.sourceforge.net >> > > > > > Sent: Monday, March 06, 2006 7:11 PM
> > > > > > Subject: Re: [Wicket-user] TextField and trimming blanks at end> (and maybe> > > > > > at beginning)> > > > > >> > > > > >
> > > > > > this should be a flag on the textfield so you can call> > > > > > setTrimValue(boolean)> > > > > > what do others thin

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Ryan Sonnek

+1 for this solution.  this seems to be the cleanest implementation to
me and puts the responsibility on the developer to *use* the correct
component.

On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> i guess thats true. you can create a subclass TrimmingTextField that
> overrides getInput() and trims it.
>
>
> -Igor
>
>
> On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> >
> > So before the input goes into the required/type conversion and validators
> we first trim it
> > when that flag is set?.
> >
> > he also could just overwrite getInput() and trim the text when called.
> >
> >
> > johan
> >
> >
> >
> >
> >
> >
> >
> > On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote:
> > >
> > > i was also thinking a trim flag on the textfield and textarea only. are
> you opposed to that also Johan?
> > >
> > >
> > > -Igor
> > >
> > >
> > >
> > >
> > > On 3/7/06, Johan Compagner < [EMAIL PROTECTED]> wrote:
> > > >
> > > > You also could use a Converter for this i guess.
> > > >
> > > >
> > > > johan
> > > >
> > > >
> > > >
> > > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED] > wrote:
> > > > > Hi,
> > > > >
> > > > > But simple validation is already on wicket level. Of course we could
> > > > > argue on this, but I really think that right place for simple
> > > > > input "cleanup" is the user interface layer:
> > > > >
> > > > > - Let's say I have a model, which has field called "code".
> > > > > - If user types new value for this in a field, I (and even user, I
> think)
> > > > >   excepts that invisible blanks at end of "code" are removed. It is
> > > > >   very easy to accidentally put them there with copy & paste, for
> example.
> > > > > - However, if I code something like this: m.setCode("ZAP   "); I
> sure
> > > > >   except that it is stored excactly as I wrote.
> > > > >
> > > > > Besides, who it would harm if TextField & TextArea had a flag
> > > > > like this ? Nobody forces one to use it.
> > > > >
> > > > > Ari S.
> > > > >
> > > > > - Original Message -
> > > > > From: "Johan Compagner" <[EMAIL PROTECTED]>
> > > > > To: < wicket-user@lists.sourceforge.net>
> > > > > Sent: Tuesday, March 07, 2006 11:35 AM
> > > > > Subject: Re: [Wicket-user] TextField and trimming blanks at end (and
> maybe at beginning)
> > > > >
> > > > >
> > > > > a trim flag on what?
> > > > > Form component?
> > > > > I don't like that what does it do for non text fields?
> > > > >
> > > > > trimming should belong in a model. For example a ModelWrapper where
> you put
> > > > > youre real models in.
> > > > >
> > > > > johan
> > > > >
> > > > >
> > > > > On 3/7/06, Ari Suutari <[EMAIL PROTECTED] > wrote:
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > setTrimValue flag would be great (maybe there should be settings
> > > > > > for left/right trim ?).
> > > > > >
> > > > > > Model might be also a working solution, but somehow I feel that
> > > > > > this kind of task belongs to upper layer.
> > > > > >
> > > > > > Ari S.
> > > > > >
> > > > > > - Original Message -
> > > > > > From: "Igor Vaynberg" <[EMAIL PROTECTED]>
> > > > > > To: < wicket-user@lists.sourceforge.net >
> > > > > > Sent: Monday, March 06, 2006 7:11 PM
> > > > > > Subject: Re: [Wicket-user] TextField and trimming blanks at end
> (and maybe
> > > > > > at beginning)
> > > > > >
> > > > > >
> > > > > > this should be a flag on the textfield so you can call
> > > > > > setTrimValue(boolean)
> > > > > > what do others think?
> > > > > >
> > > > > > if not you can write a model that trims for you on setObj

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Igor Vaynberg

i guess thats true. you can create a subclass TrimmingTextField that overrides getInput() and trims it.-IgorOn 3/7/06, Johan Compagner <
[EMAIL PROTECTED]> wrote:
So before the input goes into the required/type conversion and validators we first trim itwhen that flag is set?. he also could just overwrite getInput() and trim the text when called.
johan
On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED]
> wrote:
i was also thinking a trim flag on the textfield and textarea only. are you opposed to that also Johan?-Igor

On 3/7/06, Johan Compagner <
[EMAIL PROTECTED]> wrote:


You also could use a Converter for this i guess.johanOn 3/7/06, Ari Suutari
 <[EMAIL PROTECTED]
> wrote:Hi,But simple validation is already on wicket level. Of course we could
argue on this, but I really think that right place for simpleinput "cleanup" is the user interface layer:- Let's say I have a model, which has field called "code".- If user types new value for this in a field, I (and even user, I think)
  excepts that invisible blanks at end of "code" are removed. It is  very easy to accidentally put them there with copy & paste, for example.- However, if I code something like this: m.setCode("ZAP   "); I sure
  except that it is stored excactly as I wrote.Besides, who it would harm if TextField & TextArea had a flaglike this ? Nobody forces one to use it.Ari S.- Original Message -
From: "Johan Compagner" <[EMAIL PROTECTED]>To: <


wicket-user@lists.sourceforge.net>Sent: Tuesday, March 07, 2006 11:35 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)a trim flag on what?Form component?I don't like that what does it do for non text fields?trimming should belong in a model. For example a ModelWrapper where you put
youre real models in.johanOn 3/7/06, Ari Suutari <[EMAIL PROTECTED]
> wrote:>> Hi,>> setTrimValue flag would be great (maybe there should be settings
> for left/right trim ?).>> Model might be also a working solution, but somehow I feel that> this kind of task belongs to upper layer.>> Ari S.>> - Original Message -----
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>> To: <


wicket-user@lists.sourceforge.net
>> Sent: Monday, March 06, 2006 7:11 PM> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe> at beginning)>>> this should be a flag on the textfield so you can call
> setTrimValue(boolean)> what do others think?>> if not you can write a model that trims for you on setObject()>> -Igor>>> On 3/6/06, Ari Suutari <



[EMAIL PROTECTED]> wrote:> >> > Hi,> >> > What might be the simplest way to change behaviour of whole wicket> > application> > so that TextField have their input trimmed of blanks at end ?
> >> > I tried to do this via converters (I have my own converter factory),> > but it didn't work because Converter.convert doesn't do anything> > if String is being assigned to String field in model (it uses
> > isAssignableFrom> > for this check).> >> > Ari S.> >> >> >> >> > ---



> > This SF.Net email is sponsored by xPML, a groundbreaking scripting> > language> > that extends applications into web and mobile media. Attend the live> > webcast> > and join the prime developer group breaking into this new coding
> > territory!> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642

> > ___> > Wicket-user mailing list> > 


Wicket-user@lists.sourceforge.net> > 
https://lists.sourceforge.net/lists/listinfo/wicket-user> >>>>> ---> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language> that extends applications into web and mobile media. Attend the live> webcast> and join the prime developer group breaking into this new coding> territory!> 



http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> ___> Wicket-user mailing list> 



Wicket-user@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/wicket-user
>---
This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcastand join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing listWicket-user@lists.sourceforge.net


https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Johan Compagner

So before the input goes into the required/type conversion and validators we first trim itwhen that flag is set?. he also could just overwrite getInput() and trim the text when called.johan
On 3/7/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
i was also thinking a trim flag on the textfield and textarea only. are you opposed to that also Johan?-Igor
On 3/7/06, Johan Compagner <
[EMAIL PROTECTED]> wrote:

You also could use a Converter for this i guess.johanOn 3/7/06, Ari Suutari
 <[EMAIL PROTECTED]
> wrote:Hi,But simple validation is already on wicket level. Of course we could
argue on this, but I really think that right place for simpleinput "cleanup" is the user interface layer:- Let's say I have a model, which has field called "code".- If user types new value for this in a field, I (and even user, I think)
  excepts that invisible blanks at end of "code" are removed. It is  very easy to accidentally put them there with copy & paste, for example.- However, if I code something like this: m.setCode("ZAP   "); I sure
  except that it is stored excactly as I wrote.Besides, who it would harm if TextField & TextArea had a flaglike this ? Nobody forces one to use it.Ari S.- Original Message -
From: "Johan Compagner" <[EMAIL PROTECTED]>To: <

wicket-user@lists.sourceforge.net>Sent: Tuesday, March 07, 2006 11:35 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)a trim flag on what?Form component?I don't like that what does it do for non text fields?trimming should belong in a model. For example a ModelWrapper where you put
youre real models in.johanOn 3/7/06, Ari Suutari <[EMAIL PROTECTED]
> wrote:>> Hi,>> setTrimValue flag would be great (maybe there should be settings
> for left/right trim ?).>> Model might be also a working solution, but somehow I feel that> this kind of task belongs to upper layer.>> Ari S.>> - Original Message -
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>> To: <

wicket-user@lists.sourceforge.net
>> Sent: Monday, March 06, 2006 7:11 PM> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe> at beginning)>>> this should be a flag on the textfield so you can call
> setTrimValue(boolean)> what do others think?>> if not you can write a model that trims for you on setObject()>> -Igor>>> On 3/6/06, Ari Suutari <


[EMAIL PROTECTED]> wrote:> >> > Hi,> >> > What might be the simplest way to change behaviour of whole wicket> > application> > so that TextField have their input trimmed of blanks at end ?
> >> > I tried to do this via converters (I have my own converter factory),> > but it didn't work because Converter.convert doesn't do anything> > if String is being assigned to String field in model (it uses
> > isAssignableFrom> > for this check).> >> > Ari S.> >> >> >> >> > ---


> > This SF.Net email is sponsored by xPML, a groundbreaking scripting> > language> > that extends applications into web and mobile media. Attend the live> > webcast> > and join the prime developer group breaking into this new coding
> > territory!> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642

> > ___> > Wicket-user mailing list> > 

Wicket-user@lists.sourceforge.net> > 
https://lists.sourceforge.net/lists/listinfo/wicket-user> >>>>> ---> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language> that extends applications into web and mobile media. Attend the live> webcast> and join the prime developer group breaking into this new coding> territory!> 


http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> ___> Wicket-user mailing list> 


Wicket-user@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/wicket-user
>---
This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcastand join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing listWicket-user@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Igor Vaynberg

i was also thinking a trim flag on the textfield and textarea only. are you opposed to that also Johan?-IgorOn 3/7/06, Johan Compagner <
[EMAIL PROTECTED]> wrote:
You also could use a Converter for this i guess.johanOn 3/7/06, Ari Suutari
 <[EMAIL PROTECTED]
> wrote:Hi,But simple validation is already on wicket level. Of course we could
argue on this, but I really think that right place for simpleinput "cleanup" is the user interface layer:- Let's say I have a model, which has field called "code".- If user types new value for this in a field, I (and even user, I think)
  excepts that invisible blanks at end of "code" are removed. It is  very easy to accidentally put them there with copy & paste, for example.- However, if I code something like this: m.setCode("ZAP   "); I sure
  except that it is stored excactly as I wrote.Besides, who it would harm if TextField & TextArea had a flaglike this ? Nobody forces one to use it.Ari S.- Original Message -
From: "Johan Compagner" <[EMAIL PROTECTED]>To: <
wicket-user@lists.sourceforge.net>Sent: Tuesday, March 07, 2006 11:35 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)a trim flag on what?Form component?I don't like that what does it do for non text fields?trimming should belong in a model. For example a ModelWrapper where you put
youre real models in.johanOn 3/7/06, Ari Suutari <[EMAIL PROTECTED]
> wrote:>> Hi,>> setTrimValue flag would be great (maybe there should be settings
> for left/right trim ?).>> Model might be also a working solution, but somehow I feel that> this kind of task belongs to upper layer.>> Ari S.>> - Original Message -
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>> To: <
wicket-user@lists.sourceforge.net
>> Sent: Monday, March 06, 2006 7:11 PM> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe> at beginning)>>> this should be a flag on the textfield so you can call
> setTrimValue(boolean)> what do others think?>> if not you can write a model that trims for you on setObject()>> -Igor>>> On 3/6/06, Ari Suutari <

[EMAIL PROTECTED]> wrote:> >> > Hi,> >> > What might be the simplest way to change behaviour of whole wicket> > application> > so that TextField have their input trimmed of blanks at end ?
> >> > I tried to do this via converters (I have my own converter factory),> > but it didn't work because Converter.convert doesn't do anything> > if String is being assigned to String field in model (it uses
> > isAssignableFrom> > for this check).> >> > Ari S.> >> >> >> >> > ---

> > This SF.Net email is sponsored by xPML, a groundbreaking scripting> > language> > that extends applications into web and mobile media. Attend the live> > webcast> > and join the prime developer group breaking into this new coding
> > territory!> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642

> > ___> > Wicket-user mailing list> > 
Wicket-user@lists.sourceforge.net> > 
https://lists.sourceforge.net/lists/listinfo/wicket-user> >>>>> ---> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language> that extends applications into web and mobile media. Attend the live> webcast> and join the prime developer group breaking into this new coding> territory!> 

http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> ___> Wicket-user mailing list> 

Wicket-user@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/wicket-user
>---
This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcastand join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing listWicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Johan Compagner

You also could use a Converter for this i guess.johanOn 3/7/06, Ari Suutari <[EMAIL PROTECTED]
> wrote:Hi,But simple validation is already on wicket level. Of course we could
argue on this, but I really think that right place for simpleinput "cleanup" is the user interface layer:- Let's say I have a model, which has field called "code".- If user types new value for this in a field, I (and even user, I think)
  excepts that invisible blanks at end of "code" are removed. It is  very easy to accidentally put them there with copy & paste, for example.- However, if I code something like this: m.setCode("ZAP   "); I sure
  except that it is stored excactly as I wrote.Besides, who it would harm if TextField & TextArea had a flaglike this ? Nobody forces one to use it.Ari S.- Original Message -
From: "Johan Compagner" <[EMAIL PROTECTED]>To: <wicket-user@lists.sourceforge.net>Sent: Tuesday, March 07, 2006 11:35 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)a trim flag on what?Form component?I don't like that what does it do for non text fields?trimming should belong in a model. For example a ModelWrapper where you put
youre real models in.johanOn 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:>> Hi,>> setTrimValue flag would be great (maybe there should be settings
> for left/right trim ?).>> Model might be also a working solution, but somehow I feel that> this kind of task belongs to upper layer.>> Ari S.>> - Original Message -
> From: "Igor Vaynberg" <[EMAIL PROTECTED]>> To: <wicket-user@lists.sourceforge.net
>> Sent: Monday, March 06, 2006 7:11 PM> Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe> at beginning)>>> this should be a flag on the textfield so you can call
> setTrimValue(boolean)> what do others think?>> if not you can write a model that trims for you on setObject()>> -Igor>>> On 3/6/06, Ari Suutari <
[EMAIL PROTECTED]> wrote:> >> > Hi,> >> > What might be the simplest way to change behaviour of whole wicket> > application> > so that TextField have their input trimmed of blanks at end ?
> >> > I tried to do this via converters (I have my own converter factory),> > but it didn't work because Converter.convert doesn't do anything> > if String is being assigned to String field in model (it uses
> > isAssignableFrom> > for this check).> >> > Ari S.> >> >> >> >> > ---
> > This SF.Net email is sponsored by xPML, a groundbreaking scripting> > language> > that extends applications into web and mobile media. Attend the live> > webcast> > and join the prime developer group breaking into this new coding
> > territory!> > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> > ___> > Wicket-user mailing list> > Wicket-user@lists.sourceforge.net> > 
https://lists.sourceforge.net/lists/listinfo/wicket-user> >>>>> ---> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language> that extends applications into web and mobile media. Attend the live> webcast> and join the prime developer group breaking into this new coding> territory!> 
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642> ___> Wicket-user mailing list> 
Wicket-user@lists.sourceforge.net> https://lists.sourceforge.net/lists/listinfo/wicket-user>---
This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcastand join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642___
Wicket-user mailing listWicket-user@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Ari Suutari


Hi,

But simple validation is already on wicket level. Of course we could
argue on this, but I really think that right place for simple
input "cleanup" is the user interface layer:

- Let's say I have a model, which has field called "code".
- If user types new value for this in a field, I (and even user, I think)
 excepts that invisible blanks at end of "code" are removed. It is
 very easy to accidentally put them there with copy & paste, for example.
- However, if I code something like this: m.setCode("ZAP   "); I sure
 except that it is stored excactly as I wrote.

Besides, who it would harm if TextField & TextArea had a flag
like this ? Nobody forces one to use it.

   Ari S.

- Original Message - 
From: "Johan Compagner" <[EMAIL PROTECTED]>

To: 
Sent: Tuesday, March 07, 2006 11:35 AM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)


a trim flag on what?
Form component?
I don't like that what does it do for non text fields?

trimming should belong in a model. For example a ModelWrapper where you put
youre real models in.

johan


On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:


Hi,

setTrimValue flag would be great (maybe there should be settings
for left/right trim ?).

Model might be also a working solution, but somehow I feel that
this kind of task belongs to upper layer.

Ari S.

- Original Message -
From: "Igor Vaynberg" <[EMAIL PROTECTED]>
To: 
Sent: Monday, March 06, 2006 7:11 PM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe
at beginning)


this should be a flag on the textfield so you can call
setTrimValue(boolean)
what do others think?

if not you can write a model that trims for you on setObject()

-Igor


On 3/6/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
>
> Hi,
>
> What might be the simplest way to change behaviour of whole wicket
> application
> so that TextField have their input trimmed of blanks at end ?
>
> I tried to do this via converters (I have my own converter factory),
> but it didn't work because Converter.convert doesn't do anything
> if String is being assigned to String field in model (it uses
> isAssignableFrom
> for this check).
>
> Ari S.
>
>
>
>
> ---
> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language
> that extends applications into web and mobile media. Attend the live
> webcast
> and join the prime developer group breaking into this new coding
> territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> ___
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>



---
This SF.Net email is sponsored by xPML, a groundbreaking scripting
language
that extends applications into web and mobile media. Attend the live
webcast
and join the prime developer group breaking into this new coding
territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user





---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Johan Compagner

a trim flag on what?Form component? I don't like that what does it do for non text fields?trimming should belong in a model. For example a ModelWrapper where you put youre real models in.johan
On 3/7/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
Hi,setTrimValue flag would be great (maybe there should be settingsfor left/right trim ?).Model might be also a working solution, but somehow I feel thatthis kind of task belongs to upper layer.
Ari S.- Original Message -From: "Igor Vaynberg" <[EMAIL PROTECTED]>To: <
wicket-user@lists.sourceforge.net>Sent: Monday, March 06, 2006 7:11 PMSubject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)this should be a flag on the textfield so you can call setTrimValue(boolean)
what do others think?if not you can write a model that trims for you on setObject()-IgorOn 3/6/06, Ari Suutari <[EMAIL PROTECTED]
> wrote:>> Hi,>> What might be the simplest way to change behaviour of whole wicket> application> so that TextField have their input trimmed of blanks at end ?>> I tried to do this via converters (I have my own converter factory),
> but it didn't work because Converter.convert doesn't do anything> if String is being assigned to String field in model (it uses> isAssignableFrom> for this check).>> Ari S.
>>>>> ---> This SF.Net email is sponsored by xPML, a groundbreaking scripting> language> that extends applications into web and mobile media. Attend the live
> webcast> and join the prime developer group breaking into this new coding> territory!> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> ___> Wicket-user mailing list> Wicket-user@lists.sourceforge.net> 
https://lists.sourceforge.net/lists/listinfo/wicket-user>---This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcastand join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642___Wicket-user mailing list
Wicket-user@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-07 Thread Ari Suutari


Hi,

setTrimValue flag would be great (maybe there should be settings 
for left/right trim ?).


Model might be also a working solution, but somehow I feel that
this kind of task belongs to upper layer.

   Ari S.

- Original Message - 
From: "Igor Vaynberg" <[EMAIL PROTECTED]>

To: 
Sent: Monday, March 06, 2006 7:11 PM
Subject: Re: [Wicket-user] TextField and trimming blanks at end (and maybe at 
beginning)


this should be a flag on the textfield so you can call setTrimValue(boolean)
what do others think?

if not you can write a model that trims for you on setObject()

-Igor


On 3/6/06, Ari Suutari <[EMAIL PROTECTED]> wrote:


Hi,

What might be the simplest way to change behaviour of whole wicket
application
so that TextField have their input trimmed of blanks at end ?

I tried to do this via converters (I have my own converter factory),
but it didn't work because Converter.convert doesn't do anything
if String is being assigned to String field in model (it uses
isAssignableFrom
for this check).

Ari S.




---
This SF.Net email is sponsored by xPML, a groundbreaking scripting
language
that extends applications into web and mobile media. Attend the live
webcast
and join the prime developer group breaking into this new coding
territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user





---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

Re: [Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-06 Thread Igor Vaynberg

this should be a flag on the textfield so you can call setTrimValue(boolean) what do others think?if not you can write a model that trims for you on setObject()-Igor
On 3/6/06, Ari Suutari <[EMAIL PROTECTED]> wrote:
Hi,What might be the simplest way to change behaviour of whole wicket applicationso that TextField have their input trimmed of blanks at end ?I tried to do this via converters (I have my own converter factory),
but it didn't work because Converter.convert doesn't do anythingif String is being assigned to String field in model (it uses isAssignableFromfor this check).Ari S.---
This SF.Net email is sponsored by xPML, a groundbreaking scripting languagethat extends applications into web and mobile media. Attend the live webcastand join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642___
Wicket-user mailing listWicket-user@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-user

[Wicket-user] TextField and trimming blanks at end (and maybe at beginning)

2006-03-06 Thread Ari Suutari


Hi,

What might be the simplest way to change behaviour of whole wicket application
so that TextField have their input trimmed of blanks at end ?

I tried to do this via converters (I have my own converter factory),
but it didn't work because Converter.convert doesn't do anything
if String is being assigned to String field in model (it uses isAssignableFrom
for this check).

   Ari S.




---
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
___
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user

41 matches

Mail list logo