Re: [Wicket-user] [ wicket-Patches-1562130 ] File descriptor leak in URLResourceStream
I'd say that a file descriptor leak is not an option in any case. The code I supplied tests to see if something is a JarURLConnection and get's the URL to the jar file itself if this is the case. You can then test if THAT url is modified. This is what the JarURLConnection does anyway, so you don't change the behavior of anything at all; all you do avoid a file descriptor leak in many cases. Note: the behavior of wicket is NOT changed. Only a file descriptor leak is fixed which is caused by a bug in JarURLConnection (which I have reported to Sun). In development mode I cannot run for more than 30 minutes without going out of file descriptors, so this seems like a really serious issue to me. I think the workaround is justified since I don't think Sun will have this fixed quickly. Regards, Sebastiaan Eelco Hillenius wrote: We need a default that works for most users and via options something that works for all. If we have something that by default works for all, that's all the better. Eelco On 11/27/06, Johan Compagner [EMAIL PROTECTED] wrote: No we as a framework should think about ALL users not MOST users. And we have quit a lot OSGI users as far as i know. And we should work in that environment as good as we can. So we need to check jars. And besides that we don't know it everytime that it is a jar.. It is just and url.. johan On 11/27/06, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: * Johan Compagner: So instead of opening a connection inside the jar we just open a connection to the jar only. That would work for the app servers that uses the jar url connection but it won't help for example WebLogic and others. Because they use there own kind of thing.. We need to address the needs of *most* users. And for most users it doesn't make any sense to reload templates from JAR files. -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/ - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] [ wicket-Patches-1562130 ] File descriptor leak in URLResourceStream
its already in for 2.0 en 1.3 On 12/3/06, Sebastiaan van Erk [EMAIL PROTECTED] wrote: I'd say that a file descriptor leak is not an option in any case. The code I supplied tests to see if something is a JarURLConnection and get's the URL to the jar file itself if this is the case. You can then test if THAT url is modified. This is what the JarURLConnection does anyway, so you don't change the behavior of anything at all; all you do avoid a file descriptor leak in many cases. Note: the behavior of wicket is NOT changed. Only a file descriptor leak is fixed which is caused by a bug in JarURLConnection (which I have reported to Sun). In development mode I cannot run for more than 30 minutes without going out of file descriptors, so this seems like a really serious issue to me. I think the workaround is justified since I don't think Sun will have this fixed quickly. Regards, Sebastiaan Eelco Hillenius wrote: We need a default that works for most users and via options something that works for all. If we have something that by default works for all, that's all the better. Eelco On 11/27/06, Johan Compagner [EMAIL PROTECTED] wrote: No we as a framework should think about ALL users not MOST users. And we have quit a lot OSGI users as far as i know. And we should work in that environment as good as we can. So we need to check jars. And besides that we don't know it everytime that it is a jar.. It is just and url.. johan On 11/27/06, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: * Johan Compagner: So instead of opening a connection inside the jar we just open a connection to the jar only. That would work for the app servers that uses the jar url connection but it won't help for example WebLogic and others. Because they use there own kind of thing.. We need to address the needs of *most* users. And for most users it doesn't make any sense to reload templates from JAR files. -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/ - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] [ wicket-Patches-1562130 ] File descriptor leak in URLResourceStream
* Johan Compagner: So instead of opening a connection inside the jar we just open a connection to the jar only. That would work for the app servers that uses the jar url connection but it won't help for example WebLogic and others. Because they use there own kind of thing.. We need to address the needs of *most* users. And for most users it doesn't make any sense to reload templates from JAR files. -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/ - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] [ wicket-Patches-1562130 ] File descriptor leak in URLResourceStream
No we as a framework should think about ALL users not MOST users. And we have quit a lot OSGI users as far as i know. And we should work in that environment as good as we can. So we need to check jars. And besides that we don't know it everytime that it is a jar.. It is just and url.. johan On 11/27/06, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: * Johan Compagner: So instead of opening a connection inside the jar we just open a connection to the jar only. That would work for the app servers that uses the jar url connection but it won't help for example WebLogic and others. Because they use there own kind of thing.. We need to address the needs of *most* users. And for most users it doesn't make any sense to reload templates from JAR files. -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/ - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] [ wicket-Patches-1562130 ] File descriptor leak in URLResourceStream
We need a default that works for most users and via options something that works for all. If we have something that by default works for all, that's all the better. Eelco On 11/27/06, Johan Compagner [EMAIL PROTECTED] wrote: No we as a framework should think about ALL users not MOST users. And we have quit a lot OSGI users as far as i know. And we should work in that environment as good as we can. So we need to check jars. And besides that we don't know it everytime that it is a jar.. It is just and url.. johan On 11/27/06, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: * Johan Compagner: So instead of opening a connection inside the jar we just open a connection to the jar only. That would work for the app servers that uses the jar url connection but it won't help for example WebLogic and others. Because they use there own kind of thing.. We need to address the needs of *most* users. And for most users it doesn't make any sense to reload templates from JAR files. -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/ - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
