[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-14 Thread noreply 
The proposal to merge lp:~widelands-dev/widelands/bug-1785404-chat-scrolling 
into lp:widelands has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941
-- 
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-14 Thread bunnybot 
Continuous integration builds have changed state:

Travis build 3786. State: passed. Details: 
https://travis-ci.org/widelands/widelands/builds/415538286.
Appveyor build 3585. State: success. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1785404_chat_scrolling-3585.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-13 Thread GunChleoc 
Review: Approve

Code LGTM :)
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-12 Thread Toni Förster 
Review: Approve

Works for me. Tested on macOS 10.13.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-12 Thread bunnybot 
Continuous integration builds have changed state:

Travis build 3776. State: errored. Details: 
https://travis-ci.org/widelands/widelands/builds/415148977.
Appveyor build 3575. State: failed. Details: 
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1785404_chat_scrolling-3575.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands.

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-12 Thread Notabilis 
Notabilis has proposed merging 
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands.

Commit message:
Fixing broken auto-scrolling of multi-line text areas.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1785404 in widelands: "Chat does not autoscroll"
  https://bugs.launchpad.net/widelands/+bug/1785404

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941

Seems to be a case of wrong direction of comparison. I would appreciate it if 
someone thinks about it for a moment before merging.
-- 
Your team Widelands Developers is requested to review the proposed merge of 
lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands.
=== modified file 'src/ui_basic/multilinetextarea.cc'
--- src/ui_basic/multilinetextarea.cc	2018-07-28 07:02:25 +
+++ src/ui_basic/multilinetextarea.cc	2018-08-12 16:43:10 +
@@ -104,7 +104,7 @@
 		scrollbar_.set_steps(height - get_h());
 
 		if (scrollmode_ == ScrollMode::kScrollLog || scrollmode_ == ScrollMode::kScrollLogForced) {
-			if (scrollbar_.get_scrollpos() >= scrollbar_.get_steps() - 1) {
+			if (scrollbar_.get_scrollpos() < scrollbar_.get_steps() - 1) {
 scrollbar_.set_scrollpos(height - get_h());
 			}
 		}

___
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp