[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands
The proposal to merge lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1800182-focus-save-menu/+merge/358284 -- Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1800182-focus-save-menu. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands
Bug report is up. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1800182-focus-save-menu/+merge/358284 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1800182-focus-save-menu. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands
Or rather than letting the save menu (and possibly some others) deal with "let's not accidentally refer key handling to the game window" issues, maybe the game window needs a "state" variable to distinguish between "game is running normally", "game is paused in background behind some other window" (and possibly other states), and then any key handling is suspended in certain states. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1800182-focus-save-menu/+merge/358284 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1800182-focus-save-menu. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands
That keypresses affect the game window from the save menu is a more general issue that should be resolved. Sure, the name edit box grabs the keys when it has the focus, but as soon as the filename table is focued (which happends naturally when someone selects a name there), key handling (aside from a few keys like Up/Down) seems to be referred to the game window in the background. We should generally prevent that. (Not necessarily in this branch.) Maybe it's enough to have the LoadOrSave table simply grab the keys instead of referring the key handling to something else. Hard to say right now, I haven't even checked which route the key handling takes to end up at the game window. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1800182-focus-save-menu/+merge/358284 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1800182-focus-save-menu. ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands
Notabilis has proposed merging lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands. Commit message: Setting focus to edit box when opening the game save menu. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1800182 in widelands: "Focus missing when saving game from replay" https://bugs.launchpad.net/widelands/+bug/1800182 For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1800182-focus-save-menu/+merge/358284 When the game save menu is opened, the keyboard focus isn't set to the filename input edit box. Besides the inconvenience of having to click in the edit box before entering the filename, keyboard input also modifies the state of the game, e.g., opening the minimap. -- Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1800182-focus-save-menu into lp:widelands. === modified file 'src/wui/game_main_menu_save_game.cc' --- src/wui/game_main_menu_save_game.cc 2018-10-26 07:09:29 + +++ src/wui/game_main_menu_save_game.cc 2018-11-04 08:51:30 + @@ -115,6 +115,7 @@ center_to_parent(); move_to_top(); + filename_editbox_.focus(); pause_game(true); set_thinks(false); layout(); ___ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
