[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||krinklem...@gmail.com Blocks||28412 -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are watching all bug changes. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 --- Comment #8 from Bawolff bawolff...@gmail.com 2010-11-13 22:39:15 UTC --- btw, this is related to Bug 18954 . -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 --- Comment #2 from Krinkle krinklem...@gmail.com 2010-11-12 12:35:36 UTC --- not quite, as autopatrols and patrols are both saved with the same log_type and log_action. I haven't traced yet how MediaWiki's Special:Log/patrol extracts the information to append or not append (automatic) to the log entry, but in my toolserver tools I do this by digging through log_params *after* the query in a foreach loop since I noticed in the second or third line of that string is a '1' that indicates whether it's autopatrolled or not. Asuming MediaWiki does it the same way on the log page, this definitely needs attention. I think making it a seperate log_action would make sense (just like log_type 'upload' has log_action 'upload' and 'overwrite', log_type 'patrol' could have log_action 'patrol' and 'autopatrol'). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 --- Comment #3 from Bawolff bawolff...@gmail.com 2010-11-12 19:01:26 UTC --- I haven't traced yet how MediaWiki's Special:Log/patrol extracts the information to append or not append (automatic) to the log entry, but in my toolserver tools I do this by digging through log_params *after* the query in a foreach loop since I noticed in the second or third line of that string is a '1' that indicates whether it's autopatrolled or not. As it stands the first parameter is the current revision id, the second parameter is the revision id of the previous revision, and the third parameter is if its Automatic or not. The code for displaying this mostly happens at PatrolLog::makeActionText in PatrolLog.php. You're right that the processing takes place after the query. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 --- Comment #4 from Krinkle krinklem...@gmail.com 2010-11-12 21:30:51 UTC --- I remember from last september I did a query on the toolserver to get some statistics for our edit-patrol team. The results are here: http://commons.wikimedia.org/wiki/CT:CVU Although in my tools, like I said in comment 2, I do it post-query, I know for sure that in this particular table I did it all within the query (excluding autopatrols), I'll see if I can digg up how I did that. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 --- Comment #5 from Bawolff bawolff...@gmail.com 2010-11-12 21:42:16 UTC --- Well its entirely possible to do something like that in sql, I'm very doubtful it can be done efficiently, which makes it a moot point. (Although then again I don't think querying by log_action, which was proposed earlier, is efficient either, or at least not currently). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 --- Comment #6 from Krinkle krinklem...@gmail.com 2010-11-12 21:51:27 UTC --- Well, in the API it is already possible to filter by log_action. So if autopatrols would be recorded as such, it's possible to use the API to only get 'real' patrols. In the front-end there's only a way to filter by log_type, but that's fine I don't think log_action is really something that would be used from a front-end. It may be interesting in general, to improve that API-functionality, to add an INDEX on log_action though... But aside from the API-functionality. The main point is that different actions should be recorded as different actions, and for Patrol this is not the case. (overwrite and upload are differrent log_action's) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 --- Comment #7 from Krinkle krinklem...@gmail.com 2010-11-12 21:56:07 UTC --- I found the query by the way: // Get patrol statistics $dbQuery = SELECT count(*) AS counter, log_action, user_name, user_registration, user_editcount FROM logging log JOIN user us ON log.log_user = us.user_id WHERE log.log_type = 'patrol' AND log.log_action = 'patrol' AND log.log_params LIKE '%\n0' /* -- this line */ GROUP BY log.log_user ORDER BY counter DESC LIMIT 50;; So yeah, that's everything but effecient. The query run took little over 5-6 minutes. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 25799] Enabling viewing patrols seperate from own autopatrolled edits
https://bugzilla.wikimedia.org/show_bug.cgi?id=25799 Bawolff bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #1 from Bawolff bawolff...@gmail.com 2010-11-06 19:47:03 UTC --- Bug 22738 would provide (provides?) a method to do this in the api. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
