[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2012-10-31 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

Bug 26234 depends on bug 37727, which changed state.

Bug 37727 Summary: move geoIP lookup back to the head
https://bugzilla.wikimedia.org/show_bug.cgi?id=37727

   What|Old Value   |New Value

 Status|NEW |RESOLVED
 Resolution||FIXED

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2012-03-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

mybugs.m...@gmail.com changed:

   What|Removed |Added

 CC||mybugs.m...@gmail.com

--- Comment #9 from mybugs.m...@gmail.com 2012-03-15 13:51:42 UTC ---
See also:
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)?oldid=481885933#The_banner

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2012-03-15 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

Ryan Kaldari rkald...@wikimedia.org changed:

   What|Removed |Added

 AssignedTo|rkald...@wikimedia.org  |wikibugs-l@lists.wikimedia.
   ||org

--- Comment #10 from Ryan Kaldari rkald...@wikimedia.org 2012-03-15 23:59:36 
UTC ---
The solution in r99341 was reverted for a couple reasons. Primarily, it slows
down loading of the page itself, but also, we aren't sure how the wider
community will respond to storing cookies for every user.

A full analysis of all the possible solutions to this bug can be found at:
http://wikitech.wikimedia.org/view/CentralNotice/Optimizing_banner_loading

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2011-10-09 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

--- Comment #8 from Ryan Kaldari rkald...@wikimedia.org 2011-10-09 08:35:04 
UTC ---
This may be fixed in r99341. Need to test on the live cluster to be sure.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2011-09-08 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

Arthur Richards aricha...@wikimedia.org changed:

   What|Removed |Added

   Keywords||fundraising
 CC||aricha...@wikimedia.org

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2010-12-07 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

--- Comment #7 from Ryan Kaldari rkald...@wikimedia.org 2010-12-07 18:42:49 
UTC ---
That's an interesting idea. I know that they used different sizes earlier in
the fundraiser, but it does seem like they've started using a standard size
recently. I'll ask them if they plan on sticking with that size or not.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2010-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

--- Comment #3 from Ryan Kaldari rkald...@wikimedia.org 2010-12-06 22:47:41 
UTC ---
Unfortunately, the banner has to load after the page due to the Geotargeting
(Javascript doesn't have the Geo data until then). One possible solution would
be to have Javascript jump back to the section after the banner loads, but this
might be even more annoying since it would cause the page to jump twice instead
of once. Thoughts?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2010-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

John Mark Vandenberg jay...@gmail.com changed:

   What|Removed |Added

 CC||jay...@gmail.com

--- Comment #4 from John Mark Vandenberg jay...@gmail.com 2010-12-06 23:28:39 
UTC ---
Does PHP have the geotargetting info?  If so, the height of the banner is known
and can be written into the html whenever the country has only one banner (as
in Australia)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2010-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

--- Comment #5 from Ryan Kaldari rkald...@wikimedia.org 2010-12-06 23:46:33 
UTC ---
No, PHP doesn't know the Geo info, nor does anything on the server side. At the
end of a normal page request you'll see a call to script
type=text/javascript src=http://geoiplookup.wikimedia.org/;/script. This
sets the Geo info in a global Javascript variable. That info is then used to
choose which banner to display. We tried having the Geo call at the top of the
page, but it caused the page loading to stall sometimes (if the Geo request
took more than a second or so to return). We could theoretically have PHP do
the Geo lookup and output the result to the page, but this would break the page
caching and cause the servers to melt. It something of a chicken and egg
problem. Any other ideas?

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2010-12-06 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

--- Comment #6 from Bawolff bawolff...@gmail.com 2010-12-07 02:15:54 UTC ---
Aren't the banners the same size regardless of the geoip (or anything else?) We
could just have a blank placeholder there until it loads.

Personally i think the jump back would be less annoying (if done right). (OTOH
I'm personally not overly bothered by this whatsoever).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2010-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

Nemo_bis federicol...@tiscali.it changed:

   What|Removed |Added

 CC||federicol...@tiscali.it
  Component|User interface  |CentralNotice
Version|wikimedia-deployment|any
 AssignedTo|wikibug...@lists.wikimedia. |rkald...@wikimedia.org
   |org |
Product|MediaWiki   |MediaWiki extensions

--- Comment #1 from Nemo_bis federicol...@tiscali.it 2010-12-05 10:35:54 UTC 
---
The behaviour is quite random: the first time I tried on Firefox (after
re-enabling the centralnotice) nothing happened, then it has always moved
down as you said; on Chrome it moved down the first time, but moved the page
to the top on hard refresh (Ctrl+R) and following refreshes, and returned to
the previous behaviour when opening the page in incognito window (on bot
incognito and normal window); on Ekiga, it doesn't show the centralnotice, but
looks like loads something and brings you to the top of the page.
Someone in fundraising list sais that this doesn't happen with Chrome for him.

I think that moving down the page doesn't make any sense, but bringing you to
the top to make you read the banner does, if you're supposed to close it when
you've seen it, while moving the page to the top when there isn't anything is a
bug (but I suppose it affects only some niche browsers).

I'm using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101130
Ubuntu/9.10 (karmic) Firefox/3.6.13; Chromium 6.0.484.0 (54673) Ubuntu 9.10;
Ekiga 2.28.0.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l


[Bug 26234] CentralNotice moves content down when a link to a heading is followed

2010-12-05 Thread bugzilla-daemon
https://bugzilla.wikimedia.org/show_bug.cgi?id=26234

Bawolff bawolff...@gmail.com changed:

   What|Removed |Added

 CC||bawolff...@gmail.com

--- Comment #2 from Bawolff bawolff...@gmail.com 2010-12-05 21:23:57 UTC ---
The behaviour is quite random...

Not really, as far as i can tell, the behaviour happens because the central
notice is loaded by js independently of the page. So depending on the order of
thingies happening in your browser, it will get moved down if the central
notice loads after the rest of the page (or whenever fragment
identifiers/targets/whatever they're called get processed by the browser).
Since the central notice takes up room, so the rest of the page is moved down
to make room for it, which is noticeable if you're not at top of the page.

However the ekiga behaviour you describe is quite weird.

...but bringing you to the top to make you read the banner does...

Lets not do that, beyond breaking links to specific sections, that'd just be
plain annoying.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l