[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added Target Milestone|1.19wmf deployment |1.20wmf deployment --- Comment #7 from Rob Lanphier ro...@wikimedia.org 2012-02-07 18:32:24 UTC --- Removing as 1.19 blocker. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 Rob Lanphier ro...@wikimedia.org changed: What|Removed |Added CC||ro...@wikimedia.org --- Comment #5 from Rob Lanphier ro...@wikimedia.org 2012-01-30 22:42:37 UTC --- Krinkle, is this really something that needs to block a 1.19 release? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 --- Comment #6 from Krinkle krinklem...@gmail.com 2012-01-30 23:29:09 UTC --- (In reply to comment #5) Krinkle, is this really something that needs to block a 1.19 release? Well, I'd say it's your call. Any code written in 2011 or later should probably be providing tools for users with Vector/WikiEditor, not Monobook/Classic toolbar. WikiEditor has very good javascript hooks whereas the the classic toolbar's are crap (and always have been kind of hacky). Scripts manipulating the classic toolbar will fail if they load themselves as a resource module because the legacy code for the toolbar bypasses most of resource loader. - Either we force users to keep their classic-toolbar enhancement scripts un-resourceloaderified, or the classic toolbar needs to be resource loaderified. It's not a regression in 1.19, but race conditions are more likely in 1.19 due to speed. And unfortunately, contrary to the module story, there is no right way to edit the classic toolbar without having a race condition, simply because the classic toolbar isn't in the normal flow of execution. It exposes a global array where scripts can add things to, and at some point around document-ready event it builds the toolbar with the buttons in the array at that moment, and then the array is further ignored. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 Krinkle krinklem...@gmail.com changed: What|Removed |Added Severity|major |enhancement -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 Bergi a.d.be...@web.de changed: What|Removed |Added CC||a.d.be...@web.de --- Comment #3 from Bergi a.d.be...@web.de 2012-01-29 18:57:20 UTC --- (In reply to comment #1) Yes, I've been wanting this for a long while. :-) * Change JS logic to allow multiple building stages (i.e. addButton should work at any time not just before initialization) * Make .init() a once-function, and enqueue into document-ready from the 1-line init-module I would like to see some more functions, which could make it a part of a MVC architecture. I currently think of * removeButton() * reload() or, just as well, a public bindable init() function (of course by default on-document-ready, too) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 --- Comment #4 from Krinkle krinklem...@gmail.com 2012-01-29 18:58:41 UTC --- (In reply to comment #3) (In reply to comment #1) Yes, I've been wanting this for a long while. :-) * Change JS logic to allow multiple building stages (i.e. addButton should work at any time not just before initialization) * Make .init() a once-function, and enqueue into document-ready from the 1-line init-module I would like to see some more functions, which could make it a part of a MVC architecture. I currently think of * removeButton() Makes sense to have remove, yeah. * reload() or, just as well, a public bindable init() function (of course by default on-document-ready, too) I was thinking of automatically updateing/building the html when calling addButton, removing the need for a public init(). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 Krinkle krinklem...@gmail.com changed: What|Removed |Added AssignedTo|wikibugs-l@lists.wikimedia. |krinklem...@gmail.com |org | Summary|move (old) toolbar init |Refactor mw.action.edit |script to Ressource Loader |related JavaScript as ||dynamic ResourceLoader ||module --- Comment #1 from Krinkle krinklem...@gmail.com 2012-01-28 15:53:32 UTC --- Yes, I've been wanting this for a long while. * Remove inline code * Move into regular module or into a dynamically generated module (i.e. a new Module class) * Change JS logic to allow multiple building stages (i.e. addButton should work at any time not just before initialization) * Make .init() a once-function, and enqueue into document-ready from the 1-line init-module Note that recently Brion has made some changes in the 1.19-dev version that solved a few problems as well. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 Krinkle krinklem...@gmail.com changed: What|Removed |Added CC||listenle...@gmail.com --- Comment #2 from Krinkle krinklem...@gmail.com 2012-01-28 15:54:44 UTC --- *** Bug 33922 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 Krinkle krinklem...@gmail.com changed: What|Removed |Added Priority|Unprioritized |High Blocks||31511 Target Milestone|--- |1.19wmf deployment -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 33952] Refactor mw.action.edit related JavaScript as dynamic ResourceLoader module
https://bugzilla.wikimedia.org/show_bug.cgi?id=33952 Krinkle krinklem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
