[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #59 from Quim Gil q...@wikimedia.org --- If you have open tasks or bugs left, one possibility is to list them at https://www.mediawiki.org/wiki/Google_Code-In and volunteer yourself as mentor. We have heard from Google and free software projects participating in Code-in that students participating in this programs have done a great work finishing and polishing GSoC projects, many times mentores by the former GSoC student. The key is to be able to split the pending work in little tasks. More information in the wiki page. If you have questions you can ask there or you can contact me directly. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 MZMcBride b...@mzmcbride.com changed: What|Removed |Added URL||http://annotator.wmflabs.or ||g/ -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 Quim Gil q...@wikimedia.org changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #52 from Quim Gil q...@wikimedia.org --- GSoC soft pencils down date was yesterday and all coding must stop on 23 September. Has this project been completed? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 Tyler Romeo tylerro...@gmail.com changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW --- Comment #53 from Tyler Romeo tylerro...@gmail.com --- There are two open patches right now: https://gerrit.wikimedia.org/r/79839 https://gerrit.wikimedia.org/r/78251 Once they are merged, the extension has most of the features implemented. The only thing not implemented is threading, which would be too difficult because OKFN does not natively support it. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #54 from Matthew Flaschen mflasc...@wikimedia.org --- Yeah, I consider this complete. I think we will be able to get those two merged, but I don't think either are hard requirements (though the annotation tab is pretty useful, because otherwise you get annotations everywhere all the time). As Tyler noted, there's not really reply support. However, if you comment on the same text, it puts the annotation underneath. The other item that is not implemented (mainly since we did not prioritize it) is including the date. However, there have been other items implemented that were not listed under Required Deliverables, so I think it balances out. E.g. * Update and delete * Proper DB setup (including AnnotationRepository for testability), including SQLite support and updates. * Logged out user support (under review; Required Deliverables mentions usernames, but not IPs) * PHP unit tests (this is the third change under review, which I would like to get merged). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #55 from Steven Walling swall...@wikimedia.org --- (In reply to comment #54) Yeah, I consider this complete. I think we will be able to get those two merged, but I don't think either are hard requirements (though the annotation tab is pretty useful, because otherwise you get annotations everywhere all the time). I think bug 52064 is the only big UI/UX blocker for actually deploying this to a Wikimedia wiki. Showing annotations by default on every view is likely to annoy folks. Otherwise, I think even things like bonafide threading support can be put on hold for later release. Overall, agreed with Matt that this product is nearly done. Very good work for a GSoC project. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #57 from Quim Gil q...@wikimedia.org --- The GSoC project has the Prototyping word very visible. Wikimedia requirements for deployment are out of scope. The fact that they are being discussed already now indicates that this prototyping phase seems to be a success. :) Let's get through the GSoC evaluation and let's talk about further steps after that. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #56 from Matthew Flaschen mflasc...@wikimedia.org --- Bug 52156 (history) is also a blocker (to be clear, this is an extra, not part of the required prototype deliverables) to WMF (and probably most third parties) deployment. It's not strictly UI, but it's definitely user-visible (to experienced users who understand history). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #58 from Randall Leeds tilg...@hypothes.is --- Nice to see this worked out well! As for replies, I've got a threading plugin that handles most of this. I'm looking to upstream it for Annotator 2.0. I'll also take the feedback about not showing annotations immediately into mind. Nothing stops the integrator from overriding the .annotator-hl styles, but something more direct and programmatic might make sense. Once again, reach out any time in #annotator on freenode or the annotator-dev list and I'll keep watching this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #47 from Matthew Flaschen mflasc...@wikimedia.org --- There is now a test wiki for this, http://annotator.instance-proxy.wmflabs.org/ . If you're interested in testing it, create an account, then try annotating http://annotator.instance-proxy.wmflabs.org/wiki/Lorem_ipsum . Currently, you must be logged in, both to see annotations and to make them (bug 51722). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #48 from Matthew Flaschen mflasc...@wikimedia.org --- You can now also use the simpler URL, http://annotator.wmflabs.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #49 from dacu...@gmail.com --- Just tried the demo and it works well. Great work Richa and mentors! Just a couple of comments: - When I edited the page all annotations were gone, I reverted to the previous edition but the annotations didn't reappear. - I assume that these annotations will be displayed in the newly deployed Visual Editor. Would it be possible to update the text anchor as the text is being changed? Annotations in Google Docs have this behaviour, however I am not sure if it would be too complex to mimic that feature. - A minor glitch: when I delete an annotation I get the message sorry we could not destroy this annotation, however the annotation is indeed deleted. - In the recent changes page I didn't see any notification of my actions, I understand that it could be meant this way? And I also loved that you can select several sections of text and create one annotation for all those sections. If the annotation link could be displayed (maybe with a 3rd icon, an anchor displaying the link), that would be a great addition for external websites linking to/highlighting particular fragments, or conversations in the talk page pointing to fragments. Micru -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #50 from richa jain richa.jain1...@gmail.com --- (In reply to comment #49) Just tried the demo and it works well. Great work Richa and mentors! Just a couple of comments: - When I edited the page all annotations were gone, I reverted to the previous edition but the annotations didn't reappear. It looks for annotations for the latest revision since i am using the latest revision id. There is already a bug filed for this https://bugzilla.wikimedia.org/show_bug.cgi?id=51728 . - I assume that these annotations will be displayed in the newly deployed Visual Editor. Would it be possible to update the text anchor as the text is being changed? Annotations in Google Docs have this behaviour, however I am not sure if it would be too complex to mimic that feature. - A minor glitch: when I delete an annotation I get the message sorry we could not destroy this annotation, however the annotation is indeed deleted. The destroying of annotations is still under review. https://gerrit.wikimedia.org/r/74150 so the annotations are not actually deleted currently. - In the recent changes page I didn't see any notification of my actions, I understand that it could be meant this way? And I also loved that you can select several sections of text and create one annotation for all those sections. If the annotation link could be displayed (maybe with a 3rd icon, an anchor displaying the link), that would be a great addition for external websites linking to/highlighting particular fragments, or conversations in the talk page pointing to fragments. Micru -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #51 from Matthew Flaschen mflasc...@wikimedia.org --- (In reply to comment #49) Just tried the demo and it works well. Great work Richa and mentors! Just a couple of comments: Thanks. :) - When I edited the page all annotations were gone, I reverted to the previous edition but the annotations didn't reappear. Yes, handling page changes is one of the trickier things that there may or may not be time for this summer. However, we do want to fix the issue where the wrong annotations appear when you look at an old version of the page from the history (bug 51728). - I assume that these annotations will be displayed in the newly deployed Visual Editor. Would it be possible to update the text anchor as the text is being changed? Annotations in Google Docs have this behaviour, however I am not sure if it would be too complex to mimic that feature. There is no VE support so far. - In the recent changes page I didn't see any notification of my actions, I understand that it could be meant this way? We may have time to add logging, but you're right there is no history or logging yet. And I also loved that you can select several sections of text and create one annotation for all those sections. If the annotation link could be displayed (maybe with a 3rd icon, an anchor displaying the link), that would be a great addition for external websites linking to/highlighting particular fragments, or conversations in the talk page pointing to fragments. That's a possibility at some point. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added CC||mflasc...@wikimedia.org Component|Extensions requests |Annotator Assignee|wikibugs-l@lists.wikimedia. |richa.jain1...@gmail.com |org | --- Comment #46 from Matthew Flaschen mflasc...@wikimedia.org --- We've made a Bugzilla component. This will still be the main bug, tracking the initial key functionality. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 Nick Stenning n...@whiteink.com changed: What|Removed |Added CC||n...@whiteink.com --- Comment #44 from Nick Stenning n...@whiteink.com --- (In reply to comment #43) Hi all, Sorry not to have weighed in earlier. I'm really glad to see you're using Annotator, and hope I can help out with any problems you might have. I'm a little unclear about the relationship of 'read' and 'index', and how the URLs work. Yes, this is a bit messy. Read and index are implicitly the same endpoint at the moment, and index is just read with a null ID. Obviously this is horrible, but it turns out that it doesn't matter that much as an index endpoint that returns all annotations is almost never useful anyway, so... It seems like this may be a moot point if we use loadFromSearch. However, I would expect there to be an 'index' url for consistency. ...the vast majority of real implementations use loadFromSearch. If you're interested, current work in progress on Annotator 1.3/2.0 (http://github.com/okfn/annotator/compare/wip...master) is revisiting some of this stuff, and the four endpoints that need implementing by a store are now create/update/delete/query, and the index endpoint is gone. But, to answer your concrete question: use loadFromSearch and ignore the existence of the index endpoint. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 --- Comment #45 from Nick Stenning n...@whiteink.com --- That GitHub compare url has the sense of the comparison the wrong way round: http://github.com/okfn/annotator/compare/master...wip -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 46440] Implement inline comment support using OKFN annotator
https://bugzilla.wikimedia.org/show_bug.cgi?id=46440 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Summary|co-ment-like tool for |Implement inline comment |inline comments |support using OKFN ||annotator --- Comment #43 from Matthew Flaschen mflasc...@wikimedia.org --- I was wondering if someone from the OKFN team could answer a couple quick questions. I'm a little unclear about the relationship of 'read' and 'index', and how the URLs work. https://github.com/okfn/annotator/wiki/Storage#index says index returns a list of all annotation objects. First, I'm wondering if that is supposed to be limited to the current page's annotations. Maybe that's up to us. However, the plugin docs (https://github.com/okfn/annotator/wiki/Store-Plugin) have no mention of index, nor do I see a way to override the URL. https://github.com/okfn/annotator/wiki/Storage#read says it's a straight-forward method that takes an ID and returns a single annotation. But the plugin docs (Store-Plugin) say, read: GETs all annotations. Called when plugin loads or .loadAnnotations() is called. Server should return an array of annotations serialised as JSON. Looking at the Coffee code, it seems read is called to get a list, but never explicitly called for a single annotation (although there is a commented out line doing that). However, since we're using the recommended 303 redirect, it's implicitly used for creations. The list part is confirmed by testing. It loads http://127.0.0.1:9090/w/api.php?action=annotator-readid=:id, which is a bit weird. I think this is related to https://github.com/okfn/annotator/issues/186 It seems like this may be a moot point if we use loadFromSearch. However, I would expect there to be an 'index' url for consistency. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
