[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #40 from Andre Klapper aklap...@wikimedia.org --- All six patches mentioned in this bug report have been merged. What is left here? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |NEW --- Comment #41 from Brad Jorsch bjor...@wikimedia.org --- (In reply to Andre Klapper from comment #40) All six patches mentioned in this bug report have been merged. What is left here? One of the patches was reverted due to issues in Wikidata, see bug 59788. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Nemo federicol...@tiscali.it changed: What|Removed |Added CC||federicol...@tiscali.it --- Comment #38 from Nemo federicol...@tiscali.it --- One of the patches was backported to core stable (causing bug 60054), does this mean that there was some urgency for core too and this is not a Wikimedia-only bug? Please categorise it as appropriate. What else needs to be done here? Cyberpower678, are you still seeing errors? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Matthew Flaschen mflasc...@wikimedia.org changed: What|Removed |Added Component|General/Unknown |Parser Product|Wikimedia |MediaWiki --- Comment #39 from Matthew Flaschen mflasc...@wikimedia.org --- Main patches seem to be against core, so moving accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #36 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 107266 had a related patch set uploaded by MarkAHershberger: Avoid extra parsing in prepareContentForEdit() https://gerrit.wikimedia.org/r/107266 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #37 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 107266 merged by jenkins-bot: Avoid extra parsing in prepareContentForEdit() https://gerrit.wikimedia.org/r/107266 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added CC||daniel.kinz...@wikimedia.de --- Comment #33 from Daniel Kinzler daniel.kinz...@wikimedia.de --- The problem arises because Wikibase generates titles for new pages from a counter stored in the database, which is incremented in the transaction that actually creates the page. So, before the page is saved, the title isn't know. When calling a pre-save edit hook in such a situation, there is no way to provide the actual title of the page that will be created. Perhaps it would be possible to garb a fresh ID and determine the Title earlier - but that means wasting an ID for every failed attempt to save. It also means refactoring quite a bit of code in Wikibase, on a critical code path. I think it's really a fundamental question whether it can be assumed that the actual title of a page can be assumed to be known before a page has been created. A related fundamental question is whether the context title of an edit is always the title of the page where the new content will be saved, or if there are situations where this can not sensibly be expected to be the case. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Daniel Kinzler daniel.kinz...@wikimedia.de changed: What|Removed |Added See Also||https://bugzilla.wikimedia. ||org/show_bug.cgi?id=59788 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026
--- Comment #34 from Cyberpower678 cybernet...@yahoo.com ---
Date/Time: Thu, 09 Jan 2014 12:27:52 +
Method: POST
URL: http://cy.wikipedia.org/w/api.php (Parameters masked for security)
Raw Data:
!DOCTYPE html
html xmlns=http://www.w3.org/1999/xhtml; xml:lang=en lang=en
head
titleWikimedia Error/title
meta name=author content=Mark Ryan/
meta name=copyright content=(c) 2005-2007 Mark Ryan and others. Text
licensed under the GNU Free Documentation License.
http://www.gnu.org/licenses/fdl.txt/
style type=text/css!--
body {
background-color: #dbe5df;
font: 100% Gill Sans MT, Gill Sans, Trebuchet MS, Helvetica, sans-serif;
margin: 0px;
}
.TechnicalStuff {
font-size: 0.8em;
font-style: italic;
text-align: center;
padding-bottom: 0.8em;
}
.Lines {
width: 100%;
height: 1px;
overflow: hidden;
font-size: 0.5px;
}
.ContentArea {
background-color: white;
padding: 0.8em 10% 0 10%;
font-size: 1.0em;
}
a:hover {
color: red;
}
h1, h2 {
margin: 0px;
font-size: 1.0em;
}
h2 {
background: #9fbfd8;
font-size: 1.2em;
font-weight: bold;
text-align: center;
}
h1 {
background: #dbe5df;
font: bold 1.5em Gill Sans MT, Gill Sans, Helvetica, Humanist, sans-serif;
text-transform: uppercase;
text-align: center;
width: 100%;
padding-top:0.8em;
}
--
/style
script/*![CDATA[*/
function lines(s) {
var c = s.split(' ');
for (var i = 0; i c.length; i++) {
document.write('div class=Lines style=background-color:#' +
c[i] + ';/div');
}
}
//]]/script
/head
body link=#24442E text=#00 vlink=#24442E alink=#FF
h1Wikimedia Foundation/h1
scriptlines('ccd4cf bdc3bf adb1af 9ea09f dbe5df');/script
h2Error/h2
scriptlines('8f8f8f acacac c6c6c6 dbdbdb eaeaea f4f4f4');/script
!-- BEGIN CONTENT AREA --
div class=ContentArea
div id=en lang=en
pOur servers are currently experiencing a technical problem. This is probably
temporary and should be fixed soon. Please a href=//w/api.php
onclick=window.location.reload(false); return falsetry again/a in a few
minutes./p
hr noshade=noshade size=1px width=80% /
div class=TechnicalStuff
If you report this error to the Wikimedia System Administrators, please include
the details below.br/
/div
div class=TechnicalStuff
bdo dir=ltr
Request: POST http://cy.wikipedia.org/w/api.php, from 10.64.0.102 via cp1066
cp1066 ([10.64.0.103]:3128), Varnish XID 3544388602br/Forwarded for:
10.4.1.153, 10.64.0.102br/Error: 503, Service Unavailable at Thu, 09 Jan 2014
12:28:08 GMT
/bdo
/div
/div
/div
scriptlines('9ea09f adb1af bdc3bf ccd4cf');/script
/body
/html
UNSERIALIZATION FAILED
--
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
___
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #35 from Brad Jorsch bjor...@wikimedia.org --- (In reply to comment #34) Date/Time: Thu, 09 Jan 2014 12:27:52 + Method: POST URL: http://cy.wikipedia.org/w/api.php (Parameters masked for security) That makes it difficult to debug this. But I don't see any long times in the API log around that time (the worst time so far today for cywiki was only 14186ms, far below the point where this bug shows up). I also don't see any errors or exceptions in exception.log or fatal.log around this time. Which means it's probably unrelated to this specific bug (errors caused by long parse times). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Status|RESOLVED|REOPENED Depends on||59788 Resolution|FIXED |--- --- Comment #32 from Brad Jorsch bjor...@wikimedia.org --- Wikidata is calling Edit hooks with non-editable pages as context, which breaks Gerrit change 101490. Gerrit change 106126 can be merged to reinstate it once bug 59788 is fixed. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #30 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 101490 merged by jenkins-bot: Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent https://gerrit.wikimedia.org/r/101490 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Brad Jorsch bjor...@wikimedia.org changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED Resolution|--- |FIXED --- Comment #31 from Brad Jorsch bjor...@wikimedia.org --- We've cleaned up more instances of double-parsing, including one in the UI code path. Latest changes should go out with 1.23wmf9. Before reopening this bug, please test that the timeouts are due to page save taking much longer than an equivalent preview (or api action=parse), and that the page being saved does not use revision-specific magic words or parser functions and that the page being saved does not transclude itself. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #29 from Brad Jorsch bjor...@wikimedia.org --- (In reply to comment #27) I was testing via index.php. When I test via api.php, page save actions take the same time as rendering a page preview, which is interesting. Thus the issue I'm seeing seems to be from the web interface only. I did some investigating of the UI edit code page, and found the culprit there is SpamBlacklistHooks::filterMergedContent. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #28 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 101490 had a related patch set uploaded by Anomie: Use WikiPage::prepareContentForEdit in SpamBlacklistHooks::filterMergedContent https://gerrit.wikimedia.org/r/101490 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|REOPENED|PATCH_TO_REVIEW -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #24 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 101224 had a related patch set uploaded by Anomie: Fix WikiPage::prepareContentForEdit's default format handling https://gerrit.wikimedia.org/r/101224 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #25 from Brad Jorsch bjor...@wikimedia.org --- (In reply to comment #21) I think there's still double rendering going on. On commons, a null edit takes just slightly more than double the time a page preview takes. On my local copy, the operations take roughly the same time (As they should). I redid the same sort of simulation as I did in comment 10 (anyone with access to terbium, feel free to look at /home/anomie/eval-bug57026.txt), and it seems there is no longer double parsing going on before the text is saved to the database on enwiki. I also checked Commons with simulating a null edit on a random page, and again I see no double parsing. Doing a non-null edit on Commons, I see abuse filter rule 87's use of added_links is triggering reparses (it seems to be broken such that it runs added_links for all actions). While it could probably use at least the same as in Gerrit change 95481 (and probably some checking to see if it's going to be breaking the cache by passing the old wikitext for some vars), I submitted Gerrit change 101224 to be better about handling a null format in core. Also, there might still be a second parse from WikiPage::doEditUpdates() if the page uses magic words that access information about the current revision or if the page transcludes itself. I don't see any way around that. And I'm not entirely sure that just timing a null edit isn't going to cause a parser cache miss for the view-after-save, particularly if your preferences don't match the defaults. Do you still see double timing if you do the null edit via the API? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #26 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 101224 merged by jenkins-bot: Fix WikiPage::prepareContentForEdit's default format handling https://gerrit.wikimedia.org/r/101224 -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #27 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to comment #25) Also, there might still be a second parse from WikiPage::doEditUpdates() if the page uses magic words that access information about the current revision or if the page transcludes itself. I don't see any way around that. And I'm not entirely sure that just timing a null edit isn't going to cause a parser cache miss for the view-after-save, particularly if your preferences don't match the defaults. Do you still see double timing if you do the null edit via the API? I was looking at firebug, and recording the time it took to retrieve the POST request that results in a redirect. After the redirect, firefox does a GET request which usually parses the page again, which I didn't count. I was testing https://commons.wikimedia.org/wiki/Commons:Featured_picture_candidates/Log/November_2013 and https://commons.wikimedia.org/wiki/Commons:Featured_picture_candidates/Log/October_2013 which a user at commons had previously identified as being slow. I don't believe these pages are vary-revision, but hard to be 100% sure of that I was testing via index.php. When I test via api.php, page save actions take the same time as rendering a page preview, which is interesting. Thus the issue I'm seeing seems to be from the web interface only. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Bawolff (Brian Wolff) bawolff...@gmail.com changed: What|Removed |Added CC||bawolff...@gmail.com --- Comment #21 from Bawolff (Brian Wolff) bawolff...@gmail.com --- I think there's still double rendering going on. On commons, a null edit takes just slightly more than double the time a page preview takes. On my local copy, the operations take roughly the same time (As they should). -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Aaron Schulz aschulz4...@gmail.com changed: What|Removed |Added CC||aschulz4...@gmail.com --- Comment #22 from Aaron Schulz aschulz4...@gmail.com --- I still see TemplateDataHooks::onPageContentSave mentioned in dbperformance.log -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 --- Comment #23 from Bawolff (Brian Wolff) bawolff...@gmail.com --- (In reply to comment #22) I still see TemplateDataHooks::onPageContentSave mentioned in dbperformance.log I think that's expected. As I read it, the fix above is meant to work by having the hook do the parsing, and then have core skip doing the parsing. Testing Locally with TemplateData, this seems to work, with parsing only happening in TemplateData extension on page save. asideIt'd be nice if there was some way to do ?forceprofile=true/?forcetrace=true on page save. Maybe $wgDebugRedirects could somehow be triggered by a url parameter, and whatever magic makes forcetrace work in places where forceprofile doesn't be made to happen /aside -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Cyberpower678 cybernet...@yahoo.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #20 from Cyberpower678 cybernet...@yahoo.com --- Still getting errors. Will be happy to post what my framework is reporting. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 57026] Bot being served Error: 503, Service Unavailable (default error page) for API action=edit requests on large pages (caused by parsing the page three times on save)
https://bugzilla.wikimedia.org/show_bug.cgi?id=57026 Bartosz Dziewoński matma@gmail.com changed: What|Removed |Added Summary|Bot being served Error: |Bot being served Error: |503, Service Unavailable|503, Service Unavailable |(default error page) for|(default error page) for |API action=edit requests on |API action=edit requests on |large pages |large pages (caused by ||parsing the page three ||times on save) -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
