[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 tobias.gritschac...@wikimedia.de changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 --- Comment #5 from Thiemo Mättig thiemo.maet...@wikimedia.de --- (In reply to Fomafix from comment #3) the star stops rotating and switched back to the white star [...] Maybe the GET request gets answered by a different server This is an other, loosely connected issue. Can we move this to a new report, please? What if (I know this is not really a solution, just think about it) we don't do an API call at all? The star always turns blue if watchdefault is enabled. The question is: Are there any cases when this will be wrong? (The star turns blue but shouldn't.) And how big is the impact of these (probably rare) cases compared to the impact of the original issue? -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 Lydia Pintscher lydia.pintsc...@wikimedia.de changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Lydia Pintscher lydia.pintsc...@wikimedia.de --- Yes let's please track this in the other bug Helder mentioned. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 --- Comment #7 from Fomafix foma...@googlemail.com --- Bug 26292 is a different problem. In bug 26292 there is no JavaScript/Ajax and no API and the change is done by a single POST. I can reproduce bug 26292 on enwiki but not on a local wiki. But when the implementation for Wikibase is changed from a separate GET to a combined POST with the problem may also occur on API. Just guessing the server-state of the watch list on client site is problematic because all error paths has to implemented reimplemented on client side. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 --- Comment #8 from Thiemo Mättig thiemo.maet...@wikimedia.de --- (In reply to Fomafix from comment #7) In bug 26292 there is no JavaScript/Ajax and no API As I said you can create a new report to help us keep track of the impact this issue haves on the Wikidata users. As mentioned we belief it depends on bug 26292 or at least shares the same root cause. And will not be easy to fix, unfortunately. guessing the server-state of the watch list on client site is problematic because all error paths has to [...] reimplemented on client side. Yes, that's totally true. However, if it turns out the impact of some watchlist star animations wrongly turning white (as you described) is much bigger than a few watchlist stars wrongly turning blue (my naive suggestion) it may be a reasonable workaround instead of spending developers time on more complex solutions (like redesigning the API). -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 Fomafix foma...@googlemail.com changed: What|Removed |Added Status|VERIFIED|REOPENED Resolution|FIXED |--- --- Comment #3 from Fomafix foma...@googlemail.com --- The solution from https://gerrit.wikimedia.org/r/112464 doesn't work reliably. I just edited an unwatched item. On saving the star started to rotate. When the saving finished the star stops rotating and switched back to the white star instead to the blue star. When I reload the page the star was blue. So adding to the watch list by the POST request works but the GET request directly after saving for checking the watch status doesn't get the new state reliable. Maybe the GET request gets answered by a different server in comparison to the POST request and the state in the database was not updated yet. A more reliable solution is to integrate the changed state of the watch list into the response of the POST request. For comparison: The index.php also answers with the new state of the watch list state in the response. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 --- Comment #4 from Helder mybugs.m...@gmail.com --- That is similar to bug 26292. -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 Lydia Pintscher lydia.pintsc...@wikimedia.de changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 christopher.john...@wikimedia.de changed: What|Removed |Added Whiteboard|papercut, backlog |papercut, backlog u=dev ||c=WikidataRepo p=3 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 --- Comment #2 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 112464 merged by jenkins-bot: Update watchlist link/star when doing Wikibase edits https://gerrit.wikimedia.org/r/112464 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 tobias.gritschac...@wikimedia.de changed: What|Removed |Added Status|PATCH_TO_REVIEW |RESOLVED CC||tobias.gritschacher@wikimed ||ia.de Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 --- Comment #1 from Gerrit Notification Bot gerritad...@wikimedia.org --- Change 112464 had a related patch set uploaded by Thiemo Mättig (WMDE): Update watchlist link/star when doing Wikibase edits https://gerrit.wikimedia.org/r/112464 -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 Gerrit Notification Bot gerritad...@wikimedia.org changed: What|Removed |Added Status|ASSIGNED|PATCH_TO_REVIEW -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 Lydia Pintscher lydia.pintsc...@wikimedia.de changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
[Bug 58534] Start watch animation on submit when watchdefault is set
https://bugzilla.wikimedia.org/show_bug.cgi?id=58534 Lydia Pintscher lydia.pintsc...@wikimedia.de changed: What|Removed |Added Priority|Unprioritized |Normal CC||henning.sna...@wikimedia.de ||, ||lydia.pintscher@wikimedia.d ||e Component|WikidataClient |WikidataRepo Whiteboard||papercut, backlog Severity|enhancement |normal -- You are receiving this mail because: You are on the CC list for the bug. ___ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
