[Wikidata-bugs] [Maniphest] T289105: Remove compatConfig from Vue settings
Catrope closed subtask T355384: PageTriage: Remove compatConfig from Vue settings as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T289105 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Aklapper, Catrope, Danny_Benjafield_WMDE, BartTerpstra, Isabelladantes1983, Themindcoder, CCiufo-WMF, Adamm71, Jersione, PWaigi-WMF, Hellket777, NBaca-WMF, LisafBia6531, Astuthiodit_1, STH, JKieserman, 786, Sgs, MaryMunyoki, Madalina, Biggs657, Djackson-ctr, karapayneWMDE, toberto, Invadibot, UOzurumba, AmazingWikis, R4356th, caldera, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, CBogen, Rileych, ItamarWMDE, Un1tY, Nintendofan885, Akuckartz, Shliilh65, Demian, Hook696, darthmon_wmde, Kent7301, egardner, holger.knust, joker88john, Tris_T7, DannyS712, CucyNoiD, Nandana, kostajh, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, GoranSMilovanovic, chapulina, Nattes, Mahir256, QZanden, KimKelting, Alfa80, LawExplorer, Lewizho99, JJMC89, Maathavan, SamanthaNguyen, Iniquity, _jensen, rosalieper, Taiwania_Justo, Neuronton, Nizil, Scott_WUaS, Volker_E, Ixocactus, Niedzielski, Izno, SBisson, Nastoshka, Luke081515, Wikidata-bugs, WMDE-Fisch, Mooeypoo, Jdlrobson, aude, geraki, Capt_Swing, Dinoguy1000, Amire80, Jsahleen, Arrbee, santhosh, KartikMistry, Isarra, Jdforrester-WMF, Mbch331, Jay8g, Tgr ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304534: [EPIC] Make Wikibase work with Vue 3 (non-migration build)
Catrope removed Catrope as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T304534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Aklapper, Jdlrobson, Michael, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304534: [EPIC] Make Wikibase work with Vue 3 (non-migration build)
Catrope closed this task as "Resolved". Catrope claimed this task. Catrope added a comment. In T304534#8908758 <https://phabricator.wikimedia.org/T304534#8908758>, @Michael wrote: > I think there might only be some cleanup left here, that is: removing the `compatConfig: { MODE: 3 },` and such again, once it no longer makes a difference. That's tracked separately in T289104 <https://phabricator.wikimedia.org/T289104>, so I'm closing this task. TASK DETAIL https://phabricator.wikimedia.org/T304534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Aklapper, Jdlrobson, Michael, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
Catrope moved this task from QTE Sign-off to Design Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board. Catrope reassigned this task from EUdoh-WMF to Volker_E. Catrope added a comment. Moving to Design Sign-Off and assigning to @Volker_E per the previous comment TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD https://phabricator.wikimedia.org/project/board/5859/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Volker_E, Catrope Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Adamm71, SalmaBelal, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T314602: Migrate Wikibase's CLI testing of Vue code (jest etc.) from Vue 2 to Vue 3 in compatibility mode
Catrope closed this task as "Resolved". Catrope added a comment. This appears to have been done, as there are no references to Vue 2 left in Wikibase or WikibaseLexeme TASK DETAIL https://phabricator.wikimedia.org/T314602 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Aklapper, Jdforrester-WMF, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T304534: [EPIC] Make Wikibase work with Vue 3 (non-migration build)
Catrope added a comment. In T304534#8379196 <https://phabricator.wikimedia.org/T304534#8379196>, @Michael wrote: > @Catrope With the next train, the last pieces of the Wikibase Vue 3 migration should be rolling out, and we're done migrating the all the Wikibase Vue production code on MediaWiki. Thank you so much! > Also in this graph of tasks I can see T300176: Make Termbox SSR and CSR match exactly <https://phabricator.wikimedia.org/T300176>, but that is not directly related to the Vue 3 migration, I think, merely discovered during it. I agree > As for non-production code, I can see two open tasks: > > - T314602: Migrate Wikibase's CLI testing of Vue code (jest etc.) from Vue 2 to Vue 3 in compatibility mode <https://phabricator.wikimedia.org/T314602> > - I //think// this is done already? But maybe I missed something. All references to `"vue"` in `package.json` files in the Wikibase repo are to 3.x, none to 2.x, so I think this is done. > - T297381: Wikibase CI broken: test:mwlibs can’t find MediaWiki core Vue version <https://phabricator.wikimedia.org/T297381> > - This seems like the on genuine remaining task. We all last looked at this back in January, so maybe now would be a good time to have another go at it. But I don't think this is blocking the migration at all. It's not blocking, but it would be nice to find a solution. I'll take a look at this again soon. TASK DETAIL https://phabricator.wikimedia.org/T304534 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Aklapper, Jdlrobson, Michael, Lucas_Werkmeister_WMDE, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, Universal_Omega, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T305091: [TypeaheadSearch] Support lang and dir attributes for text nodes within MenuItem component
Catrope updated Other Assignee, added: EUdoh-WMF. TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, Sarai-WMDE, Aklapper, STH, AnneT, Michael, NHillard-WMF, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build
Catrope added a comment. Note that there is still one `new Vue()` call remaining in Wikibase, in ErrorPermission.vue in data bridge <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/d5b5885d2dc656a4e4936550630e33ec6bd1c8b2/client/data-bridge/src/presentation/components/ErrorPermission.vue#234>. That's not an immediate blocker for the Vue 3 migration (we have compatibility code that should keep it working), but I wanted to point it out as something that will eventually need to be migrated. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Catrope Cc: karapayneWMDE, Michael, Lucas_Werkmeister_WMDE, Aklapper, Catrope, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Sarai-WMDE, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T297381: WikibaseLexeme CI broken: test:mwlibs can’t find MediaWiki core Vue version
Catrope added a comment. In T297381#7559573 <https://phabricator.wikimedia.org/T297381#7559573>, @Lucas_Werkmeister_WMDE wrote: > @Catrope would you consider adding this `module.exports=Vue;` assignment directly to the `vue.global(.prod).js` files shipped by MediaWiki? That would fix our problem here and also slightly simplify the ResourceLoader setup, at the cost of having to repeat this step each time we want to update the bundled Vue. It's a bit trickier than that, because `foreign-resources.yaml` currently has no mechanism to automate such a post-processing step, and if we did it manually, we'd 1) forget all the time and 2) break the integrity check, because the post-processed file would have a different sha-512 hash. We could build post-processing steps into `foreign-resources.yaml` (ideally not by mangling the files themselves, but by adding new files that are derived from the original ones), and that is probably the best long-term solution, but I uploaded a quick and dirty solution that I hope will work for now. Vue ships a CommonJS version that we can't use in RL (because it tries to load other NPM packages) but that should hopefully work the purposes of lib-version-check. Let me know if that works. TASK DETAIL https://phabricator.wikimedia.org/T297381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Michael, Catrope, Lucas_Werkmeister_WMDE, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T296202: Migrate Termbox to Vue 3
Catrope added a comment. We've noticed problems with `.native` event bindings not working with compiled Vue 2 code running in the Vue 3 migration build, see https://gerrit.wikimedia.org/r/c/wvui/+/745576 . The only two uses of `.native` that codesearch turned up were in WVUI (which that patch fixes) and here in Termbox <https://gerrit.wikimedia.org/g/wikibase/termbox/+/09cc814f929a74143b897441a7492bc23af63deb/src/components/AliasesEdit.vue#12>. I recommend testing those specific event handlers to see if they still work. TASK DETAIL https://phabricator.wikimedia.org/T296202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Catrope Cc: Catrope, Michael, Lucas_Werkmeister_WMDE, Aklapper, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build
Catrope added a comment. That confuses me, because WVUI uses `export default Vue.extend( { ... } )` too (example <https://github.com/wikimedia/wvui/blob/master/src/components/button/Button.vue#L20>), and using the Vue 2 build of WVUI with the Vue 3 compat runtime works fine. Maybe the difference is that we never pass a WVUI component directly to `Vue.createMwApp()`, we happen to always wrap them in another component (because WVUI only contains basic components that don't make much sense on their own). It sounds like you are importing fully functional components that are mounted directly. A workaround might be as simple as: var TaintedRefs = require( './TaintedRefs.js' ); // returns a Vue 2-compiled component var wrappedTaintedRefs = { render: function ( h ) { return h( TaintedRefs, { props: { /* whatever you need to pass in */ } } ); } }; Vue.createMwApp( wrappedTaintedRefs ).mount( 'selector' ); That said, bundling Vue 2 temporarily is a good workaround too, we can always fall back on that if we can't find a good solution to the `Vue.extend()` problem. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Catrope Cc: karapayneWMDE, Michael, Lucas_Werkmeister_WMDE, Aklapper, Catrope, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Sarai-WMDE, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build
Catrope added a comment. > since we compile templates in our build step, we can’t produce a bundle that’s compatible with Vue 2 and 3 at runtime I thought this would be a problem with WVUI, but from my testing, the Vue 2-compiled WVUI bundle works just fine under the Vue 3 migration build. The compatibility that the migration build provides for the render function API is good enough that compiled templates work. I wouldn't trust this blindly without testing, but it has worked for us for the (relatively simple) Vue 2 code in WVUI. If you're using the composition API plugin for Vue 2 and bundling it with your code, then you will run into strange bugs. I had that problem with WVUI, and I plan to fix it by externalizing the composition API plugin instead of bundling it, see T284707 <https://phabricator.wikimedia.org/T284707> and T295106#7497606 <https://phabricator.wikimedia.org/T295106#7497606>. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Catrope Cc: karapayneWMDE, Michael, Lucas_Werkmeister_WMDE, Aklapper, Catrope, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Sarai-WMDE, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build
Catrope updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Aklapper, Catrope, Akuckartz, darthmon_wmde, lucamauri, Wikidata-bugs, Lydia_Pintscher ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T294465: Make Wikibase work with the Vue 3 migration build
Catrope created this task. Catrope added projects: MediaWiki-extensions-WikibaseClient, Wikidata-Termbox. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION One of the first steps in our migration to Vue 3 will be to upgrade the version of Vue in MediaWiki from Vue 2.6 to the migration build of Vue 3. This migration build is mostly compatible with Vue 2, but it doesn't provide compatibility for certain edge cases or for features that are undocumented or not officially supported. The Vue code in Wikibase (including its submodules, like termbox) needs to be tested against the Vue 3 migration build and updated to fix any errors. See the "test plan" section on T289019: Test Vue 3 migration build with extensions/skins using Vue <https://phabricator.wikimedia.org/T289019> for more detail. The outcome of this task should be that Wikibase runs without errors both under Vue 2.6 and under the migration build of Vue 3. These changes should ideally be minor; actually migrating to Vue 3 should be done later, since it's more work and will lead to incompatibility with Vue 2. TASK DETAIL https://phabricator.wikimedia.org/T294465 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Aklapper, Catrope, Akuckartz, darthmon_wmde, lucamauri, Wikidata-bugs, Lydia_Pintscher ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences
Catrope removed Catrope as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T224426 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, Urbanecm, Aklapper, Invadibot, OTichonova, caldera, maantietaja, NavinRizwi, Akuckartz, Nandana, kostajh, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Wikidata-bugs, aude, geraki, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed
Catrope added a comment. The relevant code is $layout->appendContent( ...$this->getCaptionsContent( $entity->getLabels(), $this->getLanguagesOrderedByFallbackChain( $entity ) ) ); I think the simplest fix would be to simply remove the spread operator (`...`), since `appendContent()` can also be called with an array as the only parameter. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given
Catrope added a comment. The relevant code is $layout->appendContent( ...$this->getCaptionsContent( $entity->getLabels(), $this->getLanguagesOrderedByFallbackChain( $entity ) ) ); I think the simplest fix would be to simply remove the spread operator (`...`), since `appendContent()` can also be called with an array as the only parameter. TASK DETAIL https://phabricator.wikimedia.org/T259744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T223410: Split group1 so that Commons and Wikidata aren't in the general group1, but their own buckets
Catrope added a comment. What's the rationale behind doing the branch cut on Friday, then waiting over 72 hours to deploy it to even test wikis on Monday? In the table in T223410#6174334 <https://phabricator.wikimedia.org/T223410#6174334>, maybe we could move the branch cut to the "early Monday" slot? TASK DETAIL https://phabricator.wikimedia.org/T223410 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Majavah, ArielGlenn, Krinkle, DannyS712, BEANS-X2, Amorymeltzer, RhinosF1, Ladsgroup, Michael, Jakob_WMDE, Pablo-WMDE, Addshore, Lydia_Pintscher, darthmon_wmde, WMDE-leszek, Lucas_Werkmeister_WMDE, brennen, mmodell, greg, hashar, Aklapper, Jdforrester-WMF, Blissjay007, Oblanco79, Alter-paule, Beast1978, CBogen, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Liudvikas, Scott_WUaS, Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Steinsplitter, Mbch331, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T229153: Reconsider caching in Wikibase\SitesModule::getScript
Catrope created this task. Catrope added projects: Performance, MediaWiki-ResourceLoader, MediaWiki-extensions-WikibaseClient. Restricted Application added subscribers: Liuxinyu970226, Aklapper. Restricted Application added projects: Wikidata, Performance-Team. TASK DESCRIPTION `Wikibase\SitesModule` is a content-versioned module, and in this profile <https://performance.wikimedia.org/xhgui/run/callgraph?id=5d3b723cbb8544407f9cb8ae> of a startup module request, 16.5% of the time is spent in `Wikibase\SitesModule::getScript()`. This function caches its output, but only for 10 minutes, and it uses the server cache. Given its performance impact, we may want to consider caching it in WANCache instead, and for a longer period of time (e.g. 24 hours). If there's way for this module to provide a definition summary that is guaranteed to change when the module contents change, but cheaper to compute, that would also be helpful. But I doubt that is the case given the fact that 2/3 of its time is spent in `DBSiteStore::getSites()`. The module also does message parsing, but that doesn't appear to contribute much to its slowness (probably because it only does it for a few "special" sites). TASK DETAIL https://phabricator.wikimedia.org/T229153 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Krinkle, Aklapper, Catrope, Liuxinyu970226, darthmon_wmde, DannyS712, Nandana, Imarlier, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, D3r1ck01, Volker_E, Nirmos, Wikidata-bugs, aude, GWicke, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T228290: Fatal on Watchlist: Call to a member function getAlphadecimal() on null
Catrope removed a parent task: T220739: 1.34.0-wmf.14 deployment blockers. TASK DETAIL https://phabricator.wikimedia.org/T228290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: greg, Catrope, dcausse, Jdforrester-WMF, Krinkle, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Lorentz21, NebulousIris, kostajh, Gaboe420, Jony, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, EnricoCNC, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, jayvdb, Mbch331, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reopened] T228290: Fatal on Watchlist: Call to a member function getAlphadecimal() on null
Catrope reopened this task as "Open". Catrope added a comment. I was able to confirm that this spams the logs without my fix, and doesn't spam it with my fix, so that's probably worth addressing. Unlinking this as a train blocker though, since it's not fataling entire pages anymore. TASK DETAIL https://phabricator.wikimedia.org/T228290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: greg, Catrope, dcausse, Jdforrester-WMF, Krinkle, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, 94rain, DannyS712, CucyNoiD, Nandana, Lorentz21, NebulousIris, kostajh, Gaboe420, Jony, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 45Jayjay1969, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, EnricoCNC, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, jayvdb, Mbch331, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T228290: Fatal on Watchlist: Call to a member function getAlphadecimal() on null
Catrope added a comment. For posterity: the "nesting level too deep" error was a crash in my debugging code, where it attempted to serialize a recursive data structure. The original error message before I started messing with things (and that is now happening again) is that `$oldId->getAlphadecimal() ` is called where `$oldId` is null, in `extensions/Flow/includes/Formatter/ChangesListFormatter.php` on line 197. TASK DETAIL https://phabricator.wikimedia.org/T228290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: greg, Catrope, dcausse, Liuxinyu970226, Jdforrester-WMF, Krinkle, Aklapper, darthmon_wmde, 94rain, DannyS712, Nandana, Lorentz21, kostajh, Jony, Lahi, Gq86, GoranSMilovanovic, 45Jayjay1969, QZanden, EBjune, EnricoCNC, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, jayvdb, Mbch331, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T228290: Fatal on Watchlist: Call to a member function getAlphadecimal() on null
Catrope renamed this task from "Fatal on Watchlist: Nesting level too deep" to "Fatal on Watchlist: Call to a member function getAlphadecimal() on null". TASK DETAIL https://phabricator.wikimedia.org/T228290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: greg, Catrope, dcausse, Liuxinyu970226, Jdforrester-WMF, Krinkle, Aklapper, darthmon_wmde, 94rain, DannyS712, Nandana, Lorentz21, kostajh, Jony, Lahi, Gq86, GoranSMilovanovic, 45Jayjay1969, QZanden, EBjune, EnricoCNC, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, jayvdb, Mbch331, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T228290: Fatal on Watchlist: Nesting level too deep
Catrope added a comment. Sort of. The exception is still being thrown, it's just that it's now (correctly) being swallowed by Flow's RecoverableErrorHandler so it doesn't break the page. TASK DETAIL https://phabricator.wikimedia.org/T228290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: greg, Catrope, dcausse, Liuxinyu970226, Jdforrester-WMF, Krinkle, Aklapper, darthmon_wmde, 94rain, DannyS712, Nandana, Lorentz21, kostajh, Jony, Lahi, Gq86, GoranSMilovanovic, 45Jayjay1969, QZanden, EBjune, EnricoCNC, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Trizek-WMF, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, jayvdb, Mbch331, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T224426: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences
Catrope added a comment. The preference is labeled "Show Wikidata edits *by default* in recent changes". If you don't have it enabled, the default state of the RC filters when you open RC will be such that Wikidata edits aren't shown, but if you then change the filters they may end up being shown. I'm not sure how we could make this clearer. What is a bit confusing is that the way that this excludes Wikidata edits is by filtering for everything else (Page creations, Page edits, Log actions, etc), because the interface always tells you what it is showing (not what it isn't showing). If you remove these filters, all types of changes will be shown, including Wikidata edits, and that confuses some people. But I don't think there's much to do here, unless there are relatively simple ways to clarify this. TASK DETAIL https://phabricator.wikimedia.org/T224426 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Catrope, Etonkovidova, JTannerWMF, Lydia_Pintscher, Ammarpad, Reedy, Patriccck, Urbanecm, Aklapper, darthmon_wmde, 94rain, Nandana, kostajh, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Taiwania_Justo, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T223526: Move Wikidata link from "Toolbox" to "Other projects" section
Catrope added a comment. In T223526#5189549 <https://phabricator.wikimedia.org/T223526#5189549>, @Theklan wrote: > It works (partially). It moves the link only if the "In other projects" section exists. Try this: if ( !$( '#p-wikibase-otherprojects' ).length ) { $( '#p-tb' ).before( $( 'In other projects' ) ); } $( '#p-wikibase-otherprojects ul' ).append( $( '#t-wikibase' ) ); (with "In other projects" changed to the Basque translation of that phrase) TASK DETAIL https://phabricator.wikimedia.org/T223526 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Theklan, Catrope Cc: Catrope, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Trizek-WMF, MMiller_WMF, Inaki-LL, Theklan, darthmon_wmde, alaa_wmde, Ferenczy, sarhan.alaa, Samuditha24, IM3847, Nandana, kostajh, Lahi, Gq86, Xabier.Armendaritz, Gorkaazk, Ksarasola, GoranSMilovanovic, Jayprakash12345, Chicocvenancio, MichaelSchoenitzer_WMDE, QZanden, LawExplorer, Jogi_don, _jensen, rosalieper, D3r1ck01, Samwilson, Wikidata-bugs, Jdlrobson, aude, Mbch331, Rxy ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T223526: Move Wikidata link from "Toolbox" to "Other projects" section
Catrope added a comment. In T223526#5189390 <https://phabricator.wikimedia.org/T223526#5189390>, @Theklan wrote: > Maybe we can do it only for Basque wikipedia using js? The JS for this is pretty simple: $( '#p-wikibase-otherprojects ul' ).append( $('#t-wikibase') ); TASK DETAIL https://phabricator.wikimedia.org/T223526 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Theklan, Catrope Cc: Catrope, Ladsgroup, Lea_Lacroix_WMDE, Lydia_Pintscher, Aklapper, Trizek-WMF, MMiller_WMF, Inaki-LL, Theklan, darthmon_wmde, alaa_wmde, Ferenczy, sarhan.alaa, Samuditha24, IM3847, Nandana, kostajh, Lahi, Gq86, Xabier.Armendaritz, Gorkaazk, Ksarasola, GoranSMilovanovic, Jayprakash12345, Chicocvenancio, MichaelSchoenitzer_WMDE, QZanden, LawExplorer, Jogi_don, _jensen, rosalieper, D3r1ck01, Samwilson, Wikidata-bugs, Jdlrobson, aude, Mbch331, Rxy ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T116762: Notifications in Echo on Wikidata should display label as well as Q id
Catrope added subscribers: MMiller_WMF, Catrope.Catrope moved this task from To Triage to Revisit on the Growth-Team board.Catrope added a comment. We discussed this with the team earlier this week. On a technical note (from me): this would require some Echo work to allow Wikibase to plug in and change how titles are rendered in notifications. I'm not sure offhand how that would be done, maybe through a hook. But I'm assuming that Wikibase already has a utility to get the display label of a given QID in a given language, in which case the hardest part of this task is figuring out how to cleanly integrate this into Echo (or rather, let Wikibase hook into Echo) without making the code in Echo overly Wikibase-specific/dependent. On a product/planning note (from @MMiller_WMF): How important is this in the scheme of things that are being worked on for Wikidata? Our team is pretty busy, so we want to figure out what to do here.TASK DETAILhttps://phabricator.wikimedia.org/T116762WORKBOARDhttps://phabricator.wikimedia.org/project/board/1114/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, MMiller_WMF, Aleksey_WMDE, WMDE-leszek, ChristianKl, Daniel_Mietchen, Sjoerddebruin, Jdforrester-WMF, Legoktm, matej_suchanek, Luke081515, Lydia_Pintscher, Addshore, Aklapper, Nandana, kostajh, Adrian1985, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, D3r1ck01, Taiwania_Justo, SBisson, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183993: Investigate & Fix "According to a SiteLinkLookup Q47013093 is linked to frwiki while it is not or it does not exist" in logs
Catrope added a comment. In T183993#4001382, @daniel wrote: This can happen every now and then due to replag. We should not worry unless this happens a LOT. It happened 550 times over the past hour, which is a significant amount of log spam.TASK DETAILhttps://phabricator.wikimedia.org/T183993EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, daniel, Mbch331, Lucas_Werkmeister_WMDE, WMDE-leszek, Ladsgroup, Addshore, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T171953: ORES and Enhanced Recent Changes: Background color gets stuck after patrolling
Catrope closed this task as "Resolved".Catrope claimed this task.Catrope added a comment. I can no longer reproduce thisTASK DETAILhttps://phabricator.wikimedia.org/T171953EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, Aklapper, PokestarFan, Raymond, Nandana, Kieubinhtb, kostajh, Adrian1985, Asad_Ali_Palijo, Lahi, Gq86, Vacio, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, Mkdw, Taiwania_Justo, MuhammadShuaib, notconfusing, SimmeD, Wikidata-bugs, aude, Alchimista, Ladsgroup, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T171953: ORES and Enhanced Recent Changes: Background color gets stuck after patrolling
Catrope renamed this task from "ORES and Enhanced Recent Changes: Backgound color stucks after patrolling" to "ORES and Enhanced Recent Changes: Background color gets stuck after patrolling". TASK DETAILhttps://phabricator.wikimedia.org/T171953EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Aklapper, PokestarFan, Raymond, Nandana, Kieubinhtb, kostajh, Adrian1985, Asad_Ali_Palijo, Lahi, Gq86, Vacio, GoranSMilovanovic, Soteriaspace, RazeSoldier, Jayprakash12345, JakeTheDeveloper, QZanden, Zoranzoki21, LawExplorer, TerraCodes, Mkdw, Taiwania_Justo, MuhammadShuaib, notconfusing, SimmeD, Wikidata-bugs, aude, Alchimista, Ladsgroup, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Status] T123213: User i18n@wikidata getting 503 when viewing filtered watchlist
Catrope changed the task status from "Open" to "Stalled". TASK DETAILhttps://phabricator.wikimedia.org/T123213EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Mattflaschen-WMF, TTO, I18n, Aklapper, Reedy, StudiesWorld, Analytics.mediafiles, kostajh, MMiller_WMF, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, RHo, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T184174: Expanded watchlist not working on Wikidata
Catrope added a comment. In T184174#3894615, @Mooeypoo wrote: In T184174#3887784, @MichaelSchoenitzer wrote: When you disable the beta-feture again but don't change the url – i.e. you reload the already open page instead of clicking on "watchlist" in the menu – the enhanced watch list does not work anymore. Did I misunderstand? I think he may have confused the terms "enhanced" and "expanded".TASK DETAILhttps://phabricator.wikimedia.org/T184174EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, Mooeypoo, Lea_Lacroix_WMDE, Trizek-WMF, Etonkovidova, MichaelSchoenitzer, Aklapper, Adrian1985, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, jmatazzoni, SBisson, Wikidata-bugs, aude, RandomDSdevel, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T184174: Expanded watchlist not working on Wikidata
Catrope added a comment. @Mooeypoo enhanced=1 controls "group by page", it doesn't control whether the WL shows only the most recent edit for each page, or all edits, and that's what he's talking about.TASK DETAILhttps://phabricator.wikimedia.org/T184174EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, Mooeypoo, Lea_Lacroix_WMDE, Trizek-WMF, Etonkovidova, MichaelSchoenitzer, Aklapper, Adrian1985, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, jmatazzoni, SBisson, Wikidata-bugs, aude, RandomDSdevel, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Status] T184174: Expanded watchlist not working on Wikidata
Catrope changed the task status from "Open" to "Stalled". TASK DETAILhttps://phabricator.wikimedia.org/T184174EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Etonkovidova, MichaelSchoenitzer, Aklapper, Adrian1985, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, jmatazzoni, Trizek-WMF, SBisson, Wikidata-bugs, aude, RandomDSdevel, Catrope, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183266: wikidata.beta.wmflabs.org/wiki/Special:RecentChanges InvalidArgumentException No model available for [goodfaith]
Catrope added a comment. I tried running it, but of course that doesn't work because ores-beta is down: catrope@deployment-tin:~$ mwscript extensions/ORES/maintenance/CheckModelVersions.php wikidatawiki Starting...[71400e18b1a437ff51ed197f] [no req] RuntimeException from line 95 of /srv/mediawiki-staging/php-master/extensions/ORES/includes/Api.php: Failed to make ORES request to [https://ores-beta.wmflabs.org/v3/scores/wikidatawiki/?20171219164528=1=json], There was a problem during the HTTP request: 503 SERVICE UNAVAILABLE Once it's up, though, you should try if running this script fixes it.TASK DETAILhttps://phabricator.wikimedia.org/T183266EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, gerritbot, awight, Ladsgroup, Addshore, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Mkdw, srodlund, Luke081515, Wikidata-bugs, aude, Alchimista, Mbch331, Rxy, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T183266: wikidata.beta.wmflabs.org/wiki/Special:RecentChanges InvalidArgumentException No model available for [goodfaith]
Catrope added a comment. Maybe the maintenance scripts to set up ORES on wikidatawiki were run wrong?TASK DETAILhttps://phabricator.wikimedia.org/T183266EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, gerritbot, awight, Ladsgroup, Addshore, Aklapper, Cpaulf30, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Mkdw, srodlund, Luke081515, Wikidata-bugs, aude, Alchimista, Mbch331, Rxy, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T183232: Beta enwiki is broken: EntityLookupException in Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php: Failed to unserialize the content object
Catrope closed this task as "Resolved".Catrope claimed this task.Catrope added a comment. This is fallout from T183252: Unbreak replication in beta labs. I've fixed enwiki but not wikidatawiki yet, so that's probably why it's fixed now.TASK DETAILhttps://phabricator.wikimedia.org/T183232EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, Addshore, zeljkofilipin, MarcoAurelio, KartikMistry, Aklapper, Petar.petkovic, Lahi, Gq86, GoranSMilovanovic, QZanden, TerraCodes, Liudvikas, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T179241: Enable the ArticlePlaceholder for Northern Sami (sewiki)
Catrope added a comment. This is deployed now, but someone will need to create https://se.wikipedia.org/wiki/Málle:AboutTopic for this to work properly.TASK DETAILhttps://phabricator.wikimedia.org/T179241EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21, CatropeCc: Catrope, Stashbot, Nemo_bis, Nikerabbit, gerritbot, Aklapper, jhsoby, Lea_Lacroix_WMDE, Lydia_Pintscher, Lucie, hoo, jhsoby-WMNO, Lahi, Gq86, Baloch007, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, cmadeo, Zoranzoki21, Lewizho99, Maathavan, DatGuy, Devwaker, Urbanecm, JEumerus, Tulsi_Bhagat, Wong128hk, Luke081515, SimmeD, biplabanand, Wikidata-bugs, Snowolf, aude, Dcljr, jayvdb, Ricordisamoa, Jdforrester-WMF, Matanya, Mbch331, Rxy, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171027: "Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis
Catrope added a comment. In T171027#3680606, @IKhitron wrote: Hi, @Johan. Recent changes or watchlists? Both. But the statement should really make that clearer. It uses RC and WL as if they're interchangeable, and in the code they kind of are because they use the same underlying infrastructure, but most non-technical people won't know that.TASK DETAILhttps://phabricator.wikimedia.org/T171027EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespo, CatropeCc: Alsee, awight, Matthewrbowker, Noella94, Nirmos, Stryn, Mike_Peel, Capankajsmilyo, Elitre, Risker, Peachey88, Stashbot, Finavon, WMDE-leszek, saper, Masti, Lydia_Pintscher, D3r1ck01, matej_suchanek, Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, Lordiis, GoranSMilovanovic, Adik2382, Abiyoyo, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Jack_who_built_the_house, Lewizho99, Minhnv-2809, Maathavan, Poyekhali, Volker_E, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171027: "Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis
Catrope added a comment. In T171027#3677449, @Catrope wrote: Thanks, I'll experiment with removing the STRAIGHT_JOIN, as well as with @awight's suggestion at T164796#3560530 of breaking out the change tags rollup. This is tracked over at T176456: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on, but just to close the loop here: removing the STRAIGHT_JOIN (on watchlist but not RC) appears to work. I wrote a patch for that, it was merged, and I'm SWATting it to wmf.3 in the upcoming SWAT window in 15 minutes.TASK DETAILhttps://phabricator.wikimedia.org/T171027EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespo, CatropeCc: Alsee, awight, Matthewrbowker, Noella94, Nirmos, Stryn, Mike_Peel, Capankajsmilyo, Elitre, Risker, Peachey88, Stashbot, Finavon, WMDE-leszek, saper, Masti, Lydia_Pintscher, D3r1ck01, matej_suchanek, Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, Lordiis, GoranSMilovanovic, Adik2382, Abiyoyo, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Jack_who_built_the_house, Lewizho99, Minhnv-2809, Maathavan, Poyekhali, Volker_E, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171027: "Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis
Catrope added a subscriber: awight.Catrope added a comment. Thanks, I'll experiment with removing the STRAIGHT_JOIN, as well as with @awight's suggestion at T164796#3560530 of breaking out the change tags rollup.TASK DETAILhttps://phabricator.wikimedia.org/T171027EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespo, CatropeCc: awight, Matthewrbowker, Noella94, Nirmos, Stryn, Mike_Peel, Capankajsmilyo, Elitre, Risker, Peachey88, Stashbot, Finavon, WMDE-leszek, saper, Masti, Lydia_Pintscher, D3r1ck01, matej_suchanek, Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, Lordiis, GoranSMilovanovic, Adik2382, Abiyoyo, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Jack_who_built_the_house, Lewizho99, Minhnv-2809, Maathavan, Poyekhali, Volker_E, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171027: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis
Catrope added a comment. Thanks @jcrespo , @Reedy and @Ladsgroup for taking action. In T171027#3668493, @jcrespo wrote: Notification for users: We are going to disable wikidata recentchanges (meaning, changes on pages on other wikis coming from changes done on wikidata; the recentchanges at wikidata is not a problem) due to performance concerns. Once those have been fixed, the functionality could be enabled again. To clarify: it looks like WD RC is only disabled on commonswiki and ruwiki right now, and while @Reedy has submitted a patch to disable it everywhere else, that hasn't been deployed yet. Is that planned for the future?TASK DETAILhttps://phabricator.wikimedia.org/T171027EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: jcrespo, CatropeCc: Peachey88, Stashbot, Finavon, WMDE-leszek, saper, Masti, Lydia_Pintscher, D3r1ck01, matej_suchanek, Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, Lordiis, GoranSMilovanovic, Adik2382, Abiyoyo, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Vali.matei, Jack_who_built_the_house, Lewizho99, Minhnv-2809, Maathavan, Poyekhali, Volker_E, Izno, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171027: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis
Catrope added a comment. Thanks for the detailed analysis @Bawolff and @jcrespo . My $0.02: Given the overwhelming number of Wikidata entries in the RC table (95% or more on some wikis, I was very surprised by that), I think that's the main problem that we should tackle. @Bawolff's split query approach is also promising, but it's kind of orthogonal as it speeds up the whole query more or less independent of the Wikidata issue, and I'm a bit concerned that the code is kind of scary and possibly fragile. There are four main ways that I can see us tackling the Wikidata flood problem: Reducing wasteful Wikidata entires (unused languages, unused properties) Segregating Wikidata RC entries (and possibly categorization too, since that's significant on some wikis) into a separate table Adding rc_type or rc_source (which one? these two fields seem largely redundant with each other) to the start of some indexes, so that queries that don't need to look at Wikidata rows can filter them out efficiently Disable Wikidata RC on large wikis until we have a more scalable implementation of the feature #1 is something that should be done regardless because it would make users happy (people already complain about being spammed with updates to languages they don't speak), and it sounds like it's already being worked on. I don't know how hard that is or how long it would take, but AFAIK the Wikidata team started working on it a month ago, so it might take a while yet. Every reduction in wasteful entries would only affect new entries, so it would slowly improve query performance over days or weeks after deployment, as the older generation of wasteful entries falls off the time horizons of these queries. And a very large reduction would need to be achieved to address the issue properly. Right now, Wikidata is 95% of the RC table on commons; if the number of Wikidata rows were reduced by a factor of 10, it would still be 67%, and we'd need a 21x reduction just to get below 50%. So while this seems like a good long-term plan, I worry that it wouldn't make a dent for quite some time. #2 would require creating a new table, and would require changing the code that generates RC entries (to write them to the right table) and all the code that queries the RC table (to query the right table, or when needed to query both tables with a UNION). The latter could be done in a similar way to @Bawolff's proof of concept for the split query, by rewriting the query right before it's executed. It'd require some trickery and could be a bit fragile, but we'd get an immediate performance boost for queries that exclude Wikidata (they'd need to scan 20x fewer rows on the worst-flooded wikis) and hopefully still decent performance for queries that don't. #3 should in theory (AIUI) have the same performance benefits as #2, but without having to change any code: if an index starting with rc_type is used, the query should behave roughly as if every type of query is in its own table. I wonder if this would work in practice though, because I don't expect that MySQL would use an index to satisfy a != condition (even if that value is 95% of the table); but maybe rc_type IN (all, other, values) would work? @jcrespo: How well do you think an index could approximate the effect of a separate table? Would a PARTITION like we use on the revision table work, perhaps? As for #4, that should be pretty easy to do (IIRC Wikidata RC generation is disableable, and a background script could delete old rows starting with the most recent ones) and should alleviate the issue pretty quickly too, but it would also be disruptive to people who use the feature; on the other hand, query timeouts on the watchlist are also disruptive, to a different group of people. So I think we should only do this if there isn't another way that we can get the issue under control in a reasonable amount of time.TASK DETAILhttps://phabricator.wikimedia.org/T171027EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Trizek-WMF, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, GoranSMilovanovic, Abiyoyo, QZanden, Vali.matei, Jack_who_built_the_house, Poyekhali, Volker_E, Izno, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168487: ORES: Don't highlight changes propagated from Wikidata
Catrope added a comment. In T168487#3474933, @SBisson wrote: From the task description: There should be no highlighting for these rows regardless of whether it's using the original ORES highlighting or the newer highlighting done by RC Page itself. Note that the patch above doesn't handle the original ORES highlighting. Good point, I'll fix that. Also, not sure how wikidata and log entries end up with scores. The ORES extension fetches scores only for RC_EDIT and RC_NEW.[1] Log entries aren't scored in practice, but I wanted to be paranoid/consistent. Wikidata entries end up with a score because their rc_this_oldid refers to the oldid of the revision on wikidatawiki, but then gets joined against the local (e.g. enwiki) revision table. If the sizes of the two revision tables line up in the right way, that join will succeed and find a score for a completely unrelated local edit. [1] https://phabricator.wikimedia.org/diffusion/EORS/browse/master/includes/Hooks.php;9aad3388866bf99de0862fe7a28deec9979089b9$76 TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: SBisson, gerritbot, PokestarFan, Catrope, Halfak, Aklapper, Mattflaschen-WMF, bkowshik, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Avner, Lewizho99, Maathavan, Iniquity, jmatazzoni, Izno, Wikidata-bugs, aude, He7d3r, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168487: ORES: Don't highlight changes propagated from Wikidata
Catrope added a comment. In T168487#3473450, @gerritbot wrote: Change 367841 had a related patch set uploaded (by Catrope; owner: Catrope): [mediawiki/extensions/ORES@master] Treat RC_LOG and RC_EXTERNAL rows as unscorable https://gerrit.wikimedia.org/r/367841 This patch does the following: When highlighting changes based on ORES filters, do not highlight log actions and Wikidata changes, even if we think we have a score for them (because that score will be wrong) When filtering based on ORES score (i.e. one of the damaging/goodfaith filters is active), exclude log actions and Wikidata changes, even if the "type of change" filter selection says we should be including them TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: gerritbot, PokestarFan, Catrope, Halfak, Aklapper, Mattflaschen-WMF, bkowshik, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Avner, Lewizho99, Maathavan, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T168487: ORES: Don't highlight changes propagated from Wikidata
Catrope moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.Catrope claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T168487WORKBOARDhttps://phabricator.wikimedia.org/project/board/2828/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: gerritbot, PokestarFan, Catrope, Halfak, Aklapper, Mattflaschen-WMF, bkowshik, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Avner, Lewizho99, Maathavan, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159787: Add Wikidata to new RC Filters UI
Catrope added a comment. In T159787#3440455, @jmatazzoni wrote: @Mattflaschen-WMF, I'm sure this is necessary but I don't understand what it's about. As far as I can see, Wikidata already is an option in the Type of Change filter group. What do we still need to accomplish, and what's Blocking us? Also, is this something we should do before we graduate the filters out of beta? I think this task itself is done, it's just suffering from two bugs that have been marked as subtasks of this task: T162628: 'Wikidata edits' filter does not recognize registered wikidata users (duped to T51315: [Story] record wikibase recent change entries attributed as non-anon as a pre-existing Wikidata issue) and T158025: Support ORES for propagated Wikidata edits. The former is about the registered/unregistered filters/highlights not working correctly for Wikidata edits, and the latter is about the ORES filters/highlights producing nonsense for Wikidata edits. We worked around the part of the latter by making WD+ORES a conflict state, but that only hides some of the worst of the problem, not even all of it. Things like Newpages+WD+ORES will still give weird results. As far as I'm concerned, we can separate those bugs from this task and close this task. T162630: 'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns results but the filter selection displayed as a conflict is also a subtask but that one is already fixed as far as I can tell. The registered/unregistered issue already has a patch that Matt has gotten feedback on and is improving, so I think it's worth finishing that patch which will fix that issue. As for the ORES issue, that one is harder, and we could consider dropping that one or prioritizing it less highly. There are some simple hacks we can put in place to hide the issue better (basically, deliberately ignoring ORES scores for WD entries and treating them all as unscored/unscorable).TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMF, CatropeCc: jmatazzoni, Etonkovidova, Liuxinyu970226, Catrope, gerritbot, Aklapper, Mattflaschen-WMF, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Iniquity, Izno, SBisson, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168487: ORES: Don't highlight changes propagated from Wikidata
Catrope added a comment. In T168487#3391019, @Halfak wrote: Is this something that the ORES Review Tool is doing? I'm confused. Both the ORT and RCFilters do this. As I understand it, the culprit is that recentchanges rows that come from Wikidata have an rc_this_oldid that refers to a revision ID on wikidatawiki rather than the local wiki. The code dealing with RC rows assumes that rc_this_oldid refers to a local revid and uses that to join against the revision table; that's a reasonable expectation, but Wikidata violates it, and so Wikidata RC rows will be highlighted/filtered based on the ORES score of the (totally unrelated) local revision that happens to have same ID as the Wikidata revision (if such a revision exists and if it has a score, but on some wikis that appears to be common). T158025: Support ORES for propagated Wikidata edits aims to fix this for real and get the correct ORES score in there, but pending that we should consider treating Wikidata rows as if they have no score at all.TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, Halfak, Aklapper, Mattflaschen-WMF, bkowshik, GoranSMilovanovic, QZanden, Kaartic, Avner, Iniquity, jmatazzoni, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T165011: Global default 'hard' is invalid for field oresDamagingPref
Catrope added a comment. In T165011#3255414, @Ladsgroup wrote: Well, I was working on it but I will happy to help and collaborate. What I've got so far is that hewiki is okay even though their configs is almost identical and both are on wmf-30.1 I think it's because Wikidata's default sensitivity is set to 'hard', but the corresponding damaging level ('maybebad') is set to false in the threshold settings. No other wiki had this problem except fawiki, which is in group2, and this only started mattering with rEORSc047cd54d69e: Align damaging thresholds to filters thresholds which is in wmf.1.TASK DETAILhttps://phabricator.wikimedia.org/T165011EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: gerritbot, Etonkovidova, Fralambert, Liuxinyu970226, Saerdnaer, Ladsgroup, Lydia_Pintscher, Lea_Lacroix_WMDE, Trizek-WMF, TerraCodes, matej_suchanek, Jay8g, Aklapper, mmodell, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Avner, Lewizho99, Maathavan, Izno, LNDDYL, Wikidata-bugs, aude, Catrope, He7d3r, Mbch331, Krenair, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T158025: Support ORES for propagated Wikidata edits
Catrope added a comment. Hmm, if only we had support for ORES scores for non-revision objects (like log entries or RC rows), then this'd be much easier.TASK DETAILhttps://phabricator.wikimedia.org/T158025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, jmatazzoni, Aklapper, Mattflaschen-WMF, QZanden, Avner, Iniquity, Izno, SBisson, Wikidata-bugs, aude, He7d3r, Ladsgroup, Mbch331, tarlocesilion, Legoktm___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reassigned] T159787: Add Wikidata to new RC Filters UI
Catrope reassigned this task from Catrope to Mattflaschen-WMF. TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMF, CatropeCc: Catrope, gerritbot, Aklapper, Mattflaschen-WMF, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, JJMC89, Maathavan, jmatazzoni, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T159787: Add Wikidata to new RC Filters UI
Catrope claimed this task. TASK DETAILhttps://phabricator.wikimedia.org/T159787EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: gerritbot, Aklapper, Mattflaschen-WMF, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, JJMC89, Maathavan, jmatazzoni, D3r1ck01, Izno, Wikidata-bugs, aude, Catrope, Mbch331, tarlocesilion___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T160274: Interlanguage links not appearing on Flow pages
Catrope moved this task from Untriaged to External on the Collaboration-Team-Triage board.Catrope added a comment. I'm guessing this is probably a bug in how #wikidata injects these language links? If it turns out to be a bug in Flow, or if Flow turns out to do something unhelpful, please do let us know.TASK DETAILhttps://phabricator.wikimedia.org/T160274WORKBOARDhttps://phabricator.wikimedia.org/project/board/65/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, Liuxinyu970226, The_Discoverer, Aklapper, 45Jayjay1969, QZanden, EnricoCNC, D3r1ck01, Izno, SBisson, Wikidata-bugs, aude, Gryllida, jeblad, TTO, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T46222: Wikidata watchlist/RC items broken with enhanced recent changes enabled
Catrope added a comment. In T46222#515378, @aude wrote: https://gerrit.wikimedia.org/r/#/c/48438/ will omit Wikidata edits for now, until we can get the necessary changes needed into MediaWiki core and the extension. (and then get it deployed) I can't promise a timeframe for this, but hope to have full support for enhanced changes format in the next few weeks. Is this ever going to be addressed? I was digging through the history of the relevant code in Wikidata and eventually found this bug. I've submitted a patch to make it clearer what's happening and why for future readers of the code, but it'd be nice to be able to remove this odd 4-year-old hack at some point.TASK DETAILhttps://phabricator.wikimedia.org/T46222EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Catrope, gerritbot, StudiesWorld, Wikidata-bugs, Abraham, aude, Tgr, Unknown Object (MLST), Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T154555: Special:SetSiteLink, other SpecialModifyEntity subclasses open master connection on GET
Catrope changed the title from "Special:SetSiteLink opens master connection on GET" to "Special:SetSiteLink, other SpecialModifyEntity subclasses open master connection on GET".Catrope edited the task description. (Show Details) EDIT DETAILSSeems to happen for every request of the form `/wiki/Special:SetSiteLink/Qnn`. There are also lots of other ones in the logs from other subclasses of SpecialModifyEntity. ```...TASK DETAILhttps://phabricator.wikimedia.org/T154555EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Amire80, daniel, Johan, Glaisher, Nemo_bis, Gilles, PleaseStand, Krenair, Joe, aaron, gerritbot, MZMcBride, Aklapper, Catrope, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T154596: SpecialModifyEntity master queries on page views
Catrope added a comment. Duping this one to the other one because the other one has a patch attached to it that solves the problem for all SpecialModifyEntity subclasses.TASK DETAILhttps://phabricator.wikimedia.org/T154596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, CatropeCc: Catrope, Joe, Krenair, PleaseStand, gerritbot, Aklapper, Gilles, Nemo_bis, MZMcBride, Glaisher, Johan, daniel, Amire80, aaron, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, akosiaris___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T154596: SpecialModifyEntity master queries on page views
Catrope closed this task as a duplicate of T154555: Special:SetSiteLink opens master connection on GET.Herald removed a subscriber: Liuxinyu970226. TASK DETAILhttps://phabricator.wikimedia.org/T154596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, CatropeCc: Catrope, Joe, Krenair, PleaseStand, gerritbot, Aklapper, Gilles, Nemo_bis, MZMcBride, Glaisher, Johan, daniel, Amire80, aaron, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, akosiaris___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T154555: Special:SetSiteLink opens master connection on GET
Catrope added subscribers: aaron, Joe, Krenair, PleaseStand, Gilles, Nemo_bis, Glaisher, Johan, daniel, Amire80.Catrope merged a task: T154596: SpecialModifyEntity master queries on page views. TASK DETAILhttps://phabricator.wikimedia.org/T154555EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Amire80, daniel, Johan, Glaisher, Nemo_bis, Gilles, PleaseStand, Krenair, Joe, aaron, gerritbot, MZMcBride, Aklapper, Catrope, Th3d3v1ls, Ramalepe, Liugev6, Lewizho99, Maathavan, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T154596: SpecialModifyEntity master queries on page views
Catrope added a comment. This related to / almost a duplicate of T154555: Special:SetSiteLink opens master connection on GET. Both SpecialSetSiteLink from that bug and SpecialSetLabelDescriptionAliases from this bug are subclasses of SpecialModifyEntity.TASK DETAILhttps://phabricator.wikimedia.org/T154596EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaron, CatropeCc: Catrope, Joe, Krenair, PleaseStand, gerritbot, Aklapper, Gilles, Nemo_bis, MZMcBride, Glaisher, Johan, daniel, Amire80, Liuxinyu970226, aaron, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, akosiaris___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T154555: Special:SetSiteLink opens master connection on GET
Catrope added a parent task: T92357: Fix problematic database master queries performed on HTTP GET/HEAD. TASK DETAILhttps://phabricator.wikimedia.org/T154555EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Aklapper, Catrope, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T154555: Special:SetSiteLink opens master connection on GET
Catrope created this task.Catrope added projects: Wikidata, Availability, MediaWiki-extensions-WikibaseRepository.Herald added a subscriber: Aklapper. TASK DESCRIPTIONSeems to happen for every request of the form /wiki/Special:SetSiteLink/Qnn Expectation (masterConns <= 0) by MediaWiki::main not met: [connect to 10.64.16.144 (wikidatawiki)] #0 /srv/mediawiki/php-1.29.0-wmf.6/includes/libs/rdbms/TransactionProfiler.php(160): TransactionProfiler->reportExpectationViolated() #1 /srv/mediawiki/php-1.29.0-wmf.6/includes/libs/rdbms/loadbalancer/LoadBalancer.php(587): TransactionProfiler->recordConnection() #2 /srv/mediawiki/php-1.29.0-wmf.6/includes/dao/DBAccessBase.php(61): LoadBalancer->getConnection() #3 /srv/mediawiki/php-1.29.0-wmf.6/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php(214): DBAccessBase->getConnection() #4 /srv/mediawiki/php-1.29.0-wmf.6/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php(98): Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->selectRevisionInformationMultiple() #5 /srv/mediawiki/php-1.29.0-wmf.6/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php(151): Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->loadRevisionInformation() #6 /srv/mediawiki/php-1.29.0-wmf.6/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php(84): Wikibase\Lib\Store\Sql\PrefetchingWikiPageEntityMetaDataAccessor->loadRevisionInformation() #7 /srv/mediawiki/php-1.29.0-wmf.6/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialModifyEntity.php(197): Wikibase\Lib\Store\WikiPageEntityRevisionLookup->getEntityRevision() #8 /srv/mediawiki/php-1.29.0-wmf.6/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialModifyEntity.php(180): Wikibase\Repo\Specials\SpecialModifyEntity->loadEntity() #9 /srv/mediawiki/php-1.29.0-wmf.6/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialSetSiteLink.php(108): Wikibase\Repo\Specials\SpecialModifyEntity->prepareArguments() #10 /srv/mediawiki/php-1.29.0-wmf.6/extensions/Wikidata/extensions/Wikibase/repo/includes/Specials/SpecialModifyEntity.php(129): Wikibase\Repo\Specials\SpecialSetSiteLink->prepareArguments() #11 /srv/mediawiki/php-1.29.0-wmf.6/includes/specialpage/SpecialPage.php(522): Wikibase\Repo\Specials\SpecialModifyEntity->execute() #12 /srv/mediawiki/php-1.29.0-wmf.6/includes/specialpage/SpecialPageFactory.php(577): SpecialPage->run() #13 /srv/mediawiki/php-1.29.0-wmf.6/includes/MediaWiki.php(283): SpecialPageFactory::executePath() #14 /srv/mediawiki/php-1.29.0-wmf.6/includes/MediaWiki.php(851): MediaWiki->performRequest() #15 /srv/mediawiki/php-1.29.0-wmf.6/includes/MediaWiki.php(512): MediaWiki->main() #16 /srv/mediawiki/php-1.29.0-wmf.6/index.php(43): MediaWiki->run() #17 /srv/mediawiki/w/index.php(3): include() #18 {main}TASK DETAILhttps://phabricator.wikimedia.org/T154555EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Aklapper, Catrope, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T117457: Do not apply rounding when formatting Quantities (unless unit conversion was applied)
Catrope removed a project: Collab-Archive-2015-2016. TASK DETAILhttps://phabricator.wikimedia.org/T117457EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CatropeCc: Urbanecm, TerraCodes, Luke081515, Thryduulf, daniel, Stryn, Lydia_Pintscher, Liuxinyu970226, Snipre, Event, Ash_Crow, mgrabovsky, Micru, Denny, He7d3r, Bene, Wikidata-bugs, Ricordisamoa, Kelson, MSGJ, Klortho, Wolfvoll, Aklapper, Darkdadaah, DixonD, jeblad, D3r1ck01, Izno, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)
Catrope removed a project: Collaboration-Team-Current. TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen, Catrope Cc: Catrope, Mattflaschen, gerritbot, StudiesWorld, daniel, Anomie, JanZerebecki, Aklapper, Izno, Luke081515, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, Krenair, Joe, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T127275: Wikibase RL module mw.config.values.wbSiteDetails repeatedly flapping
Catrope added a subscriber: Krinkle. TASK DETAIL https://phabricator.wikimedia.org/T127275 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Krinkle, Aklapper, Jdforrester-WMF, StudiesWorld, Izno, Wikidata-bugs, aude, GWicke, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma)
Catrope closed this task as "Resolved". Catrope added a subscriber: Catrope. TASK DETAIL https://phabricator.wikimedia.org/T103346 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mattflaschen, Catrope Cc: Catrope, Mattflaschen, gerritbot, StudiesWorld, daniel, Anomie, JanZerebecki, Aklapper, Izno, Luke081515, Wikidata-bugs, aude, Dinoguy1000, jayvdb, MrStradivarius, Jackmcbarn, Mbch331, Krenair, Joe, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T112073: Wikibase lua tracking bug
Catrope closed blocking task T103346: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma) as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T112073 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Ricordisamoa, aude, Aklapper, Izno, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T18976: Wikis waiting for creation (tracking)
Catrope removed a subscriber: Catrope. TASK DETAIL https://phabricator.wikimedia.org/T18976 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: JEumerus, greg, Krenair, Aklapper, Meno25, Matanya, Arseny1992, aude, brion, Amire80, Ebe123, SPQRobin, mxn, TTO, Az1568, Pathoschild, Merl, Petrb, Steinsplitter, revi, Glaisher, Rschen7754, Peachey88, Kanjy, Snowolf, Hkjacksonhk, Liuxinyu970226, jeremyb, MF-Warburg, Stryn, zhuyifei1999, Dcljr, Dereckson, JohnLewis, Luke081515, Wikidata-bugs, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T116485: Echo should not notify the user about his own linking activity
Catrope moved this task to Needs Review on the Collaboration-Team-Current workboard. TASK DETAIL https://phabricator.wikimedia.org/T116485 WORKBOARD https://phabricator.wikimedia.org/project/board/1384/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Legoktm, Catrope Cc: gerritbot, aaron, IKhitron, Kipod, Sjoerddebruin, He7d3r, Aklapper, Luke081515, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T116485: Echo should not notify the user about his own linking activity
Catrope moved this task to QA Review on the Collaboration-Team-Current workboard. TASK DETAIL https://phabricator.wikimedia.org/T116485 WORKBOARD https://phabricator.wikimedia.org/project/board/1384/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Legoktm, Catrope Cc: gerritbot, aaron, IKhitron, Kipod, Sjoerddebruin, He7d3r, Aklapper, Luke081515, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T116611: Enable the Wikidata personal talk opt-in Beta Feature on Wikidata.org
Catrope added subscribers: Catrope, Quiddity. TASK DETAIL https://phabricator.wikimedia.org/T116611 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Quiddity, Catrope, Aklapper, Lydia_Pintscher, Jdforrester-WMF, Matanya, Luke081515, Wikidata-bugs, Snowolf, matthiasmullie, aude, Gryllida, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T116611: Enable the Wikidata personal talk opt-in Beta Feature on Wikidata.org
Catrope added a subscriber: Trizek-WMF. TASK DETAIL https://phabricator.wikimedia.org/T116611 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Trizek-WMF, Quiddity, Catrope, Aklapper, Lydia_Pintscher, Jdforrester-WMF, Matanya, Luke081515, Wikidata-bugs, Snowolf, matthiasmullie, aude, Gryllida, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T107584: Enable Flow for Wiki Loves Open Data discussion page
Catrope triaged this task as Normal priority. TASK DETAIL https://phabricator.wikimedia.org/T107584 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyH, Catrope Cc: Catrope, Stryn, Qgil, Aklapper, Wikidata-bugs, matthiasmullie, aude, Gryllida, Quiddity, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Assigned] T107584: Enable Flow for Wiki Loves Open Data discussion page
Catrope assigned this task to DannyH. Catrope added a subscriber: Catrope. TASK DETAIL https://phabricator.wikimedia.org/T107584 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyH, Catrope Cc: Catrope, Stryn, Qgil, Aklapper, Wikidata-bugs, matthiasmullie, aude, Gryllida, Quiddity, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T102733: Wikidata registers ResourceLoader module called 'dependencies'
Catrope created this task. Catrope added a subscriber: Catrope. Catrope added projects: MediaWiki-ResourceLoader, Wikidata, Technical-Debt. Herald added a subscriber: Aklapper. TASK DESCRIPTION This is already fixed upstream in DataTypes on github: https://github.com/wmde/DataTypes/blame/master/js/resources.php but it just missed the 0.4.1 release by a few days. TASK DETAIL https://phabricator.wikimedia.org/T102733 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Aklapper, Catrope, Wikidata-bugs, aude, Jdforrester-WMF, Legoktm, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs