[Wikidata-bugs] [Maniphest] [Changed Subscribers] T104707: labels with #039; should be converted to '
Sjoerddebruin added a subscriber: Sjoerddebruin. TASK DETAIL https://phabricator.wikimedia.org/T104707 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sjoerddebruin Cc: Sjoerddebruin, Romaine, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T101950: Goal: Establish a framework to engage with data engineers and open data organizations
Qgil edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T101950 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil Cc: Hjfocs, Jane023, I9606, Scott_WUaS, Abraham, Susannaanas, Multichill, Smalyshev, Romaine, Wittylama, Sadads, Yair_rand, Lydia_Pintscher, SVentura, Qgil, Aklapper, Wikidata-bugs, aude, Gryllida, Rfarrand, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T104695: Deprecate Entity methods not in EntityDocument
Lydia_Pintscher set Security to None. Lydia_Pintscher set Story Points to 1. TASK DETAIL https://phabricator.wikimedia.org/T104695 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, Lydia_Pintscher Cc: Aklapper, Bene, thiemowmde, JeroenDeDauw, daniel, JanZerebecki, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T78286: Add Label/Description/Alias interfaces
Lydia_Pintscher set Story Points to 1. TASK DETAIL https://phabricator.wikimedia.org/T78286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, Lydia_Pintscher Cc: Aklapper, Lucie, Wikidata-bugs, aude, JeroenDeDauw, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98290: Remove deprecated methods from Entity and subtypes
thiemowmde added a comment. https://github.com/wmde/WikibaseDataModel/pull/515 TASK DETAIL https://phabricator.wikimedia.org/T98290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, thiemowmde Cc: JanZerebecki, daniel, JeroenDeDauw, thiemowmde, Bene, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T101950: Goal: Establish a framework to engage with data engineers and open data organizations
Qgil edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T101950 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil Cc: Hjfocs, Jane023, I9606, Scott_WUaS, Abraham, Susannaanas, Multichill, Smalyshev, Romaine, Wittylama, Sadads, Yair_rand, Lydia_Pintscher, SVentura, Qgil, Aklapper, Wikidata-bugs, aude, Gryllida, Rfarrand, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T104701: Create https://www.wikidata.org/wiki/Wikidata:Wiki_Loves_Open_Data project page (or equivalent)
Lydia_Pintscher added a project: Wikidata. Lydia_Pintscher added a comment. Should probably have a concept for how to integrate with the existing pages https://www.wikidata.org/wiki/Special:MyLanguage/Wikidata:Data_donation and https://www.wikidata.org/wiki/Special:MyLanguage/Wikidata:Data_access TASK DETAIL https://phabricator.wikimedia.org/T104701 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil, Lydia_Pintscher Cc: Aklapper, Qgil, SVentura, Lydia_Pintscher, Yair_rand, Sadads, Wittylama, Romaine, Smalyshev, Multichill, Susannaanas, Abraham, Scott_WUaS, I9606, Jane023, Hjfocs, Wikidata-bugs, aude, Gryllida, Rfarrand, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T104707: labels with #039; should be converted to '
Romaine created this task. Romaine added a subscriber: Romaine. Romaine added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION Bots have added many sitelinks and labels to Wikidata. In the past (?) this has gone wrong for labels with an ' in the title. Instead of the ' the html code #039; was added. The search function of Wikidata does not help finding these codes. Example of change requested: https://www.wikidata.org/w/index.php?title=Q2303027type=revisiondiff=225915198oldid=87618167 TASK DETAIL https://phabricator.wikimedia.org/T104707 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Romaine Cc: Romaine, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T104609: Warning: Encountered an entity without an EntityId
Lydia_Pintscher moved this task to consider for next sprint on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T104609 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: daniel, hoo, Lydia_Pintscher, demon, Aklapper, Wikidata-bugs, aude, Krenair, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T104460: Add tests for options for the PAGEBANNER function
Lydia_Pintscher moved this task to monitoring on the Wikidata workboard. TASK DETAIL https://phabricator.wikimedia.org/T104460 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sumit, Lydia_Pintscher Cc: Aklapper, Sumit, Jdlrobson, Nicolas_Raoul, Bene, gerritbot, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T78134: Adapt red links on the translation - part 2
Amire80 moved this task to CX6 on the MediaWiki-extensions-ContentTranslation workboard. TASK DETAIL https://phabricator.wikimedia.org/T78134 WORKBOARD https://phabricator.wikimedia.org/project/board/776/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Amire80 Cc: Arrbee, Aklapper, Wikidata-bugs, aude, Jsahleen, KartikMistry, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103554: missing message wbqc-desc
soeren.oldag added a subscriber: soeren.oldag. soeren.oldag added a comment. see https://gerrit.wikimedia.org/r/#/c/221083/ TASK DETAIL https://phabricator.wikimedia.org/T103554 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: soeren.oldag Cc: soeren.oldag, Jim_Carter, JanZerebecki, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reopened] T89661: Enforce uniqueness of property aliases
Lydia_Pintscher reopened this task as Open. Lydia_Pintscher added a comment. Reopening because of revert. TASK DETAIL https://phabricator.wikimedia.org/T89661 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel, Lydia_Pintscher Cc: Pigsonthewing, Sjoerddebruin, Lydia_Pintscher, Bene, JeroenDeDauw, JanZerebecki, hoo, aude, Aklapper, daniel, Wikidata-bugs, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T101107: Allow selecting properties by aliases
Lydia_Pintscher reopened blocking task T89661: Enforce uniqueness of property aliases as Open. TASK DETAIL https://phabricator.wikimedia.org/T101107 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher Cc: Aklapper, Bene, hoo, Lydia_Pintscher, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T102992: Review WikidataQuality DB schema
daniel added a comment. The index names are off: CREATE INDEX /*i*/wbqc_constraints_pid_index ON /*_*/wbqc_constraints (pid); is redundant, it should be CREATE INDEX /*i*/pid ON /*_*/wbqc_constraints (pid); on mysql, this will create a pid index on the wbqc_constraints table. On SqlLite, /*i*/ will expand to the table name, making the index name unique, resulting in an index called wbqc_constraints_qid, which is what we want. The current code creates an index called `wbqc_constraints_wbqc_constraints_pid_index`, which seems a bit silly. Index names are pretty irellevant, unless you use FORCE INDEX somewhere. In that case, make sure to get it right... TASK DETAIL https://phabricator.wikimedia.org/T102992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: jcrespo, Tamslo, csteipp, Springle, hoo, Aklapper, daniel, Wikidata-bugs, aude, GWicke, Krenair, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T102992: Review WikidataQuality DB schema
Jonaskeutel added a subscriber: Jonaskeutel. Jonaskeutel added a comment. In Version two we have a data issues special page where we want to be able to filter all violations by constraint_type_qid, so we think, an index makes sense. Yes, wbq_violations is unused in v1 and it actually is removed from that version. wbq_evaluation is also removed and will not come back. Instead, we use wfDebugLog for the evaluation. TASK DETAIL https://phabricator.wikimedia.org/T102992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jonaskeutel Cc: Jonaskeutel, jcrespo, Tamslo, csteipp, Springle, hoo, Aklapper, daniel, Wikidata-bugs, aude, GWicke, Krenair, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
Tobi_WMDE_SW added subscribers: JanZerebecki, Tobi_WMDE_SW. Tobi_WMDE_SW added a comment. Patch is merged, is this resolved now? @addshore @janzerebecki TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Tobi_WMDE_SW Cc: Tobi_WMDE_SW, JanZerebecki, gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
JanZerebecki moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T103626 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, JanZerebecki Cc: Tobi_WMDE_SW, JanZerebecki, gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T71345: Machine translation not applied to article title
Ricordisamoa added a subscriber: Ricordisamoa. TASK DETAIL https://phabricator.wikimedia.org/T71345 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ricordisamoa Cc: Ricordisamoa, Wikidata, Amire80, Jsahleen, Arrbee, santhosh, dchan, wikibugs-l-list, Pginer-WMF, KartikMistry, Nikerabbit, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T104187: Move services in DataModel to DataModel Services
Tobi_WMDE_SW closed blocking task T102629: Request Gerrit repository for WikibaseDataModelServices as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T104187 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc: hoo, Tpt, thiemowmde, Addshore, Bene, JeroenDeDauw, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T102629: Request Gerrit repository for WikibaseDataModelServices
Tobi_WMDE_SW moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T102629 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, Tobi_WMDE_SW Cc: Bene, Lydia_Pintscher, Ricordisamoa, JeroenDeDauw, thiemowmde, JanZerebecki, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T102629: Request Gerrit repository for WikibaseDataModelServices
Tobi_WMDE_SW closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T102629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, Tobi_WMDE_SW Cc: Bene, Lydia_Pintscher, Ricordisamoa, JeroenDeDauw, thiemowmde, JanZerebecki, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T45962: Special:ItemDisambiguation should include aliases in search, not just labels.
Tobi_WMDE_SW moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T45962 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Tobi_WMDE_SW Cc: gerritbot, Wikidata-bugs, matej_suchanek, Lucie, Lydia_Pintscher, daniel, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T103697: Add Phabricator project tag for Wikibase-DataModel-Services
Tobi_WMDE_SW closed blocking task T102629: Request Gerrit repository for WikibaseDataModelServices as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T103697 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc: Lydia_Pintscher, Tobi_WMDE_SW, thiemowmde, Aklapper, Wikidata-bugs, aude, Jdforrester-WMF, Krenair, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T96685: JS time widget: add option to let the backend choose the correct calendar
Tobi_WMDE_SW moved this task to Done on the Wikidata-Sprint-2015-06-30 workboard. TASK DETAIL https://phabricator.wikimedia.org/T96685 WORKBOARD https://phabricator.wikimedia.org/project/board/1337/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, Tobi_WMDE_SW Cc: gerritbot, Wikidata-Sprint-2015-05-05, thiemowmde, Tobi_WMDE_SW, Aklapper, aude, Lydia_Pintscher, daniel, Wikidata-bugs, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T74907: move git repositories that are dependencies of wikidata to gerrit
Tobi_WMDE_SW closed blocking task T102629: Request Gerrit repository for WikibaseDataModelServices as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T74907 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tobi_WMDE_SW Cc: Addshore, Liuxinyu970226, Ricordisamoa, chasemp, mmodell, Abraham, Aklapper, thiemowmde, Qgil, Snaterlicious, daniel, adrianheine, Tobi_WMDE_SW, GPHemsley, Legoktm, JeroenDeDauw, JanZerebecki, aude, MZMcBride, Lydia_Pintscher, Dereckson, hoo, Wikidata-bugs, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T103554: missing message wbqc-desc
soeren.oldag closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T103554 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: soeren.oldag Cc: Jim_Carter, JanZerebecki, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T102992: Review WikidataQuality DB schema
daniel edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T102992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: jcrespo, Tamslo, csteipp, Springle, hoo, Aklapper, daniel, Wikidata-bugs, aude, GWicke, Krenair, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T71345: Machine translation not applied to article title
Amire80 moved this task to CX6 on the MediaWiki-extensions-ContentTranslation workboard. TASK DETAIL https://phabricator.wikimedia.org/T71345 WORKBOARD https://phabricator.wikimedia.org/project/board/776/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Amire80 Cc: Wikidata, Amire80, Jsahleen, Arrbee, santhosh, dchan, wikibugs-l-list, Pginer-WMF, KartikMistry, Nikerabbit, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T102629: Request Gerrit repository for WikibaseDataModelServices
Tobi_WMDE_SW added a comment. Seems to be done, so closing this. https://gerrit.wikimedia.org/r/#/admin/projects/wikibase/data-model-services TASK DETAIL https://phabricator.wikimedia.org/T102629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, Tobi_WMDE_SW Cc: Bene, Lydia_Pintscher, Ricordisamoa, JeroenDeDauw, thiemowmde, JanZerebecki, Tobi_WMDE_SW, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T104364: Add MW_INSTALL_PATH hack back into WikibaseQualityConstraints maintenance scripts
hoo moved this task to WBQC Backlog on the Wikibase-Quality workboard. TASK DETAIL https://phabricator.wikimedia.org/T104364 WORKBOARD https://phabricator.wikimedia.org/project/board/989/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo Cc: hoo, Addshore, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
JanZerebecki closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, JanZerebecki Cc: Tobi_WMDE_SW, JanZerebecki, gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T72395: Displaying (and editing) the calendar model of time values is confusing
Rical added a subscriber: Rical. TASK DETAIL https://phabricator.wikimedia.org/T72395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rical Cc: Rical, daniel, Conny, Wikidata-bugs, JulesWinnfield-hu, Tobi_WMDE_SW, Denny, Snaterlicious, Jc3s5h, Lydia_Pintscher, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T104701: Create https://www.wikidata.org/wiki/Wikidata:Wiki_Loves_Open_Data project page (or equivalent)
Ricordisamoa added a subscriber: Ricordisamoa. TASK DETAIL https://phabricator.wikimedia.org/T104701 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil, Ricordisamoa Cc: Ricordisamoa, Aklapper, Qgil, SVentura, Lydia_Pintscher, Yair_rand, Sadads, Wittylama, Romaine, Smalyshev, Multichill, Susannaanas, Abraham, Scott_WUaS, I9606, Jane023, Hjfocs, Wikidata-bugs, aude, Gryllida, Rfarrand, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T101950: Goal: Establish a framework to engage with data engineers and open data organizations
Ricordisamoa added a subscriber: Ricordisamoa. TASK DETAIL https://phabricator.wikimedia.org/T101950 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil, Ricordisamoa Cc: Ricordisamoa, Hjfocs, Jane023, I9606, Scott_WUaS, Abraham, Susannaanas, Multichill, Smalyshev, Romaine, Wittylama, Sadads, Yair_rand, Lydia_Pintscher, SVentura, Qgil, Aklapper, Wikidata-bugs, aude, Gryllida, Rfarrand, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T97993: Install Graph extension on beta Wikidata
Glaisher moved this task to Done on the Wikimedia-Extension-setup workboard. TASK DETAIL https://phabricator.wikimedia.org/T97993 WORKBOARD https://phabricator.wikimedia.org/project/board/188/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, Glaisher Cc: Krenair, gerritbot, Raymond, hoo, JanZerebecki, aude, Aklapper, Lydia_Pintscher, Wikidata-bugs, tomasz, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
JanZerebecki added a comment. Maybe on the quality side the workaround needs to be partially removed? TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, JanZerebecki Cc: Tobi_WMDE_SW, JanZerebecki, gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
JanZerebecki added a project: Wikibase-Quality. TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, JanZerebecki Cc: Tobi_WMDE_SW, JanZerebecki, gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103815: enable quality extensions on www.wikidata.org
JanZerebecki added a comment. https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20150706T1130 TASK DETAIL https://phabricator.wikimedia.org/T103815 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: Wikibase-Quality, Aklapper, Lydia_Pintscher, Ricordisamoa, Reedy, hoo, greg, mmodell, Liuxinyu970226, Yair_rand, JanZerebecki, Tamslo, gerritbot, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs
hoo added a comment. In https://phabricator.wikimedia.org/T103626#1425094, @JanZerebecki wrote: Maybe on the quality side the workaround needs to be partially removed? I talked to Addshore about this on IRC on Tuesday, that lead to the creation of the other ticket. Keeping the workaround is fine, it doesn't hurt. TASK DETAIL https://phabricator.wikimedia.org/T103626 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, hoo Cc: Tobi_WMDE_SW, JanZerebecki, gerritbot, Addshore, Krinkle, Aklapper, hoo, Wikidata-bugs, aude, hashar, greg, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T104364: Add MW_INSTALL_PATH hack back into WikibaseQualityConstraints maintenance scripts
JanZerebecki closed blocking task T103626: MW_INSTALL_PATH incorrect for WikibaseQualityConstraints jenkins jobs as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T104364 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki Cc: hoo, Addshore, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T102992: Review WikidataQuality DB schema
daniel added a comment. A first review of the schema and queries: Queries run against wbqc_constraints seem to all use the (pid) index. What's the (constraint_type_qid) index for? Queries run against wbqev_external_data seem to all use the (dump_id, external_id, pid) index. Unless ExternalDataRepo-get is called with no dump id or no external id. In these cases, an exception should be thrown instead of creating extremely inefficient queries. Calling `$db-commit( __METHOD__, flush )` should not be done in DAO objects. Simmilarly, calling `wfWaitForSlaves` should be avoided in the DAO layer. These things should be kept on the level of updaters/importers. wbqev_identifier_properties should have an index on dump_id, so the query planner is free to choose which side of the join to evaluate first. It's also needed for the DELETE queries that select by dumpId. wbq_violations seems to be unused in v1, is that correct? The (claim_guid) index is redundant to the composite primary key (claim_guid, constraint_id). Prefixes of composite keys can be used like separate keys. The (constraint_id) index is thus not redundant. It seems very likely that wbq_violations needs more indexed. At one on (entity_id), for getting (or clearing) all violations for a given entity. Or is the plan to do this by prefix-matching on the claim_guid? wbq_evaluation does not define any indexes. That's bad, at least give it an auto-increment row id. But is it used at all? It seems like the eval data is going to a log file at the moment. TASK DETAIL https://phabricator.wikimedia.org/T102992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: jcrespo, Tamslo, csteipp, Springle, hoo, Aklapper, daniel, Wikidata-bugs, aude, GWicke, Krenair, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T104744: RDF produces wrong types for some properties
Smalyshev created this task. Smalyshev claimed this task. Smalyshev added a subscriber: Smalyshev. Smalyshev added a project: Wikidata-Query-Service. Herald added a subscriber: Aklapper. Herald added projects: Wikidata, Discovery. TASK DESCRIPTION For the property of type WikibaseItem, the data produced is: ``` wd:P22 a wikibase:Property ; wikibase:propertyType wikibase:WikibaseItem ; wikibase:directClaim wdt:P22 ; wikibase:claim p:P22 ; wikibase:statementProperty ps:P22 ; wikibase:statementValue psv:P22 ; wikibase:qualifier pq:P22 ; wikibase:qualifierValue pqv:P22 ; wikibase:reference pr:P22 ; wikibase:referenceValue prv:P22 ; wikibase:novalue wdno:P22 . p:P22 a owl:ObjectProperty . psv:P22 a owl:ObjectProperty . pqv:P22 a owl:ObjectProperty . prv:P22 a owl:ObjectProperty . wdt:P22 a owl:DatatypeProperty . ps:P22 a owl:DatatypeProperty . pq:P22 a owl:DatatypeProperty . pr:P22 a owl:DatatypeProperty . ``` However, the last four should be owl:ObjectProperty as wikibase item is an object, not literal. TASK DETAIL https://phabricator.wikimedia.org/T104744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev Cc: Aklapper, Smalyshev, jkroll, Wikidata-bugs, Jdouglas, aude, Manybubbles, JanZerebecki, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T104749: Support dates with unknown year but known month/day
Nikki created this task. Nikki added a subscriber: Nikki. Nikki added a project: Wikidata. Herald added a subscriber: Aklapper. TASK DESCRIPTION Sometimes people will give their birthday but not their year of birth. As far as I can tell, it's not possible to enter these (if it is, I haven't figured out how). For example, the date of birth of https://www.wikidata.org/wiki/Q11194654 is the 27th of August according to http://cleanero.com/profile.html but no year is given. Most of the pages in https://ja.wikipedia.org/wiki/Category:%E7%94%9F%E5%B9%B4%E9%9D%9E%E5%85%AC%E8%A1%A8 (birth year unknown) also only have the month and day. It seems that ISO 8601 supports these by using a hyphen to represent the unknown part, e.g. `--02-03` for the 3rd of February in an unknown year. TASK DETAIL https://phabricator.wikimedia.org/T104749 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Nikki Cc: Aklapper, Nikki, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98034: Mobile web page banner and Minerva skin issues
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 222693 had a related patch set uploaded (by Sumit): WikidataPageBanner fixes for skin Minerva https://gerrit.wikimedia.org/r/222693 TASK DETAIL https://phabricator.wikimedia.org/T98034 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Florian, Sumit, phuedx, kaldari, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Project Column] T94713: Beta: A user is able to see wikidata descriptions in mobile web search results (in order to learn better select from results)
gpaumier moved this task to Recently announced in Tech/News on the user-notice workboard. TASK DETAIL https://phabricator.wikimedia.org/T94713 WORKBOARD https://phabricator.wikimedia.org/project/board/1097/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bmansurov, gpaumier Cc: Moushira, greg, Jhernandez, phuedx, Jdlrobson, dr0ptp4kt, gerritbot, Lydia_Pintscher, Florian, JKatzWMF, Aklapper, Johan, Wikidata-bugs, aude, gpaumier, Jay8g, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98034: Mobile web page banner and Minerva skin issues
Florian added a comment. @Jdlrobson Sorry, that i haven't answered, i'm still in vacation :) You can hide the title with: $out-setPageTitle( '' ); That disables the html title tag, too, so after that, set it to the correct one: $out-setHTMLTitle( $out-getTitle() ); TASK DETAIL https://phabricator.wikimedia.org/T98034 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Florian Cc: gerritbot, Florian, Sumit, phuedx, kaldari, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T98034: Mobile web page banner and Minerva skin issues
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T98034 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Florian, Sumit, phuedx, kaldari, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98034: Mobile web page banner and Minerva skin issues
Jdlrobson added a comment. Apologies I didn't reply to your message. The banners in mobile are currently only present in the beta of the site accessible via Special:MobileOptions $out-setPageTitle( false) ; should remove the title from the page - you shouldn't need to use css TASK DETAIL https://phabricator.wikimedia.org/T98034 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: gerritbot, Florian, Sumit, phuedx, kaldari, Aklapper, Jdlrobson, Wikidata-bugs, aude, Lydia_Pintscher, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T101950: Goal: Establish a framework to engage with data engineers and open data organizations
Qgil edited the task description. TASK DETAIL https://phabricator.wikimedia.org/T101950 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil Cc: Hjfocs, Jane023, I9606, Scott_WUaS, Abraham, Susannaanas, Multichill, Smalyshev, Romaine, Wittylama, Sadads, Yair_rand, Lydia_Pintscher, SVentura, Qgil, Aklapper, Wikidata-bugs, aude, Gryllida, Rfarrand, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T103835: create new design and UX concept for input of complex datatypes
Snaterlicious added a comment. After some first evaluation, I still quite like the basic input concept offering as few input elements as possible and having the software make a best guess. This interface simplicity, however, has some implications. Those are, at least: - The software needs proper logic for making best guesses. - It is not obvious how some options may be set instantly, for example: uncertainty options like before and lower bound. The question is, per option, whether it can be regarded primary or secondary. The term advanced options currently in use, probably, is not the right expression. - The preview needs to be specific enough to make the user aware of additional adjustments (e.g. planetographic coordinates may probably need to display the globe unless there is some other concept that defines the globe, for example, per Property resulting in some Property like position on Venus). - Experienced users should be offered ways to enter information specific enough in order to circumvent false guesses (i.e. by entering something like 1 7 2015 Julian) in order to get around clicking through the secondary options. The concept is simple: Enter something, have the software present the guess (preview) and ask the user whether that is what the user expected. If it is not, the user may open detailed input components. This keeps the UI unobtrusive and accessible for new users. F188203: basicinputconcept.png https://phabricator.wikimedia.org/F188203 (Could also be something like Not what you expected? or Not what I expected? for a more personal address. Appending some phrase like Refine [date/amount/coordinates/...]. would emphasize the hint about additional input options even more.) Everyone of the existing data types can have one input box as its only primary input method, except, maybe, monolingual text. However, I wonder why the language of a monolingual text value should not be specified directly on the Property. Very likely, at least multilingual text and geographic shapes need some more sophisticated primary input, but the basic concept should remain the same. Keep it simple by not filling the page with input elements a user most likely does not need anyway. In my opinion, the actual issues are more on a per data type basis. Time data type is most prominent here as the UI for it is not as flexible as it should be and, even more, is missing options. As mentioned, advanced adjustments may change to something more communicative. Apart from that, I would propose creating tickets for the input concept of each individual data type and evaluate one by one about primary input, secondary input and how to integrate these aspects. TASK DETAIL https://phabricator.wikimedia.org/T103835 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Snaterlicious Cc: Snaterlicious, Aklapper, Lydia_Pintscher, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T73887: Other projects sidebar should show badges if applicable
Candalua added a subscriber: Candalua. TASK DETAIL https://phabricator.wikimedia.org/T73887 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tpt, Candalua Cc: Candalua, gerritbot, Wikidata-bugs, Bene, Andyrom75, Glaisher, Kky, Liuxinyu970226, Lydia_Pintscher, Stryn, Tpt, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T78286: Add Label/Description/Alias interfaces
Bene added a comment. Proposed patches: - https://github.com/wmde/WikibaseDataModel/pull/513 - https://github.com/wmde/WikibaseDataModel/pull/514 TASK DETAIL https://phabricator.wikimedia.org/T78286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: Aklapper, Lucie, Wikidata-bugs, aude, JeroenDeDauw, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T78286: Add Label/Description/Alias interfaces
Bene raised the priority of this task from Low to Normal. Bene claimed this task. Bene added projects: Wikidata-Sprint-2015-06-30, Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T78286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: Aklapper, Lucie, Wikidata-bugs, aude, JeroenDeDauw, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98290: Remove deprecated methods from Entity and subtypes
thiemowmde added a comment. Had a chat with @Bene. This is what's left in `Entity` and not deprecated: - `Entity::getFingerprint` already has an interface, FingerprintProvider. In 3.1, the method should be deprecated in Entity and un-deprecated in Item and Property (via duplicate implementations, similar to Item::setLabel and such). - `Entity::setFingerprint` needs investigation. The most flexible solution is to create a FingerprintHolder with a getter and a setter, similar to StatementListHolder, make Item and Property implement this interface and deprecate the methods in Entity. **But** do we really need setFingerprint? If getFingerprint is guaranteed to **not** return a copy, all manipulations can be done on the returned Fingerprint object and setFingerprint never needs to be called. What we need to do: - Check if all usages of setFingerprint (especially the ones in Deserializers) are optional and can be removed. - The guarantee that getFingerprint does **not** return a copy must be added to the methods documentation. - `Entity::isEmpty` should be deprecated and un-deprecated in Item and Property. - `Entity::clear` should be deprecated and later die. Just create a `new Item` if you need a new item. Repurposing existing entities is ugly. - `Entity::copy`. Not sure about this. It used a **lot**, more than 100 times, mostly in tests obviously but also in production. But it's very, very trivial and should be avoided anyway. Better create a new object. TASK DETAIL https://phabricator.wikimedia.org/T98290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, thiemowmde Cc: JanZerebecki, daniel, JeroenDeDauw, thiemowmde, Bene, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T104695: Deprecate Entity methods not in EntityDocument
Bene created this task. Bene claimed this task. Bene added subscribers: JanZerebecki, daniel, JeroenDeDauw, thiemowmde, Bene, Aklapper. Bene added projects: Wikibase-DataModel, Wikidata, Wikidata-Sprint-2015-06-30. TASK DESCRIPTION ! In T98290#1424169, @thiemowmde wrote: Had a chat with @Bene. This is what's left in `Entity` and not deprecated: * `Entity::getFingerprint` already has an interface, FingerprintProvider. In 3.1, the method should be deprecated in Entity and un-deprecated in Item and Property (via duplicate implementations, similar to Item::setLabel and such). * `Entity::setFingerprint` needs investigation. The most flexible solution is to create a FingerprintHolder with a getter and a setter, similar to StatementListHolder, make Item and Property implement this interface and deprecate the methods in Entity. **But** do we really need setFingerprint? If getFingerprint is guaranteed to **not** return a copy, all manipulations can be done on the returned Fingerprint object and setFingerprint never needs to be called. What we need to do: * Check if all usages of setFingerprint (especially the ones in Deserializers) are optional and can be removed. * The guarantee that getFingerprint does **not** return a copy must be added to the methods documentation. * `Entity::isEmpty` should be deprecated and un-deprecated in Item and Property. * `Entity::clear` should be deprecated and later die. Just create a `new Item` if you need a new item. Repurposing existing entities is ugly. * `Entity::copy`. Not sure about this. It used a **lot**, more than 100 times, mostly in tests obviously but also in production. But it's very, very trivial and should be avoided anyway. Better create a new object. TASK DETAIL https://phabricator.wikimedia.org/T104695 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: Aklapper, Bene, thiemowmde, JeroenDeDauw, daniel, JanZerebecki, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T87237: RFC: Possible redesign of the EntityTermsProvider interface
Bene removed a blocked task: T98290: Remove deprecated methods from Entity and subtypes. TASK DETAIL https://phabricator.wikimedia.org/T87237 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: Bene, Abraham, Snaterlicious, adrianheine, Lydia_Pintscher, JeroenDeDauw, Aklapper, thiemowmde, Wikidata-bugs, aude ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T98290: Remove deprecated methods from Entity and subtypes
Bene added a blocking task: T78286: Add Label/Description/Alias interfaces. TASK DETAIL https://phabricator.wikimedia.org/T98290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: JanZerebecki, daniel, JeroenDeDauw, thiemowmde, Bene, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T98290: Remove deprecated methods from Entity and subtypes
Bene removed a blocking task: T87237: RFC: Possible redesign of the EntityTermsProvider interface. TASK DETAIL https://phabricator.wikimedia.org/T98290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: JanZerebecki, daniel, JeroenDeDauw, thiemowmde, Bene, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T78286: Add Label/Description/Alias interfaces
Bene added a blocked task: T98290: Remove deprecated methods from Entity and subtypes. TASK DETAIL https://phabricator.wikimedia.org/T78286 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: Aklapper, Lucie, Wikidata-bugs, aude, JeroenDeDauw ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T104330: ParseValue API module should optionally trigger validation
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 222564 had a related patch set uploaded (by Addshore): Add ValueValidatorFactory Tests https://gerrit.wikimedia.org/r/222564 TASK DETAIL https://phabricator.wikimedia.org/T104330 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Tobi_WMDE_SW, WMDE-Fisch, Aklapper, thiemowmde, aude, daniel, Lydia_Pintscher, Jc3s5h, Wikidata-bugs, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T104330: ParseValue API module should optionally trigger validation
gerritbot added a comment. Change 222565 had a related patch set uploaded (by Addshore): Add optional validation to ParseValue api https://gerrit.wikimedia.org/r/222565 TASK DETAIL https://phabricator.wikimedia.org/T104330 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Tobi_WMDE_SW, WMDE-Fisch, Aklapper, thiemowmde, aude, daniel, Lydia_Pintscher, Jc3s5h, Wikidata-bugs, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T104330: ParseValue API module should optionally trigger validation
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T104330 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, Tobi_WMDE_SW, WMDE-Fisch, Aklapper, thiemowmde, aude, daniel, Lydia_Pintscher, Jc3s5h, Wikidata-bugs, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T98290: Remove deprecated methods from Entity and subtypes
daniel added a comment. In https://phabricator.wikimedia.org/T98290#1424169, @thiemowmde wrote: Had a chat with @Bene. This is what's left in `Entity` and not deprecated: - Check if all usages of setFingerprint (especially the ones in Deserializers) are optional and can be removed. - The guarantee that getFingerprint does **not** return a copy must be added to the methods documentation. Just don't use Fingerprint at all. However, the question whether to return a clone from the getter exists for all mutable classes. This will be the same when dealing with TermList objects. - `Entity::isEmpty` should be deprecated and un-deprecated in Item and Property. This should probably go into EntityDocument if it is needed. A generic method to check if an entity is empty seems sensible. It's also needed by EntityContent. - `Entity::clear` should be deprecated and later die. Just create a `new Item` if you need a new item. Repurposing existing entities is ugly. Agreed - `Entity::copy`. Not sure about this. It used a **lot**, more than 100 times, mostly in tests obviously but also in production. But it's very, very trivial and should be avoided anyway. Better create a new object. The implementation is nasty, but we do need a generic copying mechanism. Since EntityContent is mutable, it needs a deep clone mechanism. Creating a new object with the same content is exactly what is done here, the question is jut - how? TASK DETAIL https://phabricator.wikimedia.org/T98290 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene, daniel Cc: JanZerebecki, daniel, JeroenDeDauw, thiemowmde, Bene, Aklapper, Wikidata-bugs, aude, Malyacko, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
