date:20170609

Ladsgroup closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: WMDE-leszek, Lydia_Pintscher, gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158842: Update wording re associated Wikidata item following move

Ladsgroup added a comment.
The other one is merged too.TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: WMDE-leszek, Lydia_Pintscher, gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T152676: Simple tree query visualization

2017-06-09 Thread Quiddity

Quiddity added a comment.
@Jonas 3 things:


I tried running the example for "Tree" ("Continents, countries, regions and capitals") at https://query.wikidata.org/ but it gives "Unable to display result".



Also, this new feature needs to be documented at https://www.mediawiki.org/wiki/Wikidata_query_service/User_Manual#Default_views



Lastly, I'd suggest adding another "tree" example at the GUI, for the specific example given in the description here. That will probably be a simpler example, for non-technical people to adapt/reuse.



Specifically http://tools.wmflabs.org/wikidata-todo/tree.html?q=Q1785783=361=en=list=4
(I have this similar example bookmarked https://tools.wmflabs.org/wikidata-todo/tree.html?rp=279=list=8261 and I hope to be able to adapt that, based on the one above once it's converted. :-)


Thanks!TASK DETAILhttps://phabricator.wikimedia.org/T152676EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, QuiddityCc: Quiddity, gerritbot, nichtich, Upeksha1996, TerraCodes, Jonas, Micru, Aklapper, GoranSMilovanovic, Adik2382, Soteriaspace, harikiran, Th3d3v1ls, SacredWKnight, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, EBjune, merbst, Avner, Lewizho99, Puik, Maathavan, debt, Gehel, Abbe98, D3r1ck01, Envlh, FloNight, Xmlizer, MuhammadShuaib, Izno, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, jayvdb, TheDJ, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T167416: Import mandatory qualifiers constraints from statements

2017-06-09 Thread abian

abian added a comment.
These changes could be introduced by creating a new message (with a new name) and deleting the current one. The current message is named "wbqc-violation-message-mandatory-qualifiers" (plural), so the new one could be "wbqc-violation-message-mandatory-qualifier" (singular).TASK DETAILhttps://phabricator.wikimedia.org/T167416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, abianCc: Amire80, abian, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166379: Value type constraints show errors even when they shouldn't

2017-06-09 Thread Agabi10

Agabi10 added a comment.
OK @Lucas_Werkmeister_WMDE, so if that's intended I think it works as expected. Thanks.TASK DETAILhttps://phabricator.wikimedia.org/T166379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Agabi10Cc: gerritbot, Lydia_Pintscher, Jonas, Lucas_Werkmeister_WMDE, abian, Aklapper, Agabi10, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T167416: Import mandatory qualifiers constraints from statements

Lucas_Werkmeister_WMDE added a comment.
What will happen with the translations until they are updated? Does TranslateWiki throw them away automatically because the message changed too much? I don’t want to show broken messages to users because we’re passing the wrong parameters to old translations…TASK DETAILhttps://phabricator.wikimedia.org/T167416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Amire80, abian, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T167014: Write the tool uplift proposal

Hjfocs closed subtask T167021: Describe the tool workflow as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T167014EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Nemo_bis, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T167021: Describe the tool workflow

Hjfocs closed this task as "Resolved".Hjfocs added a subscriber: Kiailandi.Hjfocs added a comment.
Looks pretty good, thanks a lot for your valuable contributions, @Afnecors and @Kiailandi.
I'll integrate the document into the final proposal.
Just a comment: I'll replace the references to the mock-ups with image floats in the text for a more immediate description.TASK DETAILhttps://phabricator.wikimedia.org/T167021EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Afnecors, HjfocsCc: Kiailandi, Liuxinyu970226, TerraCodes, Jay8g, Aklapper, Hjfocs, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T167014: Write the tool uplift proposal

Hjfocs closed subtask T167015: Upload the full set of final mockups to phabricator as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T167014EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HjfocsCc: Nemo_bis, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T167015: Upload the full set of final mockups to phabricator

Hjfocs closed this task as "Resolved".Hjfocs added a comment.
Great job @Kiailandi and @Afnecors !
This is the first big step towards the radical uplift of the tool.
Thanks a lot for your work.TASK DETAILhttps://phabricator.wikimedia.org/T167015EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Kiailandi, HjfocsCc: Afnecors, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T166379: Value type constraints show errors even when they shouldn't

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T166379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lydia_Pintscher, Jonas, Lucas_Werkmeister_WMDE, abian, Aklapper, Agabi10, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166379: Value type constraints show errors even when they shouldn't

gerritbot added a comment.
Change 358055 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Inject use SparqlHelper in TypeCheckerHelper

https://gerrit.wikimedia.org/r/358055TASK DETAILhttps://phabricator.wikimedia.org/T166379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lydia_Pintscher, Jonas, Lucas_Werkmeister_WMDE, abian, Aklapper, Agabi10, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166379: Value type constraints show errors even when they shouldn't

Lucas_Werkmeister_WMDE added a comment.
@Agabi10 I think that’s working as intended – “instance of” and “subclass of” are different things and, in general, shouldn’t be used interchangeably. If some people think that “instance of” should be used and add a constraint to reflect that, and other people think that “subclass of” should be used and add statements with that property, then those people should get in touch and have a discussion about the discrepancy. If the constraint violations make such disagreements more obvious, and lead to more such discussions, that’s a good thing in my opinion :)

In the case of Q1616075, the constraint violation is certainly technically correct, and looking at P452 – “industry of company or organization”, “Wikidata property for items about organizations” – I would say that it’s also appropriate: the property seems intended only for individual organizations, not classes of them.TASK DETAILhttps://phabricator.wikimedia.org/T166379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, Jonas, Lucas_Werkmeister_WMDE, abian, Aklapper, Agabi10, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T167021: Describe the tool workflow

Hjfocs added a comment.
Draft available here: https://meta.wikimedia.org/wiki/User:Afnecors/PST_workflowTASK DETAILhttps://phabricator.wikimedia.org/T167021EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Afnecors, HjfocsCc: Liuxinyu970226, TerraCodes, Jay8g, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166379: Value type constraints show errors even when they shouldn't

2017-06-09 Thread Agabi10

Agabi10 added a comment.
@Lucas_Werkmeister_WMDE I think it is working now, but I think there may be a problem still in how the value type constraint is checked (or with my understanding of what a type is). It still displays an error when the entity instead of being an instance of a given entity is a subclass of a given entity, anyway, in this case I don't know if the problem is with the constraint itself or with my understanding, but for me if a cars are a subclass of vehicles they are still vehicles (as well as all the instances of the car class).

One example of this behavior is Q1616075, which from my understanding it shouldn't be triggering an error for the Type constraint due to being a subclass of a subclass of organization.

Anyway if it's just a problem of my understanding of what a type is feel free to close the task as resolved.TASK DETAILhttps://phabricator.wikimedia.org/T166379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Agabi10Cc: Lydia_Pintscher, Jonas, Lucas_Werkmeister_WMDE, abian, Aklapper, Agabi10, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T167521: Simplify access to properties that currently require traversing numerous items

2017-06-09 Thread Jarekt

Jarekt added a comment.
Discussion at Wikidata:Project_chat related to this issue.TASK DETAILhttps://phabricator.wikimedia.org/T167521EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JarektCc: Aklapper, Jarekt, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Created] T167521: Simplify access to properties that currently require traversing numerous items

2017-06-09 Thread Jarekt

Jarekt created this task.Jarekt added projects: MediaWiki-extensions-WikibaseClient, Wikidata.Herald added a subscriber: Aklapper.
TASK DESCRIPTIONMany properties related to an item are stored in other items and are presently very hard to access by templates using wikidata. For example:

taxon items have property parent taxon (P171). If I have an infobox that shows genus, family or order of a given organism I need a way to move up a chain of P171s until some rank is met.
people items have property place of death (P20) that stores most exact item related to place of death, which could be a house, street, hospital, neighborhood, etc. If I have an infobox that shows place of death of a person I usually need city or town where someone died. A query to look up a city of death of Pyotr Tchaikovsky is SELECT DISTINCT ?city { ?city ^(wdt:P20/wdt:P131*) wd:Q7315; wdt:P31/wdt:P279* wd:Q515 . }. It is very hard to access that information using Lua calls. Similar issue would be for "Country of birth" or "Country of death"

I do not have a specific proposal of how to allow access to such properties. However here are 2 ideas:

Create infrastructure to allow read-only properties which are not directly editable but precomputed based on some SPARQL query and other properties and items. Users would see and access them in a way similar to current properties. (Inverse properties like P910/P301 can be implemented using this mechanism in the future, where one of the properties would be "read-only")
Allow Lua to do SPARQL queries. This could be expensive
Other ideas?

Alternative which is happening as we speak, is to write big ugly Lua codes that are hardwired queries in disguise. They need to load multiple items to show a simple info.TASK DETAILhttps://phabricator.wikimedia.org/T167521EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JarektCc: Aklapper, Jarekt, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Retitled] T162594: Introduce MessageLocalizer interface to remove the need to depend on IContextSource for creating Message objects

2017-06-09 Thread daniel

daniel renamed this task from "Introduce MessageLocalizer interface to remove dependency on IContextSource in DiffView and friends." to "Introduce MessageLocalizer interface to remove the need to depend on IContextSource for creating Message objects".daniel updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTIONDiffView and BasicEntityDiffVisualizer rely on IContextSource for fetching system messages. IContextSource is a terrible kitchen sink, it drag in a whole bunch of dependencies that we don't need. Also, a IContextSource is hard to come by in some contexts.

I propose to introduce a MessageLocalizer interface (along with a MediaWikiMessageLocalizer implementation) that exposes a msg() methodCode that needs to construct Message objects from message keys currently tends to rely on IContextSource::msg, just like the one exposed by IContextSourceor the global function wfMsg(). Or we define getWikitext and getHtml methods that return strings.To avoid reliance on global state, That would be a bit nicer (no Message object mess)and dragging in the kitchen sink that is IContextSource, but a bit more worka narrow interface called MessageLocalizer should be introduced, and we'll need to think abouexposing just the semantics of parameter escapingmsg() function from IContextSource. Also,The IContextSource interface can then extend MessageLocalizer. an interface exposing aCalling code that only needs the msg() method just like IContextSource could be moved to MW corecan then start using MessageLocalizer instead of IContextSource, to replace usages of IContextSource therewithout further refactoring being required.

WikibaseRepo (and perhaps WikibaseClient) would supply two instances, one for the user language, and one for the content language. DiffView and friends would use the user language. This allows testing and re-use of such components without the need to construct or get an IContextSource from global state.
TASK DETAILhttps://phabricator.wikimedia.org/T162594EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, danielCc: Nemo_bis, Agabi10, gerritbot, Ladsgroup, Aklapper, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, MuhammadShuaib, Izno, LNDDYL, Psychoslave, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, KartikMistry, Mbch331, Jay8g___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T144272: new monolingual language code requests for Wikidata (tracking)

2017-06-09 Thread Nikki

Nikki added a comment.

In T144272#3322282, @Amire80 wrote:
I have a general question here: Are these languages codes provided in WikibaseRepo.php in addition to anything?

I mean, where does the basic list come from? Core Names.php? ULS's langdb? A wikidata.org query? A defined subset of CLDR? Something else?


I may have misunderstood something and things might have changed since I last looked into it, but from what I previously managed to piece together, the list available for monolingual text consists of:


All the usual MediaWiki languages from https://phabricator.wikimedia.org/source/mediawiki/browse/master/languages/data/Names.php
All the languages in wmgExtraLanguageNames from https://phabricator.wikimedia.org/source/mediawiki-config/browse/HEAD/wmf-config/InitialiseSettings.php;eba0993c096fc01374ea439bffcf875a5d6f74ac$16323 (these are additional languages which can be used both for labels and for monolingual text)
All the languages in the first array in getMonolingualTextLanguages from https://phabricator.wikimedia.org/diffusion/EWBA/browse/HEAD/repo/includes/WikibaseRepo.php;da65ffa15b2d8412a1bdf1a9d56c41ea4de69733$1670 (these are additional languages which can only be used for monolingual text)


excluding the languages in the second array in getMonolingualTextLanguages.TASK DETAILhttps://phabricator.wikimedia.org/T144272EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: NikkiCc: Nikki, Amire80, jhsoby, Liuxinyu970226, GerardM, thiemowmde, Aklapper, Esc3300, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166379: Value type constraints show errors even when they shouldn't

Lucas_Werkmeister_WMDE added a comment.
I think the new limit has been deployed (I see type checking spikes of 4 s and 7½ s in the last 12 h on Grafana), can you try it out? (Perhaps unswap the classes if you don’t have any other item where the test previously failed?)

@abian that would be possible, but I don’t want to add too many optimizations like that because eventually we would just be building a shittier, slower BlazeGraph :) the SPARQL change has already been merged, so for now I’d rather focus on integrating that into the regular “type” and “value type” checkers so that false negatives like these should no longer occur.TASK DETAILhttps://phabricator.wikimedia.org/T166379EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lydia_Pintscher, Jonas, Lucas_Werkmeister_WMDE, abian, Aklapper, Agabi10, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T166511: Dataset selection mockup (Primary Sources configuration)

2017-06-09 Thread Afnecors

Afnecors closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T166511EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AfnecorsCc: Lydia_Pintscher, Aklapper, Wikidata-primary-sources, Kiailandi, dachary, Hjfocs, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T158842: Update wording re associated Wikidata item following move

WMDE-leszek moved this task from Review to Done on the Wikidata-Sprint board.WMDE-leszek added a comment.
Thanks!
See also https://gerrit.wikimedia.org/r/358038 for the similar message.TASK DETAILhttps://phabricator.wikimedia.org/T158842WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, WMDE-leszekCc: WMDE-leszek, Lydia_Pintscher, gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158842: Update wording re associated Wikidata item following move

gerritbot added a comment.
Change 357979 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Reword move message in clients to reflect the new functionality

https://gerrit.wikimedia.org/r/357979TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, gerritbotCc: Lydia_Pintscher, gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158842: Update wording re associated Wikidata item following move

2017-06-09 Thread Billinghurst

Billinghurst added a comment.
:-)TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, BillinghurstCc: Lydia_Pintscher, gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T146705: Support rollout of editing wikidata descriptions on Android

2017-06-09 Thread Tbayer

Tbayer added a comment.
@Fjalapeno There is an existing thread about this (which also includes @Dbrant and @JKatzWMF), will loop you in.TASK DETAILhttps://phabricator.wikimedia.org/T146705EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Elitre, TbayerCc: Fjalapeno, Tbayer, Trizek-WMF, Elitre, Qgil, Moushira, Dbrant, JKatzWMF, Aklapper, GoranSMilovanovic, nickisverygood, Ivana_Isadora, QZanden, Designsbydavesconcepts, Serumulapiet, Jseddon, donaldepig, FloNight, Izno, Wikidata-bugs, aude, Mbch331, Keegan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T167025: Install and play with Wikibase

2017-06-09 Thread Afnecors

Afnecors added a comment.
Running

vagrant roles enable wikidata
vagrant provision

I raise T146443TASK DETAILhttps://phabricator.wikimedia.org/T167025EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AfnecorsCc: Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?

Ladsgroup added a comment.
@daniel: Done. I overlooked it (it's big but still...)TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Closed] T166512: Data filtering mockup

2017-06-09 Thread Kiailandi

Kiailandi closed this task as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T166512EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: KiailandiCc: Wikidata-primary-sources, Aklapper, Kiailandi, dachary, Hjfocs, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T146705: Support rollout of editing wikidata descriptions on Android

2017-06-09 Thread Fjalapeno

Fjalapeno added a project: Reading Epics (Wikidata Description Editing).
TASK DETAILhttps://phabricator.wikimedia.org/T146705EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Elitre, FjalapenoCc: Fjalapeno, Tbayer, Trizek-WMF, Elitre, Qgil, Moushira, Dbrant, JKatzWMF, Aklapper, GoranSMilovanovic, nickisverygood, Ivana_Isadora, QZanden, Designsbydavesconcepts, Serumulapiet, Jseddon, donaldepig, FloNight, Izno, Wikidata-bugs, aude, Mbch331, Keegan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T146705: Support rollout of editing wikidata descriptions on Android

2017-06-09 Thread Fjalapeno

Fjalapeno added a comment.
@Elitre Hey I wanted to check in and see if we were good from your end to do the Tier 3 rollout. Anything you need first?TASK DETAILhttps://phabricator.wikimedia.org/T146705EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Elitre, FjalapenoCc: Fjalapeno, Tbayer, Trizek-WMF, Elitre, Qgil, Moushira, Dbrant, JKatzWMF, Aklapper, GoranSMilovanovic, nickisverygood, Ivana_Isadora, QZanden, Designsbydavesconcepts, Serumulapiet, Jseddon, donaldepig, FloNight, Izno, Wikidata-bugs, aude, Mbch331, Keegan___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?

2017-06-09 Thread daniel

daniel added a subscriber: Ladsgroup.daniel added a comment.
@Ladsgroup please note the NOTE sectionTASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Ladsgroup, gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T166513: [Story] Investigate the Wikibase Client MediaWiki extension

2017-06-09 Thread Afnecors

Afnecors added a comment.
Trying vagrant roles: wikidata and wikibase_role (MediaWiki-Vagrant/Roles).TASK DETAILhttps://phabricator.wikimedia.org/T166513EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AfnecorsCc: Wikidata-primary-sources, Aklapper, Hjfocs, Kiailandi, dachary, Wikidata-bugs, Ricordisamoa, Sjoerddebruin, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158842: Update wording re associated Wikidata item following move

Ladsgroup added a comment.
@Lydia_Pintscher DoneTASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Lydia_Pintscher, gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158842: Update wording re associated Wikidata item following move

2017-06-09 Thread Lydia_Pintscher

Lydia_Pintscher added a comment.
There is a small issue with the sentence in the patch as it is now. You don't update a move. Confirm also sounds a bit like it is expecting a yes/no answer. It should also be 2 sentences I believe.
How about this instead: Your move should now be reflected in the Wikidata item language link. We ask that you check this has occurred.TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lydia_PintscherCc: Lydia_Pintscher, gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T167416: Import mandatory qualifiers constraints from statements

2017-06-09 Thread abian

abian added a comment.

In T167416#3334855, @Lucas_Werkmeister_WMDE wrote:
Only 16 constraints on Wikidata actually do that, so in my opinion it’s okay to drop support for this even while we still support constraint templates for a short time (we’ll just quietly ignore the extra properties in a template instead of raising an exception),


+1. In fact, if statements are better supported than templates, the community will definitely stop using these templates, and that's a good thing. 

I see three options:


Keep the message exactly as it is, and always supply $2 = 1, $3 = one-element list, $4 = the single required qualifier.
Change the message to “This $1 statement is missing a qualifier $4.”, and document $2 and $3 as dummy/placeholder parameters. For compatibility with old messages, still supply $2 = 1 and $3 = one-element list.
Change the message to “This $1 statement is missing a qualifier $2.”

I’m not sure what the best option is… perhaps @Amire80 or @abian can comment?


I like the 3 because it leaves the simplest code and documentation. I see no reason to preserve compatibility with the current message.TASK DETAILhttps://phabricator.wikimedia.org/T167416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, abianCc: Amire80, abian, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T167432: Run Wikibase daily browser tests on Jenkins

2017-06-09 Thread zeljkofilipin

zeljkofilipin added a comment.
I have talked with @hashar about this. I can take this task as soon as I have finished a few that I am already working on.TASK DETAILhttps://phabricator.wikimedia.org/T167432EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Tobi_WMDE_SW, Jonas, thiemowmde, WMDE-leszek, zeljkofilipin, hashar, Aleksey_WMDE, Aklapper, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T167432: Run Wikibase daily browser tests on Jenkins

2017-06-09 Thread zeljkofilipin

zeljkofilipin added projects: User-zeljkofilipin, Release-Engineering-Team.
TASK DETAILhttps://phabricator.wikimedia.org/T167432EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: Tobi_WMDE_SW, Jonas, thiemowmde, WMDE-leszek, zeljkofilipin, hashar, Aleksey_WMDE, Aklapper, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T85388: rank icon is not grayed out when clicked

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T85388EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, thiemowmde, higimo, adrianheine, Snaterlicious, Aklapper, Lydia_Pintscher, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T85388: rank icon is not grayed out when clicked

Ladsgroup claimed this task.Ladsgroup added a project: Wikidata-Sprint.Herald added a project: User-Ladsgroup.
TASK DETAILhttps://phabricator.wikimedia.org/T85388EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, thiemowmde, higimo, adrianheine, Snaterlicious, Aklapper, Lydia_Pintscher, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T85388: rank icon is not grayed out when clicked

gerritbot added a comment.
Change 357990 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Grey out RankSelector when the state is active

https://gerrit.wikimedia.org/r/357990TASK DETAILhttps://phabricator.wikimedia.org/T85388EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, thiemowmde, higimo, adrianheine, Snaterlicious, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T119536: [RFC] should wikidata.org/entity/Q12345 do content negotiation, instead of redirecting to wikidata.org/wiki/Special:EntityData/Q36661 first?

gerritbot added a comment.
Change 357985 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[operations/puppet@production] Make /entity/ redirect internal

https://gerrit.wikimedia.org/r/357985TASK DETAILhttps://phabricator.wikimedia.org/T119536EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Esc3300, thiemowmde, hoo, elf-pavlik, JanZerebecki, Aklapper, StudiesWorld, daniel, GoranSMilovanovic, QZanden, Izno, Luke081515, Wikidata-bugs, aude, fbstj, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T158842: Update wording re associated Wikidata item following move

Ladsgroup claimed this task.Ladsgroup added a project: Wikidata-Sprint.Herald added a project: User-Ladsgroup.
TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T158842: Update wording re associated Wikidata item following move

gerritbot added a project: Patch-For-Review.
TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T158842: Update wording re associated Wikidata item following move

gerritbot added a comment.
Change 357979 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] Reword move message in clients to reflect the new functionality

https://gerrit.wikimedia.org/r/357979TASK DETAILhttps://phabricator.wikimedia.org/T158842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, TerraCodes, hoo, Aklapper, Billinghurst, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, aude, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T165578: [Story] New datatype for referencing Lexemes

WMDE-leszek added a comment.
Overall does not seem that horrible, thanks @Ladsgroup

LegacyIdInterpreter is hardcoded to Property and Item. This needs to be changed (I added lexeme to that file in my localhost)

I believe the way out here is to stop using this class and used EntityIdComposer instead. How exactly do all this, it is another story.

Lots of frontend hacks had to be pushed to Wikibase, I don't know how to make frontend code injectable.

the patch itself seems small but I expect that making those few places in the frontend code generic, or making it possible to use something Lexeme-specific in the UI in a way it all fits together will be loads of work or fun.TASK DETAILhttps://phabricator.wikimedia.org/T165578EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, WMDE-leszekCc: WMDE-leszek, gerritbot, Aklapper, Lydia_Pintscher, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T165578: [Story] New datatype for referencing Lexemes

2017-06-09 Thread Lydia_Pintscher

Lydia_Pintscher added a comment.

In T165578#3332036, @Ladsgroup wrote:
Okay, I was able to add lexeme as value after tons of horrible hacks which I explain below. First, take a look:


It's beautiful! :DTASK DETAILhttps://phabricator.wikimedia.org/T165578EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Lydia_PintscherCc: gerritbot, Aklapper, Lydia_Pintscher, Cinemantique, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Darkdadaah, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Subscribers] T167416: Import mandatory qualifiers constraints from statements

Lucas_Werkmeister_WMDE added subscribers: abian, Amire80.Lucas_Werkmeister_WMDE added a comment.
Hm, there is one problem: in constraint statements, you should only specify a single property in one “mandatory qualifier” constraint (source), while in templates it’s allowed to specify multiple properties. Only 16 constraints on Wikidata actually do that, so in my opinion it’s okay to drop support for this even while we still support constraint templates for a short time (we’ll just quietly ignore the extra properties in a template instead of raising an exception), but this means that the current message is no longer appropriate.

Here’s the current message for “mandatory qualifiers”:

This $1 statement is missing {{PLURAL:$2|1=a qualifier $4.|2=$4 and $5 qualifiers.|the following qualifiers:$3}}

with the following explanation:

Message for a violation of the “Mandatory qualifiers” constraint, when one or more mandatory qualifiers are missing on a statement. Parameters:


$1 is the property of the statement.
$2 is the number of missing qualifiers.
$3 is an HTML list of all missing qualifiers.
$4, $5 etc. are the individual missing qualifiers.


I see three options:


Keep the message exactly as it is, and always supply $2 = 1, $3 = one-element list, $4 = the single required qualifier.
Change the message to “This $1 statement is missing a qualifier $4.”, and document $2 and $3 as dummy/placeholder parameters. For compatibility with old messages, still supply $2 = 1 and $3 = one-element list.
Change the message to “This $1 statement is missing a qualifier $2.”


I’m not sure what the best option is… perhaps @Amire80 or @abian can comment?TASK DETAILhttps://phabricator.wikimedia.org/T167416EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Amire80, abian, Lucas_Werkmeister_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T167436: [Task] Use Wikibase CodeSniffer standard in all Wikibase code repositories

Ladsgroup updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...* [ ] #wikibase-datamodel-serialization
* [ * [x] #wikibase-datamodel-services https://github.com/wmde/WikibaseDataModelServices/pull/179 and https://github.com/wmde/WikibaseDataModelServices/pull/180...TASK DETAILhttps://phabricator.wikimedia.org/T167436EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmde, LadsgroupCc: Ladsgroup, Aklapper, TerraCodes, aude, hoo, Aleksey_WMDE, Lydia_Pintscher, thiemowmde, GoranSMilovanovic, Adik2382, Soteriaspace, Th3d3v1ls, JakeTheDeveloper, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Abbe98, MuhammadShuaib, Izno, Wikidata-bugs, TheDJ, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Changed Project Column] T167432: Run Wikibase daily browser tests on Jenkins

WMDE-leszek moved this task from Proposed to Monitoring on the Wikidata-Sprint board.WMDE-leszek added a subscriber: Tobi_WMDE_SW.WMDE-leszek added a comment.
I didn't know what tags should I add, so can you help me with that?

I've added some tags I think are relevant here. I guess this could be also tagged with #release-engineering-team but I'll let RelEng folks do it if they think it makes sense.TASK DETAILhttps://phabricator.wikimedia.org/T167432WORKBOARDhttps://phabricator.wikimedia.org/project/board/2351/EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: Tobi_WMDE_SW, Jonas, thiemowmde, WMDE-leszek, zeljkofilipin, hashar, Aleksey_WMDE, Aklapper, GoranSMilovanovic, QZanden, Izno, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, greg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Triaged] T167432: Run Wikibase daily browser tests on Jenkins