[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a comment. Change 246192 merged by jenkins-bot: Rework standalone PageImagesDataUpdate into a ParserOutputDataUpdate https://gerrit.wikimedia.org/r/246192 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a comment. Change 246192 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Rework standalone PageImagesDataUpdate into a ParserOutputDataUpdate https://gerrit.wikimedia.org/r/246192 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a comment. Change 244165 merged by jenkins-bot: Add GeoData and PageImages configuration for Wikibase repo wikis https://gerrit.wikimedia.org/r/244165 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a comment. Change 243673 merged by jenkins-bot: Introduce PageImagesDataUpdate for PageImages extension https://gerrit.wikimedia.org/r/243673 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
Bene added a comment. Sounds good to me TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, Bene Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a comment. Change 244175 merged by jenkins-bot: Add basic PHPUnit tests https://gerrit.wikimedia.org/r/244175 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
thiemowmde added a comment. - @Lydia_Pintscher's (product manager) decision: For now we will not support the `wgPageImagesBlacklist` setting. We will most probably never need it for our algorithm, which is not based on parsing wikitext but on ranked statements. - We are introducing a new Wikibase specific `pageImagesPropertyIds` setting in https://gerrit.wikimedia.org/r/243673 and https://gerrit.wikimedia.org/r/244165. - We do not need an additional boolean setting. Instead, `pageImagesPropertyIds` is empty by default. To enable the feature, add a list of image property ids. - We do not need to support the `wgPageImagesNamespaces` setting. Instead, when `pageImagesPropertyIds` is set the feature is enabled on all entity namespaces that support statements. TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a comment. Change 244165 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Add pageImagesPropertyIds configuration for Wikibase servers https://gerrit.wikimedia.org/r/244165 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a comment. Change 244175 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Add basic PHPUnit tests https://gerrit.wikimedia.org/r/244175 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a comment. Change 243673 had a related patch set uploaded (by Thiemo Mättig (WMDE)): Introduce PageImagesDataUpdate for PageImages extension https://gerrit.wikimedia.org/r/243673 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde, gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
gerritbot added a subscriber: gerritbot. gerritbot added a comment. Change 243673 had a related patch set uploaded (by Thiemo Mättig (WMDE)): [WIP] Introduce PageImagesHookHandler for PageImages extension https://gerrit.wikimedia.org/r/243673 TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
thiemowmde added a comment. All the extension does (besides the "pageimages" API module) is appending a page property called "page_image" for each page id to the `page_props` table, containing the pure file name without the namespace. (And it does that in a way that's not really applicable for our code base, by accessing `LinksUpdate::$mProperties`.) That's all. That's so simple, the only reason to bind to the https://phabricator.wikimedia.org/tag/pageimages/ extension is literally the constant `PageImages::PROP_NAME` with the "page_image" string. As far as I can see, not even major refactoring of the PageImages class would make it possible to reuse existing code. I suggest to not bind against the PageImages extension but simply ... well, rely on `class_exists( 'PageImages' )`? To do: - What about the `wgPageImagesNamespaces` setting? Problem is, the PageImages extension should not work on Wikibase namespaces. But at the same time it would be confusing to have two separate settings for the same thing. - What about the `wgPageImagesBlacklist`? Our code should respect this. TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: gerritbot, thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
Bene added a comment. These properties should be stored in a config variable in that order I supppose? TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bene Cc: thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T112865: [Story] Add Wikibase support for PageImages
thiemowmde added a comment. Obviously, yes, very similar to `wgPropertySuggesterClassifyingPropertyIds` being an array of property ids (but I will obviously avoid numeric ids). TASK DETAIL https://phabricator.wikimedia.org/T112865 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Lydia_Pintscher, Bene, aude, Aklapper, Wikidata-bugs ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
